diff options
author | Marek Vasut <marex@denx.de> | 2014-04-24 14:05:20 -0400 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-05-08 09:58:10 -0400 |
commit | e22cdcfa13d9799ea46245946ae09b4a328ff27d (patch) | |
tree | da2fad6781a9c741c55230d2cfd732130001d928 | |
parent | 4f0fa52a5d89d763423cb9b428e988ea824fd95a (diff) |
crypto: caam - Kill SPRINTFCAT() with fire
This macro is just like an encyclopedia of string handling done wrong.
This must die. This is so wrong on so many levels.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Horia Geanta <horia.geanta@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r-- | drivers/crypto/caam/error.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c index 66a7461cf9ae..7ed2e4fb3c15 100644 --- a/drivers/crypto/caam/error.c +++ b/drivers/crypto/caam/error.c | |||
@@ -158,16 +158,6 @@ static const char * const rng_err_id_list[] = { | |||
158 | "Secure key generation", | 158 | "Secure key generation", |
159 | }; | 159 | }; |
160 | 160 | ||
161 | #define SPRINTFCAT(str, format, param, max_alloc) \ | ||
162 | { \ | ||
163 | char *tmp; \ | ||
164 | \ | ||
165 | tmp = kmalloc(sizeof(format) + max_alloc, GFP_ATOMIC); \ | ||
166 | sprintf(tmp, format, param); \ | ||
167 | strcat(str, tmp); \ | ||
168 | kfree(tmp); \ | ||
169 | } | ||
170 | |||
171 | static void report_ccb_status(struct device *jrdev, u32 status, | 161 | static void report_ccb_status(struct device *jrdev, u32 status, |
172 | const char *error, char *__outstr) | 162 | const char *error, char *__outstr) |
173 | { | 163 | { |