diff options
| author | H. Peter Anvin <hpa@linux.intel.com> | 2014-05-01 17:12:23 -0400 |
|---|---|---|
| committer | H. Peter Anvin <hpa@linux.intel.com> | 2014-05-01 17:16:15 -0400 |
| commit | e1fe9ed8d2a4937510d0d60e20705035c2609aea (patch) | |
| tree | d749d9eea67112d91ee90a617d3aba009014e40f | |
| parent | 246f2d2ee1d715e1077fc47d61c394569c8ee692 (diff) | |
x86, espfix: Move espfix definitions into a separate header file
Sparse warns that the percpu variables aren't declared before they are
defined. Rather than hacking around it, move espfix definitions into
a proper header file.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
| -rw-r--r-- | arch/x86/include/asm/espfix.h | 16 | ||||
| -rw-r--r-- | arch/x86/include/asm/setup.h | 5 | ||||
| -rw-r--r-- | arch/x86/kernel/espfix_64.c | 1 |
3 files changed, 19 insertions, 3 deletions
diff --git a/arch/x86/include/asm/espfix.h b/arch/x86/include/asm/espfix.h new file mode 100644 index 000000000000..729051c82b02 --- /dev/null +++ b/arch/x86/include/asm/espfix.h | |||
| @@ -0,0 +1,16 @@ | |||
| 1 | #ifdef _ASM_X86_ESPFIX_H | ||
| 2 | #define _ASM_X86_ESPFIX_H | ||
| 3 | |||
| 4 | #ifdef CONFIG_X86_64 | ||
| 5 | |||
| 6 | #include <asm/percpu.h> | ||
| 7 | |||
| 8 | DECLARE_PER_CPU_READ_MOSTLY(unsigned long, espfix_stack); | ||
| 9 | DECLARE_PER_CPU_READ_MOSTLY(unsigned long, espfix_waddr); | ||
| 10 | |||
| 11 | extern void init_espfix_bsp(void); | ||
| 12 | extern void init_espfix_ap(void); | ||
| 13 | |||
| 14 | #endif /* CONFIG_X86_64 */ | ||
| 15 | |||
| 16 | #endif /* _ASM_X86_ESPFIX_H */ | ||
diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm/setup.h index 9e3be3329a7e..ff4e7b236e21 100644 --- a/arch/x86/include/asm/setup.h +++ b/arch/x86/include/asm/setup.h | |||
| @@ -57,11 +57,10 @@ extern void x86_ce4100_early_setup(void); | |||
| 57 | static inline void x86_ce4100_early_setup(void) { } | 57 | static inline void x86_ce4100_early_setup(void) { } |
| 58 | #endif | 58 | #endif |
| 59 | 59 | ||
| 60 | extern void init_espfix_bsp(void); | ||
| 61 | extern void init_espfix_ap(void); | ||
| 62 | |||
| 63 | #ifndef _SETUP | 60 | #ifndef _SETUP |
| 64 | 61 | ||
| 62 | #include <asm/espfix.h> | ||
| 63 | |||
| 65 | /* | 64 | /* |
| 66 | * This is set up by the setup-routine at boot-time | 65 | * This is set up by the setup-routine at boot-time |
| 67 | */ | 66 | */ |
diff --git a/arch/x86/kernel/espfix_64.c b/arch/x86/kernel/espfix_64.c index 8a64da36310f..6afbb16e9b79 100644 --- a/arch/x86/kernel/espfix_64.c +++ b/arch/x86/kernel/espfix_64.c | |||
| @@ -40,6 +40,7 @@ | |||
| 40 | #include <asm/pgtable.h> | 40 | #include <asm/pgtable.h> |
| 41 | #include <asm/pgalloc.h> | 41 | #include <asm/pgalloc.h> |
| 42 | #include <asm/setup.h> | 42 | #include <asm/setup.h> |
| 43 | #include <asm/espfix.h> | ||
| 43 | 44 | ||
| 44 | /* | 45 | /* |
| 45 | * Note: we only need 6*8 = 48 bytes for the espfix stack, but round | 46 | * Note: we only need 6*8 = 48 bytes for the espfix stack, but round |
