aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWen Congyang <wency@cn.fujitsu.com>2013-02-22 19:33:31 -0500
committerLinus Torvalds <torvalds@linux-foundation.org>2013-02-23 20:50:13 -0500
commite13fe8695c57fed678877a9f3f8e99fc637ff4fb (patch)
tree2e5cc485c71054cec7a09920db376443e621eca2
parent76bba1423f6313ccf7bd7cd400f1f2049bbc740a (diff)
cpu-hotplug,memory-hotplug: clear cpu_to_node() when offlining the node
When the node is offlined, there is no memory/cpu on the node. If a sleep task runs on a cpu of this node, it will be migrated to the cpu on the other node. So we can clear cpu-to-node mapping. [akpm@linux-foundation.org: numa_clear_node() and numa_set_node() can no longer be __cpuinit] Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Cc: David Rientjes <rientjes@google.com> Cc: Jiang Liu <liuj97@gmail.com> Cc: Minchan Kim <minchan.kim@gmail.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Mel Gorman <mel@csn.ul.ie> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Peter Zijlstra <peterz@infradead.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--arch/x86/include/asm/numa.h4
-rw-r--r--arch/x86/mm/numa.c4
-rw-r--r--mm/memory_hotplug.c30
3 files changed, 33 insertions, 5 deletions
diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h
index 52560a2038e1..1b99ee5c9f00 100644
--- a/arch/x86/include/asm/numa.h
+++ b/arch/x86/include/asm/numa.h
@@ -57,8 +57,8 @@ static inline int numa_cpu_node(int cpu)
57#endif 57#endif
58 58
59#ifdef CONFIG_NUMA 59#ifdef CONFIG_NUMA
60extern void __cpuinit numa_set_node(int cpu, int node); 60extern void numa_set_node(int cpu, int node);
61extern void __cpuinit numa_clear_node(int cpu); 61extern void numa_clear_node(int cpu);
62extern void __init init_cpu_to_node(void); 62extern void __init init_cpu_to_node(void);
63extern void __cpuinit numa_add_cpu(int cpu); 63extern void __cpuinit numa_add_cpu(int cpu);
64extern void __cpuinit numa_remove_cpu(int cpu); 64extern void __cpuinit numa_remove_cpu(int cpu);
diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
index f22680bf69ec..a713d081b59c 100644
--- a/arch/x86/mm/numa.c
+++ b/arch/x86/mm/numa.c
@@ -78,7 +78,7 @@ EXPORT_SYMBOL(node_to_cpumask_map);
78DEFINE_EARLY_PER_CPU(int, x86_cpu_to_node_map, NUMA_NO_NODE); 78DEFINE_EARLY_PER_CPU(int, x86_cpu_to_node_map, NUMA_NO_NODE);
79EXPORT_EARLY_PER_CPU_SYMBOL(x86_cpu_to_node_map); 79EXPORT_EARLY_PER_CPU_SYMBOL(x86_cpu_to_node_map);
80 80
81void __cpuinit numa_set_node(int cpu, int node) 81void numa_set_node(int cpu, int node)
82{ 82{
83 int *cpu_to_node_map = early_per_cpu_ptr(x86_cpu_to_node_map); 83 int *cpu_to_node_map = early_per_cpu_ptr(x86_cpu_to_node_map);
84 84
@@ -101,7 +101,7 @@ void __cpuinit numa_set_node(int cpu, int node)
101 set_cpu_numa_node(cpu, node); 101 set_cpu_numa_node(cpu, node);
102} 102}
103 103
104void __cpuinit numa_clear_node(int cpu) 104void numa_clear_node(int cpu)
105{ 105{
106 numa_set_node(cpu, NUMA_NO_NODE); 106 numa_set_node(cpu, NUMA_NO_NODE);
107} 107}
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 17e1447077ab..a9072a16a160 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -1705,6 +1705,34 @@ static int check_cpu_on_node(void *data)
1705 return 0; 1705 return 0;
1706} 1706}
1707 1707
1708static void unmap_cpu_on_node(void *data)
1709{
1710#ifdef CONFIG_ACPI_NUMA
1711 struct pglist_data *pgdat = data;
1712 int cpu;
1713
1714 for_each_possible_cpu(cpu)
1715 if (cpu_to_node(cpu) == pgdat->node_id)
1716 numa_clear_node(cpu);
1717#endif
1718}
1719
1720static int check_and_unmap_cpu_on_node(void *data)
1721{
1722 int ret = check_cpu_on_node(data);
1723
1724 if (ret)
1725 return ret;
1726
1727 /*
1728 * the node will be offlined when we come here, so we can clear
1729 * the cpu_to_node() now.
1730 */
1731
1732 unmap_cpu_on_node(data);
1733 return 0;
1734}
1735
1708/* offline the node if all memory sections of this node are removed */ 1736/* offline the node if all memory sections of this node are removed */
1709void try_offline_node(int nid) 1737void try_offline_node(int nid)
1710{ 1738{
@@ -1731,7 +1759,7 @@ void try_offline_node(int nid)
1731 return; 1759 return;
1732 } 1760 }
1733 1761
1734 if (stop_machine(check_cpu_on_node, pgdat, NULL)) 1762 if (stop_machine(check_and_unmap_cpu_on_node, pgdat, NULL))
1735 return; 1763 return;
1736 1764
1737 /* 1765 /*