diff options
author | Jesse Barnes <jbarnes@virtuousgeek.org> | 2014-06-18 12:52:55 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2014-06-19 12:05:12 -0400 |
commit | e11aa362308f5de467ce355a2a2471321b15a35c (patch) | |
tree | ba6ddeb7b3381dfb337a457dfa8f8ddf41c9a9ef | |
parent | e991077ec67e08bd345fcee4f810e59740359da5 (diff) |
drm/i915: use runtime irq suspend/resume in freeze/thaw
We don't need to uninstall the full handler, simply disabling interrupts
ought to be enough.
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/i915_drv.c | 5 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_pm.c | 4 |
2 files changed, 4 insertions, 5 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 7ae4e2a20493..be9774148426 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c | |||
@@ -522,7 +522,7 @@ static int i915_drm_freeze(struct drm_device *dev) | |||
522 | return error; | 522 | return error; |
523 | } | 523 | } |
524 | 524 | ||
525 | drm_irq_uninstall(dev); | 525 | intel_runtime_pm_disable_interrupts(dev); |
526 | dev_priv->enable_hotplug_processing = false; | 526 | dev_priv->enable_hotplug_processing = false; |
527 | 527 | ||
528 | intel_suspend_gt_powersave(dev); | 528 | intel_suspend_gt_powersave(dev); |
@@ -646,8 +646,7 @@ static int __i915_drm_thaw(struct drm_device *dev, bool restore_gtt_mappings) | |||
646 | } | 646 | } |
647 | mutex_unlock(&dev->struct_mutex); | 647 | mutex_unlock(&dev->struct_mutex); |
648 | 648 | ||
649 | /* We need working interrupts for modeset enabling ... */ | 649 | intel_runtime_pm_restore_interrupts(dev); |
650 | drm_irq_install(dev, dev->pdev->irq); | ||
651 | 650 | ||
652 | intel_modeset_init_hw(dev); | 651 | intel_modeset_init_hw(dev); |
653 | 652 | ||
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 8148d06b5b5e..1cce0a590979 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c | |||
@@ -4880,7 +4880,7 @@ void intel_suspend_gt_powersave(struct drm_device *dev) | |||
4880 | struct drm_i915_private *dev_priv = dev->dev_private; | 4880 | struct drm_i915_private *dev_priv = dev->dev_private; |
4881 | 4881 | ||
4882 | /* Interrupts should be disabled already to avoid re-arming. */ | 4882 | /* Interrupts should be disabled already to avoid re-arming. */ |
4883 | WARN_ON(dev->irq_enabled); | 4883 | WARN_ON(dev->irq_enabled && !dev_priv->pm.irqs_disabled); |
4884 | 4884 | ||
4885 | flush_delayed_work(&dev_priv->rps.delayed_resume_work); | 4885 | flush_delayed_work(&dev_priv->rps.delayed_resume_work); |
4886 | 4886 | ||
@@ -4892,7 +4892,7 @@ void intel_disable_gt_powersave(struct drm_device *dev) | |||
4892 | struct drm_i915_private *dev_priv = dev->dev_private; | 4892 | struct drm_i915_private *dev_priv = dev->dev_private; |
4893 | 4893 | ||
4894 | /* Interrupts should be disabled already to avoid re-arming. */ | 4894 | /* Interrupts should be disabled already to avoid re-arming. */ |
4895 | WARN_ON(dev->irq_enabled); | 4895 | WARN_ON(dev->irq_enabled && !dev_priv->pm.irqs_disabled); |
4896 | 4896 | ||
4897 | if (IS_IRONLAKE_M(dev)) { | 4897 | if (IS_IRONLAKE_M(dev)) { |
4898 | ironlake_disable_drps(dev); | 4898 | ironlake_disable_drps(dev); |