diff options
author | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-27 12:05:49 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-27 12:05:49 -0400 |
commit | e0ab0bb6d2b77917f4c31f157b2690602a5608f9 (patch) | |
tree | 644c65b44f551e29341d5efab6b309ff1e6782f2 | |
parent | 5c46010af210712c8a390c7fe50ff05448983061 (diff) | |
parent | 40bee44eaef91b6030037c8bb47f909181fb1edc (diff) |
Merge branch 'for-linus' of git://git.kernel.dk/data/git/linux-2.6-block
* 'for-linus' of git://git.kernel.dk/data/git/linux-2.6-block:
Export __splice_from_pipe()
2/2 splice: dont readpage
1/2 splice: dont steal
make elv_register() output atomic
block: blk_max_pfn is somtimes wrong
-rw-r--r-- | block/elevator.c | 7 | ||||
-rw-r--r-- | block/ll_rw_blk.c | 6 | ||||
-rw-r--r-- | fs/splice.c | 84 | ||||
-rw-r--r-- | include/linux/pipe_fs_i.h | 4 | ||||
-rw-r--r-- | mm/bounce.c | 2 |
5 files changed, 27 insertions, 76 deletions
diff --git a/block/elevator.c b/block/elevator.c index 25f6ef28e3bb..96a00c822748 100644 --- a/block/elevator.c +++ b/block/elevator.c | |||
@@ -964,17 +964,18 @@ void elv_unregister_queue(struct request_queue *q) | |||
964 | 964 | ||
965 | int elv_register(struct elevator_type *e) | 965 | int elv_register(struct elevator_type *e) |
966 | { | 966 | { |
967 | char *def = ""; | ||
967 | spin_lock_irq(&elv_list_lock); | 968 | spin_lock_irq(&elv_list_lock); |
968 | BUG_ON(elevator_find(e->elevator_name)); | 969 | BUG_ON(elevator_find(e->elevator_name)); |
969 | list_add_tail(&e->list, &elv_list); | 970 | list_add_tail(&e->list, &elv_list); |
970 | spin_unlock_irq(&elv_list_lock); | 971 | spin_unlock_irq(&elv_list_lock); |
971 | 972 | ||
972 | printk(KERN_INFO "io scheduler %s registered", e->elevator_name); | ||
973 | if (!strcmp(e->elevator_name, chosen_elevator) || | 973 | if (!strcmp(e->elevator_name, chosen_elevator) || |
974 | (!*chosen_elevator && | 974 | (!*chosen_elevator && |
975 | !strcmp(e->elevator_name, CONFIG_DEFAULT_IOSCHED))) | 975 | !strcmp(e->elevator_name, CONFIG_DEFAULT_IOSCHED))) |
976 | printk(" (default)"); | 976 | def = " (default)"; |
977 | printk("\n"); | 977 | |
978 | printk(KERN_INFO "io scheduler %s registered%s\n", e->elevator_name, def); | ||
978 | return 0; | 979 | return 0; |
979 | } | 980 | } |
980 | EXPORT_SYMBOL_GPL(elv_register); | 981 | EXPORT_SYMBOL_GPL(elv_register); |
diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c index 38c293b987b7..3de06953ac33 100644 --- a/block/ll_rw_blk.c +++ b/block/ll_rw_blk.c | |||
@@ -1221,7 +1221,7 @@ void blk_recount_segments(request_queue_t *q, struct bio *bio) | |||
1221 | * considered part of another segment, since that might | 1221 | * considered part of another segment, since that might |
1222 | * change with the bounce page. | 1222 | * change with the bounce page. |
1223 | */ | 1223 | */ |
1224 | high = page_to_pfn(bv->bv_page) >= q->bounce_pfn; | 1224 | high = page_to_pfn(bv->bv_page) > q->bounce_pfn; |
1225 | if (high || highprv) | 1225 | if (high || highprv) |
1226 | goto new_hw_segment; | 1226 | goto new_hw_segment; |
1227 | if (cluster) { | 1227 | if (cluster) { |
@@ -3658,8 +3658,8 @@ int __init blk_dev_init(void) | |||
3658 | open_softirq(BLOCK_SOFTIRQ, blk_done_softirq, NULL); | 3658 | open_softirq(BLOCK_SOFTIRQ, blk_done_softirq, NULL); |
3659 | register_hotcpu_notifier(&blk_cpu_notifier); | 3659 | register_hotcpu_notifier(&blk_cpu_notifier); |
3660 | 3660 | ||
3661 | blk_max_low_pfn = max_low_pfn; | 3661 | blk_max_low_pfn = max_low_pfn - 1; |
3662 | blk_max_pfn = max_pfn; | 3662 | blk_max_pfn = max_pfn - 1; |
3663 | 3663 | ||
3664 | return 0; | 3664 | return 0; |
3665 | } | 3665 | } |
diff --git a/fs/splice.c b/fs/splice.c index 2fca6ebf4cc2..07f6556add0a 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
@@ -576,76 +576,21 @@ static int pipe_to_file(struct pipe_inode_info *pipe, struct pipe_buffer *buf, | |||
576 | if (this_len + offset > PAGE_CACHE_SIZE) | 576 | if (this_len + offset > PAGE_CACHE_SIZE) |
577 | this_len = PAGE_CACHE_SIZE - offset; | 577 | this_len = PAGE_CACHE_SIZE - offset; |
578 | 578 | ||
579 | /* | ||
580 | * Reuse buf page, if SPLICE_F_MOVE is set and we are doing a full | ||
581 | * page. | ||
582 | */ | ||
583 | if ((sd->flags & SPLICE_F_MOVE) && this_len == PAGE_CACHE_SIZE) { | ||
584 | /* | ||
585 | * If steal succeeds, buf->page is now pruned from the | ||
586 | * pagecache and we can reuse it. The page will also be | ||
587 | * locked on successful return. | ||
588 | */ | ||
589 | if (buf->ops->steal(pipe, buf)) | ||
590 | goto find_page; | ||
591 | |||
592 | page = buf->page; | ||
593 | if (add_to_page_cache(page, mapping, index, GFP_KERNEL)) { | ||
594 | unlock_page(page); | ||
595 | goto find_page; | ||
596 | } | ||
597 | |||
598 | page_cache_get(page); | ||
599 | |||
600 | if (!(buf->flags & PIPE_BUF_FLAG_LRU)) | ||
601 | lru_cache_add(page); | ||
602 | } else { | ||
603 | find_page: | 579 | find_page: |
604 | page = find_lock_page(mapping, index); | 580 | page = find_lock_page(mapping, index); |
605 | if (!page) { | 581 | if (!page) { |
606 | ret = -ENOMEM; | 582 | ret = -ENOMEM; |
607 | page = page_cache_alloc_cold(mapping); | 583 | page = page_cache_alloc_cold(mapping); |
608 | if (unlikely(!page)) | 584 | if (unlikely(!page)) |
609 | goto out_ret; | 585 | goto out_ret; |
610 | |||
611 | /* | ||
612 | * This will also lock the page | ||
613 | */ | ||
614 | ret = add_to_page_cache_lru(page, mapping, index, | ||
615 | GFP_KERNEL); | ||
616 | if (unlikely(ret)) | ||
617 | goto out; | ||
618 | } | ||
619 | 586 | ||
620 | /* | 587 | /* |
621 | * We get here with the page locked. If the page is also | 588 | * This will also lock the page |
622 | * uptodate, we don't need to do more. If it isn't, we | ||
623 | * may need to bring it in if we are not going to overwrite | ||
624 | * the full page. | ||
625 | */ | 589 | */ |
626 | if (!PageUptodate(page)) { | 590 | ret = add_to_page_cache_lru(page, mapping, index, |
627 | if (this_len < PAGE_CACHE_SIZE) { | 591 | GFP_KERNEL); |
628 | ret = mapping->a_ops->readpage(file, page); | 592 | if (unlikely(ret)) |
629 | if (unlikely(ret)) | 593 | goto out; |
630 | goto out; | ||
631 | |||
632 | lock_page(page); | ||
633 | |||
634 | if (!PageUptodate(page)) { | ||
635 | /* | ||
636 | * Page got invalidated, repeat. | ||
637 | */ | ||
638 | if (!page->mapping) { | ||
639 | unlock_page(page); | ||
640 | page_cache_release(page); | ||
641 | goto find_page; | ||
642 | } | ||
643 | ret = -EIO; | ||
644 | goto out; | ||
645 | } | ||
646 | } else | ||
647 | SetPageUptodate(page); | ||
648 | } | ||
649 | } | 594 | } |
650 | 595 | ||
651 | ret = mapping->a_ops->prepare_write(file, page, offset, offset+this_len); | 596 | ret = mapping->a_ops->prepare_write(file, page, offset, offset+this_len); |
@@ -706,9 +651,9 @@ out_ret: | |||
706 | * key here is the 'actor' worker passed in that actually moves the data | 651 | * key here is the 'actor' worker passed in that actually moves the data |
707 | * to the wanted destination. See pipe_to_file/pipe_to_sendpage above. | 652 | * to the wanted destination. See pipe_to_file/pipe_to_sendpage above. |
708 | */ | 653 | */ |
709 | static ssize_t __splice_from_pipe(struct pipe_inode_info *pipe, | 654 | ssize_t __splice_from_pipe(struct pipe_inode_info *pipe, |
710 | struct file *out, loff_t *ppos, size_t len, | 655 | struct file *out, loff_t *ppos, size_t len, |
711 | unsigned int flags, splice_actor *actor) | 656 | unsigned int flags, splice_actor *actor) |
712 | { | 657 | { |
713 | int ret, do_wakeup, err; | 658 | int ret, do_wakeup, err; |
714 | struct splice_desc sd; | 659 | struct splice_desc sd; |
@@ -802,6 +747,7 @@ static ssize_t __splice_from_pipe(struct pipe_inode_info *pipe, | |||
802 | 747 | ||
803 | return ret; | 748 | return ret; |
804 | } | 749 | } |
750 | EXPORT_SYMBOL(__splice_from_pipe); | ||
805 | 751 | ||
806 | ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out, | 752 | ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out, |
807 | loff_t *ppos, size_t len, unsigned int flags, | 753 | loff_t *ppos, size_t len, unsigned int flags, |
diff --git a/include/linux/pipe_fs_i.h b/include/linux/pipe_fs_i.h index 2e19478e9e84..8bcbc54e1b48 100644 --- a/include/linux/pipe_fs_i.h +++ b/include/linux/pipe_fs_i.h | |||
@@ -99,4 +99,8 @@ extern ssize_t splice_from_pipe(struct pipe_inode_info *, struct file *, | |||
99 | loff_t *, size_t, unsigned int, | 99 | loff_t *, size_t, unsigned int, |
100 | splice_actor *); | 100 | splice_actor *); |
101 | 101 | ||
102 | extern ssize_t __splice_from_pipe(struct pipe_inode_info *, struct file *, | ||
103 | loff_t *, size_t, unsigned int, | ||
104 | splice_actor *); | ||
105 | |||
102 | #endif | 106 | #endif |
diff --git a/mm/bounce.c b/mm/bounce.c index 643efbe82402..ad401fc57440 100644 --- a/mm/bounce.c +++ b/mm/bounce.c | |||
@@ -204,7 +204,7 @@ static void __blk_queue_bounce(request_queue_t *q, struct bio **bio_orig, | |||
204 | /* | 204 | /* |
205 | * is destination page below bounce pfn? | 205 | * is destination page below bounce pfn? |
206 | */ | 206 | */ |
207 | if (page_to_pfn(page) < q->bounce_pfn) | 207 | if (page_to_pfn(page) <= q->bounce_pfn) |
208 | continue; | 208 | continue; |
209 | 209 | ||
210 | /* | 210 | /* |