diff options
| author | Rafael J. Wysocki <rjw@sisk.pl> | 2011-12-21 03:51:23 -0500 |
|---|---|---|
| committer | Rafael J. Wysocki <rjw@sisk.pl> | 2011-12-21 03:51:23 -0500 |
| commit | dfa9d178cd28caf5d76bc4f37f4b3e7e8df8e697 (patch) | |
| tree | d97ca7790d8a622cba9fdd19832decdb0aa6418a | |
| parent | 3f19f08a7ec74cfc50fbad3c5e615760afbd23a0 (diff) | |
| parent | 7b4050381127ae11fcfc74a106d715a5fbbf888a (diff) | |
Merge branch 'devfreq-for-next' of git://git.infradead.org/users/kmpark/linux-samsung into pm-devfreq
* 'devfreq-for-next' of git://git.infradead.org/users/kmpark/linux-samsung: (765 commits)
PM/Devfreq: Add Exynos4-bus device DVFS driver for Exynos4210/4212/4412.
pci: Fix hotplug of Express Module with pci bridges
i2c-eg20t: correct the driver init order of pch_i2c_probe()
I2C: OMAP: fix FIFO usage for OMAP4
i2c-s3c2410: Fix return code of s3c24xx_i2c_parse_dt_gpio
i2c: i2c-s3c2410: Add a cpu_relax() to busy wait for bus idle
Linux 3.2-rc6
Revert "drm/i915: fix infinite recursion on unbind due to ilk vt-d w/a"
btrfs: lower the dirty balance poll interval
drm/i915/dp: Dither down to 6bpc if it makes the mode fit
drm/i915: enable semaphores on per-device defaults
drm/i915: don't set unpin_work if vblank_get fails
drm/i915: By default, enable RC6 on IVB and SNB when reasonable
iommu: Export intel_iommu_enabled to signal when iommu is in use
drm/i915/sdvo: Include LVDS panels for the IS_DIGITAL check
drm/i915: prevent division by zero when asking for chipset power
drm/i915: add PCH info to i915_capabilities
drm/i915: set the right SDVO transcoder for CPT
drm/i915: no-lvds quirk for ASUS AT5NM10T-I
sched: Fix select_idle_sibling() regression in selecting an idle SMT sibling
...
779 files changed, 11372 insertions, 6019 deletions
| @@ -688,10 +688,13 @@ S: Oxfordshire, UK. | |||
| 688 | 688 | ||
| 689 | N: Kees Cook | 689 | N: Kees Cook |
| 690 | E: kees@outflux.net | 690 | E: kees@outflux.net |
| 691 | W: http://outflux.net/ | 691 | E: kees@ubuntu.com |
| 692 | P: 1024D/17063E6D 9FA3 C49C 23C9 D1BC 2E30 1975 1FFF 4BA9 1706 3E6D | 692 | E: keescook@chromium.org |
| 693 | D: Minor updates to SCSI types, added /proc/pid/maps protection | 693 | W: http://outflux.net/blog/ |
| 694 | P: 4096R/DC6DC026 A5C3 F68F 229D D60F 723E 6E13 8972 F4DF DC6D C026 | ||
| 695 | D: Various security things, bug fixes, and documentation. | ||
| 694 | S: (ask for current address) | 696 | S: (ask for current address) |
| 697 | S: Portland, Oregon | ||
| 695 | S: USA | 698 | S: USA |
| 696 | 699 | ||
| 697 | N: Robin Cornelius | 700 | N: Robin Cornelius |
diff --git a/Documentation/ABI/testing/sysfs-bus-rbd b/Documentation/ABI/testing/sysfs-bus-rbd index fa72ccb2282e..dbedafb095e2 100644 --- a/Documentation/ABI/testing/sysfs-bus-rbd +++ b/Documentation/ABI/testing/sysfs-bus-rbd | |||
| @@ -57,13 +57,6 @@ create_snap | |||
| 57 | 57 | ||
| 58 | $ echo <snap-name> > /sys/bus/rbd/devices/<dev-id>/snap_create | 58 | $ echo <snap-name> > /sys/bus/rbd/devices/<dev-id>/snap_create |
| 59 | 59 | ||
| 60 | rollback_snap | ||
| 61 | |||
| 62 | Rolls back data to the specified snapshot. This goes over the entire | ||
| 63 | list of rados blocks and sends a rollback command to each. | ||
| 64 | |||
| 65 | $ echo <snap-name> > /sys/bus/rbd/devices/<dev-id>/snap_rollback | ||
| 66 | |||
| 67 | snap_* | 60 | snap_* |
| 68 | 61 | ||
| 69 | A directory per each snapshot | 62 | A directory per each snapshot |
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index e8552782b440..874921e97802 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.txt +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt | |||
| @@ -33,6 +33,7 @@ qcom Qualcomm, Inc. | |||
| 33 | ramtron Ramtron International | 33 | ramtron Ramtron International |
| 34 | samsung Samsung Semiconductor | 34 | samsung Samsung Semiconductor |
| 35 | schindler Schindler | 35 | schindler Schindler |
| 36 | sil Silicon Image | ||
| 36 | simtek | 37 | simtek |
| 37 | sirf SiRF Technology, Inc. | 38 | sirf SiRF Technology, Inc. |
| 38 | stericsson ST-Ericsson | 39 | stericsson ST-Ericsson |
diff --git a/Documentation/filesystems/btrfs.txt b/Documentation/filesystems/btrfs.txt index 64087c34327f..7671352216f1 100644 --- a/Documentation/filesystems/btrfs.txt +++ b/Documentation/filesystems/btrfs.txt | |||
| @@ -63,8 +63,8 @@ IRC network. | |||
| 63 | Userspace tools for creating and manipulating Btrfs file systems are | 63 | Userspace tools for creating and manipulating Btrfs file systems are |
| 64 | available from the git repository at the following location: | 64 | available from the git repository at the following location: |
| 65 | 65 | ||
| 66 | http://git.kernel.org/?p=linux/kernel/git/mason/btrfs-progs-unstable.git | 66 | http://git.kernel.org/?p=linux/kernel/git/mason/btrfs-progs.git |
| 67 | git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs-unstable.git | 67 | git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git |
| 68 | 68 | ||
| 69 | These include the following tools: | 69 | These include the following tools: |
| 70 | 70 | ||
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index a0c5c5f4fce6..81c287fad79d 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt | |||
| @@ -315,12 +315,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. | |||
| 315 | CPU-intensive style benchmark, and it can vary highly in | 315 | CPU-intensive style benchmark, and it can vary highly in |
| 316 | a microbenchmark depending on workload and compiler. | 316 | a microbenchmark depending on workload and compiler. |
| 317 | 317 | ||
| 318 | 1: only for 32-bit processes | 318 | 32: only for 32-bit processes |
| 319 | 2: only for 64-bit processes | 319 | 64: only for 64-bit processes |
| 320 | on: enable for both 32- and 64-bit processes | 320 | on: enable for both 32- and 64-bit processes |
| 321 | off: disable for both 32- and 64-bit processes | 321 | off: disable for both 32- and 64-bit processes |
| 322 | 322 | ||
| 323 | amd_iommu= [HW,X86-84] | 323 | amd_iommu= [HW,X86-64] |
| 324 | Pass parameters to the AMD IOMMU driver in the system. | 324 | Pass parameters to the AMD IOMMU driver in the system. |
| 325 | Possible values are: | 325 | Possible values are: |
| 326 | fullflush - enable flushing of IO/TLB entries when | 326 | fullflush - enable flushing of IO/TLB entries when |
diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt index f049a1ca186f..589f2da5d545 100644 --- a/Documentation/networking/ip-sysctl.txt +++ b/Documentation/networking/ip-sysctl.txt | |||
| @@ -282,11 +282,11 @@ tcp_max_ssthresh - INTEGER | |||
| 282 | Default: 0 (off) | 282 | Default: 0 (off) |
| 283 | 283 | ||
| 284 | tcp_max_syn_backlog - INTEGER | 284 | tcp_max_syn_backlog - INTEGER |
| 285 | Maximal number of remembered connection requests, which are | 285 | Maximal number of remembered connection requests, which have not |
| 286 | still did not receive an acknowledgment from connecting client. | 286 | received an acknowledgment from connecting client. |
| 287 | Default value is 1024 for systems with more than 128Mb of memory, | 287 | The minimal value is 128 for low memory machines, and it will |
| 288 | and 128 for low memory machines. If server suffers of overload, | 288 | increase in proportion to the memory of machine. |
| 289 | try to increase this number. | 289 | If server suffers from overload, try increasing this number. |
| 290 | 290 | ||
| 291 | tcp_max_tw_buckets - INTEGER | 291 | tcp_max_tw_buckets - INTEGER |
| 292 | Maximal number of timewait sockets held by system simultaneously. | 292 | Maximal number of timewait sockets held by system simultaneously. |
diff --git a/Documentation/power/devices.txt b/Documentation/power/devices.txt index 646a89e0c07d..3139fb505dce 100644 --- a/Documentation/power/devices.txt +++ b/Documentation/power/devices.txt | |||
| @@ -123,9 +123,10 @@ please refer directly to the source code for more information about it. | |||
| 123 | Subsystem-Level Methods | 123 | Subsystem-Level Methods |
| 124 | ----------------------- | 124 | ----------------------- |
| 125 | The core methods to suspend and resume devices reside in struct dev_pm_ops | 125 | The core methods to suspend and resume devices reside in struct dev_pm_ops |
| 126 | pointed to by the pm member of struct bus_type, struct device_type and | 126 | pointed to by the ops member of struct dev_pm_domain, or by the pm member of |
| 127 | struct class. They are mostly of interest to the people writing infrastructure | 127 | struct bus_type, struct device_type and struct class. They are mostly of |
| 128 | for buses, like PCI or USB, or device type and device class drivers. | 128 | interest to the people writing infrastructure for platforms and buses, like PCI |
| 129 | or USB, or device type and device class drivers. | ||
| 129 | 130 | ||
| 130 | Bus drivers implement these methods as appropriate for the hardware and the | 131 | Bus drivers implement these methods as appropriate for the hardware and the |
| 131 | drivers using it; PCI works differently from USB, and so on. Not many people | 132 | drivers using it; PCI works differently from USB, and so on. Not many people |
| @@ -139,41 +140,57 @@ sequencing in the driver model tree. | |||
| 139 | 140 | ||
| 140 | /sys/devices/.../power/wakeup files | 141 | /sys/devices/.../power/wakeup files |
| 141 | ----------------------------------- | 142 | ----------------------------------- |
| 142 | All devices in the driver model have two flags to control handling of wakeup | 143 | All device objects in the driver model contain fields that control the handling |
| 143 | events (hardware signals that can force the device and/or system out of a low | 144 | of system wakeup events (hardware signals that can force the system out of a |
| 144 | power state). These flags are initialized by bus or device driver code using | 145 | sleep state). These fields are initialized by bus or device driver code using |
| 145 | device_set_wakeup_capable() and device_set_wakeup_enable(), defined in | 146 | device_set_wakeup_capable() and device_set_wakeup_enable(), defined in |
| 146 | include/linux/pm_wakeup.h. | 147 | include/linux/pm_wakeup.h. |
| 147 | 148 | ||
| 148 | The "can_wakeup" flag just records whether the device (and its driver) can | 149 | The "power.can_wakeup" flag just records whether the device (and its driver) can |
| 149 | physically support wakeup events. The device_set_wakeup_capable() routine | 150 | physically support wakeup events. The device_set_wakeup_capable() routine |
| 150 | affects this flag. The "should_wakeup" flag controls whether the device should | 151 | affects this flag. The "power.wakeup" field is a pointer to an object of type |
| 151 | try to use its wakeup mechanism. device_set_wakeup_enable() affects this flag; | 152 | struct wakeup_source used for controlling whether or not the device should use |
| 152 | for the most part drivers should not change its value. The initial value of | 153 | its system wakeup mechanism and for notifying the PM core of system wakeup |
| 153 | should_wakeup is supposed to be false for the majority of devices; the major | 154 | events signaled by the device. This object is only present for wakeup-capable |
| 154 | exceptions are power buttons, keyboards, and Ethernet adapters whose WoL | 155 | devices (i.e. devices whose "can_wakeup" flags are set) and is created (or |
| 155 | (wake-on-LAN) feature has been set up with ethtool. It should also default | 156 | removed) by device_set_wakeup_capable(). |
| 156 | to true for devices that don't generate wakeup requests on their own but merely | ||
| 157 | forward wakeup requests from one bus to another (like PCI bridges). | ||
| 158 | 157 | ||
| 159 | Whether or not a device is capable of issuing wakeup events is a hardware | 158 | Whether or not a device is capable of issuing wakeup events is a hardware |
| 160 | matter, and the kernel is responsible for keeping track of it. By contrast, | 159 | matter, and the kernel is responsible for keeping track of it. By contrast, |
| 161 | whether or not a wakeup-capable device should issue wakeup events is a policy | 160 | whether or not a wakeup-capable device should issue wakeup events is a policy |
| 162 | decision, and it is managed by user space through a sysfs attribute: the | 161 | decision, and it is managed by user space through a sysfs attribute: the |
| 163 | power/wakeup file. User space can write the strings "enabled" or "disabled" to | 162 | "power/wakeup" file. User space can write the strings "enabled" or "disabled" |
| 164 | set or clear the "should_wakeup" flag, respectively. This file is only present | 163 | to it to indicate whether or not, respectively, the device is supposed to signal |
| 165 | for wakeup-capable devices (i.e. devices whose "can_wakeup" flags are set) | 164 | system wakeup. This file is only present if the "power.wakeup" object exists |
| 166 | and is created (or removed) by device_set_wakeup_capable(). Reads from the | 165 | for the given device and is created (or removed) along with that object, by |
| 167 | file will return the corresponding string. | 166 | device_set_wakeup_capable(). Reads from the file will return the corresponding |
| 168 | 167 | string. | |
| 169 | The device_may_wakeup() routine returns true only if both flags are set. | 168 | |
| 169 | The "power/wakeup" file is supposed to contain the "disabled" string initially | ||
| 170 | for the majority of devices; the major exceptions are power buttons, keyboards, | ||
| 171 | and Ethernet adapters whose WoL (wake-on-LAN) feature has been set up with | ||
| 172 | ethtool. It should also default to "enabled" for devices that don't generate | ||
| 173 | wakeup requests on their own but merely forward wakeup requests from one bus to | ||
| 174 | another (like PCI Express ports). | ||
| 175 | |||
| 176 | The device_may_wakeup() routine returns true only if the "power.wakeup" object | ||
| 177 | exists and the corresponding "power/wakeup" file contains the string "enabled". | ||
| 170 | This information is used by subsystems, like the PCI bus type code, to see | 178 | This information is used by subsystems, like the PCI bus type code, to see |
| 171 | whether or not to enable the devices' wakeup mechanisms. If device wakeup | 179 | whether or not to enable the devices' wakeup mechanisms. If device wakeup |
| 172 | mechanisms are enabled or disabled directly by drivers, they also should use | 180 | mechanisms are enabled or disabled directly by drivers, they also should use |
| 173 | device_may_wakeup() to decide what to do during a system sleep transition. | 181 | device_may_wakeup() to decide what to do during a system sleep transition. |
| 174 | However for runtime power management, wakeup events should be enabled whenever | 182 | Device drivers, however, are not supposed to call device_set_wakeup_enable() |
| 175 | the device and driver both support them, regardless of the should_wakeup flag. | 183 | directly in any case. |
| 176 | 184 | ||
| 185 | It ought to be noted that system wakeup is conceptually different from "remote | ||
| 186 | wakeup" used by runtime power management, although it may be supported by the | ||
| 187 | same physical mechanism. Remote wakeup is a feature allowing devices in | ||
| 188 | low-power states to trigger specific interrupts to signal conditions in which | ||
| 189 | they should be put into the full-power state. Those interrupts may or may not | ||
| 190 | be used to signal system wakeup events, depending on the hardware design. On | ||
| 191 | some systems it is impossible to trigger them from system sleep states. In any | ||
| 192 | case, remote wakeup should always be enabled for runtime power management for | ||
| 193 | all devices and drivers that support it. | ||
| 177 | 194 | ||
| 178 | /sys/devices/.../power/control files | 195 | /sys/devices/.../power/control files |
| 179 | ------------------------------------ | 196 | ------------------------------------ |
| @@ -249,20 +266,31 @@ for every device before the next phase begins. Not all busses or classes | |||
| 249 | support all these callbacks and not all drivers use all the callbacks. The | 266 | support all these callbacks and not all drivers use all the callbacks. The |
| 250 | various phases always run after tasks have been frozen and before they are | 267 | various phases always run after tasks have been frozen and before they are |
| 251 | unfrozen. Furthermore, the *_noirq phases run at a time when IRQ handlers have | 268 | unfrozen. Furthermore, the *_noirq phases run at a time when IRQ handlers have |
| 252 | been disabled (except for those marked with the IRQ_WAKEUP flag). | 269 | been disabled (except for those marked with the IRQF_NO_SUSPEND flag). |
| 253 | 270 | ||
| 254 | All phases use bus, type, or class callbacks (that is, methods defined in | 271 | All phases use PM domain, bus, type, or class callbacks (that is, methods |
| 255 | dev->bus->pm, dev->type->pm, or dev->class->pm). These callbacks are mutually | 272 | defined in dev->pm_domain->ops, dev->bus->pm, dev->type->pm, or dev->class->pm). |
| 256 | exclusive, so if the device type provides a struct dev_pm_ops object pointed to | 273 | These callbacks are regarded by the PM core as mutually exclusive. Moreover, |
| 257 | by its pm field (i.e. both dev->type and dev->type->pm are defined), the | 274 | PM domain callbacks always take precedence over bus, type and class callbacks, |
| 258 | callbacks included in that object (i.e. dev->type->pm) will be used. Otherwise, | 275 | while type callbacks take precedence over bus and class callbacks, and class |
| 259 | if the class provides a struct dev_pm_ops object pointed to by its pm field | 276 | callbacks take precedence over bus callbacks. To be precise, the following |
| 260 | (i.e. both dev->class and dev->class->pm are defined), the PM core will use the | 277 | rules are used to determine which callback to execute in the given phase: |
| 261 | callbacks from that object (i.e. dev->class->pm). Finally, if the pm fields of | 278 | |
| 262 | both the device type and class objects are NULL (or those objects do not exist), | 279 | 1. If dev->pm_domain is present, the PM core will attempt to execute the |
| 263 | the callbacks provided by the bus (that is, the callbacks from dev->bus->pm) | 280 | callback included in dev->pm_domain->ops. If that callback is not |
| 264 | will be used (this allows device types to override callbacks provided by bus | 281 | present, no action will be carried out for the given device. |
| 265 | types or classes if necessary). | 282 | |
| 283 | 2. Otherwise, if both dev->type and dev->type->pm are present, the callback | ||
| 284 | included in dev->type->pm will be executed. | ||
| 285 | |||
| 286 | 3. Otherwise, if both dev->class and dev->class->pm are present, the | ||
| 287 | callback included in dev->class->pm will be executed. | ||
| 288 | |||
| 289 | 4. Otherwise, if both dev->bus and dev->bus->pm are present, the callback | ||
| 290 | included in dev->bus->pm will be executed. | ||
| 291 | |||
| 292 | This allows PM domains and device types to override callbacks provided by bus | ||
| 293 | types or device classes if necessary. | ||
| 266 | 294 | ||
| 267 | These callbacks may in turn invoke device- or driver-specific methods stored in | 295 | These callbacks may in turn invoke device- or driver-specific methods stored in |
| 268 | dev->driver->pm, but they don't have to. | 296 | dev->driver->pm, but they don't have to. |
| @@ -283,9 +311,8 @@ When the system goes into the standby or memory sleep state, the phases are: | |||
| 283 | 311 | ||
| 284 | After the prepare callback method returns, no new children may be | 312 | After the prepare callback method returns, no new children may be |
| 285 | registered below the device. The method may also prepare the device or | 313 | registered below the device. The method may also prepare the device or |
| 286 | driver in some way for the upcoming system power transition (for | 314 | driver in some way for the upcoming system power transition, but it |
| 287 | example, by allocating additional memory required for this purpose), but | 315 | should not put the device into a low-power state. |
| 288 | it should not put the device into a low-power state. | ||
| 289 | 316 | ||
| 290 | 2. The suspend methods should quiesce the device to stop it from performing | 317 | 2. The suspend methods should quiesce the device to stop it from performing |
| 291 | I/O. They also may save the device registers and put it into the | 318 | I/O. They also may save the device registers and put it into the |
diff --git a/Documentation/power/runtime_pm.txt b/Documentation/power/runtime_pm.txt index 5336149f831b..c2ae8bf77d46 100644 --- a/Documentation/power/runtime_pm.txt +++ b/Documentation/power/runtime_pm.txt | |||
| @@ -44,25 +44,33 @@ struct dev_pm_ops { | |||
| 44 | }; | 44 | }; |
| 45 | 45 | ||
| 46 | The ->runtime_suspend(), ->runtime_resume() and ->runtime_idle() callbacks | 46 | The ->runtime_suspend(), ->runtime_resume() and ->runtime_idle() callbacks |
| 47 | are executed by the PM core for either the power domain, or the device type | 47 | are executed by the PM core for the device's subsystem that may be either of |
| 48 | (if the device power domain's struct dev_pm_ops does not exist), or the class | 48 | the following: |
| 49 | (if the device power domain's and type's struct dev_pm_ops object does not | 49 | |
| 50 | exist), or the bus type (if the device power domain's, type's and class' | 50 | 1. PM domain of the device, if the device's PM domain object, dev->pm_domain, |
| 51 | struct dev_pm_ops objects do not exist) of the given device, so the priority | 51 | is present. |
| 52 | order of callbacks from high to low is that power domain callbacks, device | 52 | |
| 53 | type callbacks, class callbacks and bus type callbacks, and the high priority | 53 | 2. Device type of the device, if both dev->type and dev->type->pm are present. |
| 54 | one will take precedence over low priority one. The bus type, device type and | 54 | |
| 55 | class callbacks are referred to as subsystem-level callbacks in what follows, | 55 | 3. Device class of the device, if both dev->class and dev->class->pm are |
| 56 | and generally speaking, the power domain callbacks are used for representing | 56 | present. |
| 57 | power domains within a SoC. | 57 | |
| 58 | 4. Bus type of the device, if both dev->bus and dev->bus->pm are present. | ||
| 59 | |||
| 60 | The PM core always checks which callback to use in the order given above, so the | ||
| 61 | priority order of callbacks from high to low is: PM domain, device type, class | ||
| 62 | and bus type. Moreover, the high-priority one will always take precedence over | ||
| 63 | a low-priority one. The PM domain, bus type, device type and class callbacks | ||
| 64 | are referred to as subsystem-level callbacks in what follows. | ||
| 58 | 65 | ||
| 59 | By default, the callbacks are always invoked in process context with interrupts | 66 | By default, the callbacks are always invoked in process context with interrupts |
| 60 | enabled. However, subsystems can use the pm_runtime_irq_safe() helper function | 67 | enabled. However, subsystems can use the pm_runtime_irq_safe() helper function |
| 61 | to tell the PM core that a device's ->runtime_suspend() and ->runtime_resume() | 68 | to tell the PM core that their ->runtime_suspend(), ->runtime_resume() and |
| 62 | callbacks should be invoked in atomic context with interrupts disabled. | 69 | ->runtime_idle() callbacks may be invoked in atomic context with interrupts |
| 63 | This implies that these callback routines must not block or sleep, but it also | 70 | disabled for a given device. This implies that the callback routines in |
| 64 | means that the synchronous helper functions listed at the end of Section 4 can | 71 | question must not block or sleep, but it also means that the synchronous helper |
| 65 | be used within an interrupt handler or in an atomic context. | 72 | functions listed at the end of Section 4 may be used for that device within an |
| 73 | interrupt handler or generally in an atomic context. | ||
| 66 | 74 | ||
| 67 | The subsystem-level suspend callback is _entirely_ _responsible_ for handling | 75 | The subsystem-level suspend callback is _entirely_ _responsible_ for handling |
| 68 | the suspend of the device as appropriate, which may, but need not include | 76 | the suspend of the device as appropriate, which may, but need not include |
diff --git a/Documentation/sound/alsa/soc/machine.txt b/Documentation/sound/alsa/soc/machine.txt index 3e2ec9cbf397..d50c14df3411 100644 --- a/Documentation/sound/alsa/soc/machine.txt +++ b/Documentation/sound/alsa/soc/machine.txt | |||
| @@ -50,8 +50,7 @@ Machine DAI Configuration | |||
| 50 | The machine DAI configuration glues all the codec and CPU DAIs together. It can | 50 | The machine DAI configuration glues all the codec and CPU DAIs together. It can |
| 51 | also be used to set up the DAI system clock and for any machine related DAI | 51 | also be used to set up the DAI system clock and for any machine related DAI |
| 52 | initialisation e.g. the machine audio map can be connected to the codec audio | 52 | initialisation e.g. the machine audio map can be connected to the codec audio |
| 53 | map, unconnected codec pins can be set as such. Please see corgi.c, spitz.c | 53 | map, unconnected codec pins can be set as such. |
| 54 | for examples. | ||
| 55 | 54 | ||
| 56 | struct snd_soc_dai_link is used to set up each DAI in your machine. e.g. | 55 | struct snd_soc_dai_link is used to set up each DAI in your machine. e.g. |
| 57 | 56 | ||
| @@ -83,8 +82,7 @@ Machine Power Map | |||
| 83 | The machine driver can optionally extend the codec power map and to become an | 82 | The machine driver can optionally extend the codec power map and to become an |
| 84 | audio power map of the audio subsystem. This allows for automatic power up/down | 83 | audio power map of the audio subsystem. This allows for automatic power up/down |
| 85 | of speaker/HP amplifiers, etc. Codec pins can be connected to the machines jack | 84 | of speaker/HP amplifiers, etc. Codec pins can be connected to the machines jack |
| 86 | sockets in the machine init function. See soc/pxa/spitz.c and dapm.txt for | 85 | sockets in the machine init function. |
| 87 | details. | ||
| 88 | 86 | ||
| 89 | 87 | ||
| 90 | Machine Controls | 88 | Machine Controls |
diff --git a/Documentation/usb/linux-cdc-acm.inf b/Documentation/usb/linux-cdc-acm.inf index 37a02ce54841..f0ffc27d4c0a 100644 --- a/Documentation/usb/linux-cdc-acm.inf +++ b/Documentation/usb/linux-cdc-acm.inf | |||
| @@ -90,10 +90,10 @@ ServiceBinary=%12%\USBSER.sys | |||
| 90 | [SourceDisksFiles] | 90 | [SourceDisksFiles] |
| 91 | [SourceDisksNames] | 91 | [SourceDisksNames] |
| 92 | [DeviceList] | 92 | [DeviceList] |
| 93 | %DESCRIPTION%=DriverInstall, USB\VID_0525&PID_A4A7, USB\VID_1D6B&PID_0104&MI_02 | 93 | %DESCRIPTION%=DriverInstall, USB\VID_0525&PID_A4A7, USB\VID_1D6B&PID_0104&MI_02, USB\VID_1D6B&PID_0106&MI_00 |
| 94 | 94 | ||
| 95 | [DeviceList.NTamd64] | 95 | [DeviceList.NTamd64] |
| 96 | %DESCRIPTION%=DriverInstall, USB\VID_0525&PID_A4A7, USB\VID_1D6B&PID_0104&MI_02 | 96 | %DESCRIPTION%=DriverInstall, USB\VID_0525&PID_A4A7, USB\VID_1D6B&PID_0104&MI_02, USB\VID_1D6B&PID_0106&MI_00 |
| 97 | 97 | ||
| 98 | 98 | ||
| 99 | ;------------------------------------------------------------------------------ | 99 | ;------------------------------------------------------------------------------ |
diff --git a/MAINTAINERS b/MAINTAINERS index 3523ab000f1f..855afd479156 100644 --- a/MAINTAINERS +++ b/MAINTAINERS | |||
| @@ -511,8 +511,8 @@ M: Joerg Roedel <joerg.roedel@amd.com> | |||
| 511 | L: iommu@lists.linux-foundation.org | 511 | L: iommu@lists.linux-foundation.org |
| 512 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/joro/linux-2.6-iommu.git | 512 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/joro/linux-2.6-iommu.git |
| 513 | S: Supported | 513 | S: Supported |
| 514 | F: arch/x86/kernel/amd_iommu*.c | 514 | F: drivers/iommu/amd_iommu*.[ch] |
| 515 | F: arch/x86/include/asm/amd_iommu*.h | 515 | F: include/linux/amd-iommu.h |
| 516 | 516 | ||
| 517 | AMD MICROCODE UPDATE SUPPORT | 517 | AMD MICROCODE UPDATE SUPPORT |
| 518 | M: Andreas Herrmann <andreas.herrmann3@amd.com> | 518 | M: Andreas Herrmann <andreas.herrmann3@amd.com> |
| @@ -789,6 +789,7 @@ L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | |||
| 789 | S: Maintained | 789 | S: Maintained |
| 790 | T: git git://git.pengutronix.de/git/imx/linux-2.6.git | 790 | T: git git://git.pengutronix.de/git/imx/linux-2.6.git |
| 791 | F: arch/arm/mach-mx*/ | 791 | F: arch/arm/mach-mx*/ |
| 792 | F: arch/arm/mach-imx/ | ||
| 792 | F: arch/arm/plat-mxc/ | 793 | F: arch/arm/plat-mxc/ |
| 793 | 794 | ||
| 794 | ARM/FREESCALE IMX51 | 795 | ARM/FREESCALE IMX51 |
| @@ -804,6 +805,13 @@ S: Maintained | |||
| 804 | T: git git://git.linaro.org/people/shawnguo/linux-2.6.git | 805 | T: git git://git.linaro.org/people/shawnguo/linux-2.6.git |
| 805 | F: arch/arm/mach-imx/*imx6* | 806 | F: arch/arm/mach-imx/*imx6* |
| 806 | 807 | ||
| 808 | ARM/FREESCALE MXS ARM ARCHITECTURE | ||
| 809 | M: Shawn Guo <shawn.guo@linaro.org> | ||
| 810 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | ||
| 811 | S: Maintained | ||
| 812 | T: git git://git.linaro.org/people/shawnguo/linux-2.6.git | ||
| 813 | F: arch/arm/mach-mxs/ | ||
| 814 | |||
| 807 | ARM/GLOMATION GESBC9312SX MACHINE SUPPORT | 815 | ARM/GLOMATION GESBC9312SX MACHINE SUPPORT |
| 808 | M: Lennert Buytenhek <kernel@wantstofly.org> | 816 | M: Lennert Buytenhek <kernel@wantstofly.org> |
| 809 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | 817 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) |
| @@ -1046,35 +1054,18 @@ ARM/SAMSUNG ARM ARCHITECTURES | |||
| 1046 | M: Ben Dooks <ben-linux@fluff.org> | 1054 | M: Ben Dooks <ben-linux@fluff.org> |
| 1047 | M: Kukjin Kim <kgene.kim@samsung.com> | 1055 | M: Kukjin Kim <kgene.kim@samsung.com> |
| 1048 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | 1056 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) |
| 1057 | L: linux-samsung-soc@vger.kernel.org (moderated for non-subscribers) | ||
| 1049 | W: http://www.fluff.org/ben/linux/ | 1058 | W: http://www.fluff.org/ben/linux/ |
| 1050 | S: Maintained | 1059 | S: Maintained |
| 1051 | F: arch/arm/plat-samsung/ | 1060 | F: arch/arm/plat-samsung/ |
| 1052 | F: arch/arm/plat-s3c24xx/ | 1061 | F: arch/arm/plat-s3c24xx/ |
| 1053 | F: arch/arm/plat-s5p/ | 1062 | F: arch/arm/plat-s5p/ |
| 1063 | F: arch/arm/mach-s3c24*/ | ||
| 1064 | F: arch/arm/mach-s3c64xx/ | ||
| 1054 | F: drivers/*/*s3c2410* | 1065 | F: drivers/*/*s3c2410* |
| 1055 | F: drivers/*/*/*s3c2410* | 1066 | F: drivers/*/*/*s3c2410* |
| 1056 | 1067 | F: drivers/spi/spi-s3c* | |
| 1057 | ARM/S3C2410 ARM ARCHITECTURE | 1068 | F: sound/soc/samsung/* |
| 1058 | M: Ben Dooks <ben-linux@fluff.org> | ||
| 1059 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | ||
| 1060 | W: http://www.fluff.org/ben/linux/ | ||
| 1061 | S: Maintained | ||
| 1062 | F: arch/arm/mach-s3c2410/ | ||
| 1063 | |||
| 1064 | ARM/S3C244x ARM ARCHITECTURE | ||
| 1065 | M: Ben Dooks <ben-linux@fluff.org> | ||
| 1066 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | ||
| 1067 | W: http://www.fluff.org/ben/linux/ | ||
| 1068 | S: Maintained | ||
| 1069 | F: arch/arm/mach-s3c2440/ | ||
| 1070 | F: arch/arm/mach-s3c2443/ | ||
| 1071 | |||
| 1072 | ARM/S3C64xx ARM ARCHITECTURE | ||
| 1073 | M: Ben Dooks <ben-linux@fluff.org> | ||
| 1074 | L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) | ||
| 1075 | W: http://www.fluff.org/ben/linux/ | ||
| 1076 | S: Maintained | ||
| 1077 | F: arch/arm/mach-s3c64xx/ | ||
| 1078 | 1069 | ||
| 1079 | ARM/S5P EXYNOS ARM ARCHITECTURES | 1070 | ARM/S5P EXYNOS ARM ARCHITECTURES |
| 1080 | M: Kukjin Kim <kgene.kim@samsung.com> | 1071 | M: Kukjin Kim <kgene.kim@samsung.com> |
| @@ -3110,6 +3101,7 @@ F: include/linux/hid* | |||
| 3110 | 3101 | ||
| 3111 | HIGH-RESOLUTION TIMERS, CLOCKEVENTS, DYNTICKS | 3102 | HIGH-RESOLUTION TIMERS, CLOCKEVENTS, DYNTICKS |
| 3112 | M: Thomas Gleixner <tglx@linutronix.de> | 3103 | M: Thomas Gleixner <tglx@linutronix.de> |
| 3104 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core | ||
| 3113 | S: Maintained | 3105 | S: Maintained |
| 3114 | F: Documentation/timers/ | 3106 | F: Documentation/timers/ |
| 3115 | F: kernel/hrtimer.c | 3107 | F: kernel/hrtimer.c |
| @@ -3619,7 +3611,7 @@ F: net/irda/ | |||
| 3619 | IRQ SUBSYSTEM | 3611 | IRQ SUBSYSTEM |
| 3620 | M: Thomas Gleixner <tglx@linutronix.de> | 3612 | M: Thomas Gleixner <tglx@linutronix.de> |
| 3621 | S: Maintained | 3613 | S: Maintained |
| 3622 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git irq/core | 3614 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core |
| 3623 | F: kernel/irq/ | 3615 | F: kernel/irq/ |
| 3624 | 3616 | ||
| 3625 | ISAPNP | 3617 | ISAPNP |
| @@ -4107,7 +4099,7 @@ F: drivers/hwmon/lm90.c | |||
| 4107 | LOCKDEP AND LOCKSTAT | 4099 | LOCKDEP AND LOCKSTAT |
| 4108 | M: Peter Zijlstra <peterz@infradead.org> | 4100 | M: Peter Zijlstra <peterz@infradead.org> |
| 4109 | M: Ingo Molnar <mingo@redhat.com> | 4101 | M: Ingo Molnar <mingo@redhat.com> |
| 4110 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/peterz/linux-2.6-lockdep.git | 4102 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/locking |
| 4111 | S: Maintained | 4103 | S: Maintained |
| 4112 | F: Documentation/lockdep*.txt | 4104 | F: Documentation/lockdep*.txt |
| 4113 | F: Documentation/lockstat.txt | 4105 | F: Documentation/lockstat.txt |
| @@ -4311,8 +4303,9 @@ F: include/linux/mm.h | |||
| 4311 | F: mm/ | 4303 | F: mm/ |
| 4312 | 4304 | ||
| 4313 | MEMORY RESOURCE CONTROLLER | 4305 | MEMORY RESOURCE CONTROLLER |
| 4306 | M: Johannes Weiner <hannes@cmpxchg.org> | ||
| 4307 | M: Michal Hocko <mhocko@suse.cz> | ||
| 4314 | M: Balbir Singh <bsingharora@gmail.com> | 4308 | M: Balbir Singh <bsingharora@gmail.com> |
| 4315 | M: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> | ||
| 4316 | M: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> | 4309 | M: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> |
| 4317 | L: cgroups@vger.kernel.org | 4310 | L: cgroups@vger.kernel.org |
| 4318 | L: linux-mm@kvack.org | 4311 | L: linux-mm@kvack.org |
| @@ -5094,6 +5087,7 @@ M: Peter Zijlstra <a.p.zijlstra@chello.nl> | |||
| 5094 | M: Paul Mackerras <paulus@samba.org> | 5087 | M: Paul Mackerras <paulus@samba.org> |
| 5095 | M: Ingo Molnar <mingo@elte.hu> | 5088 | M: Ingo Molnar <mingo@elte.hu> |
| 5096 | M: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> | 5089 | M: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> |
| 5090 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core | ||
| 5097 | S: Supported | 5091 | S: Supported |
| 5098 | F: kernel/events/* | 5092 | F: kernel/events/* |
| 5099 | F: include/linux/perf_event.h | 5093 | F: include/linux/perf_event.h |
| @@ -5173,6 +5167,7 @@ F: drivers/scsi/pm8001/ | |||
| 5173 | 5167 | ||
| 5174 | POSIX CLOCKS and TIMERS | 5168 | POSIX CLOCKS and TIMERS |
| 5175 | M: Thomas Gleixner <tglx@linutronix.de> | 5169 | M: Thomas Gleixner <tglx@linutronix.de> |
| 5170 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core | ||
| 5176 | S: Supported | 5171 | S: Supported |
| 5177 | F: fs/timerfd.c | 5172 | F: fs/timerfd.c |
| 5178 | F: include/linux/timer* | 5173 | F: include/linux/timer* |
| @@ -5667,7 +5662,6 @@ F: drivers/media/video/*7146* | |||
| 5667 | F: include/media/*7146* | 5662 | F: include/media/*7146* |
| 5668 | 5663 | ||
| 5669 | SAMSUNG AUDIO (ASoC) DRIVERS | 5664 | SAMSUNG AUDIO (ASoC) DRIVERS |
| 5670 | M: Jassi Brar <jassisinghbrar@gmail.com> | ||
| 5671 | M: Sangbeom Kim <sbkim73@samsung.com> | 5665 | M: Sangbeom Kim <sbkim73@samsung.com> |
| 5672 | L: alsa-devel@alsa-project.org (moderated for non-subscribers) | 5666 | L: alsa-devel@alsa-project.org (moderated for non-subscribers) |
| 5673 | S: Supported | 5667 | S: Supported |
| @@ -5689,6 +5683,7 @@ F: drivers/dma/dw_dmac.c | |||
| 5689 | TIMEKEEPING, NTP | 5683 | TIMEKEEPING, NTP |
| 5690 | M: John Stultz <johnstul@us.ibm.com> | 5684 | M: John Stultz <johnstul@us.ibm.com> |
| 5691 | M: Thomas Gleixner <tglx@linutronix.de> | 5685 | M: Thomas Gleixner <tglx@linutronix.de> |
| 5686 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core | ||
| 5692 | S: Supported | 5687 | S: Supported |
| 5693 | F: include/linux/clocksource.h | 5688 | F: include/linux/clocksource.h |
| 5694 | F: include/linux/time.h | 5689 | F: include/linux/time.h |
| @@ -5713,6 +5708,7 @@ F: drivers/watchdog/sc1200wdt.c | |||
| 5713 | SCHEDULER | 5708 | SCHEDULER |
| 5714 | M: Ingo Molnar <mingo@elte.hu> | 5709 | M: Ingo Molnar <mingo@elte.hu> |
| 5715 | M: Peter Zijlstra <peterz@infradead.org> | 5710 | M: Peter Zijlstra <peterz@infradead.org> |
| 5711 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core | ||
| 5716 | S: Maintained | 5712 | S: Maintained |
| 5717 | F: kernel/sched* | 5713 | F: kernel/sched* |
| 5718 | F: include/linux/sched.h | 5714 | F: include/linux/sched.h |
| @@ -6640,7 +6636,7 @@ TRACING | |||
| 6640 | M: Steven Rostedt <rostedt@goodmis.org> | 6636 | M: Steven Rostedt <rostedt@goodmis.org> |
| 6641 | M: Frederic Weisbecker <fweisbec@gmail.com> | 6637 | M: Frederic Weisbecker <fweisbec@gmail.com> |
| 6642 | M: Ingo Molnar <mingo@redhat.com> | 6638 | M: Ingo Molnar <mingo@redhat.com> |
| 6643 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git perf/core | 6639 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf/core |
| 6644 | S: Maintained | 6640 | S: Maintained |
| 6645 | F: Documentation/trace/ftrace.txt | 6641 | F: Documentation/trace/ftrace.txt |
| 6646 | F: arch/*/*/*/ftrace.h | 6642 | F: arch/*/*/*/ftrace.h |
| @@ -7390,7 +7386,7 @@ M: Thomas Gleixner <tglx@linutronix.de> | |||
| 7390 | M: Ingo Molnar <mingo@redhat.com> | 7386 | M: Ingo Molnar <mingo@redhat.com> |
| 7391 | M: "H. Peter Anvin" <hpa@zytor.com> | 7387 | M: "H. Peter Anvin" <hpa@zytor.com> |
| 7392 | M: x86@kernel.org | 7388 | M: x86@kernel.org |
| 7393 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git | 7389 | T: git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core |
| 7394 | S: Maintained | 7390 | S: Maintained |
| 7395 | F: Documentation/x86/ | 7391 | F: Documentation/x86/ |
| 7396 | F: arch/x86/ | 7392 | F: arch/x86/ |
| @@ -1,7 +1,7 @@ | |||
| 1 | VERSION = 3 | 1 | VERSION = 3 |
| 2 | PATCHLEVEL = 2 | 2 | PATCHLEVEL = 2 |
| 3 | SUBLEVEL = 0 | 3 | SUBLEVEL = 0 |
| 4 | EXTRAVERSION = -rc2 | 4 | EXTRAVERSION = -rc6 |
| 5 | NAME = Saber-toothed Squirrel | 5 | NAME = Saber-toothed Squirrel |
| 6 | 6 | ||
| 7 | # *DOCUMENTATION* | 7 | # *DOCUMENTATION* |
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index 44789eff983f..776d76b8cb69 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig | |||
| @@ -220,8 +220,9 @@ config NEED_MACH_MEMORY_H | |||
| 220 | be avoided when possible. | 220 | be avoided when possible. |
| 221 | 221 | ||
| 222 | config PHYS_OFFSET | 222 | config PHYS_OFFSET |
| 223 | hex "Physical address of main memory" | 223 | hex "Physical address of main memory" if MMU |
| 224 | depends on !ARM_PATCH_PHYS_VIRT && !NEED_MACH_MEMORY_H | 224 | depends on !ARM_PATCH_PHYS_VIRT && !NEED_MACH_MEMORY_H |
| 225 | default DRAM_BASE if !MMU | ||
| 225 | help | 226 | help |
| 226 | Please provide the physical address corresponding to the | 227 | Please provide the physical address corresponding to the |
| 227 | location of main memory in your system. | 228 | location of main memory in your system. |
| @@ -1231,7 +1232,7 @@ config ARM_ERRATA_742231 | |||
| 1231 | capabilities of the processor. | 1232 | capabilities of the processor. |
| 1232 | 1233 | ||
| 1233 | config PL310_ERRATA_588369 | 1234 | config PL310_ERRATA_588369 |
| 1234 | bool "Clean & Invalidate maintenance operations do not invalidate clean lines" | 1235 | bool "PL310 errata: Clean & Invalidate maintenance operations do not invalidate clean lines" |
| 1235 | depends on CACHE_L2X0 | 1236 | depends on CACHE_L2X0 |
| 1236 | help | 1237 | help |
| 1237 | The PL310 L2 cache controller implements three types of Clean & | 1238 | The PL310 L2 cache controller implements three types of Clean & |
| @@ -1256,7 +1257,7 @@ config ARM_ERRATA_720789 | |||
| 1256 | entries regardless of the ASID. | 1257 | entries regardless of the ASID. |
| 1257 | 1258 | ||
| 1258 | config PL310_ERRATA_727915 | 1259 | config PL310_ERRATA_727915 |
| 1259 | bool "Background Clean & Invalidate by Way operation can cause data corruption" | 1260 | bool "PL310 errata: Background Clean & Invalidate by Way operation can cause data corruption" |
| 1260 | depends on CACHE_L2X0 | 1261 | depends on CACHE_L2X0 |
| 1261 | help | 1262 | help |
| 1262 | PL310 implements the Clean & Invalidate by Way L2 cache maintenance | 1263 | PL310 implements the Clean & Invalidate by Way L2 cache maintenance |
| @@ -1289,8 +1290,8 @@ config ARM_ERRATA_751472 | |||
| 1289 | operation is received by a CPU before the ICIALLUIS has completed, | 1290 | operation is received by a CPU before the ICIALLUIS has completed, |
| 1290 | potentially leading to corrupted entries in the cache or TLB. | 1291 | potentially leading to corrupted entries in the cache or TLB. |
| 1291 | 1292 | ||
| 1292 | config ARM_ERRATA_753970 | 1293 | config PL310_ERRATA_753970 |
| 1293 | bool "ARM errata: cache sync operation may be faulty" | 1294 | bool "PL310 errata: cache sync operation may be faulty" |
| 1294 | depends on CACHE_PL310 | 1295 | depends on CACHE_PL310 |
| 1295 | help | 1296 | help |
| 1296 | This option enables the workaround for the 753970 PL310 (r3p0) erratum. | 1297 | This option enables the workaround for the 753970 PL310 (r3p0) erratum. |
| @@ -1352,6 +1353,18 @@ config ARM_ERRATA_764369 | |||
| 1352 | relevant cache maintenance functions and sets a specific bit | 1353 | relevant cache maintenance functions and sets a specific bit |
| 1353 | in the diagnostic control register of the SCU. | 1354 | in the diagnostic control register of the SCU. |
| 1354 | 1355 | ||
| 1356 | config PL310_ERRATA_769419 | ||
| 1357 | bool "PL310 errata: no automatic Store Buffer drain" | ||
| 1358 | depends on CACHE_L2X0 | ||
| 1359 | help | ||
| 1360 | On revisions of the PL310 prior to r3p2, the Store Buffer does | ||
| 1361 | not automatically drain. This can cause normal, non-cacheable | ||
| 1362 | writes to be retained when the memory system is idle, leading | ||
| 1363 | to suboptimal I/O performance for drivers using coherent DMA. | ||
| 1364 | This option adds a write barrier to the cpu_idle loop so that, | ||
| 1365 | on systems with an outer cache, the store buffer is drained | ||
| 1366 | explicitly. | ||
| 1367 | |||
| 1355 | endmenu | 1368 | endmenu |
| 1356 | 1369 | ||
| 1357 | source "arch/arm/common/Kconfig" | 1370 | source "arch/arm/common/Kconfig" |
diff --git a/arch/arm/common/gic.c b/arch/arm/common/gic.c index 0e6ae470c94f..410a546060a2 100644 --- a/arch/arm/common/gic.c +++ b/arch/arm/common/gic.c | |||
| @@ -526,7 +526,8 @@ static void __init gic_pm_init(struct gic_chip_data *gic) | |||
| 526 | sizeof(u32)); | 526 | sizeof(u32)); |
| 527 | BUG_ON(!gic->saved_ppi_conf); | 527 | BUG_ON(!gic->saved_ppi_conf); |
| 528 | 528 | ||
| 529 | cpu_pm_register_notifier(&gic_notifier_block); | 529 | if (gic == &gic_data[0]) |
| 530 | cpu_pm_register_notifier(&gic_notifier_block); | ||
| 530 | } | 531 | } |
| 531 | #else | 532 | #else |
| 532 | static void __init gic_pm_init(struct gic_chip_data *gic) | 533 | static void __init gic_pm_init(struct gic_chip_data *gic) |
| @@ -581,13 +582,16 @@ void __init gic_init(unsigned int gic_nr, int irq_start, | |||
| 581 | * For primary GICs, skip over SGIs. | 582 | * For primary GICs, skip over SGIs. |
| 582 | * For secondary GICs, skip over PPIs, too. | 583 | * For secondary GICs, skip over PPIs, too. |
| 583 | */ | 584 | */ |
| 585 | domain->hwirq_base = 32; | ||
| 584 | if (gic_nr == 0) { | 586 | if (gic_nr == 0) { |
| 585 | gic_cpu_base_addr = cpu_base; | 587 | gic_cpu_base_addr = cpu_base; |
| 586 | domain->hwirq_base = 16; | 588 | |
| 587 | if (irq_start > 0) | 589 | if ((irq_start & 31) > 0) { |
| 588 | irq_start = (irq_start & ~31) + 16; | 590 | domain->hwirq_base = 16; |
| 589 | } else | 591 | if (irq_start != -1) |
| 590 | domain->hwirq_base = 32; | 592 | irq_start = (irq_start & ~31) + 16; |
| 593 | } | ||
| 594 | } | ||
| 591 | 595 | ||
| 592 | /* | 596 | /* |
| 593 | * Find out how many interrupts are supported. | 597 | * Find out how many interrupts are supported. |
diff --git a/arch/arm/common/pl330.c b/arch/arm/common/pl330.c index 7129cfbdacd6..f407a6b35d3d 100644 --- a/arch/arm/common/pl330.c +++ b/arch/arm/common/pl330.c | |||
| @@ -1211,8 +1211,8 @@ static inline u32 _prepare_ccr(const struct pl330_reqcfg *rqc) | |||
| 1211 | ccr |= (rqc->brst_size << CC_SRCBRSTSIZE_SHFT); | 1211 | ccr |= (rqc->brst_size << CC_SRCBRSTSIZE_SHFT); |
| 1212 | ccr |= (rqc->brst_size << CC_DSTBRSTSIZE_SHFT); | 1212 | ccr |= (rqc->brst_size << CC_DSTBRSTSIZE_SHFT); |
| 1213 | 1213 | ||
| 1214 | ccr |= (rqc->dcctl << CC_SRCCCTRL_SHFT); | 1214 | ccr |= (rqc->scctl << CC_SRCCCTRL_SHFT); |
| 1215 | ccr |= (rqc->scctl << CC_DSTCCTRL_SHFT); | 1215 | ccr |= (rqc->dcctl << CC_DSTCCTRL_SHFT); |
| 1216 | 1216 | ||
| 1217 | ccr |= (rqc->swap << CC_SWAP_SHFT); | 1217 | ccr |= (rqc->swap << CC_SWAP_SHFT); |
| 1218 | 1218 | ||
| @@ -1623,6 +1623,11 @@ static inline int _alloc_event(struct pl330_thread *thrd) | |||
| 1623 | return -1; | 1623 | return -1; |
| 1624 | } | 1624 | } |
| 1625 | 1625 | ||
| 1626 | static bool _chan_ns(const struct pl330_info *pi, int i) | ||
| 1627 | { | ||
| 1628 | return pi->pcfg.irq_ns & (1 << i); | ||
| 1629 | } | ||
| 1630 | |||
| 1626 | /* Upon success, returns IdentityToken for the | 1631 | /* Upon success, returns IdentityToken for the |
| 1627 | * allocated channel, NULL otherwise. | 1632 | * allocated channel, NULL otherwise. |
| 1628 | */ | 1633 | */ |
| @@ -1647,7 +1652,8 @@ void *pl330_request_channel(const struct pl330_info *pi) | |||
| 1647 | 1652 | ||
| 1648 | for (i = 0; i < chans; i++) { | 1653 | for (i = 0; i < chans; i++) { |
| 1649 | thrd = &pl330->channels[i]; | 1654 | thrd = &pl330->channels[i]; |
| 1650 | if (thrd->free) { | 1655 | if ((thrd->free) && (!_manager_ns(thrd) || |
| 1656 | _chan_ns(pi, i))) { | ||
| 1651 | thrd->ev = _alloc_event(thrd); | 1657 | thrd->ev = _alloc_event(thrd); |
| 1652 | if (thrd->ev >= 0) { | 1658 | if (thrd->ev >= 0) { |
| 1653 | thrd->free = false; | 1659 | thrd->free = false; |
diff --git a/arch/arm/configs/at91cap9adk_defconfig b/arch/arm/configs/at91cap9_defconfig index ffb1edd93363..8826eb218e73 100644 --- a/arch/arm/configs/at91cap9adk_defconfig +++ b/arch/arm/configs/at91cap9_defconfig | |||
| @@ -38,7 +38,6 @@ CONFIG_IP_PNP_RARP=y | |||
| 38 | # CONFIG_IPV6 is not set | 38 | # CONFIG_IPV6 is not set |
| 39 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" | 39 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" |
| 40 | CONFIG_MTD=y | 40 | CONFIG_MTD=y |
| 41 | CONFIG_MTD_PARTITIONS=y | ||
| 42 | CONFIG_MTD_CMDLINE_PARTS=y | 41 | CONFIG_MTD_CMDLINE_PARTS=y |
| 43 | CONFIG_MTD_CHAR=y | 42 | CONFIG_MTD_CHAR=y |
| 44 | CONFIG_MTD_BLOCK=y | 43 | CONFIG_MTD_BLOCK=y |
| @@ -52,16 +51,12 @@ CONFIG_MTD_NAND_ATMEL=y | |||
| 52 | CONFIG_BLK_DEV_LOOP=y | 51 | CONFIG_BLK_DEV_LOOP=y |
| 53 | CONFIG_BLK_DEV_RAM=y | 52 | CONFIG_BLK_DEV_RAM=y |
| 54 | CONFIG_BLK_DEV_RAM_SIZE=8192 | 53 | CONFIG_BLK_DEV_RAM_SIZE=8192 |
| 55 | CONFIG_ATMEL_SSC=y | ||
| 56 | CONFIG_SCSI=y | 54 | CONFIG_SCSI=y |
| 57 | CONFIG_BLK_DEV_SD=y | 55 | CONFIG_BLK_DEV_SD=y |
| 58 | CONFIG_SCSI_MULTI_LUN=y | 56 | CONFIG_SCSI_MULTI_LUN=y |
| 59 | CONFIG_NETDEVICES=y | 57 | CONFIG_NETDEVICES=y |
| 60 | CONFIG_NET_ETHERNET=y | ||
| 61 | CONFIG_MII=y | 58 | CONFIG_MII=y |
| 62 | CONFIG_MACB=y | 59 | CONFIG_MACB=y |
| 63 | # CONFIG_NETDEV_1000 is not set | ||
| 64 | # CONFIG_NETDEV_10000 is not set | ||
| 65 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set | 60 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set |
| 66 | CONFIG_INPUT_EVDEV=y | 61 | CONFIG_INPUT_EVDEV=y |
| 67 | # CONFIG_INPUT_KEYBOARD is not set | 62 | # CONFIG_INPUT_KEYBOARD is not set |
| @@ -81,7 +76,6 @@ CONFIG_WATCHDOG=y | |||
| 81 | CONFIG_WATCHDOG_NOWAYOUT=y | 76 | CONFIG_WATCHDOG_NOWAYOUT=y |
| 82 | CONFIG_FB=y | 77 | CONFIG_FB=y |
| 83 | CONFIG_FB_ATMEL=y | 78 | CONFIG_FB_ATMEL=y |
| 84 | # CONFIG_VGA_CONSOLE is not set | ||
| 85 | CONFIG_LOGO=y | 79 | CONFIG_LOGO=y |
| 86 | # CONFIG_LOGO_LINUX_MONO is not set | 80 | # CONFIG_LOGO_LINUX_MONO is not set |
| 87 | # CONFIG_LOGO_LINUX_CLUT224 is not set | 81 | # CONFIG_LOGO_LINUX_CLUT224 is not set |
| @@ -99,7 +93,6 @@ CONFIG_MMC_AT91=m | |||
| 99 | CONFIG_RTC_CLASS=y | 93 | CONFIG_RTC_CLASS=y |
| 100 | CONFIG_RTC_DRV_AT91SAM9=y | 94 | CONFIG_RTC_DRV_AT91SAM9=y |
| 101 | CONFIG_EXT2_FS=y | 95 | CONFIG_EXT2_FS=y |
| 102 | CONFIG_INOTIFY=y | ||
| 103 | CONFIG_VFAT_FS=y | 96 | CONFIG_VFAT_FS=y |
| 104 | CONFIG_TMPFS=y | 97 | CONFIG_TMPFS=y |
| 105 | CONFIG_JFFS2_FS=y | 98 | CONFIG_JFFS2_FS=y |
diff --git a/arch/arm/configs/at91rm9200_defconfig b/arch/arm/configs/at91rm9200_defconfig index 38cb7c985426..bbe4e1a1f5d8 100644 --- a/arch/arm/configs/at91rm9200_defconfig +++ b/arch/arm/configs/at91rm9200_defconfig | |||
| @@ -5,7 +5,6 @@ CONFIG_SYSVIPC=y | |||
| 5 | CONFIG_IKCONFIG=y | 5 | CONFIG_IKCONFIG=y |
| 6 | CONFIG_IKCONFIG_PROC=y | 6 | CONFIG_IKCONFIG_PROC=y |
| 7 | CONFIG_LOG_BUF_SHIFT=14 | 7 | CONFIG_LOG_BUF_SHIFT=14 |
| 8 | CONFIG_SYSFS_DEPRECATED_V2=y | ||
| 9 | CONFIG_BLK_DEV_INITRD=y | 8 | CONFIG_BLK_DEV_INITRD=y |
| 10 | CONFIG_MODULES=y | 9 | CONFIG_MODULES=y |
| 11 | CONFIG_MODULE_FORCE_LOAD=y | 10 | CONFIG_MODULE_FORCE_LOAD=y |
| @@ -56,7 +55,6 @@ CONFIG_IP_PNP=y | |||
| 56 | CONFIG_IP_PNP_DHCP=y | 55 | CONFIG_IP_PNP_DHCP=y |
| 57 | CONFIG_IP_PNP_BOOTP=y | 56 | CONFIG_IP_PNP_BOOTP=y |
| 58 | CONFIG_NET_IPIP=m | 57 | CONFIG_NET_IPIP=m |
| 59 | CONFIG_NET_IPGRE=m | ||
| 60 | CONFIG_INET_AH=m | 58 | CONFIG_INET_AH=m |
| 61 | CONFIG_INET_ESP=m | 59 | CONFIG_INET_ESP=m |
| 62 | CONFIG_INET_IPCOMP=m | 60 | CONFIG_INET_IPCOMP=m |
| @@ -75,18 +73,8 @@ CONFIG_IPV6_TUNNEL=m | |||
| 75 | CONFIG_BRIDGE=m | 73 | CONFIG_BRIDGE=m |
| 76 | CONFIG_VLAN_8021Q=m | 74 | CONFIG_VLAN_8021Q=m |
| 77 | CONFIG_BT=m | 75 | CONFIG_BT=m |
| 78 | CONFIG_BT_L2CAP=m | ||
| 79 | CONFIG_BT_SCO=m | ||
| 80 | CONFIG_BT_RFCOMM=m | ||
| 81 | CONFIG_BT_RFCOMM_TTY=y | ||
| 82 | CONFIG_BT_BNEP=m | ||
| 83 | CONFIG_BT_BNEP_MC_FILTER=y | ||
| 84 | CONFIG_BT_BNEP_PROTO_FILTER=y | ||
| 85 | CONFIG_BT_HIDP=m | ||
| 86 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" | 76 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" |
| 87 | CONFIG_MTD=y | 77 | CONFIG_MTD=y |
| 88 | CONFIG_MTD_CONCAT=y | ||
| 89 | CONFIG_MTD_PARTITIONS=y | ||
| 90 | CONFIG_MTD_CMDLINE_PARTS=y | 78 | CONFIG_MTD_CMDLINE_PARTS=y |
| 91 | CONFIG_MTD_AFS_PARTS=y | 79 | CONFIG_MTD_AFS_PARTS=y |
| 92 | CONFIG_MTD_CHAR=y | 80 | CONFIG_MTD_CHAR=y |
| @@ -108,8 +96,6 @@ CONFIG_BLK_DEV_LOOP=y | |||
| 108 | CONFIG_BLK_DEV_NBD=y | 96 | CONFIG_BLK_DEV_NBD=y |
| 109 | CONFIG_BLK_DEV_RAM=y | 97 | CONFIG_BLK_DEV_RAM=y |
| 110 | CONFIG_BLK_DEV_RAM_SIZE=8192 | 98 | CONFIG_BLK_DEV_RAM_SIZE=8192 |
| 111 | CONFIG_ATMEL_TCLIB=y | ||
| 112 | CONFIG_EEPROM_LEGACY=m | ||
| 113 | CONFIG_SCSI=y | 99 | CONFIG_SCSI=y |
| 114 | CONFIG_BLK_DEV_SD=y | 100 | CONFIG_BLK_DEV_SD=y |
| 115 | CONFIG_BLK_DEV_SR=m | 101 | CONFIG_BLK_DEV_SR=m |
| @@ -119,14 +105,23 @@ CONFIG_SCSI_MULTI_LUN=y | |||
| 119 | # CONFIG_SCSI_LOWLEVEL is not set | 105 | # CONFIG_SCSI_LOWLEVEL is not set |
| 120 | CONFIG_NETDEVICES=y | 106 | CONFIG_NETDEVICES=y |
| 121 | CONFIG_TUN=m | 107 | CONFIG_TUN=m |
| 108 | CONFIG_ARM_AT91_ETHER=y | ||
| 122 | CONFIG_PHYLIB=y | 109 | CONFIG_PHYLIB=y |
| 123 | CONFIG_DAVICOM_PHY=y | 110 | CONFIG_DAVICOM_PHY=y |
| 124 | CONFIG_SMSC_PHY=y | 111 | CONFIG_SMSC_PHY=y |
| 125 | CONFIG_MICREL_PHY=y | 112 | CONFIG_MICREL_PHY=y |
| 126 | CONFIG_NET_ETHERNET=y | 113 | CONFIG_PPP=y |
| 127 | CONFIG_ARM_AT91_ETHER=y | 114 | CONFIG_PPP_BSDCOMP=y |
| 128 | # CONFIG_NETDEV_1000 is not set | 115 | CONFIG_PPP_DEFLATE=y |
| 129 | # CONFIG_NETDEV_10000 is not set | 116 | CONFIG_PPP_FILTER=y |
| 117 | CONFIG_PPP_MPPE=m | ||
| 118 | CONFIG_PPP_MULTILINK=y | ||
| 119 | CONFIG_PPPOE=m | ||
| 120 | CONFIG_PPP_ASYNC=y | ||
| 121 | CONFIG_SLIP=m | ||
| 122 | CONFIG_SLIP_COMPRESSED=y | ||
| 123 | CONFIG_SLIP_SMART=y | ||
| 124 | CONFIG_SLIP_MODE_SLIP6=y | ||
| 130 | CONFIG_USB_CATC=m | 125 | CONFIG_USB_CATC=m |
| 131 | CONFIG_USB_KAWETH=m | 126 | CONFIG_USB_KAWETH=m |
| 132 | CONFIG_USB_PEGASUS=m | 127 | CONFIG_USB_PEGASUS=m |
| @@ -139,18 +134,6 @@ CONFIG_USB_NET_RNDIS_HOST=m | |||
| 139 | CONFIG_USB_ALI_M5632=y | 134 | CONFIG_USB_ALI_M5632=y |
| 140 | CONFIG_USB_AN2720=y | 135 | CONFIG_USB_AN2720=y |
| 141 | CONFIG_USB_EPSON2888=y | 136 | CONFIG_USB_EPSON2888=y |
| 142 | CONFIG_PPP=y | ||
| 143 | CONFIG_PPP_MULTILINK=y | ||
| 144 | CONFIG_PPP_FILTER=y | ||
| 145 | CONFIG_PPP_ASYNC=y | ||
| 146 | CONFIG_PPP_DEFLATE=y | ||
| 147 | CONFIG_PPP_BSDCOMP=y | ||
| 148 | CONFIG_PPP_MPPE=m | ||
| 149 | CONFIG_PPPOE=m | ||
| 150 | CONFIG_SLIP=m | ||
| 151 | CONFIG_SLIP_COMPRESSED=y | ||
| 152 | CONFIG_SLIP_SMART=y | ||
| 153 | CONFIG_SLIP_MODE_SLIP6=y | ||
| 154 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set | 137 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set |
| 155 | CONFIG_INPUT_MOUSEDEV_SCREEN_X=640 | 138 | CONFIG_INPUT_MOUSEDEV_SCREEN_X=640 |
| 156 | CONFIG_INPUT_MOUSEDEV_SCREEN_Y=480 | 139 | CONFIG_INPUT_MOUSEDEV_SCREEN_Y=480 |
| @@ -158,9 +141,9 @@ CONFIG_INPUT_EVDEV=y | |||
| 158 | CONFIG_KEYBOARD_GPIO=y | 141 | CONFIG_KEYBOARD_GPIO=y |
| 159 | # CONFIG_INPUT_MOUSE is not set | 142 | # CONFIG_INPUT_MOUSE is not set |
| 160 | CONFIG_INPUT_TOUCHSCREEN=y | 143 | CONFIG_INPUT_TOUCHSCREEN=y |
| 144 | CONFIG_LEGACY_PTY_COUNT=32 | ||
| 161 | CONFIG_SERIAL_ATMEL=y | 145 | CONFIG_SERIAL_ATMEL=y |
| 162 | CONFIG_SERIAL_ATMEL_CONSOLE=y | 146 | CONFIG_SERIAL_ATMEL_CONSOLE=y |
| 163 | CONFIG_LEGACY_PTY_COUNT=32 | ||
| 164 | CONFIG_HW_RANDOM=y | 147 | CONFIG_HW_RANDOM=y |
| 165 | CONFIG_I2C=y | 148 | CONFIG_I2C=y |
| 166 | CONFIG_I2C_CHARDEV=y | 149 | CONFIG_I2C_CHARDEV=y |
| @@ -290,7 +273,6 @@ CONFIG_NFS_V3_ACL=y | |||
| 290 | CONFIG_NFS_V4=y | 273 | CONFIG_NFS_V4=y |
| 291 | CONFIG_ROOT_NFS=y | 274 | CONFIG_ROOT_NFS=y |
| 292 | CONFIG_NFSD=y | 275 | CONFIG_NFSD=y |
| 293 | CONFIG_SMB_FS=m | ||
| 294 | CONFIG_CIFS=m | 276 | CONFIG_CIFS=m |
| 295 | CONFIG_PARTITION_ADVANCED=y | 277 | CONFIG_PARTITION_ADVANCED=y |
| 296 | CONFIG_MAC_PARTITION=y | 278 | CONFIG_MAC_PARTITION=y |
| @@ -335,7 +317,6 @@ CONFIG_NLS_UTF8=y | |||
| 335 | CONFIG_MAGIC_SYSRQ=y | 317 | CONFIG_MAGIC_SYSRQ=y |
| 336 | CONFIG_DEBUG_FS=y | 318 | CONFIG_DEBUG_FS=y |
| 337 | CONFIG_DEBUG_KERNEL=y | 319 | CONFIG_DEBUG_KERNEL=y |
| 338 | # CONFIG_RCU_CPU_STALL_DETECTOR is not set | ||
| 339 | # CONFIG_FTRACE is not set | 320 | # CONFIG_FTRACE is not set |
| 340 | CONFIG_CRYPTO_PCBC=y | 321 | CONFIG_CRYPTO_PCBC=y |
| 341 | CONFIG_CRYPTO_SHA1=y | 322 | CONFIG_CRYPTO_SHA1=y |
diff --git a/arch/arm/configs/at91sam9260ek_defconfig b/arch/arm/configs/at91sam9260_defconfig index f8a9226413bf..505b3765f87e 100644 --- a/arch/arm/configs/at91sam9260ek_defconfig +++ b/arch/arm/configs/at91sam9260_defconfig | |||
| @@ -12,11 +12,23 @@ CONFIG_MODULE_UNLOAD=y | |||
| 12 | # CONFIG_IOSCHED_CFQ is not set | 12 | # CONFIG_IOSCHED_CFQ is not set |
| 13 | CONFIG_ARCH_AT91=y | 13 | CONFIG_ARCH_AT91=y |
| 14 | CONFIG_ARCH_AT91SAM9260=y | 14 | CONFIG_ARCH_AT91SAM9260=y |
| 15 | CONFIG_ARCH_AT91SAM9260_SAM9XE=y | ||
| 15 | CONFIG_MACH_AT91SAM9260EK=y | 16 | CONFIG_MACH_AT91SAM9260EK=y |
| 17 | CONFIG_MACH_CAM60=y | ||
| 18 | CONFIG_MACH_SAM9_L9260=y | ||
| 19 | CONFIG_MACH_AFEB9260=y | ||
| 20 | CONFIG_MACH_USB_A9260=y | ||
| 21 | CONFIG_MACH_QIL_A9260=y | ||
| 22 | CONFIG_MACH_CPU9260=y | ||
| 23 | CONFIG_MACH_FLEXIBITY=y | ||
| 24 | CONFIG_MACH_SNAPPER_9260=y | ||
| 25 | CONFIG_MACH_AT91SAM_DT=y | ||
| 16 | CONFIG_AT91_PROGRAMMABLE_CLOCKS=y | 26 | CONFIG_AT91_PROGRAMMABLE_CLOCKS=y |
| 17 | # CONFIG_ARM_THUMB is not set | 27 | # CONFIG_ARM_THUMB is not set |
| 18 | CONFIG_ZBOOT_ROM_TEXT=0x0 | 28 | CONFIG_ZBOOT_ROM_TEXT=0x0 |
| 19 | CONFIG_ZBOOT_ROM_BSS=0x0 | 29 | CONFIG_ZBOOT_ROM_BSS=0x0 |
| 30 | CONFIG_ARM_APPENDED_DTB=y | ||
| 31 | CONFIG_ARM_ATAG_DTB_COMPAT=y | ||
| 20 | CONFIG_CMDLINE="mem=64M console=ttyS0,115200 initrd=0x21100000,3145728 root=/dev/ram0 rw" | 32 | CONFIG_CMDLINE="mem=64M console=ttyS0,115200 initrd=0x21100000,3145728 root=/dev/ram0 rw" |
| 21 | CONFIG_FPE_NWFPE=y | 33 | CONFIG_FPE_NWFPE=y |
| 22 | CONFIG_NET=y | 34 | CONFIG_NET=y |
| @@ -33,12 +45,10 @@ CONFIG_IP_PNP_BOOTP=y | |||
| 33 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" | 45 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" |
| 34 | CONFIG_BLK_DEV_RAM=y | 46 | CONFIG_BLK_DEV_RAM=y |
| 35 | CONFIG_BLK_DEV_RAM_SIZE=8192 | 47 | CONFIG_BLK_DEV_RAM_SIZE=8192 |
| 36 | CONFIG_ATMEL_SSC=y | ||
| 37 | CONFIG_SCSI=y | 48 | CONFIG_SCSI=y |
| 38 | CONFIG_BLK_DEV_SD=y | 49 | CONFIG_BLK_DEV_SD=y |
| 39 | CONFIG_SCSI_MULTI_LUN=y | 50 | CONFIG_SCSI_MULTI_LUN=y |
| 40 | CONFIG_NETDEVICES=y | 51 | CONFIG_NETDEVICES=y |
| 41 | CONFIG_NET_ETHERNET=y | ||
| 42 | CONFIG_MII=y | 52 | CONFIG_MII=y |
| 43 | CONFIG_MACB=y | 53 | CONFIG_MACB=y |
| 44 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set | 54 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set |
| @@ -55,7 +65,6 @@ CONFIG_I2C_GPIO=y | |||
| 55 | CONFIG_WATCHDOG=y | 65 | CONFIG_WATCHDOG=y |
| 56 | CONFIG_WATCHDOG_NOWAYOUT=y | 66 | CONFIG_WATCHDOG_NOWAYOUT=y |
| 57 | CONFIG_AT91SAM9X_WATCHDOG=y | 67 | CONFIG_AT91SAM9X_WATCHDOG=y |
| 58 | # CONFIG_VGA_CONSOLE is not set | ||
| 59 | # CONFIG_USB_HID is not set | 68 | # CONFIG_USB_HID is not set |
| 60 | CONFIG_USB=y | 69 | CONFIG_USB=y |
| 61 | CONFIG_USB_DEVICEFS=y | 70 | CONFIG_USB_DEVICEFS=y |
| @@ -71,7 +80,6 @@ CONFIG_USB_G_SERIAL=m | |||
| 71 | CONFIG_RTC_CLASS=y | 80 | CONFIG_RTC_CLASS=y |
| 72 | CONFIG_RTC_DRV_AT91SAM9=y | 81 | CONFIG_RTC_DRV_AT91SAM9=y |
| 73 | CONFIG_EXT2_FS=y | 82 | CONFIG_EXT2_FS=y |
| 74 | CONFIG_INOTIFY=y | ||
| 75 | CONFIG_VFAT_FS=y | 83 | CONFIG_VFAT_FS=y |
| 76 | CONFIG_TMPFS=y | 84 | CONFIG_TMPFS=y |
| 77 | CONFIG_CRAMFS=y | 85 | CONFIG_CRAMFS=y |
diff --git a/arch/arm/configs/at91sam9g20ek_defconfig b/arch/arm/configs/at91sam9g20_defconfig index 9e90e6d79297..9123568d9a8d 100644 --- a/arch/arm/configs/at91sam9g20ek_defconfig +++ b/arch/arm/configs/at91sam9g20_defconfig | |||
| @@ -14,6 +14,15 @@ CONFIG_ARCH_AT91=y | |||
| 14 | CONFIG_ARCH_AT91SAM9G20=y | 14 | CONFIG_ARCH_AT91SAM9G20=y |
| 15 | CONFIG_MACH_AT91SAM9G20EK=y | 15 | CONFIG_MACH_AT91SAM9G20EK=y |
| 16 | CONFIG_MACH_AT91SAM9G20EK_2MMC=y | 16 | CONFIG_MACH_AT91SAM9G20EK_2MMC=y |
| 17 | CONFIG_MACH_CPU9G20=y | ||
| 18 | CONFIG_MACH_ACMENETUSFOXG20=y | ||
| 19 | CONFIG_MACH_PORTUXG20=y | ||
| 20 | CONFIG_MACH_STAMP9G20=y | ||
| 21 | CONFIG_MACH_PCONTROL_G20=y | ||
| 22 | CONFIG_MACH_GSIA18S=y | ||
| 23 | CONFIG_MACH_USB_A9G20=y | ||
| 24 | CONFIG_MACH_SNAPPER_9260=y | ||
| 25 | CONFIG_MACH_AT91SAM_DT=y | ||
| 17 | CONFIG_AT91_PROGRAMMABLE_CLOCKS=y | 26 | CONFIG_AT91_PROGRAMMABLE_CLOCKS=y |
| 18 | # CONFIG_ARM_THUMB is not set | 27 | # CONFIG_ARM_THUMB is not set |
| 19 | CONFIG_AEABI=y | 28 | CONFIG_AEABI=y |
| @@ -21,9 +30,10 @@ CONFIG_LEDS=y | |||
| 21 | CONFIG_LEDS_CPU=y | 30 | CONFIG_LEDS_CPU=y |
| 22 | CONFIG_ZBOOT_ROM_TEXT=0x0 | 31 | CONFIG_ZBOOT_ROM_TEXT=0x0 |
| 23 | CONFIG_ZBOOT_ROM_BSS=0x0 | 32 | CONFIG_ZBOOT_ROM_BSS=0x0 |
| 33 | CONFIG_ARM_APPENDED_DTB=y | ||
| 34 | CONFIG_ARM_ATAG_DTB_COMPAT=y | ||
| 24 | CONFIG_CMDLINE="mem=64M console=ttyS0,115200 initrd=0x21100000,3145728 root=/dev/ram0 rw" | 35 | CONFIG_CMDLINE="mem=64M console=ttyS0,115200 initrd=0x21100000,3145728 root=/dev/ram0 rw" |
| 25 | CONFIG_FPE_NWFPE=y | 36 | CONFIG_FPE_NWFPE=y |
| 26 | CONFIG_PM=y | ||
| 27 | CONFIG_NET=y | 37 | CONFIG_NET=y |
| 28 | CONFIG_PACKET=y | 38 | CONFIG_PACKET=y |
| 29 | CONFIG_UNIX=y | 39 | CONFIG_UNIX=y |
| @@ -37,8 +47,6 @@ CONFIG_IP_PNP_BOOTP=y | |||
| 37 | # CONFIG_IPV6 is not set | 47 | # CONFIG_IPV6 is not set |
| 38 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" | 48 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" |
| 39 | CONFIG_MTD=y | 49 | CONFIG_MTD=y |
| 40 | CONFIG_MTD_CONCAT=y | ||
| 41 | CONFIG_MTD_PARTITIONS=y | ||
| 42 | CONFIG_MTD_CMDLINE_PARTS=y | 50 | CONFIG_MTD_CMDLINE_PARTS=y |
| 43 | CONFIG_MTD_CHAR=y | 51 | CONFIG_MTD_CHAR=y |
| 44 | CONFIG_MTD_BLOCK=y | 52 | CONFIG_MTD_BLOCK=y |
| @@ -48,17 +56,13 @@ CONFIG_MTD_NAND_ATMEL=y | |||
| 48 | CONFIG_BLK_DEV_LOOP=y | 56 | CONFIG_BLK_DEV_LOOP=y |
| 49 | CONFIG_BLK_DEV_RAM=y | 57 | CONFIG_BLK_DEV_RAM=y |
| 50 | CONFIG_BLK_DEV_RAM_SIZE=8192 | 58 | CONFIG_BLK_DEV_RAM_SIZE=8192 |
| 51 | CONFIG_ATMEL_SSC=y | ||
| 52 | CONFIG_SCSI=y | 59 | CONFIG_SCSI=y |
| 53 | CONFIG_BLK_DEV_SD=y | 60 | CONFIG_BLK_DEV_SD=y |
| 54 | CONFIG_SCSI_MULTI_LUN=y | 61 | CONFIG_SCSI_MULTI_LUN=y |
| 55 | # CONFIG_SCSI_LOWLEVEL is not set | 62 | # CONFIG_SCSI_LOWLEVEL is not set |
| 56 | CONFIG_NETDEVICES=y | 63 | CONFIG_NETDEVICES=y |
| 57 | CONFIG_NET_ETHERNET=y | ||
| 58 | CONFIG_MII=y | 64 | CONFIG_MII=y |
| 59 | CONFIG_MACB=y | 65 | CONFIG_MACB=y |
| 60 | # CONFIG_NETDEV_1000 is not set | ||
| 61 | # CONFIG_NETDEV_10000 is not set | ||
| 62 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set | 66 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set |
| 63 | CONFIG_INPUT_MOUSEDEV_SCREEN_X=320 | 67 | CONFIG_INPUT_MOUSEDEV_SCREEN_X=320 |
| 64 | CONFIG_INPUT_MOUSEDEV_SCREEN_Y=240 | 68 | CONFIG_INPUT_MOUSEDEV_SCREEN_Y=240 |
| @@ -66,15 +70,14 @@ CONFIG_INPUT_EVDEV=y | |||
| 66 | # CONFIG_KEYBOARD_ATKBD is not set | 70 | # CONFIG_KEYBOARD_ATKBD is not set |
| 67 | CONFIG_KEYBOARD_GPIO=y | 71 | CONFIG_KEYBOARD_GPIO=y |
| 68 | # CONFIG_INPUT_MOUSE is not set | 72 | # CONFIG_INPUT_MOUSE is not set |
| 73 | CONFIG_LEGACY_PTY_COUNT=16 | ||
| 69 | CONFIG_SERIAL_ATMEL=y | 74 | CONFIG_SERIAL_ATMEL=y |
| 70 | CONFIG_SERIAL_ATMEL_CONSOLE=y | 75 | CONFIG_SERIAL_ATMEL_CONSOLE=y |
| 71 | CONFIG_LEGACY_PTY_COUNT=16 | ||
| 72 | CONFIG_HW_RANDOM=y | 76 | CONFIG_HW_RANDOM=y |
| 73 | CONFIG_SPI=y | 77 | CONFIG_SPI=y |
| 74 | CONFIG_SPI_ATMEL=y | 78 | CONFIG_SPI_ATMEL=y |
| 75 | CONFIG_SPI_SPIDEV=y | 79 | CONFIG_SPI_SPIDEV=y |
| 76 | # CONFIG_HWMON is not set | 80 | # CONFIG_HWMON is not set |
| 77 | # CONFIG_VGA_CONSOLE is not set | ||
| 78 | CONFIG_SOUND=y | 81 | CONFIG_SOUND=y |
| 79 | CONFIG_SND=y | 82 | CONFIG_SND=y |
| 80 | CONFIG_SND_SEQUENCER=y | 83 | CONFIG_SND_SEQUENCER=y |
| @@ -82,7 +85,6 @@ CONFIG_SND_MIXER_OSS=y | |||
| 82 | CONFIG_SND_PCM_OSS=y | 85 | CONFIG_SND_PCM_OSS=y |
| 83 | CONFIG_SND_SEQUENCER_OSS=y | 86 | CONFIG_SND_SEQUENCER_OSS=y |
| 84 | # CONFIG_SND_VERBOSE_PROCFS is not set | 87 | # CONFIG_SND_VERBOSE_PROCFS is not set |
| 85 | CONFIG_SND_AT73C213=y | ||
| 86 | CONFIG_USB=y | 88 | CONFIG_USB=y |
| 87 | CONFIG_USB_DEVICEFS=y | 89 | CONFIG_USB_DEVICEFS=y |
| 88 | # CONFIG_USB_DEVICE_CLASS is not set | 90 | # CONFIG_USB_DEVICE_CLASS is not set |
| @@ -105,7 +107,6 @@ CONFIG_LEDS_TRIGGER_HEARTBEAT=y | |||
| 105 | CONFIG_RTC_CLASS=y | 107 | CONFIG_RTC_CLASS=y |
| 106 | CONFIG_RTC_DRV_AT91SAM9=y | 108 | CONFIG_RTC_DRV_AT91SAM9=y |
| 107 | CONFIG_EXT2_FS=y | 109 | CONFIG_EXT2_FS=y |
| 108 | CONFIG_INOTIFY=y | ||
| 109 | CONFIG_MSDOS_FS=y | 110 | CONFIG_MSDOS_FS=y |
| 110 | CONFIG_VFAT_FS=y | 111 | CONFIG_VFAT_FS=y |
| 111 | CONFIG_TMPFS=y | 112 | CONFIG_TMPFS=y |
diff --git a/arch/arm/configs/at91sam9g45_defconfig b/arch/arm/configs/at91sam9g45_defconfig index c5876d244f4b..606d48f3b8f8 100644 --- a/arch/arm/configs/at91sam9g45_defconfig +++ b/arch/arm/configs/at91sam9g45_defconfig | |||
| @@ -18,6 +18,7 @@ CONFIG_MODULE_UNLOAD=y | |||
| 18 | CONFIG_ARCH_AT91=y | 18 | CONFIG_ARCH_AT91=y |
| 19 | CONFIG_ARCH_AT91SAM9G45=y | 19 | CONFIG_ARCH_AT91SAM9G45=y |
| 20 | CONFIG_MACH_AT91SAM9M10G45EK=y | 20 | CONFIG_MACH_AT91SAM9M10G45EK=y |
| 21 | CONFIG_MACH_AT91SAM_DT=y | ||
| 21 | CONFIG_AT91_PROGRAMMABLE_CLOCKS=y | 22 | CONFIG_AT91_PROGRAMMABLE_CLOCKS=y |
| 22 | CONFIG_AT91_SLOW_CLOCK=y | 23 | CONFIG_AT91_SLOW_CLOCK=y |
| 23 | CONFIG_AEABI=y | 24 | CONFIG_AEABI=y |
| @@ -73,11 +74,8 @@ CONFIG_SCSI_MULTI_LUN=y | |||
| 73 | # CONFIG_SCSI_LOWLEVEL is not set | 74 | # CONFIG_SCSI_LOWLEVEL is not set |
| 74 | CONFIG_NETDEVICES=y | 75 | CONFIG_NETDEVICES=y |
| 75 | CONFIG_MII=y | 76 | CONFIG_MII=y |
| 76 | CONFIG_DAVICOM_PHY=y | ||
| 77 | CONFIG_NET_ETHERNET=y | ||
| 78 | CONFIG_MACB=y | 77 | CONFIG_MACB=y |
| 79 | # CONFIG_NETDEV_1000 is not set | 78 | CONFIG_DAVICOM_PHY=y |
| 80 | # CONFIG_NETDEV_10000 is not set | ||
| 81 | CONFIG_LIBERTAS_THINFIRM=m | 79 | CONFIG_LIBERTAS_THINFIRM=m |
| 82 | CONFIG_LIBERTAS_THINFIRM_USB=m | 80 | CONFIG_LIBERTAS_THINFIRM_USB=m |
| 83 | CONFIG_AT76C50X_USB=m | 81 | CONFIG_AT76C50X_USB=m |
| @@ -131,7 +129,6 @@ CONFIG_I2C_GPIO=y | |||
| 131 | CONFIG_SPI=y | 129 | CONFIG_SPI=y |
| 132 | CONFIG_SPI_ATMEL=y | 130 | CONFIG_SPI_ATMEL=y |
| 133 | # CONFIG_HWMON is not set | 131 | # CONFIG_HWMON is not set |
| 134 | # CONFIG_MFD_SUPPORT is not set | ||
| 135 | CONFIG_FB=y | 132 | CONFIG_FB=y |
| 136 | CONFIG_FB_ATMEL=y | 133 | CONFIG_FB_ATMEL=y |
| 137 | CONFIG_FB_UDL=m | 134 | CONFIG_FB_UDL=m |
diff --git a/arch/arm/configs/at91sam9rlek_defconfig b/arch/arm/configs/at91sam9rl_defconfig index 75621e4d03fc..ad562ee64209 100644 --- a/arch/arm/configs/at91sam9rlek_defconfig +++ b/arch/arm/configs/at91sam9rl_defconfig | |||
| @@ -23,8 +23,6 @@ CONFIG_NET=y | |||
| 23 | CONFIG_UNIX=y | 23 | CONFIG_UNIX=y |
| 24 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" | 24 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" |
| 25 | CONFIG_MTD=y | 25 | CONFIG_MTD=y |
| 26 | CONFIG_MTD_CONCAT=y | ||
| 27 | CONFIG_MTD_PARTITIONS=y | ||
| 28 | CONFIG_MTD_CMDLINE_PARTS=y | 26 | CONFIG_MTD_CMDLINE_PARTS=y |
| 29 | CONFIG_MTD_CHAR=y | 27 | CONFIG_MTD_CHAR=y |
| 30 | CONFIG_MTD_BLOCK=y | 28 | CONFIG_MTD_BLOCK=y |
| @@ -35,7 +33,6 @@ CONFIG_BLK_DEV_LOOP=y | |||
| 35 | CONFIG_BLK_DEV_RAM=y | 33 | CONFIG_BLK_DEV_RAM=y |
| 36 | CONFIG_BLK_DEV_RAM_COUNT=4 | 34 | CONFIG_BLK_DEV_RAM_COUNT=4 |
| 37 | CONFIG_BLK_DEV_RAM_SIZE=24576 | 35 | CONFIG_BLK_DEV_RAM_SIZE=24576 |
| 38 | CONFIG_ATMEL_SSC=y | ||
| 39 | CONFIG_SCSI=y | 36 | CONFIG_SCSI=y |
| 40 | CONFIG_BLK_DEV_SD=y | 37 | CONFIG_BLK_DEV_SD=y |
| 41 | CONFIG_SCSI_MULTI_LUN=y | 38 | CONFIG_SCSI_MULTI_LUN=y |
| @@ -62,13 +59,11 @@ CONFIG_WATCHDOG_NOWAYOUT=y | |||
| 62 | CONFIG_AT91SAM9X_WATCHDOG=y | 59 | CONFIG_AT91SAM9X_WATCHDOG=y |
| 63 | CONFIG_FB=y | 60 | CONFIG_FB=y |
| 64 | CONFIG_FB_ATMEL=y | 61 | CONFIG_FB_ATMEL=y |
| 65 | # CONFIG_VGA_CONSOLE is not set | ||
| 66 | CONFIG_MMC=y | 62 | CONFIG_MMC=y |
| 67 | CONFIG_MMC_AT91=m | 63 | CONFIG_MMC_AT91=m |
| 68 | CONFIG_RTC_CLASS=y | 64 | CONFIG_RTC_CLASS=y |
| 69 | CONFIG_RTC_DRV_AT91SAM9=y | 65 | CONFIG_RTC_DRV_AT91SAM9=y |
| 70 | CONFIG_EXT2_FS=y | 66 | CONFIG_EXT2_FS=y |
| 71 | CONFIG_INOTIFY=y | ||
| 72 | CONFIG_MSDOS_FS=y | 67 | CONFIG_MSDOS_FS=y |
| 73 | CONFIG_VFAT_FS=y | 68 | CONFIG_VFAT_FS=y |
| 74 | CONFIG_TMPFS=y | 69 | CONFIG_TMPFS=y |
diff --git a/arch/arm/configs/ezx_defconfig b/arch/arm/configs/ezx_defconfig index 227a477346ed..d95763d5f0d8 100644 --- a/arch/arm/configs/ezx_defconfig +++ b/arch/arm/configs/ezx_defconfig | |||
| @@ -287,7 +287,7 @@ CONFIG_USB=y | |||
| 287 | # CONFIG_USB_DEVICE_CLASS is not set | 287 | # CONFIG_USB_DEVICE_CLASS is not set |
| 288 | CONFIG_USB_OHCI_HCD=y | 288 | CONFIG_USB_OHCI_HCD=y |
| 289 | CONFIG_USB_GADGET=y | 289 | CONFIG_USB_GADGET=y |
| 290 | CONFIG_USB_GADGET_PXA27X=y | 290 | CONFIG_USB_PXA27X=y |
| 291 | CONFIG_USB_ETH=m | 291 | CONFIG_USB_ETH=m |
| 292 | # CONFIG_USB_ETH_RNDIS is not set | 292 | # CONFIG_USB_ETH_RNDIS is not set |
| 293 | CONFIG_MMC=y | 293 | CONFIG_MMC=y |
diff --git a/arch/arm/configs/imote2_defconfig b/arch/arm/configs/imote2_defconfig index 176ec22af034..fd996bb13022 100644 --- a/arch/arm/configs/imote2_defconfig +++ b/arch/arm/configs/imote2_defconfig | |||
| @@ -263,7 +263,7 @@ CONFIG_USB=y | |||
| 263 | # CONFIG_USB_DEVICE_CLASS is not set | 263 | # CONFIG_USB_DEVICE_CLASS is not set |
| 264 | CONFIG_USB_OHCI_HCD=y | 264 | CONFIG_USB_OHCI_HCD=y |
| 265 | CONFIG_USB_GADGET=y | 265 | CONFIG_USB_GADGET=y |
| 266 | CONFIG_USB_GADGET_PXA27X=y | 266 | CONFIG_USB_PXA27X=y |
| 267 | CONFIG_USB_ETH=m | 267 | CONFIG_USB_ETH=m |
| 268 | # CONFIG_USB_ETH_RNDIS is not set | 268 | # CONFIG_USB_ETH_RNDIS is not set |
| 269 | CONFIG_MMC=y | 269 | CONFIG_MMC=y |
diff --git a/arch/arm/configs/magician_defconfig b/arch/arm/configs/magician_defconfig index a88e64d4e9a5..443675d317e6 100644 --- a/arch/arm/configs/magician_defconfig +++ b/arch/arm/configs/magician_defconfig | |||
| @@ -132,7 +132,7 @@ CONFIG_USB_MON=m | |||
| 132 | CONFIG_USB_OHCI_HCD=y | 132 | CONFIG_USB_OHCI_HCD=y |
| 133 | CONFIG_USB_GADGET=y | 133 | CONFIG_USB_GADGET=y |
| 134 | CONFIG_USB_GADGET_VBUS_DRAW=500 | 134 | CONFIG_USB_GADGET_VBUS_DRAW=500 |
| 135 | CONFIG_USB_GADGET_PXA27X=y | 135 | CONFIG_USB_PXA27X=y |
| 136 | CONFIG_USB_ETH=m | 136 | CONFIG_USB_ETH=m |
| 137 | # CONFIG_USB_ETH_RNDIS is not set | 137 | # CONFIG_USB_ETH_RNDIS is not set |
| 138 | CONFIG_USB_GADGETFS=m | 138 | CONFIG_USB_GADGETFS=m |
diff --git a/arch/arm/configs/omap1_defconfig b/arch/arm/configs/omap1_defconfig index 7b63462b349d..945a34f2a34d 100644 --- a/arch/arm/configs/omap1_defconfig +++ b/arch/arm/configs/omap1_defconfig | |||
| @@ -48,13 +48,7 @@ CONFIG_MACH_SX1=y | |||
| 48 | CONFIG_MACH_NOKIA770=y | 48 | CONFIG_MACH_NOKIA770=y |
| 49 | CONFIG_MACH_AMS_DELTA=y | 49 | CONFIG_MACH_AMS_DELTA=y |
| 50 | CONFIG_MACH_OMAP_GENERIC=y | 50 | CONFIG_MACH_OMAP_GENERIC=y |
| 51 | CONFIG_OMAP_CLOCKS_SET_BY_BOOTLOADER=y | ||
| 52 | CONFIG_OMAP_ARM_216MHZ=y | ||
| 53 | CONFIG_OMAP_ARM_195MHZ=y | ||
| 54 | CONFIG_OMAP_ARM_192MHZ=y | ||
| 55 | CONFIG_OMAP_ARM_182MHZ=y | 51 | CONFIG_OMAP_ARM_182MHZ=y |
| 56 | CONFIG_OMAP_ARM_168MHZ=y | ||
| 57 | # CONFIG_OMAP_ARM_60MHZ is not set | ||
| 58 | # CONFIG_ARM_THUMB is not set | 52 | # CONFIG_ARM_THUMB is not set |
| 59 | CONFIG_PCCARD=y | 53 | CONFIG_PCCARD=y |
| 60 | CONFIG_OMAP_CF=y | 54 | CONFIG_OMAP_CF=y |
diff --git a/arch/arm/configs/u300_defconfig b/arch/arm/configs/u300_defconfig index 4a5a12681be2..374000ec4e4e 100644 --- a/arch/arm/configs/u300_defconfig +++ b/arch/arm/configs/u300_defconfig | |||
| @@ -14,8 +14,6 @@ CONFIG_MODULE_UNLOAD=y | |||
| 14 | CONFIG_ARCH_U300=y | 14 | CONFIG_ARCH_U300=y |
| 15 | CONFIG_MACH_U300=y | 15 | CONFIG_MACH_U300=y |
| 16 | CONFIG_MACH_U300_BS335=y | 16 | CONFIG_MACH_U300_BS335=y |
| 17 | CONFIG_MACH_U300_DUAL_RAM=y | ||
| 18 | CONFIG_U300_DEBUG=y | ||
| 19 | CONFIG_MACH_U300_SPIDUMMY=y | 17 | CONFIG_MACH_U300_SPIDUMMY=y |
| 20 | CONFIG_NO_HZ=y | 18 | CONFIG_NO_HZ=y |
| 21 | CONFIG_HIGH_RES_TIMERS=y | 19 | CONFIG_HIGH_RES_TIMERS=y |
| @@ -26,19 +24,21 @@ CONFIG_ZBOOT_ROM_BSS=0x0 | |||
| 26 | CONFIG_CMDLINE="root=/dev/ram0 rw rootfstype=rootfs console=ttyAMA0,115200n8 lpj=515072" | 24 | CONFIG_CMDLINE="root=/dev/ram0 rw rootfstype=rootfs console=ttyAMA0,115200n8 lpj=515072" |
| 27 | CONFIG_CPU_IDLE=y | 25 | CONFIG_CPU_IDLE=y |
| 28 | CONFIG_FPE_NWFPE=y | 26 | CONFIG_FPE_NWFPE=y |
| 29 | CONFIG_PM=y | ||
| 30 | # CONFIG_SUSPEND is not set | 27 | # CONFIG_SUSPEND is not set |
| 31 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" | 28 | CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug" |
| 32 | # CONFIG_PREVENT_FIRMWARE_BUILD is not set | 29 | # CONFIG_PREVENT_FIRMWARE_BUILD is not set |
| 33 | # CONFIG_MISC_DEVICES is not set | 30 | CONFIG_MTD=y |
| 31 | CONFIG_MTD_CMDLINE_PARTS=y | ||
| 32 | CONFIG_MTD_NAND=y | ||
| 33 | CONFIG_MTD_NAND_FSMC=y | ||
| 34 | # CONFIG_INPUT_MOUSEDEV is not set | 34 | # CONFIG_INPUT_MOUSEDEV is not set |
| 35 | CONFIG_INPUT_EVDEV=y | 35 | CONFIG_INPUT_EVDEV=y |
| 36 | # CONFIG_KEYBOARD_ATKBD is not set | 36 | # CONFIG_KEYBOARD_ATKBD is not set |
| 37 | # CONFIG_INPUT_MOUSE is not set | 37 | # CONFIG_INPUT_MOUSE is not set |
| 38 | # CONFIG_SERIO is not set | 38 | # CONFIG_SERIO is not set |
| 39 | CONFIG_LEGACY_PTY_COUNT=16 | ||
| 39 | CONFIG_SERIAL_AMBA_PL011=y | 40 | CONFIG_SERIAL_AMBA_PL011=y |
| 40 | CONFIG_SERIAL_AMBA_PL011_CONSOLE=y | 41 | CONFIG_SERIAL_AMBA_PL011_CONSOLE=y |
| 41 | CONFIG_LEGACY_PTY_COUNT=16 | ||
| 42 | # CONFIG_HW_RANDOM is not set | 42 | # CONFIG_HW_RANDOM is not set |
| 43 | CONFIG_I2C=y | 43 | CONFIG_I2C=y |
| 44 | # CONFIG_HWMON is not set | 44 | # CONFIG_HWMON is not set |
| @@ -51,6 +51,7 @@ CONFIG_BACKLIGHT_CLASS_DEVICE=y | |||
| 51 | # CONFIG_HID_SUPPORT is not set | 51 | # CONFIG_HID_SUPPORT is not set |
| 52 | # CONFIG_USB_SUPPORT is not set | 52 | # CONFIG_USB_SUPPORT is not set |
| 53 | CONFIG_MMC=y | 53 | CONFIG_MMC=y |
| 54 | CONFIG_MMC_CLKGATE=y | ||
| 54 | CONFIG_MMC_ARMMMCI=y | 55 | CONFIG_MMC_ARMMMCI=y |
| 55 | CONFIG_RTC_CLASS=y | 56 | CONFIG_RTC_CLASS=y |
| 56 | # CONFIG_RTC_HCTOSYS is not set | 57 | # CONFIG_RTC_HCTOSYS is not set |
| @@ -65,10 +66,8 @@ CONFIG_NLS_CODEPAGE_437=y | |||
| 65 | CONFIG_NLS_ISO8859_1=y | 66 | CONFIG_NLS_ISO8859_1=y |
| 66 | CONFIG_PRINTK_TIME=y | 67 | CONFIG_PRINTK_TIME=y |
| 67 | CONFIG_DEBUG_FS=y | 68 | CONFIG_DEBUG_FS=y |
| 68 | CONFIG_DEBUG_KERNEL=y | ||
| 69 | # CONFIG_SCHED_DEBUG is not set | 69 | # CONFIG_SCHED_DEBUG is not set |
| 70 | CONFIG_TIMER_STATS=y | 70 | CONFIG_TIMER_STATS=y |
| 71 | # CONFIG_DEBUG_PREEMPT is not set | 71 | # CONFIG_DEBUG_PREEMPT is not set |
| 72 | CONFIG_DEBUG_INFO=y | 72 | CONFIG_DEBUG_INFO=y |
| 73 | # CONFIG_RCU_CPU_STALL_DETECTOR is not set | ||
| 74 | # CONFIG_CRC32 is not set | 73 | # CONFIG_CRC32 is not set |
diff --git a/arch/arm/configs/u8500_defconfig b/arch/arm/configs/u8500_defconfig index 97d31a4663da..2d7b6e7b7271 100644 --- a/arch/arm/configs/u8500_defconfig +++ b/arch/arm/configs/u8500_defconfig | |||
| @@ -10,7 +10,7 @@ CONFIG_MODULE_UNLOAD=y | |||
| 10 | CONFIG_ARCH_U8500=y | 10 | CONFIG_ARCH_U8500=y |
| 11 | CONFIG_UX500_SOC_DB5500=y | 11 | CONFIG_UX500_SOC_DB5500=y |
| 12 | CONFIG_UX500_SOC_DB8500=y | 12 | CONFIG_UX500_SOC_DB8500=y |
| 13 | CONFIG_MACH_U8500=y | 13 | CONFIG_MACH_HREFV60=y |
| 14 | CONFIG_MACH_SNOWBALL=y | 14 | CONFIG_MACH_SNOWBALL=y |
| 15 | CONFIG_MACH_U5500=y | 15 | CONFIG_MACH_U5500=y |
| 16 | CONFIG_NO_HZ=y | 16 | CONFIG_NO_HZ=y |
| @@ -24,6 +24,7 @@ CONFIG_CPU_FREQ=y | |||
| 24 | CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y | 24 | CONFIG_CPU_FREQ_DEFAULT_GOV_ONDEMAND=y |
| 25 | CONFIG_VFP=y | 25 | CONFIG_VFP=y |
| 26 | CONFIG_NEON=y | 26 | CONFIG_NEON=y |
| 27 | CONFIG_PM_RUNTIME=y | ||
| 27 | CONFIG_NET=y | 28 | CONFIG_NET=y |
| 28 | CONFIG_PACKET=y | 29 | CONFIG_PACKET=y |
| 29 | CONFIG_UNIX=y | 30 | CONFIG_UNIX=y |
| @@ -41,11 +42,8 @@ CONFIG_MISC_DEVICES=y | |||
| 41 | CONFIG_AB8500_PWM=y | 42 | CONFIG_AB8500_PWM=y |
| 42 | CONFIG_SENSORS_BH1780=y | 43 | CONFIG_SENSORS_BH1780=y |
| 43 | CONFIG_NETDEVICES=y | 44 | CONFIG_NETDEVICES=y |
| 44 | CONFIG_SMSC_PHY=y | ||
| 45 | CONFIG_NET_ETHERNET=y | ||
| 46 | CONFIG_SMSC911X=y | 45 | CONFIG_SMSC911X=y |
| 47 | # CONFIG_NETDEV_1000 is not set | 46 | CONFIG_SMSC_PHY=y |
| 48 | # CONFIG_NETDEV_10000 is not set | ||
| 49 | # CONFIG_WLAN is not set | 47 | # CONFIG_WLAN is not set |
| 50 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set | 48 | # CONFIG_INPUT_MOUSEDEV_PSAUX is not set |
| 51 | CONFIG_INPUT_EVDEV=y | 49 | CONFIG_INPUT_EVDEV=y |
| @@ -72,15 +70,12 @@ CONFIG_SPI=y | |||
| 72 | CONFIG_SPI_PL022=y | 70 | CONFIG_SPI_PL022=y |
| 73 | CONFIG_GPIO_STMPE=y | 71 | CONFIG_GPIO_STMPE=y |
| 74 | CONFIG_GPIO_TC3589X=y | 72 | CONFIG_GPIO_TC3589X=y |
| 75 | # CONFIG_HWMON is not set | ||
| 76 | CONFIG_MFD_STMPE=y | 73 | CONFIG_MFD_STMPE=y |
| 77 | CONFIG_MFD_TC3589X=y | 74 | CONFIG_MFD_TC3589X=y |
| 75 | CONFIG_AB5500_CORE=y | ||
| 78 | CONFIG_AB8500_CORE=y | 76 | CONFIG_AB8500_CORE=y |
| 79 | CONFIG_REGULATOR_AB8500=y | 77 | CONFIG_REGULATOR_AB8500=y |
| 80 | # CONFIG_HID_SUPPORT is not set | 78 | # CONFIG_HID_SUPPORT is not set |
| 81 | CONFIG_USB_MUSB_HDRC=y | ||
| 82 | CONFIG_USB_GADGET_MUSB_HDRC=y | ||
| 83 | CONFIG_MUSB_PIO_ONLY=y | ||
| 84 | CONFIG_USB_GADGET=y | 79 | CONFIG_USB_GADGET=y |
| 85 | CONFIG_AB8500_USB=y | 80 | CONFIG_AB8500_USB=y |
| 86 | CONFIG_MMC=y | 81 | CONFIG_MMC=y |
| @@ -97,6 +92,7 @@ CONFIG_DMADEVICES=y | |||
| 97 | CONFIG_STE_DMA40=y | 92 | CONFIG_STE_DMA40=y |
| 98 | CONFIG_STAGING=y | 93 | CONFIG_STAGING=y |
| 99 | CONFIG_TOUCHSCREEN_SYNAPTICS_I2C_RMI4=y | 94 | CONFIG_TOUCHSCREEN_SYNAPTICS_I2C_RMI4=y |
| 95 | CONFIG_HSEM_U8500=y | ||
| 100 | CONFIG_EXT2_FS=y | 96 | CONFIG_EXT2_FS=y |
| 101 | CONFIG_EXT2_FS_XATTR=y | 97 | CONFIG_EXT2_FS_XATTR=y |
| 102 | CONFIG_EXT2_FS_POSIX_ACL=y | 98 | CONFIG_EXT2_FS_POSIX_ACL=y |
diff --git a/arch/arm/configs/zeus_defconfig b/arch/arm/configs/zeus_defconfig index 59577ad3f4ef..547a3c1e59db 100644 --- a/arch/arm/configs/zeus_defconfig +++ b/arch/arm/configs/zeus_defconfig | |||
| @@ -140,7 +140,7 @@ CONFIG_USB_SERIAL=m | |||
| 140 | CONFIG_USB_SERIAL_GENERIC=y | 140 | CONFIG_USB_SERIAL_GENERIC=y |
| 141 | CONFIG_USB_SERIAL_MCT_U232=m | 141 | CONFIG_USB_SERIAL_MCT_U232=m |
| 142 | CONFIG_USB_GADGET=m | 142 | CONFIG_USB_GADGET=m |
| 143 | CONFIG_USB_GADGET_PXA27X=y | 143 | CONFIG_USB_PXA27X=y |
| 144 | CONFIG_USB_ETH=m | 144 | CONFIG_USB_ETH=m |
| 145 | CONFIG_USB_GADGETFS=m | 145 | CONFIG_USB_GADGETFS=m |
| 146 | CONFIG_USB_FILE_STORAGE=m | 146 | CONFIG_USB_FILE_STORAGE=m |
diff --git a/arch/arm/include/asm/pmu.h b/arch/arm/include/asm/pmu.h index 71d99b83cdb9..0bda22c094a6 100644 --- a/arch/arm/include/asm/pmu.h +++ b/arch/arm/include/asm/pmu.h | |||
| @@ -55,16 +55,6 @@ reserve_pmu(enum arm_pmu_type type); | |||
| 55 | extern void | 55 | extern void |
| 56 | release_pmu(enum arm_pmu_type type); | 56 | release_pmu(enum arm_pmu_type type); |
| 57 | 57 | ||
| 58 | /** | ||
| 59 | * init_pmu() - Initialise the PMU. | ||
| 60 | * | ||
| 61 | * Initialise the system ready for PMU enabling. This should typically set the | ||
| 62 | * IRQ affinity and nothing else. The users (oprofile/perf events etc) will do | ||
| 63 | * the actual hardware initialisation. | ||
| 64 | */ | ||
| 65 | extern int | ||
| 66 | init_pmu(enum arm_pmu_type type); | ||
| 67 | |||
| 68 | #else /* CONFIG_CPU_HAS_PMU */ | 58 | #else /* CONFIG_CPU_HAS_PMU */ |
| 69 | 59 | ||
| 70 | #include <linux/err.h> | 60 | #include <linux/err.h> |
diff --git a/arch/arm/include/asm/topology.h b/arch/arm/include/asm/topology.h index a7e457ed27c3..58b8b84adcd2 100644 --- a/arch/arm/include/asm/topology.h +++ b/arch/arm/include/asm/topology.h | |||
| @@ -25,7 +25,7 @@ extern struct cputopo_arm cpu_topology[NR_CPUS]; | |||
| 25 | 25 | ||
| 26 | void init_cpu_topology(void); | 26 | void init_cpu_topology(void); |
| 27 | void store_cpu_topology(unsigned int cpuid); | 27 | void store_cpu_topology(unsigned int cpuid); |
| 28 | const struct cpumask *cpu_coregroup_mask(unsigned int cpu); | 28 | const struct cpumask *cpu_coregroup_mask(int cpu); |
| 29 | 29 | ||
| 30 | #else | 30 | #else |
| 31 | 31 | ||
diff --git a/arch/arm/include/asm/unwind.h b/arch/arm/include/asm/unwind.h index a5edf421005c..d1c3f3a71c94 100644 --- a/arch/arm/include/asm/unwind.h +++ b/arch/arm/include/asm/unwind.h | |||
| @@ -30,14 +30,15 @@ enum unwind_reason_code { | |||
| 30 | }; | 30 | }; |
| 31 | 31 | ||
| 32 | struct unwind_idx { | 32 | struct unwind_idx { |
| 33 | unsigned long addr; | 33 | unsigned long addr_offset; |
| 34 | unsigned long insn; | 34 | unsigned long insn; |
| 35 | }; | 35 | }; |
| 36 | 36 | ||
| 37 | struct unwind_table { | 37 | struct unwind_table { |
| 38 | struct list_head list; | 38 | struct list_head list; |
| 39 | struct unwind_idx *start; | 39 | const struct unwind_idx *start; |
| 40 | struct unwind_idx *stop; | 40 | const struct unwind_idx *origin; |
| 41 | const struct unwind_idx *stop; | ||
| 41 | unsigned long begin_addr; | 42 | unsigned long begin_addr; |
| 42 | unsigned long end_addr; | 43 | unsigned long end_addr; |
| 43 | }; | 44 | }; |
| @@ -49,15 +50,6 @@ extern struct unwind_table *unwind_table_add(unsigned long start, | |||
| 49 | extern void unwind_table_del(struct unwind_table *tab); | 50 | extern void unwind_table_del(struct unwind_table *tab); |
| 50 | extern void unwind_backtrace(struct pt_regs *regs, struct task_struct *tsk); | 51 | extern void unwind_backtrace(struct pt_regs *regs, struct task_struct *tsk); |
| 51 | 52 | ||
| 52 | #ifdef CONFIG_ARM_UNWIND | ||
| 53 | extern int __init unwind_init(void); | ||
| 54 | #else | ||
| 55 | static inline int __init unwind_init(void) | ||
| 56 | { | ||
| 57 | return 0; | ||
| 58 | } | ||
| 59 | #endif | ||
| 60 | |||
| 61 | #endif /* !__ASSEMBLY__ */ | 53 | #endif /* !__ASSEMBLY__ */ |
| 62 | 54 | ||
| 63 | #ifdef CONFIG_ARM_UNWIND | 55 | #ifdef CONFIG_ARM_UNWIND |
diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S index 9ad50c4208ae..b145f16c91bc 100644 --- a/arch/arm/kernel/entry-armv.S +++ b/arch/arm/kernel/entry-armv.S | |||
| @@ -497,7 +497,7 @@ ENDPROC(__und_usr) | |||
| 497 | .popsection | 497 | .popsection |
| 498 | .pushsection __ex_table,"a" | 498 | .pushsection __ex_table,"a" |
| 499 | .long 1b, 4b | 499 | .long 1b, 4b |
| 500 | #if __LINUX_ARM_ARCH__ >= 7 | 500 | #if CONFIG_ARM_THUMB && __LINUX_ARM_ARCH__ >= 6 && CONFIG_CPU_V7 |
| 501 | .long 2b, 4b | 501 | .long 2b, 4b |
| 502 | .long 3b, 4b | 502 | .long 3b, 4b |
| 503 | #endif | 503 | #endif |
diff --git a/arch/arm/kernel/kprobes-arm.c b/arch/arm/kernel/kprobes-arm.c index 9fe8910308af..8a30c89da70e 100644 --- a/arch/arm/kernel/kprobes-arm.c +++ b/arch/arm/kernel/kprobes-arm.c | |||
| @@ -519,10 +519,12 @@ static const union decode_item arm_cccc_0000_____1001_table[] = { | |||
| 519 | static const union decode_item arm_cccc_0001_____1001_table[] = { | 519 | static const union decode_item arm_cccc_0001_____1001_table[] = { |
| 520 | /* Synchronization primitives */ | 520 | /* Synchronization primitives */ |
| 521 | 521 | ||
| 522 | #if __LINUX_ARM_ARCH__ < 6 | ||
| 523 | /* Deprecated on ARMv6 and may be UNDEFINED on v7 */ | ||
| 522 | /* SMP/SWPB cccc 0001 0x00 xxxx xxxx xxxx 1001 xxxx */ | 524 | /* SMP/SWPB cccc 0001 0x00 xxxx xxxx xxxx 1001 xxxx */ |
| 523 | DECODE_EMULATEX (0x0fb000f0, 0x01000090, emulate_rd12rn16rm0_rwflags_nopc, | 525 | DECODE_EMULATEX (0x0fb000f0, 0x01000090, emulate_rd12rn16rm0_rwflags_nopc, |
| 524 | REGS(NOPC, NOPC, 0, 0, NOPC)), | 526 | REGS(NOPC, NOPC, 0, 0, NOPC)), |
| 525 | 527 | #endif | |
| 526 | /* LDREX/STREX{,D,B,H} cccc 0001 1xxx xxxx xxxx xxxx 1001 xxxx */ | 528 | /* LDREX/STREX{,D,B,H} cccc 0001 1xxx xxxx xxxx xxxx 1001 xxxx */ |
| 527 | /* And unallocated instructions... */ | 529 | /* And unallocated instructions... */ |
| 528 | DECODE_END | 530 | DECODE_END |
diff --git a/arch/arm/kernel/kprobes-test-arm.c b/arch/arm/kernel/kprobes-test-arm.c index fc82de8bdcce..ba32b393b3f0 100644 --- a/arch/arm/kernel/kprobes-test-arm.c +++ b/arch/arm/kernel/kprobes-test-arm.c | |||
| @@ -427,18 +427,25 @@ void kprobe_arm_test_cases(void) | |||
| 427 | 427 | ||
| 428 | TEST_GROUP("Synchronization primitives") | 428 | TEST_GROUP("Synchronization primitives") |
| 429 | 429 | ||
| 430 | /* | 430 | #if __LINUX_ARM_ARCH__ < 6 |
| 431 | * Use hard coded constants for SWP instructions to avoid warnings | 431 | TEST_RP("swp lr, r",7,VAL2,", [r",8,0,"]") |
| 432 | * about deprecated instructions. | 432 | TEST_R( "swpvs r0, r",1,VAL1,", [sp]") |
| 433 | */ | 433 | TEST_RP("swp sp, r",14,VAL2,", [r",12,13*4,"]") |
| 434 | TEST_RP( ".word 0xe108e097 @ swp lr, r",7,VAL2,", [r",8,0,"]") | 434 | #else |
| 435 | TEST_R( ".word 0x610d0091 @ swpvs r0, r",1,VAL1,", [sp]") | 435 | TEST_UNSUPPORTED(".word 0xe108e097 @ swp lr, r7, [r8]") |
| 436 | TEST_RP( ".word 0xe10cd09e @ swp sp, r",14,VAL2,", [r",12,13*4,"]") | 436 | TEST_UNSUPPORTED(".word 0x610d0091 @ swpvs r0, r1, [sp]") |
| 437 | TEST_UNSUPPORTED(".word 0xe10cd09e @ swp sp, r14 [r12]") | ||
| 438 | #endif | ||
| 437 | TEST_UNSUPPORTED(".word 0xe102f091 @ swp pc, r1, [r2]") | 439 | TEST_UNSUPPORTED(".word 0xe102f091 @ swp pc, r1, [r2]") |
| 438 | TEST_UNSUPPORTED(".word 0xe102009f @ swp r0, pc, [r2]") | 440 | TEST_UNSUPPORTED(".word 0xe102009f @ swp r0, pc, [r2]") |
| 439 | TEST_UNSUPPORTED(".word 0xe10f0091 @ swp r0, r1, [pc]") | 441 | TEST_UNSUPPORTED(".word 0xe10f0091 @ swp r0, r1, [pc]") |
| 440 | TEST_RP( ".word 0xe148e097 @ swpb lr, r",7,VAL2,", [r",8,0,"]") | 442 | #if __LINUX_ARM_ARCH__ < 6 |
| 441 | TEST_R( ".word 0x614d0091 @ swpvsb r0, r",1,VAL1,", [sp]") | 443 | TEST_RP("swpb lr, r",7,VAL2,", [r",8,0,"]") |
| 444 | TEST_R( "swpvsb r0, r",1,VAL1,", [sp]") | ||
| 445 | #else | ||
| 446 | TEST_UNSUPPORTED(".word 0xe148e097 @ swpb lr, r7, [r8]") | ||
| 447 | TEST_UNSUPPORTED(".word 0x614d0091 @ swpvsb r0, r1, [sp]") | ||
| 448 | #endif | ||
| 442 | TEST_UNSUPPORTED(".word 0xe142f091 @ swpb pc, r1, [r2]") | 449 | TEST_UNSUPPORTED(".word 0xe142f091 @ swpb pc, r1, [r2]") |
| 443 | 450 | ||
| 444 | TEST_UNSUPPORTED(".word 0xe1100090") /* Unallocated space */ | 451 | TEST_UNSUPPORTED(".word 0xe1100090") /* Unallocated space */ |
| @@ -550,7 +557,7 @@ void kprobe_arm_test_cases(void) | |||
| 550 | TEST_RPR( "strccd r",8, VAL2,", [r",13,0, ", r",12,48,"]") | 557 | TEST_RPR( "strccd r",8, VAL2,", [r",13,0, ", r",12,48,"]") |
| 551 | TEST_RPR( "strd r",4, VAL1,", [r",2, 24,", r",3, 48,"]!") | 558 | TEST_RPR( "strd r",4, VAL1,", [r",2, 24,", r",3, 48,"]!") |
| 552 | TEST_RPR( "strcsd r",12,VAL2,", [r",11,48,", -r",10,24,"]!") | 559 | TEST_RPR( "strcsd r",12,VAL2,", [r",11,48,", -r",10,24,"]!") |
| 553 | TEST_RPR( "strd r",2, VAL1,", [r",3, 24,"], r",4,48,"") | 560 | TEST_RPR( "strd r",2, VAL1,", [r",5, 24,"], r",4,48,"") |
| 554 | TEST_RPR( "strd r",10,VAL2,", [r",9, 48,"], -r",7,24,"") | 561 | TEST_RPR( "strd r",10,VAL2,", [r",9, 48,"], -r",7,24,"") |
| 555 | TEST_UNSUPPORTED(".word 0xe1afc0fa @ strd r12, [pc, r10]!") | 562 | TEST_UNSUPPORTED(".word 0xe1afc0fa @ strd r12, [pc, r10]!") |
| 556 | 563 | ||
diff --git a/arch/arm/kernel/kprobes-test-thumb.c b/arch/arm/kernel/kprobes-test-thumb.c index 5e726c31c45a..5d8b85792222 100644 --- a/arch/arm/kernel/kprobes-test-thumb.c +++ b/arch/arm/kernel/kprobes-test-thumb.c | |||
| @@ -222,8 +222,8 @@ void kprobe_thumb16_test_cases(void) | |||
| 222 | DONT_TEST_IN_ITBLOCK( | 222 | DONT_TEST_IN_ITBLOCK( |
| 223 | TEST_BF_R( "cbnz r",0,0, ", 2f") | 223 | TEST_BF_R( "cbnz r",0,0, ", 2f") |
| 224 | TEST_BF_R( "cbz r",2,-1,", 2f") | 224 | TEST_BF_R( "cbz r",2,-1,", 2f") |
| 225 | TEST_BF_RX( "cbnz r",4,1, ", 2f",0x20) | 225 | TEST_BF_RX( "cbnz r",4,1, ", 2f", SPACE_0x20) |
| 226 | TEST_BF_RX( "cbz r",7,0, ", 2f",0x40) | 226 | TEST_BF_RX( "cbz r",7,0, ", 2f", SPACE_0x40) |
| 227 | ) | 227 | ) |
| 228 | TEST_R("sxth r0, r",7, HH1,"") | 228 | TEST_R("sxth r0, r",7, HH1,"") |
| 229 | TEST_R("sxth r7, r",0, HH2,"") | 229 | TEST_R("sxth r7, r",0, HH2,"") |
| @@ -246,7 +246,7 @@ DONT_TEST_IN_ITBLOCK( | |||
| 246 | TESTCASE_START(code) \ | 246 | TESTCASE_START(code) \ |
| 247 | TEST_ARG_PTR(13, offset) \ | 247 | TEST_ARG_PTR(13, offset) \ |
| 248 | TEST_ARG_END("") \ | 248 | TEST_ARG_END("") \ |
| 249 | TEST_BRANCH_F(code,0) \ | 249 | TEST_BRANCH_F(code) \ |
| 250 | TESTCASE_END | 250 | TESTCASE_END |
| 251 | 251 | ||
| 252 | TEST("push {r0}") | 252 | TEST("push {r0}") |
| @@ -319,8 +319,8 @@ CONDITION_INSTRUCTIONS(8, | |||
| 319 | 319 | ||
| 320 | TEST_BF( "b 2f") | 320 | TEST_BF( "b 2f") |
| 321 | TEST_BB( "b 2b") | 321 | TEST_BB( "b 2b") |
| 322 | TEST_BF_X("b 2f", 0x400) | 322 | TEST_BF_X("b 2f", SPACE_0x400) |
| 323 | TEST_BB_X("b 2b", 0x400) | 323 | TEST_BB_X("b 2b", SPACE_0x400) |
| 324 | 324 | ||
| 325 | TEST_GROUP("Testing instructions in IT blocks") | 325 | TEST_GROUP("Testing instructions in IT blocks") |
| 326 | 326 | ||
| @@ -746,7 +746,7 @@ CONDITION_INSTRUCTIONS(22, | |||
| 746 | TEST_BB("bne.w 2b") | 746 | TEST_BB("bne.w 2b") |
| 747 | TEST_BF("bgt.w 2f") | 747 | TEST_BF("bgt.w 2f") |
| 748 | TEST_BB("blt.w 2b") | 748 | TEST_BB("blt.w 2b") |
| 749 | TEST_BF_X("bpl.w 2f",0x1000) | 749 | TEST_BF_X("bpl.w 2f", SPACE_0x1000) |
| 750 | ) | 750 | ) |
| 751 | 751 | ||
| 752 | TEST_UNSUPPORTED("msr cpsr, r0") | 752 | TEST_UNSUPPORTED("msr cpsr, r0") |
| @@ -786,11 +786,11 @@ CONDITION_INSTRUCTIONS(22, | |||
| 786 | 786 | ||
| 787 | TEST_BF( "b.w 2f") | 787 | TEST_BF( "b.w 2f") |
| 788 | TEST_BB( "b.w 2b") | 788 | TEST_BB( "b.w 2b") |
| 789 | TEST_BF_X("b.w 2f", 0x1000) | 789 | TEST_BF_X("b.w 2f", SPACE_0x1000) |
| 790 | 790 | ||
| 791 | TEST_BF( "bl.w 2f") | 791 | TEST_BF( "bl.w 2f") |
| 792 | TEST_BB( "bl.w 2b") | 792 | TEST_BB( "bl.w 2b") |
| 793 | TEST_BB_X("bl.w 2b", 0x1000) | 793 | TEST_BB_X("bl.w 2b", SPACE_0x1000) |
| 794 | 794 | ||
| 795 | TEST_X( "blx __dummy_arm_subroutine", | 795 | TEST_X( "blx __dummy_arm_subroutine", |
| 796 | ".arm \n\t" | 796 | ".arm \n\t" |
diff --git a/arch/arm/kernel/kprobes-test.h b/arch/arm/kernel/kprobes-test.h index 0dc5d77b9356..e28a869b1ae4 100644 --- a/arch/arm/kernel/kprobes-test.h +++ b/arch/arm/kernel/kprobes-test.h | |||
| @@ -149,23 +149,31 @@ struct test_arg_end { | |||
| 149 | "1: "instruction" \n\t" \ | 149 | "1: "instruction" \n\t" \ |
| 150 | " nop \n\t" | 150 | " nop \n\t" |
| 151 | 151 | ||
| 152 | #define TEST_BRANCH_F(instruction, xtra_dist) \ | 152 | #define TEST_BRANCH_F(instruction) \ |
| 153 | TEST_INSTRUCTION(instruction) \ | 153 | TEST_INSTRUCTION(instruction) \ |
| 154 | ".if "#xtra_dist" \n\t" \ | ||
| 155 | " b 99f \n\t" \ | 154 | " b 99f \n\t" \ |
| 156 | ".space "#xtra_dist" \n\t" \ | 155 | "2: nop \n\t" |
| 157 | ".endif \n\t" \ | 156 | |
| 157 | #define TEST_BRANCH_B(instruction) \ | ||
| 158 | " b 50f \n\t" \ | ||
| 159 | " b 99f \n\t" \ | ||
| 160 | "2: nop \n\t" \ | ||
| 161 | " b 99f \n\t" \ | ||
| 162 | TEST_INSTRUCTION(instruction) | ||
| 163 | |||
| 164 | #define TEST_BRANCH_FX(instruction, codex) \ | ||
| 165 | TEST_INSTRUCTION(instruction) \ | ||
| 166 | " b 99f \n\t" \ | ||
| 167 | codex" \n\t" \ | ||
| 158 | " b 99f \n\t" \ | 168 | " b 99f \n\t" \ |
| 159 | "2: nop \n\t" | 169 | "2: nop \n\t" |
| 160 | 170 | ||
| 161 | #define TEST_BRANCH_B(instruction, xtra_dist) \ | 171 | #define TEST_BRANCH_BX(instruction, codex) \ |
| 162 | " b 50f \n\t" \ | 172 | " b 50f \n\t" \ |
| 163 | " b 99f \n\t" \ | 173 | " b 99f \n\t" \ |
| 164 | "2: nop \n\t" \ | 174 | "2: nop \n\t" \ |
| 165 | " b 99f \n\t" \ | 175 | " b 99f \n\t" \ |
| 166 | ".if "#xtra_dist" \n\t" \ | 176 | codex" \n\t" \ |
| 167 | ".space "#xtra_dist" \n\t" \ | ||
| 168 | ".endif \n\t" \ | ||
| 169 | TEST_INSTRUCTION(instruction) | 177 | TEST_INSTRUCTION(instruction) |
| 170 | 178 | ||
| 171 | #define TESTCASE_END \ | 179 | #define TESTCASE_END \ |
| @@ -301,47 +309,60 @@ struct test_arg_end { | |||
| 301 | TESTCASE_START(code1 #reg1 code2) \ | 309 | TESTCASE_START(code1 #reg1 code2) \ |
| 302 | TEST_ARG_PTR(reg1, val1) \ | 310 | TEST_ARG_PTR(reg1, val1) \ |
| 303 | TEST_ARG_END("") \ | 311 | TEST_ARG_END("") \ |
| 304 | TEST_BRANCH_F(code1 #reg1 code2, 0) \ | 312 | TEST_BRANCH_F(code1 #reg1 code2) \ |
| 305 | TESTCASE_END | 313 | TESTCASE_END |
| 306 | 314 | ||
| 307 | #define TEST_BF_X(code, xtra_dist) \ | 315 | #define TEST_BF(code) \ |
| 308 | TESTCASE_START(code) \ | 316 | TESTCASE_START(code) \ |
| 309 | TEST_ARG_END("") \ | 317 | TEST_ARG_END("") \ |
| 310 | TEST_BRANCH_F(code, xtra_dist) \ | 318 | TEST_BRANCH_F(code) \ |
| 311 | TESTCASE_END | 319 | TESTCASE_END |
| 312 | 320 | ||
| 313 | #define TEST_BB_X(code, xtra_dist) \ | 321 | #define TEST_BB(code) \ |
| 314 | TESTCASE_START(code) \ | 322 | TESTCASE_START(code) \ |
| 315 | TEST_ARG_END("") \ | 323 | TEST_ARG_END("") \ |
| 316 | TEST_BRANCH_B(code, xtra_dist) \ | 324 | TEST_BRANCH_B(code) \ |
| 317 | TESTCASE_END | 325 | TESTCASE_END |
| 318 | 326 | ||
| 319 | #define TEST_BF_RX(code1, reg, val, code2, xtra_dist) \ | 327 | #define TEST_BF_R(code1, reg, val, code2) \ |
| 320 | TESTCASE_START(code1 #reg code2) \ | 328 | TESTCASE_START(code1 #reg code2) \ |
| 321 | TEST_ARG_REG(reg, val) \ | 329 | TEST_ARG_REG(reg, val) \ |
| 322 | TEST_ARG_END("") \ | 330 | TEST_ARG_END("") \ |
| 323 | TEST_BRANCH_F(code1 #reg code2, xtra_dist) \ | 331 | TEST_BRANCH_F(code1 #reg code2) \ |
| 324 | TESTCASE_END | 332 | TESTCASE_END |
| 325 | 333 | ||
| 326 | #define TEST_BB_RX(code1, reg, val, code2, xtra_dist) \ | 334 | #define TEST_BB_R(code1, reg, val, code2) \ |
| 327 | TESTCASE_START(code1 #reg code2) \ | 335 | TESTCASE_START(code1 #reg code2) \ |
| 328 | TEST_ARG_REG(reg, val) \ | 336 | TEST_ARG_REG(reg, val) \ |
| 329 | TEST_ARG_END("") \ | 337 | TEST_ARG_END("") \ |
| 330 | TEST_BRANCH_B(code1 #reg code2, xtra_dist) \ | 338 | TEST_BRANCH_B(code1 #reg code2) \ |
| 331 | TESTCASE_END | 339 | TESTCASE_END |
| 332 | 340 | ||
| 333 | #define TEST_BF(code) TEST_BF_X(code, 0) | ||
| 334 | #define TEST_BB(code) TEST_BB_X(code, 0) | ||
| 335 | |||
| 336 | #define TEST_BF_R(code1, reg, val, code2) TEST_BF_RX(code1, reg, val, code2, 0) | ||
| 337 | #define TEST_BB_R(code1, reg, val, code2) TEST_BB_RX(code1, reg, val, code2, 0) | ||
| 338 | |||
| 339 | #define TEST_BF_RR(code1, reg1, val1, code2, reg2, val2, code3) \ | 341 | #define TEST_BF_RR(code1, reg1, val1, code2, reg2, val2, code3) \ |
| 340 | TESTCASE_START(code1 #reg1 code2 #reg2 code3) \ | 342 | TESTCASE_START(code1 #reg1 code2 #reg2 code3) \ |
| 341 | TEST_ARG_REG(reg1, val1) \ | 343 | TEST_ARG_REG(reg1, val1) \ |
| 342 | TEST_ARG_REG(reg2, val2) \ | 344 | TEST_ARG_REG(reg2, val2) \ |
| 343 | TEST_ARG_END("") \ | 345 | TEST_ARG_END("") \ |
| 344 | TEST_BRANCH_F(code1 #reg1 code2 #reg2 code3, 0) \ | 346 | TEST_BRANCH_F(code1 #reg1 code2 #reg2 code3) \ |
| 347 | TESTCASE_END | ||
| 348 | |||
| 349 | #define TEST_BF_X(code, codex) \ | ||
| 350 | TESTCASE_START(code) \ | ||
| 351 | TEST_ARG_END("") \ | ||
| 352 | TEST_BRANCH_FX(code, codex) \ | ||
| 353 | TESTCASE_END | ||
| 354 | |||
| 355 | #define TEST_BB_X(code, codex) \ | ||
| 356 | TESTCASE_START(code) \ | ||
| 357 | TEST_ARG_END("") \ | ||
| 358 | TEST_BRANCH_BX(code, codex) \ | ||
| 359 | TESTCASE_END | ||
| 360 | |||
| 361 | #define TEST_BF_RX(code1, reg, val, code2, codex) \ | ||
| 362 | TESTCASE_START(code1 #reg code2) \ | ||
| 363 | TEST_ARG_REG(reg, val) \ | ||
| 364 | TEST_ARG_END("") \ | ||
| 365 | TEST_BRANCH_FX(code1 #reg code2, codex) \ | ||
| 345 | TESTCASE_END | 366 | TESTCASE_END |
| 346 | 367 | ||
| 347 | #define TEST_X(code, codex) \ | 368 | #define TEST_X(code, codex) \ |
| @@ -372,6 +393,25 @@ struct test_arg_end { | |||
| 372 | TESTCASE_END | 393 | TESTCASE_END |
| 373 | 394 | ||
| 374 | 395 | ||
| 396 | /* | ||
| 397 | * Macros for defining space directives spread over multiple lines. | ||
| 398 | * These are required so the compiler guesses better the length of inline asm | ||
| 399 | * code and will spill the literal pool early enough to avoid generating PC | ||
| 400 | * relative loads with out of range offsets. | ||
| 401 | */ | ||
| 402 | #define TWICE(x) x x | ||
| 403 | #define SPACE_0x8 TWICE(".space 4\n\t") | ||
| 404 | #define SPACE_0x10 TWICE(SPACE_0x8) | ||
| 405 | #define SPACE_0x20 TWICE(SPACE_0x10) | ||
| 406 | #define SPACE_0x40 TWICE(SPACE_0x20) | ||
| 407 | #define SPACE_0x80 TWICE(SPACE_0x40) | ||
| 408 | #define SPACE_0x100 TWICE(SPACE_0x80) | ||
| 409 | #define SPACE_0x200 TWICE(SPACE_0x100) | ||
| 410 | #define SPACE_0x400 TWICE(SPACE_0x200) | ||
| 411 | #define SPACE_0x800 TWICE(SPACE_0x400) | ||
| 412 | #define SPACE_0x1000 TWICE(SPACE_0x800) | ||
| 413 | |||
| 414 | |||
| 375 | /* Various values used in test cases... */ | 415 | /* Various values used in test cases... */ |
| 376 | #define N(val) (val ^ 0xffffffff) | 416 | #define N(val) (val ^ 0xffffffff) |
| 377 | #define VAL1 0x12345678 | 417 | #define VAL1 0x12345678 |
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c index 24e2347be6b1..88b0941ce51e 100644 --- a/arch/arm/kernel/perf_event.c +++ b/arch/arm/kernel/perf_event.c | |||
| @@ -343,19 +343,25 @@ validate_group(struct perf_event *event) | |||
| 343 | { | 343 | { |
| 344 | struct perf_event *sibling, *leader = event->group_leader; | 344 | struct perf_event *sibling, *leader = event->group_leader; |
| 345 | struct pmu_hw_events fake_pmu; | 345 | struct pmu_hw_events fake_pmu; |
| 346 | DECLARE_BITMAP(fake_used_mask, ARMPMU_MAX_HWEVENTS); | ||
| 346 | 347 | ||
| 347 | memset(&fake_pmu, 0, sizeof(fake_pmu)); | 348 | /* |
| 349 | * Initialise the fake PMU. We only need to populate the | ||
| 350 | * used_mask for the purposes of validation. | ||
| 351 | */ | ||
| 352 | memset(fake_used_mask, 0, sizeof(fake_used_mask)); | ||
| 353 | fake_pmu.used_mask = fake_used_mask; | ||
| 348 | 354 | ||
| 349 | if (!validate_event(&fake_pmu, leader)) | 355 | if (!validate_event(&fake_pmu, leader)) |
| 350 | return -ENOSPC; | 356 | return -EINVAL; |
| 351 | 357 | ||
| 352 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { | 358 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { |
| 353 | if (!validate_event(&fake_pmu, sibling)) | 359 | if (!validate_event(&fake_pmu, sibling)) |
| 354 | return -ENOSPC; | 360 | return -EINVAL; |
| 355 | } | 361 | } |
| 356 | 362 | ||
| 357 | if (!validate_event(&fake_pmu, event)) | 363 | if (!validate_event(&fake_pmu, event)) |
| 358 | return -ENOSPC; | 364 | return -EINVAL; |
| 359 | 365 | ||
| 360 | return 0; | 366 | return 0; |
| 361 | } | 367 | } |
| @@ -396,6 +402,9 @@ armpmu_reserve_hardware(struct arm_pmu *armpmu) | |||
| 396 | int i, err, irq, irqs; | 402 | int i, err, irq, irqs; |
| 397 | struct platform_device *pmu_device = armpmu->plat_device; | 403 | struct platform_device *pmu_device = armpmu->plat_device; |
| 398 | 404 | ||
| 405 | if (!pmu_device) | ||
| 406 | return -ENODEV; | ||
| 407 | |||
| 399 | err = reserve_pmu(armpmu->type); | 408 | err = reserve_pmu(armpmu->type); |
| 400 | if (err) { | 409 | if (err) { |
| 401 | pr_warning("unable to reserve pmu\n"); | 410 | pr_warning("unable to reserve pmu\n"); |
| @@ -631,6 +640,9 @@ static struct platform_device_id armpmu_plat_device_ids[] = { | |||
| 631 | 640 | ||
| 632 | static int __devinit armpmu_device_probe(struct platform_device *pdev) | 641 | static int __devinit armpmu_device_probe(struct platform_device *pdev) |
| 633 | { | 642 | { |
| 643 | if (!cpu_pmu) | ||
| 644 | return -ENODEV; | ||
| 645 | |||
| 634 | cpu_pmu->plat_device = pdev; | 646 | cpu_pmu->plat_device = pdev; |
| 635 | return 0; | 647 | return 0; |
| 636 | } | 648 | } |
diff --git a/arch/arm/kernel/pmu.c b/arch/arm/kernel/pmu.c index 2c3407ee8576..2334bf8a650a 100644 --- a/arch/arm/kernel/pmu.c +++ b/arch/arm/kernel/pmu.c | |||
| @@ -33,3 +33,4 @@ release_pmu(enum arm_pmu_type type) | |||
| 33 | { | 33 | { |
| 34 | clear_bit_unlock(type, pmu_lock); | 34 | clear_bit_unlock(type, pmu_lock); |
| 35 | } | 35 | } |
| 36 | EXPORT_SYMBOL_GPL(release_pmu); | ||
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c index 75316f0dd02a..3d0c6fb74ae4 100644 --- a/arch/arm/kernel/process.c +++ b/arch/arm/kernel/process.c | |||
| @@ -192,6 +192,9 @@ void cpu_idle(void) | |||
| 192 | #endif | 192 | #endif |
| 193 | 193 | ||
| 194 | local_irq_disable(); | 194 | local_irq_disable(); |
| 195 | #ifdef CONFIG_PL310_ERRATA_769419 | ||
| 196 | wmb(); | ||
| 197 | #endif | ||
| 195 | if (hlt_counter) { | 198 | if (hlt_counter) { |
| 196 | local_irq_enable(); | 199 | local_irq_enable(); |
| 197 | cpu_relax(); | 200 | cpu_relax(); |
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 3448a3f9cc8c..8fc2c8fcbdc6 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c | |||
| @@ -895,8 +895,6 @@ void __init setup_arch(char **cmdline_p) | |||
| 895 | { | 895 | { |
| 896 | struct machine_desc *mdesc; | 896 | struct machine_desc *mdesc; |
| 897 | 897 | ||
| 898 | unwind_init(); | ||
| 899 | |||
| 900 | setup_processor(); | 898 | setup_processor(); |
| 901 | mdesc = setup_machine_fdt(__atags_pointer); | 899 | mdesc = setup_machine_fdt(__atags_pointer); |
| 902 | if (!mdesc) | 900 | if (!mdesc) |
| @@ -904,6 +902,12 @@ void __init setup_arch(char **cmdline_p) | |||
| 904 | machine_desc = mdesc; | 902 | machine_desc = mdesc; |
| 905 | machine_name = mdesc->name; | 903 | machine_name = mdesc->name; |
| 906 | 904 | ||
| 905 | #ifdef CONFIG_ZONE_DMA | ||
| 906 | if (mdesc->dma_zone_size) { | ||
| 907 | extern unsigned long arm_dma_zone_size; | ||
| 908 | arm_dma_zone_size = mdesc->dma_zone_size; | ||
| 909 | } | ||
| 910 | #endif | ||
| 907 | if (mdesc->soft_reboot) | 911 | if (mdesc->soft_reboot) |
| 908 | reboot_setup("s"); | 912 | reboot_setup("s"); |
| 909 | 913 | ||
| @@ -934,12 +938,6 @@ void __init setup_arch(char **cmdline_p) | |||
| 934 | 938 | ||
| 935 | tcm_init(); | 939 | tcm_init(); |
| 936 | 940 | ||
| 937 | #ifdef CONFIG_ZONE_DMA | ||
| 938 | if (mdesc->dma_zone_size) { | ||
| 939 | extern unsigned long arm_dma_zone_size; | ||
| 940 | arm_dma_zone_size = mdesc->dma_zone_size; | ||
| 941 | } | ||
| 942 | #endif | ||
| 943 | #ifdef CONFIG_MULTI_IRQ_HANDLER | 941 | #ifdef CONFIG_MULTI_IRQ_HANDLER |
| 944 | handle_arch_irq = mdesc->handle_irq; | 942 | handle_arch_irq = mdesc->handle_irq; |
| 945 | #endif | 943 | #endif |
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c index 1040c00405d0..8200deaa14f6 100644 --- a/arch/arm/kernel/topology.c +++ b/arch/arm/kernel/topology.c | |||
| @@ -43,7 +43,7 @@ | |||
| 43 | 43 | ||
| 44 | struct cputopo_arm cpu_topology[NR_CPUS]; | 44 | struct cputopo_arm cpu_topology[NR_CPUS]; |
| 45 | 45 | ||
| 46 | const struct cpumask *cpu_coregroup_mask(unsigned int cpu) | 46 | const struct cpumask *cpu_coregroup_mask(int cpu) |
| 47 | { | 47 | { |
| 48 | return &cpu_topology[cpu].core_sibling; | 48 | return &cpu_topology[cpu].core_sibling; |
| 49 | } | 49 | } |
diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c index e7e8365795c3..00df012c4678 100644 --- a/arch/arm/kernel/unwind.c +++ b/arch/arm/kernel/unwind.c | |||
| @@ -67,7 +67,7 @@ EXPORT_SYMBOL(__aeabi_unwind_cpp_pr2); | |||
| 67 | 67 | ||
| 68 | struct unwind_ctrl_block { | 68 | struct unwind_ctrl_block { |
| 69 | unsigned long vrs[16]; /* virtual register set */ | 69 | unsigned long vrs[16]; /* virtual register set */ |
| 70 | unsigned long *insn; /* pointer to the current instructions word */ | 70 | const unsigned long *insn; /* pointer to the current instructions word */ |
| 71 | int entries; /* number of entries left to interpret */ | 71 | int entries; /* number of entries left to interpret */ |
| 72 | int byte; /* current byte number in the instructions word */ | 72 | int byte; /* current byte number in the instructions word */ |
| 73 | }; | 73 | }; |
| @@ -83,8 +83,9 @@ enum regs { | |||
| 83 | PC = 15 | 83 | PC = 15 |
| 84 | }; | 84 | }; |
| 85 | 85 | ||
| 86 | extern struct unwind_idx __start_unwind_idx[]; | 86 | extern const struct unwind_idx __start_unwind_idx[]; |
| 87 | extern struct unwind_idx __stop_unwind_idx[]; | 87 | static const struct unwind_idx *__origin_unwind_idx; |
| 88 | extern const struct unwind_idx __stop_unwind_idx[]; | ||
| 88 | 89 | ||
| 89 | static DEFINE_SPINLOCK(unwind_lock); | 90 | static DEFINE_SPINLOCK(unwind_lock); |
| 90 | static LIST_HEAD(unwind_tables); | 91 | static LIST_HEAD(unwind_tables); |
| @@ -98,45 +99,99 @@ static LIST_HEAD(unwind_tables); | |||
| 98 | }) | 99 | }) |
| 99 | 100 | ||
| 100 | /* | 101 | /* |
| 101 | * Binary search in the unwind index. The entries entries are | 102 | * Binary search in the unwind index. The entries are |
| 102 | * guaranteed to be sorted in ascending order by the linker. | 103 | * guaranteed to be sorted in ascending order by the linker. |
| 104 | * | ||
| 105 | * start = first entry | ||
| 106 | * origin = first entry with positive offset (or stop if there is no such entry) | ||
| 107 | * stop - 1 = last entry | ||
| 103 | */ | 108 | */ |
| 104 | static struct unwind_idx *search_index(unsigned long addr, | 109 | static const struct unwind_idx *search_index(unsigned long addr, |
| 105 | struct unwind_idx *first, | 110 | const struct unwind_idx *start, |
| 106 | struct unwind_idx *last) | 111 | const struct unwind_idx *origin, |
| 112 | const struct unwind_idx *stop) | ||
| 107 | { | 113 | { |
| 108 | pr_debug("%s(%08lx, %p, %p)\n", __func__, addr, first, last); | 114 | unsigned long addr_prel31; |
| 115 | |||
| 116 | pr_debug("%s(%08lx, %p, %p, %p)\n", | ||
| 117 | __func__, addr, start, origin, stop); | ||
| 118 | |||
| 119 | /* | ||
| 120 | * only search in the section with the matching sign. This way the | ||
| 121 | * prel31 numbers can be compared as unsigned longs. | ||
| 122 | */ | ||
| 123 | if (addr < (unsigned long)start) | ||
| 124 | /* negative offsets: [start; origin) */ | ||
| 125 | stop = origin; | ||
| 126 | else | ||
| 127 | /* positive offsets: [origin; stop) */ | ||
| 128 | start = origin; | ||
| 129 | |||
| 130 | /* prel31 for address relavive to start */ | ||
| 131 | addr_prel31 = (addr - (unsigned long)start) & 0x7fffffff; | ||
| 109 | 132 | ||
| 110 | if (addr < first->addr) { | 133 | while (start < stop - 1) { |
| 134 | const struct unwind_idx *mid = start + ((stop - start) >> 1); | ||
| 135 | |||
| 136 | /* | ||
| 137 | * As addr_prel31 is relative to start an offset is needed to | ||
| 138 | * make it relative to mid. | ||
| 139 | */ | ||
| 140 | if (addr_prel31 - ((unsigned long)mid - (unsigned long)start) < | ||
| 141 | mid->addr_offset) | ||
| 142 | stop = mid; | ||
| 143 | else { | ||
| 144 | /* keep addr_prel31 relative to start */ | ||
| 145 | addr_prel31 -= ((unsigned long)mid - | ||
| 146 | (unsigned long)start); | ||
| 147 | start = mid; | ||
| 148 | } | ||
| 149 | } | ||
| 150 | |||
| 151 | if (likely(start->addr_offset <= addr_prel31)) | ||
| 152 | return start; | ||
| 153 | else { | ||
| 111 | pr_warning("unwind: Unknown symbol address %08lx\n", addr); | 154 | pr_warning("unwind: Unknown symbol address %08lx\n", addr); |
| 112 | return NULL; | 155 | return NULL; |
| 113 | } else if (addr >= last->addr) | 156 | } |
| 114 | return last; | 157 | } |
| 115 | 158 | ||
| 116 | while (first < last - 1) { | 159 | static const struct unwind_idx *unwind_find_origin( |
| 117 | struct unwind_idx *mid = first + ((last - first + 1) >> 1); | 160 | const struct unwind_idx *start, const struct unwind_idx *stop) |
| 161 | { | ||
| 162 | pr_debug("%s(%p, %p)\n", __func__, start, stop); | ||
| 163 | while (start < stop) { | ||
| 164 | const struct unwind_idx *mid = start + ((stop - start) >> 1); | ||
| 118 | 165 | ||
| 119 | if (addr < mid->addr) | 166 | if (mid->addr_offset >= 0x40000000) |
| 120 | last = mid; | 167 | /* negative offset */ |
| 168 | start = mid + 1; | ||
| 121 | else | 169 | else |
| 122 | first = mid; | 170 | /* positive offset */ |
| 171 | stop = mid; | ||
| 123 | } | 172 | } |
| 124 | 173 | pr_debug("%s -> %p\n", __func__, stop); | |
| 125 | return first; | 174 | return stop; |
| 126 | } | 175 | } |
| 127 | 176 | ||
| 128 | static struct unwind_idx *unwind_find_idx(unsigned long addr) | 177 | static const struct unwind_idx *unwind_find_idx(unsigned long addr) |
| 129 | { | 178 | { |
| 130 | struct unwind_idx *idx = NULL; | 179 | const struct unwind_idx *idx = NULL; |
| 131 | unsigned long flags; | 180 | unsigned long flags; |
| 132 | 181 | ||
| 133 | pr_debug("%s(%08lx)\n", __func__, addr); | 182 | pr_debug("%s(%08lx)\n", __func__, addr); |
| 134 | 183 | ||
| 135 | if (core_kernel_text(addr)) | 184 | if (core_kernel_text(addr)) { |
| 185 | if (unlikely(!__origin_unwind_idx)) | ||
| 186 | __origin_unwind_idx = | ||
| 187 | unwind_find_origin(__start_unwind_idx, | ||
| 188 | __stop_unwind_idx); | ||
| 189 | |||
| 136 | /* main unwind table */ | 190 | /* main unwind table */ |
| 137 | idx = search_index(addr, __start_unwind_idx, | 191 | idx = search_index(addr, __start_unwind_idx, |
| 138 | __stop_unwind_idx - 1); | 192 | __origin_unwind_idx, |
| 139 | else { | 193 | __stop_unwind_idx); |
| 194 | } else { | ||
| 140 | /* module unwind tables */ | 195 | /* module unwind tables */ |
| 141 | struct unwind_table *table; | 196 | struct unwind_table *table; |
| 142 | 197 | ||
| @@ -145,7 +200,8 @@ static struct unwind_idx *unwind_find_idx(unsigned long addr) | |||
| 145 | if (addr >= table->begin_addr && | 200 | if (addr >= table->begin_addr && |
| 146 | addr < table->end_addr) { | 201 | addr < table->end_addr) { |
| 147 | idx = search_index(addr, table->start, | 202 | idx = search_index(addr, table->start, |
| 148 | table->stop - 1); | 203 | table->origin, |
| 204 | table->stop); | ||
| 149 | /* Move-to-front to exploit common traces */ | 205 | /* Move-to-front to exploit common traces */ |
| 150 | list_move(&table->list, &unwind_tables); | 206 | list_move(&table->list, &unwind_tables); |
| 151 | break; | 207 | break; |
| @@ -274,7 +330,7 @@ static int unwind_exec_insn(struct unwind_ctrl_block *ctrl) | |||
| 274 | int unwind_frame(struct stackframe *frame) | 330 | int unwind_frame(struct stackframe *frame) |
| 275 | { | 331 | { |
| 276 | unsigned long high, low; | 332 | unsigned long high, low; |
| 277 | struct unwind_idx *idx; | 333 | const struct unwind_idx *idx; |
| 278 | struct unwind_ctrl_block ctrl; | 334 | struct unwind_ctrl_block ctrl; |
| 279 | 335 | ||
| 280 | /* only go to a higher address on the stack */ | 336 | /* only go to a higher address on the stack */ |
| @@ -399,7 +455,6 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, | |||
| 399 | unsigned long text_size) | 455 | unsigned long text_size) |
| 400 | { | 456 | { |
| 401 | unsigned long flags; | 457 | unsigned long flags; |
| 402 | struct unwind_idx *idx; | ||
| 403 | struct unwind_table *tab = kmalloc(sizeof(*tab), GFP_KERNEL); | 458 | struct unwind_table *tab = kmalloc(sizeof(*tab), GFP_KERNEL); |
| 404 | 459 | ||
| 405 | pr_debug("%s(%08lx, %08lx, %08lx, %08lx)\n", __func__, start, size, | 460 | pr_debug("%s(%08lx, %08lx, %08lx, %08lx)\n", __func__, start, size, |
| @@ -408,15 +463,12 @@ struct unwind_table *unwind_table_add(unsigned long start, unsigned long size, | |||
| 408 | if (!tab) | 463 | if (!tab) |
| 409 | return tab; | 464 | return tab; |
| 410 | 465 | ||
| 411 | tab->start = (struct unwind_idx *)start; | 466 | tab->start = (const struct unwind_idx *)start; |
| 412 | tab->stop = (struct unwind_idx *)(start + size); | 467 | tab->stop = (const struct unwind_idx *)(start + size); |
| 468 | tab->origin = unwind_find_origin(tab->start, tab->stop); | ||
| 413 | tab->begin_addr = text_addr; | 469 | tab->begin_addr = text_addr; |
| 414 | tab->end_addr = text_addr + text_size; | 470 | tab->end_addr = text_addr + text_size; |
| 415 | 471 | ||
| 416 | /* Convert the symbol addresses to absolute values */ | ||
| 417 | for (idx = tab->start; idx < tab->stop; idx++) | ||
| 418 | idx->addr = prel31_to_addr(&idx->addr); | ||
| 419 | |||
| 420 | spin_lock_irqsave(&unwind_lock, flags); | 472 | spin_lock_irqsave(&unwind_lock, flags); |
| 421 | list_add_tail(&tab->list, &unwind_tables); | 473 | list_add_tail(&tab->list, &unwind_tables); |
| 422 | spin_unlock_irqrestore(&unwind_lock, flags); | 474 | spin_unlock_irqrestore(&unwind_lock, flags); |
| @@ -437,16 +489,3 @@ void unwind_table_del(struct unwind_table *tab) | |||
| 437 | 489 | ||
| 438 | kfree(tab); | 490 | kfree(tab); |
| 439 | } | 491 | } |
| 440 | |||
| 441 | int __init unwind_init(void) | ||
| 442 | { | ||
| 443 | struct unwind_idx *idx; | ||
| 444 | |||
| 445 | /* Convert the symbol addresses to absolute values */ | ||
| 446 | for (idx = __start_unwind_idx; idx < __stop_unwind_idx; idx++) | ||
| 447 | idx->addr = prel31_to_addr(&idx->addr); | ||
| 448 | |||
| 449 | pr_debug("unwind: ARM stack unwinding initialised\n"); | ||
| 450 | |||
| 451 | return 0; | ||
| 452 | } | ||
diff --git a/arch/arm/lib/bitops.h b/arch/arm/lib/bitops.h index 10d868a5a481..d6408d1ee543 100644 --- a/arch/arm/lib/bitops.h +++ b/arch/arm/lib/bitops.h | |||
| @@ -1,5 +1,9 @@ | |||
| 1 | #include <asm/unwind.h> | ||
| 2 | |||
| 1 | #if __LINUX_ARM_ARCH__ >= 6 | 3 | #if __LINUX_ARM_ARCH__ >= 6 |
| 2 | .macro bitop, instr | 4 | .macro bitop, name, instr |
| 5 | ENTRY( \name ) | ||
| 6 | UNWIND( .fnstart ) | ||
| 3 | ands ip, r1, #3 | 7 | ands ip, r1, #3 |
| 4 | strneb r1, [ip] @ assert word-aligned | 8 | strneb r1, [ip] @ assert word-aligned |
| 5 | mov r2, #1 | 9 | mov r2, #1 |
| @@ -13,9 +17,13 @@ | |||
| 13 | cmp r0, #0 | 17 | cmp r0, #0 |
| 14 | bne 1b | 18 | bne 1b |
| 15 | bx lr | 19 | bx lr |
| 20 | UNWIND( .fnend ) | ||
| 21 | ENDPROC(\name ) | ||
| 16 | .endm | 22 | .endm |
| 17 | 23 | ||
| 18 | .macro testop, instr, store | 24 | .macro testop, name, instr, store |
| 25 | ENTRY( \name ) | ||
| 26 | UNWIND( .fnstart ) | ||
| 19 | ands ip, r1, #3 | 27 | ands ip, r1, #3 |
| 20 | strneb r1, [ip] @ assert word-aligned | 28 | strneb r1, [ip] @ assert word-aligned |
| 21 | mov r2, #1 | 29 | mov r2, #1 |
| @@ -34,9 +42,13 @@ | |||
| 34 | cmp r0, #0 | 42 | cmp r0, #0 |
| 35 | movne r0, #1 | 43 | movne r0, #1 |
| 36 | 2: bx lr | 44 | 2: bx lr |
| 45 | UNWIND( .fnend ) | ||
| 46 | ENDPROC(\name ) | ||
| 37 | .endm | 47 | .endm |
| 38 | #else | 48 | #else |
| 39 | .macro bitop, instr | 49 | .macro bitop, name, instr |
| 50 | ENTRY( \name ) | ||
| 51 | UNWIND( .fnstart ) | ||
| 40 | ands ip, r1, #3 | 52 | ands ip, r1, #3 |
| 41 | strneb r1, [ip] @ assert word-aligned | 53 | strneb r1, [ip] @ assert word-aligned |
| 42 | and r2, r0, #31 | 54 | and r2, r0, #31 |
| @@ -49,6 +61,8 @@ | |||
| 49 | str r2, [r1, r0, lsl #2] | 61 | str r2, [r1, r0, lsl #2] |
| 50 | restore_irqs ip | 62 | restore_irqs ip |
| 51 | mov pc, lr | 63 | mov pc, lr |
| 64 | UNWIND( .fnend ) | ||
| 65 | ENDPROC(\name ) | ||
| 52 | .endm | 66 | .endm |
| 53 | 67 | ||
| 54 | /** | 68 | /** |
| @@ -59,7 +73,9 @@ | |||
| 59 | * Note: we can trivially conditionalise the store instruction | 73 | * Note: we can trivially conditionalise the store instruction |
| 60 | * to avoid dirtying the data cache. | 74 | * to avoid dirtying the data cache. |
| 61 | */ | 75 | */ |
| 62 | .macro testop, instr, store | 76 | .macro testop, name, instr, store |
| 77 | ENTRY( \name ) | ||
| 78 | UNWIND( .fnstart ) | ||
| 63 | ands ip, r1, #3 | 79 | ands ip, r1, #3 |
| 64 | strneb r1, [ip] @ assert word-aligned | 80 | strneb r1, [ip] @ assert word-aligned |
| 65 | and r3, r0, #31 | 81 | and r3, r0, #31 |
| @@ -73,5 +89,7 @@ | |||
| 73 | moveq r0, #0 | 89 | moveq r0, #0 |
| 74 | restore_irqs ip | 90 | restore_irqs ip |
| 75 | mov pc, lr | 91 | mov pc, lr |
| 92 | UNWIND( .fnend ) | ||
| 93 | ENDPROC(\name ) | ||
| 76 | .endm | 94 | .endm |
| 77 | #endif | 95 | #endif |
diff --git a/arch/arm/lib/changebit.S b/arch/arm/lib/changebit.S index 68ed5b62e839..f4027862172f 100644 --- a/arch/arm/lib/changebit.S +++ b/arch/arm/lib/changebit.S | |||
| @@ -12,6 +12,4 @@ | |||
| 12 | #include "bitops.h" | 12 | #include "bitops.h" |
| 13 | .text | 13 | .text |
| 14 | 14 | ||
| 15 | ENTRY(_change_bit) | 15 | bitop _change_bit, eor |
| 16 | bitop eor | ||
| 17 | ENDPROC(_change_bit) | ||
diff --git a/arch/arm/lib/clearbit.S b/arch/arm/lib/clearbit.S index 4c04c3b51eeb..f6b75fb64d30 100644 --- a/arch/arm/lib/clearbit.S +++ b/arch/arm/lib/clearbit.S | |||
| @@ -12,6 +12,4 @@ | |||
| 12 | #include "bitops.h" | 12 | #include "bitops.h" |
| 13 | .text | 13 | .text |
| 14 | 14 | ||
| 15 | ENTRY(_clear_bit) | 15 | bitop _clear_bit, bic |
| 16 | bitop bic | ||
| 17 | ENDPROC(_clear_bit) | ||
diff --git a/arch/arm/lib/setbit.S b/arch/arm/lib/setbit.S index bbee5c66a23e..618fedae4b37 100644 --- a/arch/arm/lib/setbit.S +++ b/arch/arm/lib/setbit.S | |||
| @@ -12,6 +12,4 @@ | |||
| 12 | #include "bitops.h" | 12 | #include "bitops.h" |
| 13 | .text | 13 | .text |
| 14 | 14 | ||
| 15 | ENTRY(_set_bit) | 15 | bitop _set_bit, orr |
| 16 | bitop orr | ||
| 17 | ENDPROC(_set_bit) | ||
diff --git a/arch/arm/lib/testchangebit.S b/arch/arm/lib/testchangebit.S index 15a4d431f229..4becdc3a59cb 100644 --- a/arch/arm/lib/testchangebit.S +++ b/arch/arm/lib/testchangebit.S | |||
| @@ -12,6 +12,4 @@ | |||
| 12 | #include "bitops.h" | 12 | #include "bitops.h" |
| 13 | .text | 13 | .text |
| 14 | 14 | ||
| 15 | ENTRY(_test_and_change_bit) | 15 | testop _test_and_change_bit, eor, str |
| 16 | testop eor, str | ||
| 17 | ENDPROC(_test_and_change_bit) | ||
diff --git a/arch/arm/lib/testclearbit.S b/arch/arm/lib/testclearbit.S index 521b66b5b95d..918841dcce7a 100644 --- a/arch/arm/lib/testclearbit.S +++ b/arch/arm/lib/testclearbit.S | |||
| @@ -12,6 +12,4 @@ | |||
| 12 | #include "bitops.h" | 12 | #include "bitops.h" |
| 13 | .text | 13 | .text |
| 14 | 14 | ||
| 15 | ENTRY(_test_and_clear_bit) | 15 | testop _test_and_clear_bit, bicne, strne |
| 16 | testop bicne, strne | ||
| 17 | ENDPROC(_test_and_clear_bit) | ||
diff --git a/arch/arm/lib/testsetbit.S b/arch/arm/lib/testsetbit.S index 1c98cc2185bb..8d1b2fe9e487 100644 --- a/arch/arm/lib/testsetbit.S +++ b/arch/arm/lib/testsetbit.S | |||
| @@ -12,6 +12,4 @@ | |||
| 12 | #include "bitops.h" | 12 | #include "bitops.h" |
| 13 | .text | 13 | .text |
| 14 | 14 | ||
| 15 | ENTRY(_test_and_set_bit) | 15 | testop _test_and_set_bit, orreq, streq |
| 16 | testop orreq, streq | ||
| 17 | ENDPROC(_test_and_set_bit) | ||
diff --git a/arch/arm/mach-at91/at91rm9200_devices.c b/arch/arm/mach-at91/at91rm9200_devices.c index 66591fa53e05..ad930688358c 100644 --- a/arch/arm/mach-at91/at91rm9200_devices.c +++ b/arch/arm/mach-at91/at91rm9200_devices.c | |||
| @@ -83,7 +83,7 @@ void __init at91_add_device_usbh(struct at91_usbh_data *data) {} | |||
| 83 | * USB Device (Gadget) | 83 | * USB Device (Gadget) |
| 84 | * -------------------------------------------------------------------- */ | 84 | * -------------------------------------------------------------------- */ |
| 85 | 85 | ||
| 86 | #ifdef CONFIG_USB_GADGET_AT91 | 86 | #ifdef CONFIG_USB_AT91 |
| 87 | static struct at91_udc_data udc_data; | 87 | static struct at91_udc_data udc_data; |
| 88 | 88 | ||
| 89 | static struct resource udc_resources[] = { | 89 | static struct resource udc_resources[] = { |
diff --git a/arch/arm/mach-at91/at91sam9260.c b/arch/arm/mach-at91/at91sam9260.c index b84a9f642f59..0d20677fbef0 100644 --- a/arch/arm/mach-at91/at91sam9260.c +++ b/arch/arm/mach-at91/at91sam9260.c | |||
| @@ -195,9 +195,9 @@ static struct clk_lookup periph_clocks_lookups[] = { | |||
| 195 | CLKDEV_CON_DEV_ID("t0_clk", "atmel_tcb.0", &tc0_clk), | 195 | CLKDEV_CON_DEV_ID("t0_clk", "atmel_tcb.0", &tc0_clk), |
| 196 | CLKDEV_CON_DEV_ID("t1_clk", "atmel_tcb.0", &tc1_clk), | 196 | CLKDEV_CON_DEV_ID("t1_clk", "atmel_tcb.0", &tc1_clk), |
| 197 | CLKDEV_CON_DEV_ID("t2_clk", "atmel_tcb.0", &tc2_clk), | 197 | CLKDEV_CON_DEV_ID("t2_clk", "atmel_tcb.0", &tc2_clk), |
| 198 | CLKDEV_CON_DEV_ID("t3_clk", "atmel_tcb.1", &tc3_clk), | 198 | CLKDEV_CON_DEV_ID("t0_clk", "atmel_tcb.1", &tc3_clk), |
| 199 | CLKDEV_CON_DEV_ID("t4_clk", "atmel_tcb.1", &tc4_clk), | 199 | CLKDEV_CON_DEV_ID("t1_clk", "atmel_tcb.1", &tc4_clk), |
| 200 | CLKDEV_CON_DEV_ID("t5_clk", "atmel_tcb.1", &tc5_clk), | 200 | CLKDEV_CON_DEV_ID("t2_clk", "atmel_tcb.1", &tc5_clk), |
| 201 | CLKDEV_CON_DEV_ID("pclk", "ssc.0", &ssc_clk), | 201 | CLKDEV_CON_DEV_ID("pclk", "ssc.0", &ssc_clk), |
| 202 | /* more usart lookup table for DT entries */ | 202 | /* more usart lookup table for DT entries */ |
| 203 | CLKDEV_CON_DEV_ID("usart", "fffff200.serial", &mck), | 203 | CLKDEV_CON_DEV_ID("usart", "fffff200.serial", &mck), |
diff --git a/arch/arm/mach-at91/at91sam9260_devices.c b/arch/arm/mach-at91/at91sam9260_devices.c index 25e3464fb07f..629fa9774972 100644 --- a/arch/arm/mach-at91/at91sam9260_devices.c +++ b/arch/arm/mach-at91/at91sam9260_devices.c | |||
| @@ -84,7 +84,7 @@ void __init at91_add_device_usbh(struct at91_usbh_data *data) {} | |||
| 84 | * USB Device (Gadget) | 84 | * USB Device (Gadget) |
| 85 | * -------------------------------------------------------------------- */ | 85 | * -------------------------------------------------------------------- */ |
| 86 | 86 | ||
| 87 | #ifdef CONFIG_USB_GADGET_AT91 | 87 | #ifdef CONFIG_USB_AT91 |
| 88 | static struct at91_udc_data udc_data; | 88 | static struct at91_udc_data udc_data; |
| 89 | 89 | ||
| 90 | static struct resource udc_resources[] = { | 90 | static struct resource udc_resources[] = { |
diff --git a/arch/arm/mach-at91/at91sam9261_devices.c b/arch/arm/mach-at91/at91sam9261_devices.c index ae78f4d03b73..a178b58b0b9c 100644 --- a/arch/arm/mach-at91/at91sam9261_devices.c +++ b/arch/arm/mach-at91/at91sam9261_devices.c | |||
| @@ -87,7 +87,7 @@ void __init at91_add_device_usbh(struct at91_usbh_data *data) {} | |||
| 87 | * USB Device (Gadget) | 87 | * USB Device (Gadget) |
| 88 | * -------------------------------------------------------------------- */ | 88 | * -------------------------------------------------------------------- */ |
| 89 | 89 | ||
| 90 | #ifdef CONFIG_USB_GADGET_AT91 | 90 | #ifdef CONFIG_USB_AT91 |
| 91 | static struct at91_udc_data udc_data; | 91 | static struct at91_udc_data udc_data; |
| 92 | 92 | ||
| 93 | static struct resource udc_resources[] = { | 93 | static struct resource udc_resources[] = { |
diff --git a/arch/arm/mach-at91/at91sam9263_devices.c b/arch/arm/mach-at91/at91sam9263_devices.c index ad017eb1f8df..d5fbac9ff4fa 100644 --- a/arch/arm/mach-at91/at91sam9263_devices.c +++ b/arch/arm/mach-at91/at91sam9263_devices.c | |||
| @@ -92,7 +92,7 @@ void __init at91_add_device_usbh(struct at91_usbh_data *data) {} | |||
| 92 | * USB Device (Gadget) | 92 | * USB Device (Gadget) |
| 93 | * -------------------------------------------------------------------- */ | 93 | * -------------------------------------------------------------------- */ |
| 94 | 94 | ||
| 95 | #ifdef CONFIG_USB_GADGET_AT91 | 95 | #ifdef CONFIG_USB_AT91 |
| 96 | static struct at91_udc_data udc_data; | 96 | static struct at91_udc_data udc_data; |
| 97 | 97 | ||
| 98 | static struct resource udc_resources[] = { | 98 | static struct resource udc_resources[] = { |
diff --git a/arch/arm/mach-at91/include/mach/system_rev.h b/arch/arm/mach-at91/include/mach/system_rev.h index 8f4866045b41..ec164a4124c9 100644 --- a/arch/arm/mach-at91/include/mach/system_rev.h +++ b/arch/arm/mach-at91/include/mach/system_rev.h | |||
| @@ -19,7 +19,7 @@ | |||
| 19 | #define BOARD_HAVE_NAND_16BIT (1 << 31) | 19 | #define BOARD_HAVE_NAND_16BIT (1 << 31) |
| 20 | static inline int board_have_nand_16bit(void) | 20 | static inline int board_have_nand_16bit(void) |
| 21 | { | 21 | { |
| 22 | return system_rev & BOARD_HAVE_NAND_16BIT; | 22 | return (system_rev & BOARD_HAVE_NAND_16BIT) ? 1 : 0; |
| 23 | } | 23 | } |
| 24 | 24 | ||
| 25 | #endif /* __ARCH_SYSTEM_REV_H__ */ | 25 | #endif /* __ARCH_SYSTEM_REV_H__ */ |
diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c index 1d7d24995226..6659a90dbcad 100644 --- a/arch/arm/mach-davinci/board-da850-evm.c +++ b/arch/arm/mach-davinci/board-da850-evm.c | |||
| @@ -753,7 +753,7 @@ static struct snd_platform_data da850_evm_snd_data = { | |||
| 753 | .num_serializer = ARRAY_SIZE(da850_iis_serializer_direction), | 753 | .num_serializer = ARRAY_SIZE(da850_iis_serializer_direction), |
| 754 | .tdm_slots = 2, | 754 | .tdm_slots = 2, |
| 755 | .serial_dir = da850_iis_serializer_direction, | 755 | .serial_dir = da850_iis_serializer_direction, |
| 756 | .asp_chan_q = EVENTQ_1, | 756 | .asp_chan_q = EVENTQ_0, |
| 757 | .version = MCASP_VERSION_2, | 757 | .version = MCASP_VERSION_2, |
| 758 | .txnumevt = 1, | 758 | .txnumevt = 1, |
| 759 | .rxnumevt = 1, | 759 | .rxnumevt = 1, |
diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c index 1918ae711428..46e1f4173b97 100644 --- a/arch/arm/mach-davinci/board-dm365-evm.c +++ b/arch/arm/mach-davinci/board-dm365-evm.c | |||
| @@ -107,7 +107,7 @@ static struct mtd_partition davinci_nand_partitions[] = { | |||
| 107 | /* UBL (a few copies) plus U-Boot */ | 107 | /* UBL (a few copies) plus U-Boot */ |
| 108 | .name = "bootloader", | 108 | .name = "bootloader", |
| 109 | .offset = 0, | 109 | .offset = 0, |
| 110 | .size = 28 * NAND_BLOCK_SIZE, | 110 | .size = 30 * NAND_BLOCK_SIZE, |
| 111 | .mask_flags = MTD_WRITEABLE, /* force read-only */ | 111 | .mask_flags = MTD_WRITEABLE, /* force read-only */ |
| 112 | }, { | 112 | }, { |
| 113 | /* U-Boot environment */ | 113 | /* U-Boot environment */ |
diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c index e574d7f837a8..635bf7740157 100644 --- a/arch/arm/mach-davinci/board-dm646x-evm.c +++ b/arch/arm/mach-davinci/board-dm646x-evm.c | |||
| @@ -564,7 +564,7 @@ static int setup_vpif_input_channel_mode(int mux_mode) | |||
| 564 | int val; | 564 | int val; |
| 565 | u32 value; | 565 | u32 value; |
| 566 | 566 | ||
| 567 | if (!vpif_vsclkdis_reg || !cpld_client) | 567 | if (!vpif_vidclkctl_reg || !cpld_client) |
| 568 | return -ENXIO; | 568 | return -ENXIO; |
| 569 | 569 | ||
| 570 | val = i2c_smbus_read_byte(cpld_client); | 570 | val = i2c_smbus_read_byte(cpld_client); |
| @@ -572,7 +572,7 @@ static int setup_vpif_input_channel_mode(int mux_mode) | |||
| 572 | return val; | 572 | return val; |
| 573 | 573 | ||
| 574 | spin_lock_irqsave(&vpif_reg_lock, flags); | 574 | spin_lock_irqsave(&vpif_reg_lock, flags); |
| 575 | value = __raw_readl(vpif_vsclkdis_reg); | 575 | value = __raw_readl(vpif_vidclkctl_reg); |
| 576 | if (mux_mode) { | 576 | if (mux_mode) { |
| 577 | val &= VPIF_INPUT_TWO_CHANNEL; | 577 | val &= VPIF_INPUT_TWO_CHANNEL; |
| 578 | value |= VIDCH1CLK; | 578 | value |= VIDCH1CLK; |
| @@ -580,7 +580,7 @@ static int setup_vpif_input_channel_mode(int mux_mode) | |||
| 580 | val |= VPIF_INPUT_ONE_CHANNEL; | 580 | val |= VPIF_INPUT_ONE_CHANNEL; |
| 581 | value &= ~VIDCH1CLK; | 581 | value &= ~VIDCH1CLK; |
| 582 | } | 582 | } |
| 583 | __raw_writel(value, vpif_vsclkdis_reg); | 583 | __raw_writel(value, vpif_vidclkctl_reg); |
| 584 | spin_unlock_irqrestore(&vpif_reg_lock, flags); | 584 | spin_unlock_irqrestore(&vpif_reg_lock, flags); |
| 585 | 585 | ||
| 586 | err = i2c_smbus_write_byte(cpld_client, val); | 586 | err = i2c_smbus_write_byte(cpld_client, val); |
diff --git a/arch/arm/mach-davinci/dm646x.c b/arch/arm/mach-davinci/dm646x.c index 0b68ed534f8e..af27c130595f 100644 --- a/arch/arm/mach-davinci/dm646x.c +++ b/arch/arm/mach-davinci/dm646x.c | |||
| @@ -161,7 +161,6 @@ static struct clk dsp_clk = { | |||
| 161 | .name = "dsp", | 161 | .name = "dsp", |
| 162 | .parent = &pll1_sysclk1, | 162 | .parent = &pll1_sysclk1, |
| 163 | .lpsc = DM646X_LPSC_C64X_CPU, | 163 | .lpsc = DM646X_LPSC_C64X_CPU, |
| 164 | .flags = PSC_DSP, | ||
| 165 | .usecount = 1, /* REVISIT how to disable? */ | 164 | .usecount = 1, /* REVISIT how to disable? */ |
| 166 | }; | 165 | }; |
| 167 | 166 | ||
diff --git a/arch/arm/mach-davinci/include/mach/psc.h b/arch/arm/mach-davinci/include/mach/psc.h index fa59c097223d..8bc3fc256171 100644 --- a/arch/arm/mach-davinci/include/mach/psc.h +++ b/arch/arm/mach-davinci/include/mach/psc.h | |||
| @@ -233,7 +233,7 @@ | |||
| 233 | #define PTCMD 0x120 | 233 | #define PTCMD 0x120 |
| 234 | #define PTSTAT 0x128 | 234 | #define PTSTAT 0x128 |
| 235 | #define PDSTAT 0x200 | 235 | #define PDSTAT 0x200 |
| 236 | #define PDCTL1 0x304 | 236 | #define PDCTL 0x300 |
| 237 | #define MDSTAT 0x800 | 237 | #define MDSTAT 0x800 |
| 238 | #define MDCTL 0xA00 | 238 | #define MDCTL 0xA00 |
| 239 | 239 | ||
| @@ -244,7 +244,10 @@ | |||
| 244 | #define PSC_STATE_ENABLE 3 | 244 | #define PSC_STATE_ENABLE 3 |
| 245 | 245 | ||
| 246 | #define MDSTAT_STATE_MASK 0x3f | 246 | #define MDSTAT_STATE_MASK 0x3f |
| 247 | #define PDSTAT_STATE_MASK 0x1f | ||
| 247 | #define MDCTL_FORCE BIT(31) | 248 | #define MDCTL_FORCE BIT(31) |
| 249 | #define PDCTL_NEXT BIT(1) | ||
| 250 | #define PDCTL_EPCGOOD BIT(8) | ||
| 248 | 251 | ||
| 249 | #ifndef __ASSEMBLER__ | 252 | #ifndef __ASSEMBLER__ |
| 250 | 253 | ||
diff --git a/arch/arm/mach-davinci/psc.c b/arch/arm/mach-davinci/psc.c index 1fb6bdff38c1..d7e210f4b55c 100644 --- a/arch/arm/mach-davinci/psc.c +++ b/arch/arm/mach-davinci/psc.c | |||
| @@ -52,7 +52,7 @@ int __init davinci_psc_is_clk_active(unsigned int ctlr, unsigned int id) | |||
| 52 | void davinci_psc_config(unsigned int domain, unsigned int ctlr, | 52 | void davinci_psc_config(unsigned int domain, unsigned int ctlr, |
| 53 | unsigned int id, bool enable, u32 flags) | 53 | unsigned int id, bool enable, u32 flags) |
| 54 | { | 54 | { |
| 55 | u32 epcpr, ptcmd, ptstat, pdstat, pdctl1, mdstat, mdctl; | 55 | u32 epcpr, ptcmd, ptstat, pdstat, pdctl, mdstat, mdctl; |
| 56 | void __iomem *psc_base; | 56 | void __iomem *psc_base; |
| 57 | struct davinci_soc_info *soc_info = &davinci_soc_info; | 57 | struct davinci_soc_info *soc_info = &davinci_soc_info; |
| 58 | u32 next_state = PSC_STATE_ENABLE; | 58 | u32 next_state = PSC_STATE_ENABLE; |
| @@ -79,11 +79,11 @@ void davinci_psc_config(unsigned int domain, unsigned int ctlr, | |||
| 79 | mdctl |= MDCTL_FORCE; | 79 | mdctl |= MDCTL_FORCE; |
| 80 | __raw_writel(mdctl, psc_base + MDCTL + 4 * id); | 80 | __raw_writel(mdctl, psc_base + MDCTL + 4 * id); |
| 81 | 81 | ||
| 82 | pdstat = __raw_readl(psc_base + PDSTAT); | 82 | pdstat = __raw_readl(psc_base + PDSTAT + 4 * domain); |
| 83 | if ((pdstat & 0x00000001) == 0) { | 83 | if ((pdstat & PDSTAT_STATE_MASK) == 0) { |
| 84 | pdctl1 = __raw_readl(psc_base + PDCTL1); | 84 | pdctl = __raw_readl(psc_base + PDCTL + 4 * domain); |
| 85 | pdctl1 |= 0x1; | 85 | pdctl |= PDCTL_NEXT; |
| 86 | __raw_writel(pdctl1, psc_base + PDCTL1); | 86 | __raw_writel(pdctl, psc_base + PDCTL + 4 * domain); |
| 87 | 87 | ||
| 88 | ptcmd = 1 << domain; | 88 | ptcmd = 1 << domain; |
| 89 | __raw_writel(ptcmd, psc_base + PTCMD); | 89 | __raw_writel(ptcmd, psc_base + PTCMD); |
| @@ -92,9 +92,9 @@ void davinci_psc_config(unsigned int domain, unsigned int ctlr, | |||
| 92 | epcpr = __raw_readl(psc_base + EPCPR); | 92 | epcpr = __raw_readl(psc_base + EPCPR); |
| 93 | } while ((((epcpr >> domain) & 1) == 0)); | 93 | } while ((((epcpr >> domain) & 1) == 0)); |
| 94 | 94 | ||
| 95 | pdctl1 = __raw_readl(psc_base + PDCTL1); | 95 | pdctl = __raw_readl(psc_base + PDCTL + 4 * domain); |
| 96 | pdctl1 |= 0x100; | 96 | pdctl |= PDCTL_EPCGOOD; |
| 97 | __raw_writel(pdctl1, psc_base + PDCTL1); | 97 | __raw_writel(pdctl, psc_base + PDCTL + 4 * domain); |
| 98 | } else { | 98 | } else { |
| 99 | ptcmd = 1 << domain; | 99 | ptcmd = 1 << domain; |
| 100 | __raw_writel(ptcmd, psc_base + PTCMD); | 100 | __raw_writel(ptcmd, psc_base + PTCMD); |
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 35f6502144ae..4ebb382c5979 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c | |||
| @@ -12,6 +12,8 @@ | |||
| 12 | #include <linux/init.h> | 12 | #include <linux/init.h> |
| 13 | #include <linux/cpuidle.h> | 13 | #include <linux/cpuidle.h> |
| 14 | #include <linux/io.h> | 14 | #include <linux/io.h> |
| 15 | #include <linux/export.h> | ||
| 16 | #include <linux/time.h> | ||
| 15 | 17 | ||
| 16 | #include <asm/proc-fns.h> | 18 | #include <asm/proc-fns.h> |
| 17 | 19 | ||
diff --git a/arch/arm/mach-exynos/mct.c b/arch/arm/mach-exynos/mct.c index 97343df8f132..85b5527d0918 100644 --- a/arch/arm/mach-exynos/mct.c +++ b/arch/arm/mach-exynos/mct.c | |||
| @@ -44,8 +44,6 @@ struct mct_clock_event_device { | |||
| 44 | char name[10]; | 44 | char name[10]; |
| 45 | }; | 45 | }; |
| 46 | 46 | ||
| 47 | static DEFINE_PER_CPU(struct mct_clock_event_device, percpu_mct_tick); | ||
| 48 | |||
| 49 | static void exynos4_mct_write(unsigned int value, void *addr) | 47 | static void exynos4_mct_write(unsigned int value, void *addr) |
| 50 | { | 48 | { |
| 51 | void __iomem *stat_addr; | 49 | void __iomem *stat_addr; |
| @@ -264,6 +262,9 @@ static void exynos4_clockevent_init(void) | |||
| 264 | } | 262 | } |
| 265 | 263 | ||
| 266 | #ifdef CONFIG_LOCAL_TIMERS | 264 | #ifdef CONFIG_LOCAL_TIMERS |
| 265 | |||
| 266 | static DEFINE_PER_CPU(struct mct_clock_event_device, percpu_mct_tick); | ||
| 267 | |||
| 267 | /* Clock event handling */ | 268 | /* Clock event handling */ |
| 268 | static void exynos4_mct_tick_stop(struct mct_clock_event_device *mevt) | 269 | static void exynos4_mct_tick_stop(struct mct_clock_event_device *mevt) |
| 269 | { | 270 | { |
| @@ -428,9 +429,13 @@ int __cpuinit local_timer_setup(struct clock_event_device *evt) | |||
| 428 | 429 | ||
| 429 | void local_timer_stop(struct clock_event_device *evt) | 430 | void local_timer_stop(struct clock_event_device *evt) |
| 430 | { | 431 | { |
| 432 | unsigned int cpu = smp_processor_id(); | ||
| 431 | evt->set_mode(CLOCK_EVT_MODE_UNUSED, evt); | 433 | evt->set_mode(CLOCK_EVT_MODE_UNUSED, evt); |
| 432 | if (mct_int_type == MCT_INT_SPI) | 434 | if (mct_int_type == MCT_INT_SPI) |
| 433 | disable_irq(evt->irq); | 435 | if (cpu == 0) |
| 436 | remove_irq(evt->irq, &mct_tick0_event_irq); | ||
| 437 | else | ||
| 438 | remove_irq(evt->irq, &mct_tick1_event_irq); | ||
| 434 | else | 439 | else |
| 435 | disable_percpu_irq(IRQ_MCT_LOCALTIMER); | 440 | disable_percpu_irq(IRQ_MCT_LOCALTIMER); |
| 436 | } | 441 | } |
| @@ -443,6 +448,7 @@ static void __init exynos4_timer_resources(void) | |||
| 443 | 448 | ||
| 444 | clk_rate = clk_get_rate(mct_clk); | 449 | clk_rate = clk_get_rate(mct_clk); |
| 445 | 450 | ||
| 451 | #ifdef CONFIG_LOCAL_TIMERS | ||
| 446 | if (mct_int_type == MCT_INT_PPI) { | 452 | if (mct_int_type == MCT_INT_PPI) { |
| 447 | int err; | 453 | int err; |
| 448 | 454 | ||
| @@ -452,6 +458,7 @@ static void __init exynos4_timer_resources(void) | |||
| 452 | WARN(err, "MCT: can't request IRQ %d (%d)\n", | 458 | WARN(err, "MCT: can't request IRQ %d (%d)\n", |
| 453 | IRQ_MCT_LOCALTIMER, err); | 459 | IRQ_MCT_LOCALTIMER, err); |
| 454 | } | 460 | } |
| 461 | #endif /* CONFIG_LOCAL_TIMERS */ | ||
| 455 | } | 462 | } |
| 456 | 463 | ||
| 457 | static void __init exynos4_timer_init(void) | 464 | static void __init exynos4_timer_init(void) |
diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c index b82dcf08e747..88660d500f5b 100644 --- a/arch/arm/mach-highbank/highbank.c +++ b/arch/arm/mach-highbank/highbank.c | |||
| @@ -22,6 +22,7 @@ | |||
| 22 | #include <linux/of_irq.h> | 22 | #include <linux/of_irq.h> |
| 23 | #include <linux/of_platform.h> | 23 | #include <linux/of_platform.h> |
| 24 | #include <linux/of_address.h> | 24 | #include <linux/of_address.h> |
| 25 | #include <linux/smp.h> | ||
| 25 | 26 | ||
| 26 | #include <asm/cacheflush.h> | 27 | #include <asm/cacheflush.h> |
| 27 | #include <asm/unified.h> | 28 | #include <asm/unified.h> |
| @@ -72,6 +73,9 @@ static void __init highbank_map_io(void) | |||
| 72 | 73 | ||
| 73 | void highbank_set_cpu_jump(int cpu, void *jump_addr) | 74 | void highbank_set_cpu_jump(int cpu, void *jump_addr) |
| 74 | { | 75 | { |
| 76 | #ifdef CONFIG_SMP | ||
| 77 | cpu = cpu_logical_map(cpu); | ||
| 78 | #endif | ||
| 75 | writel(BSYM(virt_to_phys(jump_addr)), HB_JUMP_TABLE_VIRT(cpu)); | 79 | writel(BSYM(virt_to_phys(jump_addr)), HB_JUMP_TABLE_VIRT(cpu)); |
| 76 | __cpuc_flush_dcache_area(HB_JUMP_TABLE_VIRT(cpu), 16); | 80 | __cpuc_flush_dcache_area(HB_JUMP_TABLE_VIRT(cpu), 16); |
| 77 | outer_clean_range(HB_JUMP_TABLE_PHYS(cpu), | 81 | outer_clean_range(HB_JUMP_TABLE_PHYS(cpu), |
diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig index 5f7f9c2a34ae..c44aa974e79c 100644 --- a/arch/arm/mach-imx/Kconfig +++ b/arch/arm/mach-imx/Kconfig | |||
| @@ -10,11 +10,6 @@ config HAVE_IMX_MMDC | |||
| 10 | config HAVE_IMX_SRC | 10 | config HAVE_IMX_SRC |
| 11 | bool | 11 | bool |
| 12 | 12 | ||
| 13 | # | ||
| 14 | # ARCH_MX31 and ARCH_MX35 are left for compatibility | ||
| 15 | # Some usages assume that having one of them implies not having (e.g.) ARCH_MX2. | ||
| 16 | # To easily distinguish good and reviewed from unreviewed usages new (and IMHO | ||
| 17 | # more sensible) names are used: SOC_IMX31 and SOC_IMX35 | ||
| 18 | config ARCH_MX1 | 13 | config ARCH_MX1 |
| 19 | bool | 14 | bool |
| 20 | 15 | ||
| @@ -27,12 +22,6 @@ config ARCH_MX25 | |||
| 27 | config MACH_MX27 | 22 | config MACH_MX27 |
| 28 | bool | 23 | bool |
| 29 | 24 | ||
| 30 | config ARCH_MX31 | ||
| 31 | bool | ||
| 32 | |||
| 33 | config ARCH_MX35 | ||
| 34 | bool | ||
| 35 | |||
| 36 | config SOC_IMX1 | 25 | config SOC_IMX1 |
| 37 | bool | 26 | bool |
| 38 | select ARCH_MX1 | 27 | select ARCH_MX1 |
| @@ -72,7 +61,6 @@ config SOC_IMX31 | |||
| 72 | select CPU_V6 | 61 | select CPU_V6 |
| 73 | select IMX_HAVE_PLATFORM_MXC_RNGA | 62 | select IMX_HAVE_PLATFORM_MXC_RNGA |
| 74 | select ARCH_MXC_AUDMUX_V2 | 63 | select ARCH_MXC_AUDMUX_V2 |
| 75 | select ARCH_MX31 | ||
| 76 | select MXC_AVIC | 64 | select MXC_AVIC |
| 77 | select SMP_ON_UP if SMP | 65 | select SMP_ON_UP if SMP |
| 78 | 66 | ||
| @@ -82,7 +70,6 @@ config SOC_IMX35 | |||
| 82 | select ARCH_MXC_IOMUX_V3 | 70 | select ARCH_MXC_IOMUX_V3 |
| 83 | select ARCH_MXC_AUDMUX_V2 | 71 | select ARCH_MXC_AUDMUX_V2 |
| 84 | select HAVE_EPIT | 72 | select HAVE_EPIT |
| 85 | select ARCH_MX35 | ||
| 86 | select MXC_AVIC | 73 | select MXC_AVIC |
| 87 | select SMP_ON_UP if SMP | 74 | select SMP_ON_UP if SMP |
| 88 | 75 | ||
diff --git a/arch/arm/mach-imx/clock-imx6q.c b/arch/arm/mach-imx/clock-imx6q.c index 613a1b993bff..039a7abb165a 100644 --- a/arch/arm/mach-imx/clock-imx6q.c +++ b/arch/arm/mach-imx/clock-imx6q.c | |||
| @@ -1953,14 +1953,17 @@ static struct map_desc imx6q_clock_desc[] = { | |||
| 1953 | imx_map_entry(MX6Q, ANATOP, MT_DEVICE), | 1953 | imx_map_entry(MX6Q, ANATOP, MT_DEVICE), |
| 1954 | }; | 1954 | }; |
| 1955 | 1955 | ||
| 1956 | void __init imx6q_clock_map_io(void) | ||
| 1957 | { | ||
| 1958 | iotable_init(imx6q_clock_desc, ARRAY_SIZE(imx6q_clock_desc)); | ||
| 1959 | } | ||
| 1960 | |||
| 1956 | int __init mx6q_clocks_init(void) | 1961 | int __init mx6q_clocks_init(void) |
| 1957 | { | 1962 | { |
| 1958 | struct device_node *np; | 1963 | struct device_node *np; |
| 1959 | void __iomem *base; | 1964 | void __iomem *base; |
| 1960 | int i, irq; | 1965 | int i, irq; |
| 1961 | 1966 | ||
| 1962 | iotable_init(imx6q_clock_desc, ARRAY_SIZE(imx6q_clock_desc)); | ||
| 1963 | |||
| 1964 | /* retrieve the freqency of fixed clocks from device tree */ | 1967 | /* retrieve the freqency of fixed clocks from device tree */ |
| 1965 | for_each_compatible_node(np, NULL, "fixed-clock") { | 1968 | for_each_compatible_node(np, NULL, "fixed-clock") { |
| 1966 | u32 rate; | 1969 | u32 rate; |
diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c index 8bf5fa349484..8deb012189b5 100644 --- a/arch/arm/mach-imx/mach-imx6q.c +++ b/arch/arm/mach-imx/mach-imx6q.c | |||
| @@ -34,16 +34,18 @@ static void __init imx6q_map_io(void) | |||
| 34 | { | 34 | { |
| 35 | imx_lluart_map_io(); | 35 | imx_lluart_map_io(); |
| 36 | imx_scu_map_io(); | 36 | imx_scu_map_io(); |
| 37 | imx6q_clock_map_io(); | ||
| 37 | } | 38 | } |
| 38 | 39 | ||
| 39 | static void __init imx6q_gpio_add_irq_domain(struct device_node *np, | 40 | static int __init imx6q_gpio_add_irq_domain(struct device_node *np, |
| 40 | struct device_node *interrupt_parent) | 41 | struct device_node *interrupt_parent) |
| 41 | { | 42 | { |
| 42 | static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS - | 43 | static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS; |
| 43 | 32 * 7; /* imx6q gets 7 gpio ports */ | ||
| 44 | 44 | ||
| 45 | gpio_irq_base -= 32; | ||
| 45 | irq_domain_add_simple(np, gpio_irq_base); | 46 | irq_domain_add_simple(np, gpio_irq_base); |
| 46 | gpio_irq_base += 32; | 47 | |
| 48 | return 0; | ||
| 47 | } | 49 | } |
| 48 | 50 | ||
| 49 | static const struct of_device_id imx6q_irq_match[] __initconst = { | 51 | static const struct of_device_id imx6q_irq_match[] __initconst = { |
diff --git a/arch/arm/mach-imx/mm-imx3.c b/arch/arm/mach-imx/mm-imx3.c index 9f0e82ec3398..31807d2a8b7b 100644 --- a/arch/arm/mach-imx/mm-imx3.c +++ b/arch/arm/mach-imx/mm-imx3.c | |||
| @@ -33,29 +33,32 @@ | |||
| 33 | static void imx3_idle(void) | 33 | static void imx3_idle(void) |
| 34 | { | 34 | { |
| 35 | unsigned long reg = 0; | 35 | unsigned long reg = 0; |
| 36 | __asm__ __volatile__( | 36 | |
| 37 | /* disable I and D cache */ | 37 | if (!need_resched()) |
| 38 | "mrc p15, 0, %0, c1, c0, 0\n" | 38 | __asm__ __volatile__( |
| 39 | "bic %0, %0, #0x00001000\n" | 39 | /* disable I and D cache */ |
| 40 | "bic %0, %0, #0x00000004\n" | 40 | "mrc p15, 0, %0, c1, c0, 0\n" |
| 41 | "mcr p15, 0, %0, c1, c0, 0\n" | 41 | "bic %0, %0, #0x00001000\n" |
| 42 | /* invalidate I cache */ | 42 | "bic %0, %0, #0x00000004\n" |
| 43 | "mov %0, #0\n" | 43 | "mcr p15, 0, %0, c1, c0, 0\n" |
| 44 | "mcr p15, 0, %0, c7, c5, 0\n" | 44 | /* invalidate I cache */ |
| 45 | /* clear and invalidate D cache */ | 45 | "mov %0, #0\n" |
| 46 | "mov %0, #0\n" | 46 | "mcr p15, 0, %0, c7, c5, 0\n" |
| 47 | "mcr p15, 0, %0, c7, c14, 0\n" | 47 | /* clear and invalidate D cache */ |
| 48 | /* WFI */ | 48 | "mov %0, #0\n" |
| 49 | "mov %0, #0\n" | 49 | "mcr p15, 0, %0, c7, c14, 0\n" |
| 50 | "mcr p15, 0, %0, c7, c0, 4\n" | 50 | /* WFI */ |
| 51 | "nop\n" "nop\n" "nop\n" "nop\n" | 51 | "mov %0, #0\n" |
| 52 | "nop\n" "nop\n" "nop\n" | 52 | "mcr p15, 0, %0, c7, c0, 4\n" |
| 53 | /* enable I and D cache */ | 53 | "nop\n" "nop\n" "nop\n" "nop\n" |
| 54 | "mrc p15, 0, %0, c1, c0, 0\n" | 54 | "nop\n" "nop\n" "nop\n" |
| 55 | "orr %0, %0, #0x00001000\n" | 55 | /* enable I and D cache */ |
| 56 | "orr %0, %0, #0x00000004\n" | 56 | "mrc p15, 0, %0, c1, c0, 0\n" |
| 57 | "mcr p15, 0, %0, c1, c0, 0\n" | 57 | "orr %0, %0, #0x00001000\n" |
| 58 | : "=r" (reg)); | 58 | "orr %0, %0, #0x00000004\n" |
| 59 | "mcr p15, 0, %0, c1, c0, 0\n" | ||
| 60 | : "=r" (reg)); | ||
| 61 | local_irq_enable(); | ||
| 59 | } | 62 | } |
| 60 | 63 | ||
| 61 | static void __iomem *imx3_ioremap(unsigned long phys_addr, size_t size, | 64 | static void __iomem *imx3_ioremap(unsigned long phys_addr, size_t size, |
| @@ -108,6 +111,7 @@ void imx3_init_l2x0(void) | |||
| 108 | l2x0_init(l2x0_base, 0x00030024, 0x00000000); | 111 | l2x0_init(l2x0_base, 0x00030024, 0x00000000); |
| 109 | } | 112 | } |
| 110 | 113 | ||
| 114 | #ifdef CONFIG_SOC_IMX31 | ||
| 111 | static struct map_desc mx31_io_desc[] __initdata = { | 115 | static struct map_desc mx31_io_desc[] __initdata = { |
| 112 | imx_map_entry(MX31, X_MEMC, MT_DEVICE), | 116 | imx_map_entry(MX31, X_MEMC, MT_DEVICE), |
| 113 | imx_map_entry(MX31, AVIC, MT_DEVICE_NONSHARED), | 117 | imx_map_entry(MX31, AVIC, MT_DEVICE_NONSHARED), |
| @@ -126,33 +130,11 @@ void __init mx31_map_io(void) | |||
| 126 | iotable_init(mx31_io_desc, ARRAY_SIZE(mx31_io_desc)); | 130 | iotable_init(mx31_io_desc, ARRAY_SIZE(mx31_io_desc)); |
| 127 | } | 131 | } |
| 128 | 132 | ||
| 129 | static struct map_desc mx35_io_desc[] __initdata = { | ||
| 130 | imx_map_entry(MX35, X_MEMC, MT_DEVICE), | ||
| 131 | imx_map_entry(MX35, AVIC, MT_DEVICE_NONSHARED), | ||
| 132 | imx_map_entry(MX35, AIPS1, MT_DEVICE_NONSHARED), | ||
| 133 | imx_map_entry(MX35, AIPS2, MT_DEVICE_NONSHARED), | ||
| 134 | imx_map_entry(MX35, SPBA0, MT_DEVICE_NONSHARED), | ||
| 135 | }; | ||
| 136 | |||
| 137 | void __init mx35_map_io(void) | ||
| 138 | { | ||
| 139 | iotable_init(mx35_io_desc, ARRAY_SIZE(mx35_io_desc)); | ||
| 140 | } | ||
| 141 | |||
| 142 | void __init imx31_init_early(void) | 133 | void __init imx31_init_early(void) |
| 143 | { | 134 | { |
| 144 | mxc_set_cpu_type(MXC_CPU_MX31); | 135 | mxc_set_cpu_type(MXC_CPU_MX31); |
| 145 | mxc_arch_reset_init(MX31_IO_ADDRESS(MX31_WDOG_BASE_ADDR)); | 136 | mxc_arch_reset_init(MX31_IO_ADDRESS(MX31_WDOG_BASE_ADDR)); |
| 146 | imx_idle = imx3_idle; | 137 | pm_idle = imx3_idle; |
| 147 | imx_ioremap = imx3_ioremap; | ||
| 148 | } | ||
| 149 | |||
| 150 | void __init imx35_init_early(void) | ||
| 151 | { | ||
| 152 | mxc_set_cpu_type(MXC_CPU_MX35); | ||
| 153 | mxc_iomux_v3_init(MX35_IO_ADDRESS(MX35_IOMUXC_BASE_ADDR)); | ||
| 154 | mxc_arch_reset_init(MX35_IO_ADDRESS(MX35_WDOG_BASE_ADDR)); | ||
| 155 | imx_idle = imx3_idle; | ||
| 156 | imx_ioremap = imx3_ioremap; | 138 | imx_ioremap = imx3_ioremap; |
| 157 | } | 139 | } |
| 158 | 140 | ||
| @@ -161,11 +143,6 @@ void __init mx31_init_irq(void) | |||
| 161 | mxc_init_irq(MX31_IO_ADDRESS(MX31_AVIC_BASE_ADDR)); | 143 | mxc_init_irq(MX31_IO_ADDRESS(MX31_AVIC_BASE_ADDR)); |
| 162 | } | 144 | } |
| 163 | 145 | ||
| 164 | void __init mx35_init_irq(void) | ||
| 165 | { | ||
| 166 | mxc_init_irq(MX35_IO_ADDRESS(MX35_AVIC_BASE_ADDR)); | ||
| 167 | } | ||
| 168 | |||
| 169 | static struct sdma_script_start_addrs imx31_to1_sdma_script __initdata = { | 146 | static struct sdma_script_start_addrs imx31_to1_sdma_script __initdata = { |
| 170 | .per_2_per_addr = 1677, | 147 | .per_2_per_addr = 1677, |
| 171 | }; | 148 | }; |
| @@ -199,6 +176,35 @@ void __init imx31_soc_init(void) | |||
| 199 | 176 | ||
| 200 | imx_add_imx_sdma("imx31-sdma", MX31_SDMA_BASE_ADDR, MX31_INT_SDMA, &imx31_sdma_pdata); | 177 | imx_add_imx_sdma("imx31-sdma", MX31_SDMA_BASE_ADDR, MX31_INT_SDMA, &imx31_sdma_pdata); |
| 201 | } | 178 | } |
| 179 | #endif /* ifdef CONFIG_SOC_IMX31 */ | ||
| 180 | |||
| 181 | #ifdef CONFIG_SOC_IMX35 | ||
| 182 | static struct map_desc mx35_io_desc[] __initdata = { | ||
| 183 | imx_map_entry(MX35, X_MEMC, MT_DEVICE), | ||
| 184 | imx_map_entry(MX35, AVIC, MT_DEVICE_NONSHARED), | ||
| 185 | imx_map_entry(MX35, AIPS1, MT_DEVICE_NONSHARED), | ||
| 186 | imx_map_entry(MX35, AIPS2, MT_DEVICE_NONSHARED), | ||
| 187 | imx_map_entry(MX35, SPBA0, MT_DEVICE_NONSHARED), | ||
| 188 | }; | ||
| 189 | |||
| 190 | void __init mx35_map_io(void) | ||
| 191 | { | ||
| 192 | iotable_init(mx35_io_desc, ARRAY_SIZE(mx35_io_desc)); | ||
| 193 | } | ||
| 194 | |||
| 195 | void __init imx35_init_early(void) | ||
| 196 | { | ||
| 197 | mxc_set_cpu_type(MXC_CPU_MX35); | ||
| 198 | mxc_iomux_v3_init(MX35_IO_ADDRESS(MX35_IOMUXC_BASE_ADDR)); | ||
| 199 | mxc_arch_reset_init(MX35_IO_ADDRESS(MX35_WDOG_BASE_ADDR)); | ||
| 200 | pm_idle = imx3_idle; | ||
| 201 | imx_ioremap = imx3_ioremap; | ||
| 202 | } | ||
| 203 | |||
| 204 | void __init mx35_init_irq(void) | ||
| 205 | { | ||
| 206 | mxc_init_irq(MX35_IO_ADDRESS(MX35_AVIC_BASE_ADDR)); | ||
| 207 | } | ||
| 202 | 208 | ||
| 203 | static struct sdma_script_start_addrs imx35_to1_sdma_script __initdata = { | 209 | static struct sdma_script_start_addrs imx35_to1_sdma_script __initdata = { |
| 204 | .ap_2_ap_addr = 642, | 210 | .ap_2_ap_addr = 642, |
| @@ -254,3 +260,4 @@ void __init imx35_soc_init(void) | |||
| 254 | 260 | ||
| 255 | imx_add_imx_sdma("imx35-sdma", MX35_SDMA_BASE_ADDR, MX35_INT_SDMA, &imx35_sdma_pdata); | 261 | imx_add_imx_sdma("imx35-sdma", MX35_SDMA_BASE_ADDR, MX35_INT_SDMA, &imx35_sdma_pdata); |
| 256 | } | 262 | } |
| 263 | #endif /* ifdef CONFIG_SOC_IMX35 */ | ||
diff --git a/arch/arm/mach-imx/src.c b/arch/arm/mach-imx/src.c index 36cacbd0dcc2..a8e33681b732 100644 --- a/arch/arm/mach-imx/src.c +++ b/arch/arm/mach-imx/src.c | |||
| @@ -14,6 +14,7 @@ | |||
| 14 | #include <linux/io.h> | 14 | #include <linux/io.h> |
| 15 | #include <linux/of.h> | 15 | #include <linux/of.h> |
| 16 | #include <linux/of_address.h> | 16 | #include <linux/of_address.h> |
| 17 | #include <linux/smp.h> | ||
| 17 | #include <asm/unified.h> | 18 | #include <asm/unified.h> |
| 18 | 19 | ||
| 19 | #define SRC_SCR 0x000 | 20 | #define SRC_SCR 0x000 |
| @@ -23,10 +24,15 @@ | |||
| 23 | 24 | ||
| 24 | static void __iomem *src_base; | 25 | static void __iomem *src_base; |
| 25 | 26 | ||
| 27 | #ifndef CONFIG_SMP | ||
| 28 | #define cpu_logical_map(cpu) 0 | ||
| 29 | #endif | ||
| 30 | |||
| 26 | void imx_enable_cpu(int cpu, bool enable) | 31 | void imx_enable_cpu(int cpu, bool enable) |
| 27 | { | 32 | { |
| 28 | u32 mask, val; | 33 | u32 mask, val; |
| 29 | 34 | ||
| 35 | cpu = cpu_logical_map(cpu); | ||
| 30 | mask = 1 << (BP_SRC_SCR_CORE1_ENABLE + cpu - 1); | 36 | mask = 1 << (BP_SRC_SCR_CORE1_ENABLE + cpu - 1); |
| 31 | val = readl_relaxed(src_base + SRC_SCR); | 37 | val = readl_relaxed(src_base + SRC_SCR); |
| 32 | val = enable ? val | mask : val & ~mask; | 38 | val = enable ? val | mask : val & ~mask; |
| @@ -35,6 +41,7 @@ void imx_enable_cpu(int cpu, bool enable) | |||
| 35 | 41 | ||
| 36 | void imx_set_cpu_jump(int cpu, void *jump_addr) | 42 | void imx_set_cpu_jump(int cpu, void *jump_addr) |
| 37 | { | 43 | { |
| 44 | cpu = cpu_logical_map(cpu); | ||
| 38 | writel_relaxed(BSYM(virt_to_phys(jump_addr)), | 45 | writel_relaxed(BSYM(virt_to_phys(jump_addr)), |
| 39 | src_base + SRC_GPR1 + cpu * 8); | 46 | src_base + SRC_GPR1 + cpu * 8); |
| 40 | } | 47 | } |
diff --git a/arch/arm/mach-mmp/gplugd.c b/arch/arm/mach-mmp/gplugd.c index 69156568bc41..4665767a4f79 100644 --- a/arch/arm/mach-mmp/gplugd.c +++ b/arch/arm/mach-mmp/gplugd.c | |||
| @@ -182,7 +182,7 @@ static void __init gplugd_init(void) | |||
| 182 | 182 | ||
| 183 | /* on-chip devices */ | 183 | /* on-chip devices */ |
| 184 | pxa168_add_uart(3); | 184 | pxa168_add_uart(3); |
| 185 | pxa168_add_ssp(0); | 185 | pxa168_add_ssp(1); |
| 186 | pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(gplugd_i2c_board_info)); | 186 | pxa168_add_twsi(0, NULL, ARRAY_AND_SIZE(gplugd_i2c_board_info)); |
| 187 | 187 | ||
| 188 | pxa168_add_eth(&gplugd_eth_platform_data); | 188 | pxa168_add_eth(&gplugd_eth_platform_data); |
diff --git a/arch/arm/mach-mmp/include/mach/gpio-pxa.h b/arch/arm/mach-mmp/include/mach/gpio-pxa.h index d14eeaf16322..99b4ce1b6562 100644 --- a/arch/arm/mach-mmp/include/mach/gpio-pxa.h +++ b/arch/arm/mach-mmp/include/mach/gpio-pxa.h | |||
| @@ -7,7 +7,7 @@ | |||
| 7 | #define GPIO_REGS_VIRT (APB_VIRT_BASE + 0x19000) | 7 | #define GPIO_REGS_VIRT (APB_VIRT_BASE + 0x19000) |
| 8 | 8 | ||
| 9 | #define BANK_OFF(n) (((n) < 3) ? (n) << 2 : 0x100 + (((n) - 3) << 2)) | 9 | #define BANK_OFF(n) (((n) < 3) ? (n) << 2 : 0x100 + (((n) - 3) << 2)) |
| 10 | #define GPIO_REG(x) (GPIO_REGS_VIRT + (x)) | 10 | #define GPIO_REG(x) (*(volatile u32 *)(GPIO_REGS_VIRT + (x))) |
| 11 | 11 | ||
| 12 | #define NR_BUILTIN_GPIO IRQ_GPIO_NUM | 12 | #define NR_BUILTIN_GPIO IRQ_GPIO_NUM |
| 13 | 13 | ||
diff --git a/arch/arm/mach-msm/devices-iommu.c b/arch/arm/mach-msm/devices-iommu.c index 24030d0da6e3..0fb7a17df398 100644 --- a/arch/arm/mach-msm/devices-iommu.c +++ b/arch/arm/mach-msm/devices-iommu.c | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | #include <linux/kernel.h> | 18 | #include <linux/kernel.h> |
| 19 | #include <linux/platform_device.h> | 19 | #include <linux/platform_device.h> |
| 20 | #include <linux/bootmem.h> | 20 | #include <linux/bootmem.h> |
| 21 | #include <linux/module.h> | ||
| 21 | #include <mach/irqs.h> | 22 | #include <mach/irqs.h> |
| 22 | #include <mach/iommu.h> | 23 | #include <mach/iommu.h> |
| 23 | 24 | ||
diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c index 5c837603ff0f..24994bb52147 100644 --- a/arch/arm/mach-mx5/board-mx51_babbage.c +++ b/arch/arm/mach-mx5/board-mx51_babbage.c | |||
| @@ -362,7 +362,7 @@ static void __init mx51_babbage_init(void) | |||
| 362 | { | 362 | { |
| 363 | iomux_v3_cfg_t usbh1stp = MX51_PAD_USBH1_STP__USBH1_STP; | 363 | iomux_v3_cfg_t usbh1stp = MX51_PAD_USBH1_STP__USBH1_STP; |
| 364 | iomux_v3_cfg_t power_key = NEW_PAD_CTRL(MX51_PAD_EIM_A27__GPIO2_21, | 364 | iomux_v3_cfg_t power_key = NEW_PAD_CTRL(MX51_PAD_EIM_A27__GPIO2_21, |
| 365 | PAD_CTL_SRE_FAST | PAD_CTL_DSE_HIGH | PAD_CTL_PUS_100K_UP); | 365 | PAD_CTL_SRE_FAST | PAD_CTL_DSE_HIGH); |
| 366 | 366 | ||
| 367 | imx51_soc_init(); | 367 | imx51_soc_init(); |
| 368 | 368 | ||
diff --git a/arch/arm/mach-mx5/board-mx53_evk.c b/arch/arm/mach-mx5/board-mx53_evk.c index 6bea31ab8f85..64bbfcea6f35 100644 --- a/arch/arm/mach-mx5/board-mx53_evk.c +++ b/arch/arm/mach-mx5/board-mx53_evk.c | |||
| @@ -106,7 +106,7 @@ static inline void mx53_evk_fec_reset(void) | |||
| 106 | gpio_set_value(MX53_EVK_FEC_PHY_RST, 1); | 106 | gpio_set_value(MX53_EVK_FEC_PHY_RST, 1); |
| 107 | } | 107 | } |
| 108 | 108 | ||
| 109 | static struct fec_platform_data mx53_evk_fec_pdata = { | 109 | static const struct fec_platform_data mx53_evk_fec_pdata __initconst = { |
| 110 | .phy = PHY_INTERFACE_MODE_RMII, | 110 | .phy = PHY_INTERFACE_MODE_RMII, |
| 111 | }; | 111 | }; |
| 112 | 112 | ||
diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c index 7678f7734db6..237bdecd9331 100644 --- a/arch/arm/mach-mx5/board-mx53_loco.c +++ b/arch/arm/mach-mx5/board-mx53_loco.c | |||
| @@ -242,7 +242,7 @@ static inline void mx53_loco_fec_reset(void) | |||
| 242 | gpio_set_value(LOCO_FEC_PHY_RST, 1); | 242 | gpio_set_value(LOCO_FEC_PHY_RST, 1); |
| 243 | } | 243 | } |
| 244 | 244 | ||
| 245 | static struct fec_platform_data mx53_loco_fec_data = { | 245 | static const struct fec_platform_data mx53_loco_fec_data __initconst = { |
| 246 | .phy = PHY_INTERFACE_MODE_RMII, | 246 | .phy = PHY_INTERFACE_MODE_RMII, |
| 247 | }; | 247 | }; |
| 248 | 248 | ||
diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c index 59c0845eb4a6..d42132a80e8f 100644 --- a/arch/arm/mach-mx5/board-mx53_smd.c +++ b/arch/arm/mach-mx5/board-mx53_smd.c | |||
| @@ -104,7 +104,7 @@ static inline void mx53_smd_fec_reset(void) | |||
| 104 | gpio_set_value(SMD_FEC_PHY_RST, 1); | 104 | gpio_set_value(SMD_FEC_PHY_RST, 1); |
| 105 | } | 105 | } |
| 106 | 106 | ||
| 107 | static struct fec_platform_data mx53_smd_fec_data = { | 107 | static const struct fec_platform_data mx53_smd_fec_data __initconst = { |
| 108 | .phy = PHY_INTERFACE_MODE_RMII, | 108 | .phy = PHY_INTERFACE_MODE_RMII, |
| 109 | }; | 109 | }; |
| 110 | 110 | ||
diff --git a/arch/arm/mach-mx5/cpu.c b/arch/arm/mach-mx5/cpu.c index 5c5328257dca..5e2e7a843860 100644 --- a/arch/arm/mach-mx5/cpu.c +++ b/arch/arm/mach-mx5/cpu.c | |||
| @@ -16,7 +16,7 @@ | |||
| 16 | #include <linux/init.h> | 16 | #include <linux/init.h> |
| 17 | #include <linux/module.h> | 17 | #include <linux/module.h> |
| 18 | #include <mach/hardware.h> | 18 | #include <mach/hardware.h> |
| 19 | #include <asm/io.h> | 19 | #include <linux/io.h> |
| 20 | 20 | ||
| 21 | static int mx5_cpu_rev = -1; | 21 | static int mx5_cpu_rev = -1; |
| 22 | 22 | ||
| @@ -67,7 +67,8 @@ static int __init mx51_neon_fixup(void) | |||
| 67 | if (!cpu_is_mx51()) | 67 | if (!cpu_is_mx51()) |
| 68 | return 0; | 68 | return 0; |
| 69 | 69 | ||
| 70 | if (mx51_revision() < IMX_CHIP_REVISION_3_0 && (elf_hwcap & HWCAP_NEON)) { | 70 | if (mx51_revision() < IMX_CHIP_REVISION_3_0 && |
| 71 | (elf_hwcap & HWCAP_NEON)) { | ||
| 71 | elf_hwcap &= ~HWCAP_NEON; | 72 | elf_hwcap &= ~HWCAP_NEON; |
| 72 | pr_info("Turning off NEON support, detected broken NEON implementation\n"); | 73 | pr_info("Turning off NEON support, detected broken NEON implementation\n"); |
| 73 | } | 74 | } |
diff --git a/arch/arm/mach-mx5/imx51-dt.c b/arch/arm/mach-mx5/imx51-dt.c index ccc61585659b..596edd967dbf 100644 --- a/arch/arm/mach-mx5/imx51-dt.c +++ b/arch/arm/mach-mx5/imx51-dt.c | |||
| @@ -44,20 +44,22 @@ static const struct of_dev_auxdata imx51_auxdata_lookup[] __initconst = { | |||
| 44 | { /* sentinel */ } | 44 | { /* sentinel */ } |
| 45 | }; | 45 | }; |
| 46 | 46 | ||
| 47 | static void __init imx51_tzic_add_irq_domain(struct device_node *np, | 47 | static int __init imx51_tzic_add_irq_domain(struct device_node *np, |
| 48 | struct device_node *interrupt_parent) | 48 | struct device_node *interrupt_parent) |
| 49 | { | 49 | { |
| 50 | irq_domain_add_simple(np, 0); | 50 | irq_domain_add_simple(np, 0); |
| 51 | return 0; | ||
| 51 | } | 52 | } |
| 52 | 53 | ||
| 53 | static void __init imx51_gpio_add_irq_domain(struct device_node *np, | 54 | static int __init imx51_gpio_add_irq_domain(struct device_node *np, |
| 54 | struct device_node *interrupt_parent) | 55 | struct device_node *interrupt_parent) |
| 55 | { | 56 | { |
| 56 | static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS - | 57 | static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS; |
| 57 | 32 * 4; /* imx51 gets 4 gpio ports */ | ||
| 58 | 58 | ||
| 59 | gpio_irq_base -= 32; | ||
| 59 | irq_domain_add_simple(np, gpio_irq_base); | 60 | irq_domain_add_simple(np, gpio_irq_base); |
| 60 | gpio_irq_base += 32; | 61 | |
| 62 | return 0; | ||
| 61 | } | 63 | } |
| 62 | 64 | ||
| 63 | static const struct of_device_id imx51_irq_match[] __initconst = { | 65 | static const struct of_device_id imx51_irq_match[] __initconst = { |
diff --git a/arch/arm/mach-mx5/imx53-dt.c b/arch/arm/mach-mx5/imx53-dt.c index ccaa0b81b768..85bfd5ff21b0 100644 --- a/arch/arm/mach-mx5/imx53-dt.c +++ b/arch/arm/mach-mx5/imx53-dt.c | |||
| @@ -48,20 +48,22 @@ static const struct of_dev_auxdata imx53_auxdata_lookup[] __initconst = { | |||
| 48 | { /* sentinel */ } | 48 | { /* sentinel */ } |
| 49 | }; | 49 | }; |
| 50 | 50 | ||
| 51 | static void __init imx53_tzic_add_irq_domain(struct device_node *np, | 51 | static int __init imx53_tzic_add_irq_domain(struct device_node *np, |
| 52 | struct device_node *interrupt_parent) | 52 | struct device_node *interrupt_parent) |
| 53 | { | 53 | { |
| 54 | irq_domain_add_simple(np, 0); | 54 | irq_domain_add_simple(np, 0); |
| 55 | return 0; | ||
| 55 | } | 56 | } |
| 56 | 57 | ||
| 57 | static void __init imx53_gpio_add_irq_domain(struct device_node *np, | 58 | static int __init imx53_gpio_add_irq_domain(struct device_node *np, |
| 58 | struct device_node *interrupt_parent) | 59 | struct device_node *interrupt_parent) |
| 59 | { | 60 | { |
| 60 | static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS - | 61 | static int gpio_irq_base = MXC_GPIO_IRQ_START + ARCH_NR_GPIOS; |
| 61 | 32 * 7; /* imx53 gets 7 gpio ports */ | ||
| 62 | 62 | ||
| 63 | gpio_irq_base -= 32; | ||
| 63 | irq_domain_add_simple(np, gpio_irq_base); | 64 | irq_domain_add_simple(np, gpio_irq_base); |
| 64 | gpio_irq_base += 32; | 65 | |
| 66 | return 0; | ||
| 65 | } | 67 | } |
| 66 | 68 | ||
| 67 | static const struct of_device_id imx53_irq_match[] __initconst = { | 69 | static const struct of_device_id imx53_irq_match[] __initconst = { |
diff --git a/arch/arm/mach-mx5/mm.c b/arch/arm/mach-mx5/mm.c index 26eacc9d0d90..df4a508f240a 100644 --- a/arch/arm/mach-mx5/mm.c +++ b/arch/arm/mach-mx5/mm.c | |||
| @@ -23,7 +23,9 @@ | |||
| 23 | 23 | ||
| 24 | static void imx5_idle(void) | 24 | static void imx5_idle(void) |
| 25 | { | 25 | { |
| 26 | mx5_cpu_lp_set(WAIT_UNCLOCKED_POWER_OFF); | 26 | if (!need_resched()) |
| 27 | mx5_cpu_lp_set(WAIT_UNCLOCKED_POWER_OFF); | ||
| 28 | local_irq_enable(); | ||
| 27 | } | 29 | } |
| 28 | 30 | ||
| 29 | /* | 31 | /* |
| @@ -89,7 +91,7 @@ void __init imx51_init_early(void) | |||
| 89 | mxc_set_cpu_type(MXC_CPU_MX51); | 91 | mxc_set_cpu_type(MXC_CPU_MX51); |
| 90 | mxc_iomux_v3_init(MX51_IO_ADDRESS(MX51_IOMUXC_BASE_ADDR)); | 92 | mxc_iomux_v3_init(MX51_IO_ADDRESS(MX51_IOMUXC_BASE_ADDR)); |
| 91 | mxc_arch_reset_init(MX51_IO_ADDRESS(MX51_WDOG1_BASE_ADDR)); | 93 | mxc_arch_reset_init(MX51_IO_ADDRESS(MX51_WDOG1_BASE_ADDR)); |
| 92 | imx_idle = imx5_idle; | 94 | pm_idle = imx5_idle; |
| 93 | } | 95 | } |
| 94 | 96 | ||
| 95 | void __init imx53_init_early(void) | 97 | void __init imx53_init_early(void) |
diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c index 229ae3494216..da6e4aad177c 100644 --- a/arch/arm/mach-mxs/clock-mx28.c +++ b/arch/arm/mach-mxs/clock-mx28.c | |||
| @@ -404,7 +404,7 @@ static int name##_set_rate(struct clk *clk, unsigned long rate) \ | |||
| 404 | reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_##dr); \ | 404 | reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_##dr); \ |
| 405 | reg &= ~BM_CLKCTRL_##dr##_DIV; \ | 405 | reg &= ~BM_CLKCTRL_##dr##_DIV; \ |
| 406 | reg |= div << BP_CLKCTRL_##dr##_DIV; \ | 406 | reg |= div << BP_CLKCTRL_##dr##_DIV; \ |
| 407 | if (reg | (1 << clk->enable_shift)) { \ | 407 | if (reg & (1 << clk->enable_shift)) { \ |
| 408 | pr_err("%s: clock is gated\n", __func__); \ | 408 | pr_err("%s: clock is gated\n", __func__); \ |
| 409 | return -EINVAL; \ | 409 | return -EINVAL; \ |
| 410 | } \ | 410 | } \ |
diff --git a/arch/arm/mach-mxs/include/mach/mx28.h b/arch/arm/mach-mxs/include/mach/mx28.h index 75d86118b76a..30c7990f3c01 100644 --- a/arch/arm/mach-mxs/include/mach/mx28.h +++ b/arch/arm/mach-mxs/include/mach/mx28.h | |||
| @@ -104,8 +104,8 @@ | |||
| 104 | #define MX28_INT_CAN1 9 | 104 | #define MX28_INT_CAN1 9 |
| 105 | #define MX28_INT_LRADC_TOUCH 10 | 105 | #define MX28_INT_LRADC_TOUCH 10 |
| 106 | #define MX28_INT_HSADC 13 | 106 | #define MX28_INT_HSADC 13 |
| 107 | #define MX28_INT_IRADC_THRESH0 14 | 107 | #define MX28_INT_LRADC_THRESH0 14 |
| 108 | #define MX28_INT_IRADC_THRESH1 15 | 108 | #define MX28_INT_LRADC_THRESH1 15 |
| 109 | #define MX28_INT_LRADC_CH0 16 | 109 | #define MX28_INT_LRADC_CH0 16 |
| 110 | #define MX28_INT_LRADC_CH1 17 | 110 | #define MX28_INT_LRADC_CH1 17 |
| 111 | #define MX28_INT_LRADC_CH2 18 | 111 | #define MX28_INT_LRADC_CH2 18 |
diff --git a/arch/arm/mach-mxs/include/mach/mxs.h b/arch/arm/mach-mxs/include/mach/mxs.h index 0d2d2b470998..bde5f6634747 100644 --- a/arch/arm/mach-mxs/include/mach/mxs.h +++ b/arch/arm/mach-mxs/include/mach/mxs.h | |||
| @@ -30,6 +30,7 @@ | |||
| 30 | */ | 30 | */ |
| 31 | #define cpu_is_mx23() ( \ | 31 | #define cpu_is_mx23() ( \ |
| 32 | machine_is_mx23evk() || \ | 32 | machine_is_mx23evk() || \ |
| 33 | machine_is_stmp378x() || \ | ||
| 33 | 0) | 34 | 0) |
| 34 | #define cpu_is_mx28() ( \ | 35 | #define cpu_is_mx28() ( \ |
| 35 | machine_is_mx28evk() || \ | 36 | machine_is_mx28evk() || \ |
diff --git a/arch/arm/mach-mxs/mach-m28evk.c b/arch/arm/mach-mxs/mach-m28evk.c index 3b1681e4f49a..6b00577b7025 100644 --- a/arch/arm/mach-mxs/mach-m28evk.c +++ b/arch/arm/mach-mxs/mach-m28evk.c | |||
| @@ -361,6 +361,6 @@ static struct sys_timer m28evk_timer = { | |||
| 361 | MACHINE_START(M28EVK, "DENX M28 EVK") | 361 | MACHINE_START(M28EVK, "DENX M28 EVK") |
| 362 | .map_io = mx28_map_io, | 362 | .map_io = mx28_map_io, |
| 363 | .init_irq = mx28_init_irq, | 363 | .init_irq = mx28_init_irq, |
| 364 | .init_machine = m28evk_init, | ||
| 365 | .timer = &m28evk_timer, | 364 | .timer = &m28evk_timer, |
| 365 | .init_machine = m28evk_init, | ||
| 366 | MACHINE_END | 366 | MACHINE_END |
diff --git a/arch/arm/mach-mxs/mach-stmp378x_devb.c b/arch/arm/mach-mxs/mach-stmp378x_devb.c index 177e53123a02..6834dea38c04 100644 --- a/arch/arm/mach-mxs/mach-stmp378x_devb.c +++ b/arch/arm/mach-mxs/mach-stmp378x_devb.c | |||
| @@ -115,6 +115,6 @@ static struct sys_timer stmp378x_dvb_timer = { | |||
| 115 | MACHINE_START(STMP378X, "STMP378X") | 115 | MACHINE_START(STMP378X, "STMP378X") |
| 116 | .map_io = mx23_map_io, | 116 | .map_io = mx23_map_io, |
| 117 | .init_irq = mx23_init_irq, | 117 | .init_irq = mx23_init_irq, |
| 118 | .init_machine = stmp378x_dvb_init, | ||
| 119 | .timer = &stmp378x_dvb_timer, | 118 | .timer = &stmp378x_dvb_timer, |
| 119 | .init_machine = stmp378x_dvb_init, | ||
| 120 | MACHINE_END | 120 | MACHINE_END |
diff --git a/arch/arm/mach-mxs/module-tx28.c b/arch/arm/mach-mxs/module-tx28.c index 0fcff47009cf..9a7b08b2a925 100644 --- a/arch/arm/mach-mxs/module-tx28.c +++ b/arch/arm/mach-mxs/module-tx28.c | |||
| @@ -66,11 +66,11 @@ static const iomux_cfg_t tx28_fec1_pads[] __initconst = { | |||
| 66 | MX28_PAD_ENET0_CRS__ENET1_RX_EN, | 66 | MX28_PAD_ENET0_CRS__ENET1_RX_EN, |
| 67 | }; | 67 | }; |
| 68 | 68 | ||
| 69 | static struct fec_platform_data tx28_fec0_data = { | 69 | static const struct fec_platform_data tx28_fec0_data __initconst = { |
| 70 | .phy = PHY_INTERFACE_MODE_RMII, | 70 | .phy = PHY_INTERFACE_MODE_RMII, |
| 71 | }; | 71 | }; |
| 72 | 72 | ||
| 73 | static struct fec_platform_data tx28_fec1_data = { | 73 | static const struct fec_platform_data tx28_fec1_data __initconst = { |
| 74 | .phy = PHY_INTERFACE_MODE_RMII, | 74 | .phy = PHY_INTERFACE_MODE_RMII, |
| 75 | }; | 75 | }; |
| 76 | 76 | ||
diff --git a/arch/arm/mach-omap1/Kconfig b/arch/arm/mach-omap1/Kconfig index e0a028161dde..73f287d6429b 100644 --- a/arch/arm/mach-omap1/Kconfig +++ b/arch/arm/mach-omap1/Kconfig | |||
| @@ -171,14 +171,6 @@ config MACH_OMAP_GENERIC | |||
| 171 | comment "OMAP CPU Speed" | 171 | comment "OMAP CPU Speed" |
| 172 | depends on ARCH_OMAP1 | 172 | depends on ARCH_OMAP1 |
| 173 | 173 | ||
| 174 | config OMAP_CLOCKS_SET_BY_BOOTLOADER | ||
| 175 | bool "OMAP clocks set by bootloader" | ||
| 176 | depends on ARCH_OMAP1 | ||
| 177 | help | ||
| 178 | Enable this option to prevent the kernel from overriding the clock | ||
| 179 | frequencies programmed by bootloader for MPU, DSP, MMUs, TC, | ||
| 180 | internal LCD controller and MPU peripherals. | ||
| 181 | |||
| 182 | config OMAP_ARM_216MHZ | 174 | config OMAP_ARM_216MHZ |
| 183 | bool "OMAP ARM 216 MHz CPU (1710 only)" | 175 | bool "OMAP ARM 216 MHz CPU (1710 only)" |
| 184 | depends on ARCH_OMAP1 && ARCH_OMAP16XX | 176 | depends on ARCH_OMAP1 && ARCH_OMAP16XX |
diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c index 51bae31cf361..b0f15d234a12 100644 --- a/arch/arm/mach-omap1/board-ams-delta.c +++ b/arch/arm/mach-omap1/board-ams-delta.c | |||
| @@ -302,8 +302,6 @@ static void __init ams_delta_init(void) | |||
| 302 | omap_cfg_reg(J19_1610_CAM_D6); | 302 | omap_cfg_reg(J19_1610_CAM_D6); |
| 303 | omap_cfg_reg(J18_1610_CAM_D7); | 303 | omap_cfg_reg(J18_1610_CAM_D7); |
| 304 | 304 | ||
| 305 | iotable_init(ams_delta_io_desc, ARRAY_SIZE(ams_delta_io_desc)); | ||
| 306 | |||
| 307 | omap_board_config = ams_delta_config; | 305 | omap_board_config = ams_delta_config; |
| 308 | omap_board_config_size = ARRAY_SIZE(ams_delta_config); | 306 | omap_board_config_size = ARRAY_SIZE(ams_delta_config); |
| 309 | omap_serial_init(); | 307 | omap_serial_init(); |
| @@ -373,10 +371,16 @@ static int __init ams_delta_modem_init(void) | |||
| 373 | } | 371 | } |
| 374 | arch_initcall(ams_delta_modem_init); | 372 | arch_initcall(ams_delta_modem_init); |
| 375 | 373 | ||
| 374 | static void __init ams_delta_map_io(void) | ||
| 375 | { | ||
| 376 | omap15xx_map_io(); | ||
| 377 | iotable_init(ams_delta_io_desc, ARRAY_SIZE(ams_delta_io_desc)); | ||
| 378 | } | ||
| 379 | |||
| 376 | MACHINE_START(AMS_DELTA, "Amstrad E3 (Delta)") | 380 | MACHINE_START(AMS_DELTA, "Amstrad E3 (Delta)") |
| 377 | /* Maintainer: Jonathan McDowell <noodles@earth.li> */ | 381 | /* Maintainer: Jonathan McDowell <noodles@earth.li> */ |
| 378 | .atag_offset = 0x100, | 382 | .atag_offset = 0x100, |
| 379 | .map_io = omap15xx_map_io, | 383 | .map_io = ams_delta_map_io, |
| 380 | .init_early = omap1_init_early, | 384 | .init_early = omap1_init_early, |
| 381 | .reserve = omap_reserve, | 385 | .reserve = omap_reserve, |
| 382 | .init_irq = omap1_init_irq, | 386 | .init_irq = omap1_init_irq, |
diff --git a/arch/arm/mach-omap1/clock.h b/arch/arm/mach-omap1/clock.h index eaf09efb91ca..16b1423b454a 100644 --- a/arch/arm/mach-omap1/clock.h +++ b/arch/arm/mach-omap1/clock.h | |||
| @@ -17,7 +17,8 @@ | |||
| 17 | 17 | ||
| 18 | #include <plat/clock.h> | 18 | #include <plat/clock.h> |
| 19 | 19 | ||
| 20 | extern int __init omap1_clk_init(void); | 20 | int omap1_clk_init(void); |
| 21 | void omap1_clk_late_init(void); | ||
| 21 | extern int omap1_clk_enable(struct clk *clk); | 22 | extern int omap1_clk_enable(struct clk *clk); |
| 22 | extern void omap1_clk_disable(struct clk *clk); | 23 | extern void omap1_clk_disable(struct clk *clk); |
| 23 | extern long omap1_clk_round_rate(struct clk *clk, unsigned long rate); | 24 | extern long omap1_clk_round_rate(struct clk *clk, unsigned long rate); |
diff --git a/arch/arm/mach-omap1/clock_data.c b/arch/arm/mach-omap1/clock_data.c index 92400b9eb69f..9ff90a744a21 100644 --- a/arch/arm/mach-omap1/clock_data.c +++ b/arch/arm/mach-omap1/clock_data.c | |||
| @@ -16,6 +16,8 @@ | |||
| 16 | 16 | ||
| 17 | #include <linux/kernel.h> | 17 | #include <linux/kernel.h> |
| 18 | #include <linux/clk.h> | 18 | #include <linux/clk.h> |
| 19 | #include <linux/cpufreq.h> | ||
| 20 | #include <linux/delay.h> | ||
| 19 | #include <linux/io.h> | 21 | #include <linux/io.h> |
| 20 | 22 | ||
| 21 | #include <asm/mach-types.h> /* for machine_is_* */ | 23 | #include <asm/mach-types.h> /* for machine_is_* */ |
| @@ -767,6 +769,15 @@ static struct clk_functions omap1_clk_functions = { | |||
| 767 | .clk_disable_unused = omap1_clk_disable_unused, | 769 | .clk_disable_unused = omap1_clk_disable_unused, |
| 768 | }; | 770 | }; |
| 769 | 771 | ||
| 772 | static void __init omap1_show_rates(void) | ||
| 773 | { | ||
| 774 | pr_notice("Clocking rate (xtal/DPLL1/MPU): " | ||
| 775 | "%ld.%01ld/%ld.%01ld/%ld.%01ld MHz\n", | ||
| 776 | ck_ref.rate / 1000000, (ck_ref.rate / 100000) % 10, | ||
| 777 | ck_dpll1.rate / 1000000, (ck_dpll1.rate / 100000) % 10, | ||
| 778 | arm_ck.rate / 1000000, (arm_ck.rate / 100000) % 10); | ||
| 779 | } | ||
| 780 | |||
| 770 | int __init omap1_clk_init(void) | 781 | int __init omap1_clk_init(void) |
| 771 | { | 782 | { |
| 772 | struct omap_clk *c; | 783 | struct omap_clk *c; |
| @@ -835,9 +846,12 @@ int __init omap1_clk_init(void) | |||
| 835 | /* We want to be in syncronous scalable mode */ | 846 | /* We want to be in syncronous scalable mode */ |
| 836 | omap_writew(0x1000, ARM_SYSST); | 847 | omap_writew(0x1000, ARM_SYSST); |
| 837 | 848 | ||
| 838 | #ifdef CONFIG_OMAP_CLOCKS_SET_BY_BOOTLOADER | 849 | |
| 839 | /* Use values set by bootloader. Determine PLL rate and recalculate | 850 | /* |
| 840 | * dependent clocks as if kernel had changed PLL or divisors. | 851 | * Initially use the values set by bootloader. Determine PLL rate and |
| 852 | * recalculate dependent clocks as if kernel had changed PLL or | ||
| 853 | * divisors. See also omap1_clk_late_init() that can reprogram dpll1 | ||
| 854 | * after the SRAM is initialized. | ||
| 841 | */ | 855 | */ |
| 842 | { | 856 | { |
| 843 | unsigned pll_ctl_val = omap_readw(DPLL_CTL); | 857 | unsigned pll_ctl_val = omap_readw(DPLL_CTL); |
| @@ -862,25 +876,10 @@ int __init omap1_clk_init(void) | |||
| 862 | } | 876 | } |
| 863 | } | 877 | } |
| 864 | } | 878 | } |
| 865 | #else | ||
| 866 | /* Find the highest supported frequency and enable it */ | ||
| 867 | if (omap1_select_table_rate(&virtual_ck_mpu, ~0)) { | ||
| 868 | printk(KERN_ERR "System frequencies not set. Check your config.\n"); | ||
| 869 | /* Guess sane values (60MHz) */ | ||
| 870 | omap_writew(0x2290, DPLL_CTL); | ||
| 871 | omap_writew(cpu_is_omap7xx() ? 0x3005 : 0x1005, ARM_CKCTL); | ||
| 872 | ck_dpll1.rate = 60000000; | ||
| 873 | } | ||
| 874 | #endif | ||
| 875 | propagate_rate(&ck_dpll1); | 879 | propagate_rate(&ck_dpll1); |
| 876 | /* Cache rates for clocks connected to ck_ref (not dpll1) */ | 880 | /* Cache rates for clocks connected to ck_ref (not dpll1) */ |
| 877 | propagate_rate(&ck_ref); | 881 | propagate_rate(&ck_ref); |
| 878 | printk(KERN_INFO "Clocking rate (xtal/DPLL1/MPU): " | 882 | omap1_show_rates(); |
| 879 | "%ld.%01ld/%ld.%01ld/%ld.%01ld MHz\n", | ||
| 880 | ck_ref.rate / 1000000, (ck_ref.rate / 100000) % 10, | ||
| 881 | ck_dpll1.rate / 1000000, (ck_dpll1.rate / 100000) % 10, | ||
| 882 | arm_ck.rate / 1000000, (arm_ck.rate / 100000) % 10); | ||
| 883 | |||
| 884 | if (machine_is_omap_perseus2() || machine_is_omap_fsample()) { | 883 | if (machine_is_omap_perseus2() || machine_is_omap_fsample()) { |
| 885 | /* Select slicer output as OMAP input clock */ | 884 | /* Select slicer output as OMAP input clock */ |
| 886 | omap_writew(omap_readw(OMAP7XX_PCC_UPLD_CTRL) & ~0x1, | 885 | omap_writew(omap_readw(OMAP7XX_PCC_UPLD_CTRL) & ~0x1, |
| @@ -925,3 +924,27 @@ int __init omap1_clk_init(void) | |||
| 925 | 924 | ||
| 926 | return 0; | 925 | return 0; |
| 927 | } | 926 | } |
| 927 | |||
| 928 | #define OMAP1_DPLL1_SANE_VALUE 60000000 | ||
| 929 | |||
| 930 | void __init omap1_clk_late_init(void) | ||
| 931 | { | ||
| 932 | unsigned long rate = ck_dpll1.rate; | ||
| 933 | |||
| 934 | if (rate >= OMAP1_DPLL1_SANE_VALUE) | ||
| 935 | return; | ||
| 936 | |||
| 937 | /* System booting at unusable rate, force reprogramming of DPLL1 */ | ||
| 938 | ck_dpll1_p->rate = 0; | ||
| 939 | |||
| 940 | /* Find the highest supported frequency and enable it */ | ||
| 941 | if (omap1_select_table_rate(&virtual_ck_mpu, ~0)) { | ||
| 942 | pr_err("System frequencies not set, using default. Check your config.\n"); | ||
| 943 | omap_writew(0x2290, DPLL_CTL); | ||
| 944 | omap_writew(cpu_is_omap7xx() ? 0x2005 : 0x0005, ARM_CKCTL); | ||
| 945 | ck_dpll1.rate = OMAP1_DPLL1_SANE_VALUE; | ||
| 946 | } | ||
| 947 | propagate_rate(&ck_dpll1); | ||
| 948 | omap1_show_rates(); | ||
| 949 | loops_per_jiffy = cpufreq_scale(loops_per_jiffy, rate, ck_dpll1.rate); | ||
| 950 | } | ||
diff --git a/arch/arm/mach-omap1/devices.c b/arch/arm/mach-omap1/devices.c index 48ef9888e820..475cb2f50d87 100644 --- a/arch/arm/mach-omap1/devices.c +++ b/arch/arm/mach-omap1/devices.c | |||
| @@ -30,6 +30,8 @@ | |||
| 30 | #include <plat/omap7xx.h> | 30 | #include <plat/omap7xx.h> |
| 31 | #include <plat/mcbsp.h> | 31 | #include <plat/mcbsp.h> |
| 32 | 32 | ||
| 33 | #include "clock.h" | ||
| 34 | |||
| 33 | /*-------------------------------------------------------------------------*/ | 35 | /*-------------------------------------------------------------------------*/ |
| 34 | 36 | ||
| 35 | #if defined(CONFIG_RTC_DRV_OMAP) || defined(CONFIG_RTC_DRV_OMAP_MODULE) | 37 | #if defined(CONFIG_RTC_DRV_OMAP) || defined(CONFIG_RTC_DRV_OMAP_MODULE) |
| @@ -293,6 +295,7 @@ static int __init omap1_init_devices(void) | |||
| 293 | return -ENODEV; | 295 | return -ENODEV; |
| 294 | 296 | ||
| 295 | omap_sram_init(); | 297 | omap_sram_init(); |
| 298 | omap1_clk_late_init(); | ||
| 296 | 299 | ||
| 297 | /* please keep these calls, and their implementations above, | 300 | /* please keep these calls, and their implementations above, |
| 298 | * in alphabetical order so they're easier to sort through. | 301 | * in alphabetical order so they're easier to sort through. |
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index 503414718905..e1293aa513d3 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig | |||
| @@ -334,6 +334,7 @@ config MACH_OMAP4_PANDA | |||
| 334 | config OMAP3_EMU | 334 | config OMAP3_EMU |
| 335 | bool "OMAP3 debugging peripherals" | 335 | bool "OMAP3 debugging peripherals" |
| 336 | depends on ARCH_OMAP3 | 336 | depends on ARCH_OMAP3 |
| 337 | select ARM_AMBA | ||
| 337 | select OC_ETM | 338 | select OC_ETM |
| 338 | help | 339 | help |
| 339 | Say Y here to enable debugging hardware of omap3 | 340 | Say Y here to enable debugging hardware of omap3 |
diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 69ab1c069134..b009f17dee56 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile | |||
| @@ -4,7 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | # Common support | 5 | # Common support |
| 6 | obj-y := id.o io.o control.o mux.o devices.o serial.o gpmc.o timer.o pm.o \ | 6 | obj-y := id.o io.o control.o mux.o devices.o serial.o gpmc.o timer.o pm.o \ |
| 7 | common.o gpio.o dma.o wd_timer.o | 7 | common.o gpio.o dma.o wd_timer.o display.o |
| 8 | 8 | ||
| 9 | omap-2-3-common = irq.o sdrc.o | 9 | omap-2-3-common = irq.o sdrc.o |
| 10 | hwmod-common = omap_hwmod.o \ | 10 | hwmod-common = omap_hwmod.o \ |
| @@ -264,7 +264,4 @@ smsc911x-$(CONFIG_SMSC911X) := gpmc-smsc911x.o | |||
| 264 | obj-y += $(smsc911x-m) $(smsc911x-y) | 264 | obj-y += $(smsc911x-m) $(smsc911x-y) |
| 265 | obj-$(CONFIG_ARCH_OMAP4) += hwspinlock.o | 265 | obj-$(CONFIG_ARCH_OMAP4) += hwspinlock.o |
| 266 | 266 | ||
| 267 | disp-$(CONFIG_OMAP2_DSS) := display.o | ||
| 268 | obj-y += $(disp-m) $(disp-y) | ||
| 269 | |||
| 270 | obj-y += common-board-devices.o twl-common.o | 267 | obj-y += common-board-devices.o twl-common.o |
diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c b/arch/arm/mach-omap2/board-rx51-peripherals.c index ba1aa07bdb29..c15c5c9c9085 100644 --- a/arch/arm/mach-omap2/board-rx51-peripherals.c +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c | |||
| @@ -193,7 +193,7 @@ static struct platform_device rx51_charger_device = { | |||
| 193 | static void __init rx51_charger_init(void) | 193 | static void __init rx51_charger_init(void) |
| 194 | { | 194 | { |
| 195 | WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO, | 195 | WARN_ON(gpio_request_one(RX51_USB_TRANSCEIVER_RST_GPIO, |
| 196 | GPIOF_OUT_INIT_LOW, "isp1704_reset")); | 196 | GPIOF_OUT_INIT_HIGH, "isp1704_reset")); |
| 197 | 197 | ||
| 198 | platform_device_register(&rx51_charger_device); | 198 | platform_device_register(&rx51_charger_device); |
| 199 | } | 199 | } |
diff --git a/arch/arm/mach-omap2/cpuidle34xx.c b/arch/arm/mach-omap2/cpuidle34xx.c index 1fe35c24fba2..942bb4f19f9f 100644 --- a/arch/arm/mach-omap2/cpuidle34xx.c +++ b/arch/arm/mach-omap2/cpuidle34xx.c | |||
| @@ -24,6 +24,7 @@ | |||
| 24 | 24 | ||
| 25 | #include <linux/sched.h> | 25 | #include <linux/sched.h> |
| 26 | #include <linux/cpuidle.h> | 26 | #include <linux/cpuidle.h> |
| 27 | #include <linux/export.h> | ||
| 27 | 28 | ||
| 28 | #include <plat/prcm.h> | 29 | #include <plat/prcm.h> |
| 29 | #include <plat/irqs.h> | 30 | #include <plat/irqs.h> |
diff --git a/arch/arm/mach-omap2/display.c b/arch/arm/mach-omap2/display.c index adb2756e242f..dce9905d64bb 100644 --- a/arch/arm/mach-omap2/display.c +++ b/arch/arm/mach-omap2/display.c | |||
| @@ -27,8 +27,35 @@ | |||
| 27 | #include <plat/omap_hwmod.h> | 27 | #include <plat/omap_hwmod.h> |
| 28 | #include <plat/omap_device.h> | 28 | #include <plat/omap_device.h> |
| 29 | #include <plat/omap-pm.h> | 29 | #include <plat/omap-pm.h> |
| 30 | #include <plat/common.h> | ||
| 30 | 31 | ||
| 31 | #include "control.h" | 32 | #include "control.h" |
| 33 | #include "display.h" | ||
| 34 | |||
| 35 | #define DISPC_CONTROL 0x0040 | ||
| 36 | #define DISPC_CONTROL2 0x0238 | ||
| 37 | #define DISPC_IRQSTATUS 0x0018 | ||
| 38 | |||
| 39 | #define DSS_SYSCONFIG 0x10 | ||
| 40 | #define DSS_SYSSTATUS 0x14 | ||
| 41 | #define DSS_CONTROL 0x40 | ||
| 42 | #define DSS_SDI_CONTROL 0x44 | ||
| 43 | #define DSS_PLL_CONTROL 0x48 | ||
| 44 | |||
| 45 | #define LCD_EN_MASK (0x1 << 0) | ||
| 46 | #define DIGIT_EN_MASK (0x1 << 1) | ||
| 47 | |||
| 48 | #define FRAMEDONE_IRQ_SHIFT 0 | ||
| 49 | #define EVSYNC_EVEN_IRQ_SHIFT 2 | ||
| 50 | #define EVSYNC_ODD_IRQ_SHIFT 3 | ||
| 51 | #define FRAMEDONE2_IRQ_SHIFT 22 | ||
| 52 | #define FRAMEDONETV_IRQ_SHIFT 24 | ||
| 53 | |||
| 54 | /* | ||
| 55 | * FRAMEDONE_IRQ_TIMEOUT: how long (in milliseconds) to wait during DISPC | ||
| 56 | * reset before deciding that something has gone wrong | ||
| 57 | */ | ||
| 58 | #define FRAMEDONE_IRQ_TIMEOUT 100 | ||
| 32 | 59 | ||
| 33 | static struct platform_device omap_display_device = { | 60 | static struct platform_device omap_display_device = { |
| 34 | .name = "omapdss", | 61 | .name = "omapdss", |
| @@ -172,3 +199,135 @@ int __init omap_display_init(struct omap_dss_board_info *board_data) | |||
| 172 | 199 | ||
| 173 | return r; | 200 | return r; |
| 174 | } | 201 | } |
| 202 | |||
| 203 | static void dispc_disable_outputs(void) | ||
| 204 | { | ||
| 205 | u32 v, irq_mask = 0; | ||
| 206 | bool lcd_en, digit_en, lcd2_en = false; | ||
| 207 | int i; | ||
| 208 | struct omap_dss_dispc_dev_attr *da; | ||
| 209 | struct omap_hwmod *oh; | ||
| 210 | |||
| 211 | oh = omap_hwmod_lookup("dss_dispc"); | ||
| 212 | if (!oh) { | ||
| 213 | WARN(1, "display: could not disable outputs during reset - could not find dss_dispc hwmod\n"); | ||
| 214 | return; | ||
| 215 | } | ||
| 216 | |||
| 217 | if (!oh->dev_attr) { | ||
| 218 | pr_err("display: could not disable outputs during reset due to missing dev_attr\n"); | ||
| 219 | return; | ||
| 220 | } | ||
| 221 | |||
| 222 | da = (struct omap_dss_dispc_dev_attr *)oh->dev_attr; | ||
| 223 | |||
| 224 | /* store value of LCDENABLE and DIGITENABLE bits */ | ||
| 225 | v = omap_hwmod_read(oh, DISPC_CONTROL); | ||
| 226 | lcd_en = v & LCD_EN_MASK; | ||
| 227 | digit_en = v & DIGIT_EN_MASK; | ||
| 228 | |||
| 229 | /* store value of LCDENABLE for LCD2 */ | ||
| 230 | if (da->manager_count > 2) { | ||
| 231 | v = omap_hwmod_read(oh, DISPC_CONTROL2); | ||
| 232 | lcd2_en = v & LCD_EN_MASK; | ||
| 233 | } | ||
| 234 | |||
| 235 | if (!(lcd_en | digit_en | lcd2_en)) | ||
| 236 | return; /* no managers currently enabled */ | ||
| 237 | |||
| 238 | /* | ||
| 239 | * If any manager was enabled, we need to disable it before | ||
| 240 | * DSS clocks are disabled or DISPC module is reset | ||
| 241 | */ | ||
| 242 | if (lcd_en) | ||
| 243 | irq_mask |= 1 << FRAMEDONE_IRQ_SHIFT; | ||
| 244 | |||
| 245 | if (digit_en) { | ||
| 246 | if (da->has_framedonetv_irq) { | ||
| 247 | irq_mask |= 1 << FRAMEDONETV_IRQ_SHIFT; | ||
| 248 | } else { | ||
| 249 | irq_mask |= 1 << EVSYNC_EVEN_IRQ_SHIFT | | ||
| 250 | 1 << EVSYNC_ODD_IRQ_SHIFT; | ||
| 251 | } | ||
| 252 | } | ||
| 253 | |||
| 254 | if (lcd2_en) | ||
| 255 | irq_mask |= 1 << FRAMEDONE2_IRQ_SHIFT; | ||
| 256 | |||
| 257 | /* | ||
| 258 | * clear any previous FRAMEDONE, FRAMEDONETV, | ||
| 259 | * EVSYNC_EVEN/ODD or FRAMEDONE2 interrupts | ||
| 260 | */ | ||
| 261 | omap_hwmod_write(irq_mask, oh, DISPC_IRQSTATUS); | ||
| 262 | |||
| 263 | /* disable LCD and TV managers */ | ||
| 264 | v = omap_hwmod_read(oh, DISPC_CONTROL); | ||
| 265 | v &= ~(LCD_EN_MASK | DIGIT_EN_MASK); | ||
| 266 | omap_hwmod_write(v, oh, DISPC_CONTROL); | ||
| 267 | |||
| 268 | /* disable LCD2 manager */ | ||
| 269 | if (da->manager_count > 2) { | ||
| 270 | v = omap_hwmod_read(oh, DISPC_CONTROL2); | ||
| 271 | v &= ~LCD_EN_MASK; | ||
| 272 | omap_hwmod_write(v, oh, DISPC_CONTROL2); | ||
| 273 | } | ||
| 274 | |||
| 275 | i = 0; | ||
| 276 | while ((omap_hwmod_read(oh, DISPC_IRQSTATUS) & irq_mask) != | ||
| 277 | irq_mask) { | ||
| 278 | i++; | ||
| 279 | if (i > FRAMEDONE_IRQ_TIMEOUT) { | ||
| 280 | pr_err("didn't get FRAMEDONE1/2 or TV interrupt\n"); | ||
| 281 | break; | ||
| 282 | } | ||
| 283 | mdelay(1); | ||
| 284 | } | ||
| 285 | } | ||
| 286 | |||
| 287 | #define MAX_MODULE_SOFTRESET_WAIT 10000 | ||
| 288 | int omap_dss_reset(struct omap_hwmod *oh) | ||
| 289 | { | ||
| 290 | struct omap_hwmod_opt_clk *oc; | ||
| 291 | int c = 0; | ||
| 292 | int i, r; | ||
| 293 | |||
| 294 | if (!(oh->class->sysc->sysc_flags & SYSS_HAS_RESET_STATUS)) { | ||
| 295 | pr_err("dss_core: hwmod data doesn't contain reset data\n"); | ||
| 296 | return -EINVAL; | ||
| 297 | } | ||
| 298 | |||
| 299 | for (i = oh->opt_clks_cnt, oc = oh->opt_clks; i > 0; i--, oc++) | ||
| 300 | if (oc->_clk) | ||
| 301 | clk_enable(oc->_clk); | ||
| 302 | |||
| 303 | dispc_disable_outputs(); | ||
| 304 | |||
| 305 | /* clear SDI registers */ | ||
| 306 | if (cpu_is_omap3430()) { | ||
| 307 | omap_hwmod_write(0x0, oh, DSS_SDI_CONTROL); | ||
| 308 | omap_hwmod_write(0x0, oh, DSS_PLL_CONTROL); | ||
| 309 | } | ||
| 310 | |||
| 311 | /* | ||
| 312 | * clear DSS_CONTROL register to switch DSS clock sources to | ||
| 313 | * PRCM clock, if any | ||
| 314 | */ | ||
| 315 | omap_hwmod_write(0x0, oh, DSS_CONTROL); | ||
| 316 | |||
| 317 | omap_test_timeout((omap_hwmod_read(oh, oh->class->sysc->syss_offs) | ||
| 318 | & SYSS_RESETDONE_MASK), | ||
| 319 | MAX_MODULE_SOFTRESET_WAIT, c); | ||
| 320 | |||
| 321 | if (c == MAX_MODULE_SOFTRESET_WAIT) | ||
| 322 | pr_warning("dss_core: waiting for reset to finish failed\n"); | ||
| 323 | else | ||
| 324 | pr_debug("dss_core: softreset done\n"); | ||
| 325 | |||
| 326 | for (i = oh->opt_clks_cnt, oc = oh->opt_clks; i > 0; i--, oc++) | ||
| 327 | if (oc->_clk) | ||
| 328 | clk_disable(oc->_clk); | ||
| 329 | |||
| 330 | r = (c == MAX_MODULE_SOFTRESET_WAIT) ? -ETIMEDOUT : 0; | ||
| 331 | |||
| 332 | return r; | ||
| 333 | } | ||
diff --git a/arch/arm/mach-omap2/display.h b/arch/arm/mach-omap2/display.h new file mode 100644 index 000000000000..b871b017b352 --- /dev/null +++ b/arch/arm/mach-omap2/display.h | |||
| @@ -0,0 +1,29 @@ | |||
| 1 | /* | ||
| 2 | * display.h - OMAP2+ integration-specific DSS header | ||
| 3 | * | ||
| 4 | * Copyright (C) 2011 Texas Instruments, Inc. | ||
| 5 | * | ||
| 6 | * This program is free software; you can redistribute it and/or modify it | ||
| 7 | * under the terms of the GNU General Public License version 2 as published by | ||
| 8 | * the Free Software Foundation. | ||
| 9 | * | ||
| 10 | * This program is distributed in the hope that it will be useful, but WITHOUT | ||
| 11 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| 12 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for | ||
| 13 | * more details. | ||
| 14 | * | ||
| 15 | * You should have received a copy of the GNU General Public License along with | ||
| 16 | * this program. If not, see <http://www.gnu.org/licenses/>. | ||
| 17 | */ | ||
| 18 | |||
| 19 | #ifndef __ARCH_ARM_MACH_OMAP2_DISPLAY_H | ||
| 20 | #define __ARCH_ARM_MACH_OMAP2_DISPLAY_H | ||
| 21 | |||
| 22 | #include <linux/kernel.h> | ||
| 23 | |||
| 24 | struct omap_dss_dispc_dev_attr { | ||
| 25 | u8 manager_count; | ||
| 26 | bool has_framedonetv_irq; | ||
| 27 | }; | ||
| 28 | |||
| 29 | #endif | ||
diff --git a/arch/arm/mach-omap2/io.h b/arch/arm/mach-omap2/io.h deleted file mode 100644 index e69de29bb2d1..000000000000 --- a/arch/arm/mach-omap2/io.h +++ /dev/null | |||
diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c index 292eee3be15f..28fcb27005d2 100644 --- a/arch/arm/mach-omap2/mcbsp.c +++ b/arch/arm/mach-omap2/mcbsp.c | |||
| @@ -145,6 +145,9 @@ static int omap_init_mcbsp(struct omap_hwmod *oh, void *unused) | |||
| 145 | pdata->reg_size = 4; | 145 | pdata->reg_size = 4; |
| 146 | pdata->has_ccr = true; | 146 | pdata->has_ccr = true; |
| 147 | } | 147 | } |
| 148 | pdata->set_clk_src = omap2_mcbsp_set_clk_src; | ||
| 149 | if (id == 1) | ||
| 150 | pdata->mux_signal = omap2_mcbsp1_mux_rx_clk; | ||
| 148 | 151 | ||
| 149 | if (oh->class->rev == MCBSP_CONFIG_TYPE3) { | 152 | if (oh->class->rev == MCBSP_CONFIG_TYPE3) { |
| 150 | if (id == 2) | 153 | if (id == 2) |
| @@ -174,9 +177,6 @@ static int omap_init_mcbsp(struct omap_hwmod *oh, void *unused) | |||
| 174 | name, oh->name); | 177 | name, oh->name); |
| 175 | return PTR_ERR(pdev); | 178 | return PTR_ERR(pdev); |
| 176 | } | 179 | } |
| 177 | pdata->set_clk_src = omap2_mcbsp_set_clk_src; | ||
| 178 | if (id == 1) | ||
| 179 | pdata->mux_signal = omap2_mcbsp1_mux_rx_clk; | ||
| 180 | omap_mcbsp_count++; | 180 | omap_mcbsp_count++; |
| 181 | return 0; | 181 | return 0; |
| 182 | } | 182 | } |
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 6b3088db83b7..207a2ff9a8c4 100644 --- a/arch/arm/mach-omap2/omap_hwmod.c +++ b/arch/arm/mach-omap2/omap_hwmod.c | |||
| @@ -749,7 +749,7 @@ static int _count_mpu_irqs(struct omap_hwmod *oh) | |||
| 749 | ohii = &oh->mpu_irqs[i++]; | 749 | ohii = &oh->mpu_irqs[i++]; |
| 750 | } while (ohii->irq != -1); | 750 | } while (ohii->irq != -1); |
| 751 | 751 | ||
| 752 | return i; | 752 | return i-1; |
| 753 | } | 753 | } |
| 754 | 754 | ||
| 755 | /** | 755 | /** |
| @@ -772,7 +772,7 @@ static int _count_sdma_reqs(struct omap_hwmod *oh) | |||
| 772 | ohdi = &oh->sdma_reqs[i++]; | 772 | ohdi = &oh->sdma_reqs[i++]; |
| 773 | } while (ohdi->dma_req != -1); | 773 | } while (ohdi->dma_req != -1); |
| 774 | 774 | ||
| 775 | return i; | 775 | return i-1; |
| 776 | } | 776 | } |
| 777 | 777 | ||
| 778 | /** | 778 | /** |
| @@ -795,7 +795,7 @@ static int _count_ocp_if_addr_spaces(struct omap_hwmod_ocp_if *os) | |||
| 795 | mem = &os->addr[i++]; | 795 | mem = &os->addr[i++]; |
| 796 | } while (mem->pa_start != mem->pa_end); | 796 | } while (mem->pa_start != mem->pa_end); |
| 797 | 797 | ||
| 798 | return i; | 798 | return i-1; |
| 799 | } | 799 | } |
| 800 | 800 | ||
| 801 | /** | 801 | /** |
diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c b/arch/arm/mach-omap2/omap_hwmod_2420_data.c index 6d7206213525..a5409ce3f323 100644 --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c | |||
| @@ -875,6 +875,10 @@ static struct omap_hwmod_ocp_if *omap2420_dss_slaves[] = { | |||
| 875 | }; | 875 | }; |
| 876 | 876 | ||
| 877 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { | 877 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { |
| 878 | /* | ||
| 879 | * The DSS HW needs all DSS clocks enabled during reset. The dss_core | ||
| 880 | * driver does not use these clocks. | ||
| 881 | */ | ||
| 878 | { .role = "tv_clk", .clk = "dss_54m_fck" }, | 882 | { .role = "tv_clk", .clk = "dss_54m_fck" }, |
| 879 | { .role = "sys_clk", .clk = "dss2_fck" }, | 883 | { .role = "sys_clk", .clk = "dss2_fck" }, |
| 880 | }; | 884 | }; |
| @@ -899,7 +903,7 @@ static struct omap_hwmod omap2420_dss_core_hwmod = { | |||
| 899 | .slaves_cnt = ARRAY_SIZE(omap2420_dss_slaves), | 903 | .slaves_cnt = ARRAY_SIZE(omap2420_dss_slaves), |
| 900 | .masters = omap2420_dss_masters, | 904 | .masters = omap2420_dss_masters, |
| 901 | .masters_cnt = ARRAY_SIZE(omap2420_dss_masters), | 905 | .masters_cnt = ARRAY_SIZE(omap2420_dss_masters), |
| 902 | .flags = HWMOD_NO_IDLEST, | 906 | .flags = HWMOD_NO_IDLEST | HWMOD_CONTROL_OPT_CLKS_IN_RESET, |
| 903 | }; | 907 | }; |
| 904 | 908 | ||
| 905 | /* l4_core -> dss_dispc */ | 909 | /* l4_core -> dss_dispc */ |
| @@ -939,6 +943,7 @@ static struct omap_hwmod omap2420_dss_dispc_hwmod = { | |||
| 939 | .slaves = omap2420_dss_dispc_slaves, | 943 | .slaves = omap2420_dss_dispc_slaves, |
| 940 | .slaves_cnt = ARRAY_SIZE(omap2420_dss_dispc_slaves), | 944 | .slaves_cnt = ARRAY_SIZE(omap2420_dss_dispc_slaves), |
| 941 | .flags = HWMOD_NO_IDLEST, | 945 | .flags = HWMOD_NO_IDLEST, |
| 946 | .dev_attr = &omap2_3_dss_dispc_dev_attr | ||
| 942 | }; | 947 | }; |
| 943 | 948 | ||
| 944 | /* l4_core -> dss_rfbi */ | 949 | /* l4_core -> dss_rfbi */ |
| @@ -961,6 +966,10 @@ static struct omap_hwmod_ocp_if *omap2420_dss_rfbi_slaves[] = { | |||
| 961 | &omap2420_l4_core__dss_rfbi, | 966 | &omap2420_l4_core__dss_rfbi, |
| 962 | }; | 967 | }; |
| 963 | 968 | ||
| 969 | static struct omap_hwmod_opt_clk dss_rfbi_opt_clks[] = { | ||
| 970 | { .role = "ick", .clk = "dss_ick" }, | ||
| 971 | }; | ||
| 972 | |||
| 964 | static struct omap_hwmod omap2420_dss_rfbi_hwmod = { | 973 | static struct omap_hwmod omap2420_dss_rfbi_hwmod = { |
| 965 | .name = "dss_rfbi", | 974 | .name = "dss_rfbi", |
| 966 | .class = &omap2_rfbi_hwmod_class, | 975 | .class = &omap2_rfbi_hwmod_class, |
| @@ -972,6 +981,8 @@ static struct omap_hwmod omap2420_dss_rfbi_hwmod = { | |||
| 972 | .module_offs = CORE_MOD, | 981 | .module_offs = CORE_MOD, |
| 973 | }, | 982 | }, |
| 974 | }, | 983 | }, |
| 984 | .opt_clks = dss_rfbi_opt_clks, | ||
| 985 | .opt_clks_cnt = ARRAY_SIZE(dss_rfbi_opt_clks), | ||
| 975 | .slaves = omap2420_dss_rfbi_slaves, | 986 | .slaves = omap2420_dss_rfbi_slaves, |
| 976 | .slaves_cnt = ARRAY_SIZE(omap2420_dss_rfbi_slaves), | 987 | .slaves_cnt = ARRAY_SIZE(omap2420_dss_rfbi_slaves), |
| 977 | .flags = HWMOD_NO_IDLEST, | 988 | .flags = HWMOD_NO_IDLEST, |
| @@ -981,7 +992,7 @@ static struct omap_hwmod omap2420_dss_rfbi_hwmod = { | |||
| 981 | static struct omap_hwmod_ocp_if omap2420_l4_core__dss_venc = { | 992 | static struct omap_hwmod_ocp_if omap2420_l4_core__dss_venc = { |
| 982 | .master = &omap2420_l4_core_hwmod, | 993 | .master = &omap2420_l4_core_hwmod, |
| 983 | .slave = &omap2420_dss_venc_hwmod, | 994 | .slave = &omap2420_dss_venc_hwmod, |
| 984 | .clk = "dss_54m_fck", | 995 | .clk = "dss_ick", |
| 985 | .addr = omap2_dss_venc_addrs, | 996 | .addr = omap2_dss_venc_addrs, |
| 986 | .fw = { | 997 | .fw = { |
| 987 | .omap2 = { | 998 | .omap2 = { |
| @@ -1001,7 +1012,7 @@ static struct omap_hwmod_ocp_if *omap2420_dss_venc_slaves[] = { | |||
| 1001 | static struct omap_hwmod omap2420_dss_venc_hwmod = { | 1012 | static struct omap_hwmod omap2420_dss_venc_hwmod = { |
| 1002 | .name = "dss_venc", | 1013 | .name = "dss_venc", |
| 1003 | .class = &omap2_venc_hwmod_class, | 1014 | .class = &omap2_venc_hwmod_class, |
| 1004 | .main_clk = "dss1_fck", | 1015 | .main_clk = "dss_54m_fck", |
| 1005 | .prcm = { | 1016 | .prcm = { |
| 1006 | .omap2 = { | 1017 | .omap2 = { |
| 1007 | .prcm_reg_id = 1, | 1018 | .prcm_reg_id = 1, |
diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c b/arch/arm/mach-omap2/omap_hwmod_2430_data.c index a2580d01c3ff..c4f56cb60d7d 100644 --- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c | |||
| @@ -942,6 +942,10 @@ static struct omap_hwmod_ocp_if *omap2430_dss_slaves[] = { | |||
| 942 | }; | 942 | }; |
| 943 | 943 | ||
| 944 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { | 944 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { |
| 945 | /* | ||
| 946 | * The DSS HW needs all DSS clocks enabled during reset. The dss_core | ||
| 947 | * driver does not use these clocks. | ||
| 948 | */ | ||
| 945 | { .role = "tv_clk", .clk = "dss_54m_fck" }, | 949 | { .role = "tv_clk", .clk = "dss_54m_fck" }, |
| 946 | { .role = "sys_clk", .clk = "dss2_fck" }, | 950 | { .role = "sys_clk", .clk = "dss2_fck" }, |
| 947 | }; | 951 | }; |
| @@ -966,7 +970,7 @@ static struct omap_hwmod omap2430_dss_core_hwmod = { | |||
| 966 | .slaves_cnt = ARRAY_SIZE(omap2430_dss_slaves), | 970 | .slaves_cnt = ARRAY_SIZE(omap2430_dss_slaves), |
| 967 | .masters = omap2430_dss_masters, | 971 | .masters = omap2430_dss_masters, |
| 968 | .masters_cnt = ARRAY_SIZE(omap2430_dss_masters), | 972 | .masters_cnt = ARRAY_SIZE(omap2430_dss_masters), |
| 969 | .flags = HWMOD_NO_IDLEST, | 973 | .flags = HWMOD_NO_IDLEST | HWMOD_CONTROL_OPT_CLKS_IN_RESET, |
| 970 | }; | 974 | }; |
| 971 | 975 | ||
| 972 | /* l4_core -> dss_dispc */ | 976 | /* l4_core -> dss_dispc */ |
| @@ -1000,6 +1004,7 @@ static struct omap_hwmod omap2430_dss_dispc_hwmod = { | |||
| 1000 | .slaves = omap2430_dss_dispc_slaves, | 1004 | .slaves = omap2430_dss_dispc_slaves, |
| 1001 | .slaves_cnt = ARRAY_SIZE(omap2430_dss_dispc_slaves), | 1005 | .slaves_cnt = ARRAY_SIZE(omap2430_dss_dispc_slaves), |
| 1002 | .flags = HWMOD_NO_IDLEST, | 1006 | .flags = HWMOD_NO_IDLEST, |
| 1007 | .dev_attr = &omap2_3_dss_dispc_dev_attr | ||
| 1003 | }; | 1008 | }; |
| 1004 | 1009 | ||
| 1005 | /* l4_core -> dss_rfbi */ | 1010 | /* l4_core -> dss_rfbi */ |
| @@ -1016,6 +1021,10 @@ static struct omap_hwmod_ocp_if *omap2430_dss_rfbi_slaves[] = { | |||
| 1016 | &omap2430_l4_core__dss_rfbi, | 1021 | &omap2430_l4_core__dss_rfbi, |
| 1017 | }; | 1022 | }; |
| 1018 | 1023 | ||
| 1024 | static struct omap_hwmod_opt_clk dss_rfbi_opt_clks[] = { | ||
| 1025 | { .role = "ick", .clk = "dss_ick" }, | ||
| 1026 | }; | ||
| 1027 | |||
| 1019 | static struct omap_hwmod omap2430_dss_rfbi_hwmod = { | 1028 | static struct omap_hwmod omap2430_dss_rfbi_hwmod = { |
| 1020 | .name = "dss_rfbi", | 1029 | .name = "dss_rfbi", |
| 1021 | .class = &omap2_rfbi_hwmod_class, | 1030 | .class = &omap2_rfbi_hwmod_class, |
| @@ -1027,6 +1036,8 @@ static struct omap_hwmod omap2430_dss_rfbi_hwmod = { | |||
| 1027 | .module_offs = CORE_MOD, | 1036 | .module_offs = CORE_MOD, |
| 1028 | }, | 1037 | }, |
| 1029 | }, | 1038 | }, |
| 1039 | .opt_clks = dss_rfbi_opt_clks, | ||
| 1040 | .opt_clks_cnt = ARRAY_SIZE(dss_rfbi_opt_clks), | ||
| 1030 | .slaves = omap2430_dss_rfbi_slaves, | 1041 | .slaves = omap2430_dss_rfbi_slaves, |
| 1031 | .slaves_cnt = ARRAY_SIZE(omap2430_dss_rfbi_slaves), | 1042 | .slaves_cnt = ARRAY_SIZE(omap2430_dss_rfbi_slaves), |
| 1032 | .flags = HWMOD_NO_IDLEST, | 1043 | .flags = HWMOD_NO_IDLEST, |
| @@ -1036,7 +1047,7 @@ static struct omap_hwmod omap2430_dss_rfbi_hwmod = { | |||
| 1036 | static struct omap_hwmod_ocp_if omap2430_l4_core__dss_venc = { | 1047 | static struct omap_hwmod_ocp_if omap2430_l4_core__dss_venc = { |
| 1037 | .master = &omap2430_l4_core_hwmod, | 1048 | .master = &omap2430_l4_core_hwmod, |
| 1038 | .slave = &omap2430_dss_venc_hwmod, | 1049 | .slave = &omap2430_dss_venc_hwmod, |
| 1039 | .clk = "dss_54m_fck", | 1050 | .clk = "dss_ick", |
| 1040 | .addr = omap2_dss_venc_addrs, | 1051 | .addr = omap2_dss_venc_addrs, |
| 1041 | .flags = OCPIF_SWSUP_IDLE, | 1052 | .flags = OCPIF_SWSUP_IDLE, |
| 1042 | .user = OCP_USER_MPU | OCP_USER_SDMA, | 1053 | .user = OCP_USER_MPU | OCP_USER_SDMA, |
| @@ -1050,7 +1061,7 @@ static struct omap_hwmod_ocp_if *omap2430_dss_venc_slaves[] = { | |||
| 1050 | static struct omap_hwmod omap2430_dss_venc_hwmod = { | 1061 | static struct omap_hwmod omap2430_dss_venc_hwmod = { |
| 1051 | .name = "dss_venc", | 1062 | .name = "dss_venc", |
| 1052 | .class = &omap2_venc_hwmod_class, | 1063 | .class = &omap2_venc_hwmod_class, |
| 1053 | .main_clk = "dss1_fck", | 1064 | .main_clk = "dss_54m_fck", |
| 1054 | .prcm = { | 1065 | .prcm = { |
| 1055 | .omap2 = { | 1066 | .omap2 = { |
| 1056 | .prcm_reg_id = 1, | 1067 | .prcm_reg_id = 1, |
diff --git a/arch/arm/mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c index c451729d289a..c11273da5dcc 100644 --- a/arch/arm/mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c | |||
| @@ -11,6 +11,7 @@ | |||
| 11 | #include <plat/omap_hwmod.h> | 11 | #include <plat/omap_hwmod.h> |
| 12 | #include <plat/serial.h> | 12 | #include <plat/serial.h> |
| 13 | #include <plat/dma.h> | 13 | #include <plat/dma.h> |
| 14 | #include <plat/common.h> | ||
| 14 | 15 | ||
| 15 | #include <mach/irqs.h> | 16 | #include <mach/irqs.h> |
| 16 | 17 | ||
| @@ -43,13 +44,15 @@ static struct omap_hwmod_class_sysconfig omap2_dss_sysc = { | |||
| 43 | .rev_offs = 0x0000, | 44 | .rev_offs = 0x0000, |
| 44 | .sysc_offs = 0x0010, | 45 | .sysc_offs = 0x0010, |
| 45 | .syss_offs = 0x0014, | 46 | .syss_offs = 0x0014, |
| 46 | .sysc_flags = (SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE), | 47 | .sysc_flags = (SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE | |
| 48 | SYSS_HAS_RESET_STATUS), | ||
| 47 | .sysc_fields = &omap_hwmod_sysc_type1, | 49 | .sysc_fields = &omap_hwmod_sysc_type1, |
| 48 | }; | 50 | }; |
| 49 | 51 | ||
| 50 | struct omap_hwmod_class omap2_dss_hwmod_class = { | 52 | struct omap_hwmod_class omap2_dss_hwmod_class = { |
| 51 | .name = "dss", | 53 | .name = "dss", |
| 52 | .sysc = &omap2_dss_sysc, | 54 | .sysc = &omap2_dss_sysc, |
| 55 | .reset = omap_dss_reset, | ||
| 53 | }; | 56 | }; |
| 54 | 57 | ||
| 55 | /* | 58 | /* |
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c index bc9035ec87fc..7f8915ad5099 100644 --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | |||
| @@ -1369,9 +1369,14 @@ static struct omap_hwmod_ocp_if *omap3xxx_dss_slaves[] = { | |||
| 1369 | }; | 1369 | }; |
| 1370 | 1370 | ||
| 1371 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { | 1371 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { |
| 1372 | { .role = "tv_clk", .clk = "dss_tv_fck" }, | 1372 | /* |
| 1373 | { .role = "video_clk", .clk = "dss_96m_fck" }, | 1373 | * The DSS HW needs all DSS clocks enabled during reset. The dss_core |
| 1374 | * driver does not use these clocks. | ||
| 1375 | */ | ||
| 1374 | { .role = "sys_clk", .clk = "dss2_alwon_fck" }, | 1376 | { .role = "sys_clk", .clk = "dss2_alwon_fck" }, |
| 1377 | { .role = "tv_clk", .clk = "dss_tv_fck" }, | ||
| 1378 | /* required only on OMAP3430 */ | ||
| 1379 | { .role = "tv_dac_clk", .clk = "dss_96m_fck" }, | ||
| 1375 | }; | 1380 | }; |
| 1376 | 1381 | ||
| 1377 | static struct omap_hwmod omap3430es1_dss_core_hwmod = { | 1382 | static struct omap_hwmod omap3430es1_dss_core_hwmod = { |
| @@ -1394,11 +1399,12 @@ static struct omap_hwmod omap3430es1_dss_core_hwmod = { | |||
| 1394 | .slaves_cnt = ARRAY_SIZE(omap3430es1_dss_slaves), | 1399 | .slaves_cnt = ARRAY_SIZE(omap3430es1_dss_slaves), |
| 1395 | .masters = omap3xxx_dss_masters, | 1400 | .masters = omap3xxx_dss_masters, |
| 1396 | .masters_cnt = ARRAY_SIZE(omap3xxx_dss_masters), | 1401 | .masters_cnt = ARRAY_SIZE(omap3xxx_dss_masters), |
| 1397 | .flags = HWMOD_NO_IDLEST, | 1402 | .flags = HWMOD_NO_IDLEST | HWMOD_CONTROL_OPT_CLKS_IN_RESET, |
| 1398 | }; | 1403 | }; |
| 1399 | 1404 | ||
| 1400 | static struct omap_hwmod omap3xxx_dss_core_hwmod = { | 1405 | static struct omap_hwmod omap3xxx_dss_core_hwmod = { |
| 1401 | .name = "dss_core", | 1406 | .name = "dss_core", |
| 1407 | .flags = HWMOD_CONTROL_OPT_CLKS_IN_RESET, | ||
| 1402 | .class = &omap2_dss_hwmod_class, | 1408 | .class = &omap2_dss_hwmod_class, |
| 1403 | .main_clk = "dss1_alwon_fck", /* instead of dss_fck */ | 1409 | .main_clk = "dss1_alwon_fck", /* instead of dss_fck */ |
| 1404 | .sdma_reqs = omap3xxx_dss_sdma_chs, | 1410 | .sdma_reqs = omap3xxx_dss_sdma_chs, |
| @@ -1456,6 +1462,7 @@ static struct omap_hwmod omap3xxx_dss_dispc_hwmod = { | |||
| 1456 | .slaves = omap3xxx_dss_dispc_slaves, | 1462 | .slaves = omap3xxx_dss_dispc_slaves, |
| 1457 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_dispc_slaves), | 1463 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_dispc_slaves), |
| 1458 | .flags = HWMOD_NO_IDLEST, | 1464 | .flags = HWMOD_NO_IDLEST, |
| 1465 | .dev_attr = &omap2_3_dss_dispc_dev_attr | ||
| 1459 | }; | 1466 | }; |
| 1460 | 1467 | ||
| 1461 | /* | 1468 | /* |
| @@ -1486,6 +1493,7 @@ static struct omap_hwmod_addr_space omap3xxx_dss_dsi1_addrs[] = { | |||
| 1486 | static struct omap_hwmod_ocp_if omap3xxx_l4_core__dss_dsi1 = { | 1493 | static struct omap_hwmod_ocp_if omap3xxx_l4_core__dss_dsi1 = { |
| 1487 | .master = &omap3xxx_l4_core_hwmod, | 1494 | .master = &omap3xxx_l4_core_hwmod, |
| 1488 | .slave = &omap3xxx_dss_dsi1_hwmod, | 1495 | .slave = &omap3xxx_dss_dsi1_hwmod, |
| 1496 | .clk = "dss_ick", | ||
| 1489 | .addr = omap3xxx_dss_dsi1_addrs, | 1497 | .addr = omap3xxx_dss_dsi1_addrs, |
| 1490 | .fw = { | 1498 | .fw = { |
| 1491 | .omap2 = { | 1499 | .omap2 = { |
| @@ -1502,6 +1510,10 @@ static struct omap_hwmod_ocp_if *omap3xxx_dss_dsi1_slaves[] = { | |||
| 1502 | &omap3xxx_l4_core__dss_dsi1, | 1510 | &omap3xxx_l4_core__dss_dsi1, |
| 1503 | }; | 1511 | }; |
| 1504 | 1512 | ||
| 1513 | static struct omap_hwmod_opt_clk dss_dsi1_opt_clks[] = { | ||
| 1514 | { .role = "sys_clk", .clk = "dss2_alwon_fck" }, | ||
| 1515 | }; | ||
| 1516 | |||
| 1505 | static struct omap_hwmod omap3xxx_dss_dsi1_hwmod = { | 1517 | static struct omap_hwmod omap3xxx_dss_dsi1_hwmod = { |
| 1506 | .name = "dss_dsi1", | 1518 | .name = "dss_dsi1", |
| 1507 | .class = &omap3xxx_dsi_hwmod_class, | 1519 | .class = &omap3xxx_dsi_hwmod_class, |
| @@ -1514,6 +1526,8 @@ static struct omap_hwmod omap3xxx_dss_dsi1_hwmod = { | |||
| 1514 | .module_offs = OMAP3430_DSS_MOD, | 1526 | .module_offs = OMAP3430_DSS_MOD, |
| 1515 | }, | 1527 | }, |
| 1516 | }, | 1528 | }, |
| 1529 | .opt_clks = dss_dsi1_opt_clks, | ||
| 1530 | .opt_clks_cnt = ARRAY_SIZE(dss_dsi1_opt_clks), | ||
| 1517 | .slaves = omap3xxx_dss_dsi1_slaves, | 1531 | .slaves = omap3xxx_dss_dsi1_slaves, |
| 1518 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_dsi1_slaves), | 1532 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_dsi1_slaves), |
| 1519 | .flags = HWMOD_NO_IDLEST, | 1533 | .flags = HWMOD_NO_IDLEST, |
| @@ -1540,6 +1554,10 @@ static struct omap_hwmod_ocp_if *omap3xxx_dss_rfbi_slaves[] = { | |||
| 1540 | &omap3xxx_l4_core__dss_rfbi, | 1554 | &omap3xxx_l4_core__dss_rfbi, |
| 1541 | }; | 1555 | }; |
| 1542 | 1556 | ||
| 1557 | static struct omap_hwmod_opt_clk dss_rfbi_opt_clks[] = { | ||
| 1558 | { .role = "ick", .clk = "dss_ick" }, | ||
| 1559 | }; | ||
| 1560 | |||
| 1543 | static struct omap_hwmod omap3xxx_dss_rfbi_hwmod = { | 1561 | static struct omap_hwmod omap3xxx_dss_rfbi_hwmod = { |
| 1544 | .name = "dss_rfbi", | 1562 | .name = "dss_rfbi", |
| 1545 | .class = &omap2_rfbi_hwmod_class, | 1563 | .class = &omap2_rfbi_hwmod_class, |
| @@ -1551,6 +1569,8 @@ static struct omap_hwmod omap3xxx_dss_rfbi_hwmod = { | |||
| 1551 | .module_offs = OMAP3430_DSS_MOD, | 1569 | .module_offs = OMAP3430_DSS_MOD, |
| 1552 | }, | 1570 | }, |
| 1553 | }, | 1571 | }, |
| 1572 | .opt_clks = dss_rfbi_opt_clks, | ||
| 1573 | .opt_clks_cnt = ARRAY_SIZE(dss_rfbi_opt_clks), | ||
| 1554 | .slaves = omap3xxx_dss_rfbi_slaves, | 1574 | .slaves = omap3xxx_dss_rfbi_slaves, |
| 1555 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_rfbi_slaves), | 1575 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_rfbi_slaves), |
| 1556 | .flags = HWMOD_NO_IDLEST, | 1576 | .flags = HWMOD_NO_IDLEST, |
| @@ -1560,7 +1580,7 @@ static struct omap_hwmod omap3xxx_dss_rfbi_hwmod = { | |||
| 1560 | static struct omap_hwmod_ocp_if omap3xxx_l4_core__dss_venc = { | 1580 | static struct omap_hwmod_ocp_if omap3xxx_l4_core__dss_venc = { |
| 1561 | .master = &omap3xxx_l4_core_hwmod, | 1581 | .master = &omap3xxx_l4_core_hwmod, |
| 1562 | .slave = &omap3xxx_dss_venc_hwmod, | 1582 | .slave = &omap3xxx_dss_venc_hwmod, |
| 1563 | .clk = "dss_tv_fck", | 1583 | .clk = "dss_ick", |
| 1564 | .addr = omap2_dss_venc_addrs, | 1584 | .addr = omap2_dss_venc_addrs, |
| 1565 | .fw = { | 1585 | .fw = { |
| 1566 | .omap2 = { | 1586 | .omap2 = { |
| @@ -1578,10 +1598,15 @@ static struct omap_hwmod_ocp_if *omap3xxx_dss_venc_slaves[] = { | |||
| 1578 | &omap3xxx_l4_core__dss_venc, | 1598 | &omap3xxx_l4_core__dss_venc, |
| 1579 | }; | 1599 | }; |
| 1580 | 1600 | ||
| 1601 | static struct omap_hwmod_opt_clk dss_venc_opt_clks[] = { | ||
| 1602 | /* required only on OMAP3430 */ | ||
| 1603 | { .role = "tv_dac_clk", .clk = "dss_96m_fck" }, | ||
| 1604 | }; | ||
| 1605 | |||
| 1581 | static struct omap_hwmod omap3xxx_dss_venc_hwmod = { | 1606 | static struct omap_hwmod omap3xxx_dss_venc_hwmod = { |
| 1582 | .name = "dss_venc", | 1607 | .name = "dss_venc", |
| 1583 | .class = &omap2_venc_hwmod_class, | 1608 | .class = &omap2_venc_hwmod_class, |
| 1584 | .main_clk = "dss1_alwon_fck", | 1609 | .main_clk = "dss_tv_fck", |
| 1585 | .prcm = { | 1610 | .prcm = { |
| 1586 | .omap2 = { | 1611 | .omap2 = { |
| 1587 | .prcm_reg_id = 1, | 1612 | .prcm_reg_id = 1, |
| @@ -1589,6 +1614,8 @@ static struct omap_hwmod omap3xxx_dss_venc_hwmod = { | |||
| 1589 | .module_offs = OMAP3430_DSS_MOD, | 1614 | .module_offs = OMAP3430_DSS_MOD, |
| 1590 | }, | 1615 | }, |
| 1591 | }, | 1616 | }, |
| 1617 | .opt_clks = dss_venc_opt_clks, | ||
| 1618 | .opt_clks_cnt = ARRAY_SIZE(dss_venc_opt_clks), | ||
| 1592 | .slaves = omap3xxx_dss_venc_slaves, | 1619 | .slaves = omap3xxx_dss_venc_slaves, |
| 1593 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_venc_slaves), | 1620 | .slaves_cnt = ARRAY_SIZE(omap3xxx_dss_venc_slaves), |
| 1594 | .flags = HWMOD_NO_IDLEST, | 1621 | .flags = HWMOD_NO_IDLEST, |
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c index 7695e5d43316..daaf165af696 100644 --- a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_44xx_data.c | |||
| @@ -30,6 +30,7 @@ | |||
| 30 | #include <plat/mmc.h> | 30 | #include <plat/mmc.h> |
| 31 | #include <plat/i2c.h> | 31 | #include <plat/i2c.h> |
| 32 | #include <plat/dmtimer.h> | 32 | #include <plat/dmtimer.h> |
| 33 | #include <plat/common.h> | ||
| 33 | 34 | ||
| 34 | #include "omap_hwmod_common_data.h" | 35 | #include "omap_hwmod_common_data.h" |
| 35 | 36 | ||
| @@ -1187,6 +1188,7 @@ static struct omap_hwmod_class_sysconfig omap44xx_dss_sysc = { | |||
| 1187 | static struct omap_hwmod_class omap44xx_dss_hwmod_class = { | 1188 | static struct omap_hwmod_class omap44xx_dss_hwmod_class = { |
| 1188 | .name = "dss", | 1189 | .name = "dss", |
| 1189 | .sysc = &omap44xx_dss_sysc, | 1190 | .sysc = &omap44xx_dss_sysc, |
| 1191 | .reset = omap_dss_reset, | ||
| 1190 | }; | 1192 | }; |
| 1191 | 1193 | ||
| 1192 | /* dss */ | 1194 | /* dss */ |
| @@ -1240,12 +1242,12 @@ static struct omap_hwmod_ocp_if *omap44xx_dss_slaves[] = { | |||
| 1240 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { | 1242 | static struct omap_hwmod_opt_clk dss_opt_clks[] = { |
| 1241 | { .role = "sys_clk", .clk = "dss_sys_clk" }, | 1243 | { .role = "sys_clk", .clk = "dss_sys_clk" }, |
| 1242 | { .role = "tv_clk", .clk = "dss_tv_clk" }, | 1244 | { .role = "tv_clk", .clk = "dss_tv_clk" }, |
| 1243 | { .role = "dss_clk", .clk = "dss_dss_clk" }, | 1245 | { .role = "hdmi_clk", .clk = "dss_48mhz_clk" }, |
| 1244 | { .role = "video_clk", .clk = "dss_48mhz_clk" }, | ||
| 1245 | }; | 1246 | }; |
| 1246 | 1247 | ||
| 1247 | static struct omap_hwmod omap44xx_dss_hwmod = { | 1248 | static struct omap_hwmod omap44xx_dss_hwmod = { |
| 1248 | .name = "dss_core", | 1249 | .name = "dss_core", |
| 1250 | .flags = HWMOD_CONTROL_OPT_CLKS_IN_RESET, | ||
| 1249 | .class = &omap44xx_dss_hwmod_class, | 1251 | .class = &omap44xx_dss_hwmod_class, |
| 1250 | .clkdm_name = "l3_dss_clkdm", | 1252 | .clkdm_name = "l3_dss_clkdm", |
| 1251 | .main_clk = "dss_dss_clk", | 1253 | .main_clk = "dss_dss_clk", |
| @@ -1325,6 +1327,11 @@ static struct omap_hwmod_addr_space omap44xx_dss_dispc_addrs[] = { | |||
| 1325 | { } | 1327 | { } |
| 1326 | }; | 1328 | }; |
| 1327 | 1329 | ||
| 1330 | static struct omap_dss_dispc_dev_attr omap44xx_dss_dispc_dev_attr = { | ||
| 1331 | .manager_count = 3, | ||
| 1332 | .has_framedonetv_irq = 1 | ||
| 1333 | }; | ||
| 1334 | |||
| 1328 | /* l4_per -> dss_dispc */ | 1335 | /* l4_per -> dss_dispc */ |
| 1329 | static struct omap_hwmod_ocp_if omap44xx_l4_per__dss_dispc = { | 1336 | static struct omap_hwmod_ocp_if omap44xx_l4_per__dss_dispc = { |
| 1330 | .master = &omap44xx_l4_per_hwmod, | 1337 | .master = &omap44xx_l4_per_hwmod, |
| @@ -1340,12 +1347,6 @@ static struct omap_hwmod_ocp_if *omap44xx_dss_dispc_slaves[] = { | |||
| 1340 | &omap44xx_l4_per__dss_dispc, | 1347 | &omap44xx_l4_per__dss_dispc, |
| 1341 | }; | 1348 | }; |
| 1342 | 1349 | ||
| 1343 | static struct omap_hwmod_opt_clk dss_dispc_opt_clks[] = { | ||
| 1344 | { .role = "sys_clk", .clk = "dss_sys_clk" }, | ||
| 1345 | { .role = "tv_clk", .clk = "dss_tv_clk" }, | ||
| 1346 | { .role = "hdmi_clk", .clk = "dss_48mhz_clk" }, | ||
| 1347 | }; | ||
| 1348 | |||
| 1349 | static struct omap_hwmod omap44xx_dss_dispc_hwmod = { | 1350 | static struct omap_hwmod omap44xx_dss_dispc_hwmod = { |
| 1350 | .name = "dss_dispc", | 1351 | .name = "dss_dispc", |
| 1351 | .class = &omap44xx_dispc_hwmod_class, | 1352 | .class = &omap44xx_dispc_hwmod_class, |
| @@ -1359,10 +1360,9 @@ static struct omap_hwmod omap44xx_dss_dispc_hwmod = { | |||
| 1359 | .context_offs = OMAP4_RM_DSS_DSS_CONTEXT_OFFSET, | 1360 | .context_offs = OMAP4_RM_DSS_DSS_CONTEXT_OFFSET, |
| 1360 | }, | 1361 | }, |
| 1361 | }, | 1362 | }, |
| 1362 | .opt_clks = dss_dispc_opt_clks, | ||
| 1363 | .opt_clks_cnt = ARRAY_SIZE(dss_dispc_opt_clks), | ||
| 1364 | .slaves = omap44xx_dss_dispc_slaves, | 1363 | .slaves = omap44xx_dss_dispc_slaves, |
| 1365 | .slaves_cnt = ARRAY_SIZE(omap44xx_dss_dispc_slaves), | 1364 | .slaves_cnt = ARRAY_SIZE(omap44xx_dss_dispc_slaves), |
| 1365 | .dev_attr = &omap44xx_dss_dispc_dev_attr | ||
| 1366 | }; | 1366 | }; |
| 1367 | 1367 | ||
| 1368 | /* | 1368 | /* |
| @@ -1624,7 +1624,7 @@ static struct omap_hwmod omap44xx_dss_hdmi_hwmod = { | |||
| 1624 | .clkdm_name = "l3_dss_clkdm", | 1624 | .clkdm_name = "l3_dss_clkdm", |
| 1625 | .mpu_irqs = omap44xx_dss_hdmi_irqs, | 1625 | .mpu_irqs = omap44xx_dss_hdmi_irqs, |
| 1626 | .sdma_reqs = omap44xx_dss_hdmi_sdma_reqs, | 1626 | .sdma_reqs = omap44xx_dss_hdmi_sdma_reqs, |
| 1627 | .main_clk = "dss_dss_clk", | 1627 | .main_clk = "dss_48mhz_clk", |
| 1628 | .prcm = { | 1628 | .prcm = { |
| 1629 | .omap4 = { | 1629 | .omap4 = { |
| 1630 | .clkctrl_offs = OMAP4_CM_DSS_DSS_CLKCTRL_OFFSET, | 1630 | .clkctrl_offs = OMAP4_CM_DSS_DSS_CLKCTRL_OFFSET, |
| @@ -1785,7 +1785,7 @@ static struct omap_hwmod omap44xx_dss_venc_hwmod = { | |||
| 1785 | .name = "dss_venc", | 1785 | .name = "dss_venc", |
| 1786 | .class = &omap44xx_venc_hwmod_class, | 1786 | .class = &omap44xx_venc_hwmod_class, |
| 1787 | .clkdm_name = "l3_dss_clkdm", | 1787 | .clkdm_name = "l3_dss_clkdm", |
| 1788 | .main_clk = "dss_dss_clk", | 1788 | .main_clk = "dss_tv_clk", |
| 1789 | .prcm = { | 1789 | .prcm = { |
| 1790 | .omap4 = { | 1790 | .omap4 = { |
| 1791 | .clkctrl_offs = OMAP4_CM_DSS_DSS_CLKCTRL_OFFSET, | 1791 | .clkctrl_offs = OMAP4_CM_DSS_DSS_CLKCTRL_OFFSET, |
diff --git a/arch/arm/mach-omap2/omap_hwmod_common_data.c b/arch/arm/mach-omap2/omap_hwmod_common_data.c index de832ebc93a9..51e5418899fb 100644 --- a/arch/arm/mach-omap2/omap_hwmod_common_data.c +++ b/arch/arm/mach-omap2/omap_hwmod_common_data.c | |||
| @@ -49,3 +49,7 @@ struct omap_hwmod_sysc_fields omap_hwmod_sysc_type2 = { | |||
| 49 | .srst_shift = SYSC_TYPE2_SOFTRESET_SHIFT, | 49 | .srst_shift = SYSC_TYPE2_SOFTRESET_SHIFT, |
| 50 | }; | 50 | }; |
| 51 | 51 | ||
| 52 | struct omap_dss_dispc_dev_attr omap2_3_dss_dispc_dev_attr = { | ||
| 53 | .manager_count = 2, | ||
| 54 | .has_framedonetv_irq = 0 | ||
| 55 | }; | ||
diff --git a/arch/arm/mach-omap2/omap_hwmod_common_data.h b/arch/arm/mach-omap2/omap_hwmod_common_data.h index 39a7c37f4587..ad5d8f04c0b8 100644 --- a/arch/arm/mach-omap2/omap_hwmod_common_data.h +++ b/arch/arm/mach-omap2/omap_hwmod_common_data.h | |||
| @@ -16,6 +16,8 @@ | |||
| 16 | 16 | ||
| 17 | #include <plat/omap_hwmod.h> | 17 | #include <plat/omap_hwmod.h> |
| 18 | 18 | ||
| 19 | #include "display.h" | ||
| 20 | |||
| 19 | /* Common address space across OMAP2xxx */ | 21 | /* Common address space across OMAP2xxx */ |
| 20 | extern struct omap_hwmod_addr_space omap2xxx_uart1_addr_space[]; | 22 | extern struct omap_hwmod_addr_space omap2xxx_uart1_addr_space[]; |
| 21 | extern struct omap_hwmod_addr_space omap2xxx_uart2_addr_space[]; | 23 | extern struct omap_hwmod_addr_space omap2xxx_uart2_addr_space[]; |
| @@ -111,4 +113,6 @@ extern struct omap_hwmod_class omap2xxx_dma_hwmod_class; | |||
| 111 | extern struct omap_hwmod_class omap2xxx_mailbox_hwmod_class; | 113 | extern struct omap_hwmod_class omap2xxx_mailbox_hwmod_class; |
| 112 | extern struct omap_hwmod_class omap2xxx_mcspi_class; | 114 | extern struct omap_hwmod_class omap2xxx_mcspi_class; |
| 113 | 115 | ||
| 116 | extern struct omap_dss_dispc_dev_attr omap2_3_dss_dispc_dev_attr; | ||
| 117 | |||
| 114 | #endif | 118 | #endif |
diff --git a/arch/arm/mach-omap2/omap_l3_noc.c b/arch/arm/mach-omap2/omap_l3_noc.c index 6a66aa5e2a5b..d15225ff5c49 100644 --- a/arch/arm/mach-omap2/omap_l3_noc.c +++ b/arch/arm/mach-omap2/omap_l3_noc.c | |||
| @@ -237,7 +237,7 @@ static int __devexit omap4_l3_remove(struct platform_device *pdev) | |||
| 237 | static const struct of_device_id l3_noc_match[] = { | 237 | static const struct of_device_id l3_noc_match[] = { |
| 238 | {.compatible = "ti,omap4-l3-noc", }, | 238 | {.compatible = "ti,omap4-l3-noc", }, |
| 239 | {}, | 239 | {}, |
| 240 | } | 240 | }; |
| 241 | MODULE_DEVICE_TABLE(of, l3_noc_match); | 241 | MODULE_DEVICE_TABLE(of, l3_noc_match); |
| 242 | #else | 242 | #else |
| 243 | #define l3_noc_match NULL | 243 | #define l3_noc_match NULL |
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c index 1e79bdf313e3..00bff46ca48b 100644 --- a/arch/arm/mach-omap2/pm.c +++ b/arch/arm/mach-omap2/pm.c | |||
| @@ -24,6 +24,7 @@ | |||
| 24 | #include "powerdomain.h" | 24 | #include "powerdomain.h" |
| 25 | #include "clockdomain.h" | 25 | #include "clockdomain.h" |
| 26 | #include "pm.h" | 26 | #include "pm.h" |
| 27 | #include "twl-common.h" | ||
| 27 | 28 | ||
| 28 | static struct omap_device_pm_latency *pm_lats; | 29 | static struct omap_device_pm_latency *pm_lats; |
| 29 | 30 | ||
| @@ -226,11 +227,8 @@ postcore_initcall(omap2_common_pm_init); | |||
| 226 | 227 | ||
| 227 | static int __init omap2_common_pm_late_init(void) | 228 | static int __init omap2_common_pm_late_init(void) |
| 228 | { | 229 | { |
| 229 | /* Init the OMAP TWL parameters */ | ||
| 230 | omap3_twl_init(); | ||
| 231 | omap4_twl_init(); | ||
| 232 | |||
| 233 | /* Init the voltage layer */ | 230 | /* Init the voltage layer */ |
| 231 | omap_pmic_late_init(); | ||
| 234 | omap_voltage_late_init(); | 232 | omap_voltage_late_init(); |
| 235 | 233 | ||
| 236 | /* Initialize the voltages */ | 234 | /* Initialize the voltages */ |
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 6a4f6839a7d9..cf246b39bac7 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c | |||
| @@ -139,7 +139,7 @@ static irqreturn_t sr_interrupt(int irq, void *data) | |||
| 139 | sr_write_reg(sr_info, ERRCONFIG_V1, status); | 139 | sr_write_reg(sr_info, ERRCONFIG_V1, status); |
| 140 | } else if (sr_info->ip_type == SR_TYPE_V2) { | 140 | } else if (sr_info->ip_type == SR_TYPE_V2) { |
| 141 | /* Read the status bits */ | 141 | /* Read the status bits */ |
| 142 | sr_read_reg(sr_info, IRQSTATUS); | 142 | status = sr_read_reg(sr_info, IRQSTATUS); |
| 143 | 143 | ||
| 144 | /* Clear them by writing back */ | 144 | /* Clear them by writing back */ |
| 145 | sr_write_reg(sr_info, IRQSTATUS, status); | 145 | sr_write_reg(sr_info, IRQSTATUS, status); |
diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c index 522435772168..10b20c652e5d 100644 --- a/arch/arm/mach-omap2/twl-common.c +++ b/arch/arm/mach-omap2/twl-common.c | |||
| @@ -30,6 +30,7 @@ | |||
| 30 | #include <plat/usb.h> | 30 | #include <plat/usb.h> |
| 31 | 31 | ||
| 32 | #include "twl-common.h" | 32 | #include "twl-common.h" |
| 33 | #include "pm.h" | ||
| 33 | 34 | ||
| 34 | static struct i2c_board_info __initdata pmic_i2c_board_info = { | 35 | static struct i2c_board_info __initdata pmic_i2c_board_info = { |
| 35 | .addr = 0x48, | 36 | .addr = 0x48, |
| @@ -48,6 +49,16 @@ void __init omap_pmic_init(int bus, u32 clkrate, | |||
| 48 | omap_register_i2c_bus(bus, clkrate, &pmic_i2c_board_info, 1); | 49 | omap_register_i2c_bus(bus, clkrate, &pmic_i2c_board_info, 1); |
| 49 | } | 50 | } |
| 50 | 51 | ||
| 52 | void __init omap_pmic_late_init(void) | ||
| 53 | { | ||
| 54 | /* Init the OMAP TWL parameters (if PMIC has been registerd) */ | ||
| 55 | if (!pmic_i2c_board_info.irq) | ||
| 56 | return; | ||
| 57 | |||
| 58 | omap3_twl_init(); | ||
| 59 | omap4_twl_init(); | ||
| 60 | } | ||
| 61 | |||
| 51 | #if defined(CONFIG_ARCH_OMAP3) | 62 | #if defined(CONFIG_ARCH_OMAP3) |
| 52 | static struct twl4030_usb_data omap3_usb_pdata = { | 63 | static struct twl4030_usb_data omap3_usb_pdata = { |
| 53 | .usb_mode = T2_USB_MODE_ULPI, | 64 | .usb_mode = T2_USB_MODE_ULPI, |
diff --git a/arch/arm/mach-omap2/twl-common.h b/arch/arm/mach-omap2/twl-common.h index 5e83a5bd37fb..275dde8cb27a 100644 --- a/arch/arm/mach-omap2/twl-common.h +++ b/arch/arm/mach-omap2/twl-common.h | |||
| @@ -1,6 +1,8 @@ | |||
| 1 | #ifndef __OMAP_PMIC_COMMON__ | 1 | #ifndef __OMAP_PMIC_COMMON__ |
| 2 | #define __OMAP_PMIC_COMMON__ | 2 | #define __OMAP_PMIC_COMMON__ |
| 3 | 3 | ||
| 4 | #include <plat/irqs.h> | ||
| 5 | |||
| 4 | #define TWL_COMMON_PDATA_USB (1 << 0) | 6 | #define TWL_COMMON_PDATA_USB (1 << 0) |
| 5 | #define TWL_COMMON_PDATA_BCI (1 << 1) | 7 | #define TWL_COMMON_PDATA_BCI (1 << 1) |
| 6 | #define TWL_COMMON_PDATA_MADC (1 << 2) | 8 | #define TWL_COMMON_PDATA_MADC (1 << 2) |
| @@ -30,6 +32,7 @@ struct twl4030_platform_data; | |||
| 30 | 32 | ||
| 31 | void omap_pmic_init(int bus, u32 clkrate, const char *pmic_type, int pmic_irq, | 33 | void omap_pmic_init(int bus, u32 clkrate, const char *pmic_type, int pmic_irq, |
| 32 | struct twl4030_platform_data *pmic_data); | 34 | struct twl4030_platform_data *pmic_data); |
| 35 | void omap_pmic_late_init(void); | ||
| 33 | 36 | ||
| 34 | static inline void omap2_pmic_init(const char *pmic_type, | 37 | static inline void omap2_pmic_init(const char *pmic_type, |
| 35 | struct twl4030_platform_data *pmic_data) | 38 | struct twl4030_platform_data *pmic_data) |
diff --git a/arch/arm/mach-prima2/pm.c b/arch/arm/mach-prima2/pm.c index cb53160f6c5d..26ebb57719df 100644 --- a/arch/arm/mach-prima2/pm.c +++ b/arch/arm/mach-prima2/pm.c | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | #include <linux/kernel.h> | 9 | #include <linux/kernel.h> |
| 10 | #include <linux/suspend.h> | 10 | #include <linux/suspend.h> |
| 11 | #include <linux/slab.h> | 11 | #include <linux/slab.h> |
| 12 | #include <linux/module.h> | ||
| 12 | #include <linux/of.h> | 13 | #include <linux/of.h> |
| 13 | #include <linux/of_address.h> | 14 | #include <linux/of_address.h> |
| 14 | #include <linux/of_device.h> | 15 | #include <linux/of_device.h> |
diff --git a/arch/arm/mach-prima2/prima2.c b/arch/arm/mach-prima2/prima2.c index ef555c041962..a12b689a8702 100644 --- a/arch/arm/mach-prima2/prima2.c +++ b/arch/arm/mach-prima2/prima2.c | |||
| @@ -8,6 +8,7 @@ | |||
| 8 | 8 | ||
| 9 | #include <linux/init.h> | 9 | #include <linux/init.h> |
| 10 | #include <linux/kernel.h> | 10 | #include <linux/kernel.h> |
| 11 | #include <asm/sizes.h> | ||
| 11 | #include <asm/mach-types.h> | 12 | #include <asm/mach-types.h> |
| 12 | #include <asm/mach/arch.h> | 13 | #include <asm/mach/arch.h> |
| 13 | #include <linux/of.h> | 14 | #include <linux/of.h> |
diff --git a/arch/arm/mach-pxa/balloon3.c b/arch/arm/mach-pxa/balloon3.c index fc0b8544e174..4b81f59a4cba 100644 --- a/arch/arm/mach-pxa/balloon3.c +++ b/arch/arm/mach-pxa/balloon3.c | |||
| @@ -307,7 +307,7 @@ static inline void balloon3_mmc_init(void) {} | |||
| 307 | /****************************************************************************** | 307 | /****************************************************************************** |
| 308 | * USB Gadget | 308 | * USB Gadget |
| 309 | ******************************************************************************/ | 309 | ******************************************************************************/ |
| 310 | #if defined(CONFIG_USB_GADGET_PXA27X)||defined(CONFIG_USB_GADGET_PXA27X_MODULE) | 310 | #if defined(CONFIG_USB_PXA27X)||defined(CONFIG_USB_PXA27X_MODULE) |
| 311 | static void balloon3_udc_command(int cmd) | 311 | static void balloon3_udc_command(int cmd) |
| 312 | { | 312 | { |
| 313 | if (cmd == PXA2XX_UDC_CMD_CONNECT) | 313 | if (cmd == PXA2XX_UDC_CMD_CONNECT) |
diff --git a/arch/arm/mach-pxa/colibri-pxa320.c b/arch/arm/mach-pxa/colibri-pxa320.c index 692e1ffc5586..d23b92b80488 100644 --- a/arch/arm/mach-pxa/colibri-pxa320.c +++ b/arch/arm/mach-pxa/colibri-pxa320.c | |||
| @@ -146,7 +146,7 @@ static void __init colibri_pxa320_init_eth(void) | |||
| 146 | static inline void __init colibri_pxa320_init_eth(void) {} | 146 | static inline void __init colibri_pxa320_init_eth(void) {} |
| 147 | #endif /* CONFIG_AX88796 */ | 147 | #endif /* CONFIG_AX88796 */ |
| 148 | 148 | ||
| 149 | #if defined(CONFIG_USB_GADGET_PXA27X)||defined(CONFIG_USB_GADGET_PXA27X_MODULE) | 149 | #if defined(CONFIG_USB_PXA27X)||defined(CONFIG_USB_PXA27X_MODULE) |
| 150 | static struct gpio_vbus_mach_info colibri_pxa320_gpio_vbus_info = { | 150 | static struct gpio_vbus_mach_info colibri_pxa320_gpio_vbus_info = { |
| 151 | .gpio_vbus = mfp_to_gpio(MFP_PIN_GPIO96), | 151 | .gpio_vbus = mfp_to_gpio(MFP_PIN_GPIO96), |
| 152 | .gpio_pullup = -1, | 152 | .gpio_pullup = -1, |
diff --git a/arch/arm/mach-pxa/gumstix.c b/arch/arm/mach-pxa/gumstix.c index 9c8208ca0415..ffdd70dad327 100644 --- a/arch/arm/mach-pxa/gumstix.c +++ b/arch/arm/mach-pxa/gumstix.c | |||
| @@ -106,7 +106,7 @@ static void __init gumstix_mmc_init(void) | |||
| 106 | } | 106 | } |
| 107 | #endif | 107 | #endif |
| 108 | 108 | ||
| 109 | #ifdef CONFIG_USB_GADGET_PXA25X | 109 | #ifdef CONFIG_USB_PXA25X |
| 110 | static struct gpio_vbus_mach_info gumstix_udc_info = { | 110 | static struct gpio_vbus_mach_info gumstix_udc_info = { |
| 111 | .gpio_vbus = GPIO_GUMSTIX_USB_GPIOn, | 111 | .gpio_vbus = GPIO_GUMSTIX_USB_GPIOn, |
| 112 | .gpio_pullup = GPIO_GUMSTIX_USB_GPIOx, | 112 | .gpio_pullup = GPIO_GUMSTIX_USB_GPIOx, |
diff --git a/arch/arm/mach-pxa/include/mach/palm27x.h b/arch/arm/mach-pxa/include/mach/palm27x.h index f80bbe246afe..d4eac3d6ffb5 100644 --- a/arch/arm/mach-pxa/include/mach/palm27x.h +++ b/arch/arm/mach-pxa/include/mach/palm27x.h | |||
| @@ -37,8 +37,8 @@ extern void __init palm27x_lcd_init(int power, | |||
| 37 | #define palm27x_lcd_init(power, mode) do {} while (0) | 37 | #define palm27x_lcd_init(power, mode) do {} while (0) |
| 38 | #endif | 38 | #endif |
| 39 | 39 | ||
| 40 | #if defined(CONFIG_USB_GADGET_PXA27X) || \ | 40 | #if defined(CONFIG_USB_PXA27X) || \ |
| 41 | defined(CONFIG_USB_GADGET_PXA27X_MODULE) | 41 | defined(CONFIG_USB_PXA27X_MODULE) |
| 42 | extern void __init palm27x_udc_init(int vbus, int pullup, | 42 | extern void __init palm27x_udc_init(int vbus, int pullup, |
| 43 | int vbus_inverted); | 43 | int vbus_inverted); |
| 44 | #else | 44 | #else |
diff --git a/arch/arm/mach-pxa/palm27x.c b/arch/arm/mach-pxa/palm27x.c index 325c245c0a0d..fbc10d7b95d1 100644 --- a/arch/arm/mach-pxa/palm27x.c +++ b/arch/arm/mach-pxa/palm27x.c | |||
| @@ -164,8 +164,8 @@ void __init palm27x_lcd_init(int power, struct pxafb_mode_info *mode) | |||
| 164 | /****************************************************************************** | 164 | /****************************************************************************** |
| 165 | * USB Gadget | 165 | * USB Gadget |
| 166 | ******************************************************************************/ | 166 | ******************************************************************************/ |
| 167 | #if defined(CONFIG_USB_GADGET_PXA27X) || \ | 167 | #if defined(CONFIG_USB_PXA27X) || \ |
| 168 | defined(CONFIG_USB_GADGET_PXA27X_MODULE) | 168 | defined(CONFIG_USB_PXA27X_MODULE) |
| 169 | static struct gpio_vbus_mach_info palm27x_udc_info = { | 169 | static struct gpio_vbus_mach_info palm27x_udc_info = { |
| 170 | .gpio_vbus_inverted = 1, | 170 | .gpio_vbus_inverted = 1, |
| 171 | }; | 171 | }; |
diff --git a/arch/arm/mach-pxa/palmtc.c b/arch/arm/mach-pxa/palmtc.c index 6ec7caefb37c..2c24c67fd92b 100644 --- a/arch/arm/mach-pxa/palmtc.c +++ b/arch/arm/mach-pxa/palmtc.c | |||
| @@ -338,7 +338,7 @@ static inline void palmtc_mkp_init(void) {} | |||
| 338 | /****************************************************************************** | 338 | /****************************************************************************** |
| 339 | * UDC | 339 | * UDC |
| 340 | ******************************************************************************/ | 340 | ******************************************************************************/ |
| 341 | #if defined(CONFIG_USB_GADGET_PXA25X)||defined(CONFIG_USB_GADGET_PXA25X_MODULE) | 341 | #if defined(CONFIG_USB_PXA25X)||defined(CONFIG_USB_PXA25X_MODULE) |
| 342 | static struct gpio_vbus_mach_info palmtc_udc_info = { | 342 | static struct gpio_vbus_mach_info palmtc_udc_info = { |
| 343 | .gpio_vbus = GPIO_NR_PALMTC_USB_DETECT_N, | 343 | .gpio_vbus = GPIO_NR_PALMTC_USB_DETECT_N, |
| 344 | .gpio_vbus_inverted = 1, | 344 | .gpio_vbus_inverted = 1, |
diff --git a/arch/arm/mach-pxa/vpac270.c b/arch/arm/mach-pxa/vpac270.c index a7539a6ed1ff..ca0c6615028c 100644 --- a/arch/arm/mach-pxa/vpac270.c +++ b/arch/arm/mach-pxa/vpac270.c | |||
| @@ -343,7 +343,7 @@ static inline void vpac270_uhc_init(void) {} | |||
| 343 | /****************************************************************************** | 343 | /****************************************************************************** |
| 344 | * USB Gadget | 344 | * USB Gadget |
| 345 | ******************************************************************************/ | 345 | ******************************************************************************/ |
| 346 | #if defined(CONFIG_USB_GADGET_PXA27X)||defined(CONFIG_USB_GADGET_PXA27X_MODULE) | 346 | #if defined(CONFIG_USB_PXA27X)||defined(CONFIG_USB_PXA27X_MODULE) |
| 347 | static struct gpio_vbus_mach_info vpac270_gpio_vbus_info = { | 347 | static struct gpio_vbus_mach_info vpac270_gpio_vbus_info = { |
| 348 | .gpio_vbus = GPIO41_VPAC270_UDC_DETECT, | 348 | .gpio_vbus = GPIO41_VPAC270_UDC_DETECT, |
| 349 | .gpio_pullup = -1, | 349 | .gpio_pullup = -1, |
diff --git a/arch/arm/mach-s3c64xx/dev-spi.c b/arch/arm/mach-s3c64xx/dev-spi.c index 5e6b42089eb4..3341fd118723 100644 --- a/arch/arm/mach-s3c64xx/dev-spi.c +++ b/arch/arm/mach-s3c64xx/dev-spi.c | |||
| @@ -10,6 +10,7 @@ | |||
| 10 | 10 | ||
| 11 | #include <linux/kernel.h> | 11 | #include <linux/kernel.h> |
| 12 | #include <linux/string.h> | 12 | #include <linux/string.h> |
| 13 | #include <linux/export.h> | ||
| 13 | #include <linux/platform_device.h> | 14 | #include <linux/platform_device.h> |
| 14 | #include <linux/dma-mapping.h> | 15 | #include <linux/dma-mapping.h> |
| 15 | #include <linux/gpio.h> | 16 | #include <linux/gpio.h> |
diff --git a/arch/arm/mach-s3c64xx/mach-crag6410-module.c b/arch/arm/mach-s3c64xx/mach-crag6410-module.c index 66668565ee75..f208154b1382 100644 --- a/arch/arm/mach-s3c64xx/mach-crag6410-module.c +++ b/arch/arm/mach-s3c64xx/mach-crag6410-module.c | |||
| @@ -8,7 +8,7 @@ | |||
| 8 | * published by the Free Software Foundation. | 8 | * published by the Free Software Foundation. |
| 9 | */ | 9 | */ |
| 10 | 10 | ||
| 11 | #include <linux/module.h> | 11 | #include <linux/export.h> |
| 12 | #include <linux/interrupt.h> | 12 | #include <linux/interrupt.h> |
| 13 | #include <linux/i2c.h> | 13 | #include <linux/i2c.h> |
| 14 | 14 | ||
diff --git a/arch/arm/mach-s3c64xx/s3c6400.c b/arch/arm/mach-s3c64xx/s3c6400.c index 7a3bc32df425..51c00f2453c6 100644 --- a/arch/arm/mach-s3c64xx/s3c6400.c +++ b/arch/arm/mach-s3c64xx/s3c6400.c | |||
| @@ -70,7 +70,7 @@ void __init s3c6400_init_irq(void) | |||
| 70 | s3c64xx_init_irq(~0 & ~(0xf << 5), ~0); | 70 | s3c64xx_init_irq(~0 & ~(0xf << 5), ~0); |
| 71 | } | 71 | } |
| 72 | 72 | ||
| 73 | struct sysdev_class s3c6400_sysclass = { | 73 | static struct sysdev_class s3c6400_sysclass = { |
| 74 | .name = "s3c6400-core", | 74 | .name = "s3c6400-core", |
| 75 | }; | 75 | }; |
| 76 | 76 | ||
diff --git a/arch/arm/mach-s3c64xx/setup-fb-24bpp.c b/arch/arm/mach-s3c64xx/setup-fb-24bpp.c index 83d2afb79e9f..2cf80026c58d 100644 --- a/arch/arm/mach-s3c64xx/setup-fb-24bpp.c +++ b/arch/arm/mach-s3c64xx/setup-fb-24bpp.c | |||
| @@ -20,7 +20,7 @@ | |||
| 20 | #include <plat/fb.h> | 20 | #include <plat/fb.h> |
| 21 | #include <plat/gpio-cfg.h> | 21 | #include <plat/gpio-cfg.h> |
| 22 | 22 | ||
| 23 | extern void s3c64xx_fb_gpio_setup_24bpp(void) | 23 | void s3c64xx_fb_gpio_setup_24bpp(void) |
| 24 | { | 24 | { |
| 25 | s3c_gpio_cfgrange_nopull(S3C64XX_GPI(0), 16, S3C_GPIO_SFN(2)); | 25 | s3c_gpio_cfgrange_nopull(S3C64XX_GPI(0), 16, S3C_GPIO_SFN(2)); |
| 26 | s3c_gpio_cfgrange_nopull(S3C64XX_GPJ(0), 12, S3C_GPIO_SFN(2)); | 26 | s3c_gpio_cfgrange_nopull(S3C64XX_GPJ(0), 12, S3C_GPIO_SFN(2)); |
diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c index a9106c392398..8662ef6e5681 100644 --- a/arch/arm/mach-s5pv210/mach-smdkv210.c +++ b/arch/arm/mach-s5pv210/mach-smdkv210.c | |||
| @@ -273,6 +273,7 @@ static struct samsung_bl_gpio_info smdkv210_bl_gpio_info = { | |||
| 273 | 273 | ||
| 274 | static struct platform_pwm_backlight_data smdkv210_bl_data = { | 274 | static struct platform_pwm_backlight_data smdkv210_bl_data = { |
| 275 | .pwm_id = 3, | 275 | .pwm_id = 3, |
| 276 | .pwm_period_ns = 1000, | ||
| 276 | }; | 277 | }; |
| 277 | 278 | ||
| 278 | static void __init smdkv210_map_io(void) | 279 | static void __init smdkv210_map_io(void) |
diff --git a/arch/arm/mach-sa1100/Makefile.boot b/arch/arm/mach-sa1100/Makefile.boot index 5a616f6e5612..f7951aa04562 100644 --- a/arch/arm/mach-sa1100/Makefile.boot +++ b/arch/arm/mach-sa1100/Makefile.boot | |||
| @@ -1,5 +1,5 @@ | |||
| 1 | ifeq ($(CONFIG_ARCH_SA1100),y) | 1 | ifeq ($(CONFIG_SA1111),y) |
| 2 | zreladdr-$(CONFIG_SA1111) += 0xc0208000 | 2 | zreladdr-y += 0xc0208000 |
| 3 | else | 3 | else |
| 4 | zreladdr-y += 0xc0008000 | 4 | zreladdr-y += 0xc0008000 |
| 5 | endif | 5 | endif |
diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c index 8ac9e9f84790..b1e192ba8c24 100644 --- a/arch/arm/mm/cache-l2x0.c +++ b/arch/arm/mm/cache-l2x0.c | |||
| @@ -61,7 +61,7 @@ static inline void cache_sync(void) | |||
| 61 | { | 61 | { |
| 62 | void __iomem *base = l2x0_base; | 62 | void __iomem *base = l2x0_base; |
| 63 | 63 | ||
| 64 | #ifdef CONFIG_ARM_ERRATA_753970 | 64 | #ifdef CONFIG_PL310_ERRATA_753970 |
| 65 | /* write to an unmmapped register */ | 65 | /* write to an unmmapped register */ |
| 66 | writel_relaxed(0, base + L2X0_DUMMY_REG); | 66 | writel_relaxed(0, base + L2X0_DUMMY_REG); |
| 67 | #else | 67 | #else |
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c index e4e7f6cba1ab..1aa664a1999f 100644 --- a/arch/arm/mm/dma-mapping.c +++ b/arch/arm/mm/dma-mapping.c | |||
| @@ -168,7 +168,7 @@ static int __init consistent_init(void) | |||
| 168 | pte_t *pte; | 168 | pte_t *pte; |
| 169 | int i = 0; | 169 | int i = 0; |
| 170 | unsigned long base = consistent_base; | 170 | unsigned long base = consistent_base; |
| 171 | unsigned long num_ptes = (CONSISTENT_END - base) >> PGDIR_SHIFT; | 171 | unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT; |
| 172 | 172 | ||
| 173 | consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL); | 173 | consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL); |
| 174 | if (!consistent_pte) { | 174 | if (!consistent_pte) { |
| @@ -332,6 +332,15 @@ __dma_alloc(struct device *dev, size_t size, dma_addr_t *handle, gfp_t gfp, | |||
| 332 | struct page *page; | 332 | struct page *page; |
| 333 | void *addr; | 333 | void *addr; |
| 334 | 334 | ||
| 335 | /* | ||
| 336 | * Following is a work-around (a.k.a. hack) to prevent pages | ||
| 337 | * with __GFP_COMP being passed to split_page() which cannot | ||
| 338 | * handle them. The real problem is that this flag probably | ||
| 339 | * should be 0 on ARM as it is not supported on this | ||
| 340 | * platform; see CONFIG_HUGETLBFS. | ||
| 341 | */ | ||
| 342 | gfp &= ~(__GFP_COMP); | ||
| 343 | |||
| 335 | *handle = ~0; | 344 | *handle = ~0; |
| 336 | size = PAGE_ALIGN(size); | 345 | size = PAGE_ALIGN(size); |
| 337 | 346 | ||
diff --git a/arch/arm/mm/mmap.c b/arch/arm/mm/mmap.c index 74be05f3e03a..44b628e4d6ea 100644 --- a/arch/arm/mm/mmap.c +++ b/arch/arm/mm/mmap.c | |||
| @@ -9,8 +9,7 @@ | |||
| 9 | #include <linux/io.h> | 9 | #include <linux/io.h> |
| 10 | #include <linux/personality.h> | 10 | #include <linux/personality.h> |
| 11 | #include <linux/random.h> | 11 | #include <linux/random.h> |
| 12 | #include <asm/cputype.h> | 12 | #include <asm/cachetype.h> |
| 13 | #include <asm/system.h> | ||
| 14 | 13 | ||
| 15 | #define COLOUR_ALIGN(addr,pgoff) \ | 14 | #define COLOUR_ALIGN(addr,pgoff) \ |
| 16 | ((((addr)+SHMLBA-1)&~(SHMLBA-1)) + \ | 15 | ((((addr)+SHMLBA-1)&~(SHMLBA-1)) + \ |
| @@ -32,25 +31,15 @@ arch_get_unmapped_area(struct file *filp, unsigned long addr, | |||
| 32 | struct mm_struct *mm = current->mm; | 31 | struct mm_struct *mm = current->mm; |
| 33 | struct vm_area_struct *vma; | 32 | struct vm_area_struct *vma; |
| 34 | unsigned long start_addr; | 33 | unsigned long start_addr; |
| 35 | #if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_V6K) | 34 | int do_align = 0; |
| 36 | unsigned int cache_type; | 35 | int aliasing = cache_is_vipt_aliasing(); |
| 37 | int do_align = 0, aliasing = 0; | ||
| 38 | 36 | ||
| 39 | /* | 37 | /* |
| 40 | * We only need to do colour alignment if either the I or D | 38 | * We only need to do colour alignment if either the I or D |
| 41 | * caches alias. This is indicated by bits 9 and 21 of the | 39 | * caches alias. |
| 42 | * cache type register. | ||
| 43 | */ | 40 | */ |
| 44 | cache_type = read_cpuid_cachetype(); | 41 | if (aliasing) |
| 45 | if (cache_type != read_cpuid_id()) { | 42 | do_align = filp || (flags & MAP_SHARED); |
| 46 | aliasing = (cache_type | cache_type >> 12) & (1 << 11); | ||
| 47 | if (aliasing) | ||
| 48 | do_align = filp || flags & MAP_SHARED; | ||
| 49 | } | ||
| 50 | #else | ||
| 51 | #define do_align 0 | ||
| 52 | #define aliasing 0 | ||
| 53 | #endif | ||
| 54 | 43 | ||
| 55 | /* | 44 | /* |
| 56 | * We enforce the MAP_FIXED case. | 45 | * We enforce the MAP_FIXED case. |
diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c index 74aac96cda20..adbff706ef6f 100644 --- a/arch/arm/plat-mxc/cpufreq.c +++ b/arch/arm/plat-mxc/cpufreq.c | |||
| @@ -17,6 +17,7 @@ | |||
| 17 | * the CPU clock speed on the fly. | 17 | * the CPU clock speed on the fly. |
| 18 | */ | 18 | */ |
| 19 | 19 | ||
| 20 | #include <linux/module.h> | ||
| 20 | #include <linux/cpufreq.h> | 21 | #include <linux/cpufreq.h> |
| 21 | #include <linux/clk.h> | 22 | #include <linux/clk.h> |
| 22 | #include <linux/err.h> | 23 | #include <linux/err.h> |
diff --git a/arch/arm/plat-mxc/include/mach/common.h b/arch/arm/plat-mxc/include/mach/common.h index 83b745a5e1b7..c75f254abd85 100644 --- a/arch/arm/plat-mxc/include/mach/common.h +++ b/arch/arm/plat-mxc/include/mach/common.h | |||
| @@ -85,7 +85,6 @@ enum mxc_cpu_pwr_mode { | |||
| 85 | }; | 85 | }; |
| 86 | 86 | ||
| 87 | extern void mx5_cpu_lp_set(enum mxc_cpu_pwr_mode mode); | 87 | extern void mx5_cpu_lp_set(enum mxc_cpu_pwr_mode mode); |
| 88 | extern void (*imx_idle)(void); | ||
| 89 | extern void imx_print_silicon_rev(const char *cpu, int srev); | 88 | extern void imx_print_silicon_rev(const char *cpu, int srev); |
| 90 | 89 | ||
| 91 | void avic_handle_irq(struct pt_regs *); | 90 | void avic_handle_irq(struct pt_regs *); |
| @@ -133,4 +132,5 @@ extern void imx53_qsb_common_init(void); | |||
| 133 | extern void imx53_smd_common_init(void); | 132 | extern void imx53_smd_common_init(void); |
| 134 | extern int imx6q_set_lpm(enum mxc_cpu_pwr_mode mode); | 133 | extern int imx6q_set_lpm(enum mxc_cpu_pwr_mode mode); |
| 135 | extern void imx6q_pm_init(void); | 134 | extern void imx6q_pm_init(void); |
| 135 | extern void imx6q_clock_map_io(void); | ||
| 136 | #endif | 136 | #endif |
diff --git a/arch/arm/plat-mxc/include/mach/mxc.h b/arch/arm/plat-mxc/include/mach/mxc.h index 00a78193c681..a4d36d601d55 100644 --- a/arch/arm/plat-mxc/include/mach/mxc.h +++ b/arch/arm/plat-mxc/include/mach/mxc.h | |||
| @@ -50,20 +50,6 @@ | |||
| 50 | #define IMX_CHIP_REVISION_3_3 0x33 | 50 | #define IMX_CHIP_REVISION_3_3 0x33 |
| 51 | #define IMX_CHIP_REVISION_UNKNOWN 0xff | 51 | #define IMX_CHIP_REVISION_UNKNOWN 0xff |
| 52 | 52 | ||
| 53 | #define IMX_CHIP_REVISION_1_0_STRING "1.0" | ||
| 54 | #define IMX_CHIP_REVISION_1_1_STRING "1.1" | ||
| 55 | #define IMX_CHIP_REVISION_1_2_STRING "1.2" | ||
| 56 | #define IMX_CHIP_REVISION_1_3_STRING "1.3" | ||
| 57 | #define IMX_CHIP_REVISION_2_0_STRING "2.0" | ||
| 58 | #define IMX_CHIP_REVISION_2_1_STRING "2.1" | ||
| 59 | #define IMX_CHIP_REVISION_2_2_STRING "2.2" | ||
| 60 | #define IMX_CHIP_REVISION_2_3_STRING "2.3" | ||
| 61 | #define IMX_CHIP_REVISION_3_0_STRING "3.0" | ||
| 62 | #define IMX_CHIP_REVISION_3_1_STRING "3.1" | ||
| 63 | #define IMX_CHIP_REVISION_3_2_STRING "3.2" | ||
| 64 | #define IMX_CHIP_REVISION_3_3_STRING "3.3" | ||
| 65 | #define IMX_CHIP_REVISION_UNKNOWN_STRING "unknown" | ||
| 66 | |||
| 67 | #ifndef __ASSEMBLY__ | 53 | #ifndef __ASSEMBLY__ |
| 68 | extern unsigned int __mxc_cpu_type; | 54 | extern unsigned int __mxc_cpu_type; |
| 69 | #endif | 55 | #endif |
diff --git a/arch/arm/plat-mxc/include/mach/system.h b/arch/arm/plat-mxc/include/mach/system.h index cf88b3593fba..b9895d250167 100644 --- a/arch/arm/plat-mxc/include/mach/system.h +++ b/arch/arm/plat-mxc/include/mach/system.h | |||
| @@ -17,14 +17,9 @@ | |||
| 17 | #ifndef __ASM_ARCH_MXC_SYSTEM_H__ | 17 | #ifndef __ASM_ARCH_MXC_SYSTEM_H__ |
| 18 | #define __ASM_ARCH_MXC_SYSTEM_H__ | 18 | #define __ASM_ARCH_MXC_SYSTEM_H__ |
| 19 | 19 | ||
| 20 | extern void (*imx_idle)(void); | ||
| 21 | |||
| 22 | static inline void arch_idle(void) | 20 | static inline void arch_idle(void) |
| 23 | { | 21 | { |
| 24 | if (imx_idle != NULL) | 22 | cpu_do_idle(); |
| 25 | (imx_idle)(); | ||
| 26 | else | ||
| 27 | cpu_do_idle(); | ||
| 28 | } | 23 | } |
| 29 | 24 | ||
| 30 | void arch_reset(char mode, const char *cmd); | 25 | void arch_reset(char mode, const char *cmd); |
diff --git a/arch/arm/plat-mxc/pwm.c b/arch/arm/plat-mxc/pwm.c index 42d74ea59084..845de59f07ed 100644 --- a/arch/arm/plat-mxc/pwm.c +++ b/arch/arm/plat-mxc/pwm.c | |||
| @@ -32,6 +32,9 @@ | |||
| 32 | #define MX3_PWMSAR 0x0C /* PWM Sample Register */ | 32 | #define MX3_PWMSAR 0x0C /* PWM Sample Register */ |
| 33 | #define MX3_PWMPR 0x10 /* PWM Period Register */ | 33 | #define MX3_PWMPR 0x10 /* PWM Period Register */ |
| 34 | #define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) | 34 | #define MX3_PWMCR_PRESCALER(x) (((x - 1) & 0xFFF) << 4) |
| 35 | #define MX3_PWMCR_DOZEEN (1 << 24) | ||
| 36 | #define MX3_PWMCR_WAITEN (1 << 23) | ||
| 37 | #define MX3_PWMCR_DBGEN (1 << 22) | ||
| 35 | #define MX3_PWMCR_CLKSRC_IPG_HIGH (2 << 16) | 38 | #define MX3_PWMCR_CLKSRC_IPG_HIGH (2 << 16) |
| 36 | #define MX3_PWMCR_CLKSRC_IPG (1 << 16) | 39 | #define MX3_PWMCR_CLKSRC_IPG (1 << 16) |
| 37 | #define MX3_PWMCR_EN (1 << 0) | 40 | #define MX3_PWMCR_EN (1 << 0) |
| @@ -77,7 +80,9 @@ int pwm_config(struct pwm_device *pwm, int duty_ns, int period_ns) | |||
| 77 | writel(duty_cycles, pwm->mmio_base + MX3_PWMSAR); | 80 | writel(duty_cycles, pwm->mmio_base + MX3_PWMSAR); |
| 78 | writel(period_cycles, pwm->mmio_base + MX3_PWMPR); | 81 | writel(period_cycles, pwm->mmio_base + MX3_PWMPR); |
| 79 | 82 | ||
| 80 | cr = MX3_PWMCR_PRESCALER(prescale) | MX3_PWMCR_EN; | 83 | cr = MX3_PWMCR_PRESCALER(prescale) | |
| 84 | MX3_PWMCR_DOZEEN | MX3_PWMCR_WAITEN | | ||
| 85 | MX3_PWMCR_DBGEN | MX3_PWMCR_EN; | ||
| 81 | 86 | ||
| 82 | if (cpu_is_mx25()) | 87 | if (cpu_is_mx25()) |
| 83 | cr |= MX3_PWMCR_CLKSRC_IPG; | 88 | cr |= MX3_PWMCR_CLKSRC_IPG; |
diff --git a/arch/arm/plat-mxc/system.c b/arch/arm/plat-mxc/system.c index 9dad8dcc2ea9..d65fb31a55ca 100644 --- a/arch/arm/plat-mxc/system.c +++ b/arch/arm/plat-mxc/system.c | |||
| @@ -21,6 +21,7 @@ | |||
| 21 | #include <linux/io.h> | 21 | #include <linux/io.h> |
| 22 | #include <linux/err.h> | 22 | #include <linux/err.h> |
| 23 | #include <linux/delay.h> | 23 | #include <linux/delay.h> |
| 24 | #include <linux/module.h> | ||
| 24 | 25 | ||
| 25 | #include <mach/hardware.h> | 26 | #include <mach/hardware.h> |
| 26 | #include <mach/common.h> | 27 | #include <mach/common.h> |
| @@ -28,8 +29,8 @@ | |||
| 28 | #include <asm/system.h> | 29 | #include <asm/system.h> |
| 29 | #include <asm/mach-types.h> | 30 | #include <asm/mach-types.h> |
| 30 | 31 | ||
| 31 | void (*imx_idle)(void) = NULL; | ||
| 32 | void __iomem *(*imx_ioremap)(unsigned long, size_t, unsigned int) = NULL; | 32 | void __iomem *(*imx_ioremap)(unsigned long, size_t, unsigned int) = NULL; |
| 33 | EXPORT_SYMBOL_GPL(imx_ioremap); | ||
| 33 | 34 | ||
| 34 | static void __iomem *wdog_base; | 35 | static void __iomem *wdog_base; |
| 35 | 36 | ||
diff --git a/arch/arm/plat-omap/include/plat/clock.h b/arch/arm/plat-omap/include/plat/clock.h index 197ca03c3f7d..eb73ab40e955 100644 --- a/arch/arm/plat-omap/include/plat/clock.h +++ b/arch/arm/plat-omap/include/plat/clock.h | |||
| @@ -165,8 +165,8 @@ struct dpll_data { | |||
| 165 | u8 auto_recal_bit; | 165 | u8 auto_recal_bit; |
| 166 | u8 recal_en_bit; | 166 | u8 recal_en_bit; |
| 167 | u8 recal_st_bit; | 167 | u8 recal_st_bit; |
| 168 | u8 flags; | ||
| 169 | # endif | 168 | # endif |
| 169 | u8 flags; | ||
| 170 | }; | 170 | }; |
| 171 | 171 | ||
| 172 | #endif | 172 | #endif |
diff --git a/arch/arm/plat-omap/include/plat/common.h b/arch/arm/plat-omap/include/plat/common.h index c50df4814f6f..3ff3e36580f2 100644 --- a/arch/arm/plat-omap/include/plat/common.h +++ b/arch/arm/plat-omap/include/plat/common.h | |||
| @@ -30,6 +30,7 @@ | |||
| 30 | #include <linux/delay.h> | 30 | #include <linux/delay.h> |
| 31 | 31 | ||
| 32 | #include <plat/i2c.h> | 32 | #include <plat/i2c.h> |
| 33 | #include <plat/omap_hwmod.h> | ||
| 33 | 34 | ||
| 34 | struct sys_timer; | 35 | struct sys_timer; |
| 35 | 36 | ||
| @@ -55,6 +56,8 @@ void am35xx_init_early(void); | |||
| 55 | void ti816x_init_early(void); | 56 | void ti816x_init_early(void); |
| 56 | void omap4430_init_early(void); | 57 | void omap4430_init_early(void); |
| 57 | 58 | ||
| 59 | extern int omap_dss_reset(struct omap_hwmod *); | ||
| 60 | |||
| 58 | void omap_sram_init(void); | 61 | void omap_sram_init(void); |
| 59 | 62 | ||
| 60 | /* | 63 | /* |
diff --git a/arch/arm/plat-s3c24xx/cpu-freq-debugfs.c b/arch/arm/plat-s3c24xx/cpu-freq-debugfs.c index a9276667c2fb..c7adad0e8de0 100644 --- a/arch/arm/plat-s3c24xx/cpu-freq-debugfs.c +++ b/arch/arm/plat-s3c24xx/cpu-freq-debugfs.c | |||
| @@ -12,7 +12,7 @@ | |||
| 12 | */ | 12 | */ |
| 13 | 13 | ||
| 14 | #include <linux/init.h> | 14 | #include <linux/init.h> |
| 15 | #include <linux/module.h> | 15 | #include <linux/export.h> |
| 16 | #include <linux/interrupt.h> | 16 | #include <linux/interrupt.h> |
| 17 | #include <linux/ioport.h> | 17 | #include <linux/ioport.h> |
| 18 | #include <linux/cpufreq.h> | 18 | #include <linux/cpufreq.h> |
diff --git a/arch/arm/plat-s5p/sysmmu.c b/arch/arm/plat-s5p/sysmmu.c index e1cbc728c775..c8bec9c7655d 100644 --- a/arch/arm/plat-s5p/sysmmu.c +++ b/arch/arm/plat-s5p/sysmmu.c | |||
| @@ -11,6 +11,7 @@ | |||
| 11 | #include <linux/io.h> | 11 | #include <linux/io.h> |
| 12 | #include <linux/interrupt.h> | 12 | #include <linux/interrupt.h> |
| 13 | #include <linux/platform_device.h> | 13 | #include <linux/platform_device.h> |
| 14 | #include <linux/export.h> | ||
| 14 | 15 | ||
| 15 | #include <asm/pgtable.h> | 16 | #include <asm/pgtable.h> |
| 16 | 17 | ||
diff --git a/arch/arm/plat-samsung/dev-backlight.c b/arch/arm/plat-samsung/dev-backlight.c index e657305644cc..a976c023b286 100644 --- a/arch/arm/plat-samsung/dev-backlight.c +++ b/arch/arm/plat-samsung/dev-backlight.c | |||
| @@ -15,7 +15,6 @@ | |||
| 15 | #include <linux/slab.h> | 15 | #include <linux/slab.h> |
| 16 | #include <linux/io.h> | 16 | #include <linux/io.h> |
| 17 | #include <linux/pwm_backlight.h> | 17 | #include <linux/pwm_backlight.h> |
| 18 | #include <linux/slab.h> | ||
| 19 | 18 | ||
| 20 | #include <plat/devs.h> | 19 | #include <plat/devs.h> |
| 21 | #include <plat/gpio-cfg.h> | 20 | #include <plat/gpio-cfg.h> |
diff --git a/arch/arm/plat-samsung/include/plat/gpio-cfg.h b/arch/arm/plat-samsung/include/plat/gpio-cfg.h index d48245bb02b3..df8155b9d4d1 100644 --- a/arch/arm/plat-samsung/include/plat/gpio-cfg.h +++ b/arch/arm/plat-samsung/include/plat/gpio-cfg.h | |||
| @@ -24,6 +24,8 @@ | |||
| 24 | #ifndef __PLAT_GPIO_CFG_H | 24 | #ifndef __PLAT_GPIO_CFG_H |
| 25 | #define __PLAT_GPIO_CFG_H __FILE__ | 25 | #define __PLAT_GPIO_CFG_H __FILE__ |
| 26 | 26 | ||
| 27 | #include<linux/types.h> | ||
| 28 | |||
| 27 | typedef unsigned int __bitwise__ samsung_gpio_pull_t; | 29 | typedef unsigned int __bitwise__ samsung_gpio_pull_t; |
| 28 | typedef unsigned int __bitwise__ s5p_gpio_drvstr_t; | 30 | typedef unsigned int __bitwise__ s5p_gpio_drvstr_t; |
| 29 | 31 | ||
diff --git a/arch/arm/plat-samsung/pd.c b/arch/arm/plat-samsung/pd.c index efe1d564473e..312b510d86b7 100644 --- a/arch/arm/plat-samsung/pd.c +++ b/arch/arm/plat-samsung/pd.c | |||
| @@ -11,7 +11,7 @@ | |||
| 11 | */ | 11 | */ |
| 12 | 12 | ||
| 13 | #include <linux/init.h> | 13 | #include <linux/init.h> |
| 14 | #include <linux/module.h> | 14 | #include <linux/export.h> |
| 15 | #include <linux/platform_device.h> | 15 | #include <linux/platform_device.h> |
| 16 | #include <linux/err.h> | 16 | #include <linux/err.h> |
| 17 | #include <linux/pm_runtime.h> | 17 | #include <linux/pm_runtime.h> |
diff --git a/arch/arm/plat-samsung/pwm.c b/arch/arm/plat-samsung/pwm.c index dc1185dcf80d..c559d8438c70 100644 --- a/arch/arm/plat-samsung/pwm.c +++ b/arch/arm/plat-samsung/pwm.c | |||
| @@ -11,7 +11,7 @@ | |||
| 11 | * the Free Software Foundation; either version 2 of the License. | 11 | * the Free Software Foundation; either version 2 of the License. |
| 12 | */ | 12 | */ |
| 13 | 13 | ||
| 14 | #include <linux/module.h> | 14 | #include <linux/export.h> |
| 15 | #include <linux/kernel.h> | 15 | #include <linux/kernel.h> |
| 16 | #include <linux/platform_device.h> | 16 | #include <linux/platform_device.h> |
| 17 | #include <linux/slab.h> | 17 | #include <linux/slab.h> |
diff --git a/arch/arm/tools/mach-types b/arch/arm/tools/mach-types index 5bdeef969847..ccbe16f47227 100644 --- a/arch/arm/tools/mach-types +++ b/arch/arm/tools/mach-types | |||
| @@ -1123,5 +1123,6 @@ blissc MACH_BLISSC BLISSC 3491 | |||
| 1123 | thales_adc MACH_THALES_ADC THALES_ADC 3492 | 1123 | thales_adc MACH_THALES_ADC THALES_ADC 3492 |
| 1124 | ubisys_p9d_evp MACH_UBISYS_P9D_EVP UBISYS_P9D_EVP 3493 | 1124 | ubisys_p9d_evp MACH_UBISYS_P9D_EVP UBISYS_P9D_EVP 3493 |
| 1125 | atdgp318 MACH_ATDGP318 ATDGP318 3494 | 1125 | atdgp318 MACH_ATDGP318 ATDGP318 3494 |
| 1126 | m28evk MACH_M28EVK M28EVK 3613 | ||
| 1126 | smdk4212 MACH_SMDK4212 SMDK4212 3638 | 1127 | smdk4212 MACH_SMDK4212 SMDK4212 3638 |
| 1127 | smdk4412 MACH_SMDK4412 SMDK4412 3765 | 1128 | smdk4412 MACH_SMDK4412 SMDK4412 3765 |
diff --git a/arch/m68k/include/asm/unistd.h b/arch/m68k/include/asm/unistd.h index 43f984e93970..303192fc9260 100644 --- a/arch/m68k/include/asm/unistd.h +++ b/arch/m68k/include/asm/unistd.h | |||
| @@ -350,10 +350,12 @@ | |||
| 350 | #define __NR_clock_adjtime 342 | 350 | #define __NR_clock_adjtime 342 |
| 351 | #define __NR_syncfs 343 | 351 | #define __NR_syncfs 343 |
| 352 | #define __NR_setns 344 | 352 | #define __NR_setns 344 |
| 353 | #define __NR_process_vm_readv 345 | ||
| 354 | #define __NR_process_vm_writev 346 | ||
| 353 | 355 | ||
| 354 | #ifdef __KERNEL__ | 356 | #ifdef __KERNEL__ |
| 355 | 357 | ||
| 356 | #define NR_syscalls 345 | 358 | #define NR_syscalls 347 |
| 357 | 359 | ||
| 358 | #define __ARCH_WANT_IPC_PARSE_VERSION | 360 | #define __ARCH_WANT_IPC_PARSE_VERSION |
| 359 | #define __ARCH_WANT_OLD_READDIR | 361 | #define __ARCH_WANT_OLD_READDIR |
diff --git a/arch/m68k/kernel/syscalltable.S b/arch/m68k/kernel/syscalltable.S index c468f2edaa85..ce827b376110 100644 --- a/arch/m68k/kernel/syscalltable.S +++ b/arch/m68k/kernel/syscalltable.S | |||
| @@ -365,4 +365,6 @@ ENTRY(sys_call_table) | |||
| 365 | .long sys_clock_adjtime | 365 | .long sys_clock_adjtime |
| 366 | .long sys_syncfs | 366 | .long sys_syncfs |
| 367 | .long sys_setns | 367 | .long sys_setns |
| 368 | .long sys_process_vm_readv /* 345 */ | ||
| 369 | .long sys_process_vm_writev | ||
| 368 | 370 | ||
diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_event_mipsxx.c index 4f2971bcf8e5..315fc0b250f8 100644 --- a/arch/mips/kernel/perf_event_mipsxx.c +++ b/arch/mips/kernel/perf_event_mipsxx.c | |||
| @@ -623,7 +623,7 @@ static int mipspmu_event_init(struct perf_event *event) | |||
| 623 | if (!atomic_inc_not_zero(&active_events)) { | 623 | if (!atomic_inc_not_zero(&active_events)) { |
| 624 | if (atomic_read(&active_events) > MIPS_MAX_HWEVENTS) { | 624 | if (atomic_read(&active_events) > MIPS_MAX_HWEVENTS) { |
| 625 | atomic_dec(&active_events); | 625 | atomic_dec(&active_events); |
| 626 | return -ENOSPC; | 626 | return -EINVAL; |
| 627 | } | 627 | } |
| 628 | 628 | ||
| 629 | mutex_lock(&pmu_reserve_mutex); | 629 | mutex_lock(&pmu_reserve_mutex); |
| @@ -732,15 +732,15 @@ static int validate_group(struct perf_event *event) | |||
| 732 | memset(&fake_cpuc, 0, sizeof(fake_cpuc)); | 732 | memset(&fake_cpuc, 0, sizeof(fake_cpuc)); |
| 733 | 733 | ||
| 734 | if (!validate_event(&fake_cpuc, leader)) | 734 | if (!validate_event(&fake_cpuc, leader)) |
| 735 | return -ENOSPC; | 735 | return -EINVAL; |
| 736 | 736 | ||
| 737 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { | 737 | list_for_each_entry(sibling, &leader->sibling_list, group_entry) { |
| 738 | if (!validate_event(&fake_cpuc, sibling)) | 738 | if (!validate_event(&fake_cpuc, sibling)) |
| 739 | return -ENOSPC; | 739 | return -EINVAL; |
| 740 | } | 740 | } |
| 741 | 741 | ||
| 742 | if (!validate_event(&fake_cpuc, event)) | 742 | if (!validate_event(&fake_cpuc, event)) |
| 743 | return -ENOSPC; | 743 | return -EINVAL; |
| 744 | 744 | ||
| 745 | return 0; | 745 | return 0; |
| 746 | } | 746 | } |
diff --git a/arch/powerpc/boot/dts/p1023rds.dts b/arch/powerpc/boot/dts/p1023rds.dts index d9b776740a67..d3b478242ea9 100644 --- a/arch/powerpc/boot/dts/p1023rds.dts +++ b/arch/powerpc/boot/dts/p1023rds.dts | |||
| @@ -449,6 +449,7 @@ | |||
| 449 | interrupt-parent = <&mpic>; | 449 | interrupt-parent = <&mpic>; |
| 450 | interrupts = <16 2>; | 450 | interrupts = <16 2>; |
| 451 | interrupt-map-mask = <0xf800 0 0 7>; | 451 | interrupt-map-mask = <0xf800 0 0 7>; |
| 452 | /* IRQ[0:3] are pulled up on board, set to active-low */ | ||
| 452 | interrupt-map = < | 453 | interrupt-map = < |
| 453 | /* IDSEL 0x0 */ | 454 | /* IDSEL 0x0 */ |
| 454 | 0000 0 0 1 &mpic 0 1 | 455 | 0000 0 0 1 &mpic 0 1 |
| @@ -488,11 +489,15 @@ | |||
| 488 | interrupt-parent = <&mpic>; | 489 | interrupt-parent = <&mpic>; |
| 489 | interrupts = <16 2>; | 490 | interrupts = <16 2>; |
| 490 | interrupt-map-mask = <0xf800 0 0 7>; | 491 | interrupt-map-mask = <0xf800 0 0 7>; |
| 492 | /* | ||
| 493 | * IRQ[4:6] only for PCIe, set to active-high, | ||
| 494 | * IRQ[7] is pulled up on board, set to active-low | ||
| 495 | */ | ||
| 491 | interrupt-map = < | 496 | interrupt-map = < |
| 492 | /* IDSEL 0x0 */ | 497 | /* IDSEL 0x0 */ |
| 493 | 0000 0 0 1 &mpic 4 1 | 498 | 0000 0 0 1 &mpic 4 2 |
| 494 | 0000 0 0 2 &mpic 5 1 | 499 | 0000 0 0 2 &mpic 5 2 |
| 495 | 0000 0 0 3 &mpic 6 1 | 500 | 0000 0 0 3 &mpic 6 2 |
| 496 | 0000 0 0 4 &mpic 7 1 | 501 | 0000 0 0 4 &mpic 7 1 |
| 497 | >; | 502 | >; |
| 498 | ranges = <0x2000000 0x0 0xa0000000 | 503 | ranges = <0x2000000 0x0 0xa0000000 |
| @@ -527,12 +532,16 @@ | |||
| 527 | interrupt-parent = <&mpic>; | 532 | interrupt-parent = <&mpic>; |
| 528 | interrupts = <16 2>; | 533 | interrupts = <16 2>; |
| 529 | interrupt-map-mask = <0xf800 0 0 7>; | 534 | interrupt-map-mask = <0xf800 0 0 7>; |
| 535 | /* | ||
| 536 | * IRQ[8:10] are pulled up on board, set to active-low | ||
| 537 | * IRQ[11] only for PCIe, set to active-high, | ||
| 538 | */ | ||
| 530 | interrupt-map = < | 539 | interrupt-map = < |
| 531 | /* IDSEL 0x0 */ | 540 | /* IDSEL 0x0 */ |
| 532 | 0000 0 0 1 &mpic 8 1 | 541 | 0000 0 0 1 &mpic 8 1 |
| 533 | 0000 0 0 2 &mpic 9 1 | 542 | 0000 0 0 2 &mpic 9 1 |
| 534 | 0000 0 0 3 &mpic 10 1 | 543 | 0000 0 0 3 &mpic 10 1 |
| 535 | 0000 0 0 4 &mpic 11 1 | 544 | 0000 0 0 4 &mpic 11 2 |
| 536 | >; | 545 | >; |
| 537 | ranges = <0x2000000 0x0 0x80000000 | 546 | ranges = <0x2000000 0x0 0x80000000 |
| 538 | 0x2000000 0x0 0x80000000 | 547 | 0x2000000 0x0 0x80000000 |
diff --git a/arch/powerpc/configs/ppc44x_defconfig b/arch/powerpc/configs/ppc44x_defconfig index 6cdf1c0d2c8a..3b98d7354341 100644 --- a/arch/powerpc/configs/ppc44x_defconfig +++ b/arch/powerpc/configs/ppc44x_defconfig | |||
| @@ -52,6 +52,8 @@ CONFIG_MTD_CFI=y | |||
| 52 | CONFIG_MTD_JEDECPROBE=y | 52 | CONFIG_MTD_JEDECPROBE=y |
| 53 | CONFIG_MTD_CFI_AMDSTD=y | 53 | CONFIG_MTD_CFI_AMDSTD=y |
| 54 | CONFIG_MTD_PHYSMAP_OF=y | 54 | CONFIG_MTD_PHYSMAP_OF=y |
| 55 | CONFIG_MTD_NAND=m | ||
| 56 | CONFIG_MTD_NAND_NDFC=m | ||
| 55 | CONFIG_MTD_UBI=m | 57 | CONFIG_MTD_UBI=m |
| 56 | CONFIG_MTD_UBI_GLUEBI=m | 58 | CONFIG_MTD_UBI_GLUEBI=m |
| 57 | CONFIG_PROC_DEVICETREE=y | 59 | CONFIG_PROC_DEVICETREE=y |
diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c index 5964371303ac..8558b572e55d 100644 --- a/arch/powerpc/mm/hugetlbpage.c +++ b/arch/powerpc/mm/hugetlbpage.c | |||
| @@ -15,6 +15,7 @@ | |||
| 15 | #include <linux/of_fdt.h> | 15 | #include <linux/of_fdt.h> |
| 16 | #include <linux/memblock.h> | 16 | #include <linux/memblock.h> |
| 17 | #include <linux/bootmem.h> | 17 | #include <linux/bootmem.h> |
| 18 | #include <linux/moduleparam.h> | ||
| 18 | #include <asm/pgtable.h> | 19 | #include <asm/pgtable.h> |
| 19 | #include <asm/pgalloc.h> | 20 | #include <asm/pgalloc.h> |
| 20 | #include <asm/tlb.h> | 21 | #include <asm/tlb.h> |
diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc/platforms/85xx/Kconfig index 45023e26aea3..d7946be298b6 100644 --- a/arch/powerpc/platforms/85xx/Kconfig +++ b/arch/powerpc/platforms/85xx/Kconfig | |||
| @@ -203,7 +203,7 @@ config P3060_QDS | |||
| 203 | select PPC_E500MC | 203 | select PPC_E500MC |
| 204 | select PHYS_64BIT | 204 | select PHYS_64BIT |
| 205 | select SWIOTLB | 205 | select SWIOTLB |
| 206 | select MPC8xxx_GPIO | 206 | select GPIO_MPC8XXX |
| 207 | select HAS_RAPIDIO | 207 | select HAS_RAPIDIO |
| 208 | select PPC_EPAPR_HV_PIC | 208 | select PPC_EPAPR_HV_PIC |
| 209 | help | 209 | help |
diff --git a/arch/powerpc/platforms/85xx/p3060_qds.c b/arch/powerpc/platforms/85xx/p3060_qds.c index 01dcf44871e9..081cf4ac1881 100644 --- a/arch/powerpc/platforms/85xx/p3060_qds.c +++ b/arch/powerpc/platforms/85xx/p3060_qds.c | |||
| @@ -70,7 +70,7 @@ define_machine(p3060_qds) { | |||
| 70 | .power_save = e500_idle, | 70 | .power_save = e500_idle, |
| 71 | }; | 71 | }; |
| 72 | 72 | ||
| 73 | machine_device_initcall(p3060_qds, declare_of_platform_devices); | 73 | machine_device_initcall(p3060_qds, corenet_ds_publish_devices); |
| 74 | 74 | ||
| 75 | #ifdef CONFIG_SWIOTLB | 75 | #ifdef CONFIG_SWIOTLB |
| 76 | machine_arch_initcall(p3060_qds, swiotlb_setup_bus_notifier); | 76 | machine_arch_initcall(p3060_qds, swiotlb_setup_bus_notifier); |
diff --git a/arch/powerpc/sysdev/ehv_pic.c b/arch/powerpc/sysdev/ehv_pic.c index af1a5df46b3e..b6731e4a6646 100644 --- a/arch/powerpc/sysdev/ehv_pic.c +++ b/arch/powerpc/sysdev/ehv_pic.c | |||
| @@ -280,6 +280,7 @@ void __init ehv_pic_init(void) | |||
| 280 | 280 | ||
| 281 | if (!ehv_pic->irqhost) { | 281 | if (!ehv_pic->irqhost) { |
| 282 | of_node_put(np); | 282 | of_node_put(np); |
| 283 | kfree(ehv_pic); | ||
| 283 | return; | 284 | return; |
| 284 | } | 285 | } |
| 285 | 286 | ||
diff --git a/arch/powerpc/sysdev/fsl_lbc.c b/arch/powerpc/sysdev/fsl_lbc.c index c4d96fa32ba5..d5c3c90ee698 100644 --- a/arch/powerpc/sysdev/fsl_lbc.c +++ b/arch/powerpc/sysdev/fsl_lbc.c | |||
| @@ -328,6 +328,7 @@ static int __devinit fsl_lbc_ctrl_probe(struct platform_device *dev) | |||
| 328 | err: | 328 | err: |
| 329 | iounmap(fsl_lbc_ctrl_dev->regs); | 329 | iounmap(fsl_lbc_ctrl_dev->regs); |
| 330 | kfree(fsl_lbc_ctrl_dev); | 330 | kfree(fsl_lbc_ctrl_dev); |
| 331 | fsl_lbc_ctrl_dev = NULL; | ||
| 331 | return ret; | 332 | return ret; |
| 332 | } | 333 | } |
| 333 | 334 | ||
diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c index 3363fbc964f8..ceb09cbd2329 100644 --- a/arch/powerpc/sysdev/qe_lib/qe.c +++ b/arch/powerpc/sysdev/qe_lib/qe.c | |||
| @@ -216,7 +216,7 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate, unsigned int multiplier) | |||
| 216 | /* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says | 216 | /* Errata QE_General4, which affects some MPC832x and MPC836x SOCs, says |
| 217 | that the BRG divisor must be even if you're not using divide-by-16 | 217 | that the BRG divisor must be even if you're not using divide-by-16 |
| 218 | mode. */ | 218 | mode. */ |
| 219 | if (!div16 && (divisor & 1)) | 219 | if (!div16 && (divisor & 1) && (divisor > 3)) |
| 220 | divisor++; | 220 | divisor++; |
| 221 | 221 | ||
| 222 | tempval = ((divisor - 1) << QE_BRGC_DIVISOR_SHIFT) | | 222 | tempval = ((divisor - 1) << QE_BRGC_DIVISOR_SHIFT) | |
diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h index 524d23b8610c..4f289ff0b7fe 100644 --- a/arch/s390/include/asm/pgtable.h +++ b/arch/s390/include/asm/pgtable.h | |||
| @@ -599,10 +599,10 @@ static inline pgste_t pgste_update_all(pte_t *ptep, pgste_t pgste) | |||
| 599 | skey = page_get_storage_key(address); | 599 | skey = page_get_storage_key(address); |
| 600 | bits = skey & (_PAGE_CHANGED | _PAGE_REFERENCED); | 600 | bits = skey & (_PAGE_CHANGED | _PAGE_REFERENCED); |
| 601 | /* Clear page changed & referenced bit in the storage key */ | 601 | /* Clear page changed & referenced bit in the storage key */ |
| 602 | if (bits) { | 602 | if (bits & _PAGE_CHANGED) |
| 603 | skey ^= bits; | 603 | page_set_storage_key(address, skey ^ bits, 1); |
| 604 | page_set_storage_key(address, skey, 1); | 604 | else if (bits) |
| 605 | } | 605 | page_reset_referenced(address); |
| 606 | /* Transfer page changed & referenced bit to guest bits in pgste */ | 606 | /* Transfer page changed & referenced bit to guest bits in pgste */ |
| 607 | pgste_val(pgste) |= bits << 48; /* RCP_GR_BIT & RCP_GC_BIT */ | 607 | pgste_val(pgste) |= bits << 48; /* RCP_GR_BIT & RCP_GC_BIT */ |
| 608 | /* Get host changed & referenced bits from pgste */ | 608 | /* Get host changed & referenced bits from pgste */ |
diff --git a/arch/s390/kernel/ptrace.c b/arch/s390/kernel/ptrace.c index 450931a45b68..573bc29551ef 100644 --- a/arch/s390/kernel/ptrace.c +++ b/arch/s390/kernel/ptrace.c | |||
| @@ -296,13 +296,6 @@ static int __poke_user(struct task_struct *child, addr_t addr, addr_t data) | |||
| 296 | ((data & PSW_MASK_EA) && !(data & PSW_MASK_BA)))) | 296 | ((data & PSW_MASK_EA) && !(data & PSW_MASK_BA)))) |
| 297 | /* Invalid psw mask. */ | 297 | /* Invalid psw mask. */ |
| 298 | return -EINVAL; | 298 | return -EINVAL; |
| 299 | if (addr == (addr_t) &dummy->regs.psw.addr) | ||
| 300 | /* | ||
| 301 | * The debugger changed the instruction address, | ||
| 302 | * reset system call restart, see signal.c:do_signal | ||
| 303 | */ | ||
| 304 | task_thread_info(child)->system_call = 0; | ||
| 305 | |||
| 306 | *(addr_t *)((addr_t) &task_pt_regs(child)->psw + addr) = data; | 299 | *(addr_t *)((addr_t) &task_pt_regs(child)->psw + addr) = data; |
| 307 | 300 | ||
| 308 | } else if (addr < (addr_t) (&dummy->regs.orig_gpr2)) { | 301 | } else if (addr < (addr_t) (&dummy->regs.orig_gpr2)) { |
| @@ -614,11 +607,6 @@ static int __poke_user_compat(struct task_struct *child, | |||
| 614 | /* Transfer 31 bit amode bit to psw mask. */ | 607 | /* Transfer 31 bit amode bit to psw mask. */ |
| 615 | regs->psw.mask = (regs->psw.mask & ~PSW_MASK_BA) | | 608 | regs->psw.mask = (regs->psw.mask & ~PSW_MASK_BA) | |
| 616 | (__u64)(tmp & PSW32_ADDR_AMODE); | 609 | (__u64)(tmp & PSW32_ADDR_AMODE); |
| 617 | /* | ||
| 618 | * The debugger changed the instruction address, | ||
| 619 | * reset system call restart, see signal.c:do_signal | ||
| 620 | */ | ||
| 621 | task_thread_info(child)->system_call = 0; | ||
| 622 | } else { | 610 | } else { |
| 623 | /* gpr 0-15 */ | 611 | /* gpr 0-15 */ |
| 624 | *(__u32*)((addr_t) ®s->psw + addr*2 + 4) = tmp; | 612 | *(__u32*)((addr_t) ®s->psw + addr*2 + 4) = tmp; |
| @@ -905,6 +893,14 @@ static int s390_last_break_get(struct task_struct *target, | |||
| 905 | return 0; | 893 | return 0; |
| 906 | } | 894 | } |
| 907 | 895 | ||
| 896 | static int s390_last_break_set(struct task_struct *target, | ||
| 897 | const struct user_regset *regset, | ||
| 898 | unsigned int pos, unsigned int count, | ||
| 899 | const void *kbuf, const void __user *ubuf) | ||
| 900 | { | ||
| 901 | return 0; | ||
| 902 | } | ||
| 903 | |||
| 908 | #endif | 904 | #endif |
| 909 | 905 | ||
| 910 | static int s390_system_call_get(struct task_struct *target, | 906 | static int s390_system_call_get(struct task_struct *target, |
| @@ -951,6 +947,7 @@ static const struct user_regset s390_regsets[] = { | |||
| 951 | .size = sizeof(long), | 947 | .size = sizeof(long), |
| 952 | .align = sizeof(long), | 948 | .align = sizeof(long), |
| 953 | .get = s390_last_break_get, | 949 | .get = s390_last_break_get, |
| 950 | .set = s390_last_break_set, | ||
| 954 | }, | 951 | }, |
| 955 | #endif | 952 | #endif |
| 956 | [REGSET_SYSTEM_CALL] = { | 953 | [REGSET_SYSTEM_CALL] = { |
| @@ -1116,6 +1113,14 @@ static int s390_compat_last_break_get(struct task_struct *target, | |||
| 1116 | return 0; | 1113 | return 0; |
| 1117 | } | 1114 | } |
| 1118 | 1115 | ||
| 1116 | static int s390_compat_last_break_set(struct task_struct *target, | ||
| 1117 | const struct user_regset *regset, | ||
| 1118 | unsigned int pos, unsigned int count, | ||
| 1119 | const void *kbuf, const void __user *ubuf) | ||
| 1120 | { | ||
| 1121 | return 0; | ||
| 1122 | } | ||
| 1123 | |||
| 1119 | static const struct user_regset s390_compat_regsets[] = { | 1124 | static const struct user_regset s390_compat_regsets[] = { |
| 1120 | [REGSET_GENERAL] = { | 1125 | [REGSET_GENERAL] = { |
| 1121 | .core_note_type = NT_PRSTATUS, | 1126 | .core_note_type = NT_PRSTATUS, |
| @@ -1139,6 +1144,7 @@ static const struct user_regset s390_compat_regsets[] = { | |||
| 1139 | .size = sizeof(long), | 1144 | .size = sizeof(long), |
| 1140 | .align = sizeof(long), | 1145 | .align = sizeof(long), |
| 1141 | .get = s390_compat_last_break_get, | 1146 | .get = s390_compat_last_break_get, |
| 1147 | .set = s390_compat_last_break_set, | ||
| 1142 | }, | 1148 | }, |
| 1143 | [REGSET_SYSTEM_CALL] = { | 1149 | [REGSET_SYSTEM_CALL] = { |
| 1144 | .core_note_type = NT_S390_SYSTEM_CALL, | 1150 | .core_note_type = NT_S390_SYSTEM_CALL, |
diff --git a/arch/s390/kernel/setup.c b/arch/s390/kernel/setup.c index e58a462949b1..e54c4ff8abaa 100644 --- a/arch/s390/kernel/setup.c +++ b/arch/s390/kernel/setup.c | |||
| @@ -579,7 +579,7 @@ static unsigned long __init find_crash_base(unsigned long crash_size, | |||
| 579 | *msg = "first memory chunk must be at least crashkernel size"; | 579 | *msg = "first memory chunk must be at least crashkernel size"; |
| 580 | return 0; | 580 | return 0; |
| 581 | } | 581 | } |
| 582 | if (is_kdump_kernel() && (crash_size == OLDMEM_SIZE)) | 582 | if (OLDMEM_BASE && crash_size == OLDMEM_SIZE) |
| 583 | return OLDMEM_BASE; | 583 | return OLDMEM_BASE; |
| 584 | 584 | ||
| 585 | for (i = MEMORY_CHUNKS - 1; i >= 0; i--) { | 585 | for (i = MEMORY_CHUNKS - 1; i >= 0; i--) { |
diff --git a/arch/s390/kernel/signal.c b/arch/s390/kernel/signal.c index 05a85bc14c98..7f6f9f354545 100644 --- a/arch/s390/kernel/signal.c +++ b/arch/s390/kernel/signal.c | |||
| @@ -460,9 +460,9 @@ void do_signal(struct pt_regs *regs) | |||
| 460 | regs->svc_code >> 16); | 460 | regs->svc_code >> 16); |
| 461 | break; | 461 | break; |
| 462 | } | 462 | } |
| 463 | /* No longer in a system call */ | ||
| 464 | clear_thread_flag(TIF_SYSCALL); | ||
| 465 | } | 463 | } |
| 464 | /* No longer in a system call */ | ||
| 465 | clear_thread_flag(TIF_SYSCALL); | ||
| 466 | 466 | ||
| 467 | if ((is_compat_task() ? | 467 | if ((is_compat_task() ? |
| 468 | handle_signal32(signr, &ka, &info, oldset, regs) : | 468 | handle_signal32(signr, &ka, &info, oldset, regs) : |
| @@ -486,6 +486,7 @@ void do_signal(struct pt_regs *regs) | |||
| 486 | } | 486 | } |
| 487 | 487 | ||
| 488 | /* No handlers present - check for system call restart */ | 488 | /* No handlers present - check for system call restart */ |
| 489 | clear_thread_flag(TIF_SYSCALL); | ||
| 489 | if (current_thread_info()->system_call) { | 490 | if (current_thread_info()->system_call) { |
| 490 | regs->svc_code = current_thread_info()->system_call; | 491 | regs->svc_code = current_thread_info()->system_call; |
| 491 | switch (regs->gprs[2]) { | 492 | switch (regs->gprs[2]) { |
| @@ -500,9 +501,6 @@ void do_signal(struct pt_regs *regs) | |||
| 500 | regs->gprs[2] = regs->orig_gpr2; | 501 | regs->gprs[2] = regs->orig_gpr2; |
| 501 | set_thread_flag(TIF_SYSCALL); | 502 | set_thread_flag(TIF_SYSCALL); |
| 502 | break; | 503 | break; |
| 503 | default: | ||
| 504 | clear_thread_flag(TIF_SYSCALL); | ||
| 505 | break; | ||
| 506 | } | 504 | } |
| 507 | } | 505 | } |
| 508 | 506 | ||
diff --git a/arch/sparc/kernel/ds.c b/arch/sparc/kernel/ds.c index 7429b47c3aca..381edcd5bc29 100644 --- a/arch/sparc/kernel/ds.c +++ b/arch/sparc/kernel/ds.c | |||
| @@ -1181,13 +1181,11 @@ static int __devinit ds_probe(struct vio_dev *vdev, | |||
| 1181 | 1181 | ||
| 1182 | dp->rcv_buf_len = 4096; | 1182 | dp->rcv_buf_len = 4096; |
| 1183 | 1183 | ||
| 1184 | dp->ds_states = kzalloc(sizeof(ds_states_template), | 1184 | dp->ds_states = kmemdup(ds_states_template, |
| 1185 | GFP_KERNEL); | 1185 | sizeof(ds_states_template), GFP_KERNEL); |
| 1186 | if (!dp->ds_states) | 1186 | if (!dp->ds_states) |
| 1187 | goto out_free_rcv_buf; | 1187 | goto out_free_rcv_buf; |
| 1188 | 1188 | ||
| 1189 | memcpy(dp->ds_states, ds_states_template, | ||
| 1190 | sizeof(ds_states_template)); | ||
| 1191 | dp->num_ds_states = ARRAY_SIZE(ds_states_template); | 1189 | dp->num_ds_states = ARRAY_SIZE(ds_states_template); |
| 1192 | 1190 | ||
| 1193 | for (i = 0; i < dp->num_ds_states; i++) | 1191 | for (i = 0; i < dp->num_ds_states; i++) |
diff --git a/arch/sparc/kernel/prom_common.c b/arch/sparc/kernel/prom_common.c index 46614807a57f..741df916c124 100644 --- a/arch/sparc/kernel/prom_common.c +++ b/arch/sparc/kernel/prom_common.c | |||
| @@ -58,12 +58,10 @@ int of_set_property(struct device_node *dp, const char *name, void *val, int len | |||
| 58 | void *new_val; | 58 | void *new_val; |
| 59 | int err; | 59 | int err; |
| 60 | 60 | ||
| 61 | new_val = kmalloc(len, GFP_KERNEL); | 61 | new_val = kmemdup(val, len, GFP_KERNEL); |
| 62 | if (!new_val) | 62 | if (!new_val) |
| 63 | return -ENOMEM; | 63 | return -ENOMEM; |
| 64 | 64 | ||
| 65 | memcpy(new_val, val, len); | ||
| 66 | |||
| 67 | err = -ENODEV; | 65 | err = -ENODEV; |
| 68 | 66 | ||
| 69 | mutex_lock(&of_set_property_mutex); | 67 | mutex_lock(&of_set_property_mutex); |
diff --git a/arch/sparc/mm/btfixup.c b/arch/sparc/mm/btfixup.c index 5175ac2f4820..8a7f81743c12 100644 --- a/arch/sparc/mm/btfixup.c +++ b/arch/sparc/mm/btfixup.c | |||
| @@ -302,8 +302,7 @@ void __init btfixup(void) | |||
| 302 | case 'i': /* INT */ | 302 | case 'i': /* INT */ |
| 303 | if ((insn & 0xc1c00000) == 0x01000000) /* %HI */ | 303 | if ((insn & 0xc1c00000) == 0x01000000) /* %HI */ |
| 304 | set_addr(addr, q[1], fmangled, (insn & 0xffc00000) | (p[1] >> 10)); | 304 | set_addr(addr, q[1], fmangled, (insn & 0xffc00000) | (p[1] >> 10)); |
| 305 | else if ((insn & 0x80002000) == 0x80002000 && | 305 | else if ((insn & 0x80002000) == 0x80002000) /* %LO */ |
| 306 | (insn & 0x01800000) != 0x01800000) /* %LO */ | ||
| 307 | set_addr(addr, q[1], fmangled, (insn & 0xffffe000) | (p[1] & 0x3ff)); | 306 | set_addr(addr, q[1], fmangled, (insn & 0xffffe000) | (p[1] & 0x3ff)); |
| 308 | else { | 307 | else { |
| 309 | prom_printf(insn_i, p, addr, insn); | 308 | prom_printf(insn_i, p, addr, insn); |
diff --git a/arch/tile/include/asm/irq.h b/arch/tile/include/asm/irq.h index 94e9a511de84..f80f8ceabc67 100644 --- a/arch/tile/include/asm/irq.h +++ b/arch/tile/include/asm/irq.h | |||
| @@ -74,16 +74,6 @@ enum { | |||
| 74 | */ | 74 | */ |
| 75 | void tile_irq_activate(unsigned int irq, int tile_irq_type); | 75 | void tile_irq_activate(unsigned int irq, int tile_irq_type); |
| 76 | 76 | ||
| 77 | /* | ||
| 78 | * For onboard, non-PCI (e.g. TILE_IRQ_PERCPU) devices, drivers know | ||
| 79 | * how to use enable/disable_percpu_irq() to manage interrupts on each | ||
| 80 | * core. We can't use the generic enable/disable_irq() because they | ||
| 81 | * use a single reference count per irq, rather than per cpu per irq. | ||
| 82 | */ | ||
| 83 | void enable_percpu_irq(unsigned int irq); | ||
| 84 | void disable_percpu_irq(unsigned int irq); | ||
| 85 | |||
| 86 | |||
| 87 | void setup_irq_regs(void); | 77 | void setup_irq_regs(void); |
| 88 | 78 | ||
| 89 | #endif /* _ASM_TILE_IRQ_H */ | 79 | #endif /* _ASM_TILE_IRQ_H */ |
diff --git a/arch/tile/kernel/irq.c b/arch/tile/kernel/irq.c index aa0134db2dd6..02e628065012 100644 --- a/arch/tile/kernel/irq.c +++ b/arch/tile/kernel/irq.c | |||
| @@ -152,14 +152,13 @@ void tile_dev_intr(struct pt_regs *regs, int intnum) | |||
| 152 | * Remove an irq from the disabled mask. If we're in an interrupt | 152 | * Remove an irq from the disabled mask. If we're in an interrupt |
| 153 | * context, defer enabling the HW interrupt until we leave. | 153 | * context, defer enabling the HW interrupt until we leave. |
| 154 | */ | 154 | */ |
| 155 | void enable_percpu_irq(unsigned int irq) | 155 | static void tile_irq_chip_enable(struct irq_data *d) |
| 156 | { | 156 | { |
| 157 | get_cpu_var(irq_disable_mask) &= ~(1UL << irq); | 157 | get_cpu_var(irq_disable_mask) &= ~(1UL << d->irq); |
| 158 | if (__get_cpu_var(irq_depth) == 0) | 158 | if (__get_cpu_var(irq_depth) == 0) |
| 159 | unmask_irqs(1UL << irq); | 159 | unmask_irqs(1UL << d->irq); |
| 160 | put_cpu_var(irq_disable_mask); | 160 | put_cpu_var(irq_disable_mask); |
| 161 | } | 161 | } |
| 162 | EXPORT_SYMBOL(enable_percpu_irq); | ||
| 163 | 162 | ||
| 164 | /* | 163 | /* |
| 165 | * Add an irq to the disabled mask. We disable the HW interrupt | 164 | * Add an irq to the disabled mask. We disable the HW interrupt |
| @@ -167,13 +166,12 @@ EXPORT_SYMBOL(enable_percpu_irq); | |||
| 167 | * in an interrupt context, the return path is careful to avoid | 166 | * in an interrupt context, the return path is careful to avoid |
| 168 | * unmasking a newly disabled interrupt. | 167 | * unmasking a newly disabled interrupt. |
| 169 | */ | 168 | */ |
| 170 | void disable_percpu_irq(unsigned int irq) | 169 | static void tile_irq_chip_disable(struct irq_data *d) |
| 171 | { | 170 | { |
| 172 | get_cpu_var(irq_disable_mask) |= (1UL << irq); | 171 | get_cpu_var(irq_disable_mask) |= (1UL << d->irq); |
| 173 | mask_irqs(1UL << irq); | 172 | mask_irqs(1UL << d->irq); |
| 174 | put_cpu_var(irq_disable_mask); | 173 | put_cpu_var(irq_disable_mask); |
| 175 | } | 174 | } |
| 176 | EXPORT_SYMBOL(disable_percpu_irq); | ||
| 177 | 175 | ||
| 178 | /* Mask an interrupt. */ | 176 | /* Mask an interrupt. */ |
| 179 | static void tile_irq_chip_mask(struct irq_data *d) | 177 | static void tile_irq_chip_mask(struct irq_data *d) |
| @@ -209,6 +207,8 @@ static void tile_irq_chip_eoi(struct irq_data *d) | |||
| 209 | 207 | ||
| 210 | static struct irq_chip tile_irq_chip = { | 208 | static struct irq_chip tile_irq_chip = { |
| 211 | .name = "tile_irq_chip", | 209 | .name = "tile_irq_chip", |
| 210 | .irq_enable = tile_irq_chip_enable, | ||
| 211 | .irq_disable = tile_irq_chip_disable, | ||
| 212 | .irq_ack = tile_irq_chip_ack, | 212 | .irq_ack = tile_irq_chip_ack, |
| 213 | .irq_eoi = tile_irq_chip_eoi, | 213 | .irq_eoi = tile_irq_chip_eoi, |
| 214 | .irq_mask = tile_irq_chip_mask, | 214 | .irq_mask = tile_irq_chip_mask, |
diff --git a/arch/tile/kernel/pci-dma.c b/arch/tile/kernel/pci-dma.c index 658f2ce426a4..b3ed19f8779c 100644 --- a/arch/tile/kernel/pci-dma.c +++ b/arch/tile/kernel/pci-dma.c | |||
| @@ -15,6 +15,7 @@ | |||
| 15 | #include <linux/mm.h> | 15 | #include <linux/mm.h> |
| 16 | #include <linux/dma-mapping.h> | 16 | #include <linux/dma-mapping.h> |
| 17 | #include <linux/vmalloc.h> | 17 | #include <linux/vmalloc.h> |
| 18 | #include <linux/export.h> | ||
| 18 | #include <asm/tlbflush.h> | 19 | #include <asm/tlbflush.h> |
| 19 | #include <asm/homecache.h> | 20 | #include <asm/homecache.h> |
| 20 | 21 | ||
diff --git a/arch/tile/kernel/pci.c b/arch/tile/kernel/pci.c index 2a8014cb1ff5..9d610d3fb11e 100644 --- a/arch/tile/kernel/pci.c +++ b/arch/tile/kernel/pci.c | |||
| @@ -24,6 +24,7 @@ | |||
| 24 | #include <linux/irq.h> | 24 | #include <linux/irq.h> |
| 25 | #include <linux/io.h> | 25 | #include <linux/io.h> |
| 26 | #include <linux/uaccess.h> | 26 | #include <linux/uaccess.h> |
| 27 | #include <linux/export.h> | ||
| 27 | 28 | ||
| 28 | #include <asm/processor.h> | 29 | #include <asm/processor.h> |
| 29 | #include <asm/sections.h> | 30 | #include <asm/sections.h> |
diff --git a/arch/tile/kernel/sysfs.c b/arch/tile/kernel/sysfs.c index b671a86f4515..602908268093 100644 --- a/arch/tile/kernel/sysfs.c +++ b/arch/tile/kernel/sysfs.c | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | #include <linux/cpu.h> | 18 | #include <linux/cpu.h> |
| 19 | #include <linux/slab.h> | 19 | #include <linux/slab.h> |
| 20 | #include <linux/smp.h> | 20 | #include <linux/smp.h> |
| 21 | #include <linux/stat.h> | ||
| 21 | #include <hv/hypervisor.h> | 22 | #include <hv/hypervisor.h> |
| 22 | 23 | ||
| 23 | /* Return a string queried from the hypervisor, truncated to page size. */ | 24 | /* Return a string queried from the hypervisor, truncated to page size. */ |
diff --git a/arch/tile/lib/exports.c b/arch/tile/lib/exports.c index a87d2a859ba9..2a81d32de0da 100644 --- a/arch/tile/lib/exports.c +++ b/arch/tile/lib/exports.c | |||
| @@ -39,6 +39,9 @@ EXPORT_SYMBOL(finv_user_asm); | |||
| 39 | EXPORT_SYMBOL(current_text_addr); | 39 | EXPORT_SYMBOL(current_text_addr); |
| 40 | EXPORT_SYMBOL(dump_stack); | 40 | EXPORT_SYMBOL(dump_stack); |
| 41 | 41 | ||
| 42 | /* arch/tile/kernel/head.S */ | ||
| 43 | EXPORT_SYMBOL(empty_zero_page); | ||
| 44 | |||
| 42 | /* arch/tile/lib/, various memcpy files */ | 45 | /* arch/tile/lib/, various memcpy files */ |
| 43 | EXPORT_SYMBOL(memcpy); | 46 | EXPORT_SYMBOL(memcpy); |
| 44 | EXPORT_SYMBOL(__copy_to_user_inatomic); | 47 | EXPORT_SYMBOL(__copy_to_user_inatomic); |
diff --git a/arch/tile/mm/homecache.c b/arch/tile/mm/homecache.c index cbe6f4f9eca3..1cc6ae477c98 100644 --- a/arch/tile/mm/homecache.c +++ b/arch/tile/mm/homecache.c | |||
| @@ -449,9 +449,12 @@ void homecache_free_pages(unsigned long addr, unsigned int order) | |||
| 449 | VM_BUG_ON(!virt_addr_valid((void *)addr)); | 449 | VM_BUG_ON(!virt_addr_valid((void *)addr)); |
| 450 | page = virt_to_page((void *)addr); | 450 | page = virt_to_page((void *)addr); |
| 451 | if (put_page_testzero(page)) { | 451 | if (put_page_testzero(page)) { |
| 452 | int pages = (1 << order); | ||
| 453 | homecache_change_page_home(page, order, initial_page_home()); | 452 | homecache_change_page_home(page, order, initial_page_home()); |
| 454 | while (pages--) | 453 | if (order == 0) { |
| 455 | __free_page(page++); | 454 | free_hot_cold_page(page, 0); |
| 455 | } else { | ||
| 456 | init_page_count(page); | ||
| 457 | __free_pages(page, order); | ||
| 458 | } | ||
| 456 | } | 459 | } |
| 457 | } | 460 | } |
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index cb9a1044a771..efb42949cc09 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig | |||
| @@ -390,7 +390,7 @@ config X86_INTEL_CE | |||
| 390 | This option compiles in support for the CE4100 SOC for settop | 390 | This option compiles in support for the CE4100 SOC for settop |
| 391 | boxes and media devices. | 391 | boxes and media devices. |
| 392 | 392 | ||
| 393 | config X86_INTEL_MID | 393 | config X86_WANT_INTEL_MID |
| 394 | bool "Intel MID platform support" | 394 | bool "Intel MID platform support" |
| 395 | depends on X86_32 | 395 | depends on X86_32 |
| 396 | depends on X86_EXTENDED_PLATFORM | 396 | depends on X86_EXTENDED_PLATFORM |
| @@ -399,7 +399,10 @@ config X86_INTEL_MID | |||
| 399 | systems which do not have the PCI legacy interfaces (Moorestown, | 399 | systems which do not have the PCI legacy interfaces (Moorestown, |
| 400 | Medfield). If you are building for a PC class system say N here. | 400 | Medfield). If you are building for a PC class system say N here. |
| 401 | 401 | ||
| 402 | if X86_INTEL_MID | 402 | if X86_WANT_INTEL_MID |
| 403 | |||
| 404 | config X86_INTEL_MID | ||
| 405 | bool | ||
| 403 | 406 | ||
| 404 | config X86_MRST | 407 | config X86_MRST |
| 405 | bool "Moorestown MID platform" | 408 | bool "Moorestown MID platform" |
| @@ -411,6 +414,7 @@ config X86_MRST | |||
| 411 | select SPI | 414 | select SPI |
| 412 | select INTEL_SCU_IPC | 415 | select INTEL_SCU_IPC |
| 413 | select X86_PLATFORM_DEVICES | 416 | select X86_PLATFORM_DEVICES |
| 417 | select X86_INTEL_MID | ||
| 414 | ---help--- | 418 | ---help--- |
| 415 | Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin | 419 | Moorestown is Intel's Low Power Intel Architecture (LPIA) based Moblin |
| 416 | Internet Device(MID) platform. Moorestown consists of two chips: | 420 | Internet Device(MID) platform. Moorestown consists of two chips: |
diff --git a/arch/x86/include/asm/intel_scu_ipc.h b/arch/x86/include/asm/intel_scu_ipc.h index 4420993acc47..925b605eb5c6 100644 --- a/arch/x86/include/asm/intel_scu_ipc.h +++ b/arch/x86/include/asm/intel_scu_ipc.h | |||
| @@ -3,11 +3,15 @@ | |||
| 3 | 3 | ||
| 4 | #include <linux/notifier.h> | 4 | #include <linux/notifier.h> |
| 5 | 5 | ||
| 6 | #define IPCMSG_VRTC 0xFA /* Set vRTC device */ | 6 | #define IPCMSG_WARM_RESET 0xF0 |
| 7 | 7 | #define IPCMSG_COLD_RESET 0xF1 | |
| 8 | /* Command id associated with message IPCMSG_VRTC */ | 8 | #define IPCMSG_SOFT_RESET 0xF2 |
| 9 | #define IPC_CMD_VRTC_SETTIME 1 /* Set time */ | 9 | #define IPCMSG_COLD_BOOT 0xF3 |
| 10 | #define IPC_CMD_VRTC_SETALARM 2 /* Set alarm */ | 10 | |
| 11 | #define IPCMSG_VRTC 0xFA /* Set vRTC device */ | ||
| 12 | /* Command id associated with message IPCMSG_VRTC */ | ||
| 13 | #define IPC_CMD_VRTC_SETTIME 1 /* Set time */ | ||
| 14 | #define IPC_CMD_VRTC_SETALARM 2 /* Set alarm */ | ||
| 11 | 15 | ||
| 12 | /* Read single register */ | 16 | /* Read single register */ |
| 13 | int intel_scu_ipc_ioread8(u16 addr, u8 *data); | 17 | int intel_scu_ipc_ioread8(u16 addr, u8 *data); |
diff --git a/arch/x86/include/asm/mrst.h b/arch/x86/include/asm/mrst.h index e6283129c821..93f79094c224 100644 --- a/arch/x86/include/asm/mrst.h +++ b/arch/x86/include/asm/mrst.h | |||
| @@ -31,11 +31,20 @@ enum mrst_cpu_type { | |||
| 31 | }; | 31 | }; |
| 32 | 32 | ||
| 33 | extern enum mrst_cpu_type __mrst_cpu_chip; | 33 | extern enum mrst_cpu_type __mrst_cpu_chip; |
| 34 | |||
| 35 | #ifdef CONFIG_X86_INTEL_MID | ||
| 36 | |||
| 34 | static inline enum mrst_cpu_type mrst_identify_cpu(void) | 37 | static inline enum mrst_cpu_type mrst_identify_cpu(void) |
| 35 | { | 38 | { |
| 36 | return __mrst_cpu_chip; | 39 | return __mrst_cpu_chip; |
| 37 | } | 40 | } |
| 38 | 41 | ||
| 42 | #else /* !CONFIG_X86_INTEL_MID */ | ||
| 43 | |||
| 44 | #define mrst_identify_cpu() (0) | ||
| 45 | |||
| 46 | #endif /* !CONFIG_X86_INTEL_MID */ | ||
| 47 | |||
| 39 | enum mrst_timer_options { | 48 | enum mrst_timer_options { |
| 40 | MRST_TIMER_DEFAULT, | 49 | MRST_TIMER_DEFAULT, |
| 41 | MRST_TIMER_APBT_ONLY, | 50 | MRST_TIMER_APBT_ONLY, |
diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h index 084ef95274cd..95203d40ffdd 100644 --- a/arch/x86/include/asm/msr.h +++ b/arch/x86/include/asm/msr.h | |||
| @@ -169,7 +169,14 @@ static inline int wrmsr_safe(unsigned msr, unsigned low, unsigned high) | |||
| 169 | return native_write_msr_safe(msr, low, high); | 169 | return native_write_msr_safe(msr, low, high); |
| 170 | } | 170 | } |
| 171 | 171 | ||
| 172 | /* rdmsr with exception handling */ | 172 | /* |
| 173 | * rdmsr with exception handling. | ||
| 174 | * | ||
| 175 | * Please note that the exception handling works only after we've | ||
| 176 | * switched to the "smart" #GP handler in trap_init() which knows about | ||
| 177 | * exception tables - using this macro earlier than that causes machine | ||
| 178 | * hangs on boxes which do not implement the @msr in the first argument. | ||
| 179 | */ | ||
| 173 | #define rdmsr_safe(msr, p1, p2) \ | 180 | #define rdmsr_safe(msr, p1, p2) \ |
| 174 | ({ \ | 181 | ({ \ |
| 175 | int __err; \ | 182 | int __err; \ |
diff --git a/arch/x86/include/asm/system.h b/arch/x86/include/asm/system.h index c2ff2a1d845e..2d2f01ce6dcb 100644 --- a/arch/x86/include/asm/system.h +++ b/arch/x86/include/asm/system.h | |||
| @@ -401,6 +401,7 @@ extern unsigned long arch_align_stack(unsigned long sp); | |||
| 401 | extern void free_init_pages(char *what, unsigned long begin, unsigned long end); | 401 | extern void free_init_pages(char *what, unsigned long begin, unsigned long end); |
| 402 | 402 | ||
| 403 | void default_idle(void); | 403 | void default_idle(void); |
| 404 | bool set_pm_idle_to_default(void); | ||
| 404 | 405 | ||
| 405 | void stop_this_cpu(void *dummy); | 406 | void stop_this_cpu(void *dummy); |
| 406 | 407 | ||
diff --git a/arch/x86/include/asm/timer.h b/arch/x86/include/asm/timer.h index fa7b9176b76c..431793e5d484 100644 --- a/arch/x86/include/asm/timer.h +++ b/arch/x86/include/asm/timer.h | |||
| @@ -32,6 +32,22 @@ extern int no_timer_check; | |||
| 32 | * (mathieu.desnoyers@polymtl.ca) | 32 | * (mathieu.desnoyers@polymtl.ca) |
| 33 | * | 33 | * |
| 34 | * -johnstul@us.ibm.com "math is hard, lets go shopping!" | 34 | * -johnstul@us.ibm.com "math is hard, lets go shopping!" |
| 35 | * | ||
| 36 | * In: | ||
| 37 | * | ||
| 38 | * ns = cycles * cyc2ns_scale / SC | ||
| 39 | * | ||
| 40 | * Although we may still have enough bits to store the value of ns, | ||
| 41 | * in some cases, we may not have enough bits to store cycles * cyc2ns_scale, | ||
| 42 | * leading to an incorrect result. | ||
| 43 | * | ||
| 44 | * To avoid this, we can decompose 'cycles' into quotient and remainder | ||
| 45 | * of division by SC. Then, | ||
| 46 | * | ||
| 47 | * ns = (quot * SC + rem) * cyc2ns_scale / SC | ||
| 48 | * = quot * cyc2ns_scale + (rem * cyc2ns_scale) / SC | ||
| 49 | * | ||
| 50 | * - sqazi@google.com | ||
| 35 | */ | 51 | */ |
| 36 | 52 | ||
| 37 | DECLARE_PER_CPU(unsigned long, cyc2ns); | 53 | DECLARE_PER_CPU(unsigned long, cyc2ns); |
| @@ -41,9 +57,14 @@ DECLARE_PER_CPU(unsigned long long, cyc2ns_offset); | |||
| 41 | 57 | ||
| 42 | static inline unsigned long long __cycles_2_ns(unsigned long long cyc) | 58 | static inline unsigned long long __cycles_2_ns(unsigned long long cyc) |
| 43 | { | 59 | { |
| 60 | unsigned long long quot; | ||
| 61 | unsigned long long rem; | ||
| 44 | int cpu = smp_processor_id(); | 62 | int cpu = smp_processor_id(); |
| 45 | unsigned long long ns = per_cpu(cyc2ns_offset, cpu); | 63 | unsigned long long ns = per_cpu(cyc2ns_offset, cpu); |
| 46 | ns += cyc * per_cpu(cyc2ns, cpu) >> CYC2NS_SCALE_FACTOR; | 64 | quot = (cyc >> CYC2NS_SCALE_FACTOR); |
| 65 | rem = cyc & ((1ULL << CYC2NS_SCALE_FACTOR) - 1); | ||
| 66 | ns += quot * per_cpu(cyc2ns, cpu) + | ||
| 67 | ((rem * per_cpu(cyc2ns, cpu)) >> CYC2NS_SCALE_FACTOR); | ||
| 47 | return ns; | 68 | return ns; |
| 48 | } | 69 | } |
| 49 | 70 | ||
diff --git a/arch/x86/include/asm/uv/uv_mmrs.h b/arch/x86/include/asm/uv/uv_mmrs.h index 10474fb1185d..cf1d73643f60 100644 --- a/arch/x86/include/asm/uv/uv_mmrs.h +++ b/arch/x86/include/asm/uv/uv_mmrs.h | |||
| @@ -57,6 +57,7 @@ | |||
| 57 | 57 | ||
| 58 | #define UV1_HUB_PART_NUMBER 0x88a5 | 58 | #define UV1_HUB_PART_NUMBER 0x88a5 |
| 59 | #define UV2_HUB_PART_NUMBER 0x8eb8 | 59 | #define UV2_HUB_PART_NUMBER 0x8eb8 |
| 60 | #define UV2_HUB_PART_NUMBER_X 0x1111 | ||
| 60 | 61 | ||
| 61 | /* Compat: if this #define is present, UV headers support UV2 */ | 62 | /* Compat: if this #define is present, UV headers support UV2 */ |
| 62 | #define UV2_HUB_IS_SUPPORTED 1 | 63 | #define UV2_HUB_IS_SUPPORTED 1 |
diff --git a/arch/x86/kernel/apic/x2apic_uv_x.c b/arch/x86/kernel/apic/x2apic_uv_x.c index 62ae3001ae02..9d59bbacd4e3 100644 --- a/arch/x86/kernel/apic/x2apic_uv_x.c +++ b/arch/x86/kernel/apic/x2apic_uv_x.c | |||
| @@ -93,6 +93,8 @@ static int __init early_get_pnodeid(void) | |||
| 93 | 93 | ||
| 94 | if (node_id.s.part_number == UV2_HUB_PART_NUMBER) | 94 | if (node_id.s.part_number == UV2_HUB_PART_NUMBER) |
| 95 | uv_min_hub_revision_id += UV2_HUB_REVISION_BASE - 1; | 95 | uv_min_hub_revision_id += UV2_HUB_REVISION_BASE - 1; |
| 96 | if (node_id.s.part_number == UV2_HUB_PART_NUMBER_X) | ||
| 97 | uv_min_hub_revision_id += UV2_HUB_REVISION_BASE - 1; | ||
| 96 | 98 | ||
| 97 | uv_hub_info->hub_revision = uv_min_hub_revision_id; | 99 | uv_hub_info->hub_revision = uv_min_hub_revision_id; |
| 98 | pnode = (node_id.s.node_id >> 1) & ((1 << m_n_config.s.n_skt) - 1); | 100 | pnode = (node_id.s.node_id >> 1) & ((1 << m_n_config.s.n_skt) - 1); |
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c index c7e46cb35327..0bab2b18bb20 100644 --- a/arch/x86/kernel/cpu/amd.c +++ b/arch/x86/kernel/cpu/amd.c | |||
| @@ -442,8 +442,6 @@ static void __cpuinit bsp_init_amd(struct cpuinfo_x86 *c) | |||
| 442 | 442 | ||
| 443 | static void __cpuinit early_init_amd(struct cpuinfo_x86 *c) | 443 | static void __cpuinit early_init_amd(struct cpuinfo_x86 *c) |
| 444 | { | 444 | { |
| 445 | u32 dummy; | ||
| 446 | |||
| 447 | early_init_amd_mc(c); | 445 | early_init_amd_mc(c); |
| 448 | 446 | ||
| 449 | /* | 447 | /* |
| @@ -473,12 +471,12 @@ static void __cpuinit early_init_amd(struct cpuinfo_x86 *c) | |||
| 473 | set_cpu_cap(c, X86_FEATURE_EXTD_APICID); | 471 | set_cpu_cap(c, X86_FEATURE_EXTD_APICID); |
| 474 | } | 472 | } |
| 475 | #endif | 473 | #endif |
| 476 | |||
| 477 | rdmsr_safe(MSR_AMD64_PATCH_LEVEL, &c->microcode, &dummy); | ||
| 478 | } | 474 | } |
| 479 | 475 | ||
| 480 | static void __cpuinit init_amd(struct cpuinfo_x86 *c) | 476 | static void __cpuinit init_amd(struct cpuinfo_x86 *c) |
| 481 | { | 477 | { |
| 478 | u32 dummy; | ||
| 479 | |||
| 482 | #ifdef CONFIG_SMP | 480 | #ifdef CONFIG_SMP |
| 483 | unsigned long long value; | 481 | unsigned long long value; |
| 484 | 482 | ||
| @@ -657,6 +655,8 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c) | |||
| 657 | checking_wrmsrl(MSR_AMD64_MCx_MASK(4), mask); | 655 | checking_wrmsrl(MSR_AMD64_MCx_MASK(4), mask); |
| 658 | } | 656 | } |
| 659 | } | 657 | } |
| 658 | |||
| 659 | rdmsr_safe(MSR_AMD64_PATCH_LEVEL, &c->microcode, &dummy); | ||
| 660 | } | 660 | } |
| 661 | 661 | ||
| 662 | #ifdef CONFIG_X86_32 | 662 | #ifdef CONFIG_X86_32 |
diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index a71efcdbb092..97b26356e9ee 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c | |||
| @@ -547,6 +547,7 @@ static void generic_get_mtrr(unsigned int reg, unsigned long *base, | |||
| 547 | 547 | ||
| 548 | if (tmp != mask_lo) { | 548 | if (tmp != mask_lo) { |
| 549 | printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n"); | 549 | printk(KERN_WARNING "mtrr: your BIOS has configured an incorrect mask, fixing it.\n"); |
| 550 | add_taint(TAINT_FIRMWARE_WORKAROUND); | ||
| 550 | mask_lo = tmp; | 551 | mask_lo = tmp; |
| 551 | } | 552 | } |
| 552 | } | 553 | } |
| @@ -693,6 +694,7 @@ static void prepare_set(void) __acquires(set_atomicity_lock) | |||
| 693 | 694 | ||
| 694 | /* Disable MTRRs, and set the default type to uncached */ | 695 | /* Disable MTRRs, and set the default type to uncached */ |
| 695 | mtrr_wrmsr(MSR_MTRRdefType, deftype_lo & ~0xcff, deftype_hi); | 696 | mtrr_wrmsr(MSR_MTRRdefType, deftype_lo & ~0xcff, deftype_hi); |
| 697 | wbinvd(); | ||
| 696 | } | 698 | } |
| 697 | 699 | ||
| 698 | static void post_set(void) __releases(set_atomicity_lock) | 700 | static void post_set(void) __releases(set_atomicity_lock) |
diff --git a/arch/x86/kernel/cpu/perf_event.c b/arch/x86/kernel/cpu/perf_event.c index 640891014b2a..2bda212a0010 100644 --- a/arch/x86/kernel/cpu/perf_event.c +++ b/arch/x86/kernel/cpu/perf_event.c | |||
| @@ -312,12 +312,8 @@ int x86_setup_perfctr(struct perf_event *event) | |||
| 312 | return -EOPNOTSUPP; | 312 | return -EOPNOTSUPP; |
| 313 | } | 313 | } |
| 314 | 314 | ||
| 315 | /* | ||
| 316 | * Do not allow config1 (extended registers) to propagate, | ||
| 317 | * there's no sane user-space generalization yet: | ||
| 318 | */ | ||
| 319 | if (attr->type == PERF_TYPE_RAW) | 315 | if (attr->type == PERF_TYPE_RAW) |
| 320 | return 0; | 316 | return x86_pmu_extra_regs(event->attr.config, event); |
| 321 | 317 | ||
| 322 | if (attr->type == PERF_TYPE_HW_CACHE) | 318 | if (attr->type == PERF_TYPE_HW_CACHE) |
| 323 | return set_ext_hw_attr(hwc, event); | 319 | return set_ext_hw_attr(hwc, event); |
| @@ -588,7 +584,7 @@ done: | |||
| 588 | x86_pmu.put_event_constraints(cpuc, cpuc->event_list[i]); | 584 | x86_pmu.put_event_constraints(cpuc, cpuc->event_list[i]); |
| 589 | } | 585 | } |
| 590 | } | 586 | } |
| 591 | return num ? -ENOSPC : 0; | 587 | return num ? -EINVAL : 0; |
| 592 | } | 588 | } |
| 593 | 589 | ||
| 594 | /* | 590 | /* |
| @@ -607,7 +603,7 @@ static int collect_events(struct cpu_hw_events *cpuc, struct perf_event *leader, | |||
| 607 | 603 | ||
| 608 | if (is_x86_event(leader)) { | 604 | if (is_x86_event(leader)) { |
| 609 | if (n >= max_count) | 605 | if (n >= max_count) |
| 610 | return -ENOSPC; | 606 | return -EINVAL; |
| 611 | cpuc->event_list[n] = leader; | 607 | cpuc->event_list[n] = leader; |
| 612 | n++; | 608 | n++; |
| 613 | } | 609 | } |
| @@ -620,7 +616,7 @@ static int collect_events(struct cpu_hw_events *cpuc, struct perf_event *leader, | |||
| 620 | continue; | 616 | continue; |
| 621 | 617 | ||
| 622 | if (n >= max_count) | 618 | if (n >= max_count) |
| 623 | return -ENOSPC; | 619 | return -EINVAL; |
| 624 | 620 | ||
| 625 | cpuc->event_list[n] = event; | 621 | cpuc->event_list[n] = event; |
| 626 | n++; | 622 | n++; |
| @@ -1316,7 +1312,7 @@ static int validate_event(struct perf_event *event) | |||
| 1316 | c = x86_pmu.get_event_constraints(fake_cpuc, event); | 1312 | c = x86_pmu.get_event_constraints(fake_cpuc, event); |
| 1317 | 1313 | ||
| 1318 | if (!c || !c->weight) | 1314 | if (!c || !c->weight) |
| 1319 | ret = -ENOSPC; | 1315 | ret = -EINVAL; |
| 1320 | 1316 | ||
| 1321 | if (x86_pmu.put_event_constraints) | 1317 | if (x86_pmu.put_event_constraints) |
| 1322 | x86_pmu.put_event_constraints(fake_cpuc, event); | 1318 | x86_pmu.put_event_constraints(fake_cpuc, event); |
| @@ -1341,7 +1337,7 @@ static int validate_group(struct perf_event *event) | |||
| 1341 | { | 1337 | { |
| 1342 | struct perf_event *leader = event->group_leader; | 1338 | struct perf_event *leader = event->group_leader; |
| 1343 | struct cpu_hw_events *fake_cpuc; | 1339 | struct cpu_hw_events *fake_cpuc; |
| 1344 | int ret = -ENOSPC, n; | 1340 | int ret = -EINVAL, n; |
| 1345 | 1341 | ||
| 1346 | fake_cpuc = allocate_fake_cpuc(); | 1342 | fake_cpuc = allocate_fake_cpuc(); |
| 1347 | if (IS_ERR(fake_cpuc)) | 1343 | if (IS_ERR(fake_cpuc)) |
diff --git a/arch/x86/kernel/cpu/perf_event_amd_ibs.c b/arch/x86/kernel/cpu/perf_event_amd_ibs.c index ab6343d21825..3b8a2d30d14e 100644 --- a/arch/x86/kernel/cpu/perf_event_amd_ibs.c +++ b/arch/x86/kernel/cpu/perf_event_amd_ibs.c | |||
| @@ -199,8 +199,7 @@ static int force_ibs_eilvt_setup(void) | |||
| 199 | goto out; | 199 | goto out; |
| 200 | } | 200 | } |
| 201 | 201 | ||
| 202 | pr_err(FW_BUG "using offset %d for IBS interrupts\n", offset); | 202 | pr_info("IBS: LVT offset %d assigned\n", offset); |
| 203 | pr_err(FW_BUG "workaround enabled for IBS LVT offset\n"); | ||
| 204 | 203 | ||
| 205 | return 0; | 204 | return 0; |
| 206 | out: | 205 | out: |
| @@ -265,19 +264,23 @@ perf_ibs_cpu_notifier(struct notifier_block *self, unsigned long action, void *h | |||
| 265 | static __init int amd_ibs_init(void) | 264 | static __init int amd_ibs_init(void) |
| 266 | { | 265 | { |
| 267 | u32 caps; | 266 | u32 caps; |
| 268 | int ret; | 267 | int ret = -EINVAL; |
| 269 | 268 | ||
| 270 | caps = __get_ibs_caps(); | 269 | caps = __get_ibs_caps(); |
| 271 | if (!caps) | 270 | if (!caps) |
| 272 | return -ENODEV; /* ibs not supported by the cpu */ | 271 | return -ENODEV; /* ibs not supported by the cpu */ |
| 273 | 272 | ||
| 274 | if (!ibs_eilvt_valid()) { | 273 | /* |
| 275 | ret = force_ibs_eilvt_setup(); | 274 | * Force LVT offset assignment for family 10h: The offsets are |
| 276 | if (ret) { | 275 | * not assigned by the BIOS for this family, so the OS is |
| 277 | pr_err("Failed to setup IBS, %d\n", ret); | 276 | * responsible for doing it. If the OS assignment fails, fall |
| 278 | return ret; | 277 | * back to BIOS settings and try to setup this. |
| 279 | } | 278 | */ |
| 280 | } | 279 | if (boot_cpu_data.x86 == 0x10) |
| 280 | force_ibs_eilvt_setup(); | ||
| 281 | |||
| 282 | if (!ibs_eilvt_valid()) | ||
| 283 | goto out; | ||
| 281 | 284 | ||
| 282 | get_online_cpus(); | 285 | get_online_cpus(); |
| 283 | ibs_caps = caps; | 286 | ibs_caps = caps; |
| @@ -287,7 +290,11 @@ static __init int amd_ibs_init(void) | |||
| 287 | smp_call_function(setup_APIC_ibs, NULL, 1); | 290 | smp_call_function(setup_APIC_ibs, NULL, 1); |
| 288 | put_online_cpus(); | 291 | put_online_cpus(); |
| 289 | 292 | ||
| 290 | return perf_event_ibs_init(); | 293 | ret = perf_event_ibs_init(); |
| 294 | out: | ||
| 295 | if (ret) | ||
| 296 | pr_err("Failed to setup IBS, %d\n", ret); | ||
| 297 | return ret; | ||
| 291 | } | 298 | } |
| 292 | 299 | ||
| 293 | /* Since we need the pci subsystem to init ibs we can't do this earlier: */ | 300 | /* Since we need the pci subsystem to init ibs we can't do this earlier: */ |
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c index 2be5ebe99872..8d601b18bf9f 100644 --- a/arch/x86/kernel/cpu/perf_event_intel.c +++ b/arch/x86/kernel/cpu/perf_event_intel.c | |||
| @@ -1545,6 +1545,13 @@ static void intel_clovertown_quirks(void) | |||
| 1545 | x86_pmu.pebs_constraints = NULL; | 1545 | x86_pmu.pebs_constraints = NULL; |
| 1546 | } | 1546 | } |
| 1547 | 1547 | ||
| 1548 | static void intel_sandybridge_quirks(void) | ||
| 1549 | { | ||
| 1550 | printk(KERN_WARNING "PEBS disabled due to CPU errata.\n"); | ||
| 1551 | x86_pmu.pebs = 0; | ||
| 1552 | x86_pmu.pebs_constraints = NULL; | ||
| 1553 | } | ||
| 1554 | |||
| 1548 | __init int intel_pmu_init(void) | 1555 | __init int intel_pmu_init(void) |
| 1549 | { | 1556 | { |
| 1550 | union cpuid10_edx edx; | 1557 | union cpuid10_edx edx; |
| @@ -1694,6 +1701,7 @@ __init int intel_pmu_init(void) | |||
| 1694 | break; | 1701 | break; |
| 1695 | 1702 | ||
| 1696 | case 42: /* SandyBridge */ | 1703 | case 42: /* SandyBridge */ |
| 1704 | x86_pmu.quirks = intel_sandybridge_quirks; | ||
| 1697 | case 45: /* SandyBridge, "Romely-EP" */ | 1705 | case 45: /* SandyBridge, "Romely-EP" */ |
| 1698 | memcpy(hw_cache_event_ids, snb_hw_cache_event_ids, | 1706 | memcpy(hw_cache_event_ids, snb_hw_cache_event_ids, |
| 1699 | sizeof(hw_cache_event_ids)); | 1707 | sizeof(hw_cache_event_ids)); |
diff --git a/arch/x86/kernel/cpu/perf_event_intel_ds.c b/arch/x86/kernel/cpu/perf_event_intel_ds.c index c0d238f49db8..73da6b64f5b7 100644 --- a/arch/x86/kernel/cpu/perf_event_intel_ds.c +++ b/arch/x86/kernel/cpu/perf_event_intel_ds.c | |||
| @@ -493,6 +493,7 @@ static int intel_pmu_pebs_fixup_ip(struct pt_regs *regs) | |||
| 493 | unsigned long from = cpuc->lbr_entries[0].from; | 493 | unsigned long from = cpuc->lbr_entries[0].from; |
| 494 | unsigned long old_to, to = cpuc->lbr_entries[0].to; | 494 | unsigned long old_to, to = cpuc->lbr_entries[0].to; |
| 495 | unsigned long ip = regs->ip; | 495 | unsigned long ip = regs->ip; |
| 496 | int is_64bit = 0; | ||
| 496 | 497 | ||
| 497 | /* | 498 | /* |
| 498 | * We don't need to fixup if the PEBS assist is fault like | 499 | * We don't need to fixup if the PEBS assist is fault like |
| @@ -544,7 +545,10 @@ static int intel_pmu_pebs_fixup_ip(struct pt_regs *regs) | |||
| 544 | } else | 545 | } else |
| 545 | kaddr = (void *)to; | 546 | kaddr = (void *)to; |
| 546 | 547 | ||
| 547 | kernel_insn_init(&insn, kaddr); | 548 | #ifdef CONFIG_X86_64 |
| 549 | is_64bit = kernel_ip(to) || !test_thread_flag(TIF_IA32); | ||
| 550 | #endif | ||
| 551 | insn_init(&insn, kaddr, is_64bit); | ||
| 548 | insn_get_length(&insn); | 552 | insn_get_length(&insn); |
| 549 | to += insn.length; | 553 | to += insn.length; |
| 550 | } while (to < ip); | 554 | } while (to < ip); |
diff --git a/arch/x86/kernel/cpu/perf_event_p4.c b/arch/x86/kernel/cpu/perf_event_p4.c index 492bf1358a7c..ef484d9d0a25 100644 --- a/arch/x86/kernel/cpu/perf_event_p4.c +++ b/arch/x86/kernel/cpu/perf_event_p4.c | |||
| @@ -1268,7 +1268,7 @@ reserve: | |||
| 1268 | } | 1268 | } |
| 1269 | 1269 | ||
| 1270 | done: | 1270 | done: |
| 1271 | return num ? -ENOSPC : 0; | 1271 | return num ? -EINVAL : 0; |
| 1272 | } | 1272 | } |
| 1273 | 1273 | ||
| 1274 | static __initconst const struct x86_pmu p4_pmu = { | 1274 | static __initconst const struct x86_pmu p4_pmu = { |
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c index b946a9eac7d9..1bb0bf4d92cd 100644 --- a/arch/x86/kernel/hpet.c +++ b/arch/x86/kernel/hpet.c | |||
| @@ -1049,6 +1049,14 @@ int hpet_rtc_timer_init(void) | |||
| 1049 | } | 1049 | } |
| 1050 | EXPORT_SYMBOL_GPL(hpet_rtc_timer_init); | 1050 | EXPORT_SYMBOL_GPL(hpet_rtc_timer_init); |
| 1051 | 1051 | ||
| 1052 | static void hpet_disable_rtc_channel(void) | ||
| 1053 | { | ||
| 1054 | unsigned long cfg; | ||
| 1055 | cfg = hpet_readl(HPET_T1_CFG); | ||
| 1056 | cfg &= ~HPET_TN_ENABLE; | ||
| 1057 | hpet_writel(cfg, HPET_T1_CFG); | ||
| 1058 | } | ||
| 1059 | |||
| 1052 | /* | 1060 | /* |
| 1053 | * The functions below are called from rtc driver. | 1061 | * The functions below are called from rtc driver. |
| 1054 | * Return 0 if HPET is not being used. | 1062 | * Return 0 if HPET is not being used. |
| @@ -1060,6 +1068,9 @@ int hpet_mask_rtc_irq_bit(unsigned long bit_mask) | |||
| 1060 | return 0; | 1068 | return 0; |
| 1061 | 1069 | ||
| 1062 | hpet_rtc_flags &= ~bit_mask; | 1070 | hpet_rtc_flags &= ~bit_mask; |
| 1071 | if (unlikely(!hpet_rtc_flags)) | ||
| 1072 | hpet_disable_rtc_channel(); | ||
| 1073 | |||
| 1063 | return 1; | 1074 | return 1; |
| 1064 | } | 1075 | } |
| 1065 | EXPORT_SYMBOL_GPL(hpet_mask_rtc_irq_bit); | 1076 | EXPORT_SYMBOL_GPL(hpet_mask_rtc_irq_bit); |
| @@ -1125,15 +1136,11 @@ EXPORT_SYMBOL_GPL(hpet_rtc_dropped_irq); | |||
| 1125 | 1136 | ||
| 1126 | static void hpet_rtc_timer_reinit(void) | 1137 | static void hpet_rtc_timer_reinit(void) |
| 1127 | { | 1138 | { |
| 1128 | unsigned int cfg, delta; | 1139 | unsigned int delta; |
| 1129 | int lost_ints = -1; | 1140 | int lost_ints = -1; |
| 1130 | 1141 | ||
| 1131 | if (unlikely(!hpet_rtc_flags)) { | 1142 | if (unlikely(!hpet_rtc_flags)) |
| 1132 | cfg = hpet_readl(HPET_T1_CFG); | 1143 | hpet_disable_rtc_channel(); |
| 1133 | cfg &= ~HPET_TN_ENABLE; | ||
| 1134 | hpet_writel(cfg, HPET_T1_CFG); | ||
| 1135 | return; | ||
| 1136 | } | ||
| 1137 | 1144 | ||
| 1138 | if (!(hpet_rtc_flags & RTC_PIE) || hpet_pie_limit) | 1145 | if (!(hpet_rtc_flags & RTC_PIE) || hpet_pie_limit) |
| 1139 | delta = hpet_default_delta; | 1146 | delta = hpet_default_delta; |
diff --git a/arch/x86/kernel/irq_64.c b/arch/x86/kernel/irq_64.c index acf8fbf8fbda..69bca468c47a 100644 --- a/arch/x86/kernel/irq_64.c +++ b/arch/x86/kernel/irq_64.c | |||
| @@ -38,6 +38,9 @@ static inline void stack_overflow_check(struct pt_regs *regs) | |||
| 38 | #ifdef CONFIG_DEBUG_STACKOVERFLOW | 38 | #ifdef CONFIG_DEBUG_STACKOVERFLOW |
| 39 | u64 curbase = (u64)task_stack_page(current); | 39 | u64 curbase = (u64)task_stack_page(current); |
| 40 | 40 | ||
| 41 | if (user_mode_vm(regs)) | ||
| 42 | return; | ||
| 43 | |||
| 41 | WARN_ONCE(regs->sp >= curbase && | 44 | WARN_ONCE(regs->sp >= curbase && |
| 42 | regs->sp <= curbase + THREAD_SIZE && | 45 | regs->sp <= curbase + THREAD_SIZE && |
| 43 | regs->sp < curbase + sizeof(struct thread_info) + | 46 | regs->sp < curbase + sizeof(struct thread_info) + |
diff --git a/arch/x86/kernel/microcode_core.c b/arch/x86/kernel/microcode_core.c index f2d2a664e797..9d46f5e43b51 100644 --- a/arch/x86/kernel/microcode_core.c +++ b/arch/x86/kernel/microcode_core.c | |||
| @@ -256,7 +256,7 @@ static int __init microcode_dev_init(void) | |||
| 256 | return 0; | 256 | return 0; |
| 257 | } | 257 | } |
| 258 | 258 | ||
| 259 | static void microcode_dev_exit(void) | 259 | static void __exit microcode_dev_exit(void) |
| 260 | { | 260 | { |
| 261 | misc_deregister(µcode_dev); | 261 | misc_deregister(µcode_dev); |
| 262 | } | 262 | } |
| @@ -519,10 +519,8 @@ static int __init microcode_init(void) | |||
| 519 | 519 | ||
| 520 | microcode_pdev = platform_device_register_simple("microcode", -1, | 520 | microcode_pdev = platform_device_register_simple("microcode", -1, |
| 521 | NULL, 0); | 521 | NULL, 0); |
| 522 | if (IS_ERR(microcode_pdev)) { | 522 | if (IS_ERR(microcode_pdev)) |
| 523 | microcode_dev_exit(); | ||
| 524 | return PTR_ERR(microcode_pdev); | 523 | return PTR_ERR(microcode_pdev); |
| 525 | } | ||
| 526 | 524 | ||
| 527 | get_online_cpus(); | 525 | get_online_cpus(); |
| 528 | mutex_lock(µcode_mutex); | 526 | mutex_lock(µcode_mutex); |
| @@ -532,14 +530,12 @@ static int __init microcode_init(void) | |||
| 532 | mutex_unlock(µcode_mutex); | 530 | mutex_unlock(µcode_mutex); |
| 533 | put_online_cpus(); | 531 | put_online_cpus(); |
| 534 | 532 | ||
| 535 | if (error) { | 533 | if (error) |
| 536 | platform_device_unregister(microcode_pdev); | 534 | goto out_pdev; |
| 537 | return error; | ||
| 538 | } | ||
| 539 | 535 | ||
| 540 | error = microcode_dev_init(); | 536 | error = microcode_dev_init(); |
| 541 | if (error) | 537 | if (error) |
| 542 | return error; | 538 | goto out_sysdev_driver; |
| 543 | 539 | ||
| 544 | register_syscore_ops(&mc_syscore_ops); | 540 | register_syscore_ops(&mc_syscore_ops); |
| 545 | register_hotcpu_notifier(&mc_cpu_notifier); | 541 | register_hotcpu_notifier(&mc_cpu_notifier); |
| @@ -548,6 +544,20 @@ static int __init microcode_init(void) | |||
| 548 | " <tigran@aivazian.fsnet.co.uk>, Peter Oruba\n"); | 544 | " <tigran@aivazian.fsnet.co.uk>, Peter Oruba\n"); |
| 549 | 545 | ||
| 550 | return 0; | 546 | return 0; |
| 547 | |||
| 548 | out_sysdev_driver: | ||
| 549 | get_online_cpus(); | ||
| 550 | mutex_lock(µcode_mutex); | ||
| 551 | |||
| 552 | sysdev_driver_unregister(&cpu_sysdev_class, &mc_sysdev_driver); | ||
| 553 | |||
| 554 | mutex_unlock(µcode_mutex); | ||
| 555 | put_online_cpus(); | ||
| 556 | |||
| 557 | out_pdev: | ||
| 558 | platform_device_unregister(microcode_pdev); | ||
| 559 | return error; | ||
| 560 | |||
| 551 | } | 561 | } |
| 552 | module_init(microcode_init); | 562 | module_init(microcode_init); |
| 553 | 563 | ||
diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c index 9103b89c145a..0741b062a304 100644 --- a/arch/x86/kernel/mpparse.c +++ b/arch/x86/kernel/mpparse.c | |||
| @@ -95,8 +95,8 @@ static void __init MP_bus_info(struct mpc_bus *m) | |||
| 95 | } | 95 | } |
| 96 | #endif | 96 | #endif |
| 97 | 97 | ||
| 98 | set_bit(m->busid, mp_bus_not_pci); | ||
| 98 | if (strncmp(str, BUSTYPE_ISA, sizeof(BUSTYPE_ISA) - 1) == 0) { | 99 | if (strncmp(str, BUSTYPE_ISA, sizeof(BUSTYPE_ISA) - 1) == 0) { |
| 99 | set_bit(m->busid, mp_bus_not_pci); | ||
| 100 | #if defined(CONFIG_EISA) || defined(CONFIG_MCA) | 100 | #if defined(CONFIG_EISA) || defined(CONFIG_MCA) |
| 101 | mp_bus_id_to_type[m->busid] = MP_BUS_ISA; | 101 | mp_bus_id_to_type[m->busid] = MP_BUS_ISA; |
| 102 | #endif | 102 | #endif |
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index b9b3b1a51643..ee5d4fbd53b4 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c | |||
| @@ -403,6 +403,14 @@ void default_idle(void) | |||
| 403 | EXPORT_SYMBOL(default_idle); | 403 | EXPORT_SYMBOL(default_idle); |
| 404 | #endif | 404 | #endif |
| 405 | 405 | ||
| 406 | bool set_pm_idle_to_default(void) | ||
| 407 | { | ||
| 408 | bool ret = !!pm_idle; | ||
| 409 | |||
| 410 | pm_idle = default_idle; | ||
| 411 | |||
| 412 | return ret; | ||
| 413 | } | ||
| 406 | void stop_this_cpu(void *dummy) | 414 | void stop_this_cpu(void *dummy) |
| 407 | { | 415 | { |
| 408 | local_irq_disable(); | 416 | local_irq_disable(); |
diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c index b78643d0f9a5..03920a15a632 100644 --- a/arch/x86/kernel/quirks.c +++ b/arch/x86/kernel/quirks.c | |||
| @@ -553,4 +553,17 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_10H_NB_MISC, | |||
| 553 | quirk_amd_nb_node); | 553 | quirk_amd_nb_node); |
| 554 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_10H_NB_LINK, | 554 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_10H_NB_LINK, |
| 555 | quirk_amd_nb_node); | 555 | quirk_amd_nb_node); |
| 556 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F0, | ||
| 557 | quirk_amd_nb_node); | ||
| 558 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F1, | ||
| 559 | quirk_amd_nb_node); | ||
| 560 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F2, | ||
| 561 | quirk_amd_nb_node); | ||
| 562 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F3, | ||
| 563 | quirk_amd_nb_node); | ||
| 564 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F4, | ||
| 565 | quirk_amd_nb_node); | ||
| 566 | DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_15H_NB_F5, | ||
| 567 | quirk_amd_nb_node); | ||
| 568 | |||
| 556 | #endif | 569 | #endif |
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index e334be1182b9..37a458b521a6 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c | |||
| @@ -124,7 +124,7 @@ __setup("reboot=", reboot_setup); | |||
| 124 | */ | 124 | */ |
| 125 | 125 | ||
| 126 | /* | 126 | /* |
| 127 | * Some machines require the "reboot=b" commandline option, | 127 | * Some machines require the "reboot=b" or "reboot=k" commandline options, |
| 128 | * this quirk makes that automatic. | 128 | * this quirk makes that automatic. |
| 129 | */ | 129 | */ |
| 130 | static int __init set_bios_reboot(const struct dmi_system_id *d) | 130 | static int __init set_bios_reboot(const struct dmi_system_id *d) |
| @@ -136,6 +136,15 @@ static int __init set_bios_reboot(const struct dmi_system_id *d) | |||
| 136 | return 0; | 136 | return 0; |
| 137 | } | 137 | } |
| 138 | 138 | ||
| 139 | static int __init set_kbd_reboot(const struct dmi_system_id *d) | ||
| 140 | { | ||
| 141 | if (reboot_type != BOOT_KBD) { | ||
| 142 | reboot_type = BOOT_KBD; | ||
| 143 | printk(KERN_INFO "%s series board detected. Selecting KBD-method for reboot.\n", d->ident); | ||
| 144 | } | ||
| 145 | return 0; | ||
| 146 | } | ||
| 147 | |||
| 139 | static struct dmi_system_id __initdata reboot_dmi_table[] = { | 148 | static struct dmi_system_id __initdata reboot_dmi_table[] = { |
| 140 | { /* Handle problems with rebooting on Dell E520's */ | 149 | { /* Handle problems with rebooting on Dell E520's */ |
| 141 | .callback = set_bios_reboot, | 150 | .callback = set_bios_reboot, |
| @@ -295,7 +304,7 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = { | |||
| 295 | }, | 304 | }, |
| 296 | }, | 305 | }, |
| 297 | { /* Handle reboot issue on Acer Aspire one */ | 306 | { /* Handle reboot issue on Acer Aspire one */ |
| 298 | .callback = set_bios_reboot, | 307 | .callback = set_kbd_reboot, |
| 299 | .ident = "Acer Aspire One A110", | 308 | .ident = "Acer Aspire One A110", |
| 300 | .matches = { | 309 | .matches = { |
| 301 | DMI_MATCH(DMI_SYS_VENDOR, "Acer"), | 310 | DMI_MATCH(DMI_SYS_VENDOR, "Acer"), |
| @@ -443,6 +452,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { | |||
| 443 | DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6420"), | 452 | DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6420"), |
| 444 | }, | 453 | }, |
| 445 | }, | 454 | }, |
| 455 | { /* Handle problems with rebooting on the OptiPlex 990. */ | ||
| 456 | .callback = set_pci_reboot, | ||
| 457 | .ident = "Dell OptiPlex 990", | ||
| 458 | .matches = { | ||
| 459 | DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), | ||
| 460 | DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 990"), | ||
| 461 | }, | ||
| 462 | }, | ||
| 446 | { } | 463 | { } |
| 447 | }; | 464 | }; |
| 448 | 465 | ||
diff --git a/arch/x86/kernel/rtc.c b/arch/x86/kernel/rtc.c index 348ce016a835..af6db6ec5b2a 100644 --- a/arch/x86/kernel/rtc.c +++ b/arch/x86/kernel/rtc.c | |||
| @@ -12,6 +12,7 @@ | |||
| 12 | #include <asm/vsyscall.h> | 12 | #include <asm/vsyscall.h> |
| 13 | #include <asm/x86_init.h> | 13 | #include <asm/x86_init.h> |
| 14 | #include <asm/time.h> | 14 | #include <asm/time.h> |
| 15 | #include <asm/mrst.h> | ||
| 15 | 16 | ||
| 16 | #ifdef CONFIG_X86_32 | 17 | #ifdef CONFIG_X86_32 |
| 17 | /* | 18 | /* |
| @@ -242,6 +243,10 @@ static __init int add_rtc_cmos(void) | |||
| 242 | if (of_have_populated_dt()) | 243 | if (of_have_populated_dt()) |
| 243 | return 0; | 244 | return 0; |
| 244 | 245 | ||
| 246 | /* Intel MID platforms don't have ioport rtc */ | ||
| 247 | if (mrst_identify_cpu()) | ||
| 248 | return -ENODEV; | ||
| 249 | |||
| 245 | platform_device_register(&rtc_device); | 250 | platform_device_register(&rtc_device); |
| 246 | dev_info(&rtc_device.dev, | 251 | dev_info(&rtc_device.dev, |
| 247 | "registered platform RTC device (no PNP device found)\n"); | 252 | "registered platform RTC device (no PNP device found)\n"); |
diff --git a/arch/x86/mm/gup.c b/arch/x86/mm/gup.c index ea305856151c..dd74e46828c0 100644 --- a/arch/x86/mm/gup.c +++ b/arch/x86/mm/gup.c | |||
| @@ -201,6 +201,8 @@ static noinline int gup_huge_pud(pud_t pud, unsigned long addr, | |||
| 201 | do { | 201 | do { |
| 202 | VM_BUG_ON(compound_head(page) != head); | 202 | VM_BUG_ON(compound_head(page) != head); |
| 203 | pages[*nr] = page; | 203 | pages[*nr] = page; |
| 204 | if (PageTail(page)) | ||
| 205 | get_huge_page_tail(page); | ||
| 204 | (*nr)++; | 206 | (*nr)++; |
| 205 | page++; | 207 | page++; |
| 206 | refs++; | 208 | refs++; |
diff --git a/arch/x86/mm/highmem_32.c b/arch/x86/mm/highmem_32.c index b49962662101..f4f29b19fac5 100644 --- a/arch/x86/mm/highmem_32.c +++ b/arch/x86/mm/highmem_32.c | |||
| @@ -45,6 +45,7 @@ void *kmap_atomic_prot(struct page *page, pgprot_t prot) | |||
| 45 | vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); | 45 | vaddr = __fix_to_virt(FIX_KMAP_BEGIN + idx); |
| 46 | BUG_ON(!pte_none(*(kmap_pte-idx))); | 46 | BUG_ON(!pte_none(*(kmap_pte-idx))); |
| 47 | set_pte(kmap_pte-idx, mk_pte(page, prot)); | 47 | set_pte(kmap_pte-idx, mk_pte(page, prot)); |
| 48 | arch_flush_lazy_mmu_mode(); | ||
| 48 | 49 | ||
| 49 | return (void *)vaddr; | 50 | return (void *)vaddr; |
| 50 | } | 51 | } |
| @@ -88,6 +89,7 @@ void __kunmap_atomic(void *kvaddr) | |||
| 88 | */ | 89 | */ |
| 89 | kpte_clear_flush(kmap_pte-idx, vaddr); | 90 | kpte_clear_flush(kmap_pte-idx, vaddr); |
| 90 | kmap_atomic_idx_pop(); | 91 | kmap_atomic_idx_pop(); |
| 92 | arch_flush_lazy_mmu_mode(); | ||
| 91 | } | 93 | } |
| 92 | #ifdef CONFIG_DEBUG_HIGHMEM | 94 | #ifdef CONFIG_DEBUG_HIGHMEM |
| 93 | else { | 95 | else { |
diff --git a/arch/x86/oprofile/init.c b/arch/x86/oprofile/init.c index cdfe4c54deca..f148cf652678 100644 --- a/arch/x86/oprofile/init.c +++ b/arch/x86/oprofile/init.c | |||
| @@ -21,6 +21,7 @@ extern int op_nmi_timer_init(struct oprofile_operations *ops); | |||
| 21 | extern void op_nmi_exit(void); | 21 | extern void op_nmi_exit(void); |
| 22 | extern void x86_backtrace(struct pt_regs * const regs, unsigned int depth); | 22 | extern void x86_backtrace(struct pt_regs * const regs, unsigned int depth); |
| 23 | 23 | ||
| 24 | static int nmi_timer; | ||
| 24 | 25 | ||
| 25 | int __init oprofile_arch_init(struct oprofile_operations *ops) | 26 | int __init oprofile_arch_init(struct oprofile_operations *ops) |
| 26 | { | 27 | { |
| @@ -31,8 +32,9 @@ int __init oprofile_arch_init(struct oprofile_operations *ops) | |||
| 31 | #ifdef CONFIG_X86_LOCAL_APIC | 32 | #ifdef CONFIG_X86_LOCAL_APIC |
| 32 | ret = op_nmi_init(ops); | 33 | ret = op_nmi_init(ops); |
| 33 | #endif | 34 | #endif |
| 35 | nmi_timer = (ret != 0); | ||
| 34 | #ifdef CONFIG_X86_IO_APIC | 36 | #ifdef CONFIG_X86_IO_APIC |
| 35 | if (ret < 0) | 37 | if (nmi_timer) |
| 36 | ret = op_nmi_timer_init(ops); | 38 | ret = op_nmi_timer_init(ops); |
| 37 | #endif | 39 | #endif |
| 38 | ops->backtrace = x86_backtrace; | 40 | ops->backtrace = x86_backtrace; |
| @@ -44,6 +46,7 @@ int __init oprofile_arch_init(struct oprofile_operations *ops) | |||
| 44 | void oprofile_arch_exit(void) | 46 | void oprofile_arch_exit(void) |
| 45 | { | 47 | { |
| 46 | #ifdef CONFIG_X86_LOCAL_APIC | 48 | #ifdef CONFIG_X86_LOCAL_APIC |
| 47 | op_nmi_exit(); | 49 | if (!nmi_timer) |
| 50 | op_nmi_exit(); | ||
| 48 | #endif | 51 | #endif |
| 49 | } | 52 | } |
diff --git a/arch/x86/platform/efi/efi_32.c b/arch/x86/platform/efi/efi_32.c index e36bf714cb77..40e446941dd7 100644 --- a/arch/x86/platform/efi/efi_32.c +++ b/arch/x86/platform/efi/efi_32.c | |||
| @@ -39,43 +39,14 @@ | |||
| 39 | */ | 39 | */ |
| 40 | 40 | ||
| 41 | static unsigned long efi_rt_eflags; | 41 | static unsigned long efi_rt_eflags; |
| 42 | static pgd_t efi_bak_pg_dir_pointer[2]; | ||
| 43 | 42 | ||
| 44 | void efi_call_phys_prelog(void) | 43 | void efi_call_phys_prelog(void) |
| 45 | { | 44 | { |
| 46 | unsigned long cr4; | ||
| 47 | unsigned long temp; | ||
| 48 | struct desc_ptr gdt_descr; | 45 | struct desc_ptr gdt_descr; |
| 49 | 46 | ||
| 50 | local_irq_save(efi_rt_eflags); | 47 | local_irq_save(efi_rt_eflags); |
| 51 | 48 | ||
| 52 | /* | 49 | load_cr3(initial_page_table); |
| 53 | * If I don't have PAE, I should just duplicate two entries in page | ||
| 54 | * directory. If I have PAE, I just need to duplicate one entry in | ||
| 55 | * page directory. | ||
| 56 | */ | ||
| 57 | cr4 = read_cr4_safe(); | ||
| 58 | |||
| 59 | if (cr4 & X86_CR4_PAE) { | ||
| 60 | efi_bak_pg_dir_pointer[0].pgd = | ||
| 61 | swapper_pg_dir[pgd_index(0)].pgd; | ||
| 62 | swapper_pg_dir[0].pgd = | ||
| 63 | swapper_pg_dir[pgd_index(PAGE_OFFSET)].pgd; | ||
| 64 | } else { | ||
| 65 | efi_bak_pg_dir_pointer[0].pgd = | ||
| 66 | swapper_pg_dir[pgd_index(0)].pgd; | ||
| 67 | efi_bak_pg_dir_pointer[1].pgd = | ||
| 68 | swapper_pg_dir[pgd_index(0x400000)].pgd; | ||
| 69 | swapper_pg_dir[pgd_index(0)].pgd = | ||
| 70 | swapper_pg_dir[pgd_index(PAGE_OFFSET)].pgd; | ||
| 71 | temp = PAGE_OFFSET + 0x400000; | ||
| 72 | swapper_pg_dir[pgd_index(0x400000)].pgd = | ||
| 73 | swapper_pg_dir[pgd_index(temp)].pgd; | ||
| 74 | } | ||
| 75 | |||
| 76 | /* | ||
| 77 | * After the lock is released, the original page table is restored. | ||
| 78 | */ | ||
| 79 | __flush_tlb_all(); | 50 | __flush_tlb_all(); |
| 80 | 51 | ||
| 81 | gdt_descr.address = __pa(get_cpu_gdt_table(0)); | 52 | gdt_descr.address = __pa(get_cpu_gdt_table(0)); |
| @@ -85,28 +56,13 @@ void efi_call_phys_prelog(void) | |||
| 85 | 56 | ||
| 86 | void efi_call_phys_epilog(void) | 57 | void efi_call_phys_epilog(void) |
| 87 | { | 58 | { |
| 88 | unsigned long cr4; | ||
| 89 | struct desc_ptr gdt_descr; | 59 | struct desc_ptr gdt_descr; |
| 90 | 60 | ||
| 91 | gdt_descr.address = (unsigned long)get_cpu_gdt_table(0); | 61 | gdt_descr.address = (unsigned long)get_cpu_gdt_table(0); |
| 92 | gdt_descr.size = GDT_SIZE - 1; | 62 | gdt_descr.size = GDT_SIZE - 1; |
| 93 | load_gdt(&gdt_descr); | 63 | load_gdt(&gdt_descr); |
| 94 | 64 | ||
| 95 | cr4 = read_cr4_safe(); | 65 | load_cr3(swapper_pg_dir); |
| 96 | |||
| 97 | if (cr4 & X86_CR4_PAE) { | ||
| 98 | swapper_pg_dir[pgd_index(0)].pgd = | ||
| 99 | efi_bak_pg_dir_pointer[0].pgd; | ||
| 100 | } else { | ||
| 101 | swapper_pg_dir[pgd_index(0)].pgd = | ||
| 102 | efi_bak_pg_dir_pointer[0].pgd; | ||
| 103 | swapper_pg_dir[pgd_index(0x400000)].pgd = | ||
| 104 | efi_bak_pg_dir_pointer[1].pgd; | ||
| 105 | } | ||
| 106 | |||
| 107 | /* | ||
| 108 | * After the lock is released, the original page table is restored. | ||
| 109 | */ | ||
| 110 | __flush_tlb_all(); | 66 | __flush_tlb_all(); |
| 111 | 67 | ||
| 112 | local_irq_restore(efi_rt_eflags); | 68 | local_irq_restore(efi_rt_eflags); |
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c index b1489a06a49d..ad4ec1cb097e 100644 --- a/arch/x86/platform/mrst/mrst.c +++ b/arch/x86/platform/mrst/mrst.c | |||
| @@ -76,6 +76,20 @@ struct sfi_rtc_table_entry sfi_mrtc_array[SFI_MRTC_MAX]; | |||
| 76 | EXPORT_SYMBOL_GPL(sfi_mrtc_array); | 76 | EXPORT_SYMBOL_GPL(sfi_mrtc_array); |
| 77 | int sfi_mrtc_num; | 77 | int sfi_mrtc_num; |
| 78 | 78 | ||
| 79 | static void mrst_power_off(void) | ||
| 80 | { | ||
| 81 | if (__mrst_cpu_chip == MRST_CPU_CHIP_LINCROFT) | ||
| 82 | intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 1); | ||
| 83 | } | ||
| 84 | |||
| 85 | static void mrst_reboot(void) | ||
| 86 | { | ||
| 87 | if (__mrst_cpu_chip == MRST_CPU_CHIP_LINCROFT) | ||
| 88 | intel_scu_ipc_simple_command(IPCMSG_COLD_RESET, 0); | ||
| 89 | else | ||
| 90 | intel_scu_ipc_simple_command(IPCMSG_COLD_BOOT, 0); | ||
| 91 | } | ||
| 92 | |||
| 79 | /* parse all the mtimer info to a static mtimer array */ | 93 | /* parse all the mtimer info to a static mtimer array */ |
| 80 | static int __init sfi_parse_mtmr(struct sfi_table_header *table) | 94 | static int __init sfi_parse_mtmr(struct sfi_table_header *table) |
| 81 | { | 95 | { |
| @@ -265,17 +279,6 @@ static int mrst_i8042_detect(void) | |||
| 265 | return 0; | 279 | return 0; |
| 266 | } | 280 | } |
| 267 | 281 | ||
| 268 | /* Reboot and power off are handled by the SCU on a MID device */ | ||
| 269 | static void mrst_power_off(void) | ||
| 270 | { | ||
| 271 | intel_scu_ipc_simple_command(0xf1, 1); | ||
| 272 | } | ||
| 273 | |||
| 274 | static void mrst_reboot(void) | ||
| 275 | { | ||
| 276 | intel_scu_ipc_simple_command(0xf1, 0); | ||
| 277 | } | ||
| 278 | |||
| 279 | /* | 282 | /* |
| 280 | * Moorestown does not have external NMI source nor port 0x61 to report | 283 | * Moorestown does not have external NMI source nor port 0x61 to report |
| 281 | * NMI status. The possible NMI sources are from pmu as a result of NMI | 284 | * NMI status. The possible NMI sources are from pmu as a result of NMI |
| @@ -484,6 +487,46 @@ static void __init *max7315_platform_data(void *info) | |||
| 484 | return max7315; | 487 | return max7315; |
| 485 | } | 488 | } |
| 486 | 489 | ||
| 490 | static void *tca6416_platform_data(void *info) | ||
| 491 | { | ||
| 492 | static struct pca953x_platform_data tca6416; | ||
| 493 | struct i2c_board_info *i2c_info = info; | ||
| 494 | int gpio_base, intr; | ||
| 495 | char base_pin_name[SFI_NAME_LEN + 1]; | ||
| 496 | char intr_pin_name[SFI_NAME_LEN + 1]; | ||
| 497 | |||
| 498 | strcpy(i2c_info->type, "tca6416"); | ||
| 499 | strcpy(base_pin_name, "tca6416_base"); | ||
| 500 | strcpy(intr_pin_name, "tca6416_int"); | ||
| 501 | |||
| 502 | gpio_base = get_gpio_by_name(base_pin_name); | ||
| 503 | intr = get_gpio_by_name(intr_pin_name); | ||
| 504 | |||
| 505 | if (gpio_base == -1) | ||
| 506 | return NULL; | ||
| 507 | tca6416.gpio_base = gpio_base; | ||
| 508 | if (intr != -1) { | ||
| 509 | i2c_info->irq = intr + MRST_IRQ_OFFSET; | ||
| 510 | tca6416.irq_base = gpio_base + MRST_IRQ_OFFSET; | ||
| 511 | } else { | ||
| 512 | i2c_info->irq = -1; | ||
| 513 | tca6416.irq_base = -1; | ||
| 514 | } | ||
| 515 | return &tca6416; | ||
| 516 | } | ||
| 517 | |||
| 518 | static void *mpu3050_platform_data(void *info) | ||
| 519 | { | ||
| 520 | struct i2c_board_info *i2c_info = info; | ||
| 521 | int intr = get_gpio_by_name("mpu3050_int"); | ||
| 522 | |||
| 523 | if (intr == -1) | ||
| 524 | return NULL; | ||
| 525 | |||
| 526 | i2c_info->irq = intr + MRST_IRQ_OFFSET; | ||
| 527 | return NULL; | ||
| 528 | } | ||
| 529 | |||
| 487 | static void __init *emc1403_platform_data(void *info) | 530 | static void __init *emc1403_platform_data(void *info) |
| 488 | { | 531 | { |
| 489 | static short intr2nd_pdata; | 532 | static short intr2nd_pdata; |
| @@ -646,12 +689,15 @@ static void *msic_ocd_platform_data(void *info) | |||
| 646 | static const struct devs_id __initconst device_ids[] = { | 689 | static const struct devs_id __initconst device_ids[] = { |
| 647 | {"bma023", SFI_DEV_TYPE_I2C, 1, &no_platform_data}, | 690 | {"bma023", SFI_DEV_TYPE_I2C, 1, &no_platform_data}, |
| 648 | {"pmic_gpio", SFI_DEV_TYPE_SPI, 1, &pmic_gpio_platform_data}, | 691 | {"pmic_gpio", SFI_DEV_TYPE_SPI, 1, &pmic_gpio_platform_data}, |
| 692 | {"pmic_gpio", SFI_DEV_TYPE_IPC, 1, &pmic_gpio_platform_data}, | ||
| 649 | {"spi_max3111", SFI_DEV_TYPE_SPI, 0, &max3111_platform_data}, | 693 | {"spi_max3111", SFI_DEV_TYPE_SPI, 0, &max3111_platform_data}, |
| 650 | {"i2c_max7315", SFI_DEV_TYPE_I2C, 1, &max7315_platform_data}, | 694 | {"i2c_max7315", SFI_DEV_TYPE_I2C, 1, &max7315_platform_data}, |
| 651 | {"i2c_max7315_2", SFI_DEV_TYPE_I2C, 1, &max7315_platform_data}, | 695 | {"i2c_max7315_2", SFI_DEV_TYPE_I2C, 1, &max7315_platform_data}, |
| 696 | {"tca6416", SFI_DEV_TYPE_I2C, 1, &tca6416_platform_data}, | ||
| 652 | {"emc1403", SFI_DEV_TYPE_I2C, 1, &emc1403_platform_data}, | 697 | {"emc1403", SFI_DEV_TYPE_I2C, 1, &emc1403_platform_data}, |
| 653 | {"i2c_accel", SFI_DEV_TYPE_I2C, 0, &lis331dl_platform_data}, | 698 | {"i2c_accel", SFI_DEV_TYPE_I2C, 0, &lis331dl_platform_data}, |
| 654 | {"pmic_audio", SFI_DEV_TYPE_IPC, 1, &no_platform_data}, | 699 | {"pmic_audio", SFI_DEV_TYPE_IPC, 1, &no_platform_data}, |
| 700 | {"mpu3050", SFI_DEV_TYPE_I2C, 1, &mpu3050_platform_data}, | ||
| 655 | 701 | ||
| 656 | /* MSIC subdevices */ | 702 | /* MSIC subdevices */ |
| 657 | {"msic_battery", SFI_DEV_TYPE_IPC, 1, &msic_battery_platform_data}, | 703 | {"msic_battery", SFI_DEV_TYPE_IPC, 1, &msic_battery_platform_data}, |
diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 38d0af4fefec..b2c7179fa263 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c | |||
| @@ -173,9 +173,21 @@ static unsigned long __init xen_get_max_pages(void) | |||
| 173 | domid_t domid = DOMID_SELF; | 173 | domid_t domid = DOMID_SELF; |
| 174 | int ret; | 174 | int ret; |
| 175 | 175 | ||
| 176 | ret = HYPERVISOR_memory_op(XENMEM_maximum_reservation, &domid); | 176 | /* |
| 177 | if (ret > 0) | 177 | * For the initial domain we use the maximum reservation as |
| 178 | max_pages = ret; | 178 | * the maximum page. |
| 179 | * | ||
| 180 | * For guest domains the current maximum reservation reflects | ||
| 181 | * the current maximum rather than the static maximum. In this | ||
| 182 | * case the e820 map provided to us will cover the static | ||
| 183 | * maximum region. | ||
| 184 | */ | ||
| 185 | if (xen_initial_domain()) { | ||
| 186 | ret = HYPERVISOR_memory_op(XENMEM_maximum_reservation, &domid); | ||
| 187 | if (ret > 0) | ||
| 188 | max_pages = ret; | ||
| 189 | } | ||
| 190 | |||
| 179 | return min(max_pages, MAX_DOMAIN_PAGES); | 191 | return min(max_pages, MAX_DOMAIN_PAGES); |
| 180 | } | 192 | } |
| 181 | 193 | ||
| @@ -410,6 +422,6 @@ void __init xen_arch_setup(void) | |||
| 410 | #endif | 422 | #endif |
| 411 | disable_cpuidle(); | 423 | disable_cpuidle(); |
| 412 | boot_option_idle_override = IDLE_HALT; | 424 | boot_option_idle_override = IDLE_HALT; |
| 413 | 425 | WARN_ON(set_pm_idle_to_default()); | |
| 414 | fiddle_vdso(); | 426 | fiddle_vdso(); |
| 415 | } | 427 | } |
diff --git a/block/blk-core.c b/block/blk-core.c index ea70e6c80cd3..15de223c7f93 100644 --- a/block/blk-core.c +++ b/block/blk-core.c | |||
| @@ -366,7 +366,14 @@ void blk_drain_queue(struct request_queue *q, bool drain_all) | |||
| 366 | if (drain_all) | 366 | if (drain_all) |
| 367 | blk_throtl_drain(q); | 367 | blk_throtl_drain(q); |
| 368 | 368 | ||
| 369 | __blk_run_queue(q); | 369 | /* |
| 370 | * This function might be called on a queue which failed | ||
| 371 | * driver init after queue creation. Some drivers | ||
| 372 | * (e.g. fd) get unhappy in such cases. Kick queue iff | ||
| 373 | * dispatch queue has something on it. | ||
| 374 | */ | ||
| 375 | if (!list_empty(&q->queue_head)) | ||
| 376 | __blk_run_queue(q); | ||
| 370 | 377 | ||
| 371 | if (drain_all) | 378 | if (drain_all) |
| 372 | nr_rqs = q->rq.count[0] + q->rq.count[1]; | 379 | nr_rqs = q->rq.count[0] + q->rq.count[1]; |
| @@ -467,6 +474,7 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id) | |||
| 467 | q->backing_dev_info.state = 0; | 474 | q->backing_dev_info.state = 0; |
| 468 | q->backing_dev_info.capabilities = BDI_CAP_MAP_COPY; | 475 | q->backing_dev_info.capabilities = BDI_CAP_MAP_COPY; |
| 469 | q->backing_dev_info.name = "block"; | 476 | q->backing_dev_info.name = "block"; |
| 477 | q->node = node_id; | ||
| 470 | 478 | ||
| 471 | err = bdi_init(&q->backing_dev_info); | 479 | err = bdi_init(&q->backing_dev_info); |
| 472 | if (err) { | 480 | if (err) { |
| @@ -551,7 +559,7 @@ blk_init_queue_node(request_fn_proc *rfn, spinlock_t *lock, int node_id) | |||
| 551 | if (!uninit_q) | 559 | if (!uninit_q) |
| 552 | return NULL; | 560 | return NULL; |
| 553 | 561 | ||
| 554 | q = blk_init_allocated_queue_node(uninit_q, rfn, lock, node_id); | 562 | q = blk_init_allocated_queue(uninit_q, rfn, lock); |
| 555 | if (!q) | 563 | if (!q) |
| 556 | blk_cleanup_queue(uninit_q); | 564 | blk_cleanup_queue(uninit_q); |
| 557 | 565 | ||
| @@ -563,18 +571,9 @@ struct request_queue * | |||
| 563 | blk_init_allocated_queue(struct request_queue *q, request_fn_proc *rfn, | 571 | blk_init_allocated_queue(struct request_queue *q, request_fn_proc *rfn, |
| 564 | spinlock_t *lock) | 572 | spinlock_t *lock) |
| 565 | { | 573 | { |
| 566 | return blk_init_allocated_queue_node(q, rfn, lock, -1); | ||
| 567 | } | ||
| 568 | EXPORT_SYMBOL(blk_init_allocated_queue); | ||
| 569 | |||
| 570 | struct request_queue * | ||
| 571 | blk_init_allocated_queue_node(struct request_queue *q, request_fn_proc *rfn, | ||
| 572 | spinlock_t *lock, int node_id) | ||
| 573 | { | ||
| 574 | if (!q) | 574 | if (!q) |
| 575 | return NULL; | 575 | return NULL; |
| 576 | 576 | ||
| 577 | q->node = node_id; | ||
| 578 | if (blk_init_free_list(q)) | 577 | if (blk_init_free_list(q)) |
| 579 | return NULL; | 578 | return NULL; |
| 580 | 579 | ||
| @@ -604,7 +603,7 @@ blk_init_allocated_queue_node(struct request_queue *q, request_fn_proc *rfn, | |||
| 604 | 603 | ||
| 605 | return NULL; | 604 | return NULL; |
| 606 | } | 605 | } |
| 607 | EXPORT_SYMBOL(blk_init_allocated_queue_node); | 606 | EXPORT_SYMBOL(blk_init_allocated_queue); |
| 608 | 607 | ||
| 609 | int blk_get_queue(struct request_queue *q) | 608 | int blk_get_queue(struct request_queue *q) |
| 610 | { | 609 | { |
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 16ace89613bc..4c12869fcf77 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c | |||
| @@ -3184,7 +3184,7 @@ static int cfq_cic_link(struct cfq_data *cfqd, struct io_context *ioc, | |||
| 3184 | } | 3184 | } |
| 3185 | } | 3185 | } |
| 3186 | 3186 | ||
| 3187 | if (ret) | 3187 | if (ret && ret != -EEXIST) |
| 3188 | printk(KERN_ERR "cfq: cic link failed!\n"); | 3188 | printk(KERN_ERR "cfq: cic link failed!\n"); |
| 3189 | 3189 | ||
| 3190 | return ret; | 3190 | return ret; |
| @@ -3200,6 +3200,7 @@ cfq_get_io_context(struct cfq_data *cfqd, gfp_t gfp_mask) | |||
| 3200 | { | 3200 | { |
| 3201 | struct io_context *ioc = NULL; | 3201 | struct io_context *ioc = NULL; |
| 3202 | struct cfq_io_context *cic; | 3202 | struct cfq_io_context *cic; |
| 3203 | int ret; | ||
| 3203 | 3204 | ||
| 3204 | might_sleep_if(gfp_mask & __GFP_WAIT); | 3205 | might_sleep_if(gfp_mask & __GFP_WAIT); |
| 3205 | 3206 | ||
| @@ -3207,6 +3208,7 @@ cfq_get_io_context(struct cfq_data *cfqd, gfp_t gfp_mask) | |||
| 3207 | if (!ioc) | 3208 | if (!ioc) |
| 3208 | return NULL; | 3209 | return NULL; |
| 3209 | 3210 | ||
| 3211 | retry: | ||
| 3210 | cic = cfq_cic_lookup(cfqd, ioc); | 3212 | cic = cfq_cic_lookup(cfqd, ioc); |
| 3211 | if (cic) | 3213 | if (cic) |
| 3212 | goto out; | 3214 | goto out; |
| @@ -3215,7 +3217,12 @@ cfq_get_io_context(struct cfq_data *cfqd, gfp_t gfp_mask) | |||
| 3215 | if (cic == NULL) | 3217 | if (cic == NULL) |
| 3216 | goto err; | 3218 | goto err; |
| 3217 | 3219 | ||
| 3218 | if (cfq_cic_link(cfqd, ioc, cic, gfp_mask)) | 3220 | ret = cfq_cic_link(cfqd, ioc, cic, gfp_mask); |
| 3221 | if (ret == -EEXIST) { | ||
| 3222 | /* someone has linked cic to ioc already */ | ||
| 3223 | cfq_cic_free(cic); | ||
| 3224 | goto retry; | ||
| 3225 | } else if (ret) | ||
| 3219 | goto err_free; | 3226 | goto err_free; |
| 3220 | 3227 | ||
| 3221 | out: | 3228 | out: |
| @@ -4036,6 +4043,11 @@ static void *cfq_init_queue(struct request_queue *q) | |||
| 4036 | 4043 | ||
| 4037 | if (blkio_alloc_blkg_stats(&cfqg->blkg)) { | 4044 | if (blkio_alloc_blkg_stats(&cfqg->blkg)) { |
| 4038 | kfree(cfqg); | 4045 | kfree(cfqg); |
| 4046 | |||
| 4047 | spin_lock(&cic_index_lock); | ||
| 4048 | ida_remove(&cic_index_ida, cfqd->cic_index); | ||
| 4049 | spin_unlock(&cic_index_lock); | ||
| 4050 | |||
| 4039 | kfree(cfqd); | 4051 | kfree(cfqd); |
| 4040 | return NULL; | 4052 | return NULL; |
| 4041 | } | 4053 | } |
diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index 127408069ca7..631b9477b99c 100644 --- a/drivers/acpi/apei/erst.c +++ b/drivers/acpi/apei/erst.c | |||
| @@ -932,7 +932,8 @@ static int erst_check_table(struct acpi_table_erst *erst_tab) | |||
| 932 | static int erst_open_pstore(struct pstore_info *psi); | 932 | static int erst_open_pstore(struct pstore_info *psi); |
| 933 | static int erst_close_pstore(struct pstore_info *psi); | 933 | static int erst_close_pstore(struct pstore_info *psi); |
| 934 | static ssize_t erst_reader(u64 *id, enum pstore_type_id *type, | 934 | static ssize_t erst_reader(u64 *id, enum pstore_type_id *type, |
| 935 | struct timespec *time, struct pstore_info *psi); | 935 | struct timespec *time, char **buf, |
| 936 | struct pstore_info *psi); | ||
| 936 | static int erst_writer(enum pstore_type_id type, u64 *id, unsigned int part, | 937 | static int erst_writer(enum pstore_type_id type, u64 *id, unsigned int part, |
| 937 | size_t size, struct pstore_info *psi); | 938 | size_t size, struct pstore_info *psi); |
| 938 | static int erst_clearer(enum pstore_type_id type, u64 id, | 939 | static int erst_clearer(enum pstore_type_id type, u64 id, |
| @@ -986,17 +987,23 @@ static int erst_close_pstore(struct pstore_info *psi) | |||
| 986 | } | 987 | } |
| 987 | 988 | ||
| 988 | static ssize_t erst_reader(u64 *id, enum pstore_type_id *type, | 989 | static ssize_t erst_reader(u64 *id, enum pstore_type_id *type, |
| 989 | struct timespec *time, struct pstore_info *psi) | 990 | struct timespec *time, char **buf, |
| 991 | struct pstore_info *psi) | ||
| 990 | { | 992 | { |
| 991 | int rc; | 993 | int rc; |
| 992 | ssize_t len = 0; | 994 | ssize_t len = 0; |
| 993 | u64 record_id; | 995 | u64 record_id; |
| 994 | struct cper_pstore_record *rcd = (struct cper_pstore_record *) | 996 | struct cper_pstore_record *rcd; |
| 995 | (erst_info.buf - sizeof(*rcd)); | 997 | size_t rcd_len = sizeof(*rcd) + erst_info.bufsize; |
| 996 | 998 | ||
| 997 | if (erst_disable) | 999 | if (erst_disable) |
| 998 | return -ENODEV; | 1000 | return -ENODEV; |
| 999 | 1001 | ||
| 1002 | rcd = kmalloc(rcd_len, GFP_KERNEL); | ||
| 1003 | if (!rcd) { | ||
| 1004 | rc = -ENOMEM; | ||
| 1005 | goto out; | ||
| 1006 | } | ||
| 1000 | skip: | 1007 | skip: |
| 1001 | rc = erst_get_record_id_next(&reader_pos, &record_id); | 1008 | rc = erst_get_record_id_next(&reader_pos, &record_id); |
| 1002 | if (rc) | 1009 | if (rc) |
| @@ -1004,22 +1011,27 @@ skip: | |||
| 1004 | 1011 | ||
| 1005 | /* no more record */ | 1012 | /* no more record */ |
| 1006 | if (record_id == APEI_ERST_INVALID_RECORD_ID) { | 1013 | if (record_id == APEI_ERST_INVALID_RECORD_ID) { |
| 1007 | rc = -1; | 1014 | rc = -EINVAL; |
| 1008 | goto out; | 1015 | goto out; |
| 1009 | } | 1016 | } |
| 1010 | 1017 | ||
| 1011 | len = erst_read(record_id, &rcd->hdr, sizeof(*rcd) + | 1018 | len = erst_read(record_id, &rcd->hdr, rcd_len); |
| 1012 | erst_info.bufsize); | ||
| 1013 | /* The record may be cleared by others, try read next record */ | 1019 | /* The record may be cleared by others, try read next record */ |
| 1014 | if (len == -ENOENT) | 1020 | if (len == -ENOENT) |
| 1015 | goto skip; | 1021 | goto skip; |
| 1016 | else if (len < 0) { | 1022 | else if (len < sizeof(*rcd)) { |
| 1017 | rc = -1; | 1023 | rc = -EIO; |
| 1018 | goto out; | 1024 | goto out; |
| 1019 | } | 1025 | } |
| 1020 | if (uuid_le_cmp(rcd->hdr.creator_id, CPER_CREATOR_PSTORE) != 0) | 1026 | if (uuid_le_cmp(rcd->hdr.creator_id, CPER_CREATOR_PSTORE) != 0) |
| 1021 | goto skip; | 1027 | goto skip; |
| 1022 | 1028 | ||
| 1029 | *buf = kmalloc(len, GFP_KERNEL); | ||
| 1030 | if (*buf == NULL) { | ||
| 1031 | rc = -ENOMEM; | ||
| 1032 | goto out; | ||
| 1033 | } | ||
| 1034 | memcpy(*buf, rcd->data, len - sizeof(*rcd)); | ||
| 1023 | *id = record_id; | 1035 | *id = record_id; |
| 1024 | if (uuid_le_cmp(rcd->sec_hdr.section_type, | 1036 | if (uuid_le_cmp(rcd->sec_hdr.section_type, |
| 1025 | CPER_SECTION_TYPE_DMESG) == 0) | 1037 | CPER_SECTION_TYPE_DMESG) == 0) |
| @@ -1037,6 +1049,7 @@ skip: | |||
| 1037 | time->tv_nsec = 0; | 1049 | time->tv_nsec = 0; |
| 1038 | 1050 | ||
| 1039 | out: | 1051 | out: |
| 1052 | kfree(rcd); | ||
| 1040 | return (rc < 0) ? rc : (len - sizeof(*rcd)); | 1053 | return (rc < 0) ? rc : (len - sizeof(*rcd)); |
| 1041 | } | 1054 | } |
| 1042 | 1055 | ||
diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c index ec555951176e..43b875810d1b 100644 --- a/drivers/ata/ahci_platform.c +++ b/drivers/ata/ahci_platform.c | |||
| @@ -67,7 +67,7 @@ static int __init ahci_probe(struct platform_device *pdev) | |||
| 67 | struct device *dev = &pdev->dev; | 67 | struct device *dev = &pdev->dev; |
| 68 | struct ahci_platform_data *pdata = dev_get_platdata(dev); | 68 | struct ahci_platform_data *pdata = dev_get_platdata(dev); |
| 69 | const struct platform_device_id *id = platform_get_device_id(pdev); | 69 | const struct platform_device_id *id = platform_get_device_id(pdev); |
| 70 | struct ata_port_info pi = ahci_port_info[id->driver_data]; | 70 | struct ata_port_info pi = ahci_port_info[id ? id->driver_data : 0]; |
| 71 | const struct ata_port_info *ppi[] = { &pi, NULL }; | 71 | const struct ata_port_info *ppi[] = { &pi, NULL }; |
| 72 | struct ahci_host_priv *hpriv; | 72 | struct ahci_host_priv *hpriv; |
| 73 | struct ata_host *host; | 73 | struct ata_host *host; |
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c index 63d53277d6a9..4cadfa28f940 100644 --- a/drivers/ata/libata-sff.c +++ b/drivers/ata/libata-sff.c | |||
| @@ -2533,10 +2533,12 @@ static int ata_pci_init_one(struct pci_dev *pdev, | |||
| 2533 | if (rc) | 2533 | if (rc) |
| 2534 | goto out; | 2534 | goto out; |
| 2535 | 2535 | ||
| 2536 | #ifdef CONFIG_ATA_BMDMA | ||
| 2536 | if (bmdma) | 2537 | if (bmdma) |
| 2537 | /* prepare and activate BMDMA host */ | 2538 | /* prepare and activate BMDMA host */ |
| 2538 | rc = ata_pci_bmdma_prepare_host(pdev, ppi, &host); | 2539 | rc = ata_pci_bmdma_prepare_host(pdev, ppi, &host); |
| 2539 | else | 2540 | else |
| 2541 | #endif | ||
| 2540 | /* prepare and activate SFF host */ | 2542 | /* prepare and activate SFF host */ |
| 2541 | rc = ata_pci_sff_prepare_host(pdev, ppi, &host); | 2543 | rc = ata_pci_sff_prepare_host(pdev, ppi, &host); |
| 2542 | if (rc) | 2544 | if (rc) |
| @@ -2544,10 +2546,12 @@ static int ata_pci_init_one(struct pci_dev *pdev, | |||
| 2544 | host->private_data = host_priv; | 2546 | host->private_data = host_priv; |
| 2545 | host->flags |= hflags; | 2547 | host->flags |= hflags; |
| 2546 | 2548 | ||
| 2549 | #ifdef CONFIG_ATA_BMDMA | ||
| 2547 | if (bmdma) { | 2550 | if (bmdma) { |
| 2548 | pci_set_master(pdev); | 2551 | pci_set_master(pdev); |
| 2549 | rc = ata_pci_sff_activate_host(host, ata_bmdma_interrupt, sht); | 2552 | rc = ata_pci_sff_activate_host(host, ata_bmdma_interrupt, sht); |
| 2550 | } else | 2553 | } else |
| 2554 | #endif | ||
| 2551 | rc = ata_pci_sff_activate_host(host, ata_sff_interrupt, sht); | 2555 | rc = ata_pci_sff_activate_host(host, ata_sff_interrupt, sht); |
| 2552 | out: | 2556 | out: |
| 2553 | if (rc == 0) | 2557 | if (rc == 0) |
diff --git a/drivers/base/core.c b/drivers/base/core.c index d8b3d89db043..919daa7cd5b1 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c | |||
| @@ -1743,8 +1743,10 @@ void device_shutdown(void) | |||
| 1743 | */ | 1743 | */ |
| 1744 | list_del_init(&dev->kobj.entry); | 1744 | list_del_init(&dev->kobj.entry); |
| 1745 | spin_unlock(&devices_kset->list_lock); | 1745 | spin_unlock(&devices_kset->list_lock); |
| 1746 | /* Disable all device's runtime power management */ | 1746 | |
| 1747 | pm_runtime_disable(dev); | 1747 | /* Don't allow any more runtime suspends */ |
| 1748 | pm_runtime_get_noresume(dev); | ||
| 1749 | pm_runtime_barrier(dev); | ||
| 1748 | 1750 | ||
| 1749 | if (dev->bus && dev->bus->shutdown) { | 1751 | if (dev->bus && dev->bus->shutdown) { |
| 1750 | dev_dbg(dev, "shutdown\n"); | 1752 | dev_dbg(dev, "shutdown\n"); |
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c index 8004ac30a7a8..587cce57adae 100644 --- a/drivers/block/cciss.c +++ b/drivers/block/cciss.c | |||
| @@ -2601,6 +2601,8 @@ static int fill_cmd(ctlr_info_t *h, CommandList_struct *c, __u8 cmd, void *buff, | |||
| 2601 | c->Request.Timeout = 0; | 2601 | c->Request.Timeout = 0; |
| 2602 | c->Request.CDB[0] = BMIC_WRITE; | 2602 | c->Request.CDB[0] = BMIC_WRITE; |
| 2603 | c->Request.CDB[6] = BMIC_CACHE_FLUSH; | 2603 | c->Request.CDB[6] = BMIC_CACHE_FLUSH; |
| 2604 | c->Request.CDB[7] = (size >> 8) & 0xFF; | ||
| 2605 | c->Request.CDB[8] = size & 0xFF; | ||
| 2604 | break; | 2606 | break; |
| 2605 | case TEST_UNIT_READY: | 2607 | case TEST_UNIT_READY: |
| 2606 | c->Request.CDBLen = 6; | 2608 | c->Request.CDBLen = 6; |
| @@ -4880,7 +4882,7 @@ static int cciss_request_irq(ctlr_info_t *h, | |||
| 4880 | { | 4882 | { |
| 4881 | if (h->msix_vector || h->msi_vector) { | 4883 | if (h->msix_vector || h->msi_vector) { |
| 4882 | if (!request_irq(h->intr[h->intr_mode], msixhandler, | 4884 | if (!request_irq(h->intr[h->intr_mode], msixhandler, |
| 4883 | IRQF_DISABLED, h->devname, h)) | 4885 | 0, h->devname, h)) |
| 4884 | return 0; | 4886 | return 0; |
| 4885 | dev_err(&h->pdev->dev, "Unable to get msi irq %d" | 4887 | dev_err(&h->pdev->dev, "Unable to get msi irq %d" |
| 4886 | " for %s\n", h->intr[h->intr_mode], | 4888 | " for %s\n", h->intr[h->intr_mode], |
| @@ -4889,7 +4891,7 @@ static int cciss_request_irq(ctlr_info_t *h, | |||
| 4889 | } | 4891 | } |
| 4890 | 4892 | ||
| 4891 | if (!request_irq(h->intr[h->intr_mode], intxhandler, | 4893 | if (!request_irq(h->intr[h->intr_mode], intxhandler, |
| 4892 | IRQF_DISABLED, h->devname, h)) | 4894 | IRQF_SHARED, h->devname, h)) |
| 4893 | return 0; | 4895 | return 0; |
| 4894 | dev_err(&h->pdev->dev, "Unable to get irq %d for %s\n", | 4896 | dev_err(&h->pdev->dev, "Unable to get irq %d for %s\n", |
| 4895 | h->intr[h->intr_mode], h->devname); | 4897 | h->intr[h->intr_mode], h->devname); |
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 68b205a9338f..1e888c9e85b3 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c | |||
| @@ -422,7 +422,7 @@ static int do_bio_filebacked(struct loop_device *lo, struct bio *bio) | |||
| 422 | 422 | ||
| 423 | /* | 423 | /* |
| 424 | * We use punch hole to reclaim the free space used by the | 424 | * We use punch hole to reclaim the free space used by the |
| 425 | * image a.k.a. discard. However we do support discard if | 425 | * image a.k.a. discard. However we do not support discard if |
| 426 | * encryption is enabled, because it may give an attacker | 426 | * encryption is enabled, because it may give an attacker |
| 427 | * useful information. | 427 | * useful information. |
| 428 | */ | 428 | */ |
| @@ -797,7 +797,7 @@ static void loop_config_discard(struct loop_device *lo) | |||
| 797 | } | 797 | } |
| 798 | 798 | ||
| 799 | q->limits.discard_granularity = inode->i_sb->s_blocksize; | 799 | q->limits.discard_granularity = inode->i_sb->s_blocksize; |
| 800 | q->limits.discard_alignment = inode->i_sb->s_blocksize; | 800 | q->limits.discard_alignment = 0; |
| 801 | q->limits.max_discard_sectors = UINT_MAX >> 9; | 801 | q->limits.max_discard_sectors = UINT_MAX >> 9; |
| 802 | q->limits.discard_zeroes_data = 1; | 802 | q->limits.discard_zeroes_data = 1; |
| 803 | queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q); | 803 | queue_flag_set_unlocked(QUEUE_FLAG_DISCARD, q); |
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 65cc424359b0..148ab944378d 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c | |||
| @@ -183,10 +183,6 @@ static LIST_HEAD(rbd_client_list); /* clients */ | |||
| 183 | 183 | ||
| 184 | static int __rbd_init_snaps_header(struct rbd_device *rbd_dev); | 184 | static int __rbd_init_snaps_header(struct rbd_device *rbd_dev); |
| 185 | static void rbd_dev_release(struct device *dev); | 185 | static void rbd_dev_release(struct device *dev); |
| 186 | static ssize_t rbd_snap_rollback(struct device *dev, | ||
| 187 | struct device_attribute *attr, | ||
| 188 | const char *buf, | ||
| 189 | size_t size); | ||
| 190 | static ssize_t rbd_snap_add(struct device *dev, | 186 | static ssize_t rbd_snap_add(struct device *dev, |
| 191 | struct device_attribute *attr, | 187 | struct device_attribute *attr, |
| 192 | const char *buf, | 188 | const char *buf, |
| @@ -461,6 +457,10 @@ static int rbd_header_from_disk(struct rbd_image_header *header, | |||
| 461 | u32 snap_count = le32_to_cpu(ondisk->snap_count); | 457 | u32 snap_count = le32_to_cpu(ondisk->snap_count); |
| 462 | int ret = -ENOMEM; | 458 | int ret = -ENOMEM; |
| 463 | 459 | ||
| 460 | if (memcmp(ondisk, RBD_HEADER_TEXT, sizeof(RBD_HEADER_TEXT))) { | ||
| 461 | return -ENXIO; | ||
| 462 | } | ||
| 463 | |||
| 464 | init_rwsem(&header->snap_rwsem); | 464 | init_rwsem(&header->snap_rwsem); |
| 465 | header->snap_names_len = le64_to_cpu(ondisk->snap_names_len); | 465 | header->snap_names_len = le64_to_cpu(ondisk->snap_names_len); |
| 466 | header->snapc = kmalloc(sizeof(struct ceph_snap_context) + | 466 | header->snapc = kmalloc(sizeof(struct ceph_snap_context) + |
| @@ -1356,32 +1356,6 @@ fail: | |||
| 1356 | } | 1356 | } |
| 1357 | 1357 | ||
| 1358 | /* | 1358 | /* |
| 1359 | * Request sync osd rollback | ||
| 1360 | */ | ||
| 1361 | static int rbd_req_sync_rollback_obj(struct rbd_device *dev, | ||
| 1362 | u64 snapid, | ||
| 1363 | const char *obj) | ||
| 1364 | { | ||
| 1365 | struct ceph_osd_req_op *ops; | ||
| 1366 | int ret = rbd_create_rw_ops(&ops, 1, CEPH_OSD_OP_ROLLBACK, 0); | ||
| 1367 | if (ret < 0) | ||
| 1368 | return ret; | ||
| 1369 | |||
| 1370 | ops[0].snap.snapid = snapid; | ||
| 1371 | |||
| 1372 | ret = rbd_req_sync_op(dev, NULL, | ||
| 1373 | CEPH_NOSNAP, | ||
| 1374 | 0, | ||
| 1375 | CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK, | ||
| 1376 | ops, | ||
| 1377 | 1, obj, 0, 0, NULL, NULL, NULL); | ||
| 1378 | |||
| 1379 | rbd_destroy_ops(ops); | ||
| 1380 | |||
| 1381 | return ret; | ||
| 1382 | } | ||
| 1383 | |||
| 1384 | /* | ||
| 1385 | * Request sync osd read | 1359 | * Request sync osd read |
| 1386 | */ | 1360 | */ |
| 1387 | static int rbd_req_sync_exec(struct rbd_device *dev, | 1361 | static int rbd_req_sync_exec(struct rbd_device *dev, |
| @@ -1610,8 +1584,13 @@ static int rbd_read_header(struct rbd_device *rbd_dev, | |||
| 1610 | goto out_dh; | 1584 | goto out_dh; |
| 1611 | 1585 | ||
| 1612 | rc = rbd_header_from_disk(header, dh, snap_count, GFP_KERNEL); | 1586 | rc = rbd_header_from_disk(header, dh, snap_count, GFP_KERNEL); |
| 1613 | if (rc < 0) | 1587 | if (rc < 0) { |
| 1588 | if (rc == -ENXIO) { | ||
| 1589 | pr_warning("unrecognized header format" | ||
| 1590 | " for image %s", rbd_dev->obj); | ||
| 1591 | } | ||
| 1614 | goto out_dh; | 1592 | goto out_dh; |
| 1593 | } | ||
| 1615 | 1594 | ||
| 1616 | if (snap_count != header->total_snaps) { | 1595 | if (snap_count != header->total_snaps) { |
| 1617 | snap_count = header->total_snaps; | 1596 | snap_count = header->total_snaps; |
| @@ -1882,7 +1861,6 @@ static DEVICE_ATTR(name, S_IRUGO, rbd_name_show, NULL); | |||
| 1882 | static DEVICE_ATTR(refresh, S_IWUSR, NULL, rbd_image_refresh); | 1861 | static DEVICE_ATTR(refresh, S_IWUSR, NULL, rbd_image_refresh); |
| 1883 | static DEVICE_ATTR(current_snap, S_IRUGO, rbd_snap_show, NULL); | 1862 | static DEVICE_ATTR(current_snap, S_IRUGO, rbd_snap_show, NULL); |
| 1884 | static DEVICE_ATTR(create_snap, S_IWUSR, NULL, rbd_snap_add); | 1863 | static DEVICE_ATTR(create_snap, S_IWUSR, NULL, rbd_snap_add); |
| 1885 | static DEVICE_ATTR(rollback_snap, S_IWUSR, NULL, rbd_snap_rollback); | ||
| 1886 | 1864 | ||
| 1887 | static struct attribute *rbd_attrs[] = { | 1865 | static struct attribute *rbd_attrs[] = { |
| 1888 | &dev_attr_size.attr, | 1866 | &dev_attr_size.attr, |
| @@ -1893,7 +1871,6 @@ static struct attribute *rbd_attrs[] = { | |||
| 1893 | &dev_attr_current_snap.attr, | 1871 | &dev_attr_current_snap.attr, |
| 1894 | &dev_attr_refresh.attr, | 1872 | &dev_attr_refresh.attr, |
| 1895 | &dev_attr_create_snap.attr, | 1873 | &dev_attr_create_snap.attr, |
| 1896 | &dev_attr_rollback_snap.attr, | ||
| 1897 | NULL | 1874 | NULL |
| 1898 | }; | 1875 | }; |
| 1899 | 1876 | ||
| @@ -2424,64 +2401,6 @@ err_unlock: | |||
| 2424 | return ret; | 2401 | return ret; |
| 2425 | } | 2402 | } |
| 2426 | 2403 | ||
| 2427 | static ssize_t rbd_snap_rollback(struct device *dev, | ||
| 2428 | struct device_attribute *attr, | ||
| 2429 | const char *buf, | ||
| 2430 | size_t count) | ||
| 2431 | { | ||
| 2432 | struct rbd_device *rbd_dev = dev_to_rbd(dev); | ||
| 2433 | int ret; | ||
| 2434 | u64 snapid; | ||
| 2435 | u64 cur_ofs; | ||
| 2436 | char *seg_name = NULL; | ||
| 2437 | char *snap_name = kmalloc(count + 1, GFP_KERNEL); | ||
| 2438 | ret = -ENOMEM; | ||
| 2439 | if (!snap_name) | ||
| 2440 | return ret; | ||
| 2441 | |||
| 2442 | /* parse snaps add command */ | ||
| 2443 | snprintf(snap_name, count, "%s", buf); | ||
| 2444 | seg_name = kmalloc(RBD_MAX_SEG_NAME_LEN + 1, GFP_NOIO); | ||
| 2445 | if (!seg_name) | ||
| 2446 | goto done; | ||
| 2447 | |||
| 2448 | mutex_lock_nested(&ctl_mutex, SINGLE_DEPTH_NESTING); | ||
| 2449 | |||
| 2450 | ret = snap_by_name(&rbd_dev->header, snap_name, &snapid, NULL); | ||
| 2451 | if (ret < 0) | ||
| 2452 | goto done_unlock; | ||
| 2453 | |||
| 2454 | dout("snapid=%lld\n", snapid); | ||
| 2455 | |||
| 2456 | cur_ofs = 0; | ||
| 2457 | while (cur_ofs < rbd_dev->header.image_size) { | ||
| 2458 | cur_ofs += rbd_get_segment(&rbd_dev->header, | ||
| 2459 | rbd_dev->obj, | ||
| 2460 | cur_ofs, (u64)-1, | ||
| 2461 | seg_name, NULL); | ||
| 2462 | dout("seg_name=%s\n", seg_name); | ||
| 2463 | |||
| 2464 | ret = rbd_req_sync_rollback_obj(rbd_dev, snapid, seg_name); | ||
| 2465 | if (ret < 0) | ||
| 2466 | pr_warning("could not roll back obj %s err=%d\n", | ||
| 2467 | seg_name, ret); | ||
| 2468 | } | ||
| 2469 | |||
| 2470 | ret = __rbd_update_snaps(rbd_dev); | ||
| 2471 | if (ret < 0) | ||
| 2472 | goto done_unlock; | ||
| 2473 | |||
| 2474 | ret = count; | ||
| 2475 | |||
| 2476 | done_unlock: | ||
| 2477 | mutex_unlock(&ctl_mutex); | ||
| 2478 | done: | ||
| 2479 | kfree(seg_name); | ||
| 2480 | kfree(snap_name); | ||
| 2481 | |||
| 2482 | return ret; | ||
| 2483 | } | ||
| 2484 | |||
| 2485 | static struct bus_attribute rbd_bus_attrs[] = { | 2404 | static struct bus_attribute rbd_bus_attrs[] = { |
| 2486 | __ATTR(add, S_IWUSR, NULL, rbd_add), | 2405 | __ATTR(add, S_IWUSR, NULL, rbd_add), |
| 2487 | __ATTR(remove, S_IWUSR, NULL, rbd_remove), | 2406 | __ATTR(remove, S_IWUSR, NULL, rbd_remove), |
diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c index ae3e167e17ad..89ddab127e33 100644 --- a/drivers/block/swim3.c +++ b/drivers/block/swim3.c | |||
| @@ -16,6 +16,8 @@ | |||
| 16 | * handle GCR disks | 16 | * handle GCR disks |
| 17 | */ | 17 | */ |
| 18 | 18 | ||
| 19 | #undef DEBUG | ||
| 20 | |||
| 19 | #include <linux/stddef.h> | 21 | #include <linux/stddef.h> |
| 20 | #include <linux/kernel.h> | 22 | #include <linux/kernel.h> |
| 21 | #include <linux/sched.h> | 23 | #include <linux/sched.h> |
| @@ -36,13 +38,11 @@ | |||
| 36 | #include <asm/machdep.h> | 38 | #include <asm/machdep.h> |
| 37 | #include <asm/pmac_feature.h> | 39 | #include <asm/pmac_feature.h> |
| 38 | 40 | ||
| 39 | static DEFINE_MUTEX(swim3_mutex); | ||
| 40 | static struct request_queue *swim3_queue; | ||
| 41 | static struct gendisk *disks[2]; | ||
| 42 | static struct request *fd_req; | ||
| 43 | |||
| 44 | #define MAX_FLOPPIES 2 | 41 | #define MAX_FLOPPIES 2 |
| 45 | 42 | ||
| 43 | static DEFINE_MUTEX(swim3_mutex); | ||
| 44 | static struct gendisk *disks[MAX_FLOPPIES]; | ||
| 45 | |||
| 46 | enum swim_state { | 46 | enum swim_state { |
| 47 | idle, | 47 | idle, |
| 48 | locating, | 48 | locating, |
| @@ -177,7 +177,6 @@ struct swim3 { | |||
| 177 | 177 | ||
| 178 | struct floppy_state { | 178 | struct floppy_state { |
| 179 | enum swim_state state; | 179 | enum swim_state state; |
| 180 | spinlock_t lock; | ||
| 181 | struct swim3 __iomem *swim3; /* hardware registers */ | 180 | struct swim3 __iomem *swim3; /* hardware registers */ |
| 182 | struct dbdma_regs __iomem *dma; /* DMA controller registers */ | 181 | struct dbdma_regs __iomem *dma; /* DMA controller registers */ |
| 183 | int swim3_intr; /* interrupt number for SWIM3 */ | 182 | int swim3_intr; /* interrupt number for SWIM3 */ |
| @@ -204,8 +203,20 @@ struct floppy_state { | |||
| 204 | int wanted; | 203 | int wanted; |
| 205 | struct macio_dev *mdev; | 204 | struct macio_dev *mdev; |
| 206 | char dbdma_cmd_space[5 * sizeof(struct dbdma_cmd)]; | 205 | char dbdma_cmd_space[5 * sizeof(struct dbdma_cmd)]; |
| 206 | int index; | ||
| 207 | struct request *cur_req; | ||
| 207 | }; | 208 | }; |
| 208 | 209 | ||
| 210 | #define swim3_err(fmt, arg...) dev_err(&fs->mdev->ofdev.dev, "[fd%d] " fmt, fs->index, arg) | ||
| 211 | #define swim3_warn(fmt, arg...) dev_warn(&fs->mdev->ofdev.dev, "[fd%d] " fmt, fs->index, arg) | ||
| 212 | #define swim3_info(fmt, arg...) dev_info(&fs->mdev->ofdev.dev, "[fd%d] " fmt, fs->index, arg) | ||
| 213 | |||
| 214 | #ifdef DEBUG | ||
| 215 | #define swim3_dbg(fmt, arg...) dev_dbg(&fs->mdev->ofdev.dev, "[fd%d] " fmt, fs->index, arg) | ||
| 216 | #else | ||
| 217 | #define swim3_dbg(fmt, arg...) do { } while(0) | ||
| 218 | #endif | ||
| 219 | |||
| 209 | static struct floppy_state floppy_states[MAX_FLOPPIES]; | 220 | static struct floppy_state floppy_states[MAX_FLOPPIES]; |
| 210 | static int floppy_count = 0; | 221 | static int floppy_count = 0; |
| 211 | static DEFINE_SPINLOCK(swim3_lock); | 222 | static DEFINE_SPINLOCK(swim3_lock); |
| @@ -224,17 +235,8 @@ static unsigned short write_postamble[] = { | |||
| 224 | 0, 0, 0, 0, 0, 0 | 235 | 0, 0, 0, 0, 0, 0 |
| 225 | }; | 236 | }; |
| 226 | 237 | ||
| 227 | static void swim3_select(struct floppy_state *fs, int sel); | ||
| 228 | static void swim3_action(struct floppy_state *fs, int action); | ||
| 229 | static int swim3_readbit(struct floppy_state *fs, int bit); | ||
| 230 | static void do_fd_request(struct request_queue * q); | ||
| 231 | static void start_request(struct floppy_state *fs); | ||
| 232 | static void set_timeout(struct floppy_state *fs, int nticks, | ||
| 233 | void (*proc)(unsigned long)); | ||
| 234 | static void scan_track(struct floppy_state *fs); | ||
| 235 | static void seek_track(struct floppy_state *fs, int n); | 238 | static void seek_track(struct floppy_state *fs, int n); |
| 236 | static void init_dma(struct dbdma_cmd *cp, int cmd, void *buf, int count); | 239 | static void init_dma(struct dbdma_cmd *cp, int cmd, void *buf, int count); |
| 237 | static void setup_transfer(struct floppy_state *fs); | ||
| 238 | static void act(struct floppy_state *fs); | 240 | static void act(struct floppy_state *fs); |
| 239 | static void scan_timeout(unsigned long data); | 241 | static void scan_timeout(unsigned long data); |
| 240 | static void seek_timeout(unsigned long data); | 242 | static void seek_timeout(unsigned long data); |
| @@ -254,18 +256,21 @@ static unsigned int floppy_check_events(struct gendisk *disk, | |||
| 254 | unsigned int clearing); | 256 | unsigned int clearing); |
| 255 | static int floppy_revalidate(struct gendisk *disk); | 257 | static int floppy_revalidate(struct gendisk *disk); |
| 256 | 258 | ||
| 257 | static bool swim3_end_request(int err, unsigned int nr_bytes) | 259 | static bool swim3_end_request(struct floppy_state *fs, int err, unsigned int nr_bytes) |
| 258 | { | 260 | { |
| 259 | if (__blk_end_request(fd_req, err, nr_bytes)) | 261 | struct request *req = fs->cur_req; |
| 260 | return true; | 262 | int rc; |
| 261 | 263 | ||
| 262 | fd_req = NULL; | 264 | swim3_dbg(" end request, err=%d nr_bytes=%d, cur_req=%p\n", |
| 263 | return false; | 265 | err, nr_bytes, req); |
| 264 | } | ||
| 265 | 266 | ||
| 266 | static bool swim3_end_request_cur(int err) | 267 | if (err) |
| 267 | { | 268 | nr_bytes = blk_rq_cur_bytes(req); |
| 268 | return swim3_end_request(err, blk_rq_cur_bytes(fd_req)); | 269 | rc = __blk_end_request(req, err, nr_bytes); |
| 270 | if (rc) | ||
| 271 | return true; | ||
| 272 | fs->cur_req = NULL; | ||
| 273 | return false; | ||
| 269 | } | 274 | } |
| 270 | 275 | ||
| 271 | static void swim3_select(struct floppy_state *fs, int sel) | 276 | static void swim3_select(struct floppy_state *fs, int sel) |
| @@ -303,50 +308,53 @@ static int swim3_readbit(struct floppy_state *fs, int bit) | |||
| 303 | return (stat & DATA) == 0; | 308 | return (stat & DATA) == 0; |
| 304 | } | 309 | } |
| 305 | 310 | ||
| 306 | static void do_fd_request(struct request_queue * q) | ||
| 307 | { | ||
| 308 | int i; | ||
| 309 | |||
| 310 | for(i=0; i<floppy_count; i++) { | ||
| 311 | struct floppy_state *fs = &floppy_states[i]; | ||
| 312 | if (fs->mdev->media_bay && | ||
| 313 | check_media_bay(fs->mdev->media_bay) != MB_FD) | ||
| 314 | continue; | ||
| 315 | start_request(fs); | ||
| 316 | } | ||
| 317 | } | ||
| 318 | |||
| 319 | static void start_request(struct floppy_state *fs) | 311 | static void start_request(struct floppy_state *fs) |
| 320 | { | 312 | { |
| 321 | struct request *req; | 313 | struct request *req; |
| 322 | unsigned long x; | 314 | unsigned long x; |
| 323 | 315 | ||
| 316 | swim3_dbg("start request, initial state=%d\n", fs->state); | ||
| 317 | |||
| 324 | if (fs->state == idle && fs->wanted) { | 318 | if (fs->state == idle && fs->wanted) { |
| 325 | fs->state = available; | 319 | fs->state = available; |
| 326 | wake_up(&fs->wait); | 320 | wake_up(&fs->wait); |
| 327 | return; | 321 | return; |
| 328 | } | 322 | } |
| 329 | while (fs->state == idle) { | 323 | while (fs->state == idle) { |
| 330 | if (!fd_req) { | 324 | swim3_dbg("start request, idle loop, cur_req=%p\n", fs->cur_req); |
| 331 | fd_req = blk_fetch_request(swim3_queue); | 325 | if (!fs->cur_req) { |
| 332 | if (!fd_req) | 326 | fs->cur_req = blk_fetch_request(disks[fs->index]->queue); |
| 327 | swim3_dbg(" fetched request %p\n", fs->cur_req); | ||
| 328 | if (!fs->cur_req) | ||
| 333 | break; | 329 | break; |
| 334 | } | 330 | } |
| 335 | req = fd_req; | 331 | req = fs->cur_req; |
| 336 | #if 0 | 332 | |
| 337 | printk("do_fd_req: dev=%s cmd=%d sec=%ld nr_sec=%u buf=%p\n", | 333 | if (fs->mdev->media_bay && |
| 338 | req->rq_disk->disk_name, req->cmd, | 334 | check_media_bay(fs->mdev->media_bay) != MB_FD) { |
| 339 | (long)blk_rq_pos(req), blk_rq_sectors(req), req->buffer); | 335 | swim3_dbg("%s", " media bay absent, dropping req\n"); |
| 340 | printk(" errors=%d current_nr_sectors=%u\n", | 336 | swim3_end_request(fs, -ENODEV, 0); |
| 341 | req->errors, blk_rq_cur_sectors(req)); | 337 | continue; |
| 338 | } | ||
| 339 | |||
| 340 | #if 0 /* This is really too verbose */ | ||
| 341 | swim3_dbg("do_fd_req: dev=%s cmd=%d sec=%ld nr_sec=%u buf=%p\n", | ||
| 342 | req->rq_disk->disk_name, req->cmd, | ||
| 343 | (long)blk_rq_pos(req), blk_rq_sectors(req), | ||
| 344 | req->buffer); | ||
| 345 | swim3_dbg(" errors=%d current_nr_sectors=%u\n", | ||
| 346 | req->errors, blk_rq_cur_sectors(req)); | ||
| 342 | #endif | 347 | #endif |
| 343 | 348 | ||
| 344 | if (blk_rq_pos(req) >= fs->total_secs) { | 349 | if (blk_rq_pos(req) >= fs->total_secs) { |
| 345 | swim3_end_request_cur(-EIO); | 350 | swim3_dbg(" pos out of bounds (%ld, max is %ld)\n", |
| 351 | (long)blk_rq_pos(req), (long)fs->total_secs); | ||
| 352 | swim3_end_request(fs, -EIO, 0); | ||
| 346 | continue; | 353 | continue; |
| 347 | } | 354 | } |
| 348 | if (fs->ejected) { | 355 | if (fs->ejected) { |
| 349 | swim3_end_request_cur(-EIO); | 356 | swim3_dbg("%s", " disk ejected\n"); |
| 357 | swim3_end_request(fs, -EIO, 0); | ||
| 350 | continue; | 358 | continue; |
| 351 | } | 359 | } |
| 352 | 360 | ||
| @@ -354,7 +362,8 @@ static void start_request(struct floppy_state *fs) | |||
| 354 | if (fs->write_prot < 0) | 362 | if (fs->write_prot < 0) |
| 355 | fs->write_prot = swim3_readbit(fs, WRITE_PROT); | 363 | fs->write_prot = swim3_readbit(fs, WRITE_PROT); |
| 356 | if (fs->write_prot) { | 364 | if (fs->write_prot) { |
| 357 | swim3_end_request_cur(-EIO); | 365 | swim3_dbg("%s", " try to write, disk write protected\n"); |
| 366 | swim3_end_request(fs, -EIO, 0); | ||
| 358 | continue; | 367 | continue; |
| 359 | } | 368 | } |
| 360 | } | 369 | } |
| @@ -369,7 +378,6 @@ static void start_request(struct floppy_state *fs) | |||
| 369 | x = ((long)blk_rq_pos(req)) % fs->secpercyl; | 378 | x = ((long)blk_rq_pos(req)) % fs->secpercyl; |
| 370 | fs->head = x / fs->secpertrack; | 379 | fs->head = x / fs->secpertrack; |
| 371 | fs->req_sector = x % fs->secpertrack + 1; | 380 | fs->req_sector = x % fs->secpertrack + 1; |
| 372 | fd_req = req; | ||
| 373 | fs->state = do_transfer; | 381 | fs->state = do_transfer; |
| 374 | fs->retries = 0; | 382 | fs->retries = 0; |
| 375 | 383 | ||
| @@ -377,12 +385,14 @@ static void start_request(struct floppy_state *fs) | |||
| 377 | } | 385 | } |
| 378 | } | 386 | } |
| 379 | 387 | ||
| 388 | static void do_fd_request(struct request_queue * q) | ||
| 389 | { | ||
| 390 | start_request(q->queuedata); | ||
| 391 | } | ||
| 392 | |||
| 380 | static void set_timeout(struct floppy_state *fs, int nticks, | 393 | static void set_timeout(struct floppy_state *fs, int nticks, |
| 381 | void (*proc)(unsigned long)) | 394 | void (*proc)(unsigned long)) |
| 382 | { | 395 | { |
| 383 | unsigned long flags; | ||
| 384 | |||
| 385 | spin_lock_irqsave(&fs->lock, flags); | ||
| 386 | if (fs->timeout_pending) | 396 | if (fs->timeout_pending) |
| 387 | del_timer(&fs->timeout); | 397 | del_timer(&fs->timeout); |
| 388 | fs->timeout.expires = jiffies + nticks; | 398 | fs->timeout.expires = jiffies + nticks; |
| @@ -390,7 +400,6 @@ static void set_timeout(struct floppy_state *fs, int nticks, | |||
| 390 | fs->timeout.data = (unsigned long) fs; | 400 | fs->timeout.data = (unsigned long) fs; |
| 391 | add_timer(&fs->timeout); | 401 | add_timer(&fs->timeout); |
| 392 | fs->timeout_pending = 1; | 402 | fs->timeout_pending = 1; |
| 393 | spin_unlock_irqrestore(&fs->lock, flags); | ||
| 394 | } | 403 | } |
| 395 | 404 | ||
| 396 | static inline void scan_track(struct floppy_state *fs) | 405 | static inline void scan_track(struct floppy_state *fs) |
| @@ -442,40 +451,45 @@ static inline void setup_transfer(struct floppy_state *fs) | |||
| 442 | struct swim3 __iomem *sw = fs->swim3; | 451 | struct swim3 __iomem *sw = fs->swim3; |
| 443 | struct dbdma_cmd *cp = fs->dma_cmd; | 452 | struct dbdma_cmd *cp = fs->dma_cmd; |
| 444 | struct dbdma_regs __iomem *dr = fs->dma; | 453 | struct dbdma_regs __iomem *dr = fs->dma; |
| 454 | struct request *req = fs->cur_req; | ||
| 445 | 455 | ||
| 446 | if (blk_rq_cur_sectors(fd_req) <= 0) { | 456 | if (blk_rq_cur_sectors(req) <= 0) { |
| 447 | printk(KERN_ERR "swim3: transfer 0 sectors?\n"); | 457 | swim3_warn("%s", "Transfer 0 sectors ?\n"); |
| 448 | return; | 458 | return; |
| 449 | } | 459 | } |
| 450 | if (rq_data_dir(fd_req) == WRITE) | 460 | if (rq_data_dir(req) == WRITE) |
| 451 | n = 1; | 461 | n = 1; |
| 452 | else { | 462 | else { |
| 453 | n = fs->secpertrack - fs->req_sector + 1; | 463 | n = fs->secpertrack - fs->req_sector + 1; |
| 454 | if (n > blk_rq_cur_sectors(fd_req)) | 464 | if (n > blk_rq_cur_sectors(req)) |
| 455 | n = blk_rq_cur_sectors(fd_req); | 465 | n = blk_rq_cur_sectors(req); |
| 456 | } | 466 | } |
| 467 | |||
| 468 | swim3_dbg(" setup xfer at sect %d (of %d) head %d for %d\n", | ||
| 469 | fs->req_sector, fs->secpertrack, fs->head, n); | ||
| 470 | |||
| 457 | fs->scount = n; | 471 | fs->scount = n; |
| 458 | swim3_select(fs, fs->head? READ_DATA_1: READ_DATA_0); | 472 | swim3_select(fs, fs->head? READ_DATA_1: READ_DATA_0); |
| 459 | out_8(&sw->sector, fs->req_sector); | 473 | out_8(&sw->sector, fs->req_sector); |
| 460 | out_8(&sw->nsect, n); | 474 | out_8(&sw->nsect, n); |
| 461 | out_8(&sw->gap3, 0); | 475 | out_8(&sw->gap3, 0); |
| 462 | out_le32(&dr->cmdptr, virt_to_bus(cp)); | 476 | out_le32(&dr->cmdptr, virt_to_bus(cp)); |
| 463 | if (rq_data_dir(fd_req) == WRITE) { | 477 | if (rq_data_dir(req) == WRITE) { |
| 464 | /* Set up 3 dma commands: write preamble, data, postamble */ | 478 | /* Set up 3 dma commands: write preamble, data, postamble */ |
| 465 | init_dma(cp, OUTPUT_MORE, write_preamble, sizeof(write_preamble)); | 479 | init_dma(cp, OUTPUT_MORE, write_preamble, sizeof(write_preamble)); |
| 466 | ++cp; | 480 | ++cp; |
| 467 | init_dma(cp, OUTPUT_MORE, fd_req->buffer, 512); | 481 | init_dma(cp, OUTPUT_MORE, req->buffer, 512); |
| 468 | ++cp; | 482 | ++cp; |
| 469 | init_dma(cp, OUTPUT_LAST, write_postamble, sizeof(write_postamble)); | 483 | init_dma(cp, OUTPUT_LAST, write_postamble, sizeof(write_postamble)); |
| 470 | } else { | 484 | } else { |
| 471 | init_dma(cp, INPUT_LAST, fd_req->buffer, n * 512); | 485 | init_dma(cp, INPUT_LAST, req->buffer, n * 512); |
| 472 | } | 486 | } |
| 473 | ++cp; | 487 | ++cp; |
| 474 | out_le16(&cp->command, DBDMA_STOP); | 488 | out_le16(&cp->command, DBDMA_STOP); |
| 475 | out_8(&sw->control_bic, DO_ACTION | WRITE_SECTORS); | 489 | out_8(&sw->control_bic, DO_ACTION | WRITE_SECTORS); |
| 476 | in_8(&sw->error); | 490 | in_8(&sw->error); |
| 477 | out_8(&sw->control_bic, DO_ACTION | WRITE_SECTORS); | 491 | out_8(&sw->control_bic, DO_ACTION | WRITE_SECTORS); |
| 478 | if (rq_data_dir(fd_req) == WRITE) | 492 | if (rq_data_dir(req) == WRITE) |
| 479 | out_8(&sw->control_bis, WRITE_SECTORS); | 493 | out_8(&sw->control_bis, WRITE_SECTORS); |
| 480 | in_8(&sw->intr); | 494 | in_8(&sw->intr); |
| 481 | out_le32(&dr->control, (RUN << 16) | RUN); | 495 | out_le32(&dr->control, (RUN << 16) | RUN); |
| @@ -488,12 +502,16 @@ static inline void setup_transfer(struct floppy_state *fs) | |||
| 488 | static void act(struct floppy_state *fs) | 502 | static void act(struct floppy_state *fs) |
| 489 | { | 503 | { |
| 490 | for (;;) { | 504 | for (;;) { |
| 505 | swim3_dbg(" act loop, state=%d, req_cyl=%d, cur_cyl=%d\n", | ||
| 506 | fs->state, fs->req_cyl, fs->cur_cyl); | ||
| 507 | |||
| 491 | switch (fs->state) { | 508 | switch (fs->state) { |
| 492 | case idle: | 509 | case idle: |
| 493 | return; /* XXX shouldn't get here */ | 510 | return; /* XXX shouldn't get here */ |
| 494 | 511 | ||
| 495 | case locating: | 512 | case locating: |
| 496 | if (swim3_readbit(fs, TRACK_ZERO)) { | 513 | if (swim3_readbit(fs, TRACK_ZERO)) { |
| 514 | swim3_dbg("%s", " locate track 0\n"); | ||
| 497 | fs->cur_cyl = 0; | 515 | fs->cur_cyl = 0; |
| 498 | if (fs->req_cyl == 0) | 516 | if (fs->req_cyl == 0) |
| 499 | fs->state = do_transfer; | 517 | fs->state = do_transfer; |
| @@ -511,7 +529,7 @@ static void act(struct floppy_state *fs) | |||
| 511 | break; | 529 | break; |
| 512 | } | 530 | } |
| 513 | if (fs->req_cyl == fs->cur_cyl) { | 531 | if (fs->req_cyl == fs->cur_cyl) { |
| 514 | printk("whoops, seeking 0\n"); | 532 | swim3_warn("%s", "Whoops, seeking 0\n"); |
| 515 | fs->state = do_transfer; | 533 | fs->state = do_transfer; |
| 516 | break; | 534 | break; |
| 517 | } | 535 | } |
| @@ -527,7 +545,9 @@ static void act(struct floppy_state *fs) | |||
| 527 | case do_transfer: | 545 | case do_transfer: |
| 528 | if (fs->cur_cyl != fs->req_cyl) { | 546 | if (fs->cur_cyl != fs->req_cyl) { |
| 529 | if (fs->retries > 5) { | 547 | if (fs->retries > 5) { |
| 530 | swim3_end_request_cur(-EIO); | 548 | swim3_err("Wrong cylinder in transfer, want: %d got %d\n", |
| 549 | fs->req_cyl, fs->cur_cyl); | ||
| 550 | swim3_end_request(fs, -EIO, 0); | ||
| 531 | fs->state = idle; | 551 | fs->state = idle; |
| 532 | return; | 552 | return; |
| 533 | } | 553 | } |
| @@ -542,7 +562,7 @@ static void act(struct floppy_state *fs) | |||
| 542 | return; | 562 | return; |
| 543 | 563 | ||
| 544 | default: | 564 | default: |
| 545 | printk(KERN_ERR"swim3: unknown state %d\n", fs->state); | 565 | swim3_err("Unknown state %d\n", fs->state); |
| 546 | return; | 566 | return; |
| 547 | } | 567 | } |
| 548 | } | 568 | } |
| @@ -552,59 +572,75 @@ static void scan_timeout(unsigned long data) | |||
| 552 | { | 572 | { |
| 553 | struct floppy_state *fs = (struct floppy_state *) data; | 573 | struct floppy_state *fs = (struct floppy_state *) data; |
| 554 | struct swim3 __iomem *sw = fs->swim3; | 574 | struct swim3 __iomem *sw = fs->swim3; |
| 575 | unsigned long flags; | ||
| 576 | |||
| 577 | swim3_dbg("* scan timeout, state=%d\n", fs->state); | ||
| 555 | 578 | ||
| 579 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 556 | fs->timeout_pending = 0; | 580 | fs->timeout_pending = 0; |
| 557 | out_8(&sw->control_bic, DO_ACTION | WRITE_SECTORS); | 581 | out_8(&sw->control_bic, DO_ACTION | WRITE_SECTORS); |
| 558 | out_8(&sw->select, RELAX); | 582 | out_8(&sw->select, RELAX); |
| 559 | out_8(&sw->intr_enable, 0); | 583 | out_8(&sw->intr_enable, 0); |
| 560 | fs->cur_cyl = -1; | 584 | fs->cur_cyl = -1; |
| 561 | if (fs->retries > 5) { | 585 | if (fs->retries > 5) { |
| 562 | swim3_end_request_cur(-EIO); | 586 | swim3_end_request(fs, -EIO, 0); |
| 563 | fs->state = idle; | 587 | fs->state = idle; |
| 564 | start_request(fs); | 588 | start_request(fs); |
| 565 | } else { | 589 | } else { |
| 566 | fs->state = jogging; | 590 | fs->state = jogging; |
| 567 | act(fs); | 591 | act(fs); |
| 568 | } | 592 | } |
| 593 | spin_unlock_irqrestore(&swim3_lock, flags); | ||
| 569 | } | 594 | } |
| 570 | 595 | ||
| 571 | static void seek_timeout(unsigned long data) | 596 | static void seek_timeout(unsigned long data) |
| 572 | { | 597 | { |
| 573 | struct floppy_state *fs = (struct floppy_state *) data; | 598 | struct floppy_state *fs = (struct floppy_state *) data; |
| 574 | struct swim3 __iomem *sw = fs->swim3; | 599 | struct swim3 __iomem *sw = fs->swim3; |
| 600 | unsigned long flags; | ||
| 601 | |||
| 602 | swim3_dbg("* seek timeout, state=%d\n", fs->state); | ||
| 575 | 603 | ||
| 604 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 576 | fs->timeout_pending = 0; | 605 | fs->timeout_pending = 0; |
| 577 | out_8(&sw->control_bic, DO_SEEK); | 606 | out_8(&sw->control_bic, DO_SEEK); |
| 578 | out_8(&sw->select, RELAX); | 607 | out_8(&sw->select, RELAX); |
| 579 | out_8(&sw->intr_enable, 0); | 608 | out_8(&sw->intr_enable, 0); |
| 580 | printk(KERN_ERR "swim3: seek timeout\n"); | 609 | swim3_err("%s", "Seek timeout\n"); |
| 581 | swim3_end_request_cur(-EIO); | 610 | swim3_end_request(fs, -EIO, 0); |
| 582 | fs->state = idle; | 611 | fs->state = idle; |
| 583 | start_request(fs); | 612 | start_request(fs); |
| 613 | spin_unlock_irqrestore(&swim3_lock, flags); | ||
| 584 | } | 614 | } |
| 585 | 615 | ||
| 586 | static void settle_timeout(unsigned long data) | 616 | static void settle_timeout(unsigned long data) |
| 587 | { | 617 | { |
| 588 | struct floppy_state *fs = (struct floppy_state *) data; | 618 | struct floppy_state *fs = (struct floppy_state *) data; |
| 589 | struct swim3 __iomem *sw = fs->swim3; | 619 | struct swim3 __iomem *sw = fs->swim3; |
| 620 | unsigned long flags; | ||
| 621 | |||
| 622 | swim3_dbg("* settle timeout, state=%d\n", fs->state); | ||
| 590 | 623 | ||
| 624 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 591 | fs->timeout_pending = 0; | 625 | fs->timeout_pending = 0; |
| 592 | if (swim3_readbit(fs, SEEK_COMPLETE)) { | 626 | if (swim3_readbit(fs, SEEK_COMPLETE)) { |
| 593 | out_8(&sw->select, RELAX); | 627 | out_8(&sw->select, RELAX); |
| 594 | fs->state = locating; | 628 | fs->state = locating; |
| 595 | act(fs); | 629 | act(fs); |
| 596 | return; | 630 | goto unlock; |
| 597 | } | 631 | } |
| 598 | out_8(&sw->select, RELAX); | 632 | out_8(&sw->select, RELAX); |
| 599 | if (fs->settle_time < 2*HZ) { | 633 | if (fs->settle_time < 2*HZ) { |
| 600 | ++fs->settle_time; | 634 | ++fs->settle_time; |
| 601 | set_timeout(fs, 1, settle_timeout); | 635 | set_timeout(fs, 1, settle_timeout); |
| 602 | return; | 636 | goto unlock; |
| 603 | } | 637 | } |
| 604 | printk(KERN_ERR "swim3: seek settle timeout\n"); | 638 | swim3_err("%s", "Seek settle timeout\n"); |
| 605 | swim3_end_request_cur(-EIO); | 639 | swim3_end_request(fs, -EIO, 0); |
| 606 | fs->state = idle; | 640 | fs->state = idle; |
| 607 | start_request(fs); | 641 | start_request(fs); |
| 642 | unlock: | ||
| 643 | spin_unlock_irqrestore(&swim3_lock, flags); | ||
| 608 | } | 644 | } |
| 609 | 645 | ||
| 610 | static void xfer_timeout(unsigned long data) | 646 | static void xfer_timeout(unsigned long data) |
| @@ -612,8 +648,12 @@ static void xfer_timeout(unsigned long data) | |||
| 612 | struct floppy_state *fs = (struct floppy_state *) data; | 648 | struct floppy_state *fs = (struct floppy_state *) data; |
| 613 | struct swim3 __iomem *sw = fs->swim3; | 649 | struct swim3 __iomem *sw = fs->swim3; |
| 614 | struct dbdma_regs __iomem *dr = fs->dma; | 650 | struct dbdma_regs __iomem *dr = fs->dma; |
| 651 | unsigned long flags; | ||
| 615 | int n; | 652 | int n; |
| 616 | 653 | ||
| 654 | swim3_dbg("* xfer timeout, state=%d\n", fs->state); | ||
| 655 | |||
| 656 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 617 | fs->timeout_pending = 0; | 657 | fs->timeout_pending = 0; |
| 618 | out_le32(&dr->control, RUN << 16); | 658 | out_le32(&dr->control, RUN << 16); |
| 619 | /* We must wait a bit for dbdma to stop */ | 659 | /* We must wait a bit for dbdma to stop */ |
| @@ -622,12 +662,13 @@ static void xfer_timeout(unsigned long data) | |||
| 622 | out_8(&sw->intr_enable, 0); | 662 | out_8(&sw->intr_enable, 0); |
| 623 | out_8(&sw->control_bic, WRITE_SECTORS | DO_ACTION); | 663 | out_8(&sw->control_bic, WRITE_SECTORS | DO_ACTION); |
| 624 | out_8(&sw->select, RELAX); | 664 | out_8(&sw->select, RELAX); |
| 625 | printk(KERN_ERR "swim3: timeout %sing sector %ld\n", | 665 | swim3_err("Timeout %sing sector %ld\n", |
| 626 | (rq_data_dir(fd_req)==WRITE? "writ": "read"), | 666 | (rq_data_dir(fs->cur_req)==WRITE? "writ": "read"), |
| 627 | (long)blk_rq_pos(fd_req)); | 667 | (long)blk_rq_pos(fs->cur_req)); |
| 628 | swim3_end_request_cur(-EIO); | 668 | swim3_end_request(fs, -EIO, 0); |
| 629 | fs->state = idle; | 669 | fs->state = idle; |
| 630 | start_request(fs); | 670 | start_request(fs); |
| 671 | spin_unlock_irqrestore(&swim3_lock, flags); | ||
| 631 | } | 672 | } |
| 632 | 673 | ||
| 633 | static irqreturn_t swim3_interrupt(int irq, void *dev_id) | 674 | static irqreturn_t swim3_interrupt(int irq, void *dev_id) |
| @@ -638,12 +679,17 @@ static irqreturn_t swim3_interrupt(int irq, void *dev_id) | |||
| 638 | int stat, resid; | 679 | int stat, resid; |
| 639 | struct dbdma_regs __iomem *dr; | 680 | struct dbdma_regs __iomem *dr; |
| 640 | struct dbdma_cmd *cp; | 681 | struct dbdma_cmd *cp; |
| 682 | unsigned long flags; | ||
| 683 | struct request *req = fs->cur_req; | ||
| 684 | |||
| 685 | swim3_dbg("* interrupt, state=%d\n", fs->state); | ||
| 641 | 686 | ||
| 687 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 642 | intr = in_8(&sw->intr); | 688 | intr = in_8(&sw->intr); |
| 643 | err = (intr & ERROR_INTR)? in_8(&sw->error): 0; | 689 | err = (intr & ERROR_INTR)? in_8(&sw->error): 0; |
| 644 | if ((intr & ERROR_INTR) && fs->state != do_transfer) | 690 | if ((intr & ERROR_INTR) && fs->state != do_transfer) |
| 645 | printk(KERN_ERR "swim3_interrupt, state=%d, dir=%x, intr=%x, err=%x\n", | 691 | swim3_err("Non-transfer error interrupt: state=%d, dir=%x, intr=%x, err=%x\n", |
| 646 | fs->state, rq_data_dir(fd_req), intr, err); | 692 | fs->state, rq_data_dir(req), intr, err); |
| 647 | switch (fs->state) { | 693 | switch (fs->state) { |
| 648 | case locating: | 694 | case locating: |
| 649 | if (intr & SEEN_SECTOR) { | 695 | if (intr & SEEN_SECTOR) { |
| @@ -653,10 +699,10 @@ static irqreturn_t swim3_interrupt(int irq, void *dev_id) | |||
| 653 | del_timer(&fs->timeout); | 699 | del_timer(&fs->timeout); |
| 654 | fs->timeout_pending = 0; | 700 | fs->timeout_pending = 0; |
| 655 | if (sw->ctrack == 0xff) { | 701 | if (sw->ctrack == 0xff) { |
| 656 | printk(KERN_ERR "swim3: seen sector but cyl=ff?\n"); | 702 | swim3_err("%s", "Seen sector but cyl=ff?\n"); |
| 657 | fs->cur_cyl = -1; | 703 | fs->cur_cyl = -1; |
| 658 | if (fs->retries > 5) { | 704 | if (fs->retries > 5) { |
| 659 | swim3_end_request_cur(-EIO); | 705 | swim3_end_request(fs, -EIO, 0); |
| 660 | fs->state = idle; | 706 | fs->state = idle; |
| 661 | start_request(fs); | 707 | start_request(fs); |
| 662 | } else { | 708 | } else { |
| @@ -668,8 +714,8 @@ static irqreturn_t swim3_interrupt(int irq, void *dev_id) | |||
| 668 | fs->cur_cyl = sw->ctrack; | 714 | fs->cur_cyl = sw->ctrack; |
| 669 | fs->cur_sector = sw->csect; | 715 | fs->cur_sector = sw->csect; |
| 670 | if (fs->expect_cyl != -1 && fs->expect_cyl != fs->cur_cyl) | 716 | if (fs->expect_cyl != -1 && fs->expect_cyl != fs->cur_cyl) |
| 671 | printk(KERN_ERR "swim3: expected cyl %d, got %d\n", | 717 | swim3_err("Expected cyl %d, got %d\n", |
| 672 | fs->expect_cyl, fs->cur_cyl); | 718 | fs->expect_cyl, fs->cur_cyl); |
| 673 | fs->state = do_transfer; | 719 | fs->state = do_transfer; |
| 674 | act(fs); | 720 | act(fs); |
| 675 | } | 721 | } |
| @@ -704,7 +750,7 @@ static irqreturn_t swim3_interrupt(int irq, void *dev_id) | |||
| 704 | fs->timeout_pending = 0; | 750 | fs->timeout_pending = 0; |
| 705 | dr = fs->dma; | 751 | dr = fs->dma; |
| 706 | cp = fs->dma_cmd; | 752 | cp = fs->dma_cmd; |
| 707 | if (rq_data_dir(fd_req) == WRITE) | 753 | if (rq_data_dir(req) == WRITE) |
| 708 | ++cp; | 754 | ++cp; |
| 709 | /* | 755 | /* |
| 710 | * Check that the main data transfer has finished. | 756 | * Check that the main data transfer has finished. |
| @@ -729,31 +775,32 @@ static irqreturn_t swim3_interrupt(int irq, void *dev_id) | |||
| 729 | if (intr & ERROR_INTR) { | 775 | if (intr & ERROR_INTR) { |
| 730 | n = fs->scount - 1 - resid / 512; | 776 | n = fs->scount - 1 - resid / 512; |
| 731 | if (n > 0) { | 777 | if (n > 0) { |
| 732 | blk_update_request(fd_req, 0, n << 9); | 778 | blk_update_request(req, 0, n << 9); |
| 733 | fs->req_sector += n; | 779 | fs->req_sector += n; |
| 734 | } | 780 | } |
| 735 | if (fs->retries < 5) { | 781 | if (fs->retries < 5) { |
| 736 | ++fs->retries; | 782 | ++fs->retries; |
| 737 | act(fs); | 783 | act(fs); |
| 738 | } else { | 784 | } else { |
| 739 | printk("swim3: error %sing block %ld (err=%x)\n", | 785 | swim3_err("Error %sing block %ld (err=%x)\n", |
| 740 | rq_data_dir(fd_req) == WRITE? "writ": "read", | 786 | rq_data_dir(req) == WRITE? "writ": "read", |
| 741 | (long)blk_rq_pos(fd_req), err); | 787 | (long)blk_rq_pos(req), err); |
| 742 | swim3_end_request_cur(-EIO); | 788 | swim3_end_request(fs, -EIO, 0); |
| 743 | fs->state = idle; | 789 | fs->state = idle; |
| 744 | } | 790 | } |
| 745 | } else { | 791 | } else { |
| 746 | if ((stat & ACTIVE) == 0 || resid != 0) { | 792 | if ((stat & ACTIVE) == 0 || resid != 0) { |
| 747 | /* musta been an error */ | 793 | /* musta been an error */ |
| 748 | printk(KERN_ERR "swim3: fd dma: stat=%x resid=%d\n", stat, resid); | 794 | swim3_err("fd dma error: stat=%x resid=%d\n", stat, resid); |
| 749 | printk(KERN_ERR " state=%d, dir=%x, intr=%x, err=%x\n", | 795 | swim3_err(" state=%d, dir=%x, intr=%x, err=%x\n", |
| 750 | fs->state, rq_data_dir(fd_req), intr, err); | 796 | fs->state, rq_data_dir(req), intr, err); |
| 751 | swim3_end_request_cur(-EIO); | 797 | swim3_end_request(fs, -EIO, 0); |
| 752 | fs->state = idle; | 798 | fs->state = idle; |
| 753 | start_request(fs); | 799 | start_request(fs); |
| 754 | break; | 800 | break; |
| 755 | } | 801 | } |
| 756 | if (swim3_end_request(0, fs->scount << 9)) { | 802 | fs->retries = 0; |
| 803 | if (swim3_end_request(fs, 0, fs->scount << 9)) { | ||
| 757 | fs->req_sector += fs->scount; | 804 | fs->req_sector += fs->scount; |
| 758 | if (fs->req_sector > fs->secpertrack) { | 805 | if (fs->req_sector > fs->secpertrack) { |
| 759 | fs->req_sector -= fs->secpertrack; | 806 | fs->req_sector -= fs->secpertrack; |
| @@ -770,8 +817,9 @@ static irqreturn_t swim3_interrupt(int irq, void *dev_id) | |||
| 770 | start_request(fs); | 817 | start_request(fs); |
| 771 | break; | 818 | break; |
| 772 | default: | 819 | default: |
| 773 | printk(KERN_ERR "swim3: don't know what to do in state %d\n", fs->state); | 820 | swim3_err("Don't know what to do in state %d\n", fs->state); |
| 774 | } | 821 | } |
| 822 | spin_unlock_irqrestore(&swim3_lock, flags); | ||
| 775 | return IRQ_HANDLED; | 823 | return IRQ_HANDLED; |
| 776 | } | 824 | } |
| 777 | 825 | ||
| @@ -781,26 +829,31 @@ static void fd_dma_interrupt(int irq, void *dev_id) | |||
| 781 | } | 829 | } |
| 782 | */ | 830 | */ |
| 783 | 831 | ||
| 832 | /* Called under the mutex to grab exclusive access to a drive */ | ||
| 784 | static int grab_drive(struct floppy_state *fs, enum swim_state state, | 833 | static int grab_drive(struct floppy_state *fs, enum swim_state state, |
| 785 | int interruptible) | 834 | int interruptible) |
| 786 | { | 835 | { |
| 787 | unsigned long flags; | 836 | unsigned long flags; |
| 788 | 837 | ||
| 789 | spin_lock_irqsave(&fs->lock, flags); | 838 | swim3_dbg("%s", "-> grab drive\n"); |
| 790 | if (fs->state != idle) { | 839 | |
| 840 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 841 | if (fs->state != idle && fs->state != available) { | ||
| 791 | ++fs->wanted; | 842 | ++fs->wanted; |
| 792 | while (fs->state != available) { | 843 | while (fs->state != available) { |
| 844 | spin_unlock_irqrestore(&swim3_lock, flags); | ||
| 793 | if (interruptible && signal_pending(current)) { | 845 | if (interruptible && signal_pending(current)) { |
| 794 | --fs->wanted; | 846 | --fs->wanted; |
| 795 | spin_unlock_irqrestore(&fs->lock, flags); | ||
| 796 | return -EINTR; | 847 | return -EINTR; |
| 797 | } | 848 | } |
| 798 | interruptible_sleep_on(&fs->wait); | 849 | interruptible_sleep_on(&fs->wait); |
| 850 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 799 | } | 851 | } |
| 800 | --fs->wanted; | 852 | --fs->wanted; |
| 801 | } | 853 | } |
| 802 | fs->state = state; | 854 | fs->state = state; |
| 803 | spin_unlock_irqrestore(&fs->lock, flags); | 855 | spin_unlock_irqrestore(&swim3_lock, flags); |
| 856 | |||
| 804 | return 0; | 857 | return 0; |
| 805 | } | 858 | } |
| 806 | 859 | ||
| @@ -808,10 +861,12 @@ static void release_drive(struct floppy_state *fs) | |||
| 808 | { | 861 | { |
| 809 | unsigned long flags; | 862 | unsigned long flags; |
| 810 | 863 | ||
| 811 | spin_lock_irqsave(&fs->lock, flags); | 864 | swim3_dbg("%s", "-> release drive\n"); |
| 865 | |||
| 866 | spin_lock_irqsave(&swim3_lock, flags); | ||
| 812 | fs->state = idle; | 867 | fs->state = idle; |
| 813 | start_request(fs); | 868 | start_request(fs); |
| 814 | spin_unlock_irqrestore(&fs->lock, flags); | 869 | spin_unlock_irqrestore(&swim3_lock, flags); |
| 815 | } | 870 | } |
| 816 | 871 | ||
| 817 | static int fd_eject(struct floppy_state *fs) | 872 | static int fd_eject(struct floppy_state *fs) |
| @@ -966,6 +1021,7 @@ static int floppy_release(struct gendisk *disk, fmode_t mode) | |||
| 966 | { | 1021 | { |
| 967 | struct floppy_state *fs = disk->private_data; | 1022 | struct floppy_state *fs = disk->private_data; |
| 968 | struct swim3 __iomem *sw = fs->swim3; | 1023 | struct swim3 __iomem *sw = fs->swim3; |
| 1024 | |||
| 969 | mutex_lock(&swim3_mutex); | 1025 | mutex_lock(&swim3_mutex); |
| 970 | if (fs->ref_count > 0 && --fs->ref_count == 0) { | 1026 | if (fs->ref_count > 0 && --fs->ref_count == 0) { |
| 971 | swim3_action(fs, MOTOR_OFF); | 1027 | swim3_action(fs, MOTOR_OFF); |
| @@ -1031,30 +1087,48 @@ static const struct block_device_operations floppy_fops = { | |||
| 1031 | .revalidate_disk= floppy_revalidate, | 1087 | .revalidate_disk= floppy_revalidate, |
| 1032 | }; | 1088 | }; |
| 1033 | 1089 | ||
| 1090 | static void swim3_mb_event(struct macio_dev* mdev, int mb_state) | ||
| 1091 | { | ||
| 1092 | struct floppy_state *fs = macio_get_drvdata(mdev); | ||
| 1093 | struct swim3 __iomem *sw = fs->swim3; | ||
| 1094 | |||
| 1095 | if (!fs) | ||
| 1096 | return; | ||
| 1097 | if (mb_state != MB_FD) | ||
| 1098 | return; | ||
| 1099 | |||
| 1100 | /* Clear state */ | ||
| 1101 | out_8(&sw->intr_enable, 0); | ||
| 1102 | in_8(&sw->intr); | ||
| 1103 | in_8(&sw->error); | ||
| 1104 | } | ||
| 1105 | |||
| 1034 | static int swim3_add_device(struct macio_dev *mdev, int index) | 1106 | static int swim3_add_device(struct macio_dev *mdev, int index) |
| 1035 | { | 1107 | { |
| 1036 | struct device_node *swim = mdev->ofdev.dev.of_node; | 1108 | struct device_node *swim = mdev->ofdev.dev.of_node; |
| 1037 | struct floppy_state *fs = &floppy_states[index]; | 1109 | struct floppy_state *fs = &floppy_states[index]; |
| 1038 | int rc = -EBUSY; | 1110 | int rc = -EBUSY; |
| 1039 | 1111 | ||
| 1112 | /* Do this first for message macros */ | ||
| 1113 | memset(fs, 0, sizeof(*fs)); | ||
| 1114 | fs->mdev = mdev; | ||
| 1115 | fs->index = index; | ||
| 1116 | |||
| 1040 | /* Check & Request resources */ | 1117 | /* Check & Request resources */ |
| 1041 | if (macio_resource_count(mdev) < 2) { | 1118 | if (macio_resource_count(mdev) < 2) { |
| 1042 | printk(KERN_WARNING "ifd%d: no address for %s\n", | 1119 | swim3_err("%s", "No address in device-tree\n"); |
| 1043 | index, swim->full_name); | ||
| 1044 | return -ENXIO; | 1120 | return -ENXIO; |
| 1045 | } | 1121 | } |
| 1046 | if (macio_irq_count(mdev) < 2) { | 1122 | if (macio_irq_count(mdev) < 1) { |
| 1047 | printk(KERN_WARNING "fd%d: no intrs for device %s\n", | 1123 | swim3_err("%s", "No interrupt in device-tree\n"); |
| 1048 | index, swim->full_name); | 1124 | return -ENXIO; |
| 1049 | } | 1125 | } |
| 1050 | if (macio_request_resource(mdev, 0, "swim3 (mmio)")) { | 1126 | if (macio_request_resource(mdev, 0, "swim3 (mmio)")) { |
| 1051 | printk(KERN_ERR "fd%d: can't request mmio resource for %s\n", | 1127 | swim3_err("%s", "Can't request mmio resource\n"); |
| 1052 | index, swim->full_name); | ||
| 1053 | return -EBUSY; | 1128 | return -EBUSY; |
| 1054 | } | 1129 | } |
| 1055 | if (macio_request_resource(mdev, 1, "swim3 (dma)")) { | 1130 | if (macio_request_resource(mdev, 1, "swim3 (dma)")) { |
| 1056 | printk(KERN_ERR "fd%d: can't request dma resource for %s\n", | 1131 | swim3_err("%s", "Can't request dma resource\n"); |
| 1057 | index, swim->full_name); | ||
| 1058 | macio_release_resource(mdev, 0); | 1132 | macio_release_resource(mdev, 0); |
| 1059 | return -EBUSY; | 1133 | return -EBUSY; |
| 1060 | } | 1134 | } |
| @@ -1063,22 +1137,18 @@ static int swim3_add_device(struct macio_dev *mdev, int index) | |||
| 1063 | if (mdev->media_bay == NULL) | 1137 | if (mdev->media_bay == NULL) |
| 1064 | pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 1); | 1138 | pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 1); |
| 1065 | 1139 | ||
| 1066 | memset(fs, 0, sizeof(*fs)); | ||
| 1067 | spin_lock_init(&fs->lock); | ||
| 1068 | fs->state = idle; | 1140 | fs->state = idle; |
| 1069 | fs->swim3 = (struct swim3 __iomem *) | 1141 | fs->swim3 = (struct swim3 __iomem *) |
| 1070 | ioremap(macio_resource_start(mdev, 0), 0x200); | 1142 | ioremap(macio_resource_start(mdev, 0), 0x200); |
| 1071 | if (fs->swim3 == NULL) { | 1143 | if (fs->swim3 == NULL) { |
| 1072 | printk("fd%d: couldn't map registers for %s\n", | 1144 | swim3_err("%s", "Couldn't map mmio registers\n"); |
| 1073 | index, swim->full_name); | ||
| 1074 | rc = -ENOMEM; | 1145 | rc = -ENOMEM; |
| 1075 | goto out_release; | 1146 | goto out_release; |
| 1076 | } | 1147 | } |
| 1077 | fs->dma = (struct dbdma_regs __iomem *) | 1148 | fs->dma = (struct dbdma_regs __iomem *) |
| 1078 | ioremap(macio_resource_start(mdev, 1), 0x200); | 1149 | ioremap(macio_resource_start(mdev, 1), 0x200); |
| 1079 | if (fs->dma == NULL) { | 1150 | if (fs->dma == NULL) { |
| 1080 | printk("fd%d: couldn't map DMA for %s\n", | 1151 | swim3_err("%s", "Couldn't map dma registers\n"); |
| 1081 | index, swim->full_name); | ||
| 1082 | iounmap(fs->swim3); | 1152 | iounmap(fs->swim3); |
| 1083 | rc = -ENOMEM; | 1153 | rc = -ENOMEM; |
| 1084 | goto out_release; | 1154 | goto out_release; |
| @@ -1090,31 +1160,25 @@ static int swim3_add_device(struct macio_dev *mdev, int index) | |||
| 1090 | fs->secpercyl = 36; | 1160 | fs->secpercyl = 36; |
| 1091 | fs->secpertrack = 18; | 1161 | fs->secpertrack = 18; |
| 1092 | fs->total_secs = 2880; | 1162 | fs->total_secs = 2880; |
| 1093 | fs->mdev = mdev; | ||
| 1094 | init_waitqueue_head(&fs->wait); | 1163 | init_waitqueue_head(&fs->wait); |
| 1095 | 1164 | ||
| 1096 | fs->dma_cmd = (struct dbdma_cmd *) DBDMA_ALIGN(fs->dbdma_cmd_space); | 1165 | fs->dma_cmd = (struct dbdma_cmd *) DBDMA_ALIGN(fs->dbdma_cmd_space); |
| 1097 | memset(fs->dma_cmd, 0, 2 * sizeof(struct dbdma_cmd)); | 1166 | memset(fs->dma_cmd, 0, 2 * sizeof(struct dbdma_cmd)); |
| 1098 | st_le16(&fs->dma_cmd[1].command, DBDMA_STOP); | 1167 | st_le16(&fs->dma_cmd[1].command, DBDMA_STOP); |
| 1099 | 1168 | ||
| 1169 | if (mdev->media_bay == NULL || check_media_bay(mdev->media_bay) == MB_FD) | ||
| 1170 | swim3_mb_event(mdev, MB_FD); | ||
| 1171 | |||
| 1100 | if (request_irq(fs->swim3_intr, swim3_interrupt, 0, "SWIM3", fs)) { | 1172 | if (request_irq(fs->swim3_intr, swim3_interrupt, 0, "SWIM3", fs)) { |
| 1101 | printk(KERN_ERR "fd%d: couldn't request irq %d for %s\n", | 1173 | swim3_err("%s", "Couldn't request interrupt\n"); |
| 1102 | index, fs->swim3_intr, swim->full_name); | ||
| 1103 | pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 0); | 1174 | pmac_call_feature(PMAC_FTR_SWIM3_ENABLE, swim, 0, 0); |
| 1104 | goto out_unmap; | 1175 | goto out_unmap; |
| 1105 | return -EBUSY; | 1176 | return -EBUSY; |
| 1106 | } | 1177 | } |
| 1107 | /* | ||
| 1108 | if (request_irq(fs->dma_intr, fd_dma_interrupt, 0, "SWIM3-dma", fs)) { | ||
| 1109 | printk(KERN_ERR "Couldn't get irq %d for SWIM3 DMA", | ||
| 1110 | fs->dma_intr); | ||
| 1111 | return -EBUSY; | ||
| 1112 | } | ||
| 1113 | */ | ||
| 1114 | 1178 | ||
| 1115 | init_timer(&fs->timeout); | 1179 | init_timer(&fs->timeout); |
| 1116 | 1180 | ||
| 1117 | printk(KERN_INFO "fd%d: SWIM3 floppy controller %s\n", floppy_count, | 1181 | swim3_info("SWIM3 floppy controller %s\n", |
| 1118 | mdev->media_bay ? "in media bay" : ""); | 1182 | mdev->media_bay ? "in media bay" : ""); |
| 1119 | 1183 | ||
| 1120 | return 0; | 1184 | return 0; |
| @@ -1132,41 +1196,42 @@ static int swim3_add_device(struct macio_dev *mdev, int index) | |||
| 1132 | 1196 | ||
| 1133 | static int __devinit swim3_attach(struct macio_dev *mdev, const struct of_device_id *match) | 1197 | static int __devinit swim3_attach(struct macio_dev *mdev, const struct of_device_id *match) |
| 1134 | { | 1198 | { |
| 1135 | int i, rc; | ||
| 1136 | struct gendisk *disk; | 1199 | struct gendisk *disk; |
| 1200 | int index, rc; | ||
| 1201 | |||
| 1202 | index = floppy_count++; | ||
| 1203 | if (index >= MAX_FLOPPIES) | ||
| 1204 | return -ENXIO; | ||
| 1137 | 1205 | ||
| 1138 | /* Add the drive */ | 1206 | /* Add the drive */ |
| 1139 | rc = swim3_add_device(mdev, floppy_count); | 1207 | rc = swim3_add_device(mdev, index); |
| 1140 | if (rc) | 1208 | if (rc) |
| 1141 | return rc; | 1209 | return rc; |
| 1210 | /* Now register that disk. Same comment about failure handling */ | ||
| 1211 | disk = disks[index] = alloc_disk(1); | ||
| 1212 | if (disk == NULL) | ||
| 1213 | return -ENOMEM; | ||
| 1214 | disk->queue = blk_init_queue(do_fd_request, &swim3_lock); | ||
| 1215 | if (disk->queue == NULL) { | ||
| 1216 | put_disk(disk); | ||
| 1217 | return -ENOMEM; | ||
| 1218 | } | ||
| 1219 | disk->queue->queuedata = &floppy_states[index]; | ||
| 1142 | 1220 | ||
| 1143 | /* Now create the queue if not there yet */ | 1221 | if (index == 0) { |
| 1144 | if (swim3_queue == NULL) { | ||
| 1145 | /* If we failed, there isn't much we can do as the driver is still | 1222 | /* If we failed, there isn't much we can do as the driver is still |
| 1146 | * too dumb to remove the device, just bail out | 1223 | * too dumb to remove the device, just bail out |
| 1147 | */ | 1224 | */ |
| 1148 | if (register_blkdev(FLOPPY_MAJOR, "fd")) | 1225 | if (register_blkdev(FLOPPY_MAJOR, "fd")) |
| 1149 | return 0; | 1226 | return 0; |
| 1150 | swim3_queue = blk_init_queue(do_fd_request, &swim3_lock); | ||
| 1151 | if (swim3_queue == NULL) { | ||
| 1152 | unregister_blkdev(FLOPPY_MAJOR, "fd"); | ||
| 1153 | return 0; | ||
| 1154 | } | ||
| 1155 | } | 1227 | } |
| 1156 | 1228 | ||
| 1157 | /* Now register that disk. Same comment about failure handling */ | ||
| 1158 | i = floppy_count++; | ||
| 1159 | disk = disks[i] = alloc_disk(1); | ||
| 1160 | if (disk == NULL) | ||
| 1161 | return 0; | ||
| 1162 | |||
| 1163 | disk->major = FLOPPY_MAJOR; | 1229 | disk->major = FLOPPY_MAJOR; |
| 1164 | disk->first_minor = i; | 1230 | disk->first_minor = index; |
| 1165 | disk->fops = &floppy_fops; | 1231 | disk->fops = &floppy_fops; |
| 1166 | disk->private_data = &floppy_states[i]; | 1232 | disk->private_data = &floppy_states[index]; |
| 1167 | disk->queue = swim3_queue; | ||
| 1168 | disk->flags |= GENHD_FL_REMOVABLE; | 1233 | disk->flags |= GENHD_FL_REMOVABLE; |
| 1169 | sprintf(disk->disk_name, "fd%d", i); | 1234 | sprintf(disk->disk_name, "fd%d", index); |
| 1170 | set_capacity(disk, 2880); | 1235 | set_capacity(disk, 2880); |
| 1171 | add_disk(disk); | 1236 | add_disk(disk); |
| 1172 | 1237 | ||
| @@ -1194,6 +1259,9 @@ static struct macio_driver swim3_driver = | |||
| 1194 | .of_match_table = swim3_match, | 1259 | .of_match_table = swim3_match, |
| 1195 | }, | 1260 | }, |
| 1196 | .probe = swim3_attach, | 1261 | .probe = swim3_attach, |
| 1262 | #ifdef CONFIG_PMAC_MEDIABAY | ||
| 1263 | .mediabay_event = swim3_mb_event, | ||
| 1264 | #endif | ||
| 1197 | #if 0 | 1265 | #if 0 |
| 1198 | .suspend = swim3_suspend, | 1266 | .suspend = swim3_suspend, |
| 1199 | .resume = swim3_resume, | 1267 | .resume = swim3_resume, |
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 11b41fd40c27..5ccf142ef0b8 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig | |||
| @@ -188,7 +188,7 @@ config BT_MRVL | |||
| 188 | The core driver to support Marvell Bluetooth devices. | 188 | The core driver to support Marvell Bluetooth devices. |
| 189 | 189 | ||
| 190 | This driver is required if you want to support | 190 | This driver is required if you want to support |
| 191 | Marvell Bluetooth devices, such as 8688/8787. | 191 | Marvell Bluetooth devices, such as 8688/8787/8797. |
| 192 | 192 | ||
| 193 | Say Y here to compile Marvell Bluetooth driver | 193 | Say Y here to compile Marvell Bluetooth driver |
| 194 | into the kernel or say M to compile it as module. | 194 | into the kernel or say M to compile it as module. |
| @@ -201,8 +201,8 @@ config BT_MRVL_SDIO | |||
| 201 | The driver for Marvell Bluetooth chipsets with SDIO interface. | 201 | The driver for Marvell Bluetooth chipsets with SDIO interface. |
| 202 | 202 | ||
| 203 | This driver is required if you want to use Marvell Bluetooth | 203 | This driver is required if you want to use Marvell Bluetooth |
| 204 | devices with SDIO interface. Currently SD8688/SD8787 chipsets are | 204 | devices with SDIO interface. Currently SD8688/SD8787/SD8797 |
| 205 | supported. | 205 | chipsets are supported. |
| 206 | 206 | ||
| 207 | Say Y here to compile support for Marvell BT-over-SDIO driver | 207 | Say Y here to compile support for Marvell BT-over-SDIO driver |
| 208 | into the kernel or say M to compile it as module. | 208 | into the kernel or say M to compile it as module. |
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index 9ef48167e2cf..27b74b0d547b 100644 --- a/drivers/bluetooth/btmrvl_sdio.c +++ b/drivers/bluetooth/btmrvl_sdio.c | |||
| @@ -65,7 +65,7 @@ static const struct btmrvl_sdio_card_reg btmrvl_reg_8688 = { | |||
| 65 | .io_port_1 = 0x01, | 65 | .io_port_1 = 0x01, |
| 66 | .io_port_2 = 0x02, | 66 | .io_port_2 = 0x02, |
| 67 | }; | 67 | }; |
| 68 | static const struct btmrvl_sdio_card_reg btmrvl_reg_8787 = { | 68 | static const struct btmrvl_sdio_card_reg btmrvl_reg_87xx = { |
| 69 | .cfg = 0x00, | 69 | .cfg = 0x00, |
| 70 | .host_int_mask = 0x02, | 70 | .host_int_mask = 0x02, |
| 71 | .host_intstatus = 0x03, | 71 | .host_intstatus = 0x03, |
| @@ -92,7 +92,14 @@ static const struct btmrvl_sdio_device btmrvl_sdio_sd8688 = { | |||
| 92 | static const struct btmrvl_sdio_device btmrvl_sdio_sd8787 = { | 92 | static const struct btmrvl_sdio_device btmrvl_sdio_sd8787 = { |
| 93 | .helper = NULL, | 93 | .helper = NULL, |
| 94 | .firmware = "mrvl/sd8787_uapsta.bin", | 94 | .firmware = "mrvl/sd8787_uapsta.bin", |
| 95 | .reg = &btmrvl_reg_8787, | 95 | .reg = &btmrvl_reg_87xx, |
| 96 | .sd_blksz_fw_dl = 256, | ||
| 97 | }; | ||
| 98 | |||
| 99 | static const struct btmrvl_sdio_device btmrvl_sdio_sd8797 = { | ||
| 100 | .helper = NULL, | ||
| 101 | .firmware = "mrvl/sd8797_uapsta.bin", | ||
| 102 | .reg = &btmrvl_reg_87xx, | ||
| 96 | .sd_blksz_fw_dl = 256, | 103 | .sd_blksz_fw_dl = 256, |
| 97 | }; | 104 | }; |
| 98 | 105 | ||
| @@ -103,6 +110,9 @@ static const struct sdio_device_id btmrvl_sdio_ids[] = { | |||
| 103 | /* Marvell SD8787 Bluetooth device */ | 110 | /* Marvell SD8787 Bluetooth device */ |
| 104 | { SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, 0x911A), | 111 | { SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, 0x911A), |
| 105 | .driver_data = (unsigned long) &btmrvl_sdio_sd8787 }, | 112 | .driver_data = (unsigned long) &btmrvl_sdio_sd8787 }, |
| 113 | /* Marvell SD8797 Bluetooth device */ | ||
| 114 | { SDIO_DEVICE(SDIO_VENDOR_ID_MARVELL, 0x912A), | ||
| 115 | .driver_data = (unsigned long) &btmrvl_sdio_sd8797 }, | ||
| 106 | 116 | ||
| 107 | { } /* Terminating entry */ | 117 | { } /* Terminating entry */ |
| 108 | }; | 118 | }; |
| @@ -1076,3 +1086,4 @@ MODULE_LICENSE("GPL v2"); | |||
| 1076 | MODULE_FIRMWARE("sd8688_helper.bin"); | 1086 | MODULE_FIRMWARE("sd8688_helper.bin"); |
| 1077 | MODULE_FIRMWARE("sd8688.bin"); | 1087 | MODULE_FIRMWARE("sd8688.bin"); |
| 1078 | MODULE_FIRMWARE("mrvl/sd8787_uapsta.bin"); | 1088 | MODULE_FIRMWARE("mrvl/sd8787_uapsta.bin"); |
| 1089 | MODULE_FIRMWARE("mrvl/sd8797_uapsta.bin"); | ||
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index fe4ebc375b3d..eabc437ce500 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c | |||
| @@ -777,9 +777,8 @@ skip_waking: | |||
| 777 | usb_mark_last_busy(data->udev); | 777 | usb_mark_last_busy(data->udev); |
| 778 | } | 778 | } |
| 779 | 779 | ||
| 780 | usb_free_urb(urb); | ||
| 781 | |||
| 782 | done: | 780 | done: |
| 781 | usb_free_urb(urb); | ||
| 783 | return err; | 782 | return err; |
| 784 | } | 783 | } |
| 785 | 784 | ||
diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c index 5c6f56f21443..dcd8babae9eb 100644 --- a/drivers/crypto/mv_cesa.c +++ b/drivers/crypto/mv_cesa.c | |||
| @@ -343,11 +343,13 @@ static void mv_process_hash_current(int first_block) | |||
| 343 | else | 343 | else |
| 344 | op.config |= CFG_MID_FRAG; | 344 | op.config |= CFG_MID_FRAG; |
| 345 | 345 | ||
| 346 | writel(req_ctx->state[0], cpg->reg + DIGEST_INITIAL_VAL_A); | 346 | if (first_block) { |
| 347 | writel(req_ctx->state[1], cpg->reg + DIGEST_INITIAL_VAL_B); | 347 | writel(req_ctx->state[0], cpg->reg + DIGEST_INITIAL_VAL_A); |
| 348 | writel(req_ctx->state[2], cpg->reg + DIGEST_INITIAL_VAL_C); | 348 | writel(req_ctx->state[1], cpg->reg + DIGEST_INITIAL_VAL_B); |
| 349 | writel(req_ctx->state[3], cpg->reg + DIGEST_INITIAL_VAL_D); | 349 | writel(req_ctx->state[2], cpg->reg + DIGEST_INITIAL_VAL_C); |
| 350 | writel(req_ctx->state[4], cpg->reg + DIGEST_INITIAL_VAL_E); | 350 | writel(req_ctx->state[3], cpg->reg + DIGEST_INITIAL_VAL_D); |
| 351 | writel(req_ctx->state[4], cpg->reg + DIGEST_INITIAL_VAL_E); | ||
| 352 | } | ||
| 351 | } | 353 | } |
| 352 | 354 | ||
| 353 | memcpy(cpg->sram + SRAM_CONFIG, &op, sizeof(struct sec_accel_config)); | 355 | memcpy(cpg->sram + SRAM_CONFIG, &op, sizeof(struct sec_accel_config)); |
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 8f0491037080..464fa2147dfb 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig | |||
| @@ -65,4 +65,17 @@ config DEVFREQ_GOV_USERSPACE | |||
| 65 | 65 | ||
| 66 | comment "DEVFREQ Drivers" | 66 | comment "DEVFREQ Drivers" |
| 67 | 67 | ||
| 68 | config ARM_EXYNOS4_BUS_DEVFREQ | ||
| 69 | bool "ARM Exynos4210/4212/4412 Memory Bus DEVFREQ Driver" | ||
| 70 | depends on CPU_EXYNOS4210 || CPU_EXYNOS4212 || CPU_EXYNOS4412 | ||
| 71 | select ARCH_HAS_OPP | ||
| 72 | select DEVFREQ_GOV_SIMPLE_ONDEMAND | ||
| 73 | help | ||
| 74 | This adds the DEVFREQ driver for Exynos4210 memory bus (vdd_int) | ||
| 75 | and Exynos4212/4412 memory interface and bus (vdd_mif + vdd_int). | ||
| 76 | It reads PPMU counters of memory controllers and adjusts | ||
| 77 | the operating frequencies and voltages with OPP support. | ||
| 78 | To operate with optimal voltages, ASV support is required | ||
| 79 | (CONFIG_EXYNOS_ASV). | ||
| 80 | |||
| 68 | endif # PM_DEVFREQ | 81 | endif # PM_DEVFREQ |
diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile index 4564a89e970a..8c464234f7e7 100644 --- a/drivers/devfreq/Makefile +++ b/drivers/devfreq/Makefile | |||
| @@ -3,3 +3,6 @@ obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o | |||
| 3 | obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o | 3 | obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o |
| 4 | obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o | 4 | obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o |
| 5 | obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o | 5 | obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o |
| 6 | |||
| 7 | # DEVFREQ Drivers | ||
| 8 | obj-$(CONFIG_ARM_EXYNOS4_BUS_DEVFREQ) += exynos4_bus.o | ||
diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c new file mode 100644 index 000000000000..6460577d6701 --- /dev/null +++ b/drivers/devfreq/exynos4_bus.c | |||
| @@ -0,0 +1,1135 @@ | |||
| 1 | /* drivers/devfreq/exynos4210_memorybus.c | ||
| 2 | * | ||
| 3 | * Copyright (c) 2011 Samsung Electronics Co., Ltd. | ||
| 4 | * http://www.samsung.com/ | ||
| 5 | * MyungJoo Ham <myungjoo.ham@samsung.com> | ||
| 6 | * | ||
| 7 | * EXYNOS4 - Memory/Bus clock frequency scaling support in DEVFREQ framework | ||
| 8 | * This version supports EXYNOS4210 only. This changes bus frequencies | ||
| 9 | * and vddint voltages. Exynos4412/4212 should be able to be supported | ||
| 10 | * with minor modifications. | ||
| 11 | * | ||
| 12 | * This program is free software; you can redistribute it and/or modify | ||
| 13 | * it under the terms of the GNU General Public License version 2 as | ||
| 14 | * published by the Free Software Foundation. | ||
| 15 | * | ||
| 16 | */ | ||
| 17 | |||
| 18 | #include <linux/io.h> | ||
| 19 | #include <linux/slab.h> | ||
| 20 | #include <linux/mutex.h> | ||
| 21 | #include <linux/suspend.h> | ||
| 22 | #include <linux/opp.h> | ||
| 23 | #include <linux/devfreq.h> | ||
| 24 | #include <linux/platform_device.h> | ||
| 25 | #include <linux/regulator/consumer.h> | ||
| 26 | #include <linux/module.h> | ||
| 27 | |||
| 28 | /* Exynos4 ASV has been in the mailing list, but not upstreamed, yet. */ | ||
| 29 | #ifdef CONFIG_EXYNOS_ASV | ||
| 30 | extern unsigned int exynos_result_of_asv; | ||
| 31 | #endif | ||
| 32 | |||
| 33 | #include <mach/regs-clock.h> | ||
| 34 | |||
| 35 | #include <plat/map-s5p.h> | ||
| 36 | |||
| 37 | #define MAX_SAFEVOLT 1200000 /* 1.2V */ | ||
| 38 | |||
| 39 | enum exynos4_busf_type { | ||
| 40 | TYPE_BUSF_EXYNOS4210, | ||
| 41 | TYPE_BUSF_EXYNOS4x12, | ||
| 42 | }; | ||
| 43 | |||
| 44 | /* Assume that the bus is saturated if the utilization is 40% */ | ||
| 45 | #define BUS_SATURATION_RATIO 40 | ||
| 46 | |||
| 47 | enum ppmu_counter { | ||
| 48 | PPMU_PMNCNT0 = 0, | ||
| 49 | PPMU_PMCCNT1, | ||
| 50 | PPMU_PMNCNT2, | ||
| 51 | PPMU_PMNCNT3, | ||
| 52 | PPMU_PMNCNT_MAX, | ||
| 53 | }; | ||
| 54 | struct exynos4_ppmu { | ||
| 55 | void __iomem *hw_base; | ||
| 56 | unsigned int ccnt; | ||
| 57 | unsigned int event; | ||
| 58 | unsigned int count[PPMU_PMNCNT_MAX]; | ||
| 59 | bool ccnt_overflow; | ||
| 60 | bool count_overflow[PPMU_PMNCNT_MAX]; | ||
| 61 | }; | ||
| 62 | |||
| 63 | enum busclk_level_idx { | ||
| 64 | LV_0 = 0, | ||
| 65 | LV_1, | ||
| 66 | LV_2, | ||
| 67 | LV_3, | ||
| 68 | LV_4, | ||
| 69 | _LV_END | ||
| 70 | }; | ||
| 71 | #define EX4210_LV_MAX LV_2 | ||
| 72 | #define EX4x12_LV_MAX LV_4 | ||
| 73 | #define EX4210_LV_NUM (LV_2 + 1) | ||
| 74 | #define EX4x12_LV_NUM (LV_4 + 1) | ||
| 75 | |||
| 76 | struct busfreq_data { | ||
| 77 | enum exynos4_busf_type type; | ||
| 78 | struct device *dev; | ||
| 79 | struct devfreq *devfreq; | ||
| 80 | bool disabled; | ||
| 81 | struct regulator *vdd_int; | ||
| 82 | struct regulator *vdd_mif; /* Exynos4412/4212 only */ | ||
| 83 | struct opp *curr_opp; | ||
| 84 | struct exynos4_ppmu dmc[2]; | ||
| 85 | |||
| 86 | struct notifier_block pm_notifier; | ||
| 87 | struct mutex lock; | ||
| 88 | |||
| 89 | /* Dividers calculated at boot/probe-time */ | ||
| 90 | unsigned int dmc_divtable[_LV_END]; /* DMC0 */ | ||
| 91 | unsigned int top_divtable[_LV_END]; | ||
| 92 | }; | ||
| 93 | |||
| 94 | struct bus_opp_table { | ||
| 95 | unsigned int idx; | ||
| 96 | unsigned long clk; | ||
| 97 | unsigned long volt; | ||
| 98 | }; | ||
| 99 | |||
| 100 | /* 4210 controls clock of mif and voltage of int */ | ||
| 101 | static struct bus_opp_table exynos4210_busclk_table[] = { | ||
| 102 | {LV_0, 400000, 1150000}, | ||
| 103 | {LV_1, 267000, 1050000}, | ||
| 104 | {LV_2, 133000, 1025000}, | ||
| 105 | {0, 0, 0}, | ||
| 106 | }; | ||
| 107 | |||
| 108 | /* | ||
| 109 | * MIF is the main control knob clock for exynox4x12 MIF/INT | ||
| 110 | * clock and voltage of both mif/int are controlled. | ||
| 111 | */ | ||
| 112 | static struct bus_opp_table exynos4x12_mifclk_table[] = { | ||
| 113 | {LV_0, 400000, 1100000}, | ||
| 114 | {LV_1, 267000, 1000000}, | ||
| 115 | {LV_2, 160000, 950000}, | ||
| 116 | {LV_3, 133000, 950000}, | ||
| 117 | {LV_4, 100000, 950000}, | ||
| 118 | {0, 0, 0}, | ||
| 119 | }; | ||
| 120 | |||
| 121 | /* | ||
| 122 | * INT is not the control knob of 4x12. LV_x is not meant to represent | ||
| 123 | * the current performance. (MIF does) | ||
| 124 | */ | ||
| 125 | static struct bus_opp_table exynos4x12_intclk_table[] = { | ||
| 126 | {LV_0, 200000, 1000000}, | ||
| 127 | {LV_1, 160000, 950000}, | ||
| 128 | {LV_2, 133000, 925000}, | ||
| 129 | {LV_3, 100000, 900000}, | ||
| 130 | {0, 0, 0}, | ||
| 131 | }; | ||
| 132 | |||
| 133 | /* TODO: asv volt definitions are "__initdata"? */ | ||
| 134 | /* Some chips have different operating voltages */ | ||
| 135 | static unsigned int exynos4210_asv_volt[][EX4210_LV_NUM] = { | ||
| 136 | {1150000, 1050000, 1050000}, | ||
| 137 | {1125000, 1025000, 1025000}, | ||
| 138 | {1100000, 1000000, 1000000}, | ||
| 139 | {1075000, 975000, 975000}, | ||
| 140 | {1050000, 950000, 950000}, | ||
| 141 | }; | ||
| 142 | |||
| 143 | static unsigned int exynos4x12_mif_step_50[][EX4x12_LV_NUM] = { | ||
| 144 | /* 400 267 160 133 100 */ | ||
| 145 | {1050000, 950000, 900000, 900000, 900000}, /* ASV0 */ | ||
| 146 | {1050000, 950000, 900000, 900000, 900000}, /* ASV1 */ | ||
| 147 | {1050000, 950000, 900000, 900000, 900000}, /* ASV2 */ | ||
| 148 | {1050000, 900000, 900000, 900000, 900000}, /* ASV3 */ | ||
| 149 | {1050000, 900000, 900000, 900000, 850000}, /* ASV4 */ | ||
| 150 | {1050000, 900000, 900000, 850000, 850000}, /* ASV5 */ | ||
| 151 | {1050000, 900000, 850000, 850000, 850000}, /* ASV6 */ | ||
| 152 | {1050000, 900000, 850000, 850000, 850000}, /* ASV7 */ | ||
| 153 | {1050000, 900000, 850000, 850000, 850000}, /* ASV8 */ | ||
| 154 | }; | ||
| 155 | |||
| 156 | static unsigned int exynos4x12_int_volt[][EX4x12_LV_NUM] = { | ||
| 157 | /* 200 160 133 100 */ | ||
| 158 | {1000000, 950000, 925000, 900000}, /* ASV0 */ | ||
| 159 | {975000, 925000, 925000, 900000}, /* ASV1 */ | ||
| 160 | {950000, 925000, 900000, 875000}, /* ASV2 */ | ||
| 161 | {950000, 900000, 900000, 875000}, /* ASV3 */ | ||
| 162 | {925000, 875000, 875000, 875000}, /* ASV4 */ | ||
| 163 | {900000, 850000, 850000, 850000}, /* ASV5 */ | ||
| 164 | {900000, 850000, 850000, 850000}, /* ASV6 */ | ||
| 165 | {900000, 850000, 850000, 850000}, /* ASV7 */ | ||
| 166 | {900000, 850000, 850000, 850000}, /* ASV8 */ | ||
| 167 | }; | ||
| 168 | |||
| 169 | /*** Clock Divider Data for Exynos4210 ***/ | ||
| 170 | static unsigned int exynos4210_clkdiv_dmc0[][8] = { | ||
| 171 | /* | ||
| 172 | * Clock divider value for following | ||
| 173 | * { DIVACP, DIVACP_PCLK, DIVDPHY, DIVDMC, DIVDMCD | ||
| 174 | * DIVDMCP, DIVCOPY2, DIVCORE_TIMERS } | ||
| 175 | */ | ||
| 176 | |||
| 177 | /* DMC L0: 400MHz */ | ||
| 178 | { 3, 1, 1, 1, 1, 1, 3, 1 }, | ||
| 179 | /* DMC L1: 266.7MHz */ | ||
| 180 | { 4, 1, 1, 2, 1, 1, 3, 1 }, | ||
| 181 | /* DMC L2: 133MHz */ | ||
| 182 | { 5, 1, 1, 5, 1, 1, 3, 1 }, | ||
| 183 | }; | ||
| 184 | static unsigned int exynos4210_clkdiv_top[][5] = { | ||
| 185 | /* | ||
| 186 | * Clock divider value for following | ||
| 187 | * { DIVACLK200, DIVACLK100, DIVACLK160, DIVACLK133, DIVONENAND } | ||
| 188 | */ | ||
| 189 | /* ACLK200 L0: 200MHz */ | ||
| 190 | { 3, 7, 4, 5, 1 }, | ||
| 191 | /* ACLK200 L1: 160MHz */ | ||
| 192 | { 4, 7, 5, 6, 1 }, | ||
| 193 | /* ACLK200 L2: 133MHz */ | ||
| 194 | { 5, 7, 7, 7, 1 }, | ||
| 195 | }; | ||
| 196 | static unsigned int exynos4210_clkdiv_lr_bus[][2] = { | ||
| 197 | /* | ||
| 198 | * Clock divider value for following | ||
| 199 | * { DIVGDL/R, DIVGPL/R } | ||
| 200 | */ | ||
| 201 | /* ACLK_GDL/R L1: 200MHz */ | ||
| 202 | { 3, 1 }, | ||
| 203 | /* ACLK_GDL/R L2: 160MHz */ | ||
| 204 | { 4, 1 }, | ||
| 205 | /* ACLK_GDL/R L3: 133MHz */ | ||
| 206 | { 5, 1 }, | ||
| 207 | }; | ||
| 208 | |||
| 209 | /*** Clock Divider Data for Exynos4212/4412 ***/ | ||
| 210 | static unsigned int exynos4x12_clkdiv_dmc0[][6] = { | ||
| 211 | /* | ||
| 212 | * Clock divider value for following | ||
| 213 | * { DIVACP, DIVACP_PCLK, DIVDPHY, DIVDMC, DIVDMCD | ||
| 214 | * DIVDMCP} | ||
| 215 | */ | ||
| 216 | |||
| 217 | /* DMC L0: 400MHz */ | ||
| 218 | {3, 1, 1, 1, 1, 1}, | ||
| 219 | /* DMC L1: 266.7MHz */ | ||
| 220 | {4, 1, 1, 2, 1, 1}, | ||
| 221 | /* DMC L2: 160MHz */ | ||
| 222 | {5, 1, 1, 4, 1, 1}, | ||
| 223 | /* DMC L3: 133MHz */ | ||
| 224 | {5, 1, 1, 5, 1, 1}, | ||
| 225 | /* DMC L4: 100MHz */ | ||
| 226 | {7, 1, 1, 7, 1, 1}, | ||
| 227 | }; | ||
| 228 | static unsigned int exynos4x12_clkdiv_dmc1[][6] = { | ||
| 229 | /* | ||
| 230 | * Clock divider value for following | ||
| 231 | * { G2DACP, DIVC2C, DIVC2C_ACLK } | ||
| 232 | */ | ||
| 233 | |||
| 234 | /* DMC L0: 400MHz */ | ||
| 235 | {3, 1, 1}, | ||
| 236 | /* DMC L1: 266.7MHz */ | ||
| 237 | {4, 2, 1}, | ||
| 238 | /* DMC L2: 160MHz */ | ||
| 239 | {5, 4, 1}, | ||
| 240 | /* DMC L3: 133MHz */ | ||
| 241 | {5, 5, 1}, | ||
| 242 | /* DMC L4: 100MHz */ | ||
| 243 | {7, 7, 1}, | ||
| 244 | }; | ||
| 245 | static unsigned int exynos4x12_clkdiv_top[][5] = { | ||
| 246 | /* | ||
| 247 | * Clock divider value for following | ||
| 248 | * { DIVACLK266_GPS, DIVACLK100, DIVACLK160, | ||
| 249 | DIVACLK133, DIVONENAND } | ||
| 250 | */ | ||
| 251 | |||
| 252 | /* ACLK_GDL/R L0: 200MHz */ | ||
| 253 | {2, 7, 4, 5, 1}, | ||
| 254 | /* ACLK_GDL/R L1: 200MHz */ | ||
| 255 | {2, 7, 4, 5, 1}, | ||
| 256 | /* ACLK_GDL/R L2: 160MHz */ | ||
| 257 | {4, 7, 5, 7, 1}, | ||
| 258 | /* ACLK_GDL/R L3: 133MHz */ | ||
| 259 | {4, 7, 5, 7, 1}, | ||
| 260 | /* ACLK_GDL/R L4: 100MHz */ | ||
| 261 | {7, 7, 7, 7, 1}, | ||
| 262 | }; | ||
| 263 | static unsigned int exynos4x12_clkdiv_lr_bus[][2] = { | ||
| 264 | /* | ||
| 265 | * Clock divider value for following | ||
| 266 | * { DIVGDL/R, DIVGPL/R } | ||
| 267 | */ | ||
| 268 | |||
| 269 | /* ACLK_GDL/R L0: 200MHz */ | ||
| 270 | {3, 1}, | ||
| 271 | /* ACLK_GDL/R L1: 200MHz */ | ||
| 272 | {3, 1}, | ||
| 273 | /* ACLK_GDL/R L2: 160MHz */ | ||
| 274 | {4, 1}, | ||
| 275 | /* ACLK_GDL/R L3: 133MHz */ | ||
| 276 | {5, 1}, | ||
| 277 | /* ACLK_GDL/R L4: 100MHz */ | ||
| 278 | {7, 1}, | ||
| 279 | }; | ||
| 280 | static unsigned int exynos4x12_clkdiv_sclkip[][3] = { | ||
| 281 | /* | ||
| 282 | * Clock divider value for following | ||
| 283 | * { DIVMFC, DIVJPEG, DIVFIMC0~3} | ||
| 284 | */ | ||
| 285 | |||
| 286 | /* SCLK_MFC: 200MHz */ | ||
| 287 | {3, 3, 4}, | ||
| 288 | /* SCLK_MFC: 200MHz */ | ||
| 289 | {3, 3, 4}, | ||
| 290 | /* SCLK_MFC: 160MHz */ | ||
| 291 | {4, 4, 5}, | ||
| 292 | /* SCLK_MFC: 133MHz */ | ||
| 293 | {5, 5, 5}, | ||
| 294 | /* SCLK_MFC: 100MHz */ | ||
| 295 | {7, 7, 7}, | ||
| 296 | }; | ||
| 297 | |||
| 298 | |||
| 299 | static int exynos4210_set_busclk(struct busfreq_data *data, struct opp *opp) | ||
| 300 | { | ||
| 301 | unsigned int index; | ||
| 302 | unsigned int tmp; | ||
| 303 | |||
| 304 | for (index = LV_0; index < EX4210_LV_NUM; index++) | ||
| 305 | if (opp_get_freq(opp) == exynos4210_busclk_table[index].clk) | ||
| 306 | break; | ||
| 307 | |||
| 308 | if (index == EX4210_LV_NUM) | ||
| 309 | return -EINVAL; | ||
| 310 | |||
| 311 | /* Change Divider - DMC0 */ | ||
| 312 | tmp = data->dmc_divtable[index]; | ||
| 313 | |||
| 314 | __raw_writel(tmp, S5P_CLKDIV_DMC0); | ||
| 315 | |||
| 316 | do { | ||
| 317 | tmp = __raw_readl(S5P_CLKDIV_STAT_DMC0); | ||
| 318 | } while (tmp & 0x11111111); | ||
| 319 | |||
| 320 | /* Change Divider - TOP */ | ||
| 321 | tmp = data->top_divtable[index]; | ||
| 322 | |||
| 323 | __raw_writel(tmp, S5P_CLKDIV_TOP); | ||
| 324 | |||
| 325 | do { | ||
| 326 | tmp = __raw_readl(S5P_CLKDIV_STAT_TOP); | ||
| 327 | } while (tmp & 0x11111); | ||
| 328 | |||
| 329 | /* Change Divider - LEFTBUS */ | ||
| 330 | tmp = __raw_readl(S5P_CLKDIV_LEFTBUS); | ||
| 331 | |||
| 332 | tmp &= ~(S5P_CLKDIV_BUS_GDLR_MASK | S5P_CLKDIV_BUS_GPLR_MASK); | ||
| 333 | |||
| 334 | tmp |= ((exynos4210_clkdiv_lr_bus[index][0] << | ||
| 335 | S5P_CLKDIV_BUS_GDLR_SHIFT) | | ||
| 336 | (exynos4210_clkdiv_lr_bus[index][1] << | ||
| 337 | S5P_CLKDIV_BUS_GPLR_SHIFT)); | ||
| 338 | |||
| 339 | __raw_writel(tmp, S5P_CLKDIV_LEFTBUS); | ||
| 340 | |||
| 341 | do { | ||
| 342 | tmp = __raw_readl(S5P_CLKDIV_STAT_LEFTBUS); | ||
| 343 | } while (tmp & 0x11); | ||
| 344 | |||
| 345 | /* Change Divider - RIGHTBUS */ | ||
| 346 | tmp = __raw_readl(S5P_CLKDIV_RIGHTBUS); | ||
| 347 | |||
| 348 | tmp &= ~(S5P_CLKDIV_BUS_GDLR_MASK | S5P_CLKDIV_BUS_GPLR_MASK); | ||
| 349 | |||
| 350 | tmp |= ((exynos4210_clkdiv_lr_bus[index][0] << | ||
| 351 | S5P_CLKDIV_BUS_GDLR_SHIFT) | | ||
| 352 | (exynos4210_clkdiv_lr_bus[index][1] << | ||
| 353 | S5P_CLKDIV_BUS_GPLR_SHIFT)); | ||
| 354 | |||
| 355 | __raw_writel(tmp, S5P_CLKDIV_RIGHTBUS); | ||
| 356 | |||
| 357 | do { | ||
| 358 | tmp = __raw_readl(S5P_CLKDIV_STAT_RIGHTBUS); | ||
| 359 | } while (tmp & 0x11); | ||
| 360 | |||
| 361 | return 0; | ||
| 362 | } | ||
| 363 | |||
| 364 | static int exynos4x12_set_busclk(struct busfreq_data *data, struct opp *opp) | ||
| 365 | { | ||
| 366 | unsigned int index; | ||
| 367 | unsigned int tmp; | ||
| 368 | |||
| 369 | for (index = LV_0; index < EX4x12_LV_NUM; index++) | ||
| 370 | if (opp_get_freq(opp) == exynos4x12_mifclk_table[index].clk) | ||
| 371 | break; | ||
| 372 | |||
| 373 | if (index == EX4x12_LV_NUM) | ||
| 374 | return -EINVAL; | ||
| 375 | |||
| 376 | /* Change Divider - DMC0 */ | ||
| 377 | tmp = data->dmc_divtable[index]; | ||
| 378 | |||
| 379 | __raw_writel(tmp, S5P_CLKDIV_DMC0); | ||
| 380 | |||
| 381 | do { | ||
| 382 | tmp = __raw_readl(S5P_CLKDIV_STAT_DMC0); | ||
| 383 | } while (tmp & 0x11111111); | ||
| 384 | |||
| 385 | /* Change Divider - DMC1 */ | ||
| 386 | tmp = __raw_readl(S5P_CLKDIV_DMC1); | ||
| 387 | |||
| 388 | tmp &= ~(S5P_CLKDIV_DMC1_G2D_ACP_MASK | | ||
| 389 | S5P_CLKDIV_DMC1_C2C_MASK | | ||
| 390 | S5P_CLKDIV_DMC1_C2CACLK_MASK); | ||
| 391 | |||
| 392 | tmp |= ((exynos4x12_clkdiv_dmc1[index][0] << | ||
| 393 | S5P_CLKDIV_DMC1_G2D_ACP_SHIFT) | | ||
| 394 | (exynos4x12_clkdiv_dmc1[index][1] << | ||
| 395 | S5P_CLKDIV_DMC1_C2C_SHIFT) | | ||
| 396 | (exynos4x12_clkdiv_dmc1[index][2] << | ||
| 397 | S5P_CLKDIV_DMC1_C2CACLK_SHIFT)); | ||
| 398 | |||
| 399 | __raw_writel(tmp, S5P_CLKDIV_DMC1); | ||
| 400 | |||
| 401 | do { | ||
| 402 | tmp = __raw_readl(S5P_CLKDIV_STAT_DMC1); | ||
| 403 | } while (tmp & 0x111111); | ||
| 404 | |||
| 405 | /* Change Divider - TOP */ | ||
| 406 | tmp = __raw_readl(S5P_CLKDIV_TOP); | ||
| 407 | |||
| 408 | tmp &= ~(S5P_CLKDIV_TOP_ACLK266_GPS_MASK | | ||
| 409 | S5P_CLKDIV_TOP_ACLK100_MASK | | ||
| 410 | S5P_CLKDIV_TOP_ACLK160_MASK | | ||
| 411 | S5P_CLKDIV_TOP_ACLK133_MASK | | ||
| 412 | S5P_CLKDIV_TOP_ONENAND_MASK); | ||
| 413 | |||
| 414 | tmp |= ((exynos4x12_clkdiv_top[index][0] << | ||
| 415 | S5P_CLKDIV_TOP_ACLK266_GPS_SHIFT) | | ||
| 416 | (exynos4x12_clkdiv_top[index][1] << | ||
| 417 | S5P_CLKDIV_TOP_ACLK100_SHIFT) | | ||
| 418 | (exynos4x12_clkdiv_top[index][2] << | ||
| 419 | S5P_CLKDIV_TOP_ACLK160_SHIFT) | | ||
| 420 | (exynos4x12_clkdiv_top[index][3] << | ||
| 421 | S5P_CLKDIV_TOP_ACLK133_SHIFT) | | ||
| 422 | (exynos4x12_clkdiv_top[index][4] << | ||
| 423 | S5P_CLKDIV_TOP_ONENAND_SHIFT)); | ||
| 424 | |||
| 425 | __raw_writel(tmp, S5P_CLKDIV_TOP); | ||
| 426 | |||
| 427 | do { | ||
| 428 | tmp = __raw_readl(S5P_CLKDIV_STAT_TOP); | ||
| 429 | } while (tmp & 0x11111); | ||
| 430 | |||
| 431 | /* Change Divider - LEFTBUS */ | ||
| 432 | tmp = __raw_readl(S5P_CLKDIV_LEFTBUS); | ||
| 433 | |||
| 434 | tmp &= ~(S5P_CLKDIV_BUS_GDLR_MASK | S5P_CLKDIV_BUS_GPLR_MASK); | ||
| 435 | |||
| 436 | tmp |= ((exynos4x12_clkdiv_lr_bus[index][0] << | ||
| 437 | S5P_CLKDIV_BUS_GDLR_SHIFT) | | ||
| 438 | (exynos4x12_clkdiv_lr_bus[index][1] << | ||
| 439 | S5P_CLKDIV_BUS_GPLR_SHIFT)); | ||
| 440 | |||
| 441 | __raw_writel(tmp, S5P_CLKDIV_LEFTBUS); | ||
| 442 | |||
| 443 | do { | ||
| 444 | tmp = __raw_readl(S5P_CLKDIV_STAT_LEFTBUS); | ||
| 445 | } while (tmp & 0x11); | ||
| 446 | |||
| 447 | /* Change Divider - RIGHTBUS */ | ||
| 448 | tmp = __raw_readl(S5P_CLKDIV_RIGHTBUS); | ||
| 449 | |||
| 450 | tmp &= ~(S5P_CLKDIV_BUS_GDLR_MASK | S5P_CLKDIV_BUS_GPLR_MASK); | ||
| 451 | |||
| 452 | tmp |= ((exynos4x12_clkdiv_lr_bus[index][0] << | ||
| 453 | S5P_CLKDIV_BUS_GDLR_SHIFT) | | ||
| 454 | (exynos4x12_clkdiv_lr_bus[index][1] << | ||
| 455 | S5P_CLKDIV_BUS_GPLR_SHIFT)); | ||
| 456 | |||
| 457 | __raw_writel(tmp, S5P_CLKDIV_RIGHTBUS); | ||
| 458 | |||
| 459 | do { | ||
| 460 | tmp = __raw_readl(S5P_CLKDIV_STAT_RIGHTBUS); | ||
| 461 | } while (tmp & 0x11); | ||
| 462 | |||
| 463 | /* Change Divider - MFC */ | ||
| 464 | tmp = __raw_readl(S5P_CLKDIV_MFC); | ||
| 465 | |||
| 466 | tmp &= ~(S5P_CLKDIV_MFC_MASK); | ||
| 467 | |||
| 468 | tmp |= ((exynos4x12_clkdiv_sclkip[index][0] << | ||
| 469 | S5P_CLKDIV_MFC_SHIFT)); | ||
| 470 | |||
| 471 | __raw_writel(tmp, S5P_CLKDIV_MFC); | ||
| 472 | |||
| 473 | do { | ||
| 474 | tmp = __raw_readl(S5P_CLKDIV_STAT_MFC); | ||
| 475 | } while (tmp & 0x1); | ||
| 476 | |||
| 477 | /* Change Divider - JPEG */ | ||
| 478 | tmp = __raw_readl(S5P_CLKDIV_CAM1); | ||
| 479 | |||
| 480 | tmp &= ~(S5P_CLKDIV_CAM1_JPEG_MASK); | ||
| 481 | |||
| 482 | tmp |= ((exynos4x12_clkdiv_sclkip[index][1] << | ||
| 483 | S5P_CLKDIV_CAM1_JPEG_SHIFT)); | ||
| 484 | |||
| 485 | __raw_writel(tmp, S5P_CLKDIV_CAM1); | ||
| 486 | |||
| 487 | do { | ||
| 488 | tmp = __raw_readl(S5P_CLKDIV_STAT_CAM1); | ||
| 489 | } while (tmp & 0x1); | ||
| 490 | |||
| 491 | /* Change Divider - FIMC0~3 */ | ||
| 492 | tmp = __raw_readl(S5P_CLKDIV_CAM); | ||
| 493 | |||
| 494 | tmp &= ~(S5P_CLKDIV_CAM_FIMC0_MASK | S5P_CLKDIV_CAM_FIMC1_MASK | | ||
| 495 | S5P_CLKDIV_CAM_FIMC2_MASK | S5P_CLKDIV_CAM_FIMC3_MASK); | ||
| 496 | |||
| 497 | tmp |= ((exynos4x12_clkdiv_sclkip[index][2] << | ||
| 498 | S5P_CLKDIV_CAM_FIMC0_SHIFT) | | ||
| 499 | (exynos4x12_clkdiv_sclkip[index][2] << | ||
| 500 | S5P_CLKDIV_CAM_FIMC1_SHIFT) | | ||
| 501 | (exynos4x12_clkdiv_sclkip[index][2] << | ||
| 502 | S5P_CLKDIV_CAM_FIMC2_SHIFT) | | ||
| 503 | (exynos4x12_clkdiv_sclkip[index][2] << | ||
| 504 | S5P_CLKDIV_CAM_FIMC3_SHIFT)); | ||
| 505 | |||
| 506 | __raw_writel(tmp, S5P_CLKDIV_CAM); | ||
| 507 | |||
| 508 | do { | ||
| 509 | tmp = __raw_readl(S5P_CLKDIV_STAT_CAM1); | ||
| 510 | } while (tmp & 0x1111); | ||
| 511 | |||
| 512 | return 0; | ||
| 513 | } | ||
| 514 | |||
| 515 | |||
| 516 | static void busfreq_mon_reset(struct busfreq_data *data) | ||
| 517 | { | ||
| 518 | unsigned int i; | ||
| 519 | |||
| 520 | for (i = 0; i < 2; i++) { | ||
| 521 | void __iomem *ppmu_base = data->dmc[i].hw_base; | ||
| 522 | |||
| 523 | /* Reset PPMU */ | ||
| 524 | __raw_writel(0x8000000f, ppmu_base + 0xf010); | ||
| 525 | __raw_writel(0x8000000f, ppmu_base + 0xf050); | ||
| 526 | __raw_writel(0x6, ppmu_base + 0xf000); | ||
| 527 | __raw_writel(0x0, ppmu_base + 0xf100); | ||
| 528 | |||
| 529 | /* Set PPMU Event */ | ||
| 530 | data->dmc[i].event = 0x6; | ||
| 531 | __raw_writel(((data->dmc[i].event << 12) | 0x1), | ||
| 532 | ppmu_base + 0xfc); | ||
| 533 | |||
| 534 | /* Start PPMU */ | ||
| 535 | __raw_writel(0x1, ppmu_base + 0xf000); | ||
| 536 | } | ||
| 537 | } | ||
| 538 | |||
| 539 | static void exynos4_read_ppmu(struct busfreq_data *data) | ||
| 540 | { | ||
| 541 | int i, j; | ||
| 542 | |||
| 543 | for (i = 0; i < 2; i++) { | ||
| 544 | void __iomem *ppmu_base = data->dmc[i].hw_base; | ||
| 545 | u32 overflow; | ||
| 546 | |||
| 547 | /* Stop PPMU */ | ||
| 548 | __raw_writel(0x0, ppmu_base + 0xf000); | ||
| 549 | |||
| 550 | /* Update local data from PPMU */ | ||
| 551 | overflow = __raw_readl(ppmu_base + 0xf050); | ||
| 552 | |||
| 553 | data->dmc[i].ccnt = __raw_readl(ppmu_base + 0xf100); | ||
| 554 | data->dmc[i].ccnt_overflow = overflow & (1 << 31); | ||
| 555 | |||
| 556 | for (j = 0; j < PPMU_PMNCNT_MAX; j++) { | ||
| 557 | data->dmc[i].count[j] = __raw_readl( | ||
| 558 | ppmu_base + (0xf110 + (0x10 * j))); | ||
| 559 | data->dmc[i].count_overflow[j] = overflow & (1 << j); | ||
| 560 | } | ||
| 561 | } | ||
| 562 | |||
| 563 | busfreq_mon_reset(data); | ||
| 564 | } | ||
| 565 | |||
| 566 | static int exynos4x12_get_intspec(unsigned long mifclk) | ||
| 567 | { | ||
| 568 | int i = 0; | ||
| 569 | |||
| 570 | while (exynos4x12_intclk_table[i].clk) { | ||
| 571 | if (exynos4x12_intclk_table[i].clk <= mifclk) | ||
| 572 | return i; | ||
| 573 | i++; | ||
| 574 | } | ||
| 575 | |||
| 576 | return -EINVAL; | ||
| 577 | } | ||
| 578 | |||
| 579 | static int exynos4_bus_setvolt(struct busfreq_data *data, struct opp *opp, | ||
| 580 | struct opp *oldopp) | ||
| 581 | { | ||
| 582 | int err = 0, tmp; | ||
| 583 | unsigned long volt = opp_get_voltage(opp); | ||
| 584 | |||
| 585 | switch (data->type) { | ||
| 586 | case TYPE_BUSF_EXYNOS4210: | ||
| 587 | /* OPP represents DMC clock + INT voltage */ | ||
| 588 | err = regulator_set_voltage(data->vdd_int, volt, | ||
| 589 | MAX_SAFEVOLT); | ||
| 590 | break; | ||
| 591 | case TYPE_BUSF_EXYNOS4x12: | ||
| 592 | /* OPP represents MIF clock + MIF voltage */ | ||
| 593 | err = regulator_set_voltage(data->vdd_mif, volt, | ||
| 594 | MAX_SAFEVOLT); | ||
| 595 | if (err) | ||
| 596 | break; | ||
| 597 | |||
| 598 | tmp = exynos4x12_get_intspec(opp_get_freq(opp)); | ||
| 599 | if (tmp < 0) { | ||
| 600 | err = tmp; | ||
| 601 | regulator_set_voltage(data->vdd_mif, | ||
| 602 | opp_get_voltage(oldopp), | ||
| 603 | MAX_SAFEVOLT); | ||
| 604 | break; | ||
| 605 | } | ||
| 606 | err = regulator_set_voltage(data->vdd_int, | ||
| 607 | exynos4x12_intclk_table[tmp].volt, | ||
| 608 | MAX_SAFEVOLT); | ||
| 609 | /* Try to recover */ | ||
| 610 | if (err) | ||
| 611 | regulator_set_voltage(data->vdd_mif, | ||
| 612 | opp_get_voltage(oldopp), | ||
| 613 | MAX_SAFEVOLT); | ||
| 614 | break; | ||
| 615 | default: | ||
| 616 | err = -EINVAL; | ||
| 617 | } | ||
| 618 | |||
| 619 | return err; | ||
| 620 | } | ||
| 621 | |||
| 622 | static int exynos4_bus_target(struct device *dev, unsigned long *_freq) | ||
| 623 | { | ||
| 624 | int err = 0; | ||
| 625 | struct platform_device *pdev = container_of(dev, struct platform_device, | ||
| 626 | dev); | ||
| 627 | struct busfreq_data *data = platform_get_drvdata(pdev); | ||
| 628 | struct opp *opp = devfreq_recommended_opp(dev, _freq); | ||
| 629 | unsigned long old_freq = opp_get_freq(data->curr_opp); | ||
| 630 | unsigned long freq = opp_get_freq(opp); | ||
| 631 | |||
| 632 | if (old_freq == freq) | ||
| 633 | return 0; | ||
| 634 | |||
| 635 | dev_dbg(dev, "targetting %lukHz %luuV\n", freq, opp_get_voltage(opp)); | ||
| 636 | |||
| 637 | mutex_lock(&data->lock); | ||
| 638 | |||
| 639 | if (data->disabled) | ||
| 640 | goto out; | ||
| 641 | |||
| 642 | if (old_freq < freq) | ||
| 643 | err = exynos4_bus_setvolt(data, opp, data->curr_opp); | ||
| 644 | if (err) | ||
| 645 | goto out; | ||
| 646 | |||
| 647 | if (old_freq != freq) { | ||
| 648 | switch (data->type) { | ||
| 649 | case TYPE_BUSF_EXYNOS4210: | ||
| 650 | err = exynos4210_set_busclk(data, opp); | ||
| 651 | break; | ||
| 652 | case TYPE_BUSF_EXYNOS4x12: | ||
| 653 | err = exynos4x12_set_busclk(data, opp); | ||
| 654 | break; | ||
| 655 | default: | ||
| 656 | err = -EINVAL; | ||
| 657 | } | ||
| 658 | } | ||
| 659 | if (err) | ||
| 660 | goto out; | ||
| 661 | |||
| 662 | if (old_freq > freq) | ||
| 663 | err = exynos4_bus_setvolt(data, opp, data->curr_opp); | ||
| 664 | if (err) | ||
| 665 | goto out; | ||
| 666 | |||
| 667 | data->curr_opp = opp; | ||
| 668 | out: | ||
| 669 | mutex_unlock(&data->lock); | ||
| 670 | return err; | ||
| 671 | } | ||
| 672 | |||
| 673 | static int exynos4_get_busier_dmc(struct busfreq_data *data) | ||
| 674 | { | ||
| 675 | u64 p0 = data->dmc[0].count[0]; | ||
| 676 | u64 p1 = data->dmc[1].count[0]; | ||
| 677 | |||
| 678 | p0 *= data->dmc[1].ccnt; | ||
| 679 | p1 *= data->dmc[0].ccnt; | ||
| 680 | |||
| 681 | if (data->dmc[1].ccnt == 0) | ||
| 682 | return 0; | ||
| 683 | |||
| 684 | if (p0 > p1) | ||
| 685 | return 0; | ||
| 686 | return 1; | ||
| 687 | } | ||
| 688 | |||
| 689 | static int exynos4_bus_get_dev_status(struct device *dev, | ||
| 690 | struct devfreq_dev_status *stat) | ||
| 691 | { | ||
| 692 | struct platform_device *pdev = container_of(dev, struct platform_device, | ||
| 693 | dev); | ||
| 694 | struct busfreq_data *data = platform_get_drvdata(pdev); | ||
| 695 | int busier_dmc; | ||
| 696 | int cycles_x2 = 2; /* 2 x cycles */ | ||
| 697 | void __iomem *addr; | ||
| 698 | u32 timing; | ||
| 699 | u32 memctrl; | ||
| 700 | |||
| 701 | exynos4_read_ppmu(data); | ||
| 702 | busier_dmc = exynos4_get_busier_dmc(data); | ||
| 703 | stat->current_frequency = opp_get_freq(data->curr_opp); | ||
| 704 | |||
| 705 | if (busier_dmc) | ||
| 706 | addr = S5P_VA_DMC1; | ||
| 707 | else | ||
| 708 | addr = S5P_VA_DMC0; | ||
| 709 | |||
| 710 | memctrl = __raw_readl(addr + 0x04); /* one of DDR2/3/LPDDR2 */ | ||
| 711 | timing = __raw_readl(addr + 0x38); /* CL or WL/RL values */ | ||
| 712 | |||
| 713 | switch ((memctrl >> 8) & 0xf) { | ||
| 714 | case 0x4: /* DDR2 */ | ||
| 715 | cycles_x2 = ((timing >> 16) & 0xf) * 2; | ||
| 716 | break; | ||
| 717 | case 0x5: /* LPDDR2 */ | ||
| 718 | case 0x6: /* DDR3 */ | ||
| 719 | cycles_x2 = ((timing >> 8) & 0xf) + ((timing >> 0) & 0xf); | ||
| 720 | break; | ||
| 721 | default: | ||
| 722 | pr_err("%s: Unknown Memory Type(%d).\n", __func__, | ||
| 723 | (memctrl >> 8) & 0xf); | ||
| 724 | return -EINVAL; | ||
| 725 | } | ||
| 726 | |||
| 727 | /* Number of cycles spent on memory access */ | ||
| 728 | stat->busy_time = data->dmc[busier_dmc].count[0] / 2 * (cycles_x2 + 2); | ||
| 729 | stat->busy_time *= 100 / BUS_SATURATION_RATIO; | ||
| 730 | stat->total_time = data->dmc[busier_dmc].ccnt; | ||
| 731 | |||
| 732 | /* If the counters have overflown, retry */ | ||
| 733 | if (data->dmc[busier_dmc].ccnt_overflow || | ||
| 734 | data->dmc[busier_dmc].count_overflow[0]) | ||
| 735 | return -EAGAIN; | ||
| 736 | |||
| 737 | return 0; | ||
| 738 | } | ||
| 739 | |||
| 740 | static void exynos4_bus_exit(struct device *dev) | ||
| 741 | { | ||
| 742 | struct platform_device *pdev = container_of(dev, struct platform_device, | ||
| 743 | dev); | ||
| 744 | struct busfreq_data *data = platform_get_drvdata(pdev); | ||
| 745 | |||
| 746 | devfreq_unregister_opp_notifier(dev, data->devfreq); | ||
| 747 | } | ||
| 748 | |||
| 749 | static struct devfreq_dev_profile exynos4_devfreq_profile = { | ||
| 750 | .initial_freq = 400000, | ||
| 751 | .polling_ms = 50, | ||
| 752 | .target = exynos4_bus_target, | ||
| 753 | .get_dev_status = exynos4_bus_get_dev_status, | ||
| 754 | .exit = exynos4_bus_exit, | ||
| 755 | }; | ||
| 756 | |||
| 757 | static int exynos4210_init_tables(struct busfreq_data *data) | ||
| 758 | { | ||
| 759 | u32 tmp; | ||
| 760 | int mgrp; | ||
| 761 | int i, err = 0; | ||
| 762 | |||
| 763 | tmp = __raw_readl(S5P_CLKDIV_DMC0); | ||
| 764 | for (i = LV_0; i < EX4210_LV_NUM; i++) { | ||
| 765 | tmp &= ~(S5P_CLKDIV_DMC0_ACP_MASK | | ||
| 766 | S5P_CLKDIV_DMC0_ACPPCLK_MASK | | ||
| 767 | S5P_CLKDIV_DMC0_DPHY_MASK | | ||
| 768 | S5P_CLKDIV_DMC0_DMC_MASK | | ||
| 769 | S5P_CLKDIV_DMC0_DMCD_MASK | | ||
| 770 | S5P_CLKDIV_DMC0_DMCP_MASK | | ||
| 771 | S5P_CLKDIV_DMC0_COPY2_MASK | | ||
| 772 | S5P_CLKDIV_DMC0_CORETI_MASK); | ||
| 773 | |||
| 774 | tmp |= ((exynos4210_clkdiv_dmc0[i][0] << | ||
| 775 | S5P_CLKDIV_DMC0_ACP_SHIFT) | | ||
| 776 | (exynos4210_clkdiv_dmc0[i][1] << | ||
| 777 | S5P_CLKDIV_DMC0_ACPPCLK_SHIFT) | | ||
| 778 | (exynos4210_clkdiv_dmc0[i][2] << | ||
| 779 | S5P_CLKDIV_DMC0_DPHY_SHIFT) | | ||
| 780 | (exynos4210_clkdiv_dmc0[i][3] << | ||
| 781 | S5P_CLKDIV_DMC0_DMC_SHIFT) | | ||
| 782 | (exynos4210_clkdiv_dmc0[i][4] << | ||
| 783 | S5P_CLKDIV_DMC0_DMCD_SHIFT) | | ||
| 784 | (exynos4210_clkdiv_dmc0[i][5] << | ||
| 785 | S5P_CLKDIV_DMC0_DMCP_SHIFT) | | ||
| 786 | (exynos4210_clkdiv_dmc0[i][6] << | ||
| 787 | S5P_CLKDIV_DMC0_COPY2_SHIFT) | | ||
| 788 | (exynos4210_clkdiv_dmc0[i][7] << | ||
| 789 | S5P_CLKDIV_DMC0_CORETI_SHIFT)); | ||
| 790 | |||
| 791 | data->dmc_divtable[i] = tmp; | ||
| 792 | } | ||
| 793 | |||
| 794 | tmp = __raw_readl(S5P_CLKDIV_TOP); | ||
| 795 | for (i = LV_0; i < EX4210_LV_NUM; i++) { | ||
| 796 | tmp &= ~(S5P_CLKDIV_TOP_ACLK200_MASK | | ||
| 797 | S5P_CLKDIV_TOP_ACLK100_MASK | | ||
| 798 | S5P_CLKDIV_TOP_ACLK160_MASK | | ||
| 799 | S5P_CLKDIV_TOP_ACLK133_MASK | | ||
| 800 | S5P_CLKDIV_TOP_ONENAND_MASK); | ||
| 801 | |||
| 802 | tmp |= ((exynos4210_clkdiv_top[i][0] << | ||
| 803 | S5P_CLKDIV_TOP_ACLK200_SHIFT) | | ||
| 804 | (exynos4210_clkdiv_top[i][1] << | ||
| 805 | S5P_CLKDIV_TOP_ACLK100_SHIFT) | | ||
| 806 | (exynos4210_clkdiv_top[i][2] << | ||
| 807 | S5P_CLKDIV_TOP_ACLK160_SHIFT) | | ||
| 808 | (exynos4210_clkdiv_top[i][3] << | ||
| 809 | S5P_CLKDIV_TOP_ACLK133_SHIFT) | | ||
| 810 | (exynos4210_clkdiv_top[i][4] << | ||
| 811 | S5P_CLKDIV_TOP_ONENAND_SHIFT)); | ||
| 812 | |||
| 813 | data->top_divtable[i] = tmp; | ||
| 814 | } | ||
| 815 | |||
| 816 | #ifdef CONFIG_EXYNOS_ASV | ||
| 817 | tmp = exynos4_result_of_asv; | ||
| 818 | #else | ||
| 819 | tmp = 0; /* Max voltages for the reliability of the unknown */ | ||
| 820 | #endif | ||
| 821 | |||
| 822 | pr_debug("ASV Group of Exynos4 is %d\n", tmp); | ||
| 823 | /* Use merged grouping for voltage */ | ||
| 824 | switch (tmp) { | ||
| 825 | case 0: | ||
| 826 | mgrp = 0; | ||
| 827 | break; | ||
| 828 | case 1: | ||
| 829 | case 2: | ||
| 830 | mgrp = 1; | ||
| 831 | break; | ||
| 832 | case 3: | ||
| 833 | case 4: | ||
| 834 | mgrp = 2; | ||
| 835 | break; | ||
| 836 | case 5: | ||
| 837 | case 6: | ||
| 838 | mgrp = 3; | ||
| 839 | break; | ||
| 840 | case 7: | ||
| 841 | mgrp = 4; | ||
| 842 | break; | ||
| 843 | default: | ||
| 844 | pr_warn("Unknown ASV Group. Use max voltage.\n"); | ||
| 845 | mgrp = 0; | ||
| 846 | } | ||
| 847 | |||
| 848 | for (i = LV_0; i < EX4210_LV_NUM; i++) | ||
| 849 | exynos4210_busclk_table[i].volt = exynos4210_asv_volt[mgrp][i]; | ||
| 850 | |||
| 851 | for (i = LV_0; i < EX4210_LV_NUM; i++) { | ||
| 852 | err = opp_add(data->dev, exynos4210_busclk_table[i].clk, | ||
| 853 | exynos4210_busclk_table[i].volt); | ||
| 854 | if (err) { | ||
| 855 | dev_err(data->dev, "Cannot add opp entries.\n"); | ||
| 856 | return err; | ||
| 857 | } | ||
| 858 | } | ||
| 859 | |||
| 860 | |||
| 861 | return 0; | ||
| 862 | } | ||
| 863 | |||
| 864 | static int exynos4x12_init_tables(struct busfreq_data *data) | ||
| 865 | { | ||
| 866 | unsigned int i; | ||
| 867 | unsigned int tmp; | ||
| 868 | int ret; | ||
| 869 | |||
| 870 | /* Enable pause function for DREX2 DVFS */ | ||
| 871 | tmp = __raw_readl(S5P_DMC_PAUSE_CTRL); | ||
| 872 | tmp |= DMC_PAUSE_ENABLE; | ||
| 873 | __raw_writel(tmp, S5P_DMC_PAUSE_CTRL); | ||
| 874 | |||
| 875 | tmp = __raw_readl(S5P_CLKDIV_DMC0); | ||
| 876 | |||
| 877 | for (i = 0; i < EX4x12_LV_NUM; i++) { | ||
| 878 | tmp &= ~(S5P_CLKDIV_DMC0_ACP_MASK | | ||
| 879 | S5P_CLKDIV_DMC0_ACPPCLK_MASK | | ||
| 880 | S5P_CLKDIV_DMC0_DPHY_MASK | | ||
| 881 | S5P_CLKDIV_DMC0_DMC_MASK | | ||
| 882 | S5P_CLKDIV_DMC0_DMCD_MASK | | ||
| 883 | S5P_CLKDIV_DMC0_DMCP_MASK); | ||
| 884 | |||
| 885 | tmp |= ((exynos4x12_clkdiv_dmc0[i][0] << | ||
| 886 | S5P_CLKDIV_DMC0_ACP_SHIFT) | | ||
| 887 | (exynos4x12_clkdiv_dmc0[i][1] << | ||
| 888 | S5P_CLKDIV_DMC0_ACPPCLK_SHIFT) | | ||
| 889 | (exynos4x12_clkdiv_dmc0[i][2] << | ||
| 890 | S5P_CLKDIV_DMC0_DPHY_SHIFT) | | ||
| 891 | (exynos4x12_clkdiv_dmc0[i][3] << | ||
| 892 | S5P_CLKDIV_DMC0_DMC_SHIFT) | | ||
| 893 | (exynos4x12_clkdiv_dmc0[i][4] << | ||
| 894 | S5P_CLKDIV_DMC0_DMCD_SHIFT) | | ||
| 895 | (exynos4x12_clkdiv_dmc0[i][5] << | ||
| 896 | S5P_CLKDIV_DMC0_DMCP_SHIFT)); | ||
| 897 | |||
| 898 | data->dmc_divtable[i] = tmp; | ||
| 899 | } | ||
| 900 | |||
| 901 | #ifdef CONFIG_EXYNOS_ASV | ||
| 902 | tmp = exynos4_result_of_asv; | ||
| 903 | #else | ||
| 904 | tmp = 0; /* Max voltages for the reliability of the unknown */ | ||
| 905 | #endif | ||
| 906 | |||
| 907 | if (tmp > 8) | ||
| 908 | tmp = 0; | ||
| 909 | pr_debug("ASV Group of Exynos4x12 is %d\n", tmp); | ||
| 910 | |||
| 911 | for (i = 0; i < EX4x12_LV_NUM; i++) { | ||
| 912 | exynos4x12_mifclk_table[i].volt = | ||
| 913 | exynos4x12_mif_step_50[tmp][i]; | ||
| 914 | exynos4x12_intclk_table[i].volt = | ||
| 915 | exynos4x12_int_volt[tmp][i]; | ||
| 916 | } | ||
| 917 | |||
| 918 | for (i = 0; i < EX4x12_LV_NUM; i++) { | ||
| 919 | ret = opp_add(data->dev, exynos4x12_mifclk_table[i].clk, | ||
| 920 | exynos4x12_mifclk_table[i].volt); | ||
| 921 | if (ret) { | ||
| 922 | dev_err(data->dev, "Fail to add opp entries.\n"); | ||
| 923 | return ret; | ||
| 924 | } | ||
| 925 | } | ||
| 926 | |||
| 927 | return 0; | ||
| 928 | } | ||
| 929 | |||
| 930 | static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this, | ||
| 931 | unsigned long event, void *ptr) | ||
| 932 | { | ||
| 933 | struct busfreq_data *data = container_of(this, struct busfreq_data, | ||
| 934 | pm_notifier); | ||
| 935 | struct opp *opp; | ||
| 936 | unsigned long maxfreq = ULONG_MAX; | ||
| 937 | int err = 0; | ||
| 938 | |||
| 939 | switch (event) { | ||
| 940 | case PM_SUSPEND_PREPARE: | ||
| 941 | /* Set Fastest and Deactivate DVFS */ | ||
| 942 | mutex_lock(&data->lock); | ||
| 943 | |||
| 944 | data->disabled = true; | ||
| 945 | |||
| 946 | opp = opp_find_freq_floor(data->dev, &maxfreq); | ||
| 947 | |||
| 948 | err = exynos4_bus_setvolt(data, opp, data->curr_opp); | ||
| 949 | if (err) | ||
| 950 | goto unlock; | ||
| 951 | |||
| 952 | switch (data->type) { | ||
| 953 | case TYPE_BUSF_EXYNOS4210: | ||
| 954 | err = exynos4210_set_busclk(data, opp); | ||
| 955 | break; | ||
| 956 | case TYPE_BUSF_EXYNOS4x12: | ||
| 957 | err = exynos4x12_set_busclk(data, opp); | ||
| 958 | break; | ||
| 959 | default: | ||
| 960 | err = -EINVAL; | ||
| 961 | } | ||
| 962 | if (err) | ||
| 963 | goto unlock; | ||
| 964 | |||
| 965 | data->curr_opp = opp; | ||
| 966 | unlock: | ||
| 967 | mutex_unlock(&data->lock); | ||
| 968 | if (err) | ||
| 969 | return err; | ||
| 970 | return NOTIFY_OK; | ||
| 971 | case PM_POST_RESTORE: | ||
| 972 | case PM_POST_SUSPEND: | ||
| 973 | /* Reactivate */ | ||
| 974 | mutex_lock(&data->lock); | ||
| 975 | data->disabled = false; | ||
| 976 | mutex_unlock(&data->lock); | ||
| 977 | return NOTIFY_OK; | ||
| 978 | } | ||
| 979 | |||
| 980 | return NOTIFY_DONE; | ||
| 981 | } | ||
| 982 | |||
| 983 | static __devinit int exynos4_busfreq_probe(struct platform_device *pdev) | ||
| 984 | { | ||
| 985 | struct busfreq_data *data; | ||
| 986 | struct opp *opp; | ||
| 987 | struct device *dev = &pdev->dev; | ||
| 988 | int err = 0; | ||
| 989 | |||
| 990 | data = kzalloc(sizeof(struct busfreq_data), GFP_KERNEL); | ||
| 991 | if (data == NULL) { | ||
| 992 | dev_err(dev, "Cannot allocate memory.\n"); | ||
| 993 | return -ENOMEM; | ||
| 994 | } | ||
| 995 | |||
| 996 | data->type = pdev->id_entry->driver_data; | ||
| 997 | data->dmc[0].hw_base = S5P_VA_DMC0; | ||
| 998 | data->dmc[1].hw_base = S5P_VA_DMC1; | ||
| 999 | data->pm_notifier.notifier_call = exynos4_busfreq_pm_notifier_event; | ||
| 1000 | data->dev = dev; | ||
| 1001 | mutex_init(&data->lock); | ||
| 1002 | |||
| 1003 | switch (data->type) { | ||
| 1004 | case TYPE_BUSF_EXYNOS4210: | ||
| 1005 | err = exynos4210_init_tables(data); | ||
| 1006 | break; | ||
| 1007 | case TYPE_BUSF_EXYNOS4x12: | ||
| 1008 | err = exynos4x12_init_tables(data); | ||
| 1009 | break; | ||
| 1010 | default: | ||
| 1011 | dev_err(dev, "Cannot determine the device id %d\n", data->type); | ||
| 1012 | err = -EINVAL; | ||
| 1013 | } | ||
| 1014 | if (err) | ||
| 1015 | goto err_regulator; | ||
| 1016 | |||
| 1017 | data->vdd_int = regulator_get(dev, "vdd_int"); | ||
| 1018 | if (IS_ERR(data->vdd_int)) { | ||
| 1019 | dev_err(dev, "Cannot get the regulator \"vdd_int\"\n"); | ||
| 1020 | err = PTR_ERR(data->vdd_int); | ||
| 1021 | goto err_regulator; | ||
| 1022 | } | ||
| 1023 | if (data->type == TYPE_BUSF_EXYNOS4x12) { | ||
| 1024 | data->vdd_mif = regulator_get(dev, "vdd_mif"); | ||
| 1025 | if (IS_ERR(data->vdd_mif)) { | ||
| 1026 | dev_err(dev, "Cannot get the regulator \"vdd_mif\"\n"); | ||
| 1027 | err = PTR_ERR(data->vdd_mif); | ||
| 1028 | regulator_put(data->vdd_int); | ||
| 1029 | goto err_regulator; | ||
| 1030 | |||
| 1031 | } | ||
| 1032 | } | ||
| 1033 | |||
| 1034 | opp = opp_find_freq_floor(dev, &exynos4_devfreq_profile.initial_freq); | ||
| 1035 | if (IS_ERR(opp)) { | ||
| 1036 | dev_err(dev, "Invalid initial frequency %lu kHz.\n", | ||
| 1037 | exynos4_devfreq_profile.initial_freq); | ||
| 1038 | err = PTR_ERR(opp); | ||
| 1039 | goto err_opp_add; | ||
| 1040 | } | ||
| 1041 | data->curr_opp = opp; | ||
| 1042 | |||
| 1043 | platform_set_drvdata(pdev, data); | ||
| 1044 | |||
| 1045 | busfreq_mon_reset(data); | ||
| 1046 | |||
| 1047 | data->devfreq = devfreq_add_device(dev, &exynos4_devfreq_profile, | ||
| 1048 | &devfreq_simple_ondemand, NULL); | ||
| 1049 | if (IS_ERR(data->devfreq)) { | ||
| 1050 | err = PTR_ERR(data->devfreq); | ||
| 1051 | goto err_opp_add; | ||
| 1052 | } | ||
| 1053 | |||
| 1054 | devfreq_register_opp_notifier(dev, data->devfreq); | ||
| 1055 | |||
| 1056 | err = register_pm_notifier(&data->pm_notifier); | ||
| 1057 | if (err) { | ||
| 1058 | dev_err(dev, "Failed to setup pm notifier\n"); | ||
| 1059 | goto err_devfreq_add; | ||
| 1060 | } | ||
| 1061 | |||
| 1062 | return 0; | ||
| 1063 | err_devfreq_add: | ||
| 1064 | devfreq_remove_device(data->devfreq); | ||
| 1065 | err_opp_add: | ||
| 1066 | if (data->vdd_mif) | ||
| 1067 | regulator_put(data->vdd_mif); | ||
| 1068 | regulator_put(data->vdd_int); | ||
| 1069 | err_regulator: | ||
| 1070 | kfree(data); | ||
| 1071 | return err; | ||
| 1072 | } | ||
| 1073 | |||
| 1074 | static __devexit int exynos4_busfreq_remove(struct platform_device *pdev) | ||
| 1075 | { | ||
| 1076 | struct busfreq_data *data = platform_get_drvdata(pdev); | ||
| 1077 | |||
| 1078 | unregister_pm_notifier(&data->pm_notifier); | ||
| 1079 | devfreq_remove_device(data->devfreq); | ||
| 1080 | regulator_put(data->vdd_int); | ||
| 1081 | if (data->vdd_mif) | ||
| 1082 | regulator_put(data->vdd_mif); | ||
| 1083 | kfree(data); | ||
| 1084 | |||
| 1085 | return 0; | ||
| 1086 | } | ||
| 1087 | |||
| 1088 | static int exynos4_busfreq_resume(struct device *dev) | ||
| 1089 | { | ||
| 1090 | struct platform_device *pdev = container_of(dev, struct platform_device, | ||
| 1091 | dev); | ||
| 1092 | struct busfreq_data *data = platform_get_drvdata(pdev); | ||
| 1093 | |||
| 1094 | busfreq_mon_reset(data); | ||
| 1095 | return 0; | ||
| 1096 | } | ||
| 1097 | |||
| 1098 | static const struct dev_pm_ops exynos4_busfreq_pm = { | ||
| 1099 | .resume = exynos4_busfreq_resume, | ||
| 1100 | }; | ||
| 1101 | |||
| 1102 | static const struct platform_device_id exynos4_busfreq_id[] = { | ||
| 1103 | { "exynos4210-busfreq", TYPE_BUSF_EXYNOS4210 }, | ||
| 1104 | { "exynos4412-busfreq", TYPE_BUSF_EXYNOS4x12 }, | ||
| 1105 | { "exynos4212-busfreq", TYPE_BUSF_EXYNOS4x12 }, | ||
| 1106 | { }, | ||
| 1107 | }; | ||
| 1108 | |||
| 1109 | static struct platform_driver exynos4_busfreq_driver = { | ||
| 1110 | .probe = exynos4_busfreq_probe, | ||
| 1111 | .remove = __devexit_p(exynos4_busfreq_remove), | ||
| 1112 | .id_table = exynos4_busfreq_id, | ||
| 1113 | .driver = { | ||
| 1114 | .name = "exynos4-busfreq", | ||
| 1115 | .owner = THIS_MODULE, | ||
| 1116 | .pm = &exynos4_busfreq_pm, | ||
| 1117 | }, | ||
| 1118 | }; | ||
| 1119 | |||
| 1120 | static int __init exynos4_busfreq_init(void) | ||
| 1121 | { | ||
| 1122 | return platform_driver_register(&exynos4_busfreq_driver); | ||
| 1123 | } | ||
| 1124 | late_initcall(exynos4_busfreq_init); | ||
| 1125 | |||
| 1126 | static void __exit exynos4_busfreq_exit(void) | ||
| 1127 | { | ||
| 1128 | platform_driver_unregister(&exynos4_busfreq_driver); | ||
| 1129 | } | ||
| 1130 | module_exit(exynos4_busfreq_exit); | ||
| 1131 | |||
| 1132 | MODULE_LICENSE("GPL"); | ||
| 1133 | MODULE_DESCRIPTION("EXYNOS4 busfreq driver with devfreq framework"); | ||
| 1134 | MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>"); | ||
| 1135 | MODULE_ALIAS("exynos4-busfreq"); | ||
diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c index 8af8e864a9cf..73464a62adf7 100644 --- a/drivers/edac/mpc85xx_edac.c +++ b/drivers/edac/mpc85xx_edac.c | |||
| @@ -1128,7 +1128,7 @@ static struct of_device_id mpc85xx_mc_err_of_match[] = { | |||
| 1128 | { .compatible = "fsl,p1020-memory-controller", }, | 1128 | { .compatible = "fsl,p1020-memory-controller", }, |
| 1129 | { .compatible = "fsl,p1021-memory-controller", }, | 1129 | { .compatible = "fsl,p1021-memory-controller", }, |
| 1130 | { .compatible = "fsl,p2020-memory-controller", }, | 1130 | { .compatible = "fsl,p2020-memory-controller", }, |
| 1131 | { .compatible = "fsl,p4080-memory-controller", }, | 1131 | { .compatible = "fsl,qoriq-memory-controller", }, |
| 1132 | {}, | 1132 | {}, |
| 1133 | }; | 1133 | }; |
| 1134 | MODULE_DEVICE_TABLE(of, mpc85xx_mc_err_of_match); | 1134 | MODULE_DEVICE_TABLE(of, mpc85xx_mc_err_of_match); |
diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 8370f72d87ff..b0a81173a268 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c | |||
| @@ -457,7 +457,8 @@ static int efi_pstore_close(struct pstore_info *psi) | |||
| 457 | } | 457 | } |
| 458 | 458 | ||
| 459 | static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, | 459 | static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, |
| 460 | struct timespec *timespec, struct pstore_info *psi) | 460 | struct timespec *timespec, |
| 461 | char **buf, struct pstore_info *psi) | ||
| 461 | { | 462 | { |
| 462 | efi_guid_t vendor = LINUX_EFI_CRASH_GUID; | 463 | efi_guid_t vendor = LINUX_EFI_CRASH_GUID; |
| 463 | struct efivars *efivars = psi->data; | 464 | struct efivars *efivars = psi->data; |
| @@ -478,7 +479,11 @@ static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, | |||
| 478 | timespec->tv_nsec = 0; | 479 | timespec->tv_nsec = 0; |
| 479 | get_var_data_locked(efivars, &efivars->walk_entry->var); | 480 | get_var_data_locked(efivars, &efivars->walk_entry->var); |
| 480 | size = efivars->walk_entry->var.DataSize; | 481 | size = efivars->walk_entry->var.DataSize; |
| 481 | memcpy(psi->buf, efivars->walk_entry->var.Data, size); | 482 | *buf = kmalloc(size, GFP_KERNEL); |
| 483 | if (*buf == NULL) | ||
| 484 | return -ENOMEM; | ||
| 485 | memcpy(*buf, efivars->walk_entry->var.Data, | ||
| 486 | size); | ||
| 482 | efivars->walk_entry = list_entry(efivars->walk_entry->list.next, | 487 | efivars->walk_entry = list_entry(efivars->walk_entry->list.next, |
| 483 | struct efivar_entry, list); | 488 | struct efivar_entry, list); |
| 484 | return size; | 489 | return size; |
| @@ -576,7 +581,8 @@ static int efi_pstore_close(struct pstore_info *psi) | |||
| 576 | } | 581 | } |
| 577 | 582 | ||
| 578 | static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, | 583 | static ssize_t efi_pstore_read(u64 *id, enum pstore_type_id *type, |
| 579 | struct timespec *time, struct pstore_info *psi) | 584 | struct timespec *timespec, |
| 585 | char **buf, struct pstore_info *psi) | ||
| 580 | { | 586 | { |
| 581 | return -1; | 587 | return -1; |
| 582 | } | 588 | } |
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index c811cb107904..2cce44a1d7d0 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c | |||
| @@ -746,6 +746,37 @@ static void __exit ibft_exit(void) | |||
| 746 | ibft_cleanup(); | 746 | ibft_cleanup(); |
| 747 | } | 747 | } |
| 748 | 748 | ||
| 749 | #ifdef CONFIG_ACPI | ||
| 750 | static const struct { | ||
| 751 | char *sign; | ||
| 752 | } ibft_signs[] = { | ||
| 753 | /* | ||
| 754 | * One spec says "IBFT", the other says "iBFT". We have to check | ||
| 755 | * for both. | ||
| 756 | */ | ||
| 757 | { ACPI_SIG_IBFT }, | ||
| 758 | { "iBFT" }, | ||
| 759 | }; | ||
| 760 | |||
| 761 | static void __init acpi_find_ibft_region(void) | ||
| 762 | { | ||
| 763 | int i; | ||
| 764 | struct acpi_table_header *table = NULL; | ||
| 765 | |||
| 766 | if (acpi_disabled) | ||
| 767 | return; | ||
| 768 | |||
| 769 | for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++) { | ||
| 770 | acpi_get_table(ibft_signs[i].sign, 0, &table); | ||
| 771 | ibft_addr = (struct acpi_table_ibft *)table; | ||
| 772 | } | ||
| 773 | } | ||
| 774 | #else | ||
| 775 | static void __init acpi_find_ibft_region(void) | ||
| 776 | { | ||
| 777 | } | ||
| 778 | #endif | ||
| 779 | |||
| 749 | /* | 780 | /* |
| 750 | * ibft_init() - creates sysfs tree entries for the iBFT data. | 781 | * ibft_init() - creates sysfs tree entries for the iBFT data. |
| 751 | */ | 782 | */ |
| @@ -753,9 +784,16 @@ static int __init ibft_init(void) | |||
| 753 | { | 784 | { |
| 754 | int rc = 0; | 785 | int rc = 0; |
| 755 | 786 | ||
| 787 | /* | ||
| 788 | As on UEFI systems the setup_arch()/find_ibft_region() | ||
| 789 | is called before ACPI tables are parsed and it only does | ||
| 790 | legacy finding. | ||
| 791 | */ | ||
| 792 | if (!ibft_addr) | ||
| 793 | acpi_find_ibft_region(); | ||
| 794 | |||
| 756 | if (ibft_addr) { | 795 | if (ibft_addr) { |
| 757 | printk(KERN_INFO "iBFT detected at 0x%llx.\n", | 796 | pr_info("iBFT detected.\n"); |
| 758 | (u64)isa_virt_to_bus(ibft_addr)); | ||
| 759 | 797 | ||
| 760 | rc = ibft_check_device(); | 798 | rc = ibft_check_device(); |
| 761 | if (rc) | 799 | if (rc) |
diff --git a/drivers/firmware/iscsi_ibft_find.c b/drivers/firmware/iscsi_ibft_find.c index bfe723266fd8..4da4eb9ae926 100644 --- a/drivers/firmware/iscsi_ibft_find.c +++ b/drivers/firmware/iscsi_ibft_find.c | |||
| @@ -45,13 +45,6 @@ EXPORT_SYMBOL_GPL(ibft_addr); | |||
| 45 | static const struct { | 45 | static const struct { |
| 46 | char *sign; | 46 | char *sign; |
| 47 | } ibft_signs[] = { | 47 | } ibft_signs[] = { |
| 48 | #ifdef CONFIG_ACPI | ||
| 49 | /* | ||
| 50 | * One spec says "IBFT", the other says "iBFT". We have to check | ||
| 51 | * for both. | ||
| 52 | */ | ||
| 53 | { ACPI_SIG_IBFT }, | ||
| 54 | #endif | ||
| 55 | { "iBFT" }, | 48 | { "iBFT" }, |
| 56 | { "BIFT" }, /* Broadcom iSCSI Offload */ | 49 | { "BIFT" }, /* Broadcom iSCSI Offload */ |
| 57 | }; | 50 | }; |
| @@ -62,14 +55,6 @@ static const struct { | |||
| 62 | #define VGA_MEM 0xA0000 /* VGA buffer */ | 55 | #define VGA_MEM 0xA0000 /* VGA buffer */ |
| 63 | #define VGA_SIZE 0x20000 /* 128kB */ | 56 | #define VGA_SIZE 0x20000 /* 128kB */ |
| 64 | 57 | ||
| 65 | #ifdef CONFIG_ACPI | ||
| 66 | static int __init acpi_find_ibft(struct acpi_table_header *header) | ||
| 67 | { | ||
| 68 | ibft_addr = (struct acpi_table_ibft *)header; | ||
| 69 | return 0; | ||
| 70 | } | ||
| 71 | #endif /* CONFIG_ACPI */ | ||
| 72 | |||
| 73 | static int __init find_ibft_in_mem(void) | 58 | static int __init find_ibft_in_mem(void) |
| 74 | { | 59 | { |
| 75 | unsigned long pos; | 60 | unsigned long pos; |
| @@ -94,6 +79,7 @@ static int __init find_ibft_in_mem(void) | |||
| 94 | * the table cannot be valid. */ | 79 | * the table cannot be valid. */ |
| 95 | if (pos + len <= (IBFT_END-1)) { | 80 | if (pos + len <= (IBFT_END-1)) { |
| 96 | ibft_addr = (struct acpi_table_ibft *)virt; | 81 | ibft_addr = (struct acpi_table_ibft *)virt; |
| 82 | pr_info("iBFT found at 0x%lx.\n", pos); | ||
| 97 | goto done; | 83 | goto done; |
| 98 | } | 84 | } |
| 99 | } | 85 | } |
| @@ -108,20 +94,12 @@ done: | |||
| 108 | */ | 94 | */ |
| 109 | unsigned long __init find_ibft_region(unsigned long *sizep) | 95 | unsigned long __init find_ibft_region(unsigned long *sizep) |
| 110 | { | 96 | { |
| 111 | #ifdef CONFIG_ACPI | ||
| 112 | int i; | ||
| 113 | #endif | ||
| 114 | ibft_addr = NULL; | 97 | ibft_addr = NULL; |
| 115 | 98 | ||
| 116 | #ifdef CONFIG_ACPI | ||
| 117 | for (i = 0; i < ARRAY_SIZE(ibft_signs) && !ibft_addr; i++) | ||
| 118 | acpi_table_parse(ibft_signs[i].sign, acpi_find_ibft); | ||
| 119 | #endif /* CONFIG_ACPI */ | ||
| 120 | |||
| 121 | /* iBFT 1.03 section 1.4.3.1 mandates that UEFI machines will | 99 | /* iBFT 1.03 section 1.4.3.1 mandates that UEFI machines will |
| 122 | * only use ACPI for this */ | 100 | * only use ACPI for this */ |
| 123 | 101 | ||
| 124 | if (!ibft_addr && !efi_enabled) | 102 | if (!efi_enabled) |
| 125 | find_ibft_in_mem(); | 103 | find_ibft_in_mem(); |
| 126 | 104 | ||
| 127 | if (ibft_addr) { | 105 | if (ibft_addr) { |
diff --git a/drivers/firmware/sigma.c b/drivers/firmware/sigma.c index f10fc521951b..1eedb6f7fdab 100644 --- a/drivers/firmware/sigma.c +++ b/drivers/firmware/sigma.c | |||
| @@ -14,13 +14,34 @@ | |||
| 14 | #include <linux/module.h> | 14 | #include <linux/module.h> |
| 15 | #include <linux/sigma.h> | 15 | #include <linux/sigma.h> |
| 16 | 16 | ||
| 17 | /* Return: 0==OK, <0==error, =1 ==no more actions */ | 17 | static size_t sigma_action_size(struct sigma_action *sa) |
| 18 | { | ||
| 19 | size_t payload = 0; | ||
| 20 | |||
| 21 | switch (sa->instr) { | ||
| 22 | case SIGMA_ACTION_WRITEXBYTES: | ||
| 23 | case SIGMA_ACTION_WRITESINGLE: | ||
| 24 | case SIGMA_ACTION_WRITESAFELOAD: | ||
| 25 | payload = sigma_action_len(sa); | ||
| 26 | break; | ||
| 27 | default: | ||
| 28 | break; | ||
| 29 | } | ||
| 30 | |||
| 31 | payload = ALIGN(payload, 2); | ||
| 32 | |||
| 33 | return payload + sizeof(struct sigma_action); | ||
| 34 | } | ||
| 35 | |||
| 36 | /* | ||
| 37 | * Returns a negative error value in case of an error, 0 if processing of | ||
| 38 | * the firmware should be stopped after this action, 1 otherwise. | ||
| 39 | */ | ||
| 18 | static int | 40 | static int |
| 19 | process_sigma_action(struct i2c_client *client, struct sigma_firmware *ssfw) | 41 | process_sigma_action(struct i2c_client *client, struct sigma_action *sa) |
| 20 | { | 42 | { |
| 21 | struct sigma_action *sa = (void *)(ssfw->fw->data + ssfw->pos); | ||
| 22 | size_t len = sigma_action_len(sa); | 43 | size_t len = sigma_action_len(sa); |
| 23 | int ret = 0; | 44 | int ret; |
| 24 | 45 | ||
| 25 | pr_debug("%s: instr:%i addr:%#x len:%zu\n", __func__, | 46 | pr_debug("%s: instr:%i addr:%#x len:%zu\n", __func__, |
| 26 | sa->instr, sa->addr, len); | 47 | sa->instr, sa->addr, len); |
| @@ -29,44 +50,50 @@ process_sigma_action(struct i2c_client *client, struct sigma_firmware *ssfw) | |||
| 29 | case SIGMA_ACTION_WRITEXBYTES: | 50 | case SIGMA_ACTION_WRITEXBYTES: |
| 30 | case SIGMA_ACTION_WRITESINGLE: | 51 | case SIGMA_ACTION_WRITESINGLE: |
| 31 | case SIGMA_ACTION_WRITESAFELOAD: | 52 | case SIGMA_ACTION_WRITESAFELOAD: |
| 32 | if (ssfw->fw->size < ssfw->pos + len) | ||
| 33 | return -EINVAL; | ||
| 34 | ret = i2c_master_send(client, (void *)&sa->addr, len); | 53 | ret = i2c_master_send(client, (void *)&sa->addr, len); |
| 35 | if (ret < 0) | 54 | if (ret < 0) |
| 36 | return -EINVAL; | 55 | return -EINVAL; |
| 37 | break; | 56 | break; |
| 38 | |||
| 39 | case SIGMA_ACTION_DELAY: | 57 | case SIGMA_ACTION_DELAY: |
| 40 | ret = 0; | ||
| 41 | udelay(len); | 58 | udelay(len); |
| 42 | len = 0; | 59 | len = 0; |
| 43 | break; | 60 | break; |
| 44 | |||
| 45 | case SIGMA_ACTION_END: | 61 | case SIGMA_ACTION_END: |
| 46 | return 1; | 62 | return 0; |
| 47 | |||
| 48 | default: | 63 | default: |
| 49 | return -EINVAL; | 64 | return -EINVAL; |
| 50 | } | 65 | } |
| 51 | 66 | ||
| 52 | /* when arrive here ret=0 or sent data */ | 67 | return 1; |
| 53 | ssfw->pos += sigma_action_size(sa, len); | ||
| 54 | return ssfw->pos == ssfw->fw->size; | ||
| 55 | } | 68 | } |
| 56 | 69 | ||
| 57 | static int | 70 | static int |
| 58 | process_sigma_actions(struct i2c_client *client, struct sigma_firmware *ssfw) | 71 | process_sigma_actions(struct i2c_client *client, struct sigma_firmware *ssfw) |
| 59 | { | 72 | { |
| 60 | pr_debug("%s: processing %p\n", __func__, ssfw); | 73 | struct sigma_action *sa; |
| 74 | size_t size; | ||
| 75 | int ret; | ||
| 76 | |||
| 77 | while (ssfw->pos + sizeof(*sa) <= ssfw->fw->size) { | ||
| 78 | sa = (struct sigma_action *)(ssfw->fw->data + ssfw->pos); | ||
| 79 | |||
| 80 | size = sigma_action_size(sa); | ||
| 81 | ssfw->pos += size; | ||
| 82 | if (ssfw->pos > ssfw->fw->size || size == 0) | ||
| 83 | break; | ||
| 84 | |||
| 85 | ret = process_sigma_action(client, sa); | ||
| 61 | 86 | ||
| 62 | while (1) { | ||
| 63 | int ret = process_sigma_action(client, ssfw); | ||
| 64 | pr_debug("%s: action returned %i\n", __func__, ret); | 87 | pr_debug("%s: action returned %i\n", __func__, ret); |
| 65 | if (ret == 1) | 88 | |
| 66 | return 0; | 89 | if (ret <= 0) |
| 67 | else if (ret) | ||
| 68 | return ret; | 90 | return ret; |
| 69 | } | 91 | } |
| 92 | |||
| 93 | if (ssfw->pos != ssfw->fw->size) | ||
| 94 | return -EINVAL; | ||
| 95 | |||
| 96 | return 0; | ||
| 70 | } | 97 | } |
| 71 | 98 | ||
| 72 | int process_sigma_firmware(struct i2c_client *client, const char *name) | 99 | int process_sigma_firmware(struct i2c_client *client, const char *name) |
| @@ -89,16 +116,24 @@ int process_sigma_firmware(struct i2c_client *client, const char *name) | |||
| 89 | 116 | ||
| 90 | /* then verify the header */ | 117 | /* then verify the header */ |
| 91 | ret = -EINVAL; | 118 | ret = -EINVAL; |
| 92 | if (fw->size < sizeof(*ssfw_head)) | 119 | |
| 120 | /* | ||
| 121 | * Reject too small or unreasonable large files. The upper limit has been | ||
| 122 | * chosen a bit arbitrarily, but it should be enough for all practical | ||
| 123 | * purposes and having the limit makes it easier to avoid integer | ||
| 124 | * overflows later in the loading process. | ||
| 125 | */ | ||
| 126 | if (fw->size < sizeof(*ssfw_head) || fw->size >= 0x4000000) | ||
| 93 | goto done; | 127 | goto done; |
| 94 | 128 | ||
| 95 | ssfw_head = (void *)fw->data; | 129 | ssfw_head = (void *)fw->data; |
| 96 | if (memcmp(ssfw_head->magic, SIGMA_MAGIC, ARRAY_SIZE(ssfw_head->magic))) | 130 | if (memcmp(ssfw_head->magic, SIGMA_MAGIC, ARRAY_SIZE(ssfw_head->magic))) |
| 97 | goto done; | 131 | goto done; |
| 98 | 132 | ||
| 99 | crc = crc32(0, fw->data, fw->size); | 133 | crc = crc32(0, fw->data + sizeof(*ssfw_head), |
| 134 | fw->size - sizeof(*ssfw_head)); | ||
| 100 | pr_debug("%s: crc=%x\n", __func__, crc); | 135 | pr_debug("%s: crc=%x\n", __func__, crc); |
| 101 | if (crc != ssfw_head->crc) | 136 | if (crc != le32_to_cpu(ssfw_head->crc)) |
| 102 | goto done; | 137 | goto done; |
| 103 | 138 | ||
| 104 | ssfw.pos = sizeof(*ssfw_head); | 139 | ssfw.pos = sizeof(*ssfw_head); |
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile index dbcb0bcfd8da..4e018d6a7639 100644 --- a/drivers/gpio/Makefile +++ b/drivers/gpio/Makefile | |||
| @@ -18,7 +18,7 @@ obj-$(CONFIG_ARCH_DAVINCI) += gpio-davinci.o | |||
| 18 | obj-$(CONFIG_GPIO_EP93XX) += gpio-ep93xx.o | 18 | obj-$(CONFIG_GPIO_EP93XX) += gpio-ep93xx.o |
| 19 | obj-$(CONFIG_GPIO_IT8761E) += gpio-it8761e.o | 19 | obj-$(CONFIG_GPIO_IT8761E) += gpio-it8761e.o |
| 20 | obj-$(CONFIG_GPIO_JANZ_TTL) += gpio-janz-ttl.o | 20 | obj-$(CONFIG_GPIO_JANZ_TTL) += gpio-janz-ttl.o |
| 21 | obj-$(CONFIG_MACH_KS8695) += gpio-ks8695.o | 21 | obj-$(CONFIG_ARCH_KS8695) += gpio-ks8695.o |
| 22 | obj-$(CONFIG_GPIO_LANGWELL) += gpio-langwell.o | 22 | obj-$(CONFIG_GPIO_LANGWELL) += gpio-langwell.o |
| 23 | obj-$(CONFIG_ARCH_LPC32XX) += gpio-lpc32xx.o | 23 | obj-$(CONFIG_ARCH_LPC32XX) += gpio-lpc32xx.o |
| 24 | obj-$(CONFIG_GPIO_MAX730X) += gpio-max730x.o | 24 | obj-$(CONFIG_GPIO_MAX730X) += gpio-max730x.o |
diff --git a/drivers/gpio/gpio-da9052.c b/drivers/gpio/gpio-da9052.c index 038f5eb8b13d..f8ce29ef9f88 100644 --- a/drivers/gpio/gpio-da9052.c +++ b/drivers/gpio/gpio-da9052.c | |||
| @@ -22,7 +22,6 @@ | |||
| 22 | #include <linux/mfd/da9052/da9052.h> | 22 | #include <linux/mfd/da9052/da9052.h> |
| 23 | #include <linux/mfd/da9052/reg.h> | 23 | #include <linux/mfd/da9052/reg.h> |
| 24 | #include <linux/mfd/da9052/pdata.h> | 24 | #include <linux/mfd/da9052/pdata.h> |
| 25 | #include <linux/mfd/da9052/gpio.h> | ||
| 26 | 25 | ||
| 27 | #define DA9052_INPUT 1 | 26 | #define DA9052_INPUT 1 |
| 28 | #define DA9052_OUTPUT_OPENDRAIN 2 | 27 | #define DA9052_OUTPUT_OPENDRAIN 2 |
| @@ -43,6 +42,9 @@ | |||
| 43 | #define DA9052_GPIO_MASK_UPPER_NIBBLE 0xF0 | 42 | #define DA9052_GPIO_MASK_UPPER_NIBBLE 0xF0 |
| 44 | #define DA9052_GPIO_MASK_LOWER_NIBBLE 0x0F | 43 | #define DA9052_GPIO_MASK_LOWER_NIBBLE 0x0F |
| 45 | #define DA9052_GPIO_NIBBLE_SHIFT 4 | 44 | #define DA9052_GPIO_NIBBLE_SHIFT 4 |
| 45 | #define DA9052_IRQ_GPI0 16 | ||
| 46 | #define DA9052_GPIO_ODD_SHIFT 7 | ||
| 47 | #define DA9052_GPIO_EVEN_SHIFT 3 | ||
| 46 | 48 | ||
| 47 | struct da9052_gpio { | 49 | struct da9052_gpio { |
| 48 | struct da9052 *da9052; | 50 | struct da9052 *da9052; |
| @@ -104,33 +106,26 @@ static int da9052_gpio_get(struct gpio_chip *gc, unsigned offset) | |||
| 104 | static void da9052_gpio_set(struct gpio_chip *gc, unsigned offset, int value) | 106 | static void da9052_gpio_set(struct gpio_chip *gc, unsigned offset, int value) |
| 105 | { | 107 | { |
| 106 | struct da9052_gpio *gpio = to_da9052_gpio(gc); | 108 | struct da9052_gpio *gpio = to_da9052_gpio(gc); |
| 107 | unsigned char register_value = 0; | ||
| 108 | int ret; | 109 | int ret; |
| 109 | 110 | ||
| 110 | if (da9052_gpio_port_odd(offset)) { | 111 | if (da9052_gpio_port_odd(offset)) { |
| 111 | if (value) { | ||
| 112 | register_value = DA9052_GPIO_ODD_PORT_MODE; | ||
| 113 | ret = da9052_reg_update(gpio->da9052, (offset >> 1) + | 112 | ret = da9052_reg_update(gpio->da9052, (offset >> 1) + |
| 114 | DA9052_GPIO_0_1_REG, | 113 | DA9052_GPIO_0_1_REG, |
| 115 | DA9052_GPIO_ODD_PORT_MODE, | 114 | DA9052_GPIO_ODD_PORT_MODE, |
| 116 | register_value); | 115 | value << DA9052_GPIO_ODD_SHIFT); |
| 117 | if (ret != 0) | 116 | if (ret != 0) |
| 118 | dev_err(gpio->da9052->dev, | 117 | dev_err(gpio->da9052->dev, |
| 119 | "Failed to updated gpio odd reg,%d", | 118 | "Failed to updated gpio odd reg,%d", |
| 120 | ret); | 119 | ret); |
| 121 | } | ||
| 122 | } else { | 120 | } else { |
| 123 | if (value) { | ||
| 124 | register_value = DA9052_GPIO_EVEN_PORT_MODE; | ||
| 125 | ret = da9052_reg_update(gpio->da9052, (offset >> 1) + | 121 | ret = da9052_reg_update(gpio->da9052, (offset >> 1) + |
| 126 | DA9052_GPIO_0_1_REG, | 122 | DA9052_GPIO_0_1_REG, |
| 127 | DA9052_GPIO_EVEN_PORT_MODE, | 123 | DA9052_GPIO_EVEN_PORT_MODE, |
| 128 | register_value); | 124 | value << DA9052_GPIO_EVEN_SHIFT); |
| 129 | if (ret != 0) | 125 | if (ret != 0) |
| 130 | dev_err(gpio->da9052->dev, | 126 | dev_err(gpio->da9052->dev, |
| 131 | "Failed to updated gpio even reg,%d", | 127 | "Failed to updated gpio even reg,%d", |
| 132 | ret); | 128 | ret); |
| 133 | } | ||
| 134 | } | 129 | } |
| 135 | } | 130 | } |
| 136 | 131 | ||
| @@ -201,9 +196,9 @@ static struct gpio_chip reference_gp __devinitdata = { | |||
| 201 | .direction_input = da9052_gpio_direction_input, | 196 | .direction_input = da9052_gpio_direction_input, |
| 202 | .direction_output = da9052_gpio_direction_output, | 197 | .direction_output = da9052_gpio_direction_output, |
| 203 | .to_irq = da9052_gpio_to_irq, | 198 | .to_irq = da9052_gpio_to_irq, |
| 204 | .can_sleep = 1; | 199 | .can_sleep = 1, |
| 205 | .ngpio = 16; | 200 | .ngpio = 16, |
| 206 | .base = -1; | 201 | .base = -1, |
| 207 | }; | 202 | }; |
| 208 | 203 | ||
| 209 | static int __devinit da9052_gpio_probe(struct platform_device *pdev) | 204 | static int __devinit da9052_gpio_probe(struct platform_device *pdev) |
diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c index ea8e73869250..461958fc2264 100644 --- a/drivers/gpio/gpio-ml-ioh.c +++ b/drivers/gpio/gpio-ml-ioh.c | |||
| @@ -332,6 +332,34 @@ static void ioh_irq_mask(struct irq_data *d) | |||
| 332 | &chip->reg->regs[chip->ch].imask); | 332 | &chip->reg->regs[chip->ch].imask); |
| 333 | } | 333 | } |
| 334 | 334 | ||
| 335 | static void ioh_irq_disable(struct irq_data *d) | ||
| 336 | { | ||
| 337 | struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); | ||
| 338 | struct ioh_gpio *chip = gc->private; | ||
| 339 | unsigned long flags; | ||
| 340 | u32 ien; | ||
| 341 | |||
| 342 | spin_lock_irqsave(&chip->spinlock, flags); | ||
| 343 | ien = ioread32(&chip->reg->regs[chip->ch].ien); | ||
| 344 | ien &= ~(1 << (d->irq - chip->irq_base)); | ||
| 345 | iowrite32(ien, &chip->reg->regs[chip->ch].ien); | ||
| 346 | spin_unlock_irqrestore(&chip->spinlock, flags); | ||
| 347 | } | ||
| 348 | |||
| 349 | static void ioh_irq_enable(struct irq_data *d) | ||
| 350 | { | ||
| 351 | struct irq_chip_generic *gc = irq_data_get_irq_chip_data(d); | ||
| 352 | struct ioh_gpio *chip = gc->private; | ||
| 353 | unsigned long flags; | ||
| 354 | u32 ien; | ||
| 355 | |||
| 356 | spin_lock_irqsave(&chip->spinlock, flags); | ||
| 357 | ien = ioread32(&chip->reg->regs[chip->ch].ien); | ||
| 358 | ien |= 1 << (d->irq - chip->irq_base); | ||
| 359 | iowrite32(ien, &chip->reg->regs[chip->ch].ien); | ||
| 360 | spin_unlock_irqrestore(&chip->spinlock, flags); | ||
| 361 | } | ||
| 362 | |||
| 335 | static irqreturn_t ioh_gpio_handler(int irq, void *dev_id) | 363 | static irqreturn_t ioh_gpio_handler(int irq, void *dev_id) |
| 336 | { | 364 | { |
| 337 | struct ioh_gpio *chip = dev_id; | 365 | struct ioh_gpio *chip = dev_id; |
| @@ -339,7 +367,7 @@ static irqreturn_t ioh_gpio_handler(int irq, void *dev_id) | |||
| 339 | int i, j; | 367 | int i, j; |
| 340 | int ret = IRQ_NONE; | 368 | int ret = IRQ_NONE; |
| 341 | 369 | ||
| 342 | for (i = 0; i < 8; i++) { | 370 | for (i = 0; i < 8; i++, chip++) { |
| 343 | reg_val = ioread32(&chip->reg->regs[i].istatus); | 371 | reg_val = ioread32(&chip->reg->regs[i].istatus); |
| 344 | for (j = 0; j < num_ports[i]; j++) { | 372 | for (j = 0; j < num_ports[i]; j++) { |
| 345 | if (reg_val & BIT(j)) { | 373 | if (reg_val & BIT(j)) { |
| @@ -370,6 +398,8 @@ static __devinit void ioh_gpio_alloc_generic_chip(struct ioh_gpio *chip, | |||
| 370 | ct->chip.irq_mask = ioh_irq_mask; | 398 | ct->chip.irq_mask = ioh_irq_mask; |
| 371 | ct->chip.irq_unmask = ioh_irq_unmask; | 399 | ct->chip.irq_unmask = ioh_irq_unmask; |
| 372 | ct->chip.irq_set_type = ioh_irq_type; | 400 | ct->chip.irq_set_type = ioh_irq_type; |
| 401 | ct->chip.irq_disable = ioh_irq_disable; | ||
| 402 | ct->chip.irq_enable = ioh_irq_enable; | ||
| 373 | 403 | ||
| 374 | irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE, | 404 | irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE, |
| 375 | IRQ_NOREQUEST | IRQ_NOPROBE, 0); | 405 | IRQ_NOREQUEST | IRQ_NOPROBE, 0); |
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index ec3fcf0a7e12..5cd04b65c556 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c | |||
| @@ -132,6 +132,15 @@ static int mpc8xxx_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val | |||
| 132 | return 0; | 132 | return 0; |
| 133 | } | 133 | } |
| 134 | 134 | ||
| 135 | static int mpc5121_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val) | ||
| 136 | { | ||
| 137 | /* GPIO 28..31 are input only on MPC5121 */ | ||
| 138 | if (gpio >= 28) | ||
| 139 | return -EINVAL; | ||
| 140 | |||
| 141 | return mpc8xxx_gpio_dir_out(gc, gpio, val); | ||
| 142 | } | ||
| 143 | |||
| 135 | static int mpc8xxx_gpio_to_irq(struct gpio_chip *gc, unsigned offset) | 144 | static int mpc8xxx_gpio_to_irq(struct gpio_chip *gc, unsigned offset) |
| 136 | { | 145 | { |
| 137 | struct of_mm_gpio_chip *mm = to_of_mm_gpio_chip(gc); | 146 | struct of_mm_gpio_chip *mm = to_of_mm_gpio_chip(gc); |
| @@ -340,11 +349,10 @@ static void __init mpc8xxx_add_controller(struct device_node *np) | |||
| 340 | mm_gc->save_regs = mpc8xxx_gpio_save_regs; | 349 | mm_gc->save_regs = mpc8xxx_gpio_save_regs; |
| 341 | gc->ngpio = MPC8XXX_GPIO_PINS; | 350 | gc->ngpio = MPC8XXX_GPIO_PINS; |
| 342 | gc->direction_input = mpc8xxx_gpio_dir_in; | 351 | gc->direction_input = mpc8xxx_gpio_dir_in; |
| 343 | gc->direction_output = mpc8xxx_gpio_dir_out; | 352 | gc->direction_output = of_device_is_compatible(np, "fsl,mpc5121-gpio") ? |
| 344 | if (of_device_is_compatible(np, "fsl,mpc8572-gpio")) | 353 | mpc5121_gpio_dir_out : mpc8xxx_gpio_dir_out; |
| 345 | gc->get = mpc8572_gpio_get; | 354 | gc->get = of_device_is_compatible(np, "fsl,mpc8572-gpio") ? |
| 346 | else | 355 | mpc8572_gpio_get : mpc8xxx_gpio_get; |
| 347 | gc->get = mpc8xxx_gpio_get; | ||
| 348 | gc->set = mpc8xxx_gpio_set; | 356 | gc->set = mpc8xxx_gpio_set; |
| 349 | gc->to_irq = mpc8xxx_gpio_to_irq; | 357 | gc->to_irq = mpc8xxx_gpio_to_irq; |
| 350 | 358 | ||
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index 147df8ae79db..d3f3e8f54561 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c | |||
| @@ -546,7 +546,7 @@ static void pca953x_irq_teardown(struct pca953x_chip *chip) | |||
| 546 | * Translate OpenFirmware node properties into platform_data | 546 | * Translate OpenFirmware node properties into platform_data |
| 547 | * WARNING: This is DEPRECATED and will be removed eventually! | 547 | * WARNING: This is DEPRECATED and will be removed eventually! |
| 548 | */ | 548 | */ |
| 549 | void | 549 | static void |
| 550 | pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert) | 550 | pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert) |
| 551 | { | 551 | { |
| 552 | struct device_node *node; | 552 | struct device_node *node; |
| @@ -574,7 +574,7 @@ pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert) | |||
| 574 | *invert = *val; | 574 | *invert = *val; |
| 575 | } | 575 | } |
| 576 | #else | 576 | #else |
| 577 | void | 577 | static void |
| 578 | pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert) | 578 | pca953x_get_alt_pdata(struct i2c_client *client, int *gpio_base, int *invert) |
| 579 | { | 579 | { |
| 580 | *gpio_base = -1; | 580 | *gpio_base = -1; |
diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c index 093c90bd3c1d..4102f63230fd 100644 --- a/drivers/gpio/gpio-pl061.c +++ b/drivers/gpio/gpio-pl061.c | |||
| @@ -238,10 +238,6 @@ static int pl061_probe(struct amba_device *dev, const struct amba_id *id) | |||
| 238 | int ret, irq, i; | 238 | int ret, irq, i; |
| 239 | static DECLARE_BITMAP(init_irq, NR_IRQS); | 239 | static DECLARE_BITMAP(init_irq, NR_IRQS); |
| 240 | 240 | ||
| 241 | pdata = dev->dev.platform_data; | ||
| 242 | if (pdata == NULL) | ||
| 243 | return -ENODEV; | ||
| 244 | |||
| 245 | chip = kzalloc(sizeof(*chip), GFP_KERNEL); | 241 | chip = kzalloc(sizeof(*chip), GFP_KERNEL); |
| 246 | if (chip == NULL) | 242 | if (chip == NULL) |
| 247 | return -ENOMEM; | 243 | return -ENOMEM; |
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c index 3969f7553fe7..d2619d72cece 100644 --- a/drivers/gpu/drm/drm_crtc_helper.c +++ b/drivers/gpu/drm/drm_crtc_helper.c | |||
| @@ -456,6 +456,30 @@ done: | |||
| 456 | EXPORT_SYMBOL(drm_crtc_helper_set_mode); | 456 | EXPORT_SYMBOL(drm_crtc_helper_set_mode); |
| 457 | 457 | ||
| 458 | 458 | ||
| 459 | static int | ||
| 460 | drm_crtc_helper_disable(struct drm_crtc *crtc) | ||
| 461 | { | ||
| 462 | struct drm_device *dev = crtc->dev; | ||
| 463 | struct drm_connector *connector; | ||
| 464 | struct drm_encoder *encoder; | ||
| 465 | |||
| 466 | /* Decouple all encoders and their attached connectors from this crtc */ | ||
| 467 | list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) { | ||
| 468 | if (encoder->crtc != crtc) | ||
| 469 | continue; | ||
| 470 | |||
| 471 | list_for_each_entry(connector, &dev->mode_config.connector_list, head) { | ||
| 472 | if (connector->encoder != encoder) | ||
| 473 | continue; | ||
| 474 | |||
| 475 | connector->encoder = NULL; | ||
| 476 | } | ||
| 477 | } | ||
| 478 | |||
| 479 | drm_helper_disable_unused_functions(dev); | ||
| 480 | return 0; | ||
| 481 | } | ||
| 482 | |||
| 459 | /** | 483 | /** |
| 460 | * drm_crtc_helper_set_config - set a new config from userspace | 484 | * drm_crtc_helper_set_config - set a new config from userspace |
| 461 | * @crtc: CRTC to setup | 485 | * @crtc: CRTC to setup |
| @@ -510,8 +534,7 @@ int drm_crtc_helper_set_config(struct drm_mode_set *set) | |||
| 510 | (int)set->num_connectors, set->x, set->y); | 534 | (int)set->num_connectors, set->x, set->y); |
| 511 | } else { | 535 | } else { |
| 512 | DRM_DEBUG_KMS("[CRTC:%d] [NOFB]\n", set->crtc->base.id); | 536 | DRM_DEBUG_KMS("[CRTC:%d] [NOFB]\n", set->crtc->base.id); |
| 513 | set->mode = NULL; | 537 | return drm_crtc_helper_disable(set->crtc); |
| 514 | set->num_connectors = 0; | ||
| 515 | } | 538 | } |
| 516 | 539 | ||
| 517 | dev = set->crtc->dev; | 540 | dev = set->crtc->dev; |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.c b/drivers/gpu/drm/exynos/exynos_drm_buf.c index 6f8afea94fc9..2bb07bca511a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.c +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.c | |||
| @@ -27,82 +27,84 @@ | |||
| 27 | #include "drm.h" | 27 | #include "drm.h" |
| 28 | 28 | ||
| 29 | #include "exynos_drm_drv.h" | 29 | #include "exynos_drm_drv.h" |
| 30 | #include "exynos_drm_gem.h" | ||
| 30 | #include "exynos_drm_buf.h" | 31 | #include "exynos_drm_buf.h" |
| 31 | 32 | ||
| 32 | static DEFINE_MUTEX(exynos_drm_buf_lock); | ||
| 33 | |||
| 34 | static int lowlevel_buffer_allocate(struct drm_device *dev, | 33 | static int lowlevel_buffer_allocate(struct drm_device *dev, |
| 35 | struct exynos_drm_buf_entry *entry) | 34 | struct exynos_drm_gem_buf *buffer) |
| 36 | { | 35 | { |
| 37 | DRM_DEBUG_KMS("%s\n", __FILE__); | 36 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 38 | 37 | ||
| 39 | entry->vaddr = dma_alloc_writecombine(dev->dev, entry->size, | 38 | buffer->kvaddr = dma_alloc_writecombine(dev->dev, buffer->size, |
| 40 | (dma_addr_t *)&entry->paddr, GFP_KERNEL); | 39 | &buffer->dma_addr, GFP_KERNEL); |
| 41 | if (!entry->paddr) { | 40 | if (!buffer->kvaddr) { |
| 42 | DRM_ERROR("failed to allocate buffer.\n"); | 41 | DRM_ERROR("failed to allocate buffer.\n"); |
| 43 | return -ENOMEM; | 42 | return -ENOMEM; |
| 44 | } | 43 | } |
| 45 | 44 | ||
| 46 | DRM_DEBUG_KMS("allocated : vaddr(0x%x), paddr(0x%x), size(0x%x)\n", | 45 | DRM_DEBUG_KMS("vaddr(0x%lx), dma_addr(0x%lx), size(0x%lx)\n", |
| 47 | (unsigned int)entry->vaddr, entry->paddr, entry->size); | 46 | (unsigned long)buffer->kvaddr, |
| 47 | (unsigned long)buffer->dma_addr, | ||
| 48 | buffer->size); | ||
| 48 | 49 | ||
| 49 | return 0; | 50 | return 0; |
| 50 | } | 51 | } |
| 51 | 52 | ||
| 52 | static void lowlevel_buffer_deallocate(struct drm_device *dev, | 53 | static void lowlevel_buffer_deallocate(struct drm_device *dev, |
| 53 | struct exynos_drm_buf_entry *entry) | 54 | struct exynos_drm_gem_buf *buffer) |
| 54 | { | 55 | { |
| 55 | DRM_DEBUG_KMS("%s.\n", __FILE__); | 56 | DRM_DEBUG_KMS("%s.\n", __FILE__); |
| 56 | 57 | ||
| 57 | if (entry->paddr && entry->vaddr && entry->size) | 58 | if (buffer->dma_addr && buffer->size) |
| 58 | dma_free_writecombine(dev->dev, entry->size, entry->vaddr, | 59 | dma_free_writecombine(dev->dev, buffer->size, buffer->kvaddr, |
| 59 | entry->paddr); | 60 | (dma_addr_t)buffer->dma_addr); |
| 60 | else | 61 | else |
| 61 | DRM_DEBUG_KMS("entry data is null.\n"); | 62 | DRM_DEBUG_KMS("buffer data are invalid.\n"); |
| 62 | } | 63 | } |
| 63 | 64 | ||
| 64 | struct exynos_drm_buf_entry *exynos_drm_buf_create(struct drm_device *dev, | 65 | struct exynos_drm_gem_buf *exynos_drm_buf_create(struct drm_device *dev, |
| 65 | unsigned int size) | 66 | unsigned int size) |
| 66 | { | 67 | { |
| 67 | struct exynos_drm_buf_entry *entry; | 68 | struct exynos_drm_gem_buf *buffer; |
| 68 | 69 | ||
| 69 | DRM_DEBUG_KMS("%s.\n", __FILE__); | 70 | DRM_DEBUG_KMS("%s.\n", __FILE__); |
| 71 | DRM_DEBUG_KMS("desired size = 0x%x\n", size); | ||
| 70 | 72 | ||
| 71 | entry = kzalloc(sizeof(*entry), GFP_KERNEL); | 73 | buffer = kzalloc(sizeof(*buffer), GFP_KERNEL); |
| 72 | if (!entry) { | 74 | if (!buffer) { |
| 73 | DRM_ERROR("failed to allocate exynos_drm_buf_entry.\n"); | 75 | DRM_ERROR("failed to allocate exynos_drm_gem_buf.\n"); |
| 74 | return ERR_PTR(-ENOMEM); | 76 | return ERR_PTR(-ENOMEM); |
| 75 | } | 77 | } |
| 76 | 78 | ||
| 77 | entry->size = size; | 79 | buffer->size = size; |
| 78 | 80 | ||
| 79 | /* | 81 | /* |
| 80 | * allocate memory region with size and set the memory information | 82 | * allocate memory region with size and set the memory information |
| 81 | * to vaddr and paddr of a entry object. | 83 | * to vaddr and dma_addr of a buffer object. |
| 82 | */ | 84 | */ |
| 83 | if (lowlevel_buffer_allocate(dev, entry) < 0) { | 85 | if (lowlevel_buffer_allocate(dev, buffer) < 0) { |
| 84 | kfree(entry); | 86 | kfree(buffer); |
| 85 | entry = NULL; | 87 | buffer = NULL; |
| 86 | return ERR_PTR(-ENOMEM); | 88 | return ERR_PTR(-ENOMEM); |
| 87 | } | 89 | } |
| 88 | 90 | ||
| 89 | return entry; | 91 | return buffer; |
| 90 | } | 92 | } |
| 91 | 93 | ||
| 92 | void exynos_drm_buf_destroy(struct drm_device *dev, | 94 | void exynos_drm_buf_destroy(struct drm_device *dev, |
| 93 | struct exynos_drm_buf_entry *entry) | 95 | struct exynos_drm_gem_buf *buffer) |
| 94 | { | 96 | { |
| 95 | DRM_DEBUG_KMS("%s.\n", __FILE__); | 97 | DRM_DEBUG_KMS("%s.\n", __FILE__); |
| 96 | 98 | ||
| 97 | if (!entry) { | 99 | if (!buffer) { |
| 98 | DRM_DEBUG_KMS("entry is null.\n"); | 100 | DRM_DEBUG_KMS("buffer is null.\n"); |
| 99 | return; | 101 | return; |
| 100 | } | 102 | } |
| 101 | 103 | ||
| 102 | lowlevel_buffer_deallocate(dev, entry); | 104 | lowlevel_buffer_deallocate(dev, buffer); |
| 103 | 105 | ||
| 104 | kfree(entry); | 106 | kfree(buffer); |
| 105 | entry = NULL; | 107 | buffer = NULL; |
| 106 | } | 108 | } |
| 107 | 109 | ||
| 108 | MODULE_AUTHOR("Inki Dae <inki.dae@samsung.com>"); | 110 | MODULE_AUTHOR("Inki Dae <inki.dae@samsung.com>"); |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_buf.h b/drivers/gpu/drm/exynos/exynos_drm_buf.h index 045d59eab01a..6e91f9caa5db 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_buf.h +++ b/drivers/gpu/drm/exynos/exynos_drm_buf.h | |||
| @@ -26,28 +26,15 @@ | |||
| 26 | #ifndef _EXYNOS_DRM_BUF_H_ | 26 | #ifndef _EXYNOS_DRM_BUF_H_ |
| 27 | #define _EXYNOS_DRM_BUF_H_ | 27 | #define _EXYNOS_DRM_BUF_H_ |
| 28 | 28 | ||
| 29 | /* | ||
| 30 | * exynos drm buffer entry structure. | ||
| 31 | * | ||
| 32 | * @paddr: physical address of allocated memory. | ||
| 33 | * @vaddr: kernel virtual address of allocated memory. | ||
| 34 | * @size: size of allocated memory. | ||
| 35 | */ | ||
| 36 | struct exynos_drm_buf_entry { | ||
| 37 | dma_addr_t paddr; | ||
| 38 | void __iomem *vaddr; | ||
| 39 | unsigned int size; | ||
| 40 | }; | ||
| 41 | |||
| 42 | /* allocate physical memory. */ | 29 | /* allocate physical memory. */ |
| 43 | struct exynos_drm_buf_entry *exynos_drm_buf_create(struct drm_device *dev, | 30 | struct exynos_drm_gem_buf *exynos_drm_buf_create(struct drm_device *dev, |
| 44 | unsigned int size); | 31 | unsigned int size); |
| 45 | 32 | ||
| 46 | /* get physical memory information of a drm framebuffer. */ | 33 | /* get memory information of a drm framebuffer. */ |
| 47 | struct exynos_drm_buf_entry *exynos_drm_fb_get_buf(struct drm_framebuffer *fb); | 34 | struct exynos_drm_gem_buf *exynos_drm_fb_get_buf(struct drm_framebuffer *fb); |
| 48 | 35 | ||
| 49 | /* remove allocated physical memory. */ | 36 | /* remove allocated physical memory. */ |
| 50 | void exynos_drm_buf_destroy(struct drm_device *dev, | 37 | void exynos_drm_buf_destroy(struct drm_device *dev, |
| 51 | struct exynos_drm_buf_entry *entry); | 38 | struct exynos_drm_gem_buf *buffer); |
| 52 | 39 | ||
| 53 | #endif | 40 | #endif |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_connector.c b/drivers/gpu/drm/exynos/exynos_drm_connector.c index 985d9e768728..d620b0784257 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_connector.c +++ b/drivers/gpu/drm/exynos/exynos_drm_connector.c | |||
| @@ -37,6 +37,8 @@ | |||
| 37 | 37 | ||
| 38 | struct exynos_drm_connector { | 38 | struct exynos_drm_connector { |
| 39 | struct drm_connector drm_connector; | 39 | struct drm_connector drm_connector; |
| 40 | uint32_t encoder_id; | ||
| 41 | struct exynos_drm_manager *manager; | ||
| 40 | }; | 42 | }; |
| 41 | 43 | ||
| 42 | /* convert exynos_video_timings to drm_display_mode */ | 44 | /* convert exynos_video_timings to drm_display_mode */ |
| @@ -47,6 +49,7 @@ convert_to_display_mode(struct drm_display_mode *mode, | |||
| 47 | DRM_DEBUG_KMS("%s\n", __FILE__); | 49 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 48 | 50 | ||
| 49 | mode->clock = timing->pixclock / 1000; | 51 | mode->clock = timing->pixclock / 1000; |
| 52 | mode->vrefresh = timing->refresh; | ||
| 50 | 53 | ||
| 51 | mode->hdisplay = timing->xres; | 54 | mode->hdisplay = timing->xres; |
| 52 | mode->hsync_start = mode->hdisplay + timing->left_margin; | 55 | mode->hsync_start = mode->hdisplay + timing->left_margin; |
| @@ -57,6 +60,12 @@ convert_to_display_mode(struct drm_display_mode *mode, | |||
| 57 | mode->vsync_start = mode->vdisplay + timing->upper_margin; | 60 | mode->vsync_start = mode->vdisplay + timing->upper_margin; |
| 58 | mode->vsync_end = mode->vsync_start + timing->vsync_len; | 61 | mode->vsync_end = mode->vsync_start + timing->vsync_len; |
| 59 | mode->vtotal = mode->vsync_end + timing->lower_margin; | 62 | mode->vtotal = mode->vsync_end + timing->lower_margin; |
| 63 | |||
| 64 | if (timing->vmode & FB_VMODE_INTERLACED) | ||
| 65 | mode->flags |= DRM_MODE_FLAG_INTERLACE; | ||
| 66 | |||
| 67 | if (timing->vmode & FB_VMODE_DOUBLE) | ||
| 68 | mode->flags |= DRM_MODE_FLAG_DBLSCAN; | ||
| 60 | } | 69 | } |
| 61 | 70 | ||
| 62 | /* convert drm_display_mode to exynos_video_timings */ | 71 | /* convert drm_display_mode to exynos_video_timings */ |
| @@ -69,7 +78,7 @@ convert_to_video_timing(struct fb_videomode *timing, | |||
| 69 | memset(timing, 0, sizeof(*timing)); | 78 | memset(timing, 0, sizeof(*timing)); |
| 70 | 79 | ||
| 71 | timing->pixclock = mode->clock * 1000; | 80 | timing->pixclock = mode->clock * 1000; |
| 72 | timing->refresh = mode->vrefresh; | 81 | timing->refresh = drm_mode_vrefresh(mode); |
| 73 | 82 | ||
| 74 | timing->xres = mode->hdisplay; | 83 | timing->xres = mode->hdisplay; |
| 75 | timing->left_margin = mode->hsync_start - mode->hdisplay; | 84 | timing->left_margin = mode->hsync_start - mode->hdisplay; |
| @@ -92,15 +101,16 @@ convert_to_video_timing(struct fb_videomode *timing, | |||
| 92 | 101 | ||
| 93 | static int exynos_drm_connector_get_modes(struct drm_connector *connector) | 102 | static int exynos_drm_connector_get_modes(struct drm_connector *connector) |
| 94 | { | 103 | { |
| 95 | struct exynos_drm_manager *manager = | 104 | struct exynos_drm_connector *exynos_connector = |
| 96 | exynos_drm_get_manager(connector->encoder); | 105 | to_exynos_connector(connector); |
| 97 | struct exynos_drm_display *display = manager->display; | 106 | struct exynos_drm_manager *manager = exynos_connector->manager; |
| 107 | struct exynos_drm_display_ops *display_ops = manager->display_ops; | ||
| 98 | unsigned int count; | 108 | unsigned int count; |
| 99 | 109 | ||
| 100 | DRM_DEBUG_KMS("%s\n", __FILE__); | 110 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 101 | 111 | ||
| 102 | if (!display) { | 112 | if (!display_ops) { |
| 103 | DRM_DEBUG_KMS("display is null.\n"); | 113 | DRM_DEBUG_KMS("display_ops is null.\n"); |
| 104 | return 0; | 114 | return 0; |
| 105 | } | 115 | } |
| 106 | 116 | ||
| @@ -112,7 +122,7 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector) | |||
| 112 | * P.S. in case of lcd panel, count is always 1 if success | 122 | * P.S. in case of lcd panel, count is always 1 if success |
| 113 | * because lcd panel has only one mode. | 123 | * because lcd panel has only one mode. |
| 114 | */ | 124 | */ |
| 115 | if (display->get_edid) { | 125 | if (display_ops->get_edid) { |
| 116 | int ret; | 126 | int ret; |
| 117 | void *edid; | 127 | void *edid; |
| 118 | 128 | ||
| @@ -122,7 +132,7 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector) | |||
| 122 | return 0; | 132 | return 0; |
| 123 | } | 133 | } |
| 124 | 134 | ||
| 125 | ret = display->get_edid(manager->dev, connector, | 135 | ret = display_ops->get_edid(manager->dev, connector, |
| 126 | edid, MAX_EDID); | 136 | edid, MAX_EDID); |
| 127 | if (ret < 0) { | 137 | if (ret < 0) { |
| 128 | DRM_ERROR("failed to get edid data.\n"); | 138 | DRM_ERROR("failed to get edid data.\n"); |
| @@ -140,8 +150,8 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector) | |||
| 140 | struct drm_display_mode *mode = drm_mode_create(connector->dev); | 150 | struct drm_display_mode *mode = drm_mode_create(connector->dev); |
| 141 | struct fb_videomode *timing; | 151 | struct fb_videomode *timing; |
| 142 | 152 | ||
| 143 | if (display->get_timing) | 153 | if (display_ops->get_timing) |
| 144 | timing = display->get_timing(manager->dev); | 154 | timing = display_ops->get_timing(manager->dev); |
| 145 | else { | 155 | else { |
| 146 | drm_mode_destroy(connector->dev, mode); | 156 | drm_mode_destroy(connector->dev, mode); |
| 147 | return 0; | 157 | return 0; |
| @@ -162,9 +172,10 @@ static int exynos_drm_connector_get_modes(struct drm_connector *connector) | |||
| 162 | static int exynos_drm_connector_mode_valid(struct drm_connector *connector, | 172 | static int exynos_drm_connector_mode_valid(struct drm_connector *connector, |
| 163 | struct drm_display_mode *mode) | 173 | struct drm_display_mode *mode) |
| 164 | { | 174 | { |
| 165 | struct exynos_drm_manager *manager = | 175 | struct exynos_drm_connector *exynos_connector = |
| 166 | exynos_drm_get_manager(connector->encoder); | 176 | to_exynos_connector(connector); |
| 167 | struct exynos_drm_display *display = manager->display; | 177 | struct exynos_drm_manager *manager = exynos_connector->manager; |
| 178 | struct exynos_drm_display_ops *display_ops = manager->display_ops; | ||
| 168 | struct fb_videomode timing; | 179 | struct fb_videomode timing; |
| 169 | int ret = MODE_BAD; | 180 | int ret = MODE_BAD; |
| 170 | 181 | ||
| @@ -172,8 +183,8 @@ static int exynos_drm_connector_mode_valid(struct drm_connector *connector, | |||
| 172 | 183 | ||
| 173 | convert_to_video_timing(&timing, mode); | 184 | convert_to_video_timing(&timing, mode); |
| 174 | 185 | ||
| 175 | if (display && display->check_timing) | 186 | if (display_ops && display_ops->check_timing) |
| 176 | if (!display->check_timing(manager->dev, (void *)&timing)) | 187 | if (!display_ops->check_timing(manager->dev, (void *)&timing)) |
| 177 | ret = MODE_OK; | 188 | ret = MODE_OK; |
| 178 | 189 | ||
| 179 | return ret; | 190 | return ret; |
| @@ -181,9 +192,25 @@ static int exynos_drm_connector_mode_valid(struct drm_connector *connector, | |||
| 181 | 192 | ||
| 182 | struct drm_encoder *exynos_drm_best_encoder(struct drm_connector *connector) | 193 | struct drm_encoder *exynos_drm_best_encoder(struct drm_connector *connector) |
| 183 | { | 194 | { |
| 195 | struct drm_device *dev = connector->dev; | ||
| 196 | struct exynos_drm_connector *exynos_connector = | ||
| 197 | to_exynos_connector(connector); | ||
| 198 | struct drm_mode_object *obj; | ||
| 199 | struct drm_encoder *encoder; | ||
| 200 | |||
| 184 | DRM_DEBUG_KMS("%s\n", __FILE__); | 201 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 185 | 202 | ||
| 186 | return connector->encoder; | 203 | obj = drm_mode_object_find(dev, exynos_connector->encoder_id, |
| 204 | DRM_MODE_OBJECT_ENCODER); | ||
| 205 | if (!obj) { | ||
| 206 | DRM_DEBUG_KMS("Unknown ENCODER ID %d\n", | ||
| 207 | exynos_connector->encoder_id); | ||
| 208 | return NULL; | ||
| 209 | } | ||
| 210 | |||
| 211 | encoder = obj_to_encoder(obj); | ||
| 212 | |||
| 213 | return encoder; | ||
| 187 | } | 214 | } |
| 188 | 215 | ||
| 189 | static struct drm_connector_helper_funcs exynos_connector_helper_funcs = { | 216 | static struct drm_connector_helper_funcs exynos_connector_helper_funcs = { |
| @@ -196,15 +223,17 @@ static struct drm_connector_helper_funcs exynos_connector_helper_funcs = { | |||
| 196 | static enum drm_connector_status | 223 | static enum drm_connector_status |
| 197 | exynos_drm_connector_detect(struct drm_connector *connector, bool force) | 224 | exynos_drm_connector_detect(struct drm_connector *connector, bool force) |
| 198 | { | 225 | { |
| 199 | struct exynos_drm_manager *manager = | 226 | struct exynos_drm_connector *exynos_connector = |
| 200 | exynos_drm_get_manager(connector->encoder); | 227 | to_exynos_connector(connector); |
| 201 | struct exynos_drm_display *display = manager->display; | 228 | struct exynos_drm_manager *manager = exynos_connector->manager; |
| 229 | struct exynos_drm_display_ops *display_ops = | ||
| 230 | manager->display_ops; | ||
| 202 | enum drm_connector_status status = connector_status_disconnected; | 231 | enum drm_connector_status status = connector_status_disconnected; |
| 203 | 232 | ||
| 204 | DRM_DEBUG_KMS("%s\n", __FILE__); | 233 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 205 | 234 | ||
| 206 | if (display && display->is_connected) { | 235 | if (display_ops && display_ops->is_connected) { |
| 207 | if (display->is_connected(manager->dev)) | 236 | if (display_ops->is_connected(manager->dev)) |
| 208 | status = connector_status_connected; | 237 | status = connector_status_connected; |
| 209 | else | 238 | else |
| 210 | status = connector_status_disconnected; | 239 | status = connector_status_disconnected; |
| @@ -251,9 +280,11 @@ struct drm_connector *exynos_drm_connector_create(struct drm_device *dev, | |||
| 251 | 280 | ||
| 252 | connector = &exynos_connector->drm_connector; | 281 | connector = &exynos_connector->drm_connector; |
| 253 | 282 | ||
| 254 | switch (manager->display->type) { | 283 | switch (manager->display_ops->type) { |
| 255 | case EXYNOS_DISPLAY_TYPE_HDMI: | 284 | case EXYNOS_DISPLAY_TYPE_HDMI: |
| 256 | type = DRM_MODE_CONNECTOR_HDMIA; | 285 | type = DRM_MODE_CONNECTOR_HDMIA; |
| 286 | connector->interlace_allowed = true; | ||
| 287 | connector->polled = DRM_CONNECTOR_POLL_HPD; | ||
| 257 | break; | 288 | break; |
| 258 | default: | 289 | default: |
| 259 | type = DRM_MODE_CONNECTOR_Unknown; | 290 | type = DRM_MODE_CONNECTOR_Unknown; |
| @@ -267,7 +298,10 @@ struct drm_connector *exynos_drm_connector_create(struct drm_device *dev, | |||
| 267 | if (err) | 298 | if (err) |
| 268 | goto err_connector; | 299 | goto err_connector; |
| 269 | 300 | ||
| 301 | exynos_connector->encoder_id = encoder->base.id; | ||
| 302 | exynos_connector->manager = manager; | ||
| 270 | connector->encoder = encoder; | 303 | connector->encoder = encoder; |
| 304 | |||
| 271 | err = drm_mode_connector_attach_encoder(connector, encoder); | 305 | err = drm_mode_connector_attach_encoder(connector, encoder); |
| 272 | if (err) { | 306 | if (err) { |
| 273 | DRM_ERROR("failed to attach a connector to a encoder\n"); | 307 | DRM_ERROR("failed to attach a connector to a encoder\n"); |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index 9337e5e2dbb6..ee43cc220853 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c | |||
| @@ -29,36 +29,17 @@ | |||
| 29 | #include "drmP.h" | 29 | #include "drmP.h" |
| 30 | #include "drm_crtc_helper.h" | 30 | #include "drm_crtc_helper.h" |
| 31 | 31 | ||
| 32 | #include "exynos_drm_crtc.h" | ||
| 32 | #include "exynos_drm_drv.h" | 33 | #include "exynos_drm_drv.h" |
| 33 | #include "exynos_drm_fb.h" | 34 | #include "exynos_drm_fb.h" |
| 34 | #include "exynos_drm_encoder.h" | 35 | #include "exynos_drm_encoder.h" |
| 36 | #include "exynos_drm_gem.h" | ||
| 35 | #include "exynos_drm_buf.h" | 37 | #include "exynos_drm_buf.h" |
| 36 | 38 | ||
| 37 | #define to_exynos_crtc(x) container_of(x, struct exynos_drm_crtc,\ | 39 | #define to_exynos_crtc(x) container_of(x, struct exynos_drm_crtc,\ |
| 38 | drm_crtc) | 40 | drm_crtc) |
| 39 | 41 | ||
| 40 | /* | 42 | /* |
| 41 | * Exynos specific crtc postion structure. | ||
| 42 | * | ||
| 43 | * @fb_x: offset x on a framebuffer to be displyed | ||
| 44 | * - the unit is screen coordinates. | ||
| 45 | * @fb_y: offset y on a framebuffer to be displayed | ||
| 46 | * - the unit is screen coordinates. | ||
| 47 | * @crtc_x: offset x on hardware screen. | ||
| 48 | * @crtc_y: offset y on hardware screen. | ||
| 49 | * @crtc_w: width of hardware screen. | ||
| 50 | * @crtc_h: height of hardware screen. | ||
| 51 | */ | ||
| 52 | struct exynos_drm_crtc_pos { | ||
| 53 | unsigned int fb_x; | ||
| 54 | unsigned int fb_y; | ||
| 55 | unsigned int crtc_x; | ||
| 56 | unsigned int crtc_y; | ||
| 57 | unsigned int crtc_w; | ||
| 58 | unsigned int crtc_h; | ||
| 59 | }; | ||
| 60 | |||
| 61 | /* | ||
| 62 | * Exynos specific crtc structure. | 43 | * Exynos specific crtc structure. |
| 63 | * | 44 | * |
| 64 | * @drm_crtc: crtc object. | 45 | * @drm_crtc: crtc object. |
| @@ -85,30 +66,31 @@ static void exynos_drm_crtc_apply(struct drm_crtc *crtc) | |||
| 85 | 66 | ||
| 86 | exynos_drm_fn_encoder(crtc, overlay, | 67 | exynos_drm_fn_encoder(crtc, overlay, |
| 87 | exynos_drm_encoder_crtc_mode_set); | 68 | exynos_drm_encoder_crtc_mode_set); |
| 88 | exynos_drm_fn_encoder(crtc, NULL, exynos_drm_encoder_crtc_commit); | 69 | exynos_drm_fn_encoder(crtc, &exynos_crtc->pipe, |
| 70 | exynos_drm_encoder_crtc_commit); | ||
| 89 | } | 71 | } |
| 90 | 72 | ||
| 91 | static int exynos_drm_overlay_update(struct exynos_drm_overlay *overlay, | 73 | int exynos_drm_overlay_update(struct exynos_drm_overlay *overlay, |
| 92 | struct drm_framebuffer *fb, | 74 | struct drm_framebuffer *fb, |
| 93 | struct drm_display_mode *mode, | 75 | struct drm_display_mode *mode, |
| 94 | struct exynos_drm_crtc_pos *pos) | 76 | struct exynos_drm_crtc_pos *pos) |
| 95 | { | 77 | { |
| 96 | struct exynos_drm_buf_entry *entry; | 78 | struct exynos_drm_gem_buf *buffer; |
| 97 | unsigned int actual_w; | 79 | unsigned int actual_w; |
| 98 | unsigned int actual_h; | 80 | unsigned int actual_h; |
| 99 | 81 | ||
| 100 | entry = exynos_drm_fb_get_buf(fb); | 82 | buffer = exynos_drm_fb_get_buf(fb); |
| 101 | if (!entry) { | 83 | if (!buffer) { |
| 102 | DRM_LOG_KMS("entry is null.\n"); | 84 | DRM_LOG_KMS("buffer is null.\n"); |
| 103 | return -EFAULT; | 85 | return -EFAULT; |
| 104 | } | 86 | } |
| 105 | 87 | ||
| 106 | overlay->paddr = entry->paddr; | 88 | overlay->dma_addr = buffer->dma_addr; |
| 107 | overlay->vaddr = entry->vaddr; | 89 | overlay->vaddr = buffer->kvaddr; |
| 108 | 90 | ||
| 109 | DRM_DEBUG_KMS("vaddr = 0x%lx, paddr = 0x%lx\n", | 91 | DRM_DEBUG_KMS("vaddr = 0x%lx, dma_addr = 0x%lx\n", |
| 110 | (unsigned long)overlay->vaddr, | 92 | (unsigned long)overlay->vaddr, |
| 111 | (unsigned long)overlay->paddr); | 93 | (unsigned long)overlay->dma_addr); |
| 112 | 94 | ||
| 113 | actual_w = min((mode->hdisplay - pos->crtc_x), pos->crtc_w); | 95 | actual_w = min((mode->hdisplay - pos->crtc_x), pos->crtc_w); |
| 114 | actual_h = min((mode->vdisplay - pos->crtc_y), pos->crtc_h); | 96 | actual_h = min((mode->vdisplay - pos->crtc_y), pos->crtc_h); |
| @@ -171,9 +153,26 @@ static int exynos_drm_crtc_update(struct drm_crtc *crtc) | |||
| 171 | 153 | ||
| 172 | static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) | 154 | static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) |
| 173 | { | 155 | { |
| 174 | DRM_DEBUG_KMS("%s\n", __FILE__); | 156 | struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc); |
| 175 | 157 | ||
| 176 | /* TODO */ | 158 | DRM_DEBUG_KMS("crtc[%d] mode[%d]\n", crtc->base.id, mode); |
| 159 | |||
| 160 | switch (mode) { | ||
| 161 | case DRM_MODE_DPMS_ON: | ||
| 162 | exynos_drm_fn_encoder(crtc, &exynos_crtc->pipe, | ||
| 163 | exynos_drm_encoder_crtc_commit); | ||
| 164 | break; | ||
| 165 | case DRM_MODE_DPMS_STANDBY: | ||
| 166 | case DRM_MODE_DPMS_SUSPEND: | ||
| 167 | case DRM_MODE_DPMS_OFF: | ||
| 168 | /* TODO */ | ||
| 169 | exynos_drm_fn_encoder(crtc, NULL, | ||
| 170 | exynos_drm_encoder_crtc_disable); | ||
| 171 | break; | ||
| 172 | default: | ||
| 173 | DRM_DEBUG_KMS("unspecified mode %d\n", mode); | ||
| 174 | break; | ||
| 175 | } | ||
| 177 | } | 176 | } |
| 178 | 177 | ||
| 179 | static void exynos_drm_crtc_prepare(struct drm_crtc *crtc) | 178 | static void exynos_drm_crtc_prepare(struct drm_crtc *crtc) |
| @@ -185,9 +184,12 @@ static void exynos_drm_crtc_prepare(struct drm_crtc *crtc) | |||
| 185 | 184 | ||
| 186 | static void exynos_drm_crtc_commit(struct drm_crtc *crtc) | 185 | static void exynos_drm_crtc_commit(struct drm_crtc *crtc) |
| 187 | { | 186 | { |
| 187 | struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc); | ||
| 188 | |||
| 188 | DRM_DEBUG_KMS("%s\n", __FILE__); | 189 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 189 | 190 | ||
| 190 | /* drm framework doesn't check NULL. */ | 191 | exynos_drm_fn_encoder(crtc, &exynos_crtc->pipe, |
| 192 | exynos_drm_encoder_crtc_commit); | ||
| 191 | } | 193 | } |
| 192 | 194 | ||
| 193 | static bool | 195 | static bool |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.h b/drivers/gpu/drm/exynos/exynos_drm_crtc.h index c584042d6d2c..25f72a62cb88 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.h +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.h | |||
| @@ -35,4 +35,29 @@ int exynos_drm_crtc_create(struct drm_device *dev, unsigned int nr); | |||
| 35 | int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int crtc); | 35 | int exynos_drm_crtc_enable_vblank(struct drm_device *dev, int crtc); |
| 36 | void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int crtc); | 36 | void exynos_drm_crtc_disable_vblank(struct drm_device *dev, int crtc); |
| 37 | 37 | ||
| 38 | /* | ||
| 39 | * Exynos specific crtc postion structure. | ||
| 40 | * | ||
| 41 | * @fb_x: offset x on a framebuffer to be displyed | ||
| 42 | * - the unit is screen coordinates. | ||
| 43 | * @fb_y: offset y on a framebuffer to be displayed | ||
| 44 | * - the unit is screen coordinates. | ||
| 45 | * @crtc_x: offset x on hardware screen. | ||
| 46 | * @crtc_y: offset y on hardware screen. | ||
| 47 | * @crtc_w: width of hardware screen. | ||
| 48 | * @crtc_h: height of hardware screen. | ||
| 49 | */ | ||
| 50 | struct exynos_drm_crtc_pos { | ||
| 51 | unsigned int fb_x; | ||
| 52 | unsigned int fb_y; | ||
| 53 | unsigned int crtc_x; | ||
| 54 | unsigned int crtc_y; | ||
| 55 | unsigned int crtc_w; | ||
| 56 | unsigned int crtc_h; | ||
| 57 | }; | ||
| 58 | |||
| 59 | int exynos_drm_overlay_update(struct exynos_drm_overlay *overlay, | ||
| 60 | struct drm_framebuffer *fb, | ||
| 61 | struct drm_display_mode *mode, | ||
| 62 | struct exynos_drm_crtc_pos *pos); | ||
| 38 | #endif | 63 | #endif |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 83810cbe3c17..53e2216de61d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c | |||
| @@ -27,6 +27,7 @@ | |||
| 27 | 27 | ||
| 28 | #include "drmP.h" | 28 | #include "drmP.h" |
| 29 | #include "drm.h" | 29 | #include "drm.h" |
| 30 | #include "drm_crtc_helper.h" | ||
| 30 | 31 | ||
| 31 | #include <drm/exynos_drm.h> | 32 | #include <drm/exynos_drm.h> |
| 32 | 33 | ||
| @@ -61,6 +62,9 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags) | |||
| 61 | 62 | ||
| 62 | drm_mode_config_init(dev); | 63 | drm_mode_config_init(dev); |
| 63 | 64 | ||
| 65 | /* init kms poll for handling hpd */ | ||
| 66 | drm_kms_helper_poll_init(dev); | ||
| 67 | |||
| 64 | exynos_drm_mode_config_init(dev); | 68 | exynos_drm_mode_config_init(dev); |
| 65 | 69 | ||
| 66 | /* | 70 | /* |
| @@ -116,6 +120,7 @@ static int exynos_drm_unload(struct drm_device *dev) | |||
| 116 | exynos_drm_fbdev_fini(dev); | 120 | exynos_drm_fbdev_fini(dev); |
| 117 | exynos_drm_device_unregister(dev); | 121 | exynos_drm_device_unregister(dev); |
| 118 | drm_vblank_cleanup(dev); | 122 | drm_vblank_cleanup(dev); |
| 123 | drm_kms_helper_poll_fini(dev); | ||
| 119 | drm_mode_config_cleanup(dev); | 124 | drm_mode_config_cleanup(dev); |
| 120 | kfree(dev->dev_private); | 125 | kfree(dev->dev_private); |
| 121 | 126 | ||
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index c03683f2ae72..5e02e6ecc2e0 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h | |||
| @@ -29,6 +29,7 @@ | |||
| 29 | #ifndef _EXYNOS_DRM_DRV_H_ | 29 | #ifndef _EXYNOS_DRM_DRV_H_ |
| 30 | #define _EXYNOS_DRM_DRV_H_ | 30 | #define _EXYNOS_DRM_DRV_H_ |
| 31 | 31 | ||
| 32 | #include <linux/module.h> | ||
| 32 | #include "drm.h" | 33 | #include "drm.h" |
| 33 | 34 | ||
| 34 | #define MAX_CRTC 2 | 35 | #define MAX_CRTC 2 |
| @@ -79,8 +80,8 @@ struct exynos_drm_overlay_ops { | |||
| 79 | * @scan_flag: interlace or progressive way. | 80 | * @scan_flag: interlace or progressive way. |
| 80 | * (it could be DRM_MODE_FLAG_*) | 81 | * (it could be DRM_MODE_FLAG_*) |
| 81 | * @bpp: pixel size.(in bit) | 82 | * @bpp: pixel size.(in bit) |
| 82 | * @paddr: bus(accessed by dma) physical memory address to this overlay | 83 | * @dma_addr: bus(accessed by dma) address to the memory region allocated |
| 83 | * and this is physically continuous. | 84 | * for a overlay. |
| 84 | * @vaddr: virtual memory addresss to this overlay. | 85 | * @vaddr: virtual memory addresss to this overlay. |
| 85 | * @default_win: a window to be enabled. | 86 | * @default_win: a window to be enabled. |
| 86 | * @color_key: color key on or off. | 87 | * @color_key: color key on or off. |
| @@ -108,7 +109,7 @@ struct exynos_drm_overlay { | |||
| 108 | unsigned int scan_flag; | 109 | unsigned int scan_flag; |
| 109 | unsigned int bpp; | 110 | unsigned int bpp; |
| 110 | unsigned int pitch; | 111 | unsigned int pitch; |
| 111 | dma_addr_t paddr; | 112 | dma_addr_t dma_addr; |
| 112 | void __iomem *vaddr; | 113 | void __iomem *vaddr; |
| 113 | 114 | ||
| 114 | bool default_win; | 115 | bool default_win; |
| @@ -130,7 +131,7 @@ struct exynos_drm_overlay { | |||
| 130 | * @check_timing: check if timing is valid or not. | 131 | * @check_timing: check if timing is valid or not. |
| 131 | * @power_on: display device on or off. | 132 | * @power_on: display device on or off. |
| 132 | */ | 133 | */ |
| 133 | struct exynos_drm_display { | 134 | struct exynos_drm_display_ops { |
| 134 | enum exynos_drm_output_type type; | 135 | enum exynos_drm_output_type type; |
| 135 | bool (*is_connected)(struct device *dev); | 136 | bool (*is_connected)(struct device *dev); |
| 136 | int (*get_edid)(struct device *dev, struct drm_connector *connector, | 137 | int (*get_edid)(struct device *dev, struct drm_connector *connector, |
| @@ -146,12 +147,14 @@ struct exynos_drm_display { | |||
| 146 | * @mode_set: convert drm_display_mode to hw specific display mode and | 147 | * @mode_set: convert drm_display_mode to hw specific display mode and |
| 147 | * would be called by encoder->mode_set(). | 148 | * would be called by encoder->mode_set(). |
| 148 | * @commit: set current hw specific display mode to hw. | 149 | * @commit: set current hw specific display mode to hw. |
| 150 | * @disable: disable hardware specific display mode. | ||
| 149 | * @enable_vblank: specific driver callback for enabling vblank interrupt. | 151 | * @enable_vblank: specific driver callback for enabling vblank interrupt. |
| 150 | * @disable_vblank: specific driver callback for disabling vblank interrupt. | 152 | * @disable_vblank: specific driver callback for disabling vblank interrupt. |
| 151 | */ | 153 | */ |
| 152 | struct exynos_drm_manager_ops { | 154 | struct exynos_drm_manager_ops { |
| 153 | void (*mode_set)(struct device *subdrv_dev, void *mode); | 155 | void (*mode_set)(struct device *subdrv_dev, void *mode); |
| 154 | void (*commit)(struct device *subdrv_dev); | 156 | void (*commit)(struct device *subdrv_dev); |
| 157 | void (*disable)(struct device *subdrv_dev); | ||
| 155 | int (*enable_vblank)(struct device *subdrv_dev); | 158 | int (*enable_vblank)(struct device *subdrv_dev); |
| 156 | void (*disable_vblank)(struct device *subdrv_dev); | 159 | void (*disable_vblank)(struct device *subdrv_dev); |
| 157 | }; | 160 | }; |
| @@ -178,7 +181,7 @@ struct exynos_drm_manager { | |||
| 178 | int pipe; | 181 | int pipe; |
| 179 | struct exynos_drm_manager_ops *ops; | 182 | struct exynos_drm_manager_ops *ops; |
| 180 | struct exynos_drm_overlay_ops *overlay_ops; | 183 | struct exynos_drm_overlay_ops *overlay_ops; |
| 181 | struct exynos_drm_display *display; | 184 | struct exynos_drm_display_ops *display_ops; |
| 182 | }; | 185 | }; |
| 183 | 186 | ||
| 184 | /* | 187 | /* |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index 7cf6fa86a67e..153061415baf 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c | |||
| @@ -53,15 +53,36 @@ static void exynos_drm_encoder_dpms(struct drm_encoder *encoder, int mode) | |||
| 53 | struct drm_device *dev = encoder->dev; | 53 | struct drm_device *dev = encoder->dev; |
| 54 | struct drm_connector *connector; | 54 | struct drm_connector *connector; |
| 55 | struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder); | 55 | struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder); |
| 56 | struct exynos_drm_manager_ops *manager_ops = manager->ops; | ||
| 56 | 57 | ||
| 57 | DRM_DEBUG_KMS("%s, encoder dpms: %d\n", __FILE__, mode); | 58 | DRM_DEBUG_KMS("%s, encoder dpms: %d\n", __FILE__, mode); |
| 58 | 59 | ||
| 60 | switch (mode) { | ||
| 61 | case DRM_MODE_DPMS_ON: | ||
| 62 | if (manager_ops && manager_ops->commit) | ||
| 63 | manager_ops->commit(manager->dev); | ||
| 64 | break; | ||
| 65 | case DRM_MODE_DPMS_STANDBY: | ||
| 66 | case DRM_MODE_DPMS_SUSPEND: | ||
| 67 | case DRM_MODE_DPMS_OFF: | ||
| 68 | /* TODO */ | ||
| 69 | if (manager_ops && manager_ops->disable) | ||
| 70 | manager_ops->disable(manager->dev); | ||
| 71 | break; | ||
| 72 | default: | ||
| 73 | DRM_ERROR("unspecified mode %d\n", mode); | ||
| 74 | break; | ||
| 75 | } | ||
| 76 | |||
| 59 | list_for_each_entry(connector, &dev->mode_config.connector_list, head) { | 77 | list_for_each_entry(connector, &dev->mode_config.connector_list, head) { |
| 60 | if (connector->encoder == encoder) { | 78 | if (connector->encoder == encoder) { |
| 61 | struct exynos_drm_display *display = manager->display; | 79 | struct exynos_drm_display_ops *display_ops = |
| 80 | manager->display_ops; | ||
| 62 | 81 | ||
| 63 | if (display && display->power_on) | 82 | DRM_DEBUG_KMS("connector[%d] dpms[%d]\n", |
| 64 | display->power_on(manager->dev, mode); | 83 | connector->base.id, mode); |
| 84 | if (display_ops && display_ops->power_on) | ||
| 85 | display_ops->power_on(manager->dev, mode); | ||
| 65 | } | 86 | } |
| 66 | } | 87 | } |
| 67 | } | 88 | } |
| @@ -116,15 +137,11 @@ static void exynos_drm_encoder_commit(struct drm_encoder *encoder) | |||
| 116 | { | 137 | { |
| 117 | struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder); | 138 | struct exynos_drm_manager *manager = exynos_drm_get_manager(encoder); |
| 118 | struct exynos_drm_manager_ops *manager_ops = manager->ops; | 139 | struct exynos_drm_manager_ops *manager_ops = manager->ops; |
| 119 | struct exynos_drm_overlay_ops *overlay_ops = manager->overlay_ops; | ||
| 120 | 140 | ||
| 121 | DRM_DEBUG_KMS("%s\n", __FILE__); | 141 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 122 | 142 | ||
| 123 | if (manager_ops && manager_ops->commit) | 143 | if (manager_ops && manager_ops->commit) |
| 124 | manager_ops->commit(manager->dev); | 144 | manager_ops->commit(manager->dev); |
| 125 | |||
| 126 | if (overlay_ops && overlay_ops->commit) | ||
| 127 | overlay_ops->commit(manager->dev); | ||
| 128 | } | 145 | } |
| 129 | 146 | ||
| 130 | static struct drm_crtc * | 147 | static struct drm_crtc * |
| @@ -208,10 +225,23 @@ void exynos_drm_fn_encoder(struct drm_crtc *crtc, void *data, | |||
| 208 | { | 225 | { |
| 209 | struct drm_device *dev = crtc->dev; | 226 | struct drm_device *dev = crtc->dev; |
| 210 | struct drm_encoder *encoder; | 227 | struct drm_encoder *encoder; |
| 228 | struct exynos_drm_private *private = dev->dev_private; | ||
| 229 | struct exynos_drm_manager *manager; | ||
| 211 | 230 | ||
| 212 | list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) { | 231 | list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) { |
| 213 | if (encoder->crtc != crtc) | 232 | /* |
| 214 | continue; | 233 | * if crtc is detached from encoder, check pipe, |
| 234 | * otherwise check crtc attached to encoder | ||
| 235 | */ | ||
| 236 | if (!encoder->crtc) { | ||
| 237 | manager = to_exynos_encoder(encoder)->manager; | ||
| 238 | if (manager->pipe < 0 || | ||
| 239 | private->crtc[manager->pipe] != crtc) | ||
| 240 | continue; | ||
| 241 | } else { | ||
| 242 | if (encoder->crtc != crtc) | ||
| 243 | continue; | ||
| 244 | } | ||
| 215 | 245 | ||
| 216 | fn(encoder, data); | 246 | fn(encoder, data); |
| 217 | } | 247 | } |
| @@ -250,8 +280,18 @@ void exynos_drm_encoder_crtc_commit(struct drm_encoder *encoder, void *data) | |||
| 250 | struct exynos_drm_manager *manager = | 280 | struct exynos_drm_manager *manager = |
| 251 | to_exynos_encoder(encoder)->manager; | 281 | to_exynos_encoder(encoder)->manager; |
| 252 | struct exynos_drm_overlay_ops *overlay_ops = manager->overlay_ops; | 282 | struct exynos_drm_overlay_ops *overlay_ops = manager->overlay_ops; |
| 283 | int crtc = *(int *)data; | ||
| 284 | |||
| 285 | DRM_DEBUG_KMS("%s\n", __FILE__); | ||
| 286 | |||
| 287 | /* | ||
| 288 | * when crtc is detached from encoder, this pipe is used | ||
| 289 | * to select manager operation | ||
| 290 | */ | ||
| 291 | manager->pipe = crtc; | ||
| 253 | 292 | ||
| 254 | overlay_ops->commit(manager->dev); | 293 | if (overlay_ops && overlay_ops->commit) |
| 294 | overlay_ops->commit(manager->dev); | ||
| 255 | } | 295 | } |
| 256 | 296 | ||
| 257 | void exynos_drm_encoder_crtc_mode_set(struct drm_encoder *encoder, void *data) | 297 | void exynos_drm_encoder_crtc_mode_set(struct drm_encoder *encoder, void *data) |
| @@ -261,7 +301,28 @@ void exynos_drm_encoder_crtc_mode_set(struct drm_encoder *encoder, void *data) | |||
| 261 | struct exynos_drm_overlay_ops *overlay_ops = manager->overlay_ops; | 301 | struct exynos_drm_overlay_ops *overlay_ops = manager->overlay_ops; |
| 262 | struct exynos_drm_overlay *overlay = data; | 302 | struct exynos_drm_overlay *overlay = data; |
| 263 | 303 | ||
| 264 | overlay_ops->mode_set(manager->dev, overlay); | 304 | if (overlay_ops && overlay_ops->mode_set) |
| 305 | overlay_ops->mode_set(manager->dev, overlay); | ||
| 306 | } | ||
| 307 | |||
| 308 | void exynos_drm_encoder_crtc_disable(struct drm_encoder *encoder, void *data) | ||
| 309 | { | ||
| 310 | struct exynos_drm_manager *manager = | ||
| 311 | to_exynos_encoder(encoder)->manager; | ||
| 312 | struct exynos_drm_overlay_ops *overlay_ops = manager->overlay_ops; | ||
| 313 | |||
| 314 | DRM_DEBUG_KMS("\n"); | ||
| 315 | |||
| 316 | if (overlay_ops && overlay_ops->disable) | ||
| 317 | overlay_ops->disable(manager->dev); | ||
| 318 | |||
| 319 | /* | ||
| 320 | * crtc is already detached from encoder and last | ||
| 321 | * function for detaching is properly done, so | ||
| 322 | * clear pipe from manager to prevent repeated call | ||
| 323 | */ | ||
| 324 | if (!encoder->crtc) | ||
| 325 | manager->pipe = -1; | ||
| 265 | } | 326 | } |
| 266 | 327 | ||
| 267 | MODULE_AUTHOR("Inki Dae <inki.dae@samsung.com>"); | 328 | MODULE_AUTHOR("Inki Dae <inki.dae@samsung.com>"); |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.h b/drivers/gpu/drm/exynos/exynos_drm_encoder.h index 5ecd645d06a9..a22acfbf0e4e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.h +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.h | |||
| @@ -41,5 +41,6 @@ void exynos_drm_enable_vblank(struct drm_encoder *encoder, void *data); | |||
| 41 | void exynos_drm_disable_vblank(struct drm_encoder *encoder, void *data); | 41 | void exynos_drm_disable_vblank(struct drm_encoder *encoder, void *data); |
| 42 | void exynos_drm_encoder_crtc_commit(struct drm_encoder *encoder, void *data); | 42 | void exynos_drm_encoder_crtc_commit(struct drm_encoder *encoder, void *data); |
| 43 | void exynos_drm_encoder_crtc_mode_set(struct drm_encoder *encoder, void *data); | 43 | void exynos_drm_encoder_crtc_mode_set(struct drm_encoder *encoder, void *data); |
| 44 | void exynos_drm_encoder_crtc_disable(struct drm_encoder *encoder, void *data); | ||
| 44 | 45 | ||
| 45 | #endif | 46 | #endif |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index 48d29cfd5240..5bf4a1ac7f82 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c | |||
| @@ -29,7 +29,9 @@ | |||
| 29 | #include "drmP.h" | 29 | #include "drmP.h" |
| 30 | #include "drm_crtc.h" | 30 | #include "drm_crtc.h" |
| 31 | #include "drm_crtc_helper.h" | 31 | #include "drm_crtc_helper.h" |
| 32 | #include "drm_fb_helper.h" | ||
| 32 | 33 | ||
| 34 | #include "exynos_drm_drv.h" | ||
| 33 | #include "exynos_drm_fb.h" | 35 | #include "exynos_drm_fb.h" |
| 34 | #include "exynos_drm_buf.h" | 36 | #include "exynos_drm_buf.h" |
| 35 | #include "exynos_drm_gem.h" | 37 | #include "exynos_drm_gem.h" |
| @@ -41,14 +43,14 @@ | |||
| 41 | * | 43 | * |
| 42 | * @fb: drm framebuffer obejct. | 44 | * @fb: drm framebuffer obejct. |
| 43 | * @exynos_gem_obj: exynos specific gem object containing a gem object. | 45 | * @exynos_gem_obj: exynos specific gem object containing a gem object. |
| 44 | * @entry: pointer to exynos drm buffer entry object. | 46 | * @buffer: pointer to exynos_drm_gem_buffer object. |
| 45 | * - containing only the information to physically continuous memory | 47 | * - contain the memory information to memory region allocated |
| 46 | * region allocated at default framebuffer creation. | 48 | * at default framebuffer creation. |
| 47 | */ | 49 | */ |
| 48 | struct exynos_drm_fb { | 50 | struct exynos_drm_fb { |
| 49 | struct drm_framebuffer fb; | 51 | struct drm_framebuffer fb; |
| 50 | struct exynos_drm_gem_obj *exynos_gem_obj; | 52 | struct exynos_drm_gem_obj *exynos_gem_obj; |
| 51 | struct exynos_drm_buf_entry *entry; | 53 | struct exynos_drm_gem_buf *buffer; |
| 52 | }; | 54 | }; |
| 53 | 55 | ||
| 54 | static void exynos_drm_fb_destroy(struct drm_framebuffer *fb) | 56 | static void exynos_drm_fb_destroy(struct drm_framebuffer *fb) |
| @@ -63,8 +65,8 @@ static void exynos_drm_fb_destroy(struct drm_framebuffer *fb) | |||
| 63 | * default framebuffer has no gem object so | 65 | * default framebuffer has no gem object so |
| 64 | * a buffer of the default framebuffer should be released at here. | 66 | * a buffer of the default framebuffer should be released at here. |
| 65 | */ | 67 | */ |
| 66 | if (!exynos_fb->exynos_gem_obj && exynos_fb->entry) | 68 | if (!exynos_fb->exynos_gem_obj && exynos_fb->buffer) |
| 67 | exynos_drm_buf_destroy(fb->dev, exynos_fb->entry); | 69 | exynos_drm_buf_destroy(fb->dev, exynos_fb->buffer); |
| 68 | 70 | ||
| 69 | kfree(exynos_fb); | 71 | kfree(exynos_fb); |
| 70 | exynos_fb = NULL; | 72 | exynos_fb = NULL; |
| @@ -143,29 +145,29 @@ exynos_drm_fb_init(struct drm_file *file_priv, struct drm_device *dev, | |||
| 143 | */ | 145 | */ |
| 144 | if (!mode_cmd->handle) { | 146 | if (!mode_cmd->handle) { |
| 145 | if (!file_priv) { | 147 | if (!file_priv) { |
| 146 | struct exynos_drm_buf_entry *entry; | 148 | struct exynos_drm_gem_buf *buffer; |
| 147 | 149 | ||
| 148 | /* | 150 | /* |
| 149 | * in case that file_priv is NULL, it allocates | 151 | * in case that file_priv is NULL, it allocates |
| 150 | * only buffer and this buffer would be used | 152 | * only buffer and this buffer would be used |
| 151 | * for default framebuffer. | 153 | * for default framebuffer. |
| 152 | */ | 154 | */ |
| 153 | entry = exynos_drm_buf_create(dev, size); | 155 | buffer = exynos_drm_buf_create(dev, size); |
| 154 | if (IS_ERR(entry)) { | 156 | if (IS_ERR(buffer)) { |
| 155 | ret = PTR_ERR(entry); | 157 | ret = PTR_ERR(buffer); |
| 156 | goto err_buffer; | 158 | goto err_buffer; |
| 157 | } | 159 | } |
| 158 | 160 | ||
| 159 | exynos_fb->entry = entry; | 161 | exynos_fb->buffer = buffer; |
| 160 | 162 | ||
| 161 | DRM_LOG_KMS("default fb: paddr = 0x%lx, size = 0x%x\n", | 163 | DRM_LOG_KMS("default: dma_addr = 0x%lx, size = 0x%x\n", |
| 162 | (unsigned long)entry->paddr, size); | 164 | (unsigned long)buffer->dma_addr, size); |
| 163 | 165 | ||
| 164 | goto out; | 166 | goto out; |
| 165 | } else { | 167 | } else { |
| 166 | exynos_gem_obj = exynos_drm_gem_create(file_priv, dev, | 168 | exynos_gem_obj = exynos_drm_gem_create(dev, file_priv, |
| 167 | size, | 169 | &mode_cmd->handle, |
| 168 | &mode_cmd->handle); | 170 | size); |
| 169 | if (IS_ERR(exynos_gem_obj)) { | 171 | if (IS_ERR(exynos_gem_obj)) { |
| 170 | ret = PTR_ERR(exynos_gem_obj); | 172 | ret = PTR_ERR(exynos_gem_obj); |
| 171 | goto err_buffer; | 173 | goto err_buffer; |
| @@ -189,10 +191,10 @@ exynos_drm_fb_init(struct drm_file *file_priv, struct drm_device *dev, | |||
| 189 | * so that default framebuffer has no its own gem object, | 191 | * so that default framebuffer has no its own gem object, |
| 190 | * only its own buffer object. | 192 | * only its own buffer object. |
| 191 | */ | 193 | */ |
| 192 | exynos_fb->entry = exynos_gem_obj->entry; | 194 | exynos_fb->buffer = exynos_gem_obj->buffer; |
| 193 | 195 | ||
| 194 | DRM_LOG_KMS("paddr = 0x%lx, size = 0x%x, gem object = 0x%x\n", | 196 | DRM_LOG_KMS("dma_addr = 0x%lx, size = 0x%x, gem object = 0x%x\n", |
| 195 | (unsigned long)exynos_fb->entry->paddr, size, | 197 | (unsigned long)exynos_fb->buffer->dma_addr, size, |
| 196 | (unsigned int)&exynos_gem_obj->base); | 198 | (unsigned int)&exynos_gem_obj->base); |
| 197 | 199 | ||
| 198 | out: | 200 | out: |
| @@ -220,26 +222,36 @@ struct drm_framebuffer *exynos_drm_fb_create(struct drm_device *dev, | |||
| 220 | return exynos_drm_fb_init(file_priv, dev, mode_cmd); | 222 | return exynos_drm_fb_init(file_priv, dev, mode_cmd); |
| 221 | } | 223 | } |
| 222 | 224 | ||
| 223 | struct exynos_drm_buf_entry *exynos_drm_fb_get_buf(struct drm_framebuffer *fb) | 225 | struct exynos_drm_gem_buf *exynos_drm_fb_get_buf(struct drm_framebuffer *fb) |
| 224 | { | 226 | { |
| 225 | struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); | 227 | struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); |
| 226 | struct exynos_drm_buf_entry *entry; | 228 | struct exynos_drm_gem_buf *buffer; |
| 227 | 229 | ||
| 228 | DRM_DEBUG_KMS("%s\n", __FILE__); | 230 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 229 | 231 | ||
| 230 | entry = exynos_fb->entry; | 232 | buffer = exynos_fb->buffer; |
| 231 | if (!entry) | 233 | if (!buffer) |
| 232 | return NULL; | 234 | return NULL; |
| 233 | 235 | ||
| 234 | DRM_DEBUG_KMS("vaddr = 0x%lx, paddr = 0x%lx\n", | 236 | DRM_DEBUG_KMS("vaddr = 0x%lx, dma_addr = 0x%lx\n", |
| 235 | (unsigned long)entry->vaddr, | 237 | (unsigned long)buffer->kvaddr, |
| 236 | (unsigned long)entry->paddr); | 238 | (unsigned long)buffer->dma_addr); |
| 237 | 239 | ||
| 238 | return entry; | 240 | return buffer; |
| 241 | } | ||
| 242 | |||
| 243 | static void exynos_drm_output_poll_changed(struct drm_device *dev) | ||
| 244 | { | ||
| 245 | struct exynos_drm_private *private = dev->dev_private; | ||
| 246 | struct drm_fb_helper *fb_helper = private->fb_helper; | ||
| 247 | |||
| 248 | if (fb_helper) | ||
| 249 | drm_fb_helper_hotplug_event(fb_helper); | ||
| 239 | } | 250 | } |
| 240 | 251 | ||
| 241 | static struct drm_mode_config_funcs exynos_drm_mode_config_funcs = { | 252 | static struct drm_mode_config_funcs exynos_drm_mode_config_funcs = { |
| 242 | .fb_create = exynos_drm_fb_create, | 253 | .fb_create = exynos_drm_fb_create, |
| 254 | .output_poll_changed = exynos_drm_output_poll_changed, | ||
| 243 | }; | 255 | }; |
| 244 | 256 | ||
| 245 | void exynos_drm_mode_config_init(struct drm_device *dev) | 257 | void exynos_drm_mode_config_init(struct drm_device *dev) |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 1f4b3d1a7713..836f41008187 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c | |||
| @@ -33,6 +33,7 @@ | |||
| 33 | 33 | ||
| 34 | #include "exynos_drm_drv.h" | 34 | #include "exynos_drm_drv.h" |
| 35 | #include "exynos_drm_fb.h" | 35 | #include "exynos_drm_fb.h" |
| 36 | #include "exynos_drm_gem.h" | ||
| 36 | #include "exynos_drm_buf.h" | 37 | #include "exynos_drm_buf.h" |
| 37 | 38 | ||
| 38 | #define MAX_CONNECTOR 4 | 39 | #define MAX_CONNECTOR 4 |
| @@ -85,15 +86,13 @@ static struct fb_ops exynos_drm_fb_ops = { | |||
| 85 | }; | 86 | }; |
| 86 | 87 | ||
| 87 | static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, | 88 | static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, |
| 88 | struct drm_framebuffer *fb, | 89 | struct drm_framebuffer *fb) |
| 89 | unsigned int fb_width, | ||
| 90 | unsigned int fb_height) | ||
| 91 | { | 90 | { |
| 92 | struct fb_info *fbi = helper->fbdev; | 91 | struct fb_info *fbi = helper->fbdev; |
| 93 | struct drm_device *dev = helper->dev; | 92 | struct drm_device *dev = helper->dev; |
| 94 | struct exynos_drm_fbdev *exynos_fb = to_exynos_fbdev(helper); | 93 | struct exynos_drm_fbdev *exynos_fb = to_exynos_fbdev(helper); |
| 95 | struct exynos_drm_buf_entry *entry; | 94 | struct exynos_drm_gem_buf *buffer; |
| 96 | unsigned int size = fb_width * fb_height * (fb->bits_per_pixel >> 3); | 95 | unsigned int size = fb->width * fb->height * (fb->bits_per_pixel >> 3); |
| 97 | unsigned long offset; | 96 | unsigned long offset; |
| 98 | 97 | ||
| 99 | DRM_DEBUG_KMS("%s\n", __FILE__); | 98 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| @@ -101,20 +100,20 @@ static int exynos_drm_fbdev_update(struct drm_fb_helper *helper, | |||
| 101 | exynos_fb->fb = fb; | 100 | exynos_fb->fb = fb; |
| 102 | 101 | ||
| 103 | drm_fb_helper_fill_fix(fbi, fb->pitch, fb->depth); | 102 | drm_fb_helper_fill_fix(fbi, fb->pitch, fb->depth); |
| 104 | drm_fb_helper_fill_var(fbi, helper, fb_width, fb_height); | 103 | drm_fb_helper_fill_var(fbi, helper, fb->width, fb->height); |
| 105 | 104 | ||
| 106 | entry = exynos_drm_fb_get_buf(fb); | 105 | buffer = exynos_drm_fb_get_buf(fb); |
| 107 | if (!entry) { | 106 | if (!buffer) { |
| 108 | DRM_LOG_KMS("entry is null.\n"); | 107 | DRM_LOG_KMS("buffer is null.\n"); |
| 109 | return -EFAULT; | 108 | return -EFAULT; |
| 110 | } | 109 | } |
| 111 | 110 | ||
| 112 | offset = fbi->var.xoffset * (fb->bits_per_pixel >> 3); | 111 | offset = fbi->var.xoffset * (fb->bits_per_pixel >> 3); |
| 113 | offset += fbi->var.yoffset * fb->pitch; | 112 | offset += fbi->var.yoffset * fb->pitch; |
| 114 | 113 | ||
| 115 | dev->mode_config.fb_base = entry->paddr; | 114 | dev->mode_config.fb_base = (resource_size_t)buffer->dma_addr; |
| 116 | fbi->screen_base = entry->vaddr + offset; | 115 | fbi->screen_base = buffer->kvaddr + offset; |
| 117 | fbi->fix.smem_start = entry->paddr + offset; | 116 | fbi->fix.smem_start = (unsigned long)(buffer->dma_addr + offset); |
| 118 | fbi->screen_size = size; | 117 | fbi->screen_size = size; |
| 119 | fbi->fix.smem_len = size; | 118 | fbi->fix.smem_len = size; |
| 120 | 119 | ||
| @@ -171,8 +170,7 @@ static int exynos_drm_fbdev_create(struct drm_fb_helper *helper, | |||
| 171 | goto out; | 170 | goto out; |
| 172 | } | 171 | } |
| 173 | 172 | ||
| 174 | ret = exynos_drm_fbdev_update(helper, helper->fb, sizes->fb_width, | 173 | ret = exynos_drm_fbdev_update(helper, helper->fb); |
| 175 | sizes->fb_height); | ||
| 176 | if (ret < 0) | 174 | if (ret < 0) |
| 177 | fb_dealloc_cmap(&fbi->cmap); | 175 | fb_dealloc_cmap(&fbi->cmap); |
| 178 | 176 | ||
| @@ -235,8 +233,7 @@ static int exynos_drm_fbdev_recreate(struct drm_fb_helper *helper, | |||
| 235 | } | 233 | } |
| 236 | 234 | ||
| 237 | helper->fb = exynos_fbdev->fb; | 235 | helper->fb = exynos_fbdev->fb; |
| 238 | return exynos_drm_fbdev_update(helper, helper->fb, sizes->fb_width, | 236 | return exynos_drm_fbdev_update(helper, helper->fb); |
| 239 | sizes->fb_height); | ||
| 240 | } | 237 | } |
| 241 | 238 | ||
| 242 | static int exynos_drm_fbdev_probe(struct drm_fb_helper *helper, | 239 | static int exynos_drm_fbdev_probe(struct drm_fb_helper *helper, |
| @@ -405,6 +402,18 @@ int exynos_drm_fbdev_reinit(struct drm_device *dev) | |||
| 405 | fb_helper = private->fb_helper; | 402 | fb_helper = private->fb_helper; |
| 406 | 403 | ||
| 407 | if (fb_helper) { | 404 | if (fb_helper) { |
| 405 | struct list_head temp_list; | ||
| 406 | |||
| 407 | INIT_LIST_HEAD(&temp_list); | ||
| 408 | |||
| 409 | /* | ||
| 410 | * fb_helper is reintialized but kernel fb is reused | ||
| 411 | * so kernel_fb_list need to be backuped and restored | ||
| 412 | */ | ||
| 413 | if (!list_empty(&fb_helper->kernel_fb_list)) | ||
| 414 | list_replace_init(&fb_helper->kernel_fb_list, | ||
| 415 | &temp_list); | ||
| 416 | |||
| 408 | drm_fb_helper_fini(fb_helper); | 417 | drm_fb_helper_fini(fb_helper); |
| 409 | 418 | ||
| 410 | ret = drm_fb_helper_init(dev, fb_helper, | 419 | ret = drm_fb_helper_init(dev, fb_helper, |
| @@ -414,6 +423,9 @@ int exynos_drm_fbdev_reinit(struct drm_device *dev) | |||
| 414 | return ret; | 423 | return ret; |
| 415 | } | 424 | } |
| 416 | 425 | ||
| 426 | if (!list_empty(&temp_list)) | ||
| 427 | list_replace(&temp_list, &fb_helper->kernel_fb_list); | ||
| 428 | |||
| 417 | ret = drm_fb_helper_single_add_all_connectors(fb_helper); | 429 | ret = drm_fb_helper_single_add_all_connectors(fb_helper); |
| 418 | if (ret < 0) { | 430 | if (ret < 0) { |
| 419 | DRM_ERROR("failed to add fb helper to connectors\n"); | 431 | DRM_ERROR("failed to add fb helper to connectors\n"); |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 4659c88cdd9b..db3b3d9e731d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c | |||
| @@ -64,7 +64,7 @@ struct fimd_win_data { | |||
| 64 | unsigned int fb_width; | 64 | unsigned int fb_width; |
| 65 | unsigned int fb_height; | 65 | unsigned int fb_height; |
| 66 | unsigned int bpp; | 66 | unsigned int bpp; |
| 67 | dma_addr_t paddr; | 67 | dma_addr_t dma_addr; |
| 68 | void __iomem *vaddr; | 68 | void __iomem *vaddr; |
| 69 | unsigned int buf_offsize; | 69 | unsigned int buf_offsize; |
| 70 | unsigned int line_size; /* bytes */ | 70 | unsigned int line_size; /* bytes */ |
| @@ -124,7 +124,7 @@ static int fimd_display_power_on(struct device *dev, int mode) | |||
| 124 | return 0; | 124 | return 0; |
| 125 | } | 125 | } |
| 126 | 126 | ||
| 127 | static struct exynos_drm_display fimd_display = { | 127 | static struct exynos_drm_display_ops fimd_display_ops = { |
| 128 | .type = EXYNOS_DISPLAY_TYPE_LCD, | 128 | .type = EXYNOS_DISPLAY_TYPE_LCD, |
| 129 | .is_connected = fimd_display_is_connected, | 129 | .is_connected = fimd_display_is_connected, |
| 130 | .get_timing = fimd_get_timing, | 130 | .get_timing = fimd_get_timing, |
| @@ -177,6 +177,40 @@ static void fimd_commit(struct device *dev) | |||
| 177 | writel(val, ctx->regs + VIDCON0); | 177 | writel(val, ctx->regs + VIDCON0); |
| 178 | } | 178 | } |
| 179 | 179 | ||
| 180 | static void fimd_disable(struct device *dev) | ||
| 181 | { | ||
| 182 | struct fimd_context *ctx = get_fimd_context(dev); | ||
| 183 | struct exynos_drm_subdrv *subdrv = &ctx->subdrv; | ||
| 184 | struct drm_device *drm_dev = subdrv->drm_dev; | ||
| 185 | struct exynos_drm_manager *manager = &subdrv->manager; | ||
| 186 | u32 val; | ||
| 187 | |||
| 188 | DRM_DEBUG_KMS("%s\n", __FILE__); | ||
| 189 | |||
| 190 | /* fimd dma off */ | ||
| 191 | val = readl(ctx->regs + VIDCON0); | ||
| 192 | val &= ~(VIDCON0_ENVID | VIDCON0_ENVID_F); | ||
| 193 | writel(val, ctx->regs + VIDCON0); | ||
| 194 | |||
| 195 | /* | ||
| 196 | * if vblank is enabled status with dma off then | ||
| 197 | * it disables vsync interrupt. | ||
| 198 | */ | ||
| 199 | if (drm_dev->vblank_enabled[manager->pipe] && | ||
| 200 | atomic_read(&drm_dev->vblank_refcount[manager->pipe])) { | ||
| 201 | drm_vblank_put(drm_dev, manager->pipe); | ||
| 202 | |||
| 203 | /* | ||
| 204 | * if vblank_disable_allowed is 0 then disable | ||
| 205 | * vsync interrupt right now else the vsync interrupt | ||
| 206 | * would be disabled by drm timer once a current process | ||
| 207 | * gives up ownershop of vblank event. | ||
| 208 | */ | ||
| 209 | if (!drm_dev->vblank_disable_allowed) | ||
| 210 | drm_vblank_off(drm_dev, manager->pipe); | ||
| 211 | } | ||
| 212 | } | ||
| 213 | |||
| 180 | static int fimd_enable_vblank(struct device *dev) | 214 | static int fimd_enable_vblank(struct device *dev) |
| 181 | { | 215 | { |
| 182 | struct fimd_context *ctx = get_fimd_context(dev); | 216 | struct fimd_context *ctx = get_fimd_context(dev); |
| @@ -220,6 +254,7 @@ static void fimd_disable_vblank(struct device *dev) | |||
| 220 | 254 | ||
| 221 | static struct exynos_drm_manager_ops fimd_manager_ops = { | 255 | static struct exynos_drm_manager_ops fimd_manager_ops = { |
| 222 | .commit = fimd_commit, | 256 | .commit = fimd_commit, |
| 257 | .disable = fimd_disable, | ||
| 223 | .enable_vblank = fimd_enable_vblank, | 258 | .enable_vblank = fimd_enable_vblank, |
| 224 | .disable_vblank = fimd_disable_vblank, | 259 | .disable_vblank = fimd_disable_vblank, |
| 225 | }; | 260 | }; |
| @@ -251,7 +286,7 @@ static void fimd_win_mode_set(struct device *dev, | |||
| 251 | win_data->ovl_height = overlay->crtc_height; | 286 | win_data->ovl_height = overlay->crtc_height; |
| 252 | win_data->fb_width = overlay->fb_width; | 287 | win_data->fb_width = overlay->fb_width; |
| 253 | win_data->fb_height = overlay->fb_height; | 288 | win_data->fb_height = overlay->fb_height; |
| 254 | win_data->paddr = overlay->paddr + offset; | 289 | win_data->dma_addr = overlay->dma_addr + offset; |
| 255 | win_data->vaddr = overlay->vaddr + offset; | 290 | win_data->vaddr = overlay->vaddr + offset; |
| 256 | win_data->bpp = overlay->bpp; | 291 | win_data->bpp = overlay->bpp; |
| 257 | win_data->buf_offsize = (overlay->fb_width - overlay->crtc_width) * | 292 | win_data->buf_offsize = (overlay->fb_width - overlay->crtc_width) * |
| @@ -263,7 +298,7 @@ static void fimd_win_mode_set(struct device *dev, | |||
| 263 | DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n", | 298 | DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n", |
| 264 | win_data->ovl_width, win_data->ovl_height); | 299 | win_data->ovl_width, win_data->ovl_height); |
| 265 | DRM_DEBUG_KMS("paddr = 0x%lx, vaddr = 0x%lx\n", | 300 | DRM_DEBUG_KMS("paddr = 0x%lx, vaddr = 0x%lx\n", |
| 266 | (unsigned long)win_data->paddr, | 301 | (unsigned long)win_data->dma_addr, |
| 267 | (unsigned long)win_data->vaddr); | 302 | (unsigned long)win_data->vaddr); |
| 268 | DRM_DEBUG_KMS("fb_width = %d, crtc_width = %d\n", | 303 | DRM_DEBUG_KMS("fb_width = %d, crtc_width = %d\n", |
| 269 | overlay->fb_width, overlay->crtc_width); | 304 | overlay->fb_width, overlay->crtc_width); |
| @@ -376,16 +411,16 @@ static void fimd_win_commit(struct device *dev) | |||
| 376 | writel(val, ctx->regs + SHADOWCON); | 411 | writel(val, ctx->regs + SHADOWCON); |
| 377 | 412 | ||
| 378 | /* buffer start address */ | 413 | /* buffer start address */ |
| 379 | val = win_data->paddr; | 414 | val = (unsigned long)win_data->dma_addr; |
| 380 | writel(val, ctx->regs + VIDWx_BUF_START(win, 0)); | 415 | writel(val, ctx->regs + VIDWx_BUF_START(win, 0)); |
| 381 | 416 | ||
| 382 | /* buffer end address */ | 417 | /* buffer end address */ |
| 383 | size = win_data->fb_width * win_data->ovl_height * (win_data->bpp >> 3); | 418 | size = win_data->fb_width * win_data->ovl_height * (win_data->bpp >> 3); |
| 384 | val = win_data->paddr + size; | 419 | val = (unsigned long)(win_data->dma_addr + size); |
| 385 | writel(val, ctx->regs + VIDWx_BUF_END(win, 0)); | 420 | writel(val, ctx->regs + VIDWx_BUF_END(win, 0)); |
| 386 | 421 | ||
| 387 | DRM_DEBUG_KMS("start addr = 0x%lx, end addr = 0x%lx, size = 0x%lx\n", | 422 | DRM_DEBUG_KMS("start addr = 0x%lx, end addr = 0x%lx, size = 0x%lx\n", |
| 388 | (unsigned long)win_data->paddr, val, size); | 423 | (unsigned long)win_data->dma_addr, val, size); |
| 389 | DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n", | 424 | DRM_DEBUG_KMS("ovl_width = %d, ovl_height = %d\n", |
| 390 | win_data->ovl_width, win_data->ovl_height); | 425 | win_data->ovl_width, win_data->ovl_height); |
| 391 | 426 | ||
| @@ -447,7 +482,6 @@ static void fimd_win_commit(struct device *dev) | |||
| 447 | static void fimd_win_disable(struct device *dev) | 482 | static void fimd_win_disable(struct device *dev) |
| 448 | { | 483 | { |
| 449 | struct fimd_context *ctx = get_fimd_context(dev); | 484 | struct fimd_context *ctx = get_fimd_context(dev); |
| 450 | struct fimd_win_data *win_data; | ||
| 451 | int win = ctx->default_win; | 485 | int win = ctx->default_win; |
| 452 | u32 val; | 486 | u32 val; |
| 453 | 487 | ||
| @@ -456,8 +490,6 @@ static void fimd_win_disable(struct device *dev) | |||
| 456 | if (win < 0 || win > WINDOWS_NR) | 490 | if (win < 0 || win > WINDOWS_NR) |
| 457 | return; | 491 | return; |
| 458 | 492 | ||
| 459 | win_data = &ctx->win_data[win]; | ||
| 460 | |||
| 461 | /* protect windows */ | 493 | /* protect windows */ |
| 462 | val = readl(ctx->regs + SHADOWCON); | 494 | val = readl(ctx->regs + SHADOWCON); |
| 463 | val |= SHADOWCON_WINx_PROTECT(win); | 495 | val |= SHADOWCON_WINx_PROTECT(win); |
| @@ -528,6 +560,16 @@ static irqreturn_t fimd_irq_handler(int irq, void *dev_id) | |||
| 528 | /* VSYNC interrupt */ | 560 | /* VSYNC interrupt */ |
| 529 | writel(VIDINTCON1_INT_FRAME, ctx->regs + VIDINTCON1); | 561 | writel(VIDINTCON1_INT_FRAME, ctx->regs + VIDINTCON1); |
| 530 | 562 | ||
| 563 | /* | ||
| 564 | * in case that vblank_disable_allowed is 1, it could induce | ||
| 565 | * the problem that manager->pipe could be -1 because with | ||
| 566 | * disable callback, vsync interrupt isn't disabled and at this moment, | ||
| 567 | * vsync interrupt could occur. the vsync interrupt would be disabled | ||
| 568 | * by timer handler later. | ||
| 569 | */ | ||
| 570 | if (manager->pipe == -1) | ||
| 571 | return IRQ_HANDLED; | ||
| 572 | |||
| 531 | drm_handle_vblank(drm_dev, manager->pipe); | 573 | drm_handle_vblank(drm_dev, manager->pipe); |
| 532 | fimd_finish_pageflip(drm_dev, manager->pipe); | 574 | fimd_finish_pageflip(drm_dev, manager->pipe); |
| 533 | 575 | ||
| @@ -548,13 +590,6 @@ static int fimd_subdrv_probe(struct drm_device *drm_dev, struct device *dev) | |||
| 548 | */ | 590 | */ |
| 549 | drm_dev->irq_enabled = 1; | 591 | drm_dev->irq_enabled = 1; |
| 550 | 592 | ||
| 551 | /* | ||
| 552 | * with vblank_disable_allowed = 1, vblank interrupt will be disabled | ||
| 553 | * by drm timer once a current process gives up ownership of | ||
| 554 | * vblank event.(drm_vblank_put function was called) | ||
| 555 | */ | ||
| 556 | drm_dev->vblank_disable_allowed = 1; | ||
| 557 | |||
| 558 | return 0; | 593 | return 0; |
| 559 | } | 594 | } |
| 560 | 595 | ||
| @@ -731,7 +766,7 @@ static int __devinit fimd_probe(struct platform_device *pdev) | |||
| 731 | subdrv->manager.pipe = -1; | 766 | subdrv->manager.pipe = -1; |
| 732 | subdrv->manager.ops = &fimd_manager_ops; | 767 | subdrv->manager.ops = &fimd_manager_ops; |
| 733 | subdrv->manager.overlay_ops = &fimd_overlay_ops; | 768 | subdrv->manager.overlay_ops = &fimd_overlay_ops; |
| 734 | subdrv->manager.display = &fimd_display; | 769 | subdrv->manager.display_ops = &fimd_display_ops; |
| 735 | subdrv->manager.dev = dev; | 770 | subdrv->manager.dev = dev; |
| 736 | 771 | ||
| 737 | platform_set_drvdata(pdev, ctx); | 772 | platform_set_drvdata(pdev, ctx); |
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index a8e7a88906ed..aba0fe47f7ea 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c | |||
| @@ -62,40 +62,28 @@ static unsigned int get_gem_mmap_offset(struct drm_gem_object *obj) | |||
| 62 | return (unsigned int)obj->map_list.hash.key << PAGE_SHIFT; | 62 | return (unsigned int)obj->map_list.hash.key << PAGE_SHIFT; |
| 63 | } | 63 | } |
| 64 | 64 | ||
| 65 | struct exynos_drm_gem_obj *exynos_drm_gem_create(struct drm_file *file_priv, | 65 | static struct exynos_drm_gem_obj |
| 66 | struct drm_device *dev, unsigned int size, | 66 | *exynos_drm_gem_init(struct drm_device *drm_dev, |
| 67 | unsigned int *handle) | 67 | struct drm_file *file_priv, unsigned int *handle, |
| 68 | unsigned int size) | ||
| 68 | { | 69 | { |
| 69 | struct exynos_drm_gem_obj *exynos_gem_obj; | 70 | struct exynos_drm_gem_obj *exynos_gem_obj; |
| 70 | struct exynos_drm_buf_entry *entry; | ||
| 71 | struct drm_gem_object *obj; | 71 | struct drm_gem_object *obj; |
| 72 | int ret; | 72 | int ret; |
| 73 | 73 | ||
| 74 | DRM_DEBUG_KMS("%s\n", __FILE__); | ||
| 75 | |||
| 76 | size = roundup(size, PAGE_SIZE); | ||
| 77 | |||
| 78 | exynos_gem_obj = kzalloc(sizeof(*exynos_gem_obj), GFP_KERNEL); | 74 | exynos_gem_obj = kzalloc(sizeof(*exynos_gem_obj), GFP_KERNEL); |
| 79 | if (!exynos_gem_obj) { | 75 | if (!exynos_gem_obj) { |
| 80 | DRM_ERROR("failed to allocate exynos gem object.\n"); | 76 | DRM_ERROR("failed to allocate exynos gem object.\n"); |
| 81 | return ERR_PTR(-ENOMEM); | 77 | return ERR_PTR(-ENOMEM); |
| 82 | } | 78 | } |
| 83 | 79 | ||
| 84 | /* allocate the new buffer object and memory region. */ | ||
| 85 | entry = exynos_drm_buf_create(dev, size); | ||
| 86 | if (!entry) { | ||
| 87 | kfree(exynos_gem_obj); | ||
| 88 | return ERR_PTR(-ENOMEM); | ||
| 89 | } | ||
| 90 | |||
| 91 | exynos_gem_obj->entry = entry; | ||
| 92 | |||
| 93 | obj = &exynos_gem_obj->base; | 80 | obj = &exynos_gem_obj->base; |
| 94 | 81 | ||
| 95 | ret = drm_gem_object_init(dev, obj, size); | 82 | ret = drm_gem_object_init(drm_dev, obj, size); |
| 96 | if (ret < 0) { | 83 | if (ret < 0) { |
| 97 | DRM_ERROR("failed to initailize gem object.\n"); | 84 | DRM_ERROR("failed to initialize gem object.\n"); |
| 98 | goto err_obj_init; | 85 | ret = -EINVAL; |
| 86 | goto err_object_init; | ||
| 99 | } | 87 | } |
| 100 | 88 | ||
| 101 | DRM_DEBUG_KMS("created file object = 0x%x\n", (unsigned int)obj->filp); | 89 | DRM_DEBUG_KMS("created file object = 0x%x\n", (unsigned int)obj->filp); |
| @@ -127,24 +115,50 @@ err_handle_create: | |||
| 127 | err_create_mmap_offset: | 115 | err_create_mmap_offset: |
| 128 | drm_gem_object_release(obj); | 116 | drm_gem_object_release(obj); |
| 129 | 117 | ||
| 130 | err_obj_init: | 118 | err_object_init: |
| 131 | exynos_drm_buf_destroy(dev, exynos_gem_obj->entry); | ||
| 132 | |||
| 133 | kfree(exynos_gem_obj); | 119 | kfree(exynos_gem_obj); |
| 134 | 120 | ||
| 135 | return ERR_PTR(ret); | 121 | return ERR_PTR(ret); |
| 136 | } | 122 | } |
| 137 | 123 | ||
| 124 | struct exynos_drm_gem_obj *exynos_drm_gem_create(struct drm_device *dev, | ||
| 125 | struct drm_file *file_priv, | ||
| 126 | unsigned int *handle, unsigned long size) | ||
| 127 | { | ||
| 128 | |||
| 129 | struct exynos_drm_gem_obj *exynos_gem_obj = NULL; | ||
| 130 | struct exynos_drm_gem_buf *buffer; | ||
| 131 | |||
| 132 | size = roundup(size, PAGE_SIZE); | ||
| 133 | |||
| 134 | DRM_DEBUG_KMS("%s: size = 0x%lx\n", __FILE__, size); | ||
| 135 | |||
| 136 | buffer = exynos_drm_buf_create(dev, size); | ||
| 137 | if (IS_ERR(buffer)) { | ||
| 138 | return ERR_CAST(buffer); | ||
| 139 | } | ||
| 140 | |||
| 141 | exynos_gem_obj = exynos_drm_gem_init(dev, file_priv, handle, size); | ||
| 142 | if (IS_ERR(exynos_gem_obj)) { | ||
| 143 | exynos_drm_buf_destroy(dev, buffer); | ||
| 144 | return exynos_gem_obj; | ||
| 145 | } | ||
| 146 | |||
| 147 | exynos_gem_obj->buffer = buffer; | ||
| 148 | |||
| 149 | return exynos_gem_obj; | ||
| 150 | } | ||
| 151 | |||
| 138 | int exynos_drm_gem_create_ioctl(struct drm_device *dev, void *data, | 152 | int exynos_drm_gem_create_ioctl(struct drm_device *dev, void *data, |
| 139 | struct drm_file *file_priv) | 153 | struct drm_file *file_priv) |
| 140 | { | 154 | { |
| 141 | struct drm_exynos_gem_create *args = data; | 155 | struct drm_exynos_gem_create *args = data; |
| 142 | struct exynos_drm_gem_obj *exynos_gem_obj; | 156 | struct exynos_drm_gem_obj *exynos_gem_obj = NULL; |
| 143 | 157 | ||
| 144 | DRM_DEBUG_KMS("%s : size = 0x%x\n", __FILE__, args->size); | 158 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| 145 | 159 | ||
| 146 | exynos_gem_obj = exynos_drm_gem_create(file_priv, dev, args->size, | 160 | exynos_gem_obj = exynos_drm_gem_create(dev, file_priv, |
| 147 | &args->handle); | 161 | &args->handle, args->size); |
| 148 | if (IS_ERR(exynos_gem_obj)) | 162 | if (IS_ERR(exynos_gem_obj)) |
| 149 | return PTR_ERR(exynos_gem_obj); | 163 | return PTR_ERR(exynos_gem_obj); |
| 150 | 164 | ||
| @@ -175,7 +189,7 @@ static int exynos_drm_gem_mmap_buffer(struct file *filp, | |||
| 175 | { | 189 | { |
| 176 | struct drm_gem_object *obj = filp->private_data; | 190 | struct drm_gem_object *obj = filp->private_data; |
| 177 | struct exynos_drm_gem_obj *exynos_gem_obj = to_exynos_gem_obj(obj); | 191 | struct exynos_drm_gem_obj *exynos_gem_obj = to_exynos_gem_obj(obj); |
| 178 | struct exynos_drm_buf_entry *entry; | 192 | struct exynos_drm_gem_buf *buffer; |
| 179 | unsigned long pfn, vm_size; | 193 | unsigned long pfn, vm_size; |
| 180 | 194 | ||
| 181 | DRM_DEBUG_KMS("%s\n", __FILE__); | 195 | DRM_DEBUG_KMS("%s\n", __FILE__); |
| @@ -187,20 +201,20 @@ static int exynos_drm_gem_mmap_buffer(struct file *filp, | |||
| 187 | 201 | ||
| 188 | vm_size = vma->vm_end - vma->vm_start; | 202 | vm_size = vma->vm_end - vma->vm_start; |
| 189 | /* | 203 | /* |
| 190 | * a entry contains information to physically continuous memory | 204 | * a buffer contains information to physically continuous memory |
| 191 | * allocated by user request or at framebuffer creation. | 205 | * allocated by user request or at framebuffer creation. |
| 192 | */ | 206 | */ |
| 193 | entry = exynos_gem_obj->entry; | 207 | buffer = exynos_gem_obj->buffer; |
| 194 | 208 | ||
| 195 | /* check if user-requested size is valid. */ | 209 | /* check if user-requested size is valid. */ |
| 196 | if (vm_size > entry->size) | 210 | if (vm_size > buffer->size) |
| 197 | return -EINVAL; | 211 | return -EINVAL; |
| 198 | 212 | ||
| 199 | /* | 213 | /* |
| 200 | * get page frame number to physical memory to be mapped | 214 | * get page frame number to physical memory to be mapped |
| 201 | * to user space. | 215 | * to user space. |
| 202 | */ | 216 | */ |
| 203 | pfn = exynos_gem_obj->entry->paddr >> PAGE_SHIFT; | 217 | pfn = ((unsigned long)exynos_gem_obj->buffer->dma_addr) >> PAGE_SHIFT; |
| 204 | 218 | ||
| 205 | DRM_DEBUG_KMS("pfn = 0x%lx\n", pfn); | 219 | DRM_DEBUG_KMS("pfn = 0x%lx\n", pfn); |
| 206 | 220 | ||
| @@ -281,7 +295,7 @@ void exynos_drm_gem_free_object(struct drm_gem_object *gem_obj) | |||
| 281 | 295 | ||
| 282 | exynos_gem_obj = to_exynos_gem_obj(gem_obj); | 296 | exynos_gem_obj = to_exynos_gem_obj(gem_obj); |
| 283 | 297 | ||
| 284 | exynos_drm_buf_destroy(gem_obj->dev, exynos_gem_obj->entry); | 298 | exynos_drm_buf_destroy(gem_obj->dev, exynos_gem_obj->buffer); |
| 285 | 299 | ||
| 286 | kfree(exynos_gem_obj); | 300 | kfree(exynos_gem_obj); |
| 287 | } | 301 | } |
| @@ -302,8 +316,8 @@ int exynos_drm_gem_dumb_create(struct drm_file *file_priv, | |||
| 302 | args->pitch = args->width * args->bpp >> 3; | 316 | args->pitch = args->width * args->bpp >> 3; |
| 303 | args->size = args->pitch * args->height; | 317 | args->size = args->pitch * args->height; |
| 304 | 318 | ||
| 305 | exynos_gem_obj = exynos_drm_gem_create(file_priv, dev, args->size, | 319 | exynos_gem_obj = exynos_drm_gem_create(dev, file_priv, &args->handle, |
| 306 | &args->handle); | 320 | args->size); |
| 307 | if (IS_ERR(exynos_gem_obj)) | 321 | if (IS_ERR(exynos_gem_obj)) |
| 308 | return PTR_ERR(exynos_gem_obj); | 322 | return PTR_ERR(exynos_gem_obj); |
| 309 | 323 | ||
| @@ -360,7 +374,8 @@ int exynos_drm_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
| 360 | 374 | ||
| 361 | mutex_lock(&dev->struct_mutex); | 375 | mutex_lock(&dev->struct_mutex); |
| 362 | 376 | ||
| 363 | pfn = (exynos_gem_obj->entry->paddr >> PAGE_SHIFT) + page_offset; | 377 | pfn = (((unsigned long)exynos_gem_obj->buffer->dma_addr) >> |
| 378 | PAGE_SHIFT) + page_offset; | ||
| 364 | 379 | ||
| 365 | ret = vm_insert_mixed(vma, (unsigned long)vmf->virtual_address, pfn); | 380 | ret = vm_insert_mixed(vma, (unsigned long)vmf->virtual_address, pfn); |
| 366 | 381 | ||
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.h b/drivers/gpu/drm/exynos/exynos_drm_gem.h index e5fc0148277b..ef8797334e6d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.h +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.h | |||
| @@ -30,13 +30,29 @@ | |||
| 30 | struct exynos_drm_gem_obj, base) | 30 | struct exynos_drm_gem_obj, base) |
| 31 | 31 | ||
| 32 | /* | 32 | /* |
| 33 | * exynos drm gem buffer structure. | ||
| 34 | * | ||
| 35 | * @kvaddr: kernel virtual address to allocated memory region. | ||
| 36 | * @dma_addr: bus address(accessed by dma) to allocated memory region. | ||
| 37 | * - this address could be physical address without IOMMU and | ||
| 38 | * device address with IOMMU. | ||
| 39 | * @size: size of allocated memory region. | ||
| 40 | */ | ||
| 41 | struct exynos_drm_gem_buf { | ||
| 42 | void __iomem *kvaddr; | ||
| 43 | dma_addr_t dma_addr; | ||
| 44 | unsigned long size; | ||
| 45 | }; | ||
| 46 | |||
| 47 | /* | ||
| 33 | * exynos drm buffer structure. | 48 | * exynos drm buffer structure. |
| 34 | * | 49 | * |
| 35 | * @base: a gem object. | 50 | * @base: a gem object. |
| 36 | * - a new handle to this gem object would be created | 51 | * - a new handle to this gem object would be created |
| 37 | * by drm_gem_handle_create(). | 52 | * by drm_gem_handle_create(). |
| 38 | * @entry: pointer to exynos drm buffer entry object. | 53 | * @buffer: a pointer to exynos_drm_gem_buffer object. |
| 39 | * - containing the information to physically | 54 | * - contain the information to memory region allocated |
| 55 | * by user request or at framebuffer creation. | ||
| 40 | * continuous memory region allocated by user request | 56 | * continuous memory region allocated by user request |
| 41 | * or at framebuffer creation. | 57 | * or at framebuffer creation. |
| 42 | * | 58 | * |
| @@ -45,13 +61,13 @@ | |||
| 45 | */ | 61 | */ |
| 46 | struct exynos_drm_gem_obj { | 62 | struct exynos_drm_gem_obj { |
| 47 | struct drm_gem_object base; | 63 | struct drm_gem_object base; |
| 48 | struct exynos_drm_buf_entry *entry; | 64 | struct exynos_drm_gem_buf *buffer; |
| 49 | }; | 65 | }; |
| 50 | 66 | ||
| 51 | /* create a new buffer and get a new gem handle. */ | 67 | /* create a new buffer and get a new gem handle. */ |
| 52 | struct exynos_drm_gem_obj *exynos_drm_gem_create(struct drm_file *file_priv, | 68 | struct exynos_drm_gem_obj *exynos_drm_gem_create(struct drm_device *dev, |
| 53 | struct drm_device *dev, unsigned int size, | 69 | struct drm_file *file_priv, |
| 54 | unsigned int *handle); | 70 | unsigned int *handle, unsigned long size); |
| 55 | 71 | ||
| 56 | /* | 72 | /* |
| 57 | * request gem object creation and buffer allocation as the size | 73 | * request gem object creation and buffer allocation as the size |
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index d09a6e02dc95..004b048c5192 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c | |||
| @@ -62,6 +62,7 @@ static int i915_capabilities(struct seq_file *m, void *data) | |||
| 62 | const struct intel_device_info *info = INTEL_INFO(dev); | 62 | const struct intel_device_info *info = INTEL_INFO(dev); |
| 63 | 63 | ||
| 64 | seq_printf(m, "gen: %d\n", info->gen); | 64 | seq_printf(m, "gen: %d\n", info->gen); |
| 65 | seq_printf(m, "pch: %d\n", INTEL_PCH_TYPE(dev)); | ||
| 65 | #define B(x) seq_printf(m, #x ": %s\n", yesno(info->x)) | 66 | #define B(x) seq_printf(m, #x ": %s\n", yesno(info->x)) |
| 66 | B(is_mobile); | 67 | B(is_mobile); |
| 67 | B(is_i85x); | 68 | B(is_i85x); |
diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index a9533c54c93c..a9ae374861e7 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c | |||
| @@ -1454,6 +1454,14 @@ unsigned long i915_chipset_val(struct drm_i915_private *dev_priv) | |||
| 1454 | 1454 | ||
| 1455 | diff1 = now - dev_priv->last_time1; | 1455 | diff1 = now - dev_priv->last_time1; |
| 1456 | 1456 | ||
| 1457 | /* Prevent division-by-zero if we are asking too fast. | ||
| 1458 | * Also, we don't get interesting results if we are polling | ||
| 1459 | * faster than once in 10ms, so just return the saved value | ||
| 1460 | * in such cases. | ||
| 1461 | */ | ||
| 1462 | if (diff1 <= 10) | ||
| 1463 | return dev_priv->chipset_power; | ||
| 1464 | |||
| 1457 | count1 = I915_READ(DMIEC); | 1465 | count1 = I915_READ(DMIEC); |
| 1458 | count2 = I915_READ(DDREC); | 1466 | count2 = I915_READ(DDREC); |
| 1459 | count3 = I915_READ(CSIEC); | 1467 | count3 = I915_READ(CSIEC); |
| @@ -1484,6 +1492,8 @@ unsigned long i915_chipset_val(struct drm_i915_private *dev_priv) | |||
| 1484 | dev_priv->last_count1 = total_count; | 1492 | dev_priv->last_count1 = total_count; |
| 1485 | dev_priv->last_time1 = now; | 1493 | dev_priv->last_time1 = now; |
| 1486 | 1494 | ||
| 1495 | dev_priv->chipset_power = ret; | ||
| 1496 | |||
| 1487 | return ret; | 1497 | return ret; |
| 1488 | } | 1498 | } |
| 1489 | 1499 | ||
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 15bfa9145d2b..a1103fc6597d 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i915/i915_drv.c | |||
| @@ -58,15 +58,15 @@ module_param_named(powersave, i915_powersave, int, 0600); | |||
| 58 | MODULE_PARM_DESC(powersave, | 58 | MODULE_PARM_DESC(powersave, |
| 59 | "Enable powersavings, fbc, downclocking, etc. (default: true)"); | 59 | "Enable powersavings, fbc, downclocking, etc. (default: true)"); |
| 60 | 60 | ||
| 61 | unsigned int i915_semaphores __read_mostly = 0; | 61 | int i915_semaphores __read_mostly = -1; |
| 62 | module_param_named(semaphores, i915_semaphores, int, 0600); | 62 | module_param_named(semaphores, i915_semaphores, int, 0600); |
| 63 | MODULE_PARM_DESC(semaphores, | 63 | MODULE_PARM_DESC(semaphores, |
| 64 | "Use semaphores for inter-ring sync (default: false)"); | 64 | "Use semaphores for inter-ring sync (default: -1 (use per-chip defaults))"); |
| 65 | 65 | ||
| 66 | unsigned int i915_enable_rc6 __read_mostly = 0; | 66 | int i915_enable_rc6 __read_mostly = -1; |
| 67 | module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600); | 67 | module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600); |
| 68 | MODULE_PARM_DESC(i915_enable_rc6, | 68 | MODULE_PARM_DESC(i915_enable_rc6, |
| 69 | "Enable power-saving render C-state 6 (default: true)"); | 69 | "Enable power-saving render C-state 6 (default: -1 (use per-chip default)"); |
| 70 | 70 | ||
| 71 | int i915_enable_fbc __read_mostly = -1; | 71 | int i915_enable_fbc __read_mostly = -1; |
| 72 | module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600); | 72 | module_param_named(i915_enable_fbc, i915_enable_fbc, int, 0600); |
| @@ -328,7 +328,7 @@ void intel_detect_pch(struct drm_device *dev) | |||
| 328 | } | 328 | } |
| 329 | } | 329 | } |
| 330 | 330 | ||
| 331 | static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv) | 331 | void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv) |
| 332 | { | 332 | { |
| 333 | int count; | 333 | int count; |
| 334 | 334 | ||
| @@ -344,6 +344,22 @@ static void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv) | |||
| 344 | udelay(10); | 344 | udelay(10); |
| 345 | } | 345 | } |
| 346 | 346 | ||
| 347 | void __gen6_gt_force_wake_mt_get(struct drm_i915_private *dev_priv) | ||
| 348 | { | ||
| 349 | int count; | ||
| 350 | |||
| 351 | count = 0; | ||
| 352 | while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1)) | ||
| 353 | udelay(10); | ||
| 354 | |||
| 355 | I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<16) | 1); | ||
| 356 | POSTING_READ(FORCEWAKE_MT); | ||
| 357 | |||
| 358 | count = 0; | ||
| 359 | while (count++ < 50 && (I915_READ_NOTRACE(FORCEWAKE_MT_ACK) & 1) == 0) | ||
| 360 | udelay(10); | ||
| 361 | } | ||
| 362 | |||
| 347 | /* | 363 | /* |
| 348 | * Generally this is called implicitly by the register read function. However, | 364 | * Generally this is called implicitly by the register read function. However, |
| 349 | * if some sequence requires the GT to not power down then this function should | 365 | * if some sequence requires the GT to not power down then this function should |
| @@ -356,15 +372,21 @@ void gen6_gt_force_wake_get(struct drm_i915_private *dev_priv) | |||
| 356 | 372 | ||
| 357 | /* Forcewake is atomic in case we get in here without the lock */ | 373 | /* Forcewake is atomic in case we get in here without the lock */ |
| 358 | if (atomic_add_return(1, &dev_priv->forcewake_count) == 1) | 374 | if (atomic_add_return(1, &dev_priv->forcewake_count) == 1) |
| 359 | __gen6_gt_force_wake_get(dev_priv); | 375 | dev_priv->display.force_wake_get(dev_priv); |
| 360 | } | 376 | } |
| 361 | 377 | ||
| 362 | static void __gen6_gt_force_wake_put(struct drm_i915_private *dev_priv) | 378 | void __gen6_gt_force_wake_put(struct drm_i915_private *dev_priv) |
| 363 | { | 379 | { |
| 364 | I915_WRITE_NOTRACE(FORCEWAKE, 0); | 380 | I915_WRITE_NOTRACE(FORCEWAKE, 0); |
| 365 | POSTING_READ(FORCEWAKE); | 381 | POSTING_READ(FORCEWAKE); |
| 366 | } | 382 | } |
| 367 | 383 | ||
| 384 | void __gen6_gt_force_wake_mt_put(struct drm_i915_private *dev_priv) | ||
| 385 | { | ||
| 386 | I915_WRITE_NOTRACE(FORCEWAKE_MT, (1<<16) | 0); | ||
| 387 | POSTING_READ(FORCEWAKE_MT); | ||
| 388 | } | ||
| 389 | |||
| 368 | /* | 390 | /* |
| 369 | * see gen6_gt_force_wake_get() | 391 | * see gen6_gt_force_wake_get() |
| 370 | */ | 392 | */ |
| @@ -373,7 +395,7 @@ void gen6_gt_force_wake_put(struct drm_i915_private *dev_priv) | |||
| 373 | WARN_ON(!mutex_is_locked(&dev_priv->dev->struct_mutex)); | 395 | WARN_ON(!mutex_is_locked(&dev_priv->dev->struct_mutex)); |
| 374 | 396 | ||
| 375 | if (atomic_dec_and_test(&dev_priv->forcewake_count)) | 397 | if (atomic_dec_and_test(&dev_priv->forcewake_count)) |
| 376 | __gen6_gt_force_wake_put(dev_priv); | 398 | dev_priv->display.force_wake_put(dev_priv); |
| 377 | } | 399 | } |
| 378 | 400 | ||
| 379 | void __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv) | 401 | void __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv) |
| @@ -903,8 +925,9 @@ MODULE_LICENSE("GPL and additional rights"); | |||
| 903 | /* We give fast paths for the really cool registers */ | 925 | /* We give fast paths for the really cool registers */ |
| 904 | #define NEEDS_FORCE_WAKE(dev_priv, reg) \ | 926 | #define NEEDS_FORCE_WAKE(dev_priv, reg) \ |
| 905 | (((dev_priv)->info->gen >= 6) && \ | 927 | (((dev_priv)->info->gen >= 6) && \ |
| 906 | ((reg) < 0x40000) && \ | 928 | ((reg) < 0x40000) && \ |
| 907 | ((reg) != FORCEWAKE)) | 929 | ((reg) != FORCEWAKE) && \ |
| 930 | ((reg) != ECOBUS)) | ||
| 908 | 931 | ||
| 909 | #define __i915_read(x, y) \ | 932 | #define __i915_read(x, y) \ |
| 910 | u##x i915_read##x(struct drm_i915_private *dev_priv, u32 reg) { \ | 933 | u##x i915_read##x(struct drm_i915_private *dev_priv, u32 reg) { \ |
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 4a9c1b979804..554bef7a3b9c 100644 --- a/drivers/gpu/drm/i915/i915_drv.h +++ b/drivers/gpu/drm/i915/i915_drv.h | |||
| @@ -107,6 +107,7 @@ struct opregion_header; | |||
| 107 | struct opregion_acpi; | 107 | struct opregion_acpi; |
| 108 | struct opregion_swsci; | 108 | struct opregion_swsci; |
| 109 | struct opregion_asle; | 109 | struct opregion_asle; |
| 110 | struct drm_i915_private; | ||
| 110 | 111 | ||
| 111 | struct intel_opregion { | 112 | struct intel_opregion { |
| 112 | struct opregion_header *header; | 113 | struct opregion_header *header; |
| @@ -221,6 +222,8 @@ struct drm_i915_display_funcs { | |||
| 221 | struct drm_i915_gem_object *obj); | 222 | struct drm_i915_gem_object *obj); |
| 222 | int (*update_plane)(struct drm_crtc *crtc, struct drm_framebuffer *fb, | 223 | int (*update_plane)(struct drm_crtc *crtc, struct drm_framebuffer *fb, |
| 223 | int x, int y); | 224 | int x, int y); |
| 225 | void (*force_wake_get)(struct drm_i915_private *dev_priv); | ||
| 226 | void (*force_wake_put)(struct drm_i915_private *dev_priv); | ||
| 224 | /* clock updates for mode set */ | 227 | /* clock updates for mode set */ |
| 225 | /* cursor updates */ | 228 | /* cursor updates */ |
| 226 | /* render clock increase/decrease */ | 229 | /* render clock increase/decrease */ |
| @@ -710,6 +713,7 @@ typedef struct drm_i915_private { | |||
| 710 | 713 | ||
| 711 | u64 last_count1; | 714 | u64 last_count1; |
| 712 | unsigned long last_time1; | 715 | unsigned long last_time1; |
| 716 | unsigned long chipset_power; | ||
| 713 | u64 last_count2; | 717 | u64 last_count2; |
| 714 | struct timespec last_time2; | 718 | struct timespec last_time2; |
| 715 | unsigned long gfx_power; | 719 | unsigned long gfx_power; |
| @@ -998,11 +1002,11 @@ extern int i915_max_ioctl; | |||
| 998 | extern unsigned int i915_fbpercrtc __always_unused; | 1002 | extern unsigned int i915_fbpercrtc __always_unused; |
| 999 | extern int i915_panel_ignore_lid __read_mostly; | 1003 | extern int i915_panel_ignore_lid __read_mostly; |
| 1000 | extern unsigned int i915_powersave __read_mostly; | 1004 | extern unsigned int i915_powersave __read_mostly; |
| 1001 | extern unsigned int i915_semaphores __read_mostly; | 1005 | extern int i915_semaphores __read_mostly; |
| 1002 | extern unsigned int i915_lvds_downclock __read_mostly; | 1006 | extern unsigned int i915_lvds_downclock __read_mostly; |
| 1003 | extern int i915_panel_use_ssc __read_mostly; | 1007 | extern int i915_panel_use_ssc __read_mostly; |
| 1004 | extern int i915_vbt_sdvo_panel_type __read_mostly; | 1008 | extern int i915_vbt_sdvo_panel_type __read_mostly; |
| 1005 | extern unsigned int i915_enable_rc6 __read_mostly; | 1009 | extern int i915_enable_rc6 __read_mostly; |
| 1006 | extern int i915_enable_fbc __read_mostly; | 1010 | extern int i915_enable_fbc __read_mostly; |
| 1007 | extern bool i915_enable_hangcheck __read_mostly; | 1011 | extern bool i915_enable_hangcheck __read_mostly; |
| 1008 | 1012 | ||
| @@ -1308,6 +1312,11 @@ extern void gen6_set_rps(struct drm_device *dev, u8 val); | |||
| 1308 | extern void intel_detect_pch(struct drm_device *dev); | 1312 | extern void intel_detect_pch(struct drm_device *dev); |
| 1309 | extern int intel_trans_dp_port_sel(struct drm_crtc *crtc); | 1313 | extern int intel_trans_dp_port_sel(struct drm_crtc *crtc); |
| 1310 | 1314 | ||
| 1315 | extern void __gen6_gt_force_wake_get(struct drm_i915_private *dev_priv); | ||
| 1316 | extern void __gen6_gt_force_wake_mt_get(struct drm_i915_private *dev_priv); | ||
| 1317 | extern void __gen6_gt_force_wake_put(struct drm_i915_private *dev_priv); | ||
| 1318 | extern void __gen6_gt_force_wake_mt_put(struct drm_i915_private *dev_priv); | ||
| 1319 | |||
| 1311 | /* overlay */ | 1320 | /* overlay */ |
| 1312 | #ifdef CONFIG_DEBUG_FS | 1321 | #ifdef CONFIG_DEBUG_FS |
| 1313 | extern struct intel_overlay_error_state *intel_overlay_capture_error_state(struct drm_device *dev); | 1322 | extern struct intel_overlay_error_state *intel_overlay_capture_error_state(struct drm_device *dev); |
| @@ -1352,8 +1361,9 @@ void __gen6_gt_wait_for_fifo(struct drm_i915_private *dev_priv); | |||
| 1352 | /* We give fast paths for the really cool registers */ | 1361 | /* We give fast paths for the really cool registers */ |
| 1353 | #define NEEDS_FORCE_WAKE(dev_priv, reg) \ | 1362 | #define NEEDS_FORCE_WAKE(dev_priv, reg) \ |
| 1354 | (((dev_priv)->info->gen >= 6) && \ | 1363 | (((dev_priv)->info->gen >= 6) && \ |
| 1355 | ((reg) < 0x40000) && \ | 1364 | ((reg) < 0x40000) && \ |
| 1356 | ((reg) != FORCEWAKE)) | 1365 | ((reg) != FORCEWAKE) && \ |
| 1366 | ((reg) != ECOBUS)) | ||
| 1357 | 1367 | ||
| 1358 | #define __i915_read(x, y) \ | 1368 | #define __i915_read(x, y) \ |
| 1359 | u##x i915_read##x(struct drm_i915_private *dev_priv, u32 reg); | 1369 | u##x i915_read##x(struct drm_i915_private *dev_priv, u32 reg); |
diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c index 3693e83a97f3..c681dc149d2a 100644 --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c | |||
| @@ -32,6 +32,7 @@ | |||
| 32 | #include "i915_drv.h" | 32 | #include "i915_drv.h" |
| 33 | #include "i915_trace.h" | 33 | #include "i915_trace.h" |
| 34 | #include "intel_drv.h" | 34 | #include "intel_drv.h" |
| 35 | #include <linux/dma_remapping.h> | ||
| 35 | 36 | ||
| 36 | struct change_domains { | 37 | struct change_domains { |
| 37 | uint32_t invalidate_domains; | 38 | uint32_t invalidate_domains; |
| @@ -746,6 +747,22 @@ i915_gem_execbuffer_flush(struct drm_device *dev, | |||
| 746 | return 0; | 747 | return 0; |
| 747 | } | 748 | } |
| 748 | 749 | ||
| 750 | static bool | ||
| 751 | intel_enable_semaphores(struct drm_device *dev) | ||
| 752 | { | ||
| 753 | if (INTEL_INFO(dev)->gen < 6) | ||
| 754 | return 0; | ||
| 755 | |||
| 756 | if (i915_semaphores >= 0) | ||
| 757 | return i915_semaphores; | ||
| 758 | |||
| 759 | /* Enable semaphores on SNB when IO remapping is off */ | ||
| 760 | if (INTEL_INFO(dev)->gen == 6) | ||
| 761 | return !intel_iommu_enabled; | ||
| 762 | |||
| 763 | return 1; | ||
| 764 | } | ||
| 765 | |||
| 749 | static int | 766 | static int |
| 750 | i915_gem_execbuffer_sync_rings(struct drm_i915_gem_object *obj, | 767 | i915_gem_execbuffer_sync_rings(struct drm_i915_gem_object *obj, |
| 751 | struct intel_ring_buffer *to) | 768 | struct intel_ring_buffer *to) |
| @@ -758,7 +775,7 @@ i915_gem_execbuffer_sync_rings(struct drm_i915_gem_object *obj, | |||
| 758 | return 0; | 775 | return 0; |
| 759 | 776 | ||
| 760 | /* XXX gpu semaphores are implicated in various hard hangs on SNB */ | 777 | /* XXX gpu semaphores are implicated in various hard hangs on SNB */ |
| 761 | if (INTEL_INFO(obj->base.dev)->gen < 6 || !i915_semaphores) | 778 | if (!intel_enable_semaphores(obj->base.dev)) |
| 762 | return i915_gem_object_wait_rendering(obj); | 779 | return i915_gem_object_wait_rendering(obj); |
| 763 | 780 | ||
| 764 | idx = intel_ring_sync_index(from, to); | 781 | idx = intel_ring_sync_index(from, to); |
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index b080cc824001..a26d5b0a3690 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h | |||
| @@ -3303,10 +3303,10 @@ | |||
| 3303 | /* or SDVOB */ | 3303 | /* or SDVOB */ |
| 3304 | #define HDMIB 0xe1140 | 3304 | #define HDMIB 0xe1140 |
| 3305 | #define PORT_ENABLE (1 << 31) | 3305 | #define PORT_ENABLE (1 << 31) |
| 3306 | #define TRANSCODER_A (0) | 3306 | #define TRANSCODER(pipe) ((pipe) << 30) |
| 3307 | #define TRANSCODER_B (1 << 30) | 3307 | #define TRANSCODER_CPT(pipe) ((pipe) << 29) |
| 3308 | #define TRANSCODER(pipe) ((pipe) << 30) | 3308 | #define TRANSCODER_MASK (1 << 30) |
| 3309 | #define TRANSCODER_MASK (1 << 30) | 3309 | #define TRANSCODER_MASK_CPT (3 << 29) |
| 3310 | #define COLOR_FORMAT_8bpc (0) | 3310 | #define COLOR_FORMAT_8bpc (0) |
| 3311 | #define COLOR_FORMAT_12bpc (3 << 26) | 3311 | #define COLOR_FORMAT_12bpc (3 << 26) |
| 3312 | #define SDVOB_HOTPLUG_ENABLE (1 << 23) | 3312 | #define SDVOB_HOTPLUG_ENABLE (1 << 23) |
| @@ -3447,8 +3447,30 @@ | |||
| 3447 | #define EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B (0x38<<22) | 3447 | #define EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B (0x38<<22) |
| 3448 | #define EDP_LINK_TRAIN_VOL_EMP_MASK_SNB (0x3f<<22) | 3448 | #define EDP_LINK_TRAIN_VOL_EMP_MASK_SNB (0x3f<<22) |
| 3449 | 3449 | ||
| 3450 | /* IVB */ | ||
| 3451 | #define EDP_LINK_TRAIN_400MV_0DB_IVB (0x24 <<22) | ||
| 3452 | #define EDP_LINK_TRAIN_400MV_3_5DB_IVB (0x2a <<22) | ||
| 3453 | #define EDP_LINK_TRAIN_400MV_6DB_IVB (0x2f <<22) | ||
| 3454 | #define EDP_LINK_TRAIN_600MV_0DB_IVB (0x30 <<22) | ||
| 3455 | #define EDP_LINK_TRAIN_600MV_3_5DB_IVB (0x36 <<22) | ||
| 3456 | #define EDP_LINK_TRAIN_800MV_0DB_IVB (0x38 <<22) | ||
| 3457 | #define EDP_LINK_TRAIN_800MV_3_5DB_IVB (0x33 <<22) | ||
| 3458 | |||
| 3459 | /* legacy values */ | ||
| 3460 | #define EDP_LINK_TRAIN_500MV_0DB_IVB (0x00 <<22) | ||
| 3461 | #define EDP_LINK_TRAIN_1000MV_0DB_IVB (0x20 <<22) | ||
| 3462 | #define EDP_LINK_TRAIN_500MV_3_5DB_IVB (0x02 <<22) | ||
| 3463 | #define EDP_LINK_TRAIN_1000MV_3_5DB_IVB (0x22 <<22) | ||
| 3464 | #define EDP_LINK_TRAIN_1000MV_6DB_IVB (0x23 <<22) | ||
| 3465 | |||
| 3466 | #define EDP_LINK_TRAIN_VOL_EMP_MASK_IVB (0x3f<<22) | ||
| 3467 | |||
| 3450 | #define FORCEWAKE 0xA18C | 3468 | #define FORCEWAKE 0xA18C |
| 3451 | #define FORCEWAKE_ACK 0x130090 | 3469 | #define FORCEWAKE_ACK 0x130090 |
| 3470 | #define FORCEWAKE_MT 0xa188 /* multi-threaded */ | ||
| 3471 | #define FORCEWAKE_MT_ACK 0x130040 | ||
| 3472 | #define ECOBUS 0xa180 | ||
| 3473 | #define FORCEWAKE_MT_ENABLE (1<<5) | ||
| 3452 | 3474 | ||
| 3453 | #define GT_FIFO_FREE_ENTRIES 0x120008 | 3475 | #define GT_FIFO_FREE_ENTRIES 0x120008 |
| 3454 | #define GT_FIFO_NUM_RESERVED_ENTRIES 20 | 3476 | #define GT_FIFO_NUM_RESERVED_ENTRIES 20 |
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index e77a863a3833..d809b038ca88 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
| @@ -38,8 +38,8 @@ | |||
| 38 | #include "i915_drv.h" | 38 | #include "i915_drv.h" |
| 39 | #include "i915_trace.h" | 39 | #include "i915_trace.h" |
| 40 | #include "drm_dp_helper.h" | 40 | #include "drm_dp_helper.h" |
| 41 | |||
| 42 | #include "drm_crtc_helper.h" | 41 | #include "drm_crtc_helper.h" |
| 42 | #include <linux/dma_remapping.h> | ||
| 43 | 43 | ||
| 44 | #define HAS_eDP (intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP)) | 44 | #define HAS_eDP (intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP)) |
| 45 | 45 | ||
| @@ -4670,6 +4670,7 @@ static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv) | |||
| 4670 | /** | 4670 | /** |
| 4671 | * intel_choose_pipe_bpp_dither - figure out what color depth the pipe should send | 4671 | * intel_choose_pipe_bpp_dither - figure out what color depth the pipe should send |
| 4672 | * @crtc: CRTC structure | 4672 | * @crtc: CRTC structure |
| 4673 | * @mode: requested mode | ||
| 4673 | * | 4674 | * |
| 4674 | * A pipe may be connected to one or more outputs. Based on the depth of the | 4675 | * A pipe may be connected to one or more outputs. Based on the depth of the |
| 4675 | * attached framebuffer, choose a good color depth to use on the pipe. | 4676 | * attached framebuffer, choose a good color depth to use on the pipe. |
| @@ -4681,13 +4682,15 @@ static inline bool intel_panel_use_ssc(struct drm_i915_private *dev_priv) | |||
| 4681 | * HDMI supports only 8bpc or 12bpc, so clamp to 8bpc with dither for 10bpc | 4682 | * HDMI supports only 8bpc or 12bpc, so clamp to 8bpc with dither for 10bpc |
| 4682 | * Displays may support a restricted set as well, check EDID and clamp as | 4683 | * Displays may support a restricted set as well, check EDID and clamp as |
| 4683 | * appropriate. | 4684 | * appropriate. |
| 4685 | * DP may want to dither down to 6bpc to fit larger modes | ||
| 4684 | * | 4686 | * |
| 4685 | * RETURNS: | 4687 | * RETURNS: |
| 4686 | * Dithering requirement (i.e. false if display bpc and pipe bpc match, | 4688 | * Dithering requirement (i.e. false if display bpc and pipe bpc match, |
| 4687 | * true if they don't match). | 4689 | * true if they don't match). |
| 4688 | */ | 4690 | */ |
| 4689 | static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc, | 4691 | static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc, |
| 4690 | unsigned int *pipe_bpp) | 4692 | unsigned int *pipe_bpp, |
| 4693 | struct drm_display_mode *mode) | ||
| 4691 | { | 4694 | { |
| 4692 | struct drm_device *dev = crtc->dev; | 4695 | struct drm_device *dev = crtc->dev; |
| 4693 | struct drm_i915_private *dev_priv = dev->dev_private; | 4696 | struct drm_i915_private *dev_priv = dev->dev_private; |
| @@ -4758,6 +4761,11 @@ static bool intel_choose_pipe_bpp_dither(struct drm_crtc *crtc, | |||
| 4758 | } | 4761 | } |
| 4759 | } | 4762 | } |
| 4760 | 4763 | ||
| 4764 | if (mode->private_flags & INTEL_MODE_DP_FORCE_6BPC) { | ||
| 4765 | DRM_DEBUG_KMS("Dithering DP to 6bpc\n"); | ||
| 4766 | display_bpc = 6; | ||
| 4767 | } | ||
| 4768 | |||
| 4761 | /* | 4769 | /* |
| 4762 | * We could just drive the pipe at the highest bpc all the time and | 4770 | * We could just drive the pipe at the highest bpc all the time and |
| 4763 | * enable dithering as needed, but that costs bandwidth. So choose | 4771 | * enable dithering as needed, but that costs bandwidth. So choose |
| @@ -5019,6 +5027,16 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc, | |||
| 5019 | pipeconf &= ~PIPECONF_DOUBLE_WIDE; | 5027 | pipeconf &= ~PIPECONF_DOUBLE_WIDE; |
| 5020 | } | 5028 | } |
| 5021 | 5029 | ||
| 5030 | /* default to 8bpc */ | ||
| 5031 | pipeconf &= ~(PIPECONF_BPP_MASK | PIPECONF_DITHER_EN); | ||
| 5032 | if (is_dp) { | ||
| 5033 | if (mode->private_flags & INTEL_MODE_DP_FORCE_6BPC) { | ||
| 5034 | pipeconf |= PIPECONF_BPP_6 | | ||
| 5035 | PIPECONF_DITHER_EN | | ||
| 5036 | PIPECONF_DITHER_TYPE_SP; | ||
| 5037 | } | ||
| 5038 | } | ||
| 5039 | |||
| 5022 | dpll |= DPLL_VCO_ENABLE; | 5040 | dpll |= DPLL_VCO_ENABLE; |
| 5023 | 5041 | ||
| 5024 | DRM_DEBUG_KMS("Mode for pipe %c:\n", pipe == 0 ? 'A' : 'B'); | 5042 | DRM_DEBUG_KMS("Mode for pipe %c:\n", pipe == 0 ? 'A' : 'B'); |
| @@ -5480,7 +5498,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc, | |||
| 5480 | /* determine panel color depth */ | 5498 | /* determine panel color depth */ |
| 5481 | temp = I915_READ(PIPECONF(pipe)); | 5499 | temp = I915_READ(PIPECONF(pipe)); |
| 5482 | temp &= ~PIPE_BPC_MASK; | 5500 | temp &= ~PIPE_BPC_MASK; |
| 5483 | dither = intel_choose_pipe_bpp_dither(crtc, &pipe_bpp); | 5501 | dither = intel_choose_pipe_bpp_dither(crtc, &pipe_bpp, mode); |
| 5484 | switch (pipe_bpp) { | 5502 | switch (pipe_bpp) { |
| 5485 | case 18: | 5503 | case 18: |
| 5486 | temp |= PIPE_6BPC; | 5504 | temp |= PIPE_6BPC; |
| @@ -7189,11 +7207,16 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, | |||
| 7189 | work->old_fb_obj = intel_fb->obj; | 7207 | work->old_fb_obj = intel_fb->obj; |
| 7190 | INIT_WORK(&work->work, intel_unpin_work_fn); | 7208 | INIT_WORK(&work->work, intel_unpin_work_fn); |
| 7191 | 7209 | ||
| 7210 | ret = drm_vblank_get(dev, intel_crtc->pipe); | ||
| 7211 | if (ret) | ||
| 7212 | goto free_work; | ||
| 7213 | |||
| 7192 | /* We borrow the event spin lock for protecting unpin_work */ | 7214 | /* We borrow the event spin lock for protecting unpin_work */ |
| 7193 | spin_lock_irqsave(&dev->event_lock, flags); | 7215 | spin_lock_irqsave(&dev->event_lock, flags); |
| 7194 | if (intel_crtc->unpin_work) { | 7216 | if (intel_crtc->unpin_work) { |
| 7195 | spin_unlock_irqrestore(&dev->event_lock, flags); | 7217 | spin_unlock_irqrestore(&dev->event_lock, flags); |
| 7196 | kfree(work); | 7218 | kfree(work); |
| 7219 | drm_vblank_put(dev, intel_crtc->pipe); | ||
| 7197 | 7220 | ||
| 7198 | DRM_DEBUG_DRIVER("flip queue: crtc already busy\n"); | 7221 | DRM_DEBUG_DRIVER("flip queue: crtc already busy\n"); |
| 7199 | return -EBUSY; | 7222 | return -EBUSY; |
| @@ -7212,10 +7235,6 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, | |||
| 7212 | 7235 | ||
| 7213 | crtc->fb = fb; | 7236 | crtc->fb = fb; |
| 7214 | 7237 | ||
| 7215 | ret = drm_vblank_get(dev, intel_crtc->pipe); | ||
| 7216 | if (ret) | ||
| 7217 | goto cleanup_objs; | ||
| 7218 | |||
| 7219 | work->pending_flip_obj = obj; | 7238 | work->pending_flip_obj = obj; |
| 7220 | 7239 | ||
| 7221 | work->enable_stall_check = true; | 7240 | work->enable_stall_check = true; |
| @@ -7238,7 +7257,6 @@ static int intel_crtc_page_flip(struct drm_crtc *crtc, | |||
| 7238 | 7257 | ||
| 7239 | cleanup_pending: | 7258 | cleanup_pending: |
| 7240 | atomic_sub(1 << intel_crtc->plane, &work->old_fb_obj->pending_flip); | 7259 | atomic_sub(1 << intel_crtc->plane, &work->old_fb_obj->pending_flip); |
| 7241 | cleanup_objs: | ||
| 7242 | drm_gem_object_unreference(&work->old_fb_obj->base); | 7260 | drm_gem_object_unreference(&work->old_fb_obj->base); |
| 7243 | drm_gem_object_unreference(&obj->base); | 7261 | drm_gem_object_unreference(&obj->base); |
| 7244 | mutex_unlock(&dev->struct_mutex); | 7262 | mutex_unlock(&dev->struct_mutex); |
| @@ -7247,6 +7265,8 @@ cleanup_objs: | |||
| 7247 | intel_crtc->unpin_work = NULL; | 7265 | intel_crtc->unpin_work = NULL; |
| 7248 | spin_unlock_irqrestore(&dev->event_lock, flags); | 7266 | spin_unlock_irqrestore(&dev->event_lock, flags); |
| 7249 | 7267 | ||
| 7268 | drm_vblank_put(dev, intel_crtc->pipe); | ||
| 7269 | free_work: | ||
| 7250 | kfree(work); | 7270 | kfree(work); |
| 7251 | 7271 | ||
| 7252 | return ret; | 7272 | return ret; |
| @@ -7887,6 +7907,33 @@ void intel_init_emon(struct drm_device *dev) | |||
| 7887 | dev_priv->corr = (lcfuse & LCFUSE_HIV_MASK); | 7907 | dev_priv->corr = (lcfuse & LCFUSE_HIV_MASK); |
| 7888 | } | 7908 | } |
| 7889 | 7909 | ||
| 7910 | static bool intel_enable_rc6(struct drm_device *dev) | ||
| 7911 | { | ||
| 7912 | /* | ||
| 7913 | * Respect the kernel parameter if it is set | ||
| 7914 | */ | ||
| 7915 | if (i915_enable_rc6 >= 0) | ||
| 7916 | return i915_enable_rc6; | ||
| 7917 | |||
| 7918 | /* | ||
| 7919 | * Disable RC6 on Ironlake | ||
| 7920 | */ | ||
| 7921 | if (INTEL_INFO(dev)->gen == 5) | ||
| 7922 | return 0; | ||
| 7923 | |||
| 7924 | /* | ||
| 7925 | * Enable rc6 on Sandybridge if DMA remapping is disabled | ||
| 7926 | */ | ||
| 7927 | if (INTEL_INFO(dev)->gen == 6) { | ||
| 7928 | DRM_DEBUG_DRIVER("Sandybridge: intel_iommu_enabled %s -- RC6 %sabled\n", | ||
| 7929 | intel_iommu_enabled ? "true" : "false", | ||
| 7930 | !intel_iommu_enabled ? "en" : "dis"); | ||
| 7931 | return !intel_iommu_enabled; | ||
| 7932 | } | ||
| 7933 | DRM_DEBUG_DRIVER("RC6 enabled\n"); | ||
| 7934 | return 1; | ||
| 7935 | } | ||
| 7936 | |||
| 7890 | void gen6_enable_rps(struct drm_i915_private *dev_priv) | 7937 | void gen6_enable_rps(struct drm_i915_private *dev_priv) |
| 7891 | { | 7938 | { |
| 7892 | u32 rp_state_cap = I915_READ(GEN6_RP_STATE_CAP); | 7939 | u32 rp_state_cap = I915_READ(GEN6_RP_STATE_CAP); |
| @@ -7923,7 +7970,7 @@ void gen6_enable_rps(struct drm_i915_private *dev_priv) | |||
| 7923 | I915_WRITE(GEN6_RC6p_THRESHOLD, 100000); | 7970 | I915_WRITE(GEN6_RC6p_THRESHOLD, 100000); |
| 7924 | I915_WRITE(GEN6_RC6pp_THRESHOLD, 64000); /* unused */ | 7971 | I915_WRITE(GEN6_RC6pp_THRESHOLD, 64000); /* unused */ |
| 7925 | 7972 | ||
| 7926 | if (i915_enable_rc6) | 7973 | if (intel_enable_rc6(dev_priv->dev)) |
| 7927 | rc6_mask = GEN6_RC_CTL_RC6p_ENABLE | | 7974 | rc6_mask = GEN6_RC_CTL_RC6p_ENABLE | |
| 7928 | GEN6_RC_CTL_RC6_ENABLE; | 7975 | GEN6_RC_CTL_RC6_ENABLE; |
| 7929 | 7976 | ||
| @@ -8372,7 +8419,7 @@ void ironlake_enable_rc6(struct drm_device *dev) | |||
| 8372 | /* rc6 disabled by default due to repeated reports of hanging during | 8419 | /* rc6 disabled by default due to repeated reports of hanging during |
| 8373 | * boot and resume. | 8420 | * boot and resume. |
| 8374 | */ | 8421 | */ |
| 8375 | if (!i915_enable_rc6) | 8422 | if (!intel_enable_rc6(dev)) |
| 8376 | return; | 8423 | return; |
| 8377 | 8424 | ||
| 8378 | mutex_lock(&dev->struct_mutex); | 8425 | mutex_lock(&dev->struct_mutex); |
| @@ -8491,6 +8538,28 @@ static void intel_init_display(struct drm_device *dev) | |||
| 8491 | 8538 | ||
| 8492 | /* For FIFO watermark updates */ | 8539 | /* For FIFO watermark updates */ |
| 8493 | if (HAS_PCH_SPLIT(dev)) { | 8540 | if (HAS_PCH_SPLIT(dev)) { |
| 8541 | dev_priv->display.force_wake_get = __gen6_gt_force_wake_get; | ||
| 8542 | dev_priv->display.force_wake_put = __gen6_gt_force_wake_put; | ||
| 8543 | |||
| 8544 | /* IVB configs may use multi-threaded forcewake */ | ||
| 8545 | if (IS_IVYBRIDGE(dev)) { | ||
| 8546 | u32 ecobus; | ||
| 8547 | |||
| 8548 | mutex_lock(&dev->struct_mutex); | ||
| 8549 | __gen6_gt_force_wake_mt_get(dev_priv); | ||
| 8550 | ecobus = I915_READ(ECOBUS); | ||
| 8551 | __gen6_gt_force_wake_mt_put(dev_priv); | ||
| 8552 | mutex_unlock(&dev->struct_mutex); | ||
| 8553 | |||
| 8554 | if (ecobus & FORCEWAKE_MT_ENABLE) { | ||
| 8555 | DRM_DEBUG_KMS("Using MT version of forcewake\n"); | ||
| 8556 | dev_priv->display.force_wake_get = | ||
| 8557 | __gen6_gt_force_wake_mt_get; | ||
| 8558 | dev_priv->display.force_wake_put = | ||
| 8559 | __gen6_gt_force_wake_mt_put; | ||
| 8560 | } | ||
| 8561 | } | ||
| 8562 | |||
| 8494 | if (HAS_PCH_IBX(dev)) | 8563 | if (HAS_PCH_IBX(dev)) |
| 8495 | dev_priv->display.init_pch_clock_gating = ibx_init_clock_gating; | 8564 | dev_priv->display.init_pch_clock_gating = ibx_init_clock_gating; |
| 8496 | else if (HAS_PCH_CPT(dev)) | 8565 | else if (HAS_PCH_CPT(dev)) |
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 4d0358fad937..92b041b66e49 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c | |||
| @@ -208,13 +208,15 @@ intel_dp_link_clock(uint8_t link_bw) | |||
| 208 | */ | 208 | */ |
| 209 | 209 | ||
| 210 | static int | 210 | static int |
| 211 | intel_dp_link_required(struct intel_dp *intel_dp, int pixel_clock) | 211 | intel_dp_link_required(struct intel_dp *intel_dp, int pixel_clock, int check_bpp) |
| 212 | { | 212 | { |
| 213 | struct drm_crtc *crtc = intel_dp->base.base.crtc; | 213 | struct drm_crtc *crtc = intel_dp->base.base.crtc; |
| 214 | struct intel_crtc *intel_crtc = to_intel_crtc(crtc); | 214 | struct intel_crtc *intel_crtc = to_intel_crtc(crtc); |
| 215 | int bpp = 24; | 215 | int bpp = 24; |
| 216 | 216 | ||
| 217 | if (intel_crtc) | 217 | if (check_bpp) |
| 218 | bpp = check_bpp; | ||
| 219 | else if (intel_crtc) | ||
| 218 | bpp = intel_crtc->bpp; | 220 | bpp = intel_crtc->bpp; |
| 219 | 221 | ||
| 220 | return (pixel_clock * bpp + 9) / 10; | 222 | return (pixel_clock * bpp + 9) / 10; |
| @@ -233,6 +235,7 @@ intel_dp_mode_valid(struct drm_connector *connector, | |||
| 233 | struct intel_dp *intel_dp = intel_attached_dp(connector); | 235 | struct intel_dp *intel_dp = intel_attached_dp(connector); |
| 234 | int max_link_clock = intel_dp_link_clock(intel_dp_max_link_bw(intel_dp)); | 236 | int max_link_clock = intel_dp_link_clock(intel_dp_max_link_bw(intel_dp)); |
| 235 | int max_lanes = intel_dp_max_lane_count(intel_dp); | 237 | int max_lanes = intel_dp_max_lane_count(intel_dp); |
| 238 | int max_rate, mode_rate; | ||
| 236 | 239 | ||
| 237 | if (is_edp(intel_dp) && intel_dp->panel_fixed_mode) { | 240 | if (is_edp(intel_dp) && intel_dp->panel_fixed_mode) { |
| 238 | if (mode->hdisplay > intel_dp->panel_fixed_mode->hdisplay) | 241 | if (mode->hdisplay > intel_dp->panel_fixed_mode->hdisplay) |
| @@ -242,9 +245,17 @@ intel_dp_mode_valid(struct drm_connector *connector, | |||
| 242 | return MODE_PANEL; | 245 | return MODE_PANEL; |
| 243 | } | 246 | } |
| 244 | 247 | ||
| 245 | if (intel_dp_link_required(intel_dp, mode->clock) | 248 | mode_rate = intel_dp_link_required(intel_dp, mode->clock, 0); |
| 246 | > intel_dp_max_data_rate(max_link_clock, max_lanes)) | 249 | max_rate = intel_dp_max_data_rate(max_link_clock, max_lanes); |
| 247 | return MODE_CLOCK_HIGH; | 250 | |
| 251 | if (mode_rate > max_rate) { | ||
| 252 | mode_rate = intel_dp_link_required(intel_dp, | ||
| 253 | mode->clock, 18); | ||
| 254 | if (mode_rate > max_rate) | ||
| 255 | return MODE_CLOCK_HIGH; | ||
| 256 | else | ||
| 257 | mode->private_flags |= INTEL_MODE_DP_FORCE_6BPC; | ||
| 258 | } | ||
| 248 | 259 | ||
| 249 | if (mode->clock < 10000) | 260 | if (mode->clock < 10000) |
| 250 | return MODE_CLOCK_LOW; | 261 | return MODE_CLOCK_LOW; |
| @@ -362,8 +373,8 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, | |||
| 362 | * clock divider. | 373 | * clock divider. |
| 363 | */ | 374 | */ |
| 364 | if (is_cpu_edp(intel_dp)) { | 375 | if (is_cpu_edp(intel_dp)) { |
| 365 | if (IS_GEN6(dev)) | 376 | if (IS_GEN6(dev) || IS_GEN7(dev)) |
| 366 | aux_clock_divider = 200; /* SNB eDP input clock at 400Mhz */ | 377 | aux_clock_divider = 200; /* SNB & IVB eDP input clock at 400Mhz */ |
| 367 | else | 378 | else |
| 368 | aux_clock_divider = 225; /* eDP input clock at 450Mhz */ | 379 | aux_clock_divider = 225; /* eDP input clock at 450Mhz */ |
| 369 | } else if (HAS_PCH_SPLIT(dev)) | 380 | } else if (HAS_PCH_SPLIT(dev)) |
| @@ -672,6 +683,7 @@ intel_dp_mode_fixup(struct drm_encoder *encoder, struct drm_display_mode *mode, | |||
| 672 | int lane_count, clock; | 683 | int lane_count, clock; |
| 673 | int max_lane_count = intel_dp_max_lane_count(intel_dp); | 684 | int max_lane_count = intel_dp_max_lane_count(intel_dp); |
| 674 | int max_clock = intel_dp_max_link_bw(intel_dp) == DP_LINK_BW_2_7 ? 1 : 0; | 685 | int max_clock = intel_dp_max_link_bw(intel_dp) == DP_LINK_BW_2_7 ? 1 : 0; |
| 686 | int bpp = mode->private_flags & INTEL_MODE_DP_FORCE_6BPC ? 18 : 0; | ||
| 675 | static int bws[2] = { DP_LINK_BW_1_62, DP_LINK_BW_2_7 }; | 687 | static int bws[2] = { DP_LINK_BW_1_62, DP_LINK_BW_2_7 }; |
| 676 | 688 | ||
| 677 | if (is_edp(intel_dp) && intel_dp->panel_fixed_mode) { | 689 | if (is_edp(intel_dp) && intel_dp->panel_fixed_mode) { |
| @@ -689,7 +701,7 @@ intel_dp_mode_fixup(struct drm_encoder *encoder, struct drm_display_mode *mode, | |||
| 689 | for (clock = 0; clock <= max_clock; clock++) { | 701 | for (clock = 0; clock <= max_clock; clock++) { |
| 690 | int link_avail = intel_dp_max_data_rate(intel_dp_link_clock(bws[clock]), lane_count); | 702 | int link_avail = intel_dp_max_data_rate(intel_dp_link_clock(bws[clock]), lane_count); |
| 691 | 703 | ||
| 692 | if (intel_dp_link_required(intel_dp, mode->clock) | 704 | if (intel_dp_link_required(intel_dp, mode->clock, bpp) |
| 693 | <= link_avail) { | 705 | <= link_avail) { |
| 694 | intel_dp->link_bw = bws[clock]; | 706 | intel_dp->link_bw = bws[clock]; |
| 695 | intel_dp->lane_count = lane_count; | 707 | intel_dp->lane_count = lane_count; |
| @@ -817,10 +829,11 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode, | |||
| 817 | } | 829 | } |
| 818 | 830 | ||
| 819 | /* | 831 | /* |
| 820 | * There are three kinds of DP registers: | 832 | * There are four kinds of DP registers: |
| 821 | * | 833 | * |
| 822 | * IBX PCH | 834 | * IBX PCH |
| 823 | * CPU | 835 | * SNB CPU |
| 836 | * IVB CPU | ||
| 824 | * CPT PCH | 837 | * CPT PCH |
| 825 | * | 838 | * |
| 826 | * IBX PCH and CPU are the same for almost everything, | 839 | * IBX PCH and CPU are the same for almost everything, |
| @@ -873,7 +886,25 @@ intel_dp_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode, | |||
| 873 | 886 | ||
| 874 | /* Split out the IBX/CPU vs CPT settings */ | 887 | /* Split out the IBX/CPU vs CPT settings */ |
| 875 | 888 | ||
| 876 | if (!HAS_PCH_CPT(dev) || is_cpu_edp(intel_dp)) { | 889 | if (is_cpu_edp(intel_dp) && IS_GEN7(dev)) { |
| 890 | if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) | ||
| 891 | intel_dp->DP |= DP_SYNC_HS_HIGH; | ||
| 892 | if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC) | ||
| 893 | intel_dp->DP |= DP_SYNC_VS_HIGH; | ||
| 894 | intel_dp->DP |= DP_LINK_TRAIN_OFF_CPT; | ||
| 895 | |||
| 896 | if (intel_dp->link_configuration[1] & DP_LANE_COUNT_ENHANCED_FRAME_EN) | ||
| 897 | intel_dp->DP |= DP_ENHANCED_FRAMING; | ||
| 898 | |||
| 899 | intel_dp->DP |= intel_crtc->pipe << 29; | ||
| 900 | |||
| 901 | /* don't miss out required setting for eDP */ | ||
| 902 | intel_dp->DP |= DP_PLL_ENABLE; | ||
| 903 | if (adjusted_mode->clock < 200000) | ||
| 904 | intel_dp->DP |= DP_PLL_FREQ_160MHZ; | ||
| 905 | else | ||
| 906 | intel_dp->DP |= DP_PLL_FREQ_270MHZ; | ||
| 907 | } else if (!HAS_PCH_CPT(dev) || is_cpu_edp(intel_dp)) { | ||
| 877 | intel_dp->DP |= intel_dp->color_range; | 908 | intel_dp->DP |= intel_dp->color_range; |
| 878 | 909 | ||
| 879 | if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) | 910 | if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC) |
| @@ -1375,34 +1406,59 @@ static char *link_train_names[] = { | |||
| 1375 | * These are source-specific values; current Intel hardware supports | 1406 | * These are source-specific values; current Intel hardware supports |
| 1376 | * a maximum voltage of 800mV and a maximum pre-emphasis of 6dB | 1407 | * a maximum voltage of 800mV and a maximum pre-emphasis of 6dB |
| 1377 | */ | 1408 | */ |
| 1378 | #define I830_DP_VOLTAGE_MAX DP_TRAIN_VOLTAGE_SWING_800 | ||
| 1379 | #define I830_DP_VOLTAGE_MAX_CPT DP_TRAIN_VOLTAGE_SWING_1200 | ||
| 1380 | 1409 | ||
| 1381 | static uint8_t | 1410 | static uint8_t |
| 1382 | intel_dp_pre_emphasis_max(uint8_t voltage_swing) | 1411 | intel_dp_voltage_max(struct intel_dp *intel_dp) |
| 1383 | { | 1412 | { |
| 1384 | switch (voltage_swing & DP_TRAIN_VOLTAGE_SWING_MASK) { | 1413 | struct drm_device *dev = intel_dp->base.base.dev; |
| 1385 | case DP_TRAIN_VOLTAGE_SWING_400: | 1414 | |
| 1386 | return DP_TRAIN_PRE_EMPHASIS_6; | 1415 | if (IS_GEN7(dev) && is_cpu_edp(intel_dp)) |
| 1387 | case DP_TRAIN_VOLTAGE_SWING_600: | 1416 | return DP_TRAIN_VOLTAGE_SWING_800; |
| 1388 | return DP_TRAIN_PRE_EMPHASIS_6; | 1417 | else if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) |
| 1389 | case DP_TRAIN_VOLTAGE_SWING_800: | 1418 | return DP_TRAIN_VOLTAGE_SWING_1200; |
| 1390 | return DP_TRAIN_PRE_EMPHASIS_3_5; | 1419 | else |
| 1391 | case DP_TRAIN_VOLTAGE_SWING_1200: | 1420 | return DP_TRAIN_VOLTAGE_SWING_800; |
| 1392 | default: | 1421 | } |
| 1393 | return DP_TRAIN_PRE_EMPHASIS_0; | 1422 | |
| 1423 | static uint8_t | ||
| 1424 | intel_dp_pre_emphasis_max(struct intel_dp *intel_dp, uint8_t voltage_swing) | ||
| 1425 | { | ||
| 1426 | struct drm_device *dev = intel_dp->base.base.dev; | ||
| 1427 | |||
| 1428 | if (IS_GEN7(dev) && is_cpu_edp(intel_dp)) { | ||
| 1429 | switch (voltage_swing & DP_TRAIN_VOLTAGE_SWING_MASK) { | ||
| 1430 | case DP_TRAIN_VOLTAGE_SWING_400: | ||
| 1431 | return DP_TRAIN_PRE_EMPHASIS_6; | ||
| 1432 | case DP_TRAIN_VOLTAGE_SWING_600: | ||
| 1433 | case DP_TRAIN_VOLTAGE_SWING_800: | ||
| 1434 | return DP_TRAIN_PRE_EMPHASIS_3_5; | ||
| 1435 | default: | ||
| 1436 | return DP_TRAIN_PRE_EMPHASIS_0; | ||
| 1437 | } | ||
| 1438 | } else { | ||
| 1439 | switch (voltage_swing & DP_TRAIN_VOLTAGE_SWING_MASK) { | ||
| 1440 | case DP_TRAIN_VOLTAGE_SWING_400: | ||
| 1441 | return DP_TRAIN_PRE_EMPHASIS_6; | ||
| 1442 | case DP_TRAIN_VOLTAGE_SWING_600: | ||
| 1443 | return DP_TRAIN_PRE_EMPHASIS_6; | ||
| 1444 | case DP_TRAIN_VOLTAGE_SWING_800: | ||
| 1445 | return DP_TRAIN_PRE_EMPHASIS_3_5; | ||
| 1446 | case DP_TRAIN_VOLTAGE_SWING_1200: | ||
| 1447 | default: | ||
| 1448 | return DP_TRAIN_PRE_EMPHASIS_0; | ||
| 1449 | } | ||
| 1394 | } | 1450 | } |
| 1395 | } | 1451 | } |
| 1396 | 1452 | ||
| 1397 | static void | 1453 | static void |
| 1398 | intel_get_adjust_train(struct intel_dp *intel_dp, uint8_t link_status[DP_LINK_STATUS_SIZE]) | 1454 | intel_get_adjust_train(struct intel_dp *intel_dp, uint8_t link_status[DP_LINK_STATUS_SIZE]) |
| 1399 | { | 1455 | { |
| 1400 | struct drm_device *dev = intel_dp->base.base.dev; | ||
| 1401 | uint8_t v = 0; | 1456 | uint8_t v = 0; |
| 1402 | uint8_t p = 0; | 1457 | uint8_t p = 0; |
| 1403 | int lane; | 1458 | int lane; |
| 1404 | uint8_t *adjust_request = link_status + (DP_ADJUST_REQUEST_LANE0_1 - DP_LANE0_1_STATUS); | 1459 | uint8_t *adjust_request = link_status + (DP_ADJUST_REQUEST_LANE0_1 - DP_LANE0_1_STATUS); |
| 1405 | int voltage_max; | 1460 | uint8_t voltage_max; |
| 1461 | uint8_t preemph_max; | ||
| 1406 | 1462 | ||
| 1407 | for (lane = 0; lane < intel_dp->lane_count; lane++) { | 1463 | for (lane = 0; lane < intel_dp->lane_count; lane++) { |
| 1408 | uint8_t this_v = intel_get_adjust_request_voltage(adjust_request, lane); | 1464 | uint8_t this_v = intel_get_adjust_request_voltage(adjust_request, lane); |
| @@ -1414,15 +1470,13 @@ intel_get_adjust_train(struct intel_dp *intel_dp, uint8_t link_status[DP_LINK_ST | |||
| 1414 | p = this_p; | 1470 | p = this_p; |
| 1415 | } | 1471 | } |
| 1416 | 1472 | ||
| 1417 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) | 1473 | voltage_max = intel_dp_voltage_max(intel_dp); |
| 1418 | voltage_max = I830_DP_VOLTAGE_MAX_CPT; | ||
| 1419 | else | ||
| 1420 | voltage_max = I830_DP_VOLTAGE_MAX; | ||
| 1421 | if (v >= voltage_max) | 1474 | if (v >= voltage_max) |
| 1422 | v = voltage_max | DP_TRAIN_MAX_SWING_REACHED; | 1475 | v = voltage_max | DP_TRAIN_MAX_SWING_REACHED; |
| 1423 | 1476 | ||
| 1424 | if (p >= intel_dp_pre_emphasis_max(v)) | 1477 | preemph_max = intel_dp_pre_emphasis_max(intel_dp, v); |
| 1425 | p = intel_dp_pre_emphasis_max(v) | DP_TRAIN_MAX_PRE_EMPHASIS_REACHED; | 1478 | if (p >= preemph_max) |
| 1479 | p = preemph_max | DP_TRAIN_MAX_PRE_EMPHASIS_REACHED; | ||
| 1426 | 1480 | ||
| 1427 | for (lane = 0; lane < 4; lane++) | 1481 | for (lane = 0; lane < 4; lane++) |
| 1428 | intel_dp->train_set[lane] = v | p; | 1482 | intel_dp->train_set[lane] = v | p; |
| @@ -1494,6 +1548,37 @@ intel_gen6_edp_signal_levels(uint8_t train_set) | |||
| 1494 | } | 1548 | } |
| 1495 | } | 1549 | } |
| 1496 | 1550 | ||
| 1551 | /* Gen7's DP voltage swing and pre-emphasis control */ | ||
| 1552 | static uint32_t | ||
| 1553 | intel_gen7_edp_signal_levels(uint8_t train_set) | ||
| 1554 | { | ||
| 1555 | int signal_levels = train_set & (DP_TRAIN_VOLTAGE_SWING_MASK | | ||
| 1556 | DP_TRAIN_PRE_EMPHASIS_MASK); | ||
| 1557 | switch (signal_levels) { | ||
| 1558 | case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PRE_EMPHASIS_0: | ||
| 1559 | return EDP_LINK_TRAIN_400MV_0DB_IVB; | ||
| 1560 | case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PRE_EMPHASIS_3_5: | ||
| 1561 | return EDP_LINK_TRAIN_400MV_3_5DB_IVB; | ||
| 1562 | case DP_TRAIN_VOLTAGE_SWING_400 | DP_TRAIN_PRE_EMPHASIS_6: | ||
| 1563 | return EDP_LINK_TRAIN_400MV_6DB_IVB; | ||
| 1564 | |||
| 1565 | case DP_TRAIN_VOLTAGE_SWING_600 | DP_TRAIN_PRE_EMPHASIS_0: | ||
| 1566 | return EDP_LINK_TRAIN_600MV_0DB_IVB; | ||
| 1567 | case DP_TRAIN_VOLTAGE_SWING_600 | DP_TRAIN_PRE_EMPHASIS_3_5: | ||
| 1568 | return EDP_LINK_TRAIN_600MV_3_5DB_IVB; | ||
| 1569 | |||
| 1570 | case DP_TRAIN_VOLTAGE_SWING_800 | DP_TRAIN_PRE_EMPHASIS_0: | ||
| 1571 | return EDP_LINK_TRAIN_800MV_0DB_IVB; | ||
| 1572 | case DP_TRAIN_VOLTAGE_SWING_800 | DP_TRAIN_PRE_EMPHASIS_3_5: | ||
| 1573 | return EDP_LINK_TRAIN_800MV_3_5DB_IVB; | ||
| 1574 | |||
| 1575 | default: | ||
| 1576 | DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis level:" | ||
| 1577 | "0x%x\n", signal_levels); | ||
| 1578 | return EDP_LINK_TRAIN_500MV_0DB_IVB; | ||
| 1579 | } | ||
| 1580 | } | ||
| 1581 | |||
| 1497 | static uint8_t | 1582 | static uint8_t |
| 1498 | intel_get_lane_status(uint8_t link_status[DP_LINK_STATUS_SIZE], | 1583 | intel_get_lane_status(uint8_t link_status[DP_LINK_STATUS_SIZE], |
| 1499 | int lane) | 1584 | int lane) |
| @@ -1599,7 +1684,8 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) | |||
| 1599 | DP_LINK_CONFIGURATION_SIZE); | 1684 | DP_LINK_CONFIGURATION_SIZE); |
| 1600 | 1685 | ||
| 1601 | DP |= DP_PORT_EN; | 1686 | DP |= DP_PORT_EN; |
| 1602 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) | 1687 | |
| 1688 | if (HAS_PCH_CPT(dev) && (IS_GEN7(dev) || !is_cpu_edp(intel_dp))) | ||
| 1603 | DP &= ~DP_LINK_TRAIN_MASK_CPT; | 1689 | DP &= ~DP_LINK_TRAIN_MASK_CPT; |
| 1604 | else | 1690 | else |
| 1605 | DP &= ~DP_LINK_TRAIN_MASK; | 1691 | DP &= ~DP_LINK_TRAIN_MASK; |
| @@ -1613,7 +1699,11 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) | |||
| 1613 | uint8_t link_status[DP_LINK_STATUS_SIZE]; | 1699 | uint8_t link_status[DP_LINK_STATUS_SIZE]; |
| 1614 | uint32_t signal_levels; | 1700 | uint32_t signal_levels; |
| 1615 | 1701 | ||
| 1616 | if (IS_GEN6(dev) && is_cpu_edp(intel_dp)) { | 1702 | |
| 1703 | if (IS_GEN7(dev) && is_cpu_edp(intel_dp)) { | ||
| 1704 | signal_levels = intel_gen7_edp_signal_levels(intel_dp->train_set[0]); | ||
| 1705 | DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_IVB) | signal_levels; | ||
| 1706 | } else if (IS_GEN6(dev) && is_cpu_edp(intel_dp)) { | ||
| 1617 | signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]); | 1707 | signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]); |
| 1618 | DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels; | 1708 | DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels; |
| 1619 | } else { | 1709 | } else { |
| @@ -1622,7 +1712,7 @@ intel_dp_start_link_train(struct intel_dp *intel_dp) | |||
| 1622 | DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels; | 1712 | DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels; |
| 1623 | } | 1713 | } |
| 1624 | 1714 | ||
| 1625 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) | 1715 | if (HAS_PCH_CPT(dev) && (IS_GEN7(dev) || !is_cpu_edp(intel_dp))) |
| 1626 | reg = DP | DP_LINK_TRAIN_PAT_1_CPT; | 1716 | reg = DP | DP_LINK_TRAIN_PAT_1_CPT; |
| 1627 | else | 1717 | else |
| 1628 | reg = DP | DP_LINK_TRAIN_PAT_1; | 1718 | reg = DP | DP_LINK_TRAIN_PAT_1; |
| @@ -1703,7 +1793,10 @@ intel_dp_complete_link_train(struct intel_dp *intel_dp) | |||
| 1703 | break; | 1793 | break; |
| 1704 | } | 1794 | } |
| 1705 | 1795 | ||
| 1706 | if (IS_GEN6(dev) && is_cpu_edp(intel_dp)) { | 1796 | if (IS_GEN7(dev) && is_cpu_edp(intel_dp)) { |
| 1797 | signal_levels = intel_gen7_edp_signal_levels(intel_dp->train_set[0]); | ||
| 1798 | DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_IVB) | signal_levels; | ||
| 1799 | } else if (IS_GEN6(dev) && is_cpu_edp(intel_dp)) { | ||
| 1707 | signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]); | 1800 | signal_levels = intel_gen6_edp_signal_levels(intel_dp->train_set[0]); |
| 1708 | DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels; | 1801 | DP = (DP & ~EDP_LINK_TRAIN_VOL_EMP_MASK_SNB) | signal_levels; |
| 1709 | } else { | 1802 | } else { |
| @@ -1711,7 +1804,7 @@ intel_dp_complete_link_train(struct intel_dp *intel_dp) | |||
| 1711 | DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels; | 1804 | DP = (DP & ~(DP_VOLTAGE_MASK|DP_PRE_EMPHASIS_MASK)) | signal_levels; |
| 1712 | } | 1805 | } |
| 1713 | 1806 | ||
| 1714 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) | 1807 | if (HAS_PCH_CPT(dev) && (IS_GEN7(dev) || !is_cpu_edp(intel_dp))) |
| 1715 | reg = DP | DP_LINK_TRAIN_PAT_2_CPT; | 1808 | reg = DP | DP_LINK_TRAIN_PAT_2_CPT; |
| 1716 | else | 1809 | else |
| 1717 | reg = DP | DP_LINK_TRAIN_PAT_2; | 1810 | reg = DP | DP_LINK_TRAIN_PAT_2; |
| @@ -1752,7 +1845,7 @@ intel_dp_complete_link_train(struct intel_dp *intel_dp) | |||
| 1752 | ++tries; | 1845 | ++tries; |
| 1753 | } | 1846 | } |
| 1754 | 1847 | ||
| 1755 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) | 1848 | if (HAS_PCH_CPT(dev) && (IS_GEN7(dev) || !is_cpu_edp(intel_dp))) |
| 1756 | reg = DP | DP_LINK_TRAIN_OFF_CPT; | 1849 | reg = DP | DP_LINK_TRAIN_OFF_CPT; |
| 1757 | else | 1850 | else |
| 1758 | reg = DP | DP_LINK_TRAIN_OFF; | 1851 | reg = DP | DP_LINK_TRAIN_OFF; |
| @@ -1782,7 +1875,7 @@ intel_dp_link_down(struct intel_dp *intel_dp) | |||
| 1782 | udelay(100); | 1875 | udelay(100); |
| 1783 | } | 1876 | } |
| 1784 | 1877 | ||
| 1785 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) { | 1878 | if (HAS_PCH_CPT(dev) && (IS_GEN7(dev) || !is_cpu_edp(intel_dp))) { |
| 1786 | DP &= ~DP_LINK_TRAIN_MASK_CPT; | 1879 | DP &= ~DP_LINK_TRAIN_MASK_CPT; |
| 1787 | I915_WRITE(intel_dp->output_reg, DP | DP_LINK_TRAIN_PAT_IDLE_CPT); | 1880 | I915_WRITE(intel_dp->output_reg, DP | DP_LINK_TRAIN_PAT_IDLE_CPT); |
| 1788 | } else { | 1881 | } else { |
| @@ -1794,7 +1887,7 @@ intel_dp_link_down(struct intel_dp *intel_dp) | |||
| 1794 | msleep(17); | 1887 | msleep(17); |
| 1795 | 1888 | ||
| 1796 | if (is_edp(intel_dp)) { | 1889 | if (is_edp(intel_dp)) { |
| 1797 | if (HAS_PCH_CPT(dev) && !is_cpu_edp(intel_dp)) | 1890 | if (HAS_PCH_CPT(dev) && (IS_GEN7(dev) || !is_cpu_edp(intel_dp))) |
| 1798 | DP |= DP_LINK_TRAIN_OFF_CPT; | 1891 | DP |= DP_LINK_TRAIN_OFF_CPT; |
| 1799 | else | 1892 | else |
| 1800 | DP |= DP_LINK_TRAIN_OFF; | 1893 | DP |= DP_LINK_TRAIN_OFF; |
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index bd9a604b73da..a1b4343814e8 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h | |||
| @@ -110,6 +110,7 @@ | |||
| 110 | /* drm_display_mode->private_flags */ | 110 | /* drm_display_mode->private_flags */ |
| 111 | #define INTEL_MODE_PIXEL_MULTIPLIER_SHIFT (0x0) | 111 | #define INTEL_MODE_PIXEL_MULTIPLIER_SHIFT (0x0) |
| 112 | #define INTEL_MODE_PIXEL_MULTIPLIER_MASK (0xf << INTEL_MODE_PIXEL_MULTIPLIER_SHIFT) | 112 | #define INTEL_MODE_PIXEL_MULTIPLIER_MASK (0xf << INTEL_MODE_PIXEL_MULTIPLIER_SHIFT) |
| 113 | #define INTEL_MODE_DP_FORCE_6BPC (0x10) | ||
| 113 | 114 | ||
| 114 | static inline void | 115 | static inline void |
| 115 | intel_mode_set_pixel_multiplier(struct drm_display_mode *mode, | 116 | intel_mode_set_pixel_multiplier(struct drm_display_mode *mode, |
diff --git a/drivers/gpu/drm/i915/intel_lvds.c b/drivers/gpu/drm/i915/intel_lvds.c index 42f165a520de..e44191132ac4 100644 --- a/drivers/gpu/drm/i915/intel_lvds.c +++ b/drivers/gpu/drm/i915/intel_lvds.c | |||
| @@ -715,6 +715,14 @@ static const struct dmi_system_id intel_no_lvds[] = { | |||
| 715 | DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"), | 715 | DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"), |
| 716 | }, | 716 | }, |
| 717 | }, | 717 | }, |
| 718 | { | ||
| 719 | .callback = intel_no_lvds_dmi_callback, | ||
| 720 | .ident = "Asus AT5NM10T-I", | ||
| 721 | .matches = { | ||
| 722 | DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."), | ||
| 723 | DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"), | ||
| 724 | }, | ||
| 725 | }, | ||
| 718 | 726 | ||
| 719 | { } /* terminating entry */ | 727 | { } /* terminating entry */ |
| 720 | }; | 728 | }; |
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index 21f60b7d69a3..04d79fd1dc9d 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c | |||
| @@ -178,13 +178,10 @@ u32 intel_panel_get_max_backlight(struct drm_device *dev) | |||
| 178 | if (HAS_PCH_SPLIT(dev)) { | 178 | if (HAS_PCH_SPLIT(dev)) { |
| 179 | max >>= 16; | 179 | max >>= 16; |
| 180 | } else { | 180 | } else { |
| 181 | if (IS_PINEVIEW(dev)) { | 181 | if (INTEL_INFO(dev)->gen < 4) |
| 182 | max >>= 17; | 182 | max >>= 17; |
| 183 | } else { | 183 | else |
| 184 | max >>= 16; | 184 | max >>= 16; |
| 185 | if (INTEL_INFO(dev)->gen < 4) | ||
| 186 | max &= ~1; | ||
| 187 | } | ||
| 188 | 185 | ||
| 189 | if (is_backlight_combination_mode(dev)) | 186 | if (is_backlight_combination_mode(dev)) |
| 190 | max *= 0xff; | 187 | max *= 0xff; |
| @@ -203,13 +200,12 @@ u32 intel_panel_get_backlight(struct drm_device *dev) | |||
| 203 | val = I915_READ(BLC_PWM_CPU_CTL) & BACKLIGHT_DUTY_CYCLE_MASK; | 200 | val = I915_READ(BLC_PWM_CPU_CTL) & BACKLIGHT_DUTY_CYCLE_MASK; |
| 204 | } else { | 201 | } else { |
| 205 | val = I915_READ(BLC_PWM_CTL) & BACKLIGHT_DUTY_CYCLE_MASK; | 202 | val = I915_READ(BLC_PWM_CTL) & BACKLIGHT_DUTY_CYCLE_MASK; |
| 206 | if (IS_PINEVIEW(dev)) | 203 | if (INTEL_INFO(dev)->gen < 4) |
| 207 | val >>= 1; | 204 | val >>= 1; |
| 208 | 205 | ||
| 209 | if (is_backlight_combination_mode(dev)) { | 206 | if (is_backlight_combination_mode(dev)) { |
| 210 | u8 lbpc; | 207 | u8 lbpc; |
| 211 | 208 | ||
| 212 | val &= ~1; | ||
| 213 | pci_read_config_byte(dev->pdev, PCI_LBPC, &lbpc); | 209 | pci_read_config_byte(dev->pdev, PCI_LBPC, &lbpc); |
| 214 | val *= lbpc; | 210 | val *= lbpc; |
| 215 | } | 211 | } |
| @@ -246,11 +242,9 @@ static void intel_panel_actually_set_backlight(struct drm_device *dev, u32 level | |||
| 246 | } | 242 | } |
| 247 | 243 | ||
| 248 | tmp = I915_READ(BLC_PWM_CTL); | 244 | tmp = I915_READ(BLC_PWM_CTL); |
| 249 | if (IS_PINEVIEW(dev)) { | 245 | if (INTEL_INFO(dev)->gen < 4) |
| 250 | tmp &= ~(BACKLIGHT_DUTY_CYCLE_MASK - 1); | ||
| 251 | level <<= 1; | 246 | level <<= 1; |
| 252 | } else | 247 | tmp &= ~BACKLIGHT_DUTY_CYCLE_MASK; |
| 253 | tmp &= ~BACKLIGHT_DUTY_CYCLE_MASK; | ||
| 254 | I915_WRITE(BLC_PWM_CTL, tmp | level); | 248 | I915_WRITE(BLC_PWM_CTL, tmp | level); |
| 255 | } | 249 | } |
| 256 | 250 | ||
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index 3003fb25aefd..f7b9268df266 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c | |||
| @@ -50,6 +50,7 @@ | |||
| 50 | #define IS_TMDS(c) (c->output_flag & SDVO_TMDS_MASK) | 50 | #define IS_TMDS(c) (c->output_flag & SDVO_TMDS_MASK) |
| 51 | #define IS_LVDS(c) (c->output_flag & SDVO_LVDS_MASK) | 51 | #define IS_LVDS(c) (c->output_flag & SDVO_LVDS_MASK) |
| 52 | #define IS_TV_OR_LVDS(c) (c->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK)) | 52 | #define IS_TV_OR_LVDS(c) (c->output_flag & (SDVO_TV_MASK | SDVO_LVDS_MASK)) |
| 53 | #define IS_DIGITAL(c) (c->output_flag & (SDVO_TMDS_MASK | SDVO_LVDS_MASK)) | ||
| 53 | 54 | ||
| 54 | 55 | ||
| 55 | static const char *tv_format_names[] = { | 56 | static const char *tv_format_names[] = { |
| @@ -1086,8 +1087,12 @@ static void intel_sdvo_mode_set(struct drm_encoder *encoder, | |||
| 1086 | } | 1087 | } |
| 1087 | sdvox |= (9 << 19) | SDVO_BORDER_ENABLE; | 1088 | sdvox |= (9 << 19) | SDVO_BORDER_ENABLE; |
| 1088 | } | 1089 | } |
| 1089 | if (intel_crtc->pipe == 1) | 1090 | |
| 1090 | sdvox |= SDVO_PIPE_B_SELECT; | 1091 | if (INTEL_PCH_TYPE(dev) >= PCH_CPT) |
| 1092 | sdvox |= TRANSCODER_CPT(intel_crtc->pipe); | ||
| 1093 | else | ||
| 1094 | sdvox |= TRANSCODER(intel_crtc->pipe); | ||
| 1095 | |||
| 1091 | if (intel_sdvo->has_hdmi_audio) | 1096 | if (intel_sdvo->has_hdmi_audio) |
| 1092 | sdvox |= SDVO_AUDIO_ENABLE; | 1097 | sdvox |= SDVO_AUDIO_ENABLE; |
| 1093 | 1098 | ||
| @@ -1314,6 +1319,18 @@ intel_sdvo_tmds_sink_detect(struct drm_connector *connector) | |||
| 1314 | return status; | 1319 | return status; |
| 1315 | } | 1320 | } |
| 1316 | 1321 | ||
| 1322 | static bool | ||
| 1323 | intel_sdvo_connector_matches_edid(struct intel_sdvo_connector *sdvo, | ||
| 1324 | struct edid *edid) | ||
| 1325 | { | ||
| 1326 | bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); | ||
| 1327 | bool connector_is_digital = !!IS_DIGITAL(sdvo); | ||
| 1328 | |||
| 1329 | DRM_DEBUG_KMS("connector_is_digital? %d, monitor_is_digital? %d\n", | ||
| 1330 | connector_is_digital, monitor_is_digital); | ||
| 1331 | return connector_is_digital == monitor_is_digital; | ||
| 1332 | } | ||
| 1333 | |||
| 1317 | static enum drm_connector_status | 1334 | static enum drm_connector_status |
| 1318 | intel_sdvo_detect(struct drm_connector *connector, bool force) | 1335 | intel_sdvo_detect(struct drm_connector *connector, bool force) |
| 1319 | { | 1336 | { |
| @@ -1358,10 +1375,12 @@ intel_sdvo_detect(struct drm_connector *connector, bool force) | |||
| 1358 | if (edid == NULL) | 1375 | if (edid == NULL) |
| 1359 | edid = intel_sdvo_get_analog_edid(connector); | 1376 | edid = intel_sdvo_get_analog_edid(connector); |
| 1360 | if (edid != NULL) { | 1377 | if (edid != NULL) { |
| 1361 | if (edid->input & DRM_EDID_INPUT_DIGITAL) | 1378 | if (intel_sdvo_connector_matches_edid(intel_sdvo_connector, |
| 1362 | ret = connector_status_disconnected; | 1379 | edid)) |
| 1363 | else | ||
| 1364 | ret = connector_status_connected; | 1380 | ret = connector_status_connected; |
| 1381 | else | ||
| 1382 | ret = connector_status_disconnected; | ||
| 1383 | |||
| 1365 | connector->display_info.raw_edid = NULL; | 1384 | connector->display_info.raw_edid = NULL; |
| 1366 | kfree(edid); | 1385 | kfree(edid); |
| 1367 | } else | 1386 | } else |
| @@ -1402,11 +1421,8 @@ static void intel_sdvo_get_ddc_modes(struct drm_connector *connector) | |||
| 1402 | edid = intel_sdvo_get_analog_edid(connector); | 1421 | edid = intel_sdvo_get_analog_edid(connector); |
| 1403 | 1422 | ||
| 1404 | if (edid != NULL) { | 1423 | if (edid != NULL) { |
| 1405 | struct intel_sdvo_connector *intel_sdvo_connector = to_intel_sdvo_connector(connector); | 1424 | if (intel_sdvo_connector_matches_edid(to_intel_sdvo_connector(connector), |
| 1406 | bool monitor_is_digital = !!(edid->input & DRM_EDID_INPUT_DIGITAL); | 1425 | edid)) { |
| 1407 | bool connector_is_digital = !!IS_TMDS(intel_sdvo_connector); | ||
| 1408 | |||
| 1409 | if (connector_is_digital == monitor_is_digital) { | ||
| 1410 | drm_mode_connector_update_edid_property(connector, edid); | 1426 | drm_mode_connector_update_edid_property(connector, edid); |
| 1411 | drm_add_edid_modes(connector, edid); | 1427 | drm_add_edid_modes(connector, edid); |
| 1412 | } | 1428 | } |
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c index ddbabefb4273..b12fd2c80812 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c | |||
| @@ -369,3 +369,48 @@ nouveau_finish_page_flip(struct nouveau_channel *chan, | |||
| 369 | spin_unlock_irqrestore(&dev->event_lock, flags); | 369 | spin_unlock_irqrestore(&dev->event_lock, flags); |
| 370 | return 0; | 370 | return 0; |
| 371 | } | 371 | } |
| 372 | |||
| 373 | int | ||
| 374 | nouveau_display_dumb_create(struct drm_file *file_priv, struct drm_device *dev, | ||
| 375 | struct drm_mode_create_dumb *args) | ||
| 376 | { | ||
| 377 | struct nouveau_bo *bo; | ||
| 378 | int ret; | ||
| 379 | |||
| 380 | args->pitch = roundup(args->width * (args->bpp / 8), 256); | ||
| 381 | args->size = args->pitch * args->height; | ||
| 382 | args->size = roundup(args->size, PAGE_SIZE); | ||
| 383 | |||
| 384 | ret = nouveau_gem_new(dev, args->size, 0, TTM_PL_FLAG_VRAM, 0, 0, &bo); | ||
| 385 | if (ret) | ||
| 386 | return ret; | ||
| 387 | |||
| 388 | ret = drm_gem_handle_create(file_priv, bo->gem, &args->handle); | ||
| 389 | drm_gem_object_unreference_unlocked(bo->gem); | ||
| 390 | return ret; | ||
| 391 | } | ||
| 392 | |||
| 393 | int | ||
| 394 | nouveau_display_dumb_destroy(struct drm_file *file_priv, struct drm_device *dev, | ||
| 395 | uint32_t handle) | ||
| 396 | { | ||
| 397 | return drm_gem_handle_delete(file_priv, handle); | ||
| 398 | } | ||
| 399 | |||
| 400 | int | ||
| 401 | nouveau_display_dumb_map_offset(struct drm_file *file_priv, | ||
| 402 | struct drm_device *dev, | ||
| 403 | uint32_t handle, uint64_t *poffset) | ||
| 404 | { | ||
| 405 | struct drm_gem_object *gem; | ||
| 406 | |||
| 407 | gem = drm_gem_object_lookup(dev, file_priv, handle); | ||
| 408 | if (gem) { | ||
| 409 | struct nouveau_bo *bo = gem->driver_private; | ||
| 410 | *poffset = bo->bo.addr_space_offset; | ||
| 411 | drm_gem_object_unreference_unlocked(gem); | ||
| 412 | return 0; | ||
| 413 | } | ||
| 414 | |||
| 415 | return -ENOENT; | ||
| 416 | } | ||
diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.c b/drivers/gpu/drm/nouveau/nouveau_drv.c index 9f7bb1295262..9791d13c9e3b 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drv.c +++ b/drivers/gpu/drm/nouveau/nouveau_drv.c | |||
| @@ -433,6 +433,10 @@ static struct drm_driver driver = { | |||
| 433 | .gem_open_object = nouveau_gem_object_open, | 433 | .gem_open_object = nouveau_gem_object_open, |
| 434 | .gem_close_object = nouveau_gem_object_close, | 434 | .gem_close_object = nouveau_gem_object_close, |
| 435 | 435 | ||
| 436 | .dumb_create = nouveau_display_dumb_create, | ||
| 437 | .dumb_map_offset = nouveau_display_dumb_map_offset, | ||
| 438 | .dumb_destroy = nouveau_display_dumb_destroy, | ||
| 439 | |||
| 436 | .name = DRIVER_NAME, | 440 | .name = DRIVER_NAME, |
| 437 | .desc = DRIVER_DESC, | 441 | .desc = DRIVER_DESC, |
| 438 | #ifdef GIT_REVISION | 442 | #ifdef GIT_REVISION |
diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h index 29837da1098b..4c0be3a4ed88 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drv.h +++ b/drivers/gpu/drm/nouveau/nouveau_drv.h | |||
| @@ -1418,6 +1418,12 @@ int nouveau_crtc_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb, | |||
| 1418 | struct drm_pending_vblank_event *event); | 1418 | struct drm_pending_vblank_event *event); |
| 1419 | int nouveau_finish_page_flip(struct nouveau_channel *, | 1419 | int nouveau_finish_page_flip(struct nouveau_channel *, |
| 1420 | struct nouveau_page_flip_state *); | 1420 | struct nouveau_page_flip_state *); |
| 1421 | int nouveau_display_dumb_create(struct drm_file *, struct drm_device *, | ||
| 1422 | struct drm_mode_create_dumb *args); | ||
| 1423 | int nouveau_display_dumb_map_offset(struct drm_file *, struct drm_device *, | ||
| 1424 | uint32_t handle, uint64_t *offset); | ||
| 1425 | int nouveau_display_dumb_destroy(struct drm_file *, struct drm_device *, | ||
| 1426 | uint32_t handle); | ||
| 1421 | 1427 | ||
| 1422 | /* nv10_gpio.c */ | 1428 | /* nv10_gpio.c */ |
| 1423 | int nv10_gpio_get(struct drm_device *dev, enum dcb_gpio_tag tag); | 1429 | int nv10_gpio_get(struct drm_device *dev, enum dcb_gpio_tag tag); |
diff --git a/drivers/gpu/drm/nouveau/nouveau_object.c b/drivers/gpu/drm/nouveau/nouveau_object.c index 02222c540aee..960c0ae0c0c3 100644 --- a/drivers/gpu/drm/nouveau/nouveau_object.c +++ b/drivers/gpu/drm/nouveau/nouveau_object.c | |||
| @@ -680,7 +680,7 @@ nouveau_gpuobj_channel_init_pramin(struct nouveau_channel *chan) | |||
| 680 | return ret; | 680 | return ret; |
| 681 | } | 681 | } |
| 682 | 682 | ||
| 683 | ret = drm_mm_init(&chan->ramin_heap, base, size); | 683 | ret = drm_mm_init(&chan->ramin_heap, base, size - base); |
| 684 | if (ret) { | 684 | if (ret) { |
| 685 | NV_ERROR(dev, "Error creating PRAMIN heap: %d\n", ret); | 685 | NV_ERROR(dev, "Error creating PRAMIN heap: %d\n", ret); |
| 686 | nouveau_gpuobj_ref(NULL, &chan->ramin); | 686 | nouveau_gpuobj_ref(NULL, &chan->ramin); |
diff --git a/drivers/gpu/drm/nouveau/nouveau_sgdma.c b/drivers/gpu/drm/nouveau/nouveau_sgdma.c index b75258a9fe44..c8a463b76c89 100644 --- a/drivers/gpu/drm/nouveau/nouveau_sgdma.c +++ b/drivers/gpu/drm/nouveau/nouveau_sgdma.c | |||
| @@ -67,7 +67,10 @@ nouveau_sgdma_clear(struct ttm_backend *be) | |||
| 67 | pci_unmap_page(dev->pdev, nvbe->pages[nvbe->nr_pages], | 67 | pci_unmap_page(dev->pdev, nvbe->pages[nvbe->nr_pages], |
| 68 | PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); | 68 | PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); |
| 69 | } | 69 | } |
| 70 | nvbe->unmap_pages = false; | ||
| 70 | } | 71 | } |
| 72 | |||
| 73 | nvbe->pages = NULL; | ||
| 71 | } | 74 | } |
| 72 | 75 | ||
| 73 | static void | 76 | static void |
diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index d23ca00e7d62..06de250fe617 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b/drivers/gpu/drm/nouveau/nv50_display.c | |||
| @@ -616,7 +616,7 @@ nv50_display_unk10_handler(struct drm_device *dev) | |||
| 616 | struct drm_nouveau_private *dev_priv = dev->dev_private; | 616 | struct drm_nouveau_private *dev_priv = dev->dev_private; |
| 617 | struct nv50_display *disp = nv50_display(dev); | 617 | struct nv50_display *disp = nv50_display(dev); |
| 618 | u32 unk30 = nv_rd32(dev, 0x610030), mc; | 618 | u32 unk30 = nv_rd32(dev, 0x610030), mc; |
| 619 | int i, crtc, or, type = OUTPUT_ANY; | 619 | int i, crtc, or = 0, type = OUTPUT_ANY; |
| 620 | 620 | ||
| 621 | NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30); | 621 | NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30); |
| 622 | disp->irq.dcb = NULL; | 622 | disp->irq.dcb = NULL; |
| @@ -708,7 +708,7 @@ nv50_display_unk20_handler(struct drm_device *dev) | |||
| 708 | struct nv50_display *disp = nv50_display(dev); | 708 | struct nv50_display *disp = nv50_display(dev); |
| 709 | u32 unk30 = nv_rd32(dev, 0x610030), tmp, pclk, script, mc = 0; | 709 | u32 unk30 = nv_rd32(dev, 0x610030), tmp, pclk, script, mc = 0; |
| 710 | struct dcb_entry *dcb; | 710 | struct dcb_entry *dcb; |
| 711 | int i, crtc, or, type = OUTPUT_ANY; | 711 | int i, crtc, or = 0, type = OUTPUT_ANY; |
| 712 | 712 | ||
| 713 | NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30); | 713 | NV_DEBUG_KMS(dev, "0x610030: 0x%08x\n", unk30); |
| 714 | dcb = disp->irq.dcb; | 714 | dcb = disp->irq.dcb; |
diff --git a/drivers/gpu/drm/nouveau/nvc0_graph.c b/drivers/gpu/drm/nouveau/nvc0_graph.c index a74e501afd25..ecfafd70cf0e 100644 --- a/drivers/gpu/drm/nouveau/nvc0_graph.c +++ b/drivers/gpu/drm/nouveau/nvc0_graph.c | |||
| @@ -381,6 +381,8 @@ nvc0_graph_init_gpc_0(struct drm_device *dev) | |||
| 381 | u8 tpnr[GPC_MAX]; | 381 | u8 tpnr[GPC_MAX]; |
| 382 | int i, gpc, tpc; | 382 | int i, gpc, tpc; |
| 383 | 383 | ||
| 384 | nv_wr32(dev, TP_UNIT(0, 0, 0x5c), 1); /* affects TFB offset queries */ | ||
| 385 | |||
| 384 | /* | 386 | /* |
| 385 | * TP ROP UNKVAL(magic_not_rop_nr) | 387 | * TP ROP UNKVAL(magic_not_rop_nr) |
| 386 | * 450: 4/0/0/0 2 3 | 388 | * 450: 4/0/0/0 2 3 |
diff --git a/drivers/gpu/drm/nouveau/nvd0_display.c b/drivers/gpu/drm/nouveau/nvd0_display.c index 23d63b4b3d77..cb006a718e70 100644 --- a/drivers/gpu/drm/nouveau/nvd0_display.c +++ b/drivers/gpu/drm/nouveau/nvd0_display.c | |||
| @@ -780,7 +780,7 @@ nvd0_sor_dpms(struct drm_encoder *encoder, int mode) | |||
| 780 | continue; | 780 | continue; |
| 781 | 781 | ||
| 782 | if (nv_partner != nv_encoder && | 782 | if (nv_partner != nv_encoder && |
| 783 | nv_partner->dcb->or == nv_encoder->or) { | 783 | nv_partner->dcb->or == nv_encoder->dcb->or) { |
| 784 | if (nv_partner->last_dpms == DRM_MODE_DPMS_ON) | 784 | if (nv_partner->last_dpms == DRM_MODE_DPMS_ON) |
| 785 | return; | 785 | return; |
| 786 | break; | 786 | break; |
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c index 87631fede1f8..2b97262e3ab1 100644 --- a/drivers/gpu/drm/radeon/atombios_crtc.c +++ b/drivers/gpu/drm/radeon/atombios_crtc.c | |||
| @@ -1107,9 +1107,40 @@ static int dce4_crtc_do_set_base(struct drm_crtc *crtc, | |||
| 1107 | return -EINVAL; | 1107 | return -EINVAL; |
| 1108 | } | 1108 | } |
| 1109 | 1109 | ||
| 1110 | if (tiling_flags & RADEON_TILING_MACRO) | 1110 | if (tiling_flags & RADEON_TILING_MACRO) { |
| 1111 | if (rdev->family >= CHIP_CAYMAN) | ||
| 1112 | tmp = rdev->config.cayman.tile_config; | ||
| 1113 | else | ||
| 1114 | tmp = rdev->config.evergreen.tile_config; | ||
| 1115 | |||
| 1116 | switch ((tmp & 0xf0) >> 4) { | ||
| 1117 | case 0: /* 4 banks */ | ||
| 1118 | fb_format |= EVERGREEN_GRPH_NUM_BANKS(EVERGREEN_ADDR_SURF_4_BANK); | ||
| 1119 | break; | ||
| 1120 | case 1: /* 8 banks */ | ||
| 1121 | default: | ||
| 1122 | fb_format |= EVERGREEN_GRPH_NUM_BANKS(EVERGREEN_ADDR_SURF_8_BANK); | ||
| 1123 | break; | ||
| 1124 | case 2: /* 16 banks */ | ||
| 1125 | fb_format |= EVERGREEN_GRPH_NUM_BANKS(EVERGREEN_ADDR_SURF_16_BANK); | ||
| 1126 | break; | ||
| 1127 | } | ||
| 1128 | |||
| 1129 | switch ((tmp & 0xf000) >> 12) { | ||
| 1130 | case 0: /* 1KB rows */ | ||
| 1131 | default: | ||
| 1132 | fb_format |= EVERGREEN_GRPH_TILE_SPLIT(EVERGREEN_ADDR_SURF_TILE_SPLIT_1KB); | ||
| 1133 | break; | ||
| 1134 | case 1: /* 2KB rows */ | ||
| 1135 | fb_format |= EVERGREEN_GRPH_TILE_SPLIT(EVERGREEN_ADDR_SURF_TILE_SPLIT_2KB); | ||
| 1136 | break; | ||
| 1137 | case 2: /* 4KB rows */ | ||
| 1138 | fb_format |= EVERGREEN_GRPH_TILE_SPLIT(EVERGREEN_ADDR_SURF_TILE_SPLIT_4KB); | ||
| 1139 | break; | ||
| 1140 | } | ||
| 1141 | |||
| 1111 | fb_format |= EVERGREEN_GRPH_ARRAY_MODE(EVERGREEN_GRPH_ARRAY_2D_TILED_THIN1); | 1142 | fb_format |= EVERGREEN_GRPH_ARRAY_MODE(EVERGREEN_GRPH_ARRAY_2D_TILED_THIN1); |
| 1112 | else if (tiling_flags & RADEON_TILING_MICRO) | 1143 | } else if (tiling_flags & RADEON_TILING_MICRO) |
| 1113 | fb_format |= EVERGREEN_GRPH_ARRAY_MODE(EVERGREEN_GRPH_ARRAY_1D_TILED_THIN1); | 1144 | fb_format |= EVERGREEN_GRPH_ARRAY_MODE(EVERGREEN_GRPH_ARRAY_1D_TILED_THIN1); |
| 1114 | 1145 | ||
| 1115 | switch (radeon_crtc->crtc_id) { | 1146 | switch (radeon_crtc->crtc_id) { |
diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon/evergreen.c index 1d603a3335db..5e00d1670aa9 100644 --- a/drivers/gpu/drm/radeon/evergreen.c +++ b/drivers/gpu/drm/radeon/evergreen.c | |||
| @@ -82,6 +82,7 @@ u32 evergreen_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 82 | { | 82 | { |
| 83 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; | 83 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; |
| 84 | u32 tmp = RREG32(EVERGREEN_GRPH_UPDATE + radeon_crtc->crtc_offset); | 84 | u32 tmp = RREG32(EVERGREEN_GRPH_UPDATE + radeon_crtc->crtc_offset); |
| 85 | int i; | ||
| 85 | 86 | ||
| 86 | /* Lock the graphics update lock */ | 87 | /* Lock the graphics update lock */ |
| 87 | tmp |= EVERGREEN_GRPH_UPDATE_LOCK; | 88 | tmp |= EVERGREEN_GRPH_UPDATE_LOCK; |
| @@ -99,7 +100,11 @@ u32 evergreen_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 99 | (u32)crtc_base); | 100 | (u32)crtc_base); |
| 100 | 101 | ||
| 101 | /* Wait for update_pending to go high. */ | 102 | /* Wait for update_pending to go high. */ |
| 102 | while (!(RREG32(EVERGREEN_GRPH_UPDATE + radeon_crtc->crtc_offset) & EVERGREEN_GRPH_SURFACE_UPDATE_PENDING)); | 103 | for (i = 0; i < rdev->usec_timeout; i++) { |
| 104 | if (RREG32(EVERGREEN_GRPH_UPDATE + radeon_crtc->crtc_offset) & EVERGREEN_GRPH_SURFACE_UPDATE_PENDING) | ||
| 105 | break; | ||
| 106 | udelay(1); | ||
| 107 | } | ||
| 103 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); | 108 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); |
| 104 | 109 | ||
| 105 | /* Unlock the lock, so double-buffering can take place inside vblank */ | 110 | /* Unlock the lock, so double-buffering can take place inside vblank */ |
diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c index 38e1bda73d33..cd4590aae154 100644 --- a/drivers/gpu/drm/radeon/evergreen_cs.c +++ b/drivers/gpu/drm/radeon/evergreen_cs.c | |||
| @@ -38,6 +38,7 @@ struct evergreen_cs_track { | |||
| 38 | u32 group_size; | 38 | u32 group_size; |
| 39 | u32 nbanks; | 39 | u32 nbanks; |
| 40 | u32 npipes; | 40 | u32 npipes; |
| 41 | u32 row_size; | ||
| 41 | /* value we track */ | 42 | /* value we track */ |
| 42 | u32 nsamples; | 43 | u32 nsamples; |
| 43 | u32 cb_color_base_last[12]; | 44 | u32 cb_color_base_last[12]; |
| @@ -77,6 +78,44 @@ struct evergreen_cs_track { | |||
| 77 | struct radeon_bo *db_s_write_bo; | 78 | struct radeon_bo *db_s_write_bo; |
| 78 | }; | 79 | }; |
| 79 | 80 | ||
| 81 | static u32 evergreen_cs_get_aray_mode(u32 tiling_flags) | ||
| 82 | { | ||
| 83 | if (tiling_flags & RADEON_TILING_MACRO) | ||
| 84 | return ARRAY_2D_TILED_THIN1; | ||
| 85 | else if (tiling_flags & RADEON_TILING_MICRO) | ||
| 86 | return ARRAY_1D_TILED_THIN1; | ||
| 87 | else | ||
| 88 | return ARRAY_LINEAR_GENERAL; | ||
| 89 | } | ||
| 90 | |||
| 91 | static u32 evergreen_cs_get_num_banks(u32 nbanks) | ||
| 92 | { | ||
| 93 | switch (nbanks) { | ||
| 94 | case 2: | ||
| 95 | return ADDR_SURF_2_BANK; | ||
| 96 | case 4: | ||
| 97 | return ADDR_SURF_4_BANK; | ||
| 98 | case 8: | ||
| 99 | default: | ||
| 100 | return ADDR_SURF_8_BANK; | ||
| 101 | case 16: | ||
| 102 | return ADDR_SURF_16_BANK; | ||
| 103 | } | ||
| 104 | } | ||
| 105 | |||
| 106 | static u32 evergreen_cs_get_tile_split(u32 row_size) | ||
| 107 | { | ||
| 108 | switch (row_size) { | ||
| 109 | case 1: | ||
| 110 | default: | ||
| 111 | return ADDR_SURF_TILE_SPLIT_1KB; | ||
| 112 | case 2: | ||
| 113 | return ADDR_SURF_TILE_SPLIT_2KB; | ||
| 114 | case 4: | ||
| 115 | return ADDR_SURF_TILE_SPLIT_4KB; | ||
| 116 | } | ||
| 117 | } | ||
| 118 | |||
| 80 | static void evergreen_cs_track_init(struct evergreen_cs_track *track) | 119 | static void evergreen_cs_track_init(struct evergreen_cs_track *track) |
| 81 | { | 120 | { |
| 82 | int i; | 121 | int i; |
| @@ -490,12 +529,11 @@ static int evergreen_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) | |||
| 490 | } | 529 | } |
| 491 | ib[idx] &= ~Z_ARRAY_MODE(0xf); | 530 | ib[idx] &= ~Z_ARRAY_MODE(0xf); |
| 492 | track->db_z_info &= ~Z_ARRAY_MODE(0xf); | 531 | track->db_z_info &= ~Z_ARRAY_MODE(0xf); |
| 532 | ib[idx] |= Z_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); | ||
| 533 | track->db_z_info |= Z_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); | ||
| 493 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) { | 534 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) { |
| 494 | ib[idx] |= Z_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | 535 | ib[idx] |= DB_NUM_BANKS(evergreen_cs_get_num_banks(track->nbanks)); |
| 495 | track->db_z_info |= Z_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | 536 | ib[idx] |= DB_TILE_SPLIT(evergreen_cs_get_tile_split(track->row_size)); |
| 496 | } else { | ||
| 497 | ib[idx] |= Z_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | ||
| 498 | track->db_z_info |= Z_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | ||
| 499 | } | 537 | } |
| 500 | } | 538 | } |
| 501 | break; | 539 | break; |
| @@ -618,13 +656,8 @@ static int evergreen_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) | |||
| 618 | "0x%04X\n", reg); | 656 | "0x%04X\n", reg); |
| 619 | return -EINVAL; | 657 | return -EINVAL; |
| 620 | } | 658 | } |
| 621 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) { | 659 | ib[idx] |= CB_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); |
| 622 | ib[idx] |= CB_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | 660 | track->cb_color_info[tmp] |= CB_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); |
| 623 | track->cb_color_info[tmp] |= CB_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | ||
| 624 | } else if (reloc->lobj.tiling_flags & RADEON_TILING_MICRO) { | ||
| 625 | ib[idx] |= CB_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | ||
| 626 | track->cb_color_info[tmp] |= CB_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | ||
| 627 | } | ||
| 628 | } | 661 | } |
| 629 | break; | 662 | break; |
| 630 | case CB_COLOR8_INFO: | 663 | case CB_COLOR8_INFO: |
| @@ -640,13 +673,8 @@ static int evergreen_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) | |||
| 640 | "0x%04X\n", reg); | 673 | "0x%04X\n", reg); |
| 641 | return -EINVAL; | 674 | return -EINVAL; |
| 642 | } | 675 | } |
| 643 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) { | 676 | ib[idx] |= CB_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); |
| 644 | ib[idx] |= CB_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | 677 | track->cb_color_info[tmp] |= CB_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); |
| 645 | track->cb_color_info[tmp] |= CB_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | ||
| 646 | } else if (reloc->lobj.tiling_flags & RADEON_TILING_MICRO) { | ||
| 647 | ib[idx] |= CB_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | ||
| 648 | track->cb_color_info[tmp] |= CB_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | ||
| 649 | } | ||
| 650 | } | 678 | } |
| 651 | break; | 679 | break; |
| 652 | case CB_COLOR0_PITCH: | 680 | case CB_COLOR0_PITCH: |
| @@ -701,6 +729,16 @@ static int evergreen_cs_check_reg(struct radeon_cs_parser *p, u32 reg, u32 idx) | |||
| 701 | case CB_COLOR9_ATTRIB: | 729 | case CB_COLOR9_ATTRIB: |
| 702 | case CB_COLOR10_ATTRIB: | 730 | case CB_COLOR10_ATTRIB: |
| 703 | case CB_COLOR11_ATTRIB: | 731 | case CB_COLOR11_ATTRIB: |
| 732 | r = evergreen_cs_packet_next_reloc(p, &reloc); | ||
| 733 | if (r) { | ||
| 734 | dev_warn(p->dev, "bad SET_CONTEXT_REG " | ||
| 735 | "0x%04X\n", reg); | ||
| 736 | return -EINVAL; | ||
| 737 | } | ||
| 738 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) { | ||
| 739 | ib[idx] |= CB_NUM_BANKS(evergreen_cs_get_num_banks(track->nbanks)); | ||
| 740 | ib[idx] |= CB_TILE_SPLIT(evergreen_cs_get_tile_split(track->row_size)); | ||
| 741 | } | ||
| 704 | break; | 742 | break; |
| 705 | case CB_COLOR0_DIM: | 743 | case CB_COLOR0_DIM: |
| 706 | case CB_COLOR1_DIM: | 744 | case CB_COLOR1_DIM: |
| @@ -1318,10 +1356,14 @@ static int evergreen_packet3_check(struct radeon_cs_parser *p, | |||
| 1318 | } | 1356 | } |
| 1319 | ib[idx+1+(i*8)+2] += (u32)((reloc->lobj.gpu_offset >> 8) & 0xffffffff); | 1357 | ib[idx+1+(i*8)+2] += (u32)((reloc->lobj.gpu_offset >> 8) & 0xffffffff); |
| 1320 | if (!p->keep_tiling_flags) { | 1358 | if (!p->keep_tiling_flags) { |
| 1321 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) | 1359 | ib[idx+1+(i*8)+1] |= |
| 1322 | ib[idx+1+(i*8)+1] |= TEX_ARRAY_MODE(ARRAY_2D_TILED_THIN1); | 1360 | TEX_ARRAY_MODE(evergreen_cs_get_aray_mode(reloc->lobj.tiling_flags)); |
| 1323 | else if (reloc->lobj.tiling_flags & RADEON_TILING_MICRO) | 1361 | if (reloc->lobj.tiling_flags & RADEON_TILING_MACRO) { |
| 1324 | ib[idx+1+(i*8)+1] |= TEX_ARRAY_MODE(ARRAY_1D_TILED_THIN1); | 1362 | ib[idx+1+(i*8)+6] |= |
| 1363 | TEX_TILE_SPLIT(evergreen_cs_get_tile_split(track->row_size)); | ||
| 1364 | ib[idx+1+(i*8)+7] |= | ||
| 1365 | TEX_NUM_BANKS(evergreen_cs_get_num_banks(track->nbanks)); | ||
| 1366 | } | ||
| 1325 | } | 1367 | } |
| 1326 | texture = reloc->robj; | 1368 | texture = reloc->robj; |
| 1327 | /* tex mip base */ | 1369 | /* tex mip base */ |
| @@ -1422,6 +1464,7 @@ int evergreen_cs_parse(struct radeon_cs_parser *p) | |||
| 1422 | { | 1464 | { |
| 1423 | struct radeon_cs_packet pkt; | 1465 | struct radeon_cs_packet pkt; |
| 1424 | struct evergreen_cs_track *track; | 1466 | struct evergreen_cs_track *track; |
| 1467 | u32 tmp; | ||
| 1425 | int r; | 1468 | int r; |
| 1426 | 1469 | ||
| 1427 | if (p->track == NULL) { | 1470 | if (p->track == NULL) { |
| @@ -1430,9 +1473,63 @@ int evergreen_cs_parse(struct radeon_cs_parser *p) | |||
| 1430 | if (track == NULL) | 1473 | if (track == NULL) |
| 1431 | return -ENOMEM; | 1474 | return -ENOMEM; |
| 1432 | evergreen_cs_track_init(track); | 1475 | evergreen_cs_track_init(track); |
| 1433 | track->npipes = p->rdev->config.evergreen.tiling_npipes; | 1476 | if (p->rdev->family >= CHIP_CAYMAN) |
| 1434 | track->nbanks = p->rdev->config.evergreen.tiling_nbanks; | 1477 | tmp = p->rdev->config.cayman.tile_config; |
| 1435 | track->group_size = p->rdev->config.evergreen.tiling_group_size; | 1478 | else |
| 1479 | tmp = p->rdev->config.evergreen.tile_config; | ||
| 1480 | |||
| 1481 | switch (tmp & 0xf) { | ||
| 1482 | case 0: | ||
| 1483 | track->npipes = 1; | ||
| 1484 | break; | ||
| 1485 | case 1: | ||
| 1486 | default: | ||
| 1487 | track->npipes = 2; | ||
| 1488 | break; | ||
| 1489 | case 2: | ||
| 1490 | track->npipes = 4; | ||
| 1491 | break; | ||
| 1492 | case 3: | ||
| 1493 | track->npipes = 8; | ||
| 1494 | break; | ||
| 1495 | } | ||
| 1496 | |||
| 1497 | switch ((tmp & 0xf0) >> 4) { | ||
| 1498 | case 0: | ||
| 1499 | track->nbanks = 4; | ||
| 1500 | break; | ||
| 1501 | case 1: | ||
| 1502 | default: | ||
| 1503 | track->nbanks = 8; | ||
| 1504 | break; | ||
| 1505 | case 2: | ||
| 1506 | track->nbanks = 16; | ||
| 1507 | break; | ||
| 1508 | } | ||
| 1509 | |||
| 1510 | switch ((tmp & 0xf00) >> 8) { | ||
| 1511 | case 0: | ||
| 1512 | track->group_size = 256; | ||
| 1513 | break; | ||
| 1514 | case 1: | ||
| 1515 | default: | ||
| 1516 | track->group_size = 512; | ||
| 1517 | break; | ||
| 1518 | } | ||
| 1519 | |||
| 1520 | switch ((tmp & 0xf000) >> 12) { | ||
| 1521 | case 0: | ||
| 1522 | track->row_size = 1; | ||
| 1523 | break; | ||
| 1524 | case 1: | ||
| 1525 | default: | ||
| 1526 | track->row_size = 2; | ||
| 1527 | break; | ||
| 1528 | case 2: | ||
| 1529 | track->row_size = 4; | ||
| 1530 | break; | ||
| 1531 | } | ||
| 1532 | |||
| 1436 | p->track = track; | 1533 | p->track = track; |
| 1437 | } | 1534 | } |
| 1438 | do { | 1535 | do { |
diff --git a/drivers/gpu/drm/radeon/evergreen_reg.h b/drivers/gpu/drm/radeon/evergreen_reg.h index c781c92c3451..7d7f2155e34c 100644 --- a/drivers/gpu/drm/radeon/evergreen_reg.h +++ b/drivers/gpu/drm/radeon/evergreen_reg.h | |||
| @@ -42,6 +42,17 @@ | |||
| 42 | # define EVERGREEN_GRPH_DEPTH_8BPP 0 | 42 | # define EVERGREEN_GRPH_DEPTH_8BPP 0 |
| 43 | # define EVERGREEN_GRPH_DEPTH_16BPP 1 | 43 | # define EVERGREEN_GRPH_DEPTH_16BPP 1 |
| 44 | # define EVERGREEN_GRPH_DEPTH_32BPP 2 | 44 | # define EVERGREEN_GRPH_DEPTH_32BPP 2 |
| 45 | # define EVERGREEN_GRPH_NUM_BANKS(x) (((x) & 0x3) << 2) | ||
| 46 | # define EVERGREEN_ADDR_SURF_2_BANK 0 | ||
| 47 | # define EVERGREEN_ADDR_SURF_4_BANK 1 | ||
| 48 | # define EVERGREEN_ADDR_SURF_8_BANK 2 | ||
| 49 | # define EVERGREEN_ADDR_SURF_16_BANK 3 | ||
| 50 | # define EVERGREEN_GRPH_Z(x) (((x) & 0x3) << 4) | ||
| 51 | # define EVERGREEN_GRPH_BANK_WIDTH(x) (((x) & 0x3) << 6) | ||
| 52 | # define EVERGREEN_ADDR_SURF_BANK_WIDTH_1 0 | ||
| 53 | # define EVERGREEN_ADDR_SURF_BANK_WIDTH_2 1 | ||
| 54 | # define EVERGREEN_ADDR_SURF_BANK_WIDTH_4 2 | ||
| 55 | # define EVERGREEN_ADDR_SURF_BANK_WIDTH_8 3 | ||
| 45 | # define EVERGREEN_GRPH_FORMAT(x) (((x) & 0x7) << 8) | 56 | # define EVERGREEN_GRPH_FORMAT(x) (((x) & 0x7) << 8) |
| 46 | /* 8 BPP */ | 57 | /* 8 BPP */ |
| 47 | # define EVERGREEN_GRPH_FORMAT_INDEXED 0 | 58 | # define EVERGREEN_GRPH_FORMAT_INDEXED 0 |
| @@ -61,6 +72,24 @@ | |||
| 61 | # define EVERGREEN_GRPH_FORMAT_8B_BGRA1010102 5 | 72 | # define EVERGREEN_GRPH_FORMAT_8B_BGRA1010102 5 |
| 62 | # define EVERGREEN_GRPH_FORMAT_RGB111110 6 | 73 | # define EVERGREEN_GRPH_FORMAT_RGB111110 6 |
| 63 | # define EVERGREEN_GRPH_FORMAT_BGR101111 7 | 74 | # define EVERGREEN_GRPH_FORMAT_BGR101111 7 |
| 75 | # define EVERGREEN_GRPH_BANK_HEIGHT(x) (((x) & 0x3) << 11) | ||
| 76 | # define EVERGREEN_ADDR_SURF_BANK_HEIGHT_1 0 | ||
| 77 | # define EVERGREEN_ADDR_SURF_BANK_HEIGHT_2 1 | ||
| 78 | # define EVERGREEN_ADDR_SURF_BANK_HEIGHT_4 2 | ||
| 79 | # define EVERGREEN_ADDR_SURF_BANK_HEIGHT_8 3 | ||
| 80 | # define EVERGREEN_GRPH_TILE_SPLIT(x) (((x) & 0x7) << 13) | ||
| 81 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_64B 0 | ||
| 82 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_128B 1 | ||
| 83 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_256B 2 | ||
| 84 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_512B 3 | ||
| 85 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_1KB 4 | ||
| 86 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_2KB 5 | ||
| 87 | # define EVERGREEN_ADDR_SURF_TILE_SPLIT_4KB 6 | ||
| 88 | # define EVERGREEN_GRPH_MACRO_TILE_ASPECT(x) (((x) & 0x3) << 18) | ||
| 89 | # define EVERGREEN_ADDR_SURF_MACRO_TILE_ASPECT_1 0 | ||
| 90 | # define EVERGREEN_ADDR_SURF_MACRO_TILE_ASPECT_2 1 | ||
| 91 | # define EVERGREEN_ADDR_SURF_MACRO_TILE_ASPECT_4 2 | ||
| 92 | # define EVERGREEN_ADDR_SURF_MACRO_TILE_ASPECT_8 3 | ||
| 64 | # define EVERGREEN_GRPH_ARRAY_MODE(x) (((x) & 0x7) << 20) | 93 | # define EVERGREEN_GRPH_ARRAY_MODE(x) (((x) & 0x7) << 20) |
| 65 | # define EVERGREEN_GRPH_ARRAY_LINEAR_GENERAL 0 | 94 | # define EVERGREEN_GRPH_ARRAY_LINEAR_GENERAL 0 |
| 66 | # define EVERGREEN_GRPH_ARRAY_LINEAR_ALIGNED 1 | 95 | # define EVERGREEN_GRPH_ARRAY_LINEAR_ALIGNED 1 |
diff --git a/drivers/gpu/drm/radeon/evergreend.h b/drivers/gpu/drm/radeon/evergreend.h index b937c49054d9..e00039e59a75 100644 --- a/drivers/gpu/drm/radeon/evergreend.h +++ b/drivers/gpu/drm/radeon/evergreend.h | |||
| @@ -899,6 +899,10 @@ | |||
| 899 | #define DB_HTILE_DATA_BASE 0x28014 | 899 | #define DB_HTILE_DATA_BASE 0x28014 |
| 900 | #define DB_Z_INFO 0x28040 | 900 | #define DB_Z_INFO 0x28040 |
| 901 | # define Z_ARRAY_MODE(x) ((x) << 4) | 901 | # define Z_ARRAY_MODE(x) ((x) << 4) |
| 902 | # define DB_TILE_SPLIT(x) (((x) & 0x7) << 8) | ||
| 903 | # define DB_NUM_BANKS(x) (((x) & 0x3) << 12) | ||
| 904 | # define DB_BANK_WIDTH(x) (((x) & 0x3) << 16) | ||
| 905 | # define DB_BANK_HEIGHT(x) (((x) & 0x3) << 20) | ||
| 902 | #define DB_STENCIL_INFO 0x28044 | 906 | #define DB_STENCIL_INFO 0x28044 |
| 903 | #define DB_Z_READ_BASE 0x28048 | 907 | #define DB_Z_READ_BASE 0x28048 |
| 904 | #define DB_STENCIL_READ_BASE 0x2804c | 908 | #define DB_STENCIL_READ_BASE 0x2804c |
| @@ -951,6 +955,29 @@ | |||
| 951 | # define CB_SF_EXPORT_FULL 0 | 955 | # define CB_SF_EXPORT_FULL 0 |
| 952 | # define CB_SF_EXPORT_NORM 1 | 956 | # define CB_SF_EXPORT_NORM 1 |
| 953 | #define CB_COLOR0_ATTRIB 0x28c74 | 957 | #define CB_COLOR0_ATTRIB 0x28c74 |
| 958 | # define CB_TILE_SPLIT(x) (((x) & 0x7) << 5) | ||
| 959 | # define ADDR_SURF_TILE_SPLIT_64B 0 | ||
| 960 | # define ADDR_SURF_TILE_SPLIT_128B 1 | ||
| 961 | # define ADDR_SURF_TILE_SPLIT_256B 2 | ||
| 962 | # define ADDR_SURF_TILE_SPLIT_512B 3 | ||
| 963 | # define ADDR_SURF_TILE_SPLIT_1KB 4 | ||
| 964 | # define ADDR_SURF_TILE_SPLIT_2KB 5 | ||
| 965 | # define ADDR_SURF_TILE_SPLIT_4KB 6 | ||
| 966 | # define CB_NUM_BANKS(x) (((x) & 0x3) << 10) | ||
| 967 | # define ADDR_SURF_2_BANK 0 | ||
| 968 | # define ADDR_SURF_4_BANK 1 | ||
| 969 | # define ADDR_SURF_8_BANK 2 | ||
| 970 | # define ADDR_SURF_16_BANK 3 | ||
| 971 | # define CB_BANK_WIDTH(x) (((x) & 0x3) << 13) | ||
| 972 | # define ADDR_SURF_BANK_WIDTH_1 0 | ||
| 973 | # define ADDR_SURF_BANK_WIDTH_2 1 | ||
| 974 | # define ADDR_SURF_BANK_WIDTH_4 2 | ||
| 975 | # define ADDR_SURF_BANK_WIDTH_8 3 | ||
| 976 | # define CB_BANK_HEIGHT(x) (((x) & 0x3) << 16) | ||
| 977 | # define ADDR_SURF_BANK_HEIGHT_1 0 | ||
| 978 | # define ADDR_SURF_BANK_HEIGHT_2 1 | ||
| 979 | # define ADDR_SURF_BANK_HEIGHT_4 2 | ||
| 980 | # define ADDR_SURF_BANK_HEIGHT_8 3 | ||
| 954 | #define CB_COLOR0_DIM 0x28c78 | 981 | #define CB_COLOR0_DIM 0x28c78 |
| 955 | /* only CB0-7 blocks have these regs */ | 982 | /* only CB0-7 blocks have these regs */ |
| 956 | #define CB_COLOR0_CMASK 0x28c7c | 983 | #define CB_COLOR0_CMASK 0x28c7c |
| @@ -1137,7 +1164,11 @@ | |||
| 1137 | # define SQ_SEL_1 5 | 1164 | # define SQ_SEL_1 5 |
| 1138 | #define SQ_TEX_RESOURCE_WORD5_0 0x30014 | 1165 | #define SQ_TEX_RESOURCE_WORD5_0 0x30014 |
| 1139 | #define SQ_TEX_RESOURCE_WORD6_0 0x30018 | 1166 | #define SQ_TEX_RESOURCE_WORD6_0 0x30018 |
| 1167 | # define TEX_TILE_SPLIT(x) (((x) & 0x7) << 29) | ||
| 1140 | #define SQ_TEX_RESOURCE_WORD7_0 0x3001c | 1168 | #define SQ_TEX_RESOURCE_WORD7_0 0x3001c |
| 1169 | # define TEX_BANK_WIDTH(x) (((x) & 0x3) << 8) | ||
| 1170 | # define TEX_BANK_HEIGHT(x) (((x) & 0x3) << 10) | ||
| 1171 | # define TEX_NUM_BANKS(x) (((x) & 0x3) << 16) | ||
| 1141 | 1172 | ||
| 1142 | #define SQ_VTX_CONSTANT_WORD0_0 0x30000 | 1173 | #define SQ_VTX_CONSTANT_WORD0_0 0x30000 |
| 1143 | #define SQ_VTX_CONSTANT_WORD1_0 0x30004 | 1174 | #define SQ_VTX_CONSTANT_WORD1_0 0x30004 |
diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index ad158ea49901..bfc08f6320f8 100644 --- a/drivers/gpu/drm/radeon/r100.c +++ b/drivers/gpu/drm/radeon/r100.c | |||
| @@ -187,13 +187,18 @@ u32 r100_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 187 | { | 187 | { |
| 188 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; | 188 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; |
| 189 | u32 tmp = ((u32)crtc_base) | RADEON_CRTC_OFFSET__OFFSET_LOCK; | 189 | u32 tmp = ((u32)crtc_base) | RADEON_CRTC_OFFSET__OFFSET_LOCK; |
| 190 | int i; | ||
| 190 | 191 | ||
| 191 | /* Lock the graphics update lock */ | 192 | /* Lock the graphics update lock */ |
| 192 | /* update the scanout addresses */ | 193 | /* update the scanout addresses */ |
| 193 | WREG32(RADEON_CRTC_OFFSET + radeon_crtc->crtc_offset, tmp); | 194 | WREG32(RADEON_CRTC_OFFSET + radeon_crtc->crtc_offset, tmp); |
| 194 | 195 | ||
| 195 | /* Wait for update_pending to go high. */ | 196 | /* Wait for update_pending to go high. */ |
| 196 | while (!(RREG32(RADEON_CRTC_OFFSET + radeon_crtc->crtc_offset) & RADEON_CRTC_OFFSET__GUI_TRIG_OFFSET)); | 197 | for (i = 0; i < rdev->usec_timeout; i++) { |
| 198 | if (RREG32(RADEON_CRTC_OFFSET + radeon_crtc->crtc_offset) & RADEON_CRTC_OFFSET__GUI_TRIG_OFFSET) | ||
| 199 | break; | ||
| 200 | udelay(1); | ||
| 201 | } | ||
| 197 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); | 202 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); |
| 198 | 203 | ||
| 199 | /* Unlock the lock, so double-buffering can take place inside vblank */ | 204 | /* Unlock the lock, so double-buffering can take place inside vblank */ |
diff --git a/drivers/gpu/drm/radeon/radeon_acpi.c b/drivers/gpu/drm/radeon/radeon_acpi.c index 3f6636bb2d7f..3516a6081dcf 100644 --- a/drivers/gpu/drm/radeon/radeon_acpi.c +++ b/drivers/gpu/drm/radeon/radeon_acpi.c | |||
| @@ -35,7 +35,8 @@ static int radeon_atif_call(acpi_handle handle) | |||
| 35 | 35 | ||
| 36 | /* Fail only if calling the method fails and ATIF is supported */ | 36 | /* Fail only if calling the method fails and ATIF is supported */ |
| 37 | if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { | 37 | if (ACPI_FAILURE(status) && status != AE_NOT_FOUND) { |
| 38 | printk(KERN_DEBUG "failed to evaluate ATIF got %s\n", acpi_format_exception(status)); | 38 | DRM_DEBUG_DRIVER("failed to evaluate ATIF got %s\n", |
| 39 | acpi_format_exception(status)); | ||
| 39 | kfree(buffer.pointer); | 40 | kfree(buffer.pointer); |
| 40 | return 1; | 41 | return 1; |
| 41 | } | 42 | } |
| @@ -50,13 +51,13 @@ int radeon_acpi_init(struct radeon_device *rdev) | |||
| 50 | acpi_handle handle; | 51 | acpi_handle handle; |
| 51 | int ret; | 52 | int ret; |
| 52 | 53 | ||
| 53 | /* No need to proceed if we're sure that ATIF is not supported */ | ||
| 54 | if (!ASIC_IS_AVIVO(rdev) || !rdev->bios) | ||
| 55 | return 0; | ||
| 56 | |||
| 57 | /* Get the device handle */ | 54 | /* Get the device handle */ |
| 58 | handle = DEVICE_ACPI_HANDLE(&rdev->pdev->dev); | 55 | handle = DEVICE_ACPI_HANDLE(&rdev->pdev->dev); |
| 59 | 56 | ||
| 57 | /* No need to proceed if we're sure that ATIF is not supported */ | ||
| 58 | if (!ASIC_IS_AVIVO(rdev) || !rdev->bios || !handle) | ||
| 59 | return 0; | ||
| 60 | |||
| 60 | /* Call the ATIF method */ | 61 | /* Call the ATIF method */ |
| 61 | ret = radeon_atif_call(handle); | 62 | ret = radeon_atif_call(handle); |
| 62 | if (ret) | 63 | if (ret) |
diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c index 06e413e6a920..4b27efa4405b 100644 --- a/drivers/gpu/drm/radeon/radeon_encoders.c +++ b/drivers/gpu/drm/radeon/radeon_encoders.c | |||
| @@ -233,13 +233,12 @@ u16 radeon_encoder_get_dp_bridge_encoder_id(struct drm_encoder *encoder) | |||
| 233 | switch (radeon_encoder->encoder_id) { | 233 | switch (radeon_encoder->encoder_id) { |
| 234 | case ENCODER_OBJECT_ID_TRAVIS: | 234 | case ENCODER_OBJECT_ID_TRAVIS: |
| 235 | case ENCODER_OBJECT_ID_NUTMEG: | 235 | case ENCODER_OBJECT_ID_NUTMEG: |
| 236 | return true; | 236 | return radeon_encoder->encoder_id; |
| 237 | default: | 237 | default: |
| 238 | return false; | 238 | return ENCODER_OBJECT_ID_NONE; |
| 239 | } | 239 | } |
| 240 | } | 240 | } |
| 241 | 241 | return ENCODER_OBJECT_ID_NONE; | |
| 242 | return false; | ||
| 243 | } | 242 | } |
| 244 | 243 | ||
| 245 | void radeon_panel_mode_fixup(struct drm_encoder *encoder, | 244 | void radeon_panel_mode_fixup(struct drm_encoder *encoder, |
diff --git a/drivers/gpu/drm/radeon/rs600.c b/drivers/gpu/drm/radeon/rs600.c index 481b99e89f65..b1053d640423 100644 --- a/drivers/gpu/drm/radeon/rs600.c +++ b/drivers/gpu/drm/radeon/rs600.c | |||
| @@ -62,6 +62,7 @@ u32 rs600_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 62 | { | 62 | { |
| 63 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; | 63 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; |
| 64 | u32 tmp = RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset); | 64 | u32 tmp = RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset); |
| 65 | int i; | ||
| 65 | 66 | ||
| 66 | /* Lock the graphics update lock */ | 67 | /* Lock the graphics update lock */ |
| 67 | tmp |= AVIVO_D1GRPH_UPDATE_LOCK; | 68 | tmp |= AVIVO_D1GRPH_UPDATE_LOCK; |
| @@ -74,7 +75,11 @@ u32 rs600_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 74 | (u32)crtc_base); | 75 | (u32)crtc_base); |
| 75 | 76 | ||
| 76 | /* Wait for update_pending to go high. */ | 77 | /* Wait for update_pending to go high. */ |
| 77 | while (!(RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset) & AVIVO_D1GRPH_SURFACE_UPDATE_PENDING)); | 78 | for (i = 0; i < rdev->usec_timeout; i++) { |
| 79 | if (RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset) & AVIVO_D1GRPH_SURFACE_UPDATE_PENDING) | ||
| 80 | break; | ||
| 81 | udelay(1); | ||
| 82 | } | ||
| 78 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); | 83 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); |
| 79 | 84 | ||
| 80 | /* Unlock the lock, so double-buffering can take place inside vblank */ | 85 | /* Unlock the lock, so double-buffering can take place inside vblank */ |
diff --git a/drivers/gpu/drm/radeon/rv770.c b/drivers/gpu/drm/radeon/rv770.c index a983f410ab89..23ae1c60ab3d 100644 --- a/drivers/gpu/drm/radeon/rv770.c +++ b/drivers/gpu/drm/radeon/rv770.c | |||
| @@ -47,6 +47,7 @@ u32 rv770_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 47 | { | 47 | { |
| 48 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; | 48 | struct radeon_crtc *radeon_crtc = rdev->mode_info.crtcs[crtc_id]; |
| 49 | u32 tmp = RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset); | 49 | u32 tmp = RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset); |
| 50 | int i; | ||
| 50 | 51 | ||
| 51 | /* Lock the graphics update lock */ | 52 | /* Lock the graphics update lock */ |
| 52 | tmp |= AVIVO_D1GRPH_UPDATE_LOCK; | 53 | tmp |= AVIVO_D1GRPH_UPDATE_LOCK; |
| @@ -66,7 +67,11 @@ u32 rv770_page_flip(struct radeon_device *rdev, int crtc_id, u64 crtc_base) | |||
| 66 | (u32)crtc_base); | 67 | (u32)crtc_base); |
| 67 | 68 | ||
| 68 | /* Wait for update_pending to go high. */ | 69 | /* Wait for update_pending to go high. */ |
| 69 | while (!(RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset) & AVIVO_D1GRPH_SURFACE_UPDATE_PENDING)); | 70 | for (i = 0; i < rdev->usec_timeout; i++) { |
| 71 | if (RREG32(AVIVO_D1GRPH_UPDATE + radeon_crtc->crtc_offset) & AVIVO_D1GRPH_SURFACE_UPDATE_PENDING) | ||
| 72 | break; | ||
| 73 | udelay(1); | ||
| 74 | } | ||
| 70 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); | 75 | DRM_DEBUG("Update pending now high. Unlocking vupdate_lock.\n"); |
| 71 | 76 | ||
| 72 | /* Unlock the lock, so double-buffering can take place inside vblank */ | 77 | /* Unlock the lock, so double-buffering can take place inside vblank */ |
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c index 3f6343502d1f..5ff561d4e0b4 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | |||
| @@ -140,7 +140,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data, | |||
| 140 | goto out_clips; | 140 | goto out_clips; |
| 141 | } | 141 | } |
| 142 | 142 | ||
| 143 | clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL); | 143 | clips = kcalloc(num_clips, sizeof(*clips), GFP_KERNEL); |
| 144 | if (clips == NULL) { | 144 | if (clips == NULL) { |
| 145 | DRM_ERROR("Failed to allocate clip rect list.\n"); | 145 | DRM_ERROR("Failed to allocate clip rect list.\n"); |
| 146 | ret = -ENOMEM; | 146 | ret = -ENOMEM; |
| @@ -232,7 +232,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data, | |||
| 232 | goto out_clips; | 232 | goto out_clips; |
| 233 | } | 233 | } |
| 234 | 234 | ||
| 235 | clips = kzalloc(num_clips * sizeof(*clips), GFP_KERNEL); | 235 | clips = kcalloc(num_clips, sizeof(*clips), GFP_KERNEL); |
| 236 | if (clips == NULL) { | 236 | if (clips == NULL) { |
| 237 | DRM_ERROR("Failed to allocate clip rect list.\n"); | 237 | DRM_ERROR("Failed to allocate clip rect list.\n"); |
| 238 | ret = -ENOMEM; | 238 | ret = -ENOMEM; |
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 880e285d7578..37d40545ed77 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | |||
| @@ -1809,7 +1809,8 @@ int vmw_kms_update_layout_ioctl(struct drm_device *dev, void *data, | |||
| 1809 | } | 1809 | } |
| 1810 | 1810 | ||
| 1811 | rects_size = arg->num_outputs * sizeof(struct drm_vmw_rect); | 1811 | rects_size = arg->num_outputs * sizeof(struct drm_vmw_rect); |
| 1812 | rects = kzalloc(rects_size, GFP_KERNEL); | 1812 | rects = kcalloc(arg->num_outputs, sizeof(struct drm_vmw_rect), |
| 1813 | GFP_KERNEL); | ||
| 1813 | if (unlikely(!rects)) { | 1814 | if (unlikely(!rects)) { |
| 1814 | ret = -ENOMEM; | 1815 | ret = -ENOMEM; |
| 1815 | goto out_unlock; | 1816 | goto out_unlock; |
| @@ -1824,10 +1825,10 @@ int vmw_kms_update_layout_ioctl(struct drm_device *dev, void *data, | |||
| 1824 | } | 1825 | } |
| 1825 | 1826 | ||
| 1826 | for (i = 0; i < arg->num_outputs; ++i) { | 1827 | for (i = 0; i < arg->num_outputs; ++i) { |
| 1827 | if (rects->x < 0 || | 1828 | if (rects[i].x < 0 || |
| 1828 | rects->y < 0 || | 1829 | rects[i].y < 0 || |
| 1829 | rects->x + rects->w > mode_config->max_width || | 1830 | rects[i].x + rects[i].w > mode_config->max_width || |
| 1830 | rects->y + rects->h > mode_config->max_height) { | 1831 | rects[i].y + rects[i].h > mode_config->max_height) { |
| 1831 | DRM_ERROR("Invalid GUI layout.\n"); | 1832 | DRM_ERROR("Invalid GUI layout.\n"); |
| 1832 | ret = -EINVAL; | 1833 | ret = -EINVAL; |
| 1833 | goto out_free; | 1834 | goto out_free; |
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 848a56c0279c..af353842f75f 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c | |||
| @@ -1771,8 +1771,8 @@ static const struct hid_device_id hid_ignore_list[] = { | |||
| 1771 | { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, | 1771 | { HID_USB_DEVICE(USB_VENDOR_ID_ESSENTIAL_REALITY, USB_DEVICE_ID_ESSENTIAL_REALITY_P5) }, |
| 1772 | { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, | 1772 | { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC5UH) }, |
| 1773 | { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, | 1773 | { HID_USB_DEVICE(USB_VENDOR_ID_ETT, USB_DEVICE_ID_TC4UM) }, |
| 1774 | { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0001) }, | ||
| 1774 | { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0002) }, | 1775 | { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0002) }, |
| 1775 | { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0003) }, | ||
| 1776 | { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0004) }, | 1776 | { HID_USB_DEVICE(USB_VENDOR_ID_GENERAL_TOUCH, 0x0004) }, |
| 1777 | { HID_USB_DEVICE(USB_VENDOR_ID_GLAB, USB_DEVICE_ID_4_PHIDGETSERVO_30) }, | 1777 | { HID_USB_DEVICE(USB_VENDOR_ID_GLAB, USB_DEVICE_ID_4_PHIDGETSERVO_30) }, |
| 1778 | { HID_USB_DEVICE(USB_VENDOR_ID_GLAB, USB_DEVICE_ID_1_PHIDGETSERVO_30) }, | 1778 | { HID_USB_DEVICE(USB_VENDOR_ID_GLAB, USB_DEVICE_ID_1_PHIDGETSERVO_30) }, |
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 06ce996b8b65..4a441a6f9967 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h | |||
| @@ -266,7 +266,7 @@ | |||
| 266 | #define USB_DEVICE_ID_GAMERON_DUAL_PCS_ADAPTOR 0x0002 | 266 | #define USB_DEVICE_ID_GAMERON_DUAL_PCS_ADAPTOR 0x0002 |
| 267 | 267 | ||
| 268 | #define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc | 268 | #define USB_VENDOR_ID_GENERAL_TOUCH 0x0dfc |
| 269 | #define USB_DEVICE_ID_GENERAL_TOUCH_WIN7_TWOFINGERS 0x0001 | 269 | #define USB_DEVICE_ID_GENERAL_TOUCH_WIN7_TWOFINGERS 0x0003 |
| 270 | 270 | ||
| 271 | #define USB_VENDOR_ID_GLAB 0x06c2 | 271 | #define USB_VENDOR_ID_GLAB 0x06c2 |
| 272 | #define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038 | 272 | #define USB_DEVICE_ID_4_PHIDGETSERVO_30 0x0038 |
diff --git a/drivers/hwmon/ad7314.c b/drivers/hwmon/ad7314.c index 318e38e85376..5d760f3d21c2 100644 --- a/drivers/hwmon/ad7314.c +++ b/drivers/hwmon/ad7314.c | |||
| @@ -160,7 +160,6 @@ MODULE_DEVICE_TABLE(spi, ad7314_id); | |||
| 160 | static struct spi_driver ad7314_driver = { | 160 | static struct spi_driver ad7314_driver = { |
| 161 | .driver = { | 161 | .driver = { |
| 162 | .name = "ad7314", | 162 | .name = "ad7314", |
| 163 | .bus = &spi_bus_type, | ||
| 164 | .owner = THIS_MODULE, | 163 | .owner = THIS_MODULE, |
| 165 | }, | 164 | }, |
| 166 | .probe = ad7314_probe, | 165 | .probe = ad7314_probe, |
diff --git a/drivers/hwmon/ads7871.c b/drivers/hwmon/ads7871.c index 52319340e182..04450f8bf5da 100644 --- a/drivers/hwmon/ads7871.c +++ b/drivers/hwmon/ads7871.c | |||
| @@ -227,7 +227,6 @@ static int __devexit ads7871_remove(struct spi_device *spi) | |||
| 227 | static struct spi_driver ads7871_driver = { | 227 | static struct spi_driver ads7871_driver = { |
| 228 | .driver = { | 228 | .driver = { |
| 229 | .name = DEVICE_NAME, | 229 | .name = DEVICE_NAME, |
| 230 | .bus = &spi_bus_type, | ||
| 231 | .owner = THIS_MODULE, | 230 | .owner = THIS_MODULE, |
| 232 | }, | 231 | }, |
| 233 | 232 | ||
diff --git a/drivers/hwmon/exynos4_tmu.c b/drivers/hwmon/exynos4_tmu.c index faa0884f61f6..f2359a0093bd 100644 --- a/drivers/hwmon/exynos4_tmu.c +++ b/drivers/hwmon/exynos4_tmu.c | |||
| @@ -506,17 +506,7 @@ static struct platform_driver exynos4_tmu_driver = { | |||
| 506 | .resume = exynos4_tmu_resume, | 506 | .resume = exynos4_tmu_resume, |
| 507 | }; | 507 | }; |
| 508 | 508 | ||
| 509 | static int __init exynos4_tmu_driver_init(void) | 509 | module_platform_driver(exynos4_tmu_driver); |
| 510 | { | ||
| 511 | return platform_driver_register(&exynos4_tmu_driver); | ||
| 512 | } | ||
| 513 | module_init(exynos4_tmu_driver_init); | ||
| 514 | |||
| 515 | static void __exit exynos4_tmu_driver_exit(void) | ||
| 516 | { | ||
| 517 | platform_driver_unregister(&exynos4_tmu_driver); | ||
| 518 | } | ||
| 519 | module_exit(exynos4_tmu_driver_exit); | ||
| 520 | 510 | ||
| 521 | MODULE_DESCRIPTION("EXYNOS4 TMU Driver"); | 511 | MODULE_DESCRIPTION("EXYNOS4 TMU Driver"); |
| 522 | MODULE_AUTHOR("Donggeun Kim <dg77.kim@samsung.com>"); | 512 | MODULE_AUTHOR("Donggeun Kim <dg77.kim@samsung.com>"); |
diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c index 89aa9fb743af..9ba38f318ffb 100644 --- a/drivers/hwmon/gpio-fan.c +++ b/drivers/hwmon/gpio-fan.c | |||
| @@ -539,18 +539,7 @@ static struct platform_driver gpio_fan_driver = { | |||
| 539 | }, | 539 | }, |
| 540 | }; | 540 | }; |
| 541 | 541 | ||
| 542 | static int __init gpio_fan_init(void) | 542 | module_platform_driver(gpio_fan_driver); |
| 543 | { | ||
| 544 | return platform_driver_register(&gpio_fan_driver); | ||
| 545 | } | ||
| 546 | |||
| 547 | static void __exit gpio_fan_exit(void) | ||
| 548 | { | ||
| 549 | platform_driver_unregister(&gpio_fan_driver); | ||
| 550 | } | ||
| 551 | |||
| 552 | module_init(gpio_fan_init); | ||
| 553 | module_exit(gpio_fan_exit); | ||
| 554 | 543 | ||
| 555 | MODULE_AUTHOR("Simon Guinot <sguinot@lacie.com>"); | 544 | MODULE_AUTHOR("Simon Guinot <sguinot@lacie.com>"); |
| 556 | MODULE_DESCRIPTION("GPIO FAN driver"); | 545 | MODULE_DESCRIPTION("GPIO FAN driver"); |
diff --git a/drivers/hwmon/jz4740-hwmon.c b/drivers/hwmon/jz4740-hwmon.c index fea292d43407..5253d23361d9 100644 --- a/drivers/hwmon/jz4740-hwmon.c +++ b/drivers/hwmon/jz4740-hwmon.c | |||
| @@ -59,7 +59,7 @@ static ssize_t jz4740_hwmon_read_adcin(struct device *dev, | |||
| 59 | { | 59 | { |
| 60 | struct jz4740_hwmon *hwmon = dev_get_drvdata(dev); | 60 | struct jz4740_hwmon *hwmon = dev_get_drvdata(dev); |
| 61 | struct completion *completion = &hwmon->read_completion; | 61 | struct completion *completion = &hwmon->read_completion; |
| 62 | unsigned long t; | 62 | long t; |
| 63 | unsigned long val; | 63 | unsigned long val; |
| 64 | int ret; | 64 | int ret; |
| 65 | 65 | ||
| @@ -203,7 +203,7 @@ static int __devexit jz4740_hwmon_remove(struct platform_device *pdev) | |||
| 203 | return 0; | 203 | return 0; |
| 204 | } | 204 | } |
| 205 | 205 | ||
| 206 | struct platform_driver jz4740_hwmon_driver = { | 206 | static struct platform_driver jz4740_hwmon_driver = { |
| 207 | .probe = jz4740_hwmon_probe, | 207 | .probe = jz4740_hwmon_probe, |
| 208 | .remove = __devexit_p(jz4740_hwmon_remove), | 208 | .remove = __devexit_p(jz4740_hwmon_remove), |
| 209 | .driver = { | 209 | .driver = { |
| @@ -212,17 +212,7 @@ struct platform_driver jz4740_hwmon_driver = { | |||
| 212 | }, | 212 | }, |
| 213 | }; | 213 | }; |
| 214 | 214 | ||
| 215 | static int __init jz4740_hwmon_init(void) | 215 | module_platform_driver(jz4740_hwmon_driver); |
| 216 | { | ||
| 217 | return platform_driver_register(&jz4740_hwmon_driver); | ||
| 218 | } | ||
| 219 | module_init(jz4740_hwmon_init); | ||
| 220 | |||
| 221 | static void __exit jz4740_hwmon_exit(void) | ||
| 222 | { | ||
| 223 | platform_driver_unregister(&jz4740_hwmon_driver); | ||
| 224 | } | ||
| 225 | module_exit(jz4740_hwmon_exit); | ||
| 226 | 216 | ||
| 227 | MODULE_DESCRIPTION("JZ4740 SoC HWMON driver"); | 217 | MODULE_DESCRIPTION("JZ4740 SoC HWMON driver"); |
| 228 | MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>"); | 218 | MODULE_AUTHOR("Lars-Peter Clausen <lars@metafoo.de>"); |
diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c index eab11615dced..9b382ec2c3bd 100644 --- a/drivers/hwmon/ntc_thermistor.c +++ b/drivers/hwmon/ntc_thermistor.c | |||
| @@ -432,19 +432,7 @@ static struct platform_driver ntc_thermistor_driver = { | |||
| 432 | .id_table = ntc_thermistor_id, | 432 | .id_table = ntc_thermistor_id, |
| 433 | }; | 433 | }; |
| 434 | 434 | ||
| 435 | static int __init ntc_thermistor_init(void) | 435 | module_platform_driver(ntc_thermistor_driver); |
| 436 | { | ||
| 437 | return platform_driver_register(&ntc_thermistor_driver); | ||
| 438 | } | ||
| 439 | |||
| 440 | module_init(ntc_thermistor_init); | ||
| 441 | |||
| 442 | static void __exit ntc_thermistor_cleanup(void) | ||
| 443 | { | ||
| 444 | platform_driver_unregister(&ntc_thermistor_driver); | ||
| 445 | } | ||
| 446 | |||
| 447 | module_exit(ntc_thermistor_cleanup); | ||
| 448 | 436 | ||
| 449 | MODULE_DESCRIPTION("NTC Thermistor Driver"); | 437 | MODULE_DESCRIPTION("NTC Thermistor Driver"); |
| 450 | MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>"); | 438 | MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>"); |
diff --git a/drivers/hwmon/s3c-hwmon.c b/drivers/hwmon/s3c-hwmon.c index b39f52e2752a..f6c26d19f521 100644 --- a/drivers/hwmon/s3c-hwmon.c +++ b/drivers/hwmon/s3c-hwmon.c | |||
| @@ -393,18 +393,7 @@ static struct platform_driver s3c_hwmon_driver = { | |||
| 393 | .remove = __devexit_p(s3c_hwmon_remove), | 393 | .remove = __devexit_p(s3c_hwmon_remove), |
| 394 | }; | 394 | }; |
| 395 | 395 | ||
| 396 | static int __init s3c_hwmon_init(void) | 396 | module_platform_driver(s3c_hwmon_driver); |
| 397 | { | ||
| 398 | return platform_driver_register(&s3c_hwmon_driver); | ||
| 399 | } | ||
| 400 | |||
| 401 | static void __exit s3c_hwmon_exit(void) | ||
| 402 | { | ||
| 403 | platform_driver_unregister(&s3c_hwmon_driver); | ||
| 404 | } | ||
| 405 | |||
| 406 | module_init(s3c_hwmon_init); | ||
| 407 | module_exit(s3c_hwmon_exit); | ||
| 408 | 397 | ||
| 409 | MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>"); | 398 | MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>"); |
| 410 | MODULE_DESCRIPTION("S3C ADC HWMon driver"); | 399 | MODULE_DESCRIPTION("S3C ADC HWMon driver"); |
diff --git a/drivers/hwmon/sch5627.c b/drivers/hwmon/sch5627.c index e3b5c6039c25..79b6dabe3161 100644 --- a/drivers/hwmon/sch5627.c +++ b/drivers/hwmon/sch5627.c | |||
| @@ -590,19 +590,8 @@ static struct platform_driver sch5627_driver = { | |||
| 590 | .remove = sch5627_remove, | 590 | .remove = sch5627_remove, |
| 591 | }; | 591 | }; |
| 592 | 592 | ||
| 593 | static int __init sch5627_init(void) | 593 | module_platform_driver(sch5627_driver); |
| 594 | { | ||
| 595 | return platform_driver_register(&sch5627_driver); | ||
| 596 | } | ||
| 597 | |||
| 598 | static void __exit sch5627_exit(void) | ||
| 599 | { | ||
| 600 | platform_driver_unregister(&sch5627_driver); | ||
| 601 | } | ||
| 602 | 594 | ||
| 603 | MODULE_DESCRIPTION("SMSC SCH5627 Hardware Monitoring Driver"); | 595 | MODULE_DESCRIPTION("SMSC SCH5627 Hardware Monitoring Driver"); |
| 604 | MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); | 596 | MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); |
| 605 | MODULE_LICENSE("GPL"); | 597 | MODULE_LICENSE("GPL"); |
| 606 | |||
| 607 | module_init(sch5627_init); | ||
| 608 | module_exit(sch5627_exit); | ||
diff --git a/drivers/hwmon/sch5636.c b/drivers/hwmon/sch5636.c index 244407aa79fc..9d5236fb09b4 100644 --- a/drivers/hwmon/sch5636.c +++ b/drivers/hwmon/sch5636.c | |||
| @@ -521,19 +521,8 @@ static struct platform_driver sch5636_driver = { | |||
| 521 | .remove = sch5636_remove, | 521 | .remove = sch5636_remove, |
| 522 | }; | 522 | }; |
| 523 | 523 | ||
| 524 | static int __init sch5636_init(void) | 524 | module_platform_driver(sch5636_driver); |
| 525 | { | ||
| 526 | return platform_driver_register(&sch5636_driver); | ||
| 527 | } | ||
| 528 | |||
| 529 | static void __exit sch5636_exit(void) | ||
| 530 | { | ||
| 531 | platform_driver_unregister(&sch5636_driver); | ||
| 532 | } | ||
| 533 | 525 | ||
| 534 | MODULE_DESCRIPTION("SMSC SCH5636 Hardware Monitoring Driver"); | 526 | MODULE_DESCRIPTION("SMSC SCH5636 Hardware Monitoring Driver"); |
| 535 | MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); | 527 | MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>"); |
| 536 | MODULE_LICENSE("GPL"); | 528 | MODULE_LICENSE("GPL"); |
| 537 | |||
| 538 | module_init(sch5636_init); | ||
| 539 | module_exit(sch5636_exit); | ||
diff --git a/drivers/hwmon/twl4030-madc-hwmon.c b/drivers/hwmon/twl4030-madc-hwmon.c index 57240740b161..0018c7dd0097 100644 --- a/drivers/hwmon/twl4030-madc-hwmon.c +++ b/drivers/hwmon/twl4030-madc-hwmon.c | |||
| @@ -136,19 +136,7 @@ static struct platform_driver twl4030_madc_hwmon_driver = { | |||
| 136 | }, | 136 | }, |
| 137 | }; | 137 | }; |
| 138 | 138 | ||
| 139 | static int __init twl4030_madc_hwmon_init(void) | 139 | module_platform_driver(twl4030_madc_hwmon_driver); |
| 140 | { | ||
| 141 | return platform_driver_register(&twl4030_madc_hwmon_driver); | ||
| 142 | } | ||
| 143 | |||
| 144 | module_init(twl4030_madc_hwmon_init); | ||
| 145 | |||
| 146 | static void __exit twl4030_madc_hwmon_exit(void) | ||
| 147 | { | ||
| 148 | platform_driver_unregister(&twl4030_madc_hwmon_driver); | ||
| 149 | } | ||
| 150 | |||
| 151 | module_exit(twl4030_madc_hwmon_exit); | ||
| 152 | 140 | ||
| 153 | MODULE_DESCRIPTION("TWL4030 ADC Hwmon driver"); | 141 | MODULE_DESCRIPTION("TWL4030 ADC Hwmon driver"); |
| 154 | MODULE_LICENSE("GPL"); | 142 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/hwmon/ultra45_env.c b/drivers/hwmon/ultra45_env.c index 3cd07bf42dca..b9a87e89bab4 100644 --- a/drivers/hwmon/ultra45_env.c +++ b/drivers/hwmon/ultra45_env.c | |||
| @@ -309,15 +309,4 @@ static struct platform_driver env_driver = { | |||
| 309 | .remove = __devexit_p(env_remove), | 309 | .remove = __devexit_p(env_remove), |
| 310 | }; | 310 | }; |
| 311 | 311 | ||
| 312 | static int __init env_init(void) | 312 | module_platform_driver(env_driver); |
| 313 | { | ||
| 314 | return platform_driver_register(&env_driver); | ||
| 315 | } | ||
| 316 | |||
| 317 | static void __exit env_exit(void) | ||
| 318 | { | ||
| 319 | platform_driver_unregister(&env_driver); | ||
| 320 | } | ||
| 321 | |||
| 322 | module_init(env_init); | ||
| 323 | module_exit(env_exit); | ||
diff --git a/drivers/hwmon/wm831x-hwmon.c b/drivers/hwmon/wm831x-hwmon.c index 97b1f834a471..9b598ed26020 100644 --- a/drivers/hwmon/wm831x-hwmon.c +++ b/drivers/hwmon/wm831x-hwmon.c | |||
| @@ -209,17 +209,7 @@ static struct platform_driver wm831x_hwmon_driver = { | |||
| 209 | }, | 209 | }, |
| 210 | }; | 210 | }; |
| 211 | 211 | ||
| 212 | static int __init wm831x_hwmon_init(void) | 212 | module_platform_driver(wm831x_hwmon_driver); |
| 213 | { | ||
| 214 | return platform_driver_register(&wm831x_hwmon_driver); | ||
| 215 | } | ||
| 216 | module_init(wm831x_hwmon_init); | ||
| 217 | |||
| 218 | static void __exit wm831x_hwmon_exit(void) | ||
| 219 | { | ||
| 220 | platform_driver_unregister(&wm831x_hwmon_driver); | ||
| 221 | } | ||
| 222 | module_exit(wm831x_hwmon_exit); | ||
| 223 | 213 | ||
| 224 | MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>"); | 214 | MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>"); |
| 225 | MODULE_DESCRIPTION("WM831x Hardware Monitoring"); | 215 | MODULE_DESCRIPTION("WM831x Hardware Monitoring"); |
diff --git a/drivers/hwmon/wm8350-hwmon.c b/drivers/hwmon/wm8350-hwmon.c index 13290595ca86..3ff67edbdc44 100644 --- a/drivers/hwmon/wm8350-hwmon.c +++ b/drivers/hwmon/wm8350-hwmon.c | |||
| @@ -133,17 +133,7 @@ static struct platform_driver wm8350_hwmon_driver = { | |||
| 133 | }, | 133 | }, |
| 134 | }; | 134 | }; |
| 135 | 135 | ||
| 136 | static int __init wm8350_hwmon_init(void) | 136 | module_platform_driver(wm8350_hwmon_driver); |
| 137 | { | ||
| 138 | return platform_driver_register(&wm8350_hwmon_driver); | ||
| 139 | } | ||
| 140 | module_init(wm8350_hwmon_init); | ||
| 141 | |||
| 142 | static void __exit wm8350_hwmon_exit(void) | ||
| 143 | { | ||
| 144 | platform_driver_unregister(&wm8350_hwmon_driver); | ||
| 145 | } | ||
| 146 | module_exit(wm8350_hwmon_exit); | ||
| 147 | 137 | ||
| 148 | MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>"); | 138 | MODULE_AUTHOR("Mark Brown <broonie@opensource.wolfsonmicro.com>"); |
| 149 | MODULE_DESCRIPTION("WM8350 Hardware Monitoring"); | 139 | MODULE_DESCRIPTION("WM8350 Hardware Monitoring"); |
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c index 8cebef49aeac..18936ac9d51c 100644 --- a/drivers/i2c/busses/i2c-eg20t.c +++ b/drivers/i2c/busses/i2c-eg20t.c | |||
| @@ -893,6 +893,13 @@ static int __devinit pch_i2c_probe(struct pci_dev *pdev, | |||
| 893 | /* Set the number of I2C channel instance */ | 893 | /* Set the number of I2C channel instance */ |
| 894 | adap_info->ch_num = id->driver_data; | 894 | adap_info->ch_num = id->driver_data; |
| 895 | 895 | ||
| 896 | ret = request_irq(pdev->irq, pch_i2c_handler, IRQF_SHARED, | ||
| 897 | KBUILD_MODNAME, adap_info); | ||
| 898 | if (ret) { | ||
| 899 | pch_pci_err(pdev, "request_irq FAILED\n"); | ||
| 900 | goto err_request_irq; | ||
| 901 | } | ||
| 902 | |||
| 896 | for (i = 0; i < adap_info->ch_num; i++) { | 903 | for (i = 0; i < adap_info->ch_num; i++) { |
| 897 | pch_adap = &adap_info->pch_data[i].pch_adapter; | 904 | pch_adap = &adap_info->pch_data[i].pch_adapter; |
| 898 | adap_info->pch_i2c_suspended = false; | 905 | adap_info->pch_i2c_suspended = false; |
| @@ -910,28 +917,23 @@ static int __devinit pch_i2c_probe(struct pci_dev *pdev, | |||
| 910 | 917 | ||
| 911 | pch_adap->dev.parent = &pdev->dev; | 918 | pch_adap->dev.parent = &pdev->dev; |
| 912 | 919 | ||
| 920 | pch_i2c_init(&adap_info->pch_data[i]); | ||
| 913 | ret = i2c_add_adapter(pch_adap); | 921 | ret = i2c_add_adapter(pch_adap); |
| 914 | if (ret) { | 922 | if (ret) { |
| 915 | pch_pci_err(pdev, "i2c_add_adapter[ch:%d] FAILED\n", i); | 923 | pch_pci_err(pdev, "i2c_add_adapter[ch:%d] FAILED\n", i); |
| 916 | goto err_i2c_add_adapter; | 924 | goto err_add_adapter; |
| 917 | } | 925 | } |
| 918 | |||
| 919 | pch_i2c_init(&adap_info->pch_data[i]); | ||
| 920 | } | ||
| 921 | ret = request_irq(pdev->irq, pch_i2c_handler, IRQF_SHARED, | ||
| 922 | KBUILD_MODNAME, adap_info); | ||
| 923 | if (ret) { | ||
| 924 | pch_pci_err(pdev, "request_irq FAILED\n"); | ||
| 925 | goto err_i2c_add_adapter; | ||
| 926 | } | 926 | } |
| 927 | 927 | ||
| 928 | pci_set_drvdata(pdev, adap_info); | 928 | pci_set_drvdata(pdev, adap_info); |
| 929 | pch_pci_dbg(pdev, "returns %d.\n", ret); | 929 | pch_pci_dbg(pdev, "returns %d.\n", ret); |
| 930 | return 0; | 930 | return 0; |
| 931 | 931 | ||
| 932 | err_i2c_add_adapter: | 932 | err_add_adapter: |
| 933 | for (j = 0; j < i; j++) | 933 | for (j = 0; j < i; j++) |
| 934 | i2c_del_adapter(&adap_info->pch_data[j].pch_adapter); | 934 | i2c_del_adapter(&adap_info->pch_data[j].pch_adapter); |
| 935 | free_irq(pdev->irq, adap_info); | ||
| 936 | err_request_irq: | ||
| 935 | pci_iounmap(pdev, base_addr); | 937 | pci_iounmap(pdev, base_addr); |
| 936 | err_pci_iomap: | 938 | err_pci_iomap: |
| 937 | pci_release_regions(pdev); | 939 | pci_release_regions(pdev); |
diff --git a/drivers/i2c/busses/i2c-nuc900.c b/drivers/i2c/busses/i2c-nuc900.c index 835e47b39bc2..03b615778887 100644 --- a/drivers/i2c/busses/i2c-nuc900.c +++ b/drivers/i2c/busses/i2c-nuc900.c | |||
| @@ -593,7 +593,7 @@ static int __devinit nuc900_i2c_probe(struct platform_device *pdev) | |||
| 593 | i2c->adap.algo_data = i2c; | 593 | i2c->adap.algo_data = i2c; |
| 594 | i2c->adap.dev.parent = &pdev->dev; | 594 | i2c->adap.dev.parent = &pdev->dev; |
| 595 | 595 | ||
| 596 | mfp_set_groupg(&pdev->dev); | 596 | mfp_set_groupg(&pdev->dev, NULL); |
| 597 | 597 | ||
| 598 | clk_get_rate(i2c->clk); | 598 | clk_get_rate(i2c->clk); |
| 599 | 599 | ||
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index a43d0023446a..fa23faa20f0e 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c | |||
| @@ -1047,13 +1047,14 @@ omap_i2c_probe(struct platform_device *pdev) | |||
| 1047 | * size. This is to ensure that we can handle the status on int | 1047 | * size. This is to ensure that we can handle the status on int |
| 1048 | * call back latencies. | 1048 | * call back latencies. |
| 1049 | */ | 1049 | */ |
| 1050 | if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) { | 1050 | |
| 1051 | dev->fifo_size = 0; | 1051 | dev->fifo_size = (dev->fifo_size / 2); |
| 1052 | |||
| 1053 | if (dev->rev >= OMAP_I2C_REV_ON_3530_4430) | ||
| 1052 | dev->b_hw = 0; /* Disable hardware fixes */ | 1054 | dev->b_hw = 0; /* Disable hardware fixes */ |
| 1053 | } else { | 1055 | else |
| 1054 | dev->fifo_size = (dev->fifo_size / 2); | ||
| 1055 | dev->b_hw = 1; /* Enable hardware fixes */ | 1056 | dev->b_hw = 1; /* Enable hardware fixes */ |
| 1056 | } | 1057 | |
| 1057 | /* calculate wakeup latency constraint for MPU */ | 1058 | /* calculate wakeup latency constraint for MPU */ |
| 1058 | if (dev->set_mpu_wkup_lat != NULL) | 1059 | if (dev->set_mpu_wkup_lat != NULL) |
| 1059 | dev->latency = (1000000 * dev->fifo_size) / | 1060 | dev->latency = (1000000 * dev->fifo_size) / |
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 2754cef86a06..4c1718081685 100644 --- a/drivers/i2c/busses/i2c-s3c2410.c +++ b/drivers/i2c/busses/i2c-s3c2410.c | |||
| @@ -534,6 +534,7 @@ static int s3c24xx_i2c_doxfer(struct s3c24xx_i2c *i2c, | |||
| 534 | 534 | ||
| 535 | /* first, try busy waiting briefly */ | 535 | /* first, try busy waiting briefly */ |
| 536 | do { | 536 | do { |
| 537 | cpu_relax(); | ||
| 537 | iicstat = readl(i2c->regs + S3C2410_IICSTAT); | 538 | iicstat = readl(i2c->regs + S3C2410_IICSTAT); |
| 538 | } while ((iicstat & S3C2410_IICSTAT_START) && --spins); | 539 | } while ((iicstat & S3C2410_IICSTAT_START) && --spins); |
| 539 | 540 | ||
| @@ -786,7 +787,7 @@ static void s3c24xx_i2c_dt_gpio_free(struct s3c24xx_i2c *i2c) | |||
| 786 | #else | 787 | #else |
| 787 | static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c) | 788 | static int s3c24xx_i2c_parse_dt_gpio(struct s3c24xx_i2c *i2c) |
| 788 | { | 789 | { |
| 789 | return -EINVAL; | 790 | return 0; |
| 790 | } | 791 | } |
| 791 | 792 | ||
| 792 | static void s3c24xx_i2c_dt_gpio_free(struct s3c24xx_i2c *i2c) | 793 | static void s3c24xx_i2c_dt_gpio_free(struct s3c24xx_i2c *i2c) |
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 691276bafd78..e9cf51b1343b 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c | |||
| @@ -216,7 +216,9 @@ static int addr4_resolve(struct sockaddr_in *src_in, | |||
| 216 | 216 | ||
| 217 | neigh = neigh_lookup(&arp_tbl, &rt->rt_gateway, rt->dst.dev); | 217 | neigh = neigh_lookup(&arp_tbl, &rt->rt_gateway, rt->dst.dev); |
| 218 | if (!neigh || !(neigh->nud_state & NUD_VALID)) { | 218 | if (!neigh || !(neigh->nud_state & NUD_VALID)) { |
| 219 | rcu_read_lock(); | ||
| 219 | neigh_event_send(dst_get_neighbour(&rt->dst), NULL); | 220 | neigh_event_send(dst_get_neighbour(&rt->dst), NULL); |
| 221 | rcu_read_unlock(); | ||
| 220 | ret = -ENODATA; | 222 | ret = -ENODATA; |
| 221 | if (neigh) | 223 | if (neigh) |
| 222 | goto release; | 224 | goto release; |
| @@ -274,15 +276,16 @@ static int addr6_resolve(struct sockaddr_in6 *src_in, | |||
| 274 | goto put; | 276 | goto put; |
| 275 | } | 277 | } |
| 276 | 278 | ||
| 279 | rcu_read_lock(); | ||
| 277 | neigh = dst_get_neighbour(dst); | 280 | neigh = dst_get_neighbour(dst); |
| 278 | if (!neigh || !(neigh->nud_state & NUD_VALID)) { | 281 | if (!neigh || !(neigh->nud_state & NUD_VALID)) { |
| 279 | if (neigh) | 282 | if (neigh) |
| 280 | neigh_event_send(neigh, NULL); | 283 | neigh_event_send(neigh, NULL); |
| 281 | ret = -ENODATA; | 284 | ret = -ENODATA; |
| 282 | goto put; | 285 | } else { |
| 286 | ret = rdma_copy_addr(addr, dst->dev, neigh->ha); | ||
| 283 | } | 287 | } |
| 284 | 288 | rcu_read_unlock(); | |
| 285 | ret = rdma_copy_addr(addr, dst->dev, neigh->ha); | ||
| 286 | put: | 289 | put: |
| 287 | dst_release(dst); | 290 | dst_release(dst); |
| 288 | return ret; | 291 | return ret; |
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c index de6d0774e609..c88b12beef25 100644 --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c | |||
| @@ -1375,8 +1375,10 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx) | |||
| 1375 | goto reject; | 1375 | goto reject; |
| 1376 | } | 1376 | } |
| 1377 | dst = &rt->dst; | 1377 | dst = &rt->dst; |
| 1378 | rcu_read_lock(); | ||
| 1378 | neigh = dst_get_neighbour(dst); | 1379 | neigh = dst_get_neighbour(dst); |
| 1379 | l2t = t3_l2t_get(tdev, neigh, neigh->dev); | 1380 | l2t = t3_l2t_get(tdev, neigh, neigh->dev); |
| 1381 | rcu_read_unlock(); | ||
| 1380 | if (!l2t) { | 1382 | if (!l2t) { |
| 1381 | printk(KERN_ERR MOD "%s - failed to allocate l2t entry!\n", | 1383 | printk(KERN_ERR MOD "%s - failed to allocate l2t entry!\n", |
| 1382 | __func__); | 1384 | __func__); |
| @@ -1946,10 +1948,12 @@ int iwch_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) | |||
| 1946 | } | 1948 | } |
| 1947 | ep->dst = &rt->dst; | 1949 | ep->dst = &rt->dst; |
| 1948 | 1950 | ||
| 1951 | rcu_read_lock(); | ||
| 1949 | neigh = dst_get_neighbour(ep->dst); | 1952 | neigh = dst_get_neighbour(ep->dst); |
| 1950 | 1953 | ||
| 1951 | /* get a l2t entry */ | 1954 | /* get a l2t entry */ |
| 1952 | ep->l2t = t3_l2t_get(ep->com.tdev, neigh, neigh->dev); | 1955 | ep->l2t = t3_l2t_get(ep->com.tdev, neigh, neigh->dev); |
| 1956 | rcu_read_unlock(); | ||
| 1953 | if (!ep->l2t) { | 1957 | if (!ep->l2t) { |
| 1954 | printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); | 1958 | printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); |
| 1955 | err = -ENOMEM; | 1959 | err = -ENOMEM; |
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index b36cdac9c558..0747004313ad 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infiniband/hw/cxgb4/cm.c | |||
| @@ -542,8 +542,10 @@ static void send_mpa_req(struct c4iw_ep *ep, struct sk_buff *skb, | |||
| 542 | (mpa_rev_to_use == 2 ? MPA_ENHANCED_RDMA_CONN : 0); | 542 | (mpa_rev_to_use == 2 ? MPA_ENHANCED_RDMA_CONN : 0); |
| 543 | mpa->private_data_size = htons(ep->plen); | 543 | mpa->private_data_size = htons(ep->plen); |
| 544 | mpa->revision = mpa_rev_to_use; | 544 | mpa->revision = mpa_rev_to_use; |
| 545 | if (mpa_rev_to_use == 1) | 545 | if (mpa_rev_to_use == 1) { |
| 546 | ep->tried_with_mpa_v1 = 1; | 546 | ep->tried_with_mpa_v1 = 1; |
| 547 | ep->retry_with_mpa_v1 = 0; | ||
| 548 | } | ||
| 547 | 549 | ||
| 548 | if (mpa_rev_to_use == 2) { | 550 | if (mpa_rev_to_use == 2) { |
| 549 | mpa->private_data_size += | 551 | mpa->private_data_size += |
| @@ -1594,6 +1596,7 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb) | |||
| 1594 | goto reject; | 1596 | goto reject; |
| 1595 | } | 1597 | } |
| 1596 | dst = &rt->dst; | 1598 | dst = &rt->dst; |
| 1599 | rcu_read_lock(); | ||
| 1597 | neigh = dst_get_neighbour(dst); | 1600 | neigh = dst_get_neighbour(dst); |
| 1598 | if (neigh->dev->flags & IFF_LOOPBACK) { | 1601 | if (neigh->dev->flags & IFF_LOOPBACK) { |
| 1599 | pdev = ip_dev_find(&init_net, peer_ip); | 1602 | pdev = ip_dev_find(&init_net, peer_ip); |
| @@ -1620,6 +1623,7 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb) | |||
| 1620 | rss_qid = dev->rdev.lldi.rxq_ids[ | 1623 | rss_qid = dev->rdev.lldi.rxq_ids[ |
| 1621 | cxgb4_port_idx(neigh->dev) * step]; | 1624 | cxgb4_port_idx(neigh->dev) * step]; |
| 1622 | } | 1625 | } |
| 1626 | rcu_read_unlock(); | ||
| 1623 | if (!l2t) { | 1627 | if (!l2t) { |
| 1624 | printk(KERN_ERR MOD "%s - failed to allocate l2t entry!\n", | 1628 | printk(KERN_ERR MOD "%s - failed to allocate l2t entry!\n", |
| 1625 | __func__); | 1629 | __func__); |
| @@ -1820,6 +1824,7 @@ static int c4iw_reconnect(struct c4iw_ep *ep) | |||
| 1820 | } | 1824 | } |
| 1821 | ep->dst = &rt->dst; | 1825 | ep->dst = &rt->dst; |
| 1822 | 1826 | ||
| 1827 | rcu_read_lock(); | ||
| 1823 | neigh = dst_get_neighbour(ep->dst); | 1828 | neigh = dst_get_neighbour(ep->dst); |
| 1824 | 1829 | ||
| 1825 | /* get a l2t entry */ | 1830 | /* get a l2t entry */ |
| @@ -1856,6 +1861,7 @@ static int c4iw_reconnect(struct c4iw_ep *ep) | |||
| 1856 | ep->rss_qid = ep->com.dev->rdev.lldi.rxq_ids[ | 1861 | ep->rss_qid = ep->com.dev->rdev.lldi.rxq_ids[ |
| 1857 | cxgb4_port_idx(neigh->dev) * step]; | 1862 | cxgb4_port_idx(neigh->dev) * step]; |
| 1858 | } | 1863 | } |
| 1864 | rcu_read_unlock(); | ||
| 1859 | if (!ep->l2t) { | 1865 | if (!ep->l2t) { |
| 1860 | printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); | 1866 | printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); |
| 1861 | err = -ENOMEM; | 1867 | err = -ENOMEM; |
| @@ -2301,6 +2307,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) | |||
| 2301 | } | 2307 | } |
| 2302 | ep->dst = &rt->dst; | 2308 | ep->dst = &rt->dst; |
| 2303 | 2309 | ||
| 2310 | rcu_read_lock(); | ||
| 2304 | neigh = dst_get_neighbour(ep->dst); | 2311 | neigh = dst_get_neighbour(ep->dst); |
| 2305 | 2312 | ||
| 2306 | /* get a l2t entry */ | 2313 | /* get a l2t entry */ |
| @@ -2339,6 +2346,7 @@ int c4iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) | |||
| 2339 | ep->retry_with_mpa_v1 = 0; | 2346 | ep->retry_with_mpa_v1 = 0; |
| 2340 | ep->tried_with_mpa_v1 = 0; | 2347 | ep->tried_with_mpa_v1 = 0; |
| 2341 | } | 2348 | } |
| 2349 | rcu_read_unlock(); | ||
| 2342 | if (!ep->l2t) { | 2350 | if (!ep->l2t) { |
| 2343 | printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); | 2351 | printk(KERN_ERR MOD "%s - cannot alloc l2e.\n", __func__); |
| 2344 | err = -ENOMEM; | 2352 | err = -ENOMEM; |
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c index f35a935267e7..0f1607c8325a 100644 --- a/drivers/infiniband/hw/cxgb4/cq.c +++ b/drivers/infiniband/hw/cxgb4/cq.c | |||
| @@ -311,7 +311,7 @@ void c4iw_count_rcqes(struct t4_cq *cq, struct t4_wq *wq, int *count) | |||
| 311 | while (ptr != cq->sw_pidx) { | 311 | while (ptr != cq->sw_pidx) { |
| 312 | cqe = &cq->sw_queue[ptr]; | 312 | cqe = &cq->sw_queue[ptr]; |
| 313 | if (RQ_TYPE(cqe) && (CQE_OPCODE(cqe) != FW_RI_READ_RESP) && | 313 | if (RQ_TYPE(cqe) && (CQE_OPCODE(cqe) != FW_RI_READ_RESP) && |
| 314 | (CQE_QPID(cqe) == wq->rq.qid) && cqe_completes_wr(cqe, wq)) | 314 | (CQE_QPID(cqe) == wq->sq.qid) && cqe_completes_wr(cqe, wq)) |
| 315 | (*count)++; | 315 | (*count)++; |
| 316 | if (++ptr == cq->size) | 316 | if (++ptr == cq->size) |
| 317 | ptr = 0; | 317 | ptr = 0; |
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index dfce9ea98a39..0a52d72371ee 100644 --- a/drivers/infiniband/hw/nes/nes_cm.c +++ b/drivers/infiniband/hw/nes/nes_cm.c | |||
| @@ -1377,9 +1377,11 @@ static int nes_addr_resolve_neigh(struct nes_vnic *nesvnic, u32 dst_ip, int arpi | |||
| 1377 | neigh_release(neigh); | 1377 | neigh_release(neigh); |
| 1378 | } | 1378 | } |
| 1379 | 1379 | ||
| 1380 | if ((neigh == NULL) || (!(neigh->nud_state & NUD_VALID))) | 1380 | if ((neigh == NULL) || (!(neigh->nud_state & NUD_VALID))) { |
| 1381 | rcu_read_lock(); | ||
| 1381 | neigh_event_send(dst_get_neighbour(&rt->dst), NULL); | 1382 | neigh_event_send(dst_get_neighbour(&rt->dst), NULL); |
| 1382 | 1383 | rcu_read_unlock(); | |
| 1384 | } | ||
| 1383 | ip_rt_put(rt); | 1385 | ip_rt_put(rt); |
| 1384 | return rc; | 1386 | return rc; |
| 1385 | } | 1387 | } |
diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib/qib_iba7322.c index 5bd2162b95dc..1d5895941e19 100644 --- a/drivers/infiniband/hw/qib/qib_iba7322.c +++ b/drivers/infiniband/hw/qib/qib_iba7322.c | |||
| @@ -2307,19 +2307,11 @@ static int qib_7322_bringup_serdes(struct qib_pportdata *ppd) | |||
| 2307 | SYM_LSB(IBCCtrlA_0, MaxPktLen); | 2307 | SYM_LSB(IBCCtrlA_0, MaxPktLen); |
| 2308 | ppd->cpspec->ibcctrl_a = ibc; /* without linkcmd or linkinitcmd! */ | 2308 | ppd->cpspec->ibcctrl_a = ibc; /* without linkcmd or linkinitcmd! */ |
| 2309 | 2309 | ||
| 2310 | /* initially come up waiting for TS1, without sending anything. */ | ||
| 2311 | val = ppd->cpspec->ibcctrl_a | (QLOGIC_IB_IBCC_LINKINITCMD_DISABLE << | ||
| 2312 | QLOGIC_IB_IBCC_LINKINITCMD_SHIFT); | ||
| 2313 | |||
| 2314 | ppd->cpspec->ibcctrl_a = val; | ||
| 2315 | /* | 2310 | /* |
| 2316 | * Reset the PCS interface to the serdes (and also ibc, which is still | 2311 | * Reset the PCS interface to the serdes (and also ibc, which is still |
| 2317 | * in reset from above). Writes new value of ibcctrl_a as last step. | 2312 | * in reset from above). Writes new value of ibcctrl_a as last step. |
| 2318 | */ | 2313 | */ |
| 2319 | qib_7322_mini_pcs_reset(ppd); | 2314 | qib_7322_mini_pcs_reset(ppd); |
| 2320 | qib_write_kreg(dd, kr_scratch, 0ULL); | ||
| 2321 | /* clear the linkinit cmds */ | ||
| 2322 | ppd->cpspec->ibcctrl_a &= ~SYM_MASK(IBCCtrlA_0, LinkInitCmd); | ||
| 2323 | 2315 | ||
| 2324 | if (!ppd->cpspec->ibcctrl_b) { | 2316 | if (!ppd->cpspec->ibcctrl_b) { |
| 2325 | unsigned lse = ppd->link_speed_enabled; | 2317 | unsigned lse = ppd->link_speed_enabled; |
| @@ -2385,6 +2377,14 @@ static int qib_7322_bringup_serdes(struct qib_pportdata *ppd) | |||
| 2385 | ppd->cpspec->ibcctrl_a |= SYM_MASK(IBCCtrlA_0, IBLinkEn); | 2377 | ppd->cpspec->ibcctrl_a |= SYM_MASK(IBCCtrlA_0, IBLinkEn); |
| 2386 | set_vls(ppd); | 2378 | set_vls(ppd); |
| 2387 | 2379 | ||
| 2380 | /* initially come up DISABLED, without sending anything. */ | ||
| 2381 | val = ppd->cpspec->ibcctrl_a | (QLOGIC_IB_IBCC_LINKINITCMD_DISABLE << | ||
| 2382 | QLOGIC_IB_IBCC_LINKINITCMD_SHIFT); | ||
| 2383 | qib_write_kreg_port(ppd, krp_ibcctrl_a, val); | ||
| 2384 | qib_write_kreg(dd, kr_scratch, 0ULL); | ||
| 2385 | /* clear the linkinit cmds */ | ||
| 2386 | ppd->cpspec->ibcctrl_a = val & ~SYM_MASK(IBCCtrlA_0, LinkInitCmd); | ||
| 2387 | |||
| 2388 | /* be paranoid against later code motion, etc. */ | 2388 | /* be paranoid against later code motion, etc. */ |
| 2389 | spin_lock_irqsave(&dd->cspec->rcvmod_lock, flags); | 2389 | spin_lock_irqsave(&dd->cspec->rcvmod_lock, flags); |
| 2390 | ppd->p_rcvctrl |= SYM_MASK(RcvCtrl_0, RcvIBPortEnable); | 2390 | ppd->p_rcvctrl |= SYM_MASK(RcvCtrl_0, RcvIBPortEnable); |
| @@ -5241,7 +5241,7 @@ static int qib_7322_ib_updown(struct qib_pportdata *ppd, int ibup, u64 ibcs) | |||
| 5241 | off */ | 5241 | off */ |
| 5242 | if (ppd->dd->flags & QIB_HAS_QSFP) { | 5242 | if (ppd->dd->flags & QIB_HAS_QSFP) { |
| 5243 | qd->t_insert = get_jiffies_64(); | 5243 | qd->t_insert = get_jiffies_64(); |
| 5244 | schedule_work(&qd->work); | 5244 | queue_work(ib_wq, &qd->work); |
| 5245 | } | 5245 | } |
| 5246 | spin_lock_irqsave(&ppd->sdma_lock, flags); | 5246 | spin_lock_irqsave(&ppd->sdma_lock, flags); |
| 5247 | if (__qib_sdma_running(ppd)) | 5247 | if (__qib_sdma_running(ppd)) |
diff --git a/drivers/infiniband/hw/qib/qib_qsfp.c b/drivers/infiniband/hw/qib/qib_qsfp.c index e06c4ed383f1..fa71b1e666c5 100644 --- a/drivers/infiniband/hw/qib/qib_qsfp.c +++ b/drivers/infiniband/hw/qib/qib_qsfp.c | |||
| @@ -480,18 +480,6 @@ void qib_qsfp_init(struct qib_qsfp_data *qd, | |||
| 480 | udelay(20); /* Generous RST dwell */ | 480 | udelay(20); /* Generous RST dwell */ |
| 481 | 481 | ||
| 482 | dd->f_gpio_mod(dd, mask, mask, mask); | 482 | dd->f_gpio_mod(dd, mask, mask, mask); |
| 483 | /* Spec says module can take up to two seconds! */ | ||
| 484 | mask = QSFP_GPIO_MOD_PRS_N; | ||
| 485 | if (qd->ppd->hw_pidx) | ||
| 486 | mask <<= QSFP_GPIO_PORT2_SHIFT; | ||
| 487 | |||
| 488 | /* Do not try to wait here. Better to let event handle it */ | ||
| 489 | if (!qib_qsfp_mod_present(qd->ppd)) | ||
| 490 | goto bail; | ||
| 491 | /* We see a module, but it may be unwise to look yet. Just schedule */ | ||
| 492 | qd->t_insert = get_jiffies_64(); | ||
| 493 | queue_work(ib_wq, &qd->work); | ||
| 494 | bail: | ||
| 495 | return; | 483 | return; |
| 496 | } | 484 | } |
| 497 | 485 | ||
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index 0ef9af94997d..4115be54ba3b 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c | |||
| @@ -57,21 +57,24 @@ struct ipoib_ah *ipoib_create_ah(struct net_device *dev, | |||
| 57 | struct ib_pd *pd, struct ib_ah_attr *attr) | 57 | struct ib_pd *pd, struct ib_ah_attr *attr) |
| 58 | { | 58 | { |
| 59 | struct ipoib_ah *ah; | 59 | struct ipoib_ah *ah; |
| 60 | struct ib_ah *vah; | ||
| 60 | 61 | ||
| 61 | ah = kmalloc(sizeof *ah, GFP_KERNEL); | 62 | ah = kmalloc(sizeof *ah, GFP_KERNEL); |
| 62 | if (!ah) | 63 | if (!ah) |
| 63 | return NULL; | 64 | return ERR_PTR(-ENOMEM); |
| 64 | 65 | ||
| 65 | ah->dev = dev; | 66 | ah->dev = dev; |
| 66 | ah->last_send = 0; | 67 | ah->last_send = 0; |
| 67 | kref_init(&ah->ref); | 68 | kref_init(&ah->ref); |
| 68 | 69 | ||
| 69 | ah->ah = ib_create_ah(pd, attr); | 70 | vah = ib_create_ah(pd, attr); |
| 70 | if (IS_ERR(ah->ah)) { | 71 | if (IS_ERR(vah)) { |
| 71 | kfree(ah); | 72 | kfree(ah); |
| 72 | ah = NULL; | 73 | ah = (struct ipoib_ah *)vah; |
| 73 | } else | 74 | } else { |
| 75 | ah->ah = vah; | ||
| 74 | ipoib_dbg(netdev_priv(dev), "Created ah %p\n", ah->ah); | 76 | ipoib_dbg(netdev_priv(dev), "Created ah %p\n", ah->ah); |
| 77 | } | ||
| 75 | 78 | ||
| 76 | return ah; | 79 | return ah; |
| 77 | } | 80 | } |
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 7567b6000230..83695b48b010 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c | |||
| @@ -432,7 +432,7 @@ static void path_rec_completion(int status, | |||
| 432 | 432 | ||
| 433 | spin_lock_irqsave(&priv->lock, flags); | 433 | spin_lock_irqsave(&priv->lock, flags); |
| 434 | 434 | ||
| 435 | if (ah) { | 435 | if (!IS_ERR_OR_NULL(ah)) { |
| 436 | path->pathrec = *pathrec; | 436 | path->pathrec = *pathrec; |
| 437 | 437 | ||
| 438 | old_ah = path->ah; | 438 | old_ah = path->ah; |
| @@ -555,6 +555,7 @@ static int path_rec_start(struct net_device *dev, | |||
| 555 | return 0; | 555 | return 0; |
| 556 | } | 556 | } |
| 557 | 557 | ||
| 558 | /* called with rcu_read_lock */ | ||
| 558 | static void neigh_add_path(struct sk_buff *skb, struct net_device *dev) | 559 | static void neigh_add_path(struct sk_buff *skb, struct net_device *dev) |
| 559 | { | 560 | { |
| 560 | struct ipoib_dev_priv *priv = netdev_priv(dev); | 561 | struct ipoib_dev_priv *priv = netdev_priv(dev); |
| @@ -636,6 +637,7 @@ err_drop: | |||
| 636 | spin_unlock_irqrestore(&priv->lock, flags); | 637 | spin_unlock_irqrestore(&priv->lock, flags); |
| 637 | } | 638 | } |
| 638 | 639 | ||
| 640 | /* called with rcu_read_lock */ | ||
| 639 | static void ipoib_path_lookup(struct sk_buff *skb, struct net_device *dev) | 641 | static void ipoib_path_lookup(struct sk_buff *skb, struct net_device *dev) |
| 640 | { | 642 | { |
| 641 | struct ipoib_dev_priv *priv = netdev_priv(skb->dev); | 643 | struct ipoib_dev_priv *priv = netdev_priv(skb->dev); |
| @@ -720,13 +722,14 @@ static int ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
| 720 | struct neighbour *n = NULL; | 722 | struct neighbour *n = NULL; |
| 721 | unsigned long flags; | 723 | unsigned long flags; |
| 722 | 724 | ||
| 725 | rcu_read_lock(); | ||
| 723 | if (likely(skb_dst(skb))) | 726 | if (likely(skb_dst(skb))) |
| 724 | n = dst_get_neighbour(skb_dst(skb)); | 727 | n = dst_get_neighbour(skb_dst(skb)); |
| 725 | 728 | ||
| 726 | if (likely(n)) { | 729 | if (likely(n)) { |
| 727 | if (unlikely(!*to_ipoib_neigh(n))) { | 730 | if (unlikely(!*to_ipoib_neigh(n))) { |
| 728 | ipoib_path_lookup(skb, dev); | 731 | ipoib_path_lookup(skb, dev); |
| 729 | return NETDEV_TX_OK; | 732 | goto unlock; |
| 730 | } | 733 | } |
| 731 | 734 | ||
| 732 | neigh = *to_ipoib_neigh(n); | 735 | neigh = *to_ipoib_neigh(n); |
| @@ -749,17 +752,17 @@ static int ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
| 749 | ipoib_neigh_free(dev, neigh); | 752 | ipoib_neigh_free(dev, neigh); |
| 750 | spin_unlock_irqrestore(&priv->lock, flags); | 753 | spin_unlock_irqrestore(&priv->lock, flags); |
| 751 | ipoib_path_lookup(skb, dev); | 754 | ipoib_path_lookup(skb, dev); |
| 752 | return NETDEV_TX_OK; | 755 | goto unlock; |
| 753 | } | 756 | } |
| 754 | 757 | ||
| 755 | if (ipoib_cm_get(neigh)) { | 758 | if (ipoib_cm_get(neigh)) { |
| 756 | if (ipoib_cm_up(neigh)) { | 759 | if (ipoib_cm_up(neigh)) { |
| 757 | ipoib_cm_send(dev, skb, ipoib_cm_get(neigh)); | 760 | ipoib_cm_send(dev, skb, ipoib_cm_get(neigh)); |
| 758 | return NETDEV_TX_OK; | 761 | goto unlock; |
| 759 | } | 762 | } |
| 760 | } else if (neigh->ah) { | 763 | } else if (neigh->ah) { |
| 761 | ipoib_send(dev, skb, neigh->ah, IPOIB_QPN(n->ha)); | 764 | ipoib_send(dev, skb, neigh->ah, IPOIB_QPN(n->ha)); |
| 762 | return NETDEV_TX_OK; | 765 | goto unlock; |
| 763 | } | 766 | } |
| 764 | 767 | ||
| 765 | if (skb_queue_len(&neigh->queue) < IPOIB_MAX_PATH_REC_QUEUE) { | 768 | if (skb_queue_len(&neigh->queue) < IPOIB_MAX_PATH_REC_QUEUE) { |
| @@ -793,13 +796,14 @@ static int ipoib_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
| 793 | phdr->hwaddr + 4); | 796 | phdr->hwaddr + 4); |
| 794 | dev_kfree_skb_any(skb); | 797 | dev_kfree_skb_any(skb); |
| 795 | ++dev->stats.tx_dropped; | 798 | ++dev->stats.tx_dropped; |
| 796 | return NETDEV_TX_OK; | 799 | goto unlock; |
| 797 | } | 800 | } |
| 798 | 801 | ||
| 799 | unicast_arp_send(skb, dev, phdr); | 802 | unicast_arp_send(skb, dev, phdr); |
| 800 | } | 803 | } |
| 801 | } | 804 | } |
| 802 | 805 | unlock: | |
| 806 | rcu_read_unlock(); | ||
| 803 | return NETDEV_TX_OK; | 807 | return NETDEV_TX_OK; |
| 804 | } | 808 | } |
| 805 | 809 | ||
| @@ -837,7 +841,7 @@ static int ipoib_hard_header(struct sk_buff *skb, | |||
| 837 | dst = skb_dst(skb); | 841 | dst = skb_dst(skb); |
| 838 | n = NULL; | 842 | n = NULL; |
| 839 | if (dst) | 843 | if (dst) |
| 840 | n = dst_get_neighbour(dst); | 844 | n = dst_get_neighbour_raw(dst); |
| 841 | if ((!dst || !n) && daddr) { | 845 | if ((!dst || !n) && daddr) { |
| 842 | struct ipoib_pseudoheader *phdr = | 846 | struct ipoib_pseudoheader *phdr = |
| 843 | (struct ipoib_pseudoheader *) skb_push(skb, sizeof *phdr); | 847 | (struct ipoib_pseudoheader *) skb_push(skb, sizeof *phdr); |
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index 1b7a97686356..873bff97e69e 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c | |||
| @@ -240,8 +240,11 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast, | |||
| 240 | av.grh.dgid = mcast->mcmember.mgid; | 240 | av.grh.dgid = mcast->mcmember.mgid; |
| 241 | 241 | ||
| 242 | ah = ipoib_create_ah(dev, priv->pd, &av); | 242 | ah = ipoib_create_ah(dev, priv->pd, &av); |
| 243 | if (!ah) { | 243 | if (IS_ERR(ah)) { |
| 244 | ipoib_warn(priv, "ib_address_create failed\n"); | 244 | ipoib_warn(priv, "ib_address_create failed %ld\n", |
| 245 | -PTR_ERR(ah)); | ||
| 246 | /* use original error */ | ||
| 247 | return PTR_ERR(ah); | ||
| 245 | } else { | 248 | } else { |
| 246 | spin_lock_irq(&priv->lock); | 249 | spin_lock_irq(&priv->lock); |
| 247 | mcast->ah = ah; | 250 | mcast->ah = ah; |
| @@ -266,7 +269,7 @@ static int ipoib_mcast_join_finish(struct ipoib_mcast *mcast, | |||
| 266 | 269 | ||
| 267 | skb->dev = dev; | 270 | skb->dev = dev; |
| 268 | if (dst) | 271 | if (dst) |
| 269 | n = dst_get_neighbour(dst); | 272 | n = dst_get_neighbour_raw(dst); |
| 270 | if (!dst || !n) { | 273 | if (!dst || !n) { |
| 271 | /* put pseudoheader back on for next time */ | 274 | /* put pseudoheader back on for next time */ |
| 272 | skb_push(skb, sizeof (struct ipoib_pseudoheader)); | 275 | skb_push(skb, sizeof (struct ipoib_pseudoheader)); |
| @@ -722,6 +725,8 @@ out: | |||
| 722 | if (mcast && mcast->ah) { | 725 | if (mcast && mcast->ah) { |
| 723 | struct dst_entry *dst = skb_dst(skb); | 726 | struct dst_entry *dst = skb_dst(skb); |
| 724 | struct neighbour *n = NULL; | 727 | struct neighbour *n = NULL; |
| 728 | |||
| 729 | rcu_read_lock(); | ||
| 725 | if (dst) | 730 | if (dst) |
| 726 | n = dst_get_neighbour(dst); | 731 | n = dst_get_neighbour(dst); |
| 727 | if (n && !*to_ipoib_neigh(n)) { | 732 | if (n && !*to_ipoib_neigh(n)) { |
| @@ -734,7 +739,7 @@ out: | |||
| 734 | list_add_tail(&neigh->list, &mcast->neigh_list); | 739 | list_add_tail(&neigh->list, &mcast->neigh_list); |
| 735 | } | 740 | } |
| 736 | } | 741 | } |
| 737 | 742 | rcu_read_unlock(); | |
| 738 | spin_unlock_irqrestore(&priv->lock, flags); | 743 | spin_unlock_irqrestore(&priv->lock, flags); |
| 739 | ipoib_send(dev, skb, mcast->ah, IB_MULTICAST_QPN); | 744 | ipoib_send(dev, skb, mcast->ah, IB_MULTICAST_QPN); |
| 740 | return; | 745 | return; |
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index c0c7820d4c46..bdc447fd4766 100644 --- a/drivers/iommu/intel-iommu.c +++ b/drivers/iommu/intel-iommu.c | |||
| @@ -405,6 +405,9 @@ int dmar_disabled = 0; | |||
| 405 | int dmar_disabled = 1; | 405 | int dmar_disabled = 1; |
| 406 | #endif /*CONFIG_INTEL_IOMMU_DEFAULT_ON*/ | 406 | #endif /*CONFIG_INTEL_IOMMU_DEFAULT_ON*/ |
| 407 | 407 | ||
| 408 | int intel_iommu_enabled = 0; | ||
| 409 | EXPORT_SYMBOL_GPL(intel_iommu_enabled); | ||
| 410 | |||
| 408 | static int dmar_map_gfx = 1; | 411 | static int dmar_map_gfx = 1; |
| 409 | static int dmar_forcedac; | 412 | static int dmar_forcedac; |
| 410 | static int intel_iommu_strict; | 413 | static int intel_iommu_strict; |
| @@ -3524,7 +3527,7 @@ found: | |||
| 3524 | return 0; | 3527 | return 0; |
| 3525 | } | 3528 | } |
| 3526 | 3529 | ||
| 3527 | int dmar_parse_rmrr_atsr_dev(void) | 3530 | int __init dmar_parse_rmrr_atsr_dev(void) |
| 3528 | { | 3531 | { |
| 3529 | struct dmar_rmrr_unit *rmrr, *rmrr_n; | 3532 | struct dmar_rmrr_unit *rmrr, *rmrr_n; |
| 3530 | struct dmar_atsr_unit *atsr, *atsr_n; | 3533 | struct dmar_atsr_unit *atsr, *atsr_n; |
| @@ -3647,6 +3650,8 @@ int __init intel_iommu_init(void) | |||
| 3647 | 3650 | ||
| 3648 | bus_register_notifier(&pci_bus_type, &device_nb); | 3651 | bus_register_notifier(&pci_bus_type, &device_nb); |
| 3649 | 3652 | ||
| 3653 | intel_iommu_enabled = 1; | ||
| 3654 | |||
| 3650 | return 0; | 3655 | return 0; |
| 3651 | } | 3656 | } |
| 3652 | 3657 | ||
diff --git a/drivers/iommu/intr_remapping.c b/drivers/iommu/intr_remapping.c index 07c9f189f314..6777ca049471 100644 --- a/drivers/iommu/intr_remapping.c +++ b/drivers/iommu/intr_remapping.c | |||
| @@ -773,7 +773,7 @@ int __init parse_ioapics_under_ir(void) | |||
| 773 | return ir_supported; | 773 | return ir_supported; |
| 774 | } | 774 | } |
| 775 | 775 | ||
| 776 | int ir_dev_scope_init(void) | 776 | int __init ir_dev_scope_init(void) |
| 777 | { | 777 | { |
| 778 | if (!intr_remapping_enabled) | 778 | if (!intr_remapping_enabled) |
| 779 | return 0; | 779 | return 0; |
diff --git a/drivers/isdn/divert/divert_procfs.c b/drivers/isdn/divert/divert_procfs.c index 33ec9e467772..9021182c4b76 100644 --- a/drivers/isdn/divert/divert_procfs.c +++ b/drivers/isdn/divert/divert_procfs.c | |||
| @@ -242,6 +242,12 @@ static int isdn_divert_ioctl_unlocked(struct file *file, uint cmd, ulong arg) | |||
| 242 | case IIOCDOCFINT: | 242 | case IIOCDOCFINT: |
| 243 | if (!divert_if.drv_to_name(dioctl.cf_ctrl.drvid)) | 243 | if (!divert_if.drv_to_name(dioctl.cf_ctrl.drvid)) |
| 244 | return (-EINVAL); /* invalid driver */ | 244 | return (-EINVAL); /* invalid driver */ |
| 245 | if (strnlen(dioctl.cf_ctrl.msn, sizeof(dioctl.cf_ctrl.msn)) == | ||
| 246 | sizeof(dioctl.cf_ctrl.msn)) | ||
| 247 | return -EINVAL; | ||
| 248 | if (strnlen(dioctl.cf_ctrl.fwd_nr, sizeof(dioctl.cf_ctrl.fwd_nr)) == | ||
| 249 | sizeof(dioctl.cf_ctrl.fwd_nr)) | ||
| 250 | return -EINVAL; | ||
| 245 | if ((i = cf_command(dioctl.cf_ctrl.drvid, | 251 | if ((i = cf_command(dioctl.cf_ctrl.drvid, |
| 246 | (cmd == IIOCDOCFACT) ? 1 : (cmd == IIOCDOCFDIS) ? 0 : 2, | 252 | (cmd == IIOCDOCFACT) ? 1 : (cmd == IIOCDOCFDIS) ? 0 : 2, |
| 247 | dioctl.cf_ctrl.cfproc, | 253 | dioctl.cf_ctrl.cfproc, |
diff --git a/drivers/isdn/i4l/isdn_net.c b/drivers/isdn/i4l/isdn_net.c index 1f73d7f7e024..2339d7396b9e 100644 --- a/drivers/isdn/i4l/isdn_net.c +++ b/drivers/isdn/i4l/isdn_net.c | |||
| @@ -2756,6 +2756,9 @@ isdn_net_setcfg(isdn_net_ioctl_cfg * cfg) | |||
| 2756 | char *c, | 2756 | char *c, |
| 2757 | *e; | 2757 | *e; |
| 2758 | 2758 | ||
| 2759 | if (strnlen(cfg->drvid, sizeof(cfg->drvid)) == | ||
| 2760 | sizeof(cfg->drvid)) | ||
| 2761 | return -EINVAL; | ||
| 2759 | drvidx = -1; | 2762 | drvidx = -1; |
| 2760 | chidx = -1; | 2763 | chidx = -1; |
| 2761 | strcpy(drvid, cfg->drvid); | 2764 | strcpy(drvid, cfg->drvid); |
diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c index 7878712721bf..b6907118283a 100644 --- a/drivers/md/bitmap.c +++ b/drivers/md/bitmap.c | |||
| @@ -1106,10 +1106,12 @@ void bitmap_write_all(struct bitmap *bitmap) | |||
| 1106 | */ | 1106 | */ |
| 1107 | int i; | 1107 | int i; |
| 1108 | 1108 | ||
| 1109 | spin_lock_irq(&bitmap->lock); | ||
| 1109 | for (i = 0; i < bitmap->file_pages; i++) | 1110 | for (i = 0; i < bitmap->file_pages; i++) |
| 1110 | set_page_attr(bitmap, bitmap->filemap[i], | 1111 | set_page_attr(bitmap, bitmap->filemap[i], |
| 1111 | BITMAP_PAGE_NEEDWRITE); | 1112 | BITMAP_PAGE_NEEDWRITE); |
| 1112 | bitmap->allclean = 0; | 1113 | bitmap->allclean = 0; |
| 1114 | spin_unlock_irq(&bitmap->lock); | ||
| 1113 | } | 1115 | } |
| 1114 | 1116 | ||
| 1115 | static void bitmap_count_page(struct bitmap *bitmap, sector_t offset, int inc) | 1117 | static void bitmap_count_page(struct bitmap *bitmap, sector_t offset, int inc) |
| @@ -1605,7 +1607,9 @@ void bitmap_dirty_bits(struct bitmap *bitmap, unsigned long s, unsigned long e) | |||
| 1605 | for (chunk = s; chunk <= e; chunk++) { | 1607 | for (chunk = s; chunk <= e; chunk++) { |
| 1606 | sector_t sec = (sector_t)chunk << CHUNK_BLOCK_SHIFT(bitmap); | 1608 | sector_t sec = (sector_t)chunk << CHUNK_BLOCK_SHIFT(bitmap); |
| 1607 | bitmap_set_memory_bits(bitmap, sec, 1); | 1609 | bitmap_set_memory_bits(bitmap, sec, 1); |
| 1610 | spin_lock_irq(&bitmap->lock); | ||
| 1608 | bitmap_file_set_bit(bitmap, sec); | 1611 | bitmap_file_set_bit(bitmap, sec); |
| 1612 | spin_unlock_irq(&bitmap->lock); | ||
| 1609 | if (sec < bitmap->mddev->recovery_cp) | 1613 | if (sec < bitmap->mddev->recovery_cp) |
| 1610 | /* We are asserting that the array is dirty, | 1614 | /* We are asserting that the array is dirty, |
| 1611 | * so move the recovery_cp address back so | 1615 | * so move the recovery_cp address back so |
diff --git a/drivers/md/md.c b/drivers/md/md.c index 84acfe7d10e4..ee981737edfc 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c | |||
| @@ -570,7 +570,7 @@ static void mddev_put(struct mddev *mddev) | |||
| 570 | mddev->ctime == 0 && !mddev->hold_active) { | 570 | mddev->ctime == 0 && !mddev->hold_active) { |
| 571 | /* Array is not configured at all, and not held active, | 571 | /* Array is not configured at all, and not held active, |
| 572 | * so destroy it */ | 572 | * so destroy it */ |
| 573 | list_del(&mddev->all_mddevs); | 573 | list_del_init(&mddev->all_mddevs); |
| 574 | bs = mddev->bio_set; | 574 | bs = mddev->bio_set; |
| 575 | mddev->bio_set = NULL; | 575 | mddev->bio_set = NULL; |
| 576 | if (mddev->gendisk) { | 576 | if (mddev->gendisk) { |
| @@ -2546,7 +2546,8 @@ state_show(struct md_rdev *rdev, char *page) | |||
| 2546 | sep = ","; | 2546 | sep = ","; |
| 2547 | } | 2547 | } |
| 2548 | if (test_bit(Blocked, &rdev->flags) || | 2548 | if (test_bit(Blocked, &rdev->flags) || |
| 2549 | rdev->badblocks.unacked_exist) { | 2549 | (rdev->badblocks.unacked_exist |
| 2550 | && !test_bit(Faulty, &rdev->flags))) { | ||
| 2550 | len += sprintf(page+len, "%sblocked", sep); | 2551 | len += sprintf(page+len, "%sblocked", sep); |
| 2551 | sep = ","; | 2552 | sep = ","; |
| 2552 | } | 2553 | } |
| @@ -3788,6 +3789,8 @@ array_state_store(struct mddev *mddev, const char *buf, size_t len) | |||
| 3788 | if (err) | 3789 | if (err) |
| 3789 | return err; | 3790 | return err; |
| 3790 | else { | 3791 | else { |
| 3792 | if (mddev->hold_active == UNTIL_IOCTL) | ||
| 3793 | mddev->hold_active = 0; | ||
| 3791 | sysfs_notify_dirent_safe(mddev->sysfs_state); | 3794 | sysfs_notify_dirent_safe(mddev->sysfs_state); |
| 3792 | return len; | 3795 | return len; |
| 3793 | } | 3796 | } |
| @@ -4487,11 +4490,20 @@ md_attr_show(struct kobject *kobj, struct attribute *attr, char *page) | |||
| 4487 | 4490 | ||
| 4488 | if (!entry->show) | 4491 | if (!entry->show) |
| 4489 | return -EIO; | 4492 | return -EIO; |
| 4493 | spin_lock(&all_mddevs_lock); | ||
| 4494 | if (list_empty(&mddev->all_mddevs)) { | ||
| 4495 | spin_unlock(&all_mddevs_lock); | ||
| 4496 | return -EBUSY; | ||
| 4497 | } | ||
| 4498 | mddev_get(mddev); | ||
| 4499 | spin_unlock(&all_mddevs_lock); | ||
| 4500 | |||
| 4490 | rv = mddev_lock(mddev); | 4501 | rv = mddev_lock(mddev); |
| 4491 | if (!rv) { | 4502 | if (!rv) { |
| 4492 | rv = entry->show(mddev, page); | 4503 | rv = entry->show(mddev, page); |
| 4493 | mddev_unlock(mddev); | 4504 | mddev_unlock(mddev); |
| 4494 | } | 4505 | } |
| 4506 | mddev_put(mddev); | ||
| 4495 | return rv; | 4507 | return rv; |
| 4496 | } | 4508 | } |
| 4497 | 4509 | ||
| @@ -4507,13 +4519,19 @@ md_attr_store(struct kobject *kobj, struct attribute *attr, | |||
| 4507 | return -EIO; | 4519 | return -EIO; |
| 4508 | if (!capable(CAP_SYS_ADMIN)) | 4520 | if (!capable(CAP_SYS_ADMIN)) |
| 4509 | return -EACCES; | 4521 | return -EACCES; |
| 4522 | spin_lock(&all_mddevs_lock); | ||
| 4523 | if (list_empty(&mddev->all_mddevs)) { | ||
| 4524 | spin_unlock(&all_mddevs_lock); | ||
| 4525 | return -EBUSY; | ||
| 4526 | } | ||
| 4527 | mddev_get(mddev); | ||
| 4528 | spin_unlock(&all_mddevs_lock); | ||
| 4510 | rv = mddev_lock(mddev); | 4529 | rv = mddev_lock(mddev); |
| 4511 | if (mddev->hold_active == UNTIL_IOCTL) | ||
| 4512 | mddev->hold_active = 0; | ||
| 4513 | if (!rv) { | 4530 | if (!rv) { |
| 4514 | rv = entry->store(mddev, page, length); | 4531 | rv = entry->store(mddev, page, length); |
| 4515 | mddev_unlock(mddev); | 4532 | mddev_unlock(mddev); |
| 4516 | } | 4533 | } |
| 4534 | mddev_put(mddev); | ||
| 4517 | return rv; | 4535 | return rv; |
| 4518 | } | 4536 | } |
| 4519 | 4537 | ||
| @@ -7840,6 +7858,7 @@ int rdev_set_badblocks(struct md_rdev *rdev, sector_t s, int sectors, | |||
| 7840 | s + rdev->data_offset, sectors, acknowledged); | 7858 | s + rdev->data_offset, sectors, acknowledged); |
| 7841 | if (rv) { | 7859 | if (rv) { |
| 7842 | /* Make sure they get written out promptly */ | 7860 | /* Make sure they get written out promptly */ |
| 7861 | sysfs_notify_dirent_safe(rdev->sysfs_state); | ||
| 7843 | set_bit(MD_CHANGE_CLEAN, &rdev->mddev->flags); | 7862 | set_bit(MD_CHANGE_CLEAN, &rdev->mddev->flags); |
| 7844 | md_wakeup_thread(rdev->mddev->thread); | 7863 | md_wakeup_thread(rdev->mddev->thread); |
| 7845 | } | 7864 | } |
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 297e26092178..31670f8d6b65 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c | |||
| @@ -3036,6 +3036,8 @@ static void analyse_stripe(struct stripe_head *sh, struct stripe_head_state *s) | |||
| 3036 | if (dev->written) | 3036 | if (dev->written) |
| 3037 | s->written++; | 3037 | s->written++; |
| 3038 | rdev = rcu_dereference(conf->disks[i].rdev); | 3038 | rdev = rcu_dereference(conf->disks[i].rdev); |
| 3039 | if (rdev && test_bit(Faulty, &rdev->flags)) | ||
| 3040 | rdev = NULL; | ||
| 3039 | if (rdev) { | 3041 | if (rdev) { |
| 3040 | is_bad = is_badblock(rdev, sh->sector, STRIPE_SECTORS, | 3042 | is_bad = is_badblock(rdev, sh->sector, STRIPE_SECTORS, |
| 3041 | &first_bad, &bad_sectors); | 3043 | &first_bad, &bad_sectors); |
| @@ -3063,12 +3065,12 @@ static void analyse_stripe(struct stripe_head *sh, struct stripe_head_state *s) | |||
| 3063 | } | 3065 | } |
| 3064 | } else if (test_bit(In_sync, &rdev->flags)) | 3066 | } else if (test_bit(In_sync, &rdev->flags)) |
| 3065 | set_bit(R5_Insync, &dev->flags); | 3067 | set_bit(R5_Insync, &dev->flags); |
| 3066 | else if (!test_bit(Faulty, &rdev->flags)) { | 3068 | else { |
| 3067 | /* in sync if before recovery_offset */ | 3069 | /* in sync if before recovery_offset */ |
| 3068 | if (sh->sector + STRIPE_SECTORS <= rdev->recovery_offset) | 3070 | if (sh->sector + STRIPE_SECTORS <= rdev->recovery_offset) |
| 3069 | set_bit(R5_Insync, &dev->flags); | 3071 | set_bit(R5_Insync, &dev->flags); |
| 3070 | } | 3072 | } |
| 3071 | if (test_bit(R5_WriteError, &dev->flags)) { | 3073 | if (rdev && test_bit(R5_WriteError, &dev->flags)) { |
| 3072 | clear_bit(R5_Insync, &dev->flags); | 3074 | clear_bit(R5_Insync, &dev->flags); |
| 3073 | if (!test_bit(Faulty, &rdev->flags)) { | 3075 | if (!test_bit(Faulty, &rdev->flags)) { |
| 3074 | s->handle_bad_blocks = 1; | 3076 | s->handle_bad_blocks = 1; |
| @@ -3076,7 +3078,7 @@ static void analyse_stripe(struct stripe_head *sh, struct stripe_head_state *s) | |||
| 3076 | } else | 3078 | } else |
| 3077 | clear_bit(R5_WriteError, &dev->flags); | 3079 | clear_bit(R5_WriteError, &dev->flags); |
| 3078 | } | 3080 | } |
| 3079 | if (test_bit(R5_MadeGood, &dev->flags)) { | 3081 | if (rdev && test_bit(R5_MadeGood, &dev->flags)) { |
| 3080 | if (!test_bit(Faulty, &rdev->flags)) { | 3082 | if (!test_bit(Faulty, &rdev->flags)) { |
| 3081 | s->handle_bad_blocks = 1; | 3083 | s->handle_bad_blocks = 1; |
| 3082 | atomic_inc(&rdev->nr_pending); | 3084 | atomic_inc(&rdev->nr_pending); |
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index a1cb21f95302..1e0e27cbe987 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c | |||
| @@ -1606,6 +1606,14 @@ static const struct mmc_fixup blk_fixups[] = | |||
| 1606 | MMC_QUIRK_BLK_NO_CMD23), | 1606 | MMC_QUIRK_BLK_NO_CMD23), |
| 1607 | MMC_FIXUP("MMC32G", 0x11, CID_OEMID_ANY, add_quirk_mmc, | 1607 | MMC_FIXUP("MMC32G", 0x11, CID_OEMID_ANY, add_quirk_mmc, |
| 1608 | MMC_QUIRK_BLK_NO_CMD23), | 1608 | MMC_QUIRK_BLK_NO_CMD23), |
| 1609 | |||
| 1610 | /* | ||
| 1611 | * Some Micron MMC cards needs longer data read timeout than | ||
| 1612 | * indicated in CSD. | ||
| 1613 | */ | ||
| 1614 | MMC_FIXUP(CID_NAME_ANY, 0x13, 0x200, add_quirk_mmc, | ||
| 1615 | MMC_QUIRK_LONG_READ_TIME), | ||
| 1616 | |||
| 1609 | END_FIXUP | 1617 | END_FIXUP |
| 1610 | }; | 1618 | }; |
| 1611 | 1619 | ||
diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index 5278ffb20e74..950b97d7412a 100644 --- a/drivers/mmc/core/core.c +++ b/drivers/mmc/core/core.c | |||
| @@ -529,6 +529,18 @@ void mmc_set_data_timeout(struct mmc_data *data, const struct mmc_card *card) | |||
| 529 | data->timeout_clks = 0; | 529 | data->timeout_clks = 0; |
| 530 | } | 530 | } |
| 531 | } | 531 | } |
| 532 | |||
| 533 | /* | ||
| 534 | * Some cards require longer data read timeout than indicated in CSD. | ||
| 535 | * Address this by setting the read timeout to a "reasonably high" | ||
| 536 | * value. For the cards tested, 300ms has proven enough. If necessary, | ||
| 537 | * this value can be increased if other problematic cards require this. | ||
| 538 | */ | ||
| 539 | if (mmc_card_long_read_time(card) && data->flags & MMC_DATA_READ) { | ||
| 540 | data->timeout_ns = 300000000; | ||
| 541 | data->timeout_clks = 0; | ||
| 542 | } | ||
| 543 | |||
| 532 | /* | 544 | /* |
| 533 | * Some cards need very high timeouts if driven in SPI mode. | 545 | * Some cards need very high timeouts if driven in SPI mode. |
| 534 | * The worst observed timeout was 900ms after writing a | 546 | * The worst observed timeout was 900ms after writing a |
| @@ -1213,6 +1225,46 @@ void mmc_set_driver_type(struct mmc_host *host, unsigned int drv_type) | |||
| 1213 | mmc_host_clk_release(host); | 1225 | mmc_host_clk_release(host); |
| 1214 | } | 1226 | } |
| 1215 | 1227 | ||
| 1228 | static void mmc_poweroff_notify(struct mmc_host *host) | ||
| 1229 | { | ||
| 1230 | struct mmc_card *card; | ||
| 1231 | unsigned int timeout; | ||
| 1232 | unsigned int notify_type = EXT_CSD_NO_POWER_NOTIFICATION; | ||
| 1233 | int err = 0; | ||
| 1234 | |||
| 1235 | card = host->card; | ||
| 1236 | |||
| 1237 | /* | ||
| 1238 | * Send power notify command only if card | ||
| 1239 | * is mmc and notify state is powered ON | ||
| 1240 | */ | ||
| 1241 | if (card && mmc_card_mmc(card) && | ||
| 1242 | (card->poweroff_notify_state == MMC_POWERED_ON)) { | ||
| 1243 | |||
| 1244 | if (host->power_notify_type == MMC_HOST_PW_NOTIFY_SHORT) { | ||
| 1245 | notify_type = EXT_CSD_POWER_OFF_SHORT; | ||
| 1246 | timeout = card->ext_csd.generic_cmd6_time; | ||
| 1247 | card->poweroff_notify_state = MMC_POWEROFF_SHORT; | ||
| 1248 | } else { | ||
| 1249 | notify_type = EXT_CSD_POWER_OFF_LONG; | ||
| 1250 | timeout = card->ext_csd.power_off_longtime; | ||
| 1251 | card->poweroff_notify_state = MMC_POWEROFF_LONG; | ||
| 1252 | } | ||
| 1253 | |||
| 1254 | err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, | ||
| 1255 | EXT_CSD_POWER_OFF_NOTIFICATION, | ||
| 1256 | notify_type, timeout); | ||
| 1257 | |||
| 1258 | if (err && err != -EBADMSG) | ||
| 1259 | pr_err("Device failed to respond within %d poweroff " | ||
| 1260 | "time. Forcefully powering down the device\n", | ||
| 1261 | timeout); | ||
| 1262 | |||
| 1263 | /* Set the card state to no notification after the poweroff */ | ||
| 1264 | card->poweroff_notify_state = MMC_NO_POWER_NOTIFICATION; | ||
| 1265 | } | ||
| 1266 | } | ||
| 1267 | |||
| 1216 | /* | 1268 | /* |
| 1217 | * Apply power to the MMC stack. This is a two-stage process. | 1269 | * Apply power to the MMC stack. This is a two-stage process. |
| 1218 | * First, we enable power to the card without the clock running. | 1270 | * First, we enable power to the card without the clock running. |
| @@ -1269,42 +1321,12 @@ static void mmc_power_up(struct mmc_host *host) | |||
| 1269 | 1321 | ||
| 1270 | void mmc_power_off(struct mmc_host *host) | 1322 | void mmc_power_off(struct mmc_host *host) |
| 1271 | { | 1323 | { |
| 1272 | struct mmc_card *card; | ||
| 1273 | unsigned int notify_type; | ||
| 1274 | unsigned int timeout; | ||
| 1275 | int err; | ||
| 1276 | |||
| 1277 | mmc_host_clk_hold(host); | 1324 | mmc_host_clk_hold(host); |
| 1278 | 1325 | ||
| 1279 | card = host->card; | ||
| 1280 | host->ios.clock = 0; | 1326 | host->ios.clock = 0; |
| 1281 | host->ios.vdd = 0; | 1327 | host->ios.vdd = 0; |
| 1282 | 1328 | ||
| 1283 | if (card && mmc_card_mmc(card) && | 1329 | mmc_poweroff_notify(host); |
| 1284 | (card->poweroff_notify_state == MMC_POWERED_ON)) { | ||
| 1285 | |||
| 1286 | if (host->power_notify_type == MMC_HOST_PW_NOTIFY_SHORT) { | ||
| 1287 | notify_type = EXT_CSD_POWER_OFF_SHORT; | ||
| 1288 | timeout = card->ext_csd.generic_cmd6_time; | ||
| 1289 | card->poweroff_notify_state = MMC_POWEROFF_SHORT; | ||
| 1290 | } else { | ||
| 1291 | notify_type = EXT_CSD_POWER_OFF_LONG; | ||
| 1292 | timeout = card->ext_csd.power_off_longtime; | ||
| 1293 | card->poweroff_notify_state = MMC_POWEROFF_LONG; | ||
| 1294 | } | ||
| 1295 | |||
| 1296 | err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, | ||
| 1297 | EXT_CSD_POWER_OFF_NOTIFICATION, | ||
| 1298 | notify_type, timeout); | ||
| 1299 | |||
| 1300 | if (err && err != -EBADMSG) | ||
| 1301 | pr_err("Device failed to respond within %d poweroff " | ||
| 1302 | "time. Forcefully powering down the device\n", | ||
| 1303 | timeout); | ||
| 1304 | |||
| 1305 | /* Set the card state to no notification after the poweroff */ | ||
| 1306 | card->poweroff_notify_state = MMC_NO_POWER_NOTIFICATION; | ||
| 1307 | } | ||
| 1308 | 1330 | ||
| 1309 | /* | 1331 | /* |
| 1310 | * Reset ocr mask to be the highest possible voltage supported for | 1332 | * Reset ocr mask to be the highest possible voltage supported for |
| @@ -2196,7 +2218,7 @@ int mmc_card_sleep(struct mmc_host *host) | |||
| 2196 | 2218 | ||
| 2197 | mmc_bus_get(host); | 2219 | mmc_bus_get(host); |
| 2198 | 2220 | ||
| 2199 | if (host->bus_ops && !host->bus_dead && host->bus_ops->awake) | 2221 | if (host->bus_ops && !host->bus_dead && host->bus_ops->sleep) |
| 2200 | err = host->bus_ops->sleep(host); | 2222 | err = host->bus_ops->sleep(host); |
| 2201 | 2223 | ||
| 2202 | mmc_bus_put(host); | 2224 | mmc_bus_put(host); |
| @@ -2302,8 +2324,17 @@ int mmc_suspend_host(struct mmc_host *host) | |||
| 2302 | * pre-claim the host. | 2324 | * pre-claim the host. |
| 2303 | */ | 2325 | */ |
| 2304 | if (mmc_try_claim_host(host)) { | 2326 | if (mmc_try_claim_host(host)) { |
| 2305 | if (host->bus_ops->suspend) | 2327 | if (host->bus_ops->suspend) { |
| 2328 | /* | ||
| 2329 | * For eMMC 4.5 device send notify command | ||
| 2330 | * before sleep, because in sleep state eMMC 4.5 | ||
| 2331 | * devices respond to only RESET and AWAKE cmd | ||
| 2332 | */ | ||
| 2333 | mmc_poweroff_notify(host); | ||
| 2306 | err = host->bus_ops->suspend(host); | 2334 | err = host->bus_ops->suspend(host); |
| 2335 | } | ||
| 2336 | mmc_do_release_host(host); | ||
| 2337 | |||
| 2307 | if (err == -ENOSYS || !host->bus_ops->resume) { | 2338 | if (err == -ENOSYS || !host->bus_ops->resume) { |
| 2308 | /* | 2339 | /* |
| 2309 | * We simply "remove" the card in this case. | 2340 | * We simply "remove" the card in this case. |
| @@ -2318,7 +2349,6 @@ int mmc_suspend_host(struct mmc_host *host) | |||
| 2318 | host->pm_flags = 0; | 2349 | host->pm_flags = 0; |
| 2319 | err = 0; | 2350 | err = 0; |
| 2320 | } | 2351 | } |
| 2321 | mmc_do_release_host(host); | ||
| 2322 | } else { | 2352 | } else { |
| 2323 | err = -EBUSY; | 2353 | err = -EBUSY; |
| 2324 | } | 2354 | } |
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index dbf421a6279c..d240427c1246 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c | |||
| @@ -876,17 +876,21 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr, | |||
| 876 | * set the notification byte in the ext_csd register of device | 876 | * set the notification byte in the ext_csd register of device |
| 877 | */ | 877 | */ |
| 878 | if ((host->caps2 & MMC_CAP2_POWEROFF_NOTIFY) && | 878 | if ((host->caps2 & MMC_CAP2_POWEROFF_NOTIFY) && |
| 879 | (card->poweroff_notify_state == MMC_NO_POWER_NOTIFICATION)) { | 879 | (card->ext_csd.rev >= 6)) { |
| 880 | err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, | 880 | err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL, |
| 881 | EXT_CSD_POWER_OFF_NOTIFICATION, | 881 | EXT_CSD_POWER_OFF_NOTIFICATION, |
| 882 | EXT_CSD_POWER_ON, | 882 | EXT_CSD_POWER_ON, |
| 883 | card->ext_csd.generic_cmd6_time); | 883 | card->ext_csd.generic_cmd6_time); |
| 884 | if (err && err != -EBADMSG) | 884 | if (err && err != -EBADMSG) |
| 885 | goto free_card; | 885 | goto free_card; |
| 886 | } | ||
| 887 | 886 | ||
| 888 | if (!err) | 887 | /* |
| 889 | card->poweroff_notify_state = MMC_POWERED_ON; | 888 | * The err can be -EBADMSG or 0, |
| 889 | * so check for success and update the flag | ||
| 890 | */ | ||
| 891 | if (!err) | ||
| 892 | card->poweroff_notify_state = MMC_POWERED_ON; | ||
| 893 | } | ||
| 890 | 894 | ||
| 891 | /* | 895 | /* |
| 892 | * Activate high speed (if supported) | 896 | * Activate high speed (if supported) |
diff --git a/drivers/mmc/host/mxcmmc.c b/drivers/mmc/host/mxcmmc.c index 325ea61e12d3..8e0fbe994047 100644 --- a/drivers/mmc/host/mxcmmc.c +++ b/drivers/mmc/host/mxcmmc.c | |||
| @@ -732,6 +732,7 @@ static void mxcmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) | |||
| 732 | "failed to config DMA channel. Falling back to PIO\n"); | 732 | "failed to config DMA channel. Falling back to PIO\n"); |
| 733 | dma_release_channel(host->dma); | 733 | dma_release_channel(host->dma); |
| 734 | host->do_dma = 0; | 734 | host->do_dma = 0; |
| 735 | host->dma = NULL; | ||
| 735 | } | 736 | } |
| 736 | } | 737 | } |
| 737 | 738 | ||
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 101cd31c8220..d5fe43d53c51 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c | |||
| @@ -1010,6 +1010,7 @@ static void omap_hsmmc_dma_cleanup(struct omap_hsmmc_host *host, int errno) | |||
| 1010 | host->data->sg_len, | 1010 | host->data->sg_len, |
| 1011 | omap_hsmmc_get_dma_dir(host, host->data)); | 1011 | omap_hsmmc_get_dma_dir(host, host->data)); |
| 1012 | omap_free_dma(dma_ch); | 1012 | omap_free_dma(dma_ch); |
| 1013 | host->data->host_cookie = 0; | ||
| 1013 | } | 1014 | } |
| 1014 | host->data = NULL; | 1015 | host->data = NULL; |
| 1015 | } | 1016 | } |
| @@ -1575,8 +1576,10 @@ static void omap_hsmmc_post_req(struct mmc_host *mmc, struct mmc_request *mrq, | |||
| 1575 | struct mmc_data *data = mrq->data; | 1576 | struct mmc_data *data = mrq->data; |
| 1576 | 1577 | ||
| 1577 | if (host->use_dma) { | 1578 | if (host->use_dma) { |
| 1578 | dma_unmap_sg(mmc_dev(host->mmc), data->sg, data->sg_len, | 1579 | if (data->host_cookie) |
| 1579 | omap_hsmmc_get_dma_dir(host, data)); | 1580 | dma_unmap_sg(mmc_dev(host->mmc), data->sg, |
| 1581 | data->sg_len, | ||
| 1582 | omap_hsmmc_get_dma_dir(host, data)); | ||
| 1580 | data->host_cookie = 0; | 1583 | data->host_cookie = 0; |
| 1581 | } | 1584 | } |
| 1582 | } | 1585 | } |
diff --git a/drivers/mmc/host/sdhci-cns3xxx.c b/drivers/mmc/host/sdhci-cns3xxx.c index 4b920b7621cf..87b6f079b6e0 100644 --- a/drivers/mmc/host/sdhci-cns3xxx.c +++ b/drivers/mmc/host/sdhci-cns3xxx.c | |||
| @@ -15,6 +15,7 @@ | |||
| 15 | #include <linux/delay.h> | 15 | #include <linux/delay.h> |
| 16 | #include <linux/device.h> | 16 | #include <linux/device.h> |
| 17 | #include <linux/mmc/host.h> | 17 | #include <linux/mmc/host.h> |
| 18 | #include <linux/module.h> | ||
| 18 | #include <mach/cns3xxx.h> | 19 | #include <mach/cns3xxx.h> |
| 19 | #include "sdhci-pltfm.h" | 20 | #include "sdhci-pltfm.h" |
| 20 | 21 | ||
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 3d00e722efc9..cb60c4197e0a 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c | |||
| @@ -644,8 +644,6 @@ static int sdhci_s3c_resume(struct platform_device *dev) | |||
| 644 | static struct platform_driver sdhci_s3c_driver = { | 644 | static struct platform_driver sdhci_s3c_driver = { |
| 645 | .probe = sdhci_s3c_probe, | 645 | .probe = sdhci_s3c_probe, |
| 646 | .remove = __devexit_p(sdhci_s3c_remove), | 646 | .remove = __devexit_p(sdhci_s3c_remove), |
| 647 | .suspend = sdhci_s3c_suspend, | ||
| 648 | .resume = sdhci_s3c_resume, | ||
| 649 | .driver = { | 647 | .driver = { |
| 650 | .owner = THIS_MODULE, | 648 | .owner = THIS_MODULE, |
| 651 | .name = "s3c-sdhci", | 649 | .name = "s3c-sdhci", |
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 369366c8e205..d5505f3fe2a1 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c | |||
| @@ -908,7 +908,7 @@ static void sh_mmcif_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) | |||
| 908 | if (host->power) { | 908 | if (host->power) { |
| 909 | pm_runtime_put(&host->pd->dev); | 909 | pm_runtime_put(&host->pd->dev); |
| 910 | host->power = false; | 910 | host->power = false; |
| 911 | if (p->down_pwr) | 911 | if (p->down_pwr && ios->power_mode == MMC_POWER_OFF) |
| 912 | p->down_pwr(host->pd); | 912 | p->down_pwr(host->pd); |
| 913 | } | 913 | } |
| 914 | host->state = STATE_IDLE; | 914 | host->state = STATE_IDLE; |
diff --git a/drivers/mmc/host/tmio_mmc_pio.c b/drivers/mmc/host/tmio_mmc_pio.c index d85a60cda167..4208b3958069 100644 --- a/drivers/mmc/host/tmio_mmc_pio.c +++ b/drivers/mmc/host/tmio_mmc_pio.c | |||
| @@ -798,7 +798,7 @@ static void tmio_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) | |||
| 798 | /* start bus clock */ | 798 | /* start bus clock */ |
| 799 | tmio_mmc_clk_start(host); | 799 | tmio_mmc_clk_start(host); |
| 800 | } else if (ios->power_mode != MMC_POWER_UP) { | 800 | } else if (ios->power_mode != MMC_POWER_UP) { |
| 801 | if (host->set_pwr) | 801 | if (host->set_pwr && ios->power_mode == MMC_POWER_OFF) |
| 802 | host->set_pwr(host->pdev, 0); | 802 | host->set_pwr(host->pdev, 0); |
| 803 | if ((pdata->flags & TMIO_MMC_HAS_COLD_CD) && | 803 | if ((pdata->flags & TMIO_MMC_HAS_COLD_CD) && |
| 804 | pdata->power) { | 804 | pdata->power) { |
diff --git a/drivers/net/arcnet/Kconfig b/drivers/net/arcnet/Kconfig index a73d9dc80ff6..84fb6349a59a 100644 --- a/drivers/net/arcnet/Kconfig +++ b/drivers/net/arcnet/Kconfig | |||
| @@ -4,7 +4,7 @@ | |||
| 4 | 4 | ||
| 5 | menuconfig ARCNET | 5 | menuconfig ARCNET |
| 6 | depends on NETDEVICES && (ISA || PCI || PCMCIA) | 6 | depends on NETDEVICES && (ISA || PCI || PCMCIA) |
| 7 | bool "ARCnet support" | 7 | tristate "ARCnet support" |
| 8 | ---help--- | 8 | ---help--- |
| 9 | If you have a network card of this type, say Y and check out the | 9 | If you have a network card of this type, say Y and check out the |
| 10 | (arguably) beautiful poetry in | 10 | (arguably) beautiful poetry in |
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index b0c577256487..7f8756825b8a 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c | |||
| @@ -2553,30 +2553,6 @@ re_arm: | |||
| 2553 | } | 2553 | } |
| 2554 | } | 2554 | } |
| 2555 | 2555 | ||
| 2556 | static __be32 bond_glean_dev_ip(struct net_device *dev) | ||
| 2557 | { | ||
| 2558 | struct in_device *idev; | ||
| 2559 | struct in_ifaddr *ifa; | ||
| 2560 | __be32 addr = 0; | ||
| 2561 | |||
| 2562 | if (!dev) | ||
| 2563 | return 0; | ||
| 2564 | |||
| 2565 | rcu_read_lock(); | ||
| 2566 | idev = __in_dev_get_rcu(dev); | ||
| 2567 | if (!idev) | ||
| 2568 | goto out; | ||
| 2569 | |||
| 2570 | ifa = idev->ifa_list; | ||
| 2571 | if (!ifa) | ||
| 2572 | goto out; | ||
| 2573 | |||
| 2574 | addr = ifa->ifa_local; | ||
| 2575 | out: | ||
| 2576 | rcu_read_unlock(); | ||
| 2577 | return addr; | ||
| 2578 | } | ||
| 2579 | |||
| 2580 | static int bond_has_this_ip(struct bonding *bond, __be32 ip) | 2556 | static int bond_has_this_ip(struct bonding *bond, __be32 ip) |
| 2581 | { | 2557 | { |
| 2582 | struct vlan_entry *vlan; | 2558 | struct vlan_entry *vlan; |
| @@ -3322,6 +3298,10 @@ static int bond_inetaddr_event(struct notifier_block *this, unsigned long event, | |||
| 3322 | struct bonding *bond; | 3298 | struct bonding *bond; |
| 3323 | struct vlan_entry *vlan; | 3299 | struct vlan_entry *vlan; |
| 3324 | 3300 | ||
| 3301 | /* we only care about primary address */ | ||
| 3302 | if(ifa->ifa_flags & IFA_F_SECONDARY) | ||
| 3303 | return NOTIFY_DONE; | ||
| 3304 | |||
| 3325 | list_for_each_entry(bond, &bn->dev_list, bond_list) { | 3305 | list_for_each_entry(bond, &bn->dev_list, bond_list) { |
| 3326 | if (bond->dev == event_dev) { | 3306 | if (bond->dev == event_dev) { |
| 3327 | switch (event) { | 3307 | switch (event) { |
| @@ -3329,7 +3309,7 @@ static int bond_inetaddr_event(struct notifier_block *this, unsigned long event, | |||
| 3329 | bond->master_ip = ifa->ifa_local; | 3309 | bond->master_ip = ifa->ifa_local; |
| 3330 | return NOTIFY_OK; | 3310 | return NOTIFY_OK; |
| 3331 | case NETDEV_DOWN: | 3311 | case NETDEV_DOWN: |
| 3332 | bond->master_ip = bond_glean_dev_ip(bond->dev); | 3312 | bond->master_ip = 0; |
| 3333 | return NOTIFY_OK; | 3313 | return NOTIFY_OK; |
| 3334 | default: | 3314 | default: |
| 3335 | return NOTIFY_DONE; | 3315 | return NOTIFY_DONE; |
| @@ -3345,8 +3325,7 @@ static int bond_inetaddr_event(struct notifier_block *this, unsigned long event, | |||
| 3345 | vlan->vlan_ip = ifa->ifa_local; | 3325 | vlan->vlan_ip = ifa->ifa_local; |
| 3346 | return NOTIFY_OK; | 3326 | return NOTIFY_OK; |
| 3347 | case NETDEV_DOWN: | 3327 | case NETDEV_DOWN: |
| 3348 | vlan->vlan_ip = | 3328 | vlan->vlan_ip = 0; |
| 3349 | bond_glean_dev_ip(vlan_dev); | ||
| 3350 | return NOTIFY_OK; | 3329 | return NOTIFY_OK; |
| 3351 | default: | 3330 | default: |
| 3352 | return NOTIFY_DONE; | 3331 | return NOTIFY_DONE; |
diff --git a/drivers/net/can/sja1000/peak_pci.c b/drivers/net/can/sja1000/peak_pci.c index 905bce0b3a43..2c7f5036f570 100644 --- a/drivers/net/can/sja1000/peak_pci.c +++ b/drivers/net/can/sja1000/peak_pci.c | |||
| @@ -20,7 +20,6 @@ | |||
| 20 | */ | 20 | */ |
| 21 | 21 | ||
| 22 | #include <linux/kernel.h> | 22 | #include <linux/kernel.h> |
| 23 | #include <linux/version.h> | ||
| 24 | #include <linux/module.h> | 23 | #include <linux/module.h> |
| 25 | #include <linux/interrupt.h> | 24 | #include <linux/interrupt.h> |
| 26 | #include <linux/netdevice.h> | 25 | #include <linux/netdevice.h> |
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c index 4cf835dbc122..3fb66d09ece5 100644 --- a/drivers/net/ethernet/broadcom/b44.c +++ b/drivers/net/ethernet/broadcom/b44.c | |||
| @@ -608,7 +608,7 @@ static void b44_tx(struct b44 *bp) | |||
| 608 | skb->len, | 608 | skb->len, |
| 609 | DMA_TO_DEVICE); | 609 | DMA_TO_DEVICE); |
| 610 | rp->skb = NULL; | 610 | rp->skb = NULL; |
| 611 | dev_kfree_skb(skb); | 611 | dev_kfree_skb_irq(skb); |
| 612 | } | 612 | } |
| 613 | 613 | ||
| 614 | bp->tx_cons = cons; | 614 | bp->tx_cons = cons; |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c index bce203fa4b9e..882f48f0a03c 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | |||
| @@ -10327,6 +10327,43 @@ static int bnx2x_54618se_config_init(struct bnx2x_phy *phy, | |||
| 10327 | return 0; | 10327 | return 0; |
| 10328 | } | 10328 | } |
| 10329 | 10329 | ||
| 10330 | |||
| 10331 | static void bnx2x_5461x_set_link_led(struct bnx2x_phy *phy, | ||
| 10332 | struct link_params *params, u8 mode) | ||
| 10333 | { | ||
| 10334 | struct bnx2x *bp = params->bp; | ||
| 10335 | u16 temp; | ||
| 10336 | |||
| 10337 | bnx2x_cl22_write(bp, phy, | ||
| 10338 | MDIO_REG_GPHY_SHADOW, | ||
| 10339 | MDIO_REG_GPHY_SHADOW_LED_SEL1); | ||
| 10340 | bnx2x_cl22_read(bp, phy, | ||
| 10341 | MDIO_REG_GPHY_SHADOW, | ||
| 10342 | &temp); | ||
| 10343 | temp &= 0xff00; | ||
| 10344 | |||
| 10345 | DP(NETIF_MSG_LINK, "54618x set link led (mode=%x)\n", mode); | ||
| 10346 | switch (mode) { | ||
| 10347 | case LED_MODE_FRONT_PANEL_OFF: | ||
| 10348 | case LED_MODE_OFF: | ||
| 10349 | temp |= 0x00ee; | ||
| 10350 | break; | ||
| 10351 | case LED_MODE_OPER: | ||
| 10352 | temp |= 0x0001; | ||
| 10353 | break; | ||
| 10354 | case LED_MODE_ON: | ||
| 10355 | temp |= 0x00ff; | ||
| 10356 | break; | ||
| 10357 | default: | ||
| 10358 | break; | ||
| 10359 | } | ||
| 10360 | bnx2x_cl22_write(bp, phy, | ||
| 10361 | MDIO_REG_GPHY_SHADOW, | ||
| 10362 | MDIO_REG_GPHY_SHADOW_WR_ENA | temp); | ||
| 10363 | return; | ||
| 10364 | } | ||
| 10365 | |||
| 10366 | |||
| 10330 | static void bnx2x_54618se_link_reset(struct bnx2x_phy *phy, | 10367 | static void bnx2x_54618se_link_reset(struct bnx2x_phy *phy, |
| 10331 | struct link_params *params) | 10368 | struct link_params *params) |
| 10332 | { | 10369 | { |
| @@ -11103,7 +11140,7 @@ static struct bnx2x_phy phy_54618se = { | |||
| 11103 | .config_loopback = (config_loopback_t)bnx2x_54618se_config_loopback, | 11140 | .config_loopback = (config_loopback_t)bnx2x_54618se_config_loopback, |
| 11104 | .format_fw_ver = (format_fw_ver_t)NULL, | 11141 | .format_fw_ver = (format_fw_ver_t)NULL, |
| 11105 | .hw_reset = (hw_reset_t)NULL, | 11142 | .hw_reset = (hw_reset_t)NULL, |
| 11106 | .set_link_led = (set_link_led_t)NULL, | 11143 | .set_link_led = (set_link_led_t)bnx2x_5461x_set_link_led, |
| 11107 | .phy_specific_func = (phy_specific_func_t)NULL | 11144 | .phy_specific_func = (phy_specific_func_t)NULL |
| 11108 | }; | 11145 | }; |
| 11109 | /*****************************************************************/ | 11146 | /*****************************************************************/ |
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h index fc7bd0f23c0b..e58073ef33b4 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_reg.h | |||
| @@ -6990,6 +6990,7 @@ Theotherbitsarereservedandshouldbezero*/ | |||
| 6990 | #define MDIO_REG_INTR_MASK 0x1b | 6990 | #define MDIO_REG_INTR_MASK 0x1b |
| 6991 | #define MDIO_REG_INTR_MASK_LINK_STATUS (0x1 << 1) | 6991 | #define MDIO_REG_INTR_MASK_LINK_STATUS (0x1 << 1) |
| 6992 | #define MDIO_REG_GPHY_SHADOW 0x1c | 6992 | #define MDIO_REG_GPHY_SHADOW 0x1c |
| 6993 | #define MDIO_REG_GPHY_SHADOW_LED_SEL1 (0x0d << 10) | ||
| 6993 | #define MDIO_REG_GPHY_SHADOW_LED_SEL2 (0x0e << 10) | 6994 | #define MDIO_REG_GPHY_SHADOW_LED_SEL2 (0x0e << 10) |
| 6994 | #define MDIO_REG_GPHY_SHADOW_WR_ENA (0x1 << 15) | 6995 | #define MDIO_REG_GPHY_SHADOW_WR_ENA (0x1 << 15) |
| 6995 | #define MDIO_REG_GPHY_SHADOW_AUTO_DET_MED (0x1e << 10) | 6996 | #define MDIO_REG_GPHY_SHADOW_AUTO_DET_MED (0x1e << 10) |
diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 438f4580bf66..2a22f5256353 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c | |||
| @@ -613,7 +613,7 @@ static int dm9000_set_wol(struct net_device *dev, struct ethtool_wolinfo *w) | |||
| 613 | 613 | ||
| 614 | if (!dm->wake_state) | 614 | if (!dm->wake_state) |
| 615 | irq_set_irq_wake(dm->irq_wake, 1); | 615 | irq_set_irq_wake(dm->irq_wake, 1); |
| 616 | else if (dm->wake_state & !opts) | 616 | else if (dm->wake_state && !opts) |
| 617 | irq_set_irq_wake(dm->irq_wake, 0); | 617 | irq_set_irq_wake(dm->irq_wake, 0); |
| 618 | } | 618 | } |
| 619 | 619 | ||
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig index c520cfd3b298..5272f9d4dda9 100644 --- a/drivers/net/ethernet/freescale/Kconfig +++ b/drivers/net/ethernet/freescale/Kconfig | |||
| @@ -24,6 +24,7 @@ config FEC | |||
| 24 | bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)" | 24 | bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)" |
| 25 | depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \ | 25 | depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \ |
| 26 | ARCH_MXC || ARCH_MXS) | 26 | ARCH_MXC || ARCH_MXS) |
| 27 | default ARCH_MXC || ARCH_MXS if ARM | ||
| 27 | select PHYLIB | 28 | select PHYLIB |
| 28 | ---help--- | 29 | ---help--- |
| 29 | Say Y here if you want to use the built-in 10/100 Fast ethernet | 30 | Say Y here if you want to use the built-in 10/100 Fast ethernet |
diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c index 1124ce0a1594..c136230d50bb 100644 --- a/drivers/net/ethernet/freescale/fec.c +++ b/drivers/net/ethernet/freescale/fec.c | |||
| @@ -232,6 +232,7 @@ struct fec_enet_private { | |||
| 232 | struct platform_device *pdev; | 232 | struct platform_device *pdev; |
| 233 | 233 | ||
| 234 | int opened; | 234 | int opened; |
| 235 | int dev_id; | ||
| 235 | 236 | ||
| 236 | /* Phylib and MDIO interface */ | 237 | /* Phylib and MDIO interface */ |
| 237 | struct mii_bus *mii_bus; | 238 | struct mii_bus *mii_bus; |
| @@ -837,7 +838,7 @@ static void __inline__ fec_get_mac(struct net_device *ndev) | |||
| 837 | 838 | ||
| 838 | /* Adjust MAC if using macaddr */ | 839 | /* Adjust MAC if using macaddr */ |
| 839 | if (iap == macaddr) | 840 | if (iap == macaddr) |
| 840 | ndev->dev_addr[ETH_ALEN-1] = macaddr[ETH_ALEN-1] + fep->pdev->id; | 841 | ndev->dev_addr[ETH_ALEN-1] = macaddr[ETH_ALEN-1] + fep->dev_id; |
| 841 | } | 842 | } |
| 842 | 843 | ||
| 843 | /* ------------------------------------------------------------------------- */ | 844 | /* ------------------------------------------------------------------------- */ |
| @@ -953,7 +954,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) | |||
| 953 | char mdio_bus_id[MII_BUS_ID_SIZE]; | 954 | char mdio_bus_id[MII_BUS_ID_SIZE]; |
| 954 | char phy_name[MII_BUS_ID_SIZE + 3]; | 955 | char phy_name[MII_BUS_ID_SIZE + 3]; |
| 955 | int phy_id; | 956 | int phy_id; |
| 956 | int dev_id = fep->pdev->id; | 957 | int dev_id = fep->dev_id; |
| 957 | 958 | ||
| 958 | fep->phy_dev = NULL; | 959 | fep->phy_dev = NULL; |
| 959 | 960 | ||
| @@ -1031,7 +1032,7 @@ static int fec_enet_mii_init(struct platform_device *pdev) | |||
| 1031 | * mdio interface in board design, and need to be configured by | 1032 | * mdio interface in board design, and need to be configured by |
| 1032 | * fec0 mii_bus. | 1033 | * fec0 mii_bus. |
| 1033 | */ | 1034 | */ |
| 1034 | if ((id_entry->driver_data & FEC_QUIRK_ENET_MAC) && pdev->id > 0) { | 1035 | if ((id_entry->driver_data & FEC_QUIRK_ENET_MAC) && fep->dev_id > 0) { |
| 1035 | /* fec1 uses fec0 mii_bus */ | 1036 | /* fec1 uses fec0 mii_bus */ |
| 1036 | fep->mii_bus = fec0_mii_bus; | 1037 | fep->mii_bus = fec0_mii_bus; |
| 1037 | return 0; | 1038 | return 0; |
| @@ -1063,7 +1064,7 @@ static int fec_enet_mii_init(struct platform_device *pdev) | |||
| 1063 | fep->mii_bus->read = fec_enet_mdio_read; | 1064 | fep->mii_bus->read = fec_enet_mdio_read; |
| 1064 | fep->mii_bus->write = fec_enet_mdio_write; | 1065 | fep->mii_bus->write = fec_enet_mdio_write; |
| 1065 | fep->mii_bus->reset = fec_enet_mdio_reset; | 1066 | fep->mii_bus->reset = fec_enet_mdio_reset; |
| 1066 | snprintf(fep->mii_bus->id, MII_BUS_ID_SIZE, "%x", pdev->id + 1); | 1067 | snprintf(fep->mii_bus->id, MII_BUS_ID_SIZE, "%x", fep->dev_id + 1); |
| 1067 | fep->mii_bus->priv = fep; | 1068 | fep->mii_bus->priv = fep; |
| 1068 | fep->mii_bus->parent = &pdev->dev; | 1069 | fep->mii_bus->parent = &pdev->dev; |
| 1069 | 1070 | ||
| @@ -1521,6 +1522,7 @@ fec_probe(struct platform_device *pdev) | |||
| 1521 | int i, irq, ret = 0; | 1522 | int i, irq, ret = 0; |
| 1522 | struct resource *r; | 1523 | struct resource *r; |
| 1523 | const struct of_device_id *of_id; | 1524 | const struct of_device_id *of_id; |
| 1525 | static int dev_id; | ||
| 1524 | 1526 | ||
| 1525 | of_id = of_match_device(fec_dt_ids, &pdev->dev); | 1527 | of_id = of_match_device(fec_dt_ids, &pdev->dev); |
| 1526 | if (of_id) | 1528 | if (of_id) |
| @@ -1548,6 +1550,7 @@ fec_probe(struct platform_device *pdev) | |||
| 1548 | 1550 | ||
| 1549 | fep->hwp = ioremap(r->start, resource_size(r)); | 1551 | fep->hwp = ioremap(r->start, resource_size(r)); |
| 1550 | fep->pdev = pdev; | 1552 | fep->pdev = pdev; |
| 1553 | fep->dev_id = dev_id++; | ||
| 1551 | 1554 | ||
| 1552 | if (!fep->hwp) { | 1555 | if (!fep->hwp) { |
| 1553 | ret = -ENOMEM; | 1556 | ret = -ENOMEM; |
diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c index 52f4e8ad48e7..4d9f84b8ab97 100644 --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c | |||
| @@ -183,28 +183,10 @@ void fsl_pq_mdio_bus_name(char *name, struct device_node *np) | |||
| 183 | } | 183 | } |
| 184 | EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name); | 184 | EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name); |
| 185 | 185 | ||
| 186 | /* Scan the bus in reverse, looking for an empty spot */ | ||
| 187 | static int fsl_pq_mdio_find_free(struct mii_bus *new_bus) | ||
| 188 | { | ||
| 189 | int i; | ||
| 190 | |||
| 191 | for (i = PHY_MAX_ADDR; i > 0; i--) { | ||
| 192 | u32 phy_id; | ||
| 193 | |||
| 194 | if (get_phy_id(new_bus, i, &phy_id)) | ||
| 195 | return -1; | ||
| 196 | |||
| 197 | if (phy_id == 0xffffffff) | ||
| 198 | break; | ||
| 199 | } | ||
| 200 | |||
| 201 | return i; | ||
| 202 | } | ||
| 203 | |||
| 204 | 186 | ||
| 205 | #if defined(CONFIG_GIANFAR) || defined(CONFIG_GIANFAR_MODULE) | ||
| 206 | static u32 __iomem *get_gfar_tbipa(struct fsl_pq_mdio __iomem *regs, struct device_node *np) | 187 | static u32 __iomem *get_gfar_tbipa(struct fsl_pq_mdio __iomem *regs, struct device_node *np) |
| 207 | { | 188 | { |
| 189 | #if defined(CONFIG_GIANFAR) || defined(CONFIG_GIANFAR_MODULE) | ||
| 208 | struct gfar __iomem *enet_regs; | 190 | struct gfar __iomem *enet_regs; |
| 209 | 191 | ||
| 210 | /* | 192 | /* |
| @@ -220,15 +202,15 @@ static u32 __iomem *get_gfar_tbipa(struct fsl_pq_mdio __iomem *regs, struct devi | |||
| 220 | } else if (of_device_is_compatible(np, "fsl,etsec2-mdio") || | 202 | } else if (of_device_is_compatible(np, "fsl,etsec2-mdio") || |
| 221 | of_device_is_compatible(np, "fsl,etsec2-tbi")) { | 203 | of_device_is_compatible(np, "fsl,etsec2-tbi")) { |
| 222 | return of_iomap(np, 1); | 204 | return of_iomap(np, 1); |
| 223 | } else | 205 | } |
| 224 | return NULL; | ||
| 225 | } | ||
| 226 | #endif | 206 | #endif |
| 207 | return NULL; | ||
| 208 | } | ||
| 227 | 209 | ||
| 228 | 210 | ||
| 229 | #if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE) | ||
| 230 | static int get_ucc_id_for_range(u64 start, u64 end, u32 *ucc_id) | 211 | static int get_ucc_id_for_range(u64 start, u64 end, u32 *ucc_id) |
| 231 | { | 212 | { |
| 213 | #if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE) | ||
| 232 | struct device_node *np = NULL; | 214 | struct device_node *np = NULL; |
| 233 | int err = 0; | 215 | int err = 0; |
| 234 | 216 | ||
| @@ -261,9 +243,10 @@ static int get_ucc_id_for_range(u64 start, u64 end, u32 *ucc_id) | |||
| 261 | return err; | 243 | return err; |
| 262 | else | 244 | else |
| 263 | return -EINVAL; | 245 | return -EINVAL; |
| 264 | } | 246 | #else |
| 247 | return -ENODEV; | ||
| 265 | #endif | 248 | #endif |
| 266 | 249 | } | |
| 267 | 250 | ||
| 268 | static int fsl_pq_mdio_probe(struct platform_device *ofdev) | 251 | static int fsl_pq_mdio_probe(struct platform_device *ofdev) |
| 269 | { | 252 | { |
| @@ -339,19 +322,13 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev) | |||
| 339 | of_device_is_compatible(np, "fsl,etsec2-mdio") || | 322 | of_device_is_compatible(np, "fsl,etsec2-mdio") || |
| 340 | of_device_is_compatible(np, "fsl,etsec2-tbi") || | 323 | of_device_is_compatible(np, "fsl,etsec2-tbi") || |
| 341 | of_device_is_compatible(np, "gianfar")) { | 324 | of_device_is_compatible(np, "gianfar")) { |
| 342 | #if defined(CONFIG_GIANFAR) || defined(CONFIG_GIANFAR_MODULE) | ||
| 343 | tbipa = get_gfar_tbipa(regs, np); | 325 | tbipa = get_gfar_tbipa(regs, np); |
| 344 | if (!tbipa) { | 326 | if (!tbipa) { |
| 345 | err = -EINVAL; | 327 | err = -EINVAL; |
| 346 | goto err_free_irqs; | 328 | goto err_free_irqs; |
| 347 | } | 329 | } |
| 348 | #else | ||
| 349 | err = -ENODEV; | ||
| 350 | goto err_free_irqs; | ||
| 351 | #endif | ||
| 352 | } else if (of_device_is_compatible(np, "fsl,ucc-mdio") || | 330 | } else if (of_device_is_compatible(np, "fsl,ucc-mdio") || |
| 353 | of_device_is_compatible(np, "ucc_geth_phy")) { | 331 | of_device_is_compatible(np, "ucc_geth_phy")) { |
| 354 | #if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE) | ||
| 355 | u32 id; | 332 | u32 id; |
| 356 | static u32 mii_mng_master; | 333 | static u32 mii_mng_master; |
| 357 | 334 | ||
| @@ -364,10 +341,6 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev) | |||
| 364 | mii_mng_master = id; | 341 | mii_mng_master = id; |
| 365 | ucc_set_qe_mux_mii_mng(id - 1); | 342 | ucc_set_qe_mux_mii_mng(id - 1); |
| 366 | } | 343 | } |
| 367 | #else | ||
| 368 | err = -ENODEV; | ||
| 369 | goto err_free_irqs; | ||
| 370 | #endif | ||
| 371 | } else { | 344 | } else { |
| 372 | err = -ENODEV; | 345 | err = -ENODEV; |
| 373 | goto err_free_irqs; | 346 | goto err_free_irqs; |
| @@ -386,16 +359,6 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev) | |||
| 386 | } | 359 | } |
| 387 | 360 | ||
| 388 | if (tbiaddr == -1) { | 361 | if (tbiaddr == -1) { |
| 389 | out_be32(tbipa, 0); | ||
| 390 | |||
| 391 | tbiaddr = fsl_pq_mdio_find_free(new_bus); | ||
| 392 | } | ||
| 393 | |||
| 394 | /* | ||
| 395 | * We define TBIPA at 0 to be illegal, opting to fail for boards that | ||
| 396 | * have PHYs at 1-31, rather than change tbipa and rescan. | ||
| 397 | */ | ||
| 398 | if (tbiaddr == 0) { | ||
| 399 | err = -EBUSY; | 362 | err = -EBUSY; |
| 400 | 363 | ||
| 401 | goto err_free_irqs; | 364 | goto err_free_irqs; |
diff --git a/drivers/net/ethernet/ibm/ehea/ehea.h b/drivers/net/ethernet/ibm/ehea/ehea.h index 410d6a1984ed..6650068c996c 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea.h +++ b/drivers/net/ethernet/ibm/ehea/ehea.h | |||
| @@ -61,9 +61,9 @@ | |||
| 61 | #ifdef EHEA_SMALL_QUEUES | 61 | #ifdef EHEA_SMALL_QUEUES |
| 62 | #define EHEA_MAX_CQE_COUNT 1023 | 62 | #define EHEA_MAX_CQE_COUNT 1023 |
| 63 | #define EHEA_DEF_ENTRIES_SQ 1023 | 63 | #define EHEA_DEF_ENTRIES_SQ 1023 |
| 64 | #define EHEA_DEF_ENTRIES_RQ1 4095 | 64 | #define EHEA_DEF_ENTRIES_RQ1 1023 |
| 65 | #define EHEA_DEF_ENTRIES_RQ2 1023 | 65 | #define EHEA_DEF_ENTRIES_RQ2 1023 |
| 66 | #define EHEA_DEF_ENTRIES_RQ3 1023 | 66 | #define EHEA_DEF_ENTRIES_RQ3 511 |
| 67 | #else | 67 | #else |
| 68 | #define EHEA_MAX_CQE_COUNT 4080 | 68 | #define EHEA_MAX_CQE_COUNT 4080 |
| 69 | #define EHEA_DEF_ENTRIES_SQ 4080 | 69 | #define EHEA_DEF_ENTRIES_SQ 4080 |
diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c index 37b70f7052b6..bfeccbfde236 100644 --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c | |||
| @@ -371,7 +371,8 @@ static void ehea_update_stats(struct work_struct *work) | |||
| 371 | out_herr: | 371 | out_herr: |
| 372 | free_page((unsigned long)cb2); | 372 | free_page((unsigned long)cb2); |
| 373 | resched: | 373 | resched: |
| 374 | schedule_delayed_work(&port->stats_work, msecs_to_jiffies(1000)); | 374 | schedule_delayed_work(&port->stats_work, |
| 375 | round_jiffies_relative(msecs_to_jiffies(1000))); | ||
| 375 | } | 376 | } |
| 376 | 377 | ||
| 377 | static void ehea_refill_rq1(struct ehea_port_res *pr, int index, int nr_of_wqes) | 378 | static void ehea_refill_rq1(struct ehea_port_res *pr, int index, int nr_of_wqes) |
| @@ -2434,7 +2435,8 @@ static int ehea_open(struct net_device *dev) | |||
| 2434 | } | 2435 | } |
| 2435 | 2436 | ||
| 2436 | mutex_unlock(&port->port_lock); | 2437 | mutex_unlock(&port->port_lock); |
| 2437 | schedule_delayed_work(&port->stats_work, msecs_to_jiffies(1000)); | 2438 | schedule_delayed_work(&port->stats_work, |
| 2439 | round_jiffies_relative(msecs_to_jiffies(1000))); | ||
| 2438 | 2440 | ||
| 2439 | return ret; | 2441 | return ret; |
| 2440 | } | 2442 | } |
diff --git a/drivers/net/ethernet/ibm/iseries_veth.c b/drivers/net/ethernet/ibm/iseries_veth.c index 4326681df382..acc31af6594a 100644 --- a/drivers/net/ethernet/ibm/iseries_veth.c +++ b/drivers/net/ethernet/ibm/iseries_veth.c | |||
| @@ -1421,7 +1421,7 @@ static void veth_receive(struct veth_lpar_connection *cnx, | |||
| 1421 | 1421 | ||
| 1422 | /* FIXME: do we need this? */ | 1422 | /* FIXME: do we need this? */ |
| 1423 | memset(local_list, 0, sizeof(local_list)); | 1423 | memset(local_list, 0, sizeof(local_list)); |
| 1424 | memset(remote_list, 0, sizeof(VETH_MAX_FRAMES_PER_MSG)); | 1424 | memset(remote_list, 0, sizeof(remote_list)); |
| 1425 | 1425 | ||
| 1426 | /* a 0 address marks the end of the valid entries */ | 1426 | /* a 0 address marks the end of the valid entries */ |
| 1427 | if (senddata->addr[startchunk] == 0) | 1427 | if (senddata->addr[startchunk] == 0) |
diff --git a/drivers/net/ethernet/jme.c b/drivers/net/ethernet/jme.c index 7becff1f387d..76b84573566b 100644 --- a/drivers/net/ethernet/jme.c +++ b/drivers/net/ethernet/jme.c | |||
| @@ -1745,6 +1745,112 @@ jme_phy_off(struct jme_adapter *jme) | |||
| 1745 | } | 1745 | } |
| 1746 | 1746 | ||
| 1747 | static int | 1747 | static int |
| 1748 | jme_phy_specreg_read(struct jme_adapter *jme, u32 specreg) | ||
| 1749 | { | ||
| 1750 | u32 phy_addr; | ||
| 1751 | |||
| 1752 | phy_addr = JM_PHY_SPEC_REG_READ | specreg; | ||
| 1753 | jme_mdio_write(jme->dev, jme->mii_if.phy_id, JM_PHY_SPEC_ADDR_REG, | ||
| 1754 | phy_addr); | ||
| 1755 | return jme_mdio_read(jme->dev, jme->mii_if.phy_id, | ||
| 1756 | JM_PHY_SPEC_DATA_REG); | ||
| 1757 | } | ||
| 1758 | |||
| 1759 | static void | ||
| 1760 | jme_phy_specreg_write(struct jme_adapter *jme, u32 ext_reg, u32 phy_data) | ||
| 1761 | { | ||
| 1762 | u32 phy_addr; | ||
| 1763 | |||
| 1764 | phy_addr = JM_PHY_SPEC_REG_WRITE | ext_reg; | ||
| 1765 | jme_mdio_write(jme->dev, jme->mii_if.phy_id, JM_PHY_SPEC_DATA_REG, | ||
| 1766 | phy_data); | ||
| 1767 | jme_mdio_write(jme->dev, jme->mii_if.phy_id, JM_PHY_SPEC_ADDR_REG, | ||
| 1768 | phy_addr); | ||
| 1769 | } | ||
| 1770 | |||
| 1771 | static int | ||
| 1772 | jme_phy_calibration(struct jme_adapter *jme) | ||
| 1773 | { | ||
| 1774 | u32 ctrl1000, phy_data; | ||
| 1775 | |||
| 1776 | jme_phy_off(jme); | ||
| 1777 | jme_phy_on(jme); | ||
| 1778 | /* Enabel PHY test mode 1 */ | ||
| 1779 | ctrl1000 = jme_mdio_read(jme->dev, jme->mii_if.phy_id, MII_CTRL1000); | ||
| 1780 | ctrl1000 &= ~PHY_GAD_TEST_MODE_MSK; | ||
| 1781 | ctrl1000 |= PHY_GAD_TEST_MODE_1; | ||
| 1782 | jme_mdio_write(jme->dev, jme->mii_if.phy_id, MII_CTRL1000, ctrl1000); | ||
| 1783 | |||
| 1784 | phy_data = jme_phy_specreg_read(jme, JM_PHY_EXT_COMM_2_REG); | ||
| 1785 | phy_data &= ~JM_PHY_EXT_COMM_2_CALI_MODE_0; | ||
| 1786 | phy_data |= JM_PHY_EXT_COMM_2_CALI_LATCH | | ||
| 1787 | JM_PHY_EXT_COMM_2_CALI_ENABLE; | ||
| 1788 | jme_phy_specreg_write(jme, JM_PHY_EXT_COMM_2_REG, phy_data); | ||
| 1789 | msleep(20); | ||
| 1790 | phy_data = jme_phy_specreg_read(jme, JM_PHY_EXT_COMM_2_REG); | ||
| 1791 | phy_data &= ~(JM_PHY_EXT_COMM_2_CALI_ENABLE | | ||
| 1792 | JM_PHY_EXT_COMM_2_CALI_MODE_0 | | ||
| 1793 | JM_PHY_EXT_COMM_2_CALI_LATCH); | ||
| 1794 | jme_phy_specreg_write(jme, JM_PHY_EXT_COMM_2_REG, phy_data); | ||
| 1795 | |||
| 1796 | /* Disable PHY test mode */ | ||
| 1797 | ctrl1000 = jme_mdio_read(jme->dev, jme->mii_if.phy_id, MII_CTRL1000); | ||
| 1798 | ctrl1000 &= ~PHY_GAD_TEST_MODE_MSK; | ||
| 1799 | jme_mdio_write(jme->dev, jme->mii_if.phy_id, MII_CTRL1000, ctrl1000); | ||
| 1800 | return 0; | ||
| 1801 | } | ||
| 1802 | |||
| 1803 | static int | ||
| 1804 | jme_phy_setEA(struct jme_adapter *jme) | ||
| 1805 | { | ||
| 1806 | u32 phy_comm0 = 0, phy_comm1 = 0; | ||
| 1807 | u8 nic_ctrl; | ||
| 1808 | |||
| 1809 | pci_read_config_byte(jme->pdev, PCI_PRIV_SHARE_NICCTRL, &nic_ctrl); | ||
| 1810 | if ((nic_ctrl & 0x3) == JME_FLAG_PHYEA_ENABLE) | ||
| 1811 | return 0; | ||
| 1812 | |||
| 1813 | switch (jme->pdev->device) { | ||
| 1814 | case PCI_DEVICE_ID_JMICRON_JMC250: | ||
| 1815 | if (((jme->chip_main_rev == 5) && | ||
| 1816 | ((jme->chip_sub_rev == 0) || (jme->chip_sub_rev == 1) || | ||
| 1817 | (jme->chip_sub_rev == 3))) || | ||
| 1818 | (jme->chip_main_rev >= 6)) { | ||
| 1819 | phy_comm0 = 0x008A; | ||
| 1820 | phy_comm1 = 0x4109; | ||
| 1821 | } | ||
| 1822 | if ((jme->chip_main_rev == 3) && | ||
| 1823 | ((jme->chip_sub_rev == 1) || (jme->chip_sub_rev == 2))) | ||
| 1824 | phy_comm0 = 0xE088; | ||
| 1825 | break; | ||
| 1826 | case PCI_DEVICE_ID_JMICRON_JMC260: | ||
| 1827 | if (((jme->chip_main_rev == 5) && | ||
| 1828 | ((jme->chip_sub_rev == 0) || (jme->chip_sub_rev == 1) || | ||
| 1829 | (jme->chip_sub_rev == 3))) || | ||
| 1830 | (jme->chip_main_rev >= 6)) { | ||
| 1831 | phy_comm0 = 0x008A; | ||
| 1832 | phy_comm1 = 0x4109; | ||
| 1833 | } | ||
| 1834 | if ((jme->chip_main_rev == 3) && | ||
| 1835 | ((jme->chip_sub_rev == 1) || (jme->chip_sub_rev == 2))) | ||
| 1836 | phy_comm0 = 0xE088; | ||
| 1837 | if ((jme->chip_main_rev == 2) && (jme->chip_sub_rev == 0)) | ||
| 1838 | phy_comm0 = 0x608A; | ||
| 1839 | if ((jme->chip_main_rev == 2) && (jme->chip_sub_rev == 2)) | ||
| 1840 | phy_comm0 = 0x408A; | ||
| 1841 | break; | ||
| 1842 | default: | ||
| 1843 | return -ENODEV; | ||
| 1844 | } | ||
| 1845 | if (phy_comm0) | ||
| 1846 | jme_phy_specreg_write(jme, JM_PHY_EXT_COMM_0_REG, phy_comm0); | ||
| 1847 | if (phy_comm1) | ||
| 1848 | jme_phy_specreg_write(jme, JM_PHY_EXT_COMM_1_REG, phy_comm1); | ||
| 1849 | |||
| 1850 | return 0; | ||
| 1851 | } | ||
| 1852 | |||
| 1853 | static int | ||
| 1748 | jme_open(struct net_device *netdev) | 1854 | jme_open(struct net_device *netdev) |
| 1749 | { | 1855 | { |
| 1750 | struct jme_adapter *jme = netdev_priv(netdev); | 1856 | struct jme_adapter *jme = netdev_priv(netdev); |
| @@ -1769,7 +1875,8 @@ jme_open(struct net_device *netdev) | |||
| 1769 | jme_set_settings(netdev, &jme->old_ecmd); | 1875 | jme_set_settings(netdev, &jme->old_ecmd); |
| 1770 | else | 1876 | else |
| 1771 | jme_reset_phy_processor(jme); | 1877 | jme_reset_phy_processor(jme); |
| 1772 | 1878 | jme_phy_calibration(jme); | |
| 1879 | jme_phy_setEA(jme); | ||
| 1773 | jme_reset_link(jme); | 1880 | jme_reset_link(jme); |
| 1774 | 1881 | ||
| 1775 | return 0; | 1882 | return 0; |
| @@ -3184,7 +3291,8 @@ jme_resume(struct device *dev) | |||
| 3184 | jme_set_settings(netdev, &jme->old_ecmd); | 3291 | jme_set_settings(netdev, &jme->old_ecmd); |
| 3185 | else | 3292 | else |
| 3186 | jme_reset_phy_processor(jme); | 3293 | jme_reset_phy_processor(jme); |
| 3187 | 3294 | jme_phy_calibration(jme); | |
| 3295 | jme_phy_setEA(jme); | ||
| 3188 | jme_start_irq(jme); | 3296 | jme_start_irq(jme); |
| 3189 | netif_device_attach(netdev); | 3297 | netif_device_attach(netdev); |
| 3190 | 3298 | ||
| @@ -3239,4 +3347,3 @@ MODULE_DESCRIPTION("JMicron JMC2x0 PCI Express Ethernet driver"); | |||
| 3239 | MODULE_LICENSE("GPL"); | 3347 | MODULE_LICENSE("GPL"); |
| 3240 | MODULE_VERSION(DRV_VERSION); | 3348 | MODULE_VERSION(DRV_VERSION); |
| 3241 | MODULE_DEVICE_TABLE(pci, jme_pci_tbl); | 3349 | MODULE_DEVICE_TABLE(pci, jme_pci_tbl); |
| 3242 | |||
diff --git a/drivers/net/ethernet/jme.h b/drivers/net/ethernet/jme.h index 02ea27c1dcb5..4304072bd3c5 100644 --- a/drivers/net/ethernet/jme.h +++ b/drivers/net/ethernet/jme.h | |||
| @@ -760,6 +760,25 @@ enum jme_rxmcs_bits { | |||
| 760 | RXMCS_CHECKSUM, | 760 | RXMCS_CHECKSUM, |
| 761 | }; | 761 | }; |
| 762 | 762 | ||
| 763 | /* Extern PHY common register 2 */ | ||
| 764 | |||
| 765 | #define PHY_GAD_TEST_MODE_1 0x00002000 | ||
| 766 | #define PHY_GAD_TEST_MODE_MSK 0x0000E000 | ||
| 767 | #define JM_PHY_SPEC_REG_READ 0x00004000 | ||
| 768 | #define JM_PHY_SPEC_REG_WRITE 0x00008000 | ||
| 769 | #define PHY_CALIBRATION_DELAY 20 | ||
| 770 | #define JM_PHY_SPEC_ADDR_REG 0x1E | ||
| 771 | #define JM_PHY_SPEC_DATA_REG 0x1F | ||
| 772 | |||
| 773 | #define JM_PHY_EXT_COMM_0_REG 0x30 | ||
| 774 | #define JM_PHY_EXT_COMM_1_REG 0x31 | ||
| 775 | #define JM_PHY_EXT_COMM_2_REG 0x32 | ||
| 776 | #define JM_PHY_EXT_COMM_2_CALI_ENABLE 0x01 | ||
| 777 | #define JM_PHY_EXT_COMM_2_CALI_MODE_0 0x02 | ||
| 778 | #define JM_PHY_EXT_COMM_2_CALI_LATCH 0x10 | ||
| 779 | #define PCI_PRIV_SHARE_NICCTRL 0xF5 | ||
| 780 | #define JME_FLAG_PHYEA_ENABLE 0x2 | ||
| 781 | |||
| 763 | /* | 782 | /* |
| 764 | * Wakeup Frame setup interface registers | 783 | * Wakeup Frame setup interface registers |
| 765 | */ | 784 | */ |
diff --git a/drivers/net/ethernet/pasemi/Makefile b/drivers/net/ethernet/pasemi/Makefile index 05db5434bafc..90497ffb1ac3 100644 --- a/drivers/net/ethernet/pasemi/Makefile +++ b/drivers/net/ethernet/pasemi/Makefile | |||
| @@ -2,4 +2,5 @@ | |||
| 2 | # Makefile for the A Semi network device drivers. | 2 | # Makefile for the A Semi network device drivers. |
| 3 | # | 3 | # |
| 4 | 4 | ||
| 5 | obj-$(CONFIG_PASEMI_MAC) += pasemi_mac.o pasemi_mac_ethtool.o | 5 | obj-$(CONFIG_PASEMI_MAC) += pasemi_mac_driver.o |
| 6 | pasemi_mac_driver-objs := pasemi_mac.o pasemi_mac_ethtool.o | ||
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge.h b/drivers/net/ethernet/qlogic/qlge/qlge.h index 8731f79c9efc..b8478aab050e 100644 --- a/drivers/net/ethernet/qlogic/qlge/qlge.h +++ b/drivers/net/ethernet/qlogic/qlge/qlge.h | |||
| @@ -58,10 +58,8 @@ | |||
| 58 | 58 | ||
| 59 | 59 | ||
| 60 | #define TX_DESC_PER_IOCB 8 | 60 | #define TX_DESC_PER_IOCB 8 |
| 61 | /* The maximum number of frags we handle is based | 61 | |
| 62 | * on PAGE_SIZE... | 62 | #if ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2) > 0 |
| 63 | */ | ||
| 64 | #if (PAGE_SHIFT == 12) || (PAGE_SHIFT == 13) /* 4k & 8k pages */ | ||
| 65 | #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2) | 63 | #define TX_DESC_PER_OAL ((MAX_SKB_FRAGS - TX_DESC_PER_IOCB) + 2) |
| 66 | #else /* all other page sizes */ | 64 | #else /* all other page sizes */ |
| 67 | #define TX_DESC_PER_OAL 0 | 65 | #define TX_DESC_PER_OAL 0 |
| @@ -1353,7 +1351,7 @@ struct tx_ring_desc { | |||
| 1353 | struct ob_mac_iocb_req *queue_entry; | 1351 | struct ob_mac_iocb_req *queue_entry; |
| 1354 | u32 index; | 1352 | u32 index; |
| 1355 | struct oal oal; | 1353 | struct oal oal; |
| 1356 | struct map_list map[MAX_SKB_FRAGS + 1]; | 1354 | struct map_list map[MAX_SKB_FRAGS + 2]; |
| 1357 | int map_cnt; | 1355 | int map_cnt; |
| 1358 | struct tx_ring_desc *next; | 1356 | struct tx_ring_desc *next; |
| 1359 | }; | 1357 | }; |
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 6f06aa10f0d7..67bf07819992 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c | |||
| @@ -1183,11 +1183,13 @@ static u8 rtl8168d_efuse_read(void __iomem *ioaddr, int reg_addr) | |||
| 1183 | return value; | 1183 | return value; |
| 1184 | } | 1184 | } |
| 1185 | 1185 | ||
| 1186 | static void rtl8169_irq_mask_and_ack(void __iomem *ioaddr) | 1186 | static void rtl8169_irq_mask_and_ack(struct rtl8169_private *tp) |
| 1187 | { | 1187 | { |
| 1188 | RTL_W16(IntrMask, 0x0000); | 1188 | void __iomem *ioaddr = tp->mmio_addr; |
| 1189 | 1189 | ||
| 1190 | RTL_W16(IntrStatus, 0xffff); | 1190 | RTL_W16(IntrMask, 0x0000); |
| 1191 | RTL_W16(IntrStatus, tp->intr_event); | ||
| 1192 | RTL_R8(ChipCmd); | ||
| 1191 | } | 1193 | } |
| 1192 | 1194 | ||
| 1193 | static unsigned int rtl8169_tbi_reset_pending(struct rtl8169_private *tp) | 1195 | static unsigned int rtl8169_tbi_reset_pending(struct rtl8169_private *tp) |
| @@ -3933,8 +3935,6 @@ static void rtl_hw_reset(struct rtl8169_private *tp) | |||
| 3933 | break; | 3935 | break; |
| 3934 | udelay(100); | 3936 | udelay(100); |
| 3935 | } | 3937 | } |
| 3936 | |||
| 3937 | rtl8169_init_ring_indexes(tp); | ||
| 3938 | } | 3938 | } |
| 3939 | 3939 | ||
| 3940 | static int __devinit | 3940 | static int __devinit |
| @@ -4339,7 +4339,7 @@ static void rtl8169_hw_reset(struct rtl8169_private *tp) | |||
| 4339 | void __iomem *ioaddr = tp->mmio_addr; | 4339 | void __iomem *ioaddr = tp->mmio_addr; |
| 4340 | 4340 | ||
| 4341 | /* Disable interrupts */ | 4341 | /* Disable interrupts */ |
| 4342 | rtl8169_irq_mask_and_ack(ioaddr); | 4342 | rtl8169_irq_mask_and_ack(tp); |
| 4343 | 4343 | ||
| 4344 | rtl_rx_close(tp); | 4344 | rtl_rx_close(tp); |
| 4345 | 4345 | ||
| @@ -4885,8 +4885,7 @@ static void rtl_hw_start_8168(struct net_device *dev) | |||
| 4885 | RTL_W16(IntrMitigate, 0x5151); | 4885 | RTL_W16(IntrMitigate, 0x5151); |
| 4886 | 4886 | ||
| 4887 | /* Work around for RxFIFO overflow. */ | 4887 | /* Work around for RxFIFO overflow. */ |
| 4888 | if (tp->mac_version == RTL_GIGA_MAC_VER_11 || | 4888 | if (tp->mac_version == RTL_GIGA_MAC_VER_11) { |
| 4889 | tp->mac_version == RTL_GIGA_MAC_VER_22) { | ||
| 4890 | tp->intr_event |= RxFIFOOver | PCSTimeout; | 4889 | tp->intr_event |= RxFIFOOver | PCSTimeout; |
| 4891 | tp->intr_event &= ~RxOverflow; | 4890 | tp->intr_event &= ~RxOverflow; |
| 4892 | } | 4891 | } |
| @@ -5076,6 +5075,11 @@ static void rtl_hw_start_8101(struct net_device *dev) | |||
| 5076 | void __iomem *ioaddr = tp->mmio_addr; | 5075 | void __iomem *ioaddr = tp->mmio_addr; |
| 5077 | struct pci_dev *pdev = tp->pci_dev; | 5076 | struct pci_dev *pdev = tp->pci_dev; |
| 5078 | 5077 | ||
| 5078 | if (tp->mac_version >= RTL_GIGA_MAC_VER_30) { | ||
| 5079 | tp->intr_event &= ~RxFIFOOver; | ||
| 5080 | tp->napi_event &= ~RxFIFOOver; | ||
| 5081 | } | ||
| 5082 | |||
| 5079 | if (tp->mac_version == RTL_GIGA_MAC_VER_13 || | 5083 | if (tp->mac_version == RTL_GIGA_MAC_VER_13 || |
| 5080 | tp->mac_version == RTL_GIGA_MAC_VER_16) { | 5084 | tp->mac_version == RTL_GIGA_MAC_VER_16) { |
| 5081 | int cap = pci_pcie_cap(pdev); | 5085 | int cap = pci_pcie_cap(pdev); |
| @@ -5342,7 +5346,7 @@ static void rtl8169_wait_for_quiescence(struct net_device *dev) | |||
| 5342 | /* Wait for any pending NAPI task to complete */ | 5346 | /* Wait for any pending NAPI task to complete */ |
| 5343 | napi_disable(&tp->napi); | 5347 | napi_disable(&tp->napi); |
| 5344 | 5348 | ||
| 5345 | rtl8169_irq_mask_and_ack(ioaddr); | 5349 | rtl8169_irq_mask_and_ack(tp); |
| 5346 | 5350 | ||
| 5347 | tp->intr_mask = 0xffff; | 5351 | tp->intr_mask = 0xffff; |
| 5348 | RTL_W16(IntrMask, tp->intr_event); | 5352 | RTL_W16(IntrMask, tp->intr_event); |
| @@ -5389,14 +5393,16 @@ static void rtl8169_reset_task(struct work_struct *work) | |||
| 5389 | if (!netif_running(dev)) | 5393 | if (!netif_running(dev)) |
| 5390 | goto out_unlock; | 5394 | goto out_unlock; |
| 5391 | 5395 | ||
| 5396 | rtl8169_hw_reset(tp); | ||
| 5397 | |||
| 5392 | rtl8169_wait_for_quiescence(dev); | 5398 | rtl8169_wait_for_quiescence(dev); |
| 5393 | 5399 | ||
| 5394 | for (i = 0; i < NUM_RX_DESC; i++) | 5400 | for (i = 0; i < NUM_RX_DESC; i++) |
| 5395 | rtl8169_mark_to_asic(tp->RxDescArray + i, rx_buf_sz); | 5401 | rtl8169_mark_to_asic(tp->RxDescArray + i, rx_buf_sz); |
| 5396 | 5402 | ||
| 5397 | rtl8169_tx_clear(tp); | 5403 | rtl8169_tx_clear(tp); |
| 5404 | rtl8169_init_ring_indexes(tp); | ||
| 5398 | 5405 | ||
| 5399 | rtl8169_hw_reset(tp); | ||
| 5400 | rtl_hw_start(dev); | 5406 | rtl_hw_start(dev); |
| 5401 | netif_wake_queue(dev); | 5407 | netif_wake_queue(dev); |
| 5402 | rtl8169_check_link_status(dev, tp, tp->mmio_addr); | 5408 | rtl8169_check_link_status(dev, tp, tp->mmio_addr); |
| @@ -5407,11 +5413,6 @@ out_unlock: | |||
| 5407 | 5413 | ||
| 5408 | static void rtl8169_tx_timeout(struct net_device *dev) | 5414 | static void rtl8169_tx_timeout(struct net_device *dev) |
| 5409 | { | 5415 | { |
| 5410 | struct rtl8169_private *tp = netdev_priv(dev); | ||
| 5411 | |||
| 5412 | rtl8169_hw_reset(tp); | ||
| 5413 | |||
| 5414 | /* Let's wait a bit while any (async) irq lands on */ | ||
| 5415 | rtl8169_schedule_work(dev, rtl8169_reset_task); | 5416 | rtl8169_schedule_work(dev, rtl8169_reset_task); |
| 5416 | } | 5417 | } |
| 5417 | 5418 | ||
| @@ -5804,6 +5805,10 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) | |||
| 5804 | */ | 5805 | */ |
| 5805 | status = RTL_R16(IntrStatus); | 5806 | status = RTL_R16(IntrStatus); |
| 5806 | while (status && status != 0xffff) { | 5807 | while (status && status != 0xffff) { |
| 5808 | status &= tp->intr_event; | ||
| 5809 | if (!status) | ||
| 5810 | break; | ||
| 5811 | |||
| 5807 | handled = 1; | 5812 | handled = 1; |
| 5808 | 5813 | ||
| 5809 | /* Handle all of the error cases first. These will reset | 5814 | /* Handle all of the error cases first. These will reset |
| @@ -5818,27 +5823,9 @@ static irqreturn_t rtl8169_interrupt(int irq, void *dev_instance) | |||
| 5818 | switch (tp->mac_version) { | 5823 | switch (tp->mac_version) { |
| 5819 | /* Work around for rx fifo overflow */ | 5824 | /* Work around for rx fifo overflow */ |
| 5820 | case RTL_GIGA_MAC_VER_11: | 5825 | case RTL_GIGA_MAC_VER_11: |
| 5821 | case RTL_GIGA_MAC_VER_22: | ||
| 5822 | case RTL_GIGA_MAC_VER_26: | ||
| 5823 | netif_stop_queue(dev); | 5826 | netif_stop_queue(dev); |
| 5824 | rtl8169_tx_timeout(dev); | 5827 | rtl8169_tx_timeout(dev); |
| 5825 | goto done; | 5828 | goto done; |
| 5826 | /* Testers needed. */ | ||
| 5827 | case RTL_GIGA_MAC_VER_17: | ||
| 5828 | case RTL_GIGA_MAC_VER_19: | ||
| 5829 | case RTL_GIGA_MAC_VER_20: | ||
| 5830 | case RTL_GIGA_MAC_VER_21: | ||
| 5831 | case RTL_GIGA_MAC_VER_23: | ||
| 5832 | case RTL_GIGA_MAC_VER_24: | ||
| 5833 | case RTL_GIGA_MAC_VER_27: | ||
| 5834 | case RTL_GIGA_MAC_VER_28: | ||
| 5835 | case RTL_GIGA_MAC_VER_31: | ||
| 5836 | /* Experimental science. Pktgen proof. */ | ||
| 5837 | case RTL_GIGA_MAC_VER_12: | ||
| 5838 | case RTL_GIGA_MAC_VER_25: | ||
| 5839 | if (status == RxFIFOOver) | ||
| 5840 | goto done; | ||
| 5841 | break; | ||
| 5842 | default: | 5829 | default: |
| 5843 | break; | 5830 | break; |
| 5844 | } | 5831 | } |
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 8ea770a89f25..72cd190b9c1a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | |||
| @@ -781,10 +781,15 @@ static void stmmac_mmc_setup(struct stmmac_priv *priv) | |||
| 781 | unsigned int mode = MMC_CNTRL_RESET_ON_READ | MMC_CNTRL_COUNTER_RESET | | 781 | unsigned int mode = MMC_CNTRL_RESET_ON_READ | MMC_CNTRL_COUNTER_RESET | |
| 782 | MMC_CNTRL_PRESET | MMC_CNTRL_FULL_HALF_PRESET; | 782 | MMC_CNTRL_PRESET | MMC_CNTRL_FULL_HALF_PRESET; |
| 783 | 783 | ||
| 784 | /* Do not manage MMC IRQ (FIXME) */ | 784 | /* Mask MMC irq, counters are managed in SW and registers |
| 785 | * are cleared on each READ eventually. */ | ||
| 785 | dwmac_mmc_intr_all_mask(priv->ioaddr); | 786 | dwmac_mmc_intr_all_mask(priv->ioaddr); |
| 786 | dwmac_mmc_ctrl(priv->ioaddr, mode); | 787 | |
| 787 | memset(&priv->mmc, 0, sizeof(struct stmmac_counters)); | 788 | if (priv->dma_cap.rmon) { |
| 789 | dwmac_mmc_ctrl(priv->ioaddr, mode); | ||
| 790 | memset(&priv->mmc, 0, sizeof(struct stmmac_counters)); | ||
| 791 | } else | ||
| 792 | pr_info(" No MAC Management Counters available"); | ||
| 788 | } | 793 | } |
| 789 | 794 | ||
| 790 | static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv) | 795 | static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv) |
| @@ -1012,8 +1017,7 @@ static int stmmac_open(struct net_device *dev) | |||
| 1012 | memset(&priv->xstats, 0, sizeof(struct stmmac_extra_stats)); | 1017 | memset(&priv->xstats, 0, sizeof(struct stmmac_extra_stats)); |
| 1013 | priv->xstats.threshold = tc; | 1018 | priv->xstats.threshold = tc; |
| 1014 | 1019 | ||
| 1015 | if (priv->dma_cap.rmon) | 1020 | stmmac_mmc_setup(priv); |
| 1016 | stmmac_mmc_setup(priv); | ||
| 1017 | 1021 | ||
| 1018 | /* Start the ball rolling... */ | 1022 | /* Start the ball rolling... */ |
| 1019 | DBG(probe, DEBUG, "%s: DMA RX/TX processes started...\n", dev->name); | 1023 | DBG(probe, DEBUG, "%s: DMA RX/TX processes started...\n", dev->name); |
diff --git a/drivers/net/ethernet/tile/tilepro.c b/drivers/net/ethernet/tile/tilepro.c index 10826d8a2a2d..1187a1169eb2 100644 --- a/drivers/net/ethernet/tile/tilepro.c +++ b/drivers/net/ethernet/tile/tilepro.c | |||
| @@ -926,7 +926,7 @@ static int tile_net_poll(struct napi_struct *napi, int budget) | |||
| 926 | goto done; | 926 | goto done; |
| 927 | 927 | ||
| 928 | /* Re-enable the ingress interrupt. */ | 928 | /* Re-enable the ingress interrupt. */ |
| 929 | enable_percpu_irq(priv->intr_id); | 929 | enable_percpu_irq(priv->intr_id, 0); |
| 930 | 930 | ||
| 931 | /* HACK: Avoid the "rotting packet" problem (see above). */ | 931 | /* HACK: Avoid the "rotting packet" problem (see above). */ |
| 932 | if (qup->__packet_receive_read != | 932 | if (qup->__packet_receive_read != |
| @@ -1296,7 +1296,7 @@ static void tile_net_open_enable(void *dev_ptr) | |||
| 1296 | info->napi_enabled = true; | 1296 | info->napi_enabled = true; |
| 1297 | 1297 | ||
| 1298 | /* Enable the ingress interrupt. */ | 1298 | /* Enable the ingress interrupt. */ |
| 1299 | enable_percpu_irq(priv->intr_id); | 1299 | enable_percpu_irq(priv->intr_id, 0); |
| 1300 | } | 1300 | } |
| 1301 | 1301 | ||
| 1302 | 1302 | ||
| @@ -1697,7 +1697,7 @@ static unsigned int tile_net_tx_frags(lepp_frag_t *frags, | |||
| 1697 | for (i = 0; i < sh->nr_frags; i++) { | 1697 | for (i = 0; i < sh->nr_frags; i++) { |
| 1698 | 1698 | ||
| 1699 | skb_frag_t *f = &sh->frags[i]; | 1699 | skb_frag_t *f = &sh->frags[i]; |
| 1700 | unsigned long pfn = page_to_pfn(f->page); | 1700 | unsigned long pfn = page_to_pfn(skb_frag_page(f)); |
| 1701 | 1701 | ||
| 1702 | /* FIXME: Compute "hash_for_home" properly. */ | 1702 | /* FIXME: Compute "hash_for_home" properly. */ |
| 1703 | /* ISSUE: The hypervisor checks CHIP_HAS_REV1_DMA_PACKETS(). */ | 1703 | /* ISSUE: The hypervisor checks CHIP_HAS_REV1_DMA_PACKETS(). */ |
| @@ -1706,7 +1706,7 @@ static unsigned int tile_net_tx_frags(lepp_frag_t *frags, | |||
| 1706 | /* FIXME: Hmmm. */ | 1706 | /* FIXME: Hmmm. */ |
| 1707 | if (!hash_default) { | 1707 | if (!hash_default) { |
| 1708 | void *va = pfn_to_kaddr(pfn) + f->page_offset; | 1708 | void *va = pfn_to_kaddr(pfn) + f->page_offset; |
| 1709 | BUG_ON(PageHighMem(f->page)); | 1709 | BUG_ON(PageHighMem(skb_frag_page(f))); |
| 1710 | finv_buffer_remote(va, f->size, 0); | 1710 | finv_buffer_remote(va, f->size, 0); |
| 1711 | } | 1711 | } |
| 1712 | 1712 | ||
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index bb88e12101c7..a70244306c94 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig | |||
| @@ -3,7 +3,7 @@ | |||
| 3 | # | 3 | # |
| 4 | 4 | ||
| 5 | menuconfig PHYLIB | 5 | menuconfig PHYLIB |
| 6 | bool "PHY Device support and infrastructure" | 6 | tristate "PHY Device support and infrastructure" |
| 7 | depends on !S390 | 7 | depends on !S390 |
| 8 | depends on NETDEVICES | 8 | depends on NETDEVICES |
| 9 | help | 9 | help |
diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c index 89f829f5f725..f8a6853b692e 100644 --- a/drivers/net/ppp/pptp.c +++ b/drivers/net/ppp/pptp.c | |||
| @@ -423,10 +423,8 @@ static int pptp_bind(struct socket *sock, struct sockaddr *uservaddr, | |||
| 423 | lock_sock(sk); | 423 | lock_sock(sk); |
| 424 | 424 | ||
| 425 | opt->src_addr = sp->sa_addr.pptp; | 425 | opt->src_addr = sp->sa_addr.pptp; |
| 426 | if (add_chan(po)) { | 426 | if (add_chan(po)) |
| 427 | release_sock(sk); | ||
| 428 | error = -EBUSY; | 427 | error = -EBUSY; |
| 429 | } | ||
| 430 | 428 | ||
| 431 | release_sock(sk); | 429 | release_sock(sk); |
| 432 | return error; | 430 | return error; |
diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c index 2f91acccb7db..8873c6e6fb96 100644 --- a/drivers/net/wireless/ath/ath9k/hw.c +++ b/drivers/net/wireless/ath/ath9k/hw.c | |||
| @@ -1827,7 +1827,8 @@ static void ath9k_set_power_sleep(struct ath_hw *ah, int setChip) | |||
| 1827 | } | 1827 | } |
| 1828 | 1828 | ||
| 1829 | /* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */ | 1829 | /* Clear Bit 14 of AR_WA after putting chip into Full Sleep mode. */ |
| 1830 | REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE); | 1830 | if (AR_SREV_9300_20_OR_LATER(ah)) |
| 1831 | REG_WRITE(ah, AR_WA, ah->WARegVal & ~AR_WA_D3_L1_DISABLE); | ||
| 1831 | } | 1832 | } |
| 1832 | 1833 | ||
| 1833 | /* | 1834 | /* |
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c index 93fbe6f40898..d2348a5a7809 100644 --- a/drivers/net/wireless/ath/ath9k/main.c +++ b/drivers/net/wireless/ath/ath9k/main.c | |||
| @@ -286,7 +286,7 @@ static bool ath_complete_reset(struct ath_softc *sc, bool start) | |||
| 286 | ath_start_ani(common); | 286 | ath_start_ani(common); |
| 287 | } | 287 | } |
| 288 | 288 | ||
| 289 | if (ath9k_hw_ops(ah)->antdiv_comb_conf_get && sc->ant_rx != 3) { | 289 | if ((ah->caps.hw_caps & ATH9K_HW_CAP_ANT_DIV_COMB) && sc->ant_rx != 3) { |
| 290 | struct ath_hw_antcomb_conf div_ant_conf; | 290 | struct ath_hw_antcomb_conf div_ant_conf; |
| 291 | u8 lna_conf; | 291 | u8 lna_conf; |
| 292 | 292 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-1000.c b/drivers/net/wireless/iwlwifi/iwl-1000.c index e12b48c2cff6..dd008b0e6417 100644 --- a/drivers/net/wireless/iwlwifi/iwl-1000.c +++ b/drivers/net/wireless/iwlwifi/iwl-1000.c | |||
| @@ -191,6 +191,7 @@ static struct iwl_base_params iwl1000_base_params = { | |||
| 191 | .chain_noise_scale = 1000, | 191 | .chain_noise_scale = 1000, |
| 192 | .wd_timeout = IWL_DEF_WD_TIMEOUT, | 192 | .wd_timeout = IWL_DEF_WD_TIMEOUT, |
| 193 | .max_event_log_size = 128, | 193 | .max_event_log_size = 128, |
| 194 | .wd_disable = true, | ||
| 194 | }; | 195 | }; |
| 195 | static struct iwl_ht_params iwl1000_ht_params = { | 196 | static struct iwl_ht_params iwl1000_ht_params = { |
| 196 | .ht_greenfield_support = true, | 197 | .ht_greenfield_support = true, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c index c511c98a89a8..f55fb2d1af52 100644 --- a/drivers/net/wireless/iwlwifi/iwl-5000.c +++ b/drivers/net/wireless/iwlwifi/iwl-5000.c | |||
| @@ -364,6 +364,7 @@ static struct iwl_base_params iwl5000_base_params = { | |||
| 364 | .wd_timeout = IWL_LONG_WD_TIMEOUT, | 364 | .wd_timeout = IWL_LONG_WD_TIMEOUT, |
| 365 | .max_event_log_size = 512, | 365 | .max_event_log_size = 512, |
| 366 | .no_idle_support = true, | 366 | .no_idle_support = true, |
| 367 | .wd_disable = true, | ||
| 367 | }; | 368 | }; |
| 368 | static struct iwl_ht_params iwl5000_ht_params = { | 369 | static struct iwl_ht_params iwl5000_ht_params = { |
| 369 | .ht_greenfield_support = true, | 370 | .ht_greenfield_support = true, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c index 58a381c01c89..a7a6def40d05 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn-rxon.c | |||
| @@ -528,6 +528,24 @@ int iwlagn_commit_rxon(struct iwl_priv *priv, struct iwl_rxon_context *ctx) | |||
| 528 | return 0; | 528 | return 0; |
| 529 | } | 529 | } |
| 530 | 530 | ||
| 531 | void iwlagn_config_ht40(struct ieee80211_conf *conf, | ||
| 532 | struct iwl_rxon_context *ctx) | ||
| 533 | { | ||
| 534 | if (conf_is_ht40_minus(conf)) { | ||
| 535 | ctx->ht.extension_chan_offset = | ||
| 536 | IEEE80211_HT_PARAM_CHA_SEC_BELOW; | ||
| 537 | ctx->ht.is_40mhz = true; | ||
| 538 | } else if (conf_is_ht40_plus(conf)) { | ||
| 539 | ctx->ht.extension_chan_offset = | ||
| 540 | IEEE80211_HT_PARAM_CHA_SEC_ABOVE; | ||
| 541 | ctx->ht.is_40mhz = true; | ||
| 542 | } else { | ||
| 543 | ctx->ht.extension_chan_offset = | ||
| 544 | IEEE80211_HT_PARAM_CHA_SEC_NONE; | ||
| 545 | ctx->ht.is_40mhz = false; | ||
| 546 | } | ||
| 547 | } | ||
| 548 | |||
| 531 | int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed) | 549 | int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed) |
| 532 | { | 550 | { |
| 533 | struct iwl_priv *priv = hw->priv; | 551 | struct iwl_priv *priv = hw->priv; |
| @@ -586,19 +604,11 @@ int iwlagn_mac_config(struct ieee80211_hw *hw, u32 changed) | |||
| 586 | ctx->ht.enabled = conf_is_ht(conf); | 604 | ctx->ht.enabled = conf_is_ht(conf); |
| 587 | 605 | ||
| 588 | if (ctx->ht.enabled) { | 606 | if (ctx->ht.enabled) { |
| 589 | if (conf_is_ht40_minus(conf)) { | 607 | /* if HT40 is used, it should not change |
| 590 | ctx->ht.extension_chan_offset = | 608 | * after associated except channel switch */ |
| 591 | IEEE80211_HT_PARAM_CHA_SEC_BELOW; | 609 | if (iwl_is_associated_ctx(ctx) && |
| 592 | ctx->ht.is_40mhz = true; | 610 | !ctx->ht.is_40mhz) |
| 593 | } else if (conf_is_ht40_plus(conf)) { | 611 | iwlagn_config_ht40(conf, ctx); |
| 594 | ctx->ht.extension_chan_offset = | ||
| 595 | IEEE80211_HT_PARAM_CHA_SEC_ABOVE; | ||
| 596 | ctx->ht.is_40mhz = true; | ||
| 597 | } else { | ||
| 598 | ctx->ht.extension_chan_offset = | ||
| 599 | IEEE80211_HT_PARAM_CHA_SEC_NONE; | ||
| 600 | ctx->ht.is_40mhz = false; | ||
| 601 | } | ||
| 602 | } else | 612 | } else |
| 603 | ctx->ht.is_40mhz = false; | 613 | ctx->ht.is_40mhz = false; |
| 604 | 614 | ||
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c index ed6283623932..4b2aa1da0953 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c | |||
| @@ -1268,9 +1268,6 @@ int iwl_set_dynamic_key(struct iwl_priv *priv, | |||
| 1268 | 1268 | ||
| 1269 | switch (keyconf->cipher) { | 1269 | switch (keyconf->cipher) { |
| 1270 | case WLAN_CIPHER_SUITE_TKIP: | 1270 | case WLAN_CIPHER_SUITE_TKIP: |
| 1271 | keyconf->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC; | ||
| 1272 | keyconf->flags |= IEEE80211_KEY_FLAG_GENERATE_IV; | ||
| 1273 | |||
| 1274 | if (sta) | 1271 | if (sta) |
| 1275 | addr = sta->addr; | 1272 | addr = sta->addr; |
| 1276 | else /* station mode case only */ | 1273 | else /* station mode case only */ |
| @@ -1283,8 +1280,6 @@ int iwl_set_dynamic_key(struct iwl_priv *priv, | |||
| 1283 | seq.tkip.iv32, p1k, CMD_SYNC); | 1280 | seq.tkip.iv32, p1k, CMD_SYNC); |
| 1284 | break; | 1281 | break; |
| 1285 | case WLAN_CIPHER_SUITE_CCMP: | 1282 | case WLAN_CIPHER_SUITE_CCMP: |
| 1286 | keyconf->flags |= IEEE80211_KEY_FLAG_GENERATE_IV; | ||
| 1287 | /* fall through */ | ||
| 1288 | case WLAN_CIPHER_SUITE_WEP40: | 1283 | case WLAN_CIPHER_SUITE_WEP40: |
| 1289 | case WLAN_CIPHER_SUITE_WEP104: | 1284 | case WLAN_CIPHER_SUITE_WEP104: |
| 1290 | ret = iwlagn_send_sta_key(priv, keyconf, sta_id, | 1285 | ret = iwlagn_send_sta_key(priv, keyconf, sta_id, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c index ccba69b7f8a7..bacc06c95e7a 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn.c +++ b/drivers/net/wireless/iwlwifi/iwl-agn.c | |||
| @@ -2316,6 +2316,17 @@ static int iwlagn_mac_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, | |||
| 2316 | return -EOPNOTSUPP; | 2316 | return -EOPNOTSUPP; |
| 2317 | } | 2317 | } |
| 2318 | 2318 | ||
| 2319 | switch (key->cipher) { | ||
| 2320 | case WLAN_CIPHER_SUITE_TKIP: | ||
| 2321 | key->flags |= IEEE80211_KEY_FLAG_GENERATE_MMIC; | ||
| 2322 | /* fall through */ | ||
| 2323 | case WLAN_CIPHER_SUITE_CCMP: | ||
| 2324 | key->flags |= IEEE80211_KEY_FLAG_GENERATE_IV; | ||
| 2325 | break; | ||
| 2326 | default: | ||
| 2327 | break; | ||
| 2328 | } | ||
| 2329 | |||
| 2319 | /* | 2330 | /* |
| 2320 | * We could program these keys into the hardware as well, but we | 2331 | * We could program these keys into the hardware as well, but we |
| 2321 | * don't expect much multicast traffic in IBSS and having keys | 2332 | * don't expect much multicast traffic in IBSS and having keys |
| @@ -2599,21 +2610,9 @@ static void iwlagn_mac_channel_switch(struct ieee80211_hw *hw, | |||
| 2599 | 2610 | ||
| 2600 | /* Configure HT40 channels */ | 2611 | /* Configure HT40 channels */ |
| 2601 | ctx->ht.enabled = conf_is_ht(conf); | 2612 | ctx->ht.enabled = conf_is_ht(conf); |
| 2602 | if (ctx->ht.enabled) { | 2613 | if (ctx->ht.enabled) |
| 2603 | if (conf_is_ht40_minus(conf)) { | 2614 | iwlagn_config_ht40(conf, ctx); |
| 2604 | ctx->ht.extension_chan_offset = | 2615 | else |
| 2605 | IEEE80211_HT_PARAM_CHA_SEC_BELOW; | ||
| 2606 | ctx->ht.is_40mhz = true; | ||
| 2607 | } else if (conf_is_ht40_plus(conf)) { | ||
| 2608 | ctx->ht.extension_chan_offset = | ||
| 2609 | IEEE80211_HT_PARAM_CHA_SEC_ABOVE; | ||
| 2610 | ctx->ht.is_40mhz = true; | ||
| 2611 | } else { | ||
| 2612 | ctx->ht.extension_chan_offset = | ||
| 2613 | IEEE80211_HT_PARAM_CHA_SEC_NONE; | ||
| 2614 | ctx->ht.is_40mhz = false; | ||
| 2615 | } | ||
| 2616 | } else | ||
| 2617 | ctx->ht.is_40mhz = false; | 2616 | ctx->ht.is_40mhz = false; |
| 2618 | 2617 | ||
| 2619 | if ((le16_to_cpu(ctx->staging.channel) != ch)) | 2618 | if ((le16_to_cpu(ctx->staging.channel) != ch)) |
| @@ -3499,9 +3498,10 @@ MODULE_PARM_DESC(plcp_check, "Check plcp health (default: 1 [enabled])"); | |||
| 3499 | module_param_named(ack_check, iwlagn_mod_params.ack_check, bool, S_IRUGO); | 3498 | module_param_named(ack_check, iwlagn_mod_params.ack_check, bool, S_IRUGO); |
| 3500 | MODULE_PARM_DESC(ack_check, "Check ack health (default: 0 [disabled])"); | 3499 | MODULE_PARM_DESC(ack_check, "Check ack health (default: 0 [disabled])"); |
| 3501 | 3500 | ||
| 3502 | module_param_named(wd_disable, iwlagn_mod_params.wd_disable, bool, S_IRUGO); | 3501 | module_param_named(wd_disable, iwlagn_mod_params.wd_disable, int, S_IRUGO); |
| 3503 | MODULE_PARM_DESC(wd_disable, | 3502 | MODULE_PARM_DESC(wd_disable, |
| 3504 | "Disable stuck queue watchdog timer (default: 0 [enabled])"); | 3503 | "Disable stuck queue watchdog timer 0=system default, " |
| 3504 | "1=disable, 2=enable (default: 0)"); | ||
| 3505 | 3505 | ||
| 3506 | /* | 3506 | /* |
| 3507 | * set bt_coex_active to true, uCode will do kill/defer | 3507 | * set bt_coex_active to true, uCode will do kill/defer |
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.h b/drivers/net/wireless/iwlwifi/iwl-agn.h index 5b936ec1a541..3856abaea507 100644 --- a/drivers/net/wireless/iwlwifi/iwl-agn.h +++ b/drivers/net/wireless/iwlwifi/iwl-agn.h | |||
| @@ -86,6 +86,8 @@ void iwlagn_bss_info_changed(struct ieee80211_hw *hw, | |||
| 86 | struct ieee80211_vif *vif, | 86 | struct ieee80211_vif *vif, |
| 87 | struct ieee80211_bss_conf *bss_conf, | 87 | struct ieee80211_bss_conf *bss_conf, |
| 88 | u32 changes); | 88 | u32 changes); |
| 89 | void iwlagn_config_ht40(struct ieee80211_conf *conf, | ||
| 90 | struct iwl_rxon_context *ctx); | ||
| 89 | 91 | ||
| 90 | /* uCode */ | 92 | /* uCode */ |
| 91 | int iwlagn_rx_calib_result(struct iwl_priv *priv, | 93 | int iwlagn_rx_calib_result(struct iwl_priv *priv, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.c b/drivers/net/wireless/iwlwifi/iwl-core.c index 001fdf140abb..fcf54160e4ed 100644 --- a/drivers/net/wireless/iwlwifi/iwl-core.c +++ b/drivers/net/wireless/iwlwifi/iwl-core.c | |||
| @@ -1810,11 +1810,23 @@ void iwl_setup_watchdog(struct iwl_priv *priv) | |||
| 1810 | { | 1810 | { |
| 1811 | unsigned int timeout = priv->cfg->base_params->wd_timeout; | 1811 | unsigned int timeout = priv->cfg->base_params->wd_timeout; |
| 1812 | 1812 | ||
| 1813 | if (timeout && !iwlagn_mod_params.wd_disable) | 1813 | if (!iwlagn_mod_params.wd_disable) { |
| 1814 | mod_timer(&priv->watchdog, | 1814 | /* use system default */ |
| 1815 | jiffies + msecs_to_jiffies(IWL_WD_TICK(timeout))); | 1815 | if (timeout && !priv->cfg->base_params->wd_disable) |
| 1816 | else | 1816 | mod_timer(&priv->watchdog, |
| 1817 | del_timer(&priv->watchdog); | 1817 | jiffies + |
| 1818 | msecs_to_jiffies(IWL_WD_TICK(timeout))); | ||
| 1819 | else | ||
| 1820 | del_timer(&priv->watchdog); | ||
| 1821 | } else { | ||
| 1822 | /* module parameter overwrite default configuration */ | ||
| 1823 | if (timeout && iwlagn_mod_params.wd_disable == 2) | ||
| 1824 | mod_timer(&priv->watchdog, | ||
| 1825 | jiffies + | ||
| 1826 | msecs_to_jiffies(IWL_WD_TICK(timeout))); | ||
| 1827 | else | ||
| 1828 | del_timer(&priv->watchdog); | ||
| 1829 | } | ||
| 1818 | } | 1830 | } |
| 1819 | 1831 | ||
| 1820 | /** | 1832 | /** |
diff --git a/drivers/net/wireless/iwlwifi/iwl-core.h b/drivers/net/wireless/iwlwifi/iwl-core.h index 137da3380704..f2fc288f3dd3 100644 --- a/drivers/net/wireless/iwlwifi/iwl-core.h +++ b/drivers/net/wireless/iwlwifi/iwl-core.h | |||
| @@ -113,6 +113,7 @@ struct iwl_lib_ops { | |||
| 113 | * @shadow_reg_enable: HW shadhow register bit | 113 | * @shadow_reg_enable: HW shadhow register bit |
| 114 | * @no_idle_support: do not support idle mode | 114 | * @no_idle_support: do not support idle mode |
| 115 | * @hd_v2: v2 of enhanced sensitivity value, used for 2000 series and up | 115 | * @hd_v2: v2 of enhanced sensitivity value, used for 2000 series and up |
| 116 | * wd_disable: disable watchdog timer | ||
| 116 | */ | 117 | */ |
| 117 | struct iwl_base_params { | 118 | struct iwl_base_params { |
| 118 | int eeprom_size; | 119 | int eeprom_size; |
| @@ -134,6 +135,7 @@ struct iwl_base_params { | |||
| 134 | const bool shadow_reg_enable; | 135 | const bool shadow_reg_enable; |
| 135 | const bool no_idle_support; | 136 | const bool no_idle_support; |
| 136 | const bool hd_v2; | 137 | const bool hd_v2; |
| 138 | const bool wd_disable; | ||
| 137 | }; | 139 | }; |
| 138 | /* | 140 | /* |
| 139 | * @advanced_bt_coexist: support advanced bt coexist | 141 | * @advanced_bt_coexist: support advanced bt coexist |
diff --git a/drivers/net/wireless/iwlwifi/iwl-shared.h b/drivers/net/wireless/iwlwifi/iwl-shared.h index 1f7a93c67c45..14eaf37ce3b1 100644 --- a/drivers/net/wireless/iwlwifi/iwl-shared.h +++ b/drivers/net/wireless/iwlwifi/iwl-shared.h | |||
| @@ -120,7 +120,7 @@ extern struct iwl_mod_params iwlagn_mod_params; | |||
| 120 | * @restart_fw: restart firmware, default = 1 | 120 | * @restart_fw: restart firmware, default = 1 |
| 121 | * @plcp_check: enable plcp health check, default = true | 121 | * @plcp_check: enable plcp health check, default = true |
| 122 | * @ack_check: disable ack health check, default = false | 122 | * @ack_check: disable ack health check, default = false |
| 123 | * @wd_disable: enable stuck queue check, default = false | 123 | * @wd_disable: enable stuck queue check, default = 0 |
| 124 | * @bt_coex_active: enable bt coex, default = true | 124 | * @bt_coex_active: enable bt coex, default = true |
| 125 | * @led_mode: system default, default = 0 | 125 | * @led_mode: system default, default = 0 |
| 126 | * @no_sleep_autoadjust: disable autoadjust, default = true | 126 | * @no_sleep_autoadjust: disable autoadjust, default = true |
| @@ -141,7 +141,7 @@ struct iwl_mod_params { | |||
| 141 | int restart_fw; | 141 | int restart_fw; |
| 142 | bool plcp_check; | 142 | bool plcp_check; |
| 143 | bool ack_check; | 143 | bool ack_check; |
| 144 | bool wd_disable; | 144 | int wd_disable; |
| 145 | bool bt_coex_active; | 145 | bool bt_coex_active; |
| 146 | int led_mode; | 146 | int led_mode; |
| 147 | bool no_sleep_autoadjust; | 147 | bool no_sleep_autoadjust; |
diff --git a/drivers/net/wireless/p54/p54spi.c b/drivers/net/wireless/p54/p54spi.c index f18df82eeb92..78d0d6988553 100644 --- a/drivers/net/wireless/p54/p54spi.c +++ b/drivers/net/wireless/p54/p54spi.c | |||
| @@ -588,8 +588,6 @@ static void p54spi_op_stop(struct ieee80211_hw *dev) | |||
| 588 | 588 | ||
| 589 | WARN_ON(priv->fw_state != FW_STATE_READY); | 589 | WARN_ON(priv->fw_state != FW_STATE_READY); |
| 590 | 590 | ||
| 591 | cancel_work_sync(&priv->work); | ||
| 592 | |||
| 593 | p54spi_power_off(priv); | 591 | p54spi_power_off(priv); |
| 594 | spin_lock_irqsave(&priv->tx_lock, flags); | 592 | spin_lock_irqsave(&priv->tx_lock, flags); |
| 595 | INIT_LIST_HEAD(&priv->tx_pending); | 593 | INIT_LIST_HEAD(&priv->tx_pending); |
| @@ -597,6 +595,8 @@ static void p54spi_op_stop(struct ieee80211_hw *dev) | |||
| 597 | 595 | ||
| 598 | priv->fw_state = FW_STATE_OFF; | 596 | priv->fw_state = FW_STATE_OFF; |
| 599 | mutex_unlock(&priv->mutex); | 597 | mutex_unlock(&priv->mutex); |
| 598 | |||
| 599 | cancel_work_sync(&priv->work); | ||
| 600 | } | 600 | } |
| 601 | 601 | ||
| 602 | static int __devinit p54spi_probe(struct spi_device *spi) | 602 | static int __devinit p54spi_probe(struct spi_device *spi) |
| @@ -656,6 +656,7 @@ static int __devinit p54spi_probe(struct spi_device *spi) | |||
| 656 | init_completion(&priv->fw_comp); | 656 | init_completion(&priv->fw_comp); |
| 657 | INIT_LIST_HEAD(&priv->tx_pending); | 657 | INIT_LIST_HEAD(&priv->tx_pending); |
| 658 | mutex_init(&priv->mutex); | 658 | mutex_init(&priv->mutex); |
| 659 | spin_lock_init(&priv->tx_lock); | ||
| 659 | SET_IEEE80211_DEV(hw, &spi->dev); | 660 | SET_IEEE80211_DEV(hw, &spi->dev); |
| 660 | priv->common.open = p54spi_op_start; | 661 | priv->common.open = p54spi_op_start; |
| 661 | priv->common.stop = p54spi_op_stop; | 662 | priv->common.stop = p54spi_op_stop; |
diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c index d97a2caf582b..bc2ba80c47bb 100644 --- a/drivers/net/wireless/prism54/isl_ioctl.c +++ b/drivers/net/wireless/prism54/isl_ioctl.c | |||
| @@ -778,7 +778,7 @@ prism54_get_essid(struct net_device *ndev, struct iw_request_info *info, | |||
| 778 | dwrq->flags = 0; | 778 | dwrq->flags = 0; |
| 779 | dwrq->length = 0; | 779 | dwrq->length = 0; |
| 780 | } | 780 | } |
| 781 | essid->octets[essid->length] = '\0'; | 781 | essid->octets[dwrq->length] = '\0'; |
| 782 | memcpy(extra, essid->octets, dwrq->length); | 782 | memcpy(extra, essid->octets, dwrq->length); |
| 783 | kfree(essid); | 783 | kfree(essid); |
| 784 | 784 | ||
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c index 3f183a15186e..1ba079dffb11 100644 --- a/drivers/net/wireless/rt2x00/rt2800lib.c +++ b/drivers/net/wireless/rt2x00/rt2800lib.c | |||
| @@ -3771,7 +3771,7 @@ static void rt2800_efuse_read(struct rt2x00_dev *rt2x00dev, unsigned int i) | |||
| 3771 | /* Apparently the data is read from end to start */ | 3771 | /* Apparently the data is read from end to start */ |
| 3772 | rt2800_register_read_lock(rt2x00dev, EFUSE_DATA3, ®); | 3772 | rt2800_register_read_lock(rt2x00dev, EFUSE_DATA3, ®); |
| 3773 | /* The returned value is in CPU order, but eeprom is le */ | 3773 | /* The returned value is in CPU order, but eeprom is le */ |
| 3774 | rt2x00dev->eeprom[i] = cpu_to_le32(reg); | 3774 | *(u32 *)&rt2x00dev->eeprom[i] = cpu_to_le32(reg); |
| 3775 | rt2800_register_read_lock(rt2x00dev, EFUSE_DATA2, ®); | 3775 | rt2800_register_read_lock(rt2x00dev, EFUSE_DATA2, ®); |
| 3776 | *(u32 *)&rt2x00dev->eeprom[i + 2] = cpu_to_le32(reg); | 3776 | *(u32 *)&rt2x00dev->eeprom[i + 2] = cpu_to_le32(reg); |
| 3777 | rt2800_register_read_lock(rt2x00dev, EFUSE_DATA1, ®); | 3777 | rt2800_register_read_lock(rt2x00dev, EFUSE_DATA1, ®); |
diff --git a/drivers/net/wireless/rtlwifi/ps.c b/drivers/net/wireless/rtlwifi/ps.c index db5262844543..55c8e50f45fd 100644 --- a/drivers/net/wireless/rtlwifi/ps.c +++ b/drivers/net/wireless/rtlwifi/ps.c | |||
| @@ -395,7 +395,7 @@ void rtl_lps_enter(struct ieee80211_hw *hw) | |||
| 395 | if (mac->link_state != MAC80211_LINKED) | 395 | if (mac->link_state != MAC80211_LINKED) |
| 396 | return; | 396 | return; |
| 397 | 397 | ||
| 398 | spin_lock(&rtlpriv->locks.lps_lock); | 398 | spin_lock_irq(&rtlpriv->locks.lps_lock); |
| 399 | 399 | ||
| 400 | /* Idle for a while if we connect to AP a while ago. */ | 400 | /* Idle for a while if we connect to AP a while ago. */ |
| 401 | if (mac->cnt_after_linked >= 2) { | 401 | if (mac->cnt_after_linked >= 2) { |
| @@ -407,7 +407,7 @@ void rtl_lps_enter(struct ieee80211_hw *hw) | |||
| 407 | } | 407 | } |
| 408 | } | 408 | } |
| 409 | 409 | ||
| 410 | spin_unlock(&rtlpriv->locks.lps_lock); | 410 | spin_unlock_irq(&rtlpriv->locks.lps_lock); |
| 411 | } | 411 | } |
| 412 | 412 | ||
| 413 | /*Leave the leisure power save mode.*/ | 413 | /*Leave the leisure power save mode.*/ |
| @@ -416,8 +416,9 @@ void rtl_lps_leave(struct ieee80211_hw *hw) | |||
| 416 | struct rtl_priv *rtlpriv = rtl_priv(hw); | 416 | struct rtl_priv *rtlpriv = rtl_priv(hw); |
| 417 | struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw)); | 417 | struct rtl_ps_ctl *ppsc = rtl_psc(rtl_priv(hw)); |
| 418 | struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); | 418 | struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw)); |
| 419 | unsigned long flags; | ||
| 419 | 420 | ||
| 420 | spin_lock(&rtlpriv->locks.lps_lock); | 421 | spin_lock_irqsave(&rtlpriv->locks.lps_lock, flags); |
| 421 | 422 | ||
| 422 | if (ppsc->fwctrl_lps) { | 423 | if (ppsc->fwctrl_lps) { |
| 423 | if (ppsc->dot11_psmode != EACTIVE) { | 424 | if (ppsc->dot11_psmode != EACTIVE) { |
| @@ -438,7 +439,7 @@ void rtl_lps_leave(struct ieee80211_hw *hw) | |||
| 438 | rtl_lps_set_psmode(hw, EACTIVE); | 439 | rtl_lps_set_psmode(hw, EACTIVE); |
| 439 | } | 440 | } |
| 440 | } | 441 | } |
| 441 | spin_unlock(&rtlpriv->locks.lps_lock); | 442 | spin_unlock_irqrestore(&rtlpriv->locks.lps_lock, flags); |
| 442 | } | 443 | } |
| 443 | 444 | ||
| 444 | /* For sw LPS*/ | 445 | /* For sw LPS*/ |
| @@ -539,9 +540,9 @@ void rtl_swlps_rf_awake(struct ieee80211_hw *hw) | |||
| 539 | RT_CLEAR_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM); | 540 | RT_CLEAR_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM); |
| 540 | } | 541 | } |
| 541 | 542 | ||
| 542 | spin_lock(&rtlpriv->locks.lps_lock); | 543 | spin_lock_irq(&rtlpriv->locks.lps_lock); |
| 543 | rtl_ps_set_rf_state(hw, ERFON, RF_CHANGE_BY_PS); | 544 | rtl_ps_set_rf_state(hw, ERFON, RF_CHANGE_BY_PS); |
| 544 | spin_unlock(&rtlpriv->locks.lps_lock); | 545 | spin_unlock_irq(&rtlpriv->locks.lps_lock); |
| 545 | } | 546 | } |
| 546 | 547 | ||
| 547 | void rtl_swlps_rfon_wq_callback(void *data) | 548 | void rtl_swlps_rfon_wq_callback(void *data) |
| @@ -574,9 +575,9 @@ void rtl_swlps_rf_sleep(struct ieee80211_hw *hw) | |||
| 574 | if (rtlpriv->link_info.busytraffic) | 575 | if (rtlpriv->link_info.busytraffic) |
| 575 | return; | 576 | return; |
| 576 | 577 | ||
| 577 | spin_lock(&rtlpriv->locks.lps_lock); | 578 | spin_lock_irq(&rtlpriv->locks.lps_lock); |
| 578 | rtl_ps_set_rf_state(hw, ERFSLEEP, RF_CHANGE_BY_PS); | 579 | rtl_ps_set_rf_state(hw, ERFSLEEP, RF_CHANGE_BY_PS); |
| 579 | spin_unlock(&rtlpriv->locks.lps_lock); | 580 | spin_unlock_irq(&rtlpriv->locks.lps_lock); |
| 580 | 581 | ||
| 581 | if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM && | 582 | if (ppsc->reg_rfps_level & RT_RF_OFF_LEVL_ASPM && |
| 582 | !RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM)) { | 583 | !RT_IN_PS_LEVEL(ppsc, RT_PS_LEVEL_ASPM)) { |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c index 592a10ac5929..3b585aadabfc 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192ce/phy.c | |||
| @@ -569,7 +569,7 @@ static bool _rtl92ce_phy_set_rf_power_state(struct ieee80211_hw *hw, | |||
| 569 | } | 569 | } |
| 570 | case ERFSLEEP:{ | 570 | case ERFSLEEP:{ |
| 571 | if (ppsc->rfpwr_state == ERFOFF) | 571 | if (ppsc->rfpwr_state == ERFOFF) |
| 572 | break; | 572 | return false; |
| 573 | for (queue_id = 0, i = 0; | 573 | for (queue_id = 0, i = 0; |
| 574 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { | 574 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { |
| 575 | ring = &pcipriv->dev.tx_ring[queue_id]; | 575 | ring = &pcipriv->dev.tx_ring[queue_id]; |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c index 72852900df84..e49cf2244c75 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/phy.c | |||
| @@ -548,7 +548,7 @@ static bool _rtl92cu_phy_set_rf_power_state(struct ieee80211_hw *hw, | |||
| 548 | break; | 548 | break; |
| 549 | case ERFSLEEP: | 549 | case ERFSLEEP: |
| 550 | if (ppsc->rfpwr_state == ERFOFF) | 550 | if (ppsc->rfpwr_state == ERFOFF) |
| 551 | break; | 551 | return false; |
| 552 | for (queue_id = 0, i = 0; | 552 | for (queue_id = 0, i = 0; |
| 553 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { | 553 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { |
| 554 | ring = &pcipriv->dev.tx_ring[queue_id]; | 554 | ring = &pcipriv->dev.tx_ring[queue_id]; |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c index 3ac7af1c5509..0883349e1c83 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/phy.c | |||
| @@ -3374,7 +3374,7 @@ bool rtl92d_phy_set_rf_power_state(struct ieee80211_hw *hw, | |||
| 3374 | break; | 3374 | break; |
| 3375 | case ERFSLEEP: | 3375 | case ERFSLEEP: |
| 3376 | if (ppsc->rfpwr_state == ERFOFF) | 3376 | if (ppsc->rfpwr_state == ERFOFF) |
| 3377 | break; | 3377 | return false; |
| 3378 | 3378 | ||
| 3379 | for (queue_id = 0, i = 0; | 3379 | for (queue_id = 0, i = 0; |
| 3380 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { | 3380 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { |
diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c index f27171af979c..f10ac1ad9087 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/phy.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/phy.c | |||
| @@ -602,7 +602,7 @@ bool rtl92s_phy_set_rf_power_state(struct ieee80211_hw *hw, | |||
| 602 | } | 602 | } |
| 603 | case ERFSLEEP: | 603 | case ERFSLEEP: |
| 604 | if (ppsc->rfpwr_state == ERFOFF) | 604 | if (ppsc->rfpwr_state == ERFOFF) |
| 605 | break; | 605 | return false; |
| 606 | 606 | ||
| 607 | for (queue_id = 0, i = 0; | 607 | for (queue_id = 0, i = 0; |
| 608 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { | 608 | queue_id < RTL_PCI_MAX_TX_QUEUE_COUNT;) { |
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 0cb594c86090..15e332d08c8d 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c | |||
| @@ -1021,7 +1021,7 @@ static int xen_netbk_tx_check_gop(struct xen_netbk *netbk, | |||
| 1021 | pending_idx = *((u16 *)skb->data); | 1021 | pending_idx = *((u16 *)skb->data); |
| 1022 | xen_netbk_idx_release(netbk, pending_idx); | 1022 | xen_netbk_idx_release(netbk, pending_idx); |
| 1023 | for (j = start; j < i; j++) { | 1023 | for (j = start; j < i; j++) { |
| 1024 | pending_idx = frag_get_pending_idx(&shinfo->frags[i]); | 1024 | pending_idx = frag_get_pending_idx(&shinfo->frags[j]); |
| 1025 | xen_netbk_idx_release(netbk, pending_idx); | 1025 | xen_netbk_idx_release(netbk, pending_idx); |
| 1026 | } | 1026 | } |
| 1027 | 1027 | ||
| @@ -1668,7 +1668,7 @@ static int __init netback_init(void) | |||
| 1668 | "netback/%u", group); | 1668 | "netback/%u", group); |
| 1669 | 1669 | ||
| 1670 | if (IS_ERR(netbk->task)) { | 1670 | if (IS_ERR(netbk->task)) { |
| 1671 | printk(KERN_ALERT "kthread_run() fails at netback\n"); | 1671 | printk(KERN_ALERT "kthread_create() fails at netback\n"); |
| 1672 | del_timer(&netbk->net_timer); | 1672 | del_timer(&netbk->net_timer); |
| 1673 | rc = PTR_ERR(netbk->task); | 1673 | rc = PTR_ERR(netbk->task); |
| 1674 | goto failed_init; | 1674 | goto failed_init; |
diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 791270b8bd1c..0f0cfa3bca30 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c | |||
| @@ -26,11 +26,6 @@ | |||
| 26 | #include <linux/string.h> | 26 | #include <linux/string.h> |
| 27 | #include <linux/slab.h> | 27 | #include <linux/slab.h> |
| 28 | 28 | ||
| 29 | /* For archs that don't support NO_IRQ (such as x86), provide a dummy value */ | ||
| 30 | #ifndef NO_IRQ | ||
| 31 | #define NO_IRQ 0 | ||
| 32 | #endif | ||
| 33 | |||
| 34 | /** | 29 | /** |
| 35 | * irq_of_parse_and_map - Parse and map an interrupt into linux virq space | 30 | * irq_of_parse_and_map - Parse and map an interrupt into linux virq space |
| 36 | * @device: Device node of the device whose interrupt is to be mapped | 31 | * @device: Device node of the device whose interrupt is to be mapped |
| @@ -44,7 +39,7 @@ unsigned int irq_of_parse_and_map(struct device_node *dev, int index) | |||
| 44 | struct of_irq oirq; | 39 | struct of_irq oirq; |
| 45 | 40 | ||
| 46 | if (of_irq_map_one(dev, index, &oirq)) | 41 | if (of_irq_map_one(dev, index, &oirq)) |
| 47 | return NO_IRQ; | 42 | return 0; |
| 48 | 43 | ||
| 49 | return irq_create_of_mapping(oirq.controller, oirq.specifier, | 44 | return irq_create_of_mapping(oirq.controller, oirq.specifier, |
| 50 | oirq.size); | 45 | oirq.size); |
| @@ -345,7 +340,7 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r) | |||
| 345 | 340 | ||
| 346 | /* Only dereference the resource if both the | 341 | /* Only dereference the resource if both the |
| 347 | * resource and the irq are valid. */ | 342 | * resource and the irq are valid. */ |
| 348 | if (r && irq != NO_IRQ) { | 343 | if (r && irq) { |
| 349 | r->start = r->end = irq; | 344 | r->start = r->end = irq; |
| 350 | r->flags = IORESOURCE_IRQ; | 345 | r->flags = IORESOURCE_IRQ; |
| 351 | r->name = dev->full_name; | 346 | r->name = dev->full_name; |
| @@ -363,7 +358,7 @@ int of_irq_count(struct device_node *dev) | |||
| 363 | { | 358 | { |
| 364 | int nr = 0; | 359 | int nr = 0; |
| 365 | 360 | ||
| 366 | while (of_irq_to_resource(dev, nr, NULL) != NO_IRQ) | 361 | while (of_irq_to_resource(dev, nr, NULL)) |
| 367 | nr++; | 362 | nr++; |
| 368 | 363 | ||
| 369 | return nr; | 364 | return nr; |
| @@ -383,7 +378,7 @@ int of_irq_to_resource_table(struct device_node *dev, struct resource *res, | |||
| 383 | int i; | 378 | int i; |
| 384 | 379 | ||
| 385 | for (i = 0; i < nr_irqs; i++, res++) | 380 | for (i = 0; i < nr_irqs; i++, res++) |
| 386 | if (of_irq_to_resource(dev, i, res) == NO_IRQ) | 381 | if (!of_irq_to_resource(dev, i, res)) |
| 387 | break; | 382 | break; |
| 388 | 383 | ||
| 389 | return i; | 384 | return i; |
| @@ -424,6 +419,8 @@ void __init of_irq_init(const struct of_device_id *matches) | |||
| 424 | 419 | ||
| 425 | desc->dev = np; | 420 | desc->dev = np; |
| 426 | desc->interrupt_parent = of_irq_find_parent(np); | 421 | desc->interrupt_parent = of_irq_find_parent(np); |
| 422 | if (desc->interrupt_parent == np) | ||
| 423 | desc->interrupt_parent = NULL; | ||
| 427 | list_add_tail(&desc->list, &intc_desc_list); | 424 | list_add_tail(&desc->list, &intc_desc_list); |
| 428 | } | 425 | } |
| 429 | 426 | ||
diff --git a/drivers/oprofile/oprof.c b/drivers/oprofile/oprof.c index dccd8636095c..f8c752e408a6 100644 --- a/drivers/oprofile/oprof.c +++ b/drivers/oprofile/oprof.c | |||
| @@ -239,26 +239,45 @@ int oprofile_set_ulong(unsigned long *addr, unsigned long val) | |||
| 239 | return err; | 239 | return err; |
| 240 | } | 240 | } |
| 241 | 241 | ||
| 242 | static int timer_mode; | ||
| 243 | |||
| 242 | static int __init oprofile_init(void) | 244 | static int __init oprofile_init(void) |
| 243 | { | 245 | { |
| 244 | int err; | 246 | int err; |
| 245 | 247 | ||
| 248 | /* always init architecture to setup backtrace support */ | ||
| 246 | err = oprofile_arch_init(&oprofile_ops); | 249 | err = oprofile_arch_init(&oprofile_ops); |
| 247 | if (err < 0 || timer) { | 250 | |
| 248 | printk(KERN_INFO "oprofile: using timer interrupt.\n"); | 251 | timer_mode = err || timer; /* fall back to timer mode on errors */ |
| 252 | if (timer_mode) { | ||
| 253 | if (!err) | ||
| 254 | oprofile_arch_exit(); | ||
| 249 | err = oprofile_timer_init(&oprofile_ops); | 255 | err = oprofile_timer_init(&oprofile_ops); |
| 250 | if (err) | 256 | if (err) |
| 251 | return err; | 257 | return err; |
| 252 | } | 258 | } |
| 253 | return oprofilefs_register(); | 259 | |
| 260 | err = oprofilefs_register(); | ||
| 261 | if (!err) | ||
| 262 | return 0; | ||
| 263 | |||
| 264 | /* failed */ | ||
| 265 | if (timer_mode) | ||
| 266 | oprofile_timer_exit(); | ||
| 267 | else | ||
| 268 | oprofile_arch_exit(); | ||
| 269 | |||
| 270 | return err; | ||
| 254 | } | 271 | } |
| 255 | 272 | ||
| 256 | 273 | ||
| 257 | static void __exit oprofile_exit(void) | 274 | static void __exit oprofile_exit(void) |
| 258 | { | 275 | { |
| 259 | oprofile_timer_exit(); | ||
| 260 | oprofilefs_unregister(); | 276 | oprofilefs_unregister(); |
| 261 | oprofile_arch_exit(); | 277 | if (timer_mode) |
| 278 | oprofile_timer_exit(); | ||
| 279 | else | ||
| 280 | oprofile_arch_exit(); | ||
| 262 | } | 281 | } |
| 263 | 282 | ||
| 264 | 283 | ||
diff --git a/drivers/oprofile/timer_int.c b/drivers/oprofile/timer_int.c index 3ef44624f510..878fba126582 100644 --- a/drivers/oprofile/timer_int.c +++ b/drivers/oprofile/timer_int.c | |||
| @@ -110,6 +110,7 @@ int oprofile_timer_init(struct oprofile_operations *ops) | |||
| 110 | ops->start = oprofile_hrtimer_start; | 110 | ops->start = oprofile_hrtimer_start; |
| 111 | ops->stop = oprofile_hrtimer_stop; | 111 | ops->stop = oprofile_hrtimer_stop; |
| 112 | ops->cpu_type = "timer"; | 112 | ops->cpu_type = "timer"; |
| 113 | printk(KERN_INFO "oprofile: using timer interrupt.\n"); | ||
| 113 | return 0; | 114 | return 0; |
| 114 | } | 115 | } |
| 115 | 116 | ||
diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig index b6f9749b4fa7..f02b5235056d 100644 --- a/drivers/pci/Kconfig +++ b/drivers/pci/Kconfig | |||
| @@ -76,6 +76,7 @@ config PCI_IOV | |||
| 76 | 76 | ||
| 77 | config PCI_PRI | 77 | config PCI_PRI |
| 78 | bool "PCI PRI support" | 78 | bool "PCI PRI support" |
| 79 | depends on PCI | ||
| 79 | select PCI_ATS | 80 | select PCI_ATS |
| 80 | help | 81 | help |
| 81 | PRI is the PCI Page Request Interface. It allows PCI devices that are | 82 | PRI is the PCI Page Request Interface. It allows PCI devices that are |
diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 7ec56fb0bd78..b0dd08e6a9da 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c | |||
| @@ -13,6 +13,7 @@ | |||
| 13 | #include <linux/export.h> | 13 | #include <linux/export.h> |
| 14 | #include <linux/pci-ats.h> | 14 | #include <linux/pci-ats.h> |
| 15 | #include <linux/pci.h> | 15 | #include <linux/pci.h> |
| 16 | #include <linux/slab.h> | ||
| 16 | 17 | ||
| 17 | #include "pci.h" | 18 | #include "pci.h" |
| 18 | 19 | ||
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 596172b4ae95..9ddf69e3bbef 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c | |||
| @@ -132,6 +132,18 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv) | |||
| 132 | if (!acpi_pci_check_ejectable(pbus, handle) && !is_dock_device(handle)) | 132 | if (!acpi_pci_check_ejectable(pbus, handle) && !is_dock_device(handle)) |
| 133 | return AE_OK; | 133 | return AE_OK; |
| 134 | 134 | ||
| 135 | pdev = pbus->self; | ||
| 136 | if (pdev && pci_is_pcie(pdev)) { | ||
| 137 | tmp = acpi_find_root_bridge_handle(pdev); | ||
| 138 | if (tmp) { | ||
| 139 | struct acpi_pci_root *root = acpi_pci_find_root(tmp); | ||
| 140 | |||
| 141 | if (root && (root->osc_control_set & | ||
| 142 | OSC_PCI_EXPRESS_NATIVE_HP_CONTROL)) | ||
| 143 | return AE_OK; | ||
| 144 | } | ||
| 145 | } | ||
| 146 | |||
| 135 | acpi_evaluate_integer(handle, "_ADR", NULL, &adr); | 147 | acpi_evaluate_integer(handle, "_ADR", NULL, &adr); |
| 136 | device = (adr >> 16) & 0xffff; | 148 | device = (adr >> 16) & 0xffff; |
| 137 | function = adr & 0xffff; | 149 | function = adr & 0xffff; |
| @@ -213,7 +225,6 @@ register_slot(acpi_handle handle, u32 lvl, void *context, void **rv) | |||
| 213 | 225 | ||
| 214 | pdev = pci_get_slot(pbus, PCI_DEVFN(device, function)); | 226 | pdev = pci_get_slot(pbus, PCI_DEVFN(device, function)); |
| 215 | if (pdev) { | 227 | if (pdev) { |
| 216 | pdev->current_state = PCI_D0; | ||
| 217 | slot->flags |= (SLOT_ENABLED | SLOT_POWEREDON); | 228 | slot->flags |= (SLOT_ENABLED | SLOT_POWEREDON); |
| 218 | pci_dev_put(pdev); | 229 | pci_dev_put(pdev); |
| 219 | } | 230 | } |
| @@ -1378,11 +1389,13 @@ find_root_bridges(acpi_handle handle, u32 lvl, void *context, void **rv) | |||
| 1378 | { | 1389 | { |
| 1379 | int *count = (int *)context; | 1390 | int *count = (int *)context; |
| 1380 | 1391 | ||
| 1381 | if (acpi_is_root_bridge(handle)) { | 1392 | if (!acpi_is_root_bridge(handle)) |
| 1382 | acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY, | 1393 | return AE_OK; |
| 1383 | handle_hotplug_event_bridge, NULL); | 1394 | |
| 1384 | (*count)++; | 1395 | (*count)++; |
| 1385 | } | 1396 | acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY, |
| 1397 | handle_hotplug_event_bridge, NULL); | ||
| 1398 | |||
| 1386 | return AE_OK ; | 1399 | return AE_OK ; |
| 1387 | } | 1400 | } |
| 1388 | 1401 | ||
diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c index 1e9c9aacc3a6..085dbb5fc168 100644 --- a/drivers/pci/hotplug/pciehp_ctrl.c +++ b/drivers/pci/hotplug/pciehp_ctrl.c | |||
| @@ -213,9 +213,6 @@ static int board_added(struct slot *p_slot) | |||
| 213 | goto err_exit; | 213 | goto err_exit; |
| 214 | } | 214 | } |
| 215 | 215 | ||
| 216 | /* Wait for 1 second after checking link training status */ | ||
| 217 | msleep(1000); | ||
| 218 | |||
| 219 | /* Check for a power fault */ | 216 | /* Check for a power fault */ |
| 220 | if (ctrl->power_fault_detected || pciehp_query_power_fault(p_slot)) { | 217 | if (ctrl->power_fault_detected || pciehp_query_power_fault(p_slot)) { |
| 221 | ctrl_err(ctrl, "Power fault on slot %s\n", slot_name(p_slot)); | 218 | ctrl_err(ctrl, "Power fault on slot %s\n", slot_name(p_slot)); |
diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pciehp_hpc.c index 96dc4734e4af..7b1414810ae3 100644 --- a/drivers/pci/hotplug/pciehp_hpc.c +++ b/drivers/pci/hotplug/pciehp_hpc.c | |||
| @@ -280,6 +280,14 @@ int pciehp_check_link_status(struct controller *ctrl) | |||
| 280 | else | 280 | else |
| 281 | msleep(1000); | 281 | msleep(1000); |
| 282 | 282 | ||
| 283 | /* | ||
| 284 | * Need to wait for 1000 ms after Data Link Layer Link Active | ||
| 285 | * (DLLLA) bit reads 1b before sending configuration request. | ||
| 286 | * We need it before checking Link Training (LT) bit becuase | ||
| 287 | * LT is still set even after DLLLA bit is set on some platform. | ||
| 288 | */ | ||
| 289 | msleep(1000); | ||
| 290 | |||
| 283 | retval = pciehp_readw(ctrl, PCI_EXP_LNKSTA, &lnk_status); | 291 | retval = pciehp_readw(ctrl, PCI_EXP_LNKSTA, &lnk_status); |
| 284 | if (retval) { | 292 | if (retval) { |
| 285 | ctrl_err(ctrl, "Cannot read LNKSTATUS register\n"); | 293 | ctrl_err(ctrl, "Cannot read LNKSTATUS register\n"); |
| @@ -294,6 +302,16 @@ int pciehp_check_link_status(struct controller *ctrl) | |||
| 294 | return retval; | 302 | return retval; |
| 295 | } | 303 | } |
| 296 | 304 | ||
| 305 | /* | ||
| 306 | * If the port supports Link speeds greater than 5.0 GT/s, we | ||
| 307 | * must wait for 100 ms after Link training completes before | ||
| 308 | * sending configuration request. | ||
| 309 | */ | ||
| 310 | if (ctrl->pcie->port->subordinate->max_bus_speed > PCIE_SPEED_5_0GT) | ||
| 311 | msleep(100); | ||
| 312 | |||
| 313 | pcie_update_link_speed(ctrl->pcie->port->subordinate, lnk_status); | ||
| 314 | |||
| 297 | return retval; | 315 | return retval; |
| 298 | } | 316 | } |
| 299 | 317 | ||
| @@ -484,7 +502,6 @@ int pciehp_power_on_slot(struct slot * slot) | |||
| 484 | u16 slot_cmd; | 502 | u16 slot_cmd; |
| 485 | u16 cmd_mask; | 503 | u16 cmd_mask; |
| 486 | u16 slot_status; | 504 | u16 slot_status; |
| 487 | u16 lnk_status; | ||
| 488 | int retval = 0; | 505 | int retval = 0; |
| 489 | 506 | ||
| 490 | /* Clear sticky power-fault bit from previous power failures */ | 507 | /* Clear sticky power-fault bit from previous power failures */ |
| @@ -516,14 +533,6 @@ int pciehp_power_on_slot(struct slot * slot) | |||
| 516 | ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__, | 533 | ctrl_dbg(ctrl, "%s: SLOTCTRL %x write cmd %x\n", __func__, |
| 517 | pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL, slot_cmd); | 534 | pci_pcie_cap(ctrl->pcie->port) + PCI_EXP_SLTCTL, slot_cmd); |
| 518 | 535 | ||
| 519 | retval = pciehp_readw(ctrl, PCI_EXP_LNKSTA, &lnk_status); | ||
| 520 | if (retval) { | ||
| 521 | ctrl_err(ctrl, "%s: Cannot read LNKSTA register\n", | ||
| 522 | __func__); | ||
| 523 | return retval; | ||
| 524 | } | ||
| 525 | pcie_update_link_speed(ctrl->pcie->port->subordinate, lnk_status); | ||
| 526 | |||
| 527 | return retval; | 536 | return retval; |
| 528 | } | 537 | } |
| 529 | 538 | ||
diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c index aca972bbfb4c..dd7e0c51a33e 100644 --- a/drivers/pci/hotplug/shpchp_core.c +++ b/drivers/pci/hotplug/shpchp_core.c | |||
| @@ -278,8 +278,8 @@ static int get_adapter_status (struct hotplug_slot *hotplug_slot, u8 *value) | |||
| 278 | 278 | ||
| 279 | static int is_shpc_capable(struct pci_dev *dev) | 279 | static int is_shpc_capable(struct pci_dev *dev) |
| 280 | { | 280 | { |
| 281 | if ((dev->vendor == PCI_VENDOR_ID_AMD) || (dev->device == | 281 | if (dev->vendor == PCI_VENDOR_ID_AMD && |
| 282 | PCI_DEVICE_ID_AMD_GOLAM_7450)) | 282 | dev->device == PCI_DEVICE_ID_AMD_GOLAM_7450) |
| 283 | return 1; | 283 | return 1; |
| 284 | if (!pci_find_capability(dev, PCI_CAP_ID_SHPC)) | 284 | if (!pci_find_capability(dev, PCI_CAP_ID_SHPC)) |
| 285 | return 0; | 285 | return 0; |
diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index 36547f0ce305..75ba2311b54f 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c | |||
| @@ -944,8 +944,8 @@ int shpc_init(struct controller *ctrl, struct pci_dev *pdev) | |||
| 944 | ctrl->pci_dev = pdev; /* pci_dev of the P2P bridge */ | 944 | ctrl->pci_dev = pdev; /* pci_dev of the P2P bridge */ |
| 945 | ctrl_dbg(ctrl, "Hotplug Controller:\n"); | 945 | ctrl_dbg(ctrl, "Hotplug Controller:\n"); |
| 946 | 946 | ||
| 947 | if ((pdev->vendor == PCI_VENDOR_ID_AMD) || (pdev->device == | 947 | if (pdev->vendor == PCI_VENDOR_ID_AMD && |
| 948 | PCI_DEVICE_ID_AMD_GOLAM_7450)) { | 948 | pdev->device == PCI_DEVICE_ID_AMD_GOLAM_7450) { |
| 949 | /* amd shpc driver doesn't use Base Offset; assume 0 */ | 949 | /* amd shpc driver doesn't use Base Offset; assume 0 */ |
| 950 | ctrl->mmio_base = pci_resource_start(pdev, 0); | 950 | ctrl->mmio_base = pci_resource_start(pdev, 0); |
| 951 | ctrl->mmio_size = pci_resource_len(pdev, 0); | 951 | ctrl->mmio_size = pci_resource_len(pdev, 0); |
diff --git a/drivers/pci/iov.c b/drivers/pci/iov.c index b82c155d7b37..1969a3ee3058 100644 --- a/drivers/pci/iov.c +++ b/drivers/pci/iov.c | |||
| @@ -283,6 +283,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) | |||
| 283 | struct resource *res; | 283 | struct resource *res; |
| 284 | struct pci_dev *pdev; | 284 | struct pci_dev *pdev; |
| 285 | struct pci_sriov *iov = dev->sriov; | 285 | struct pci_sriov *iov = dev->sriov; |
| 286 | int bars = 0; | ||
| 286 | 287 | ||
| 287 | if (!nr_virtfn) | 288 | if (!nr_virtfn) |
| 288 | return 0; | 289 | return 0; |
| @@ -307,6 +308,7 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) | |||
| 307 | 308 | ||
| 308 | nres = 0; | 309 | nres = 0; |
| 309 | for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) { | 310 | for (i = 0; i < PCI_SRIOV_NUM_BARS; i++) { |
| 311 | bars |= (1 << (i + PCI_IOV_RESOURCES)); | ||
| 310 | res = dev->resource + PCI_IOV_RESOURCES + i; | 312 | res = dev->resource + PCI_IOV_RESOURCES + i; |
| 311 | if (res->parent) | 313 | if (res->parent) |
| 312 | nres++; | 314 | nres++; |
| @@ -324,6 +326,11 @@ static int sriov_enable(struct pci_dev *dev, int nr_virtfn) | |||
| 324 | return -ENOMEM; | 326 | return -ENOMEM; |
| 325 | } | 327 | } |
| 326 | 328 | ||
| 329 | if (pci_enable_resources(dev, bars)) { | ||
| 330 | dev_err(&dev->dev, "SR-IOV: IOV BARS not allocated\n"); | ||
| 331 | return -ENOMEM; | ||
| 332 | } | ||
| 333 | |||
| 327 | if (iov->link != dev->devfn) { | 334 | if (iov->link != dev->devfn) { |
| 328 | pdev = pci_get_slot(dev->bus, iov->link); | 335 | pdev = pci_get_slot(dev->bus, iov->link); |
| 329 | if (!pdev) | 336 | if (!pdev) |
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 6f45a73c6e9f..6d4a5319148d 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c | |||
| @@ -664,6 +664,9 @@ static int pci_platform_power_transition(struct pci_dev *dev, pci_power_t state) | |||
| 664 | error = platform_pci_set_power_state(dev, state); | 664 | error = platform_pci_set_power_state(dev, state); |
| 665 | if (!error) | 665 | if (!error) |
| 666 | pci_update_current_state(dev, state); | 666 | pci_update_current_state(dev, state); |
| 667 | /* Fall back to PCI_D0 if native PM is not supported */ | ||
| 668 | if (!dev->pm_cap) | ||
| 669 | dev->current_state = PCI_D0; | ||
| 667 | } else { | 670 | } else { |
| 668 | error = -ENODEV; | 671 | error = -ENODEV; |
| 669 | /* Fall back to PCI_D0 if native PM is not supported */ | 672 | /* Fall back to PCI_D0 if native PM is not supported */ |
| @@ -1126,7 +1129,11 @@ static int __pci_enable_device_flags(struct pci_dev *dev, | |||
| 1126 | if (atomic_add_return(1, &dev->enable_cnt) > 1) | 1129 | if (atomic_add_return(1, &dev->enable_cnt) > 1) |
| 1127 | return 0; /* already enabled */ | 1130 | return 0; /* already enabled */ |
| 1128 | 1131 | ||
| 1129 | for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) | 1132 | /* only skip sriov related */ |
| 1133 | for (i = 0; i <= PCI_ROM_RESOURCE; i++) | ||
| 1134 | if (dev->resource[i].flags & flags) | ||
| 1135 | bars |= (1 << i); | ||
| 1136 | for (i = PCI_BRIDGE_RESOURCES; i < DEVICE_COUNT_RESOURCE; i++) | ||
| 1130 | if (dev->resource[i].flags & flags) | 1137 | if (dev->resource[i].flags & flags) |
| 1131 | bars |= (1 << i); | 1138 | bars |= (1 << i); |
| 1132 | 1139 | ||
diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 13ef8c37471d..dcdc1f4a4624 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c | |||
| @@ -121,6 +121,7 @@ struct toshiba_acpi_dev { | |||
| 121 | int illumination_supported:1; | 121 | int illumination_supported:1; |
| 122 | int video_supported:1; | 122 | int video_supported:1; |
| 123 | int fan_supported:1; | 123 | int fan_supported:1; |
| 124 | int system_event_supported:1; | ||
| 124 | 125 | ||
| 125 | struct mutex mutex; | 126 | struct mutex mutex; |
| 126 | }; | 127 | }; |
| @@ -724,7 +725,7 @@ static int keys_proc_show(struct seq_file *m, void *v) | |||
| 724 | u32 hci_result; | 725 | u32 hci_result; |
| 725 | u32 value; | 726 | u32 value; |
| 726 | 727 | ||
| 727 | if (!dev->key_event_valid) { | 728 | if (!dev->key_event_valid && dev->system_event_supported) { |
| 728 | hci_read1(dev, HCI_SYSTEM_EVENT, &value, &hci_result); | 729 | hci_read1(dev, HCI_SYSTEM_EVENT, &value, &hci_result); |
| 729 | if (hci_result == HCI_SUCCESS) { | 730 | if (hci_result == HCI_SUCCESS) { |
| 730 | dev->key_event_valid = 1; | 731 | dev->key_event_valid = 1; |
| @@ -964,6 +965,8 @@ static int __devinit toshiba_acpi_add(struct acpi_device *acpi_dev) | |||
| 964 | 965 | ||
| 965 | /* enable event fifo */ | 966 | /* enable event fifo */ |
| 966 | hci_write1(dev, HCI_SYSTEM_EVENT, 1, &hci_result); | 967 | hci_write1(dev, HCI_SYSTEM_EVENT, 1, &hci_result); |
| 968 | if (hci_result == HCI_SUCCESS) | ||
| 969 | dev->system_event_supported = 1; | ||
| 967 | 970 | ||
| 968 | props.type = BACKLIGHT_PLATFORM; | 971 | props.type = BACKLIGHT_PLATFORM; |
| 969 | props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1; | 972 | props.max_brightness = HCI_LCD_BRIGHTNESS_LEVELS - 1; |
| @@ -1032,12 +1035,15 @@ static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event) | |||
| 1032 | { | 1035 | { |
| 1033 | struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev); | 1036 | struct toshiba_acpi_dev *dev = acpi_driver_data(acpi_dev); |
| 1034 | u32 hci_result, value; | 1037 | u32 hci_result, value; |
| 1038 | int retries = 3; | ||
| 1035 | 1039 | ||
| 1036 | if (event != 0x80) | 1040 | if (!dev->system_event_supported || event != 0x80) |
| 1037 | return; | 1041 | return; |
| 1042 | |||
| 1038 | do { | 1043 | do { |
| 1039 | hci_read1(dev, HCI_SYSTEM_EVENT, &value, &hci_result); | 1044 | hci_read1(dev, HCI_SYSTEM_EVENT, &value, &hci_result); |
| 1040 | if (hci_result == HCI_SUCCESS) { | 1045 | switch (hci_result) { |
| 1046 | case HCI_SUCCESS: | ||
| 1041 | if (value == 0x100) | 1047 | if (value == 0x100) |
| 1042 | continue; | 1048 | continue; |
| 1043 | /* act on key press; ignore key release */ | 1049 | /* act on key press; ignore key release */ |
| @@ -1049,14 +1055,19 @@ static void toshiba_acpi_notify(struct acpi_device *acpi_dev, u32 event) | |||
| 1049 | pr_info("Unknown key %x\n", | 1055 | pr_info("Unknown key %x\n", |
| 1050 | value); | 1056 | value); |
| 1051 | } | 1057 | } |
| 1052 | } else if (hci_result == HCI_NOT_SUPPORTED) { | 1058 | break; |
| 1059 | case HCI_NOT_SUPPORTED: | ||
| 1053 | /* This is a workaround for an unresolved issue on | 1060 | /* This is a workaround for an unresolved issue on |
| 1054 | * some machines where system events sporadically | 1061 | * some machines where system events sporadically |
| 1055 | * become disabled. */ | 1062 | * become disabled. */ |
| 1056 | hci_write1(dev, HCI_SYSTEM_EVENT, 1, &hci_result); | 1063 | hci_write1(dev, HCI_SYSTEM_EVENT, 1, &hci_result); |
| 1057 | pr_notice("Re-enabled hotkeys\n"); | 1064 | pr_notice("Re-enabled hotkeys\n"); |
| 1065 | /* fall through */ | ||
| 1066 | default: | ||
| 1067 | retries--; | ||
| 1068 | break; | ||
| 1058 | } | 1069 | } |
| 1059 | } while (hci_result != HCI_EMPTY); | 1070 | } while (retries && hci_result != HCI_EMPTY); |
| 1060 | } | 1071 | } |
| 1061 | 1072 | ||
| 1062 | 1073 | ||
diff --git a/drivers/power/intel_mid_battery.c b/drivers/power/intel_mid_battery.c index cffcb7c00b00..01fa671ec97f 100644 --- a/drivers/power/intel_mid_battery.c +++ b/drivers/power/intel_mid_battery.c | |||
| @@ -61,7 +61,8 @@ MODULE_PARM_DESC(debug, "Flag to enable PMIC Battery debug messages."); | |||
| 61 | #define PMIC_BATT_CHR_SBATDET_MASK (1 << 5) | 61 | #define PMIC_BATT_CHR_SBATDET_MASK (1 << 5) |
| 62 | #define PMIC_BATT_CHR_SDCLMT_MASK (1 << 6) | 62 | #define PMIC_BATT_CHR_SDCLMT_MASK (1 << 6) |
| 63 | #define PMIC_BATT_CHR_SUSBOVP_MASK (1 << 7) | 63 | #define PMIC_BATT_CHR_SUSBOVP_MASK (1 << 7) |
| 64 | #define PMIC_BATT_CHR_EXCPT_MASK 0xC6 | 64 | #define PMIC_BATT_CHR_EXCPT_MASK 0x86 |
| 65 | |||
| 65 | #define PMIC_BATT_ADC_ACCCHRG_MASK (1 << 31) | 66 | #define PMIC_BATT_ADC_ACCCHRG_MASK (1 << 31) |
| 66 | #define PMIC_BATT_ADC_ACCCHRGVAL_MASK 0x7FFFFFFF | 67 | #define PMIC_BATT_ADC_ACCCHRGVAL_MASK 0x7FFFFFFF |
| 67 | 68 | ||
| @@ -304,11 +305,6 @@ static void pmic_battery_read_status(struct pmic_power_module_info *pbi) | |||
| 304 | pbi->batt_status = POWER_SUPPLY_STATUS_NOT_CHARGING; | 305 | pbi->batt_status = POWER_SUPPLY_STATUS_NOT_CHARGING; |
| 305 | pmic_battery_log_event(BATT_EVENT_BATOVP_EXCPT); | 306 | pmic_battery_log_event(BATT_EVENT_BATOVP_EXCPT); |
| 306 | batt_exception = 1; | 307 | batt_exception = 1; |
| 307 | } else if (r8 & PMIC_BATT_CHR_SDCLMT_MASK) { | ||
| 308 | pbi->batt_health = POWER_SUPPLY_HEALTH_OVERVOLTAGE; | ||
| 309 | pbi->batt_status = POWER_SUPPLY_STATUS_NOT_CHARGING; | ||
| 310 | pmic_battery_log_event(BATT_EVENT_DCLMT_EXCPT); | ||
| 311 | batt_exception = 1; | ||
| 312 | } else if (r8 & PMIC_BATT_CHR_STEMP_MASK) { | 308 | } else if (r8 & PMIC_BATT_CHR_STEMP_MASK) { |
| 313 | pbi->batt_health = POWER_SUPPLY_HEALTH_OVERHEAT; | 309 | pbi->batt_health = POWER_SUPPLY_HEALTH_OVERHEAT; |
| 314 | pbi->batt_status = POWER_SUPPLY_STATUS_NOT_CHARGING; | 310 | pbi->batt_status = POWER_SUPPLY_STATUS_NOT_CHARGING; |
| @@ -316,6 +312,10 @@ static void pmic_battery_read_status(struct pmic_power_module_info *pbi) | |||
| 316 | batt_exception = 1; | 312 | batt_exception = 1; |
| 317 | } else { | 313 | } else { |
| 318 | pbi->batt_health = POWER_SUPPLY_HEALTH_GOOD; | 314 | pbi->batt_health = POWER_SUPPLY_HEALTH_GOOD; |
| 315 | if (r8 & PMIC_BATT_CHR_SDCLMT_MASK) { | ||
| 316 | /* PMIC will change charging current automatically */ | ||
| 317 | pmic_battery_log_event(BATT_EVENT_DCLMT_EXCPT); | ||
| 318 | } | ||
| 319 | } | 319 | } |
| 320 | } | 320 | } |
| 321 | 321 | ||
diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index cf3f9997546d..10451a15e828 100644 --- a/drivers/ptp/ptp_clock.c +++ b/drivers/ptp/ptp_clock.c | |||
| @@ -101,7 +101,9 @@ static s32 scaled_ppm_to_ppb(long ppm) | |||
| 101 | 101 | ||
| 102 | static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp) | 102 | static int ptp_clock_getres(struct posix_clock *pc, struct timespec *tp) |
| 103 | { | 103 | { |
| 104 | return 1; /* always round timer functions to one nanosecond */ | 104 | tp->tv_sec = 0; |
| 105 | tp->tv_nsec = 1; | ||
| 106 | return 0; | ||
| 105 | } | 107 | } |
| 106 | 108 | ||
| 107 | static int ptp_clock_settime(struct posix_clock *pc, const struct timespec *tp) | 109 | static int ptp_clock_settime(struct posix_clock *pc, const struct timespec *tp) |
diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c index 5225930a10cd..691b1ab1a3d0 100644 --- a/drivers/rapidio/devices/tsi721.c +++ b/drivers/rapidio/devices/tsi721.c | |||
| @@ -851,14 +851,12 @@ static int tsi721_doorbell_init(struct tsi721_device *priv) | |||
| 851 | INIT_WORK(&priv->idb_work, tsi721_db_dpc); | 851 | INIT_WORK(&priv->idb_work, tsi721_db_dpc); |
| 852 | 852 | ||
| 853 | /* Allocate buffer for inbound doorbells queue */ | 853 | /* Allocate buffer for inbound doorbells queue */ |
| 854 | priv->idb_base = dma_alloc_coherent(&priv->pdev->dev, | 854 | priv->idb_base = dma_zalloc_coherent(&priv->pdev->dev, |
| 855 | IDB_QSIZE * TSI721_IDB_ENTRY_SIZE, | 855 | IDB_QSIZE * TSI721_IDB_ENTRY_SIZE, |
| 856 | &priv->idb_dma, GFP_KERNEL); | 856 | &priv->idb_dma, GFP_KERNEL); |
| 857 | if (!priv->idb_base) | 857 | if (!priv->idb_base) |
| 858 | return -ENOMEM; | 858 | return -ENOMEM; |
| 859 | 859 | ||
| 860 | memset(priv->idb_base, 0, IDB_QSIZE * TSI721_IDB_ENTRY_SIZE); | ||
| 861 | |||
| 862 | dev_dbg(&priv->pdev->dev, "Allocated IDB buffer @ %p (phys = %llx)\n", | 860 | dev_dbg(&priv->pdev->dev, "Allocated IDB buffer @ %p (phys = %llx)\n", |
| 863 | priv->idb_base, (unsigned long long)priv->idb_dma); | 861 | priv->idb_base, (unsigned long long)priv->idb_dma); |
| 864 | 862 | ||
| @@ -904,7 +902,7 @@ static int tsi721_bdma_ch_init(struct tsi721_device *priv, int chnum) | |||
| 904 | */ | 902 | */ |
| 905 | 903 | ||
| 906 | /* Allocate space for DMA descriptors */ | 904 | /* Allocate space for DMA descriptors */ |
| 907 | bd_ptr = dma_alloc_coherent(&priv->pdev->dev, | 905 | bd_ptr = dma_zalloc_coherent(&priv->pdev->dev, |
| 908 | bd_num * sizeof(struct tsi721_dma_desc), | 906 | bd_num * sizeof(struct tsi721_dma_desc), |
| 909 | &bd_phys, GFP_KERNEL); | 907 | &bd_phys, GFP_KERNEL); |
| 910 | if (!bd_ptr) | 908 | if (!bd_ptr) |
| @@ -913,8 +911,6 @@ static int tsi721_bdma_ch_init(struct tsi721_device *priv, int chnum) | |||
| 913 | priv->bdma[chnum].bd_phys = bd_phys; | 911 | priv->bdma[chnum].bd_phys = bd_phys; |
| 914 | priv->bdma[chnum].bd_base = bd_ptr; | 912 | priv->bdma[chnum].bd_base = bd_ptr; |
| 915 | 913 | ||
| 916 | memset(bd_ptr, 0, bd_num * sizeof(struct tsi721_dma_desc)); | ||
| 917 | |||
| 918 | dev_dbg(&priv->pdev->dev, "DMA descriptors @ %p (phys = %llx)\n", | 914 | dev_dbg(&priv->pdev->dev, "DMA descriptors @ %p (phys = %llx)\n", |
| 919 | bd_ptr, (unsigned long long)bd_phys); | 915 | bd_ptr, (unsigned long long)bd_phys); |
| 920 | 916 | ||
| @@ -922,7 +918,7 @@ static int tsi721_bdma_ch_init(struct tsi721_device *priv, int chnum) | |||
| 922 | sts_size = (bd_num >= TSI721_DMA_MINSTSSZ) ? | 918 | sts_size = (bd_num >= TSI721_DMA_MINSTSSZ) ? |
| 923 | bd_num : TSI721_DMA_MINSTSSZ; | 919 | bd_num : TSI721_DMA_MINSTSSZ; |
| 924 | sts_size = roundup_pow_of_two(sts_size); | 920 | sts_size = roundup_pow_of_two(sts_size); |
| 925 | sts_ptr = dma_alloc_coherent(&priv->pdev->dev, | 921 | sts_ptr = dma_zalloc_coherent(&priv->pdev->dev, |
| 926 | sts_size * sizeof(struct tsi721_dma_sts), | 922 | sts_size * sizeof(struct tsi721_dma_sts), |
| 927 | &sts_phys, GFP_KERNEL); | 923 | &sts_phys, GFP_KERNEL); |
| 928 | if (!sts_ptr) { | 924 | if (!sts_ptr) { |
| @@ -938,8 +934,6 @@ static int tsi721_bdma_ch_init(struct tsi721_device *priv, int chnum) | |||
| 938 | priv->bdma[chnum].sts_base = sts_ptr; | 934 | priv->bdma[chnum].sts_base = sts_ptr; |
| 939 | priv->bdma[chnum].sts_size = sts_size; | 935 | priv->bdma[chnum].sts_size = sts_size; |
| 940 | 936 | ||
| 941 | memset(sts_ptr, 0, sts_size); | ||
| 942 | |||
| 943 | dev_dbg(&priv->pdev->dev, | 937 | dev_dbg(&priv->pdev->dev, |
| 944 | "desc status FIFO @ %p (phys = %llx) size=0x%x\n", | 938 | "desc status FIFO @ %p (phys = %llx) size=0x%x\n", |
| 945 | sts_ptr, (unsigned long long)sts_phys, sts_size); | 939 | sts_ptr, (unsigned long long)sts_phys, sts_size); |
| @@ -1400,7 +1394,7 @@ static int tsi721_open_outb_mbox(struct rio_mport *mport, void *dev_id, | |||
| 1400 | 1394 | ||
| 1401 | /* Outbound message descriptor status FIFO allocation */ | 1395 | /* Outbound message descriptor status FIFO allocation */ |
| 1402 | priv->omsg_ring[mbox].sts_size = roundup_pow_of_two(entries + 1); | 1396 | priv->omsg_ring[mbox].sts_size = roundup_pow_of_two(entries + 1); |
| 1403 | priv->omsg_ring[mbox].sts_base = dma_alloc_coherent(&priv->pdev->dev, | 1397 | priv->omsg_ring[mbox].sts_base = dma_zalloc_coherent(&priv->pdev->dev, |
| 1404 | priv->omsg_ring[mbox].sts_size * | 1398 | priv->omsg_ring[mbox].sts_size * |
| 1405 | sizeof(struct tsi721_dma_sts), | 1399 | sizeof(struct tsi721_dma_sts), |
| 1406 | &priv->omsg_ring[mbox].sts_phys, GFP_KERNEL); | 1400 | &priv->omsg_ring[mbox].sts_phys, GFP_KERNEL); |
| @@ -1412,9 +1406,6 @@ static int tsi721_open_outb_mbox(struct rio_mport *mport, void *dev_id, | |||
| 1412 | goto out_desc; | 1406 | goto out_desc; |
| 1413 | } | 1407 | } |
| 1414 | 1408 | ||
| 1415 | memset(priv->omsg_ring[mbox].sts_base, 0, | ||
| 1416 | entries * sizeof(struct tsi721_dma_sts)); | ||
| 1417 | |||
| 1418 | /* | 1409 | /* |
| 1419 | * Configure Outbound Messaging Engine | 1410 | * Configure Outbound Messaging Engine |
| 1420 | */ | 1411 | */ |
| @@ -2116,8 +2107,8 @@ static int __devinit tsi721_setup_mport(struct tsi721_device *priv) | |||
| 2116 | INIT_LIST_HEAD(&mport->dbells); | 2107 | INIT_LIST_HEAD(&mport->dbells); |
| 2117 | 2108 | ||
| 2118 | rio_init_dbell_res(&mport->riores[RIO_DOORBELL_RESOURCE], 0, 0xffff); | 2109 | rio_init_dbell_res(&mport->riores[RIO_DOORBELL_RESOURCE], 0, 0xffff); |
| 2119 | rio_init_mbox_res(&mport->riores[RIO_INB_MBOX_RESOURCE], 0, 0); | 2110 | rio_init_mbox_res(&mport->riores[RIO_INB_MBOX_RESOURCE], 0, 3); |
| 2120 | rio_init_mbox_res(&mport->riores[RIO_OUTB_MBOX_RESOURCE], 0, 0); | 2111 | rio_init_mbox_res(&mport->riores[RIO_OUTB_MBOX_RESOURCE], 0, 3); |
| 2121 | strcpy(mport->name, "Tsi721 mport"); | 2112 | strcpy(mport->name, "Tsi721 mport"); |
| 2122 | 2113 | ||
| 2123 | /* Hook up interrupt handler */ | 2114 | /* Hook up interrupt handler */ |
| @@ -2163,7 +2154,7 @@ static int __devinit tsi721_probe(struct pci_dev *pdev, | |||
| 2163 | const struct pci_device_id *id) | 2154 | const struct pci_device_id *id) |
| 2164 | { | 2155 | { |
| 2165 | struct tsi721_device *priv; | 2156 | struct tsi721_device *priv; |
| 2166 | int i; | 2157 | int i, cap; |
| 2167 | int err; | 2158 | int err; |
| 2168 | u32 regval; | 2159 | u32 regval; |
| 2169 | 2160 | ||
| @@ -2271,10 +2262,20 @@ static int __devinit tsi721_probe(struct pci_dev *pdev, | |||
| 2271 | dev_info(&pdev->dev, "Unable to set consistent DMA mask\n"); | 2262 | dev_info(&pdev->dev, "Unable to set consistent DMA mask\n"); |
| 2272 | } | 2263 | } |
| 2273 | 2264 | ||
| 2274 | /* Clear "no snoop" and "relaxed ordering" bits. */ | 2265 | cap = pci_pcie_cap(pdev); |
| 2275 | pci_read_config_dword(pdev, 0x40 + PCI_EXP_DEVCTL, ®val); | 2266 | BUG_ON(cap == 0); |
| 2276 | regval &= ~(PCI_EXP_DEVCTL_RELAX_EN | PCI_EXP_DEVCTL_NOSNOOP_EN); | 2267 | |
| 2277 | pci_write_config_dword(pdev, 0x40 + PCI_EXP_DEVCTL, regval); | 2268 | /* Clear "no snoop" and "relaxed ordering" bits, use default MRRS. */ |
| 2269 | pci_read_config_dword(pdev, cap + PCI_EXP_DEVCTL, ®val); | ||
| 2270 | regval &= ~(PCI_EXP_DEVCTL_READRQ | PCI_EXP_DEVCTL_RELAX_EN | | ||
| 2271 | PCI_EXP_DEVCTL_NOSNOOP_EN); | ||
| 2272 | regval |= 0x2 << MAX_READ_REQUEST_SZ_SHIFT; | ||
| 2273 | pci_write_config_dword(pdev, cap + PCI_EXP_DEVCTL, regval); | ||
| 2274 | |||
| 2275 | /* Adjust PCIe completion timeout. */ | ||
| 2276 | pci_read_config_dword(pdev, cap + PCI_EXP_DEVCTL2, ®val); | ||
| 2277 | regval &= ~(0x0f); | ||
| 2278 | pci_write_config_dword(pdev, cap + PCI_EXP_DEVCTL2, regval | 0x2); | ||
| 2278 | 2279 | ||
| 2279 | /* | 2280 | /* |
| 2280 | * FIXUP: correct offsets of MSI-X tables in the MSI-X Capability Block | 2281 | * FIXUP: correct offsets of MSI-X tables in the MSI-X Capability Block |
diff --git a/drivers/rapidio/devices/tsi721.h b/drivers/rapidio/devices/tsi721.h index 58be4deb1402..822e54c394d5 100644 --- a/drivers/rapidio/devices/tsi721.h +++ b/drivers/rapidio/devices/tsi721.h | |||
| @@ -72,6 +72,8 @@ | |||
| 72 | #define TSI721_MSIXPBA_OFFSET 0x2a000 | 72 | #define TSI721_MSIXPBA_OFFSET 0x2a000 |
| 73 | #define TSI721_PCIECFG_EPCTL 0x400 | 73 | #define TSI721_PCIECFG_EPCTL 0x400 |
| 74 | 74 | ||
| 75 | #define MAX_READ_REQUEST_SZ_SHIFT 12 | ||
| 76 | |||
| 75 | /* | 77 | /* |
| 76 | * Event Management Registers | 78 | * Event Management Registers |
| 77 | */ | 79 | */ |
diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c index 5abeb3ac3e8d..298c6c6a2795 100644 --- a/drivers/regulator/aat2870-regulator.c +++ b/drivers/regulator/aat2870-regulator.c | |||
| @@ -160,7 +160,7 @@ static struct aat2870_regulator *aat2870_get_regulator(int id) | |||
| 160 | break; | 160 | break; |
| 161 | } | 161 | } |
| 162 | 162 | ||
| 163 | if (!ri) | 163 | if (i == ARRAY_SIZE(aat2870_regulators)) |
| 164 | return NULL; | 164 | return NULL; |
| 165 | 165 | ||
| 166 | ri->enable_addr = AAT2870_LDO_EN; | 166 | ri->enable_addr = AAT2870_LDO_EN; |
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 669d02160221..938398f3e869 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c | |||
| @@ -2799,8 +2799,8 @@ void regulator_unregister(struct regulator_dev *rdev) | |||
| 2799 | list_del(&rdev->list); | 2799 | list_del(&rdev->list); |
| 2800 | if (rdev->supply) | 2800 | if (rdev->supply) |
| 2801 | regulator_put(rdev->supply); | 2801 | regulator_put(rdev->supply); |
| 2802 | device_unregister(&rdev->dev); | ||
| 2803 | kfree(rdev->constraints); | 2802 | kfree(rdev->constraints); |
| 2803 | device_unregister(&rdev->dev); | ||
| 2804 | mutex_unlock(®ulator_list_mutex); | 2804 | mutex_unlock(®ulator_list_mutex); |
| 2805 | } | 2805 | } |
| 2806 | EXPORT_SYMBOL_GPL(regulator_unregister); | 2806 | EXPORT_SYMBOL_GPL(regulator_unregister); |
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c index ee8747f4fa08..11cc308d66e9 100644 --- a/drivers/regulator/twl-regulator.c +++ b/drivers/regulator/twl-regulator.c | |||
| @@ -71,6 +71,7 @@ struct twlreg_info { | |||
| 71 | #define VREG_TYPE 1 | 71 | #define VREG_TYPE 1 |
| 72 | #define VREG_REMAP 2 | 72 | #define VREG_REMAP 2 |
| 73 | #define VREG_DEDICATED 3 /* LDO control */ | 73 | #define VREG_DEDICATED 3 /* LDO control */ |
| 74 | #define VREG_VOLTAGE_SMPS_4030 9 | ||
| 74 | /* TWL6030 register offsets */ | 75 | /* TWL6030 register offsets */ |
| 75 | #define VREG_TRANS 1 | 76 | #define VREG_TRANS 1 |
| 76 | #define VREG_STATE 2 | 77 | #define VREG_STATE 2 |
| @@ -514,6 +515,32 @@ static struct regulator_ops twl4030ldo_ops = { | |||
| 514 | .get_status = twl4030reg_get_status, | 515 | .get_status = twl4030reg_get_status, |
| 515 | }; | 516 | }; |
| 516 | 517 | ||
| 518 | static int | ||
| 519 | twl4030smps_set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV, | ||
| 520 | unsigned *selector) | ||
| 521 | { | ||
| 522 | struct twlreg_info *info = rdev_get_drvdata(rdev); | ||
| 523 | int vsel = DIV_ROUND_UP(min_uV - 600000, 12500); | ||
| 524 | |||
| 525 | twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE_SMPS_4030, | ||
| 526 | vsel); | ||
| 527 | return 0; | ||
| 528 | } | ||
| 529 | |||
| 530 | static int twl4030smps_get_voltage(struct regulator_dev *rdev) | ||
| 531 | { | ||
| 532 | struct twlreg_info *info = rdev_get_drvdata(rdev); | ||
| 533 | int vsel = twlreg_read(info, TWL_MODULE_PM_RECEIVER, | ||
| 534 | VREG_VOLTAGE_SMPS_4030); | ||
| 535 | |||
| 536 | return vsel * 12500 + 600000; | ||
| 537 | } | ||
| 538 | |||
| 539 | static struct regulator_ops twl4030smps_ops = { | ||
| 540 | .set_voltage = twl4030smps_set_voltage, | ||
| 541 | .get_voltage = twl4030smps_get_voltage, | ||
| 542 | }; | ||
| 543 | |||
| 517 | static int twl6030ldo_list_voltage(struct regulator_dev *rdev, unsigned index) | 544 | static int twl6030ldo_list_voltage(struct regulator_dev *rdev, unsigned index) |
| 518 | { | 545 | { |
| 519 | struct twlreg_info *info = rdev_get_drvdata(rdev); | 546 | struct twlreg_info *info = rdev_get_drvdata(rdev); |
| @@ -856,6 +883,21 @@ static struct regulator_ops twlsmps_ops = { | |||
| 856 | }, \ | 883 | }, \ |
| 857 | } | 884 | } |
| 858 | 885 | ||
| 886 | #define TWL4030_ADJUSTABLE_SMPS(label, offset, num, turnon_delay, remap_conf) \ | ||
| 887 | { \ | ||
| 888 | .base = offset, \ | ||
| 889 | .id = num, \ | ||
| 890 | .delay = turnon_delay, \ | ||
| 891 | .remap = remap_conf, \ | ||
| 892 | .desc = { \ | ||
| 893 | .name = #label, \ | ||
| 894 | .id = TWL4030_REG_##label, \ | ||
| 895 | .ops = &twl4030smps_ops, \ | ||
| 896 | .type = REGULATOR_VOLTAGE, \ | ||
| 897 | .owner = THIS_MODULE, \ | ||
| 898 | }, \ | ||
| 899 | } | ||
| 900 | |||
| 859 | #define TWL6030_ADJUSTABLE_LDO(label, offset, min_mVolts, max_mVolts) { \ | 901 | #define TWL6030_ADJUSTABLE_LDO(label, offset, min_mVolts, max_mVolts) { \ |
| 860 | .base = offset, \ | 902 | .base = offset, \ |
| 861 | .min_mV = min_mVolts, \ | 903 | .min_mV = min_mVolts, \ |
| @@ -947,8 +989,8 @@ static struct twlreg_info twl_regs[] = { | |||
| 947 | TWL4030_ADJUSTABLE_LDO(VINTANA2, 0x43, 12, 100, 0x08), | 989 | TWL4030_ADJUSTABLE_LDO(VINTANA2, 0x43, 12, 100, 0x08), |
| 948 | TWL4030_FIXED_LDO(VINTDIG, 0x47, 1500, 13, 100, 0x08), | 990 | TWL4030_FIXED_LDO(VINTDIG, 0x47, 1500, 13, 100, 0x08), |
| 949 | TWL4030_ADJUSTABLE_LDO(VIO, 0x4b, 14, 1000, 0x08), | 991 | TWL4030_ADJUSTABLE_LDO(VIO, 0x4b, 14, 1000, 0x08), |
| 950 | TWL4030_ADJUSTABLE_LDO(VDD1, 0x55, 15, 1000, 0x08), | 992 | TWL4030_ADJUSTABLE_SMPS(VDD1, 0x55, 15, 1000, 0x08), |
| 951 | TWL4030_ADJUSTABLE_LDO(VDD2, 0x63, 16, 1000, 0x08), | 993 | TWL4030_ADJUSTABLE_SMPS(VDD2, 0x63, 16, 1000, 0x08), |
| 952 | TWL4030_FIXED_LDO(VUSB1V5, 0x71, 1500, 17, 100, 0x08), | 994 | TWL4030_FIXED_LDO(VUSB1V5, 0x71, 1500, 17, 100, 0x08), |
| 953 | TWL4030_FIXED_LDO(VUSB1V8, 0x74, 1800, 18, 100, 0x08), | 995 | TWL4030_FIXED_LDO(VUSB1V8, 0x74, 1800, 18, 100, 0x08), |
| 954 | TWL4030_FIXED_LDO(VUSB3V1, 0x77, 3100, 19, 150, 0x08), | 996 | TWL4030_FIXED_LDO(VUSB3V1, 0x77, 3100, 19, 150, 0x08), |
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index e8326f26fa2f..dc4c2748bbc3 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c | |||
| @@ -63,7 +63,7 @@ static int rtc_suspend(struct device *dev, pm_message_t mesg) | |||
| 63 | */ | 63 | */ |
| 64 | delta = timespec_sub(old_system, old_rtc); | 64 | delta = timespec_sub(old_system, old_rtc); |
| 65 | delta_delta = timespec_sub(delta, old_delta); | 65 | delta_delta = timespec_sub(delta, old_delta); |
| 66 | if (abs(delta_delta.tv_sec) >= 2) { | 66 | if (delta_delta.tv_sec < -2 || delta_delta.tv_sec >= 2) { |
| 67 | /* | 67 | /* |
| 68 | * if delta_delta is too large, assume time correction | 68 | * if delta_delta is too large, assume time correction |
| 69 | * has occured and set old_delta to the current delta. | 69 | * has occured and set old_delta to the current delta. |
| @@ -97,9 +97,8 @@ static int rtc_resume(struct device *dev) | |||
| 97 | rtc_tm_to_time(&tm, &new_rtc.tv_sec); | 97 | rtc_tm_to_time(&tm, &new_rtc.tv_sec); |
| 98 | new_rtc.tv_nsec = 0; | 98 | new_rtc.tv_nsec = 0; |
| 99 | 99 | ||
| 100 | if (new_rtc.tv_sec <= old_rtc.tv_sec) { | 100 | if (new_rtc.tv_sec < old_rtc.tv_sec) { |
| 101 | if (new_rtc.tv_sec < old_rtc.tv_sec) | 101 | pr_debug("%s: time travel!\n", dev_name(&rtc->dev)); |
| 102 | pr_debug("%s: time travel!\n", dev_name(&rtc->dev)); | ||
| 103 | return 0; | 102 | return 0; |
| 104 | } | 103 | } |
| 105 | 104 | ||
| @@ -116,7 +115,8 @@ static int rtc_resume(struct device *dev) | |||
| 116 | sleep_time = timespec_sub(sleep_time, | 115 | sleep_time = timespec_sub(sleep_time, |
| 117 | timespec_sub(new_system, old_system)); | 116 | timespec_sub(new_system, old_system)); |
| 118 | 117 | ||
| 119 | timekeeping_inject_sleeptime(&sleep_time); | 118 | if (sleep_time.tv_sec >= 0) |
| 119 | timekeeping_inject_sleeptime(&sleep_time); | ||
| 120 | return 0; | 120 | return 0; |
| 121 | } | 121 | } |
| 122 | 122 | ||
diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index 8e286259a007..fa4d9f324189 100644 --- a/drivers/rtc/interface.c +++ b/drivers/rtc/interface.c | |||
| @@ -319,6 +319,20 @@ int rtc_read_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | |||
| 319 | } | 319 | } |
| 320 | EXPORT_SYMBOL_GPL(rtc_read_alarm); | 320 | EXPORT_SYMBOL_GPL(rtc_read_alarm); |
| 321 | 321 | ||
| 322 | static int ___rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | ||
| 323 | { | ||
| 324 | int err; | ||
| 325 | |||
| 326 | if (!rtc->ops) | ||
| 327 | err = -ENODEV; | ||
| 328 | else if (!rtc->ops->set_alarm) | ||
| 329 | err = -EINVAL; | ||
| 330 | else | ||
| 331 | err = rtc->ops->set_alarm(rtc->dev.parent, alarm); | ||
| 332 | |||
| 333 | return err; | ||
| 334 | } | ||
| 335 | |||
| 322 | static int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | 336 | static int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) |
| 323 | { | 337 | { |
| 324 | struct rtc_time tm; | 338 | struct rtc_time tm; |
| @@ -342,14 +356,7 @@ static int __rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | |||
| 342 | * over right here, before we set the alarm. | 356 | * over right here, before we set the alarm. |
| 343 | */ | 357 | */ |
| 344 | 358 | ||
| 345 | if (!rtc->ops) | 359 | return ___rtc_set_alarm(rtc, alarm); |
| 346 | err = -ENODEV; | ||
| 347 | else if (!rtc->ops->set_alarm) | ||
| 348 | err = -EINVAL; | ||
| 349 | else | ||
| 350 | err = rtc->ops->set_alarm(rtc->dev.parent, alarm); | ||
| 351 | |||
| 352 | return err; | ||
| 353 | } | 360 | } |
| 354 | 361 | ||
| 355 | int rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) | 362 | int rtc_set_alarm(struct rtc_device *rtc, struct rtc_wkalrm *alarm) |
| @@ -763,6 +770,20 @@ static int rtc_timer_enqueue(struct rtc_device *rtc, struct rtc_timer *timer) | |||
| 763 | return 0; | 770 | return 0; |
| 764 | } | 771 | } |
| 765 | 772 | ||
| 773 | static void rtc_alarm_disable(struct rtc_device *rtc) | ||
| 774 | { | ||
| 775 | struct rtc_wkalrm alarm; | ||
| 776 | struct rtc_time tm; | ||
| 777 | |||
| 778 | __rtc_read_time(rtc, &tm); | ||
| 779 | |||
| 780 | alarm.time = rtc_ktime_to_tm(ktime_add(rtc_tm_to_ktime(tm), | ||
| 781 | ktime_set(300, 0))); | ||
| 782 | alarm.enabled = 0; | ||
| 783 | |||
| 784 | ___rtc_set_alarm(rtc, &alarm); | ||
| 785 | } | ||
| 786 | |||
| 766 | /** | 787 | /** |
| 767 | * rtc_timer_remove - Removes a rtc_timer from the rtc_device timerqueue | 788 | * rtc_timer_remove - Removes a rtc_timer from the rtc_device timerqueue |
| 768 | * @rtc rtc device | 789 | * @rtc rtc device |
| @@ -784,8 +805,10 @@ static void rtc_timer_remove(struct rtc_device *rtc, struct rtc_timer *timer) | |||
| 784 | struct rtc_wkalrm alarm; | 805 | struct rtc_wkalrm alarm; |
| 785 | int err; | 806 | int err; |
| 786 | next = timerqueue_getnext(&rtc->timerqueue); | 807 | next = timerqueue_getnext(&rtc->timerqueue); |
| 787 | if (!next) | 808 | if (!next) { |
| 809 | rtc_alarm_disable(rtc); | ||
| 788 | return; | 810 | return; |
| 811 | } | ||
| 789 | alarm.time = rtc_ktime_to_tm(next->expires); | 812 | alarm.time = rtc_ktime_to_tm(next->expires); |
| 790 | alarm.enabled = 1; | 813 | alarm.enabled = 1; |
| 791 | err = __rtc_set_alarm(rtc, &alarm); | 814 | err = __rtc_set_alarm(rtc, &alarm); |
| @@ -847,7 +870,8 @@ again: | |||
| 847 | err = __rtc_set_alarm(rtc, &alarm); | 870 | err = __rtc_set_alarm(rtc, &alarm); |
| 848 | if (err == -ETIME) | 871 | if (err == -ETIME) |
| 849 | goto again; | 872 | goto again; |
| 850 | } | 873 | } else |
| 874 | rtc_alarm_disable(rtc); | ||
| 851 | 875 | ||
| 852 | mutex_unlock(&rtc->ops_lock); | 876 | mutex_unlock(&rtc->ops_lock); |
| 853 | } | 877 | } |
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 7639ab906f02..5b979d9cc332 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c | |||
| @@ -202,7 +202,6 @@ static int s3c_rtc_settime(struct device *dev, struct rtc_time *tm) | |||
| 202 | void __iomem *base = s3c_rtc_base; | 202 | void __iomem *base = s3c_rtc_base; |
| 203 | int year = tm->tm_year - 100; | 203 | int year = tm->tm_year - 100; |
| 204 | 204 | ||
| 205 | clk_enable(rtc_clk); | ||
| 206 | pr_debug("set time %04d.%02d.%02d %02d:%02d:%02d\n", | 205 | pr_debug("set time %04d.%02d.%02d %02d:%02d:%02d\n", |
| 207 | 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, | 206 | 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, |
| 208 | tm->tm_hour, tm->tm_min, tm->tm_sec); | 207 | tm->tm_hour, tm->tm_min, tm->tm_sec); |
| @@ -214,6 +213,7 @@ static int s3c_rtc_settime(struct device *dev, struct rtc_time *tm) | |||
| 214 | return -EINVAL; | 213 | return -EINVAL; |
| 215 | } | 214 | } |
| 216 | 215 | ||
| 216 | clk_enable(rtc_clk); | ||
| 217 | writeb(bin2bcd(tm->tm_sec), base + S3C2410_RTCSEC); | 217 | writeb(bin2bcd(tm->tm_sec), base + S3C2410_RTCSEC); |
| 218 | writeb(bin2bcd(tm->tm_min), base + S3C2410_RTCMIN); | 218 | writeb(bin2bcd(tm->tm_min), base + S3C2410_RTCMIN); |
| 219 | writeb(bin2bcd(tm->tm_hour), base + S3C2410_RTCHOUR); | 219 | writeb(bin2bcd(tm->tm_hour), base + S3C2410_RTCHOUR); |
diff --git a/drivers/s390/cio/chsc.c b/drivers/s390/cio/chsc.c index 75c3f1f8fd43..a84631a7391d 100644 --- a/drivers/s390/cio/chsc.c +++ b/drivers/s390/cio/chsc.c | |||
| @@ -529,10 +529,7 @@ __s390_vary_chpid_on(struct subchannel_id schid, void *data) | |||
| 529 | int chsc_chp_vary(struct chp_id chpid, int on) | 529 | int chsc_chp_vary(struct chp_id chpid, int on) |
| 530 | { | 530 | { |
| 531 | struct channel_path *chp = chpid_to_chp(chpid); | 531 | struct channel_path *chp = chpid_to_chp(chpid); |
| 532 | struct chp_link link; | ||
| 533 | 532 | ||
| 534 | memset(&link, 0, sizeof(struct chp_link)); | ||
| 535 | link.chpid = chpid; | ||
| 536 | /* Wait until previous actions have settled. */ | 533 | /* Wait until previous actions have settled. */ |
| 537 | css_wait_for_slow_path(); | 534 | css_wait_for_slow_path(); |
| 538 | /* | 535 | /* |
| @@ -542,10 +539,10 @@ int chsc_chp_vary(struct chp_id chpid, int on) | |||
| 542 | /* Try to update the channel path descritor. */ | 539 | /* Try to update the channel path descritor. */ |
| 543 | chsc_determine_base_channel_path_desc(chpid, &chp->desc); | 540 | chsc_determine_base_channel_path_desc(chpid, &chp->desc); |
| 544 | for_each_subchannel_staged(s390_subchannel_vary_chpid_on, | 541 | for_each_subchannel_staged(s390_subchannel_vary_chpid_on, |
| 545 | __s390_vary_chpid_on, &link); | 542 | __s390_vary_chpid_on, &chpid); |
| 546 | } else | 543 | } else |
| 547 | for_each_subchannel_staged(s390_subchannel_vary_chpid_off, | 544 | for_each_subchannel_staged(s390_subchannel_vary_chpid_off, |
| 548 | NULL, &link); | 545 | NULL, &chpid); |
| 549 | 546 | ||
| 550 | return 0; | 547 | return 0; |
| 551 | } | 548 | } |
diff --git a/drivers/s390/cio/cio.h b/drivers/s390/cio/cio.h index 155a82bcb9e5..4a1ff5c2eb88 100644 --- a/drivers/s390/cio/cio.h +++ b/drivers/s390/cio/cio.h | |||
| @@ -68,8 +68,13 @@ struct schib { | |||
| 68 | __u8 mda[4]; /* model dependent area */ | 68 | __u8 mda[4]; /* model dependent area */ |
| 69 | } __attribute__ ((packed,aligned(4))); | 69 | } __attribute__ ((packed,aligned(4))); |
| 70 | 70 | ||
| 71 | /* | ||
| 72 | * When rescheduled, todo's with higher values will overwrite those | ||
| 73 | * with lower values. | ||
| 74 | */ | ||
| 71 | enum sch_todo { | 75 | enum sch_todo { |
| 72 | SCH_TODO_NOTHING, | 76 | SCH_TODO_NOTHING, |
| 77 | SCH_TODO_EVAL, | ||
| 73 | SCH_TODO_UNREG, | 78 | SCH_TODO_UNREG, |
| 74 | }; | 79 | }; |
| 75 | 80 | ||
diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c index 92d7324acb1c..21908e67bf67 100644 --- a/drivers/s390/cio/css.c +++ b/drivers/s390/cio/css.c | |||
| @@ -195,51 +195,6 @@ void css_sch_device_unregister(struct subchannel *sch) | |||
| 195 | } | 195 | } |
| 196 | EXPORT_SYMBOL_GPL(css_sch_device_unregister); | 196 | EXPORT_SYMBOL_GPL(css_sch_device_unregister); |
| 197 | 197 | ||
| 198 | static void css_sch_todo(struct work_struct *work) | ||
| 199 | { | ||
| 200 | struct subchannel *sch; | ||
| 201 | enum sch_todo todo; | ||
| 202 | |||
| 203 | sch = container_of(work, struct subchannel, todo_work); | ||
| 204 | /* Find out todo. */ | ||
| 205 | spin_lock_irq(sch->lock); | ||
| 206 | todo = sch->todo; | ||
| 207 | CIO_MSG_EVENT(4, "sch_todo: sch=0.%x.%04x, todo=%d\n", sch->schid.ssid, | ||
| 208 | sch->schid.sch_no, todo); | ||
| 209 | sch->todo = SCH_TODO_NOTHING; | ||
| 210 | spin_unlock_irq(sch->lock); | ||
| 211 | /* Perform todo. */ | ||
| 212 | if (todo == SCH_TODO_UNREG) | ||
| 213 | css_sch_device_unregister(sch); | ||
| 214 | /* Release workqueue ref. */ | ||
| 215 | put_device(&sch->dev); | ||
| 216 | } | ||
| 217 | |||
| 218 | /** | ||
| 219 | * css_sched_sch_todo - schedule a subchannel operation | ||
| 220 | * @sch: subchannel | ||
| 221 | * @todo: todo | ||
| 222 | * | ||
| 223 | * Schedule the operation identified by @todo to be performed on the slow path | ||
| 224 | * workqueue. Do nothing if another operation with higher priority is already | ||
| 225 | * scheduled. Needs to be called with subchannel lock held. | ||
| 226 | */ | ||
| 227 | void css_sched_sch_todo(struct subchannel *sch, enum sch_todo todo) | ||
| 228 | { | ||
| 229 | CIO_MSG_EVENT(4, "sch_todo: sched sch=0.%x.%04x todo=%d\n", | ||
| 230 | sch->schid.ssid, sch->schid.sch_no, todo); | ||
| 231 | if (sch->todo >= todo) | ||
| 232 | return; | ||
| 233 | /* Get workqueue ref. */ | ||
| 234 | if (!get_device(&sch->dev)) | ||
| 235 | return; | ||
| 236 | sch->todo = todo; | ||
| 237 | if (!queue_work(cio_work_q, &sch->todo_work)) { | ||
| 238 | /* Already queued, release workqueue ref. */ | ||
| 239 | put_device(&sch->dev); | ||
| 240 | } | ||
| 241 | } | ||
| 242 | |||
| 243 | static void ssd_from_pmcw(struct chsc_ssd_info *ssd, struct pmcw *pmcw) | 198 | static void ssd_from_pmcw(struct chsc_ssd_info *ssd, struct pmcw *pmcw) |
| 244 | { | 199 | { |
| 245 | int i; | 200 | int i; |
| @@ -466,6 +421,65 @@ static void css_evaluate_subchannel(struct subchannel_id schid, int slow) | |||
| 466 | css_schedule_eval(schid); | 421 | css_schedule_eval(schid); |
| 467 | } | 422 | } |
| 468 | 423 | ||
| 424 | /** | ||
| 425 | * css_sched_sch_todo - schedule a subchannel operation | ||
| 426 | * @sch: subchannel | ||
| 427 | * @todo: todo | ||
| 428 | * | ||
| 429 | * Schedule the operation identified by @todo to be performed on the slow path | ||
| 430 | * workqueue. Do nothing if another operation with higher priority is already | ||
| 431 | * scheduled. Needs to be called with subchannel lock held. | ||
| 432 | */ | ||
| 433 | void css_sched_sch_todo(struct subchannel *sch, enum sch_todo todo) | ||
| 434 | { | ||
| 435 | CIO_MSG_EVENT(4, "sch_todo: sched sch=0.%x.%04x todo=%d\n", | ||
| 436 | sch->schid.ssid, sch->schid.sch_no, todo); | ||
| 437 | if (sch->todo >= todo) | ||
| 438 | return; | ||
| 439 | /* Get workqueue ref. */ | ||
| 440 | if (!get_device(&sch->dev)) | ||
| 441 | return; | ||
| 442 | sch->todo = todo; | ||
| 443 | if (!queue_work(cio_work_q, &sch->todo_work)) { | ||
| 444 | /* Already queued, release workqueue ref. */ | ||
| 445 | put_device(&sch->dev); | ||
| 446 | } | ||
| 447 | } | ||
| 448 | |||
| 449 | static void css_sch_todo(struct work_struct *work) | ||
| 450 | { | ||
| 451 | struct subchannel *sch; | ||
| 452 | enum sch_todo todo; | ||
| 453 | int ret; | ||
| 454 | |||
| 455 | sch = container_of(work, struct subchannel, todo_work); | ||
| 456 | /* Find out todo. */ | ||
| 457 | spin_lock_irq(sch->lock); | ||
| 458 | todo = sch->todo; | ||
| 459 | CIO_MSG_EVENT(4, "sch_todo: sch=0.%x.%04x, todo=%d\n", sch->schid.ssid, | ||
| 460 | sch->schid.sch_no, todo); | ||
| 461 | sch->todo = SCH_TODO_NOTHING; | ||
| 462 | spin_unlock_irq(sch->lock); | ||
| 463 | /* Perform todo. */ | ||
| 464 | switch (todo) { | ||
| 465 | case SCH_TODO_NOTHING: | ||
| 466 | break; | ||
| 467 | case SCH_TODO_EVAL: | ||
| 468 | ret = css_evaluate_known_subchannel(sch, 1); | ||
| 469 | if (ret == -EAGAIN) { | ||
| 470 | spin_lock_irq(sch->lock); | ||
| 471 | css_sched_sch_todo(sch, todo); | ||
| 472 | spin_unlock_irq(sch->lock); | ||
| 473 | } | ||
| 474 | break; | ||
| 475 | case SCH_TODO_UNREG: | ||
| 476 | css_sch_device_unregister(sch); | ||
| 477 | break; | ||
| 478 | } | ||
| 479 | /* Release workqueue ref. */ | ||
| 480 | put_device(&sch->dev); | ||
| 481 | } | ||
| 482 | |||
| 469 | static struct idset *slow_subchannel_set; | 483 | static struct idset *slow_subchannel_set; |
| 470 | static spinlock_t slow_subchannel_lock; | 484 | static spinlock_t slow_subchannel_lock; |
| 471 | static wait_queue_head_t css_eval_wq; | 485 | static wait_queue_head_t css_eval_wq; |
diff --git a/drivers/s390/cio/device.c b/drivers/s390/cio/device.c index d734f4a0ecac..47269858ecb6 100644 --- a/drivers/s390/cio/device.c +++ b/drivers/s390/cio/device.c | |||
| @@ -1868,9 +1868,9 @@ static void __ccw_device_pm_restore(struct ccw_device *cdev) | |||
| 1868 | */ | 1868 | */ |
| 1869 | cdev->private->flags.resuming = 1; | 1869 | cdev->private->flags.resuming = 1; |
| 1870 | cdev->private->path_new_mask = LPM_ANYPATH; | 1870 | cdev->private->path_new_mask = LPM_ANYPATH; |
| 1871 | css_schedule_eval(sch->schid); | 1871 | css_sched_sch_todo(sch, SCH_TODO_EVAL); |
| 1872 | spin_unlock_irq(sch->lock); | 1872 | spin_unlock_irq(sch->lock); |
| 1873 | css_complete_work(); | 1873 | css_wait_for_slow_path(); |
| 1874 | 1874 | ||
| 1875 | /* cdev may have been moved to a different subchannel. */ | 1875 | /* cdev may have been moved to a different subchannel. */ |
| 1876 | sch = to_subchannel(cdev->dev.parent); | 1876 | sch = to_subchannel(cdev->dev.parent); |
diff --git a/drivers/s390/cio/device_fsm.c b/drivers/s390/cio/device_fsm.c index 52c233fa2b12..1b853513c891 100644 --- a/drivers/s390/cio/device_fsm.c +++ b/drivers/s390/cio/device_fsm.c | |||
| @@ -496,8 +496,26 @@ static void ccw_device_reset_path_events(struct ccw_device *cdev) | |||
| 496 | cdev->private->pgid_reset_mask = 0; | 496 | cdev->private->pgid_reset_mask = 0; |
| 497 | } | 497 | } |
| 498 | 498 | ||
| 499 | void | 499 | static void create_fake_irb(struct irb *irb, int type) |
| 500 | ccw_device_verify_done(struct ccw_device *cdev, int err) | 500 | { |
| 501 | memset(irb, 0, sizeof(*irb)); | ||
| 502 | if (type == FAKE_CMD_IRB) { | ||
| 503 | struct cmd_scsw *scsw = &irb->scsw.cmd; | ||
| 504 | scsw->cc = 1; | ||
| 505 | scsw->fctl = SCSW_FCTL_START_FUNC; | ||
| 506 | scsw->actl = SCSW_ACTL_START_PEND; | ||
| 507 | scsw->stctl = SCSW_STCTL_STATUS_PEND; | ||
| 508 | } else if (type == FAKE_TM_IRB) { | ||
| 509 | struct tm_scsw *scsw = &irb->scsw.tm; | ||
| 510 | scsw->x = 1; | ||
| 511 | scsw->cc = 1; | ||
| 512 | scsw->fctl = SCSW_FCTL_START_FUNC; | ||
| 513 | scsw->actl = SCSW_ACTL_START_PEND; | ||
| 514 | scsw->stctl = SCSW_STCTL_STATUS_PEND; | ||
| 515 | } | ||
| 516 | } | ||
| 517 | |||
| 518 | void ccw_device_verify_done(struct ccw_device *cdev, int err) | ||
| 501 | { | 519 | { |
| 502 | struct subchannel *sch; | 520 | struct subchannel *sch; |
| 503 | 521 | ||
| @@ -520,12 +538,8 @@ callback: | |||
| 520 | ccw_device_done(cdev, DEV_STATE_ONLINE); | 538 | ccw_device_done(cdev, DEV_STATE_ONLINE); |
| 521 | /* Deliver fake irb to device driver, if needed. */ | 539 | /* Deliver fake irb to device driver, if needed. */ |
| 522 | if (cdev->private->flags.fake_irb) { | 540 | if (cdev->private->flags.fake_irb) { |
| 523 | memset(&cdev->private->irb, 0, sizeof(struct irb)); | 541 | create_fake_irb(&cdev->private->irb, |
| 524 | cdev->private->irb.scsw.cmd.cc = 1; | 542 | cdev->private->flags.fake_irb); |
| 525 | cdev->private->irb.scsw.cmd.fctl = SCSW_FCTL_START_FUNC; | ||
| 526 | cdev->private->irb.scsw.cmd.actl = SCSW_ACTL_START_PEND; | ||
| 527 | cdev->private->irb.scsw.cmd.stctl = | ||
| 528 | SCSW_STCTL_STATUS_PEND; | ||
| 529 | cdev->private->flags.fake_irb = 0; | 543 | cdev->private->flags.fake_irb = 0; |
| 530 | if (cdev->handler) | 544 | if (cdev->handler) |
| 531 | cdev->handler(cdev, cdev->private->intparm, | 545 | cdev->handler(cdev, cdev->private->intparm, |
diff --git a/drivers/s390/cio/device_ops.c b/drivers/s390/cio/device_ops.c index f98698d5735e..ec7fb6d3b479 100644 --- a/drivers/s390/cio/device_ops.c +++ b/drivers/s390/cio/device_ops.c | |||
| @@ -198,7 +198,7 @@ int ccw_device_start_key(struct ccw_device *cdev, struct ccw1 *cpa, | |||
| 198 | if (cdev->private->state == DEV_STATE_VERIFY) { | 198 | if (cdev->private->state == DEV_STATE_VERIFY) { |
| 199 | /* Remember to fake irb when finished. */ | 199 | /* Remember to fake irb when finished. */ |
| 200 | if (!cdev->private->flags.fake_irb) { | 200 | if (!cdev->private->flags.fake_irb) { |
| 201 | cdev->private->flags.fake_irb = 1; | 201 | cdev->private->flags.fake_irb = FAKE_CMD_IRB; |
| 202 | cdev->private->intparm = intparm; | 202 | cdev->private->intparm = intparm; |
| 203 | return 0; | 203 | return 0; |
| 204 | } else | 204 | } else |
| @@ -213,9 +213,9 @@ int ccw_device_start_key(struct ccw_device *cdev, struct ccw1 *cpa, | |||
| 213 | ret = cio_set_options (sch, flags); | 213 | ret = cio_set_options (sch, flags); |
| 214 | if (ret) | 214 | if (ret) |
| 215 | return ret; | 215 | return ret; |
| 216 | /* Adjust requested path mask to excluded varied off paths. */ | 216 | /* Adjust requested path mask to exclude unusable paths. */ |
| 217 | if (lpm) { | 217 | if (lpm) { |
| 218 | lpm &= sch->opm; | 218 | lpm &= sch->lpm; |
| 219 | if (lpm == 0) | 219 | if (lpm == 0) |
| 220 | return -EACCES; | 220 | return -EACCES; |
| 221 | } | 221 | } |
| @@ -605,11 +605,21 @@ int ccw_device_tm_start_key(struct ccw_device *cdev, struct tcw *tcw, | |||
| 605 | sch = to_subchannel(cdev->dev.parent); | 605 | sch = to_subchannel(cdev->dev.parent); |
| 606 | if (!sch->schib.pmcw.ena) | 606 | if (!sch->schib.pmcw.ena) |
| 607 | return -EINVAL; | 607 | return -EINVAL; |
| 608 | if (cdev->private->state == DEV_STATE_VERIFY) { | ||
| 609 | /* Remember to fake irb when finished. */ | ||
| 610 | if (!cdev->private->flags.fake_irb) { | ||
| 611 | cdev->private->flags.fake_irb = FAKE_TM_IRB; | ||
| 612 | cdev->private->intparm = intparm; | ||
| 613 | return 0; | ||
| 614 | } else | ||
| 615 | /* There's already a fake I/O around. */ | ||
| 616 | return -EBUSY; | ||
| 617 | } | ||
| 608 | if (cdev->private->state != DEV_STATE_ONLINE) | 618 | if (cdev->private->state != DEV_STATE_ONLINE) |
| 609 | return -EIO; | 619 | return -EIO; |
| 610 | /* Adjust requested path mask to excluded varied off paths. */ | 620 | /* Adjust requested path mask to exclude unusable paths. */ |
| 611 | if (lpm) { | 621 | if (lpm) { |
| 612 | lpm &= sch->opm; | 622 | lpm &= sch->lpm; |
| 613 | if (lpm == 0) | 623 | if (lpm == 0) |
| 614 | return -EACCES; | 624 | return -EACCES; |
| 615 | } | 625 | } |
diff --git a/drivers/s390/cio/io_sch.h b/drivers/s390/cio/io_sch.h index 2ebb492a5c17..76253dfcc1be 100644 --- a/drivers/s390/cio/io_sch.h +++ b/drivers/s390/cio/io_sch.h | |||
| @@ -111,6 +111,9 @@ enum cdev_todo { | |||
| 111 | CDEV_TODO_UNREG_EVAL, | 111 | CDEV_TODO_UNREG_EVAL, |
| 112 | }; | 112 | }; |
| 113 | 113 | ||
| 114 | #define FAKE_CMD_IRB 1 | ||
| 115 | #define FAKE_TM_IRB 2 | ||
| 116 | |||
| 114 | struct ccw_device_private { | 117 | struct ccw_device_private { |
| 115 | struct ccw_device *cdev; | 118 | struct ccw_device *cdev; |
| 116 | struct subchannel *sch; | 119 | struct subchannel *sch; |
| @@ -138,7 +141,7 @@ struct ccw_device_private { | |||
| 138 | unsigned int doverify:1; /* delayed path verification */ | 141 | unsigned int doverify:1; /* delayed path verification */ |
| 139 | unsigned int donotify:1; /* call notify function */ | 142 | unsigned int donotify:1; /* call notify function */ |
| 140 | unsigned int recog_done:1; /* dev. recog. complete */ | 143 | unsigned int recog_done:1; /* dev. recog. complete */ |
| 141 | unsigned int fake_irb:1; /* deliver faked irb */ | 144 | unsigned int fake_irb:2; /* deliver faked irb */ |
| 142 | unsigned int resuming:1; /* recognition while resume */ | 145 | unsigned int resuming:1; /* recognition while resume */ |
| 143 | unsigned int pgroup:1; /* pathgroup is set up */ | 146 | unsigned int pgroup:1; /* pathgroup is set up */ |
| 144 | unsigned int mpath:1; /* multipathing is set up */ | 147 | unsigned int mpath:1; /* multipathing is set up */ |
diff --git a/drivers/s390/crypto/ap_bus.c b/drivers/s390/crypto/ap_bus.c index ec94f049e995..96bbe9d12a79 100644 --- a/drivers/s390/crypto/ap_bus.c +++ b/drivers/s390/crypto/ap_bus.c | |||
| @@ -1552,6 +1552,8 @@ static void ap_reset(struct ap_device *ap_dev) | |||
| 1552 | rc = ap_init_queue(ap_dev->qid); | 1552 | rc = ap_init_queue(ap_dev->qid); |
| 1553 | if (rc == -ENODEV) | 1553 | if (rc == -ENODEV) |
| 1554 | ap_dev->unregistered = 1; | 1554 | ap_dev->unregistered = 1; |
| 1555 | else | ||
| 1556 | __ap_schedule_poll_timer(); | ||
| 1555 | } | 1557 | } |
| 1556 | 1558 | ||
| 1557 | static int __ap_poll_device(struct ap_device *ap_dev, unsigned long *flags) | 1559 | static int __ap_poll_device(struct ap_device *ap_dev, unsigned long *flags) |
diff --git a/drivers/s390/scsi/zfcp_scsi.c b/drivers/s390/scsi/zfcp_scsi.c index 11f07f888223..b79576b64f45 100644 --- a/drivers/s390/scsi/zfcp_scsi.c +++ b/drivers/s390/scsi/zfcp_scsi.c | |||
| @@ -55,6 +55,10 @@ static void zfcp_scsi_slave_destroy(struct scsi_device *sdev) | |||
| 55 | { | 55 | { |
| 56 | struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev); | 56 | struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev); |
| 57 | 57 | ||
| 58 | /* if previous slave_alloc returned early, there is nothing to do */ | ||
| 59 | if (!zfcp_sdev->port) | ||
| 60 | return; | ||
| 61 | |||
| 58 | zfcp_erp_lun_shutdown_wait(sdev, "scssd_1"); | 62 | zfcp_erp_lun_shutdown_wait(sdev, "scssd_1"); |
| 59 | put_device(&zfcp_sdev->port->dev); | 63 | put_device(&zfcp_sdev->port->dev); |
| 60 | } | 64 | } |
diff --git a/drivers/sbus/char/bbc_i2c.c b/drivers/sbus/char/bbc_i2c.c index 5f94d22c491e..542668292900 100644 --- a/drivers/sbus/char/bbc_i2c.c +++ b/drivers/sbus/char/bbc_i2c.c | |||
| @@ -233,13 +233,9 @@ int bbc_i2c_write_buf(struct bbc_i2c_client *client, | |||
| 233 | int ret = 0; | 233 | int ret = 0; |
| 234 | 234 | ||
| 235 | while (len > 0) { | 235 | while (len > 0) { |
| 236 | int err = bbc_i2c_writeb(client, *buf, off); | 236 | ret = bbc_i2c_writeb(client, *buf, off); |
| 237 | 237 | if (ret < 0) | |
| 238 | if (err < 0) { | ||
| 239 | ret = err; | ||
| 240 | break; | 238 | break; |
| 241 | } | ||
| 242 | |||
| 243 | len--; | 239 | len--; |
| 244 | buf++; | 240 | buf++; |
| 245 | off++; | 241 | off++; |
| @@ -253,11 +249,9 @@ int bbc_i2c_read_buf(struct bbc_i2c_client *client, | |||
| 253 | int ret = 0; | 249 | int ret = 0; |
| 254 | 250 | ||
| 255 | while (len > 0) { | 251 | while (len > 0) { |
| 256 | int err = bbc_i2c_readb(client, buf, off); | 252 | ret = bbc_i2c_readb(client, buf, off); |
| 257 | if (err < 0) { | 253 | if (ret < 0) |
| 258 | ret = err; | ||
| 259 | break; | 254 | break; |
| 260 | } | ||
| 261 | len--; | 255 | len--; |
| 262 | buf++; | 256 | buf++; |
| 263 | off++; | 257 | off++; |
| @@ -422,17 +416,6 @@ static struct platform_driver bbc_i2c_driver = { | |||
| 422 | .remove = __devexit_p(bbc_i2c_remove), | 416 | .remove = __devexit_p(bbc_i2c_remove), |
| 423 | }; | 417 | }; |
| 424 | 418 | ||
| 425 | static int __init bbc_i2c_init(void) | 419 | module_platform_driver(bbc_i2c_driver); |
| 426 | { | ||
| 427 | return platform_driver_register(&bbc_i2c_driver); | ||
| 428 | } | ||
| 429 | |||
| 430 | static void __exit bbc_i2c_exit(void) | ||
| 431 | { | ||
| 432 | platform_driver_unregister(&bbc_i2c_driver); | ||
| 433 | } | ||
| 434 | |||
| 435 | module_init(bbc_i2c_init); | ||
| 436 | module_exit(bbc_i2c_exit); | ||
| 437 | 420 | ||
| 438 | MODULE_LICENSE("GPL"); | 421 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c index 965a1fccd66a..4b9939726c34 100644 --- a/drivers/sbus/char/display7seg.c +++ b/drivers/sbus/char/display7seg.c | |||
| @@ -275,15 +275,4 @@ static struct platform_driver d7s_driver = { | |||
| 275 | .remove = __devexit_p(d7s_remove), | 275 | .remove = __devexit_p(d7s_remove), |
| 276 | }; | 276 | }; |
| 277 | 277 | ||
| 278 | static int __init d7s_init(void) | 278 | module_platform_driver(d7s_driver); |
| 279 | { | ||
| 280 | return platform_driver_register(&d7s_driver); | ||
| 281 | } | ||
| 282 | |||
| 283 | static void __exit d7s_exit(void) | ||
| 284 | { | ||
| 285 | platform_driver_unregister(&d7s_driver); | ||
| 286 | } | ||
| 287 | |||
| 288 | module_init(d7s_init); | ||
| 289 | module_exit(d7s_exit); | ||
diff --git a/drivers/sbus/char/envctrl.c b/drivers/sbus/char/envctrl.c index be7b4e56154f..339fd6f65eda 100644 --- a/drivers/sbus/char/envctrl.c +++ b/drivers/sbus/char/envctrl.c | |||
| @@ -1138,16 +1138,6 @@ static struct platform_driver envctrl_driver = { | |||
| 1138 | .remove = __devexit_p(envctrl_remove), | 1138 | .remove = __devexit_p(envctrl_remove), |
| 1139 | }; | 1139 | }; |
| 1140 | 1140 | ||
| 1141 | static int __init envctrl_init(void) | 1141 | module_platform_driver(envctrl_driver); |
| 1142 | { | ||
| 1143 | return platform_driver_register(&envctrl_driver); | ||
| 1144 | } | ||
| 1145 | |||
| 1146 | static void __exit envctrl_exit(void) | ||
| 1147 | { | ||
| 1148 | platform_driver_unregister(&envctrl_driver); | ||
| 1149 | } | ||
| 1150 | 1142 | ||
| 1151 | module_init(envctrl_init); | ||
| 1152 | module_exit(envctrl_exit); | ||
| 1153 | MODULE_LICENSE("GPL"); | 1143 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/sbus/char/flash.c b/drivers/sbus/char/flash.c index 73dd4e7afaaa..826157f38694 100644 --- a/drivers/sbus/char/flash.c +++ b/drivers/sbus/char/flash.c | |||
| @@ -216,16 +216,6 @@ static struct platform_driver flash_driver = { | |||
| 216 | .remove = __devexit_p(flash_remove), | 216 | .remove = __devexit_p(flash_remove), |
| 217 | }; | 217 | }; |
| 218 | 218 | ||
| 219 | static int __init flash_init(void) | 219 | module_platform_driver(flash_driver); |
| 220 | { | ||
| 221 | return platform_driver_register(&flash_driver); | ||
| 222 | } | ||
| 223 | |||
| 224 | static void __exit flash_cleanup(void) | ||
| 225 | { | ||
| 226 | platform_driver_unregister(&flash_driver); | ||
| 227 | } | ||
| 228 | 220 | ||
| 229 | module_init(flash_init); | ||
| 230 | module_exit(flash_cleanup); | ||
| 231 | MODULE_LICENSE("GPL"); | 221 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/sbus/char/uctrl.c b/drivers/sbus/char/uctrl.c index ebce9639a26a..0b31658ccde5 100644 --- a/drivers/sbus/char/uctrl.c +++ b/drivers/sbus/char/uctrl.c | |||
| @@ -435,16 +435,6 @@ static struct platform_driver uctrl_driver = { | |||
| 435 | }; | 435 | }; |
| 436 | 436 | ||
| 437 | 437 | ||
| 438 | static int __init uctrl_init(void) | 438 | module_platform_driver(uctrl_driver); |
| 439 | { | ||
| 440 | return platform_driver_register(&uctrl_driver); | ||
| 441 | } | ||
| 442 | |||
| 443 | static void __exit uctrl_exit(void) | ||
| 444 | { | ||
| 445 | platform_driver_unregister(&uctrl_driver); | ||
| 446 | } | ||
| 447 | 439 | ||
| 448 | module_init(uctrl_init); | ||
| 449 | module_exit(uctrl_exit); | ||
| 450 | MODULE_LICENSE("GPL"); | 440 | MODULE_LICENSE("GPL"); |
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c index dba72a4e6a1c..1ad0b8225560 100644 --- a/drivers/scsi/bnx2i/bnx2i_hwi.c +++ b/drivers/scsi/bnx2i/bnx2i_hwi.c | |||
| @@ -1906,18 +1906,19 @@ static int bnx2i_queue_scsi_cmd_resp(struct iscsi_session *session, | |||
| 1906 | spin_lock(&session->lock); | 1906 | spin_lock(&session->lock); |
| 1907 | task = iscsi_itt_to_task(bnx2i_conn->cls_conn->dd_data, | 1907 | task = iscsi_itt_to_task(bnx2i_conn->cls_conn->dd_data, |
| 1908 | cqe->itt & ISCSI_CMD_RESPONSE_INDEX); | 1908 | cqe->itt & ISCSI_CMD_RESPONSE_INDEX); |
| 1909 | if (!task) { | 1909 | if (!task || !task->sc) { |
| 1910 | spin_unlock(&session->lock); | 1910 | spin_unlock(&session->lock); |
| 1911 | return -EINVAL; | 1911 | return -EINVAL; |
| 1912 | } | 1912 | } |
| 1913 | sc = task->sc; | 1913 | sc = task->sc; |
| 1914 | spin_unlock(&session->lock); | ||
| 1915 | 1914 | ||
| 1916 | if (!blk_rq_cpu_valid(sc->request)) | 1915 | if (!blk_rq_cpu_valid(sc->request)) |
| 1917 | cpu = smp_processor_id(); | 1916 | cpu = smp_processor_id(); |
| 1918 | else | 1917 | else |
| 1919 | cpu = sc->request->cpu; | 1918 | cpu = sc->request->cpu; |
| 1920 | 1919 | ||
| 1920 | spin_unlock(&session->lock); | ||
| 1921 | |||
| 1921 | p = &per_cpu(bnx2i_percpu, cpu); | 1922 | p = &per_cpu(bnx2i_percpu, cpu); |
| 1922 | spin_lock(&p->p_work_lock); | 1923 | spin_lock(&p->p_work_lock); |
| 1923 | if (unlikely(!p->iothread)) { | 1924 | if (unlikely(!p->iothread)) { |
diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index cefbe44bb84a..8d67467dd9ce 100644 --- a/drivers/scsi/fcoe/fcoe.c +++ b/drivers/scsi/fcoe/fcoe.c | |||
| @@ -31,6 +31,8 @@ | |||
| 31 | #include <linux/sysfs.h> | 31 | #include <linux/sysfs.h> |
| 32 | #include <linux/ctype.h> | 32 | #include <linux/ctype.h> |
| 33 | #include <linux/workqueue.h> | 33 | #include <linux/workqueue.h> |
| 34 | #include <net/dcbnl.h> | ||
| 35 | #include <net/dcbevent.h> | ||
| 34 | #include <scsi/scsi_tcq.h> | 36 | #include <scsi/scsi_tcq.h> |
| 35 | #include <scsi/scsicam.h> | 37 | #include <scsi/scsicam.h> |
| 36 | #include <scsi/scsi_transport.h> | 38 | #include <scsi/scsi_transport.h> |
| @@ -101,6 +103,8 @@ static int fcoe_ddp_done(struct fc_lport *, u16); | |||
| 101 | static int fcoe_ddp_target(struct fc_lport *, u16, struct scatterlist *, | 103 | static int fcoe_ddp_target(struct fc_lport *, u16, struct scatterlist *, |
| 102 | unsigned int); | 104 | unsigned int); |
| 103 | static int fcoe_cpu_callback(struct notifier_block *, unsigned long, void *); | 105 | static int fcoe_cpu_callback(struct notifier_block *, unsigned long, void *); |
| 106 | static int fcoe_dcb_app_notification(struct notifier_block *notifier, | ||
| 107 | ulong event, void *ptr); | ||
| 104 | 108 | ||
| 105 | static bool fcoe_match(struct net_device *netdev); | 109 | static bool fcoe_match(struct net_device *netdev); |
| 106 | static int fcoe_create(struct net_device *netdev, enum fip_state fip_mode); | 110 | static int fcoe_create(struct net_device *netdev, enum fip_state fip_mode); |
| @@ -129,6 +133,11 @@ static struct notifier_block fcoe_cpu_notifier = { | |||
| 129 | .notifier_call = fcoe_cpu_callback, | 133 | .notifier_call = fcoe_cpu_callback, |
| 130 | }; | 134 | }; |
| 131 | 135 | ||
| 136 | /* notification function for DCB events */ | ||
| 137 | static struct notifier_block dcb_notifier = { | ||
| 138 | .notifier_call = fcoe_dcb_app_notification, | ||
| 139 | }; | ||
| 140 | |||
| 132 | static struct scsi_transport_template *fcoe_nport_scsi_transport; | 141 | static struct scsi_transport_template *fcoe_nport_scsi_transport; |
| 133 | static struct scsi_transport_template *fcoe_vport_scsi_transport; | 142 | static struct scsi_transport_template *fcoe_vport_scsi_transport; |
| 134 | 143 | ||
| @@ -1522,6 +1531,8 @@ int fcoe_xmit(struct fc_lport *lport, struct fc_frame *fp) | |||
| 1522 | skb_reset_network_header(skb); | 1531 | skb_reset_network_header(skb); |
| 1523 | skb->mac_len = elen; | 1532 | skb->mac_len = elen; |
| 1524 | skb->protocol = htons(ETH_P_FCOE); | 1533 | skb->protocol = htons(ETH_P_FCOE); |
| 1534 | skb->priority = port->priority; | ||
| 1535 | |||
| 1525 | if (fcoe->netdev->priv_flags & IFF_802_1Q_VLAN && | 1536 | if (fcoe->netdev->priv_flags & IFF_802_1Q_VLAN && |
| 1526 | fcoe->realdev->features & NETIF_F_HW_VLAN_TX) { | 1537 | fcoe->realdev->features & NETIF_F_HW_VLAN_TX) { |
| 1527 | skb->vlan_tci = VLAN_TAG_PRESENT | | 1538 | skb->vlan_tci = VLAN_TAG_PRESENT | |
| @@ -1624,6 +1635,7 @@ static inline int fcoe_filter_frames(struct fc_lport *lport, | |||
| 1624 | stats->InvalidCRCCount++; | 1635 | stats->InvalidCRCCount++; |
| 1625 | if (stats->InvalidCRCCount < 5) | 1636 | if (stats->InvalidCRCCount < 5) |
| 1626 | printk(KERN_WARNING "fcoe: dropping frame with CRC error\n"); | 1637 | printk(KERN_WARNING "fcoe: dropping frame with CRC error\n"); |
| 1638 | put_cpu(); | ||
| 1627 | return -EINVAL; | 1639 | return -EINVAL; |
| 1628 | } | 1640 | } |
| 1629 | 1641 | ||
| @@ -1746,6 +1758,7 @@ int fcoe_percpu_receive_thread(void *arg) | |||
| 1746 | */ | 1758 | */ |
| 1747 | static void fcoe_dev_setup(void) | 1759 | static void fcoe_dev_setup(void) |
| 1748 | { | 1760 | { |
| 1761 | register_dcbevent_notifier(&dcb_notifier); | ||
| 1749 | register_netdevice_notifier(&fcoe_notifier); | 1762 | register_netdevice_notifier(&fcoe_notifier); |
| 1750 | } | 1763 | } |
| 1751 | 1764 | ||
| @@ -1754,9 +1767,69 @@ static void fcoe_dev_setup(void) | |||
| 1754 | */ | 1767 | */ |
| 1755 | static void fcoe_dev_cleanup(void) | 1768 | static void fcoe_dev_cleanup(void) |
| 1756 | { | 1769 | { |
| 1770 | unregister_dcbevent_notifier(&dcb_notifier); | ||
| 1757 | unregister_netdevice_notifier(&fcoe_notifier); | 1771 | unregister_netdevice_notifier(&fcoe_notifier); |
| 1758 | } | 1772 | } |
| 1759 | 1773 | ||
| 1774 | static struct fcoe_interface * | ||
| 1775 | fcoe_hostlist_lookup_realdev_port(struct net_device *netdev) | ||
| 1776 | { | ||
| 1777 | struct fcoe_interface *fcoe; | ||
| 1778 | struct net_device *real_dev; | ||
| 1779 | |||
| 1780 | list_for_each_entry(fcoe, &fcoe_hostlist, list) { | ||
| 1781 | if (fcoe->netdev->priv_flags & IFF_802_1Q_VLAN) | ||
| 1782 | real_dev = vlan_dev_real_dev(fcoe->netdev); | ||
| 1783 | else | ||
| 1784 | real_dev = fcoe->netdev; | ||
| 1785 | |||
| 1786 | if (netdev == real_dev) | ||
| 1787 | return fcoe; | ||
| 1788 | } | ||
| 1789 | return NULL; | ||
| 1790 | } | ||
| 1791 | |||
| 1792 | static int fcoe_dcb_app_notification(struct notifier_block *notifier, | ||
| 1793 | ulong event, void *ptr) | ||
| 1794 | { | ||
| 1795 | struct dcb_app_type *entry = ptr; | ||
| 1796 | struct fcoe_interface *fcoe; | ||
| 1797 | struct net_device *netdev; | ||
| 1798 | struct fcoe_port *port; | ||
| 1799 | int prio; | ||
| 1800 | |||
| 1801 | if (entry->app.selector != DCB_APP_IDTYPE_ETHTYPE) | ||
| 1802 | return NOTIFY_OK; | ||
| 1803 | |||
| 1804 | netdev = dev_get_by_index(&init_net, entry->ifindex); | ||
| 1805 | if (!netdev) | ||
| 1806 | return NOTIFY_OK; | ||
| 1807 | |||
| 1808 | fcoe = fcoe_hostlist_lookup_realdev_port(netdev); | ||
| 1809 | dev_put(netdev); | ||
| 1810 | if (!fcoe) | ||
| 1811 | return NOTIFY_OK; | ||
| 1812 | |||
| 1813 | if (entry->dcbx & DCB_CAP_DCBX_VER_CEE) | ||
| 1814 | prio = ffs(entry->app.priority) - 1; | ||
| 1815 | else | ||
| 1816 | prio = entry->app.priority; | ||
| 1817 | |||
| 1818 | if (prio < 0) | ||
| 1819 | return NOTIFY_OK; | ||
| 1820 | |||
| 1821 | if (entry->app.protocol == ETH_P_FIP || | ||
| 1822 | entry->app.protocol == ETH_P_FCOE) | ||
| 1823 | fcoe->ctlr.priority = prio; | ||
| 1824 | |||
| 1825 | if (entry->app.protocol == ETH_P_FCOE) { | ||
| 1826 | port = lport_priv(fcoe->ctlr.lp); | ||
| 1827 | port->priority = prio; | ||
| 1828 | } | ||
| 1829 | |||
| 1830 | return NOTIFY_OK; | ||
| 1831 | } | ||
| 1832 | |||
| 1760 | /** | 1833 | /** |
| 1761 | * fcoe_device_notification() - Handler for net device events | 1834 | * fcoe_device_notification() - Handler for net device events |
| 1762 | * @notifier: The context of the notification | 1835 | * @notifier: The context of the notification |
| @@ -1965,6 +2038,46 @@ static bool fcoe_match(struct net_device *netdev) | |||
| 1965 | } | 2038 | } |
| 1966 | 2039 | ||
| 1967 | /** | 2040 | /** |
| 2041 | * fcoe_dcb_create() - Initialize DCB attributes and hooks | ||
| 2042 | * @netdev: The net_device object of the L2 link that should be queried | ||
| 2043 | * @port: The fcoe_port to bind FCoE APP priority with | ||
| 2044 | * @ | ||
| 2045 | */ | ||
| 2046 | static void fcoe_dcb_create(struct fcoe_interface *fcoe) | ||
| 2047 | { | ||
| 2048 | #ifdef CONFIG_DCB | ||
| 2049 | int dcbx; | ||
| 2050 | u8 fup, up; | ||
| 2051 | struct net_device *netdev = fcoe->realdev; | ||
| 2052 | struct fcoe_port *port = lport_priv(fcoe->ctlr.lp); | ||
| 2053 | struct dcb_app app = { | ||
| 2054 | .priority = 0, | ||
| 2055 | .protocol = ETH_P_FCOE | ||
| 2056 | }; | ||
| 2057 | |||
| 2058 | /* setup DCB priority attributes. */ | ||
| 2059 | if (netdev && netdev->dcbnl_ops && netdev->dcbnl_ops->getdcbx) { | ||
| 2060 | dcbx = netdev->dcbnl_ops->getdcbx(netdev); | ||
| 2061 | |||
| 2062 | if (dcbx & DCB_CAP_DCBX_VER_IEEE) { | ||
| 2063 | app.selector = IEEE_8021QAZ_APP_SEL_ETHERTYPE; | ||
| 2064 | up = dcb_ieee_getapp_mask(netdev, &app); | ||
| 2065 | app.protocol = ETH_P_FIP; | ||
| 2066 | fup = dcb_ieee_getapp_mask(netdev, &app); | ||
| 2067 | } else { | ||
| 2068 | app.selector = DCB_APP_IDTYPE_ETHTYPE; | ||
| 2069 | up = dcb_getapp(netdev, &app); | ||
| 2070 | app.protocol = ETH_P_FIP; | ||
| 2071 | fup = dcb_getapp(netdev, &app); | ||
| 2072 | } | ||
| 2073 | |||
| 2074 | port->priority = ffs(up) ? ffs(up) - 1 : 0; | ||
| 2075 | fcoe->ctlr.priority = ffs(fup) ? ffs(fup) - 1 : port->priority; | ||
| 2076 | } | ||
| 2077 | #endif | ||
| 2078 | } | ||
| 2079 | |||
| 2080 | /** | ||
| 1968 | * fcoe_create() - Create a fcoe interface | 2081 | * fcoe_create() - Create a fcoe interface |
| 1969 | * @netdev : The net_device object the Ethernet interface to create on | 2082 | * @netdev : The net_device object the Ethernet interface to create on |
| 1970 | * @fip_mode: The FIP mode for this creation | 2083 | * @fip_mode: The FIP mode for this creation |
| @@ -2007,6 +2120,9 @@ static int fcoe_create(struct net_device *netdev, enum fip_state fip_mode) | |||
| 2007 | /* Make this the "master" N_Port */ | 2120 | /* Make this the "master" N_Port */ |
| 2008 | fcoe->ctlr.lp = lport; | 2121 | fcoe->ctlr.lp = lport; |
| 2009 | 2122 | ||
| 2123 | /* setup DCB priority attributes. */ | ||
| 2124 | fcoe_dcb_create(fcoe); | ||
| 2125 | |||
| 2010 | /* add to lports list */ | 2126 | /* add to lports list */ |
| 2011 | fcoe_hostlist_add(lport); | 2127 | fcoe_hostlist_add(lport); |
| 2012 | 2128 | ||
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index c74c4b8e71ef..e7522dcc296e 100644 --- a/drivers/scsi/fcoe/fcoe_ctlr.c +++ b/drivers/scsi/fcoe/fcoe_ctlr.c | |||
| @@ -320,6 +320,7 @@ static void fcoe_ctlr_solicit(struct fcoe_ctlr *fip, struct fcoe_fcf *fcf) | |||
| 320 | 320 | ||
| 321 | skb_put(skb, sizeof(*sol)); | 321 | skb_put(skb, sizeof(*sol)); |
| 322 | skb->protocol = htons(ETH_P_FIP); | 322 | skb->protocol = htons(ETH_P_FIP); |
| 323 | skb->priority = fip->priority; | ||
| 323 | skb_reset_mac_header(skb); | 324 | skb_reset_mac_header(skb); |
| 324 | skb_reset_network_header(skb); | 325 | skb_reset_network_header(skb); |
| 325 | fip->send(fip, skb); | 326 | fip->send(fip, skb); |
| @@ -474,6 +475,7 @@ static void fcoe_ctlr_send_keep_alive(struct fcoe_ctlr *fip, | |||
| 474 | } | 475 | } |
| 475 | skb_put(skb, len); | 476 | skb_put(skb, len); |
| 476 | skb->protocol = htons(ETH_P_FIP); | 477 | skb->protocol = htons(ETH_P_FIP); |
| 478 | skb->priority = fip->priority; | ||
| 477 | skb_reset_mac_header(skb); | 479 | skb_reset_mac_header(skb); |
| 478 | skb_reset_network_header(skb); | 480 | skb_reset_network_header(skb); |
| 479 | fip->send(fip, skb); | 481 | fip->send(fip, skb); |
| @@ -566,6 +568,7 @@ static int fcoe_ctlr_encaps(struct fcoe_ctlr *fip, struct fc_lport *lport, | |||
| 566 | cap->fip.fip_dl_len = htons(dlen / FIP_BPW); | 568 | cap->fip.fip_dl_len = htons(dlen / FIP_BPW); |
| 567 | 569 | ||
| 568 | skb->protocol = htons(ETH_P_FIP); | 570 | skb->protocol = htons(ETH_P_FIP); |
| 571 | skb->priority = fip->priority; | ||
| 569 | skb_reset_mac_header(skb); | 572 | skb_reset_mac_header(skb); |
| 570 | skb_reset_network_header(skb); | 573 | skb_reset_network_header(skb); |
| 571 | return 0; | 574 | return 0; |
| @@ -1911,6 +1914,7 @@ static void fcoe_ctlr_vn_send(struct fcoe_ctlr *fip, | |||
| 1911 | 1914 | ||
| 1912 | skb_put(skb, len); | 1915 | skb_put(skb, len); |
| 1913 | skb->protocol = htons(ETH_P_FIP); | 1916 | skb->protocol = htons(ETH_P_FIP); |
| 1917 | skb->priority = fip->priority; | ||
| 1914 | skb_reset_mac_header(skb); | 1918 | skb_reset_mac_header(skb); |
| 1915 | skb_reset_network_header(skb); | 1919 | skb_reset_network_header(skb); |
| 1916 | 1920 | ||
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index 4e041f6d808c..d570573b7963 100644 --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c | |||
| @@ -4335,7 +4335,7 @@ _scsih_smart_predicted_fault(struct MPT2SAS_ADAPTER *ioc, u16 handle) | |||
| 4335 | /* insert into event log */ | 4335 | /* insert into event log */ |
| 4336 | sz = offsetof(Mpi2EventNotificationReply_t, EventData) + | 4336 | sz = offsetof(Mpi2EventNotificationReply_t, EventData) + |
| 4337 | sizeof(Mpi2EventDataSasDeviceStatusChange_t); | 4337 | sizeof(Mpi2EventDataSasDeviceStatusChange_t); |
| 4338 | event_reply = kzalloc(sz, GFP_KERNEL); | 4338 | event_reply = kzalloc(sz, GFP_ATOMIC); |
| 4339 | if (!event_reply) { | 4339 | if (!event_reply) { |
| 4340 | printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", | 4340 | printk(MPT2SAS_ERR_FMT "failure at %s:%d/%s()!\n", |
| 4341 | ioc->name, __FILE__, __LINE__, __func__); | 4341 | ioc->name, __FILE__, __LINE__, __func__); |
diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index ac326c41e931..6465dae5883a 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c | |||
| @@ -1762,12 +1762,31 @@ qla2x00_get_host_port_state(struct Scsi_Host *shost) | |||
| 1762 | scsi_qla_host_t *vha = shost_priv(shost); | 1762 | scsi_qla_host_t *vha = shost_priv(shost); |
| 1763 | struct scsi_qla_host *base_vha = pci_get_drvdata(vha->hw->pdev); | 1763 | struct scsi_qla_host *base_vha = pci_get_drvdata(vha->hw->pdev); |
| 1764 | 1764 | ||
| 1765 | if (!base_vha->flags.online) | 1765 | if (!base_vha->flags.online) { |
| 1766 | fc_host_port_state(shost) = FC_PORTSTATE_OFFLINE; | 1766 | fc_host_port_state(shost) = FC_PORTSTATE_OFFLINE; |
| 1767 | else if (atomic_read(&base_vha->loop_state) == LOOP_TIMEOUT) | 1767 | return; |
| 1768 | fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; | 1768 | } |
| 1769 | else | 1769 | |
| 1770 | switch (atomic_read(&base_vha->loop_state)) { | ||
| 1771 | case LOOP_UPDATE: | ||
| 1772 | fc_host_port_state(shost) = FC_PORTSTATE_DIAGNOSTICS; | ||
| 1773 | break; | ||
| 1774 | case LOOP_DOWN: | ||
| 1775 | if (test_bit(LOOP_RESYNC_NEEDED, &base_vha->dpc_flags)) | ||
| 1776 | fc_host_port_state(shost) = FC_PORTSTATE_DIAGNOSTICS; | ||
| 1777 | else | ||
| 1778 | fc_host_port_state(shost) = FC_PORTSTATE_LINKDOWN; | ||
| 1779 | break; | ||
| 1780 | case LOOP_DEAD: | ||
| 1781 | fc_host_port_state(shost) = FC_PORTSTATE_LINKDOWN; | ||
| 1782 | break; | ||
| 1783 | case LOOP_READY: | ||
| 1770 | fc_host_port_state(shost) = FC_PORTSTATE_ONLINE; | 1784 | fc_host_port_state(shost) = FC_PORTSTATE_ONLINE; |
| 1785 | break; | ||
| 1786 | default: | ||
| 1787 | fc_host_port_state(shost) = FC_PORTSTATE_UNKNOWN; | ||
| 1788 | break; | ||
| 1789 | } | ||
| 1771 | } | 1790 | } |
| 1772 | 1791 | ||
| 1773 | static int | 1792 | static int |
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c index 9df4787715c0..f3cddd5800c3 100644 --- a/drivers/scsi/qla2xxx/qla_dbg.c +++ b/drivers/scsi/qla2xxx/qla_dbg.c | |||
| @@ -12,17 +12,17 @@ | |||
| 12 | * | Level | Last Value Used | Holes | | 12 | * | Level | Last Value Used | Holes | |
| 13 | * ---------------------------------------------------------------------- | 13 | * ---------------------------------------------------------------------- |
| 14 | * | Module Init and Probe | 0x0116 | | | 14 | * | Module Init and Probe | 0x0116 | | |
| 15 | * | Mailbox commands | 0x1129 | | | 15 | * | Mailbox commands | 0x112b | | |
| 16 | * | Device Discovery | 0x2083 | | | 16 | * | Device Discovery | 0x2083 | | |
| 17 | * | Queue Command and IO tracing | 0x302e | 0x3008 | | 17 | * | Queue Command and IO tracing | 0x302e | 0x3008 | |
| 18 | * | DPC Thread | 0x401c | | | 18 | * | DPC Thread | 0x401c | | |
| 19 | * | Async Events | 0x5059 | | | 19 | * | Async Events | 0x5059 | | |
| 20 | * | Timer Routines | 0x600d | | | 20 | * | Timer Routines | 0x6010 | 0x600e,0x600f | |
| 21 | * | User Space Interactions | 0x709d | | | 21 | * | User Space Interactions | 0x709d | | |
| 22 | * | Task Management | 0x8041 | | | 22 | * | Task Management | 0x8041 | 0x800b | |
| 23 | * | AER/EEH | 0x900f | | | 23 | * | AER/EEH | 0x900f | | |
| 24 | * | Virtual Port | 0xa007 | | | 24 | * | Virtual Port | 0xa007 | | |
| 25 | * | ISP82XX Specific | 0xb051 | | | 25 | * | ISP82XX Specific | 0xb052 | | |
| 26 | * | MultiQ | 0xc00b | | | 26 | * | MultiQ | 0xc00b | | |
| 27 | * | Misc | 0xd00b | | | 27 | * | Misc | 0xd00b | | |
| 28 | * ---------------------------------------------------------------------- | 28 | * ---------------------------------------------------------------------- |
diff --git a/drivers/scsi/qla2xxx/qla_gbl.h b/drivers/scsi/qla2xxx/qla_gbl.h index ce32d8135c9e..c0c11afb685c 100644 --- a/drivers/scsi/qla2xxx/qla_gbl.h +++ b/drivers/scsi/qla2xxx/qla_gbl.h | |||
| @@ -578,6 +578,7 @@ extern int qla82xx_check_md_needed(scsi_qla_host_t *); | |||
| 578 | extern void qla82xx_chip_reset_cleanup(scsi_qla_host_t *); | 578 | extern void qla82xx_chip_reset_cleanup(scsi_qla_host_t *); |
| 579 | extern int qla82xx_mbx_beacon_ctl(scsi_qla_host_t *, int); | 579 | extern int qla82xx_mbx_beacon_ctl(scsi_qla_host_t *, int); |
| 580 | extern char *qdev_state(uint32_t); | 580 | extern char *qdev_state(uint32_t); |
| 581 | extern void qla82xx_clear_pending_mbx(scsi_qla_host_t *); | ||
| 581 | 582 | ||
| 582 | /* BSG related functions */ | 583 | /* BSG related functions */ |
| 583 | extern int qla24xx_bsg_request(struct fc_bsg_job *); | 584 | extern int qla24xx_bsg_request(struct fc_bsg_job *); |
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index f03e915f1877..54ea68cec4c5 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c | |||
| @@ -1509,7 +1509,8 @@ enable_82xx_npiv: | |||
| 1509 | &ha->fw_xcb_count, NULL, NULL, | 1509 | &ha->fw_xcb_count, NULL, NULL, |
| 1510 | &ha->max_npiv_vports, NULL); | 1510 | &ha->max_npiv_vports, NULL); |
| 1511 | 1511 | ||
| 1512 | if (!fw_major_version && ql2xallocfwdump) | 1512 | if (!fw_major_version && ql2xallocfwdump |
| 1513 | && !IS_QLA82XX(ha)) | ||
| 1513 | qla2x00_alloc_fw_dump(vha); | 1514 | qla2x00_alloc_fw_dump(vha); |
| 1514 | } | 1515 | } |
| 1515 | } else { | 1516 | } else { |
diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index dbec89622a0f..a4b267e60a35 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c | |||
| @@ -120,11 +120,10 @@ qla2x00_prep_cont_type0_iocb(struct scsi_qla_host *vha) | |||
| 120 | * Returns a pointer to the continuation type 1 IOCB packet. | 120 | * Returns a pointer to the continuation type 1 IOCB packet. |
| 121 | */ | 121 | */ |
| 122 | static inline cont_a64_entry_t * | 122 | static inline cont_a64_entry_t * |
| 123 | qla2x00_prep_cont_type1_iocb(scsi_qla_host_t *vha) | 123 | qla2x00_prep_cont_type1_iocb(scsi_qla_host_t *vha, struct req_que *req) |
| 124 | { | 124 | { |
| 125 | cont_a64_entry_t *cont_pkt; | 125 | cont_a64_entry_t *cont_pkt; |
| 126 | 126 | ||
| 127 | struct req_que *req = vha->req; | ||
| 128 | /* Adjust ring index. */ | 127 | /* Adjust ring index. */ |
| 129 | req->ring_index++; | 128 | req->ring_index++; |
| 130 | if (req->ring_index == req->length) { | 129 | if (req->ring_index == req->length) { |
| @@ -292,7 +291,7 @@ void qla2x00_build_scsi_iocbs_64(srb_t *sp, cmd_entry_t *cmd_pkt, | |||
| 292 | * Five DSDs are available in the Continuation | 291 | * Five DSDs are available in the Continuation |
| 293 | * Type 1 IOCB. | 292 | * Type 1 IOCB. |
| 294 | */ | 293 | */ |
| 295 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha); | 294 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha, vha->req); |
| 296 | cur_dsd = (uint32_t *)cont_pkt->dseg_0_address; | 295 | cur_dsd = (uint32_t *)cont_pkt->dseg_0_address; |
| 297 | avail_dsds = 5; | 296 | avail_dsds = 5; |
| 298 | } | 297 | } |
| @@ -684,7 +683,7 @@ qla24xx_build_scsi_iocbs(srb_t *sp, struct cmd_type_7 *cmd_pkt, | |||
| 684 | * Five DSDs are available in the Continuation | 683 | * Five DSDs are available in the Continuation |
| 685 | * Type 1 IOCB. | 684 | * Type 1 IOCB. |
| 686 | */ | 685 | */ |
| 687 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha); | 686 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha, vha->req); |
| 688 | cur_dsd = (uint32_t *)cont_pkt->dseg_0_address; | 687 | cur_dsd = (uint32_t *)cont_pkt->dseg_0_address; |
| 689 | avail_dsds = 5; | 688 | avail_dsds = 5; |
| 690 | } | 689 | } |
| @@ -2070,7 +2069,8 @@ qla2x00_ct_iocb(srb_t *sp, ms_iocb_entry_t *ct_iocb) | |||
| 2070 | * Five DSDs are available in the Cont. | 2069 | * Five DSDs are available in the Cont. |
| 2071 | * Type 1 IOCB. | 2070 | * Type 1 IOCB. |
| 2072 | */ | 2071 | */ |
| 2073 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha); | 2072 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha, |
| 2073 | vha->hw->req_q_map[0]); | ||
| 2074 | cur_dsd = (uint32_t *) cont_pkt->dseg_0_address; | 2074 | cur_dsd = (uint32_t *) cont_pkt->dseg_0_address; |
| 2075 | avail_dsds = 5; | 2075 | avail_dsds = 5; |
| 2076 | cont_iocb_prsnt = 1; | 2076 | cont_iocb_prsnt = 1; |
| @@ -2096,6 +2096,7 @@ qla24xx_ct_iocb(srb_t *sp, struct ct_entry_24xx *ct_iocb) | |||
| 2096 | int index; | 2096 | int index; |
| 2097 | uint16_t tot_dsds; | 2097 | uint16_t tot_dsds; |
| 2098 | scsi_qla_host_t *vha = sp->fcport->vha; | 2098 | scsi_qla_host_t *vha = sp->fcport->vha; |
| 2099 | struct qla_hw_data *ha = vha->hw; | ||
| 2099 | struct fc_bsg_job *bsg_job = ((struct srb_ctx *)sp->ctx)->u.bsg_job; | 2100 | struct fc_bsg_job *bsg_job = ((struct srb_ctx *)sp->ctx)->u.bsg_job; |
| 2100 | int loop_iterartion = 0; | 2101 | int loop_iterartion = 0; |
| 2101 | int cont_iocb_prsnt = 0; | 2102 | int cont_iocb_prsnt = 0; |
| @@ -2141,7 +2142,8 @@ qla24xx_ct_iocb(srb_t *sp, struct ct_entry_24xx *ct_iocb) | |||
| 2141 | * Five DSDs are available in the Cont. | 2142 | * Five DSDs are available in the Cont. |
| 2142 | * Type 1 IOCB. | 2143 | * Type 1 IOCB. |
| 2143 | */ | 2144 | */ |
| 2144 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha); | 2145 | cont_pkt = qla2x00_prep_cont_type1_iocb(vha, |
| 2146 | ha->req_q_map[0]); | ||
| 2145 | cur_dsd = (uint32_t *) cont_pkt->dseg_0_address; | 2147 | cur_dsd = (uint32_t *) cont_pkt->dseg_0_address; |
| 2146 | avail_dsds = 5; | 2148 | avail_dsds = 5; |
| 2147 | cont_iocb_prsnt = 1; | 2149 | cont_iocb_prsnt = 1; |
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 2516adf1aeea..7b91b290ffd6 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c | |||
| @@ -1741,7 +1741,7 @@ qla2x00_status_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, void *pkt) | |||
| 1741 | resid, scsi_bufflen(cp)); | 1741 | resid, scsi_bufflen(cp)); |
| 1742 | 1742 | ||
| 1743 | cp->result = DID_ERROR << 16 | lscsi_status; | 1743 | cp->result = DID_ERROR << 16 | lscsi_status; |
| 1744 | break; | 1744 | goto check_scsi_status; |
| 1745 | } | 1745 | } |
| 1746 | 1746 | ||
| 1747 | if (!lscsi_status && | 1747 | if (!lscsi_status && |
diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c index 3b3cec9f6ac2..82a33533ed26 100644 --- a/drivers/scsi/qla2xxx/qla_mbx.c +++ b/drivers/scsi/qla2xxx/qla_mbx.c | |||
| @@ -79,8 +79,7 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) | |||
| 79 | mcp->mb[0] = MBS_LINK_DOWN_ERROR; | 79 | mcp->mb[0] = MBS_LINK_DOWN_ERROR; |
| 80 | ql_log(ql_log_warn, base_vha, 0x1004, | 80 | ql_log(ql_log_warn, base_vha, 0x1004, |
| 81 | "FW hung = %d.\n", ha->flags.isp82xx_fw_hung); | 81 | "FW hung = %d.\n", ha->flags.isp82xx_fw_hung); |
| 82 | rval = QLA_FUNCTION_FAILED; | 82 | return QLA_FUNCTION_TIMEOUT; |
| 83 | goto premature_exit; | ||
| 84 | } | 83 | } |
| 85 | 84 | ||
| 86 | /* | 85 | /* |
| @@ -163,6 +162,7 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) | |||
| 163 | HINT_MBX_INT_PENDING) { | 162 | HINT_MBX_INT_PENDING) { |
| 164 | spin_unlock_irqrestore(&ha->hardware_lock, | 163 | spin_unlock_irqrestore(&ha->hardware_lock, |
| 165 | flags); | 164 | flags); |
| 165 | ha->flags.mbox_busy = 0; | ||
| 166 | ql_dbg(ql_dbg_mbx, base_vha, 0x1010, | 166 | ql_dbg(ql_dbg_mbx, base_vha, 0x1010, |
| 167 | "Pending mailbox timeout, exiting.\n"); | 167 | "Pending mailbox timeout, exiting.\n"); |
| 168 | rval = QLA_FUNCTION_TIMEOUT; | 168 | rval = QLA_FUNCTION_TIMEOUT; |
| @@ -188,6 +188,7 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) | |||
| 188 | HINT_MBX_INT_PENDING) { | 188 | HINT_MBX_INT_PENDING) { |
| 189 | spin_unlock_irqrestore(&ha->hardware_lock, | 189 | spin_unlock_irqrestore(&ha->hardware_lock, |
| 190 | flags); | 190 | flags); |
| 191 | ha->flags.mbox_busy = 0; | ||
| 191 | ql_dbg(ql_dbg_mbx, base_vha, 0x1012, | 192 | ql_dbg(ql_dbg_mbx, base_vha, 0x1012, |
| 192 | "Pending mailbox timeout, exiting.\n"); | 193 | "Pending mailbox timeout, exiting.\n"); |
| 193 | rval = QLA_FUNCTION_TIMEOUT; | 194 | rval = QLA_FUNCTION_TIMEOUT; |
| @@ -302,7 +303,15 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) | |||
| 302 | if (!test_bit(ISP_ABORT_NEEDED, &vha->dpc_flags) && | 303 | if (!test_bit(ISP_ABORT_NEEDED, &vha->dpc_flags) && |
| 303 | !test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) && | 304 | !test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) && |
| 304 | !test_bit(ISP_ABORT_RETRY, &vha->dpc_flags)) { | 305 | !test_bit(ISP_ABORT_RETRY, &vha->dpc_flags)) { |
| 305 | 306 | if (IS_QLA82XX(ha)) { | |
| 307 | ql_dbg(ql_dbg_mbx, vha, 0x112a, | ||
| 308 | "disabling pause transmit on port " | ||
| 309 | "0 & 1.\n"); | ||
| 310 | qla82xx_wr_32(ha, | ||
| 311 | QLA82XX_CRB_NIU + 0x98, | ||
| 312 | CRB_NIU_XG_PAUSE_CTL_P0| | ||
| 313 | CRB_NIU_XG_PAUSE_CTL_P1); | ||
| 314 | } | ||
| 306 | ql_log(ql_log_info, base_vha, 0x101c, | 315 | ql_log(ql_log_info, base_vha, 0x101c, |
| 307 | "Mailbox cmd timeout occured. " | 316 | "Mailbox cmd timeout occured. " |
| 308 | "Scheduling ISP abort eeh_busy=0x%x.\n", | 317 | "Scheduling ISP abort eeh_busy=0x%x.\n", |
| @@ -318,7 +327,15 @@ qla2x00_mailbox_command(scsi_qla_host_t *vha, mbx_cmd_t *mcp) | |||
| 318 | if (!test_bit(ISP_ABORT_NEEDED, &vha->dpc_flags) && | 327 | if (!test_bit(ISP_ABORT_NEEDED, &vha->dpc_flags) && |
| 319 | !test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) && | 328 | !test_bit(ABORT_ISP_ACTIVE, &vha->dpc_flags) && |
| 320 | !test_bit(ISP_ABORT_RETRY, &vha->dpc_flags)) { | 329 | !test_bit(ISP_ABORT_RETRY, &vha->dpc_flags)) { |
| 321 | 330 | if (IS_QLA82XX(ha)) { | |
| 331 | ql_dbg(ql_dbg_mbx, vha, 0x112b, | ||
| 332 | "disabling pause transmit on port " | ||
| 333 | "0 & 1.\n"); | ||
| 334 | qla82xx_wr_32(ha, | ||
| 335 | QLA82XX_CRB_NIU + 0x98, | ||
| 336 | CRB_NIU_XG_PAUSE_CTL_P0| | ||
| 337 | CRB_NIU_XG_PAUSE_CTL_P1); | ||
| 338 | } | ||
| 322 | ql_log(ql_log_info, base_vha, 0x101e, | 339 | ql_log(ql_log_info, base_vha, 0x101e, |
| 323 | "Mailbox cmd timeout occured. " | 340 | "Mailbox cmd timeout occured. " |
| 324 | "Scheduling ISP abort.\n"); | 341 | "Scheduling ISP abort.\n"); |
diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c index 94bded5ddce4..03554934b0a5 100644 --- a/drivers/scsi/qla2xxx/qla_nx.c +++ b/drivers/scsi/qla2xxx/qla_nx.c | |||
| @@ -3817,6 +3817,20 @@ exit: | |||
| 3817 | return rval; | 3817 | return rval; |
| 3818 | } | 3818 | } |
| 3819 | 3819 | ||
| 3820 | void qla82xx_clear_pending_mbx(scsi_qla_host_t *vha) | ||
| 3821 | { | ||
| 3822 | struct qla_hw_data *ha = vha->hw; | ||
| 3823 | |||
| 3824 | if (ha->flags.mbox_busy) { | ||
| 3825 | ha->flags.mbox_int = 1; | ||
| 3826 | ha->flags.mbox_busy = 0; | ||
| 3827 | ql_log(ql_log_warn, vha, 0x6010, | ||
| 3828 | "Doing premature completion of mbx command.\n"); | ||
| 3829 | if (test_bit(MBX_INTR_WAIT, &ha->mbx_cmd_flags)) | ||
| 3830 | complete(&ha->mbx_intr_comp); | ||
| 3831 | } | ||
| 3832 | } | ||
| 3833 | |||
| 3820 | void qla82xx_watchdog(scsi_qla_host_t *vha) | 3834 | void qla82xx_watchdog(scsi_qla_host_t *vha) |
| 3821 | { | 3835 | { |
| 3822 | uint32_t dev_state, halt_status; | 3836 | uint32_t dev_state, halt_status; |
| @@ -3839,9 +3853,13 @@ void qla82xx_watchdog(scsi_qla_host_t *vha) | |||
| 3839 | qla2xxx_wake_dpc(vha); | 3853 | qla2xxx_wake_dpc(vha); |
| 3840 | } else { | 3854 | } else { |
| 3841 | if (qla82xx_check_fw_alive(vha)) { | 3855 | if (qla82xx_check_fw_alive(vha)) { |
| 3856 | ql_dbg(ql_dbg_timer, vha, 0x6011, | ||
| 3857 | "disabling pause transmit on port 0 & 1.\n"); | ||
| 3858 | qla82xx_wr_32(ha, QLA82XX_CRB_NIU + 0x98, | ||
| 3859 | CRB_NIU_XG_PAUSE_CTL_P0|CRB_NIU_XG_PAUSE_CTL_P1); | ||
| 3842 | halt_status = qla82xx_rd_32(ha, | 3860 | halt_status = qla82xx_rd_32(ha, |
| 3843 | QLA82XX_PEG_HALT_STATUS1); | 3861 | QLA82XX_PEG_HALT_STATUS1); |
| 3844 | ql_dbg(ql_dbg_timer, vha, 0x6005, | 3862 | ql_log(ql_log_info, vha, 0x6005, |
| 3845 | "dumping hw/fw registers:.\n " | 3863 | "dumping hw/fw registers:.\n " |
| 3846 | " PEG_HALT_STATUS1: 0x%x, PEG_HALT_STATUS2: 0x%x,.\n " | 3864 | " PEG_HALT_STATUS1: 0x%x, PEG_HALT_STATUS2: 0x%x,.\n " |
| 3847 | " PEG_NET_0_PC: 0x%x, PEG_NET_1_PC: 0x%x,.\n " | 3865 | " PEG_NET_0_PC: 0x%x, PEG_NET_1_PC: 0x%x,.\n " |
| @@ -3858,6 +3876,11 @@ void qla82xx_watchdog(scsi_qla_host_t *vha) | |||
| 3858 | QLA82XX_CRB_PEG_NET_3 + 0x3c), | 3876 | QLA82XX_CRB_PEG_NET_3 + 0x3c), |
| 3859 | qla82xx_rd_32(ha, | 3877 | qla82xx_rd_32(ha, |
| 3860 | QLA82XX_CRB_PEG_NET_4 + 0x3c)); | 3878 | QLA82XX_CRB_PEG_NET_4 + 0x3c)); |
| 3879 | if (LSW(MSB(halt_status)) == 0x67) | ||
| 3880 | ql_log(ql_log_warn, vha, 0xb052, | ||
| 3881 | "Firmware aborted with " | ||
| 3882 | "error code 0x00006700. Device is " | ||
| 3883 | "being reset.\n"); | ||
| 3861 | if (halt_status & HALT_STATUS_UNRECOVERABLE) { | 3884 | if (halt_status & HALT_STATUS_UNRECOVERABLE) { |
| 3862 | set_bit(ISP_UNRECOVERABLE, | 3885 | set_bit(ISP_UNRECOVERABLE, |
| 3863 | &vha->dpc_flags); | 3886 | &vha->dpc_flags); |
| @@ -3869,16 +3892,8 @@ void qla82xx_watchdog(scsi_qla_host_t *vha) | |||
| 3869 | } | 3892 | } |
| 3870 | qla2xxx_wake_dpc(vha); | 3893 | qla2xxx_wake_dpc(vha); |
| 3871 | ha->flags.isp82xx_fw_hung = 1; | 3894 | ha->flags.isp82xx_fw_hung = 1; |
| 3872 | if (ha->flags.mbox_busy) { | 3895 | ql_log(ql_log_warn, vha, 0x6007, "Firmware hung.\n"); |
| 3873 | ha->flags.mbox_int = 1; | 3896 | qla82xx_clear_pending_mbx(vha); |
| 3874 | ql_log(ql_log_warn, vha, 0x6007, | ||
| 3875 | "Due to FW hung, doing " | ||
| 3876 | "premature completion of mbx " | ||
| 3877 | "command.\n"); | ||
| 3878 | if (test_bit(MBX_INTR_WAIT, | ||
| 3879 | &ha->mbx_cmd_flags)) | ||
| 3880 | complete(&ha->mbx_intr_comp); | ||
| 3881 | } | ||
| 3882 | } | 3897 | } |
| 3883 | } | 3898 | } |
| 3884 | } | 3899 | } |
| @@ -4073,10 +4088,7 @@ qla82xx_chip_reset_cleanup(scsi_qla_host_t *vha) | |||
| 4073 | msleep(1000); | 4088 | msleep(1000); |
| 4074 | if (qla82xx_check_fw_alive(vha)) { | 4089 | if (qla82xx_check_fw_alive(vha)) { |
| 4075 | ha->flags.isp82xx_fw_hung = 1; | 4090 | ha->flags.isp82xx_fw_hung = 1; |
| 4076 | if (ha->flags.mbox_busy) { | 4091 | qla82xx_clear_pending_mbx(vha); |
| 4077 | ha->flags.mbox_int = 1; | ||
| 4078 | complete(&ha->mbx_intr_comp); | ||
| 4079 | } | ||
| 4080 | break; | 4092 | break; |
| 4081 | } | 4093 | } |
| 4082 | } | 4094 | } |
diff --git a/drivers/scsi/qla2xxx/qla_nx.h b/drivers/scsi/qla2xxx/qla_nx.h index 57820c199bc2..57a226be339a 100644 --- a/drivers/scsi/qla2xxx/qla_nx.h +++ b/drivers/scsi/qla2xxx/qla_nx.h | |||
| @@ -1173,4 +1173,8 @@ struct qla82xx_md_entry_queue { | |||
| 1173 | 1173 | ||
| 1174 | static const int MD_MIU_TEST_AGT_RDDATA[] = { 0x410000A8, 0x410000AC, | 1174 | static const int MD_MIU_TEST_AGT_RDDATA[] = { 0x410000A8, 0x410000AC, |
| 1175 | 0x410000B8, 0x410000BC }; | 1175 | 0x410000B8, 0x410000BC }; |
| 1176 | |||
| 1177 | #define CRB_NIU_XG_PAUSE_CTL_P0 0x1 | ||
| 1178 | #define CRB_NIU_XG_PAUSE_CTL_P1 0x8 | ||
| 1179 | |||
| 1176 | #endif | 1180 | #endif |
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index fd14c7bfc626..f9e5b85e84d8 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c | |||
| @@ -201,12 +201,12 @@ MODULE_PARM_DESC(ql2xmdcapmask, | |||
| 201 | "Set the Minidump driver capture mask level. " | 201 | "Set the Minidump driver capture mask level. " |
| 202 | "Default is 0x7F - Can be set to 0x3, 0x7, 0xF, 0x1F, 0x7F."); | 202 | "Default is 0x7F - Can be set to 0x3, 0x7, 0xF, 0x1F, 0x7F."); |
| 203 | 203 | ||
| 204 | int ql2xmdenable; | 204 | int ql2xmdenable = 1; |
| 205 | module_param(ql2xmdenable, int, S_IRUGO); | 205 | module_param(ql2xmdenable, int, S_IRUGO); |
| 206 | MODULE_PARM_DESC(ql2xmdenable, | 206 | MODULE_PARM_DESC(ql2xmdenable, |
| 207 | "Enable/disable MiniDump. " | 207 | "Enable/disable MiniDump. " |
| 208 | "0 (Default) - MiniDump disabled. " | 208 | "0 - MiniDump disabled. " |
| 209 | "1 - MiniDump enabled."); | 209 | "1 (Default) - MiniDump enabled."); |
| 210 | 210 | ||
| 211 | /* | 211 | /* |
| 212 | * SCSI host template entry points | 212 | * SCSI host template entry points |
| @@ -423,6 +423,7 @@ fail2: | |||
| 423 | qla25xx_delete_queues(vha); | 423 | qla25xx_delete_queues(vha); |
| 424 | destroy_workqueue(ha->wq); | 424 | destroy_workqueue(ha->wq); |
| 425 | ha->wq = NULL; | 425 | ha->wq = NULL; |
| 426 | vha->req = ha->req_q_map[0]; | ||
| 426 | fail: | 427 | fail: |
| 427 | ha->mqenable = 0; | 428 | ha->mqenable = 0; |
| 428 | kfree(ha->req_q_map); | 429 | kfree(ha->req_q_map); |
| @@ -814,49 +815,6 @@ qla2x00_wait_for_chip_reset(scsi_qla_host_t *vha) | |||
| 814 | return return_status; | 815 | return return_status; |
| 815 | } | 816 | } |
| 816 | 817 | ||
| 817 | /* | ||
| 818 | * qla2x00_wait_for_loop_ready | ||
| 819 | * Wait for MAX_LOOP_TIMEOUT(5 min) value for loop | ||
| 820 | * to be in LOOP_READY state. | ||
| 821 | * Input: | ||
| 822 | * ha - pointer to host adapter structure | ||
| 823 | * | ||
| 824 | * Note: | ||
| 825 | * Does context switching-Release SPIN_LOCK | ||
| 826 | * (if any) before calling this routine. | ||
| 827 | * | ||
| 828 | * | ||
| 829 | * Return: | ||
| 830 | * Success (LOOP_READY) : 0 | ||
| 831 | * Failed (LOOP_NOT_READY) : 1 | ||
| 832 | */ | ||
| 833 | static inline int | ||
| 834 | qla2x00_wait_for_loop_ready(scsi_qla_host_t *vha) | ||
| 835 | { | ||
| 836 | int return_status = QLA_SUCCESS; | ||
| 837 | unsigned long loop_timeout ; | ||
| 838 | struct qla_hw_data *ha = vha->hw; | ||
| 839 | scsi_qla_host_t *base_vha = pci_get_drvdata(ha->pdev); | ||
| 840 | |||
| 841 | /* wait for 5 min at the max for loop to be ready */ | ||
| 842 | loop_timeout = jiffies + (MAX_LOOP_TIMEOUT * HZ); | ||
| 843 | |||
| 844 | while ((!atomic_read(&base_vha->loop_down_timer) && | ||
| 845 | atomic_read(&base_vha->loop_state) == LOOP_DOWN) || | ||
| 846 | atomic_read(&base_vha->loop_state) != LOOP_READY) { | ||
| 847 | if (atomic_read(&base_vha->loop_state) == LOOP_DEAD) { | ||
| 848 | return_status = QLA_FUNCTION_FAILED; | ||
| 849 | break; | ||
| 850 | } | ||
| 851 | msleep(1000); | ||
| 852 | if (time_after_eq(jiffies, loop_timeout)) { | ||
| 853 | return_status = QLA_FUNCTION_FAILED; | ||
| 854 | break; | ||
| 855 | } | ||
| 856 | } | ||
| 857 | return (return_status); | ||
| 858 | } | ||
| 859 | |||
| 860 | static void | 818 | static void |
| 861 | sp_get(struct srb *sp) | 819 | sp_get(struct srb *sp) |
| 862 | { | 820 | { |
| @@ -1035,12 +993,6 @@ __qla2xxx_eh_generic_reset(char *name, enum nexus_wait_type type, | |||
| 1035 | "Wait for hba online failed for cmd=%p.\n", cmd); | 993 | "Wait for hba online failed for cmd=%p.\n", cmd); |
| 1036 | goto eh_reset_failed; | 994 | goto eh_reset_failed; |
| 1037 | } | 995 | } |
| 1038 | err = 1; | ||
| 1039 | if (qla2x00_wait_for_loop_ready(vha) != QLA_SUCCESS) { | ||
| 1040 | ql_log(ql_log_warn, vha, 0x800b, | ||
| 1041 | "Wait for loop ready failed for cmd=%p.\n", cmd); | ||
| 1042 | goto eh_reset_failed; | ||
| 1043 | } | ||
| 1044 | err = 2; | 996 | err = 2; |
| 1045 | if (do_reset(fcport, cmd->device->lun, cmd->request->cpu + 1) | 997 | if (do_reset(fcport, cmd->device->lun, cmd->request->cpu + 1) |
| 1046 | != QLA_SUCCESS) { | 998 | != QLA_SUCCESS) { |
| @@ -1137,10 +1089,9 @@ qla2xxx_eh_bus_reset(struct scsi_cmnd *cmd) | |||
| 1137 | goto eh_bus_reset_done; | 1089 | goto eh_bus_reset_done; |
| 1138 | } | 1090 | } |
| 1139 | 1091 | ||
| 1140 | if (qla2x00_wait_for_loop_ready(vha) == QLA_SUCCESS) { | 1092 | if (qla2x00_loop_reset(vha) == QLA_SUCCESS) |
| 1141 | if (qla2x00_loop_reset(vha) == QLA_SUCCESS) | 1093 | ret = SUCCESS; |
| 1142 | ret = SUCCESS; | 1094 | |
| 1143 | } | ||
| 1144 | if (ret == FAILED) | 1095 | if (ret == FAILED) |
| 1145 | goto eh_bus_reset_done; | 1096 | goto eh_bus_reset_done; |
| 1146 | 1097 | ||
| @@ -1206,15 +1157,6 @@ qla2xxx_eh_host_reset(struct scsi_cmnd *cmd) | |||
| 1206 | if (qla2x00_wait_for_reset_ready(vha) != QLA_SUCCESS) | 1157 | if (qla2x00_wait_for_reset_ready(vha) != QLA_SUCCESS) |
| 1207 | goto eh_host_reset_lock; | 1158 | goto eh_host_reset_lock; |
| 1208 | 1159 | ||
| 1209 | /* | ||
| 1210 | * Fixme-may be dpc thread is active and processing | ||
| 1211 | * loop_resync,so wait a while for it to | ||
| 1212 | * be completed and then issue big hammer.Otherwise | ||
| 1213 | * it may cause I/O failure as big hammer marks the | ||
| 1214 | * devices as lost kicking of the port_down_timer | ||
| 1215 | * while dpc is stuck for the mailbox to complete. | ||
| 1216 | */ | ||
| 1217 | qla2x00_wait_for_loop_ready(vha); | ||
| 1218 | if (vha != base_vha) { | 1160 | if (vha != base_vha) { |
| 1219 | if (qla2x00_vp_abort_isp(vha)) | 1161 | if (qla2x00_vp_abort_isp(vha)) |
| 1220 | goto eh_host_reset_lock; | 1162 | goto eh_host_reset_lock; |
| @@ -1297,16 +1239,13 @@ qla2x00_loop_reset(scsi_qla_host_t *vha) | |||
| 1297 | atomic_set(&vha->loop_state, LOOP_DOWN); | 1239 | atomic_set(&vha->loop_state, LOOP_DOWN); |
| 1298 | atomic_set(&vha->loop_down_timer, LOOP_DOWN_TIME); | 1240 | atomic_set(&vha->loop_down_timer, LOOP_DOWN_TIME); |
| 1299 | qla2x00_mark_all_devices_lost(vha, 0); | 1241 | qla2x00_mark_all_devices_lost(vha, 0); |
| 1300 | qla2x00_wait_for_loop_ready(vha); | ||
| 1301 | } | 1242 | } |
| 1302 | 1243 | ||
| 1303 | if (ha->flags.enable_lip_reset) { | 1244 | if (ha->flags.enable_lip_reset) { |
| 1304 | ret = qla2x00_lip_reset(vha); | 1245 | ret = qla2x00_lip_reset(vha); |
| 1305 | if (ret != QLA_SUCCESS) { | 1246 | if (ret != QLA_SUCCESS) |
| 1306 | ql_dbg(ql_dbg_taskm, vha, 0x802e, | 1247 | ql_dbg(ql_dbg_taskm, vha, 0x802e, |
| 1307 | "lip_reset failed (%d).\n", ret); | 1248 | "lip_reset failed (%d).\n", ret); |
| 1308 | } else | ||
| 1309 | qla2x00_wait_for_loop_ready(vha); | ||
| 1310 | } | 1249 | } |
| 1311 | 1250 | ||
| 1312 | /* Issue marker command only when we are going to start the I/O */ | 1251 | /* Issue marker command only when we are going to start the I/O */ |
| @@ -4070,13 +4009,8 @@ qla2xxx_pci_error_detected(struct pci_dev *pdev, pci_channel_state_t state) | |||
| 4070 | /* For ISP82XX complete any pending mailbox cmd */ | 4009 | /* For ISP82XX complete any pending mailbox cmd */ |
| 4071 | if (IS_QLA82XX(ha)) { | 4010 | if (IS_QLA82XX(ha)) { |
| 4072 | ha->flags.isp82xx_fw_hung = 1; | 4011 | ha->flags.isp82xx_fw_hung = 1; |
| 4073 | if (ha->flags.mbox_busy) { | 4012 | ql_dbg(ql_dbg_aer, vha, 0x9001, "Pci channel io frozen\n"); |
| 4074 | ha->flags.mbox_int = 1; | 4013 | qla82xx_clear_pending_mbx(vha); |
| 4075 | ql_dbg(ql_dbg_aer, vha, 0x9001, | ||
| 4076 | "Due to pci channel io frozen, doing premature " | ||
| 4077 | "completion of mbx command.\n"); | ||
| 4078 | complete(&ha->mbx_intr_comp); | ||
| 4079 | } | ||
| 4080 | } | 4014 | } |
| 4081 | qla2x00_free_irqs(vha); | 4015 | qla2x00_free_irqs(vha); |
| 4082 | pci_disable_device(pdev); | 4016 | pci_disable_device(pdev); |
diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 13b6357c1fa2..23f33a6d52d7 100644 --- a/drivers/scsi/qla2xxx/qla_version.h +++ b/drivers/scsi/qla2xxx/qla_version.h | |||
| @@ -7,7 +7,7 @@ | |||
| 7 | /* | 7 | /* |
| 8 | * Driver version | 8 | * Driver version |
| 9 | */ | 9 | */ |
| 10 | #define QLA2XXX_VERSION "8.03.07.07-k" | 10 | #define QLA2XXX_VERSION "8.03.07.12-k" |
| 11 | 11 | ||
| 12 | #define QLA_DRIVER_MAJOR_VER 8 | 12 | #define QLA_DRIVER_MAJOR_VER 8 |
| 13 | #define QLA_DRIVER_MINOR_VER 3 | 13 | #define QLA_DRIVER_MINOR_VER 3 |
diff --git a/drivers/scsi/qla4xxx/ql4_def.h b/drivers/scsi/qla4xxx/ql4_def.h index ace637bf254e..fd5edc6e166d 100644 --- a/drivers/scsi/qla4xxx/ql4_def.h +++ b/drivers/scsi/qla4xxx/ql4_def.h | |||
| @@ -147,7 +147,7 @@ | |||
| 147 | #define ISCSI_ALIAS_SIZE 32 /* ISCSI Alias name size */ | 147 | #define ISCSI_ALIAS_SIZE 32 /* ISCSI Alias name size */ |
| 148 | #define ISCSI_NAME_SIZE 0xE0 /* ISCSI Name size */ | 148 | #define ISCSI_NAME_SIZE 0xE0 /* ISCSI Name size */ |
| 149 | 149 | ||
| 150 | #define QL4_SESS_RECOVERY_TMO 30 /* iSCSI session */ | 150 | #define QL4_SESS_RECOVERY_TMO 120 /* iSCSI session */ |
| 151 | /* recovery timeout */ | 151 | /* recovery timeout */ |
| 152 | 152 | ||
| 153 | #define LSDW(x) ((u32)((u64)(x))) | 153 | #define LSDW(x) ((u32)((u64)(x))) |
| @@ -173,6 +173,8 @@ | |||
| 173 | #define ISNS_DEREG_TOV 5 | 173 | #define ISNS_DEREG_TOV 5 |
| 174 | #define HBA_ONLINE_TOV 30 | 174 | #define HBA_ONLINE_TOV 30 |
| 175 | #define DISABLE_ACB_TOV 30 | 175 | #define DISABLE_ACB_TOV 30 |
| 176 | #define IP_CONFIG_TOV 30 | ||
| 177 | #define LOGIN_TOV 12 | ||
| 176 | 178 | ||
| 177 | #define MAX_RESET_HA_RETRIES 2 | 179 | #define MAX_RESET_HA_RETRIES 2 |
| 178 | 180 | ||
| @@ -240,6 +242,45 @@ struct ddb_entry { | |||
| 240 | 242 | ||
| 241 | uint16_t fw_ddb_index; /* DDB firmware index */ | 243 | uint16_t fw_ddb_index; /* DDB firmware index */ |
| 242 | uint32_t fw_ddb_device_state; /* F/W Device State -- see ql4_fw.h */ | 244 | uint32_t fw_ddb_device_state; /* F/W Device State -- see ql4_fw.h */ |
| 245 | uint16_t ddb_type; | ||
| 246 | #define FLASH_DDB 0x01 | ||
| 247 | |||
| 248 | struct dev_db_entry fw_ddb_entry; | ||
| 249 | int (*unblock_sess)(struct iscsi_cls_session *cls_session); | ||
| 250 | int (*ddb_change)(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | ||
| 251 | struct ddb_entry *ddb_entry, uint32_t state); | ||
| 252 | |||
| 253 | /* Driver Re-login */ | ||
| 254 | unsigned long flags; /* DDB Flags */ | ||
| 255 | uint16_t default_relogin_timeout; /* Max time to wait for | ||
| 256 | * relogin to complete */ | ||
| 257 | atomic_t retry_relogin_timer; /* Min Time between relogins | ||
| 258 | * (4000 only) */ | ||
| 259 | atomic_t relogin_timer; /* Max Time to wait for | ||
| 260 | * relogin to complete */ | ||
| 261 | atomic_t relogin_retry_count; /* Num of times relogin has been | ||
| 262 | * retried */ | ||
| 263 | uint32_t default_time2wait; /* Default Min time between | ||
| 264 | * relogins (+aens) */ | ||
| 265 | |||
| 266 | }; | ||
| 267 | |||
| 268 | struct qla_ddb_index { | ||
| 269 | struct list_head list; | ||
| 270 | uint16_t fw_ddb_idx; | ||
| 271 | struct dev_db_entry fw_ddb; | ||
| 272 | }; | ||
| 273 | |||
| 274 | #define DDB_IPADDR_LEN 64 | ||
| 275 | |||
| 276 | struct ql4_tuple_ddb { | ||
| 277 | int port; | ||
| 278 | int tpgt; | ||
| 279 | char ip_addr[DDB_IPADDR_LEN]; | ||
| 280 | char iscsi_name[ISCSI_NAME_SIZE]; | ||
| 281 | uint16_t options; | ||
| 282 | #define DDB_OPT_IPV6 0x0e0e | ||
| 283 | #define DDB_OPT_IPV4 0x0f0f | ||
| 243 | }; | 284 | }; |
| 244 | 285 | ||
| 245 | /* | 286 | /* |
| @@ -411,7 +452,7 @@ struct scsi_qla_host { | |||
| 411 | #define AF_FW_RECOVERY 19 /* 0x00080000 */ | 452 | #define AF_FW_RECOVERY 19 /* 0x00080000 */ |
| 412 | #define AF_EEH_BUSY 20 /* 0x00100000 */ | 453 | #define AF_EEH_BUSY 20 /* 0x00100000 */ |
| 413 | #define AF_PCI_CHANNEL_IO_PERM_FAILURE 21 /* 0x00200000 */ | 454 | #define AF_PCI_CHANNEL_IO_PERM_FAILURE 21 /* 0x00200000 */ |
| 414 | 455 | #define AF_BUILD_DDB_LIST 22 /* 0x00400000 */ | |
| 415 | unsigned long dpc_flags; | 456 | unsigned long dpc_flags; |
| 416 | 457 | ||
| 417 | #define DPC_RESET_HA 1 /* 0x00000002 */ | 458 | #define DPC_RESET_HA 1 /* 0x00000002 */ |
| @@ -604,6 +645,7 @@ struct scsi_qla_host { | |||
| 604 | uint16_t bootload_minor; | 645 | uint16_t bootload_minor; |
| 605 | uint16_t bootload_patch; | 646 | uint16_t bootload_patch; |
| 606 | uint16_t bootload_build; | 647 | uint16_t bootload_build; |
| 648 | uint16_t def_timeout; /* Default login timeout */ | ||
| 607 | 649 | ||
| 608 | uint32_t flash_state; | 650 | uint32_t flash_state; |
| 609 | #define QLFLASH_WAITING 0 | 651 | #define QLFLASH_WAITING 0 |
| @@ -623,6 +665,11 @@ struct scsi_qla_host { | |||
| 623 | uint16_t iscsi_pci_func_cnt; | 665 | uint16_t iscsi_pci_func_cnt; |
| 624 | uint8_t model_name[16]; | 666 | uint8_t model_name[16]; |
| 625 | struct completion disable_acb_comp; | 667 | struct completion disable_acb_comp; |
| 668 | struct dma_pool *fw_ddb_dma_pool; | ||
| 669 | #define DDB_DMA_BLOCK_SIZE 512 | ||
| 670 | uint16_t pri_ddb_idx; | ||
| 671 | uint16_t sec_ddb_idx; | ||
| 672 | int is_reset; | ||
| 626 | }; | 673 | }; |
| 627 | 674 | ||
| 628 | struct ql4_task_data { | 675 | struct ql4_task_data { |
| @@ -835,6 +882,10 @@ static inline int ql4xxx_reset_active(struct scsi_qla_host *ha) | |||
| 835 | /*---------------------------------------------------------------------------*/ | 882 | /*---------------------------------------------------------------------------*/ |
| 836 | 883 | ||
| 837 | /* Defines for qla4xxx_initialize_adapter() and qla4xxx_recover_adapter() */ | 884 | /* Defines for qla4xxx_initialize_adapter() and qla4xxx_recover_adapter() */ |
| 885 | |||
| 886 | #define INIT_ADAPTER 0 | ||
| 887 | #define RESET_ADAPTER 1 | ||
| 888 | |||
| 838 | #define PRESERVE_DDB_LIST 0 | 889 | #define PRESERVE_DDB_LIST 0 |
| 839 | #define REBUILD_DDB_LIST 1 | 890 | #define REBUILD_DDB_LIST 1 |
| 840 | 891 | ||
diff --git a/drivers/scsi/qla4xxx/ql4_fw.h b/drivers/scsi/qla4xxx/ql4_fw.h index cbd5a20dbbd1..4ac07f882521 100644 --- a/drivers/scsi/qla4xxx/ql4_fw.h +++ b/drivers/scsi/qla4xxx/ql4_fw.h | |||
| @@ -12,6 +12,7 @@ | |||
| 12 | #define MAX_PRST_DEV_DB_ENTRIES 64 | 12 | #define MAX_PRST_DEV_DB_ENTRIES 64 |
| 13 | #define MIN_DISC_DEV_DB_ENTRY MAX_PRST_DEV_DB_ENTRIES | 13 | #define MIN_DISC_DEV_DB_ENTRY MAX_PRST_DEV_DB_ENTRIES |
| 14 | #define MAX_DEV_DB_ENTRIES 512 | 14 | #define MAX_DEV_DB_ENTRIES 512 |
| 15 | #define MAX_DEV_DB_ENTRIES_40XX 256 | ||
| 15 | 16 | ||
| 16 | /************************************************************************* | 17 | /************************************************************************* |
| 17 | * | 18 | * |
| @@ -604,6 +605,13 @@ struct addr_ctrl_blk { | |||
| 604 | uint8_t res14[140]; /* 274-2FF */ | 605 | uint8_t res14[140]; /* 274-2FF */ |
| 605 | }; | 606 | }; |
| 606 | 607 | ||
| 608 | #define IP_ADDR_COUNT 4 /* Total 4 IP address supported in one interface | ||
| 609 | * One IPv4, one IPv6 link local and 2 IPv6 | ||
| 610 | */ | ||
| 611 | |||
| 612 | #define IP_STATE_MASK 0x0F000000 | ||
| 613 | #define IP_STATE_SHIFT 24 | ||
| 614 | |||
| 607 | struct init_fw_ctrl_blk { | 615 | struct init_fw_ctrl_blk { |
| 608 | struct addr_ctrl_blk pri; | 616 | struct addr_ctrl_blk pri; |
| 609 | /* struct addr_ctrl_blk sec;*/ | 617 | /* struct addr_ctrl_blk sec;*/ |
diff --git a/drivers/scsi/qla4xxx/ql4_glbl.h b/drivers/scsi/qla4xxx/ql4_glbl.h index 160db9d5ea21..d0dd4b330206 100644 --- a/drivers/scsi/qla4xxx/ql4_glbl.h +++ b/drivers/scsi/qla4xxx/ql4_glbl.h | |||
| @@ -13,7 +13,7 @@ struct iscsi_cls_conn; | |||
| 13 | int qla4xxx_hw_reset(struct scsi_qla_host *ha); | 13 | int qla4xxx_hw_reset(struct scsi_qla_host *ha); |
| 14 | int ql4xxx_lock_drvr_wait(struct scsi_qla_host *a); | 14 | int ql4xxx_lock_drvr_wait(struct scsi_qla_host *a); |
| 15 | int qla4xxx_send_command_to_isp(struct scsi_qla_host *ha, struct srb *srb); | 15 | int qla4xxx_send_command_to_isp(struct scsi_qla_host *ha, struct srb *srb); |
| 16 | int qla4xxx_initialize_adapter(struct scsi_qla_host *ha); | 16 | int qla4xxx_initialize_adapter(struct scsi_qla_host *ha, int is_reset); |
| 17 | int qla4xxx_soft_reset(struct scsi_qla_host *ha); | 17 | int qla4xxx_soft_reset(struct scsi_qla_host *ha); |
| 18 | irqreturn_t qla4xxx_intr_handler(int irq, void *dev_id); | 18 | irqreturn_t qla4xxx_intr_handler(int irq, void *dev_id); |
| 19 | 19 | ||
| @@ -153,10 +153,13 @@ int qla4xxx_req_ddb_entry(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | |||
| 153 | uint32_t *mbx_sts); | 153 | uint32_t *mbx_sts); |
| 154 | int qla4xxx_clear_ddb_entry(struct scsi_qla_host *ha, uint32_t fw_ddb_index); | 154 | int qla4xxx_clear_ddb_entry(struct scsi_qla_host *ha, uint32_t fw_ddb_index); |
| 155 | int qla4xxx_send_passthru0(struct iscsi_task *task); | 155 | int qla4xxx_send_passthru0(struct iscsi_task *task); |
| 156 | void qla4xxx_free_ddb_index(struct scsi_qla_host *ha); | ||
| 156 | int qla4xxx_get_mgmt_data(struct scsi_qla_host *ha, uint16_t fw_ddb_index, | 157 | int qla4xxx_get_mgmt_data(struct scsi_qla_host *ha, uint16_t fw_ddb_index, |
| 157 | uint16_t stats_size, dma_addr_t stats_dma); | 158 | uint16_t stats_size, dma_addr_t stats_dma); |
| 158 | void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, | 159 | void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, |
| 159 | struct ddb_entry *ddb_entry); | 160 | struct ddb_entry *ddb_entry); |
| 161 | void qla4xxx_update_session_conn_fwddb_param(struct scsi_qla_host *ha, | ||
| 162 | struct ddb_entry *ddb_entry); | ||
| 160 | int qla4xxx_bootdb_by_index(struct scsi_qla_host *ha, | 163 | int qla4xxx_bootdb_by_index(struct scsi_qla_host *ha, |
| 161 | struct dev_db_entry *fw_ddb_entry, | 164 | struct dev_db_entry *fw_ddb_entry, |
| 162 | dma_addr_t fw_ddb_entry_dma, uint16_t ddb_index); | 165 | dma_addr_t fw_ddb_entry_dma, uint16_t ddb_index); |
| @@ -169,11 +172,22 @@ int qla4xxx_set_nvram(struct scsi_qla_host *ha, dma_addr_t nvram_dma, | |||
| 169 | int qla4xxx_restore_factory_defaults(struct scsi_qla_host *ha, | 172 | int qla4xxx_restore_factory_defaults(struct scsi_qla_host *ha, |
| 170 | uint32_t region, uint32_t field0, | 173 | uint32_t region, uint32_t field0, |
| 171 | uint32_t field1); | 174 | uint32_t field1); |
| 175 | int qla4xxx_get_ddb_index(struct scsi_qla_host *ha, uint16_t *ddb_index); | ||
| 176 | void qla4xxx_login_flash_ddb(struct iscsi_cls_session *cls_session); | ||
| 177 | int qla4xxx_unblock_ddb(struct iscsi_cls_session *cls_session); | ||
| 178 | int qla4xxx_unblock_flash_ddb(struct iscsi_cls_session *cls_session); | ||
| 179 | int qla4xxx_flash_ddb_change(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | ||
| 180 | struct ddb_entry *ddb_entry, uint32_t state); | ||
| 181 | int qla4xxx_ddb_change(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | ||
| 182 | struct ddb_entry *ddb_entry, uint32_t state); | ||
| 183 | void qla4xxx_build_ddb_list(struct scsi_qla_host *ha, int is_reset); | ||
| 172 | 184 | ||
| 173 | /* BSG Functions */ | 185 | /* BSG Functions */ |
| 174 | int qla4xxx_bsg_request(struct bsg_job *bsg_job); | 186 | int qla4xxx_bsg_request(struct bsg_job *bsg_job); |
| 175 | int qla4xxx_process_vendor_specific(struct bsg_job *bsg_job); | 187 | int qla4xxx_process_vendor_specific(struct bsg_job *bsg_job); |
| 176 | 188 | ||
| 189 | void qla4xxx_arm_relogin_timer(struct ddb_entry *ddb_entry); | ||
| 190 | |||
| 177 | extern int ql4xextended_error_logging; | 191 | extern int ql4xextended_error_logging; |
| 178 | extern int ql4xdontresethba; | 192 | extern int ql4xdontresethba; |
| 179 | extern int ql4xenablemsix; | 193 | extern int ql4xenablemsix; |
diff --git a/drivers/scsi/qla4xxx/ql4_init.c b/drivers/scsi/qla4xxx/ql4_init.c index 3075fbaef553..1bdfa8120ac8 100644 --- a/drivers/scsi/qla4xxx/ql4_init.c +++ b/drivers/scsi/qla4xxx/ql4_init.c | |||
| @@ -773,22 +773,24 @@ int qla4xxx_start_firmware(struct scsi_qla_host *ha) | |||
| 773 | * be freed so that when login happens from user space there are free DDB | 773 | * be freed so that when login happens from user space there are free DDB |
| 774 | * indices available. | 774 | * indices available. |
| 775 | **/ | 775 | **/ |
| 776 | static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha) | 776 | void qla4xxx_free_ddb_index(struct scsi_qla_host *ha) |
| 777 | { | 777 | { |
| 778 | int max_ddbs; | 778 | int max_ddbs; |
| 779 | int ret; | 779 | int ret; |
| 780 | uint32_t idx = 0, next_idx = 0; | 780 | uint32_t idx = 0, next_idx = 0; |
| 781 | uint32_t state = 0, conn_err = 0; | 781 | uint32_t state = 0, conn_err = 0; |
| 782 | 782 | ||
| 783 | max_ddbs = is_qla40XX(ha) ? MAX_PRST_DEV_DB_ENTRIES : | 783 | max_ddbs = is_qla40XX(ha) ? MAX_DEV_DB_ENTRIES_40XX : |
| 784 | MAX_DEV_DB_ENTRIES; | 784 | MAX_DEV_DB_ENTRIES; |
| 785 | 785 | ||
| 786 | for (idx = 0; idx < max_ddbs; idx = next_idx) { | 786 | for (idx = 0; idx < max_ddbs; idx = next_idx) { |
| 787 | ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL, | 787 | ret = qla4xxx_get_fwddb_entry(ha, idx, NULL, 0, NULL, |
| 788 | &next_idx, &state, &conn_err, | 788 | &next_idx, &state, &conn_err, |
| 789 | NULL, NULL); | 789 | NULL, NULL); |
| 790 | if (ret == QLA_ERROR) | 790 | if (ret == QLA_ERROR) { |
| 791 | next_idx++; | ||
| 791 | continue; | 792 | continue; |
| 793 | } | ||
| 792 | if (state == DDB_DS_NO_CONNECTION_ACTIVE || | 794 | if (state == DDB_DS_NO_CONNECTION_ACTIVE || |
| 793 | state == DDB_DS_SESSION_FAILED) { | 795 | state == DDB_DS_SESSION_FAILED) { |
| 794 | DEBUG2(ql4_printk(KERN_INFO, ha, | 796 | DEBUG2(ql4_printk(KERN_INFO, ha, |
| @@ -804,7 +806,6 @@ static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha) | |||
| 804 | } | 806 | } |
| 805 | } | 807 | } |
| 806 | 808 | ||
| 807 | |||
| 808 | /** | 809 | /** |
| 809 | * qla4xxx_initialize_adapter - initiailizes hba | 810 | * qla4xxx_initialize_adapter - initiailizes hba |
| 810 | * @ha: Pointer to host adapter structure. | 811 | * @ha: Pointer to host adapter structure. |
| @@ -812,7 +813,7 @@ static void qla4xxx_free_ddb_index(struct scsi_qla_host *ha) | |||
| 812 | * This routine parforms all of the steps necessary to initialize the adapter. | 813 | * This routine parforms all of the steps necessary to initialize the adapter. |
| 813 | * | 814 | * |
| 814 | **/ | 815 | **/ |
| 815 | int qla4xxx_initialize_adapter(struct scsi_qla_host *ha) | 816 | int qla4xxx_initialize_adapter(struct scsi_qla_host *ha, int is_reset) |
| 816 | { | 817 | { |
| 817 | int status = QLA_ERROR; | 818 | int status = QLA_ERROR; |
| 818 | 819 | ||
| @@ -840,7 +841,8 @@ int qla4xxx_initialize_adapter(struct scsi_qla_host *ha) | |||
| 840 | if (status == QLA_ERROR) | 841 | if (status == QLA_ERROR) |
| 841 | goto exit_init_hba; | 842 | goto exit_init_hba; |
| 842 | 843 | ||
| 843 | qla4xxx_free_ddb_index(ha); | 844 | if (is_reset == RESET_ADAPTER) |
| 845 | qla4xxx_build_ddb_list(ha, is_reset); | ||
| 844 | 846 | ||
| 845 | set_bit(AF_ONLINE, &ha->flags); | 847 | set_bit(AF_ONLINE, &ha->flags); |
| 846 | exit_init_hba: | 848 | exit_init_hba: |
| @@ -855,38 +857,12 @@ exit_init_hba: | |||
| 855 | return status; | 857 | return status; |
| 856 | } | 858 | } |
| 857 | 859 | ||
| 858 | /** | 860 | int qla4xxx_ddb_change(struct scsi_qla_host *ha, uint32_t fw_ddb_index, |
| 859 | * qla4xxx_process_ddb_changed - process ddb state change | 861 | struct ddb_entry *ddb_entry, uint32_t state) |
| 860 | * @ha - Pointer to host adapter structure. | ||
| 861 | * @fw_ddb_index - Firmware's device database index | ||
| 862 | * @state - Device state | ||
| 863 | * | ||
| 864 | * This routine processes a Decive Database Changed AEN Event. | ||
| 865 | **/ | ||
| 866 | int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | ||
| 867 | uint32_t state, uint32_t conn_err) | ||
| 868 | { | 862 | { |
| 869 | struct ddb_entry * ddb_entry; | ||
| 870 | uint32_t old_fw_ddb_device_state; | 863 | uint32_t old_fw_ddb_device_state; |
| 871 | int status = QLA_ERROR; | 864 | int status = QLA_ERROR; |
| 872 | 865 | ||
| 873 | /* check for out of range index */ | ||
| 874 | if (fw_ddb_index >= MAX_DDB_ENTRIES) | ||
| 875 | goto exit_ddb_event; | ||
| 876 | |||
| 877 | /* Get the corresponging ddb entry */ | ||
| 878 | ddb_entry = qla4xxx_lookup_ddb_by_fw_index(ha, fw_ddb_index); | ||
| 879 | /* Device does not currently exist in our database. */ | ||
| 880 | if (ddb_entry == NULL) { | ||
| 881 | ql4_printk(KERN_ERR, ha, "%s: No ddb_entry at FW index [%d]\n", | ||
| 882 | __func__, fw_ddb_index); | ||
| 883 | |||
| 884 | if (state == DDB_DS_NO_CONNECTION_ACTIVE) | ||
| 885 | clear_bit(fw_ddb_index, ha->ddb_idx_map); | ||
| 886 | |||
| 887 | goto exit_ddb_event; | ||
| 888 | } | ||
| 889 | |||
| 890 | old_fw_ddb_device_state = ddb_entry->fw_ddb_device_state; | 866 | old_fw_ddb_device_state = ddb_entry->fw_ddb_device_state; |
| 891 | DEBUG2(ql4_printk(KERN_INFO, ha, | 867 | DEBUG2(ql4_printk(KERN_INFO, ha, |
| 892 | "%s: DDB - old state = 0x%x, new state = 0x%x for " | 868 | "%s: DDB - old state = 0x%x, new state = 0x%x for " |
| @@ -900,9 +876,7 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | |||
| 900 | switch (state) { | 876 | switch (state) { |
| 901 | case DDB_DS_SESSION_ACTIVE: | 877 | case DDB_DS_SESSION_ACTIVE: |
| 902 | case DDB_DS_DISCOVERY: | 878 | case DDB_DS_DISCOVERY: |
| 903 | iscsi_conn_start(ddb_entry->conn); | 879 | ddb_entry->unblock_sess(ddb_entry->sess); |
| 904 | iscsi_conn_login_event(ddb_entry->conn, | ||
| 905 | ISCSI_CONN_STATE_LOGGED_IN); | ||
| 906 | qla4xxx_update_session_conn_param(ha, ddb_entry); | 880 | qla4xxx_update_session_conn_param(ha, ddb_entry); |
| 907 | status = QLA_SUCCESS; | 881 | status = QLA_SUCCESS; |
| 908 | break; | 882 | break; |
| @@ -936,9 +910,7 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | |||
| 936 | switch (state) { | 910 | switch (state) { |
| 937 | case DDB_DS_SESSION_ACTIVE: | 911 | case DDB_DS_SESSION_ACTIVE: |
| 938 | case DDB_DS_DISCOVERY: | 912 | case DDB_DS_DISCOVERY: |
| 939 | iscsi_conn_start(ddb_entry->conn); | 913 | ddb_entry->unblock_sess(ddb_entry->sess); |
| 940 | iscsi_conn_login_event(ddb_entry->conn, | ||
| 941 | ISCSI_CONN_STATE_LOGGED_IN); | ||
| 942 | qla4xxx_update_session_conn_param(ha, ddb_entry); | 914 | qla4xxx_update_session_conn_param(ha, ddb_entry); |
| 943 | status = QLA_SUCCESS; | 915 | status = QLA_SUCCESS; |
| 944 | break; | 916 | break; |
| @@ -954,7 +926,198 @@ int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | |||
| 954 | __func__)); | 926 | __func__)); |
| 955 | break; | 927 | break; |
| 956 | } | 928 | } |
| 929 | return status; | ||
| 930 | } | ||
| 931 | |||
| 932 | void qla4xxx_arm_relogin_timer(struct ddb_entry *ddb_entry) | ||
| 933 | { | ||
| 934 | /* | ||
| 935 | * This triggers a relogin. After the relogin_timer | ||
| 936 | * expires, the relogin gets scheduled. We must wait a | ||
| 937 | * minimum amount of time since receiving an 0x8014 AEN | ||
| 938 | * with failed device_state or a logout response before | ||
| 939 | * we can issue another relogin. | ||
| 940 | * | ||
| 941 | * Firmware pads this timeout: (time2wait +1). | ||
| 942 | * Driver retry to login should be longer than F/W. | ||
| 943 | * Otherwise F/W will fail | ||
| 944 | * set_ddb() mbx cmd with 0x4005 since it still | ||
| 945 | * counting down its time2wait. | ||
| 946 | */ | ||
| 947 | atomic_set(&ddb_entry->relogin_timer, 0); | ||
| 948 | atomic_set(&ddb_entry->retry_relogin_timer, | ||
| 949 | ddb_entry->default_time2wait + 4); | ||
| 950 | |||
| 951 | } | ||
| 952 | |||
| 953 | int qla4xxx_flash_ddb_change(struct scsi_qla_host *ha, uint32_t fw_ddb_index, | ||
| 954 | struct ddb_entry *ddb_entry, uint32_t state) | ||
| 955 | { | ||
| 956 | uint32_t old_fw_ddb_device_state; | ||
| 957 | int status = QLA_ERROR; | ||
| 958 | |||
| 959 | old_fw_ddb_device_state = ddb_entry->fw_ddb_device_state; | ||
| 960 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 961 | "%s: DDB - old state = 0x%x, new state = 0x%x for " | ||
| 962 | "index [%d]\n", __func__, | ||
| 963 | ddb_entry->fw_ddb_device_state, state, fw_ddb_index)); | ||
| 964 | |||
| 965 | ddb_entry->fw_ddb_device_state = state; | ||
| 966 | |||
| 967 | switch (old_fw_ddb_device_state) { | ||
| 968 | case DDB_DS_LOGIN_IN_PROCESS: | ||
| 969 | case DDB_DS_NO_CONNECTION_ACTIVE: | ||
| 970 | switch (state) { | ||
| 971 | case DDB_DS_SESSION_ACTIVE: | ||
| 972 | ddb_entry->unblock_sess(ddb_entry->sess); | ||
| 973 | qla4xxx_update_session_conn_fwddb_param(ha, ddb_entry); | ||
| 974 | status = QLA_SUCCESS; | ||
| 975 | break; | ||
| 976 | case DDB_DS_SESSION_FAILED: | ||
| 977 | iscsi_block_session(ddb_entry->sess); | ||
| 978 | if (!test_bit(DF_RELOGIN, &ddb_entry->flags)) | ||
| 979 | qla4xxx_arm_relogin_timer(ddb_entry); | ||
| 980 | status = QLA_SUCCESS; | ||
| 981 | break; | ||
| 982 | } | ||
| 983 | break; | ||
| 984 | case DDB_DS_SESSION_ACTIVE: | ||
| 985 | switch (state) { | ||
| 986 | case DDB_DS_SESSION_FAILED: | ||
| 987 | iscsi_block_session(ddb_entry->sess); | ||
| 988 | if (!test_bit(DF_RELOGIN, &ddb_entry->flags)) | ||
| 989 | qla4xxx_arm_relogin_timer(ddb_entry); | ||
| 990 | status = QLA_SUCCESS; | ||
| 991 | break; | ||
| 992 | } | ||
| 993 | break; | ||
| 994 | case DDB_DS_SESSION_FAILED: | ||
| 995 | switch (state) { | ||
| 996 | case DDB_DS_SESSION_ACTIVE: | ||
| 997 | ddb_entry->unblock_sess(ddb_entry->sess); | ||
| 998 | qla4xxx_update_session_conn_fwddb_param(ha, ddb_entry); | ||
| 999 | status = QLA_SUCCESS; | ||
| 1000 | break; | ||
| 1001 | case DDB_DS_SESSION_FAILED: | ||
| 1002 | if (!test_bit(DF_RELOGIN, &ddb_entry->flags)) | ||
| 1003 | qla4xxx_arm_relogin_timer(ddb_entry); | ||
| 1004 | status = QLA_SUCCESS; | ||
| 1005 | break; | ||
| 1006 | } | ||
| 1007 | break; | ||
| 1008 | default: | ||
| 1009 | DEBUG2(ql4_printk(KERN_INFO, ha, "%s: Unknown Event\n", | ||
| 1010 | __func__)); | ||
| 1011 | break; | ||
| 1012 | } | ||
| 1013 | return status; | ||
| 1014 | } | ||
| 1015 | |||
| 1016 | /** | ||
| 1017 | * qla4xxx_process_ddb_changed - process ddb state change | ||
| 1018 | * @ha - Pointer to host adapter structure. | ||
| 1019 | * @fw_ddb_index - Firmware's device database index | ||
| 1020 | * @state - Device state | ||
| 1021 | * | ||
| 1022 | * This routine processes a Decive Database Changed AEN Event. | ||
| 1023 | **/ | ||
| 1024 | int qla4xxx_process_ddb_changed(struct scsi_qla_host *ha, | ||
| 1025 | uint32_t fw_ddb_index, | ||
| 1026 | uint32_t state, uint32_t conn_err) | ||
| 1027 | { | ||
| 1028 | struct ddb_entry *ddb_entry; | ||
| 1029 | int status = QLA_ERROR; | ||
| 1030 | |||
| 1031 | /* check for out of range index */ | ||
| 1032 | if (fw_ddb_index >= MAX_DDB_ENTRIES) | ||
| 1033 | goto exit_ddb_event; | ||
| 1034 | |||
| 1035 | /* Get the corresponging ddb entry */ | ||
| 1036 | ddb_entry = qla4xxx_lookup_ddb_by_fw_index(ha, fw_ddb_index); | ||
| 1037 | /* Device does not currently exist in our database. */ | ||
| 1038 | if (ddb_entry == NULL) { | ||
| 1039 | ql4_printk(KERN_ERR, ha, "%s: No ddb_entry at FW index [%d]\n", | ||
| 1040 | __func__, fw_ddb_index); | ||
| 1041 | |||
| 1042 | if (state == DDB_DS_NO_CONNECTION_ACTIVE) | ||
| 1043 | clear_bit(fw_ddb_index, ha->ddb_idx_map); | ||
| 1044 | |||
| 1045 | goto exit_ddb_event; | ||
| 1046 | } | ||
| 1047 | |||
| 1048 | ddb_entry->ddb_change(ha, fw_ddb_index, ddb_entry, state); | ||
| 957 | 1049 | ||
| 958 | exit_ddb_event: | 1050 | exit_ddb_event: |
| 959 | return status; | 1051 | return status; |
| 960 | } | 1052 | } |
| 1053 | |||
| 1054 | /** | ||
| 1055 | * qla4xxx_login_flash_ddb - Login to target (DDB) | ||
| 1056 | * @cls_session: Pointer to the session to login | ||
| 1057 | * | ||
| 1058 | * This routine logins to the target. | ||
| 1059 | * Issues setddb and conn open mbx | ||
| 1060 | **/ | ||
| 1061 | void qla4xxx_login_flash_ddb(struct iscsi_cls_session *cls_session) | ||
| 1062 | { | ||
| 1063 | struct iscsi_session *sess; | ||
| 1064 | struct ddb_entry *ddb_entry; | ||
| 1065 | struct scsi_qla_host *ha; | ||
| 1066 | struct dev_db_entry *fw_ddb_entry = NULL; | ||
| 1067 | dma_addr_t fw_ddb_dma; | ||
| 1068 | uint32_t mbx_sts = 0; | ||
| 1069 | int ret; | ||
| 1070 | |||
| 1071 | sess = cls_session->dd_data; | ||
| 1072 | ddb_entry = sess->dd_data; | ||
| 1073 | ha = ddb_entry->ha; | ||
| 1074 | |||
| 1075 | if (!test_bit(AF_LINK_UP, &ha->flags)) | ||
| 1076 | return; | ||
| 1077 | |||
| 1078 | if (ddb_entry->ddb_type != FLASH_DDB) { | ||
| 1079 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1080 | "Skipping login to non FLASH DB")); | ||
| 1081 | goto exit_login; | ||
| 1082 | } | ||
| 1083 | |||
| 1084 | fw_ddb_entry = dma_pool_alloc(ha->fw_ddb_dma_pool, GFP_KERNEL, | ||
| 1085 | &fw_ddb_dma); | ||
| 1086 | if (fw_ddb_entry == NULL) { | ||
| 1087 | DEBUG2(ql4_printk(KERN_ERR, ha, "Out of memory\n")); | ||
| 1088 | goto exit_login; | ||
| 1089 | } | ||
| 1090 | |||
| 1091 | if (ddb_entry->fw_ddb_index == INVALID_ENTRY) { | ||
| 1092 | ret = qla4xxx_get_ddb_index(ha, &ddb_entry->fw_ddb_index); | ||
| 1093 | if (ret == QLA_ERROR) | ||
| 1094 | goto exit_login; | ||
| 1095 | |||
| 1096 | ha->fw_ddb_index_map[ddb_entry->fw_ddb_index] = ddb_entry; | ||
| 1097 | ha->tot_ddbs++; | ||
| 1098 | } | ||
| 1099 | |||
| 1100 | memcpy(fw_ddb_entry, &ddb_entry->fw_ddb_entry, | ||
| 1101 | sizeof(struct dev_db_entry)); | ||
| 1102 | ddb_entry->sess->target_id = ddb_entry->fw_ddb_index; | ||
| 1103 | |||
| 1104 | ret = qla4xxx_set_ddb_entry(ha, ddb_entry->fw_ddb_index, | ||
| 1105 | fw_ddb_dma, &mbx_sts); | ||
| 1106 | if (ret == QLA_ERROR) { | ||
| 1107 | DEBUG2(ql4_printk(KERN_ERR, ha, "Set DDB failed\n")); | ||
| 1108 | goto exit_login; | ||
| 1109 | } | ||
| 1110 | |||
| 1111 | ddb_entry->fw_ddb_device_state = DDB_DS_LOGIN_IN_PROCESS; | ||
| 1112 | ret = qla4xxx_conn_open(ha, ddb_entry->fw_ddb_index); | ||
| 1113 | if (ret == QLA_ERROR) { | ||
| 1114 | ql4_printk(KERN_ERR, ha, "%s: Login failed: %s\n", __func__, | ||
| 1115 | sess->targetname); | ||
| 1116 | goto exit_login; | ||
| 1117 | } | ||
| 1118 | |||
| 1119 | exit_login: | ||
| 1120 | if (fw_ddb_entry) | ||
| 1121 | dma_pool_free(ha->fw_ddb_dma_pool, fw_ddb_entry, fw_ddb_dma); | ||
| 1122 | } | ||
| 1123 | |||
diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c index 4c2b84870392..c2593782fbbe 100644 --- a/drivers/scsi/qla4xxx/ql4_mbx.c +++ b/drivers/scsi/qla4xxx/ql4_mbx.c | |||
| @@ -41,6 +41,16 @@ int qla4xxx_mailbox_command(struct scsi_qla_host *ha, uint8_t inCount, | |||
| 41 | return status; | 41 | return status; |
| 42 | } | 42 | } |
| 43 | 43 | ||
| 44 | if (is_qla40XX(ha)) { | ||
| 45 | if (test_bit(AF_HA_REMOVAL, &ha->flags)) { | ||
| 46 | DEBUG2(ql4_printk(KERN_WARNING, ha, "scsi%ld: %s: " | ||
| 47 | "prematurely completing mbx cmd as " | ||
| 48 | "adapter removal detected\n", | ||
| 49 | ha->host_no, __func__)); | ||
| 50 | return status; | ||
| 51 | } | ||
| 52 | } | ||
| 53 | |||
| 44 | if (is_qla8022(ha)) { | 54 | if (is_qla8022(ha)) { |
| 45 | if (test_bit(AF_FW_RECOVERY, &ha->flags)) { | 55 | if (test_bit(AF_FW_RECOVERY, &ha->flags)) { |
| 46 | DEBUG2(ql4_printk(KERN_WARNING, ha, "scsi%ld: %s: " | 56 | DEBUG2(ql4_printk(KERN_WARNING, ha, "scsi%ld: %s: " |
| @@ -413,6 +423,7 @@ qla4xxx_update_local_ifcb(struct scsi_qla_host *ha, | |||
| 413 | memcpy(ha->name_string, init_fw_cb->iscsi_name, | 423 | memcpy(ha->name_string, init_fw_cb->iscsi_name, |
| 414 | min(sizeof(ha->name_string), | 424 | min(sizeof(ha->name_string), |
| 415 | sizeof(init_fw_cb->iscsi_name))); | 425 | sizeof(init_fw_cb->iscsi_name))); |
| 426 | ha->def_timeout = le16_to_cpu(init_fw_cb->def_timeout); | ||
| 416 | /*memcpy(ha->alias, init_fw_cb->Alias, | 427 | /*memcpy(ha->alias, init_fw_cb->Alias, |
| 417 | min(sizeof(ha->alias), sizeof(init_fw_cb->Alias)));*/ | 428 | min(sizeof(ha->alias), sizeof(init_fw_cb->Alias)));*/ |
| 418 | 429 | ||
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 30f31b127f33..4169c8baa112 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c | |||
| @@ -8,6 +8,7 @@ | |||
| 8 | #include <linux/slab.h> | 8 | #include <linux/slab.h> |
| 9 | #include <linux/blkdev.h> | 9 | #include <linux/blkdev.h> |
| 10 | #include <linux/iscsi_boot_sysfs.h> | 10 | #include <linux/iscsi_boot_sysfs.h> |
| 11 | #include <linux/inet.h> | ||
| 11 | 12 | ||
| 12 | #include <scsi/scsi_tcq.h> | 13 | #include <scsi/scsi_tcq.h> |
| 13 | #include <scsi/scsicam.h> | 14 | #include <scsi/scsicam.h> |
| @@ -31,6 +32,13 @@ static struct kmem_cache *srb_cachep; | |||
| 31 | /* | 32 | /* |
| 32 | * Module parameter information and variables | 33 | * Module parameter information and variables |
| 33 | */ | 34 | */ |
| 35 | int ql4xdisablesysfsboot = 1; | ||
| 36 | module_param(ql4xdisablesysfsboot, int, S_IRUGO | S_IWUSR); | ||
| 37 | MODULE_PARM_DESC(ql4xdisablesysfsboot, | ||
| 38 | "Set to disable exporting boot targets to sysfs\n" | ||
| 39 | " 0 - Export boot targets\n" | ||
| 40 | " 1 - Do not export boot targets (Default)"); | ||
| 41 | |||
| 34 | int ql4xdontresethba = 0; | 42 | int ql4xdontresethba = 0; |
| 35 | module_param(ql4xdontresethba, int, S_IRUGO | S_IWUSR); | 43 | module_param(ql4xdontresethba, int, S_IRUGO | S_IWUSR); |
| 36 | MODULE_PARM_DESC(ql4xdontresethba, | 44 | MODULE_PARM_DESC(ql4xdontresethba, |
| @@ -63,7 +71,7 @@ static int ql4xsess_recovery_tmo = QL4_SESS_RECOVERY_TMO; | |||
| 63 | module_param(ql4xsess_recovery_tmo, int, S_IRUGO); | 71 | module_param(ql4xsess_recovery_tmo, int, S_IRUGO); |
| 64 | MODULE_PARM_DESC(ql4xsess_recovery_tmo, | 72 | MODULE_PARM_DESC(ql4xsess_recovery_tmo, |
| 65 | "Target Session Recovery Timeout.\n" | 73 | "Target Session Recovery Timeout.\n" |
| 66 | " Default: 30 sec."); | 74 | " Default: 120 sec."); |
| 67 | 75 | ||
| 68 | static int qla4xxx_wait_for_hba_online(struct scsi_qla_host *ha); | 76 | static int qla4xxx_wait_for_hba_online(struct scsi_qla_host *ha); |
| 69 | /* | 77 | /* |
| @@ -415,7 +423,7 @@ static int qla4xxx_ep_poll(struct iscsi_endpoint *ep, int timeout_ms) | |||
| 415 | qla_ep = ep->dd_data; | 423 | qla_ep = ep->dd_data; |
| 416 | ha = to_qla_host(qla_ep->host); | 424 | ha = to_qla_host(qla_ep->host); |
| 417 | 425 | ||
| 418 | if (adapter_up(ha)) | 426 | if (adapter_up(ha) && !test_bit(AF_BUILD_DDB_LIST, &ha->flags)) |
| 419 | ret = 1; | 427 | ret = 1; |
| 420 | 428 | ||
| 421 | return ret; | 429 | return ret; |
| @@ -975,6 +983,150 @@ static int qla4xxx_conn_get_param(struct iscsi_cls_conn *cls_conn, | |||
| 975 | 983 | ||
| 976 | } | 984 | } |
| 977 | 985 | ||
| 986 | int qla4xxx_get_ddb_index(struct scsi_qla_host *ha, uint16_t *ddb_index) | ||
| 987 | { | ||
| 988 | uint32_t mbx_sts = 0; | ||
| 989 | uint16_t tmp_ddb_index; | ||
| 990 | int ret; | ||
| 991 | |||
| 992 | get_ddb_index: | ||
| 993 | tmp_ddb_index = find_first_zero_bit(ha->ddb_idx_map, MAX_DDB_ENTRIES); | ||
| 994 | |||
| 995 | if (tmp_ddb_index >= MAX_DDB_ENTRIES) { | ||
| 996 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 997 | "Free DDB index not available\n")); | ||
| 998 | ret = QLA_ERROR; | ||
| 999 | goto exit_get_ddb_index; | ||
| 1000 | } | ||
| 1001 | |||
| 1002 | if (test_and_set_bit(tmp_ddb_index, ha->ddb_idx_map)) | ||
| 1003 | goto get_ddb_index; | ||
| 1004 | |||
| 1005 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1006 | "Found a free DDB index at %d\n", tmp_ddb_index)); | ||
| 1007 | ret = qla4xxx_req_ddb_entry(ha, tmp_ddb_index, &mbx_sts); | ||
| 1008 | if (ret == QLA_ERROR) { | ||
| 1009 | if (mbx_sts == MBOX_STS_COMMAND_ERROR) { | ||
| 1010 | ql4_printk(KERN_INFO, ha, | ||
| 1011 | "DDB index = %d not available trying next\n", | ||
| 1012 | tmp_ddb_index); | ||
| 1013 | goto get_ddb_index; | ||
| 1014 | } | ||
| 1015 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1016 | "Free FW DDB not available\n")); | ||
| 1017 | } | ||
| 1018 | |||
| 1019 | *ddb_index = tmp_ddb_index; | ||
| 1020 | |||
| 1021 | exit_get_ddb_index: | ||
| 1022 | return ret; | ||
| 1023 | } | ||
| 1024 | |||
| 1025 | static int qla4xxx_match_ipaddress(struct scsi_qla_host *ha, | ||
| 1026 | struct ddb_entry *ddb_entry, | ||
| 1027 | char *existing_ipaddr, | ||
| 1028 | char *user_ipaddr) | ||
| 1029 | { | ||
| 1030 | uint8_t dst_ipaddr[IPv6_ADDR_LEN]; | ||
| 1031 | char formatted_ipaddr[DDB_IPADDR_LEN]; | ||
| 1032 | int status = QLA_SUCCESS, ret = 0; | ||
| 1033 | |||
| 1034 | if (ddb_entry->fw_ddb_entry.options & DDB_OPT_IPV6_DEVICE) { | ||
| 1035 | ret = in6_pton(user_ipaddr, strlen(user_ipaddr), dst_ipaddr, | ||
| 1036 | '\0', NULL); | ||
| 1037 | if (ret == 0) { | ||
| 1038 | status = QLA_ERROR; | ||
| 1039 | goto out_match; | ||
| 1040 | } | ||
| 1041 | ret = sprintf(formatted_ipaddr, "%pI6", dst_ipaddr); | ||
| 1042 | } else { | ||
| 1043 | ret = in4_pton(user_ipaddr, strlen(user_ipaddr), dst_ipaddr, | ||
| 1044 | '\0', NULL); | ||
| 1045 | if (ret == 0) { | ||
| 1046 | status = QLA_ERROR; | ||
| 1047 | goto out_match; | ||
| 1048 | } | ||
| 1049 | ret = sprintf(formatted_ipaddr, "%pI4", dst_ipaddr); | ||
| 1050 | } | ||
| 1051 | |||
| 1052 | if (strcmp(existing_ipaddr, formatted_ipaddr)) | ||
| 1053 | status = QLA_ERROR; | ||
| 1054 | |||
| 1055 | out_match: | ||
| 1056 | return status; | ||
| 1057 | } | ||
| 1058 | |||
| 1059 | static int qla4xxx_match_fwdb_session(struct scsi_qla_host *ha, | ||
| 1060 | struct iscsi_cls_conn *cls_conn) | ||
| 1061 | { | ||
| 1062 | int idx = 0, max_ddbs, rval; | ||
| 1063 | struct iscsi_cls_session *cls_sess = iscsi_conn_to_session(cls_conn); | ||
| 1064 | struct iscsi_session *sess, *existing_sess; | ||
| 1065 | struct iscsi_conn *conn, *existing_conn; | ||
| 1066 | struct ddb_entry *ddb_entry; | ||
| 1067 | |||
| 1068 | sess = cls_sess->dd_data; | ||
| 1069 | conn = cls_conn->dd_data; | ||
| 1070 | |||
| 1071 | if (sess->targetname == NULL || | ||
| 1072 | conn->persistent_address == NULL || | ||
| 1073 | conn->persistent_port == 0) | ||
| 1074 | return QLA_ERROR; | ||
| 1075 | |||
| 1076 | max_ddbs = is_qla40XX(ha) ? MAX_DEV_DB_ENTRIES_40XX : | ||
| 1077 | MAX_DEV_DB_ENTRIES; | ||
| 1078 | |||
| 1079 | for (idx = 0; idx < max_ddbs; idx++) { | ||
| 1080 | ddb_entry = qla4xxx_lookup_ddb_by_fw_index(ha, idx); | ||
| 1081 | if (ddb_entry == NULL) | ||
| 1082 | continue; | ||
| 1083 | |||
| 1084 | if (ddb_entry->ddb_type != FLASH_DDB) | ||
| 1085 | continue; | ||
| 1086 | |||
| 1087 | existing_sess = ddb_entry->sess->dd_data; | ||
| 1088 | existing_conn = ddb_entry->conn->dd_data; | ||
| 1089 | |||
| 1090 | if (existing_sess->targetname == NULL || | ||
| 1091 | existing_conn->persistent_address == NULL || | ||
| 1092 | existing_conn->persistent_port == 0) | ||
| 1093 | continue; | ||
| 1094 | |||
| 1095 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1096 | "IQN = %s User IQN = %s\n", | ||
| 1097 | existing_sess->targetname, | ||
| 1098 | sess->targetname)); | ||
| 1099 | |||
| 1100 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1101 | "IP = %s User IP = %s\n", | ||
| 1102 | existing_conn->persistent_address, | ||
| 1103 | conn->persistent_address)); | ||
| 1104 | |||
| 1105 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1106 | "Port = %d User Port = %d\n", | ||
| 1107 | existing_conn->persistent_port, | ||
| 1108 | conn->persistent_port)); | ||
| 1109 | |||
| 1110 | if (strcmp(existing_sess->targetname, sess->targetname)) | ||
| 1111 | continue; | ||
| 1112 | rval = qla4xxx_match_ipaddress(ha, ddb_entry, | ||
| 1113 | existing_conn->persistent_address, | ||
| 1114 | conn->persistent_address); | ||
| 1115 | if (rval == QLA_ERROR) | ||
| 1116 | continue; | ||
| 1117 | if (existing_conn->persistent_port != conn->persistent_port) | ||
| 1118 | continue; | ||
| 1119 | break; | ||
| 1120 | } | ||
| 1121 | |||
| 1122 | if (idx == max_ddbs) | ||
| 1123 | return QLA_ERROR; | ||
| 1124 | |||
| 1125 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1126 | "Match found in fwdb sessions\n")); | ||
| 1127 | return QLA_SUCCESS; | ||
| 1128 | } | ||
| 1129 | |||
| 978 | static struct iscsi_cls_session * | 1130 | static struct iscsi_cls_session * |
| 979 | qla4xxx_session_create(struct iscsi_endpoint *ep, | 1131 | qla4xxx_session_create(struct iscsi_endpoint *ep, |
| 980 | uint16_t cmds_max, uint16_t qdepth, | 1132 | uint16_t cmds_max, uint16_t qdepth, |
| @@ -984,8 +1136,7 @@ qla4xxx_session_create(struct iscsi_endpoint *ep, | |||
| 984 | struct scsi_qla_host *ha; | 1136 | struct scsi_qla_host *ha; |
| 985 | struct qla_endpoint *qla_ep; | 1137 | struct qla_endpoint *qla_ep; |
| 986 | struct ddb_entry *ddb_entry; | 1138 | struct ddb_entry *ddb_entry; |
| 987 | uint32_t ddb_index; | 1139 | uint16_t ddb_index; |
| 988 | uint32_t mbx_sts = 0; | ||
| 989 | struct iscsi_session *sess; | 1140 | struct iscsi_session *sess; |
| 990 | struct sockaddr *dst_addr; | 1141 | struct sockaddr *dst_addr; |
| 991 | int ret; | 1142 | int ret; |
| @@ -1000,32 +1151,9 @@ qla4xxx_session_create(struct iscsi_endpoint *ep, | |||
| 1000 | dst_addr = (struct sockaddr *)&qla_ep->dst_addr; | 1151 | dst_addr = (struct sockaddr *)&qla_ep->dst_addr; |
| 1001 | ha = to_qla_host(qla_ep->host); | 1152 | ha = to_qla_host(qla_ep->host); |
| 1002 | 1153 | ||
| 1003 | get_ddb_index: | 1154 | ret = qla4xxx_get_ddb_index(ha, &ddb_index); |
| 1004 | ddb_index = find_first_zero_bit(ha->ddb_idx_map, MAX_DDB_ENTRIES); | 1155 | if (ret == QLA_ERROR) |
| 1005 | |||
| 1006 | if (ddb_index >= MAX_DDB_ENTRIES) { | ||
| 1007 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1008 | "Free DDB index not available\n")); | ||
| 1009 | return NULL; | ||
| 1010 | } | ||
| 1011 | |||
| 1012 | if (test_and_set_bit(ddb_index, ha->ddb_idx_map)) | ||
| 1013 | goto get_ddb_index; | ||
| 1014 | |||
| 1015 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1016 | "Found a free DDB index at %d\n", ddb_index)); | ||
| 1017 | ret = qla4xxx_req_ddb_entry(ha, ddb_index, &mbx_sts); | ||
| 1018 | if (ret == QLA_ERROR) { | ||
| 1019 | if (mbx_sts == MBOX_STS_COMMAND_ERROR) { | ||
| 1020 | ql4_printk(KERN_INFO, ha, | ||
| 1021 | "DDB index = %d not available trying next\n", | ||
| 1022 | ddb_index); | ||
| 1023 | goto get_ddb_index; | ||
| 1024 | } | ||
| 1025 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 1026 | "Free FW DDB not available\n")); | ||
| 1027 | return NULL; | 1156 | return NULL; |
| 1028 | } | ||
| 1029 | 1157 | ||
| 1030 | cls_sess = iscsi_session_setup(&qla4xxx_iscsi_transport, qla_ep->host, | 1158 | cls_sess = iscsi_session_setup(&qla4xxx_iscsi_transport, qla_ep->host, |
| 1031 | cmds_max, sizeof(struct ddb_entry), | 1159 | cmds_max, sizeof(struct ddb_entry), |
| @@ -1040,6 +1168,8 @@ get_ddb_index: | |||
| 1040 | ddb_entry->fw_ddb_device_state = DDB_DS_NO_CONNECTION_ACTIVE; | 1168 | ddb_entry->fw_ddb_device_state = DDB_DS_NO_CONNECTION_ACTIVE; |
| 1041 | ddb_entry->ha = ha; | 1169 | ddb_entry->ha = ha; |
| 1042 | ddb_entry->sess = cls_sess; | 1170 | ddb_entry->sess = cls_sess; |
| 1171 | ddb_entry->unblock_sess = qla4xxx_unblock_ddb; | ||
| 1172 | ddb_entry->ddb_change = qla4xxx_ddb_change; | ||
| 1043 | cls_sess->recovery_tmo = ql4xsess_recovery_tmo; | 1173 | cls_sess->recovery_tmo = ql4xsess_recovery_tmo; |
| 1044 | ha->fw_ddb_index_map[ddb_entry->fw_ddb_index] = ddb_entry; | 1174 | ha->fw_ddb_index_map[ddb_entry->fw_ddb_index] = ddb_entry; |
| 1045 | ha->tot_ddbs++; | 1175 | ha->tot_ddbs++; |
| @@ -1077,6 +1207,9 @@ qla4xxx_conn_create(struct iscsi_cls_session *cls_sess, uint32_t conn_idx) | |||
| 1077 | DEBUG2(printk(KERN_INFO "Func: %s\n", __func__)); | 1207 | DEBUG2(printk(KERN_INFO "Func: %s\n", __func__)); |
| 1078 | cls_conn = iscsi_conn_setup(cls_sess, sizeof(struct qla_conn), | 1208 | cls_conn = iscsi_conn_setup(cls_sess, sizeof(struct qla_conn), |
| 1079 | conn_idx); | 1209 | conn_idx); |
| 1210 | if (!cls_conn) | ||
| 1211 | return NULL; | ||
| 1212 | |||
| 1080 | sess = cls_sess->dd_data; | 1213 | sess = cls_sess->dd_data; |
| 1081 | ddb_entry = sess->dd_data; | 1214 | ddb_entry = sess->dd_data; |
| 1082 | ddb_entry->conn = cls_conn; | 1215 | ddb_entry->conn = cls_conn; |
| @@ -1109,7 +1242,7 @@ static int qla4xxx_conn_start(struct iscsi_cls_conn *cls_conn) | |||
| 1109 | struct iscsi_session *sess; | 1242 | struct iscsi_session *sess; |
| 1110 | struct ddb_entry *ddb_entry; | 1243 | struct ddb_entry *ddb_entry; |
| 1111 | struct scsi_qla_host *ha; | 1244 | struct scsi_qla_host *ha; |
| 1112 | struct dev_db_entry *fw_ddb_entry; | 1245 | struct dev_db_entry *fw_ddb_entry = NULL; |
| 1113 | dma_addr_t fw_ddb_entry_dma; | 1246 | dma_addr_t fw_ddb_entry_dma; |
| 1114 | uint32_t mbx_sts = 0; | 1247 | uint32_t mbx_sts = 0; |
| 1115 | int ret = 0; | 1248 | int ret = 0; |
| @@ -1120,12 +1253,25 @@ static int qla4xxx_conn_start(struct iscsi_cls_conn *cls_conn) | |||
| 1120 | ddb_entry = sess->dd_data; | 1253 | ddb_entry = sess->dd_data; |
| 1121 | ha = ddb_entry->ha; | 1254 | ha = ddb_entry->ha; |
| 1122 | 1255 | ||
| 1256 | /* Check if we have matching FW DDB, if yes then do not | ||
| 1257 | * login to this target. This could cause target to logout previous | ||
| 1258 | * connection | ||
| 1259 | */ | ||
| 1260 | ret = qla4xxx_match_fwdb_session(ha, cls_conn); | ||
| 1261 | if (ret == QLA_SUCCESS) { | ||
| 1262 | ql4_printk(KERN_INFO, ha, | ||
| 1263 | "Session already exist in FW.\n"); | ||
| 1264 | ret = -EEXIST; | ||
| 1265 | goto exit_conn_start; | ||
| 1266 | } | ||
| 1267 | |||
| 1123 | fw_ddb_entry = dma_alloc_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), | 1268 | fw_ddb_entry = dma_alloc_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), |
| 1124 | &fw_ddb_entry_dma, GFP_KERNEL); | 1269 | &fw_ddb_entry_dma, GFP_KERNEL); |
| 1125 | if (!fw_ddb_entry) { | 1270 | if (!fw_ddb_entry) { |
| 1126 | ql4_printk(KERN_ERR, ha, | 1271 | ql4_printk(KERN_ERR, ha, |
| 1127 | "%s: Unable to allocate dma buffer\n", __func__); | 1272 | "%s: Unable to allocate dma buffer\n", __func__); |
| 1128 | return -ENOMEM; | 1273 | ret = -ENOMEM; |
| 1274 | goto exit_conn_start; | ||
| 1129 | } | 1275 | } |
| 1130 | 1276 | ||
| 1131 | ret = qla4xxx_set_param_ddbentry(ha, ddb_entry, cls_conn, &mbx_sts); | 1277 | ret = qla4xxx_set_param_ddbentry(ha, ddb_entry, cls_conn, &mbx_sts); |
| @@ -1138,9 +1284,7 @@ static int qla4xxx_conn_start(struct iscsi_cls_conn *cls_conn) | |||
| 1138 | if (mbx_sts) | 1284 | if (mbx_sts) |
| 1139 | if (ddb_entry->fw_ddb_device_state == | 1285 | if (ddb_entry->fw_ddb_device_state == |
| 1140 | DDB_DS_SESSION_ACTIVE) { | 1286 | DDB_DS_SESSION_ACTIVE) { |
| 1141 | iscsi_conn_start(ddb_entry->conn); | 1287 | ddb_entry->unblock_sess(ddb_entry->sess); |
| 1142 | iscsi_conn_login_event(ddb_entry->conn, | ||
| 1143 | ISCSI_CONN_STATE_LOGGED_IN); | ||
| 1144 | goto exit_set_param; | 1288 | goto exit_set_param; |
| 1145 | } | 1289 | } |
| 1146 | 1290 | ||
| @@ -1167,8 +1311,9 @@ exit_set_param: | |||
| 1167 | ret = 0; | 1311 | ret = 0; |
| 1168 | 1312 | ||
| 1169 | exit_conn_start: | 1313 | exit_conn_start: |
| 1170 | dma_free_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), | 1314 | if (fw_ddb_entry) |
| 1171 | fw_ddb_entry, fw_ddb_entry_dma); | 1315 | dma_free_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), |
| 1316 | fw_ddb_entry, fw_ddb_entry_dma); | ||
| 1172 | return ret; | 1317 | return ret; |
| 1173 | } | 1318 | } |
| 1174 | 1319 | ||
| @@ -1344,6 +1489,101 @@ static int qla4xxx_task_xmit(struct iscsi_task *task) | |||
| 1344 | return -ENOSYS; | 1489 | return -ENOSYS; |
| 1345 | } | 1490 | } |
| 1346 | 1491 | ||
| 1492 | static void qla4xxx_copy_fwddb_param(struct scsi_qla_host *ha, | ||
| 1493 | struct dev_db_entry *fw_ddb_entry, | ||
| 1494 | struct iscsi_cls_session *cls_sess, | ||
| 1495 | struct iscsi_cls_conn *cls_conn) | ||
| 1496 | { | ||
| 1497 | int buflen = 0; | ||
| 1498 | struct iscsi_session *sess; | ||
| 1499 | struct iscsi_conn *conn; | ||
| 1500 | char ip_addr[DDB_IPADDR_LEN]; | ||
| 1501 | uint16_t options = 0; | ||
| 1502 | |||
| 1503 | sess = cls_sess->dd_data; | ||
| 1504 | conn = cls_conn->dd_data; | ||
| 1505 | |||
| 1506 | conn->max_recv_dlength = BYTE_UNITS * | ||
| 1507 | le16_to_cpu(fw_ddb_entry->iscsi_max_rcv_data_seg_len); | ||
| 1508 | |||
| 1509 | conn->max_xmit_dlength = BYTE_UNITS * | ||
| 1510 | le16_to_cpu(fw_ddb_entry->iscsi_max_snd_data_seg_len); | ||
| 1511 | |||
| 1512 | sess->initial_r2t_en = | ||
| 1513 | (BIT_10 & le16_to_cpu(fw_ddb_entry->iscsi_options)); | ||
| 1514 | |||
| 1515 | sess->max_r2t = le16_to_cpu(fw_ddb_entry->iscsi_max_outsnd_r2t); | ||
| 1516 | |||
| 1517 | sess->imm_data_en = (BIT_11 & le16_to_cpu(fw_ddb_entry->iscsi_options)); | ||
| 1518 | |||
| 1519 | sess->first_burst = BYTE_UNITS * | ||
| 1520 | le16_to_cpu(fw_ddb_entry->iscsi_first_burst_len); | ||
| 1521 | |||
| 1522 | sess->max_burst = BYTE_UNITS * | ||
| 1523 | le16_to_cpu(fw_ddb_entry->iscsi_max_burst_len); | ||
| 1524 | |||
| 1525 | sess->time2wait = le16_to_cpu(fw_ddb_entry->iscsi_def_time2wait); | ||
| 1526 | |||
| 1527 | sess->time2retain = le16_to_cpu(fw_ddb_entry->iscsi_def_time2retain); | ||
| 1528 | |||
| 1529 | conn->persistent_port = le16_to_cpu(fw_ddb_entry->port); | ||
| 1530 | |||
| 1531 | sess->tpgt = le32_to_cpu(fw_ddb_entry->tgt_portal_grp); | ||
| 1532 | |||
| 1533 | options = le16_to_cpu(fw_ddb_entry->options); | ||
| 1534 | if (options & DDB_OPT_IPV6_DEVICE) | ||
| 1535 | sprintf(ip_addr, "%pI6", fw_ddb_entry->ip_addr); | ||
| 1536 | else | ||
| 1537 | sprintf(ip_addr, "%pI4", fw_ddb_entry->ip_addr); | ||
| 1538 | |||
| 1539 | iscsi_set_param(cls_conn, ISCSI_PARAM_TARGET_NAME, | ||
| 1540 | (char *)fw_ddb_entry->iscsi_name, buflen); | ||
| 1541 | iscsi_set_param(cls_conn, ISCSI_PARAM_INITIATOR_NAME, | ||
| 1542 | (char *)ha->name_string, buflen); | ||
| 1543 | iscsi_set_param(cls_conn, ISCSI_PARAM_PERSISTENT_ADDRESS, | ||
| 1544 | (char *)ip_addr, buflen); | ||
| 1545 | } | ||
| 1546 | |||
| 1547 | void qla4xxx_update_session_conn_fwddb_param(struct scsi_qla_host *ha, | ||
| 1548 | struct ddb_entry *ddb_entry) | ||
| 1549 | { | ||
| 1550 | struct iscsi_cls_session *cls_sess; | ||
| 1551 | struct iscsi_cls_conn *cls_conn; | ||
| 1552 | uint32_t ddb_state; | ||
| 1553 | dma_addr_t fw_ddb_entry_dma; | ||
| 1554 | struct dev_db_entry *fw_ddb_entry; | ||
| 1555 | |||
| 1556 | fw_ddb_entry = dma_alloc_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), | ||
| 1557 | &fw_ddb_entry_dma, GFP_KERNEL); | ||
| 1558 | if (!fw_ddb_entry) { | ||
| 1559 | ql4_printk(KERN_ERR, ha, | ||
| 1560 | "%s: Unable to allocate dma buffer\n", __func__); | ||
| 1561 | goto exit_session_conn_fwddb_param; | ||
| 1562 | } | ||
| 1563 | |||
| 1564 | if (qla4xxx_get_fwddb_entry(ha, ddb_entry->fw_ddb_index, fw_ddb_entry, | ||
| 1565 | fw_ddb_entry_dma, NULL, NULL, &ddb_state, | ||
| 1566 | NULL, NULL, NULL) == QLA_ERROR) { | ||
| 1567 | DEBUG2(ql4_printk(KERN_ERR, ha, "scsi%ld: %s: failed " | ||
| 1568 | "get_ddb_entry for fw_ddb_index %d\n", | ||
| 1569 | ha->host_no, __func__, | ||
| 1570 | ddb_entry->fw_ddb_index)); | ||
| 1571 | goto exit_session_conn_fwddb_param; | ||
| 1572 | } | ||
| 1573 | |||
| 1574 | cls_sess = ddb_entry->sess; | ||
| 1575 | |||
| 1576 | cls_conn = ddb_entry->conn; | ||
| 1577 | |||
| 1578 | /* Update params */ | ||
| 1579 | qla4xxx_copy_fwddb_param(ha, fw_ddb_entry, cls_sess, cls_conn); | ||
| 1580 | |||
| 1581 | exit_session_conn_fwddb_param: | ||
| 1582 | if (fw_ddb_entry) | ||
| 1583 | dma_free_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), | ||
| 1584 | fw_ddb_entry, fw_ddb_entry_dma); | ||
| 1585 | } | ||
| 1586 | |||
| 1347 | void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, | 1587 | void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, |
| 1348 | struct ddb_entry *ddb_entry) | 1588 | struct ddb_entry *ddb_entry) |
| 1349 | { | 1589 | { |
| @@ -1360,7 +1600,7 @@ void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, | |||
| 1360 | if (!fw_ddb_entry) { | 1600 | if (!fw_ddb_entry) { |
| 1361 | ql4_printk(KERN_ERR, ha, | 1601 | ql4_printk(KERN_ERR, ha, |
| 1362 | "%s: Unable to allocate dma buffer\n", __func__); | 1602 | "%s: Unable to allocate dma buffer\n", __func__); |
| 1363 | return; | 1603 | goto exit_session_conn_param; |
| 1364 | } | 1604 | } |
| 1365 | 1605 | ||
| 1366 | if (qla4xxx_get_fwddb_entry(ha, ddb_entry->fw_ddb_index, fw_ddb_entry, | 1606 | if (qla4xxx_get_fwddb_entry(ha, ddb_entry->fw_ddb_index, fw_ddb_entry, |
| @@ -1370,7 +1610,7 @@ void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, | |||
| 1370 | "get_ddb_entry for fw_ddb_index %d\n", | 1610 | "get_ddb_entry for fw_ddb_index %d\n", |
| 1371 | ha->host_no, __func__, | 1611 | ha->host_no, __func__, |
| 1372 | ddb_entry->fw_ddb_index)); | 1612 | ddb_entry->fw_ddb_index)); |
| 1373 | return; | 1613 | goto exit_session_conn_param; |
| 1374 | } | 1614 | } |
| 1375 | 1615 | ||
| 1376 | cls_sess = ddb_entry->sess; | 1616 | cls_sess = ddb_entry->sess; |
| @@ -1379,6 +1619,12 @@ void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, | |||
| 1379 | cls_conn = ddb_entry->conn; | 1619 | cls_conn = ddb_entry->conn; |
| 1380 | conn = cls_conn->dd_data; | 1620 | conn = cls_conn->dd_data; |
| 1381 | 1621 | ||
| 1622 | /* Update timers after login */ | ||
| 1623 | ddb_entry->default_relogin_timeout = | ||
| 1624 | le16_to_cpu(fw_ddb_entry->def_timeout); | ||
| 1625 | ddb_entry->default_time2wait = | ||
| 1626 | le16_to_cpu(fw_ddb_entry->iscsi_def_time2wait); | ||
| 1627 | |||
| 1382 | /* Update params */ | 1628 | /* Update params */ |
| 1383 | conn->max_recv_dlength = BYTE_UNITS * | 1629 | conn->max_recv_dlength = BYTE_UNITS * |
| 1384 | le16_to_cpu(fw_ddb_entry->iscsi_max_rcv_data_seg_len); | 1630 | le16_to_cpu(fw_ddb_entry->iscsi_max_rcv_data_seg_len); |
| @@ -1407,6 +1653,11 @@ void qla4xxx_update_session_conn_param(struct scsi_qla_host *ha, | |||
| 1407 | 1653 | ||
| 1408 | memcpy(sess->initiatorname, ha->name_string, | 1654 | memcpy(sess->initiatorname, ha->name_string, |
| 1409 | min(sizeof(ha->name_string), sizeof(sess->initiatorname))); | 1655 | min(sizeof(ha->name_string), sizeof(sess->initiatorname))); |
| 1656 | |||
| 1657 | exit_session_conn_param: | ||
| 1658 | if (fw_ddb_entry) | ||
| 1659 | dma_free_coherent(&ha->pdev->dev, sizeof(*fw_ddb_entry), | ||
| 1660 | fw_ddb_entry, fw_ddb_entry_dma); | ||
| 1410 | } | 1661 | } |
| 1411 | 1662 | ||
| 1412 | /* | 1663 | /* |
| @@ -1607,6 +1858,9 @@ static void qla4xxx_mem_free(struct scsi_qla_host *ha) | |||
| 1607 | vfree(ha->chap_list); | 1858 | vfree(ha->chap_list); |
| 1608 | ha->chap_list = NULL; | 1859 | ha->chap_list = NULL; |
| 1609 | 1860 | ||
| 1861 | if (ha->fw_ddb_dma_pool) | ||
| 1862 | dma_pool_destroy(ha->fw_ddb_dma_pool); | ||
| 1863 | |||
| 1610 | /* release io space registers */ | 1864 | /* release io space registers */ |
| 1611 | if (is_qla8022(ha)) { | 1865 | if (is_qla8022(ha)) { |
| 1612 | if (ha->nx_pcibase) | 1866 | if (ha->nx_pcibase) |
| @@ -1689,6 +1943,16 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) | |||
| 1689 | goto mem_alloc_error_exit; | 1943 | goto mem_alloc_error_exit; |
| 1690 | } | 1944 | } |
| 1691 | 1945 | ||
| 1946 | ha->fw_ddb_dma_pool = dma_pool_create("ql4_fw_ddb", &ha->pdev->dev, | ||
| 1947 | DDB_DMA_BLOCK_SIZE, 8, 0); | ||
| 1948 | |||
| 1949 | if (ha->fw_ddb_dma_pool == NULL) { | ||
| 1950 | ql4_printk(KERN_WARNING, ha, | ||
| 1951 | "%s: fw_ddb_dma_pool allocation failed..\n", | ||
| 1952 | __func__); | ||
| 1953 | goto mem_alloc_error_exit; | ||
| 1954 | } | ||
| 1955 | |||
| 1692 | return QLA_SUCCESS; | 1956 | return QLA_SUCCESS; |
| 1693 | 1957 | ||
| 1694 | mem_alloc_error_exit: | 1958 | mem_alloc_error_exit: |
| @@ -1800,6 +2064,60 @@ void qla4_8xxx_watchdog(struct scsi_qla_host *ha) | |||
| 1800 | } | 2064 | } |
| 1801 | } | 2065 | } |
| 1802 | 2066 | ||
| 2067 | void qla4xxx_check_relogin_flash_ddb(struct iscsi_cls_session *cls_sess) | ||
| 2068 | { | ||
| 2069 | struct iscsi_session *sess; | ||
| 2070 | struct ddb_entry *ddb_entry; | ||
| 2071 | struct scsi_qla_host *ha; | ||
| 2072 | |||
| 2073 | sess = cls_sess->dd_data; | ||
| 2074 | ddb_entry = sess->dd_data; | ||
| 2075 | ha = ddb_entry->ha; | ||
| 2076 | |||
| 2077 | if (!(ddb_entry->ddb_type == FLASH_DDB)) | ||
| 2078 | return; | ||
| 2079 | |||
| 2080 | if (adapter_up(ha) && !test_bit(DF_RELOGIN, &ddb_entry->flags) && | ||
| 2081 | !iscsi_is_session_online(cls_sess)) { | ||
| 2082 | if (atomic_read(&ddb_entry->retry_relogin_timer) != | ||
| 2083 | INVALID_ENTRY) { | ||
| 2084 | if (atomic_read(&ddb_entry->retry_relogin_timer) == | ||
| 2085 | 0) { | ||
| 2086 | atomic_set(&ddb_entry->retry_relogin_timer, | ||
| 2087 | INVALID_ENTRY); | ||
| 2088 | set_bit(DPC_RELOGIN_DEVICE, &ha->dpc_flags); | ||
| 2089 | set_bit(DF_RELOGIN, &ddb_entry->flags); | ||
| 2090 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 2091 | "%s: index [%d] login device\n", | ||
| 2092 | __func__, ddb_entry->fw_ddb_index)); | ||
| 2093 | } else | ||
| 2094 | atomic_dec(&ddb_entry->retry_relogin_timer); | ||
| 2095 | } | ||
| 2096 | } | ||
| 2097 | |||
| 2098 | /* Wait for relogin to timeout */ | ||
| 2099 | if (atomic_read(&ddb_entry->relogin_timer) && | ||
| 2100 | (atomic_dec_and_test(&ddb_entry->relogin_timer) != 0)) { | ||
| 2101 | /* | ||
| 2102 | * If the relogin times out and the device is | ||
| 2103 | * still NOT ONLINE then try and relogin again. | ||
| 2104 | */ | ||
| 2105 | if (!iscsi_is_session_online(cls_sess)) { | ||
| 2106 | /* Reset retry relogin timer */ | ||
| 2107 | atomic_inc(&ddb_entry->relogin_retry_count); | ||
| 2108 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 2109 | "%s: index[%d] relogin timed out-retrying" | ||
| 2110 | " relogin (%d), retry (%d)\n", __func__, | ||
| 2111 | ddb_entry->fw_ddb_index, | ||
| 2112 | atomic_read(&ddb_entry->relogin_retry_count), | ||
| 2113 | ddb_entry->default_time2wait + 4)); | ||
| 2114 | set_bit(DPC_RELOGIN_DEVICE, &ha->dpc_flags); | ||
| 2115 | atomic_set(&ddb_entry->retry_relogin_timer, | ||
| 2116 | ddb_entry->default_time2wait + 4); | ||
| 2117 | } | ||
| 2118 | } | ||
| 2119 | } | ||
| 2120 | |||
| 1803 | /** | 2121 | /** |
| 1804 | * qla4xxx_timer - checks every second for work to do. | 2122 | * qla4xxx_timer - checks every second for work to do. |
| 1805 | * @ha: Pointer to host adapter structure. | 2123 | * @ha: Pointer to host adapter structure. |
| @@ -1809,6 +2127,8 @@ static void qla4xxx_timer(struct scsi_qla_host *ha) | |||
| 1809 | int start_dpc = 0; | 2127 | int start_dpc = 0; |
| 1810 | uint16_t w; | 2128 | uint16_t w; |
| 1811 | 2129 | ||
| 2130 | iscsi_host_for_each_session(ha->host, qla4xxx_check_relogin_flash_ddb); | ||
| 2131 | |||
| 1812 | /* If we are in the middle of AER/EEH processing | 2132 | /* If we are in the middle of AER/EEH processing |
| 1813 | * skip any processing and reschedule the timer | 2133 | * skip any processing and reschedule the timer |
| 1814 | */ | 2134 | */ |
| @@ -2078,7 +2398,12 @@ static void qla4xxx_fail_session(struct iscsi_cls_session *cls_session) | |||
| 2078 | sess = cls_session->dd_data; | 2398 | sess = cls_session->dd_data; |
| 2079 | ddb_entry = sess->dd_data; | 2399 | ddb_entry = sess->dd_data; |
| 2080 | ddb_entry->fw_ddb_device_state = DDB_DS_SESSION_FAILED; | 2400 | ddb_entry->fw_ddb_device_state = DDB_DS_SESSION_FAILED; |
| 2081 | iscsi_session_failure(cls_session->dd_data, ISCSI_ERR_CONN_FAILED); | 2401 | |
| 2402 | if (ddb_entry->ddb_type == FLASH_DDB) | ||
| 2403 | iscsi_block_session(ddb_entry->sess); | ||
| 2404 | else | ||
| 2405 | iscsi_session_failure(cls_session->dd_data, | ||
| 2406 | ISCSI_ERR_CONN_FAILED); | ||
| 2082 | } | 2407 | } |
| 2083 | 2408 | ||
| 2084 | /** | 2409 | /** |
| @@ -2163,7 +2488,7 @@ recover_ha_init_adapter: | |||
| 2163 | 2488 | ||
| 2164 | /* NOTE: AF_ONLINE flag set upon successful completion of | 2489 | /* NOTE: AF_ONLINE flag set upon successful completion of |
| 2165 | * qla4xxx_initialize_adapter */ | 2490 | * qla4xxx_initialize_adapter */ |
| 2166 | status = qla4xxx_initialize_adapter(ha); | 2491 | status = qla4xxx_initialize_adapter(ha, RESET_ADAPTER); |
| 2167 | } | 2492 | } |
| 2168 | 2493 | ||
| 2169 | /* Retry failed adapter initialization, if necessary | 2494 | /* Retry failed adapter initialization, if necessary |
| @@ -2245,17 +2570,108 @@ static void qla4xxx_relogin_devices(struct iscsi_cls_session *cls_session) | |||
| 2245 | iscsi_unblock_session(ddb_entry->sess); | 2570 | iscsi_unblock_session(ddb_entry->sess); |
| 2246 | } else { | 2571 | } else { |
| 2247 | /* Trigger relogin */ | 2572 | /* Trigger relogin */ |
| 2248 | iscsi_session_failure(cls_session->dd_data, | 2573 | if (ddb_entry->ddb_type == FLASH_DDB) { |
| 2249 | ISCSI_ERR_CONN_FAILED); | 2574 | if (!test_bit(DF_RELOGIN, &ddb_entry->flags)) |
| 2575 | qla4xxx_arm_relogin_timer(ddb_entry); | ||
| 2576 | } else | ||
| 2577 | iscsi_session_failure(cls_session->dd_data, | ||
| 2578 | ISCSI_ERR_CONN_FAILED); | ||
| 2250 | } | 2579 | } |
| 2251 | } | 2580 | } |
| 2252 | } | 2581 | } |
| 2253 | 2582 | ||
| 2583 | int qla4xxx_unblock_flash_ddb(struct iscsi_cls_session *cls_session) | ||
| 2584 | { | ||
| 2585 | struct iscsi_session *sess; | ||
| 2586 | struct ddb_entry *ddb_entry; | ||
| 2587 | struct scsi_qla_host *ha; | ||
| 2588 | |||
| 2589 | sess = cls_session->dd_data; | ||
| 2590 | ddb_entry = sess->dd_data; | ||
| 2591 | ha = ddb_entry->ha; | ||
| 2592 | ql4_printk(KERN_INFO, ha, "scsi%ld: %s: ddb[%d]" | ||
| 2593 | " unblock session\n", ha->host_no, __func__, | ||
| 2594 | ddb_entry->fw_ddb_index); | ||
| 2595 | |||
| 2596 | iscsi_unblock_session(ddb_entry->sess); | ||
| 2597 | |||
| 2598 | /* Start scan target */ | ||
| 2599 | if (test_bit(AF_ONLINE, &ha->flags)) { | ||
| 2600 | ql4_printk(KERN_INFO, ha, "scsi%ld: %s: ddb[%d]" | ||
| 2601 | " start scan\n", ha->host_no, __func__, | ||
| 2602 | ddb_entry->fw_ddb_index); | ||
| 2603 | scsi_queue_work(ha->host, &ddb_entry->sess->scan_work); | ||
| 2604 | } | ||
| 2605 | return QLA_SUCCESS; | ||
| 2606 | } | ||
| 2607 | |||
| 2608 | int qla4xxx_unblock_ddb(struct iscsi_cls_session *cls_session) | ||
| 2609 | { | ||
| 2610 | struct iscsi_session *sess; | ||
| 2611 | struct ddb_entry *ddb_entry; | ||
| 2612 | struct scsi_qla_host *ha; | ||
| 2613 | |||
| 2614 | sess = cls_session->dd_data; | ||
| 2615 | ddb_entry = sess->dd_data; | ||
| 2616 | ha = ddb_entry->ha; | ||
| 2617 | ql4_printk(KERN_INFO, ha, "scsi%ld: %s: ddb[%d]" | ||
| 2618 | " unblock user space session\n", ha->host_no, __func__, | ||
| 2619 | ddb_entry->fw_ddb_index); | ||
| 2620 | iscsi_conn_start(ddb_entry->conn); | ||
| 2621 | iscsi_conn_login_event(ddb_entry->conn, | ||
| 2622 | ISCSI_CONN_STATE_LOGGED_IN); | ||
| 2623 | |||
| 2624 | return QLA_SUCCESS; | ||
| 2625 | } | ||
| 2626 | |||
| 2254 | static void qla4xxx_relogin_all_devices(struct scsi_qla_host *ha) | 2627 | static void qla4xxx_relogin_all_devices(struct scsi_qla_host *ha) |
| 2255 | { | 2628 | { |
| 2256 | iscsi_host_for_each_session(ha->host, qla4xxx_relogin_devices); | 2629 | iscsi_host_for_each_session(ha->host, qla4xxx_relogin_devices); |
| 2257 | } | 2630 | } |
| 2258 | 2631 | ||
| 2632 | static void qla4xxx_relogin_flash_ddb(struct iscsi_cls_session *cls_sess) | ||
| 2633 | { | ||
| 2634 | uint16_t relogin_timer; | ||
| 2635 | struct iscsi_session *sess; | ||
| 2636 | struct ddb_entry *ddb_entry; | ||
| 2637 | struct scsi_qla_host *ha; | ||
| 2638 | |||
| 2639 | sess = cls_sess->dd_data; | ||
| 2640 | ddb_entry = sess->dd_data; | ||
| 2641 | ha = ddb_entry->ha; | ||
| 2642 | |||
| 2643 | relogin_timer = max(ddb_entry->default_relogin_timeout, | ||
| 2644 | (uint16_t)RELOGIN_TOV); | ||
| 2645 | atomic_set(&ddb_entry->relogin_timer, relogin_timer); | ||
| 2646 | |||
| 2647 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 2648 | "scsi%ld: Relogin index [%d]. TOV=%d\n", ha->host_no, | ||
| 2649 | ddb_entry->fw_ddb_index, relogin_timer)); | ||
| 2650 | |||
| 2651 | qla4xxx_login_flash_ddb(cls_sess); | ||
| 2652 | } | ||
| 2653 | |||
| 2654 | static void qla4xxx_dpc_relogin(struct iscsi_cls_session *cls_sess) | ||
| 2655 | { | ||
| 2656 | struct iscsi_session *sess; | ||
| 2657 | struct ddb_entry *ddb_entry; | ||
| 2658 | struct scsi_qla_host *ha; | ||
| 2659 | |||
| 2660 | sess = cls_sess->dd_data; | ||
| 2661 | ddb_entry = sess->dd_data; | ||
| 2662 | ha = ddb_entry->ha; | ||
| 2663 | |||
| 2664 | if (!(ddb_entry->ddb_type == FLASH_DDB)) | ||
| 2665 | return; | ||
| 2666 | |||
| 2667 | if (test_and_clear_bit(DF_RELOGIN, &ddb_entry->flags) && | ||
| 2668 | !iscsi_is_session_online(cls_sess)) { | ||
| 2669 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 2670 | "relogin issued\n")); | ||
| 2671 | qla4xxx_relogin_flash_ddb(cls_sess); | ||
| 2672 | } | ||
| 2673 | } | ||
| 2674 | |||
| 2259 | void qla4xxx_wake_dpc(struct scsi_qla_host *ha) | 2675 | void qla4xxx_wake_dpc(struct scsi_qla_host *ha) |
| 2260 | { | 2676 | { |
| 2261 | if (ha->dpc_thread) | 2677 | if (ha->dpc_thread) |
| @@ -2356,6 +2772,12 @@ dpc_post_reset_ha: | |||
| 2356 | if (test_and_clear_bit(DPC_GET_DHCP_IP_ADDR, &ha->dpc_flags)) | 2772 | if (test_and_clear_bit(DPC_GET_DHCP_IP_ADDR, &ha->dpc_flags)) |
| 2357 | qla4xxx_get_dhcp_ip_address(ha); | 2773 | qla4xxx_get_dhcp_ip_address(ha); |
| 2358 | 2774 | ||
| 2775 | /* ---- relogin device? --- */ | ||
| 2776 | if (adapter_up(ha) && | ||
| 2777 | test_and_clear_bit(DPC_RELOGIN_DEVICE, &ha->dpc_flags)) { | ||
| 2778 | iscsi_host_for_each_session(ha->host, qla4xxx_dpc_relogin); | ||
| 2779 | } | ||
| 2780 | |||
| 2359 | /* ---- link change? --- */ | 2781 | /* ---- link change? --- */ |
| 2360 | if (test_and_clear_bit(DPC_LINK_CHANGED, &ha->dpc_flags)) { | 2782 | if (test_and_clear_bit(DPC_LINK_CHANGED, &ha->dpc_flags)) { |
| 2361 | if (!test_bit(AF_LINK_UP, &ha->flags)) { | 2783 | if (!test_bit(AF_LINK_UP, &ha->flags)) { |
| @@ -2368,8 +2790,12 @@ dpc_post_reset_ha: | |||
| 2368 | * fatal error recovery. Therefore, the driver must | 2790 | * fatal error recovery. Therefore, the driver must |
| 2369 | * manually relogin to devices when recovering from | 2791 | * manually relogin to devices when recovering from |
| 2370 | * connection failures, logouts, expired KATO, etc. */ | 2792 | * connection failures, logouts, expired KATO, etc. */ |
| 2371 | 2793 | if (test_and_clear_bit(AF_BUILD_DDB_LIST, &ha->flags)) { | |
| 2372 | qla4xxx_relogin_all_devices(ha); | 2794 | qla4xxx_build_ddb_list(ha, ha->is_reset); |
| 2795 | iscsi_host_for_each_session(ha->host, | ||
| 2796 | qla4xxx_login_flash_ddb); | ||
| 2797 | } else | ||
| 2798 | qla4xxx_relogin_all_devices(ha); | ||
| 2373 | } | 2799 | } |
| 2374 | } | 2800 | } |
| 2375 | } | 2801 | } |
| @@ -2867,6 +3293,9 @@ static int get_fw_boot_info(struct scsi_qla_host *ha, uint16_t ddb_index[]) | |||
| 2867 | " target ID %d\n", __func__, ddb_index[0], | 3293 | " target ID %d\n", __func__, ddb_index[0], |
| 2868 | ddb_index[1])); | 3294 | ddb_index[1])); |
| 2869 | 3295 | ||
| 3296 | ha->pri_ddb_idx = ddb_index[0]; | ||
| 3297 | ha->sec_ddb_idx = ddb_index[1]; | ||
| 3298 | |||
| 2870 | exit_boot_info_free: | 3299 | exit_boot_info_free: |
| 2871 | dma_free_coherent(&ha->pdev->dev, size, buf, buf_dma); | 3300 | dma_free_coherent(&ha->pdev->dev, size, buf, buf_dma); |
| 2872 | exit_boot_info: | 3301 | exit_boot_info: |
| @@ -3034,6 +3463,9 @@ static int qla4xxx_get_boot_info(struct scsi_qla_host *ha) | |||
| 3034 | return ret; | 3463 | return ret; |
| 3035 | } | 3464 | } |
| 3036 | 3465 | ||
| 3466 | if (ql4xdisablesysfsboot) | ||
| 3467 | return QLA_SUCCESS; | ||
| 3468 | |||
| 3037 | if (ddb_index[0] == 0xffff) | 3469 | if (ddb_index[0] == 0xffff) |
| 3038 | goto sec_target; | 3470 | goto sec_target; |
| 3039 | 3471 | ||
| @@ -3066,7 +3498,15 @@ static int qla4xxx_setup_boot_info(struct scsi_qla_host *ha) | |||
| 3066 | struct iscsi_boot_kobj *boot_kobj; | 3498 | struct iscsi_boot_kobj *boot_kobj; |
| 3067 | 3499 | ||
| 3068 | if (qla4xxx_get_boot_info(ha) != QLA_SUCCESS) | 3500 | if (qla4xxx_get_boot_info(ha) != QLA_SUCCESS) |
| 3069 | return 0; | 3501 | return QLA_ERROR; |
| 3502 | |||
| 3503 | if (ql4xdisablesysfsboot) { | ||
| 3504 | ql4_printk(KERN_INFO, ha, | ||
| 3505 | "%s: syfsboot disabled - driver will trigger login" | ||
| 3506 | "and publish session for discovery .\n", __func__); | ||
| 3507 | return QLA_SUCCESS; | ||
| 3508 | } | ||
| 3509 | |||
| 3070 | 3510 | ||
| 3071 | ha->boot_kset = iscsi_boot_create_host_kset(ha->host->host_no); | 3511 | ha->boot_kset = iscsi_boot_create_host_kset(ha->host->host_no); |
| 3072 | if (!ha->boot_kset) | 3512 | if (!ha->boot_kset) |
| @@ -3108,7 +3548,7 @@ static int qla4xxx_setup_boot_info(struct scsi_qla_host *ha) | |||
| 3108 | if (!boot_kobj) | 3548 | if (!boot_kobj) |
| 3109 | goto put_host; | 3549 | goto put_host; |
| 3110 | 3550 | ||
| 3111 | return 0; | 3551 | return QLA_SUCCESS; |
| 3112 | 3552 | ||
| 3113 | put_host: | 3553 | put_host: |
| 3114 | scsi_host_put(ha->host); | 3554 | scsi_host_put(ha->host); |
| @@ -3174,9 +3614,507 @@ static void qla4xxx_create_chap_list(struct scsi_qla_host *ha) | |||
| 3174 | exit_chap_list: | 3614 | exit_chap_list: |
| 3175 | dma_free_coherent(&ha->pdev->dev, chap_size, | 3615 | dma_free_coherent(&ha->pdev->dev, chap_size, |
| 3176 | chap_flash_data, chap_dma); | 3616 | chap_flash_data, chap_dma); |
| 3177 | return; | ||
| 3178 | } | 3617 | } |
| 3179 | 3618 | ||
| 3619 | static void qla4xxx_get_param_ddb(struct ddb_entry *ddb_entry, | ||
| 3620 | struct ql4_tuple_ddb *tddb) | ||
| 3621 | { | ||
| 3622 | struct scsi_qla_host *ha; | ||
| 3623 | struct iscsi_cls_session *cls_sess; | ||
| 3624 | struct iscsi_cls_conn *cls_conn; | ||
| 3625 | struct iscsi_session *sess; | ||
| 3626 | struct iscsi_conn *conn; | ||
| 3627 | |||
| 3628 | DEBUG2(printk(KERN_INFO "Func: %s\n", __func__)); | ||
| 3629 | ha = ddb_entry->ha; | ||
| 3630 | cls_sess = ddb_entry->sess; | ||
| 3631 | sess = cls_sess->dd_data; | ||
| 3632 | cls_conn = ddb_entry->conn; | ||
| 3633 | conn = cls_conn->dd_data; | ||
| 3634 | |||
| 3635 | tddb->tpgt = sess->tpgt; | ||
| 3636 | tddb->port = conn->persistent_port; | ||
| 3637 | strncpy(tddb->iscsi_name, sess->targetname, ISCSI_NAME_SIZE); | ||
| 3638 | strncpy(tddb->ip_addr, conn->persistent_address, DDB_IPADDR_LEN); | ||
| 3639 | } | ||
| 3640 | |||
| 3641 | static void qla4xxx_convert_param_ddb(struct dev_db_entry *fw_ddb_entry, | ||
| 3642 | struct ql4_tuple_ddb *tddb) | ||
| 3643 | { | ||
| 3644 | uint16_t options = 0; | ||
| 3645 | |||
| 3646 | tddb->tpgt = le32_to_cpu(fw_ddb_entry->tgt_portal_grp); | ||
| 3647 | memcpy(&tddb->iscsi_name[0], &fw_ddb_entry->iscsi_name[0], | ||
| 3648 | min(sizeof(tddb->iscsi_name), sizeof(fw_ddb_entry->iscsi_name))); | ||
| 3649 | |||
| 3650 | options = le16_to_cpu(fw_ddb_entry->options); | ||
| 3651 | if (options & DDB_OPT_IPV6_DEVICE) | ||
| 3652 | sprintf(tddb->ip_addr, "%pI6", fw_ddb_entry->ip_addr); | ||
| 3653 | else | ||
| 3654 | sprintf(tddb->ip_addr, "%pI4", fw_ddb_entry->ip_addr); | ||
| 3655 | |||
| 3656 | tddb->port = le16_to_cpu(fw_ddb_entry->port); | ||
| 3657 | } | ||
| 3658 | |||
| 3659 | static int qla4xxx_compare_tuple_ddb(struct scsi_qla_host *ha, | ||
| 3660 | struct ql4_tuple_ddb *old_tddb, | ||
| 3661 | struct ql4_tuple_ddb *new_tddb) | ||
| 3662 | { | ||
| 3663 | if (strcmp(old_tddb->iscsi_name, new_tddb->iscsi_name)) | ||
| 3664 | return QLA_ERROR; | ||
| 3665 | |||
| 3666 | if (strcmp(old_tddb->ip_addr, new_tddb->ip_addr)) | ||
| 3667 | return QLA_ERROR; | ||
| 3668 | |||
| 3669 | if (old_tddb->port != new_tddb->port) | ||
| 3670 | return QLA_ERROR; | ||
| 3671 | |||
| 3672 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 3673 | "Match Found, fw[%d,%d,%s,%s], [%d,%d,%s,%s]", | ||
| 3674 | old_tddb->port, old_tddb->tpgt, old_tddb->ip_addr, | ||
| 3675 | old_tddb->iscsi_name, new_tddb->port, new_tddb->tpgt, | ||
| 3676 | new_tddb->ip_addr, new_tddb->iscsi_name)); | ||
| 3677 | |||
| 3678 | return QLA_SUCCESS; | ||
| 3679 | } | ||
| 3680 | |||
| 3681 | static int qla4xxx_is_session_exists(struct scsi_qla_host *ha, | ||
| 3682 | struct dev_db_entry *fw_ddb_entry) | ||
| 3683 | { | ||
| 3684 | struct ddb_entry *ddb_entry; | ||
| 3685 | struct ql4_tuple_ddb *fw_tddb = NULL; | ||
| 3686 | struct ql4_tuple_ddb *tmp_tddb = NULL; | ||
| 3687 | int idx; | ||
| 3688 | int ret = QLA_ERROR; | ||
| 3689 | |||
| 3690 | fw_tddb = vzalloc(sizeof(*fw_tddb)); | ||
| 3691 | if (!fw_tddb) { | ||
| 3692 | DEBUG2(ql4_printk(KERN_WARNING, ha, | ||
| 3693 | "Memory Allocation failed.\n")); | ||
| 3694 | ret = QLA_SUCCESS; | ||
| 3695 | goto exit_check; | ||
| 3696 | } | ||
| 3697 | |||
| 3698 | tmp_tddb = vzalloc(sizeof(*tmp_tddb)); | ||
| 3699 | if (!tmp_tddb) { | ||
| 3700 | DEBUG2(ql4_printk(KERN_WARNING, ha, | ||
| 3701 | "Memory Allocation failed.\n")); | ||
| 3702 | ret = QLA_SUCCESS; | ||
| 3703 | goto exit_check; | ||
| 3704 | } | ||
| 3705 | |||
| 3706 | qla4xxx_convert_param_ddb(fw_ddb_entry, fw_tddb); | ||
| 3707 | |||
| 3708 | for (idx = 0; idx < MAX_DDB_ENTRIES; idx++) { | ||
| 3709 | ddb_entry = qla4xxx_lookup_ddb_by_fw_index(ha, idx); | ||
| 3710 | if (ddb_entry == NULL) | ||
| 3711 | continue; | ||
| 3712 | |||
| 3713 | qla4xxx_get_param_ddb(ddb_entry, tmp_tddb); | ||
| 3714 | if (!qla4xxx_compare_tuple_ddb(ha, fw_tddb, tmp_tddb)) { | ||
| 3715 | ret = QLA_SUCCESS; /* found */ | ||
| 3716 | goto exit_check; | ||
| 3717 | } | ||
| 3718 | } | ||
| 3719 | |||
| 3720 | exit_check: | ||
| 3721 | if (fw_tddb) | ||
| 3722 | vfree(fw_tddb); | ||
| 3723 | if (tmp_tddb) | ||
| 3724 | vfree(tmp_tddb); | ||
| 3725 | return ret; | ||
| 3726 | } | ||
| 3727 | |||
| 3728 | static int qla4xxx_is_flash_ddb_exists(struct scsi_qla_host *ha, | ||
| 3729 | struct list_head *list_nt, | ||
| 3730 | struct dev_db_entry *fw_ddb_entry) | ||
| 3731 | { | ||
| 3732 | struct qla_ddb_index *nt_ddb_idx, *nt_ddb_idx_tmp; | ||
| 3733 | struct ql4_tuple_ddb *fw_tddb = NULL; | ||
| 3734 | struct ql4_tuple_ddb *tmp_tddb = NULL; | ||
| 3735 | int ret = QLA_ERROR; | ||
| 3736 | |||
| 3737 | fw_tddb = vzalloc(sizeof(*fw_tddb)); | ||
| 3738 | if (!fw_tddb) { | ||
| 3739 | DEBUG2(ql4_printk(KERN_WARNING, ha, | ||
| 3740 | "Memory Allocation failed.\n")); | ||
| 3741 | ret = QLA_SUCCESS; | ||
| 3742 | goto exit_check; | ||
| 3743 | } | ||
| 3744 | |||
| 3745 | tmp_tddb = vzalloc(sizeof(*tmp_tddb)); | ||
| 3746 | if (!tmp_tddb) { | ||
| 3747 | DEBUG2(ql4_printk(KERN_WARNING, ha, | ||
| 3748 | "Memory Allocation failed.\n")); | ||
| 3749 | ret = QLA_SUCCESS; | ||
| 3750 | goto exit_check; | ||
| 3751 | } | ||
| 3752 | |||
| 3753 | qla4xxx_convert_param_ddb(fw_ddb_entry, fw_tddb); | ||
| 3754 | |||
| 3755 | list_for_each_entry_safe(nt_ddb_idx, nt_ddb_idx_tmp, list_nt, list) { | ||
| 3756 | qla4xxx_convert_param_ddb(&nt_ddb_idx->fw_ddb, tmp_tddb); | ||
| 3757 | if (!qla4xxx_compare_tuple_ddb(ha, fw_tddb, tmp_tddb)) { | ||
| 3758 | ret = QLA_SUCCESS; /* found */ | ||
| 3759 | goto exit_check; | ||
| 3760 | } | ||
| 3761 | } | ||
| 3762 | |||
| 3763 | exit_check: | ||
| 3764 | if (fw_tddb) | ||
| 3765 | vfree(fw_tddb); | ||
| 3766 | if (tmp_tddb) | ||
| 3767 | vfree(tmp_tddb); | ||
| 3768 | return ret; | ||
| 3769 | } | ||
| 3770 | |||
| 3771 | static void qla4xxx_free_nt_list(struct list_head *list_nt) | ||
| 3772 | { | ||
| 3773 | struct qla_ddb_index *nt_ddb_idx, *nt_ddb_idx_tmp; | ||
| 3774 | |||
| 3775 | /* Free up the normaltargets list */ | ||
| 3776 | list_for_each_entry_safe(nt_ddb_idx, nt_ddb_idx_tmp, list_nt, list) { | ||
| 3777 | list_del_init(&nt_ddb_idx->list); | ||
| 3778 | vfree(nt_ddb_idx); | ||
| 3779 | } | ||
| 3780 | |||
| 3781 | } | ||
| 3782 | |||
| 3783 | static struct iscsi_endpoint *qla4xxx_get_ep_fwdb(struct scsi_qla_host *ha, | ||
| 3784 | struct dev_db_entry *fw_ddb_entry) | ||
| 3785 | { | ||
| 3786 | struct iscsi_endpoint *ep; | ||
| 3787 | struct sockaddr_in *addr; | ||
| 3788 | struct sockaddr_in6 *addr6; | ||
| 3789 | struct sockaddr *dst_addr; | ||
| 3790 | char *ip; | ||
| 3791 | |||
| 3792 | /* TODO: need to destroy on unload iscsi_endpoint*/ | ||
| 3793 | dst_addr = vmalloc(sizeof(*dst_addr)); | ||
| 3794 | if (!dst_addr) | ||
| 3795 | return NULL; | ||
| 3796 | |||
| 3797 | if (fw_ddb_entry->options & DDB_OPT_IPV6_DEVICE) { | ||
| 3798 | dst_addr->sa_family = AF_INET6; | ||
| 3799 | addr6 = (struct sockaddr_in6 *)dst_addr; | ||
| 3800 | ip = (char *)&addr6->sin6_addr; | ||
| 3801 | memcpy(ip, fw_ddb_entry->ip_addr, IPv6_ADDR_LEN); | ||
| 3802 | addr6->sin6_port = htons(le16_to_cpu(fw_ddb_entry->port)); | ||
| 3803 | |||
| 3804 | } else { | ||
| 3805 | dst_addr->sa_family = AF_INET; | ||
| 3806 | addr = (struct sockaddr_in *)dst_addr; | ||
| 3807 | ip = (char *)&addr->sin_addr; | ||
| 3808 | memcpy(ip, fw_ddb_entry->ip_addr, IP_ADDR_LEN); | ||
| 3809 | addr->sin_port = htons(le16_to_cpu(fw_ddb_entry->port)); | ||
| 3810 | } | ||
| 3811 | |||
| 3812 | ep = qla4xxx_ep_connect(ha->host, dst_addr, 0); | ||
| 3813 | vfree(dst_addr); | ||
| 3814 | return ep; | ||
| 3815 | } | ||
| 3816 | |||
| 3817 | static int qla4xxx_verify_boot_idx(struct scsi_qla_host *ha, uint16_t idx) | ||
| 3818 | { | ||
| 3819 | if (ql4xdisablesysfsboot) | ||
| 3820 | return QLA_SUCCESS; | ||
| 3821 | if (idx == ha->pri_ddb_idx || idx == ha->sec_ddb_idx) | ||
| 3822 | return QLA_ERROR; | ||
| 3823 | return QLA_SUCCESS; | ||
| 3824 | } | ||
| 3825 | |||
| 3826 | static void qla4xxx_setup_flash_ddb_entry(struct scsi_qla_host *ha, | ||
| 3827 | struct ddb_entry *ddb_entry) | ||
| 3828 | { | ||
| 3829 | ddb_entry->ddb_type = FLASH_DDB; | ||
| 3830 | ddb_entry->fw_ddb_index = INVALID_ENTRY; | ||
| 3831 | ddb_entry->fw_ddb_device_state = DDB_DS_NO_CONNECTION_ACTIVE; | ||
| 3832 | ddb_entry->ha = ha; | ||
| 3833 | ddb_entry->unblock_sess = qla4xxx_unblock_flash_ddb; | ||
| 3834 | ddb_entry->ddb_change = qla4xxx_flash_ddb_change; | ||
| 3835 | |||
| 3836 | atomic_set(&ddb_entry->retry_relogin_timer, INVALID_ENTRY); | ||
| 3837 | atomic_set(&ddb_entry->relogin_timer, 0); | ||
| 3838 | atomic_set(&ddb_entry->relogin_retry_count, 0); | ||
| 3839 | |||
| 3840 | ddb_entry->default_relogin_timeout = | ||
| 3841 | le16_to_cpu(ddb_entry->fw_ddb_entry.def_timeout); | ||
| 3842 | ddb_entry->default_time2wait = | ||
| 3843 | le16_to_cpu(ddb_entry->fw_ddb_entry.iscsi_def_time2wait); | ||
| 3844 | } | ||
| 3845 | |||
| 3846 | static void qla4xxx_wait_for_ip_configuration(struct scsi_qla_host *ha) | ||
| 3847 | { | ||
| 3848 | uint32_t idx = 0; | ||
| 3849 | uint32_t ip_idx[IP_ADDR_COUNT] = {0, 1, 2, 3}; /* 4 IP interfaces */ | ||
| 3850 | uint32_t sts[MBOX_REG_COUNT]; | ||
| 3851 | uint32_t ip_state; | ||
| 3852 | unsigned long wtime; | ||
| 3853 | int ret; | ||
| 3854 | |||
| 3855 | wtime = jiffies + (HZ * IP_CONFIG_TOV); | ||
| 3856 | do { | ||
| 3857 | for (idx = 0; idx < IP_ADDR_COUNT; idx++) { | ||
| 3858 | if (ip_idx[idx] == -1) | ||
| 3859 | continue; | ||
| 3860 | |||
| 3861 | ret = qla4xxx_get_ip_state(ha, 0, ip_idx[idx], sts); | ||
| 3862 | |||
| 3863 | if (ret == QLA_ERROR) { | ||
| 3864 | ip_idx[idx] = -1; | ||
| 3865 | continue; | ||
| 3866 | } | ||
| 3867 | |||
| 3868 | ip_state = (sts[1] & IP_STATE_MASK) >> IP_STATE_SHIFT; | ||
| 3869 | |||
| 3870 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 3871 | "Waiting for IP state for idx = %d, state = 0x%x\n", | ||
| 3872 | ip_idx[idx], ip_state)); | ||
| 3873 | if (ip_state == IP_ADDRSTATE_UNCONFIGURED || | ||
| 3874 | ip_state == IP_ADDRSTATE_INVALID || | ||
| 3875 | ip_state == IP_ADDRSTATE_PREFERRED || | ||
| 3876 | ip_state == IP_ADDRSTATE_DEPRICATED || | ||
| 3877 | ip_state == IP_ADDRSTATE_DISABLING) | ||
| 3878 | ip_idx[idx] = -1; | ||
| 3879 | |||
| 3880 | } | ||
| 3881 | |||
| 3882 | /* Break if all IP states checked */ | ||
| 3883 | if ((ip_idx[0] == -1) && | ||
| 3884 | (ip_idx[1] == -1) && | ||
| 3885 | (ip_idx[2] == -1) && | ||
| 3886 | (ip_idx[3] == -1)) | ||
| 3887 | break; | ||
| 3888 | schedule_timeout_uninterruptible(HZ); | ||
| 3889 | } while (time_after(wtime, jiffies)); | ||
| 3890 | } | ||
| 3891 | |||
| 3892 | void qla4xxx_build_ddb_list(struct scsi_qla_host *ha, int is_reset) | ||
| 3893 | { | ||
| 3894 | int max_ddbs; | ||
| 3895 | int ret; | ||
| 3896 | uint32_t idx = 0, next_idx = 0; | ||
| 3897 | uint32_t state = 0, conn_err = 0; | ||
| 3898 | uint16_t conn_id; | ||
| 3899 | struct dev_db_entry *fw_ddb_entry; | ||
| 3900 | struct ddb_entry *ddb_entry = NULL; | ||
| 3901 | dma_addr_t fw_ddb_dma; | ||
| 3902 | struct iscsi_cls_session *cls_sess; | ||
| 3903 | struct iscsi_session *sess; | ||
| 3904 | struct iscsi_cls_conn *cls_conn; | ||
| 3905 | struct iscsi_endpoint *ep; | ||
| 3906 | uint16_t cmds_max = 32, tmo = 0; | ||
| 3907 | uint32_t initial_cmdsn = 0; | ||
| 3908 | struct list_head list_st, list_nt; /* List of sendtargets */ | ||
| 3909 | struct qla_ddb_index *st_ddb_idx, *st_ddb_idx_tmp; | ||
| 3910 | int fw_idx_size; | ||
| 3911 | unsigned long wtime; | ||
| 3912 | struct qla_ddb_index *nt_ddb_idx; | ||
| 3913 | |||
| 3914 | if (!test_bit(AF_LINK_UP, &ha->flags)) { | ||
| 3915 | set_bit(AF_BUILD_DDB_LIST, &ha->flags); | ||
| 3916 | ha->is_reset = is_reset; | ||
| 3917 | return; | ||
| 3918 | } | ||
| 3919 | max_ddbs = is_qla40XX(ha) ? MAX_DEV_DB_ENTRIES_40XX : | ||
| 3920 | MAX_DEV_DB_ENTRIES; | ||
| 3921 | |||
| 3922 | fw_ddb_entry = dma_pool_alloc(ha->fw_ddb_dma_pool, GFP_KERNEL, | ||
| 3923 | &fw_ddb_dma); | ||
| 3924 | if (fw_ddb_entry == NULL) { | ||
| 3925 | DEBUG2(ql4_printk(KERN_ERR, ha, "Out of memory\n")); | ||
| 3926 | goto exit_ddb_list; | ||
| 3927 | } | ||
| 3928 | |||
| 3929 | INIT_LIST_HEAD(&list_st); | ||
| 3930 | INIT_LIST_HEAD(&list_nt); | ||
| 3931 | fw_idx_size = sizeof(struct qla_ddb_index); | ||
| 3932 | |||
| 3933 | for (idx = 0; idx < max_ddbs; idx = next_idx) { | ||
| 3934 | ret = qla4xxx_get_fwddb_entry(ha, idx, fw_ddb_entry, | ||
| 3935 | fw_ddb_dma, NULL, | ||
| 3936 | &next_idx, &state, &conn_err, | ||
| 3937 | NULL, &conn_id); | ||
| 3938 | if (ret == QLA_ERROR) | ||
| 3939 | break; | ||
| 3940 | |||
| 3941 | if (qla4xxx_verify_boot_idx(ha, idx) != QLA_SUCCESS) | ||
| 3942 | goto continue_next_st; | ||
| 3943 | |||
| 3944 | /* Check if ST, add to the list_st */ | ||
| 3945 | if (strlen((char *) fw_ddb_entry->iscsi_name) != 0) | ||
| 3946 | goto continue_next_st; | ||
| 3947 | |||
| 3948 | st_ddb_idx = vzalloc(fw_idx_size); | ||
| 3949 | if (!st_ddb_idx) | ||
| 3950 | break; | ||
| 3951 | |||
| 3952 | st_ddb_idx->fw_ddb_idx = idx; | ||
| 3953 | |||
| 3954 | list_add_tail(&st_ddb_idx->list, &list_st); | ||
| 3955 | continue_next_st: | ||
| 3956 | if (next_idx == 0) | ||
| 3957 | break; | ||
| 3958 | } | ||
| 3959 | |||
| 3960 | /* Before issuing conn open mbox, ensure all IPs states are configured | ||
| 3961 | * Note, conn open fails if IPs are not configured | ||
| 3962 | */ | ||
| 3963 | qla4xxx_wait_for_ip_configuration(ha); | ||
| 3964 | |||
| 3965 | /* Go thru the STs and fire the sendtargets by issuing conn open mbx */ | ||
| 3966 | list_for_each_entry_safe(st_ddb_idx, st_ddb_idx_tmp, &list_st, list) { | ||
| 3967 | qla4xxx_conn_open(ha, st_ddb_idx->fw_ddb_idx); | ||
| 3968 | } | ||
| 3969 | |||
| 3970 | /* Wait to ensure all sendtargets are done for min 12 sec wait */ | ||
| 3971 | tmo = ((ha->def_timeout < LOGIN_TOV) ? LOGIN_TOV : ha->def_timeout); | ||
| 3972 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 3973 | "Default time to wait for build ddb %d\n", tmo)); | ||
| 3974 | |||
| 3975 | wtime = jiffies + (HZ * tmo); | ||
| 3976 | do { | ||
| 3977 | list_for_each_entry_safe(st_ddb_idx, st_ddb_idx_tmp, &list_st, | ||
| 3978 | list) { | ||
| 3979 | ret = qla4xxx_get_fwddb_entry(ha, | ||
| 3980 | st_ddb_idx->fw_ddb_idx, | ||
| 3981 | NULL, 0, NULL, &next_idx, | ||
| 3982 | &state, &conn_err, NULL, | ||
| 3983 | NULL); | ||
| 3984 | if (ret == QLA_ERROR) | ||
| 3985 | continue; | ||
| 3986 | |||
| 3987 | if (state == DDB_DS_NO_CONNECTION_ACTIVE || | ||
| 3988 | state == DDB_DS_SESSION_FAILED) { | ||
| 3989 | list_del_init(&st_ddb_idx->list); | ||
| 3990 | vfree(st_ddb_idx); | ||
| 3991 | } | ||
| 3992 | } | ||
| 3993 | schedule_timeout_uninterruptible(HZ / 10); | ||
| 3994 | } while (time_after(wtime, jiffies)); | ||
| 3995 | |||
| 3996 | /* Free up the sendtargets list */ | ||
| 3997 | list_for_each_entry_safe(st_ddb_idx, st_ddb_idx_tmp, &list_st, list) { | ||
| 3998 | list_del_init(&st_ddb_idx->list); | ||
| 3999 | vfree(st_ddb_idx); | ||
| 4000 | } | ||
| 4001 | |||
| 4002 | for (idx = 0; idx < max_ddbs; idx = next_idx) { | ||
| 4003 | ret = qla4xxx_get_fwddb_entry(ha, idx, fw_ddb_entry, | ||
| 4004 | fw_ddb_dma, NULL, | ||
| 4005 | &next_idx, &state, &conn_err, | ||
| 4006 | NULL, &conn_id); | ||
| 4007 | if (ret == QLA_ERROR) | ||
| 4008 | break; | ||
| 4009 | |||
| 4010 | if (qla4xxx_verify_boot_idx(ha, idx) != QLA_SUCCESS) | ||
| 4011 | goto continue_next_nt; | ||
| 4012 | |||
| 4013 | /* Check if NT, then add to list it */ | ||
| 4014 | if (strlen((char *) fw_ddb_entry->iscsi_name) == 0) | ||
| 4015 | goto continue_next_nt; | ||
| 4016 | |||
| 4017 | if (state == DDB_DS_NO_CONNECTION_ACTIVE || | ||
| 4018 | state == DDB_DS_SESSION_FAILED) { | ||
| 4019 | DEBUG2(ql4_printk(KERN_INFO, ha, | ||
| 4020 | "Adding DDB to session = 0x%x\n", | ||
| 4021 | idx)); | ||
| 4022 | if (is_reset == INIT_ADAPTER) { | ||
| 4023 | nt_ddb_idx = vmalloc(fw_idx_size); | ||
| 4024 | if (!nt_ddb_idx) | ||
| 4025 | break; | ||
| 4026 | |||
| 4027 | nt_ddb_idx->fw_ddb_idx = idx; | ||
| 4028 | |||
| 4029 | memcpy(&nt_ddb_idx->fw_ddb, fw_ddb_entry, | ||
| 4030 | sizeof(struct dev_db_entry)); | ||
| 4031 | |||
| 4032 | if (qla4xxx_is_flash_ddb_exists(ha, &list_nt, | ||
| 4033 | fw_ddb_entry) == QLA_SUCCESS) { | ||
| 4034 | vfree(nt_ddb_idx); | ||
| 4035 | goto continue_next_nt; | ||
| 4036 | } | ||
| 4037 | list_add_tail(&nt_ddb_idx->list, &list_nt); | ||
| 4038 | } else if (is_reset == RESET_ADAPTER) { | ||
| 4039 | if (qla4xxx_is_session_exists(ha, | ||
| 4040 | fw_ddb_entry) == QLA_SUCCESS) | ||
| 4041 | goto continue_next_nt; | ||
| 4042 | } | ||
| 4043 | |||
| 4044 | /* Create session object, with INVALID_ENTRY, | ||
| 4045 | * the targer_id would get set when we issue the login | ||
| 4046 | */ | ||
| 4047 | cls_sess = iscsi_session_setup(&qla4xxx_iscsi_transport, | ||
| 4048 | ha->host, cmds_max, | ||
| 4049 | sizeof(struct ddb_entry), | ||
| 4050 | sizeof(struct ql4_task_data), | ||
| 4051 | initial_cmdsn, INVALID_ENTRY); | ||
| 4052 | if (!cls_sess) | ||
| 4053 | goto exit_ddb_list; | ||
| 4054 | |||
| 4055 | /* | ||
| 4056 | * iscsi_session_setup increments the driver reference | ||
| 4057 | * count which wouldn't let the driver to be unloaded. | ||
| 4058 | * so calling module_put function to decrement the | ||
| 4059 | * reference count. | ||
| 4060 | **/ | ||
| 4061 | module_put(qla4xxx_iscsi_transport.owner); | ||
| 4062 | sess = cls_sess->dd_data; | ||
| 4063 | ddb_entry = sess->dd_data; | ||
| 4064 | ddb_entry->sess = cls_sess; | ||
| 4065 | |||
| 4066 | cls_sess->recovery_tmo = ql4xsess_recovery_tmo; | ||
| 4067 | memcpy(&ddb_entry->fw_ddb_entry, fw_ddb_entry, | ||
| 4068 | sizeof(struct dev_db_entry)); | ||
| 4069 | |||
| 4070 | qla4xxx_setup_flash_ddb_entry(ha, ddb_entry); | ||
| 4071 | |||
| 4072 | cls_conn = iscsi_conn_setup(cls_sess, | ||
| 4073 | sizeof(struct qla_conn), | ||
| 4074 | conn_id); | ||
| 4075 | if (!cls_conn) | ||
| 4076 | goto exit_ddb_list; | ||
| 4077 | |||
| 4078 | ddb_entry->conn = cls_conn; | ||
| 4079 | |||
| 4080 | /* Setup ep, for displaying attributes in sysfs */ | ||
| 4081 | ep = qla4xxx_get_ep_fwdb(ha, fw_ddb_entry); | ||
| 4082 | if (ep) { | ||
| 4083 | ep->conn = cls_conn; | ||
| 4084 | cls_conn->ep = ep; | ||
| 4085 | } else { | ||
| 4086 | DEBUG2(ql4_printk(KERN_ERR, ha, | ||
| 4087 | "Unable to get ep\n")); | ||
| 4088 | } | ||
| 4089 | |||
| 4090 | /* Update sess/conn params */ | ||
| 4091 | qla4xxx_copy_fwddb_param(ha, fw_ddb_entry, cls_sess, | ||
| 4092 | cls_conn); | ||
| 4093 | |||
| 4094 | if (is_reset == RESET_ADAPTER) { | ||
| 4095 | iscsi_block_session(cls_sess); | ||
| 4096 | /* Use the relogin path to discover new devices | ||
| 4097 | * by short-circuting the logic of setting | ||
| 4098 | * timer to relogin - instead set the flags | ||
| 4099 | * to initiate login right away. | ||
| 4100 | */ | ||
| 4101 | set_bit(DPC_RELOGIN_DEVICE, &ha->dpc_flags); | ||
| 4102 | set_bit(DF_RELOGIN, &ddb_entry->flags); | ||
| 4103 | } | ||
| 4104 | } | ||
| 4105 | continue_next_nt: | ||
| 4106 | if (next_idx == 0) | ||
| 4107 | break; | ||
| 4108 | } | ||
| 4109 | exit_ddb_list: | ||
| 4110 | qla4xxx_free_nt_list(&list_nt); | ||
| 4111 | if (fw_ddb_entry) | ||
| 4112 | dma_pool_free(ha->fw_ddb_dma_pool, fw_ddb_entry, fw_ddb_dma); | ||
| 4113 | |||
| 4114 | qla4xxx_free_ddb_index(ha); | ||
| 4115 | } | ||
| 4116 | |||
| 4117 | |||
| 3180 | /** | 4118 | /** |
| 3181 | * qla4xxx_probe_adapter - callback function to probe HBA | 4119 | * qla4xxx_probe_adapter - callback function to probe HBA |
| 3182 | * @pdev: pointer to pci_dev structure | 4120 | * @pdev: pointer to pci_dev structure |
| @@ -3298,7 +4236,7 @@ static int __devinit qla4xxx_probe_adapter(struct pci_dev *pdev, | |||
| 3298 | * firmware | 4236 | * firmware |
| 3299 | * NOTE: interrupts enabled upon successful completion | 4237 | * NOTE: interrupts enabled upon successful completion |
| 3300 | */ | 4238 | */ |
| 3301 | status = qla4xxx_initialize_adapter(ha); | 4239 | status = qla4xxx_initialize_adapter(ha, INIT_ADAPTER); |
| 3302 | while ((!test_bit(AF_ONLINE, &ha->flags)) && | 4240 | while ((!test_bit(AF_ONLINE, &ha->flags)) && |
| 3303 | init_retry_count++ < MAX_INIT_RETRIES) { | 4241 | init_retry_count++ < MAX_INIT_RETRIES) { |
| 3304 | 4242 | ||
| @@ -3319,7 +4257,7 @@ static int __devinit qla4xxx_probe_adapter(struct pci_dev *pdev, | |||
| 3319 | if (ha->isp_ops->reset_chip(ha) == QLA_ERROR) | 4257 | if (ha->isp_ops->reset_chip(ha) == QLA_ERROR) |
| 3320 | continue; | 4258 | continue; |
| 3321 | 4259 | ||
| 3322 | status = qla4xxx_initialize_adapter(ha); | 4260 | status = qla4xxx_initialize_adapter(ha, INIT_ADAPTER); |
| 3323 | } | 4261 | } |
| 3324 | 4262 | ||
| 3325 | if (!test_bit(AF_ONLINE, &ha->flags)) { | 4263 | if (!test_bit(AF_ONLINE, &ha->flags)) { |
| @@ -3386,12 +4324,16 @@ static int __devinit qla4xxx_probe_adapter(struct pci_dev *pdev, | |||
| 3386 | ha->host_no, ha->firmware_version[0], ha->firmware_version[1], | 4324 | ha->host_no, ha->firmware_version[0], ha->firmware_version[1], |
| 3387 | ha->patch_number, ha->build_number); | 4325 | ha->patch_number, ha->build_number); |
| 3388 | 4326 | ||
| 3389 | qla4xxx_create_chap_list(ha); | ||
| 3390 | |||
| 3391 | if (qla4xxx_setup_boot_info(ha)) | 4327 | if (qla4xxx_setup_boot_info(ha)) |
| 3392 | ql4_printk(KERN_ERR, ha, "%s:ISCSI boot info setup failed\n", | 4328 | ql4_printk(KERN_ERR, ha, "%s:ISCSI boot info setup failed\n", |
| 3393 | __func__); | 4329 | __func__); |
| 3394 | 4330 | ||
| 4331 | /* Perform the build ddb list and login to each */ | ||
| 4332 | qla4xxx_build_ddb_list(ha, INIT_ADAPTER); | ||
| 4333 | iscsi_host_for_each_session(ha->host, qla4xxx_login_flash_ddb); | ||
| 4334 | |||
| 4335 | qla4xxx_create_chap_list(ha); | ||
| 4336 | |||
| 3395 | qla4xxx_create_ifaces(ha); | 4337 | qla4xxx_create_ifaces(ha); |
| 3396 | return 0; | 4338 | return 0; |
| 3397 | 4339 | ||
| @@ -3449,6 +4391,38 @@ static void qla4xxx_prevent_other_port_reinit(struct scsi_qla_host *ha) | |||
| 3449 | } | 4391 | } |
| 3450 | } | 4392 | } |
| 3451 | 4393 | ||
| 4394 | static void qla4xxx_destroy_fw_ddb_session(struct scsi_qla_host *ha) | ||
| 4395 | { | ||
| 4396 | struct ddb_entry *ddb_entry; | ||
| 4397 | int options; | ||
| 4398 | int idx; | ||
| 4399 | |||
| 4400 | for (idx = 0; idx < MAX_DDB_ENTRIES; idx++) { | ||
| 4401 | |||
| 4402 | ddb_entry = qla4xxx_lookup_ddb_by_fw_index(ha, idx); | ||
| 4403 | if ((ddb_entry != NULL) && | ||
| 4404 | (ddb_entry->ddb_type == FLASH_DDB)) { | ||
| 4405 | |||
| 4406 | options = LOGOUT_OPTION_CLOSE_SESSION; | ||
| 4407 | if (qla4xxx_session_logout_ddb(ha, ddb_entry, options) | ||
| 4408 | == QLA_ERROR) | ||
| 4409 | ql4_printk(KERN_ERR, ha, "%s: Logout failed\n", | ||
| 4410 | __func__); | ||
| 4411 | |||
| 4412 | qla4xxx_clear_ddb_entry(ha, ddb_entry->fw_ddb_index); | ||
| 4413 | /* | ||
| 4414 | * we have decremented the reference count of the driver | ||
| 4415 | * when we setup the session to have the driver unload | ||
| 4416 | * to be seamless without actually destroying the | ||
| 4417 | * session | ||
| 4418 | **/ | ||
| 4419 | try_module_get(qla4xxx_iscsi_transport.owner); | ||
| 4420 | iscsi_destroy_endpoint(ddb_entry->conn->ep); | ||
| 4421 | qla4xxx_free_ddb(ha, ddb_entry); | ||
| 4422 | iscsi_session_teardown(ddb_entry->sess); | ||
| 4423 | } | ||
| 4424 | } | ||
| 4425 | } | ||
| 3452 | /** | 4426 | /** |
| 3453 | * qla4xxx_remove_adapter - calback function to remove adapter. | 4427 | * qla4xxx_remove_adapter - calback function to remove adapter. |
| 3454 | * @pci_dev: PCI device pointer | 4428 | * @pci_dev: PCI device pointer |
| @@ -3465,9 +4439,11 @@ static void __devexit qla4xxx_remove_adapter(struct pci_dev *pdev) | |||
| 3465 | /* destroy iface from sysfs */ | 4439 | /* destroy iface from sysfs */ |
| 3466 | qla4xxx_destroy_ifaces(ha); | 4440 | qla4xxx_destroy_ifaces(ha); |
| 3467 | 4441 | ||
| 3468 | if (ha->boot_kset) | 4442 | if ((!ql4xdisablesysfsboot) && ha->boot_kset) |
| 3469 | iscsi_boot_destroy_kset(ha->boot_kset); | 4443 | iscsi_boot_destroy_kset(ha->boot_kset); |
| 3470 | 4444 | ||
| 4445 | qla4xxx_destroy_fw_ddb_session(ha); | ||
| 4446 | |||
| 3471 | scsi_remove_host(ha->host); | 4447 | scsi_remove_host(ha->host); |
| 3472 | 4448 | ||
| 3473 | qla4xxx_free_adapter(ha); | 4449 | qla4xxx_free_adapter(ha); |
| @@ -4115,7 +5091,7 @@ static uint32_t qla4_8xxx_error_recovery(struct scsi_qla_host *ha) | |||
| 4115 | 5091 | ||
| 4116 | qla4_8xxx_idc_unlock(ha); | 5092 | qla4_8xxx_idc_unlock(ha); |
| 4117 | clear_bit(AF_FW_RECOVERY, &ha->flags); | 5093 | clear_bit(AF_FW_RECOVERY, &ha->flags); |
| 4118 | rval = qla4xxx_initialize_adapter(ha); | 5094 | rval = qla4xxx_initialize_adapter(ha, RESET_ADAPTER); |
| 4119 | qla4_8xxx_idc_lock(ha); | 5095 | qla4_8xxx_idc_lock(ha); |
| 4120 | 5096 | ||
| 4121 | if (rval != QLA_SUCCESS) { | 5097 | if (rval != QLA_SUCCESS) { |
| @@ -4151,7 +5127,7 @@ static uint32_t qla4_8xxx_error_recovery(struct scsi_qla_host *ha) | |||
| 4151 | if ((qla4_8xxx_rd_32(ha, QLA82XX_CRB_DEV_STATE) == | 5127 | if ((qla4_8xxx_rd_32(ha, QLA82XX_CRB_DEV_STATE) == |
| 4152 | QLA82XX_DEV_READY)) { | 5128 | QLA82XX_DEV_READY)) { |
| 4153 | clear_bit(AF_FW_RECOVERY, &ha->flags); | 5129 | clear_bit(AF_FW_RECOVERY, &ha->flags); |
| 4154 | rval = qla4xxx_initialize_adapter(ha); | 5130 | rval = qla4xxx_initialize_adapter(ha, RESET_ADAPTER); |
| 4155 | if (rval == QLA_SUCCESS) { | 5131 | if (rval == QLA_SUCCESS) { |
| 4156 | ret = qla4xxx_request_irqs(ha); | 5132 | ret = qla4xxx_request_irqs(ha); |
| 4157 | if (ret) { | 5133 | if (ret) { |
diff --git a/drivers/scsi/qla4xxx/ql4_version.h b/drivers/scsi/qla4xxx/ql4_version.h index c15347d3f532..5254e57968f5 100644 --- a/drivers/scsi/qla4xxx/ql4_version.h +++ b/drivers/scsi/qla4xxx/ql4_version.h | |||
| @@ -5,4 +5,4 @@ | |||
| 5 | * See LICENSE.qla4xxx for copyright and licensing details. | 5 | * See LICENSE.qla4xxx for copyright and licensing details. |
| 6 | */ | 6 | */ |
| 7 | 7 | ||
| 8 | #define QLA4XXX_DRIVER_VERSION "5.02.00-k8" | 8 | #define QLA4XXX_DRIVER_VERSION "5.02.00-k9" |
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index a1fd73df5416..8ba4510a9519 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig | |||
| @@ -199,7 +199,7 @@ config SPI_FSL_LIB | |||
| 199 | depends on FSL_SOC | 199 | depends on FSL_SOC |
| 200 | 200 | ||
| 201 | config SPI_FSL_SPI | 201 | config SPI_FSL_SPI |
| 202 | tristate "Freescale SPI controller" | 202 | bool "Freescale SPI controller" |
| 203 | depends on FSL_SOC | 203 | depends on FSL_SOC |
| 204 | select SPI_FSL_LIB | 204 | select SPI_FSL_LIB |
| 205 | help | 205 | help |
| @@ -208,7 +208,7 @@ config SPI_FSL_SPI | |||
| 208 | MPC8569 uses the controller in QE mode, MPC8610 in cpu mode. | 208 | MPC8569 uses the controller in QE mode, MPC8610 in cpu mode. |
| 209 | 209 | ||
| 210 | config SPI_FSL_ESPI | 210 | config SPI_FSL_ESPI |
| 211 | tristate "Freescale eSPI controller" | 211 | bool "Freescale eSPI controller" |
| 212 | depends on FSL_SOC | 212 | depends on FSL_SOC |
| 213 | select SPI_FSL_LIB | 213 | select SPI_FSL_LIB |
| 214 | help | 214 | help |
diff --git a/drivers/spi/spi-ath79.c b/drivers/spi/spi-ath79.c index 024b48aed5ca..acc88b4d2869 100644 --- a/drivers/spi/spi-ath79.c +++ b/drivers/spi/spi-ath79.c | |||
| @@ -13,6 +13,7 @@ | |||
| 13 | */ | 13 | */ |
| 14 | 14 | ||
| 15 | #include <linux/kernel.h> | 15 | #include <linux/kernel.h> |
| 16 | #include <linux/module.h> | ||
| 16 | #include <linux/init.h> | 17 | #include <linux/init.h> |
| 17 | #include <linux/delay.h> | 18 | #include <linux/delay.h> |
| 18 | #include <linux/spinlock.h> | 19 | #include <linux/spinlock.h> |
diff --git a/drivers/spi/spi-gpio.c b/drivers/spi/spi-gpio.c index e093d3ec41ba..0094c645ff0d 100644 --- a/drivers/spi/spi-gpio.c +++ b/drivers/spi/spi-gpio.c | |||
| @@ -256,7 +256,7 @@ static void spi_gpio_cleanup(struct spi_device *spi) | |||
| 256 | spi_bitbang_cleanup(spi); | 256 | spi_bitbang_cleanup(spi); |
| 257 | } | 257 | } |
| 258 | 258 | ||
| 259 | static int __init spi_gpio_alloc(unsigned pin, const char *label, bool is_in) | 259 | static int __devinit spi_gpio_alloc(unsigned pin, const char *label, bool is_in) |
| 260 | { | 260 | { |
| 261 | int value; | 261 | int value; |
| 262 | 262 | ||
| @@ -270,7 +270,7 @@ static int __init spi_gpio_alloc(unsigned pin, const char *label, bool is_in) | |||
| 270 | return value; | 270 | return value; |
| 271 | } | 271 | } |
| 272 | 272 | ||
| 273 | static int __init | 273 | static int __devinit |
| 274 | spi_gpio_request(struct spi_gpio_platform_data *pdata, const char *label, | 274 | spi_gpio_request(struct spi_gpio_platform_data *pdata, const char *label, |
| 275 | u16 *res_flags) | 275 | u16 *res_flags) |
| 276 | { | 276 | { |
diff --git a/drivers/spi/spi-nuc900.c b/drivers/spi/spi-nuc900.c index e763254741c2..182e9c873822 100644 --- a/drivers/spi/spi-nuc900.c +++ b/drivers/spi/spi-nuc900.c | |||
| @@ -8,6 +8,7 @@ | |||
| 8 | * | 8 | * |
| 9 | */ | 9 | */ |
| 10 | 10 | ||
| 11 | #include <linux/module.h> | ||
| 11 | #include <linux/init.h> | 12 | #include <linux/init.h> |
| 12 | #include <linux/spinlock.h> | 13 | #include <linux/spinlock.h> |
| 13 | #include <linux/workqueue.h> | 14 | #include <linux/workqueue.h> |
| @@ -426,7 +427,7 @@ static int __devinit nuc900_spi_probe(struct platform_device *pdev) | |||
| 426 | goto err_clk; | 427 | goto err_clk; |
| 427 | } | 428 | } |
| 428 | 429 | ||
| 429 | mfp_set_groupg(&pdev->dev); | 430 | mfp_set_groupg(&pdev->dev, NULL); |
| 430 | nuc900_init_spi(hw); | 431 | nuc900_init_spi(hw); |
| 431 | 432 | ||
| 432 | err = spi_bitbang_start(&hw->bitbang); | 433 | err = spi_bitbang_start(&hw->bitbang); |
diff --git a/drivers/ssb/driver_pcicore.c b/drivers/ssb/driver_pcicore.c index 84c934c0a545..520e8286db28 100644 --- a/drivers/ssb/driver_pcicore.c +++ b/drivers/ssb/driver_pcicore.c | |||
| @@ -517,10 +517,14 @@ static void ssb_pcicore_pcie_setup_workarounds(struct ssb_pcicore *pc) | |||
| 517 | 517 | ||
| 518 | static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore *pc) | 518 | static void __devinit ssb_pcicore_init_clientmode(struct ssb_pcicore *pc) |
| 519 | { | 519 | { |
| 520 | ssb_pcicore_fix_sprom_core_index(pc); | 520 | struct ssb_device *pdev = pc->dev; |
| 521 | struct ssb_bus *bus = pdev->bus; | ||
| 522 | |||
| 523 | if (bus->bustype == SSB_BUSTYPE_PCI) | ||
| 524 | ssb_pcicore_fix_sprom_core_index(pc); | ||
| 521 | 525 | ||
| 522 | /* Disable PCI interrupts. */ | 526 | /* Disable PCI interrupts. */ |
| 523 | ssb_write32(pc->dev, SSB_INTVEC, 0); | 527 | ssb_write32(pdev, SSB_INTVEC, 0); |
| 524 | 528 | ||
| 525 | /* Additional PCIe always once-executed workarounds */ | 529 | /* Additional PCIe always once-executed workarounds */ |
| 526 | if (pc->dev->id.coreid == SSB_DEV_PCIE) { | 530 | if (pc->dev->id.coreid == SSB_DEV_PCIE) { |
diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 21d8c1c16cd8..5e78c77d5a08 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c | |||
| @@ -671,7 +671,7 @@ static int do_insnlist_ioctl(struct comedi_device *dev, | |||
| 671 | } | 671 | } |
| 672 | 672 | ||
| 673 | insns = | 673 | insns = |
| 674 | kmalloc(sizeof(struct comedi_insn) * insnlist.n_insns, GFP_KERNEL); | 674 | kcalloc(insnlist.n_insns, sizeof(struct comedi_insn), GFP_KERNEL); |
| 675 | if (!insns) { | 675 | if (!insns) { |
| 676 | DPRINTK("kmalloc failed\n"); | 676 | DPRINTK("kmalloc failed\n"); |
| 677 | ret = -ENOMEM; | 677 | ret = -ENOMEM; |
| @@ -1432,7 +1432,21 @@ static int do_cancel(struct comedi_device *dev, struct comedi_subdevice *s) | |||
| 1432 | return ret; | 1432 | return ret; |
| 1433 | } | 1433 | } |
| 1434 | 1434 | ||
| 1435 | static void comedi_unmap(struct vm_area_struct *area) | 1435 | |
| 1436 | static void comedi_vm_open(struct vm_area_struct *area) | ||
| 1437 | { | ||
| 1438 | struct comedi_async *async; | ||
| 1439 | struct comedi_device *dev; | ||
| 1440 | |||
| 1441 | async = area->vm_private_data; | ||
| 1442 | dev = async->subdevice->device; | ||
| 1443 | |||
| 1444 | mutex_lock(&dev->mutex); | ||
| 1445 | async->mmap_count++; | ||
| 1446 | mutex_unlock(&dev->mutex); | ||
| 1447 | } | ||
| 1448 | |||
| 1449 | static void comedi_vm_close(struct vm_area_struct *area) | ||
| 1436 | { | 1450 | { |
| 1437 | struct comedi_async *async; | 1451 | struct comedi_async *async; |
| 1438 | struct comedi_device *dev; | 1452 | struct comedi_device *dev; |
| @@ -1446,15 +1460,13 @@ static void comedi_unmap(struct vm_area_struct *area) | |||
| 1446 | } | 1460 | } |
| 1447 | 1461 | ||
| 1448 | static struct vm_operations_struct comedi_vm_ops = { | 1462 | static struct vm_operations_struct comedi_vm_ops = { |
| 1449 | .close = comedi_unmap, | 1463 | .open = comedi_vm_open, |
| 1464 | .close = comedi_vm_close, | ||
| 1450 | }; | 1465 | }; |
| 1451 | 1466 | ||
| 1452 | static int comedi_mmap(struct file *file, struct vm_area_struct *vma) | 1467 | static int comedi_mmap(struct file *file, struct vm_area_struct *vma) |
| 1453 | { | 1468 | { |
| 1454 | const unsigned minor = iminor(file->f_dentry->d_inode); | 1469 | const unsigned minor = iminor(file->f_dentry->d_inode); |
| 1455 | struct comedi_device_file_info *dev_file_info = | ||
| 1456 | comedi_get_device_file_info(minor); | ||
| 1457 | struct comedi_device *dev = dev_file_info->device; | ||
| 1458 | struct comedi_async *async = NULL; | 1470 | struct comedi_async *async = NULL; |
| 1459 | unsigned long start = vma->vm_start; | 1471 | unsigned long start = vma->vm_start; |
| 1460 | unsigned long size; | 1472 | unsigned long size; |
| @@ -1462,6 +1474,15 @@ static int comedi_mmap(struct file *file, struct vm_area_struct *vma) | |||
| 1462 | int i; | 1474 | int i; |
| 1463 | int retval; | 1475 | int retval; |
| 1464 | struct comedi_subdevice *s; | 1476 | struct comedi_subdevice *s; |
| 1477 | struct comedi_device_file_info *dev_file_info; | ||
| 1478 | struct comedi_device *dev; | ||
| 1479 | |||
| 1480 | dev_file_info = comedi_get_device_file_info(minor); | ||
| 1481 | if (dev_file_info == NULL) | ||
| 1482 | return -ENODEV; | ||
| 1483 | dev = dev_file_info->device; | ||
| 1484 | if (dev == NULL) | ||
| 1485 | return -ENODEV; | ||
| 1465 | 1486 | ||
| 1466 | mutex_lock(&dev->mutex); | 1487 | mutex_lock(&dev->mutex); |
| 1467 | if (!dev->attached) { | 1488 | if (!dev->attached) { |
| @@ -1528,11 +1549,17 @@ static unsigned int comedi_poll(struct file *file, poll_table * wait) | |||
| 1528 | { | 1549 | { |
| 1529 | unsigned int mask = 0; | 1550 | unsigned int mask = 0; |
| 1530 | const unsigned minor = iminor(file->f_dentry->d_inode); | 1551 | const unsigned minor = iminor(file->f_dentry->d_inode); |
| 1531 | struct comedi_device_file_info *dev_file_info = | ||
| 1532 | comedi_get_device_file_info(minor); | ||
| 1533 | struct comedi_device *dev = dev_file_info->device; | ||
| 1534 | struct comedi_subdevice *read_subdev; | 1552 | struct comedi_subdevice *read_subdev; |
| 1535 | struct comedi_subdevice *write_subdev; | 1553 | struct comedi_subdevice *write_subdev; |
| 1554 | struct comedi_device_file_info *dev_file_info; | ||
| 1555 | struct comedi_device *dev; | ||
| 1556 | dev_file_info = comedi_get_device_file_info(minor); | ||
| 1557 | |||
| 1558 | if (dev_file_info == NULL) | ||
| 1559 | return -ENODEV; | ||
| 1560 | dev = dev_file_info->device; | ||
| 1561 | if (dev == NULL) | ||
| 1562 | return -ENODEV; | ||
| 1536 | 1563 | ||
| 1537 | mutex_lock(&dev->mutex); | 1564 | mutex_lock(&dev->mutex); |
| 1538 | if (!dev->attached) { | 1565 | if (!dev->attached) { |
| @@ -1578,9 +1605,15 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, | |||
| 1578 | int n, m, count = 0, retval = 0; | 1605 | int n, m, count = 0, retval = 0; |
| 1579 | DECLARE_WAITQUEUE(wait, current); | 1606 | DECLARE_WAITQUEUE(wait, current); |
| 1580 | const unsigned minor = iminor(file->f_dentry->d_inode); | 1607 | const unsigned minor = iminor(file->f_dentry->d_inode); |
| 1581 | struct comedi_device_file_info *dev_file_info = | 1608 | struct comedi_device_file_info *dev_file_info; |
| 1582 | comedi_get_device_file_info(minor); | 1609 | struct comedi_device *dev; |
| 1583 | struct comedi_device *dev = dev_file_info->device; | 1610 | dev_file_info = comedi_get_device_file_info(minor); |
| 1611 | |||
| 1612 | if (dev_file_info == NULL) | ||
| 1613 | return -ENODEV; | ||
| 1614 | dev = dev_file_info->device; | ||
| 1615 | if (dev == NULL) | ||
| 1616 | return -ENODEV; | ||
| 1584 | 1617 | ||
| 1585 | if (!dev->attached) { | 1618 | if (!dev->attached) { |
| 1586 | DPRINTK("no driver configured on comedi%i\n", dev->minor); | 1619 | DPRINTK("no driver configured on comedi%i\n", dev->minor); |
| @@ -1640,11 +1673,11 @@ static ssize_t comedi_write(struct file *file, const char __user *buf, | |||
| 1640 | retval = -EAGAIN; | 1673 | retval = -EAGAIN; |
| 1641 | break; | 1674 | break; |
| 1642 | } | 1675 | } |
| 1676 | schedule(); | ||
| 1643 | if (signal_pending(current)) { | 1677 | if (signal_pending(current)) { |
| 1644 | retval = -ERESTARTSYS; | 1678 | retval = -ERESTARTSYS; |
| 1645 | break; | 1679 | break; |
| 1646 | } | 1680 | } |
| 1647 | schedule(); | ||
| 1648 | if (!s->busy) | 1681 | if (!s->busy) |
| 1649 | break; | 1682 | break; |
| 1650 | if (s->busy != file) { | 1683 | if (s->busy != file) { |
| @@ -1683,9 +1716,15 @@ static ssize_t comedi_read(struct file *file, char __user *buf, size_t nbytes, | |||
| 1683 | int n, m, count = 0, retval = 0; | 1716 | int n, m, count = 0, retval = 0; |
| 1684 | DECLARE_WAITQUEUE(wait, current); | 1717 | DECLARE_WAITQUEUE(wait, current); |
| 1685 | const unsigned minor = iminor(file->f_dentry->d_inode); | 1718 | const unsigned minor = iminor(file->f_dentry->d_inode); |
| 1686 | struct comedi_device_file_info *dev_file_info = | 1719 | struct comedi_device_file_info *dev_file_info; |
| 1687 | comedi_get_device_file_info(minor); | 1720 | struct comedi_device *dev; |
| 1688 | struct comedi_device *dev = dev_file_info->device; | 1721 | dev_file_info = comedi_get_device_file_info(minor); |
| 1722 | |||
| 1723 | if (dev_file_info == NULL) | ||
| 1724 | return -ENODEV; | ||
| 1725 | dev = dev_file_info->device; | ||
| 1726 | if (dev == NULL) | ||
| 1727 | return -ENODEV; | ||
| 1689 | 1728 | ||
| 1690 | if (!dev->attached) { | 1729 | if (!dev->attached) { |
| 1691 | DPRINTK("no driver configured on comedi%i\n", dev->minor); | 1730 | DPRINTK("no driver configured on comedi%i\n", dev->minor); |
| @@ -1741,11 +1780,11 @@ static ssize_t comedi_read(struct file *file, char __user *buf, size_t nbytes, | |||
| 1741 | retval = -EAGAIN; | 1780 | retval = -EAGAIN; |
| 1742 | break; | 1781 | break; |
| 1743 | } | 1782 | } |
| 1783 | schedule(); | ||
| 1744 | if (signal_pending(current)) { | 1784 | if (signal_pending(current)) { |
| 1745 | retval = -ERESTARTSYS; | 1785 | retval = -ERESTARTSYS; |
| 1746 | break; | 1786 | break; |
| 1747 | } | 1787 | } |
| 1748 | schedule(); | ||
| 1749 | if (!s->busy) { | 1788 | if (!s->busy) { |
| 1750 | retval = 0; | 1789 | retval = 0; |
| 1751 | break; | 1790 | break; |
| @@ -1885,11 +1924,17 @@ ok: | |||
| 1885 | static int comedi_close(struct inode *inode, struct file *file) | 1924 | static int comedi_close(struct inode *inode, struct file *file) |
| 1886 | { | 1925 | { |
| 1887 | const unsigned minor = iminor(inode); | 1926 | const unsigned minor = iminor(inode); |
| 1888 | struct comedi_device_file_info *dev_file_info = | ||
| 1889 | comedi_get_device_file_info(minor); | ||
| 1890 | struct comedi_device *dev = dev_file_info->device; | ||
| 1891 | struct comedi_subdevice *s = NULL; | 1927 | struct comedi_subdevice *s = NULL; |
| 1892 | int i; | 1928 | int i; |
| 1929 | struct comedi_device_file_info *dev_file_info; | ||
| 1930 | struct comedi_device *dev; | ||
| 1931 | dev_file_info = comedi_get_device_file_info(minor); | ||
| 1932 | |||
| 1933 | if (dev_file_info == NULL) | ||
| 1934 | return -ENODEV; | ||
| 1935 | dev = dev_file_info->device; | ||
| 1936 | if (dev == NULL) | ||
| 1937 | return -ENODEV; | ||
| 1893 | 1938 | ||
| 1894 | mutex_lock(&dev->mutex); | 1939 | mutex_lock(&dev->mutex); |
| 1895 | 1940 | ||
| @@ -1923,10 +1968,15 @@ static int comedi_close(struct inode *inode, struct file *file) | |||
| 1923 | static int comedi_fasync(int fd, struct file *file, int on) | 1968 | static int comedi_fasync(int fd, struct file *file, int on) |
| 1924 | { | 1969 | { |
| 1925 | const unsigned minor = iminor(file->f_dentry->d_inode); | 1970 | const unsigned minor = iminor(file->f_dentry->d_inode); |
| 1926 | struct comedi_device_file_info *dev_file_info = | 1971 | struct comedi_device_file_info *dev_file_info; |
| 1927 | comedi_get_device_file_info(minor); | 1972 | struct comedi_device *dev; |
| 1973 | dev_file_info = comedi_get_device_file_info(minor); | ||
| 1928 | 1974 | ||
| 1929 | struct comedi_device *dev = dev_file_info->device; | 1975 | if (dev_file_info == NULL) |
| 1976 | return -ENODEV; | ||
| 1977 | dev = dev_file_info->device; | ||
| 1978 | if (dev == NULL) | ||
| 1979 | return -ENODEV; | ||
| 1930 | 1980 | ||
| 1931 | return fasync_helper(fd, file, on, &dev->async_queue); | 1981 | return fasync_helper(fd, file, on, &dev->async_queue); |
| 1932 | } | 1982 | } |
diff --git a/drivers/staging/comedi/drivers/usbduxsigma.c b/drivers/staging/comedi/drivers/usbduxsigma.c index a8fea9a91733..6144afb8cbaa 100644 --- a/drivers/staging/comedi/drivers/usbduxsigma.c +++ b/drivers/staging/comedi/drivers/usbduxsigma.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | #define DRIVER_VERSION "v0.5" | 1 | #define DRIVER_VERSION "v0.6" |
| 2 | #define DRIVER_AUTHOR "Bernd Porr, BerndPorr@f2s.com" | 2 | #define DRIVER_AUTHOR "Bernd Porr, BerndPorr@f2s.com" |
| 3 | #define DRIVER_DESC "Stirling/ITL USB-DUX SIGMA -- Bernd.Porr@f2s.com" | 3 | #define DRIVER_DESC "Stirling/ITL USB-DUX SIGMA -- Bernd.Porr@f2s.com" |
| 4 | /* | 4 | /* |
| @@ -25,7 +25,7 @@ Driver: usbduxsigma | |||
| 25 | Description: University of Stirling USB DAQ & INCITE Technology Limited | 25 | Description: University of Stirling USB DAQ & INCITE Technology Limited |
| 26 | Devices: [ITL] USB-DUX (usbduxsigma.o) | 26 | Devices: [ITL] USB-DUX (usbduxsigma.o) |
| 27 | Author: Bernd Porr <BerndPorr@f2s.com> | 27 | Author: Bernd Porr <BerndPorr@f2s.com> |
| 28 | Updated: 21 Jul 2011 | 28 | Updated: 8 Nov 2011 |
| 29 | Status: testing | 29 | Status: testing |
| 30 | */ | 30 | */ |
| 31 | /* | 31 | /* |
| @@ -44,6 +44,7 @@ Status: testing | |||
| 44 | * 0.3: proper vendor ID and driver name | 44 | * 0.3: proper vendor ID and driver name |
| 45 | * 0.4: fixed D/A voltage range | 45 | * 0.4: fixed D/A voltage range |
| 46 | * 0.5: various bug fixes, health check at startup | 46 | * 0.5: various bug fixes, health check at startup |
| 47 | * 0.6: corrected wrong input range | ||
| 47 | */ | 48 | */ |
| 48 | 49 | ||
| 49 | /* generates loads of debug info */ | 50 | /* generates loads of debug info */ |
| @@ -175,7 +176,7 @@ Status: testing | |||
| 175 | /* comedi constants */ | 176 | /* comedi constants */ |
| 176 | static const struct comedi_lrange range_usbdux_ai_range = { 1, { | 177 | static const struct comedi_lrange range_usbdux_ai_range = { 1, { |
| 177 | BIP_RANGE | 178 | BIP_RANGE |
| 178 | (2.65) | 179 | (2.65/2.0) |
| 179 | } | 180 | } |
| 180 | }; | 181 | }; |
| 181 | 182 | ||
diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c index 26564094e33b..aec9311b108c 100644 --- a/drivers/staging/iio/industrialio-core.c +++ b/drivers/staging/iio/industrialio-core.c | |||
| @@ -242,25 +242,24 @@ static const struct file_operations iio_event_chrdev_fileops = { | |||
| 242 | 242 | ||
| 243 | static int iio_event_getfd(struct iio_dev *indio_dev) | 243 | static int iio_event_getfd(struct iio_dev *indio_dev) |
| 244 | { | 244 | { |
| 245 | struct iio_event_interface *ev_int = indio_dev->event_interface; | ||
| 245 | int fd; | 246 | int fd; |
| 246 | 247 | ||
| 247 | if (indio_dev->event_interface == NULL) | 248 | if (ev_int == NULL) |
| 248 | return -ENODEV; | 249 | return -ENODEV; |
| 249 | 250 | ||
| 250 | mutex_lock(&indio_dev->event_interface->event_list_lock); | 251 | mutex_lock(&ev_int->event_list_lock); |
| 251 | if (test_and_set_bit(IIO_BUSY_BIT_POS, | 252 | if (test_and_set_bit(IIO_BUSY_BIT_POS, &ev_int->flags)) { |
| 252 | &indio_dev->event_interface->flags)) { | 253 | mutex_unlock(&ev_int->event_list_lock); |
| 253 | mutex_unlock(&indio_dev->event_interface->event_list_lock); | ||
| 254 | return -EBUSY; | 254 | return -EBUSY; |
| 255 | } | 255 | } |
| 256 | mutex_unlock(&indio_dev->event_interface->event_list_lock); | 256 | mutex_unlock(&ev_int->event_list_lock); |
| 257 | fd = anon_inode_getfd("iio:event", | 257 | fd = anon_inode_getfd("iio:event", |
| 258 | &iio_event_chrdev_fileops, | 258 | &iio_event_chrdev_fileops, ev_int, O_RDONLY); |
| 259 | indio_dev->event_interface, O_RDONLY); | ||
| 260 | if (fd < 0) { | 259 | if (fd < 0) { |
| 261 | mutex_lock(&indio_dev->event_interface->event_list_lock); | 260 | mutex_lock(&ev_int->event_list_lock); |
| 262 | clear_bit(IIO_BUSY_BIT_POS, &ev_int->flags); | 261 | clear_bit(IIO_BUSY_BIT_POS, &ev_int->flags); |
| 263 | mutex_unlock(&indio_dev->event_interface->event_list_lock); | 262 | mutex_unlock(&ev_int->event_list_lock); |
| 264 | } | 263 | } |
| 265 | return fd; | 264 | return fd; |
| 266 | } | 265 | } |
diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c index fb2e89c3056c..5385da2e9cdb 100644 --- a/drivers/staging/rtl8712/usb_intf.c +++ b/drivers/staging/rtl8712/usb_intf.c | |||
| @@ -89,6 +89,7 @@ static struct usb_device_id rtl871x_usb_id_tbl[] = { | |||
| 89 | {USB_DEVICE(0x0DF6, 0x0045)}, | 89 | {USB_DEVICE(0x0DF6, 0x0045)}, |
| 90 | {USB_DEVICE(0x0DF6, 0x0059)}, /* 11n mode disable */ | 90 | {USB_DEVICE(0x0DF6, 0x0059)}, /* 11n mode disable */ |
| 91 | {USB_DEVICE(0x0DF6, 0x004B)}, | 91 | {USB_DEVICE(0x0DF6, 0x004B)}, |
| 92 | {USB_DEVICE(0x0DF6, 0x005D)}, | ||
| 92 | {USB_DEVICE(0x0DF6, 0x0063)}, | 93 | {USB_DEVICE(0x0DF6, 0x0063)}, |
| 93 | /* Sweex */ | 94 | /* Sweex */ |
| 94 | {USB_DEVICE(0x177F, 0x0154)}, | 95 | {USB_DEVICE(0x177F, 0x0154)}, |
diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c index 480b0ed2e4de..115635f95024 100644 --- a/drivers/staging/rts_pstor/rtsx.c +++ b/drivers/staging/rts_pstor/rtsx.c | |||
| @@ -1021,6 +1021,7 @@ static int __devinit rtsx_probe(struct pci_dev *pci, | |||
| 1021 | th = kthread_create(rtsx_scan_thread, dev, "rtsx-scan"); | 1021 | th = kthread_create(rtsx_scan_thread, dev, "rtsx-scan"); |
| 1022 | if (IS_ERR(th)) { | 1022 | if (IS_ERR(th)) { |
| 1023 | printk(KERN_ERR "Unable to start the device-scanning thread\n"); | 1023 | printk(KERN_ERR "Unable to start the device-scanning thread\n"); |
| 1024 | complete(&dev->scanning_done); | ||
| 1024 | quiesce_and_remove_host(dev); | 1025 | quiesce_and_remove_host(dev); |
| 1025 | err = PTR_ERR(th); | 1026 | err = PTR_ERR(th); |
| 1026 | goto errout; | 1027 | goto errout; |
diff --git a/drivers/staging/tidspbridge/core/dsp-clock.c b/drivers/staging/tidspbridge/core/dsp-clock.c index 3d1279c424a8..7eb56178fb64 100644 --- a/drivers/staging/tidspbridge/core/dsp-clock.c +++ b/drivers/staging/tidspbridge/core/dsp-clock.c | |||
| @@ -54,6 +54,7 @@ | |||
| 54 | 54 | ||
| 55 | /* Bridge GPT id (1 - 4), DM Timer id (5 - 8) */ | 55 | /* Bridge GPT id (1 - 4), DM Timer id (5 - 8) */ |
| 56 | #define DMT_ID(id) ((id) + 4) | 56 | #define DMT_ID(id) ((id) + 4) |
| 57 | #define DM_TIMER_CLOCKS 4 | ||
| 57 | 58 | ||
| 58 | /* Bridge MCBSP id (6 - 10), OMAP Mcbsp id (0 - 4) */ | 59 | /* Bridge MCBSP id (6 - 10), OMAP Mcbsp id (0 - 4) */ |
| 59 | #define MCBSP_ID(id) ((id) - 6) | 60 | #define MCBSP_ID(id) ((id) - 6) |
| @@ -114,8 +115,13 @@ static s8 get_clk_type(u8 id) | |||
| 114 | */ | 115 | */ |
| 115 | void dsp_clk_exit(void) | 116 | void dsp_clk_exit(void) |
| 116 | { | 117 | { |
| 118 | int i; | ||
| 119 | |||
| 117 | dsp_clock_disable_all(dsp_clocks); | 120 | dsp_clock_disable_all(dsp_clocks); |
| 118 | 121 | ||
| 122 | for (i = 0; i < DM_TIMER_CLOCKS; i++) | ||
| 123 | omap_dm_timer_free(timer[i]); | ||
| 124 | |||
| 119 | clk_put(iva2_clk); | 125 | clk_put(iva2_clk); |
| 120 | clk_put(ssi.sst_fck); | 126 | clk_put(ssi.sst_fck); |
| 121 | clk_put(ssi.ssr_fck); | 127 | clk_put(ssi.ssr_fck); |
| @@ -130,9 +136,13 @@ void dsp_clk_exit(void) | |||
| 130 | void dsp_clk_init(void) | 136 | void dsp_clk_init(void) |
| 131 | { | 137 | { |
| 132 | static struct platform_device dspbridge_device; | 138 | static struct platform_device dspbridge_device; |
| 139 | int i, id; | ||
| 133 | 140 | ||
| 134 | dspbridge_device.dev.bus = &platform_bus_type; | 141 | dspbridge_device.dev.bus = &platform_bus_type; |
| 135 | 142 | ||
| 143 | for (i = 0, id = 5; i < DM_TIMER_CLOCKS; i++, id++) | ||
| 144 | timer[i] = omap_dm_timer_request_specific(id); | ||
| 145 | |||
| 136 | iva2_clk = clk_get(&dspbridge_device.dev, "iva2_ck"); | 146 | iva2_clk = clk_get(&dspbridge_device.dev, "iva2_ck"); |
| 137 | if (IS_ERR(iva2_clk)) | 147 | if (IS_ERR(iva2_clk)) |
| 138 | dev_err(bridge, "failed to get iva2 clock %p\n", iva2_clk); | 148 | dev_err(bridge, "failed to get iva2 clock %p\n", iva2_clk); |
| @@ -204,8 +214,7 @@ int dsp_clk_enable(enum dsp_clk_id clk_id) | |||
| 204 | clk_enable(iva2_clk); | 214 | clk_enable(iva2_clk); |
| 205 | break; | 215 | break; |
| 206 | case GPT_CLK: | 216 | case GPT_CLK: |
| 207 | timer[clk_id - 1] = | 217 | status = omap_dm_timer_start(timer[clk_id - 1]); |
| 208 | omap_dm_timer_request_specific(DMT_ID(clk_id)); | ||
| 209 | break; | 218 | break; |
| 210 | #ifdef CONFIG_OMAP_MCBSP | 219 | #ifdef CONFIG_OMAP_MCBSP |
| 211 | case MCBSP_CLK: | 220 | case MCBSP_CLK: |
| @@ -281,7 +290,7 @@ int dsp_clk_disable(enum dsp_clk_id clk_id) | |||
| 281 | clk_disable(iva2_clk); | 290 | clk_disable(iva2_clk); |
| 282 | break; | 291 | break; |
| 283 | case GPT_CLK: | 292 | case GPT_CLK: |
| 284 | omap_dm_timer_free(timer[clk_id - 1]); | 293 | status = omap_dm_timer_stop(timer[clk_id - 1]); |
| 285 | break; | 294 | break; |
| 286 | #ifdef CONFIG_OMAP_MCBSP | 295 | #ifdef CONFIG_OMAP_MCBSP |
| 287 | case MCBSP_CLK: | 296 | case MCBSP_CLK: |
diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c b/drivers/staging/tidspbridge/rmgr/drv_interface.c index c43c7e3421c8..76cfc6edecd9 100644 --- a/drivers/staging/tidspbridge/rmgr/drv_interface.c +++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c | |||
| @@ -24,11 +24,7 @@ | |||
| 24 | #include <linux/types.h> | 24 | #include <linux/types.h> |
| 25 | #include <linux/platform_device.h> | 25 | #include <linux/platform_device.h> |
| 26 | #include <linux/pm.h> | 26 | #include <linux/pm.h> |
| 27 | |||
| 28 | #ifdef MODULE | ||
| 29 | #include <linux/module.h> | 27 | #include <linux/module.h> |
| 30 | #endif | ||
| 31 | |||
| 32 | #include <linux/device.h> | 28 | #include <linux/device.h> |
| 33 | #include <linux/init.h> | 29 | #include <linux/init.h> |
| 34 | #include <linux/moduleparam.h> | 30 | #include <linux/moduleparam.h> |
diff --git a/drivers/staging/usbip/vhci_rx.c b/drivers/staging/usbip/vhci_rx.c index 09c44abb89e8..3872b8cccdcf 100644 --- a/drivers/staging/usbip/vhci_rx.c +++ b/drivers/staging/usbip/vhci_rx.c | |||
| @@ -68,6 +68,7 @@ static void vhci_recv_ret_submit(struct vhci_device *vdev, | |||
| 68 | { | 68 | { |
| 69 | struct usbip_device *ud = &vdev->ud; | 69 | struct usbip_device *ud = &vdev->ud; |
| 70 | struct urb *urb; | 70 | struct urb *urb; |
| 71 | unsigned long flags; | ||
| 71 | 72 | ||
| 72 | spin_lock(&vdev->priv_lock); | 73 | spin_lock(&vdev->priv_lock); |
| 73 | urb = pickup_urb_and_free_priv(vdev, pdu->base.seqnum); | 74 | urb = pickup_urb_and_free_priv(vdev, pdu->base.seqnum); |
| @@ -101,9 +102,9 @@ static void vhci_recv_ret_submit(struct vhci_device *vdev, | |||
| 101 | 102 | ||
| 102 | usbip_dbg_vhci_rx("now giveback urb %p\n", urb); | 103 | usbip_dbg_vhci_rx("now giveback urb %p\n", urb); |
| 103 | 104 | ||
| 104 | spin_lock(&the_controller->lock); | 105 | spin_lock_irqsave(&the_controller->lock, flags); |
| 105 | usb_hcd_unlink_urb_from_ep(vhci_to_hcd(the_controller), urb); | 106 | usb_hcd_unlink_urb_from_ep(vhci_to_hcd(the_controller), urb); |
| 106 | spin_unlock(&the_controller->lock); | 107 | spin_unlock_irqrestore(&the_controller->lock, flags); |
| 107 | 108 | ||
| 108 | usb_hcd_giveback_urb(vhci_to_hcd(the_controller), urb, urb->status); | 109 | usb_hcd_giveback_urb(vhci_to_hcd(the_controller), urb, urb->status); |
| 109 | 110 | ||
| @@ -141,6 +142,7 @@ static void vhci_recv_ret_unlink(struct vhci_device *vdev, | |||
| 141 | { | 142 | { |
| 142 | struct vhci_unlink *unlink; | 143 | struct vhci_unlink *unlink; |
| 143 | struct urb *urb; | 144 | struct urb *urb; |
| 145 | unsigned long flags; | ||
| 144 | 146 | ||
| 145 | usbip_dump_header(pdu); | 147 | usbip_dump_header(pdu); |
| 146 | 148 | ||
| @@ -170,9 +172,9 @@ static void vhci_recv_ret_unlink(struct vhci_device *vdev, | |||
| 170 | urb->status = pdu->u.ret_unlink.status; | 172 | urb->status = pdu->u.ret_unlink.status; |
| 171 | pr_info("urb->status %d\n", urb->status); | 173 | pr_info("urb->status %d\n", urb->status); |
| 172 | 174 | ||
| 173 | spin_lock(&the_controller->lock); | 175 | spin_lock_irqsave(&the_controller->lock, flags); |
| 174 | usb_hcd_unlink_urb_from_ep(vhci_to_hcd(the_controller), urb); | 176 | usb_hcd_unlink_urb_from_ep(vhci_to_hcd(the_controller), urb); |
| 175 | spin_unlock(&the_controller->lock); | 177 | spin_unlock_irqrestore(&the_controller->lock, flags); |
| 176 | 178 | ||
| 177 | usb_hcd_giveback_urb(vhci_to_hcd(the_controller), urb, | 179 | usb_hcd_giveback_urb(vhci_to_hcd(the_controller), urb, |
| 178 | urb->status); | 180 | urb->status); |
diff --git a/drivers/target/iscsi/iscsi_target.c b/drivers/target/iscsi/iscsi_target.c index 0fd96c10271d..8599545cdf9e 100644 --- a/drivers/target/iscsi/iscsi_target.c +++ b/drivers/target/iscsi/iscsi_target.c | |||
| @@ -614,13 +614,12 @@ int iscsit_add_reject( | |||
| 614 | hdr = (struct iscsi_reject *) cmd->pdu; | 614 | hdr = (struct iscsi_reject *) cmd->pdu; |
| 615 | hdr->reason = reason; | 615 | hdr->reason = reason; |
| 616 | 616 | ||
| 617 | cmd->buf_ptr = kzalloc(ISCSI_HDR_LEN, GFP_KERNEL); | 617 | cmd->buf_ptr = kmemdup(buf, ISCSI_HDR_LEN, GFP_KERNEL); |
| 618 | if (!cmd->buf_ptr) { | 618 | if (!cmd->buf_ptr) { |
| 619 | pr_err("Unable to allocate memory for cmd->buf_ptr\n"); | 619 | pr_err("Unable to allocate memory for cmd->buf_ptr\n"); |
| 620 | iscsit_release_cmd(cmd); | 620 | iscsit_release_cmd(cmd); |
| 621 | return -1; | 621 | return -1; |
| 622 | } | 622 | } |
| 623 | memcpy(cmd->buf_ptr, buf, ISCSI_HDR_LEN); | ||
| 624 | 623 | ||
| 625 | spin_lock_bh(&conn->cmd_lock); | 624 | spin_lock_bh(&conn->cmd_lock); |
| 626 | list_add_tail(&cmd->i_list, &conn->conn_cmd_list); | 625 | list_add_tail(&cmd->i_list, &conn->conn_cmd_list); |
| @@ -661,13 +660,12 @@ int iscsit_add_reject_from_cmd( | |||
| 661 | hdr = (struct iscsi_reject *) cmd->pdu; | 660 | hdr = (struct iscsi_reject *) cmd->pdu; |
| 662 | hdr->reason = reason; | 661 | hdr->reason = reason; |
| 663 | 662 | ||
| 664 | cmd->buf_ptr = kzalloc(ISCSI_HDR_LEN, GFP_KERNEL); | 663 | cmd->buf_ptr = kmemdup(buf, ISCSI_HDR_LEN, GFP_KERNEL); |
| 665 | if (!cmd->buf_ptr) { | 664 | if (!cmd->buf_ptr) { |
| 666 | pr_err("Unable to allocate memory for cmd->buf_ptr\n"); | 665 | pr_err("Unable to allocate memory for cmd->buf_ptr\n"); |
| 667 | iscsit_release_cmd(cmd); | 666 | iscsit_release_cmd(cmd); |
| 668 | return -1; | 667 | return -1; |
| 669 | } | 668 | } |
| 670 | memcpy(cmd->buf_ptr, buf, ISCSI_HDR_LEN); | ||
| 671 | 669 | ||
| 672 | if (add_to_conn) { | 670 | if (add_to_conn) { |
| 673 | spin_lock_bh(&conn->cmd_lock); | 671 | spin_lock_bh(&conn->cmd_lock); |
| @@ -1017,11 +1015,6 @@ done: | |||
| 1017 | " non-existent or non-exported iSCSI LUN:" | 1015 | " non-existent or non-exported iSCSI LUN:" |
| 1018 | " 0x%016Lx\n", get_unaligned_le64(&hdr->lun)); | 1016 | " 0x%016Lx\n", get_unaligned_le64(&hdr->lun)); |
| 1019 | } | 1017 | } |
| 1020 | if (ret == PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES) | ||
| 1021 | return iscsit_add_reject_from_cmd( | ||
| 1022 | ISCSI_REASON_BOOKMARK_NO_RESOURCES, | ||
| 1023 | 1, 1, buf, cmd); | ||
| 1024 | |||
| 1025 | send_check_condition = 1; | 1018 | send_check_condition = 1; |
| 1026 | goto attach_cmd; | 1019 | goto attach_cmd; |
| 1027 | } | 1020 | } |
| @@ -1044,6 +1037,8 @@ done: | |||
| 1044 | */ | 1037 | */ |
| 1045 | send_check_condition = 1; | 1038 | send_check_condition = 1; |
| 1046 | } else { | 1039 | } else { |
| 1040 | cmd->data_length = cmd->se_cmd.data_length; | ||
| 1041 | |||
| 1047 | if (iscsit_decide_list_to_build(cmd, payload_length) < 0) | 1042 | if (iscsit_decide_list_to_build(cmd, payload_length) < 0) |
| 1048 | return iscsit_add_reject_from_cmd( | 1043 | return iscsit_add_reject_from_cmd( |
| 1049 | ISCSI_REASON_BOOKMARK_NO_RESOURCES, | 1044 | ISCSI_REASON_BOOKMARK_NO_RESOURCES, |
| @@ -1123,7 +1118,7 @@ attach_cmd: | |||
| 1123 | * the backend memory allocation. | 1118 | * the backend memory allocation. |
| 1124 | */ | 1119 | */ |
| 1125 | ret = transport_generic_new_cmd(&cmd->se_cmd); | 1120 | ret = transport_generic_new_cmd(&cmd->se_cmd); |
| 1126 | if ((ret < 0) || (cmd->se_cmd.se_cmd_flags & SCF_SE_CMD_FAILED)) { | 1121 | if (ret < 0) { |
| 1127 | immed_ret = IMMEDIATE_DATA_NORMAL_OPERATION; | 1122 | immed_ret = IMMEDIATE_DATA_NORMAL_OPERATION; |
| 1128 | dump_immediate_data = 1; | 1123 | dump_immediate_data = 1; |
| 1129 | goto after_immediate_data; | 1124 | goto after_immediate_data; |
| @@ -1341,7 +1336,7 @@ static int iscsit_handle_data_out(struct iscsi_conn *conn, unsigned char *buf) | |||
| 1341 | 1336 | ||
| 1342 | spin_lock_irqsave(&se_cmd->t_state_lock, flags); | 1337 | spin_lock_irqsave(&se_cmd->t_state_lock, flags); |
| 1343 | if (!(se_cmd->se_cmd_flags & SCF_SUPPORTED_SAM_OPCODE) || | 1338 | if (!(se_cmd->se_cmd_flags & SCF_SUPPORTED_SAM_OPCODE) || |
| 1344 | (se_cmd->se_cmd_flags & SCF_SE_CMD_FAILED)) | 1339 | (se_cmd->se_cmd_flags & SCF_SCSI_CDB_EXCEPTION)) |
| 1345 | dump_unsolicited_data = 1; | 1340 | dump_unsolicited_data = 1; |
| 1346 | spin_unlock_irqrestore(&se_cmd->t_state_lock, flags); | 1341 | spin_unlock_irqrestore(&se_cmd->t_state_lock, flags); |
| 1347 | 1342 | ||
| @@ -2513,10 +2508,10 @@ static int iscsit_send_data_in( | |||
| 2513 | if (hdr->flags & ISCSI_FLAG_DATA_STATUS) { | 2508 | if (hdr->flags & ISCSI_FLAG_DATA_STATUS) { |
| 2514 | if (cmd->se_cmd.se_cmd_flags & SCF_OVERFLOW_BIT) { | 2509 | if (cmd->se_cmd.se_cmd_flags & SCF_OVERFLOW_BIT) { |
| 2515 | hdr->flags |= ISCSI_FLAG_DATA_OVERFLOW; | 2510 | hdr->flags |= ISCSI_FLAG_DATA_OVERFLOW; |
| 2516 | hdr->residual_count = cpu_to_be32(cmd->residual_count); | 2511 | hdr->residual_count = cpu_to_be32(cmd->se_cmd.residual_count); |
| 2517 | } else if (cmd->se_cmd.se_cmd_flags & SCF_UNDERFLOW_BIT) { | 2512 | } else if (cmd->se_cmd.se_cmd_flags & SCF_UNDERFLOW_BIT) { |
| 2518 | hdr->flags |= ISCSI_FLAG_DATA_UNDERFLOW; | 2513 | hdr->flags |= ISCSI_FLAG_DATA_UNDERFLOW; |
| 2519 | hdr->residual_count = cpu_to_be32(cmd->residual_count); | 2514 | hdr->residual_count = cpu_to_be32(cmd->se_cmd.residual_count); |
| 2520 | } | 2515 | } |
| 2521 | } | 2516 | } |
| 2522 | hton24(hdr->dlength, datain.length); | 2517 | hton24(hdr->dlength, datain.length); |
| @@ -3018,10 +3013,10 @@ static int iscsit_send_status( | |||
| 3018 | hdr->flags |= ISCSI_FLAG_CMD_FINAL; | 3013 | hdr->flags |= ISCSI_FLAG_CMD_FINAL; |
| 3019 | if (cmd->se_cmd.se_cmd_flags & SCF_OVERFLOW_BIT) { | 3014 | if (cmd->se_cmd.se_cmd_flags & SCF_OVERFLOW_BIT) { |
| 3020 | hdr->flags |= ISCSI_FLAG_CMD_OVERFLOW; | 3015 | hdr->flags |= ISCSI_FLAG_CMD_OVERFLOW; |
| 3021 | hdr->residual_count = cpu_to_be32(cmd->residual_count); | 3016 | hdr->residual_count = cpu_to_be32(cmd->se_cmd.residual_count); |
| 3022 | } else if (cmd->se_cmd.se_cmd_flags & SCF_UNDERFLOW_BIT) { | 3017 | } else if (cmd->se_cmd.se_cmd_flags & SCF_UNDERFLOW_BIT) { |
| 3023 | hdr->flags |= ISCSI_FLAG_CMD_UNDERFLOW; | 3018 | hdr->flags |= ISCSI_FLAG_CMD_UNDERFLOW; |
| 3024 | hdr->residual_count = cpu_to_be32(cmd->residual_count); | 3019 | hdr->residual_count = cpu_to_be32(cmd->se_cmd.residual_count); |
| 3025 | } | 3020 | } |
| 3026 | hdr->response = cmd->iscsi_response; | 3021 | hdr->response = cmd->iscsi_response; |
| 3027 | hdr->cmd_status = cmd->se_cmd.scsi_status; | 3022 | hdr->cmd_status = cmd->se_cmd.scsi_status; |
| @@ -3133,6 +3128,7 @@ static int iscsit_send_task_mgt_rsp( | |||
| 3133 | hdr = (struct iscsi_tm_rsp *) cmd->pdu; | 3128 | hdr = (struct iscsi_tm_rsp *) cmd->pdu; |
| 3134 | memset(hdr, 0, ISCSI_HDR_LEN); | 3129 | memset(hdr, 0, ISCSI_HDR_LEN); |
| 3135 | hdr->opcode = ISCSI_OP_SCSI_TMFUNC_RSP; | 3130 | hdr->opcode = ISCSI_OP_SCSI_TMFUNC_RSP; |
| 3131 | hdr->flags = ISCSI_FLAG_CMD_FINAL; | ||
| 3136 | hdr->response = iscsit_convert_tcm_tmr_rsp(se_tmr); | 3132 | hdr->response = iscsit_convert_tcm_tmr_rsp(se_tmr); |
| 3137 | hdr->itt = cpu_to_be32(cmd->init_task_tag); | 3133 | hdr->itt = cpu_to_be32(cmd->init_task_tag); |
| 3138 | cmd->stat_sn = conn->stat_sn++; | 3134 | cmd->stat_sn = conn->stat_sn++; |
diff --git a/drivers/target/iscsi/iscsi_target_auth.c b/drivers/target/iscsi/iscsi_target_auth.c index beb39469e7f1..1cd6ce373b83 100644 --- a/drivers/target/iscsi/iscsi_target_auth.c +++ b/drivers/target/iscsi/iscsi_target_auth.c | |||
| @@ -30,9 +30,11 @@ | |||
| 30 | 30 | ||
| 31 | static int chap_string_to_hex(unsigned char *dst, unsigned char *src, int len) | 31 | static int chap_string_to_hex(unsigned char *dst, unsigned char *src, int len) |
| 32 | { | 32 | { |
| 33 | int j = DIV_ROUND_UP(len, 2); | 33 | int j = DIV_ROUND_UP(len, 2), rc; |
| 34 | 34 | ||
| 35 | hex2bin(dst, src, j); | 35 | rc = hex2bin(dst, src, j); |
| 36 | if (rc < 0) | ||
| 37 | pr_debug("CHAP string contains non hex digit symbols\n"); | ||
| 36 | 38 | ||
| 37 | dst[j] = '\0'; | 39 | dst[j] = '\0'; |
| 38 | return j; | 40 | return j; |
diff --git a/drivers/target/iscsi/iscsi_target_core.h b/drivers/target/iscsi/iscsi_target_core.h index 3723d90d5ae5..f1a02dad05a0 100644 --- a/drivers/target/iscsi/iscsi_target_core.h +++ b/drivers/target/iscsi/iscsi_target_core.h | |||
| @@ -398,7 +398,6 @@ struct iscsi_cmd { | |||
| 398 | u32 pdu_send_order; | 398 | u32 pdu_send_order; |
| 399 | /* Current struct iscsi_pdu in struct iscsi_cmd->pdu_list */ | 399 | /* Current struct iscsi_pdu in struct iscsi_cmd->pdu_list */ |
| 400 | u32 pdu_start; | 400 | u32 pdu_start; |
| 401 | u32 residual_count; | ||
| 402 | /* Next struct iscsi_seq to send in struct iscsi_cmd->seq_list */ | 401 | /* Next struct iscsi_seq to send in struct iscsi_cmd->seq_list */ |
| 403 | u32 seq_send_order; | 402 | u32 seq_send_order; |
| 404 | /* Number of struct iscsi_seq in struct iscsi_cmd->seq_list */ | 403 | /* Number of struct iscsi_seq in struct iscsi_cmd->seq_list */ |
| @@ -535,7 +534,6 @@ struct iscsi_conn { | |||
| 535 | atomic_t connection_exit; | 534 | atomic_t connection_exit; |
| 536 | atomic_t connection_recovery; | 535 | atomic_t connection_recovery; |
| 537 | atomic_t connection_reinstatement; | 536 | atomic_t connection_reinstatement; |
| 538 | atomic_t connection_wait; | ||
| 539 | atomic_t connection_wait_rcfr; | 537 | atomic_t connection_wait_rcfr; |
| 540 | atomic_t sleep_on_conn_wait_comp; | 538 | atomic_t sleep_on_conn_wait_comp; |
| 541 | atomic_t transport_failed; | 539 | atomic_t transport_failed; |
| @@ -643,7 +641,6 @@ struct iscsi_session { | |||
| 643 | atomic_t session_reinstatement; | 641 | atomic_t session_reinstatement; |
| 644 | atomic_t session_stop_active; | 642 | atomic_t session_stop_active; |
| 645 | atomic_t sleep_on_sess_wait_comp; | 643 | atomic_t sleep_on_sess_wait_comp; |
| 646 | atomic_t transport_wait_cmds; | ||
| 647 | /* connection list */ | 644 | /* connection list */ |
| 648 | struct list_head sess_conn_list; | 645 | struct list_head sess_conn_list; |
| 649 | struct list_head cr_active_list; | 646 | struct list_head cr_active_list; |
diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index c4c68da3e500..101b1beb3bca 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c | |||
| @@ -938,8 +938,7 @@ int iscsit_execute_cmd(struct iscsi_cmd *cmd, int ooo) | |||
| 938 | * handle the SCF_SCSI_RESERVATION_CONFLICT case here as well. | 938 | * handle the SCF_SCSI_RESERVATION_CONFLICT case here as well. |
| 939 | */ | 939 | */ |
| 940 | if (se_cmd->se_cmd_flags & SCF_SCSI_CDB_EXCEPTION) { | 940 | if (se_cmd->se_cmd_flags & SCF_SCSI_CDB_EXCEPTION) { |
| 941 | if (se_cmd->se_cmd_flags & | 941 | if (se_cmd->scsi_sense_reason == TCM_RESERVATION_CONFLICT) { |
| 942 | SCF_SCSI_RESERVATION_CONFLICT) { | ||
| 943 | cmd->i_state = ISTATE_SEND_STATUS; | 942 | cmd->i_state = ISTATE_SEND_STATUS; |
| 944 | spin_unlock_bh(&cmd->istate_lock); | 943 | spin_unlock_bh(&cmd->istate_lock); |
| 945 | iscsit_add_cmd_to_response_queue(cmd, cmd->conn, | 944 | iscsit_add_cmd_to_response_queue(cmd, cmd->conn, |
diff --git a/drivers/target/iscsi/iscsi_target_login.c b/drivers/target/iscsi/iscsi_target_login.c index daad362a93ce..d734bdec24f9 100644 --- a/drivers/target/iscsi/iscsi_target_login.c +++ b/drivers/target/iscsi/iscsi_target_login.c | |||
| @@ -224,7 +224,7 @@ static int iscsi_login_zero_tsih_s1( | |||
| 224 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, | 224 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, |
| 225 | ISCSI_LOGIN_STATUS_NO_RESOURCES); | 225 | ISCSI_LOGIN_STATUS_NO_RESOURCES); |
| 226 | pr_err("Could not allocate memory for session\n"); | 226 | pr_err("Could not allocate memory for session\n"); |
| 227 | return -1; | 227 | return -ENOMEM; |
| 228 | } | 228 | } |
| 229 | 229 | ||
| 230 | iscsi_login_set_conn_values(sess, conn, pdu->cid); | 230 | iscsi_login_set_conn_values(sess, conn, pdu->cid); |
| @@ -250,7 +250,8 @@ static int iscsi_login_zero_tsih_s1( | |||
| 250 | pr_err("idr_pre_get() for sess_idr failed\n"); | 250 | pr_err("idr_pre_get() for sess_idr failed\n"); |
| 251 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, | 251 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, |
| 252 | ISCSI_LOGIN_STATUS_NO_RESOURCES); | 252 | ISCSI_LOGIN_STATUS_NO_RESOURCES); |
| 253 | return -1; | 253 | kfree(sess); |
| 254 | return -ENOMEM; | ||
| 254 | } | 255 | } |
| 255 | spin_lock(&sess_idr_lock); | 256 | spin_lock(&sess_idr_lock); |
| 256 | idr_get_new(&sess_idr, NULL, &sess->session_index); | 257 | idr_get_new(&sess_idr, NULL, &sess->session_index); |
| @@ -270,14 +271,16 @@ static int iscsi_login_zero_tsih_s1( | |||
| 270 | ISCSI_LOGIN_STATUS_NO_RESOURCES); | 271 | ISCSI_LOGIN_STATUS_NO_RESOURCES); |
| 271 | pr_err("Unable to allocate memory for" | 272 | pr_err("Unable to allocate memory for" |
| 272 | " struct iscsi_sess_ops.\n"); | 273 | " struct iscsi_sess_ops.\n"); |
| 273 | return -1; | 274 | kfree(sess); |
| 275 | return -ENOMEM; | ||
| 274 | } | 276 | } |
| 275 | 277 | ||
| 276 | sess->se_sess = transport_init_session(); | 278 | sess->se_sess = transport_init_session(); |
| 277 | if (!sess->se_sess) { | 279 | if (IS_ERR(sess->se_sess)) { |
| 278 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, | 280 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, |
| 279 | ISCSI_LOGIN_STATUS_NO_RESOURCES); | 281 | ISCSI_LOGIN_STATUS_NO_RESOURCES); |
| 280 | return -1; | 282 | kfree(sess); |
| 283 | return -ENOMEM; | ||
| 281 | } | 284 | } |
| 282 | 285 | ||
| 283 | return 0; | 286 | return 0; |
diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 426cd4bf6a9a..98936cb7c294 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c | |||
| @@ -981,14 +981,13 @@ struct iscsi_login *iscsi_target_init_negotiation( | |||
| 981 | return NULL; | 981 | return NULL; |
| 982 | } | 982 | } |
| 983 | 983 | ||
| 984 | login->req = kzalloc(ISCSI_HDR_LEN, GFP_KERNEL); | 984 | login->req = kmemdup(login_pdu, ISCSI_HDR_LEN, GFP_KERNEL); |
| 985 | if (!login->req) { | 985 | if (!login->req) { |
| 986 | pr_err("Unable to allocate memory for Login Request.\n"); | 986 | pr_err("Unable to allocate memory for Login Request.\n"); |
| 987 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, | 987 | iscsit_tx_login_rsp(conn, ISCSI_STATUS_CLS_TARGET_ERR, |
| 988 | ISCSI_LOGIN_STATUS_NO_RESOURCES); | 988 | ISCSI_LOGIN_STATUS_NO_RESOURCES); |
| 989 | goto out; | 989 | goto out; |
| 990 | } | 990 | } |
| 991 | memcpy(login->req, login_pdu, ISCSI_HDR_LEN); | ||
| 992 | 991 | ||
| 993 | login->req_buf = kzalloc(MAX_KEY_VALUE_PAIRS, GFP_KERNEL); | 992 | login->req_buf = kzalloc(MAX_KEY_VALUE_PAIRS, GFP_KERNEL); |
| 994 | if (!login->req_buf) { | 993 | if (!login->req_buf) { |
diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 3df1c9b8ae6b..81d5832fbbd5 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drivers/target/loopback/tcm_loop.c | |||
| @@ -113,11 +113,9 @@ static struct se_cmd *tcm_loop_allocate_core_cmd( | |||
| 113 | scsi_bufflen(sc), sc->sc_data_direction, sam_task_attr, | 113 | scsi_bufflen(sc), sc->sc_data_direction, sam_task_attr, |
| 114 | &tl_cmd->tl_sense_buf[0]); | 114 | &tl_cmd->tl_sense_buf[0]); |
| 115 | 115 | ||
| 116 | /* | ||
| 117 | * Signal BIDI usage with T_TASK(cmd)->t_tasks_bidi | ||
| 118 | */ | ||
| 119 | if (scsi_bidi_cmnd(sc)) | 116 | if (scsi_bidi_cmnd(sc)) |
| 120 | se_cmd->t_tasks_bidi = 1; | 117 | se_cmd->se_cmd_flags |= SCF_BIDI; |
| 118 | |||
| 121 | /* | 119 | /* |
| 122 | * Locate the struct se_lun pointer and attach it to struct se_cmd | 120 | * Locate the struct se_lun pointer and attach it to struct se_cmd |
| 123 | */ | 121 | */ |
| @@ -148,27 +146,13 @@ static int tcm_loop_new_cmd_map(struct se_cmd *se_cmd) | |||
| 148 | * Allocate the necessary tasks to complete the received CDB+data | 146 | * Allocate the necessary tasks to complete the received CDB+data |
| 149 | */ | 147 | */ |
| 150 | ret = transport_generic_allocate_tasks(se_cmd, sc->cmnd); | 148 | ret = transport_generic_allocate_tasks(se_cmd, sc->cmnd); |
| 151 | if (ret == -ENOMEM) { | 149 | if (ret != 0) |
| 152 | /* Out of Resources */ | 150 | return ret; |
| 153 | return PYX_TRANSPORT_LU_COMM_FAILURE; | ||
| 154 | } else if (ret == -EINVAL) { | ||
| 155 | /* | ||
| 156 | * Handle case for SAM_STAT_RESERVATION_CONFLICT | ||
| 157 | */ | ||
| 158 | if (se_cmd->se_cmd_flags & SCF_SCSI_RESERVATION_CONFLICT) | ||
| 159 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | ||
| 160 | /* | ||
| 161 | * Otherwise, return SAM_STAT_CHECK_CONDITION and return | ||
| 162 | * sense data. | ||
| 163 | */ | ||
| 164 | return PYX_TRANSPORT_USE_SENSE_REASON; | ||
| 165 | } | ||
| 166 | |||
| 167 | /* | 151 | /* |
| 168 | * For BIDI commands, pass in the extra READ buffer | 152 | * For BIDI commands, pass in the extra READ buffer |
| 169 | * to transport_generic_map_mem_to_cmd() below.. | 153 | * to transport_generic_map_mem_to_cmd() below.. |
| 170 | */ | 154 | */ |
| 171 | if (se_cmd->t_tasks_bidi) { | 155 | if (se_cmd->se_cmd_flags & SCF_BIDI) { |
| 172 | struct scsi_data_buffer *sdb = scsi_in(sc); | 156 | struct scsi_data_buffer *sdb = scsi_in(sc); |
| 173 | 157 | ||
| 174 | sgl_bidi = sdb->table.sgl; | 158 | sgl_bidi = sdb->table.sgl; |
| @@ -194,12 +178,8 @@ static int tcm_loop_new_cmd_map(struct se_cmd *se_cmd) | |||
| 194 | } | 178 | } |
| 195 | 179 | ||
| 196 | /* Tell the core about our preallocated memory */ | 180 | /* Tell the core about our preallocated memory */ |
| 197 | ret = transport_generic_map_mem_to_cmd(se_cmd, scsi_sglist(sc), | 181 | return transport_generic_map_mem_to_cmd(se_cmd, scsi_sglist(sc), |
| 198 | scsi_sg_count(sc), sgl_bidi, sgl_bidi_count); | 182 | scsi_sg_count(sc), sgl_bidi, sgl_bidi_count); |
| 199 | if (ret < 0) | ||
| 200 | return PYX_TRANSPORT_LU_COMM_FAILURE; | ||
| 201 | |||
| 202 | return 0; | ||
| 203 | } | 183 | } |
| 204 | 184 | ||
| 205 | /* | 185 | /* |
| @@ -1360,17 +1340,16 @@ void tcm_loop_drop_scsi_hba( | |||
| 1360 | { | 1340 | { |
| 1361 | struct tcm_loop_hba *tl_hba = container_of(wwn, | 1341 | struct tcm_loop_hba *tl_hba = container_of(wwn, |
| 1362 | struct tcm_loop_hba, tl_hba_wwn); | 1342 | struct tcm_loop_hba, tl_hba_wwn); |
| 1363 | int host_no = tl_hba->sh->host_no; | 1343 | |
| 1344 | pr_debug("TCM_Loop_ConfigFS: Deallocating emulated Target" | ||
| 1345 | " SAS Address: %s at Linux/SCSI Host ID: %d\n", | ||
| 1346 | tl_hba->tl_wwn_address, tl_hba->sh->host_no); | ||
| 1364 | /* | 1347 | /* |
| 1365 | * Call device_unregister() on the original tl_hba->dev. | 1348 | * Call device_unregister() on the original tl_hba->dev. |
| 1366 | * tcm_loop_fabric_scsi.c:tcm_loop_release_adapter() will | 1349 | * tcm_loop_fabric_scsi.c:tcm_loop_release_adapter() will |
| 1367 | * release *tl_hba; | 1350 | * release *tl_hba; |
| 1368 | */ | 1351 | */ |
| 1369 | device_unregister(&tl_hba->dev); | 1352 | device_unregister(&tl_hba->dev); |
| 1370 | |||
| 1371 | pr_debug("TCM_Loop_ConfigFS: Deallocated emulated Target" | ||
| 1372 | " SAS Address: %s at Linux/SCSI Host ID: %d\n", | ||
| 1373 | config_item_name(&wwn->wwn_group.cg_item), host_no); | ||
| 1374 | } | 1353 | } |
| 1375 | 1354 | ||
| 1376 | /* Start items for tcm_loop_cit */ | 1355 | /* Start items for tcm_loop_cit */ |
diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index 88f2ad43ec8b..1dcbef499d6a 100644 --- a/drivers/target/target_core_alua.c +++ b/drivers/target/target_core_alua.c | |||
| @@ -191,9 +191,10 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 191 | int alua_access_state, primary = 0, rc; | 191 | int alua_access_state, primary = 0, rc; |
| 192 | u16 tg_pt_id, rtpi; | 192 | u16 tg_pt_id, rtpi; |
| 193 | 193 | ||
| 194 | if (!l_port) | 194 | if (!l_port) { |
| 195 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 195 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 196 | 196 | return -EINVAL; | |
| 197 | } | ||
| 197 | buf = transport_kmap_first_data_page(cmd); | 198 | buf = transport_kmap_first_data_page(cmd); |
| 198 | 199 | ||
| 199 | /* | 200 | /* |
| @@ -203,7 +204,8 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 203 | l_tg_pt_gp_mem = l_port->sep_alua_tg_pt_gp_mem; | 204 | l_tg_pt_gp_mem = l_port->sep_alua_tg_pt_gp_mem; |
| 204 | if (!l_tg_pt_gp_mem) { | 205 | if (!l_tg_pt_gp_mem) { |
| 205 | pr_err("Unable to access l_port->sep_alua_tg_pt_gp_mem\n"); | 206 | pr_err("Unable to access l_port->sep_alua_tg_pt_gp_mem\n"); |
| 206 | rc = PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 207 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 208 | rc = -EINVAL; | ||
| 207 | goto out; | 209 | goto out; |
| 208 | } | 210 | } |
| 209 | spin_lock(&l_tg_pt_gp_mem->tg_pt_gp_mem_lock); | 211 | spin_lock(&l_tg_pt_gp_mem->tg_pt_gp_mem_lock); |
| @@ -211,7 +213,8 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 211 | if (!l_tg_pt_gp) { | 213 | if (!l_tg_pt_gp) { |
| 212 | spin_unlock(&l_tg_pt_gp_mem->tg_pt_gp_mem_lock); | 214 | spin_unlock(&l_tg_pt_gp_mem->tg_pt_gp_mem_lock); |
| 213 | pr_err("Unable to access *l_tg_pt_gp_mem->tg_pt_gp\n"); | 215 | pr_err("Unable to access *l_tg_pt_gp_mem->tg_pt_gp\n"); |
| 214 | rc = PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 216 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 217 | rc = -EINVAL; | ||
| 215 | goto out; | 218 | goto out; |
| 216 | } | 219 | } |
| 217 | rc = (l_tg_pt_gp->tg_pt_gp_alua_access_type & TPGS_EXPLICT_ALUA); | 220 | rc = (l_tg_pt_gp->tg_pt_gp_alua_access_type & TPGS_EXPLICT_ALUA); |
| @@ -220,7 +223,8 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 220 | if (!rc) { | 223 | if (!rc) { |
| 221 | pr_debug("Unable to process SET_TARGET_PORT_GROUPS" | 224 | pr_debug("Unable to process SET_TARGET_PORT_GROUPS" |
| 222 | " while TPGS_EXPLICT_ALUA is disabled\n"); | 225 | " while TPGS_EXPLICT_ALUA is disabled\n"); |
| 223 | rc = PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 226 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 227 | rc = -EINVAL; | ||
| 224 | goto out; | 228 | goto out; |
| 225 | } | 229 | } |
| 226 | 230 | ||
| @@ -245,7 +249,8 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 245 | * REQUEST, and the additional sense code set to INVALID | 249 | * REQUEST, and the additional sense code set to INVALID |
| 246 | * FIELD IN PARAMETER LIST. | 250 | * FIELD IN PARAMETER LIST. |
| 247 | */ | 251 | */ |
| 248 | rc = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 252 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 253 | rc = -EINVAL; | ||
| 249 | goto out; | 254 | goto out; |
| 250 | } | 255 | } |
| 251 | rc = -1; | 256 | rc = -1; |
| @@ -298,7 +303,8 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 298 | * throw an exception with ASCQ: INVALID_PARAMETER_LIST | 303 | * throw an exception with ASCQ: INVALID_PARAMETER_LIST |
| 299 | */ | 304 | */ |
| 300 | if (rc != 0) { | 305 | if (rc != 0) { |
| 301 | rc = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 306 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 307 | rc = -EINVAL; | ||
| 302 | goto out; | 308 | goto out; |
| 303 | } | 309 | } |
| 304 | } else { | 310 | } else { |
| @@ -335,7 +341,8 @@ int target_emulate_set_target_port_groups(struct se_task *task) | |||
| 335 | * INVALID_PARAMETER_LIST | 341 | * INVALID_PARAMETER_LIST |
| 336 | */ | 342 | */ |
| 337 | if (rc != 0) { | 343 | if (rc != 0) { |
| 338 | rc = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 344 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 345 | rc = -EINVAL; | ||
| 339 | goto out; | 346 | goto out; |
| 340 | } | 347 | } |
| 341 | } | 348 | } |
| @@ -1184,7 +1191,6 @@ void core_alua_free_lu_gp(struct t10_alua_lu_gp *lu_gp) | |||
| 1184 | * struct t10_alua_lu_gp. | 1191 | * struct t10_alua_lu_gp. |
| 1185 | */ | 1192 | */ |
| 1186 | spin_lock(&lu_gps_lock); | 1193 | spin_lock(&lu_gps_lock); |
| 1187 | atomic_set(&lu_gp->lu_gp_shutdown, 1); | ||
| 1188 | list_del(&lu_gp->lu_gp_node); | 1194 | list_del(&lu_gp->lu_gp_node); |
| 1189 | alua_lu_gps_count--; | 1195 | alua_lu_gps_count--; |
| 1190 | spin_unlock(&lu_gps_lock); | 1196 | spin_unlock(&lu_gps_lock); |
| @@ -1438,7 +1444,6 @@ struct t10_alua_tg_pt_gp_member *core_alua_allocate_tg_pt_gp_mem( | |||
| 1438 | 1444 | ||
| 1439 | tg_pt_gp_mem->tg_pt = port; | 1445 | tg_pt_gp_mem->tg_pt = port; |
| 1440 | port->sep_alua_tg_pt_gp_mem = tg_pt_gp_mem; | 1446 | port->sep_alua_tg_pt_gp_mem = tg_pt_gp_mem; |
| 1441 | atomic_set(&port->sep_tg_pt_gp_active, 1); | ||
| 1442 | 1447 | ||
| 1443 | return tg_pt_gp_mem; | 1448 | return tg_pt_gp_mem; |
| 1444 | } | 1449 | } |
diff --git a/drivers/target/target_core_cdb.c b/drivers/target/target_core_cdb.c index 683ba02b8247..831468b3163d 100644 --- a/drivers/target/target_core_cdb.c +++ b/drivers/target/target_core_cdb.c | |||
| @@ -478,7 +478,7 @@ target_emulate_evpd_86(struct se_cmd *cmd, unsigned char *buf) | |||
| 478 | if (cmd->data_length < 60) | 478 | if (cmd->data_length < 60) |
| 479 | return 0; | 479 | return 0; |
| 480 | 480 | ||
| 481 | buf[2] = 0x3c; | 481 | buf[3] = 0x3c; |
| 482 | /* Set HEADSUP, ORDSUP, SIMPSUP */ | 482 | /* Set HEADSUP, ORDSUP, SIMPSUP */ |
| 483 | buf[5] = 0x07; | 483 | buf[5] = 0x07; |
| 484 | 484 | ||
| @@ -703,6 +703,7 @@ int target_emulate_inquiry(struct se_task *task) | |||
| 703 | if (cmd->data_length < 4) { | 703 | if (cmd->data_length < 4) { |
| 704 | pr_err("SCSI Inquiry payload length: %u" | 704 | pr_err("SCSI Inquiry payload length: %u" |
| 705 | " too small for EVPD=1\n", cmd->data_length); | 705 | " too small for EVPD=1\n", cmd->data_length); |
| 706 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; | ||
| 706 | return -EINVAL; | 707 | return -EINVAL; |
| 707 | } | 708 | } |
| 708 | 709 | ||
| @@ -719,6 +720,7 @@ int target_emulate_inquiry(struct se_task *task) | |||
| 719 | } | 720 | } |
| 720 | 721 | ||
| 721 | pr_err("Unknown VPD Code: 0x%02x\n", cdb[2]); | 722 | pr_err("Unknown VPD Code: 0x%02x\n", cdb[2]); |
| 723 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; | ||
| 722 | ret = -EINVAL; | 724 | ret = -EINVAL; |
| 723 | 725 | ||
| 724 | out_unmap: | 726 | out_unmap: |
| @@ -969,7 +971,8 @@ int target_emulate_modesense(struct se_task *task) | |||
| 969 | default: | 971 | default: |
| 970 | pr_err("MODE SENSE: unimplemented page/subpage: 0x%02x/0x%02x\n", | 972 | pr_err("MODE SENSE: unimplemented page/subpage: 0x%02x/0x%02x\n", |
| 971 | cdb[2] & 0x3f, cdb[3]); | 973 | cdb[2] & 0x3f, cdb[3]); |
| 972 | return PYX_TRANSPORT_UNKNOWN_MODE_PAGE; | 974 | cmd->scsi_sense_reason = TCM_UNKNOWN_MODE_PAGE; |
| 975 | return -EINVAL; | ||
| 973 | } | 976 | } |
| 974 | offset += length; | 977 | offset += length; |
| 975 | 978 | ||
| @@ -1027,7 +1030,8 @@ int target_emulate_request_sense(struct se_task *task) | |||
| 1027 | if (cdb[1] & 0x01) { | 1030 | if (cdb[1] & 0x01) { |
| 1028 | pr_err("REQUEST_SENSE description emulation not" | 1031 | pr_err("REQUEST_SENSE description emulation not" |
| 1029 | " supported\n"); | 1032 | " supported\n"); |
| 1030 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 1033 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 1034 | return -ENOSYS; | ||
| 1031 | } | 1035 | } |
| 1032 | 1036 | ||
| 1033 | buf = transport_kmap_first_data_page(cmd); | 1037 | buf = transport_kmap_first_data_page(cmd); |
| @@ -1100,7 +1104,8 @@ int target_emulate_unmap(struct se_task *task) | |||
| 1100 | if (!dev->transport->do_discard) { | 1104 | if (!dev->transport->do_discard) { |
| 1101 | pr_err("UNMAP emulation not supported for: %s\n", | 1105 | pr_err("UNMAP emulation not supported for: %s\n", |
| 1102 | dev->transport->name); | 1106 | dev->transport->name); |
| 1103 | return PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 1107 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 1108 | return -ENOSYS; | ||
| 1104 | } | 1109 | } |
| 1105 | 1110 | ||
| 1106 | /* First UNMAP block descriptor starts at 8 byte offset */ | 1111 | /* First UNMAP block descriptor starts at 8 byte offset */ |
| @@ -1157,7 +1162,8 @@ int target_emulate_write_same(struct se_task *task) | |||
| 1157 | if (!dev->transport->do_discard) { | 1162 | if (!dev->transport->do_discard) { |
| 1158 | pr_err("WRITE_SAME emulation not supported" | 1163 | pr_err("WRITE_SAME emulation not supported" |
| 1159 | " for: %s\n", dev->transport->name); | 1164 | " for: %s\n", dev->transport->name); |
| 1160 | return PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 1165 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 1166 | return -ENOSYS; | ||
| 1161 | } | 1167 | } |
| 1162 | 1168 | ||
| 1163 | if (cmd->t_task_cdb[0] == WRITE_SAME) | 1169 | if (cmd->t_task_cdb[0] == WRITE_SAME) |
| @@ -1193,11 +1199,13 @@ int target_emulate_write_same(struct se_task *task) | |||
| 1193 | int target_emulate_synchronize_cache(struct se_task *task) | 1199 | int target_emulate_synchronize_cache(struct se_task *task) |
| 1194 | { | 1200 | { |
| 1195 | struct se_device *dev = task->task_se_cmd->se_dev; | 1201 | struct se_device *dev = task->task_se_cmd->se_dev; |
| 1202 | struct se_cmd *cmd = task->task_se_cmd; | ||
| 1196 | 1203 | ||
| 1197 | if (!dev->transport->do_sync_cache) { | 1204 | if (!dev->transport->do_sync_cache) { |
| 1198 | pr_err("SYNCHRONIZE_CACHE emulation not supported" | 1205 | pr_err("SYNCHRONIZE_CACHE emulation not supported" |
| 1199 | " for: %s\n", dev->transport->name); | 1206 | " for: %s\n", dev->transport->name); |
| 1200 | return PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 1207 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 1208 | return -ENOSYS; | ||
| 1201 | } | 1209 | } |
| 1202 | 1210 | ||
| 1203 | dev->transport->do_sync_cache(task); | 1211 | dev->transport->do_sync_cache(task); |
diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index e0c1e8a8dd4e..93d4f6a1b798 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c | |||
| @@ -67,9 +67,6 @@ static struct config_group target_core_hbagroup; | |||
| 67 | static struct config_group alua_group; | 67 | static struct config_group alua_group; |
| 68 | static struct config_group alua_lu_gps_group; | 68 | static struct config_group alua_lu_gps_group; |
| 69 | 69 | ||
| 70 | static DEFINE_SPINLOCK(se_device_lock); | ||
| 71 | static LIST_HEAD(se_dev_list); | ||
| 72 | |||
| 73 | static inline struct se_hba * | 70 | static inline struct se_hba * |
| 74 | item_to_hba(struct config_item *item) | 71 | item_to_hba(struct config_item *item) |
| 75 | { | 72 | { |
| @@ -2741,7 +2738,6 @@ static struct config_group *target_core_make_subdev( | |||
| 2741 | " struct se_subsystem_dev\n"); | 2738 | " struct se_subsystem_dev\n"); |
| 2742 | goto unlock; | 2739 | goto unlock; |
| 2743 | } | 2740 | } |
| 2744 | INIT_LIST_HEAD(&se_dev->se_dev_node); | ||
| 2745 | INIT_LIST_HEAD(&se_dev->t10_wwn.t10_vpd_list); | 2741 | INIT_LIST_HEAD(&se_dev->t10_wwn.t10_vpd_list); |
| 2746 | spin_lock_init(&se_dev->t10_wwn.t10_vpd_lock); | 2742 | spin_lock_init(&se_dev->t10_wwn.t10_vpd_lock); |
| 2747 | INIT_LIST_HEAD(&se_dev->t10_pr.registration_list); | 2743 | INIT_LIST_HEAD(&se_dev->t10_pr.registration_list); |
| @@ -2777,9 +2773,6 @@ static struct config_group *target_core_make_subdev( | |||
| 2777 | " from allocate_virtdevice()\n"); | 2773 | " from allocate_virtdevice()\n"); |
| 2778 | goto out; | 2774 | goto out; |
| 2779 | } | 2775 | } |
| 2780 | spin_lock(&se_device_lock); | ||
| 2781 | list_add_tail(&se_dev->se_dev_node, &se_dev_list); | ||
| 2782 | spin_unlock(&se_device_lock); | ||
| 2783 | 2776 | ||
| 2784 | config_group_init_type_name(&se_dev->se_dev_group, name, | 2777 | config_group_init_type_name(&se_dev->se_dev_group, name, |
| 2785 | &target_core_dev_cit); | 2778 | &target_core_dev_cit); |
| @@ -2874,10 +2867,6 @@ static void target_core_drop_subdev( | |||
| 2874 | mutex_lock(&hba->hba_access_mutex); | 2867 | mutex_lock(&hba->hba_access_mutex); |
| 2875 | t = hba->transport; | 2868 | t = hba->transport; |
| 2876 | 2869 | ||
| 2877 | spin_lock(&se_device_lock); | ||
| 2878 | list_del(&se_dev->se_dev_node); | ||
| 2879 | spin_unlock(&se_device_lock); | ||
| 2880 | |||
| 2881 | dev_stat_grp = &se_dev->dev_stat_grps.stat_group; | 2870 | dev_stat_grp = &se_dev->dev_stat_grps.stat_group; |
| 2882 | for (i = 0; dev_stat_grp->default_groups[i]; i++) { | 2871 | for (i = 0; dev_stat_grp->default_groups[i]; i++) { |
| 2883 | df_item = &dev_stat_grp->default_groups[i]->cg_item; | 2872 | df_item = &dev_stat_grp->default_groups[i]->cg_item; |
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c index ba5edec2c5f8..9b8639425472 100644 --- a/drivers/target/target_core_device.c +++ b/drivers/target/target_core_device.c | |||
| @@ -104,7 +104,6 @@ int transport_lookup_cmd_lun(struct se_cmd *se_cmd, u32 unpacked_lun) | |||
| 104 | se_cmd->se_lun = deve->se_lun; | 104 | se_cmd->se_lun = deve->se_lun; |
| 105 | se_cmd->pr_res_key = deve->pr_res_key; | 105 | se_cmd->pr_res_key = deve->pr_res_key; |
| 106 | se_cmd->orig_fe_lun = unpacked_lun; | 106 | se_cmd->orig_fe_lun = unpacked_lun; |
| 107 | se_cmd->se_orig_obj_ptr = se_cmd->se_lun->lun_se_dev; | ||
| 108 | se_cmd->se_cmd_flags |= SCF_SE_LUN_CMD; | 107 | se_cmd->se_cmd_flags |= SCF_SE_LUN_CMD; |
| 109 | } | 108 | } |
| 110 | spin_unlock_irqrestore(&se_sess->se_node_acl->device_list_lock, flags); | 109 | spin_unlock_irqrestore(&se_sess->se_node_acl->device_list_lock, flags); |
| @@ -137,7 +136,6 @@ int transport_lookup_cmd_lun(struct se_cmd *se_cmd, u32 unpacked_lun) | |||
| 137 | se_lun = &se_sess->se_tpg->tpg_virt_lun0; | 136 | se_lun = &se_sess->se_tpg->tpg_virt_lun0; |
| 138 | se_cmd->se_lun = &se_sess->se_tpg->tpg_virt_lun0; | 137 | se_cmd->se_lun = &se_sess->se_tpg->tpg_virt_lun0; |
| 139 | se_cmd->orig_fe_lun = 0; | 138 | se_cmd->orig_fe_lun = 0; |
| 140 | se_cmd->se_orig_obj_ptr = se_cmd->se_lun->lun_se_dev; | ||
| 141 | se_cmd->se_cmd_flags |= SCF_SE_LUN_CMD; | 139 | se_cmd->se_cmd_flags |= SCF_SE_LUN_CMD; |
| 142 | } | 140 | } |
| 143 | /* | 141 | /* |
| @@ -200,7 +198,6 @@ int transport_lookup_tmr_lun(struct se_cmd *se_cmd, u32 unpacked_lun) | |||
| 200 | se_lun = deve->se_lun; | 198 | se_lun = deve->se_lun; |
| 201 | se_cmd->pr_res_key = deve->pr_res_key; | 199 | se_cmd->pr_res_key = deve->pr_res_key; |
| 202 | se_cmd->orig_fe_lun = unpacked_lun; | 200 | se_cmd->orig_fe_lun = unpacked_lun; |
| 203 | se_cmd->se_orig_obj_ptr = se_cmd->se_dev; | ||
| 204 | } | 201 | } |
| 205 | spin_unlock_irqrestore(&se_sess->se_node_acl->device_list_lock, flags); | 202 | spin_unlock_irqrestore(&se_sess->se_node_acl->device_list_lock, flags); |
| 206 | 203 | ||
| @@ -708,7 +705,7 @@ done: | |||
| 708 | 705 | ||
| 709 | se_task->task_scsi_status = GOOD; | 706 | se_task->task_scsi_status = GOOD; |
| 710 | transport_complete_task(se_task, 1); | 707 | transport_complete_task(se_task, 1); |
| 711 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 708 | return 0; |
| 712 | } | 709 | } |
| 713 | 710 | ||
| 714 | /* se_release_device_for_hba(): | 711 | /* se_release_device_for_hba(): |
| @@ -957,8 +954,12 @@ int se_dev_set_emulate_dpo(struct se_device *dev, int flag) | |||
| 957 | return -EINVAL; | 954 | return -EINVAL; |
| 958 | } | 955 | } |
| 959 | 956 | ||
| 960 | pr_err("dpo_emulated not supported\n"); | 957 | if (flag) { |
| 961 | return -EINVAL; | 958 | pr_err("dpo_emulated not supported\n"); |
| 959 | return -EINVAL; | ||
| 960 | } | ||
| 961 | |||
| 962 | return 0; | ||
| 962 | } | 963 | } |
| 963 | 964 | ||
| 964 | int se_dev_set_emulate_fua_write(struct se_device *dev, int flag) | 965 | int se_dev_set_emulate_fua_write(struct se_device *dev, int flag) |
| @@ -968,7 +969,7 @@ int se_dev_set_emulate_fua_write(struct se_device *dev, int flag) | |||
| 968 | return -EINVAL; | 969 | return -EINVAL; |
| 969 | } | 970 | } |
| 970 | 971 | ||
| 971 | if (dev->transport->fua_write_emulated == 0) { | 972 | if (flag && dev->transport->fua_write_emulated == 0) { |
| 972 | pr_err("fua_write_emulated not supported\n"); | 973 | pr_err("fua_write_emulated not supported\n"); |
| 973 | return -EINVAL; | 974 | return -EINVAL; |
| 974 | } | 975 | } |
| @@ -985,8 +986,12 @@ int se_dev_set_emulate_fua_read(struct se_device *dev, int flag) | |||
| 985 | return -EINVAL; | 986 | return -EINVAL; |
| 986 | } | 987 | } |
| 987 | 988 | ||
| 988 | pr_err("ua read emulated not supported\n"); | 989 | if (flag) { |
| 989 | return -EINVAL; | 990 | pr_err("ua read emulated not supported\n"); |
| 991 | return -EINVAL; | ||
| 992 | } | ||
| 993 | |||
| 994 | return 0; | ||
| 990 | } | 995 | } |
| 991 | 996 | ||
| 992 | int se_dev_set_emulate_write_cache(struct se_device *dev, int flag) | 997 | int se_dev_set_emulate_write_cache(struct se_device *dev, int flag) |
| @@ -995,7 +1000,7 @@ int se_dev_set_emulate_write_cache(struct se_device *dev, int flag) | |||
| 995 | pr_err("Illegal value %d\n", flag); | 1000 | pr_err("Illegal value %d\n", flag); |
| 996 | return -EINVAL; | 1001 | return -EINVAL; |
| 997 | } | 1002 | } |
| 998 | if (dev->transport->write_cache_emulated == 0) { | 1003 | if (flag && dev->transport->write_cache_emulated == 0) { |
| 999 | pr_err("write_cache_emulated not supported\n"); | 1004 | pr_err("write_cache_emulated not supported\n"); |
| 1000 | return -EINVAL; | 1005 | return -EINVAL; |
| 1001 | } | 1006 | } |
| @@ -1056,7 +1061,7 @@ int se_dev_set_emulate_tpu(struct se_device *dev, int flag) | |||
| 1056 | * We expect this value to be non-zero when generic Block Layer | 1061 | * We expect this value to be non-zero when generic Block Layer |
| 1057 | * Discard supported is detected iblock_create_virtdevice(). | 1062 | * Discard supported is detected iblock_create_virtdevice(). |
| 1058 | */ | 1063 | */ |
| 1059 | if (!dev->se_sub_dev->se_dev_attrib.max_unmap_block_desc_count) { | 1064 | if (flag && !dev->se_sub_dev->se_dev_attrib.max_unmap_block_desc_count) { |
| 1060 | pr_err("Generic Block Discard not supported\n"); | 1065 | pr_err("Generic Block Discard not supported\n"); |
| 1061 | return -ENOSYS; | 1066 | return -ENOSYS; |
| 1062 | } | 1067 | } |
| @@ -1077,7 +1082,7 @@ int se_dev_set_emulate_tpws(struct se_device *dev, int flag) | |||
| 1077 | * We expect this value to be non-zero when generic Block Layer | 1082 | * We expect this value to be non-zero when generic Block Layer |
| 1078 | * Discard supported is detected iblock_create_virtdevice(). | 1083 | * Discard supported is detected iblock_create_virtdevice(). |
| 1079 | */ | 1084 | */ |
| 1080 | if (!dev->se_sub_dev->se_dev_attrib.max_unmap_block_desc_count) { | 1085 | if (flag && !dev->se_sub_dev->se_dev_attrib.max_unmap_block_desc_count) { |
| 1081 | pr_err("Generic Block Discard not supported\n"); | 1086 | pr_err("Generic Block Discard not supported\n"); |
| 1082 | return -ENOSYS; | 1087 | return -ENOSYS; |
| 1083 | } | 1088 | } |
| @@ -1587,7 +1592,6 @@ int core_dev_setup_virtual_lun0(void) | |||
| 1587 | ret = -ENOMEM; | 1592 | ret = -ENOMEM; |
| 1588 | goto out; | 1593 | goto out; |
| 1589 | } | 1594 | } |
| 1590 | INIT_LIST_HEAD(&se_dev->se_dev_node); | ||
| 1591 | INIT_LIST_HEAD(&se_dev->t10_wwn.t10_vpd_list); | 1595 | INIT_LIST_HEAD(&se_dev->t10_wwn.t10_vpd_list); |
| 1592 | spin_lock_init(&se_dev->t10_wwn.t10_vpd_lock); | 1596 | spin_lock_init(&se_dev->t10_wwn.t10_vpd_lock); |
| 1593 | INIT_LIST_HEAD(&se_dev->t10_pr.registration_list); | 1597 | INIT_LIST_HEAD(&se_dev->t10_pr.registration_list); |
diff --git a/drivers/target/target_core_file.c b/drivers/target/target_core_file.c index 67cd6fe05bfa..b4864fba4ef0 100644 --- a/drivers/target/target_core_file.c +++ b/drivers/target/target_core_file.c | |||
| @@ -289,9 +289,9 @@ static int fd_do_readv(struct se_task *task) | |||
| 289 | return -ENOMEM; | 289 | return -ENOMEM; |
| 290 | } | 290 | } |
| 291 | 291 | ||
| 292 | for (i = 0; i < task->task_sg_nents; i++) { | 292 | for_each_sg(task->task_sg, sg, task->task_sg_nents, i) { |
| 293 | iov[i].iov_len = sg[i].length; | 293 | iov[i].iov_len = sg->length; |
| 294 | iov[i].iov_base = sg_virt(&sg[i]); | 294 | iov[i].iov_base = sg_virt(sg); |
| 295 | } | 295 | } |
| 296 | 296 | ||
| 297 | old_fs = get_fs(); | 297 | old_fs = get_fs(); |
| @@ -342,9 +342,9 @@ static int fd_do_writev(struct se_task *task) | |||
| 342 | return -ENOMEM; | 342 | return -ENOMEM; |
| 343 | } | 343 | } |
| 344 | 344 | ||
| 345 | for (i = 0; i < task->task_sg_nents; i++) { | 345 | for_each_sg(task->task_sg, sg, task->task_sg_nents, i) { |
| 346 | iov[i].iov_len = sg[i].length; | 346 | iov[i].iov_len = sg->length; |
| 347 | iov[i].iov_base = sg_virt(&sg[i]); | 347 | iov[i].iov_base = sg_virt(sg); |
| 348 | } | 348 | } |
| 349 | 349 | ||
| 350 | old_fs = get_fs(); | 350 | old_fs = get_fs(); |
| @@ -438,7 +438,7 @@ static int fd_do_task(struct se_task *task) | |||
| 438 | if (ret > 0 && | 438 | if (ret > 0 && |
| 439 | dev->se_sub_dev->se_dev_attrib.emulate_write_cache > 0 && | 439 | dev->se_sub_dev->se_dev_attrib.emulate_write_cache > 0 && |
| 440 | dev->se_sub_dev->se_dev_attrib.emulate_fua_write > 0 && | 440 | dev->se_sub_dev->se_dev_attrib.emulate_fua_write > 0 && |
| 441 | cmd->t_tasks_fua) { | 441 | (cmd->se_cmd_flags & SCF_FUA)) { |
| 442 | /* | 442 | /* |
| 443 | * We might need to be a bit smarter here | 443 | * We might need to be a bit smarter here |
| 444 | * and return some sense data to let the initiator | 444 | * and return some sense data to let the initiator |
| @@ -449,13 +449,15 @@ static int fd_do_task(struct se_task *task) | |||
| 449 | 449 | ||
| 450 | } | 450 | } |
| 451 | 451 | ||
| 452 | if (ret < 0) | 452 | if (ret < 0) { |
| 453 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 453 | return ret; | 454 | return ret; |
| 455 | } | ||
| 454 | if (ret) { | 456 | if (ret) { |
| 455 | task->task_scsi_status = GOOD; | 457 | task->task_scsi_status = GOOD; |
| 456 | transport_complete_task(task, 1); | 458 | transport_complete_task(task, 1); |
| 457 | } | 459 | } |
| 458 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 460 | return 0; |
| 459 | } | 461 | } |
| 460 | 462 | ||
| 461 | /* fd_free_task(): (Part of se_subsystem_api_t template) | 463 | /* fd_free_task(): (Part of se_subsystem_api_t template) |
diff --git a/drivers/target/target_core_iblock.c b/drivers/target/target_core_iblock.c index 7698efe29262..4aa992204438 100644 --- a/drivers/target/target_core_iblock.c +++ b/drivers/target/target_core_iblock.c | |||
| @@ -531,7 +531,7 @@ static int iblock_do_task(struct se_task *task) | |||
| 531 | */ | 531 | */ |
| 532 | if (dev->se_sub_dev->se_dev_attrib.emulate_write_cache == 0 || | 532 | if (dev->se_sub_dev->se_dev_attrib.emulate_write_cache == 0 || |
| 533 | (dev->se_sub_dev->se_dev_attrib.emulate_fua_write > 0 && | 533 | (dev->se_sub_dev->se_dev_attrib.emulate_fua_write > 0 && |
| 534 | task->task_se_cmd->t_tasks_fua)) | 534 | (cmd->se_cmd_flags & SCF_FUA))) |
| 535 | rw = WRITE_FUA; | 535 | rw = WRITE_FUA; |
| 536 | else | 536 | else |
| 537 | rw = WRITE; | 537 | rw = WRITE; |
| @@ -554,12 +554,15 @@ static int iblock_do_task(struct se_task *task) | |||
| 554 | else { | 554 | else { |
| 555 | pr_err("Unsupported SCSI -> BLOCK LBA conversion:" | 555 | pr_err("Unsupported SCSI -> BLOCK LBA conversion:" |
| 556 | " %u\n", dev->se_sub_dev->se_dev_attrib.block_size); | 556 | " %u\n", dev->se_sub_dev->se_dev_attrib.block_size); |
| 557 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 557 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 558 | return -ENOSYS; | ||
| 558 | } | 559 | } |
| 559 | 560 | ||
| 560 | bio = iblock_get_bio(task, block_lba, sg_num); | 561 | bio = iblock_get_bio(task, block_lba, sg_num); |
| 561 | if (!bio) | 562 | if (!bio) { |
| 562 | return PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES; | 563 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 564 | return -ENOMEM; | ||
| 565 | } | ||
| 563 | 566 | ||
| 564 | bio_list_init(&list); | 567 | bio_list_init(&list); |
| 565 | bio_list_add(&list, bio); | 568 | bio_list_add(&list, bio); |
| @@ -588,12 +591,13 @@ static int iblock_do_task(struct se_task *task) | |||
| 588 | submit_bio(rw, bio); | 591 | submit_bio(rw, bio); |
| 589 | blk_finish_plug(&plug); | 592 | blk_finish_plug(&plug); |
| 590 | 593 | ||
| 591 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 594 | return 0; |
| 592 | 595 | ||
| 593 | fail: | 596 | fail: |
| 594 | while ((bio = bio_list_pop(&list))) | 597 | while ((bio = bio_list_pop(&list))) |
| 595 | bio_put(bio); | 598 | bio_put(bio); |
| 596 | return PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES; | 599 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 600 | return -ENOMEM; | ||
| 597 | } | 601 | } |
| 598 | 602 | ||
| 599 | static u32 iblock_get_device_rev(struct se_device *dev) | 603 | static u32 iblock_get_device_rev(struct se_device *dev) |
diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index 5a4ebfc3a54f..95dee7074aeb 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c | |||
| @@ -191,7 +191,7 @@ static int target_check_scsi2_reservation_conflict(struct se_cmd *cmd, int *ret) | |||
| 191 | pr_err("Received legacy SPC-2 RESERVE/RELEASE" | 191 | pr_err("Received legacy SPC-2 RESERVE/RELEASE" |
| 192 | " while active SPC-3 registrations exist," | 192 | " while active SPC-3 registrations exist," |
| 193 | " returning RESERVATION_CONFLICT\n"); | 193 | " returning RESERVATION_CONFLICT\n"); |
| 194 | *ret = PYX_TRANSPORT_RESERVATION_CONFLICT; | 194 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 195 | return true; | 195 | return true; |
| 196 | } | 196 | } |
| 197 | 197 | ||
| @@ -252,7 +252,8 @@ int target_scsi2_reservation_reserve(struct se_task *task) | |||
| 252 | (cmd->t_task_cdb[1] & 0x02)) { | 252 | (cmd->t_task_cdb[1] & 0x02)) { |
| 253 | pr_err("LongIO and Obselete Bits set, returning" | 253 | pr_err("LongIO and Obselete Bits set, returning" |
| 254 | " ILLEGAL_REQUEST\n"); | 254 | " ILLEGAL_REQUEST\n"); |
| 255 | ret = PYX_TRANSPORT_ILLEGAL_REQUEST; | 255 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 256 | ret = -EINVAL; | ||
| 256 | goto out; | 257 | goto out; |
| 257 | } | 258 | } |
| 258 | /* | 259 | /* |
| @@ -277,7 +278,8 @@ int target_scsi2_reservation_reserve(struct se_task *task) | |||
| 277 | " from %s \n", cmd->se_lun->unpacked_lun, | 278 | " from %s \n", cmd->se_lun->unpacked_lun, |
| 278 | cmd->se_deve->mapped_lun, | 279 | cmd->se_deve->mapped_lun, |
| 279 | sess->se_node_acl->initiatorname); | 280 | sess->se_node_acl->initiatorname); |
| 280 | ret = PYX_TRANSPORT_RESERVATION_CONFLICT; | 281 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 282 | ret = -EINVAL; | ||
| 281 | goto out_unlock; | 283 | goto out_unlock; |
| 282 | } | 284 | } |
| 283 | 285 | ||
| @@ -1510,7 +1512,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1510 | tidh_new = kzalloc(sizeof(struct pr_transport_id_holder), GFP_KERNEL); | 1512 | tidh_new = kzalloc(sizeof(struct pr_transport_id_holder), GFP_KERNEL); |
| 1511 | if (!tidh_new) { | 1513 | if (!tidh_new) { |
| 1512 | pr_err("Unable to allocate tidh_new\n"); | 1514 | pr_err("Unable to allocate tidh_new\n"); |
| 1513 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 1515 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 1516 | return -EINVAL; | ||
| 1514 | } | 1517 | } |
| 1515 | INIT_LIST_HEAD(&tidh_new->dest_list); | 1518 | INIT_LIST_HEAD(&tidh_new->dest_list); |
| 1516 | tidh_new->dest_tpg = tpg; | 1519 | tidh_new->dest_tpg = tpg; |
| @@ -1522,7 +1525,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1522 | sa_res_key, all_tg_pt, aptpl); | 1525 | sa_res_key, all_tg_pt, aptpl); |
| 1523 | if (!local_pr_reg) { | 1526 | if (!local_pr_reg) { |
| 1524 | kfree(tidh_new); | 1527 | kfree(tidh_new); |
| 1525 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 1528 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 1529 | return -ENOMEM; | ||
| 1526 | } | 1530 | } |
| 1527 | tidh_new->dest_pr_reg = local_pr_reg; | 1531 | tidh_new->dest_pr_reg = local_pr_reg; |
| 1528 | /* | 1532 | /* |
| @@ -1548,7 +1552,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1548 | pr_err("SPC-3 PR: Illegal tpdl: %u + 28 byte header" | 1552 | pr_err("SPC-3 PR: Illegal tpdl: %u + 28 byte header" |
| 1549 | " does not equal CDB data_length: %u\n", tpdl, | 1553 | " does not equal CDB data_length: %u\n", tpdl, |
| 1550 | cmd->data_length); | 1554 | cmd->data_length); |
| 1551 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 1555 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 1556 | ret = -EINVAL; | ||
| 1552 | goto out; | 1557 | goto out; |
| 1553 | } | 1558 | } |
| 1554 | /* | 1559 | /* |
| @@ -1598,7 +1603,9 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1598 | " for tmp_tpg\n"); | 1603 | " for tmp_tpg\n"); |
| 1599 | atomic_dec(&tmp_tpg->tpg_pr_ref_count); | 1604 | atomic_dec(&tmp_tpg->tpg_pr_ref_count); |
| 1600 | smp_mb__after_atomic_dec(); | 1605 | smp_mb__after_atomic_dec(); |
| 1601 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 1606 | cmd->scsi_sense_reason = |
| 1607 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1608 | ret = -EINVAL; | ||
| 1602 | goto out; | 1609 | goto out; |
| 1603 | } | 1610 | } |
| 1604 | /* | 1611 | /* |
| @@ -1628,7 +1635,9 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1628 | atomic_dec(&dest_node_acl->acl_pr_ref_count); | 1635 | atomic_dec(&dest_node_acl->acl_pr_ref_count); |
| 1629 | smp_mb__after_atomic_dec(); | 1636 | smp_mb__after_atomic_dec(); |
| 1630 | core_scsi3_tpg_undepend_item(tmp_tpg); | 1637 | core_scsi3_tpg_undepend_item(tmp_tpg); |
| 1631 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 1638 | cmd->scsi_sense_reason = |
| 1639 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1640 | ret = -EINVAL; | ||
| 1632 | goto out; | 1641 | goto out; |
| 1633 | } | 1642 | } |
| 1634 | 1643 | ||
| @@ -1646,7 +1655,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1646 | if (!dest_tpg) { | 1655 | if (!dest_tpg) { |
| 1647 | pr_err("SPC-3 PR SPEC_I_PT: Unable to locate" | 1656 | pr_err("SPC-3 PR SPEC_I_PT: Unable to locate" |
| 1648 | " dest_tpg\n"); | 1657 | " dest_tpg\n"); |
| 1649 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 1658 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 1659 | ret = -EINVAL; | ||
| 1650 | goto out; | 1660 | goto out; |
| 1651 | } | 1661 | } |
| 1652 | #if 0 | 1662 | #if 0 |
| @@ -1660,7 +1670,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1660 | " %u for Transport ID: %s\n", tid_len, ptr); | 1670 | " %u for Transport ID: %s\n", tid_len, ptr); |
| 1661 | core_scsi3_nodeacl_undepend_item(dest_node_acl); | 1671 | core_scsi3_nodeacl_undepend_item(dest_node_acl); |
| 1662 | core_scsi3_tpg_undepend_item(dest_tpg); | 1672 | core_scsi3_tpg_undepend_item(dest_tpg); |
| 1663 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 1673 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 1674 | ret = -EINVAL; | ||
| 1664 | goto out; | 1675 | goto out; |
| 1665 | } | 1676 | } |
| 1666 | /* | 1677 | /* |
| @@ -1678,7 +1689,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1678 | 1689 | ||
| 1679 | core_scsi3_nodeacl_undepend_item(dest_node_acl); | 1690 | core_scsi3_nodeacl_undepend_item(dest_node_acl); |
| 1680 | core_scsi3_tpg_undepend_item(dest_tpg); | 1691 | core_scsi3_tpg_undepend_item(dest_tpg); |
| 1681 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 1692 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 1693 | ret = -EINVAL; | ||
| 1682 | goto out; | 1694 | goto out; |
| 1683 | } | 1695 | } |
| 1684 | 1696 | ||
| @@ -1690,7 +1702,9 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1690 | smp_mb__after_atomic_dec(); | 1702 | smp_mb__after_atomic_dec(); |
| 1691 | core_scsi3_nodeacl_undepend_item(dest_node_acl); | 1703 | core_scsi3_nodeacl_undepend_item(dest_node_acl); |
| 1692 | core_scsi3_tpg_undepend_item(dest_tpg); | 1704 | core_scsi3_tpg_undepend_item(dest_tpg); |
| 1693 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 1705 | cmd->scsi_sense_reason = |
| 1706 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1707 | ret = -EINVAL; | ||
| 1694 | goto out; | 1708 | goto out; |
| 1695 | } | 1709 | } |
| 1696 | #if 0 | 1710 | #if 0 |
| @@ -1727,7 +1741,9 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1727 | core_scsi3_lunacl_undepend_item(dest_se_deve); | 1741 | core_scsi3_lunacl_undepend_item(dest_se_deve); |
| 1728 | core_scsi3_nodeacl_undepend_item(dest_node_acl); | 1742 | core_scsi3_nodeacl_undepend_item(dest_node_acl); |
| 1729 | core_scsi3_tpg_undepend_item(dest_tpg); | 1743 | core_scsi3_tpg_undepend_item(dest_tpg); |
| 1730 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 1744 | cmd->scsi_sense_reason = |
| 1745 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1746 | ret = -ENOMEM; | ||
| 1731 | goto out; | 1747 | goto out; |
| 1732 | } | 1748 | } |
| 1733 | INIT_LIST_HEAD(&tidh_new->dest_list); | 1749 | INIT_LIST_HEAD(&tidh_new->dest_list); |
| @@ -1759,7 +1775,8 @@ static int core_scsi3_decode_spec_i_port( | |||
| 1759 | core_scsi3_nodeacl_undepend_item(dest_node_acl); | 1775 | core_scsi3_nodeacl_undepend_item(dest_node_acl); |
| 1760 | core_scsi3_tpg_undepend_item(dest_tpg); | 1776 | core_scsi3_tpg_undepend_item(dest_tpg); |
| 1761 | kfree(tidh_new); | 1777 | kfree(tidh_new); |
| 1762 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 1778 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 1779 | ret = -EINVAL; | ||
| 1763 | goto out; | 1780 | goto out; |
| 1764 | } | 1781 | } |
| 1765 | tidh_new->dest_pr_reg = dest_pr_reg; | 1782 | tidh_new->dest_pr_reg = dest_pr_reg; |
| @@ -2098,7 +2115,8 @@ static int core_scsi3_emulate_pro_register( | |||
| 2098 | 2115 | ||
| 2099 | if (!se_sess || !se_lun) { | 2116 | if (!se_sess || !se_lun) { |
| 2100 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); | 2117 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); |
| 2101 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2118 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2119 | return -EINVAL; | ||
| 2102 | } | 2120 | } |
| 2103 | se_tpg = se_sess->se_tpg; | 2121 | se_tpg = se_sess->se_tpg; |
| 2104 | se_deve = &se_sess->se_node_acl->device_list[cmd->orig_fe_lun]; | 2122 | se_deve = &se_sess->se_node_acl->device_list[cmd->orig_fe_lun]; |
| @@ -2117,13 +2135,14 @@ static int core_scsi3_emulate_pro_register( | |||
| 2117 | if (res_key) { | 2135 | if (res_key) { |
| 2118 | pr_warn("SPC-3 PR: Reservation Key non-zero" | 2136 | pr_warn("SPC-3 PR: Reservation Key non-zero" |
| 2119 | " for SA REGISTER, returning CONFLICT\n"); | 2137 | " for SA REGISTER, returning CONFLICT\n"); |
| 2120 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2138 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2139 | return -EINVAL; | ||
| 2121 | } | 2140 | } |
| 2122 | /* | 2141 | /* |
| 2123 | * Do nothing but return GOOD status. | 2142 | * Do nothing but return GOOD status. |
| 2124 | */ | 2143 | */ |
| 2125 | if (!sa_res_key) | 2144 | if (!sa_res_key) |
| 2126 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 2145 | return 0; |
| 2127 | 2146 | ||
| 2128 | if (!spec_i_pt) { | 2147 | if (!spec_i_pt) { |
| 2129 | /* | 2148 | /* |
| @@ -2138,7 +2157,8 @@ static int core_scsi3_emulate_pro_register( | |||
| 2138 | if (ret != 0) { | 2157 | if (ret != 0) { |
| 2139 | pr_err("Unable to allocate" | 2158 | pr_err("Unable to allocate" |
| 2140 | " struct t10_pr_registration\n"); | 2159 | " struct t10_pr_registration\n"); |
| 2141 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 2160 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 2161 | return -EINVAL; | ||
| 2142 | } | 2162 | } |
| 2143 | } else { | 2163 | } else { |
| 2144 | /* | 2164 | /* |
| @@ -2197,14 +2217,16 @@ static int core_scsi3_emulate_pro_register( | |||
| 2197 | " 0x%016Lx\n", res_key, | 2217 | " 0x%016Lx\n", res_key, |
| 2198 | pr_reg->pr_res_key); | 2218 | pr_reg->pr_res_key); |
| 2199 | core_scsi3_put_pr_reg(pr_reg); | 2219 | core_scsi3_put_pr_reg(pr_reg); |
| 2200 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2220 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2221 | return -EINVAL; | ||
| 2201 | } | 2222 | } |
| 2202 | } | 2223 | } |
| 2203 | if (spec_i_pt) { | 2224 | if (spec_i_pt) { |
| 2204 | pr_err("SPC-3 PR UNREGISTER: SPEC_I_PT" | 2225 | pr_err("SPC-3 PR UNREGISTER: SPEC_I_PT" |
| 2205 | " set while sa_res_key=0\n"); | 2226 | " set while sa_res_key=0\n"); |
| 2206 | core_scsi3_put_pr_reg(pr_reg); | 2227 | core_scsi3_put_pr_reg(pr_reg); |
| 2207 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 2228 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 2229 | return -EINVAL; | ||
| 2208 | } | 2230 | } |
| 2209 | /* | 2231 | /* |
| 2210 | * An existing ALL_TG_PT=1 registration being released | 2232 | * An existing ALL_TG_PT=1 registration being released |
| @@ -2215,7 +2237,8 @@ static int core_scsi3_emulate_pro_register( | |||
| 2215 | " registration exists, but ALL_TG_PT=1 bit not" | 2237 | " registration exists, but ALL_TG_PT=1 bit not" |
| 2216 | " present in received PROUT\n"); | 2238 | " present in received PROUT\n"); |
| 2217 | core_scsi3_put_pr_reg(pr_reg); | 2239 | core_scsi3_put_pr_reg(pr_reg); |
| 2218 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 2240 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 2241 | return -EINVAL; | ||
| 2219 | } | 2242 | } |
| 2220 | /* | 2243 | /* |
| 2221 | * Allocate APTPL metadata buffer used for UNREGISTER ops | 2244 | * Allocate APTPL metadata buffer used for UNREGISTER ops |
| @@ -2227,7 +2250,9 @@ static int core_scsi3_emulate_pro_register( | |||
| 2227 | pr_err("Unable to allocate" | 2250 | pr_err("Unable to allocate" |
| 2228 | " pr_aptpl_buf\n"); | 2251 | " pr_aptpl_buf\n"); |
| 2229 | core_scsi3_put_pr_reg(pr_reg); | 2252 | core_scsi3_put_pr_reg(pr_reg); |
| 2230 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2253 | cmd->scsi_sense_reason = |
| 2254 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 2255 | return -EINVAL; | ||
| 2231 | } | 2256 | } |
| 2232 | } | 2257 | } |
| 2233 | /* | 2258 | /* |
| @@ -2241,7 +2266,8 @@ static int core_scsi3_emulate_pro_register( | |||
| 2241 | if (pr_holder < 0) { | 2266 | if (pr_holder < 0) { |
| 2242 | kfree(pr_aptpl_buf); | 2267 | kfree(pr_aptpl_buf); |
| 2243 | core_scsi3_put_pr_reg(pr_reg); | 2268 | core_scsi3_put_pr_reg(pr_reg); |
| 2244 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2269 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2270 | return -EINVAL; | ||
| 2245 | } | 2271 | } |
| 2246 | 2272 | ||
| 2247 | spin_lock(&pr_tmpl->registration_lock); | 2273 | spin_lock(&pr_tmpl->registration_lock); |
| @@ -2405,7 +2431,8 @@ static int core_scsi3_pro_reserve( | |||
| 2405 | 2431 | ||
| 2406 | if (!se_sess || !se_lun) { | 2432 | if (!se_sess || !se_lun) { |
| 2407 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); | 2433 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); |
| 2408 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2434 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2435 | return -EINVAL; | ||
| 2409 | } | 2436 | } |
| 2410 | se_tpg = se_sess->se_tpg; | 2437 | se_tpg = se_sess->se_tpg; |
| 2411 | se_deve = &se_sess->se_node_acl->device_list[cmd->orig_fe_lun]; | 2438 | se_deve = &se_sess->se_node_acl->device_list[cmd->orig_fe_lun]; |
| @@ -2417,7 +2444,8 @@ static int core_scsi3_pro_reserve( | |||
| 2417 | if (!pr_reg) { | 2444 | if (!pr_reg) { |
| 2418 | pr_err("SPC-3 PR: Unable to locate" | 2445 | pr_err("SPC-3 PR: Unable to locate" |
| 2419 | " PR_REGISTERED *pr_reg for RESERVE\n"); | 2446 | " PR_REGISTERED *pr_reg for RESERVE\n"); |
| 2420 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2447 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2448 | return -EINVAL; | ||
| 2421 | } | 2449 | } |
| 2422 | /* | 2450 | /* |
| 2423 | * From spc4r17 Section 5.7.9: Reserving: | 2451 | * From spc4r17 Section 5.7.9: Reserving: |
| @@ -2433,7 +2461,8 @@ static int core_scsi3_pro_reserve( | |||
| 2433 | " does not match existing SA REGISTER res_key:" | 2461 | " does not match existing SA REGISTER res_key:" |
| 2434 | " 0x%016Lx\n", res_key, pr_reg->pr_res_key); | 2462 | " 0x%016Lx\n", res_key, pr_reg->pr_res_key); |
| 2435 | core_scsi3_put_pr_reg(pr_reg); | 2463 | core_scsi3_put_pr_reg(pr_reg); |
| 2436 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2464 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2465 | return -EINVAL; | ||
| 2437 | } | 2466 | } |
| 2438 | /* | 2467 | /* |
| 2439 | * From spc4r17 Section 5.7.9: Reserving: | 2468 | * From spc4r17 Section 5.7.9: Reserving: |
| @@ -2448,7 +2477,8 @@ static int core_scsi3_pro_reserve( | |||
| 2448 | if (scope != PR_SCOPE_LU_SCOPE) { | 2477 | if (scope != PR_SCOPE_LU_SCOPE) { |
| 2449 | pr_err("SPC-3 PR: Illegal SCOPE: 0x%02x\n", scope); | 2478 | pr_err("SPC-3 PR: Illegal SCOPE: 0x%02x\n", scope); |
| 2450 | core_scsi3_put_pr_reg(pr_reg); | 2479 | core_scsi3_put_pr_reg(pr_reg); |
| 2451 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 2480 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 2481 | return -EINVAL; | ||
| 2452 | } | 2482 | } |
| 2453 | /* | 2483 | /* |
| 2454 | * See if we have an existing PR reservation holder pointer at | 2484 | * See if we have an existing PR reservation holder pointer at |
| @@ -2480,7 +2510,8 @@ static int core_scsi3_pro_reserve( | |||
| 2480 | 2510 | ||
| 2481 | spin_unlock(&dev->dev_reservation_lock); | 2511 | spin_unlock(&dev->dev_reservation_lock); |
| 2482 | core_scsi3_put_pr_reg(pr_reg); | 2512 | core_scsi3_put_pr_reg(pr_reg); |
| 2483 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2513 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2514 | return -EINVAL; | ||
| 2484 | } | 2515 | } |
| 2485 | /* | 2516 | /* |
| 2486 | * From spc4r17 Section 5.7.9: Reserving: | 2517 | * From spc4r17 Section 5.7.9: Reserving: |
| @@ -2503,7 +2534,8 @@ static int core_scsi3_pro_reserve( | |||
| 2503 | 2534 | ||
| 2504 | spin_unlock(&dev->dev_reservation_lock); | 2535 | spin_unlock(&dev->dev_reservation_lock); |
| 2505 | core_scsi3_put_pr_reg(pr_reg); | 2536 | core_scsi3_put_pr_reg(pr_reg); |
| 2506 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2537 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2538 | return -EINVAL; | ||
| 2507 | } | 2539 | } |
| 2508 | /* | 2540 | /* |
| 2509 | * From spc4r17 Section 5.7.9: Reserving: | 2541 | * From spc4r17 Section 5.7.9: Reserving: |
| @@ -2517,7 +2549,7 @@ static int core_scsi3_pro_reserve( | |||
| 2517 | */ | 2549 | */ |
| 2518 | spin_unlock(&dev->dev_reservation_lock); | 2550 | spin_unlock(&dev->dev_reservation_lock); |
| 2519 | core_scsi3_put_pr_reg(pr_reg); | 2551 | core_scsi3_put_pr_reg(pr_reg); |
| 2520 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 2552 | return 0; |
| 2521 | } | 2553 | } |
| 2522 | /* | 2554 | /* |
| 2523 | * Otherwise, our *pr_reg becomes the PR reservation holder for said | 2555 | * Otherwise, our *pr_reg becomes the PR reservation holder for said |
| @@ -2574,7 +2606,8 @@ static int core_scsi3_emulate_pro_reserve( | |||
| 2574 | default: | 2606 | default: |
| 2575 | pr_err("SPC-3 PR: Unknown Service Action RESERVE Type:" | 2607 | pr_err("SPC-3 PR: Unknown Service Action RESERVE Type:" |
| 2576 | " 0x%02x\n", type); | 2608 | " 0x%02x\n", type); |
| 2577 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 2609 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 2610 | return -EINVAL; | ||
| 2578 | } | 2611 | } |
| 2579 | 2612 | ||
| 2580 | return ret; | 2613 | return ret; |
| @@ -2630,7 +2663,8 @@ static int core_scsi3_emulate_pro_release( | |||
| 2630 | 2663 | ||
| 2631 | if (!se_sess || !se_lun) { | 2664 | if (!se_sess || !se_lun) { |
| 2632 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); | 2665 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); |
| 2633 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2666 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2667 | return -EINVAL; | ||
| 2634 | } | 2668 | } |
| 2635 | /* | 2669 | /* |
| 2636 | * Locate the existing *pr_reg via struct se_node_acl pointers | 2670 | * Locate the existing *pr_reg via struct se_node_acl pointers |
| @@ -2639,7 +2673,8 @@ static int core_scsi3_emulate_pro_release( | |||
| 2639 | if (!pr_reg) { | 2673 | if (!pr_reg) { |
| 2640 | pr_err("SPC-3 PR: Unable to locate" | 2674 | pr_err("SPC-3 PR: Unable to locate" |
| 2641 | " PR_REGISTERED *pr_reg for RELEASE\n"); | 2675 | " PR_REGISTERED *pr_reg for RELEASE\n"); |
| 2642 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2676 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2677 | return -EINVAL; | ||
| 2643 | } | 2678 | } |
| 2644 | /* | 2679 | /* |
| 2645 | * From spc4r17 Section 5.7.11.2 Releasing: | 2680 | * From spc4r17 Section 5.7.11.2 Releasing: |
| @@ -2661,7 +2696,7 @@ static int core_scsi3_emulate_pro_release( | |||
| 2661 | */ | 2696 | */ |
| 2662 | spin_unlock(&dev->dev_reservation_lock); | 2697 | spin_unlock(&dev->dev_reservation_lock); |
| 2663 | core_scsi3_put_pr_reg(pr_reg); | 2698 | core_scsi3_put_pr_reg(pr_reg); |
| 2664 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 2699 | return 0; |
| 2665 | } | 2700 | } |
| 2666 | if ((pr_res_holder->pr_res_type == PR_TYPE_WRITE_EXCLUSIVE_ALLREG) || | 2701 | if ((pr_res_holder->pr_res_type == PR_TYPE_WRITE_EXCLUSIVE_ALLREG) || |
| 2667 | (pr_res_holder->pr_res_type == PR_TYPE_EXCLUSIVE_ACCESS_ALLREG)) | 2702 | (pr_res_holder->pr_res_type == PR_TYPE_EXCLUSIVE_ACCESS_ALLREG)) |
| @@ -2675,7 +2710,7 @@ static int core_scsi3_emulate_pro_release( | |||
| 2675 | */ | 2710 | */ |
| 2676 | spin_unlock(&dev->dev_reservation_lock); | 2711 | spin_unlock(&dev->dev_reservation_lock); |
| 2677 | core_scsi3_put_pr_reg(pr_reg); | 2712 | core_scsi3_put_pr_reg(pr_reg); |
| 2678 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 2713 | return 0; |
| 2679 | } | 2714 | } |
| 2680 | /* | 2715 | /* |
| 2681 | * From spc4r17 Section 5.7.11.2 Releasing: | 2716 | * From spc4r17 Section 5.7.11.2 Releasing: |
| @@ -2697,7 +2732,8 @@ static int core_scsi3_emulate_pro_release( | |||
| 2697 | " 0x%016Lx\n", res_key, pr_reg->pr_res_key); | 2732 | " 0x%016Lx\n", res_key, pr_reg->pr_res_key); |
| 2698 | spin_unlock(&dev->dev_reservation_lock); | 2733 | spin_unlock(&dev->dev_reservation_lock); |
| 2699 | core_scsi3_put_pr_reg(pr_reg); | 2734 | core_scsi3_put_pr_reg(pr_reg); |
| 2700 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2735 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2736 | return -EINVAL; | ||
| 2701 | } | 2737 | } |
| 2702 | /* | 2738 | /* |
| 2703 | * From spc4r17 Section 5.7.11.2 Releasing and above: | 2739 | * From spc4r17 Section 5.7.11.2 Releasing and above: |
| @@ -2719,7 +2755,8 @@ static int core_scsi3_emulate_pro_release( | |||
| 2719 | 2755 | ||
| 2720 | spin_unlock(&dev->dev_reservation_lock); | 2756 | spin_unlock(&dev->dev_reservation_lock); |
| 2721 | core_scsi3_put_pr_reg(pr_reg); | 2757 | core_scsi3_put_pr_reg(pr_reg); |
| 2722 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2758 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2759 | return -EINVAL; | ||
| 2723 | } | 2760 | } |
| 2724 | /* | 2761 | /* |
| 2725 | * In response to a persistent reservation release request from the | 2762 | * In response to a persistent reservation release request from the |
| @@ -2802,7 +2839,8 @@ static int core_scsi3_emulate_pro_clear( | |||
| 2802 | if (!pr_reg_n) { | 2839 | if (!pr_reg_n) { |
| 2803 | pr_err("SPC-3 PR: Unable to locate" | 2840 | pr_err("SPC-3 PR: Unable to locate" |
| 2804 | " PR_REGISTERED *pr_reg for CLEAR\n"); | 2841 | " PR_REGISTERED *pr_reg for CLEAR\n"); |
| 2805 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 2842 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2843 | return -EINVAL; | ||
| 2806 | } | 2844 | } |
| 2807 | /* | 2845 | /* |
| 2808 | * From spc4r17 section 5.7.11.6, Clearing: | 2846 | * From spc4r17 section 5.7.11.6, Clearing: |
| @@ -2821,7 +2859,8 @@ static int core_scsi3_emulate_pro_clear( | |||
| 2821 | " existing SA REGISTER res_key:" | 2859 | " existing SA REGISTER res_key:" |
| 2822 | " 0x%016Lx\n", res_key, pr_reg_n->pr_res_key); | 2860 | " 0x%016Lx\n", res_key, pr_reg_n->pr_res_key); |
| 2823 | core_scsi3_put_pr_reg(pr_reg_n); | 2861 | core_scsi3_put_pr_reg(pr_reg_n); |
| 2824 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 2862 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 2863 | return -EINVAL; | ||
| 2825 | } | 2864 | } |
| 2826 | /* | 2865 | /* |
| 2827 | * a) Release the persistent reservation, if any; | 2866 | * a) Release the persistent reservation, if any; |
| @@ -2979,8 +3018,10 @@ static int core_scsi3_pro_preempt( | |||
| 2979 | int all_reg = 0, calling_it_nexus = 0, released_regs = 0; | 3018 | int all_reg = 0, calling_it_nexus = 0, released_regs = 0; |
| 2980 | int prh_type = 0, prh_scope = 0, ret; | 3019 | int prh_type = 0, prh_scope = 0, ret; |
| 2981 | 3020 | ||
| 2982 | if (!se_sess) | 3021 | if (!se_sess) { |
| 2983 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 3022 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3023 | return -EINVAL; | ||
| 3024 | } | ||
| 2984 | 3025 | ||
| 2985 | se_deve = &se_sess->se_node_acl->device_list[cmd->orig_fe_lun]; | 3026 | se_deve = &se_sess->se_node_acl->device_list[cmd->orig_fe_lun]; |
| 2986 | pr_reg_n = core_scsi3_locate_pr_reg(cmd->se_dev, se_sess->se_node_acl, | 3027 | pr_reg_n = core_scsi3_locate_pr_reg(cmd->se_dev, se_sess->se_node_acl, |
| @@ -2989,16 +3030,19 @@ static int core_scsi3_pro_preempt( | |||
| 2989 | pr_err("SPC-3 PR: Unable to locate" | 3030 | pr_err("SPC-3 PR: Unable to locate" |
| 2990 | " PR_REGISTERED *pr_reg for PREEMPT%s\n", | 3031 | " PR_REGISTERED *pr_reg for PREEMPT%s\n", |
| 2991 | (abort) ? "_AND_ABORT" : ""); | 3032 | (abort) ? "_AND_ABORT" : ""); |
| 2992 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 3033 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3034 | return -EINVAL; | ||
| 2993 | } | 3035 | } |
| 2994 | if (pr_reg_n->pr_res_key != res_key) { | 3036 | if (pr_reg_n->pr_res_key != res_key) { |
| 2995 | core_scsi3_put_pr_reg(pr_reg_n); | 3037 | core_scsi3_put_pr_reg(pr_reg_n); |
| 2996 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 3038 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3039 | return -EINVAL; | ||
| 2997 | } | 3040 | } |
| 2998 | if (scope != PR_SCOPE_LU_SCOPE) { | 3041 | if (scope != PR_SCOPE_LU_SCOPE) { |
| 2999 | pr_err("SPC-3 PR: Illegal SCOPE: 0x%02x\n", scope); | 3042 | pr_err("SPC-3 PR: Illegal SCOPE: 0x%02x\n", scope); |
| 3000 | core_scsi3_put_pr_reg(pr_reg_n); | 3043 | core_scsi3_put_pr_reg(pr_reg_n); |
| 3001 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3044 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3045 | return -EINVAL; | ||
| 3002 | } | 3046 | } |
| 3003 | INIT_LIST_HEAD(&preempt_and_abort_list); | 3047 | INIT_LIST_HEAD(&preempt_and_abort_list); |
| 3004 | 3048 | ||
| @@ -3012,7 +3056,8 @@ static int core_scsi3_pro_preempt( | |||
| 3012 | if (!all_reg && !sa_res_key) { | 3056 | if (!all_reg && !sa_res_key) { |
| 3013 | spin_unlock(&dev->dev_reservation_lock); | 3057 | spin_unlock(&dev->dev_reservation_lock); |
| 3014 | core_scsi3_put_pr_reg(pr_reg_n); | 3058 | core_scsi3_put_pr_reg(pr_reg_n); |
| 3015 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3059 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3060 | return -EINVAL; | ||
| 3016 | } | 3061 | } |
| 3017 | /* | 3062 | /* |
| 3018 | * From spc4r17, section 5.7.11.4.4 Removing Registrations: | 3063 | * From spc4r17, section 5.7.11.4.4 Removing Registrations: |
| @@ -3106,7 +3151,8 @@ static int core_scsi3_pro_preempt( | |||
| 3106 | if (!released_regs) { | 3151 | if (!released_regs) { |
| 3107 | spin_unlock(&dev->dev_reservation_lock); | 3152 | spin_unlock(&dev->dev_reservation_lock); |
| 3108 | core_scsi3_put_pr_reg(pr_reg_n); | 3153 | core_scsi3_put_pr_reg(pr_reg_n); |
| 3109 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 3154 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3155 | return -EINVAL; | ||
| 3110 | } | 3156 | } |
| 3111 | /* | 3157 | /* |
| 3112 | * For an existing all registrants type reservation | 3158 | * For an existing all registrants type reservation |
| @@ -3297,7 +3343,8 @@ static int core_scsi3_emulate_pro_preempt( | |||
| 3297 | default: | 3343 | default: |
| 3298 | pr_err("SPC-3 PR: Unknown Service Action PREEMPT%s" | 3344 | pr_err("SPC-3 PR: Unknown Service Action PREEMPT%s" |
| 3299 | " Type: 0x%02x\n", (abort) ? "_AND_ABORT" : "", type); | 3345 | " Type: 0x%02x\n", (abort) ? "_AND_ABORT" : "", type); |
| 3300 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 3346 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 3347 | return -EINVAL; | ||
| 3301 | } | 3348 | } |
| 3302 | 3349 | ||
| 3303 | return ret; | 3350 | return ret; |
| @@ -3331,7 +3378,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3331 | 3378 | ||
| 3332 | if (!se_sess || !se_lun) { | 3379 | if (!se_sess || !se_lun) { |
| 3333 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); | 3380 | pr_err("SPC-3 PR: se_sess || struct se_lun is NULL!\n"); |
| 3334 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 3381 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3382 | return -EINVAL; | ||
| 3335 | } | 3383 | } |
| 3336 | memset(dest_iport, 0, 64); | 3384 | memset(dest_iport, 0, 64); |
| 3337 | memset(i_buf, 0, PR_REG_ISID_ID_LEN); | 3385 | memset(i_buf, 0, PR_REG_ISID_ID_LEN); |
| @@ -3349,7 +3397,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3349 | if (!pr_reg) { | 3397 | if (!pr_reg) { |
| 3350 | pr_err("SPC-3 PR: Unable to locate PR_REGISTERED" | 3398 | pr_err("SPC-3 PR: Unable to locate PR_REGISTERED" |
| 3351 | " *pr_reg for REGISTER_AND_MOVE\n"); | 3399 | " *pr_reg for REGISTER_AND_MOVE\n"); |
| 3352 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 3400 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3401 | return -EINVAL; | ||
| 3353 | } | 3402 | } |
| 3354 | /* | 3403 | /* |
| 3355 | * The provided reservation key much match the existing reservation key | 3404 | * The provided reservation key much match the existing reservation key |
| @@ -3360,7 +3409,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3360 | " res_key: 0x%016Lx does not match existing SA REGISTER" | 3409 | " res_key: 0x%016Lx does not match existing SA REGISTER" |
| 3361 | " res_key: 0x%016Lx\n", res_key, pr_reg->pr_res_key); | 3410 | " res_key: 0x%016Lx\n", res_key, pr_reg->pr_res_key); |
| 3362 | core_scsi3_put_pr_reg(pr_reg); | 3411 | core_scsi3_put_pr_reg(pr_reg); |
| 3363 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 3412 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3413 | return -EINVAL; | ||
| 3364 | } | 3414 | } |
| 3365 | /* | 3415 | /* |
| 3366 | * The service active reservation key needs to be non zero | 3416 | * The service active reservation key needs to be non zero |
| @@ -3369,7 +3419,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3369 | pr_warn("SPC-3 PR REGISTER_AND_MOVE: Received zero" | 3419 | pr_warn("SPC-3 PR REGISTER_AND_MOVE: Received zero" |
| 3370 | " sa_res_key\n"); | 3420 | " sa_res_key\n"); |
| 3371 | core_scsi3_put_pr_reg(pr_reg); | 3421 | core_scsi3_put_pr_reg(pr_reg); |
| 3372 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3422 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3423 | return -EINVAL; | ||
| 3373 | } | 3424 | } |
| 3374 | 3425 | ||
| 3375 | /* | 3426 | /* |
| @@ -3392,7 +3443,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3392 | " does not equal CDB data_length: %u\n", tid_len, | 3443 | " does not equal CDB data_length: %u\n", tid_len, |
| 3393 | cmd->data_length); | 3444 | cmd->data_length); |
| 3394 | core_scsi3_put_pr_reg(pr_reg); | 3445 | core_scsi3_put_pr_reg(pr_reg); |
| 3395 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3446 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3447 | return -EINVAL; | ||
| 3396 | } | 3448 | } |
| 3397 | 3449 | ||
| 3398 | spin_lock(&dev->se_port_lock); | 3450 | spin_lock(&dev->se_port_lock); |
| @@ -3417,7 +3469,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3417 | atomic_dec(&dest_se_tpg->tpg_pr_ref_count); | 3469 | atomic_dec(&dest_se_tpg->tpg_pr_ref_count); |
| 3418 | smp_mb__after_atomic_dec(); | 3470 | smp_mb__after_atomic_dec(); |
| 3419 | core_scsi3_put_pr_reg(pr_reg); | 3471 | core_scsi3_put_pr_reg(pr_reg); |
| 3420 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 3472 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3473 | return -EINVAL; | ||
| 3421 | } | 3474 | } |
| 3422 | 3475 | ||
| 3423 | spin_lock(&dev->se_port_lock); | 3476 | spin_lock(&dev->se_port_lock); |
| @@ -3430,7 +3483,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3430 | " fabric ops from Relative Target Port Identifier:" | 3483 | " fabric ops from Relative Target Port Identifier:" |
| 3431 | " %hu\n", rtpi); | 3484 | " %hu\n", rtpi); |
| 3432 | core_scsi3_put_pr_reg(pr_reg); | 3485 | core_scsi3_put_pr_reg(pr_reg); |
| 3433 | return PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3486 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3487 | return -EINVAL; | ||
| 3434 | } | 3488 | } |
| 3435 | 3489 | ||
| 3436 | buf = transport_kmap_first_data_page(cmd); | 3490 | buf = transport_kmap_first_data_page(cmd); |
| @@ -3445,14 +3499,16 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3445 | " from fabric: %s\n", proto_ident, | 3499 | " from fabric: %s\n", proto_ident, |
| 3446 | dest_tf_ops->get_fabric_proto_ident(dest_se_tpg), | 3500 | dest_tf_ops->get_fabric_proto_ident(dest_se_tpg), |
| 3447 | dest_tf_ops->get_fabric_name()); | 3501 | dest_tf_ops->get_fabric_name()); |
| 3448 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3502 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3503 | ret = -EINVAL; | ||
| 3449 | goto out; | 3504 | goto out; |
| 3450 | } | 3505 | } |
| 3451 | if (dest_tf_ops->tpg_parse_pr_out_transport_id == NULL) { | 3506 | if (dest_tf_ops->tpg_parse_pr_out_transport_id == NULL) { |
| 3452 | pr_err("SPC-3 PR REGISTER_AND_MOVE: Fabric does not" | 3507 | pr_err("SPC-3 PR REGISTER_AND_MOVE: Fabric does not" |
| 3453 | " containg a valid tpg_parse_pr_out_transport_id" | 3508 | " containg a valid tpg_parse_pr_out_transport_id" |
| 3454 | " function pointer\n"); | 3509 | " function pointer\n"); |
| 3455 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 3510 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3511 | ret = -EINVAL; | ||
| 3456 | goto out; | 3512 | goto out; |
| 3457 | } | 3513 | } |
| 3458 | initiator_str = dest_tf_ops->tpg_parse_pr_out_transport_id(dest_se_tpg, | 3514 | initiator_str = dest_tf_ops->tpg_parse_pr_out_transport_id(dest_se_tpg, |
| @@ -3460,7 +3516,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3460 | if (!initiator_str) { | 3516 | if (!initiator_str) { |
| 3461 | pr_err("SPC-3 PR REGISTER_AND_MOVE: Unable to locate" | 3517 | pr_err("SPC-3 PR REGISTER_AND_MOVE: Unable to locate" |
| 3462 | " initiator_str from Transport ID\n"); | 3518 | " initiator_str from Transport ID\n"); |
| 3463 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3519 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3520 | ret = -EINVAL; | ||
| 3464 | goto out; | 3521 | goto out; |
| 3465 | } | 3522 | } |
| 3466 | 3523 | ||
| @@ -3489,7 +3546,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3489 | pr_err("SPC-3 PR REGISTER_AND_MOVE: TransportID: %s" | 3546 | pr_err("SPC-3 PR REGISTER_AND_MOVE: TransportID: %s" |
| 3490 | " matches: %s on received I_T Nexus\n", initiator_str, | 3547 | " matches: %s on received I_T Nexus\n", initiator_str, |
| 3491 | pr_reg_nacl->initiatorname); | 3548 | pr_reg_nacl->initiatorname); |
| 3492 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3549 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3550 | ret = -EINVAL; | ||
| 3493 | goto out; | 3551 | goto out; |
| 3494 | } | 3552 | } |
| 3495 | if (!strcmp(iport_ptr, pr_reg->pr_reg_isid)) { | 3553 | if (!strcmp(iport_ptr, pr_reg->pr_reg_isid)) { |
| @@ -3497,7 +3555,8 @@ static int core_scsi3_emulate_pro_register_and_move( | |||
| 3497 | " matches: %s %s on received I_T Nexus\n", | 3555 | " matches: %s %s on received I_T Nexus\n", |
| 3498 | initiator_str, iport_ptr, pr_reg_nacl->initiatorname, | 3556 | initiator_str, iport_ptr, pr_reg_nacl->initiatorname, |
| 3499 | pr_reg->pr_reg_isid); | 3557 | pr_reg->pr_reg_isid); |
| 3500 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3558 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3559 | ret = -EINVAL; | ||
| 3501 | goto out; | 3560 | goto out; |
| 3502 | } | 3561 | } |
| 3503 | after_iport_check: | 3562 | after_iport_check: |
| @@ -3517,7 +3576,8 @@ after_iport_check: | |||
| 3517 | pr_err("Unable to locate %s dest_node_acl for" | 3576 | pr_err("Unable to locate %s dest_node_acl for" |
| 3518 | " TransportID%s\n", dest_tf_ops->get_fabric_name(), | 3577 | " TransportID%s\n", dest_tf_ops->get_fabric_name(), |
| 3519 | initiator_str); | 3578 | initiator_str); |
| 3520 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3579 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3580 | ret = -EINVAL; | ||
| 3521 | goto out; | 3581 | goto out; |
| 3522 | } | 3582 | } |
| 3523 | ret = core_scsi3_nodeacl_depend_item(dest_node_acl); | 3583 | ret = core_scsi3_nodeacl_depend_item(dest_node_acl); |
| @@ -3527,7 +3587,8 @@ after_iport_check: | |||
| 3527 | atomic_dec(&dest_node_acl->acl_pr_ref_count); | 3587 | atomic_dec(&dest_node_acl->acl_pr_ref_count); |
| 3528 | smp_mb__after_atomic_dec(); | 3588 | smp_mb__after_atomic_dec(); |
| 3529 | dest_node_acl = NULL; | 3589 | dest_node_acl = NULL; |
| 3530 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 3590 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3591 | ret = -EINVAL; | ||
| 3531 | goto out; | 3592 | goto out; |
| 3532 | } | 3593 | } |
| 3533 | #if 0 | 3594 | #if 0 |
| @@ -3543,7 +3604,8 @@ after_iport_check: | |||
| 3543 | if (!dest_se_deve) { | 3604 | if (!dest_se_deve) { |
| 3544 | pr_err("Unable to locate %s dest_se_deve from RTPI:" | 3605 | pr_err("Unable to locate %s dest_se_deve from RTPI:" |
| 3545 | " %hu\n", dest_tf_ops->get_fabric_name(), rtpi); | 3606 | " %hu\n", dest_tf_ops->get_fabric_name(), rtpi); |
| 3546 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3607 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3608 | ret = -EINVAL; | ||
| 3547 | goto out; | 3609 | goto out; |
| 3548 | } | 3610 | } |
| 3549 | 3611 | ||
| @@ -3553,7 +3615,8 @@ after_iport_check: | |||
| 3553 | atomic_dec(&dest_se_deve->pr_ref_count); | 3615 | atomic_dec(&dest_se_deve->pr_ref_count); |
| 3554 | smp_mb__after_atomic_dec(); | 3616 | smp_mb__after_atomic_dec(); |
| 3555 | dest_se_deve = NULL; | 3617 | dest_se_deve = NULL; |
| 3556 | ret = PYX_TRANSPORT_LU_COMM_FAILURE; | 3618 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3619 | ret = -EINVAL; | ||
| 3557 | goto out; | 3620 | goto out; |
| 3558 | } | 3621 | } |
| 3559 | #if 0 | 3622 | #if 0 |
| @@ -3572,7 +3635,8 @@ after_iport_check: | |||
| 3572 | pr_warn("SPC-3 PR REGISTER_AND_MOVE: No reservation" | 3635 | pr_warn("SPC-3 PR REGISTER_AND_MOVE: No reservation" |
| 3573 | " currently held\n"); | 3636 | " currently held\n"); |
| 3574 | spin_unlock(&dev->dev_reservation_lock); | 3637 | spin_unlock(&dev->dev_reservation_lock); |
| 3575 | ret = PYX_TRANSPORT_INVALID_CDB_FIELD; | 3638 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 3639 | ret = -EINVAL; | ||
| 3576 | goto out; | 3640 | goto out; |
| 3577 | } | 3641 | } |
| 3578 | /* | 3642 | /* |
| @@ -3585,7 +3649,8 @@ after_iport_check: | |||
| 3585 | pr_warn("SPC-3 PR REGISTER_AND_MOVE: Calling I_T" | 3649 | pr_warn("SPC-3 PR REGISTER_AND_MOVE: Calling I_T" |
| 3586 | " Nexus is not reservation holder\n"); | 3650 | " Nexus is not reservation holder\n"); |
| 3587 | spin_unlock(&dev->dev_reservation_lock); | 3651 | spin_unlock(&dev->dev_reservation_lock); |
| 3588 | ret = PYX_TRANSPORT_RESERVATION_CONFLICT; | 3652 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3653 | ret = -EINVAL; | ||
| 3589 | goto out; | 3654 | goto out; |
| 3590 | } | 3655 | } |
| 3591 | /* | 3656 | /* |
| @@ -3603,7 +3668,8 @@ after_iport_check: | |||
| 3603 | " reservation for type: %s\n", | 3668 | " reservation for type: %s\n", |
| 3604 | core_scsi3_pr_dump_type(pr_res_holder->pr_res_type)); | 3669 | core_scsi3_pr_dump_type(pr_res_holder->pr_res_type)); |
| 3605 | spin_unlock(&dev->dev_reservation_lock); | 3670 | spin_unlock(&dev->dev_reservation_lock); |
| 3606 | ret = PYX_TRANSPORT_RESERVATION_CONFLICT; | 3671 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3672 | ret = -EINVAL; | ||
| 3607 | goto out; | 3673 | goto out; |
| 3608 | } | 3674 | } |
| 3609 | pr_res_nacl = pr_res_holder->pr_reg_nacl; | 3675 | pr_res_nacl = pr_res_holder->pr_reg_nacl; |
| @@ -3640,7 +3706,8 @@ after_iport_check: | |||
| 3640 | sa_res_key, 0, aptpl, 2, 1); | 3706 | sa_res_key, 0, aptpl, 2, 1); |
| 3641 | if (ret != 0) { | 3707 | if (ret != 0) { |
| 3642 | spin_unlock(&dev->dev_reservation_lock); | 3708 | spin_unlock(&dev->dev_reservation_lock); |
| 3643 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3709 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3710 | ret = -EINVAL; | ||
| 3644 | goto out; | 3711 | goto out; |
| 3645 | } | 3712 | } |
| 3646 | dest_pr_reg = __core_scsi3_locate_pr_reg(dev, dest_node_acl, | 3713 | dest_pr_reg = __core_scsi3_locate_pr_reg(dev, dest_node_acl, |
| @@ -3771,7 +3838,8 @@ int target_scsi3_emulate_pr_out(struct se_task *task) | |||
| 3771 | pr_err("Received PERSISTENT_RESERVE CDB while legacy" | 3838 | pr_err("Received PERSISTENT_RESERVE CDB while legacy" |
| 3772 | " SPC-2 reservation is held, returning" | 3839 | " SPC-2 reservation is held, returning" |
| 3773 | " RESERVATION_CONFLICT\n"); | 3840 | " RESERVATION_CONFLICT\n"); |
| 3774 | ret = PYX_TRANSPORT_RESERVATION_CONFLICT; | 3841 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 3842 | ret = EINVAL; | ||
| 3775 | goto out; | 3843 | goto out; |
| 3776 | } | 3844 | } |
| 3777 | 3845 | ||
| @@ -3779,13 +3847,16 @@ int target_scsi3_emulate_pr_out(struct se_task *task) | |||
| 3779 | * FIXME: A NULL struct se_session pointer means an this is not coming from | 3847 | * FIXME: A NULL struct se_session pointer means an this is not coming from |
| 3780 | * a $FABRIC_MOD's nexus, but from internal passthrough ops. | 3848 | * a $FABRIC_MOD's nexus, but from internal passthrough ops. |
| 3781 | */ | 3849 | */ |
| 3782 | if (!cmd->se_sess) | 3850 | if (!cmd->se_sess) { |
| 3783 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 3851 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 3852 | return -EINVAL; | ||
| 3853 | } | ||
| 3784 | 3854 | ||
| 3785 | if (cmd->data_length < 24) { | 3855 | if (cmd->data_length < 24) { |
| 3786 | pr_warn("SPC-PR: Received PR OUT parameter list" | 3856 | pr_warn("SPC-PR: Received PR OUT parameter list" |
| 3787 | " length too small: %u\n", cmd->data_length); | 3857 | " length too small: %u\n", cmd->data_length); |
| 3788 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3858 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3859 | ret = -EINVAL; | ||
| 3789 | goto out; | 3860 | goto out; |
| 3790 | } | 3861 | } |
| 3791 | /* | 3862 | /* |
| @@ -3820,7 +3891,8 @@ int target_scsi3_emulate_pr_out(struct se_task *task) | |||
| 3820 | * SPEC_I_PT=1 is only valid for Service action: REGISTER | 3891 | * SPEC_I_PT=1 is only valid for Service action: REGISTER |
| 3821 | */ | 3892 | */ |
| 3822 | if (spec_i_pt && ((cdb[1] & 0x1f) != PRO_REGISTER)) { | 3893 | if (spec_i_pt && ((cdb[1] & 0x1f) != PRO_REGISTER)) { |
| 3823 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3894 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3895 | ret = -EINVAL; | ||
| 3824 | goto out; | 3896 | goto out; |
| 3825 | } | 3897 | } |
| 3826 | 3898 | ||
| @@ -3837,7 +3909,8 @@ int target_scsi3_emulate_pr_out(struct se_task *task) | |||
| 3837 | (cmd->data_length != 24)) { | 3909 | (cmd->data_length != 24)) { |
| 3838 | pr_warn("SPC-PR: Received PR OUT illegal parameter" | 3910 | pr_warn("SPC-PR: Received PR OUT illegal parameter" |
| 3839 | " list length: %u\n", cmd->data_length); | 3911 | " list length: %u\n", cmd->data_length); |
| 3840 | ret = PYX_TRANSPORT_INVALID_PARAMETER_LIST; | 3912 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; |
| 3913 | ret = -EINVAL; | ||
| 3841 | goto out; | 3914 | goto out; |
| 3842 | } | 3915 | } |
| 3843 | /* | 3916 | /* |
| @@ -3878,7 +3951,8 @@ int target_scsi3_emulate_pr_out(struct se_task *task) | |||
| 3878 | default: | 3951 | default: |
| 3879 | pr_err("Unknown PERSISTENT_RESERVE_OUT service" | 3952 | pr_err("Unknown PERSISTENT_RESERVE_OUT service" |
| 3880 | " action: 0x%02x\n", cdb[1] & 0x1f); | 3953 | " action: 0x%02x\n", cdb[1] & 0x1f); |
| 3881 | ret = PYX_TRANSPORT_INVALID_CDB_FIELD; | 3954 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 3955 | ret = -EINVAL; | ||
| 3882 | break; | 3956 | break; |
| 3883 | } | 3957 | } |
| 3884 | 3958 | ||
| @@ -3906,7 +3980,8 @@ static int core_scsi3_pri_read_keys(struct se_cmd *cmd) | |||
| 3906 | if (cmd->data_length < 8) { | 3980 | if (cmd->data_length < 8) { |
| 3907 | pr_err("PRIN SA READ_KEYS SCSI Data Length: %u" | 3981 | pr_err("PRIN SA READ_KEYS SCSI Data Length: %u" |
| 3908 | " too small\n", cmd->data_length); | 3982 | " too small\n", cmd->data_length); |
| 3909 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 3983 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 3984 | return -EINVAL; | ||
| 3910 | } | 3985 | } |
| 3911 | 3986 | ||
| 3912 | buf = transport_kmap_first_data_page(cmd); | 3987 | buf = transport_kmap_first_data_page(cmd); |
| @@ -3965,7 +4040,8 @@ static int core_scsi3_pri_read_reservation(struct se_cmd *cmd) | |||
| 3965 | if (cmd->data_length < 8) { | 4040 | if (cmd->data_length < 8) { |
| 3966 | pr_err("PRIN SA READ_RESERVATIONS SCSI Data Length: %u" | 4041 | pr_err("PRIN SA READ_RESERVATIONS SCSI Data Length: %u" |
| 3967 | " too small\n", cmd->data_length); | 4042 | " too small\n", cmd->data_length); |
| 3968 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 4043 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 4044 | return -EINVAL; | ||
| 3969 | } | 4045 | } |
| 3970 | 4046 | ||
| 3971 | buf = transport_kmap_first_data_page(cmd); | 4047 | buf = transport_kmap_first_data_page(cmd); |
| @@ -4047,7 +4123,8 @@ static int core_scsi3_pri_report_capabilities(struct se_cmd *cmd) | |||
| 4047 | if (cmd->data_length < 6) { | 4123 | if (cmd->data_length < 6) { |
| 4048 | pr_err("PRIN SA REPORT_CAPABILITIES SCSI Data Length:" | 4124 | pr_err("PRIN SA REPORT_CAPABILITIES SCSI Data Length:" |
| 4049 | " %u too small\n", cmd->data_length); | 4125 | " %u too small\n", cmd->data_length); |
| 4050 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 4126 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 4127 | return -EINVAL; | ||
| 4051 | } | 4128 | } |
| 4052 | 4129 | ||
| 4053 | buf = transport_kmap_first_data_page(cmd); | 4130 | buf = transport_kmap_first_data_page(cmd); |
| @@ -4108,7 +4185,8 @@ static int core_scsi3_pri_read_full_status(struct se_cmd *cmd) | |||
| 4108 | if (cmd->data_length < 8) { | 4185 | if (cmd->data_length < 8) { |
| 4109 | pr_err("PRIN SA READ_FULL_STATUS SCSI Data Length: %u" | 4186 | pr_err("PRIN SA READ_FULL_STATUS SCSI Data Length: %u" |
| 4110 | " too small\n", cmd->data_length); | 4187 | " too small\n", cmd->data_length); |
| 4111 | return PYX_TRANSPORT_INVALID_CDB_FIELD; | 4188 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 4189 | return -EINVAL; | ||
| 4112 | } | 4190 | } |
| 4113 | 4191 | ||
| 4114 | buf = transport_kmap_first_data_page(cmd); | 4192 | buf = transport_kmap_first_data_page(cmd); |
| @@ -4255,7 +4333,8 @@ int target_scsi3_emulate_pr_in(struct se_task *task) | |||
| 4255 | pr_err("Received PERSISTENT_RESERVE CDB while legacy" | 4333 | pr_err("Received PERSISTENT_RESERVE CDB while legacy" |
| 4256 | " SPC-2 reservation is held, returning" | 4334 | " SPC-2 reservation is held, returning" |
| 4257 | " RESERVATION_CONFLICT\n"); | 4335 | " RESERVATION_CONFLICT\n"); |
| 4258 | return PYX_TRANSPORT_RESERVATION_CONFLICT; | 4336 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; |
| 4337 | return -EINVAL; | ||
| 4259 | } | 4338 | } |
| 4260 | 4339 | ||
| 4261 | switch (cmd->t_task_cdb[1] & 0x1f) { | 4340 | switch (cmd->t_task_cdb[1] & 0x1f) { |
| @@ -4274,7 +4353,8 @@ int target_scsi3_emulate_pr_in(struct se_task *task) | |||
| 4274 | default: | 4353 | default: |
| 4275 | pr_err("Unknown PERSISTENT_RESERVE_IN service" | 4354 | pr_err("Unknown PERSISTENT_RESERVE_IN service" |
| 4276 | " action: 0x%02x\n", cmd->t_task_cdb[1] & 0x1f); | 4355 | " action: 0x%02x\n", cmd->t_task_cdb[1] & 0x1f); |
| 4277 | ret = PYX_TRANSPORT_INVALID_CDB_FIELD; | 4356 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; |
| 4357 | ret = -EINVAL; | ||
| 4278 | break; | 4358 | break; |
| 4279 | } | 4359 | } |
| 4280 | 4360 | ||
diff --git a/drivers/target/target_core_pscsi.c b/drivers/target/target_core_pscsi.c index ed32e1efe429..8b15e56b0384 100644 --- a/drivers/target/target_core_pscsi.c +++ b/drivers/target/target_core_pscsi.c | |||
| @@ -963,6 +963,7 @@ static inline struct bio *pscsi_get_bio(int sg_num) | |||
| 963 | static int pscsi_map_sg(struct se_task *task, struct scatterlist *task_sg, | 963 | static int pscsi_map_sg(struct se_task *task, struct scatterlist *task_sg, |
| 964 | struct bio **hbio) | 964 | struct bio **hbio) |
| 965 | { | 965 | { |
| 966 | struct se_cmd *cmd = task->task_se_cmd; | ||
| 966 | struct pscsi_dev_virt *pdv = task->task_se_cmd->se_dev->dev_ptr; | 967 | struct pscsi_dev_virt *pdv = task->task_se_cmd->se_dev->dev_ptr; |
| 967 | u32 task_sg_num = task->task_sg_nents; | 968 | u32 task_sg_num = task->task_sg_nents; |
| 968 | struct bio *bio = NULL, *tbio = NULL; | 969 | struct bio *bio = NULL, *tbio = NULL; |
| @@ -971,7 +972,7 @@ static int pscsi_map_sg(struct se_task *task, struct scatterlist *task_sg, | |||
| 971 | u32 data_len = task->task_size, i, len, bytes, off; | 972 | u32 data_len = task->task_size, i, len, bytes, off; |
| 972 | int nr_pages = (task->task_size + task_sg[0].offset + | 973 | int nr_pages = (task->task_size + task_sg[0].offset + |
| 973 | PAGE_SIZE - 1) >> PAGE_SHIFT; | 974 | PAGE_SIZE - 1) >> PAGE_SHIFT; |
| 974 | int nr_vecs = 0, rc, ret = PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES; | 975 | int nr_vecs = 0, rc; |
| 975 | int rw = (task->task_data_direction == DMA_TO_DEVICE); | 976 | int rw = (task->task_data_direction == DMA_TO_DEVICE); |
| 976 | 977 | ||
| 977 | *hbio = NULL; | 978 | *hbio = NULL; |
| @@ -1058,11 +1059,13 @@ fail: | |||
| 1058 | bio->bi_next = NULL; | 1059 | bio->bi_next = NULL; |
| 1059 | bio_endio(bio, 0); /* XXX: should be error */ | 1060 | bio_endio(bio, 0); /* XXX: should be error */ |
| 1060 | } | 1061 | } |
| 1061 | return ret; | 1062 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 1063 | return -ENOMEM; | ||
| 1062 | } | 1064 | } |
| 1063 | 1065 | ||
| 1064 | static int pscsi_do_task(struct se_task *task) | 1066 | static int pscsi_do_task(struct se_task *task) |
| 1065 | { | 1067 | { |
| 1068 | struct se_cmd *cmd = task->task_se_cmd; | ||
| 1066 | struct pscsi_dev_virt *pdv = task->task_se_cmd->se_dev->dev_ptr; | 1069 | struct pscsi_dev_virt *pdv = task->task_se_cmd->se_dev->dev_ptr; |
| 1067 | struct pscsi_plugin_task *pt = PSCSI_TASK(task); | 1070 | struct pscsi_plugin_task *pt = PSCSI_TASK(task); |
| 1068 | struct request *req; | 1071 | struct request *req; |
| @@ -1078,7 +1081,9 @@ static int pscsi_do_task(struct se_task *task) | |||
| 1078 | if (!req || IS_ERR(req)) { | 1081 | if (!req || IS_ERR(req)) { |
| 1079 | pr_err("PSCSI: blk_get_request() failed: %ld\n", | 1082 | pr_err("PSCSI: blk_get_request() failed: %ld\n", |
| 1080 | req ? IS_ERR(req) : -ENOMEM); | 1083 | req ? IS_ERR(req) : -ENOMEM); |
| 1081 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 1084 | cmd->scsi_sense_reason = |
| 1085 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1086 | return -ENODEV; | ||
| 1082 | } | 1087 | } |
| 1083 | } else { | 1088 | } else { |
| 1084 | BUG_ON(!task->task_size); | 1089 | BUG_ON(!task->task_size); |
| @@ -1087,8 +1092,11 @@ static int pscsi_do_task(struct se_task *task) | |||
| 1087 | * Setup the main struct request for the task->task_sg[] payload | 1092 | * Setup the main struct request for the task->task_sg[] payload |
| 1088 | */ | 1093 | */ |
| 1089 | ret = pscsi_map_sg(task, task->task_sg, &hbio); | 1094 | ret = pscsi_map_sg(task, task->task_sg, &hbio); |
| 1090 | if (ret < 0) | 1095 | if (ret < 0) { |
| 1091 | return PYX_TRANSPORT_LU_COMM_FAILURE; | 1096 | cmd->scsi_sense_reason = |
| 1097 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1098 | return ret; | ||
| 1099 | } | ||
| 1092 | 1100 | ||
| 1093 | req = blk_make_request(pdv->pdv_sd->request_queue, hbio, | 1101 | req = blk_make_request(pdv->pdv_sd->request_queue, hbio, |
| 1094 | GFP_KERNEL); | 1102 | GFP_KERNEL); |
| @@ -1115,7 +1123,7 @@ static int pscsi_do_task(struct se_task *task) | |||
| 1115 | (task->task_se_cmd->sam_task_attr == MSG_HEAD_TAG), | 1123 | (task->task_se_cmd->sam_task_attr == MSG_HEAD_TAG), |
| 1116 | pscsi_req_done); | 1124 | pscsi_req_done); |
| 1117 | 1125 | ||
| 1118 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | 1126 | return 0; |
| 1119 | 1127 | ||
| 1120 | fail: | 1128 | fail: |
| 1121 | while (hbio) { | 1129 | while (hbio) { |
| @@ -1124,7 +1132,8 @@ fail: | |||
| 1124 | bio->bi_next = NULL; | 1132 | bio->bi_next = NULL; |
| 1125 | bio_endio(bio, 0); /* XXX: should be error */ | 1133 | bio_endio(bio, 0); /* XXX: should be error */ |
| 1126 | } | 1134 | } |
| 1127 | return PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES; | 1135 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 1136 | return -ENOMEM; | ||
| 1128 | } | 1137 | } |
| 1129 | 1138 | ||
| 1130 | /* pscsi_get_sense_buffer(): | 1139 | /* pscsi_get_sense_buffer(): |
| @@ -1198,9 +1207,8 @@ static inline void pscsi_process_SAM_status( | |||
| 1198 | " 0x%02x Result: 0x%08x\n", task, pt->pscsi_cdb[0], | 1207 | " 0x%02x Result: 0x%08x\n", task, pt->pscsi_cdb[0], |
| 1199 | pt->pscsi_result); | 1208 | pt->pscsi_result); |
| 1200 | task->task_scsi_status = SAM_STAT_CHECK_CONDITION; | 1209 | task->task_scsi_status = SAM_STAT_CHECK_CONDITION; |
| 1201 | task->task_error_status = PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 1210 | task->task_se_cmd->scsi_sense_reason = |
| 1202 | task->task_se_cmd->transport_error_status = | 1211 | TCM_UNSUPPORTED_SCSI_OPCODE; |
| 1203 | PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | ||
| 1204 | transport_complete_task(task, 0); | 1212 | transport_complete_task(task, 0); |
| 1205 | break; | 1213 | break; |
| 1206 | } | 1214 | } |
diff --git a/drivers/target/target_core_rd.c b/drivers/target/target_core_rd.c index 5158d3846f19..02e51faa2f4e 100644 --- a/drivers/target/target_core_rd.c +++ b/drivers/target/target_core_rd.c | |||
| @@ -343,235 +343,74 @@ static struct rd_dev_sg_table *rd_get_sg_table(struct rd_dev *rd_dev, u32 page) | |||
| 343 | return NULL; | 343 | return NULL; |
| 344 | } | 344 | } |
| 345 | 345 | ||
| 346 | /* rd_MEMCPY_read(): | 346 | static int rd_MEMCPY(struct rd_request *req, u32 read_rd) |
| 347 | * | ||
| 348 | * | ||
| 349 | */ | ||
| 350 | static int rd_MEMCPY_read(struct rd_request *req) | ||
| 351 | { | 347 | { |
| 352 | struct se_task *task = &req->rd_task; | 348 | struct se_task *task = &req->rd_task; |
| 353 | struct rd_dev *dev = req->rd_task.task_se_cmd->se_dev->dev_ptr; | 349 | struct rd_dev *dev = req->rd_task.task_se_cmd->se_dev->dev_ptr; |
| 354 | struct rd_dev_sg_table *table; | 350 | struct rd_dev_sg_table *table; |
| 355 | struct scatterlist *sg_d, *sg_s; | 351 | struct scatterlist *rd_sg; |
| 356 | void *dst, *src; | 352 | struct sg_mapping_iter m; |
| 357 | u32 i = 0, j = 0, dst_offset = 0, src_offset = 0; | ||
| 358 | u32 length, page_end = 0, table_sg_end; | ||
| 359 | u32 rd_offset = req->rd_offset; | 353 | u32 rd_offset = req->rd_offset; |
| 354 | u32 src_len; | ||
| 360 | 355 | ||
| 361 | table = rd_get_sg_table(dev, req->rd_page); | 356 | table = rd_get_sg_table(dev, req->rd_page); |
| 362 | if (!table) | 357 | if (!table) |
| 363 | return -EINVAL; | 358 | return -EINVAL; |
| 364 | 359 | ||
| 365 | table_sg_end = (table->page_end_offset - req->rd_page); | 360 | rd_sg = &table->sg_table[req->rd_page - table->page_start_offset]; |
| 366 | sg_d = task->task_sg; | ||
| 367 | sg_s = &table->sg_table[req->rd_page - table->page_start_offset]; | ||
| 368 | 361 | ||
| 369 | pr_debug("RD[%u]: Read LBA: %llu, Size: %u Page: %u, Offset:" | 362 | pr_debug("RD[%u]: %s LBA: %llu, Size: %u Page: %u, Offset: %u\n", |
| 370 | " %u\n", dev->rd_dev_id, task->task_lba, req->rd_size, | 363 | dev->rd_dev_id, read_rd ? "Read" : "Write", |
| 371 | req->rd_page, req->rd_offset); | 364 | task->task_lba, req->rd_size, req->rd_page, |
| 372 | 365 | rd_offset); | |
| 373 | src_offset = rd_offset; | ||
| 374 | 366 | ||
| 367 | src_len = PAGE_SIZE - rd_offset; | ||
| 368 | sg_miter_start(&m, task->task_sg, task->task_sg_nents, | ||
| 369 | read_rd ? SG_MITER_TO_SG : SG_MITER_FROM_SG); | ||
| 375 | while (req->rd_size) { | 370 | while (req->rd_size) { |
| 376 | if ((sg_d[i].length - dst_offset) < | 371 | u32 len; |
| 377 | (sg_s[j].length - src_offset)) { | 372 | void *rd_addr; |
| 378 | length = (sg_d[i].length - dst_offset); | ||
| 379 | |||
| 380 | pr_debug("Step 1 - sg_d[%d]: %p length: %d" | ||
| 381 | " offset: %u sg_s[%d].length: %u\n", i, | ||
| 382 | &sg_d[i], sg_d[i].length, sg_d[i].offset, j, | ||
| 383 | sg_s[j].length); | ||
| 384 | pr_debug("Step 1 - length: %u dst_offset: %u" | ||
| 385 | " src_offset: %u\n", length, dst_offset, | ||
| 386 | src_offset); | ||
| 387 | |||
| 388 | if (length > req->rd_size) | ||
| 389 | length = req->rd_size; | ||
| 390 | |||
| 391 | dst = sg_virt(&sg_d[i++]) + dst_offset; | ||
| 392 | BUG_ON(!dst); | ||
| 393 | |||
| 394 | src = sg_virt(&sg_s[j]) + src_offset; | ||
| 395 | BUG_ON(!src); | ||
| 396 | |||
| 397 | dst_offset = 0; | ||
| 398 | src_offset = length; | ||
| 399 | page_end = 0; | ||
| 400 | } else { | ||
| 401 | length = (sg_s[j].length - src_offset); | ||
| 402 | |||
| 403 | pr_debug("Step 2 - sg_d[%d]: %p length: %d" | ||
| 404 | " offset: %u sg_s[%d].length: %u\n", i, | ||
| 405 | &sg_d[i], sg_d[i].length, sg_d[i].offset, | ||
| 406 | j, sg_s[j].length); | ||
| 407 | pr_debug("Step 2 - length: %u dst_offset: %u" | ||
| 408 | " src_offset: %u\n", length, dst_offset, | ||
| 409 | src_offset); | ||
| 410 | |||
| 411 | if (length > req->rd_size) | ||
| 412 | length = req->rd_size; | ||
| 413 | |||
| 414 | dst = sg_virt(&sg_d[i]) + dst_offset; | ||
| 415 | BUG_ON(!dst); | ||
| 416 | |||
| 417 | if (sg_d[i].length == length) { | ||
| 418 | i++; | ||
| 419 | dst_offset = 0; | ||
| 420 | } else | ||
| 421 | dst_offset = length; | ||
| 422 | |||
| 423 | src = sg_virt(&sg_s[j++]) + src_offset; | ||
| 424 | BUG_ON(!src); | ||
| 425 | |||
| 426 | src_offset = 0; | ||
| 427 | page_end = 1; | ||
| 428 | } | ||
| 429 | 373 | ||
| 430 | memcpy(dst, src, length); | 374 | sg_miter_next(&m); |
| 375 | len = min((u32)m.length, src_len); | ||
| 376 | m.consumed = len; | ||
| 431 | 377 | ||
| 432 | pr_debug("page: %u, remaining size: %u, length: %u," | 378 | rd_addr = sg_virt(rd_sg) + rd_offset; |
| 433 | " i: %u, j: %u\n", req->rd_page, | ||
| 434 | (req->rd_size - length), length, i, j); | ||
| 435 | 379 | ||
| 436 | req->rd_size -= length; | 380 | if (read_rd) |
| 437 | if (!req->rd_size) | 381 | memcpy(m.addr, rd_addr, len); |
| 438 | return 0; | 382 | else |
| 383 | memcpy(rd_addr, m.addr, len); | ||
| 439 | 384 | ||
| 440 | if (!page_end) | 385 | req->rd_size -= len; |
| 386 | if (!req->rd_size) | ||
| 441 | continue; | 387 | continue; |
| 442 | 388 | ||
| 443 | if (++req->rd_page <= table->page_end_offset) { | 389 | src_len -= len; |
| 444 | pr_debug("page: %u in same page table\n", | 390 | if (src_len) { |
| 445 | req->rd_page); | 391 | rd_offset += len; |
| 446 | continue; | 392 | continue; |
| 447 | } | 393 | } |
| 448 | 394 | ||
| 449 | pr_debug("getting new page table for page: %u\n", | 395 | /* rd page completed, next one please */ |
| 450 | req->rd_page); | 396 | req->rd_page++; |
| 451 | 397 | rd_offset = 0; | |
| 452 | table = rd_get_sg_table(dev, req->rd_page); | 398 | src_len = PAGE_SIZE; |
| 453 | if (!table) | 399 | if (req->rd_page <= table->page_end_offset) { |
| 454 | return -EINVAL; | 400 | rd_sg++; |
| 455 | |||
| 456 | sg_s = &table->sg_table[j = 0]; | ||
| 457 | } | ||
| 458 | |||
| 459 | return 0; | ||
| 460 | } | ||
| 461 | |||
| 462 | /* rd_MEMCPY_write(): | ||
| 463 | * | ||
| 464 | * | ||
| 465 | */ | ||
| 466 | static int rd_MEMCPY_write(struct rd_request *req) | ||
| 467 | { | ||
| 468 | struct se_task *task = &req->rd_task; | ||
| 469 | struct rd_dev *dev = req->rd_task.task_se_cmd->se_dev->dev_ptr; | ||
| 470 | struct rd_dev_sg_table *table; | ||
| 471 | struct scatterlist *sg_d, *sg_s; | ||
| 472 | void *dst, *src; | ||
| 473 | u32 i = 0, j = 0, dst_offset = 0, src_offset = 0; | ||
| 474 | u32 length, page_end = 0, table_sg_end; | ||
| 475 | u32 rd_offset = req->rd_offset; | ||
| 476 | |||
| 477 | table = rd_get_sg_table(dev, req->rd_page); | ||
| 478 | if (!table) | ||
| 479 | return -EINVAL; | ||
| 480 | |||
| 481 | table_sg_end = (table->page_end_offset - req->rd_page); | ||
| 482 | sg_d = &table->sg_table[req->rd_page - table->page_start_offset]; | ||
| 483 | sg_s = task->task_sg; | ||
| 484 | |||
| 485 | pr_debug("RD[%d] Write LBA: %llu, Size: %u, Page: %u," | ||
| 486 | " Offset: %u\n", dev->rd_dev_id, task->task_lba, req->rd_size, | ||
| 487 | req->rd_page, req->rd_offset); | ||
| 488 | |||
| 489 | dst_offset = rd_offset; | ||
| 490 | |||
| 491 | while (req->rd_size) { | ||
| 492 | if ((sg_s[i].length - src_offset) < | ||
| 493 | (sg_d[j].length - dst_offset)) { | ||
| 494 | length = (sg_s[i].length - src_offset); | ||
| 495 | |||
| 496 | pr_debug("Step 1 - sg_s[%d]: %p length: %d" | ||
| 497 | " offset: %d sg_d[%d].length: %u\n", i, | ||
| 498 | &sg_s[i], sg_s[i].length, sg_s[i].offset, | ||
| 499 | j, sg_d[j].length); | ||
| 500 | pr_debug("Step 1 - length: %u src_offset: %u" | ||
| 501 | " dst_offset: %u\n", length, src_offset, | ||
| 502 | dst_offset); | ||
| 503 | |||
| 504 | if (length > req->rd_size) | ||
| 505 | length = req->rd_size; | ||
| 506 | |||
| 507 | src = sg_virt(&sg_s[i++]) + src_offset; | ||
| 508 | BUG_ON(!src); | ||
| 509 | |||
| 510 | dst = sg_virt(&sg_d[j]) + dst_offset; | ||
| 511 | BUG_ON(!dst); | ||
| 512 | |||
| 513 | src_offset = 0; | ||
| 514 | dst_offset = length; | ||
| 515 | page_end = 0; | ||
| 516 | } else { | ||
| 517 | length = (sg_d[j].length - dst_offset); | ||
| 518 | |||
| 519 | pr_debug("Step 2 - sg_s[%d]: %p length: %d" | ||
| 520 | " offset: %d sg_d[%d].length: %u\n", i, | ||
| 521 | &sg_s[i], sg_s[i].length, sg_s[i].offset, | ||
| 522 | j, sg_d[j].length); | ||
| 523 | pr_debug("Step 2 - length: %u src_offset: %u" | ||
| 524 | " dst_offset: %u\n", length, src_offset, | ||
| 525 | dst_offset); | ||
| 526 | |||
| 527 | if (length > req->rd_size) | ||
| 528 | length = req->rd_size; | ||
| 529 | |||
| 530 | src = sg_virt(&sg_s[i]) + src_offset; | ||
| 531 | BUG_ON(!src); | ||
| 532 | |||
| 533 | if (sg_s[i].length == length) { | ||
| 534 | i++; | ||
| 535 | src_offset = 0; | ||
| 536 | } else | ||
| 537 | src_offset = length; | ||
| 538 | |||
| 539 | dst = sg_virt(&sg_d[j++]) + dst_offset; | ||
| 540 | BUG_ON(!dst); | ||
| 541 | |||
| 542 | dst_offset = 0; | ||
| 543 | page_end = 1; | ||
| 544 | } | ||
| 545 | |||
| 546 | memcpy(dst, src, length); | ||
| 547 | |||
| 548 | pr_debug("page: %u, remaining size: %u, length: %u," | ||
| 549 | " i: %u, j: %u\n", req->rd_page, | ||
| 550 | (req->rd_size - length), length, i, j); | ||
| 551 | |||
| 552 | req->rd_size -= length; | ||
| 553 | if (!req->rd_size) | ||
| 554 | return 0; | ||
| 555 | |||
| 556 | if (!page_end) | ||
| 557 | continue; | ||
| 558 | |||
| 559 | if (++req->rd_page <= table->page_end_offset) { | ||
| 560 | pr_debug("page: %u in same page table\n", | ||
| 561 | req->rd_page); | ||
| 562 | continue; | 401 | continue; |
| 563 | } | 402 | } |
| 564 | 403 | ||
| 565 | pr_debug("getting new page table for page: %u\n", | ||
| 566 | req->rd_page); | ||
| 567 | |||
| 568 | table = rd_get_sg_table(dev, req->rd_page); | 404 | table = rd_get_sg_table(dev, req->rd_page); |
| 569 | if (!table) | 405 | if (!table) { |
| 406 | sg_miter_stop(&m); | ||
| 570 | return -EINVAL; | 407 | return -EINVAL; |
| 408 | } | ||
| 571 | 409 | ||
| 572 | sg_d = &table->sg_table[j = 0]; | 410 | /* since we increment, the first sg entry is correct */ |
| 411 | rd_sg = table->sg_table; | ||
| 573 | } | 412 | } |
| 574 | 413 | sg_miter_stop(&m); | |
| 575 | return 0; | 414 | return 0; |
| 576 | } | 415 | } |
| 577 | 416 | ||
| @@ -583,28 +422,21 @@ static int rd_MEMCPY_do_task(struct se_task *task) | |||
| 583 | { | 422 | { |
| 584 | struct se_device *dev = task->task_se_cmd->se_dev; | 423 | struct se_device *dev = task->task_se_cmd->se_dev; |
| 585 | struct rd_request *req = RD_REQ(task); | 424 | struct rd_request *req = RD_REQ(task); |
| 586 | unsigned long long lba; | 425 | u64 tmp; |
| 587 | int ret; | 426 | int ret; |
| 588 | 427 | ||
| 589 | req->rd_page = (task->task_lba * dev->se_sub_dev->se_dev_attrib.block_size) / PAGE_SIZE; | 428 | tmp = task->task_lba * dev->se_sub_dev->se_dev_attrib.block_size; |
| 590 | lba = task->task_lba; | 429 | req->rd_offset = do_div(tmp, PAGE_SIZE); |
| 591 | req->rd_offset = (do_div(lba, | 430 | req->rd_page = tmp; |
| 592 | (PAGE_SIZE / dev->se_sub_dev->se_dev_attrib.block_size))) * | ||
| 593 | dev->se_sub_dev->se_dev_attrib.block_size; | ||
| 594 | req->rd_size = task->task_size; | 431 | req->rd_size = task->task_size; |
| 595 | 432 | ||
| 596 | if (task->task_data_direction == DMA_FROM_DEVICE) | 433 | ret = rd_MEMCPY(req, task->task_data_direction == DMA_FROM_DEVICE); |
| 597 | ret = rd_MEMCPY_read(req); | ||
| 598 | else | ||
| 599 | ret = rd_MEMCPY_write(req); | ||
| 600 | |||
| 601 | if (ret != 0) | 434 | if (ret != 0) |
| 602 | return ret; | 435 | return ret; |
| 603 | 436 | ||
| 604 | task->task_scsi_status = GOOD; | 437 | task->task_scsi_status = GOOD; |
| 605 | transport_complete_task(task, 1); | 438 | transport_complete_task(task, 1); |
| 606 | 439 | return 0; | |
| 607 | return PYX_TRANSPORT_SENT_TO_TRANSPORT; | ||
| 608 | } | 440 | } |
| 609 | 441 | ||
| 610 | /* rd_free_task(): (Part of se_subsystem_api_t template) | 442 | /* rd_free_task(): (Part of se_subsystem_api_t template) |
diff --git a/drivers/target/target_core_tmr.c b/drivers/target/target_core_tmr.c index 217e29df6297..684522805a1f 100644 --- a/drivers/target/target_core_tmr.c +++ b/drivers/target/target_core_tmr.c | |||
| @@ -345,10 +345,6 @@ static void core_tmr_drain_cmd_list( | |||
| 345 | " %d t_fe_count: %d\n", (preempt_and_abort_list) ? | 345 | " %d t_fe_count: %d\n", (preempt_and_abort_list) ? |
| 346 | "Preempt" : "", cmd, cmd->t_state, | 346 | "Preempt" : "", cmd, cmd->t_state, |
| 347 | atomic_read(&cmd->t_fe_count)); | 347 | atomic_read(&cmd->t_fe_count)); |
| 348 | /* | ||
| 349 | * Signal that the command has failed via cmd->se_cmd_flags, | ||
| 350 | */ | ||
| 351 | transport_new_cmd_failure(cmd); | ||
| 352 | 348 | ||
| 353 | core_tmr_handle_tas_abort(tmr_nacl, cmd, tas, | 349 | core_tmr_handle_tas_abort(tmr_nacl, cmd, tas, |
| 354 | atomic_read(&cmd->t_fe_count)); | 350 | atomic_read(&cmd->t_fe_count)); |
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 3400ae6e93f8..0257658e2e3e 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c | |||
| @@ -61,7 +61,6 @@ | |||
| 61 | static int sub_api_initialized; | 61 | static int sub_api_initialized; |
| 62 | 62 | ||
| 63 | static struct workqueue_struct *target_completion_wq; | 63 | static struct workqueue_struct *target_completion_wq; |
| 64 | static struct kmem_cache *se_cmd_cache; | ||
| 65 | static struct kmem_cache *se_sess_cache; | 64 | static struct kmem_cache *se_sess_cache; |
| 66 | struct kmem_cache *se_tmr_req_cache; | 65 | struct kmem_cache *se_tmr_req_cache; |
| 67 | struct kmem_cache *se_ua_cache; | 66 | struct kmem_cache *se_ua_cache; |
| @@ -82,24 +81,18 @@ static int transport_generic_get_mem(struct se_cmd *cmd); | |||
| 82 | static void transport_put_cmd(struct se_cmd *cmd); | 81 | static void transport_put_cmd(struct se_cmd *cmd); |
| 83 | static void transport_remove_cmd_from_queue(struct se_cmd *cmd); | 82 | static void transport_remove_cmd_from_queue(struct se_cmd *cmd); |
| 84 | static int transport_set_sense_codes(struct se_cmd *cmd, u8 asc, u8 ascq); | 83 | static int transport_set_sense_codes(struct se_cmd *cmd, u8 asc, u8 ascq); |
| 85 | static void transport_generic_request_failure(struct se_cmd *, int, int); | 84 | static void transport_generic_request_failure(struct se_cmd *); |
| 86 | static void target_complete_ok_work(struct work_struct *work); | 85 | static void target_complete_ok_work(struct work_struct *work); |
| 87 | 86 | ||
| 88 | int init_se_kmem_caches(void) | 87 | int init_se_kmem_caches(void) |
| 89 | { | 88 | { |
| 90 | se_cmd_cache = kmem_cache_create("se_cmd_cache", | ||
| 91 | sizeof(struct se_cmd), __alignof__(struct se_cmd), 0, NULL); | ||
| 92 | if (!se_cmd_cache) { | ||
| 93 | pr_err("kmem_cache_create for struct se_cmd failed\n"); | ||
| 94 | goto out; | ||
| 95 | } | ||
| 96 | se_tmr_req_cache = kmem_cache_create("se_tmr_cache", | 89 | se_tmr_req_cache = kmem_cache_create("se_tmr_cache", |
| 97 | sizeof(struct se_tmr_req), __alignof__(struct se_tmr_req), | 90 | sizeof(struct se_tmr_req), __alignof__(struct se_tmr_req), |
| 98 | 0, NULL); | 91 | 0, NULL); |
| 99 | if (!se_tmr_req_cache) { | 92 | if (!se_tmr_req_cache) { |
| 100 | pr_err("kmem_cache_create() for struct se_tmr_req" | 93 | pr_err("kmem_cache_create() for struct se_tmr_req" |
| 101 | " failed\n"); | 94 | " failed\n"); |
| 102 | goto out_free_cmd_cache; | 95 | goto out; |
| 103 | } | 96 | } |
| 104 | se_sess_cache = kmem_cache_create("se_sess_cache", | 97 | se_sess_cache = kmem_cache_create("se_sess_cache", |
| 105 | sizeof(struct se_session), __alignof__(struct se_session), | 98 | sizeof(struct se_session), __alignof__(struct se_session), |
| @@ -182,8 +175,6 @@ out_free_sess_cache: | |||
| 182 | kmem_cache_destroy(se_sess_cache); | 175 | kmem_cache_destroy(se_sess_cache); |
| 183 | out_free_tmr_req_cache: | 176 | out_free_tmr_req_cache: |
| 184 | kmem_cache_destroy(se_tmr_req_cache); | 177 | kmem_cache_destroy(se_tmr_req_cache); |
| 185 | out_free_cmd_cache: | ||
| 186 | kmem_cache_destroy(se_cmd_cache); | ||
| 187 | out: | 178 | out: |
| 188 | return -ENOMEM; | 179 | return -ENOMEM; |
| 189 | } | 180 | } |
| @@ -191,7 +182,6 @@ out: | |||
| 191 | void release_se_kmem_caches(void) | 182 | void release_se_kmem_caches(void) |
| 192 | { | 183 | { |
| 193 | destroy_workqueue(target_completion_wq); | 184 | destroy_workqueue(target_completion_wq); |
| 194 | kmem_cache_destroy(se_cmd_cache); | ||
| 195 | kmem_cache_destroy(se_tmr_req_cache); | 185 | kmem_cache_destroy(se_tmr_req_cache); |
| 196 | kmem_cache_destroy(se_sess_cache); | 186 | kmem_cache_destroy(se_sess_cache); |
| 197 | kmem_cache_destroy(se_ua_cache); | 187 | kmem_cache_destroy(se_ua_cache); |
| @@ -680,9 +670,9 @@ void transport_complete_sync_cache(struct se_cmd *cmd, int good) | |||
| 680 | task->task_scsi_status = GOOD; | 670 | task->task_scsi_status = GOOD; |
| 681 | } else { | 671 | } else { |
| 682 | task->task_scsi_status = SAM_STAT_CHECK_CONDITION; | 672 | task->task_scsi_status = SAM_STAT_CHECK_CONDITION; |
| 683 | task->task_error_status = PYX_TRANSPORT_ILLEGAL_REQUEST; | 673 | task->task_se_cmd->scsi_sense_reason = |
| 684 | task->task_se_cmd->transport_error_status = | 674 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 685 | PYX_TRANSPORT_ILLEGAL_REQUEST; | 675 | |
| 686 | } | 676 | } |
| 687 | 677 | ||
| 688 | transport_complete_task(task, good); | 678 | transport_complete_task(task, good); |
| @@ -693,7 +683,7 @@ static void target_complete_failure_work(struct work_struct *work) | |||
| 693 | { | 683 | { |
| 694 | struct se_cmd *cmd = container_of(work, struct se_cmd, work); | 684 | struct se_cmd *cmd = container_of(work, struct se_cmd, work); |
| 695 | 685 | ||
| 696 | transport_generic_request_failure(cmd, 1, 1); | 686 | transport_generic_request_failure(cmd); |
| 697 | } | 687 | } |
| 698 | 688 | ||
| 699 | /* transport_complete_task(): | 689 | /* transport_complete_task(): |
| @@ -755,10 +745,11 @@ void transport_complete_task(struct se_task *task, int success) | |||
| 755 | if (cmd->t_tasks_failed) { | 745 | if (cmd->t_tasks_failed) { |
| 756 | if (!task->task_error_status) { | 746 | if (!task->task_error_status) { |
| 757 | task->task_error_status = | 747 | task->task_error_status = |
| 758 | PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 748 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 759 | cmd->transport_error_status = | 749 | cmd->scsi_sense_reason = |
| 760 | PYX_TRANSPORT_UNKNOWN_SAM_OPCODE; | 750 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 761 | } | 751 | } |
| 752 | |||
| 762 | INIT_WORK(&cmd->work, target_complete_failure_work); | 753 | INIT_WORK(&cmd->work, target_complete_failure_work); |
| 763 | } else { | 754 | } else { |
| 764 | atomic_set(&cmd->t_transport_complete, 1); | 755 | atomic_set(&cmd->t_transport_complete, 1); |
| @@ -1335,23 +1326,17 @@ struct se_device *transport_add_device_to_core_hba( | |||
| 1335 | dev->se_hba = hba; | 1326 | dev->se_hba = hba; |
| 1336 | dev->se_sub_dev = se_dev; | 1327 | dev->se_sub_dev = se_dev; |
| 1337 | dev->transport = transport; | 1328 | dev->transport = transport; |
| 1338 | atomic_set(&dev->active_cmds, 0); | ||
| 1339 | INIT_LIST_HEAD(&dev->dev_list); | 1329 | INIT_LIST_HEAD(&dev->dev_list); |
| 1340 | INIT_LIST_HEAD(&dev->dev_sep_list); | 1330 | INIT_LIST_HEAD(&dev->dev_sep_list); |
| 1341 | INIT_LIST_HEAD(&dev->dev_tmr_list); | 1331 | INIT_LIST_HEAD(&dev->dev_tmr_list); |
| 1342 | INIT_LIST_HEAD(&dev->execute_task_list); | 1332 | INIT_LIST_HEAD(&dev->execute_task_list); |
| 1343 | INIT_LIST_HEAD(&dev->delayed_cmd_list); | 1333 | INIT_LIST_HEAD(&dev->delayed_cmd_list); |
| 1344 | INIT_LIST_HEAD(&dev->ordered_cmd_list); | ||
| 1345 | INIT_LIST_HEAD(&dev->state_task_list); | 1334 | INIT_LIST_HEAD(&dev->state_task_list); |
| 1346 | INIT_LIST_HEAD(&dev->qf_cmd_list); | 1335 | INIT_LIST_HEAD(&dev->qf_cmd_list); |
| 1347 | spin_lock_init(&dev->execute_task_lock); | 1336 | spin_lock_init(&dev->execute_task_lock); |
| 1348 | spin_lock_init(&dev->delayed_cmd_lock); | 1337 | spin_lock_init(&dev->delayed_cmd_lock); |
| 1349 | spin_lock_init(&dev->ordered_cmd_lock); | ||
| 1350 | spin_lock_init(&dev->state_task_lock); | ||
| 1351 | spin_lock_init(&dev->dev_alua_lock); | ||
| 1352 | spin_lock_init(&dev->dev_reservation_lock); | 1338 | spin_lock_init(&dev->dev_reservation_lock); |
| 1353 | spin_lock_init(&dev->dev_status_lock); | 1339 | spin_lock_init(&dev->dev_status_lock); |
| 1354 | spin_lock_init(&dev->dev_status_thr_lock); | ||
| 1355 | spin_lock_init(&dev->se_port_lock); | 1340 | spin_lock_init(&dev->se_port_lock); |
| 1356 | spin_lock_init(&dev->se_tmr_lock); | 1341 | spin_lock_init(&dev->se_tmr_lock); |
| 1357 | spin_lock_init(&dev->qf_cmd_lock); | 1342 | spin_lock_init(&dev->qf_cmd_lock); |
| @@ -1507,7 +1492,6 @@ void transport_init_se_cmd( | |||
| 1507 | { | 1492 | { |
| 1508 | INIT_LIST_HEAD(&cmd->se_lun_node); | 1493 | INIT_LIST_HEAD(&cmd->se_lun_node); |
| 1509 | INIT_LIST_HEAD(&cmd->se_delayed_node); | 1494 | INIT_LIST_HEAD(&cmd->se_delayed_node); |
| 1510 | INIT_LIST_HEAD(&cmd->se_ordered_node); | ||
| 1511 | INIT_LIST_HEAD(&cmd->se_qf_node); | 1495 | INIT_LIST_HEAD(&cmd->se_qf_node); |
| 1512 | INIT_LIST_HEAD(&cmd->se_queue_node); | 1496 | INIT_LIST_HEAD(&cmd->se_queue_node); |
| 1513 | INIT_LIST_HEAD(&cmd->se_cmd_list); | 1497 | INIT_LIST_HEAD(&cmd->se_cmd_list); |
| @@ -1573,6 +1557,8 @@ int transport_generic_allocate_tasks( | |||
| 1573 | pr_err("Received SCSI CDB with command_size: %d that" | 1557 | pr_err("Received SCSI CDB with command_size: %d that" |
| 1574 | " exceeds SCSI_MAX_VARLEN_CDB_SIZE: %d\n", | 1558 | " exceeds SCSI_MAX_VARLEN_CDB_SIZE: %d\n", |
| 1575 | scsi_command_size(cdb), SCSI_MAX_VARLEN_CDB_SIZE); | 1559 | scsi_command_size(cdb), SCSI_MAX_VARLEN_CDB_SIZE); |
| 1560 | cmd->se_cmd_flags |= SCF_SCSI_CDB_EXCEPTION; | ||
| 1561 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; | ||
| 1576 | return -EINVAL; | 1562 | return -EINVAL; |
| 1577 | } | 1563 | } |
| 1578 | /* | 1564 | /* |
| @@ -1588,6 +1574,9 @@ int transport_generic_allocate_tasks( | |||
| 1588 | " %u > sizeof(cmd->__t_task_cdb): %lu ops\n", | 1574 | " %u > sizeof(cmd->__t_task_cdb): %lu ops\n", |
| 1589 | scsi_command_size(cdb), | 1575 | scsi_command_size(cdb), |
| 1590 | (unsigned long)sizeof(cmd->__t_task_cdb)); | 1576 | (unsigned long)sizeof(cmd->__t_task_cdb)); |
| 1577 | cmd->se_cmd_flags |= SCF_SCSI_CDB_EXCEPTION; | ||
| 1578 | cmd->scsi_sense_reason = | ||
| 1579 | TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1591 | return -ENOMEM; | 1580 | return -ENOMEM; |
| 1592 | } | 1581 | } |
| 1593 | } else | 1582 | } else |
| @@ -1658,11 +1647,9 @@ int transport_handle_cdb_direct( | |||
| 1658 | * and call transport_generic_request_failure() if necessary.. | 1647 | * and call transport_generic_request_failure() if necessary.. |
| 1659 | */ | 1648 | */ |
| 1660 | ret = transport_generic_new_cmd(cmd); | 1649 | ret = transport_generic_new_cmd(cmd); |
| 1661 | if (ret < 0) { | 1650 | if (ret < 0) |
| 1662 | cmd->transport_error_status = ret; | 1651 | transport_generic_request_failure(cmd); |
| 1663 | transport_generic_request_failure(cmd, 0, | 1652 | |
| 1664 | (cmd->data_direction != DMA_TO_DEVICE)); | ||
| 1665 | } | ||
| 1666 | return 0; | 1653 | return 0; |
| 1667 | } | 1654 | } |
| 1668 | EXPORT_SYMBOL(transport_handle_cdb_direct); | 1655 | EXPORT_SYMBOL(transport_handle_cdb_direct); |
| @@ -1798,20 +1785,16 @@ static int transport_stop_tasks_for_cmd(struct se_cmd *cmd) | |||
| 1798 | /* | 1785 | /* |
| 1799 | * Handle SAM-esque emulation for generic transport request failures. | 1786 | * Handle SAM-esque emulation for generic transport request failures. |
| 1800 | */ | 1787 | */ |
| 1801 | static void transport_generic_request_failure( | 1788 | static void transport_generic_request_failure(struct se_cmd *cmd) |
| 1802 | struct se_cmd *cmd, | ||
| 1803 | int complete, | ||
| 1804 | int sc) | ||
| 1805 | { | 1789 | { |
| 1806 | int ret = 0; | 1790 | int ret = 0; |
| 1807 | 1791 | ||
| 1808 | pr_debug("-----[ Storage Engine Exception for cmd: %p ITT: 0x%08x" | 1792 | pr_debug("-----[ Storage Engine Exception for cmd: %p ITT: 0x%08x" |
| 1809 | " CDB: 0x%02x\n", cmd, cmd->se_tfo->get_task_tag(cmd), | 1793 | " CDB: 0x%02x\n", cmd, cmd->se_tfo->get_task_tag(cmd), |
| 1810 | cmd->t_task_cdb[0]); | 1794 | cmd->t_task_cdb[0]); |
| 1811 | pr_debug("-----[ i_state: %d t_state: %d transport_error_status: %d\n", | 1795 | pr_debug("-----[ i_state: %d t_state: %d scsi_sense_reason: %d\n", |
| 1812 | cmd->se_tfo->get_cmd_state(cmd), | 1796 | cmd->se_tfo->get_cmd_state(cmd), |
| 1813 | cmd->t_state, | 1797 | cmd->t_state, cmd->scsi_sense_reason); |
| 1814 | cmd->transport_error_status); | ||
| 1815 | pr_debug("-----[ t_tasks: %d t_task_cdbs_left: %d" | 1798 | pr_debug("-----[ t_tasks: %d t_task_cdbs_left: %d" |
| 1816 | " t_task_cdbs_sent: %d t_task_cdbs_ex_left: %d --" | 1799 | " t_task_cdbs_sent: %d t_task_cdbs_ex_left: %d --" |
| 1817 | " t_transport_active: %d t_transport_stop: %d" | 1800 | " t_transport_active: %d t_transport_stop: %d" |
| @@ -1829,46 +1812,19 @@ static void transport_generic_request_failure( | |||
| 1829 | if (cmd->se_dev->dev_task_attr_type == SAM_TASK_ATTR_EMULATED) | 1812 | if (cmd->se_dev->dev_task_attr_type == SAM_TASK_ATTR_EMULATED) |
| 1830 | transport_complete_task_attr(cmd); | 1813 | transport_complete_task_attr(cmd); |
| 1831 | 1814 | ||
| 1832 | if (complete) { | 1815 | switch (cmd->scsi_sense_reason) { |
| 1833 | cmd->transport_error_status = PYX_TRANSPORT_LU_COMM_FAILURE; | 1816 | case TCM_NON_EXISTENT_LUN: |
| 1834 | } | 1817 | case TCM_UNSUPPORTED_SCSI_OPCODE: |
| 1835 | 1818 | case TCM_INVALID_CDB_FIELD: | |
| 1836 | switch (cmd->transport_error_status) { | 1819 | case TCM_INVALID_PARAMETER_LIST: |
| 1837 | case PYX_TRANSPORT_UNKNOWN_SAM_OPCODE: | 1820 | case TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE: |
| 1838 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; | 1821 | case TCM_UNKNOWN_MODE_PAGE: |
| 1839 | break; | 1822 | case TCM_WRITE_PROTECTED: |
| 1840 | case PYX_TRANSPORT_REQ_TOO_MANY_SECTORS: | 1823 | case TCM_CHECK_CONDITION_ABORT_CMD: |
| 1841 | cmd->scsi_sense_reason = TCM_SECTOR_COUNT_TOO_MANY; | 1824 | case TCM_CHECK_CONDITION_UNIT_ATTENTION: |
| 1842 | break; | 1825 | case TCM_CHECK_CONDITION_NOT_READY: |
| 1843 | case PYX_TRANSPORT_INVALID_CDB_FIELD: | ||
| 1844 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; | ||
| 1845 | break; | ||
| 1846 | case PYX_TRANSPORT_INVALID_PARAMETER_LIST: | ||
| 1847 | cmd->scsi_sense_reason = TCM_INVALID_PARAMETER_LIST; | ||
| 1848 | break; | ||
| 1849 | case PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES: | ||
| 1850 | if (!sc) | ||
| 1851 | transport_new_cmd_failure(cmd); | ||
| 1852 | /* | ||
| 1853 | * Currently for PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES, | ||
| 1854 | * we force this session to fall back to session | ||
| 1855 | * recovery. | ||
| 1856 | */ | ||
| 1857 | cmd->se_tfo->fall_back_to_erl0(cmd->se_sess); | ||
| 1858 | cmd->se_tfo->stop_session(cmd->se_sess, 0, 0); | ||
| 1859 | |||
| 1860 | goto check_stop; | ||
| 1861 | case PYX_TRANSPORT_LU_COMM_FAILURE: | ||
| 1862 | case PYX_TRANSPORT_ILLEGAL_REQUEST: | ||
| 1863 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; | ||
| 1864 | break; | ||
| 1865 | case PYX_TRANSPORT_UNKNOWN_MODE_PAGE: | ||
| 1866 | cmd->scsi_sense_reason = TCM_UNKNOWN_MODE_PAGE; | ||
| 1867 | break; | ||
| 1868 | case PYX_TRANSPORT_WRITE_PROTECTED: | ||
| 1869 | cmd->scsi_sense_reason = TCM_WRITE_PROTECTED; | ||
| 1870 | break; | 1826 | break; |
| 1871 | case PYX_TRANSPORT_RESERVATION_CONFLICT: | 1827 | case TCM_RESERVATION_CONFLICT: |
| 1872 | /* | 1828 | /* |
| 1873 | * No SENSE Data payload for this case, set SCSI Status | 1829 | * No SENSE Data payload for this case, set SCSI Status |
| 1874 | * and queue the response to $FABRIC_MOD. | 1830 | * and queue the response to $FABRIC_MOD. |
| @@ -1893,15 +1849,9 @@ static void transport_generic_request_failure( | |||
| 1893 | if (ret == -EAGAIN || ret == -ENOMEM) | 1849 | if (ret == -EAGAIN || ret == -ENOMEM) |
| 1894 | goto queue_full; | 1850 | goto queue_full; |
| 1895 | goto check_stop; | 1851 | goto check_stop; |
| 1896 | case PYX_TRANSPORT_USE_SENSE_REASON: | ||
| 1897 | /* | ||
| 1898 | * struct se_cmd->scsi_sense_reason already set | ||
| 1899 | */ | ||
| 1900 | break; | ||
| 1901 | default: | 1852 | default: |
| 1902 | pr_err("Unknown transport error for CDB 0x%02x: %d\n", | 1853 | pr_err("Unknown transport error for CDB 0x%02x: %d\n", |
| 1903 | cmd->t_task_cdb[0], | 1854 | cmd->t_task_cdb[0], cmd->scsi_sense_reason); |
| 1904 | cmd->transport_error_status); | ||
| 1905 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; | 1855 | cmd->scsi_sense_reason = TCM_UNSUPPORTED_SCSI_OPCODE; |
| 1906 | break; | 1856 | break; |
| 1907 | } | 1857 | } |
| @@ -1912,14 +1862,10 @@ static void transport_generic_request_failure( | |||
| 1912 | * transport_send_check_condition_and_sense() after handling | 1862 | * transport_send_check_condition_and_sense() after handling |
| 1913 | * possible unsoliticied write data payloads. | 1863 | * possible unsoliticied write data payloads. |
| 1914 | */ | 1864 | */ |
| 1915 | if (!sc && !cmd->se_tfo->new_cmd_map) | 1865 | ret = transport_send_check_condition_and_sense(cmd, |
| 1916 | transport_new_cmd_failure(cmd); | 1866 | cmd->scsi_sense_reason, 0); |
| 1917 | else { | 1867 | if (ret == -EAGAIN || ret == -ENOMEM) |
| 1918 | ret = transport_send_check_condition_and_sense(cmd, | 1868 | goto queue_full; |
| 1919 | cmd->scsi_sense_reason, 0); | ||
| 1920 | if (ret == -EAGAIN || ret == -ENOMEM) | ||
| 1921 | goto queue_full; | ||
| 1922 | } | ||
| 1923 | 1869 | ||
| 1924 | check_stop: | 1870 | check_stop: |
| 1925 | transport_lun_remove_cmd(cmd); | 1871 | transport_lun_remove_cmd(cmd); |
| @@ -2002,19 +1948,12 @@ static inline int transport_execute_task_attr(struct se_cmd *cmd) | |||
| 2002 | * to allow the passed struct se_cmd list of tasks to the front of the list. | 1948 | * to allow the passed struct se_cmd list of tasks to the front of the list. |
| 2003 | */ | 1949 | */ |
| 2004 | if (cmd->sam_task_attr == MSG_HEAD_TAG) { | 1950 | if (cmd->sam_task_attr == MSG_HEAD_TAG) { |
| 2005 | atomic_inc(&cmd->se_dev->dev_hoq_count); | ||
| 2006 | smp_mb__after_atomic_inc(); | ||
| 2007 | pr_debug("Added HEAD_OF_QUEUE for CDB:" | 1951 | pr_debug("Added HEAD_OF_QUEUE for CDB:" |
| 2008 | " 0x%02x, se_ordered_id: %u\n", | 1952 | " 0x%02x, se_ordered_id: %u\n", |
| 2009 | cmd->t_task_cdb[0], | 1953 | cmd->t_task_cdb[0], |
| 2010 | cmd->se_ordered_id); | 1954 | cmd->se_ordered_id); |
| 2011 | return 1; | 1955 | return 1; |
| 2012 | } else if (cmd->sam_task_attr == MSG_ORDERED_TAG) { | 1956 | } else if (cmd->sam_task_attr == MSG_ORDERED_TAG) { |
| 2013 | spin_lock(&cmd->se_dev->ordered_cmd_lock); | ||
| 2014 | list_add_tail(&cmd->se_ordered_node, | ||
| 2015 | &cmd->se_dev->ordered_cmd_list); | ||
| 2016 | spin_unlock(&cmd->se_dev->ordered_cmd_lock); | ||
| 2017 | |||
| 2018 | atomic_inc(&cmd->se_dev->dev_ordered_sync); | 1957 | atomic_inc(&cmd->se_dev->dev_ordered_sync); |
| 2019 | smp_mb__after_atomic_inc(); | 1958 | smp_mb__after_atomic_inc(); |
| 2020 | 1959 | ||
| @@ -2076,9 +2015,9 @@ static int transport_execute_tasks(struct se_cmd *cmd) | |||
| 2076 | { | 2015 | { |
| 2077 | int add_tasks; | 2016 | int add_tasks; |
| 2078 | 2017 | ||
| 2079 | if (se_dev_check_online(cmd->se_orig_obj_ptr) != 0) { | 2018 | if (se_dev_check_online(cmd->se_dev) != 0) { |
| 2080 | cmd->transport_error_status = PYX_TRANSPORT_LU_COMM_FAILURE; | 2019 | cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE; |
| 2081 | transport_generic_request_failure(cmd, 0, 1); | 2020 | transport_generic_request_failure(cmd); |
| 2082 | return 0; | 2021 | return 0; |
| 2083 | } | 2022 | } |
| 2084 | 2023 | ||
| @@ -2163,14 +2102,13 @@ check_depth: | |||
| 2163 | else | 2102 | else |
| 2164 | error = dev->transport->do_task(task); | 2103 | error = dev->transport->do_task(task); |
| 2165 | if (error != 0) { | 2104 | if (error != 0) { |
| 2166 | cmd->transport_error_status = error; | ||
| 2167 | spin_lock_irqsave(&cmd->t_state_lock, flags); | 2105 | spin_lock_irqsave(&cmd->t_state_lock, flags); |
| 2168 | task->task_flags &= ~TF_ACTIVE; | 2106 | task->task_flags &= ~TF_ACTIVE; |
| 2169 | spin_unlock_irqrestore(&cmd->t_state_lock, flags); | 2107 | spin_unlock_irqrestore(&cmd->t_state_lock, flags); |
| 2170 | atomic_set(&cmd->t_transport_sent, 0); | 2108 | atomic_set(&cmd->t_transport_sent, 0); |
| 2171 | transport_stop_tasks_for_cmd(cmd); | 2109 | transport_stop_tasks_for_cmd(cmd); |
| 2172 | atomic_inc(&dev->depth_left); | 2110 | atomic_inc(&dev->depth_left); |
| 2173 | transport_generic_request_failure(cmd, 0, 1); | 2111 | transport_generic_request_failure(cmd); |
| 2174 | } | 2112 | } |
| 2175 | 2113 | ||
| 2176 | goto check_depth; | 2114 | goto check_depth; |
| @@ -2178,19 +2116,6 @@ check_depth: | |||
| 2178 | return 0; | 2116 | return 0; |
| 2179 | } | 2117 | } |
| 2180 | 2118 | ||
| 2181 | void transport_new_cmd_failure(struct se_cmd *se_cmd) | ||
| 2182 | { | ||
| 2183 | unsigned long flags; | ||
| 2184 | /* | ||
| 2185 | * Any unsolicited data will get dumped for failed command inside of | ||
| 2186 | * the fabric plugin | ||
| 2187 | */ | ||
| 2188 | spin_lock_irqsave(&se_cmd->t_state_lock, flags); | ||
| 2189 | se_cmd->se_cmd_flags |= SCF_SE_CMD_FAILED; | ||
| 2190 | se_cmd->se_cmd_flags |= SCF_SCSI_CDB_EXCEPTION; | ||
| 2191 | spin_unlock_irqrestore(&se_cmd->t_state_lock, flags); | ||
| 2192 | } | ||
| 2193 | |||
| 2194 | static inline u32 transport_get_sectors_6( | 2119 | static inline u32 transport_get_sectors_6( |
| 2195 | unsigned char *cdb, | 2120 | unsigned char *cdb, |
| 2196 | struct se_cmd *cmd, | 2121 | struct se_cmd *cmd, |
| @@ -2213,10 +2138,15 @@ static inline u32 transport_get_sectors_6( | |||
| 2213 | 2138 | ||
| 2214 | /* | 2139 | /* |
| 2215 | * Everything else assume TYPE_DISK Sector CDB location. | 2140 | * Everything else assume TYPE_DISK Sector CDB location. |
| 2216 | * Use 8-bit sector value. | 2141 | * Use 8-bit sector value. SBC-3 says: |
| 2142 | * | ||
| 2143 | * A TRANSFER LENGTH field set to zero specifies that 256 | ||
| 2144 | * logical blocks shall be written. Any other value | ||
| 2145 | * specifies the number of logical blocks that shall be | ||
| 2146 | * written. | ||
| 2217 | */ | 2147 | */ |
| 2218 | type_disk: | 2148 | type_disk: |
| 2219 | return (u32)cdb[4]; | 2149 | return cdb[4] ? : 256; |
| 2220 | } | 2150 | } |
| 2221 | 2151 | ||
| 2222 | static inline u32 transport_get_sectors_10( | 2152 | static inline u32 transport_get_sectors_10( |
| @@ -2460,27 +2390,6 @@ static int transport_get_sense_data(struct se_cmd *cmd) | |||
| 2460 | return -1; | 2390 | return -1; |
| 2461 | } | 2391 | } |
| 2462 | 2392 | ||
| 2463 | static int | ||
| 2464 | transport_handle_reservation_conflict(struct se_cmd *cmd) | ||
| 2465 | { | ||
| 2466 | cmd->se_cmd_flags |= SCF_SCSI_CDB_EXCEPTION; | ||
| 2467 | cmd->se_cmd_flags |= SCF_SCSI_RESERVATION_CONFLICT; | ||
| 2468 | cmd->scsi_status = SAM_STAT_RESERVATION_CONFLICT; | ||
| 2469 | /* | ||
| 2470 | * For UA Interlock Code 11b, a RESERVATION CONFLICT will | ||
| 2471 | * establish a UNIT ATTENTION with PREVIOUS RESERVATION | ||
| 2472 | * CONFLICT STATUS. | ||
| 2473 | * | ||
| 2474 | * See spc4r17, section 7.4.6 Control Mode Page, Table 349 | ||
| 2475 | */ | ||
| 2476 | if (cmd->se_sess && | ||
| 2477 | cmd->se_dev->se_sub_dev->se_dev_attrib.emulate_ua_intlck_ctrl == 2) | ||
| 2478 | core_scsi3_ua_allocate(cmd->se_sess->se_node_acl, | ||
| 2479 | cmd->orig_fe_lun, 0x2C, | ||
| 2480 | ASCQ_2CH_PREVIOUS_RESERVATION_CONFLICT_STATUS); | ||
| 2481 | return -EINVAL; | ||
| 2482 | } | ||
| 2483 | |||
| 2484 | static inline long long transport_dev_end_lba(struct se_device *dev) | 2393 | static inline long long transport_dev_end_lba(struct se_device *dev) |
| 2485 | { | 2394 | { |
| 2486 | return dev->transport->get_blocks(dev) + 1; | 2395 | return dev->transport->get_blocks(dev) + 1; |
| @@ -2595,8 +2504,12 @@ static int transport_generic_cmd_sequencer( | |||
| 2595 | */ | 2504 | */ |
| 2596 | if (su_dev->t10_pr.pr_ops.t10_reservation_check(cmd, &pr_reg_type) != 0) { | 2505 | if (su_dev->t10_pr.pr_ops.t10_reservation_check(cmd, &pr_reg_type) != 0) { |
| 2597 | if (su_dev->t10_pr.pr_ops.t10_seq_non_holder( | 2506 | if (su_dev->t10_pr.pr_ops.t10_seq_non_holder( |
| 2598 | cmd, cdb, pr_reg_type) != 0) | 2507 | cmd, cdb, pr_reg_type) != 0) { |
| 2599 | return transport_handle_reservation_conflict(cmd); | 2508 | cmd->se_cmd_flags |= SCF_SCSI_CDB_EXCEPTION; |
| 2509 | cmd->se_cmd_flags |= SCF_SCSI_RESERVATION_CONFLICT; | ||
| 2510 | cmd->scsi_sense_reason = TCM_RESERVATION_CONFLICT; | ||
| 2511 | return -EBUSY; | ||
| 2512 | } | ||
| 2600 | /* | 2513 | /* |
| 2601 | * This means the CDB is allowed for the SCSI Initiator port | 2514 | * This means the CDB is allowed for the SCSI Initiator port |
| 2602 | * when said port is *NOT* holding the legacy SPC-2 or | 2515 | * when said port is *NOT* holding the legacy SPC-2 or |
| @@ -2658,7 +2571,8 @@ static int transport_generic_cmd_sequencer( | |||
| 2658 | goto out_unsupported_cdb; | 2571 | goto out_unsupported_cdb; |
| 2659 | size = transport_get_size(sectors, cdb, cmd); | 2572 | size = transport_get_size(sectors, cdb, cmd); |
| 2660 | cmd->t_task_lba = transport_lba_32(cdb); | 2573 | cmd->t_task_lba = transport_lba_32(cdb); |
| 2661 | cmd->t_tasks_fua = (cdb[1] & 0x8); | 2574 | if (cdb[1] & 0x8) |
| 2575 | cmd->se_cmd_flags |= SCF_FUA; | ||
| 2662 | cmd->se_cmd_flags |= SCF_SCSI_DATA_SG_IO_CDB; | 2576 | cmd->se_cmd_flags |= SCF_SCSI_DATA_SG_IO_CDB; |
| 2663 | break; | 2577 | break; |
| 2664 | case WRITE_12: | 2578 | case WRITE_12: |
| @@ -2667,7 +2581,8 @@ static int transport_generic_cmd_sequencer( | |||
| 2667 | goto out_unsupported_cdb; | 2581 | goto out_unsupported_cdb; |
| 2668 | size = transport_get_size(sectors, cdb, cmd); | 2582 | size = transport_get_size(sectors, cdb, cmd); |
| 2669 | cmd->t_task_lba = transport_lba_32(cdb); | 2583 | cmd->t_task_lba = transport_lba_32(cdb); |
| 2670 | cmd->t_tasks_fua = (cdb[1] & 0x8); | 2584 | if (cdb[1] & 0x8) |
| 2585 | cmd->se_cmd_flags |= SCF_FUA; | ||
| 2671 | cmd->se_cmd_flags |= SCF_SCSI_DATA_SG_IO_CDB; | 2586 | cmd->se_cmd_flags |= SCF_SCSI_DATA_SG_IO_CDB; |
| 2672 | break; | 2587 | break; |
| 2673 | case WRITE_16: | 2588 | case WRITE_16: |
| @@ -2676,12 +2591,13 @@ static int transport_generic_cmd_sequencer( | |||
| 2676 | goto out_unsupported_cdb; | 2591 | goto out_unsupported_cdb; |
| 2677 | size = transport_get_size(sectors, cdb, cmd); | 2592 | size = transport_get_size(sectors, cdb, cmd); |
| 2678 | cmd->t_task_lba = transport_lba_64(cdb); | 2593 | cmd->t_task_lba = transport_lba_64(cdb); |
| 2679 | cmd->t_tasks_fua = (cdb[1] & 0x8); | 2594 | if (cdb[1] & 0x8) |
| 2595 | cmd->se_cmd_flags |= SCF_FUA; | ||
| 2680 | cmd->se_cmd_flags |= SCF_SCSI_DATA_SG_IO_CDB; | 2596 | cmd->se_cmd_flags |= SCF_SCSI_DATA_SG_IO_CDB; |
| 2681 | break; | 2597 | break; |
| 2682 | case XDWRITEREAD_10: | 2598 | case XDWRITEREAD_10: |
| 2683 | if ((cmd->data_direction != DMA_TO_DEVICE) || | 2599 | if ((cmd->data_direction != DMA_TO_DEVICE) || |
| 2684 | !(cmd->t_tasks_bidi)) | 2600 | !(cmd->se_cmd_flags & SCF_BIDI)) |
| 2685 | goto out_invalid_cdb_field; | 2601 | goto out_invalid_cdb_field; |
| 2686 | sectors = transport_get_sectors_10(cdb, cmd, §or_ret); | 2602 | sectors = transport_get_sectors_10(cdb, cmd, §or_ret); |
| 2687 | if (sector_ret) | 2603 | if (sector_ret) |
| @@ -2700,7 +2616,8 @@ static int transport_generic_cmd_sequencer( | |||
| 2700 | * Setup BIDI XOR callback to be run after I/O completion. | 2616 | * Setup BIDI XOR callback to be run after I/O completion. |
| 2701 | */ | 2617 | */ |
| 2702 | cmd->transport_complete_callback = &transport_xor_callback; | 2618 | cmd->transport_complete_callback = &transport_xor_callback; |
| 2703 | cmd->t_tasks_fua = (cdb[1] & 0x8); | 2619 | if (cdb[1] & 0x8) |
| 2620 | cmd->se_cmd_flags |= SCF_FUA; | ||
| 2704 | break; | 2621 | break; |
| 2705 | case VARIABLE_LENGTH_CMD: | 2622 | case VARIABLE_LENGTH_CMD: |
| 2706 | service_action = get_unaligned_be16(&cdb[8]); | 2623 | service_action = get_unaligned_be16(&cdb[8]); |
| @@ -2728,7 +2645,8 @@ static int transport_generic_cmd_sequencer( | |||
| 2728 | * completion. | 2645 | * completion. |
| 2729 | */ | 2646 | */ |
| 2730 | cmd->transport_complete_callback = &transport_xor_callback; | 2647 | cmd->transport_complete_callback = &transport_xor_callback; |
| 2731 | cmd->t_tasks_fua = (cdb[10] & 0x8); | 2648 | if (cdb[1] & 0x8) |
| 2649 | cmd->se_cmd_flags |= SCF_FUA; | ||
| 2732 | break; | 2650 | break; |
| 2733 | case WRITE_SAME_32: | 2651 | case WRITE_SAME_32: |
| 2734 | sectors = transport_get_sectors_32(cdb, cmd, §or_ret); | 2652 | sectors = transport_get_sectors_32(cdb, cmd, §or_ret); |
| @@ -3171,18 +3089,13 @@ static void transport_complete_task_attr(struct se_cmd *cmd) | |||
| 3171 | " SIMPLE: %u\n", dev->dev_cur_ordered_id, | 3089 | " SIMPLE: %u\n", dev->dev_cur_ordered_id, |
| 3172 | cmd->se_ordered_id); | 3090 | cmd->se_ordered_id); |
| 3173 | } else if (cmd->sam_task_attr == MSG_HEAD_TAG) { | 3091 | } else if (cmd->sam_task_attr == MSG_HEAD_TAG) { |
| 3174 | atomic_dec(&dev->dev_hoq_count); | ||
| 3175 | smp_mb__after_atomic_dec(); | ||
| 3176 | dev->dev_cur_ordered_id++; | 3092 | dev->dev_cur_ordered_id++; |
| 3177 | pr_debug("Incremented dev_cur_ordered_id: %u for" | 3093 | pr_debug("Incremented dev_cur_ordered_id: %u for" |
| 3178 | " HEAD_OF_QUEUE: %u\n", dev->dev_cur_ordered_id, | 3094 | " HEAD_OF_QUEUE: %u\n", dev->dev_cur_ordered_id, |
| 3179 | cmd->se_ordered_id); | 3095 | cmd->se_ordered_id); |
| 3180 | } else if (cmd->sam_task_attr == MSG_ORDERED_TAG) { | 3096 | } else if (cmd->sam_task_attr == MSG_ORDERED_TAG) { |
| 3181 | spin_lock(&dev->ordered_cmd_lock); | ||
| 3182 | list_del(&cmd->se_ordered_node); | ||
| 3183 | atomic_dec(&dev->dev_ordered_sync); | 3097 | atomic_dec(&dev->dev_ordered_sync); |
| 3184 | smp_mb__after_atomic_dec(); | 3098 | smp_mb__after_atomic_dec(); |
| 3185 | spin_unlock(&dev->ordered_cmd_lock); | ||
| 3186 | 3099 | ||
| 3187 | dev->dev_cur_ordered_id++; | 3100 | dev->dev_cur_ordered_id++; |
| 3188 | pr_debug("Incremented dev_cur_ordered_id: %u for ORDERED:" | 3101 | pr_debug("Incremented dev_cur_ordered_id: %u for ORDERED:" |
| @@ -3495,6 +3408,18 @@ int transport_generic_map_mem_to_cmd( | |||
| 3495 | 3408 | ||
| 3496 | if ((cmd->se_cmd_flags & SCF_SCSI_DATA_SG_IO_CDB) || | 3409 | if ((cmd->se_cmd_flags & SCF_SCSI_DATA_SG_IO_CDB) || |
| 3497 | (cmd->se_cmd_flags & SCF_SCSI_CONTROL_SG_IO_CDB)) { | 3410 | (cmd->se_cmd_flags & SCF_SCSI_CONTROL_SG_IO_CDB)) { |
| 3411 | /* | ||
| 3412 | * Reject SCSI data overflow with map_mem_to_cmd() as incoming | ||
| 3413 | * scatterlists already have been set to follow what the fabric | ||
| 3414 | * passes for the original expected data transfer length. | ||
| 3415 | */ | ||
| 3416 | if (cmd->se_cmd_flags & SCF_OVERFLOW_BIT) { | ||
| 3417 | pr_warn("Rejecting SCSI DATA overflow for fabric using" | ||
| 3418 | " SCF_PASSTHROUGH_SG_TO_MEM_NOALLOC\n"); | ||
| 3419 | cmd->se_cmd_flags |= SCF_SCSI_CDB_EXCEPTION; | ||
| 3420 | cmd->scsi_sense_reason = TCM_INVALID_CDB_FIELD; | ||
| 3421 | return -EINVAL; | ||
| 3422 | } | ||
| 3498 | 3423 | ||
| 3499 | cmd->t_data_sg = sgl; | 3424 | cmd->t_data_sg = sgl; |
| 3500 | cmd->t_data_nents = sgl_count; | 3425 | cmd->t_data_nents = sgl_count; |
| @@ -3813,7 +3738,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd) | |||
| 3813 | cmd->data_length) { | 3738 | cmd->data_length) { |
| 3814 | ret = transport_generic_get_mem(cmd); | 3739 | ret = transport_generic_get_mem(cmd); |
| 3815 | if (ret < 0) | 3740 | if (ret < 0) |
| 3816 | return ret; | 3741 | goto out_fail; |
| 3817 | } | 3742 | } |
| 3818 | 3743 | ||
| 3819 | /* | 3744 | /* |
| @@ -3842,8 +3767,15 @@ int transport_generic_new_cmd(struct se_cmd *cmd) | |||
| 3842 | task_cdbs = transport_allocate_control_task(cmd); | 3767 | task_cdbs = transport_allocate_control_task(cmd); |
| 3843 | } | 3768 | } |
| 3844 | 3769 | ||
| 3845 | if (task_cdbs <= 0) | 3770 | if (task_cdbs < 0) |
| 3846 | goto out_fail; | 3771 | goto out_fail; |
| 3772 | else if (!task_cdbs && (cmd->se_cmd_flags & SCF_SCSI_DATA_SG_IO_CDB)) { | ||
| 3773 | cmd->t_state = TRANSPORT_COMPLETE; | ||
| 3774 | atomic_set(&cmd->t_transport_active, 1); | ||
| 3775 | INIT_WORK(&cmd->work, target_complete_ok_work); | ||
| 3776 | queue_work(target_completion_wq, &cmd->work); | ||
| 3777 | return 0; | ||
| 3778 | } | ||
| 3847 | 3779 | ||
| 3848 | if (set_counts) { | 3780 | if (set_counts) { |
| 3849 | atomic_inc(&cmd->t_fe_count); | 3781 | atomic_inc(&cmd->t_fe_count); |
| @@ -3929,7 +3861,7 @@ static int transport_generic_write_pending(struct se_cmd *cmd) | |||
| 3929 | else if (ret < 0) | 3861 | else if (ret < 0) |
| 3930 | return ret; | 3862 | return ret; |
| 3931 | 3863 | ||
| 3932 | return PYX_TRANSPORT_WRITE_PENDING; | 3864 | return 1; |
| 3933 | 3865 | ||
| 3934 | queue_full: | 3866 | queue_full: |
| 3935 | pr_debug("Handling write_pending QUEUE__FULL: se_cmd: %p\n", cmd); | 3867 | pr_debug("Handling write_pending QUEUE__FULL: se_cmd: %p\n", cmd); |
| @@ -4602,9 +4534,6 @@ void transport_send_task_abort(struct se_cmd *cmd) | |||
| 4602 | if (cmd->se_tfo->write_pending_status(cmd) != 0) { | 4534 | if (cmd->se_tfo->write_pending_status(cmd) != 0) { |
| 4603 | atomic_inc(&cmd->t_transport_aborted); | 4535 | atomic_inc(&cmd->t_transport_aborted); |
| 4604 | smp_mb__after_atomic_inc(); | 4536 | smp_mb__after_atomic_inc(); |
| 4605 | cmd->scsi_status = SAM_STAT_TASK_ABORTED; | ||
| 4606 | transport_new_cmd_failure(cmd); | ||
| 4607 | return; | ||
| 4608 | } | 4537 | } |
| 4609 | } | 4538 | } |
| 4610 | cmd->scsi_status = SAM_STAT_TASK_ABORTED; | 4539 | cmd->scsi_status = SAM_STAT_TASK_ABORTED; |
| @@ -4670,8 +4599,6 @@ static int transport_processing_thread(void *param) | |||
| 4670 | struct se_cmd *cmd; | 4599 | struct se_cmd *cmd; |
| 4671 | struct se_device *dev = (struct se_device *) param; | 4600 | struct se_device *dev = (struct se_device *) param; |
| 4672 | 4601 | ||
| 4673 | set_user_nice(current, -20); | ||
| 4674 | |||
| 4675 | while (!kthread_should_stop()) { | 4602 | while (!kthread_should_stop()) { |
| 4676 | ret = wait_event_interruptible(dev->dev_queue_obj.thread_wq, | 4603 | ret = wait_event_interruptible(dev->dev_queue_obj.thread_wq, |
| 4677 | atomic_read(&dev->dev_queue_obj.queue_cnt) || | 4604 | atomic_read(&dev->dev_queue_obj.queue_cnt) || |
| @@ -4698,18 +4625,13 @@ get_cmd: | |||
| 4698 | } | 4625 | } |
| 4699 | ret = cmd->se_tfo->new_cmd_map(cmd); | 4626 | ret = cmd->se_tfo->new_cmd_map(cmd); |
| 4700 | if (ret < 0) { | 4627 | if (ret < 0) { |
| 4701 | cmd->transport_error_status = ret; | 4628 | transport_generic_request_failure(cmd); |
| 4702 | transport_generic_request_failure(cmd, | ||
| 4703 | 0, (cmd->data_direction != | ||
| 4704 | DMA_TO_DEVICE)); | ||
| 4705 | break; | 4629 | break; |
| 4706 | } | 4630 | } |
| 4707 | ret = transport_generic_new_cmd(cmd); | 4631 | ret = transport_generic_new_cmd(cmd); |
| 4708 | if (ret < 0) { | 4632 | if (ret < 0) { |
| 4709 | cmd->transport_error_status = ret; | 4633 | transport_generic_request_failure(cmd); |
| 4710 | transport_generic_request_failure(cmd, | 4634 | break; |
| 4711 | 0, (cmd->data_direction != | ||
| 4712 | DMA_TO_DEVICE)); | ||
| 4713 | } | 4635 | } |
| 4714 | break; | 4636 | break; |
| 4715 | case TRANSPORT_PROCESS_WRITE: | 4637 | case TRANSPORT_PROCESS_WRITE: |
diff --git a/drivers/target/tcm_fc/tfc_cmd.c b/drivers/target/tcm_fc/tfc_cmd.c index 4fac37c4c615..71fc9cea5dc9 100644 --- a/drivers/target/tcm_fc/tfc_cmd.c +++ b/drivers/target/tcm_fc/tfc_cmd.c | |||
| @@ -200,7 +200,7 @@ int ft_write_pending(struct se_cmd *se_cmd) | |||
| 200 | lport = ep->lp; | 200 | lport = ep->lp; |
| 201 | fp = fc_frame_alloc(lport, sizeof(*txrdy)); | 201 | fp = fc_frame_alloc(lport, sizeof(*txrdy)); |
| 202 | if (!fp) | 202 | if (!fp) |
| 203 | return PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES; | 203 | return -ENOMEM; /* Signal QUEUE_FULL */ |
| 204 | 204 | ||
| 205 | txrdy = fc_frame_payload_get(fp, sizeof(*txrdy)); | 205 | txrdy = fc_frame_payload_get(fp, sizeof(*txrdy)); |
| 206 | memset(txrdy, 0, sizeof(*txrdy)); | 206 | memset(txrdy, 0, sizeof(*txrdy)); |
diff --git a/drivers/target/tcm_fc/tfc_conf.c b/drivers/target/tcm_fc/tfc_conf.c index 5f770412ca40..9402b7387cac 100644 --- a/drivers/target/tcm_fc/tfc_conf.c +++ b/drivers/target/tcm_fc/tfc_conf.c | |||
| @@ -436,8 +436,7 @@ static void ft_del_lport(struct se_wwn *wwn) | |||
| 436 | struct ft_lport_acl *lacl = container_of(wwn, | 436 | struct ft_lport_acl *lacl = container_of(wwn, |
| 437 | struct ft_lport_acl, fc_lport_wwn); | 437 | struct ft_lport_acl, fc_lport_wwn); |
| 438 | 438 | ||
| 439 | pr_debug("del lport %s\n", | 439 | pr_debug("del lport %s\n", lacl->name); |
| 440 | config_item_name(&wwn->wwn_group.cg_item)); | ||
| 441 | mutex_lock(&ft_lport_lock); | 440 | mutex_lock(&ft_lport_lock); |
| 442 | list_del(&lacl->list); | 441 | list_del(&lacl->list); |
| 443 | mutex_unlock(&ft_lport_lock); | 442 | mutex_unlock(&ft_lport_lock); |
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index e8c564a53346..a8078d0638fa 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c | |||
| @@ -1458,6 +1458,16 @@ static const struct usb_device_id acm_ids[] = { | |||
| 1458 | }, | 1458 | }, |
| 1459 | { USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */ | 1459 | { USB_DEVICE(0x22b8, 0x6425), /* Motorola MOTOMAGX phones */ |
| 1460 | }, | 1460 | }, |
| 1461 | /* Motorola H24 HSPA module: */ | ||
| 1462 | { USB_DEVICE(0x22b8, 0x2d91) }, /* modem */ | ||
| 1463 | { USB_DEVICE(0x22b8, 0x2d92) }, /* modem + diagnostics */ | ||
| 1464 | { USB_DEVICE(0x22b8, 0x2d93) }, /* modem + AT port */ | ||
| 1465 | { USB_DEVICE(0x22b8, 0x2d95) }, /* modem + AT port + diagnostics */ | ||
| 1466 | { USB_DEVICE(0x22b8, 0x2d96) }, /* modem + NMEA */ | ||
| 1467 | { USB_DEVICE(0x22b8, 0x2d97) }, /* modem + diagnostics + NMEA */ | ||
| 1468 | { USB_DEVICE(0x22b8, 0x2d99) }, /* modem + AT port + NMEA */ | ||
| 1469 | { USB_DEVICE(0x22b8, 0x2d9a) }, /* modem + AT port + diagnostics + NMEA */ | ||
| 1470 | |||
| 1461 | { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */ | 1471 | { USB_DEVICE(0x0572, 0x1329), /* Hummingbird huc56s (Conexant) */ |
| 1462 | .driver_info = NO_UNION_NORMAL, /* union descriptor misplaced on | 1472 | .driver_info = NO_UNION_NORMAL, /* union descriptor misplaced on |
| 1463 | data interface instead of | 1473 | data interface instead of |
diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c index 4730016d7cd4..45f422ac103f 100644 --- a/drivers/usb/gadget/amd5536udc.c +++ b/drivers/usb/gadget/amd5536udc.c | |||
| @@ -1959,7 +1959,7 @@ static int amd5536_start(struct usb_gadget_driver *driver, | |||
| 1959 | u32 tmp; | 1959 | u32 tmp; |
| 1960 | 1960 | ||
| 1961 | if (!driver || !bind || !driver->setup | 1961 | if (!driver || !bind || !driver->setup |
| 1962 | || driver->speed != USB_SPEED_HIGH) | 1962 | || driver->speed < USB_SPEED_HIGH) |
| 1963 | return -EINVAL; | 1963 | return -EINVAL; |
| 1964 | if (!dev) | 1964 | if (!dev) |
| 1965 | return -ENODEV; | 1965 | return -ENODEV; |
diff --git a/drivers/usb/gadget/f_mass_storage.c b/drivers/usb/gadget/f_mass_storage.c index c39d58860fa0..1a6f415c0d02 100644 --- a/drivers/usb/gadget/f_mass_storage.c +++ b/drivers/usb/gadget/f_mass_storage.c | |||
| @@ -2975,6 +2975,7 @@ static void fsg_unbind(struct usb_configuration *c, struct usb_function *f) | |||
| 2975 | fsg_common_put(common); | 2975 | fsg_common_put(common); |
| 2976 | usb_free_descriptors(fsg->function.descriptors); | 2976 | usb_free_descriptors(fsg->function.descriptors); |
| 2977 | usb_free_descriptors(fsg->function.hs_descriptors); | 2977 | usb_free_descriptors(fsg->function.hs_descriptors); |
| 2978 | usb_free_descriptors(fsg->function.ss_descriptors); | ||
| 2978 | kfree(fsg); | 2979 | kfree(fsg); |
| 2979 | } | 2980 | } |
| 2980 | 2981 | ||
diff --git a/drivers/usb/gadget/f_serial.c b/drivers/usb/gadget/f_serial.c index 91fdf790ed20..cf33a8d0fd5d 100644 --- a/drivers/usb/gadget/f_serial.c +++ b/drivers/usb/gadget/f_serial.c | |||
| @@ -131,8 +131,8 @@ static int gser_set_alt(struct usb_function *f, unsigned intf, unsigned alt) | |||
| 131 | } | 131 | } |
| 132 | if (!gser->port.in->desc || !gser->port.out->desc) { | 132 | if (!gser->port.in->desc || !gser->port.out->desc) { |
| 133 | DBG(cdev, "activate generic ttyGS%d\n", gser->port_num); | 133 | DBG(cdev, "activate generic ttyGS%d\n", gser->port_num); |
| 134 | if (!config_ep_by_speed(cdev->gadget, f, gser->port.in) || | 134 | if (config_ep_by_speed(cdev->gadget, f, gser->port.in) || |
| 135 | !config_ep_by_speed(cdev->gadget, f, gser->port.out)) { | 135 | config_ep_by_speed(cdev->gadget, f, gser->port.out)) { |
| 136 | gser->port.in->desc = NULL; | 136 | gser->port.in->desc = NULL; |
| 137 | gser->port.out->desc = NULL; | 137 | gser->port.out->desc = NULL; |
| 138 | return -EINVAL; | 138 | return -EINVAL; |
diff --git a/drivers/usb/gadget/fsl_mxc_udc.c b/drivers/usb/gadget/fsl_mxc_udc.c index 43a49ecc1f36..dcbc0a2e48dd 100644 --- a/drivers/usb/gadget/fsl_mxc_udc.c +++ b/drivers/usb/gadget/fsl_mxc_udc.c | |||
| @@ -16,6 +16,7 @@ | |||
| 16 | #include <linux/err.h> | 16 | #include <linux/err.h> |
| 17 | #include <linux/fsl_devices.h> | 17 | #include <linux/fsl_devices.h> |
| 18 | #include <linux/platform_device.h> | 18 | #include <linux/platform_device.h> |
| 19 | #include <linux/io.h> | ||
| 19 | 20 | ||
| 20 | #include <mach/hardware.h> | 21 | #include <mach/hardware.h> |
| 21 | 22 | ||
| @@ -88,7 +89,6 @@ eenahb: | |||
| 88 | void fsl_udc_clk_finalize(struct platform_device *pdev) | 89 | void fsl_udc_clk_finalize(struct platform_device *pdev) |
| 89 | { | 90 | { |
| 90 | struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data; | 91 | struct fsl_usb2_platform_data *pdata = pdev->dev.platform_data; |
| 91 | #if defined(CONFIG_SOC_IMX35) | ||
| 92 | if (cpu_is_mx35()) { | 92 | if (cpu_is_mx35()) { |
| 93 | unsigned int v; | 93 | unsigned int v; |
| 94 | 94 | ||
| @@ -101,7 +101,6 @@ void fsl_udc_clk_finalize(struct platform_device *pdev) | |||
| 101 | USBPHYCTRL_OTGBASE_OFFSET)); | 101 | USBPHYCTRL_OTGBASE_OFFSET)); |
| 102 | } | 102 | } |
| 103 | } | 103 | } |
| 104 | #endif | ||
| 105 | 104 | ||
| 106 | /* ULPI transceivers don't need usbpll */ | 105 | /* ULPI transceivers don't need usbpll */ |
| 107 | if (pdata->phy_mode == FSL_USB2_PHY_ULPI) { | 106 | if (pdata->phy_mode == FSL_USB2_PHY_ULPI) { |
diff --git a/drivers/usb/gadget/fsl_qe_udc.c b/drivers/usb/gadget/fsl_qe_udc.c index 2a03e4de11c1..e00cf92409ce 100644 --- a/drivers/usb/gadget/fsl_qe_udc.c +++ b/drivers/usb/gadget/fsl_qe_udc.c | |||
| @@ -2336,8 +2336,7 @@ static int fsl_qe_start(struct usb_gadget_driver *driver, | |||
| 2336 | if (!udc_controller) | 2336 | if (!udc_controller) |
| 2337 | return -ENODEV; | 2337 | return -ENODEV; |
| 2338 | 2338 | ||
| 2339 | if (!driver || (driver->speed != USB_SPEED_FULL | 2339 | if (!driver || driver->speed < USB_SPEED_FULL |
| 2340 | && driver->speed != USB_SPEED_HIGH) | ||
| 2341 | || !bind || !driver->disconnect || !driver->setup) | 2340 | || !bind || !driver->disconnect || !driver->setup) |
| 2342 | return -EINVAL; | 2341 | return -EINVAL; |
| 2343 | 2342 | ||
diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index b3b3d83b7c33..dd28ef3def71 100644 --- a/drivers/usb/gadget/fsl_udc_core.c +++ b/drivers/usb/gadget/fsl_udc_core.c | |||
| @@ -696,12 +696,31 @@ static void fsl_free_request(struct usb_ep *_ep, struct usb_request *_req) | |||
| 696 | kfree(req); | 696 | kfree(req); |
| 697 | } | 697 | } |
| 698 | 698 | ||
| 699 | /*-------------------------------------------------------------------------*/ | 699 | /* Actually add a dTD chain to an empty dQH and let go */ |
| 700 | static void fsl_prime_ep(struct fsl_ep *ep, struct ep_td_struct *td) | ||
| 701 | { | ||
| 702 | struct ep_queue_head *qh = get_qh_by_ep(ep); | ||
| 703 | |||
| 704 | /* Write dQH next pointer and terminate bit to 0 */ | ||
| 705 | qh->next_dtd_ptr = cpu_to_hc32(td->td_dma | ||
| 706 | & EP_QUEUE_HEAD_NEXT_POINTER_MASK); | ||
| 707 | |||
| 708 | /* Clear active and halt bit */ | ||
| 709 | qh->size_ioc_int_sts &= cpu_to_hc32(~(EP_QUEUE_HEAD_STATUS_ACTIVE | ||
| 710 | | EP_QUEUE_HEAD_STATUS_HALT)); | ||
| 711 | |||
| 712 | /* Ensure that updates to the QH will occur before priming. */ | ||
| 713 | wmb(); | ||
| 714 | |||
| 715 | /* Prime endpoint by writing correct bit to ENDPTPRIME */ | ||
| 716 | fsl_writel(ep_is_in(ep) ? (1 << (ep_index(ep) + 16)) | ||
| 717 | : (1 << (ep_index(ep))), &dr_regs->endpointprime); | ||
| 718 | } | ||
| 719 | |||
| 720 | /* Add dTD chain to the dQH of an EP */ | ||
| 700 | static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req) | 721 | static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req) |
| 701 | { | 722 | { |
| 702 | int i = ep_index(ep) * 2 + ep_is_in(ep); | ||
| 703 | u32 temp, bitmask, tmp_stat; | 723 | u32 temp, bitmask, tmp_stat; |
| 704 | struct ep_queue_head *dQH = &ep->udc->ep_qh[i]; | ||
| 705 | 724 | ||
| 706 | /* VDBG("QH addr Register 0x%8x", dr_regs->endpointlistaddr); | 725 | /* VDBG("QH addr Register 0x%8x", dr_regs->endpointlistaddr); |
| 707 | VDBG("ep_qh[%d] addr is 0x%8x", i, (u32)&(ep->udc->ep_qh[i])); */ | 726 | VDBG("ep_qh[%d] addr is 0x%8x", i, (u32)&(ep->udc->ep_qh[i])); */ |
| @@ -719,7 +738,7 @@ static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req) | |||
| 719 | cpu_to_hc32(req->head->td_dma & DTD_ADDR_MASK); | 738 | cpu_to_hc32(req->head->td_dma & DTD_ADDR_MASK); |
| 720 | /* Read prime bit, if 1 goto done */ | 739 | /* Read prime bit, if 1 goto done */ |
| 721 | if (fsl_readl(&dr_regs->endpointprime) & bitmask) | 740 | if (fsl_readl(&dr_regs->endpointprime) & bitmask) |
| 722 | goto out; | 741 | return; |
| 723 | 742 | ||
| 724 | do { | 743 | do { |
| 725 | /* Set ATDTW bit in USBCMD */ | 744 | /* Set ATDTW bit in USBCMD */ |
| @@ -736,28 +755,10 @@ static void fsl_queue_td(struct fsl_ep *ep, struct fsl_req *req) | |||
| 736 | fsl_writel(temp & ~USB_CMD_ATDTW, &dr_regs->usbcmd); | 755 | fsl_writel(temp & ~USB_CMD_ATDTW, &dr_regs->usbcmd); |
| 737 | 756 | ||
| 738 | if (tmp_stat) | 757 | if (tmp_stat) |
| 739 | goto out; | 758 | return; |
| 740 | } | 759 | } |
| 741 | 760 | ||
| 742 | /* Write dQH next pointer and terminate bit to 0 */ | 761 | fsl_prime_ep(ep, req->head); |
| 743 | temp = req->head->td_dma & EP_QUEUE_HEAD_NEXT_POINTER_MASK; | ||
| 744 | dQH->next_dtd_ptr = cpu_to_hc32(temp); | ||
| 745 | |||
| 746 | /* Clear active and halt bit */ | ||
| 747 | temp = cpu_to_hc32(~(EP_QUEUE_HEAD_STATUS_ACTIVE | ||
| 748 | | EP_QUEUE_HEAD_STATUS_HALT)); | ||
| 749 | dQH->size_ioc_int_sts &= temp; | ||
| 750 | |||
| 751 | /* Ensure that updates to the QH will occur before priming. */ | ||
| 752 | wmb(); | ||
| 753 | |||
| 754 | /* Prime endpoint by writing 1 to ENDPTPRIME */ | ||
| 755 | temp = ep_is_in(ep) | ||
| 756 | ? (1 << (ep_index(ep) + 16)) | ||
| 757 | : (1 << (ep_index(ep))); | ||
| 758 | fsl_writel(temp, &dr_regs->endpointprime); | ||
| 759 | out: | ||
| 760 | return; | ||
| 761 | } | 762 | } |
| 762 | 763 | ||
| 763 | /* Fill in the dTD structure | 764 | /* Fill in the dTD structure |
| @@ -877,7 +878,7 @@ fsl_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags) | |||
| 877 | VDBG("%s, bad ep", __func__); | 878 | VDBG("%s, bad ep", __func__); |
| 878 | return -EINVAL; | 879 | return -EINVAL; |
| 879 | } | 880 | } |
| 880 | if (ep->desc->bmAttributes == USB_ENDPOINT_XFER_ISOC) { | 881 | if (usb_endpoint_xfer_isoc(ep->desc)) { |
| 881 | if (req->req.length > ep->ep.maxpacket) | 882 | if (req->req.length > ep->ep.maxpacket) |
| 882 | return -EMSGSIZE; | 883 | return -EMSGSIZE; |
| 883 | } | 884 | } |
| @@ -973,25 +974,20 @@ static int fsl_ep_dequeue(struct usb_ep *_ep, struct usb_request *_req) | |||
| 973 | 974 | ||
| 974 | /* The request isn't the last request in this ep queue */ | 975 | /* The request isn't the last request in this ep queue */ |
| 975 | if (req->queue.next != &ep->queue) { | 976 | if (req->queue.next != &ep->queue) { |
| 976 | struct ep_queue_head *qh; | ||
| 977 | struct fsl_req *next_req; | 977 | struct fsl_req *next_req; |
| 978 | 978 | ||
| 979 | qh = ep->qh; | ||
| 980 | next_req = list_entry(req->queue.next, struct fsl_req, | 979 | next_req = list_entry(req->queue.next, struct fsl_req, |
| 981 | queue); | 980 | queue); |
| 982 | 981 | ||
| 983 | /* Point the QH to the first TD of next request */ | 982 | /* prime with dTD of next request */ |
| 984 | fsl_writel((u32) next_req->head, &qh->curr_dtd_ptr); | 983 | fsl_prime_ep(ep, next_req->head); |
| 985 | } | 984 | } |
| 986 | 985 | /* The request hasn't been processed, patch up the TD chain */ | |
| 987 | /* The request hasn't been processed, patch up the TD chain */ | ||
| 988 | } else { | 986 | } else { |
| 989 | struct fsl_req *prev_req; | 987 | struct fsl_req *prev_req; |
| 990 | 988 | ||
| 991 | prev_req = list_entry(req->queue.prev, struct fsl_req, queue); | 989 | prev_req = list_entry(req->queue.prev, struct fsl_req, queue); |
| 992 | fsl_writel(fsl_readl(&req->tail->next_td_ptr), | 990 | prev_req->tail->next_td_ptr = req->tail->next_td_ptr; |
| 993 | &prev_req->tail->next_td_ptr); | ||
| 994 | |||
| 995 | } | 991 | } |
| 996 | 992 | ||
| 997 | done(ep, req, -ECONNRESET); | 993 | done(ep, req, -ECONNRESET); |
| @@ -1032,7 +1028,7 @@ static int fsl_ep_set_halt(struct usb_ep *_ep, int value) | |||
| 1032 | goto out; | 1028 | goto out; |
| 1033 | } | 1029 | } |
| 1034 | 1030 | ||
| 1035 | if (ep->desc->bmAttributes == USB_ENDPOINT_XFER_ISOC) { | 1031 | if (usb_endpoint_xfer_isoc(ep->desc)) { |
| 1036 | status = -EOPNOTSUPP; | 1032 | status = -EOPNOTSUPP; |
| 1037 | goto out; | 1033 | goto out; |
| 1038 | } | 1034 | } |
| @@ -1068,7 +1064,7 @@ static int fsl_ep_fifo_status(struct usb_ep *_ep) | |||
| 1068 | struct fsl_udc *udc; | 1064 | struct fsl_udc *udc; |
| 1069 | int size = 0; | 1065 | int size = 0; |
| 1070 | u32 bitmask; | 1066 | u32 bitmask; |
| 1071 | struct ep_queue_head *d_qh; | 1067 | struct ep_queue_head *qh; |
| 1072 | 1068 | ||
| 1073 | ep = container_of(_ep, struct fsl_ep, ep); | 1069 | ep = container_of(_ep, struct fsl_ep, ep); |
| 1074 | if (!_ep || (!ep->desc && ep_index(ep) != 0)) | 1070 | if (!_ep || (!ep->desc && ep_index(ep) != 0)) |
| @@ -1079,13 +1075,13 @@ static int fsl_ep_fifo_status(struct usb_ep *_ep) | |||
| 1079 | if (!udc->driver || udc->gadget.speed == USB_SPEED_UNKNOWN) | 1075 | if (!udc->driver || udc->gadget.speed == USB_SPEED_UNKNOWN) |
| 1080 | return -ESHUTDOWN; | 1076 | return -ESHUTDOWN; |
| 1081 | 1077 | ||
| 1082 | d_qh = &ep->udc->ep_qh[ep_index(ep) * 2 + ep_is_in(ep)]; | 1078 | qh = get_qh_by_ep(ep); |
| 1083 | 1079 | ||
| 1084 | bitmask = (ep_is_in(ep)) ? (1 << (ep_index(ep) + 16)) : | 1080 | bitmask = (ep_is_in(ep)) ? (1 << (ep_index(ep) + 16)) : |
| 1085 | (1 << (ep_index(ep))); | 1081 | (1 << (ep_index(ep))); |
| 1086 | 1082 | ||
| 1087 | if (fsl_readl(&dr_regs->endptstatus) & bitmask) | 1083 | if (fsl_readl(&dr_regs->endptstatus) & bitmask) |
| 1088 | size = (d_qh->size_ioc_int_sts & DTD_PACKET_SIZE) | 1084 | size = (qh->size_ioc_int_sts & DTD_PACKET_SIZE) |
| 1089 | >> DTD_LENGTH_BIT_POS; | 1085 | >> DTD_LENGTH_BIT_POS; |
| 1090 | 1086 | ||
| 1091 | pr_debug("%s %u\n", __func__, size); | 1087 | pr_debug("%s %u\n", __func__, size); |
| @@ -1938,8 +1934,7 @@ static int fsl_start(struct usb_gadget_driver *driver, | |||
| 1938 | if (!udc_controller) | 1934 | if (!udc_controller) |
| 1939 | return -ENODEV; | 1935 | return -ENODEV; |
| 1940 | 1936 | ||
| 1941 | if (!driver || (driver->speed != USB_SPEED_FULL | 1937 | if (!driver || driver->speed < USB_SPEED_FULL |
| 1942 | && driver->speed != USB_SPEED_HIGH) | ||
| 1943 | || !bind || !driver->disconnect || !driver->setup) | 1938 | || !bind || !driver->disconnect || !driver->setup) |
| 1944 | return -EINVAL; | 1939 | return -EINVAL; |
| 1945 | 1940 | ||
diff --git a/drivers/usb/gadget/fsl_usb2_udc.h b/drivers/usb/gadget/fsl_usb2_udc.h index 1d51be83fda8..f781f5dec417 100644 --- a/drivers/usb/gadget/fsl_usb2_udc.h +++ b/drivers/usb/gadget/fsl_usb2_udc.h | |||
| @@ -569,6 +569,16 @@ static void dump_msg(const char *label, const u8 * buf, unsigned int length) | |||
| 569 | * 2 + ((windex & USB_DIR_IN) ? 1 : 0)) | 569 | * 2 + ((windex & USB_DIR_IN) ? 1 : 0)) |
| 570 | #define get_pipe_by_ep(EP) (ep_index(EP) * 2 + ep_is_in(EP)) | 570 | #define get_pipe_by_ep(EP) (ep_index(EP) * 2 + ep_is_in(EP)) |
| 571 | 571 | ||
| 572 | static inline struct ep_queue_head *get_qh_by_ep(struct fsl_ep *ep) | ||
| 573 | { | ||
| 574 | /* we only have one ep0 structure but two queue heads */ | ||
| 575 | if (ep_index(ep) != 0) | ||
| 576 | return ep->qh; | ||
| 577 | else | ||
| 578 | return &ep->udc->ep_qh[(ep->udc->ep0_dir == | ||
| 579 | USB_DIR_IN) ? 1 : 0]; | ||
| 580 | } | ||
| 581 | |||
| 572 | struct platform_device; | 582 | struct platform_device; |
| 573 | #ifdef CONFIG_ARCH_MXC | 583 | #ifdef CONFIG_ARCH_MXC |
| 574 | int fsl_udc_clk_init(struct platform_device *pdev); | 584 | int fsl_udc_clk_init(struct platform_device *pdev); |
diff --git a/drivers/usb/gadget/m66592-udc.c b/drivers/usb/gadget/m66592-udc.c index 91d0af2a24a8..9aa1cbbee45b 100644 --- a/drivers/usb/gadget/m66592-udc.c +++ b/drivers/usb/gadget/m66592-udc.c | |||
| @@ -1472,7 +1472,7 @@ static int m66592_start(struct usb_gadget_driver *driver, | |||
| 1472 | int retval; | 1472 | int retval; |
| 1473 | 1473 | ||
| 1474 | if (!driver | 1474 | if (!driver |
| 1475 | || driver->speed != USB_SPEED_HIGH | 1475 | || driver->speed < USB_SPEED_HIGH |
| 1476 | || !bind | 1476 | || !bind |
| 1477 | || !driver->setup) | 1477 | || !driver->setup) |
| 1478 | return -EINVAL; | 1478 | return -EINVAL; |
diff --git a/drivers/usb/gadget/net2280.c b/drivers/usb/gadget/net2280.c index 7f1bc9a73cda..da2b9d0be3ca 100644 --- a/drivers/usb/gadget/net2280.c +++ b/drivers/usb/gadget/net2280.c | |||
| @@ -1881,7 +1881,7 @@ static int net2280_start(struct usb_gadget *_gadget, | |||
| 1881 | * (dev->usb->xcvrdiag & FORCE_FULL_SPEED_MODE) | 1881 | * (dev->usb->xcvrdiag & FORCE_FULL_SPEED_MODE) |
| 1882 | * "must not be used in normal operation" | 1882 | * "must not be used in normal operation" |
| 1883 | */ | 1883 | */ |
| 1884 | if (!driver || driver->speed != USB_SPEED_HIGH | 1884 | if (!driver || driver->speed < USB_SPEED_HIGH |
| 1885 | || !driver->setup) | 1885 | || !driver->setup) |
| 1886 | return -EINVAL; | 1886 | return -EINVAL; |
| 1887 | 1887 | ||
diff --git a/drivers/usb/gadget/r8a66597-udc.c b/drivers/usb/gadget/r8a66597-udc.c index 24f84b210ce1..fc719a3f8557 100644 --- a/drivers/usb/gadget/r8a66597-udc.c +++ b/drivers/usb/gadget/r8a66597-udc.c | |||
| @@ -1746,7 +1746,7 @@ static int r8a66597_start(struct usb_gadget *gadget, | |||
| 1746 | struct r8a66597 *r8a66597 = gadget_to_r8a66597(gadget); | 1746 | struct r8a66597 *r8a66597 = gadget_to_r8a66597(gadget); |
| 1747 | 1747 | ||
| 1748 | if (!driver | 1748 | if (!driver |
| 1749 | || driver->speed != USB_SPEED_HIGH | 1749 | || driver->speed < USB_SPEED_HIGH |
| 1750 | || !driver->setup) | 1750 | || !driver->setup) |
| 1751 | return -EINVAL; | 1751 | return -EINVAL; |
| 1752 | if (!r8a66597) | 1752 | if (!r8a66597) |
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index a552453dc946..b31448229f0b 100644 --- a/drivers/usb/gadget/s3c-hsotg.c +++ b/drivers/usb/gadget/s3c-hsotg.c | |||
| @@ -2586,10 +2586,8 @@ static int s3c_hsotg_start(struct usb_gadget_driver *driver, | |||
| 2586 | return -EINVAL; | 2586 | return -EINVAL; |
| 2587 | } | 2587 | } |
| 2588 | 2588 | ||
| 2589 | if (driver->speed != USB_SPEED_HIGH && | 2589 | if (driver->speed < USB_SPEED_FULL) |
| 2590 | driver->speed != USB_SPEED_FULL) { | ||
| 2591 | dev_err(hsotg->dev, "%s: bad speed\n", __func__); | 2590 | dev_err(hsotg->dev, "%s: bad speed\n", __func__); |
| 2592 | } | ||
| 2593 | 2591 | ||
| 2594 | if (!bind || !driver->setup) { | 2592 | if (!bind || !driver->setup) { |
| 2595 | dev_err(hsotg->dev, "%s: missing entry points\n", __func__); | 2593 | dev_err(hsotg->dev, "%s: missing entry points\n", __func__); |
diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index 8d54f893cefe..20a553b46aed 100644 --- a/drivers/usb/gadget/s3c-hsudc.c +++ b/drivers/usb/gadget/s3c-hsudc.c | |||
| @@ -1142,8 +1142,7 @@ static int s3c_hsudc_start(struct usb_gadget_driver *driver, | |||
| 1142 | int ret; | 1142 | int ret; |
| 1143 | 1143 | ||
| 1144 | if (!driver | 1144 | if (!driver |
| 1145 | || (driver->speed != USB_SPEED_FULL && | 1145 | || driver->speed < USB_SPEED_FULL |
| 1146 | driver->speed != USB_SPEED_HIGH) | ||
| 1147 | || !bind | 1146 | || !bind |
| 1148 | || !driver->unbind || !driver->disconnect || !driver->setup) | 1147 | || !driver->unbind || !driver->disconnect || !driver->setup) |
| 1149 | return -EINVAL; | 1148 | return -EINVAL; |
diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c index 56a32033adb3..a60679cbbf85 100644 --- a/drivers/usb/host/ehci-sched.c +++ b/drivers/usb/host/ehci-sched.c | |||
| @@ -1475,6 +1475,7 @@ iso_stream_schedule ( | |||
| 1475 | * jump until after the queue is primed. | 1475 | * jump until after the queue is primed. |
| 1476 | */ | 1476 | */ |
| 1477 | else { | 1477 | else { |
| 1478 | int done = 0; | ||
| 1478 | start = SCHEDULE_SLOP + (now & ~0x07); | 1479 | start = SCHEDULE_SLOP + (now & ~0x07); |
| 1479 | 1480 | ||
| 1480 | /* NOTE: assumes URB_ISO_ASAP, to limit complexity/bugs */ | 1481 | /* NOTE: assumes URB_ISO_ASAP, to limit complexity/bugs */ |
| @@ -1492,18 +1493,18 @@ iso_stream_schedule ( | |||
| 1492 | if (stream->highspeed) { | 1493 | if (stream->highspeed) { |
| 1493 | if (itd_slot_ok(ehci, mod, start, | 1494 | if (itd_slot_ok(ehci, mod, start, |
| 1494 | stream->usecs, period)) | 1495 | stream->usecs, period)) |
| 1495 | break; | 1496 | done = 1; |
| 1496 | } else { | 1497 | } else { |
| 1497 | if ((start % 8) >= 6) | 1498 | if ((start % 8) >= 6) |
| 1498 | continue; | 1499 | continue; |
| 1499 | if (sitd_slot_ok(ehci, mod, stream, | 1500 | if (sitd_slot_ok(ehci, mod, stream, |
| 1500 | start, sched, period)) | 1501 | start, sched, period)) |
| 1501 | break; | 1502 | done = 1; |
| 1502 | } | 1503 | } |
| 1503 | } while (start > next); | 1504 | } while (start > next && !done); |
| 1504 | 1505 | ||
| 1505 | /* no room in the schedule */ | 1506 | /* no room in the schedule */ |
| 1506 | if (start == next) { | 1507 | if (!done) { |
| 1507 | ehci_dbg(ehci, "iso resched full %p (now %d max %d)\n", | 1508 | ehci_dbg(ehci, "iso resched full %p (now %d max %d)\n", |
| 1508 | urb, now, now + mod); | 1509 | urb, now, now + mod); |
| 1509 | status = -ENOSPC; | 1510 | status = -ENOSPC; |
diff --git a/drivers/usb/host/whci/qset.c b/drivers/usb/host/whci/qset.c index d6e175428618..a403b53e86b9 100644 --- a/drivers/usb/host/whci/qset.c +++ b/drivers/usb/host/whci/qset.c | |||
| @@ -124,7 +124,7 @@ void qset_clear(struct whc *whc, struct whc_qset *qset) | |||
| 124 | { | 124 | { |
| 125 | qset->td_start = qset->td_end = qset->ntds = 0; | 125 | qset->td_start = qset->td_end = qset->ntds = 0; |
| 126 | 126 | ||
| 127 | qset->qh.link = cpu_to_le32(QH_LINK_NTDS(8) | QH_LINK_T); | 127 | qset->qh.link = cpu_to_le64(QH_LINK_NTDS(8) | QH_LINK_T); |
| 128 | qset->qh.status = qset->qh.status & QH_STATUS_SEQ_MASK; | 128 | qset->qh.status = qset->qh.status & QH_STATUS_SEQ_MASK; |
| 129 | qset->qh.err_count = 0; | 129 | qset->qh.err_count = 0; |
| 130 | qset->qh.scratch[0] = 0; | 130 | qset->qh.scratch[0] = 0; |
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c index aa94c0195791..a1afb7c39f7e 100644 --- a/drivers/usb/host/xhci.c +++ b/drivers/usb/host/xhci.c | |||
| @@ -711,7 +711,10 @@ static void xhci_clear_command_ring(struct xhci_hcd *xhci) | |||
| 711 | ring = xhci->cmd_ring; | 711 | ring = xhci->cmd_ring; |
| 712 | seg = ring->deq_seg; | 712 | seg = ring->deq_seg; |
| 713 | do { | 713 | do { |
| 714 | memset(seg->trbs, 0, SEGMENT_SIZE); | 714 | memset(seg->trbs, 0, |
| 715 | sizeof(union xhci_trb) * (TRBS_PER_SEGMENT - 1)); | ||
| 716 | seg->trbs[TRBS_PER_SEGMENT - 1].link.control &= | ||
| 717 | cpu_to_le32(~TRB_CYCLE); | ||
| 715 | seg = seg->next; | 718 | seg = seg->next; |
| 716 | } while (seg != ring->deq_seg); | 719 | } while (seg != ring->deq_seg); |
| 717 | 720 | ||
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c index c1fa12ec7a9a..b63ab1570103 100644 --- a/drivers/usb/musb/musb_core.c +++ b/drivers/usb/musb/musb_core.c | |||
| @@ -2301,18 +2301,12 @@ static int musb_suspend(struct device *dev) | |||
| 2301 | */ | 2301 | */ |
| 2302 | } | 2302 | } |
| 2303 | 2303 | ||
| 2304 | musb_save_context(musb); | ||
| 2305 | |||
| 2306 | spin_unlock_irqrestore(&musb->lock, flags); | 2304 | spin_unlock_irqrestore(&musb->lock, flags); |
| 2307 | return 0; | 2305 | return 0; |
| 2308 | } | 2306 | } |
| 2309 | 2307 | ||
| 2310 | static int musb_resume_noirq(struct device *dev) | 2308 | static int musb_resume_noirq(struct device *dev) |
| 2311 | { | 2309 | { |
| 2312 | struct musb *musb = dev_to_musb(dev); | ||
| 2313 | |||
| 2314 | musb_restore_context(musb); | ||
| 2315 | |||
| 2316 | /* for static cmos like DaVinci, register values were preserved | 2310 | /* for static cmos like DaVinci, register values were preserved |
| 2317 | * unless for some reason the whole soc powered down or the USB | 2311 | * unless for some reason the whole soc powered down or the USB |
| 2318 | * module got reset through the PSC (vs just being disabled). | 2312 | * module got reset through the PSC (vs just being disabled). |
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index d51043acfe1a..922148ff8d29 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c | |||
| @@ -1903,7 +1903,7 @@ static int musb_gadget_start(struct usb_gadget *g, | |||
| 1903 | unsigned long flags; | 1903 | unsigned long flags; |
| 1904 | int retval = -EINVAL; | 1904 | int retval = -EINVAL; |
| 1905 | 1905 | ||
| 1906 | if (driver->speed != USB_SPEED_HIGH) | 1906 | if (driver->speed < USB_SPEED_HIGH) |
| 1907 | goto err0; | 1907 | goto err0; |
| 1908 | 1908 | ||
| 1909 | pm_runtime_get_sync(musb->controller); | 1909 | pm_runtime_get_sync(musb->controller); |
diff --git a/drivers/usb/renesas_usbhs/mod.c b/drivers/usb/renesas_usbhs/mod.c index 053f86d70009..ad96a3896729 100644 --- a/drivers/usb/renesas_usbhs/mod.c +++ b/drivers/usb/renesas_usbhs/mod.c | |||
| @@ -349,7 +349,7 @@ void usbhs_irq_callback_update(struct usbhs_priv *priv, struct usbhs_mod *mod) | |||
| 349 | if (mod->irq_attch) | 349 | if (mod->irq_attch) |
| 350 | intenb1 |= ATTCHE; | 350 | intenb1 |= ATTCHE; |
| 351 | 351 | ||
| 352 | if (mod->irq_attch) | 352 | if (mod->irq_dtch) |
| 353 | intenb1 |= DTCHE; | 353 | intenb1 |= DTCHE; |
| 354 | 354 | ||
| 355 | if (mod->irq_sign) | 355 | if (mod->irq_sign) |
diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c index d9717e0bc1ff..7f4e80338570 100644 --- a/drivers/usb/renesas_usbhs/mod_gadget.c +++ b/drivers/usb/renesas_usbhs/mod_gadget.c | |||
| @@ -751,53 +751,32 @@ static int usbhsg_gadget_start(struct usb_gadget *gadget, | |||
| 751 | struct usb_gadget_driver *driver) | 751 | struct usb_gadget_driver *driver) |
| 752 | { | 752 | { |
| 753 | struct usbhsg_gpriv *gpriv = usbhsg_gadget_to_gpriv(gadget); | 753 | struct usbhsg_gpriv *gpriv = usbhsg_gadget_to_gpriv(gadget); |
| 754 | struct usbhs_priv *priv; | 754 | struct usbhs_priv *priv = usbhsg_gpriv_to_priv(gpriv); |
| 755 | struct device *dev; | ||
| 756 | int ret; | ||
| 757 | 755 | ||
| 758 | if (!driver || | 756 | if (!driver || |
| 759 | !driver->setup || | 757 | !driver->setup || |
| 760 | driver->speed != USB_SPEED_HIGH) | 758 | driver->speed < USB_SPEED_FULL) |
| 761 | return -EINVAL; | 759 | return -EINVAL; |
| 762 | 760 | ||
| 763 | dev = usbhsg_gpriv_to_dev(gpriv); | ||
| 764 | priv = usbhsg_gpriv_to_priv(gpriv); | ||
| 765 | |||
| 766 | /* first hook up the driver ... */ | 761 | /* first hook up the driver ... */ |
| 767 | gpriv->driver = driver; | 762 | gpriv->driver = driver; |
| 768 | gpriv->gadget.dev.driver = &driver->driver; | 763 | gpriv->gadget.dev.driver = &driver->driver; |
| 769 | 764 | ||
| 770 | ret = device_add(&gpriv->gadget.dev); | ||
| 771 | if (ret) { | ||
| 772 | dev_err(dev, "device_add error %d\n", ret); | ||
| 773 | goto add_fail; | ||
| 774 | } | ||
| 775 | |||
| 776 | return usbhsg_try_start(priv, USBHSG_STATUS_REGISTERD); | 765 | return usbhsg_try_start(priv, USBHSG_STATUS_REGISTERD); |
| 777 | |||
| 778 | add_fail: | ||
| 779 | gpriv->driver = NULL; | ||
| 780 | gpriv->gadget.dev.driver = NULL; | ||
| 781 | |||
| 782 | return ret; | ||
| 783 | } | 766 | } |
| 784 | 767 | ||
| 785 | static int usbhsg_gadget_stop(struct usb_gadget *gadget, | 768 | static int usbhsg_gadget_stop(struct usb_gadget *gadget, |
| 786 | struct usb_gadget_driver *driver) | 769 | struct usb_gadget_driver *driver) |
| 787 | { | 770 | { |
| 788 | struct usbhsg_gpriv *gpriv = usbhsg_gadget_to_gpriv(gadget); | 771 | struct usbhsg_gpriv *gpriv = usbhsg_gadget_to_gpriv(gadget); |
| 789 | struct usbhs_priv *priv; | 772 | struct usbhs_priv *priv = usbhsg_gpriv_to_priv(gpriv); |
| 790 | struct device *dev; | ||
| 791 | 773 | ||
| 792 | if (!driver || | 774 | if (!driver || |
| 793 | !driver->unbind) | 775 | !driver->unbind) |
| 794 | return -EINVAL; | 776 | return -EINVAL; |
| 795 | 777 | ||
| 796 | dev = usbhsg_gpriv_to_dev(gpriv); | ||
| 797 | priv = usbhsg_gpriv_to_priv(gpriv); | ||
| 798 | |||
| 799 | usbhsg_try_stop(priv, USBHSG_STATUS_REGISTERD); | 778 | usbhsg_try_stop(priv, USBHSG_STATUS_REGISTERD); |
| 800 | device_del(&gpriv->gadget.dev); | 779 | gpriv->gadget.dev.driver = NULL; |
| 801 | gpriv->driver = NULL; | 780 | gpriv->driver = NULL; |
| 802 | 781 | ||
| 803 | return 0; | 782 | return 0; |
| @@ -827,6 +806,13 @@ static int usbhsg_start(struct usbhs_priv *priv) | |||
| 827 | 806 | ||
| 828 | static int usbhsg_stop(struct usbhs_priv *priv) | 807 | static int usbhsg_stop(struct usbhs_priv *priv) |
| 829 | { | 808 | { |
| 809 | struct usbhsg_gpriv *gpriv = usbhsg_priv_to_gpriv(priv); | ||
| 810 | |||
| 811 | /* cable disconnect */ | ||
| 812 | if (gpriv->driver && | ||
| 813 | gpriv->driver->disconnect) | ||
| 814 | gpriv->driver->disconnect(&gpriv->gadget); | ||
| 815 | |||
| 830 | return usbhsg_try_stop(priv, USBHSG_STATUS_STARTED); | 816 | return usbhsg_try_stop(priv, USBHSG_STATUS_STARTED); |
| 831 | } | 817 | } |
| 832 | 818 | ||
| @@ -876,12 +862,14 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) | |||
| 876 | /* | 862 | /* |
| 877 | * init gadget | 863 | * init gadget |
| 878 | */ | 864 | */ |
| 879 | device_initialize(&gpriv->gadget.dev); | ||
| 880 | dev_set_name(&gpriv->gadget.dev, "gadget"); | 865 | dev_set_name(&gpriv->gadget.dev, "gadget"); |
| 881 | gpriv->gadget.dev.parent = dev; | 866 | gpriv->gadget.dev.parent = dev; |
| 882 | gpriv->gadget.name = "renesas_usbhs_udc"; | 867 | gpriv->gadget.name = "renesas_usbhs_udc"; |
| 883 | gpriv->gadget.ops = &usbhsg_gadget_ops; | 868 | gpriv->gadget.ops = &usbhsg_gadget_ops; |
| 884 | gpriv->gadget.is_dualspeed = 1; | 869 | gpriv->gadget.is_dualspeed = 1; |
| 870 | ret = device_register(&gpriv->gadget.dev); | ||
| 871 | if (ret < 0) | ||
| 872 | goto err_add_udc; | ||
| 885 | 873 | ||
| 886 | INIT_LIST_HEAD(&gpriv->gadget.ep_list); | 874 | INIT_LIST_HEAD(&gpriv->gadget.ep_list); |
| 887 | 875 | ||
| @@ -912,12 +900,15 @@ int usbhs_mod_gadget_probe(struct usbhs_priv *priv) | |||
| 912 | 900 | ||
| 913 | ret = usb_add_gadget_udc(dev, &gpriv->gadget); | 901 | ret = usb_add_gadget_udc(dev, &gpriv->gadget); |
| 914 | if (ret) | 902 | if (ret) |
| 915 | goto err_add_udc; | 903 | goto err_register; |
| 916 | 904 | ||
| 917 | 905 | ||
| 918 | dev_info(dev, "gadget probed\n"); | 906 | dev_info(dev, "gadget probed\n"); |
| 919 | 907 | ||
| 920 | return 0; | 908 | return 0; |
| 909 | |||
| 910 | err_register: | ||
| 911 | device_unregister(&gpriv->gadget.dev); | ||
| 921 | err_add_udc: | 912 | err_add_udc: |
| 922 | kfree(gpriv->uep); | 913 | kfree(gpriv->uep); |
| 923 | 914 | ||
| @@ -933,6 +924,8 @@ void usbhs_mod_gadget_remove(struct usbhs_priv *priv) | |||
| 933 | 924 | ||
| 934 | usb_del_gadget_udc(&gpriv->gadget); | 925 | usb_del_gadget_udc(&gpriv->gadget); |
| 935 | 926 | ||
| 927 | device_unregister(&gpriv->gadget.dev); | ||
| 928 | |||
| 936 | usbhsg_controller_unregister(gpriv); | 929 | usbhsg_controller_unregister(gpriv); |
| 937 | 930 | ||
| 938 | kfree(gpriv->uep); | 931 | kfree(gpriv->uep); |
diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c index bade761a1e52..7955de589951 100644 --- a/drivers/usb/renesas_usbhs/mod_host.c +++ b/drivers/usb/renesas_usbhs/mod_host.c | |||
| @@ -1267,6 +1267,7 @@ int usbhs_mod_host_probe(struct usbhs_priv *priv) | |||
| 1267 | dev_err(dev, "Failed to create hcd\n"); | 1267 | dev_err(dev, "Failed to create hcd\n"); |
| 1268 | return -ENOMEM; | 1268 | return -ENOMEM; |
| 1269 | } | 1269 | } |
| 1270 | hcd->has_tt = 1; /* for low/full speed */ | ||
| 1270 | 1271 | ||
| 1271 | pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL); | 1272 | pipe_info = kzalloc(sizeof(*pipe_info) * pipe_size, GFP_KERNEL); |
| 1272 | if (!pipe_info) { | 1273 | if (!pipe_info) { |
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index bd4298bb6750..ff3db5d056a5 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c | |||
| @@ -736,6 +736,7 @@ static struct usb_device_id id_table_combined [] = { | |||
| 736 | { USB_DEVICE(TML_VID, TML_USB_SERIAL_PID) }, | 736 | { USB_DEVICE(TML_VID, TML_USB_SERIAL_PID) }, |
| 737 | { USB_DEVICE(FTDI_VID, FTDI_ELSTER_UNICOM_PID) }, | 737 | { USB_DEVICE(FTDI_VID, FTDI_ELSTER_UNICOM_PID) }, |
| 738 | { USB_DEVICE(FTDI_VID, FTDI_PROPOX_JTAGCABLEII_PID) }, | 738 | { USB_DEVICE(FTDI_VID, FTDI_PROPOX_JTAGCABLEII_PID) }, |
| 739 | { USB_DEVICE(FTDI_VID, FTDI_PROPOX_ISPCABLEIII_PID) }, | ||
| 739 | { USB_DEVICE(OLIMEX_VID, OLIMEX_ARM_USB_OCD_PID), | 740 | { USB_DEVICE(OLIMEX_VID, OLIMEX_ARM_USB_OCD_PID), |
| 740 | .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, | 741 | .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk }, |
| 741 | { USB_DEVICE(OLIMEX_VID, OLIMEX_ARM_USB_OCD_H_PID), | 742 | { USB_DEVICE(OLIMEX_VID, OLIMEX_ARM_USB_OCD_H_PID), |
diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h index 571fa96b49c7..055b64ef0bba 100644 --- a/drivers/usb/serial/ftdi_sio_ids.h +++ b/drivers/usb/serial/ftdi_sio_ids.h | |||
| @@ -112,6 +112,7 @@ | |||
| 112 | 112 | ||
| 113 | /* Propox devices */ | 113 | /* Propox devices */ |
| 114 | #define FTDI_PROPOX_JTAGCABLEII_PID 0xD738 | 114 | #define FTDI_PROPOX_JTAGCABLEII_PID 0xD738 |
| 115 | #define FTDI_PROPOX_ISPCABLEIII_PID 0xD739 | ||
| 115 | 116 | ||
| 116 | /* Lenz LI-USB Computer Interface. */ | 117 | /* Lenz LI-USB Computer Interface. */ |
| 117 | #define FTDI_LENZ_LIUSB_PID 0xD780 | 118 | #define FTDI_LENZ_LIUSB_PID 0xD780 |
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d865878c9f97..6dd64534fad0 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c | |||
| @@ -661,6 +661,14 @@ static const struct usb_device_id option_ids[] = { | |||
| 661 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4511, 0xff, 0x01, 0x31) }, | 661 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4511, 0xff, 0x01, 0x31) }, |
| 662 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4511, 0xff, 0x01, 0x32) }, | 662 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K4511, 0xff, 0x01, 0x32) }, |
| 663 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x01) }, | 663 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x01) }, |
| 664 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x02) }, | ||
| 665 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x03) }, | ||
| 666 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x10) }, | ||
| 667 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x12) }, | ||
| 668 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x13) }, | ||
| 669 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x02, 0x01) }, /* E398 3G Modem */ | ||
| 670 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x02, 0x02) }, /* E398 3G PC UI Interface */ | ||
| 671 | { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x02, 0x03) }, /* E398 3G Application Interface */ | ||
| 664 | { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) }, | 672 | { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) }, |
| 665 | { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) }, | 673 | { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) }, |
| 666 | { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V740) }, | 674 | { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V740) }, |
| @@ -747,6 +755,7 @@ static const struct usb_device_id option_ids[] = { | |||
| 747 | { USB_DEVICE(KYOCERA_VENDOR_ID, KYOCERA_PRODUCT_KPC680) }, | 755 | { USB_DEVICE(KYOCERA_VENDOR_ID, KYOCERA_PRODUCT_KPC680) }, |
| 748 | { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6000)}, /* ZTE AC8700 */ | 756 | { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6000)}, /* ZTE AC8700 */ |
| 749 | { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ | 757 | { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */ |
| 758 | { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */ | ||
| 750 | { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6280) }, /* BP3-USB & BP3-EXT HSDPA */ | 759 | { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6280) }, /* BP3-USB & BP3-EXT HSDPA */ |
| 751 | { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6008) }, | 760 | { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6008) }, |
| 752 | { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_UC864E) }, | 761 | { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_UC864E) }, |
diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 3041a974faf3..24caba79d722 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h | |||
| @@ -1854,6 +1854,13 @@ UNUSUAL_DEV( 0x1370, 0x6828, 0x0110, 0x0110, | |||
| 1854 | USB_SC_DEVICE, USB_PR_DEVICE, NULL, | 1854 | USB_SC_DEVICE, USB_PR_DEVICE, NULL, |
| 1855 | US_FL_IGNORE_RESIDUE ), | 1855 | US_FL_IGNORE_RESIDUE ), |
| 1856 | 1856 | ||
| 1857 | /* Reported by Qinglin Ye <yestyle@gmail.com> */ | ||
| 1858 | UNUSUAL_DEV( 0x13fe, 0x3600, 0x0100, 0x0100, | ||
| 1859 | "Kingston", | ||
| 1860 | "DT 101 G2", | ||
| 1861 | USB_SC_DEVICE, USB_PR_DEVICE, NULL, | ||
| 1862 | US_FL_BULK_IGNORE_TAG ), | ||
| 1863 | |||
| 1857 | /* Reported by Francesco Foresti <frafore@tiscali.it> */ | 1864 | /* Reported by Francesco Foresti <frafore@tiscali.it> */ |
| 1858 | UNUSUAL_DEV( 0x14cd, 0x6600, 0x0201, 0x0201, | 1865 | UNUSUAL_DEV( 0x14cd, 0x6600, 0x0201, 0x0201, |
| 1859 | "Super Top", | 1866 | "Super Top", |
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index 55f91d9ab00b..29577bf1f559 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c | |||
| @@ -116,6 +116,7 @@ | |||
| 116 | /* Clock registers available only on Version 2 */ | 116 | /* Clock registers available only on Version 2 */ |
| 117 | #define LCD_CLK_ENABLE_REG 0x6c | 117 | #define LCD_CLK_ENABLE_REG 0x6c |
| 118 | #define LCD_CLK_RESET_REG 0x70 | 118 | #define LCD_CLK_RESET_REG 0x70 |
| 119 | #define LCD_CLK_MAIN_RESET BIT(3) | ||
| 119 | 120 | ||
| 120 | #define LCD_NUM_BUFFERS 2 | 121 | #define LCD_NUM_BUFFERS 2 |
| 121 | 122 | ||
| @@ -244,6 +245,10 @@ static inline void lcd_enable_raster(void) | |||
| 244 | { | 245 | { |
| 245 | u32 reg; | 246 | u32 reg; |
| 246 | 247 | ||
| 248 | /* Bring LCDC out of reset */ | ||
| 249 | if (lcd_revision == LCD_VERSION_2) | ||
| 250 | lcdc_write(0, LCD_CLK_RESET_REG); | ||
| 251 | |||
| 247 | reg = lcdc_read(LCD_RASTER_CTRL_REG); | 252 | reg = lcdc_read(LCD_RASTER_CTRL_REG); |
| 248 | if (!(reg & LCD_RASTER_ENABLE)) | 253 | if (!(reg & LCD_RASTER_ENABLE)) |
| 249 | lcdc_write(reg | LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); | 254 | lcdc_write(reg | LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); |
| @@ -257,6 +262,10 @@ static inline void lcd_disable_raster(void) | |||
| 257 | reg = lcdc_read(LCD_RASTER_CTRL_REG); | 262 | reg = lcdc_read(LCD_RASTER_CTRL_REG); |
| 258 | if (reg & LCD_RASTER_ENABLE) | 263 | if (reg & LCD_RASTER_ENABLE) |
| 259 | lcdc_write(reg & ~LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); | 264 | lcdc_write(reg & ~LCD_RASTER_ENABLE, LCD_RASTER_CTRL_REG); |
| 265 | |||
| 266 | if (lcd_revision == LCD_VERSION_2) | ||
| 267 | /* Write 1 to reset LCDC */ | ||
| 268 | lcdc_write(LCD_CLK_MAIN_RESET, LCD_CLK_RESET_REG); | ||
| 260 | } | 269 | } |
| 261 | 270 | ||
| 262 | static void lcd_blit(int load_mode, struct da8xx_fb_par *par) | 271 | static void lcd_blit(int load_mode, struct da8xx_fb_par *par) |
| @@ -584,8 +593,12 @@ static void lcd_reset(struct da8xx_fb_par *par) | |||
| 584 | lcdc_write(0, LCD_DMA_CTRL_REG); | 593 | lcdc_write(0, LCD_DMA_CTRL_REG); |
| 585 | lcdc_write(0, LCD_RASTER_CTRL_REG); | 594 | lcdc_write(0, LCD_RASTER_CTRL_REG); |
| 586 | 595 | ||
| 587 | if (lcd_revision == LCD_VERSION_2) | 596 | if (lcd_revision == LCD_VERSION_2) { |
| 588 | lcdc_write(0, LCD_INT_ENABLE_SET_REG); | 597 | lcdc_write(0, LCD_INT_ENABLE_SET_REG); |
| 598 | /* Write 1 to reset */ | ||
| 599 | lcdc_write(LCD_CLK_MAIN_RESET, LCD_CLK_RESET_REG); | ||
| 600 | lcdc_write(0, LCD_CLK_RESET_REG); | ||
| 601 | } | ||
| 589 | } | 602 | } |
| 590 | 603 | ||
| 591 | static void lcd_calc_clk_divider(struct da8xx_fb_par *par) | 604 | static void lcd_calc_clk_divider(struct da8xx_fb_par *par) |
diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c index 0ccd7adf47bb..6f61e781f15a 100644 --- a/drivers/video/omap/dispc.c +++ b/drivers/video/omap/dispc.c | |||
| @@ -19,6 +19,7 @@ | |||
| 19 | * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. | 19 | * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. |
| 20 | */ | 20 | */ |
| 21 | #include <linux/kernel.h> | 21 | #include <linux/kernel.h> |
| 22 | #include <linux/module.h> | ||
| 22 | #include <linux/dma-mapping.h> | 23 | #include <linux/dma-mapping.h> |
| 23 | #include <linux/mm.h> | 24 | #include <linux/mm.h> |
| 24 | #include <linux/vmalloc.h> | 25 | #include <linux/vmalloc.h> |
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c index 3532782551cb..5c81533eacaa 100644 --- a/drivers/video/omap2/dss/dispc.c +++ b/drivers/video/omap2/dss/dispc.c | |||
| @@ -1720,12 +1720,11 @@ static int dispc_ovl_calc_scaling(enum omap_plane plane, | |||
| 1720 | const int maxdownscale = dss_feat_get_param_max(FEAT_PARAM_DOWNSCALE); | 1720 | const int maxdownscale = dss_feat_get_param_max(FEAT_PARAM_DOWNSCALE); |
| 1721 | unsigned long fclk = 0; | 1721 | unsigned long fclk = 0; |
| 1722 | 1722 | ||
| 1723 | if ((ovl->caps & OMAP_DSS_OVL_CAP_SCALE) == 0) { | 1723 | if (width == out_width && height == out_height) |
| 1724 | if (width != out_width || height != out_height) | 1724 | return 0; |
| 1725 | return -EINVAL; | 1725 | |
| 1726 | else | 1726 | if ((ovl->caps & OMAP_DSS_OVL_CAP_SCALE) == 0) |
| 1727 | return 0; | 1727 | return -EINVAL; |
| 1728 | } | ||
| 1729 | 1728 | ||
| 1730 | if (out_width < width / maxdownscale || | 1729 | if (out_width < width / maxdownscale || |
| 1731 | out_width > width * 8) | 1730 | out_width > width * 8) |
diff --git a/drivers/video/omap2/dss/hdmi.c b/drivers/video/omap2/dss/hdmi.c index 3262f0f1fa35..c56378c555b0 100644 --- a/drivers/video/omap2/dss/hdmi.c +++ b/drivers/video/omap2/dss/hdmi.c | |||
| @@ -269,7 +269,7 @@ static void update_hdmi_timings(struct hdmi_config *cfg, | |||
| 269 | unsigned long hdmi_get_pixel_clock(void) | 269 | unsigned long hdmi_get_pixel_clock(void) |
| 270 | { | 270 | { |
| 271 | /* HDMI Pixel Clock in Mhz */ | 271 | /* HDMI Pixel Clock in Mhz */ |
| 272 | return hdmi.ip_data.cfg.timings.timings.pixel_clock * 10000; | 272 | return hdmi.ip_data.cfg.timings.timings.pixel_clock * 1000; |
| 273 | } | 273 | } |
| 274 | 274 | ||
| 275 | static void hdmi_compute_pll(struct omap_dss_device *dssdev, int phy, | 275 | static void hdmi_compute_pll(struct omap_dss_device *dssdev, int phy, |
diff --git a/drivers/video/via/share.h b/drivers/video/via/share.h index 69d882cbe709..c01c1c162726 100644 --- a/drivers/video/via/share.h +++ b/drivers/video/via/share.h | |||
| @@ -559,8 +559,8 @@ | |||
| 559 | #define M1200X720_R60_VSP POSITIVE | 559 | #define M1200X720_R60_VSP POSITIVE |
| 560 | 560 | ||
| 561 | /* 1200x900@60 Sync Polarity (DCON) */ | 561 | /* 1200x900@60 Sync Polarity (DCON) */ |
| 562 | #define M1200X900_R60_HSP NEGATIVE | 562 | #define M1200X900_R60_HSP POSITIVE |
| 563 | #define M1200X900_R60_VSP NEGATIVE | 563 | #define M1200X900_R60_VSP POSITIVE |
| 564 | 564 | ||
| 565 | /* 1280x600@60 Sync Polarity (GTF Mode) */ | 565 | /* 1280x600@60 Sync Polarity (GTF Mode) */ |
| 566 | #define M1280x600_R60_HSP NEGATIVE | 566 | #define M1280x600_R60_HSP NEGATIVE |
diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 816ed08e7cf3..1a61939b85fc 100644 --- a/drivers/virtio/Kconfig +++ b/drivers/virtio/Kconfig | |||
| @@ -37,7 +37,7 @@ config VIRTIO_BALLOON | |||
| 37 | 37 | ||
| 38 | config VIRTIO_MMIO | 38 | config VIRTIO_MMIO |
| 39 | tristate "Platform bus driver for memory mapped virtio devices (EXPERIMENTAL)" | 39 | tristate "Platform bus driver for memory mapped virtio devices (EXPERIMENTAL)" |
| 40 | depends on EXPERIMENTAL | 40 | depends on HAS_IOMEM && EXPERIMENTAL |
| 41 | select VIRTIO | 41 | select VIRTIO |
| 42 | select VIRTIO_RING | 42 | select VIRTIO_RING |
| 43 | ---help--- | 43 | ---help--- |
diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index acc5e43c373e..7317dc2ec426 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c | |||
| @@ -118,7 +118,7 @@ static void vm_finalize_features(struct virtio_device *vdev) | |||
| 118 | vring_transport_features(vdev); | 118 | vring_transport_features(vdev); |
| 119 | 119 | ||
| 120 | for (i = 0; i < ARRAY_SIZE(vdev->features); i++) { | 120 | for (i = 0; i < ARRAY_SIZE(vdev->features); i++) { |
| 121 | writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SET); | 121 | writel(i, vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES_SEL); |
| 122 | writel(vdev->features[i], | 122 | writel(vdev->features[i], |
| 123 | vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES); | 123 | vm_dev->base + VIRTIO_MMIO_GUEST_FEATURES); |
| 124 | } | 124 | } |
diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c index 3d1bf41e8892..03d1984bd363 100644 --- a/drivers/virtio/virtio_pci.c +++ b/drivers/virtio/virtio_pci.c | |||
| @@ -169,11 +169,29 @@ static void vp_set_status(struct virtio_device *vdev, u8 status) | |||
| 169 | iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS); | 169 | iowrite8(status, vp_dev->ioaddr + VIRTIO_PCI_STATUS); |
| 170 | } | 170 | } |
| 171 | 171 | ||
| 172 | /* wait for pending irq handlers */ | ||
| 173 | static void vp_synchronize_vectors(struct virtio_device *vdev) | ||
| 174 | { | ||
| 175 | struct virtio_pci_device *vp_dev = to_vp_device(vdev); | ||
| 176 | int i; | ||
| 177 | |||
| 178 | if (vp_dev->intx_enabled) | ||
| 179 | synchronize_irq(vp_dev->pci_dev->irq); | ||
| 180 | |||
| 181 | for (i = 0; i < vp_dev->msix_vectors; ++i) | ||
| 182 | synchronize_irq(vp_dev->msix_entries[i].vector); | ||
| 183 | } | ||
| 184 | |||
| 172 | static void vp_reset(struct virtio_device *vdev) | 185 | static void vp_reset(struct virtio_device *vdev) |
| 173 | { | 186 | { |
| 174 | struct virtio_pci_device *vp_dev = to_vp_device(vdev); | 187 | struct virtio_pci_device *vp_dev = to_vp_device(vdev); |
| 175 | /* 0 status means a reset. */ | 188 | /* 0 status means a reset. */ |
| 176 | iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS); | 189 | iowrite8(0, vp_dev->ioaddr + VIRTIO_PCI_STATUS); |
| 190 | /* Flush out the status write, and flush in device writes, | ||
| 191 | * including MSi-X interrupts, if any. */ | ||
| 192 | ioread8(vp_dev->ioaddr + VIRTIO_PCI_STATUS); | ||
| 193 | /* Flush pending VQ/configuration callbacks. */ | ||
| 194 | vp_synchronize_vectors(vdev); | ||
| 177 | } | 195 | } |
| 178 | 196 | ||
| 179 | /* the notify function used when creating a virt queue */ | 197 | /* the notify function used when creating a virt queue */ |
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c index 8e964b91c447..284798aaf8b1 100644 --- a/drivers/xen/swiotlb-xen.c +++ b/drivers/xen/swiotlb-xen.c | |||
| @@ -166,7 +166,7 @@ retry: | |||
| 166 | /* | 166 | /* |
| 167 | * Get IO TLB memory from any location. | 167 | * Get IO TLB memory from any location. |
| 168 | */ | 168 | */ |
| 169 | xen_io_tlb_start = alloc_bootmem(bytes); | 169 | xen_io_tlb_start = alloc_bootmem_pages(PAGE_ALIGN(bytes)); |
| 170 | if (!xen_io_tlb_start) { | 170 | if (!xen_io_tlb_start) { |
| 171 | m = "Cannot allocate Xen-SWIOTLB buffer!\n"; | 171 | m = "Cannot allocate Xen-SWIOTLB buffer!\n"; |
| 172 | goto error; | 172 | goto error; |
| @@ -179,7 +179,7 @@ retry: | |||
| 179 | bytes, | 179 | bytes, |
| 180 | xen_io_tlb_nslabs); | 180 | xen_io_tlb_nslabs); |
| 181 | if (rc) { | 181 | if (rc) { |
| 182 | free_bootmem(__pa(xen_io_tlb_start), bytes); | 182 | free_bootmem(__pa(xen_io_tlb_start), PAGE_ALIGN(bytes)); |
| 183 | m = "Failed to get contiguous memory for DMA from Xen!\n"\ | 183 | m = "Failed to get contiguous memory for DMA from Xen!\n"\ |
| 184 | "You either: don't have the permissions, do not have"\ | 184 | "You either: don't have the permissions, do not have"\ |
| 185 | " enough free memory under 4GB, or the hypervisor memory"\ | 185 | " enough free memory under 4GB, or the hypervisor memory"\ |
diff --git a/fs/btrfs/async-thread.c b/fs/btrfs/async-thread.c index 7ec14097fef1..cb97174e2366 100644 --- a/fs/btrfs/async-thread.c +++ b/fs/btrfs/async-thread.c | |||
| @@ -64,6 +64,8 @@ struct btrfs_worker_thread { | |||
| 64 | int idle; | 64 | int idle; |
| 65 | }; | 65 | }; |
| 66 | 66 | ||
| 67 | static int __btrfs_start_workers(struct btrfs_workers *workers); | ||
| 68 | |||
| 67 | /* | 69 | /* |
| 68 | * btrfs_start_workers uses kthread_run, which can block waiting for memory | 70 | * btrfs_start_workers uses kthread_run, which can block waiting for memory |
| 69 | * for a very long time. It will actually throttle on page writeback, | 71 | * for a very long time. It will actually throttle on page writeback, |
| @@ -88,27 +90,10 @@ static void start_new_worker_func(struct btrfs_work *work) | |||
| 88 | { | 90 | { |
| 89 | struct worker_start *start; | 91 | struct worker_start *start; |
| 90 | start = container_of(work, struct worker_start, work); | 92 | start = container_of(work, struct worker_start, work); |
| 91 | btrfs_start_workers(start->queue, 1); | 93 | __btrfs_start_workers(start->queue); |
| 92 | kfree(start); | 94 | kfree(start); |
| 93 | } | 95 | } |
| 94 | 96 | ||
| 95 | static int start_new_worker(struct btrfs_workers *queue) | ||
| 96 | { | ||
| 97 | struct worker_start *start; | ||
| 98 | int ret; | ||
| 99 | |||
| 100 | start = kzalloc(sizeof(*start), GFP_NOFS); | ||
| 101 | if (!start) | ||
| 102 | return -ENOMEM; | ||
| 103 | |||
| 104 | start->work.func = start_new_worker_func; | ||
| 105 | start->queue = queue; | ||
| 106 | ret = btrfs_queue_worker(queue->atomic_worker_start, &start->work); | ||
| 107 | if (ret) | ||
| 108 | kfree(start); | ||
| 109 | return ret; | ||
| 110 | } | ||
| 111 | |||
| 112 | /* | 97 | /* |
| 113 | * helper function to move a thread onto the idle list after it | 98 | * helper function to move a thread onto the idle list after it |
| 114 | * has finished some requests. | 99 | * has finished some requests. |
| @@ -153,12 +138,20 @@ static void check_busy_worker(struct btrfs_worker_thread *worker) | |||
| 153 | static void check_pending_worker_creates(struct btrfs_worker_thread *worker) | 138 | static void check_pending_worker_creates(struct btrfs_worker_thread *worker) |
| 154 | { | 139 | { |
| 155 | struct btrfs_workers *workers = worker->workers; | 140 | struct btrfs_workers *workers = worker->workers; |
| 141 | struct worker_start *start; | ||
| 156 | unsigned long flags; | 142 | unsigned long flags; |
| 157 | 143 | ||
| 158 | rmb(); | 144 | rmb(); |
| 159 | if (!workers->atomic_start_pending) | 145 | if (!workers->atomic_start_pending) |
| 160 | return; | 146 | return; |
| 161 | 147 | ||
| 148 | start = kzalloc(sizeof(*start), GFP_NOFS); | ||
| 149 | if (!start) | ||
| 150 | return; | ||
| 151 | |||
| 152 | start->work.func = start_new_worker_func; | ||
| 153 | start->queue = workers; | ||
| 154 | |||
| 162 | spin_lock_irqsave(&workers->lock, flags); | 155 | spin_lock_irqsave(&workers->lock, flags); |
| 163 | if (!workers->atomic_start_pending) | 156 | if (!workers->atomic_start_pending) |
| 164 | goto out; | 157 | goto out; |
| @@ -170,10 +163,11 @@ static void check_pending_worker_creates(struct btrfs_worker_thread *worker) | |||
| 170 | 163 | ||
| 171 | workers->num_workers_starting += 1; | 164 | workers->num_workers_starting += 1; |
| 172 | spin_unlock_irqrestore(&workers->lock, flags); | 165 | spin_unlock_irqrestore(&workers->lock, flags); |
| 173 | start_new_worker(workers); | 166 | btrfs_queue_worker(workers->atomic_worker_start, &start->work); |
| 174 | return; | 167 | return; |
| 175 | 168 | ||
| 176 | out: | 169 | out: |
| 170 | kfree(start); | ||
| 177 | spin_unlock_irqrestore(&workers->lock, flags); | 171 | spin_unlock_irqrestore(&workers->lock, flags); |
| 178 | } | 172 | } |
| 179 | 173 | ||
| @@ -331,7 +325,7 @@ again: | |||
| 331 | run_ordered_completions(worker->workers, work); | 325 | run_ordered_completions(worker->workers, work); |
| 332 | 326 | ||
| 333 | check_pending_worker_creates(worker); | 327 | check_pending_worker_creates(worker); |
| 334 | 328 | cond_resched(); | |
| 335 | } | 329 | } |
| 336 | 330 | ||
| 337 | spin_lock_irq(&worker->lock); | 331 | spin_lock_irq(&worker->lock); |
| @@ -462,56 +456,55 @@ void btrfs_init_workers(struct btrfs_workers *workers, char *name, int max, | |||
| 462 | * starts new worker threads. This does not enforce the max worker | 456 | * starts new worker threads. This does not enforce the max worker |
| 463 | * count in case you need to temporarily go past it. | 457 | * count in case you need to temporarily go past it. |
| 464 | */ | 458 | */ |
| 465 | static int __btrfs_start_workers(struct btrfs_workers *workers, | 459 | static int __btrfs_start_workers(struct btrfs_workers *workers) |
| 466 | int num_workers) | ||
| 467 | { | 460 | { |
| 468 | struct btrfs_worker_thread *worker; | 461 | struct btrfs_worker_thread *worker; |
| 469 | int ret = 0; | 462 | int ret = 0; |
| 470 | int i; | ||
| 471 | 463 | ||
| 472 | for (i = 0; i < num_workers; i++) { | 464 | worker = kzalloc(sizeof(*worker), GFP_NOFS); |
| 473 | worker = kzalloc(sizeof(*worker), GFP_NOFS); | 465 | if (!worker) { |
| 474 | if (!worker) { | 466 | ret = -ENOMEM; |
| 475 | ret = -ENOMEM; | 467 | goto fail; |
| 476 | goto fail; | 468 | } |
| 477 | } | ||
| 478 | 469 | ||
| 479 | INIT_LIST_HEAD(&worker->pending); | 470 | INIT_LIST_HEAD(&worker->pending); |
| 480 | INIT_LIST_HEAD(&worker->prio_pending); | 471 | INIT_LIST_HEAD(&worker->prio_pending); |
| 481 | INIT_LIST_HEAD(&worker->worker_list); | 472 | INIT_LIST_HEAD(&worker->worker_list); |
| 482 | spin_lock_init(&worker->lock); | 473 | spin_lock_init(&worker->lock); |
| 483 | 474 | ||
| 484 | atomic_set(&worker->num_pending, 0); | 475 | atomic_set(&worker->num_pending, 0); |
| 485 | atomic_set(&worker->refs, 1); | 476 | atomic_set(&worker->refs, 1); |
| 486 | worker->workers = workers; | 477 | worker->workers = workers; |
| 487 | worker->task = kthread_run(worker_loop, worker, | 478 | worker->task = kthread_run(worker_loop, worker, |
| 488 | "btrfs-%s-%d", workers->name, | 479 | "btrfs-%s-%d", workers->name, |
| 489 | workers->num_workers + i); | 480 | workers->num_workers + 1); |
| 490 | if (IS_ERR(worker->task)) { | 481 | if (IS_ERR(worker->task)) { |
| 491 | ret = PTR_ERR(worker->task); | 482 | ret = PTR_ERR(worker->task); |
| 492 | kfree(worker); | 483 | kfree(worker); |
| 493 | goto fail; | 484 | goto fail; |
| 494 | } | ||
| 495 | spin_lock_irq(&workers->lock); | ||
| 496 | list_add_tail(&worker->worker_list, &workers->idle_list); | ||
| 497 | worker->idle = 1; | ||
| 498 | workers->num_workers++; | ||
| 499 | workers->num_workers_starting--; | ||
| 500 | WARN_ON(workers->num_workers_starting < 0); | ||
| 501 | spin_unlock_irq(&workers->lock); | ||
| 502 | } | 485 | } |
| 486 | spin_lock_irq(&workers->lock); | ||
| 487 | list_add_tail(&worker->worker_list, &workers->idle_list); | ||
| 488 | worker->idle = 1; | ||
| 489 | workers->num_workers++; | ||
| 490 | workers->num_workers_starting--; | ||
| 491 | WARN_ON(workers->num_workers_starting < 0); | ||
| 492 | spin_unlock_irq(&workers->lock); | ||
| 493 | |||
| 503 | return 0; | 494 | return 0; |
| 504 | fail: | 495 | fail: |
| 505 | btrfs_stop_workers(workers); | 496 | spin_lock_irq(&workers->lock); |
| 497 | workers->num_workers_starting--; | ||
| 498 | spin_unlock_irq(&workers->lock); | ||
| 506 | return ret; | 499 | return ret; |
| 507 | } | 500 | } |
| 508 | 501 | ||
| 509 | int btrfs_start_workers(struct btrfs_workers *workers, int num_workers) | 502 | int btrfs_start_workers(struct btrfs_workers *workers) |
| 510 | { | 503 | { |
| 511 | spin_lock_irq(&workers->lock); | 504 | spin_lock_irq(&workers->lock); |
| 512 | workers->num_workers_starting += num_workers; | 505 | workers->num_workers_starting++; |
| 513 | spin_unlock_irq(&workers->lock); | 506 | spin_unlock_irq(&workers->lock); |
| 514 | return __btrfs_start_workers(workers, num_workers); | 507 | return __btrfs_start_workers(workers); |
| 515 | } | 508 | } |
| 516 | 509 | ||
| 517 | /* | 510 | /* |
| @@ -568,6 +561,7 @@ static struct btrfs_worker_thread *find_worker(struct btrfs_workers *workers) | |||
| 568 | struct btrfs_worker_thread *worker; | 561 | struct btrfs_worker_thread *worker; |
| 569 | unsigned long flags; | 562 | unsigned long flags; |
| 570 | struct list_head *fallback; | 563 | struct list_head *fallback; |
| 564 | int ret; | ||
| 571 | 565 | ||
| 572 | again: | 566 | again: |
| 573 | spin_lock_irqsave(&workers->lock, flags); | 567 | spin_lock_irqsave(&workers->lock, flags); |
| @@ -584,7 +578,9 @@ again: | |||
| 584 | workers->num_workers_starting++; | 578 | workers->num_workers_starting++; |
| 585 | spin_unlock_irqrestore(&workers->lock, flags); | 579 | spin_unlock_irqrestore(&workers->lock, flags); |
| 586 | /* we're below the limit, start another worker */ | 580 | /* we're below the limit, start another worker */ |
| 587 | __btrfs_start_workers(workers, 1); | 581 | ret = __btrfs_start_workers(workers); |
| 582 | if (ret) | ||
| 583 | goto fallback; | ||
| 588 | goto again; | 584 | goto again; |
| 589 | } | 585 | } |
| 590 | } | 586 | } |
| @@ -665,7 +661,7 @@ void btrfs_set_work_high_prio(struct btrfs_work *work) | |||
| 665 | /* | 661 | /* |
| 666 | * places a struct btrfs_work into the pending queue of one of the kthreads | 662 | * places a struct btrfs_work into the pending queue of one of the kthreads |
| 667 | */ | 663 | */ |
| 668 | int btrfs_queue_worker(struct btrfs_workers *workers, struct btrfs_work *work) | 664 | void btrfs_queue_worker(struct btrfs_workers *workers, struct btrfs_work *work) |
| 669 | { | 665 | { |
| 670 | struct btrfs_worker_thread *worker; | 666 | struct btrfs_worker_thread *worker; |
| 671 | unsigned long flags; | 667 | unsigned long flags; |
| @@ -673,7 +669,7 @@ int btrfs_queue_worker(struct btrfs_workers *workers, struct btrfs_work *work) | |||
| 673 | 669 | ||
| 674 | /* don't requeue something already on a list */ | 670 | /* don't requeue something already on a list */ |
| 675 | if (test_and_set_bit(WORK_QUEUED_BIT, &work->flags)) | 671 | if (test_and_set_bit(WORK_QUEUED_BIT, &work->flags)) |
| 676 | goto out; | 672 | return; |
| 677 | 673 | ||
| 678 | worker = find_worker(workers); | 674 | worker = find_worker(workers); |
| 679 | if (workers->ordered) { | 675 | if (workers->ordered) { |
| @@ -712,7 +708,4 @@ int btrfs_queue_worker(struct btrfs_workers *workers, struct btrfs_work *work) | |||
| 712 | if (wake) | 708 | if (wake) |
| 713 | wake_up_process(worker->task); | 709 | wake_up_process(worker->task); |
| 714 | spin_unlock_irqrestore(&worker->lock, flags); | 710 | spin_unlock_irqrestore(&worker->lock, flags); |
| 715 | |||
| 716 | out: | ||
| 717 | return 0; | ||
| 718 | } | 711 | } |
diff --git a/fs/btrfs/async-thread.h b/fs/btrfs/async-thread.h index 5077746cf85e..f34cc31fa3c9 100644 --- a/fs/btrfs/async-thread.h +++ b/fs/btrfs/async-thread.h | |||
| @@ -109,8 +109,8 @@ struct btrfs_workers { | |||
| 109 | char *name; | 109 | char *name; |
| 110 | }; | 110 | }; |
| 111 | 111 | ||
| 112 | int btrfs_queue_worker(struct btrfs_workers *workers, struct btrfs_work *work); | 112 | void btrfs_queue_worker(struct btrfs_workers *workers, struct btrfs_work *work); |
| 113 | int btrfs_start_workers(struct btrfs_workers *workers, int num_workers); | 113 | int btrfs_start_workers(struct btrfs_workers *workers); |
| 114 | int btrfs_stop_workers(struct btrfs_workers *workers); | 114 | int btrfs_stop_workers(struct btrfs_workers *workers); |
| 115 | void btrfs_init_workers(struct btrfs_workers *workers, char *name, int max, | 115 | void btrfs_init_workers(struct btrfs_workers *workers, char *name, int max, |
| 116 | struct btrfs_workers *async_starter); | 116 | struct btrfs_workers *async_starter); |
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index 04a5dfcee5a1..67385033323d 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h | |||
| @@ -2369,6 +2369,9 @@ int btrfs_block_rsv_check(struct btrfs_root *root, | |||
| 2369 | int btrfs_block_rsv_refill(struct btrfs_root *root, | 2369 | int btrfs_block_rsv_refill(struct btrfs_root *root, |
| 2370 | struct btrfs_block_rsv *block_rsv, | 2370 | struct btrfs_block_rsv *block_rsv, |
| 2371 | u64 min_reserved); | 2371 | u64 min_reserved); |
| 2372 | int btrfs_block_rsv_refill_noflush(struct btrfs_root *root, | ||
| 2373 | struct btrfs_block_rsv *block_rsv, | ||
| 2374 | u64 min_reserved); | ||
| 2372 | int btrfs_block_rsv_migrate(struct btrfs_block_rsv *src_rsv, | 2375 | int btrfs_block_rsv_migrate(struct btrfs_block_rsv *src_rsv, |
| 2373 | struct btrfs_block_rsv *dst_rsv, | 2376 | struct btrfs_block_rsv *dst_rsv, |
| 2374 | u64 num_bytes); | 2377 | u64 num_bytes); |
| @@ -2689,7 +2692,8 @@ int btrfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf); | |||
| 2689 | int btrfs_readpage(struct file *file, struct page *page); | 2692 | int btrfs_readpage(struct file *file, struct page *page); |
| 2690 | void btrfs_evict_inode(struct inode *inode); | 2693 | void btrfs_evict_inode(struct inode *inode); |
| 2691 | int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc); | 2694 | int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc); |
| 2692 | void btrfs_dirty_inode(struct inode *inode, int flags); | 2695 | int btrfs_dirty_inode(struct inode *inode); |
| 2696 | int btrfs_update_time(struct file *file); | ||
| 2693 | struct inode *btrfs_alloc_inode(struct super_block *sb); | 2697 | struct inode *btrfs_alloc_inode(struct super_block *sb); |
| 2694 | void btrfs_destroy_inode(struct inode *inode); | 2698 | void btrfs_destroy_inode(struct inode *inode); |
| 2695 | int btrfs_drop_inode(struct inode *inode); | 2699 | int btrfs_drop_inode(struct inode *inode); |
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index 5b163572e0ca..9c1eccc2c503 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c | |||
| @@ -640,8 +640,8 @@ static int btrfs_delayed_inode_reserve_metadata( | |||
| 640 | * Now if src_rsv == delalloc_block_rsv we'll let it just steal since | 640 | * Now if src_rsv == delalloc_block_rsv we'll let it just steal since |
| 641 | * we're accounted for. | 641 | * we're accounted for. |
| 642 | */ | 642 | */ |
| 643 | if (!trans->bytes_reserved && | 643 | if (!src_rsv || (!trans->bytes_reserved && |
| 644 | src_rsv != &root->fs_info->delalloc_block_rsv) { | 644 | src_rsv != &root->fs_info->delalloc_block_rsv)) { |
| 645 | ret = btrfs_block_rsv_add_noflush(root, dst_rsv, num_bytes); | 645 | ret = btrfs_block_rsv_add_noflush(root, dst_rsv, num_bytes); |
| 646 | /* | 646 | /* |
| 647 | * Since we're under a transaction reserve_metadata_bytes could | 647 | * Since we're under a transaction reserve_metadata_bytes could |
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 632f8f3cc9db..f44b3928dc2d 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c | |||
| @@ -2194,19 +2194,27 @@ struct btrfs_root *open_ctree(struct super_block *sb, | |||
| 2194 | fs_info->endio_meta_write_workers.idle_thresh = 2; | 2194 | fs_info->endio_meta_write_workers.idle_thresh = 2; |
| 2195 | fs_info->readahead_workers.idle_thresh = 2; | 2195 | fs_info->readahead_workers.idle_thresh = 2; |
| 2196 | 2196 | ||
| 2197 | btrfs_start_workers(&fs_info->workers, 1); | 2197 | /* |
| 2198 | btrfs_start_workers(&fs_info->generic_worker, 1); | 2198 | * btrfs_start_workers can really only fail because of ENOMEM so just |
| 2199 | btrfs_start_workers(&fs_info->submit_workers, 1); | 2199 | * return -ENOMEM if any of these fail. |
| 2200 | btrfs_start_workers(&fs_info->delalloc_workers, 1); | 2200 | */ |
| 2201 | btrfs_start_workers(&fs_info->fixup_workers, 1); | 2201 | ret = btrfs_start_workers(&fs_info->workers); |
| 2202 | btrfs_start_workers(&fs_info->endio_workers, 1); | 2202 | ret |= btrfs_start_workers(&fs_info->generic_worker); |
| 2203 | btrfs_start_workers(&fs_info->endio_meta_workers, 1); | 2203 | ret |= btrfs_start_workers(&fs_info->submit_workers); |
| 2204 | btrfs_start_workers(&fs_info->endio_meta_write_workers, 1); | 2204 | ret |= btrfs_start_workers(&fs_info->delalloc_workers); |
| 2205 | btrfs_start_workers(&fs_info->endio_write_workers, 1); | 2205 | ret |= btrfs_start_workers(&fs_info->fixup_workers); |
| 2206 | btrfs_start_workers(&fs_info->endio_freespace_worker, 1); | 2206 | ret |= btrfs_start_workers(&fs_info->endio_workers); |
| 2207 | btrfs_start_workers(&fs_info->delayed_workers, 1); | 2207 | ret |= btrfs_start_workers(&fs_info->endio_meta_workers); |
| 2208 | btrfs_start_workers(&fs_info->caching_workers, 1); | 2208 | ret |= btrfs_start_workers(&fs_info->endio_meta_write_workers); |
| 2209 | btrfs_start_workers(&fs_info->readahead_workers, 1); | 2209 | ret |= btrfs_start_workers(&fs_info->endio_write_workers); |
| 2210 | ret |= btrfs_start_workers(&fs_info->endio_freespace_worker); | ||
| 2211 | ret |= btrfs_start_workers(&fs_info->delayed_workers); | ||
| 2212 | ret |= btrfs_start_workers(&fs_info->caching_workers); | ||
| 2213 | ret |= btrfs_start_workers(&fs_info->readahead_workers); | ||
| 2214 | if (ret) { | ||
| 2215 | ret = -ENOMEM; | ||
| 2216 | goto fail_sb_buffer; | ||
| 2217 | } | ||
| 2210 | 2218 | ||
| 2211 | fs_info->bdi.ra_pages *= btrfs_super_num_devices(disk_super); | 2219 | fs_info->bdi.ra_pages *= btrfs_super_num_devices(disk_super); |
| 2212 | fs_info->bdi.ra_pages = max(fs_info->bdi.ra_pages, | 2220 | fs_info->bdi.ra_pages = max(fs_info->bdi.ra_pages, |
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 930ae8949737..f5fbe576d2ba 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c | |||
| @@ -2822,7 +2822,7 @@ out_free: | |||
| 2822 | btrfs_release_path(path); | 2822 | btrfs_release_path(path); |
| 2823 | out: | 2823 | out: |
| 2824 | spin_lock(&block_group->lock); | 2824 | spin_lock(&block_group->lock); |
| 2825 | if (!ret) | 2825 | if (!ret && dcs == BTRFS_DC_SETUP) |
| 2826 | block_group->cache_generation = trans->transid; | 2826 | block_group->cache_generation = trans->transid; |
| 2827 | block_group->disk_cache_state = dcs; | 2827 | block_group->disk_cache_state = dcs; |
| 2828 | spin_unlock(&block_group->lock); | 2828 | spin_unlock(&block_group->lock); |
| @@ -3888,9 +3888,9 @@ int btrfs_block_rsv_check(struct btrfs_root *root, | |||
| 3888 | return ret; | 3888 | return ret; |
| 3889 | } | 3889 | } |
| 3890 | 3890 | ||
| 3891 | int btrfs_block_rsv_refill(struct btrfs_root *root, | 3891 | static inline int __btrfs_block_rsv_refill(struct btrfs_root *root, |
| 3892 | struct btrfs_block_rsv *block_rsv, | 3892 | struct btrfs_block_rsv *block_rsv, |
| 3893 | u64 min_reserved) | 3893 | u64 min_reserved, int flush) |
| 3894 | { | 3894 | { |
| 3895 | u64 num_bytes = 0; | 3895 | u64 num_bytes = 0; |
| 3896 | int ret = -ENOSPC; | 3896 | int ret = -ENOSPC; |
| @@ -3909,7 +3909,7 @@ int btrfs_block_rsv_refill(struct btrfs_root *root, | |||
| 3909 | if (!ret) | 3909 | if (!ret) |
| 3910 | return 0; | 3910 | return 0; |
| 3911 | 3911 | ||
| 3912 | ret = reserve_metadata_bytes(root, block_rsv, num_bytes, 1); | 3912 | ret = reserve_metadata_bytes(root, block_rsv, num_bytes, flush); |
| 3913 | if (!ret) { | 3913 | if (!ret) { |
| 3914 | block_rsv_add_bytes(block_rsv, num_bytes, 0); | 3914 | block_rsv_add_bytes(block_rsv, num_bytes, 0); |
| 3915 | return 0; | 3915 | return 0; |
| @@ -3918,6 +3918,20 @@ int btrfs_block_rsv_refill(struct btrfs_root *root, | |||
| 3918 | return ret; | 3918 | return ret; |
| 3919 | } | 3919 | } |
| 3920 | 3920 | ||
| 3921 | int btrfs_block_rsv_refill(struct btrfs_root *root, | ||
| 3922 | struct btrfs_block_rsv *block_rsv, | ||
| 3923 | u64 min_reserved) | ||
| 3924 | { | ||
| 3925 | return __btrfs_block_rsv_refill(root, block_rsv, min_reserved, 1); | ||
| 3926 | } | ||
| 3927 | |||
| 3928 | int btrfs_block_rsv_refill_noflush(struct btrfs_root *root, | ||
| 3929 | struct btrfs_block_rsv *block_rsv, | ||
| 3930 | u64 min_reserved) | ||
| 3931 | { | ||
| 3932 | return __btrfs_block_rsv_refill(root, block_rsv, min_reserved, 0); | ||
| 3933 | } | ||
| 3934 | |||
| 3921 | int btrfs_block_rsv_migrate(struct btrfs_block_rsv *src_rsv, | 3935 | int btrfs_block_rsv_migrate(struct btrfs_block_rsv *src_rsv, |
| 3922 | struct btrfs_block_rsv *dst_rsv, | 3936 | struct btrfs_block_rsv *dst_rsv, |
| 3923 | u64 num_bytes) | 3937 | u64 num_bytes) |
| @@ -4190,12 +4204,17 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode, u64 num_bytes) | |||
| 4190 | struct btrfs_root *root = BTRFS_I(inode)->root; | 4204 | struct btrfs_root *root = BTRFS_I(inode)->root; |
| 4191 | struct btrfs_block_rsv *block_rsv = &root->fs_info->delalloc_block_rsv; | 4205 | struct btrfs_block_rsv *block_rsv = &root->fs_info->delalloc_block_rsv; |
| 4192 | u64 to_reserve = 0; | 4206 | u64 to_reserve = 0; |
| 4207 | u64 csum_bytes; | ||
| 4193 | unsigned nr_extents = 0; | 4208 | unsigned nr_extents = 0; |
| 4209 | int extra_reserve = 0; | ||
| 4194 | int flush = 1; | 4210 | int flush = 1; |
| 4195 | int ret; | 4211 | int ret; |
| 4196 | 4212 | ||
| 4213 | /* Need to be holding the i_mutex here if we aren't free space cache */ | ||
| 4197 | if (btrfs_is_free_space_inode(root, inode)) | 4214 | if (btrfs_is_free_space_inode(root, inode)) |
| 4198 | flush = 0; | 4215 | flush = 0; |
| 4216 | else | ||
| 4217 | WARN_ON(!mutex_is_locked(&inode->i_mutex)); | ||
| 4199 | 4218 | ||
| 4200 | if (flush && btrfs_transaction_in_commit(root->fs_info)) | 4219 | if (flush && btrfs_transaction_in_commit(root->fs_info)) |
| 4201 | schedule_timeout(1); | 4220 | schedule_timeout(1); |
| @@ -4206,11 +4225,9 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode, u64 num_bytes) | |||
| 4206 | BTRFS_I(inode)->outstanding_extents++; | 4225 | BTRFS_I(inode)->outstanding_extents++; |
| 4207 | 4226 | ||
| 4208 | if (BTRFS_I(inode)->outstanding_extents > | 4227 | if (BTRFS_I(inode)->outstanding_extents > |
| 4209 | BTRFS_I(inode)->reserved_extents) { | 4228 | BTRFS_I(inode)->reserved_extents) |
| 4210 | nr_extents = BTRFS_I(inode)->outstanding_extents - | 4229 | nr_extents = BTRFS_I(inode)->outstanding_extents - |
| 4211 | BTRFS_I(inode)->reserved_extents; | 4230 | BTRFS_I(inode)->reserved_extents; |
| 4212 | BTRFS_I(inode)->reserved_extents += nr_extents; | ||
| 4213 | } | ||
| 4214 | 4231 | ||
| 4215 | /* | 4232 | /* |
| 4216 | * Add an item to reserve for updating the inode when we complete the | 4233 | * Add an item to reserve for updating the inode when we complete the |
| @@ -4218,11 +4235,12 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode, u64 num_bytes) | |||
| 4218 | */ | 4235 | */ |
| 4219 | if (!BTRFS_I(inode)->delalloc_meta_reserved) { | 4236 | if (!BTRFS_I(inode)->delalloc_meta_reserved) { |
| 4220 | nr_extents++; | 4237 | nr_extents++; |
| 4221 | BTRFS_I(inode)->delalloc_meta_reserved = 1; | 4238 | extra_reserve = 1; |
| 4222 | } | 4239 | } |
| 4223 | 4240 | ||
| 4224 | to_reserve = btrfs_calc_trans_metadata_size(root, nr_extents); | 4241 | to_reserve = btrfs_calc_trans_metadata_size(root, nr_extents); |
| 4225 | to_reserve += calc_csum_metadata_size(inode, num_bytes, 1); | 4242 | to_reserve += calc_csum_metadata_size(inode, num_bytes, 1); |
| 4243 | csum_bytes = BTRFS_I(inode)->csum_bytes; | ||
| 4226 | spin_unlock(&BTRFS_I(inode)->lock); | 4244 | spin_unlock(&BTRFS_I(inode)->lock); |
| 4227 | 4245 | ||
| 4228 | ret = reserve_metadata_bytes(root, block_rsv, to_reserve, flush); | 4246 | ret = reserve_metadata_bytes(root, block_rsv, to_reserve, flush); |
| @@ -4232,22 +4250,35 @@ int btrfs_delalloc_reserve_metadata(struct inode *inode, u64 num_bytes) | |||
| 4232 | 4250 | ||
| 4233 | spin_lock(&BTRFS_I(inode)->lock); | 4251 | spin_lock(&BTRFS_I(inode)->lock); |
| 4234 | dropped = drop_outstanding_extent(inode); | 4252 | dropped = drop_outstanding_extent(inode); |
| 4235 | to_free = calc_csum_metadata_size(inode, num_bytes, 0); | ||
| 4236 | spin_unlock(&BTRFS_I(inode)->lock); | ||
| 4237 | to_free += btrfs_calc_trans_metadata_size(root, dropped); | ||
| 4238 | |||
| 4239 | /* | 4253 | /* |
| 4240 | * Somebody could have come in and twiddled with the | 4254 | * If the inodes csum_bytes is the same as the original |
| 4241 | * reservation, so if we have to free more than we would have | 4255 | * csum_bytes then we know we haven't raced with any free()ers |
| 4242 | * reserved from this reservation go ahead and release those | 4256 | * so we can just reduce our inodes csum bytes and carry on. |
| 4243 | * bytes. | 4257 | * Otherwise we have to do the normal free thing to account for |
| 4258 | * the case that the free side didn't free up its reserve | ||
| 4259 | * because of this outstanding reservation. | ||
| 4244 | */ | 4260 | */ |
| 4245 | to_free -= to_reserve; | 4261 | if (BTRFS_I(inode)->csum_bytes == csum_bytes) |
| 4262 | calc_csum_metadata_size(inode, num_bytes, 0); | ||
| 4263 | else | ||
| 4264 | to_free = calc_csum_metadata_size(inode, num_bytes, 0); | ||
| 4265 | spin_unlock(&BTRFS_I(inode)->lock); | ||
| 4266 | if (dropped) | ||
| 4267 | to_free += btrfs_calc_trans_metadata_size(root, dropped); | ||
| 4268 | |||
| 4246 | if (to_free) | 4269 | if (to_free) |
| 4247 | btrfs_block_rsv_release(root, block_rsv, to_free); | 4270 | btrfs_block_rsv_release(root, block_rsv, to_free); |
| 4248 | return ret; | 4271 | return ret; |
| 4249 | } | 4272 | } |
| 4250 | 4273 | ||
| 4274 | spin_lock(&BTRFS_I(inode)->lock); | ||
| 4275 | if (extra_reserve) { | ||
| 4276 | BTRFS_I(inode)->delalloc_meta_reserved = 1; | ||
| 4277 | nr_extents--; | ||
| 4278 | } | ||
| 4279 | BTRFS_I(inode)->reserved_extents += nr_extents; | ||
| 4280 | spin_unlock(&BTRFS_I(inode)->lock); | ||
| 4281 | |||
| 4251 | block_rsv_add_bytes(block_rsv, to_reserve, 1); | 4282 | block_rsv_add_bytes(block_rsv, to_reserve, 1); |
| 4252 | 4283 | ||
| 4253 | return 0; | 4284 | return 0; |
| @@ -5093,11 +5124,11 @@ static noinline int find_free_extent(struct btrfs_trans_handle *trans, | |||
| 5093 | struct btrfs_root *root = orig_root->fs_info->extent_root; | 5124 | struct btrfs_root *root = orig_root->fs_info->extent_root; |
| 5094 | struct btrfs_free_cluster *last_ptr = NULL; | 5125 | struct btrfs_free_cluster *last_ptr = NULL; |
| 5095 | struct btrfs_block_group_cache *block_group = NULL; | 5126 | struct btrfs_block_group_cache *block_group = NULL; |
| 5127 | struct btrfs_block_group_cache *used_block_group; | ||
| 5096 | int empty_cluster = 2 * 1024 * 1024; | 5128 | int empty_cluster = 2 * 1024 * 1024; |
| 5097 | int allowed_chunk_alloc = 0; | 5129 | int allowed_chunk_alloc = 0; |
| 5098 | int done_chunk_alloc = 0; | 5130 | int done_chunk_alloc = 0; |
| 5099 | struct btrfs_space_info *space_info; | 5131 | struct btrfs_space_info *space_info; |
| 5100 | int last_ptr_loop = 0; | ||
| 5101 | int loop = 0; | 5132 | int loop = 0; |
| 5102 | int index = 0; | 5133 | int index = 0; |
| 5103 | int alloc_type = (data & BTRFS_BLOCK_GROUP_DATA) ? | 5134 | int alloc_type = (data & BTRFS_BLOCK_GROUP_DATA) ? |
| @@ -5159,6 +5190,7 @@ static noinline int find_free_extent(struct btrfs_trans_handle *trans, | |||
| 5159 | ideal_cache: | 5190 | ideal_cache: |
| 5160 | block_group = btrfs_lookup_block_group(root->fs_info, | 5191 | block_group = btrfs_lookup_block_group(root->fs_info, |
| 5161 | search_start); | 5192 | search_start); |
| 5193 | used_block_group = block_group; | ||
| 5162 | /* | 5194 | /* |
| 5163 | * we don't want to use the block group if it doesn't match our | 5195 | * we don't want to use the block group if it doesn't match our |
| 5164 | * allocation bits, or if its not cached. | 5196 | * allocation bits, or if its not cached. |
| @@ -5196,6 +5228,7 @@ search: | |||
| 5196 | u64 offset; | 5228 | u64 offset; |
| 5197 | int cached; | 5229 | int cached; |
| 5198 | 5230 | ||
| 5231 | used_block_group = block_group; | ||
| 5199 | btrfs_get_block_group(block_group); | 5232 | btrfs_get_block_group(block_group); |
| 5200 | search_start = block_group->key.objectid; | 5233 | search_start = block_group->key.objectid; |
| 5201 | 5234 | ||
| @@ -5265,84 +5298,73 @@ alloc: | |||
| 5265 | spin_lock(&block_group->free_space_ctl->tree_lock); | 5298 | spin_lock(&block_group->free_space_ctl->tree_lock); |
| 5266 | if (cached && | 5299 | if (cached && |
| 5267 | block_group->free_space_ctl->free_space < | 5300 | block_group->free_space_ctl->free_space < |
| 5268 | num_bytes + empty_size) { | 5301 | num_bytes + empty_cluster + empty_size) { |
| 5269 | spin_unlock(&block_group->free_space_ctl->tree_lock); | 5302 | spin_unlock(&block_group->free_space_ctl->tree_lock); |
| 5270 | goto loop; | 5303 | goto loop; |
| 5271 | } | 5304 | } |
| 5272 | spin_unlock(&block_group->free_space_ctl->tree_lock); | 5305 | spin_unlock(&block_group->free_space_ctl->tree_lock); |
| 5273 | 5306 | ||
| 5274 | /* | 5307 | /* |
| 5275 | * Ok we want to try and use the cluster allocator, so lets look | 5308 | * Ok we want to try and use the cluster allocator, so |
| 5276 | * there, unless we are on LOOP_NO_EMPTY_SIZE, since we will | 5309 | * lets look there |
| 5277 | * have tried the cluster allocator plenty of times at this | ||
| 5278 | * point and not have found anything, so we are likely way too | ||
| 5279 | * fragmented for the clustering stuff to find anything, so lets | ||
| 5280 | * just skip it and let the allocator find whatever block it can | ||
| 5281 | * find | ||
| 5282 | */ | 5310 | */ |
| 5283 | if (last_ptr && loop < LOOP_NO_EMPTY_SIZE) { | 5311 | if (last_ptr) { |
| 5284 | /* | 5312 | /* |
| 5285 | * the refill lock keeps out other | 5313 | * the refill lock keeps out other |
| 5286 | * people trying to start a new cluster | 5314 | * people trying to start a new cluster |
| 5287 | */ | 5315 | */ |
| 5288 | spin_lock(&last_ptr->refill_lock); | 5316 | spin_lock(&last_ptr->refill_lock); |
| 5289 | if (last_ptr->block_group && | 5317 | used_block_group = last_ptr->block_group; |
| 5290 | (last_ptr->block_group->ro || | 5318 | if (used_block_group != block_group && |
| 5291 | !block_group_bits(last_ptr->block_group, data))) { | 5319 | (!used_block_group || |
| 5292 | offset = 0; | 5320 | used_block_group->ro || |
| 5321 | !block_group_bits(used_block_group, data))) { | ||
| 5322 | used_block_group = block_group; | ||
| 5293 | goto refill_cluster; | 5323 | goto refill_cluster; |
| 5294 | } | 5324 | } |
| 5295 | 5325 | ||
| 5296 | offset = btrfs_alloc_from_cluster(block_group, last_ptr, | 5326 | if (used_block_group != block_group) |
| 5297 | num_bytes, search_start); | 5327 | btrfs_get_block_group(used_block_group); |
| 5328 | |||
| 5329 | offset = btrfs_alloc_from_cluster(used_block_group, | ||
| 5330 | last_ptr, num_bytes, used_block_group->key.objectid); | ||
| 5298 | if (offset) { | 5331 | if (offset) { |
| 5299 | /* we have a block, we're done */ | 5332 | /* we have a block, we're done */ |
| 5300 | spin_unlock(&last_ptr->refill_lock); | 5333 | spin_unlock(&last_ptr->refill_lock); |
| 5301 | goto checks; | 5334 | goto checks; |
| 5302 | } | 5335 | } |
| 5303 | 5336 | ||
| 5304 | spin_lock(&last_ptr->lock); | 5337 | WARN_ON(last_ptr->block_group != used_block_group); |
| 5305 | /* | 5338 | if (used_block_group != block_group) { |
| 5306 | * whoops, this cluster doesn't actually point to | 5339 | btrfs_put_block_group(used_block_group); |
| 5307 | * this block group. Get a ref on the block | 5340 | used_block_group = block_group; |
| 5308 | * group is does point to and try again | ||
| 5309 | */ | ||
| 5310 | if (!last_ptr_loop && last_ptr->block_group && | ||
| 5311 | last_ptr->block_group != block_group && | ||
| 5312 | index <= | ||
| 5313 | get_block_group_index(last_ptr->block_group)) { | ||
| 5314 | |||
| 5315 | btrfs_put_block_group(block_group); | ||
| 5316 | block_group = last_ptr->block_group; | ||
| 5317 | btrfs_get_block_group(block_group); | ||
| 5318 | spin_unlock(&last_ptr->lock); | ||
| 5319 | spin_unlock(&last_ptr->refill_lock); | ||
| 5320 | |||
| 5321 | last_ptr_loop = 1; | ||
| 5322 | search_start = block_group->key.objectid; | ||
| 5323 | /* | ||
| 5324 | * we know this block group is properly | ||
| 5325 | * in the list because | ||
| 5326 | * btrfs_remove_block_group, drops the | ||
| 5327 | * cluster before it removes the block | ||
| 5328 | * group from the list | ||
| 5329 | */ | ||
| 5330 | goto have_block_group; | ||
| 5331 | } | 5341 | } |
| 5332 | spin_unlock(&last_ptr->lock); | ||
| 5333 | refill_cluster: | 5342 | refill_cluster: |
| 5343 | BUG_ON(used_block_group != block_group); | ||
| 5344 | /* If we are on LOOP_NO_EMPTY_SIZE, we can't | ||
| 5345 | * set up a new clusters, so lets just skip it | ||
| 5346 | * and let the allocator find whatever block | ||
| 5347 | * it can find. If we reach this point, we | ||
| 5348 | * will have tried the cluster allocator | ||
| 5349 | * plenty of times and not have found | ||
| 5350 | * anything, so we are likely way too | ||
| 5351 | * fragmented for the clustering stuff to find | ||
| 5352 | * anything. */ | ||
| 5353 | if (loop >= LOOP_NO_EMPTY_SIZE) { | ||
| 5354 | spin_unlock(&last_ptr->refill_lock); | ||
| 5355 | goto unclustered_alloc; | ||
| 5356 | } | ||
| 5357 | |||
| 5334 | /* | 5358 | /* |
| 5335 | * this cluster didn't work out, free it and | 5359 | * this cluster didn't work out, free it and |
| 5336 | * start over | 5360 | * start over |
| 5337 | */ | 5361 | */ |
| 5338 | btrfs_return_cluster_to_free_space(NULL, last_ptr); | 5362 | btrfs_return_cluster_to_free_space(NULL, last_ptr); |
| 5339 | 5363 | ||
| 5340 | last_ptr_loop = 0; | ||
| 5341 | |||
| 5342 | /* allocate a cluster in this block group */ | 5364 | /* allocate a cluster in this block group */ |
| 5343 | ret = btrfs_find_space_cluster(trans, root, | 5365 | ret = btrfs_find_space_cluster(trans, root, |
| 5344 | block_group, last_ptr, | 5366 | block_group, last_ptr, |
| 5345 | offset, num_bytes, | 5367 | search_start, num_bytes, |
| 5346 | empty_cluster + empty_size); | 5368 | empty_cluster + empty_size); |
| 5347 | if (ret == 0) { | 5369 | if (ret == 0) { |
| 5348 | /* | 5370 | /* |
| @@ -5378,6 +5400,7 @@ refill_cluster: | |||
| 5378 | goto loop; | 5400 | goto loop; |
| 5379 | } | 5401 | } |
| 5380 | 5402 | ||
| 5403 | unclustered_alloc: | ||
| 5381 | offset = btrfs_find_space_for_alloc(block_group, search_start, | 5404 | offset = btrfs_find_space_for_alloc(block_group, search_start, |
| 5382 | num_bytes, empty_size); | 5405 | num_bytes, empty_size); |
| 5383 | /* | 5406 | /* |
| @@ -5404,14 +5427,14 @@ checks: | |||
| 5404 | search_start = stripe_align(root, offset); | 5427 | search_start = stripe_align(root, offset); |
| 5405 | /* move on to the next group */ | 5428 | /* move on to the next group */ |
| 5406 | if (search_start + num_bytes >= search_end) { | 5429 | if (search_start + num_bytes >= search_end) { |
| 5407 | btrfs_add_free_space(block_group, offset, num_bytes); | 5430 | btrfs_add_free_space(used_block_group, offset, num_bytes); |
| 5408 | goto loop; | 5431 | goto loop; |
| 5409 | } | 5432 | } |
| 5410 | 5433 | ||
| 5411 | /* move on to the next group */ | 5434 | /* move on to the next group */ |
| 5412 | if (search_start + num_bytes > | 5435 | if (search_start + num_bytes > |
| 5413 | block_group->key.objectid + block_group->key.offset) { | 5436 | used_block_group->key.objectid + used_block_group->key.offset) { |
| 5414 | btrfs_add_free_space(block_group, offset, num_bytes); | 5437 | btrfs_add_free_space(used_block_group, offset, num_bytes); |
| 5415 | goto loop; | 5438 | goto loop; |
| 5416 | } | 5439 | } |
| 5417 | 5440 | ||
| @@ -5419,14 +5442,14 @@ checks: | |||
| 5419 | ins->offset = num_bytes; | 5442 | ins->offset = num_bytes; |
| 5420 | 5443 | ||
| 5421 | if (offset < search_start) | 5444 | if (offset < search_start) |
| 5422 | btrfs_add_free_space(block_group, offset, | 5445 | btrfs_add_free_space(used_block_group, offset, |
| 5423 | search_start - offset); | 5446 | search_start - offset); |
| 5424 | BUG_ON(offset > search_start); | 5447 | BUG_ON(offset > search_start); |
| 5425 | 5448 | ||
| 5426 | ret = btrfs_update_reserved_bytes(block_group, num_bytes, | 5449 | ret = btrfs_update_reserved_bytes(used_block_group, num_bytes, |
| 5427 | alloc_type); | 5450 | alloc_type); |
| 5428 | if (ret == -EAGAIN) { | 5451 | if (ret == -EAGAIN) { |
| 5429 | btrfs_add_free_space(block_group, offset, num_bytes); | 5452 | btrfs_add_free_space(used_block_group, offset, num_bytes); |
| 5430 | goto loop; | 5453 | goto loop; |
| 5431 | } | 5454 | } |
| 5432 | 5455 | ||
| @@ -5435,15 +5458,19 @@ checks: | |||
| 5435 | ins->offset = num_bytes; | 5458 | ins->offset = num_bytes; |
| 5436 | 5459 | ||
| 5437 | if (offset < search_start) | 5460 | if (offset < search_start) |
| 5438 | btrfs_add_free_space(block_group, offset, | 5461 | btrfs_add_free_space(used_block_group, offset, |
| 5439 | search_start - offset); | 5462 | search_start - offset); |
| 5440 | BUG_ON(offset > search_start); | 5463 | BUG_ON(offset > search_start); |
| 5464 | if (used_block_group != block_group) | ||
| 5465 | btrfs_put_block_group(used_block_group); | ||
| 5441 | btrfs_put_block_group(block_group); | 5466 | btrfs_put_block_group(block_group); |
| 5442 | break; | 5467 | break; |
| 5443 | loop: | 5468 | loop: |
| 5444 | failed_cluster_refill = false; | 5469 | failed_cluster_refill = false; |
| 5445 | failed_alloc = false; | 5470 | failed_alloc = false; |
| 5446 | BUG_ON(index != get_block_group_index(block_group)); | 5471 | BUG_ON(index != get_block_group_index(block_group)); |
| 5472 | if (used_block_group != block_group) | ||
| 5473 | btrfs_put_block_group(used_block_group); | ||
| 5447 | btrfs_put_block_group(block_group); | 5474 | btrfs_put_block_group(block_group); |
| 5448 | } | 5475 | } |
| 5449 | up_read(&space_info->groups_sem); | 5476 | up_read(&space_info->groups_sem); |
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 9472d3de5e52..49f3c9dc09f4 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c | |||
| @@ -935,8 +935,10 @@ again: | |||
| 935 | node = tree_search(tree, start); | 935 | node = tree_search(tree, start); |
| 936 | if (!node) { | 936 | if (!node) { |
| 937 | prealloc = alloc_extent_state_atomic(prealloc); | 937 | prealloc = alloc_extent_state_atomic(prealloc); |
| 938 | if (!prealloc) | 938 | if (!prealloc) { |
| 939 | return -ENOMEM; | 939 | err = -ENOMEM; |
| 940 | goto out; | ||
| 941 | } | ||
| 940 | err = insert_state(tree, prealloc, start, end, &bits); | 942 | err = insert_state(tree, prealloc, start, end, &bits); |
| 941 | prealloc = NULL; | 943 | prealloc = NULL; |
| 942 | BUG_ON(err == -EEXIST); | 944 | BUG_ON(err == -EEXIST); |
| @@ -992,8 +994,10 @@ hit_next: | |||
| 992 | */ | 994 | */ |
| 993 | if (state->start < start) { | 995 | if (state->start < start) { |
| 994 | prealloc = alloc_extent_state_atomic(prealloc); | 996 | prealloc = alloc_extent_state_atomic(prealloc); |
| 995 | if (!prealloc) | 997 | if (!prealloc) { |
| 996 | return -ENOMEM; | 998 | err = -ENOMEM; |
| 999 | goto out; | ||
| 1000 | } | ||
| 997 | err = split_state(tree, state, prealloc, start); | 1001 | err = split_state(tree, state, prealloc, start); |
| 998 | BUG_ON(err == -EEXIST); | 1002 | BUG_ON(err == -EEXIST); |
| 999 | prealloc = NULL; | 1003 | prealloc = NULL; |
| @@ -1024,8 +1028,10 @@ hit_next: | |||
| 1024 | this_end = last_start - 1; | 1028 | this_end = last_start - 1; |
| 1025 | 1029 | ||
| 1026 | prealloc = alloc_extent_state_atomic(prealloc); | 1030 | prealloc = alloc_extent_state_atomic(prealloc); |
| 1027 | if (!prealloc) | 1031 | if (!prealloc) { |
| 1028 | return -ENOMEM; | 1032 | err = -ENOMEM; |
| 1033 | goto out; | ||
| 1034 | } | ||
| 1029 | 1035 | ||
| 1030 | /* | 1036 | /* |
| 1031 | * Avoid to free 'prealloc' if it can be merged with | 1037 | * Avoid to free 'prealloc' if it can be merged with |
| @@ -1051,8 +1057,10 @@ hit_next: | |||
| 1051 | */ | 1057 | */ |
| 1052 | if (state->start <= end && state->end > end) { | 1058 | if (state->start <= end && state->end > end) { |
| 1053 | prealloc = alloc_extent_state_atomic(prealloc); | 1059 | prealloc = alloc_extent_state_atomic(prealloc); |
| 1054 | if (!prealloc) | 1060 | if (!prealloc) { |
| 1055 | return -ENOMEM; | 1061 | err = -ENOMEM; |
| 1062 | goto out; | ||
| 1063 | } | ||
| 1056 | 1064 | ||
| 1057 | err = split_state(tree, state, prealloc, end + 1); | 1065 | err = split_state(tree, state, prealloc, end + 1); |
| 1058 | BUG_ON(err == -EEXIST); | 1066 | BUG_ON(err == -EEXIST); |
| @@ -2287,14 +2295,20 @@ static void end_bio_extent_readpage(struct bio *bio, int err) | |||
| 2287 | if (!uptodate) { | 2295 | if (!uptodate) { |
| 2288 | int failed_mirror; | 2296 | int failed_mirror; |
| 2289 | failed_mirror = (int)(unsigned long)bio->bi_bdev; | 2297 | failed_mirror = (int)(unsigned long)bio->bi_bdev; |
| 2290 | if (tree->ops && tree->ops->readpage_io_failed_hook) | 2298 | /* |
| 2291 | ret = tree->ops->readpage_io_failed_hook( | 2299 | * The generic bio_readpage_error handles errors the |
| 2292 | bio, page, start, end, | 2300 | * following way: If possible, new read requests are |
| 2293 | failed_mirror, state); | 2301 | * created and submitted and will end up in |
| 2294 | else | 2302 | * end_bio_extent_readpage as well (if we're lucky, not |
| 2295 | ret = bio_readpage_error(bio, page, start, end, | 2303 | * in the !uptodate case). In that case it returns 0 and |
| 2296 | failed_mirror, NULL); | 2304 | * we just go on with the next page in our bio. If it |
| 2305 | * can't handle the error it will return -EIO and we | ||
| 2306 | * remain responsible for that page. | ||
| 2307 | */ | ||
| 2308 | ret = bio_readpage_error(bio, page, start, end, | ||
| 2309 | failed_mirror, NULL); | ||
| 2297 | if (ret == 0) { | 2310 | if (ret == 0) { |
| 2311 | error_handled: | ||
| 2298 | uptodate = | 2312 | uptodate = |
| 2299 | test_bit(BIO_UPTODATE, &bio->bi_flags); | 2313 | test_bit(BIO_UPTODATE, &bio->bi_flags); |
| 2300 | if (err) | 2314 | if (err) |
| @@ -2302,6 +2316,13 @@ static void end_bio_extent_readpage(struct bio *bio, int err) | |||
| 2302 | uncache_state(&cached); | 2316 | uncache_state(&cached); |
| 2303 | continue; | 2317 | continue; |
| 2304 | } | 2318 | } |
| 2319 | if (tree->ops && tree->ops->readpage_io_failed_hook) { | ||
| 2320 | ret = tree->ops->readpage_io_failed_hook( | ||
| 2321 | bio, page, start, end, | ||
| 2322 | failed_mirror, state); | ||
| 2323 | if (ret == 0) | ||
| 2324 | goto error_handled; | ||
| 2325 | } | ||
| 2305 | } | 2326 | } |
| 2306 | 2327 | ||
| 2307 | if (uptodate) { | 2328 | if (uptodate) { |
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index dafdfa059bf6..97fbe939c050 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c | |||
| @@ -1167,6 +1167,8 @@ static noinline ssize_t __btrfs_buffered_write(struct file *file, | |||
| 1167 | nrptrs = min((iov_iter_count(i) + PAGE_CACHE_SIZE - 1) / | 1167 | nrptrs = min((iov_iter_count(i) + PAGE_CACHE_SIZE - 1) / |
| 1168 | PAGE_CACHE_SIZE, PAGE_CACHE_SIZE / | 1168 | PAGE_CACHE_SIZE, PAGE_CACHE_SIZE / |
| 1169 | (sizeof(struct page *))); | 1169 | (sizeof(struct page *))); |
| 1170 | nrptrs = min(nrptrs, current->nr_dirtied_pause - current->nr_dirtied); | ||
| 1171 | nrptrs = max(nrptrs, 8); | ||
| 1170 | pages = kmalloc(nrptrs * sizeof(struct page *), GFP_KERNEL); | 1172 | pages = kmalloc(nrptrs * sizeof(struct page *), GFP_KERNEL); |
| 1171 | if (!pages) | 1173 | if (!pages) |
| 1172 | return -ENOMEM; | 1174 | return -ENOMEM; |
| @@ -1387,7 +1389,11 @@ static ssize_t btrfs_file_aio_write(struct kiocb *iocb, | |||
| 1387 | goto out; | 1389 | goto out; |
| 1388 | } | 1390 | } |
| 1389 | 1391 | ||
| 1390 | file_update_time(file); | 1392 | err = btrfs_update_time(file); |
| 1393 | if (err) { | ||
| 1394 | mutex_unlock(&inode->i_mutex); | ||
| 1395 | goto out; | ||
| 1396 | } | ||
| 1391 | BTRFS_I(inode)->sequence++; | 1397 | BTRFS_I(inode)->sequence++; |
| 1392 | 1398 | ||
| 1393 | start_pos = round_down(pos, root->sectorsize); | 1399 | start_pos = round_down(pos, root->sectorsize); |
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 6e5b7e463698..ec23d43d0c35 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c | |||
| @@ -1470,6 +1470,7 @@ static void add_new_bitmap(struct btrfs_free_space_ctl *ctl, | |||
| 1470 | { | 1470 | { |
| 1471 | info->offset = offset_to_bitmap(ctl, offset); | 1471 | info->offset = offset_to_bitmap(ctl, offset); |
| 1472 | info->bytes = 0; | 1472 | info->bytes = 0; |
| 1473 | INIT_LIST_HEAD(&info->list); | ||
| 1473 | link_free_space(ctl, info); | 1474 | link_free_space(ctl, info); |
| 1474 | ctl->total_bitmaps++; | 1475 | ctl->total_bitmaps++; |
| 1475 | 1476 | ||
| @@ -2319,6 +2320,7 @@ again: | |||
| 2319 | 2320 | ||
| 2320 | if (!found) { | 2321 | if (!found) { |
| 2321 | start = i; | 2322 | start = i; |
| 2323 | cluster->max_size = 0; | ||
| 2322 | found = true; | 2324 | found = true; |
| 2323 | } | 2325 | } |
| 2324 | 2326 | ||
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 526dd51a1966..0a6b928813a4 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c | |||
| @@ -38,6 +38,7 @@ | |||
| 38 | #include <linux/falloc.h> | 38 | #include <linux/falloc.h> |
| 39 | #include <linux/slab.h> | 39 | #include <linux/slab.h> |
| 40 | #include <linux/ratelimit.h> | 40 | #include <linux/ratelimit.h> |
| 41 | #include <linux/mount.h> | ||
| 41 | #include "compat.h" | 42 | #include "compat.h" |
| 42 | #include "ctree.h" | 43 | #include "ctree.h" |
| 43 | #include "disk-io.h" | 44 | #include "disk-io.h" |
| @@ -2031,7 +2032,7 @@ int btrfs_orphan_add(struct btrfs_trans_handle *trans, struct inode *inode) | |||
| 2031 | /* insert an orphan item to track this unlinked/truncated file */ | 2032 | /* insert an orphan item to track this unlinked/truncated file */ |
| 2032 | if (insert >= 1) { | 2033 | if (insert >= 1) { |
| 2033 | ret = btrfs_insert_orphan_item(trans, root, btrfs_ino(inode)); | 2034 | ret = btrfs_insert_orphan_item(trans, root, btrfs_ino(inode)); |
| 2034 | BUG_ON(ret); | 2035 | BUG_ON(ret && ret != -EEXIST); |
| 2035 | } | 2036 | } |
| 2036 | 2037 | ||
| 2037 | /* insert an orphan item to track subvolume contains orphan files */ | 2038 | /* insert an orphan item to track subvolume contains orphan files */ |
| @@ -2158,6 +2159,38 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) | |||
| 2158 | if (ret && ret != -ESTALE) | 2159 | if (ret && ret != -ESTALE) |
| 2159 | goto out; | 2160 | goto out; |
| 2160 | 2161 | ||
| 2162 | if (ret == -ESTALE && root == root->fs_info->tree_root) { | ||
| 2163 | struct btrfs_root *dead_root; | ||
| 2164 | struct btrfs_fs_info *fs_info = root->fs_info; | ||
| 2165 | int is_dead_root = 0; | ||
| 2166 | |||
| 2167 | /* | ||
| 2168 | * this is an orphan in the tree root. Currently these | ||
| 2169 | * could come from 2 sources: | ||
| 2170 | * a) a snapshot deletion in progress | ||
| 2171 | * b) a free space cache inode | ||
| 2172 | * We need to distinguish those two, as the snapshot | ||
| 2173 | * orphan must not get deleted. | ||
| 2174 | * find_dead_roots already ran before us, so if this | ||
| 2175 | * is a snapshot deletion, we should find the root | ||
| 2176 | * in the dead_roots list | ||
| 2177 | */ | ||
| 2178 | spin_lock(&fs_info->trans_lock); | ||
| 2179 | list_for_each_entry(dead_root, &fs_info->dead_roots, | ||
| 2180 | root_list) { | ||
| 2181 | if (dead_root->root_key.objectid == | ||
| 2182 | found_key.objectid) { | ||
| 2183 | is_dead_root = 1; | ||
| 2184 | break; | ||
| 2185 | } | ||
| 2186 | } | ||
| 2187 | spin_unlock(&fs_info->trans_lock); | ||
| 2188 | if (is_dead_root) { | ||
| 2189 | /* prevent this orphan from being found again */ | ||
| 2190 | key.offset = found_key.objectid - 1; | ||
| 2191 | continue; | ||
| 2192 | } | ||
| 2193 | } | ||
| 2161 | /* | 2194 | /* |
| 2162 | * Inode is already gone but the orphan item is still there, | 2195 | * Inode is already gone but the orphan item is still there, |
| 2163 | * kill the orphan item. | 2196 | * kill the orphan item. |
| @@ -2191,7 +2224,14 @@ int btrfs_orphan_cleanup(struct btrfs_root *root) | |||
| 2191 | continue; | 2224 | continue; |
| 2192 | } | 2225 | } |
| 2193 | nr_truncate++; | 2226 | nr_truncate++; |
| 2227 | /* | ||
| 2228 | * Need to hold the imutex for reservation purposes, not | ||
| 2229 | * a huge deal here but I have a WARN_ON in | ||
| 2230 | * btrfs_delalloc_reserve_space to catch offenders. | ||
| 2231 | */ | ||
| 2232 | mutex_lock(&inode->i_mutex); | ||
| 2194 | ret = btrfs_truncate(inode); | 2233 | ret = btrfs_truncate(inode); |
| 2234 | mutex_unlock(&inode->i_mutex); | ||
| 2195 | } else { | 2235 | } else { |
| 2196 | nr_unlink++; | 2236 | nr_unlink++; |
| 2197 | } | 2237 | } |
| @@ -3327,7 +3367,7 @@ int btrfs_cont_expand(struct inode *inode, loff_t oldsize, loff_t size) | |||
| 3327 | u64 hint_byte = 0; | 3367 | u64 hint_byte = 0; |
| 3328 | hole_size = last_byte - cur_offset; | 3368 | hole_size = last_byte - cur_offset; |
| 3329 | 3369 | ||
| 3330 | trans = btrfs_start_transaction(root, 2); | 3370 | trans = btrfs_start_transaction(root, 3); |
| 3331 | if (IS_ERR(trans)) { | 3371 | if (IS_ERR(trans)) { |
| 3332 | err = PTR_ERR(trans); | 3372 | err = PTR_ERR(trans); |
| 3333 | break; | 3373 | break; |
| @@ -3337,6 +3377,7 @@ int btrfs_cont_expand(struct inode *inode, loff_t oldsize, loff_t size) | |||
| 3337 | cur_offset + hole_size, | 3377 | cur_offset + hole_size, |
| 3338 | &hint_byte, 1); | 3378 | &hint_byte, 1); |
| 3339 | if (err) { | 3379 | if (err) { |
| 3380 | btrfs_update_inode(trans, root, inode); | ||
| 3340 | btrfs_end_transaction(trans, root); | 3381 | btrfs_end_transaction(trans, root); |
| 3341 | break; | 3382 | break; |
| 3342 | } | 3383 | } |
| @@ -3346,6 +3387,7 @@ int btrfs_cont_expand(struct inode *inode, loff_t oldsize, loff_t size) | |||
| 3346 | 0, hole_size, 0, hole_size, | 3387 | 0, hole_size, 0, hole_size, |
| 3347 | 0, 0, 0); | 3388 | 0, 0, 0); |
| 3348 | if (err) { | 3389 | if (err) { |
| 3390 | btrfs_update_inode(trans, root, inode); | ||
| 3349 | btrfs_end_transaction(trans, root); | 3391 | btrfs_end_transaction(trans, root); |
| 3350 | break; | 3392 | break; |
| 3351 | } | 3393 | } |
| @@ -3353,6 +3395,7 @@ int btrfs_cont_expand(struct inode *inode, loff_t oldsize, loff_t size) | |||
| 3353 | btrfs_drop_extent_cache(inode, hole_start, | 3395 | btrfs_drop_extent_cache(inode, hole_start, |
| 3354 | last_byte - 1, 0); | 3396 | last_byte - 1, 0); |
| 3355 | 3397 | ||
| 3398 | btrfs_update_inode(trans, root, inode); | ||
| 3356 | btrfs_end_transaction(trans, root); | 3399 | btrfs_end_transaction(trans, root); |
| 3357 | } | 3400 | } |
| 3358 | free_extent_map(em); | 3401 | free_extent_map(em); |
| @@ -3370,6 +3413,8 @@ int btrfs_cont_expand(struct inode *inode, loff_t oldsize, loff_t size) | |||
| 3370 | 3413 | ||
| 3371 | static int btrfs_setsize(struct inode *inode, loff_t newsize) | 3414 | static int btrfs_setsize(struct inode *inode, loff_t newsize) |
| 3372 | { | 3415 | { |
| 3416 | struct btrfs_root *root = BTRFS_I(inode)->root; | ||
| 3417 | struct btrfs_trans_handle *trans; | ||
| 3373 | loff_t oldsize = i_size_read(inode); | 3418 | loff_t oldsize = i_size_read(inode); |
| 3374 | int ret; | 3419 | int ret; |
| 3375 | 3420 | ||
| @@ -3377,16 +3422,19 @@ static int btrfs_setsize(struct inode *inode, loff_t newsize) | |||
| 3377 | return 0; | 3422 | return 0; |
| 3378 | 3423 | ||
| 3379 | if (newsize > oldsize) { | 3424 | if (newsize > oldsize) { |
| 3380 | i_size_write(inode, newsize); | ||
| 3381 | btrfs_ordered_update_i_size(inode, i_size_read(inode), NULL); | ||
| 3382 | truncate_pagecache(inode, oldsize, newsize); | 3425 | truncate_pagecache(inode, oldsize, newsize); |
| 3383 | ret = btrfs_cont_expand(inode, oldsize, newsize); | 3426 | ret = btrfs_cont_expand(inode, oldsize, newsize); |
| 3384 | if (ret) { | 3427 | if (ret) |
| 3385 | btrfs_setsize(inode, oldsize); | ||
| 3386 | return ret; | 3428 | return ret; |
| 3387 | } | ||
| 3388 | 3429 | ||
| 3389 | mark_inode_dirty(inode); | 3430 | trans = btrfs_start_transaction(root, 1); |
| 3431 | if (IS_ERR(trans)) | ||
| 3432 | return PTR_ERR(trans); | ||
| 3433 | |||
| 3434 | i_size_write(inode, newsize); | ||
| 3435 | btrfs_ordered_update_i_size(inode, i_size_read(inode), NULL); | ||
| 3436 | ret = btrfs_update_inode(trans, root, inode); | ||
| 3437 | btrfs_end_transaction_throttle(trans, root); | ||
| 3390 | } else { | 3438 | } else { |
| 3391 | 3439 | ||
| 3392 | /* | 3440 | /* |
| @@ -3426,9 +3474,9 @@ static int btrfs_setattr(struct dentry *dentry, struct iattr *attr) | |||
| 3426 | 3474 | ||
| 3427 | if (attr->ia_valid) { | 3475 | if (attr->ia_valid) { |
| 3428 | setattr_copy(inode, attr); | 3476 | setattr_copy(inode, attr); |
| 3429 | mark_inode_dirty(inode); | 3477 | err = btrfs_dirty_inode(inode); |
| 3430 | 3478 | ||
| 3431 | if (attr->ia_valid & ATTR_MODE) | 3479 | if (!err && attr->ia_valid & ATTR_MODE) |
| 3432 | err = btrfs_acl_chmod(inode); | 3480 | err = btrfs_acl_chmod(inode); |
| 3433 | } | 3481 | } |
| 3434 | 3482 | ||
| @@ -3490,7 +3538,7 @@ void btrfs_evict_inode(struct inode *inode) | |||
| 3490 | * doing the truncate. | 3538 | * doing the truncate. |
| 3491 | */ | 3539 | */ |
| 3492 | while (1) { | 3540 | while (1) { |
| 3493 | ret = btrfs_block_rsv_refill(root, rsv, min_size); | 3541 | ret = btrfs_block_rsv_refill_noflush(root, rsv, min_size); |
| 3494 | 3542 | ||
| 3495 | /* | 3543 | /* |
| 3496 | * Try and steal from the global reserve since we will | 3544 | * Try and steal from the global reserve since we will |
| @@ -4204,42 +4252,80 @@ int btrfs_write_inode(struct inode *inode, struct writeback_control *wbc) | |||
| 4204 | * FIXME, needs more benchmarking...there are no reasons other than performance | 4252 | * FIXME, needs more benchmarking...there are no reasons other than performance |
| 4205 | * to keep or drop this code. | 4253 | * to keep or drop this code. |
| 4206 | */ | 4254 | */ |
| 4207 | void btrfs_dirty_inode(struct inode *inode, int flags) | 4255 | int btrfs_dirty_inode(struct inode *inode) |
| 4208 | { | 4256 | { |
| 4209 | struct btrfs_root *root = BTRFS_I(inode)->root; | 4257 | struct btrfs_root *root = BTRFS_I(inode)->root; |
| 4210 | struct btrfs_trans_handle *trans; | 4258 | struct btrfs_trans_handle *trans; |
| 4211 | int ret; | 4259 | int ret; |
| 4212 | 4260 | ||
| 4213 | if (BTRFS_I(inode)->dummy_inode) | 4261 | if (BTRFS_I(inode)->dummy_inode) |
| 4214 | return; | 4262 | return 0; |
| 4215 | 4263 | ||
| 4216 | trans = btrfs_join_transaction(root); | 4264 | trans = btrfs_join_transaction(root); |
| 4217 | BUG_ON(IS_ERR(trans)); | 4265 | if (IS_ERR(trans)) |
| 4266 | return PTR_ERR(trans); | ||
| 4218 | 4267 | ||
| 4219 | ret = btrfs_update_inode(trans, root, inode); | 4268 | ret = btrfs_update_inode(trans, root, inode); |
| 4220 | if (ret && ret == -ENOSPC) { | 4269 | if (ret && ret == -ENOSPC) { |
| 4221 | /* whoops, lets try again with the full transaction */ | 4270 | /* whoops, lets try again with the full transaction */ |
| 4222 | btrfs_end_transaction(trans, root); | 4271 | btrfs_end_transaction(trans, root); |
| 4223 | trans = btrfs_start_transaction(root, 1); | 4272 | trans = btrfs_start_transaction(root, 1); |
| 4224 | if (IS_ERR(trans)) { | 4273 | if (IS_ERR(trans)) |
| 4225 | printk_ratelimited(KERN_ERR "btrfs: fail to " | 4274 | return PTR_ERR(trans); |
| 4226 | "dirty inode %llu error %ld\n", | ||
| 4227 | (unsigned long long)btrfs_ino(inode), | ||
| 4228 | PTR_ERR(trans)); | ||
| 4229 | return; | ||
| 4230 | } | ||
| 4231 | 4275 | ||
| 4232 | ret = btrfs_update_inode(trans, root, inode); | 4276 | ret = btrfs_update_inode(trans, root, inode); |
| 4233 | if (ret) { | ||
| 4234 | printk_ratelimited(KERN_ERR "btrfs: fail to " | ||
| 4235 | "dirty inode %llu error %d\n", | ||
| 4236 | (unsigned long long)btrfs_ino(inode), | ||
| 4237 | ret); | ||
| 4238 | } | ||
| 4239 | } | 4277 | } |
| 4240 | btrfs_end_transaction(trans, root); | 4278 | btrfs_end_transaction(trans, root); |
| 4241 | if (BTRFS_I(inode)->delayed_node) | 4279 | if (BTRFS_I(inode)->delayed_node) |
| 4242 | btrfs_balance_delayed_items(root); | 4280 | btrfs_balance_delayed_items(root); |
| 4281 | |||
| 4282 | return ret; | ||
| 4283 | } | ||
| 4284 | |||
| 4285 | /* | ||
| 4286 | * This is a copy of file_update_time. We need this so we can return error on | ||
| 4287 | * ENOSPC for updating the inode in the case of file write and mmap writes. | ||
| 4288 | */ | ||
| 4289 | int btrfs_update_time(struct file *file) | ||
| 4290 | { | ||
| 4291 | struct inode *inode = file->f_path.dentry->d_inode; | ||
| 4292 | struct timespec now; | ||
| 4293 | int ret; | ||
| 4294 | enum { S_MTIME = 1, S_CTIME = 2, S_VERSION = 4 } sync_it = 0; | ||
| 4295 | |||
| 4296 | /* First try to exhaust all avenues to not sync */ | ||
| 4297 | if (IS_NOCMTIME(inode)) | ||
| 4298 | return 0; | ||
| 4299 | |||
| 4300 | now = current_fs_time(inode->i_sb); | ||
| 4301 | if (!timespec_equal(&inode->i_mtime, &now)) | ||
| 4302 | sync_it = S_MTIME; | ||
| 4303 | |||
| 4304 | if (!timespec_equal(&inode->i_ctime, &now)) | ||
| 4305 | sync_it |= S_CTIME; | ||
| 4306 | |||
| 4307 | if (IS_I_VERSION(inode)) | ||
| 4308 | sync_it |= S_VERSION; | ||
| 4309 | |||
| 4310 | if (!sync_it) | ||
| 4311 | return 0; | ||
| 4312 | |||
| 4313 | /* Finally allowed to write? Takes lock. */ | ||
| 4314 | if (mnt_want_write_file(file)) | ||
| 4315 | return 0; | ||
| 4316 | |||
| 4317 | /* Only change inode inside the lock region */ | ||
| 4318 | if (sync_it & S_VERSION) | ||
| 4319 | inode_inc_iversion(inode); | ||
| 4320 | if (sync_it & S_CTIME) | ||
| 4321 | inode->i_ctime = now; | ||
| 4322 | if (sync_it & S_MTIME) | ||
| 4323 | inode->i_mtime = now; | ||
| 4324 | ret = btrfs_dirty_inode(inode); | ||
| 4325 | if (!ret) | ||
| 4326 | mark_inode_dirty_sync(inode); | ||
| 4327 | mnt_drop_write(file->f_path.mnt); | ||
| 4328 | return ret; | ||
| 4243 | } | 4329 | } |
| 4244 | 4330 | ||
| 4245 | /* | 4331 | /* |
| @@ -4555,11 +4641,18 @@ static int btrfs_mknod(struct inode *dir, struct dentry *dentry, | |||
| 4555 | goto out_unlock; | 4641 | goto out_unlock; |
| 4556 | } | 4642 | } |
| 4557 | 4643 | ||
| 4644 | /* | ||
| 4645 | * If the active LSM wants to access the inode during | ||
| 4646 | * d_instantiate it needs these. Smack checks to see | ||
| 4647 | * if the filesystem supports xattrs by looking at the | ||
| 4648 | * ops vector. | ||
| 4649 | */ | ||
| 4650 | |||
| 4651 | inode->i_op = &btrfs_special_inode_operations; | ||
| 4558 | err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index); | 4652 | err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index); |
| 4559 | if (err) | 4653 | if (err) |
| 4560 | drop_inode = 1; | 4654 | drop_inode = 1; |
| 4561 | else { | 4655 | else { |
| 4562 | inode->i_op = &btrfs_special_inode_operations; | ||
| 4563 | init_special_inode(inode, inode->i_mode, rdev); | 4656 | init_special_inode(inode, inode->i_mode, rdev); |
| 4564 | btrfs_update_inode(trans, root, inode); | 4657 | btrfs_update_inode(trans, root, inode); |
| 4565 | } | 4658 | } |
| @@ -4613,14 +4706,21 @@ static int btrfs_create(struct inode *dir, struct dentry *dentry, | |||
| 4613 | goto out_unlock; | 4706 | goto out_unlock; |
| 4614 | } | 4707 | } |
| 4615 | 4708 | ||
| 4709 | /* | ||
| 4710 | * If the active LSM wants to access the inode during | ||
| 4711 | * d_instantiate it needs these. Smack checks to see | ||
| 4712 | * if the filesystem supports xattrs by looking at the | ||
| 4713 | * ops vector. | ||
| 4714 | */ | ||
| 4715 | inode->i_fop = &btrfs_file_operations; | ||
| 4716 | inode->i_op = &btrfs_file_inode_operations; | ||
| 4717 | |||
| 4616 | err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index); | 4718 | err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index); |
| 4617 | if (err) | 4719 | if (err) |
| 4618 | drop_inode = 1; | 4720 | drop_inode = 1; |
| 4619 | else { | 4721 | else { |
| 4620 | inode->i_mapping->a_ops = &btrfs_aops; | 4722 | inode->i_mapping->a_ops = &btrfs_aops; |
| 4621 | inode->i_mapping->backing_dev_info = &root->fs_info->bdi; | 4723 | inode->i_mapping->backing_dev_info = &root->fs_info->bdi; |
| 4622 | inode->i_fop = &btrfs_file_operations; | ||
| 4623 | inode->i_op = &btrfs_file_inode_operations; | ||
| 4624 | BTRFS_I(inode)->io_tree.ops = &btrfs_extent_io_ops; | 4724 | BTRFS_I(inode)->io_tree.ops = &btrfs_extent_io_ops; |
| 4625 | } | 4725 | } |
| 4626 | out_unlock: | 4726 | out_unlock: |
| @@ -6303,7 +6403,12 @@ int btrfs_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
| 6303 | u64 page_start; | 6403 | u64 page_start; |
| 6304 | u64 page_end; | 6404 | u64 page_end; |
| 6305 | 6405 | ||
| 6406 | /* Need this to keep space reservations serialized */ | ||
| 6407 | mutex_lock(&inode->i_mutex); | ||
| 6306 | ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE); | 6408 | ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE); |
| 6409 | mutex_unlock(&inode->i_mutex); | ||
| 6410 | if (!ret) | ||
| 6411 | ret = btrfs_update_time(vma->vm_file); | ||
| 6307 | if (ret) { | 6412 | if (ret) { |
| 6308 | if (ret == -ENOMEM) | 6413 | if (ret == -ENOMEM) |
| 6309 | ret = VM_FAULT_OOM; | 6414 | ret = VM_FAULT_OOM; |
| @@ -6515,8 +6620,9 @@ static int btrfs_truncate(struct inode *inode) | |||
| 6515 | /* Just need the 1 for updating the inode */ | 6620 | /* Just need the 1 for updating the inode */ |
| 6516 | trans = btrfs_start_transaction(root, 1); | 6621 | trans = btrfs_start_transaction(root, 1); |
| 6517 | if (IS_ERR(trans)) { | 6622 | if (IS_ERR(trans)) { |
| 6518 | err = PTR_ERR(trans); | 6623 | ret = err = PTR_ERR(trans); |
| 6519 | goto out; | 6624 | trans = NULL; |
| 6625 | break; | ||
| 6520 | } | 6626 | } |
| 6521 | } | 6627 | } |
| 6522 | 6628 | ||
| @@ -7076,14 +7182,21 @@ static int btrfs_symlink(struct inode *dir, struct dentry *dentry, | |||
| 7076 | goto out_unlock; | 7182 | goto out_unlock; |
| 7077 | } | 7183 | } |
| 7078 | 7184 | ||
| 7185 | /* | ||
| 7186 | * If the active LSM wants to access the inode during | ||
| 7187 | * d_instantiate it needs these. Smack checks to see | ||
| 7188 | * if the filesystem supports xattrs by looking at the | ||
| 7189 | * ops vector. | ||
| 7190 | */ | ||
| 7191 | inode->i_fop = &btrfs_file_operations; | ||
| 7192 | inode->i_op = &btrfs_file_inode_operations; | ||
| 7193 | |||
| 7079 | err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index); | 7194 | err = btrfs_add_nondir(trans, dir, dentry, inode, 0, index); |
| 7080 | if (err) | 7195 | if (err) |
| 7081 | drop_inode = 1; | 7196 | drop_inode = 1; |
| 7082 | else { | 7197 | else { |
| 7083 | inode->i_mapping->a_ops = &btrfs_aops; | 7198 | inode->i_mapping->a_ops = &btrfs_aops; |
| 7084 | inode->i_mapping->backing_dev_info = &root->fs_info->bdi; | 7199 | inode->i_mapping->backing_dev_info = &root->fs_info->bdi; |
| 7085 | inode->i_fop = &btrfs_file_operations; | ||
| 7086 | inode->i_op = &btrfs_file_inode_operations; | ||
| 7087 | BTRFS_I(inode)->io_tree.ops = &btrfs_extent_io_ops; | 7200 | BTRFS_I(inode)->io_tree.ops = &btrfs_extent_io_ops; |
| 7088 | } | 7201 | } |
| 7089 | if (drop_inode) | 7202 | if (drop_inode) |
| @@ -7353,6 +7466,7 @@ static const struct inode_operations btrfs_symlink_inode_operations = { | |||
| 7353 | .follow_link = page_follow_link_light, | 7466 | .follow_link = page_follow_link_light, |
| 7354 | .put_link = page_put_link, | 7467 | .put_link = page_put_link, |
| 7355 | .getattr = btrfs_getattr, | 7468 | .getattr = btrfs_getattr, |
| 7469 | .setattr = btrfs_setattr, | ||
| 7356 | .permission = btrfs_permission, | 7470 | .permission = btrfs_permission, |
| 7357 | .setxattr = btrfs_setxattr, | 7471 | .setxattr = btrfs_setxattr, |
| 7358 | .getxattr = btrfs_getxattr, | 7472 | .getxattr = btrfs_getxattr, |
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index a90e749ed6d2..c04f02c7d5bb 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c | |||
| @@ -252,11 +252,11 @@ static int btrfs_ioctl_setflags(struct file *file, void __user *arg) | |||
| 252 | trans = btrfs_join_transaction(root); | 252 | trans = btrfs_join_transaction(root); |
| 253 | BUG_ON(IS_ERR(trans)); | 253 | BUG_ON(IS_ERR(trans)); |
| 254 | 254 | ||
| 255 | btrfs_update_iflags(inode); | ||
| 256 | inode->i_ctime = CURRENT_TIME; | ||
| 255 | ret = btrfs_update_inode(trans, root, inode); | 257 | ret = btrfs_update_inode(trans, root, inode); |
| 256 | BUG_ON(ret); | 258 | BUG_ON(ret); |
| 257 | 259 | ||
| 258 | btrfs_update_iflags(inode); | ||
| 259 | inode->i_ctime = CURRENT_TIME; | ||
| 260 | btrfs_end_transaction(trans, root); | 260 | btrfs_end_transaction(trans, root); |
| 261 | 261 | ||
| 262 | mnt_drop_write(file->f_path.mnt); | 262 | mnt_drop_write(file->f_path.mnt); |
| @@ -858,8 +858,10 @@ static int cluster_pages_for_defrag(struct inode *inode, | |||
| 858 | return 0; | 858 | return 0; |
| 859 | file_end = (isize - 1) >> PAGE_CACHE_SHIFT; | 859 | file_end = (isize - 1) >> PAGE_CACHE_SHIFT; |
| 860 | 860 | ||
| 861 | mutex_lock(&inode->i_mutex); | ||
| 861 | ret = btrfs_delalloc_reserve_space(inode, | 862 | ret = btrfs_delalloc_reserve_space(inode, |
| 862 | num_pages << PAGE_CACHE_SHIFT); | 863 | num_pages << PAGE_CACHE_SHIFT); |
| 864 | mutex_unlock(&inode->i_mutex); | ||
| 863 | if (ret) | 865 | if (ret) |
| 864 | return ret; | 866 | return ret; |
| 865 | again: | 867 | again: |
| @@ -1278,7 +1280,7 @@ static noinline int btrfs_ioctl_resize(struct btrfs_root *root, | |||
| 1278 | } | 1280 | } |
| 1279 | ret = btrfs_grow_device(trans, device, new_size); | 1281 | ret = btrfs_grow_device(trans, device, new_size); |
| 1280 | btrfs_commit_transaction(trans, root); | 1282 | btrfs_commit_transaction(trans, root); |
| 1281 | } else { | 1283 | } else if (new_size < old_size) { |
| 1282 | ret = btrfs_shrink_device(device, new_size); | 1284 | ret = btrfs_shrink_device(device, new_size); |
| 1283 | } | 1285 | } |
| 1284 | 1286 | ||
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index dff29d5e151a..cfb55434a469 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c | |||
| @@ -2947,7 +2947,9 @@ static int relocate_file_extent_cluster(struct inode *inode, | |||
| 2947 | index = (cluster->start - offset) >> PAGE_CACHE_SHIFT; | 2947 | index = (cluster->start - offset) >> PAGE_CACHE_SHIFT; |
| 2948 | last_index = (cluster->end - offset) >> PAGE_CACHE_SHIFT; | 2948 | last_index = (cluster->end - offset) >> PAGE_CACHE_SHIFT; |
| 2949 | while (index <= last_index) { | 2949 | while (index <= last_index) { |
| 2950 | mutex_lock(&inode->i_mutex); | ||
| 2950 | ret = btrfs_delalloc_reserve_metadata(inode, PAGE_CACHE_SIZE); | 2951 | ret = btrfs_delalloc_reserve_metadata(inode, PAGE_CACHE_SIZE); |
| 2952 | mutex_unlock(&inode->i_mutex); | ||
| 2951 | if (ret) | 2953 | if (ret) |
| 2952 | goto out; | 2954 | goto out; |
| 2953 | 2955 | ||
diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index fab420db5121..ddf2c90d3fc0 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c | |||
| @@ -256,6 +256,11 @@ static int scrub_print_warning_inode(u64 inum, u64 offset, u64 root, void *ctx) | |||
| 256 | btrfs_release_path(swarn->path); | 256 | btrfs_release_path(swarn->path); |
| 257 | 257 | ||
| 258 | ipath = init_ipath(4096, local_root, swarn->path); | 258 | ipath = init_ipath(4096, local_root, swarn->path); |
| 259 | if (IS_ERR(ipath)) { | ||
| 260 | ret = PTR_ERR(ipath); | ||
| 261 | ipath = NULL; | ||
| 262 | goto err; | ||
| 263 | } | ||
| 259 | ret = paths_from_inode(inum, ipath); | 264 | ret = paths_from_inode(inum, ipath); |
| 260 | 265 | ||
| 261 | if (ret < 0) | 266 | if (ret < 0) |
| @@ -1530,18 +1535,22 @@ static noinline_for_stack int scrub_supers(struct scrub_dev *sdev) | |||
| 1530 | static noinline_for_stack int scrub_workers_get(struct btrfs_root *root) | 1535 | static noinline_for_stack int scrub_workers_get(struct btrfs_root *root) |
| 1531 | { | 1536 | { |
| 1532 | struct btrfs_fs_info *fs_info = root->fs_info; | 1537 | struct btrfs_fs_info *fs_info = root->fs_info; |
| 1538 | int ret = 0; | ||
| 1533 | 1539 | ||
| 1534 | mutex_lock(&fs_info->scrub_lock); | 1540 | mutex_lock(&fs_info->scrub_lock); |
| 1535 | if (fs_info->scrub_workers_refcnt == 0) { | 1541 | if (fs_info->scrub_workers_refcnt == 0) { |
| 1536 | btrfs_init_workers(&fs_info->scrub_workers, "scrub", | 1542 | btrfs_init_workers(&fs_info->scrub_workers, "scrub", |
| 1537 | fs_info->thread_pool_size, &fs_info->generic_worker); | 1543 | fs_info->thread_pool_size, &fs_info->generic_worker); |
| 1538 | fs_info->scrub_workers.idle_thresh = 4; | 1544 | fs_info->scrub_workers.idle_thresh = 4; |
| 1539 | btrfs_start_workers(&fs_info->scrub_workers, 1); | 1545 | ret = btrfs_start_workers(&fs_info->scrub_workers); |
| 1546 | if (ret) | ||
| 1547 | goto out; | ||
| 1540 | } | 1548 | } |
| 1541 | ++fs_info->scrub_workers_refcnt; | 1549 | ++fs_info->scrub_workers_refcnt; |
| 1550 | out: | ||
| 1542 | mutex_unlock(&fs_info->scrub_lock); | 1551 | mutex_unlock(&fs_info->scrub_lock); |
| 1543 | 1552 | ||
| 1544 | return 0; | 1553 | return ret; |
| 1545 | } | 1554 | } |
| 1546 | 1555 | ||
| 1547 | static noinline_for_stack void scrub_workers_put(struct btrfs_root *root) | 1556 | static noinline_for_stack void scrub_workers_put(struct btrfs_root *root) |
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 17ee7fc5e64e..200f63bc6675 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c | |||
| @@ -41,6 +41,7 @@ | |||
| 41 | #include <linux/slab.h> | 41 | #include <linux/slab.h> |
| 42 | #include <linux/cleancache.h> | 42 | #include <linux/cleancache.h> |
| 43 | #include <linux/mnt_namespace.h> | 43 | #include <linux/mnt_namespace.h> |
| 44 | #include <linux/ratelimit.h> | ||
| 44 | #include "compat.h" | 45 | #include "compat.h" |
| 45 | #include "delayed-inode.h" | 46 | #include "delayed-inode.h" |
| 46 | #include "ctree.h" | 47 | #include "ctree.h" |
| @@ -1053,11 +1054,11 @@ static int btrfs_calc_avail_data_space(struct btrfs_root *root, u64 *free_bytes) | |||
| 1053 | u64 avail_space; | 1054 | u64 avail_space; |
| 1054 | u64 used_space; | 1055 | u64 used_space; |
| 1055 | u64 min_stripe_size; | 1056 | u64 min_stripe_size; |
| 1056 | int min_stripes = 1; | 1057 | int min_stripes = 1, num_stripes = 1; |
| 1057 | int i = 0, nr_devices; | 1058 | int i = 0, nr_devices; |
| 1058 | int ret; | 1059 | int ret; |
| 1059 | 1060 | ||
| 1060 | nr_devices = fs_info->fs_devices->rw_devices; | 1061 | nr_devices = fs_info->fs_devices->open_devices; |
| 1061 | BUG_ON(!nr_devices); | 1062 | BUG_ON(!nr_devices); |
| 1062 | 1063 | ||
| 1063 | devices_info = kmalloc(sizeof(*devices_info) * nr_devices, | 1064 | devices_info = kmalloc(sizeof(*devices_info) * nr_devices, |
| @@ -1067,20 +1068,24 @@ static int btrfs_calc_avail_data_space(struct btrfs_root *root, u64 *free_bytes) | |||
| 1067 | 1068 | ||
| 1068 | /* calc min stripe number for data space alloction */ | 1069 | /* calc min stripe number for data space alloction */ |
| 1069 | type = btrfs_get_alloc_profile(root, 1); | 1070 | type = btrfs_get_alloc_profile(root, 1); |
| 1070 | if (type & BTRFS_BLOCK_GROUP_RAID0) | 1071 | if (type & BTRFS_BLOCK_GROUP_RAID0) { |
| 1071 | min_stripes = 2; | 1072 | min_stripes = 2; |
| 1072 | else if (type & BTRFS_BLOCK_GROUP_RAID1) | 1073 | num_stripes = nr_devices; |
| 1074 | } else if (type & BTRFS_BLOCK_GROUP_RAID1) { | ||
| 1073 | min_stripes = 2; | 1075 | min_stripes = 2; |
| 1074 | else if (type & BTRFS_BLOCK_GROUP_RAID10) | 1076 | num_stripes = 2; |
| 1077 | } else if (type & BTRFS_BLOCK_GROUP_RAID10) { | ||
| 1075 | min_stripes = 4; | 1078 | min_stripes = 4; |
| 1079 | num_stripes = 4; | ||
| 1080 | } | ||
| 1076 | 1081 | ||
| 1077 | if (type & BTRFS_BLOCK_GROUP_DUP) | 1082 | if (type & BTRFS_BLOCK_GROUP_DUP) |
| 1078 | min_stripe_size = 2 * BTRFS_STRIPE_LEN; | 1083 | min_stripe_size = 2 * BTRFS_STRIPE_LEN; |
| 1079 | else | 1084 | else |
| 1080 | min_stripe_size = BTRFS_STRIPE_LEN; | 1085 | min_stripe_size = BTRFS_STRIPE_LEN; |
| 1081 | 1086 | ||
| 1082 | list_for_each_entry(device, &fs_devices->alloc_list, dev_alloc_list) { | 1087 | list_for_each_entry(device, &fs_devices->devices, dev_list) { |
| 1083 | if (!device->in_fs_metadata) | 1088 | if (!device->in_fs_metadata || !device->bdev) |
| 1084 | continue; | 1089 | continue; |
| 1085 | 1090 | ||
| 1086 | avail_space = device->total_bytes - device->bytes_used; | 1091 | avail_space = device->total_bytes - device->bytes_used; |
| @@ -1141,13 +1146,16 @@ static int btrfs_calc_avail_data_space(struct btrfs_root *root, u64 *free_bytes) | |||
| 1141 | i = nr_devices - 1; | 1146 | i = nr_devices - 1; |
| 1142 | avail_space = 0; | 1147 | avail_space = 0; |
| 1143 | while (nr_devices >= min_stripes) { | 1148 | while (nr_devices >= min_stripes) { |
| 1149 | if (num_stripes > nr_devices) | ||
| 1150 | num_stripes = nr_devices; | ||
| 1151 | |||
| 1144 | if (devices_info[i].max_avail >= min_stripe_size) { | 1152 | if (devices_info[i].max_avail >= min_stripe_size) { |
| 1145 | int j; | 1153 | int j; |
| 1146 | u64 alloc_size; | 1154 | u64 alloc_size; |
| 1147 | 1155 | ||
| 1148 | avail_space += devices_info[i].max_avail * min_stripes; | 1156 | avail_space += devices_info[i].max_avail * num_stripes; |
| 1149 | alloc_size = devices_info[i].max_avail; | 1157 | alloc_size = devices_info[i].max_avail; |
| 1150 | for (j = i + 1 - min_stripes; j <= i; j++) | 1158 | for (j = i + 1 - num_stripes; j <= i; j++) |
| 1151 | devices_info[j].max_avail -= alloc_size; | 1159 | devices_info[j].max_avail -= alloc_size; |
| 1152 | } | 1160 | } |
| 1153 | i--; | 1161 | i--; |
| @@ -1264,6 +1272,16 @@ static int btrfs_unfreeze(struct super_block *sb) | |||
| 1264 | return 0; | 1272 | return 0; |
| 1265 | } | 1273 | } |
| 1266 | 1274 | ||
| 1275 | static void btrfs_fs_dirty_inode(struct inode *inode, int flags) | ||
| 1276 | { | ||
| 1277 | int ret; | ||
| 1278 | |||
| 1279 | ret = btrfs_dirty_inode(inode); | ||
| 1280 | if (ret) | ||
| 1281 | printk_ratelimited(KERN_ERR "btrfs: fail to dirty inode %Lu " | ||
| 1282 | "error %d\n", btrfs_ino(inode), ret); | ||
| 1283 | } | ||
| 1284 | |||
| 1267 | static const struct super_operations btrfs_super_ops = { | 1285 | static const struct super_operations btrfs_super_ops = { |
| 1268 | .drop_inode = btrfs_drop_inode, | 1286 | .drop_inode = btrfs_drop_inode, |
| 1269 | .evict_inode = btrfs_evict_inode, | 1287 | .evict_inode = btrfs_evict_inode, |
| @@ -1271,7 +1289,7 @@ static const struct super_operations btrfs_super_ops = { | |||
| 1271 | .sync_fs = btrfs_sync_fs, | 1289 | .sync_fs = btrfs_sync_fs, |
| 1272 | .show_options = btrfs_show_options, | 1290 | .show_options = btrfs_show_options, |
| 1273 | .write_inode = btrfs_write_inode, | 1291 | .write_inode = btrfs_write_inode, |
| 1274 | .dirty_inode = btrfs_dirty_inode, | 1292 | .dirty_inode = btrfs_fs_dirty_inode, |
| 1275 | .alloc_inode = btrfs_alloc_inode, | 1293 | .alloc_inode = btrfs_alloc_inode, |
| 1276 | .destroy_inode = btrfs_destroy_inode, | 1294 | .destroy_inode = btrfs_destroy_inode, |
| 1277 | .statfs = btrfs_statfs, | 1295 | .statfs = btrfs_statfs, |
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index c37433d3cd82..f4b839fd3c9d 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c | |||
| @@ -295,6 +295,12 @@ loop_lock: | |||
| 295 | btrfs_requeue_work(&device->work); | 295 | btrfs_requeue_work(&device->work); |
| 296 | goto done; | 296 | goto done; |
| 297 | } | 297 | } |
| 298 | /* unplug every 64 requests just for good measure */ | ||
| 299 | if (batch_run % 64 == 0) { | ||
| 300 | blk_finish_plug(&plug); | ||
| 301 | blk_start_plug(&plug); | ||
| 302 | sync_pending = 0; | ||
| 303 | } | ||
| 298 | } | 304 | } |
| 299 | 305 | ||
| 300 | cond_resched(); | 306 | cond_resched(); |
| @@ -1611,7 +1617,7 @@ int btrfs_init_new_device(struct btrfs_root *root, char *device_path) | |||
| 1611 | if ((sb->s_flags & MS_RDONLY) && !root->fs_info->fs_devices->seeding) | 1617 | if ((sb->s_flags & MS_RDONLY) && !root->fs_info->fs_devices->seeding) |
| 1612 | return -EINVAL; | 1618 | return -EINVAL; |
| 1613 | 1619 | ||
| 1614 | bdev = blkdev_get_by_path(device_path, FMODE_EXCL, | 1620 | bdev = blkdev_get_by_path(device_path, FMODE_WRITE | FMODE_EXCL, |
| 1615 | root->fs_info->bdev_holder); | 1621 | root->fs_info->bdev_holder); |
| 1616 | if (IS_ERR(bdev)) | 1622 | if (IS_ERR(bdev)) |
| 1617 | return PTR_ERR(bdev); | 1623 | return PTR_ERR(bdev); |
| @@ -3258,7 +3264,7 @@ static void btrfs_end_bio(struct bio *bio, int err) | |||
| 3258 | */ | 3264 | */ |
| 3259 | if (atomic_read(&bbio->error) > bbio->max_errors) { | 3265 | if (atomic_read(&bbio->error) > bbio->max_errors) { |
| 3260 | err = -EIO; | 3266 | err = -EIO; |
| 3261 | } else if (err) { | 3267 | } else { |
| 3262 | /* | 3268 | /* |
| 3263 | * this bio is actually up to date, we didn't | 3269 | * this bio is actually up to date, we didn't |
| 3264 | * go over the max number of errors | 3270 | * go over the max number of errors |
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 4144caf2f9d3..173b1d22e59b 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c | |||
| @@ -87,7 +87,7 @@ static int ceph_set_page_dirty(struct page *page) | |||
| 87 | snapc = ceph_get_snap_context(ci->i_snap_realm->cached_context); | 87 | snapc = ceph_get_snap_context(ci->i_snap_realm->cached_context); |
| 88 | 88 | ||
| 89 | /* dirty the head */ | 89 | /* dirty the head */ |
| 90 | spin_lock(&inode->i_lock); | 90 | spin_lock(&ci->i_ceph_lock); |
| 91 | if (ci->i_head_snapc == NULL) | 91 | if (ci->i_head_snapc == NULL) |
| 92 | ci->i_head_snapc = ceph_get_snap_context(snapc); | 92 | ci->i_head_snapc = ceph_get_snap_context(snapc); |
| 93 | ++ci->i_wrbuffer_ref_head; | 93 | ++ci->i_wrbuffer_ref_head; |
| @@ -100,7 +100,7 @@ static int ceph_set_page_dirty(struct page *page) | |||
| 100 | ci->i_wrbuffer_ref-1, ci->i_wrbuffer_ref_head-1, | 100 | ci->i_wrbuffer_ref-1, ci->i_wrbuffer_ref_head-1, |
| 101 | ci->i_wrbuffer_ref, ci->i_wrbuffer_ref_head, | 101 | ci->i_wrbuffer_ref, ci->i_wrbuffer_ref_head, |
| 102 | snapc, snapc->seq, snapc->num_snaps); | 102 | snapc, snapc->seq, snapc->num_snaps); |
| 103 | spin_unlock(&inode->i_lock); | 103 | spin_unlock(&ci->i_ceph_lock); |
| 104 | 104 | ||
| 105 | /* now adjust page */ | 105 | /* now adjust page */ |
| 106 | spin_lock_irq(&mapping->tree_lock); | 106 | spin_lock_irq(&mapping->tree_lock); |
| @@ -391,7 +391,7 @@ static struct ceph_snap_context *get_oldest_context(struct inode *inode, | |||
| 391 | struct ceph_snap_context *snapc = NULL; | 391 | struct ceph_snap_context *snapc = NULL; |
| 392 | struct ceph_cap_snap *capsnap = NULL; | 392 | struct ceph_cap_snap *capsnap = NULL; |
| 393 | 393 | ||
| 394 | spin_lock(&inode->i_lock); | 394 | spin_lock(&ci->i_ceph_lock); |
| 395 | list_for_each_entry(capsnap, &ci->i_cap_snaps, ci_item) { | 395 | list_for_each_entry(capsnap, &ci->i_cap_snaps, ci_item) { |
| 396 | dout(" cap_snap %p snapc %p has %d dirty pages\n", capsnap, | 396 | dout(" cap_snap %p snapc %p has %d dirty pages\n", capsnap, |
| 397 | capsnap->context, capsnap->dirty_pages); | 397 | capsnap->context, capsnap->dirty_pages); |
| @@ -407,7 +407,7 @@ static struct ceph_snap_context *get_oldest_context(struct inode *inode, | |||
| 407 | dout(" head snapc %p has %d dirty pages\n", | 407 | dout(" head snapc %p has %d dirty pages\n", |
| 408 | snapc, ci->i_wrbuffer_ref_head); | 408 | snapc, ci->i_wrbuffer_ref_head); |
| 409 | } | 409 | } |
| 410 | spin_unlock(&inode->i_lock); | 410 | spin_unlock(&ci->i_ceph_lock); |
| 411 | return snapc; | 411 | return snapc; |
| 412 | } | 412 | } |
| 413 | 413 | ||
diff --git a/fs/ceph/caps.c b/fs/ceph/caps.c index 0f327c6c9679..8b53193e4f7c 100644 --- a/fs/ceph/caps.c +++ b/fs/ceph/caps.c | |||
| @@ -309,7 +309,7 @@ void ceph_reservation_status(struct ceph_fs_client *fsc, | |||
| 309 | /* | 309 | /* |
| 310 | * Find ceph_cap for given mds, if any. | 310 | * Find ceph_cap for given mds, if any. |
| 311 | * | 311 | * |
| 312 | * Called with i_lock held. | 312 | * Called with i_ceph_lock held. |
| 313 | */ | 313 | */ |
| 314 | static struct ceph_cap *__get_cap_for_mds(struct ceph_inode_info *ci, int mds) | 314 | static struct ceph_cap *__get_cap_for_mds(struct ceph_inode_info *ci, int mds) |
| 315 | { | 315 | { |
| @@ -332,9 +332,9 @@ struct ceph_cap *ceph_get_cap_for_mds(struct ceph_inode_info *ci, int mds) | |||
| 332 | { | 332 | { |
| 333 | struct ceph_cap *cap; | 333 | struct ceph_cap *cap; |
| 334 | 334 | ||
| 335 | spin_lock(&ci->vfs_inode.i_lock); | 335 | spin_lock(&ci->i_ceph_lock); |
| 336 | cap = __get_cap_for_mds(ci, mds); | 336 | cap = __get_cap_for_mds(ci, mds); |
| 337 | spin_unlock(&ci->vfs_inode.i_lock); | 337 | spin_unlock(&ci->i_ceph_lock); |
| 338 | return cap; | 338 | return cap; |
| 339 | } | 339 | } |
| 340 | 340 | ||
| @@ -361,15 +361,16 @@ static int __ceph_get_cap_mds(struct ceph_inode_info *ci) | |||
| 361 | 361 | ||
| 362 | int ceph_get_cap_mds(struct inode *inode) | 362 | int ceph_get_cap_mds(struct inode *inode) |
| 363 | { | 363 | { |
| 364 | struct ceph_inode_info *ci = ceph_inode(inode); | ||
| 364 | int mds; | 365 | int mds; |
| 365 | spin_lock(&inode->i_lock); | 366 | spin_lock(&ci->i_ceph_lock); |
| 366 | mds = __ceph_get_cap_mds(ceph_inode(inode)); | 367 | mds = __ceph_get_cap_mds(ceph_inode(inode)); |
| 367 | spin_unlock(&inode->i_lock); | 368 | spin_unlock(&ci->i_ceph_lock); |
| 368 | return mds; | 369 | return mds; |
| 369 | } | 370 | } |
| 370 | 371 | ||
| 371 | /* | 372 | /* |
| 372 | * Called under i_lock. | 373 | * Called under i_ceph_lock. |
| 373 | */ | 374 | */ |
| 374 | static void __insert_cap_node(struct ceph_inode_info *ci, | 375 | static void __insert_cap_node(struct ceph_inode_info *ci, |
| 375 | struct ceph_cap *new) | 376 | struct ceph_cap *new) |
| @@ -415,7 +416,7 @@ static void __cap_set_timeouts(struct ceph_mds_client *mdsc, | |||
| 415 | * | 416 | * |
| 416 | * If I_FLUSH is set, leave the inode at the front of the list. | 417 | * If I_FLUSH is set, leave the inode at the front of the list. |
| 417 | * | 418 | * |
| 418 | * Caller holds i_lock | 419 | * Caller holds i_ceph_lock |
| 419 | * -> we take mdsc->cap_delay_lock | 420 | * -> we take mdsc->cap_delay_lock |
| 420 | */ | 421 | */ |
| 421 | static void __cap_delay_requeue(struct ceph_mds_client *mdsc, | 422 | static void __cap_delay_requeue(struct ceph_mds_client *mdsc, |
| @@ -457,7 +458,7 @@ static void __cap_delay_requeue_front(struct ceph_mds_client *mdsc, | |||
| 457 | /* | 458 | /* |
| 458 | * Cancel delayed work on cap. | 459 | * Cancel delayed work on cap. |
| 459 | * | 460 | * |
| 460 | * Caller must hold i_lock. | 461 | * Caller must hold i_ceph_lock. |
| 461 | */ | 462 | */ |
| 462 | static void __cap_delay_cancel(struct ceph_mds_client *mdsc, | 463 | static void __cap_delay_cancel(struct ceph_mds_client *mdsc, |
| 463 | struct ceph_inode_info *ci) | 464 | struct ceph_inode_info *ci) |
| @@ -532,14 +533,14 @@ int ceph_add_cap(struct inode *inode, | |||
| 532 | wanted |= ceph_caps_for_mode(fmode); | 533 | wanted |= ceph_caps_for_mode(fmode); |
| 533 | 534 | ||
| 534 | retry: | 535 | retry: |
| 535 | spin_lock(&inode->i_lock); | 536 | spin_lock(&ci->i_ceph_lock); |
| 536 | cap = __get_cap_for_mds(ci, mds); | 537 | cap = __get_cap_for_mds(ci, mds); |
| 537 | if (!cap) { | 538 | if (!cap) { |
| 538 | if (new_cap) { | 539 | if (new_cap) { |
| 539 | cap = new_cap; | 540 | cap = new_cap; |
| 540 | new_cap = NULL; | 541 | new_cap = NULL; |
| 541 | } else { | 542 | } else { |
| 542 | spin_unlock(&inode->i_lock); | 543 | spin_unlock(&ci->i_ceph_lock); |
| 543 | new_cap = get_cap(mdsc, caps_reservation); | 544 | new_cap = get_cap(mdsc, caps_reservation); |
| 544 | if (new_cap == NULL) | 545 | if (new_cap == NULL) |
| 545 | return -ENOMEM; | 546 | return -ENOMEM; |
| @@ -625,7 +626,7 @@ retry: | |||
| 625 | 626 | ||
| 626 | if (fmode >= 0) | 627 | if (fmode >= 0) |
| 627 | __ceph_get_fmode(ci, fmode); | 628 | __ceph_get_fmode(ci, fmode); |
| 628 | spin_unlock(&inode->i_lock); | 629 | spin_unlock(&ci->i_ceph_lock); |
| 629 | wake_up_all(&ci->i_cap_wq); | 630 | wake_up_all(&ci->i_cap_wq); |
| 630 | return 0; | 631 | return 0; |
| 631 | } | 632 | } |
| @@ -792,7 +793,7 @@ int ceph_caps_revoking(struct ceph_inode_info *ci, int mask) | |||
| 792 | struct rb_node *p; | 793 | struct rb_node *p; |
| 793 | int ret = 0; | 794 | int ret = 0; |
| 794 | 795 | ||
| 795 | spin_lock(&inode->i_lock); | 796 | spin_lock(&ci->i_ceph_lock); |
| 796 | for (p = rb_first(&ci->i_caps); p; p = rb_next(p)) { | 797 | for (p = rb_first(&ci->i_caps); p; p = rb_next(p)) { |
| 797 | cap = rb_entry(p, struct ceph_cap, ci_node); | 798 | cap = rb_entry(p, struct ceph_cap, ci_node); |
| 798 | if (__cap_is_valid(cap) && | 799 | if (__cap_is_valid(cap) && |
| @@ -801,7 +802,7 @@ int ceph_caps_revoking(struct ceph_inode_info *ci, int mask) | |||
| 801 | break; | 802 | break; |
| 802 | } | 803 | } |
| 803 | } | 804 | } |
| 804 | spin_unlock(&inode->i_lock); | 805 | spin_unlock(&ci->i_ceph_lock); |
| 805 | dout("ceph_caps_revoking %p %s = %d\n", inode, | 806 | dout("ceph_caps_revoking %p %s = %d\n", inode, |
| 806 | ceph_cap_string(mask), ret); | 807 | ceph_cap_string(mask), ret); |
| 807 | return ret; | 808 | return ret; |
| @@ -855,7 +856,7 @@ int __ceph_caps_mds_wanted(struct ceph_inode_info *ci) | |||
| 855 | } | 856 | } |
| 856 | 857 | ||
| 857 | /* | 858 | /* |
| 858 | * called under i_lock | 859 | * called under i_ceph_lock |
| 859 | */ | 860 | */ |
| 860 | static int __ceph_is_any_caps(struct ceph_inode_info *ci) | 861 | static int __ceph_is_any_caps(struct ceph_inode_info *ci) |
| 861 | { | 862 | { |
| @@ -865,7 +866,7 @@ static int __ceph_is_any_caps(struct ceph_inode_info *ci) | |||
| 865 | /* | 866 | /* |
| 866 | * Remove a cap. Take steps to deal with a racing iterate_session_caps. | 867 | * Remove a cap. Take steps to deal with a racing iterate_session_caps. |
| 867 | * | 868 | * |
| 868 | * caller should hold i_lock. | 869 | * caller should hold i_ceph_lock. |
| 869 | * caller will not hold session s_mutex if called from destroy_inode. | 870 | * caller will not hold session s_mutex if called from destroy_inode. |
| 870 | */ | 871 | */ |
| 871 | void __ceph_remove_cap(struct ceph_cap *cap) | 872 | void __ceph_remove_cap(struct ceph_cap *cap) |
| @@ -1028,7 +1029,7 @@ static void __queue_cap_release(struct ceph_mds_session *session, | |||
| 1028 | 1029 | ||
| 1029 | /* | 1030 | /* |
| 1030 | * Queue cap releases when an inode is dropped from our cache. Since | 1031 | * Queue cap releases when an inode is dropped from our cache. Since |
| 1031 | * inode is about to be destroyed, there is no need for i_lock. | 1032 | * inode is about to be destroyed, there is no need for i_ceph_lock. |
| 1032 | */ | 1033 | */ |
| 1033 | void ceph_queue_caps_release(struct inode *inode) | 1034 | void ceph_queue_caps_release(struct inode *inode) |
| 1034 | { | 1035 | { |
| @@ -1049,7 +1050,7 @@ void ceph_queue_caps_release(struct inode *inode) | |||
| 1049 | 1050 | ||
| 1050 | /* | 1051 | /* |
| 1051 | * Send a cap msg on the given inode. Update our caps state, then | 1052 | * Send a cap msg on the given inode. Update our caps state, then |
| 1052 | * drop i_lock and send the message. | 1053 | * drop i_ceph_lock and send the message. |
| 1053 | * | 1054 | * |
| 1054 | * Make note of max_size reported/requested from mds, revoked caps | 1055 | * Make note of max_size reported/requested from mds, revoked caps |
| 1055 | * that have now been implemented. | 1056 | * that have now been implemented. |
| @@ -1061,13 +1062,13 @@ void ceph_queue_caps_release(struct inode *inode) | |||
| 1061 | * Return non-zero if delayed release, or we experienced an error | 1062 | * Return non-zero if delayed release, or we experienced an error |
| 1062 | * such that the caller should requeue + retry later. | 1063 | * such that the caller should requeue + retry later. |
| 1063 | * | 1064 | * |
| 1064 | * called with i_lock, then drops it. | 1065 | * called with i_ceph_lock, then drops it. |
| 1065 | * caller should hold snap_rwsem (read), s_mutex. | 1066 | * caller should hold snap_rwsem (read), s_mutex. |
| 1066 | */ | 1067 | */ |
| 1067 | static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap, | 1068 | static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap, |
| 1068 | int op, int used, int want, int retain, int flushing, | 1069 | int op, int used, int want, int retain, int flushing, |
| 1069 | unsigned *pflush_tid) | 1070 | unsigned *pflush_tid) |
| 1070 | __releases(cap->ci->vfs_inode->i_lock) | 1071 | __releases(cap->ci->i_ceph_lock) |
| 1071 | { | 1072 | { |
| 1072 | struct ceph_inode_info *ci = cap->ci; | 1073 | struct ceph_inode_info *ci = cap->ci; |
| 1073 | struct inode *inode = &ci->vfs_inode; | 1074 | struct inode *inode = &ci->vfs_inode; |
| @@ -1170,7 +1171,7 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap, | |||
| 1170 | xattr_version = ci->i_xattrs.version; | 1171 | xattr_version = ci->i_xattrs.version; |
| 1171 | } | 1172 | } |
| 1172 | 1173 | ||
| 1173 | spin_unlock(&inode->i_lock); | 1174 | spin_unlock(&ci->i_ceph_lock); |
| 1174 | 1175 | ||
| 1175 | ret = send_cap_msg(session, ceph_vino(inode).ino, cap_id, | 1176 | ret = send_cap_msg(session, ceph_vino(inode).ino, cap_id, |
| 1176 | op, keep, want, flushing, seq, flush_tid, issue_seq, mseq, | 1177 | op, keep, want, flushing, seq, flush_tid, issue_seq, mseq, |
| @@ -1198,13 +1199,13 @@ static int __send_cap(struct ceph_mds_client *mdsc, struct ceph_cap *cap, | |||
| 1198 | * Unless @again is true, skip cap_snaps that were already sent to | 1199 | * Unless @again is true, skip cap_snaps that were already sent to |
| 1199 | * the MDS (i.e., during this session). | 1200 | * the MDS (i.e., during this session). |
| 1200 | * | 1201 | * |
| 1201 | * Called under i_lock. Takes s_mutex as needed. | 1202 | * Called under i_ceph_lock. Takes s_mutex as needed. |
| 1202 | */ | 1203 | */ |
| 1203 | void __ceph_flush_snaps(struct ceph_inode_info *ci, | 1204 | void __ceph_flush_snaps(struct ceph_inode_info *ci, |
| 1204 | struct ceph_mds_session **psession, | 1205 | struct ceph_mds_session **psession, |
| 1205 | int again) | 1206 | int again) |
| 1206 | __releases(ci->vfs_inode->i_lock) | 1207 | __releases(ci->i_ceph_lock) |
| 1207 | __acquires(ci->vfs_inode->i_lock) | 1208 | __acquires(ci->i_ceph_lock) |
| 1208 | { | 1209 | { |
| 1209 | struct inode *inode = &ci->vfs_inode; | 1210 | struct inode *inode = &ci->vfs_inode; |
| 1210 | int mds; | 1211 | int mds; |
| @@ -1261,7 +1262,7 @@ retry: | |||
| 1261 | session = NULL; | 1262 | session = NULL; |
| 1262 | } | 1263 | } |
| 1263 | if (!session) { | 1264 | if (!session) { |
| 1264 | spin_unlock(&inode->i_lock); | 1265 | spin_unlock(&ci->i_ceph_lock); |
| 1265 | mutex_lock(&mdsc->mutex); | 1266 | mutex_lock(&mdsc->mutex); |
| 1266 | session = __ceph_lookup_mds_session(mdsc, mds); | 1267 | session = __ceph_lookup_mds_session(mdsc, mds); |
| 1267 | mutex_unlock(&mdsc->mutex); | 1268 | mutex_unlock(&mdsc->mutex); |
| @@ -1275,7 +1276,7 @@ retry: | |||
| 1275 | * deletion or migration. retry, and we'll | 1276 | * deletion or migration. retry, and we'll |
| 1276 | * get a better @mds value next time. | 1277 | * get a better @mds value next time. |
| 1277 | */ | 1278 | */ |
| 1278 | spin_lock(&inode->i_lock); | 1279 | spin_lock(&ci->i_ceph_lock); |
| 1279 | goto retry; | 1280 | goto retry; |
| 1280 | } | 1281 | } |
| 1281 | 1282 | ||
| @@ -1285,7 +1286,7 @@ retry: | |||
| 1285 | list_del_init(&capsnap->flushing_item); | 1286 | list_del_init(&capsnap->flushing_item); |
| 1286 | list_add_tail(&capsnap->flushing_item, | 1287 | list_add_tail(&capsnap->flushing_item, |
| 1287 | &session->s_cap_snaps_flushing); | 1288 | &session->s_cap_snaps_flushing); |
| 1288 | spin_unlock(&inode->i_lock); | 1289 | spin_unlock(&ci->i_ceph_lock); |
| 1289 | 1290 | ||
| 1290 | dout("flush_snaps %p cap_snap %p follows %lld tid %llu\n", | 1291 | dout("flush_snaps %p cap_snap %p follows %lld tid %llu\n", |
| 1291 | inode, capsnap, capsnap->follows, capsnap->flush_tid); | 1292 | inode, capsnap, capsnap->follows, capsnap->flush_tid); |
| @@ -1302,7 +1303,7 @@ retry: | |||
| 1302 | next_follows = capsnap->follows + 1; | 1303 | next_follows = capsnap->follows + 1; |
| 1303 | ceph_put_cap_snap(capsnap); | 1304 | ceph_put_cap_snap(capsnap); |
| 1304 | 1305 | ||
| 1305 | spin_lock(&inode->i_lock); | 1306 | spin_lock(&ci->i_ceph_lock); |
| 1306 | goto retry; | 1307 | goto retry; |
| 1307 | } | 1308 | } |
| 1308 | 1309 | ||
| @@ -1322,11 +1323,9 @@ out: | |||
| 1322 | 1323 | ||
| 1323 | static void ceph_flush_snaps(struct ceph_inode_info *ci) | 1324 | static void ceph_flush_snaps(struct ceph_inode_info *ci) |
| 1324 | { | 1325 | { |
| 1325 | struct inode *inode = &ci->vfs_inode; | 1326 | spin_lock(&ci->i_ceph_lock); |
| 1326 | |||
| 1327 | spin_lock(&inode->i_lock); | ||
| 1328 | __ceph_flush_snaps(ci, NULL, 0); | 1327 | __ceph_flush_snaps(ci, NULL, 0); |
| 1329 | spin_unlock(&inode->i_lock); | 1328 | spin_unlock(&ci->i_ceph_lock); |
| 1330 | } | 1329 | } |
| 1331 | 1330 | ||
| 1332 | /* | 1331 | /* |
| @@ -1373,7 +1372,7 @@ int __ceph_mark_dirty_caps(struct ceph_inode_info *ci, int mask) | |||
| 1373 | * Add dirty inode to the flushing list. Assigned a seq number so we | 1372 | * Add dirty inode to the flushing list. Assigned a seq number so we |
| 1374 | * can wait for caps to flush without starving. | 1373 | * can wait for caps to flush without starving. |
| 1375 | * | 1374 | * |
| 1376 | * Called under i_lock. | 1375 | * Called under i_ceph_lock. |
| 1377 | */ | 1376 | */ |
| 1378 | static int __mark_caps_flushing(struct inode *inode, | 1377 | static int __mark_caps_flushing(struct inode *inode, |
| 1379 | struct ceph_mds_session *session) | 1378 | struct ceph_mds_session *session) |
| @@ -1421,9 +1420,9 @@ static int try_nonblocking_invalidate(struct inode *inode) | |||
| 1421 | struct ceph_inode_info *ci = ceph_inode(inode); | 1420 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 1422 | u32 invalidating_gen = ci->i_rdcache_gen; | 1421 | u32 invalidating_gen = ci->i_rdcache_gen; |
| 1423 | 1422 | ||
| 1424 | spin_unlock(&inode->i_lock); | 1423 | spin_unlock(&ci->i_ceph_lock); |
| 1425 | invalidate_mapping_pages(&inode->i_data, 0, -1); | 1424 | invalidate_mapping_pages(&inode->i_data, 0, -1); |
| 1426 | spin_lock(&inode->i_lock); | 1425 | spin_lock(&ci->i_ceph_lock); |
| 1427 | 1426 | ||
| 1428 | if (inode->i_data.nrpages == 0 && | 1427 | if (inode->i_data.nrpages == 0 && |
| 1429 | invalidating_gen == ci->i_rdcache_gen) { | 1428 | invalidating_gen == ci->i_rdcache_gen) { |
| @@ -1470,7 +1469,7 @@ void ceph_check_caps(struct ceph_inode_info *ci, int flags, | |||
| 1470 | if (mdsc->stopping) | 1469 | if (mdsc->stopping) |
| 1471 | is_delayed = 1; | 1470 | is_delayed = 1; |
| 1472 | 1471 | ||
| 1473 | spin_lock(&inode->i_lock); | 1472 | spin_lock(&ci->i_ceph_lock); |
| 1474 | 1473 | ||
| 1475 | if (ci->i_ceph_flags & CEPH_I_FLUSH) | 1474 | if (ci->i_ceph_flags & CEPH_I_FLUSH) |
| 1476 | flags |= CHECK_CAPS_FLUSH; | 1475 | flags |= CHECK_CAPS_FLUSH; |
| @@ -1480,7 +1479,7 @@ void ceph_check_caps(struct ceph_inode_info *ci, int flags, | |||
| 1480 | __ceph_flush_snaps(ci, &session, 0); | 1479 | __ceph_flush_snaps(ci, &session, 0); |
| 1481 | goto retry_locked; | 1480 | goto retry_locked; |
| 1482 | retry: | 1481 | retry: |
| 1483 | spin_lock(&inode->i_lock); | 1482 | spin_lock(&ci->i_ceph_lock); |
| 1484 | retry_locked: | 1483 | retry_locked: |
| 1485 | file_wanted = __ceph_caps_file_wanted(ci); | 1484 | file_wanted = __ceph_caps_file_wanted(ci); |
| 1486 | used = __ceph_caps_used(ci); | 1485 | used = __ceph_caps_used(ci); |
| @@ -1634,7 +1633,7 @@ ack: | |||
| 1634 | if (mutex_trylock(&session->s_mutex) == 0) { | 1633 | if (mutex_trylock(&session->s_mutex) == 0) { |
| 1635 | dout("inverting session/ino locks on %p\n", | 1634 | dout("inverting session/ino locks on %p\n", |
| 1636 | session); | 1635 | session); |
| 1637 | spin_unlock(&inode->i_lock); | 1636 | spin_unlock(&ci->i_ceph_lock); |
| 1638 | if (took_snap_rwsem) { | 1637 | if (took_snap_rwsem) { |
| 1639 | up_read(&mdsc->snap_rwsem); | 1638 | up_read(&mdsc->snap_rwsem); |
| 1640 | took_snap_rwsem = 0; | 1639 | took_snap_rwsem = 0; |
| @@ -1648,7 +1647,7 @@ ack: | |||
| 1648 | if (down_read_trylock(&mdsc->snap_rwsem) == 0) { | 1647 | if (down_read_trylock(&mdsc->snap_rwsem) == 0) { |
| 1649 | dout("inverting snap/in locks on %p\n", | 1648 | dout("inverting snap/in locks on %p\n", |
| 1650 | inode); | 1649 | inode); |
| 1651 | spin_unlock(&inode->i_lock); | 1650 | spin_unlock(&ci->i_ceph_lock); |
| 1652 | down_read(&mdsc->snap_rwsem); | 1651 | down_read(&mdsc->snap_rwsem); |
| 1653 | took_snap_rwsem = 1; | 1652 | took_snap_rwsem = 1; |
| 1654 | goto retry; | 1653 | goto retry; |
| @@ -1664,10 +1663,10 @@ ack: | |||
| 1664 | mds = cap->mds; /* remember mds, so we don't repeat */ | 1663 | mds = cap->mds; /* remember mds, so we don't repeat */ |
| 1665 | sent++; | 1664 | sent++; |
| 1666 | 1665 | ||
| 1667 | /* __send_cap drops i_lock */ | 1666 | /* __send_cap drops i_ceph_lock */ |
| 1668 | delayed += __send_cap(mdsc, cap, CEPH_CAP_OP_UPDATE, used, want, | 1667 | delayed += __send_cap(mdsc, cap, CEPH_CAP_OP_UPDATE, used, want, |
| 1669 | retain, flushing, NULL); | 1668 | retain, flushing, NULL); |
| 1670 | goto retry; /* retake i_lock and restart our cap scan. */ | 1669 | goto retry; /* retake i_ceph_lock and restart our cap scan. */ |
| 1671 | } | 1670 | } |
| 1672 | 1671 | ||
| 1673 | /* | 1672 | /* |
| @@ -1681,7 +1680,7 @@ ack: | |||
| 1681 | else if (!is_delayed || force_requeue) | 1680 | else if (!is_delayed || force_requeue) |
| 1682 | __cap_delay_requeue(mdsc, ci); | 1681 | __cap_delay_requeue(mdsc, ci); |
| 1683 | 1682 | ||
| 1684 | spin_unlock(&inode->i_lock); | 1683 | spin_unlock(&ci->i_ceph_lock); |
| 1685 | 1684 | ||
| 1686 | if (queue_invalidate) | 1685 | if (queue_invalidate) |
| 1687 | ceph_queue_invalidate(inode); | 1686 | ceph_queue_invalidate(inode); |
| @@ -1704,7 +1703,7 @@ static int try_flush_caps(struct inode *inode, struct ceph_mds_session *session, | |||
| 1704 | int flushing = 0; | 1703 | int flushing = 0; |
| 1705 | 1704 | ||
| 1706 | retry: | 1705 | retry: |
| 1707 | spin_lock(&inode->i_lock); | 1706 | spin_lock(&ci->i_ceph_lock); |
| 1708 | if (ci->i_ceph_flags & CEPH_I_NOFLUSH) { | 1707 | if (ci->i_ceph_flags & CEPH_I_NOFLUSH) { |
| 1709 | dout("try_flush_caps skipping %p I_NOFLUSH set\n", inode); | 1708 | dout("try_flush_caps skipping %p I_NOFLUSH set\n", inode); |
| 1710 | goto out; | 1709 | goto out; |
| @@ -1716,7 +1715,7 @@ retry: | |||
| 1716 | int delayed; | 1715 | int delayed; |
| 1717 | 1716 | ||
| 1718 | if (!session) { | 1717 | if (!session) { |
| 1719 | spin_unlock(&inode->i_lock); | 1718 | spin_unlock(&ci->i_ceph_lock); |
| 1720 | session = cap->session; | 1719 | session = cap->session; |
| 1721 | mutex_lock(&session->s_mutex); | 1720 | mutex_lock(&session->s_mutex); |
| 1722 | goto retry; | 1721 | goto retry; |
| @@ -1727,18 +1726,18 @@ retry: | |||
| 1727 | 1726 | ||
| 1728 | flushing = __mark_caps_flushing(inode, session); | 1727 | flushing = __mark_caps_flushing(inode, session); |
| 1729 | 1728 | ||
| 1730 | /* __send_cap drops i_lock */ | 1729 | /* __send_cap drops i_ceph_lock */ |
| 1731 | delayed = __send_cap(mdsc, cap, CEPH_CAP_OP_FLUSH, used, want, | 1730 | delayed = __send_cap(mdsc, cap, CEPH_CAP_OP_FLUSH, used, want, |
| 1732 | cap->issued | cap->implemented, flushing, | 1731 | cap->issued | cap->implemented, flushing, |
| 1733 | flush_tid); | 1732 | flush_tid); |
| 1734 | if (!delayed) | 1733 | if (!delayed) |
| 1735 | goto out_unlocked; | 1734 | goto out_unlocked; |
| 1736 | 1735 | ||
| 1737 | spin_lock(&inode->i_lock); | 1736 | spin_lock(&ci->i_ceph_lock); |
| 1738 | __cap_delay_requeue(mdsc, ci); | 1737 | __cap_delay_requeue(mdsc, ci); |
| 1739 | } | 1738 | } |
| 1740 | out: | 1739 | out: |
| 1741 | spin_unlock(&inode->i_lock); | 1740 | spin_unlock(&ci->i_ceph_lock); |
| 1742 | out_unlocked: | 1741 | out_unlocked: |
| 1743 | if (session && unlock_session) | 1742 | if (session && unlock_session) |
| 1744 | mutex_unlock(&session->s_mutex); | 1743 | mutex_unlock(&session->s_mutex); |
| @@ -1753,7 +1752,7 @@ static int caps_are_flushed(struct inode *inode, unsigned tid) | |||
| 1753 | struct ceph_inode_info *ci = ceph_inode(inode); | 1752 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 1754 | int i, ret = 1; | 1753 | int i, ret = 1; |
| 1755 | 1754 | ||
| 1756 | spin_lock(&inode->i_lock); | 1755 | spin_lock(&ci->i_ceph_lock); |
| 1757 | for (i = 0; i < CEPH_CAP_BITS; i++) | 1756 | for (i = 0; i < CEPH_CAP_BITS; i++) |
| 1758 | if ((ci->i_flushing_caps & (1 << i)) && | 1757 | if ((ci->i_flushing_caps & (1 << i)) && |
| 1759 | ci->i_cap_flush_tid[i] <= tid) { | 1758 | ci->i_cap_flush_tid[i] <= tid) { |
| @@ -1761,7 +1760,7 @@ static int caps_are_flushed(struct inode *inode, unsigned tid) | |||
| 1761 | ret = 0; | 1760 | ret = 0; |
| 1762 | break; | 1761 | break; |
| 1763 | } | 1762 | } |
| 1764 | spin_unlock(&inode->i_lock); | 1763 | spin_unlock(&ci->i_ceph_lock); |
| 1765 | return ret; | 1764 | return ret; |
| 1766 | } | 1765 | } |
| 1767 | 1766 | ||
| @@ -1868,10 +1867,10 @@ int ceph_write_inode(struct inode *inode, struct writeback_control *wbc) | |||
| 1868 | struct ceph_mds_client *mdsc = | 1867 | struct ceph_mds_client *mdsc = |
| 1869 | ceph_sb_to_client(inode->i_sb)->mdsc; | 1868 | ceph_sb_to_client(inode->i_sb)->mdsc; |
| 1870 | 1869 | ||
| 1871 | spin_lock(&inode->i_lock); | 1870 | spin_lock(&ci->i_ceph_lock); |
| 1872 | if (__ceph_caps_dirty(ci)) | 1871 | if (__ceph_caps_dirty(ci)) |
| 1873 | __cap_delay_requeue_front(mdsc, ci); | 1872 | __cap_delay_requeue_front(mdsc, ci); |
| 1874 | spin_unlock(&inode->i_lock); | 1873 | spin_unlock(&ci->i_ceph_lock); |
| 1875 | } | 1874 | } |
| 1876 | return err; | 1875 | return err; |
| 1877 | } | 1876 | } |
| @@ -1894,7 +1893,7 @@ static void kick_flushing_capsnaps(struct ceph_mds_client *mdsc, | |||
| 1894 | struct inode *inode = &ci->vfs_inode; | 1893 | struct inode *inode = &ci->vfs_inode; |
| 1895 | struct ceph_cap *cap; | 1894 | struct ceph_cap *cap; |
| 1896 | 1895 | ||
| 1897 | spin_lock(&inode->i_lock); | 1896 | spin_lock(&ci->i_ceph_lock); |
| 1898 | cap = ci->i_auth_cap; | 1897 | cap = ci->i_auth_cap; |
| 1899 | if (cap && cap->session == session) { | 1898 | if (cap && cap->session == session) { |
| 1900 | dout("kick_flushing_caps %p cap %p capsnap %p\n", inode, | 1899 | dout("kick_flushing_caps %p cap %p capsnap %p\n", inode, |
| @@ -1904,7 +1903,7 @@ static void kick_flushing_capsnaps(struct ceph_mds_client *mdsc, | |||
| 1904 | pr_err("%p auth cap %p not mds%d ???\n", inode, | 1903 | pr_err("%p auth cap %p not mds%d ???\n", inode, |
| 1905 | cap, session->s_mds); | 1904 | cap, session->s_mds); |
| 1906 | } | 1905 | } |
| 1907 | spin_unlock(&inode->i_lock); | 1906 | spin_unlock(&ci->i_ceph_lock); |
| 1908 | } | 1907 | } |
| 1909 | } | 1908 | } |
| 1910 | 1909 | ||
| @@ -1921,7 +1920,7 @@ void ceph_kick_flushing_caps(struct ceph_mds_client *mdsc, | |||
| 1921 | struct ceph_cap *cap; | 1920 | struct ceph_cap *cap; |
| 1922 | int delayed = 0; | 1921 | int delayed = 0; |
| 1923 | 1922 | ||
| 1924 | spin_lock(&inode->i_lock); | 1923 | spin_lock(&ci->i_ceph_lock); |
| 1925 | cap = ci->i_auth_cap; | 1924 | cap = ci->i_auth_cap; |
| 1926 | if (cap && cap->session == session) { | 1925 | if (cap && cap->session == session) { |
| 1927 | dout("kick_flushing_caps %p cap %p %s\n", inode, | 1926 | dout("kick_flushing_caps %p cap %p %s\n", inode, |
| @@ -1932,14 +1931,14 @@ void ceph_kick_flushing_caps(struct ceph_mds_client *mdsc, | |||
| 1932 | cap->issued | cap->implemented, | 1931 | cap->issued | cap->implemented, |
| 1933 | ci->i_flushing_caps, NULL); | 1932 | ci->i_flushing_caps, NULL); |
| 1934 | if (delayed) { | 1933 | if (delayed) { |
| 1935 | spin_lock(&inode->i_lock); | 1934 | spin_lock(&ci->i_ceph_lock); |
| 1936 | __cap_delay_requeue(mdsc, ci); | 1935 | __cap_delay_requeue(mdsc, ci); |
| 1937 | spin_unlock(&inode->i_lock); | 1936 | spin_unlock(&ci->i_ceph_lock); |
| 1938 | } | 1937 | } |
| 1939 | } else { | 1938 | } else { |
| 1940 | pr_err("%p auth cap %p not mds%d ???\n", inode, | 1939 | pr_err("%p auth cap %p not mds%d ???\n", inode, |
| 1941 | cap, session->s_mds); | 1940 | cap, session->s_mds); |
| 1942 | spin_unlock(&inode->i_lock); | 1941 | spin_unlock(&ci->i_ceph_lock); |
| 1943 | } | 1942 | } |
| 1944 | } | 1943 | } |
| 1945 | } | 1944 | } |
| @@ -1952,7 +1951,7 @@ static void kick_flushing_inode_caps(struct ceph_mds_client *mdsc, | |||
| 1952 | struct ceph_cap *cap; | 1951 | struct ceph_cap *cap; |
| 1953 | int delayed = 0; | 1952 | int delayed = 0; |
| 1954 | 1953 | ||
| 1955 | spin_lock(&inode->i_lock); | 1954 | spin_lock(&ci->i_ceph_lock); |
| 1956 | cap = ci->i_auth_cap; | 1955 | cap = ci->i_auth_cap; |
| 1957 | dout("kick_flushing_inode_caps %p flushing %s flush_seq %lld\n", inode, | 1956 | dout("kick_flushing_inode_caps %p flushing %s flush_seq %lld\n", inode, |
| 1958 | ceph_cap_string(ci->i_flushing_caps), ci->i_cap_flush_seq); | 1957 | ceph_cap_string(ci->i_flushing_caps), ci->i_cap_flush_seq); |
| @@ -1964,12 +1963,12 @@ static void kick_flushing_inode_caps(struct ceph_mds_client *mdsc, | |||
| 1964 | cap->issued | cap->implemented, | 1963 | cap->issued | cap->implemented, |
| 1965 | ci->i_flushing_caps, NULL); | 1964 | ci->i_flushing_caps, NULL); |
| 1966 | if (delayed) { | 1965 | if (delayed) { |
| 1967 | spin_lock(&inode->i_lock); | 1966 | spin_lock(&ci->i_ceph_lock); |
| 1968 | __cap_delay_requeue(mdsc, ci); | 1967 | __cap_delay_requeue(mdsc, ci); |
| 1969 | spin_unlock(&inode->i_lock); | 1968 | spin_unlock(&ci->i_ceph_lock); |
| 1970 | } | 1969 | } |
| 1971 | } else { | 1970 | } else { |
| 1972 | spin_unlock(&inode->i_lock); | 1971 | spin_unlock(&ci->i_ceph_lock); |
| 1973 | } | 1972 | } |
| 1974 | } | 1973 | } |
| 1975 | 1974 | ||
| @@ -1978,7 +1977,7 @@ static void kick_flushing_inode_caps(struct ceph_mds_client *mdsc, | |||
| 1978 | * Take references to capabilities we hold, so that we don't release | 1977 | * Take references to capabilities we hold, so that we don't release |
| 1979 | * them to the MDS prematurely. | 1978 | * them to the MDS prematurely. |
| 1980 | * | 1979 | * |
| 1981 | * Protected by i_lock. | 1980 | * Protected by i_ceph_lock. |
| 1982 | */ | 1981 | */ |
| 1983 | static void __take_cap_refs(struct ceph_inode_info *ci, int got) | 1982 | static void __take_cap_refs(struct ceph_inode_info *ci, int got) |
| 1984 | { | 1983 | { |
| @@ -2016,7 +2015,7 @@ static int try_get_cap_refs(struct ceph_inode_info *ci, int need, int want, | |||
| 2016 | 2015 | ||
| 2017 | dout("get_cap_refs %p need %s want %s\n", inode, | 2016 | dout("get_cap_refs %p need %s want %s\n", inode, |
| 2018 | ceph_cap_string(need), ceph_cap_string(want)); | 2017 | ceph_cap_string(need), ceph_cap_string(want)); |
| 2019 | spin_lock(&inode->i_lock); | 2018 | spin_lock(&ci->i_ceph_lock); |
| 2020 | 2019 | ||
| 2021 | /* make sure file is actually open */ | 2020 | /* make sure file is actually open */ |
| 2022 | file_wanted = __ceph_caps_file_wanted(ci); | 2021 | file_wanted = __ceph_caps_file_wanted(ci); |
| @@ -2077,7 +2076,7 @@ static int try_get_cap_refs(struct ceph_inode_info *ci, int need, int want, | |||
| 2077 | ceph_cap_string(have), ceph_cap_string(need)); | 2076 | ceph_cap_string(have), ceph_cap_string(need)); |
| 2078 | } | 2077 | } |
| 2079 | out: | 2078 | out: |
| 2080 | spin_unlock(&inode->i_lock); | 2079 | spin_unlock(&ci->i_ceph_lock); |
| 2081 | dout("get_cap_refs %p ret %d got %s\n", inode, | 2080 | dout("get_cap_refs %p ret %d got %s\n", inode, |
| 2082 | ret, ceph_cap_string(*got)); | 2081 | ret, ceph_cap_string(*got)); |
| 2083 | return ret; | 2082 | return ret; |
| @@ -2094,7 +2093,7 @@ static void check_max_size(struct inode *inode, loff_t endoff) | |||
| 2094 | int check = 0; | 2093 | int check = 0; |
| 2095 | 2094 | ||
| 2096 | /* do we need to explicitly request a larger max_size? */ | 2095 | /* do we need to explicitly request a larger max_size? */ |
| 2097 | spin_lock(&inode->i_lock); | 2096 | spin_lock(&ci->i_ceph_lock); |
| 2098 | if ((endoff >= ci->i_max_size || | 2097 | if ((endoff >= ci->i_max_size || |
| 2099 | endoff > (inode->i_size << 1)) && | 2098 | endoff > (inode->i_size << 1)) && |
| 2100 | endoff > ci->i_wanted_max_size) { | 2099 | endoff > ci->i_wanted_max_size) { |
| @@ -2103,7 +2102,7 @@ static void check_max_size(struct inode *inode, loff_t endoff) | |||
| 2103 | ci->i_wanted_max_size = endoff; | 2102 | ci->i_wanted_max_size = endoff; |
| 2104 | check = 1; | 2103 | check = 1; |
| 2105 | } | 2104 | } |
| 2106 | spin_unlock(&inode->i_lock); | 2105 | spin_unlock(&ci->i_ceph_lock); |
| 2107 | if (check) | 2106 | if (check) |
| 2108 | ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); | 2107 | ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); |
| 2109 | } | 2108 | } |
| @@ -2140,9 +2139,9 @@ retry: | |||
| 2140 | */ | 2139 | */ |
| 2141 | void ceph_get_cap_refs(struct ceph_inode_info *ci, int caps) | 2140 | void ceph_get_cap_refs(struct ceph_inode_info *ci, int caps) |
| 2142 | { | 2141 | { |
| 2143 | spin_lock(&ci->vfs_inode.i_lock); | 2142 | spin_lock(&ci->i_ceph_lock); |
| 2144 | __take_cap_refs(ci, caps); | 2143 | __take_cap_refs(ci, caps); |
| 2145 | spin_unlock(&ci->vfs_inode.i_lock); | 2144 | spin_unlock(&ci->i_ceph_lock); |
| 2146 | } | 2145 | } |
| 2147 | 2146 | ||
| 2148 | /* | 2147 | /* |
| @@ -2160,7 +2159,7 @@ void ceph_put_cap_refs(struct ceph_inode_info *ci, int had) | |||
| 2160 | int last = 0, put = 0, flushsnaps = 0, wake = 0; | 2159 | int last = 0, put = 0, flushsnaps = 0, wake = 0; |
| 2161 | struct ceph_cap_snap *capsnap; | 2160 | struct ceph_cap_snap *capsnap; |
| 2162 | 2161 | ||
| 2163 | spin_lock(&inode->i_lock); | 2162 | spin_lock(&ci->i_ceph_lock); |
| 2164 | if (had & CEPH_CAP_PIN) | 2163 | if (had & CEPH_CAP_PIN) |
| 2165 | --ci->i_pin_ref; | 2164 | --ci->i_pin_ref; |
| 2166 | if (had & CEPH_CAP_FILE_RD) | 2165 | if (had & CEPH_CAP_FILE_RD) |
| @@ -2193,7 +2192,7 @@ void ceph_put_cap_refs(struct ceph_inode_info *ci, int had) | |||
| 2193 | } | 2192 | } |
| 2194 | } | 2193 | } |
| 2195 | } | 2194 | } |
| 2196 | spin_unlock(&inode->i_lock); | 2195 | spin_unlock(&ci->i_ceph_lock); |
| 2197 | 2196 | ||
| 2198 | dout("put_cap_refs %p had %s%s%s\n", inode, ceph_cap_string(had), | 2197 | dout("put_cap_refs %p had %s%s%s\n", inode, ceph_cap_string(had), |
| 2199 | last ? " last" : "", put ? " put" : ""); | 2198 | last ? " last" : "", put ? " put" : ""); |
| @@ -2225,7 +2224,7 @@ void ceph_put_wrbuffer_cap_refs(struct ceph_inode_info *ci, int nr, | |||
| 2225 | int found = 0; | 2224 | int found = 0; |
| 2226 | struct ceph_cap_snap *capsnap = NULL; | 2225 | struct ceph_cap_snap *capsnap = NULL; |
| 2227 | 2226 | ||
| 2228 | spin_lock(&inode->i_lock); | 2227 | spin_lock(&ci->i_ceph_lock); |
| 2229 | ci->i_wrbuffer_ref -= nr; | 2228 | ci->i_wrbuffer_ref -= nr; |
| 2230 | last = !ci->i_wrbuffer_ref; | 2229 | last = !ci->i_wrbuffer_ref; |
| 2231 | 2230 | ||
| @@ -2274,7 +2273,7 @@ void ceph_put_wrbuffer_cap_refs(struct ceph_inode_info *ci, int nr, | |||
| 2274 | } | 2273 | } |
| 2275 | } | 2274 | } |
| 2276 | 2275 | ||
| 2277 | spin_unlock(&inode->i_lock); | 2276 | spin_unlock(&ci->i_ceph_lock); |
| 2278 | 2277 | ||
| 2279 | if (last) { | 2278 | if (last) { |
| 2280 | ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); | 2279 | ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); |
| @@ -2291,7 +2290,7 @@ void ceph_put_wrbuffer_cap_refs(struct ceph_inode_info *ci, int nr, | |||
| 2291 | * Handle a cap GRANT message from the MDS. (Note that a GRANT may | 2290 | * Handle a cap GRANT message from the MDS. (Note that a GRANT may |
| 2292 | * actually be a revocation if it specifies a smaller cap set.) | 2291 | * actually be a revocation if it specifies a smaller cap set.) |
| 2293 | * | 2292 | * |
| 2294 | * caller holds s_mutex and i_lock, we drop both. | 2293 | * caller holds s_mutex and i_ceph_lock, we drop both. |
| 2295 | * | 2294 | * |
| 2296 | * return value: | 2295 | * return value: |
| 2297 | * 0 - ok | 2296 | * 0 - ok |
| @@ -2302,7 +2301,7 @@ static void handle_cap_grant(struct inode *inode, struct ceph_mds_caps *grant, | |||
| 2302 | struct ceph_mds_session *session, | 2301 | struct ceph_mds_session *session, |
| 2303 | struct ceph_cap *cap, | 2302 | struct ceph_cap *cap, |
| 2304 | struct ceph_buffer *xattr_buf) | 2303 | struct ceph_buffer *xattr_buf) |
| 2305 | __releases(inode->i_lock) | 2304 | __releases(ci->i_ceph_lock) |
| 2306 | { | 2305 | { |
| 2307 | struct ceph_inode_info *ci = ceph_inode(inode); | 2306 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 2308 | int mds = session->s_mds; | 2307 | int mds = session->s_mds; |
| @@ -2453,7 +2452,7 @@ static void handle_cap_grant(struct inode *inode, struct ceph_mds_caps *grant, | |||
| 2453 | } | 2452 | } |
| 2454 | BUG_ON(cap->issued & ~cap->implemented); | 2453 | BUG_ON(cap->issued & ~cap->implemented); |
| 2455 | 2454 | ||
| 2456 | spin_unlock(&inode->i_lock); | 2455 | spin_unlock(&ci->i_ceph_lock); |
| 2457 | if (writeback) | 2456 | if (writeback) |
| 2458 | /* | 2457 | /* |
| 2459 | * queue inode for writeback: we can't actually call | 2458 | * queue inode for writeback: we can't actually call |
| @@ -2483,7 +2482,7 @@ static void handle_cap_flush_ack(struct inode *inode, u64 flush_tid, | |||
| 2483 | struct ceph_mds_caps *m, | 2482 | struct ceph_mds_caps *m, |
| 2484 | struct ceph_mds_session *session, | 2483 | struct ceph_mds_session *session, |
| 2485 | struct ceph_cap *cap) | 2484 | struct ceph_cap *cap) |
| 2486 | __releases(inode->i_lock) | 2485 | __releases(ci->i_ceph_lock) |
| 2487 | { | 2486 | { |
| 2488 | struct ceph_inode_info *ci = ceph_inode(inode); | 2487 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 2489 | struct ceph_mds_client *mdsc = ceph_sb_to_client(inode->i_sb)->mdsc; | 2488 | struct ceph_mds_client *mdsc = ceph_sb_to_client(inode->i_sb)->mdsc; |
| @@ -2539,7 +2538,7 @@ static void handle_cap_flush_ack(struct inode *inode, u64 flush_tid, | |||
| 2539 | wake_up_all(&ci->i_cap_wq); | 2538 | wake_up_all(&ci->i_cap_wq); |
| 2540 | 2539 | ||
| 2541 | out: | 2540 | out: |
| 2542 | spin_unlock(&inode->i_lock); | 2541 | spin_unlock(&ci->i_ceph_lock); |
| 2543 | if (drop) | 2542 | if (drop) |
| 2544 | iput(inode); | 2543 | iput(inode); |
| 2545 | } | 2544 | } |
| @@ -2562,7 +2561,7 @@ static void handle_cap_flushsnap_ack(struct inode *inode, u64 flush_tid, | |||
| 2562 | dout("handle_cap_flushsnap_ack inode %p ci %p mds%d follows %lld\n", | 2561 | dout("handle_cap_flushsnap_ack inode %p ci %p mds%d follows %lld\n", |
| 2563 | inode, ci, session->s_mds, follows); | 2562 | inode, ci, session->s_mds, follows); |
| 2564 | 2563 | ||
| 2565 | spin_lock(&inode->i_lock); | 2564 | spin_lock(&ci->i_ceph_lock); |
| 2566 | list_for_each_entry(capsnap, &ci->i_cap_snaps, ci_item) { | 2565 | list_for_each_entry(capsnap, &ci->i_cap_snaps, ci_item) { |
| 2567 | if (capsnap->follows == follows) { | 2566 | if (capsnap->follows == follows) { |
| 2568 | if (capsnap->flush_tid != flush_tid) { | 2567 | if (capsnap->flush_tid != flush_tid) { |
| @@ -2585,7 +2584,7 @@ static void handle_cap_flushsnap_ack(struct inode *inode, u64 flush_tid, | |||
| 2585 | capsnap, capsnap->follows); | 2584 | capsnap, capsnap->follows); |
| 2586 | } | 2585 | } |
| 2587 | } | 2586 | } |
| 2588 | spin_unlock(&inode->i_lock); | 2587 | spin_unlock(&ci->i_ceph_lock); |
| 2589 | if (drop) | 2588 | if (drop) |
| 2590 | iput(inode); | 2589 | iput(inode); |
| 2591 | } | 2590 | } |
| @@ -2598,7 +2597,7 @@ static void handle_cap_flushsnap_ack(struct inode *inode, u64 flush_tid, | |||
| 2598 | static void handle_cap_trunc(struct inode *inode, | 2597 | static void handle_cap_trunc(struct inode *inode, |
| 2599 | struct ceph_mds_caps *trunc, | 2598 | struct ceph_mds_caps *trunc, |
| 2600 | struct ceph_mds_session *session) | 2599 | struct ceph_mds_session *session) |
| 2601 | __releases(inode->i_lock) | 2600 | __releases(ci->i_ceph_lock) |
| 2602 | { | 2601 | { |
| 2603 | struct ceph_inode_info *ci = ceph_inode(inode); | 2602 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 2604 | int mds = session->s_mds; | 2603 | int mds = session->s_mds; |
| @@ -2617,7 +2616,7 @@ static void handle_cap_trunc(struct inode *inode, | |||
| 2617 | inode, mds, seq, truncate_size, truncate_seq); | 2616 | inode, mds, seq, truncate_size, truncate_seq); |
| 2618 | queue_trunc = ceph_fill_file_size(inode, issued, | 2617 | queue_trunc = ceph_fill_file_size(inode, issued, |
| 2619 | truncate_seq, truncate_size, size); | 2618 | truncate_seq, truncate_size, size); |
| 2620 | spin_unlock(&inode->i_lock); | 2619 | spin_unlock(&ci->i_ceph_lock); |
| 2621 | 2620 | ||
| 2622 | if (queue_trunc) | 2621 | if (queue_trunc) |
| 2623 | ceph_queue_vmtruncate(inode); | 2622 | ceph_queue_vmtruncate(inode); |
| @@ -2646,7 +2645,7 @@ static void handle_cap_export(struct inode *inode, struct ceph_mds_caps *ex, | |||
| 2646 | dout("handle_cap_export inode %p ci %p mds%d mseq %d\n", | 2645 | dout("handle_cap_export inode %p ci %p mds%d mseq %d\n", |
| 2647 | inode, ci, mds, mseq); | 2646 | inode, ci, mds, mseq); |
| 2648 | 2647 | ||
| 2649 | spin_lock(&inode->i_lock); | 2648 | spin_lock(&ci->i_ceph_lock); |
| 2650 | 2649 | ||
| 2651 | /* make sure we haven't seen a higher mseq */ | 2650 | /* make sure we haven't seen a higher mseq */ |
| 2652 | for (p = rb_first(&ci->i_caps); p; p = rb_next(p)) { | 2651 | for (p = rb_first(&ci->i_caps); p; p = rb_next(p)) { |
| @@ -2690,7 +2689,7 @@ static void handle_cap_export(struct inode *inode, struct ceph_mds_caps *ex, | |||
| 2690 | } | 2689 | } |
| 2691 | /* else, we already released it */ | 2690 | /* else, we already released it */ |
| 2692 | 2691 | ||
| 2693 | spin_unlock(&inode->i_lock); | 2692 | spin_unlock(&ci->i_ceph_lock); |
| 2694 | } | 2693 | } |
| 2695 | 2694 | ||
| 2696 | /* | 2695 | /* |
| @@ -2745,9 +2744,9 @@ static void handle_cap_import(struct ceph_mds_client *mdsc, | |||
| 2745 | up_read(&mdsc->snap_rwsem); | 2744 | up_read(&mdsc->snap_rwsem); |
| 2746 | 2745 | ||
| 2747 | /* make sure we re-request max_size, if necessary */ | 2746 | /* make sure we re-request max_size, if necessary */ |
| 2748 | spin_lock(&inode->i_lock); | 2747 | spin_lock(&ci->i_ceph_lock); |
| 2749 | ci->i_requested_max_size = 0; | 2748 | ci->i_requested_max_size = 0; |
| 2750 | spin_unlock(&inode->i_lock); | 2749 | spin_unlock(&ci->i_ceph_lock); |
| 2751 | } | 2750 | } |
| 2752 | 2751 | ||
| 2753 | /* | 2752 | /* |
| @@ -2762,6 +2761,7 @@ void ceph_handle_caps(struct ceph_mds_session *session, | |||
| 2762 | struct ceph_mds_client *mdsc = session->s_mdsc; | 2761 | struct ceph_mds_client *mdsc = session->s_mdsc; |
| 2763 | struct super_block *sb = mdsc->fsc->sb; | 2762 | struct super_block *sb = mdsc->fsc->sb; |
| 2764 | struct inode *inode; | 2763 | struct inode *inode; |
| 2764 | struct ceph_inode_info *ci; | ||
| 2765 | struct ceph_cap *cap; | 2765 | struct ceph_cap *cap; |
| 2766 | struct ceph_mds_caps *h; | 2766 | struct ceph_mds_caps *h; |
| 2767 | int mds = session->s_mds; | 2767 | int mds = session->s_mds; |
| @@ -2815,6 +2815,7 @@ void ceph_handle_caps(struct ceph_mds_session *session, | |||
| 2815 | 2815 | ||
| 2816 | /* lookup ino */ | 2816 | /* lookup ino */ |
| 2817 | inode = ceph_find_inode(sb, vino); | 2817 | inode = ceph_find_inode(sb, vino); |
| 2818 | ci = ceph_inode(inode); | ||
| 2818 | dout(" op %s ino %llx.%llx inode %p\n", ceph_cap_op_name(op), vino.ino, | 2819 | dout(" op %s ino %llx.%llx inode %p\n", ceph_cap_op_name(op), vino.ino, |
| 2819 | vino.snap, inode); | 2820 | vino.snap, inode); |
| 2820 | if (!inode) { | 2821 | if (!inode) { |
| @@ -2844,16 +2845,16 @@ void ceph_handle_caps(struct ceph_mds_session *session, | |||
| 2844 | } | 2845 | } |
| 2845 | 2846 | ||
| 2846 | /* the rest require a cap */ | 2847 | /* the rest require a cap */ |
| 2847 | spin_lock(&inode->i_lock); | 2848 | spin_lock(&ci->i_ceph_lock); |
| 2848 | cap = __get_cap_for_mds(ceph_inode(inode), mds); | 2849 | cap = __get_cap_for_mds(ceph_inode(inode), mds); |
| 2849 | if (!cap) { | 2850 | if (!cap) { |
| 2850 | dout(" no cap on %p ino %llx.%llx from mds%d\n", | 2851 | dout(" no cap on %p ino %llx.%llx from mds%d\n", |
| 2851 | inode, ceph_ino(inode), ceph_snap(inode), mds); | 2852 | inode, ceph_ino(inode), ceph_snap(inode), mds); |
| 2852 | spin_unlock(&inode->i_lock); | 2853 | spin_unlock(&ci->i_ceph_lock); |
| 2853 | goto flush_cap_releases; | 2854 | goto flush_cap_releases; |
| 2854 | } | 2855 | } |
| 2855 | 2856 | ||
| 2856 | /* note that each of these drops i_lock for us */ | 2857 | /* note that each of these drops i_ceph_lock for us */ |
| 2857 | switch (op) { | 2858 | switch (op) { |
| 2858 | case CEPH_CAP_OP_REVOKE: | 2859 | case CEPH_CAP_OP_REVOKE: |
| 2859 | case CEPH_CAP_OP_GRANT: | 2860 | case CEPH_CAP_OP_GRANT: |
| @@ -2869,7 +2870,7 @@ void ceph_handle_caps(struct ceph_mds_session *session, | |||
| 2869 | break; | 2870 | break; |
| 2870 | 2871 | ||
| 2871 | default: | 2872 | default: |
| 2872 | spin_unlock(&inode->i_lock); | 2873 | spin_unlock(&ci->i_ceph_lock); |
| 2873 | pr_err("ceph_handle_caps: unknown cap op %d %s\n", op, | 2874 | pr_err("ceph_handle_caps: unknown cap op %d %s\n", op, |
| 2874 | ceph_cap_op_name(op)); | 2875 | ceph_cap_op_name(op)); |
| 2875 | } | 2876 | } |
| @@ -2962,13 +2963,13 @@ void ceph_put_fmode(struct ceph_inode_info *ci, int fmode) | |||
| 2962 | struct inode *inode = &ci->vfs_inode; | 2963 | struct inode *inode = &ci->vfs_inode; |
| 2963 | int last = 0; | 2964 | int last = 0; |
| 2964 | 2965 | ||
| 2965 | spin_lock(&inode->i_lock); | 2966 | spin_lock(&ci->i_ceph_lock); |
| 2966 | dout("put_fmode %p fmode %d %d -> %d\n", inode, fmode, | 2967 | dout("put_fmode %p fmode %d %d -> %d\n", inode, fmode, |
| 2967 | ci->i_nr_by_mode[fmode], ci->i_nr_by_mode[fmode]-1); | 2968 | ci->i_nr_by_mode[fmode], ci->i_nr_by_mode[fmode]-1); |
| 2968 | BUG_ON(ci->i_nr_by_mode[fmode] == 0); | 2969 | BUG_ON(ci->i_nr_by_mode[fmode] == 0); |
| 2969 | if (--ci->i_nr_by_mode[fmode] == 0) | 2970 | if (--ci->i_nr_by_mode[fmode] == 0) |
| 2970 | last++; | 2971 | last++; |
| 2971 | spin_unlock(&inode->i_lock); | 2972 | spin_unlock(&ci->i_ceph_lock); |
| 2972 | 2973 | ||
| 2973 | if (last && ci->i_vino.snap == CEPH_NOSNAP) | 2974 | if (last && ci->i_vino.snap == CEPH_NOSNAP) |
| 2974 | ceph_check_caps(ci, 0, NULL); | 2975 | ceph_check_caps(ci, 0, NULL); |
| @@ -2991,7 +2992,7 @@ int ceph_encode_inode_release(void **p, struct inode *inode, | |||
| 2991 | int used, dirty; | 2992 | int used, dirty; |
| 2992 | int ret = 0; | 2993 | int ret = 0; |
| 2993 | 2994 | ||
| 2994 | spin_lock(&inode->i_lock); | 2995 | spin_lock(&ci->i_ceph_lock); |
| 2995 | used = __ceph_caps_used(ci); | 2996 | used = __ceph_caps_used(ci); |
| 2996 | dirty = __ceph_caps_dirty(ci); | 2997 | dirty = __ceph_caps_dirty(ci); |
| 2997 | 2998 | ||
| @@ -3046,7 +3047,7 @@ int ceph_encode_inode_release(void **p, struct inode *inode, | |||
| 3046 | inode, cap, ceph_cap_string(cap->issued)); | 3047 | inode, cap, ceph_cap_string(cap->issued)); |
| 3047 | } | 3048 | } |
| 3048 | } | 3049 | } |
| 3049 | spin_unlock(&inode->i_lock); | 3050 | spin_unlock(&ci->i_ceph_lock); |
| 3050 | return ret; | 3051 | return ret; |
| 3051 | } | 3052 | } |
| 3052 | 3053 | ||
| @@ -3061,7 +3062,7 @@ int ceph_encode_dentry_release(void **p, struct dentry *dentry, | |||
| 3061 | 3062 | ||
| 3062 | /* | 3063 | /* |
| 3063 | * force an record for the directory caps if we have a dentry lease. | 3064 | * force an record for the directory caps if we have a dentry lease. |
| 3064 | * this is racy (can't take i_lock and d_lock together), but it | 3065 | * this is racy (can't take i_ceph_lock and d_lock together), but it |
| 3065 | * doesn't have to be perfect; the mds will revoke anything we don't | 3066 | * doesn't have to be perfect; the mds will revoke anything we don't |
| 3066 | * release. | 3067 | * release. |
| 3067 | */ | 3068 | */ |
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index bca3948e9dbf..3eeb97661262 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c | |||
| @@ -281,18 +281,18 @@ static int ceph_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
| 281 | } | 281 | } |
| 282 | 282 | ||
| 283 | /* can we use the dcache? */ | 283 | /* can we use the dcache? */ |
| 284 | spin_lock(&inode->i_lock); | 284 | spin_lock(&ci->i_ceph_lock); |
| 285 | if ((filp->f_pos == 2 || fi->dentry) && | 285 | if ((filp->f_pos == 2 || fi->dentry) && |
| 286 | !ceph_test_mount_opt(fsc, NOASYNCREADDIR) && | 286 | !ceph_test_mount_opt(fsc, NOASYNCREADDIR) && |
| 287 | ceph_snap(inode) != CEPH_SNAPDIR && | 287 | ceph_snap(inode) != CEPH_SNAPDIR && |
| 288 | ceph_dir_test_complete(inode) && | 288 | ceph_dir_test_complete(inode) && |
| 289 | __ceph_caps_issued_mask(ci, CEPH_CAP_FILE_SHARED, 1)) { | 289 | __ceph_caps_issued_mask(ci, CEPH_CAP_FILE_SHARED, 1)) { |
| 290 | spin_unlock(&inode->i_lock); | 290 | spin_unlock(&ci->i_ceph_lock); |
| 291 | err = __dcache_readdir(filp, dirent, filldir); | 291 | err = __dcache_readdir(filp, dirent, filldir); |
| 292 | if (err != -EAGAIN) | 292 | if (err != -EAGAIN) |
| 293 | return err; | 293 | return err; |
| 294 | } else { | 294 | } else { |
| 295 | spin_unlock(&inode->i_lock); | 295 | spin_unlock(&ci->i_ceph_lock); |
| 296 | } | 296 | } |
| 297 | if (fi->dentry) { | 297 | if (fi->dentry) { |
| 298 | err = note_last_dentry(fi, fi->dentry->d_name.name, | 298 | err = note_last_dentry(fi, fi->dentry->d_name.name, |
| @@ -428,12 +428,12 @@ more: | |||
| 428 | * were released during the whole readdir, and we should have | 428 | * were released during the whole readdir, and we should have |
| 429 | * the complete dir contents in our cache. | 429 | * the complete dir contents in our cache. |
| 430 | */ | 430 | */ |
| 431 | spin_lock(&inode->i_lock); | 431 | spin_lock(&ci->i_ceph_lock); |
| 432 | if (ci->i_release_count == fi->dir_release_count) { | 432 | if (ci->i_release_count == fi->dir_release_count) { |
| 433 | ceph_dir_set_complete(inode); | 433 | ceph_dir_set_complete(inode); |
| 434 | ci->i_max_offset = filp->f_pos; | 434 | ci->i_max_offset = filp->f_pos; |
| 435 | } | 435 | } |
| 436 | spin_unlock(&inode->i_lock); | 436 | spin_unlock(&ci->i_ceph_lock); |
| 437 | 437 | ||
| 438 | dout("readdir %p filp %p done.\n", inode, filp); | 438 | dout("readdir %p filp %p done.\n", inode, filp); |
| 439 | return 0; | 439 | return 0; |
| @@ -607,7 +607,7 @@ static struct dentry *ceph_lookup(struct inode *dir, struct dentry *dentry, | |||
| 607 | struct ceph_inode_info *ci = ceph_inode(dir); | 607 | struct ceph_inode_info *ci = ceph_inode(dir); |
| 608 | struct ceph_dentry_info *di = ceph_dentry(dentry); | 608 | struct ceph_dentry_info *di = ceph_dentry(dentry); |
| 609 | 609 | ||
| 610 | spin_lock(&dir->i_lock); | 610 | spin_lock(&ci->i_ceph_lock); |
| 611 | dout(" dir %p flags are %d\n", dir, ci->i_ceph_flags); | 611 | dout(" dir %p flags are %d\n", dir, ci->i_ceph_flags); |
| 612 | if (strncmp(dentry->d_name.name, | 612 | if (strncmp(dentry->d_name.name, |
| 613 | fsc->mount_options->snapdir_name, | 613 | fsc->mount_options->snapdir_name, |
| @@ -615,13 +615,13 @@ static struct dentry *ceph_lookup(struct inode *dir, struct dentry *dentry, | |||
| 615 | !is_root_ceph_dentry(dir, dentry) && | 615 | !is_root_ceph_dentry(dir, dentry) && |
| 616 | ceph_dir_test_complete(dir) && | 616 | ceph_dir_test_complete(dir) && |
| 617 | (__ceph_caps_issued_mask(ci, CEPH_CAP_FILE_SHARED, 1))) { | 617 | (__ceph_caps_issued_mask(ci, CEPH_CAP_FILE_SHARED, 1))) { |
| 618 | spin_unlock(&dir->i_lock); | 618 | spin_unlock(&ci->i_ceph_lock); |
| 619 | dout(" dir %p complete, -ENOENT\n", dir); | 619 | dout(" dir %p complete, -ENOENT\n", dir); |
| 620 | d_add(dentry, NULL); | 620 | d_add(dentry, NULL); |
| 621 | di->lease_shared_gen = ci->i_shared_gen; | 621 | di->lease_shared_gen = ci->i_shared_gen; |
| 622 | return NULL; | 622 | return NULL; |
| 623 | } | 623 | } |
| 624 | spin_unlock(&dir->i_lock); | 624 | spin_unlock(&ci->i_ceph_lock); |
| 625 | } | 625 | } |
| 626 | 626 | ||
| 627 | op = ceph_snap(dir) == CEPH_SNAPDIR ? | 627 | op = ceph_snap(dir) == CEPH_SNAPDIR ? |
| @@ -841,12 +841,12 @@ static int drop_caps_for_unlink(struct inode *inode) | |||
| 841 | struct ceph_inode_info *ci = ceph_inode(inode); | 841 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 842 | int drop = CEPH_CAP_LINK_SHARED | CEPH_CAP_LINK_EXCL; | 842 | int drop = CEPH_CAP_LINK_SHARED | CEPH_CAP_LINK_EXCL; |
| 843 | 843 | ||
| 844 | spin_lock(&inode->i_lock); | 844 | spin_lock(&ci->i_ceph_lock); |
| 845 | if (inode->i_nlink == 1) { | 845 | if (inode->i_nlink == 1) { |
| 846 | drop |= ~(__ceph_caps_wanted(ci) | CEPH_CAP_PIN); | 846 | drop |= ~(__ceph_caps_wanted(ci) | CEPH_CAP_PIN); |
| 847 | ci->i_ceph_flags |= CEPH_I_NODELAY; | 847 | ci->i_ceph_flags |= CEPH_I_NODELAY; |
| 848 | } | 848 | } |
| 849 | spin_unlock(&inode->i_lock); | 849 | spin_unlock(&ci->i_ceph_lock); |
| 850 | return drop; | 850 | return drop; |
| 851 | } | 851 | } |
| 852 | 852 | ||
| @@ -1015,10 +1015,10 @@ static int dir_lease_is_valid(struct inode *dir, struct dentry *dentry) | |||
| 1015 | struct ceph_dentry_info *di = ceph_dentry(dentry); | 1015 | struct ceph_dentry_info *di = ceph_dentry(dentry); |
| 1016 | int valid = 0; | 1016 | int valid = 0; |
| 1017 | 1017 | ||
| 1018 | spin_lock(&dir->i_lock); | 1018 | spin_lock(&ci->i_ceph_lock); |
| 1019 | if (ci->i_shared_gen == di->lease_shared_gen) | 1019 | if (ci->i_shared_gen == di->lease_shared_gen) |
| 1020 | valid = __ceph_caps_issued_mask(ci, CEPH_CAP_FILE_SHARED, 1); | 1020 | valid = __ceph_caps_issued_mask(ci, CEPH_CAP_FILE_SHARED, 1); |
| 1021 | spin_unlock(&dir->i_lock); | 1021 | spin_unlock(&ci->i_ceph_lock); |
| 1022 | dout("dir_lease_is_valid dir %p v%u dentry %p v%u = %d\n", | 1022 | dout("dir_lease_is_valid dir %p v%u dentry %p v%u = %d\n", |
| 1023 | dir, (unsigned)ci->i_shared_gen, dentry, | 1023 | dir, (unsigned)ci->i_shared_gen, dentry, |
| 1024 | (unsigned)di->lease_shared_gen, valid); | 1024 | (unsigned)di->lease_shared_gen, valid); |
diff --git a/fs/ceph/file.c b/fs/ceph/file.c index ce549d31eeb7..ed72428d9c75 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c | |||
| @@ -147,9 +147,9 @@ int ceph_open(struct inode *inode, struct file *file) | |||
| 147 | 147 | ||
| 148 | /* trivially open snapdir */ | 148 | /* trivially open snapdir */ |
| 149 | if (ceph_snap(inode) == CEPH_SNAPDIR) { | 149 | if (ceph_snap(inode) == CEPH_SNAPDIR) { |
| 150 | spin_lock(&inode->i_lock); | 150 | spin_lock(&ci->i_ceph_lock); |
| 151 | __ceph_get_fmode(ci, fmode); | 151 | __ceph_get_fmode(ci, fmode); |
| 152 | spin_unlock(&inode->i_lock); | 152 | spin_unlock(&ci->i_ceph_lock); |
| 153 | return ceph_init_file(inode, file, fmode); | 153 | return ceph_init_file(inode, file, fmode); |
| 154 | } | 154 | } |
| 155 | 155 | ||
| @@ -158,7 +158,7 @@ int ceph_open(struct inode *inode, struct file *file) | |||
| 158 | * write) or any MDS (for read). Update wanted set | 158 | * write) or any MDS (for read). Update wanted set |
| 159 | * asynchronously. | 159 | * asynchronously. |
| 160 | */ | 160 | */ |
| 161 | spin_lock(&inode->i_lock); | 161 | spin_lock(&ci->i_ceph_lock); |
| 162 | if (__ceph_is_any_real_caps(ci) && | 162 | if (__ceph_is_any_real_caps(ci) && |
| 163 | (((fmode & CEPH_FILE_MODE_WR) == 0) || ci->i_auth_cap)) { | 163 | (((fmode & CEPH_FILE_MODE_WR) == 0) || ci->i_auth_cap)) { |
| 164 | int mds_wanted = __ceph_caps_mds_wanted(ci); | 164 | int mds_wanted = __ceph_caps_mds_wanted(ci); |
| @@ -168,7 +168,7 @@ int ceph_open(struct inode *inode, struct file *file) | |||
| 168 | inode, fmode, ceph_cap_string(wanted), | 168 | inode, fmode, ceph_cap_string(wanted), |
| 169 | ceph_cap_string(issued)); | 169 | ceph_cap_string(issued)); |
| 170 | __ceph_get_fmode(ci, fmode); | 170 | __ceph_get_fmode(ci, fmode); |
| 171 | spin_unlock(&inode->i_lock); | 171 | spin_unlock(&ci->i_ceph_lock); |
| 172 | 172 | ||
| 173 | /* adjust wanted? */ | 173 | /* adjust wanted? */ |
| 174 | if ((issued & wanted) != wanted && | 174 | if ((issued & wanted) != wanted && |
| @@ -180,10 +180,10 @@ int ceph_open(struct inode *inode, struct file *file) | |||
| 180 | } else if (ceph_snap(inode) != CEPH_NOSNAP && | 180 | } else if (ceph_snap(inode) != CEPH_NOSNAP && |
| 181 | (ci->i_snap_caps & wanted) == wanted) { | 181 | (ci->i_snap_caps & wanted) == wanted) { |
| 182 | __ceph_get_fmode(ci, fmode); | 182 | __ceph_get_fmode(ci, fmode); |
| 183 | spin_unlock(&inode->i_lock); | 183 | spin_unlock(&ci->i_ceph_lock); |
| 184 | return ceph_init_file(inode, file, fmode); | 184 | return ceph_init_file(inode, file, fmode); |
| 185 | } | 185 | } |
| 186 | spin_unlock(&inode->i_lock); | 186 | spin_unlock(&ci->i_ceph_lock); |
| 187 | 187 | ||
| 188 | dout("open fmode %d wants %s\n", fmode, ceph_cap_string(wanted)); | 188 | dout("open fmode %d wants %s\n", fmode, ceph_cap_string(wanted)); |
| 189 | req = prepare_open_request(inode->i_sb, flags, 0); | 189 | req = prepare_open_request(inode->i_sb, flags, 0); |
| @@ -743,9 +743,9 @@ retry_snap: | |||
| 743 | */ | 743 | */ |
| 744 | int dirty; | 744 | int dirty; |
| 745 | 745 | ||
| 746 | spin_lock(&inode->i_lock); | 746 | spin_lock(&ci->i_ceph_lock); |
| 747 | dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_FILE_WR); | 747 | dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_FILE_WR); |
| 748 | spin_unlock(&inode->i_lock); | 748 | spin_unlock(&ci->i_ceph_lock); |
| 749 | ceph_put_cap_refs(ci, got); | 749 | ceph_put_cap_refs(ci, got); |
| 750 | 750 | ||
| 751 | ret = generic_file_aio_write(iocb, iov, nr_segs, pos); | 751 | ret = generic_file_aio_write(iocb, iov, nr_segs, pos); |
| @@ -764,9 +764,9 @@ retry_snap: | |||
| 764 | 764 | ||
| 765 | if (ret >= 0) { | 765 | if (ret >= 0) { |
| 766 | int dirty; | 766 | int dirty; |
| 767 | spin_lock(&inode->i_lock); | 767 | spin_lock(&ci->i_ceph_lock); |
| 768 | dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_FILE_WR); | 768 | dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_FILE_WR); |
| 769 | spin_unlock(&inode->i_lock); | 769 | spin_unlock(&ci->i_ceph_lock); |
| 770 | if (dirty) | 770 | if (dirty) |
| 771 | __mark_inode_dirty(inode, dirty); | 771 | __mark_inode_dirty(inode, dirty); |
| 772 | } | 772 | } |
| @@ -797,7 +797,8 @@ static loff_t ceph_llseek(struct file *file, loff_t offset, int origin) | |||
| 797 | 797 | ||
| 798 | mutex_lock(&inode->i_mutex); | 798 | mutex_lock(&inode->i_mutex); |
| 799 | __ceph_do_pending_vmtruncate(inode); | 799 | __ceph_do_pending_vmtruncate(inode); |
| 800 | if (origin != SEEK_CUR || origin != SEEK_SET) { | 800 | |
| 801 | if (origin == SEEK_END || origin == SEEK_DATA || origin == SEEK_HOLE) { | ||
| 801 | ret = ceph_do_getattr(inode, CEPH_STAT_CAP_SIZE); | 802 | ret = ceph_do_getattr(inode, CEPH_STAT_CAP_SIZE); |
| 802 | if (ret < 0) { | 803 | if (ret < 0) { |
| 803 | offset = ret; | 804 | offset = ret; |
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 116f36502f17..87fb132fb330 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c | |||
| @@ -297,6 +297,8 @@ struct inode *ceph_alloc_inode(struct super_block *sb) | |||
| 297 | 297 | ||
| 298 | dout("alloc_inode %p\n", &ci->vfs_inode); | 298 | dout("alloc_inode %p\n", &ci->vfs_inode); |
| 299 | 299 | ||
| 300 | spin_lock_init(&ci->i_ceph_lock); | ||
| 301 | |||
| 300 | ci->i_version = 0; | 302 | ci->i_version = 0; |
| 301 | ci->i_time_warp_seq = 0; | 303 | ci->i_time_warp_seq = 0; |
| 302 | ci->i_ceph_flags = 0; | 304 | ci->i_ceph_flags = 0; |
| @@ -583,7 +585,7 @@ static int fill_inode(struct inode *inode, | |||
| 583 | iinfo->xattr_len); | 585 | iinfo->xattr_len); |
| 584 | } | 586 | } |
| 585 | 587 | ||
| 586 | spin_lock(&inode->i_lock); | 588 | spin_lock(&ci->i_ceph_lock); |
| 587 | 589 | ||
| 588 | /* | 590 | /* |
| 589 | * provided version will be odd if inode value is projected, | 591 | * provided version will be odd if inode value is projected, |
| @@ -680,7 +682,7 @@ static int fill_inode(struct inode *inode, | |||
| 680 | char *sym; | 682 | char *sym; |
| 681 | 683 | ||
| 682 | BUG_ON(symlen != inode->i_size); | 684 | BUG_ON(symlen != inode->i_size); |
| 683 | spin_unlock(&inode->i_lock); | 685 | spin_unlock(&ci->i_ceph_lock); |
| 684 | 686 | ||
| 685 | err = -ENOMEM; | 687 | err = -ENOMEM; |
| 686 | sym = kmalloc(symlen+1, GFP_NOFS); | 688 | sym = kmalloc(symlen+1, GFP_NOFS); |
| @@ -689,7 +691,7 @@ static int fill_inode(struct inode *inode, | |||
| 689 | memcpy(sym, iinfo->symlink, symlen); | 691 | memcpy(sym, iinfo->symlink, symlen); |
| 690 | sym[symlen] = 0; | 692 | sym[symlen] = 0; |
| 691 | 693 | ||
| 692 | spin_lock(&inode->i_lock); | 694 | spin_lock(&ci->i_ceph_lock); |
| 693 | if (!ci->i_symlink) | 695 | if (!ci->i_symlink) |
| 694 | ci->i_symlink = sym; | 696 | ci->i_symlink = sym; |
| 695 | else | 697 | else |
| @@ -715,7 +717,7 @@ static int fill_inode(struct inode *inode, | |||
| 715 | } | 717 | } |
| 716 | 718 | ||
| 717 | no_change: | 719 | no_change: |
| 718 | spin_unlock(&inode->i_lock); | 720 | spin_unlock(&ci->i_ceph_lock); |
| 719 | 721 | ||
| 720 | /* queue truncate if we saw i_size decrease */ | 722 | /* queue truncate if we saw i_size decrease */ |
| 721 | if (queue_trunc) | 723 | if (queue_trunc) |
| @@ -750,13 +752,13 @@ no_change: | |||
| 750 | info->cap.flags, | 752 | info->cap.flags, |
| 751 | caps_reservation); | 753 | caps_reservation); |
| 752 | } else { | 754 | } else { |
| 753 | spin_lock(&inode->i_lock); | 755 | spin_lock(&ci->i_ceph_lock); |
| 754 | dout(" %p got snap_caps %s\n", inode, | 756 | dout(" %p got snap_caps %s\n", inode, |
| 755 | ceph_cap_string(le32_to_cpu(info->cap.caps))); | 757 | ceph_cap_string(le32_to_cpu(info->cap.caps))); |
| 756 | ci->i_snap_caps |= le32_to_cpu(info->cap.caps); | 758 | ci->i_snap_caps |= le32_to_cpu(info->cap.caps); |
| 757 | if (cap_fmode >= 0) | 759 | if (cap_fmode >= 0) |
| 758 | __ceph_get_fmode(ci, cap_fmode); | 760 | __ceph_get_fmode(ci, cap_fmode); |
| 759 | spin_unlock(&inode->i_lock); | 761 | spin_unlock(&ci->i_ceph_lock); |
| 760 | } | 762 | } |
| 761 | } else if (cap_fmode >= 0) { | 763 | } else if (cap_fmode >= 0) { |
| 762 | pr_warning("mds issued no caps on %llx.%llx\n", | 764 | pr_warning("mds issued no caps on %llx.%llx\n", |
| @@ -849,19 +851,20 @@ static void ceph_set_dentry_offset(struct dentry *dn) | |||
| 849 | { | 851 | { |
| 850 | struct dentry *dir = dn->d_parent; | 852 | struct dentry *dir = dn->d_parent; |
| 851 | struct inode *inode = dir->d_inode; | 853 | struct inode *inode = dir->d_inode; |
| 854 | struct ceph_inode_info *ci = ceph_inode(inode); | ||
| 852 | struct ceph_dentry_info *di; | 855 | struct ceph_dentry_info *di; |
| 853 | 856 | ||
| 854 | BUG_ON(!inode); | 857 | BUG_ON(!inode); |
| 855 | 858 | ||
| 856 | di = ceph_dentry(dn); | 859 | di = ceph_dentry(dn); |
| 857 | 860 | ||
| 858 | spin_lock(&inode->i_lock); | 861 | spin_lock(&ci->i_ceph_lock); |
| 859 | if (!ceph_dir_test_complete(inode)) { | 862 | if (!ceph_dir_test_complete(inode)) { |
| 860 | spin_unlock(&inode->i_lock); | 863 | spin_unlock(&ci->i_ceph_lock); |
| 861 | return; | 864 | return; |
| 862 | } | 865 | } |
| 863 | di->offset = ceph_inode(inode)->i_max_offset++; | 866 | di->offset = ceph_inode(inode)->i_max_offset++; |
| 864 | spin_unlock(&inode->i_lock); | 867 | spin_unlock(&ci->i_ceph_lock); |
| 865 | 868 | ||
| 866 | spin_lock(&dir->d_lock); | 869 | spin_lock(&dir->d_lock); |
| 867 | spin_lock_nested(&dn->d_lock, DENTRY_D_LOCK_NESTED); | 870 | spin_lock_nested(&dn->d_lock, DENTRY_D_LOCK_NESTED); |
| @@ -1308,7 +1311,7 @@ int ceph_inode_set_size(struct inode *inode, loff_t size) | |||
| 1308 | struct ceph_inode_info *ci = ceph_inode(inode); | 1311 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 1309 | int ret = 0; | 1312 | int ret = 0; |
| 1310 | 1313 | ||
| 1311 | spin_lock(&inode->i_lock); | 1314 | spin_lock(&ci->i_ceph_lock); |
| 1312 | dout("set_size %p %llu -> %llu\n", inode, inode->i_size, size); | 1315 | dout("set_size %p %llu -> %llu\n", inode, inode->i_size, size); |
| 1313 | inode->i_size = size; | 1316 | inode->i_size = size; |
| 1314 | inode->i_blocks = (size + (1 << 9) - 1) >> 9; | 1317 | inode->i_blocks = (size + (1 << 9) - 1) >> 9; |
| @@ -1318,7 +1321,7 @@ int ceph_inode_set_size(struct inode *inode, loff_t size) | |||
| 1318 | (ci->i_reported_size << 1) < ci->i_max_size) | 1321 | (ci->i_reported_size << 1) < ci->i_max_size) |
| 1319 | ret = 1; | 1322 | ret = 1; |
| 1320 | 1323 | ||
| 1321 | spin_unlock(&inode->i_lock); | 1324 | spin_unlock(&ci->i_ceph_lock); |
| 1322 | return ret; | 1325 | return ret; |
| 1323 | } | 1326 | } |
| 1324 | 1327 | ||
| @@ -1376,20 +1379,20 @@ static void ceph_invalidate_work(struct work_struct *work) | |||
| 1376 | u32 orig_gen; | 1379 | u32 orig_gen; |
| 1377 | int check = 0; | 1380 | int check = 0; |
| 1378 | 1381 | ||
| 1379 | spin_lock(&inode->i_lock); | 1382 | spin_lock(&ci->i_ceph_lock); |
| 1380 | dout("invalidate_pages %p gen %d revoking %d\n", inode, | 1383 | dout("invalidate_pages %p gen %d revoking %d\n", inode, |
| 1381 | ci->i_rdcache_gen, ci->i_rdcache_revoking); | 1384 | ci->i_rdcache_gen, ci->i_rdcache_revoking); |
| 1382 | if (ci->i_rdcache_revoking != ci->i_rdcache_gen) { | 1385 | if (ci->i_rdcache_revoking != ci->i_rdcache_gen) { |
| 1383 | /* nevermind! */ | 1386 | /* nevermind! */ |
| 1384 | spin_unlock(&inode->i_lock); | 1387 | spin_unlock(&ci->i_ceph_lock); |
| 1385 | goto out; | 1388 | goto out; |
| 1386 | } | 1389 | } |
| 1387 | orig_gen = ci->i_rdcache_gen; | 1390 | orig_gen = ci->i_rdcache_gen; |
| 1388 | spin_unlock(&inode->i_lock); | 1391 | spin_unlock(&ci->i_ceph_lock); |
| 1389 | 1392 | ||
| 1390 | truncate_inode_pages(&inode->i_data, 0); | 1393 | truncate_inode_pages(&inode->i_data, 0); |
| 1391 | 1394 | ||
| 1392 | spin_lock(&inode->i_lock); | 1395 | spin_lock(&ci->i_ceph_lock); |
| 1393 | if (orig_gen == ci->i_rdcache_gen && | 1396 | if (orig_gen == ci->i_rdcache_gen && |
| 1394 | orig_gen == ci->i_rdcache_revoking) { | 1397 | orig_gen == ci->i_rdcache_revoking) { |
| 1395 | dout("invalidate_pages %p gen %d successful\n", inode, | 1398 | dout("invalidate_pages %p gen %d successful\n", inode, |
| @@ -1401,7 +1404,7 @@ static void ceph_invalidate_work(struct work_struct *work) | |||
| 1401 | inode, orig_gen, ci->i_rdcache_gen, | 1404 | inode, orig_gen, ci->i_rdcache_gen, |
| 1402 | ci->i_rdcache_revoking); | 1405 | ci->i_rdcache_revoking); |
| 1403 | } | 1406 | } |
| 1404 | spin_unlock(&inode->i_lock); | 1407 | spin_unlock(&ci->i_ceph_lock); |
| 1405 | 1408 | ||
| 1406 | if (check) | 1409 | if (check) |
| 1407 | ceph_check_caps(ci, 0, NULL); | 1410 | ceph_check_caps(ci, 0, NULL); |
| @@ -1460,10 +1463,10 @@ void __ceph_do_pending_vmtruncate(struct inode *inode) | |||
| 1460 | int wrbuffer_refs, wake = 0; | 1463 | int wrbuffer_refs, wake = 0; |
| 1461 | 1464 | ||
| 1462 | retry: | 1465 | retry: |
| 1463 | spin_lock(&inode->i_lock); | 1466 | spin_lock(&ci->i_ceph_lock); |
| 1464 | if (ci->i_truncate_pending == 0) { | 1467 | if (ci->i_truncate_pending == 0) { |
| 1465 | dout("__do_pending_vmtruncate %p none pending\n", inode); | 1468 | dout("__do_pending_vmtruncate %p none pending\n", inode); |
| 1466 | spin_unlock(&inode->i_lock); | 1469 | spin_unlock(&ci->i_ceph_lock); |
| 1467 | return; | 1470 | return; |
| 1468 | } | 1471 | } |
| 1469 | 1472 | ||
| @@ -1474,7 +1477,7 @@ retry: | |||
| 1474 | if (ci->i_wrbuffer_ref_head < ci->i_wrbuffer_ref) { | 1477 | if (ci->i_wrbuffer_ref_head < ci->i_wrbuffer_ref) { |
| 1475 | dout("__do_pending_vmtruncate %p flushing snaps first\n", | 1478 | dout("__do_pending_vmtruncate %p flushing snaps first\n", |
| 1476 | inode); | 1479 | inode); |
| 1477 | spin_unlock(&inode->i_lock); | 1480 | spin_unlock(&ci->i_ceph_lock); |
| 1478 | filemap_write_and_wait_range(&inode->i_data, 0, | 1481 | filemap_write_and_wait_range(&inode->i_data, 0, |
| 1479 | inode->i_sb->s_maxbytes); | 1482 | inode->i_sb->s_maxbytes); |
| 1480 | goto retry; | 1483 | goto retry; |
| @@ -1484,15 +1487,15 @@ retry: | |||
| 1484 | wrbuffer_refs = ci->i_wrbuffer_ref; | 1487 | wrbuffer_refs = ci->i_wrbuffer_ref; |
| 1485 | dout("__do_pending_vmtruncate %p (%d) to %lld\n", inode, | 1488 | dout("__do_pending_vmtruncate %p (%d) to %lld\n", inode, |
| 1486 | ci->i_truncate_pending, to); | 1489 | ci->i_truncate_pending, to); |
| 1487 | spin_unlock(&inode->i_lock); | 1490 | spin_unlock(&ci->i_ceph_lock); |
| 1488 | 1491 | ||
| 1489 | truncate_inode_pages(inode->i_mapping, to); | 1492 | truncate_inode_pages(inode->i_mapping, to); |
| 1490 | 1493 | ||
| 1491 | spin_lock(&inode->i_lock); | 1494 | spin_lock(&ci->i_ceph_lock); |
| 1492 | ci->i_truncate_pending--; | 1495 | ci->i_truncate_pending--; |
| 1493 | if (ci->i_truncate_pending == 0) | 1496 | if (ci->i_truncate_pending == 0) |
| 1494 | wake = 1; | 1497 | wake = 1; |
| 1495 | spin_unlock(&inode->i_lock); | 1498 | spin_unlock(&ci->i_ceph_lock); |
| 1496 | 1499 | ||
| 1497 | if (wrbuffer_refs == 0) | 1500 | if (wrbuffer_refs == 0) |
| 1498 | ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); | 1501 | ceph_check_caps(ci, CHECK_CAPS_AUTHONLY, NULL); |
| @@ -1547,7 +1550,7 @@ int ceph_setattr(struct dentry *dentry, struct iattr *attr) | |||
| 1547 | if (IS_ERR(req)) | 1550 | if (IS_ERR(req)) |
| 1548 | return PTR_ERR(req); | 1551 | return PTR_ERR(req); |
| 1549 | 1552 | ||
| 1550 | spin_lock(&inode->i_lock); | 1553 | spin_lock(&ci->i_ceph_lock); |
| 1551 | issued = __ceph_caps_issued(ci, NULL); | 1554 | issued = __ceph_caps_issued(ci, NULL); |
| 1552 | dout("setattr %p issued %s\n", inode, ceph_cap_string(issued)); | 1555 | dout("setattr %p issued %s\n", inode, ceph_cap_string(issued)); |
| 1553 | 1556 | ||
| @@ -1695,7 +1698,7 @@ int ceph_setattr(struct dentry *dentry, struct iattr *attr) | |||
| 1695 | } | 1698 | } |
| 1696 | 1699 | ||
| 1697 | release &= issued; | 1700 | release &= issued; |
| 1698 | spin_unlock(&inode->i_lock); | 1701 | spin_unlock(&ci->i_ceph_lock); |
| 1699 | 1702 | ||
| 1700 | if (inode_dirty_flags) | 1703 | if (inode_dirty_flags) |
| 1701 | __mark_inode_dirty(inode, inode_dirty_flags); | 1704 | __mark_inode_dirty(inode, inode_dirty_flags); |
| @@ -1717,7 +1720,7 @@ int ceph_setattr(struct dentry *dentry, struct iattr *attr) | |||
| 1717 | __ceph_do_pending_vmtruncate(inode); | 1720 | __ceph_do_pending_vmtruncate(inode); |
| 1718 | return err; | 1721 | return err; |
| 1719 | out: | 1722 | out: |
| 1720 | spin_unlock(&inode->i_lock); | 1723 | spin_unlock(&ci->i_ceph_lock); |
| 1721 | ceph_mdsc_put_request(req); | 1724 | ceph_mdsc_put_request(req); |
| 1722 | return err; | 1725 | return err; |
| 1723 | } | 1726 | } |
diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c index 5a14c29cbba6..790914a598dd 100644 --- a/fs/ceph/ioctl.c +++ b/fs/ceph/ioctl.c | |||
| @@ -241,11 +241,11 @@ static long ceph_ioctl_lazyio(struct file *file) | |||
| 241 | struct ceph_inode_info *ci = ceph_inode(inode); | 241 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 242 | 242 | ||
| 243 | if ((fi->fmode & CEPH_FILE_MODE_LAZY) == 0) { | 243 | if ((fi->fmode & CEPH_FILE_MODE_LAZY) == 0) { |
| 244 | spin_lock(&inode->i_lock); | 244 | spin_lock(&ci->i_ceph_lock); |
| 245 | ci->i_nr_by_mode[fi->fmode]--; | 245 | ci->i_nr_by_mode[fi->fmode]--; |
| 246 | fi->fmode |= CEPH_FILE_MODE_LAZY; | 246 | fi->fmode |= CEPH_FILE_MODE_LAZY; |
| 247 | ci->i_nr_by_mode[fi->fmode]++; | 247 | ci->i_nr_by_mode[fi->fmode]++; |
| 248 | spin_unlock(&inode->i_lock); | 248 | spin_unlock(&ci->i_ceph_lock); |
| 249 | dout("ioctl_layzio: file %p marked lazy\n", file); | 249 | dout("ioctl_layzio: file %p marked lazy\n", file); |
| 250 | 250 | ||
| 251 | ceph_check_caps(ci, 0, NULL); | 251 | ceph_check_caps(ci, 0, NULL); |
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c index 264ab701154f..6203d805eb45 100644 --- a/fs/ceph/mds_client.c +++ b/fs/ceph/mds_client.c | |||
| @@ -732,21 +732,21 @@ static int __choose_mds(struct ceph_mds_client *mdsc, | |||
| 732 | } | 732 | } |
| 733 | } | 733 | } |
| 734 | 734 | ||
| 735 | spin_lock(&inode->i_lock); | 735 | spin_lock(&ci->i_ceph_lock); |
| 736 | cap = NULL; | 736 | cap = NULL; |
| 737 | if (mode == USE_AUTH_MDS) | 737 | if (mode == USE_AUTH_MDS) |
| 738 | cap = ci->i_auth_cap; | 738 | cap = ci->i_auth_cap; |
| 739 | if (!cap && !RB_EMPTY_ROOT(&ci->i_caps)) | 739 | if (!cap && !RB_EMPTY_ROOT(&ci->i_caps)) |
| 740 | cap = rb_entry(rb_first(&ci->i_caps), struct ceph_cap, ci_node); | 740 | cap = rb_entry(rb_first(&ci->i_caps), struct ceph_cap, ci_node); |
| 741 | if (!cap) { | 741 | if (!cap) { |
| 742 | spin_unlock(&inode->i_lock); | 742 | spin_unlock(&ci->i_ceph_lock); |
| 743 | goto random; | 743 | goto random; |
| 744 | } | 744 | } |
| 745 | mds = cap->session->s_mds; | 745 | mds = cap->session->s_mds; |
| 746 | dout("choose_mds %p %llx.%llx mds%d (%scap %p)\n", | 746 | dout("choose_mds %p %llx.%llx mds%d (%scap %p)\n", |
| 747 | inode, ceph_vinop(inode), mds, | 747 | inode, ceph_vinop(inode), mds, |
| 748 | cap == ci->i_auth_cap ? "auth " : "", cap); | 748 | cap == ci->i_auth_cap ? "auth " : "", cap); |
| 749 | spin_unlock(&inode->i_lock); | 749 | spin_unlock(&ci->i_ceph_lock); |
| 750 | return mds; | 750 | return mds; |
| 751 | 751 | ||
| 752 | random: | 752 | random: |
| @@ -951,7 +951,7 @@ static int remove_session_caps_cb(struct inode *inode, struct ceph_cap *cap, | |||
| 951 | 951 | ||
| 952 | dout("removing cap %p, ci is %p, inode is %p\n", | 952 | dout("removing cap %p, ci is %p, inode is %p\n", |
| 953 | cap, ci, &ci->vfs_inode); | 953 | cap, ci, &ci->vfs_inode); |
| 954 | spin_lock(&inode->i_lock); | 954 | spin_lock(&ci->i_ceph_lock); |
| 955 | __ceph_remove_cap(cap); | 955 | __ceph_remove_cap(cap); |
| 956 | if (!__ceph_is_any_real_caps(ci)) { | 956 | if (!__ceph_is_any_real_caps(ci)) { |
| 957 | struct ceph_mds_client *mdsc = | 957 | struct ceph_mds_client *mdsc = |
| @@ -984,7 +984,7 @@ static int remove_session_caps_cb(struct inode *inode, struct ceph_cap *cap, | |||
| 984 | } | 984 | } |
| 985 | spin_unlock(&mdsc->cap_dirty_lock); | 985 | spin_unlock(&mdsc->cap_dirty_lock); |
| 986 | } | 986 | } |
| 987 | spin_unlock(&inode->i_lock); | 987 | spin_unlock(&ci->i_ceph_lock); |
| 988 | while (drop--) | 988 | while (drop--) |
| 989 | iput(inode); | 989 | iput(inode); |
| 990 | return 0; | 990 | return 0; |
| @@ -1015,10 +1015,10 @@ static int wake_up_session_cb(struct inode *inode, struct ceph_cap *cap, | |||
| 1015 | 1015 | ||
| 1016 | wake_up_all(&ci->i_cap_wq); | 1016 | wake_up_all(&ci->i_cap_wq); |
| 1017 | if (arg) { | 1017 | if (arg) { |
| 1018 | spin_lock(&inode->i_lock); | 1018 | spin_lock(&ci->i_ceph_lock); |
| 1019 | ci->i_wanted_max_size = 0; | 1019 | ci->i_wanted_max_size = 0; |
| 1020 | ci->i_requested_max_size = 0; | 1020 | ci->i_requested_max_size = 0; |
| 1021 | spin_unlock(&inode->i_lock); | 1021 | spin_unlock(&ci->i_ceph_lock); |
| 1022 | } | 1022 | } |
| 1023 | return 0; | 1023 | return 0; |
| 1024 | } | 1024 | } |
| @@ -1151,7 +1151,7 @@ static int trim_caps_cb(struct inode *inode, struct ceph_cap *cap, void *arg) | |||
| 1151 | if (session->s_trim_caps <= 0) | 1151 | if (session->s_trim_caps <= 0) |
| 1152 | return -1; | 1152 | return -1; |
| 1153 | 1153 | ||
| 1154 | spin_lock(&inode->i_lock); | 1154 | spin_lock(&ci->i_ceph_lock); |
| 1155 | mine = cap->issued | cap->implemented; | 1155 | mine = cap->issued | cap->implemented; |
| 1156 | used = __ceph_caps_used(ci); | 1156 | used = __ceph_caps_used(ci); |
| 1157 | oissued = __ceph_caps_issued_other(ci, cap); | 1157 | oissued = __ceph_caps_issued_other(ci, cap); |
| @@ -1170,7 +1170,7 @@ static int trim_caps_cb(struct inode *inode, struct ceph_cap *cap, void *arg) | |||
| 1170 | __ceph_remove_cap(cap); | 1170 | __ceph_remove_cap(cap); |
| 1171 | } else { | 1171 | } else { |
| 1172 | /* try to drop referring dentries */ | 1172 | /* try to drop referring dentries */ |
| 1173 | spin_unlock(&inode->i_lock); | 1173 | spin_unlock(&ci->i_ceph_lock); |
| 1174 | d_prune_aliases(inode); | 1174 | d_prune_aliases(inode); |
| 1175 | dout("trim_caps_cb %p cap %p pruned, count now %d\n", | 1175 | dout("trim_caps_cb %p cap %p pruned, count now %d\n", |
| 1176 | inode, cap, atomic_read(&inode->i_count)); | 1176 | inode, cap, atomic_read(&inode->i_count)); |
| @@ -1178,7 +1178,7 @@ static int trim_caps_cb(struct inode *inode, struct ceph_cap *cap, void *arg) | |||
| 1178 | } | 1178 | } |
| 1179 | 1179 | ||
| 1180 | out: | 1180 | out: |
| 1181 | spin_unlock(&inode->i_lock); | 1181 | spin_unlock(&ci->i_ceph_lock); |
| 1182 | return 0; | 1182 | return 0; |
| 1183 | } | 1183 | } |
| 1184 | 1184 | ||
| @@ -1296,7 +1296,7 @@ static int check_cap_flush(struct ceph_mds_client *mdsc, u64 want_flush_seq) | |||
| 1296 | i_flushing_item); | 1296 | i_flushing_item); |
| 1297 | struct inode *inode = &ci->vfs_inode; | 1297 | struct inode *inode = &ci->vfs_inode; |
| 1298 | 1298 | ||
| 1299 | spin_lock(&inode->i_lock); | 1299 | spin_lock(&ci->i_ceph_lock); |
| 1300 | if (ci->i_cap_flush_seq <= want_flush_seq) { | 1300 | if (ci->i_cap_flush_seq <= want_flush_seq) { |
| 1301 | dout("check_cap_flush still flushing %p " | 1301 | dout("check_cap_flush still flushing %p " |
| 1302 | "seq %lld <= %lld to mds%d\n", inode, | 1302 | "seq %lld <= %lld to mds%d\n", inode, |
| @@ -1304,7 +1304,7 @@ static int check_cap_flush(struct ceph_mds_client *mdsc, u64 want_flush_seq) | |||
| 1304 | session->s_mds); | 1304 | session->s_mds); |
| 1305 | ret = 0; | 1305 | ret = 0; |
| 1306 | } | 1306 | } |
| 1307 | spin_unlock(&inode->i_lock); | 1307 | spin_unlock(&ci->i_ceph_lock); |
| 1308 | } | 1308 | } |
| 1309 | mutex_unlock(&session->s_mutex); | 1309 | mutex_unlock(&session->s_mutex); |
| 1310 | ceph_put_mds_session(session); | 1310 | ceph_put_mds_session(session); |
| @@ -1495,6 +1495,7 @@ retry: | |||
| 1495 | pos, temp); | 1495 | pos, temp); |
| 1496 | } else if (stop_on_nosnap && inode && | 1496 | } else if (stop_on_nosnap && inode && |
| 1497 | ceph_snap(inode) == CEPH_NOSNAP) { | 1497 | ceph_snap(inode) == CEPH_NOSNAP) { |
| 1498 | spin_unlock(&temp->d_lock); | ||
| 1498 | break; | 1499 | break; |
| 1499 | } else { | 1500 | } else { |
| 1500 | pos -= temp->d_name.len; | 1501 | pos -= temp->d_name.len; |
| @@ -2011,10 +2012,10 @@ void ceph_invalidate_dir_request(struct ceph_mds_request *req) | |||
| 2011 | struct ceph_inode_info *ci = ceph_inode(inode); | 2012 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 2012 | 2013 | ||
| 2013 | dout("invalidate_dir_request %p (D_COMPLETE, lease(s))\n", inode); | 2014 | dout("invalidate_dir_request %p (D_COMPLETE, lease(s))\n", inode); |
| 2014 | spin_lock(&inode->i_lock); | 2015 | spin_lock(&ci->i_ceph_lock); |
| 2015 | ceph_dir_clear_complete(inode); | 2016 | ceph_dir_clear_complete(inode); |
| 2016 | ci->i_release_count++; | 2017 | ci->i_release_count++; |
| 2017 | spin_unlock(&inode->i_lock); | 2018 | spin_unlock(&ci->i_ceph_lock); |
| 2018 | 2019 | ||
| 2019 | if (req->r_dentry) | 2020 | if (req->r_dentry) |
| 2020 | ceph_invalidate_dentry_lease(req->r_dentry); | 2021 | ceph_invalidate_dentry_lease(req->r_dentry); |
| @@ -2422,7 +2423,7 @@ static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap, | |||
| 2422 | if (err) | 2423 | if (err) |
| 2423 | goto out_free; | 2424 | goto out_free; |
| 2424 | 2425 | ||
| 2425 | spin_lock(&inode->i_lock); | 2426 | spin_lock(&ci->i_ceph_lock); |
| 2426 | cap->seq = 0; /* reset cap seq */ | 2427 | cap->seq = 0; /* reset cap seq */ |
| 2427 | cap->issue_seq = 0; /* and issue_seq */ | 2428 | cap->issue_seq = 0; /* and issue_seq */ |
| 2428 | 2429 | ||
| @@ -2445,7 +2446,7 @@ static int encode_caps_cb(struct inode *inode, struct ceph_cap *cap, | |||
| 2445 | rec.v1.pathbase = cpu_to_le64(pathbase); | 2446 | rec.v1.pathbase = cpu_to_le64(pathbase); |
| 2446 | reclen = sizeof(rec.v1); | 2447 | reclen = sizeof(rec.v1); |
| 2447 | } | 2448 | } |
| 2448 | spin_unlock(&inode->i_lock); | 2449 | spin_unlock(&ci->i_ceph_lock); |
| 2449 | 2450 | ||
| 2450 | if (recon_state->flock) { | 2451 | if (recon_state->flock) { |
| 2451 | int num_fcntl_locks, num_flock_locks; | 2452 | int num_fcntl_locks, num_flock_locks; |
diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h index 4bb239921dbd..a50ca0e39475 100644 --- a/fs/ceph/mds_client.h +++ b/fs/ceph/mds_client.h | |||
| @@ -20,7 +20,7 @@ | |||
| 20 | * | 20 | * |
| 21 | * mdsc->snap_rwsem | 21 | * mdsc->snap_rwsem |
| 22 | * | 22 | * |
| 23 | * inode->i_lock | 23 | * ci->i_ceph_lock |
| 24 | * mdsc->snap_flush_lock | 24 | * mdsc->snap_flush_lock |
| 25 | * mdsc->cap_delay_lock | 25 | * mdsc->cap_delay_lock |
| 26 | * | 26 | * |
diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c index e26437191333..a559c80f127a 100644 --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c | |||
| @@ -446,7 +446,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci) | |||
| 446 | return; | 446 | return; |
| 447 | } | 447 | } |
| 448 | 448 | ||
| 449 | spin_lock(&inode->i_lock); | 449 | spin_lock(&ci->i_ceph_lock); |
| 450 | used = __ceph_caps_used(ci); | 450 | used = __ceph_caps_used(ci); |
| 451 | dirty = __ceph_caps_dirty(ci); | 451 | dirty = __ceph_caps_dirty(ci); |
| 452 | 452 | ||
| @@ -528,7 +528,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci) | |||
| 528 | kfree(capsnap); | 528 | kfree(capsnap); |
| 529 | } | 529 | } |
| 530 | 530 | ||
| 531 | spin_unlock(&inode->i_lock); | 531 | spin_unlock(&ci->i_ceph_lock); |
| 532 | } | 532 | } |
| 533 | 533 | ||
| 534 | /* | 534 | /* |
| @@ -537,7 +537,7 @@ void ceph_queue_cap_snap(struct ceph_inode_info *ci) | |||
| 537 | * | 537 | * |
| 538 | * If capsnap can now be flushed, add to snap_flush list, and return 1. | 538 | * If capsnap can now be flushed, add to snap_flush list, and return 1. |
| 539 | * | 539 | * |
| 540 | * Caller must hold i_lock. | 540 | * Caller must hold i_ceph_lock. |
| 541 | */ | 541 | */ |
| 542 | int __ceph_finish_cap_snap(struct ceph_inode_info *ci, | 542 | int __ceph_finish_cap_snap(struct ceph_inode_info *ci, |
| 543 | struct ceph_cap_snap *capsnap) | 543 | struct ceph_cap_snap *capsnap) |
| @@ -739,9 +739,9 @@ static void flush_snaps(struct ceph_mds_client *mdsc) | |||
| 739 | inode = &ci->vfs_inode; | 739 | inode = &ci->vfs_inode; |
| 740 | ihold(inode); | 740 | ihold(inode); |
| 741 | spin_unlock(&mdsc->snap_flush_lock); | 741 | spin_unlock(&mdsc->snap_flush_lock); |
| 742 | spin_lock(&inode->i_lock); | 742 | spin_lock(&ci->i_ceph_lock); |
| 743 | __ceph_flush_snaps(ci, &session, 0); | 743 | __ceph_flush_snaps(ci, &session, 0); |
| 744 | spin_unlock(&inode->i_lock); | 744 | spin_unlock(&ci->i_ceph_lock); |
| 745 | iput(inode); | 745 | iput(inode); |
| 746 | spin_lock(&mdsc->snap_flush_lock); | 746 | spin_lock(&mdsc->snap_flush_lock); |
| 747 | } | 747 | } |
| @@ -847,7 +847,7 @@ void ceph_handle_snap(struct ceph_mds_client *mdsc, | |||
| 847 | continue; | 847 | continue; |
| 848 | ci = ceph_inode(inode); | 848 | ci = ceph_inode(inode); |
| 849 | 849 | ||
| 850 | spin_lock(&inode->i_lock); | 850 | spin_lock(&ci->i_ceph_lock); |
| 851 | if (!ci->i_snap_realm) | 851 | if (!ci->i_snap_realm) |
| 852 | goto skip_inode; | 852 | goto skip_inode; |
| 853 | /* | 853 | /* |
| @@ -876,7 +876,7 @@ void ceph_handle_snap(struct ceph_mds_client *mdsc, | |||
| 876 | oldrealm = ci->i_snap_realm; | 876 | oldrealm = ci->i_snap_realm; |
| 877 | ci->i_snap_realm = realm; | 877 | ci->i_snap_realm = realm; |
| 878 | spin_unlock(&realm->inodes_with_caps_lock); | 878 | spin_unlock(&realm->inodes_with_caps_lock); |
| 879 | spin_unlock(&inode->i_lock); | 879 | spin_unlock(&ci->i_ceph_lock); |
| 880 | 880 | ||
| 881 | ceph_get_snap_realm(mdsc, realm); | 881 | ceph_get_snap_realm(mdsc, realm); |
| 882 | ceph_put_snap_realm(mdsc, oldrealm); | 882 | ceph_put_snap_realm(mdsc, oldrealm); |
| @@ -885,7 +885,7 @@ void ceph_handle_snap(struct ceph_mds_client *mdsc, | |||
| 885 | continue; | 885 | continue; |
| 886 | 886 | ||
| 887 | skip_inode: | 887 | skip_inode: |
| 888 | spin_unlock(&inode->i_lock); | 888 | spin_unlock(&ci->i_ceph_lock); |
| 889 | iput(inode); | 889 | iput(inode); |
| 890 | } | 890 | } |
| 891 | 891 | ||
diff --git a/fs/ceph/super.c b/fs/ceph/super.c index 8dc73a594a90..b48f15f101a0 100644 --- a/fs/ceph/super.c +++ b/fs/ceph/super.c | |||
| @@ -383,7 +383,7 @@ static int ceph_show_options(struct seq_file *m, struct vfsmount *mnt) | |||
| 383 | if (fsopt->rsize != CEPH_RSIZE_DEFAULT) | 383 | if (fsopt->rsize != CEPH_RSIZE_DEFAULT) |
| 384 | seq_printf(m, ",rsize=%d", fsopt->rsize); | 384 | seq_printf(m, ",rsize=%d", fsopt->rsize); |
| 385 | if (fsopt->rasize != CEPH_RASIZE_DEFAULT) | 385 | if (fsopt->rasize != CEPH_RASIZE_DEFAULT) |
| 386 | seq_printf(m, ",rasize=%d", fsopt->rsize); | 386 | seq_printf(m, ",rasize=%d", fsopt->rasize); |
| 387 | if (fsopt->congestion_kb != default_congestion_kb()) | 387 | if (fsopt->congestion_kb != default_congestion_kb()) |
| 388 | seq_printf(m, ",write_congestion_kb=%d", fsopt->congestion_kb); | 388 | seq_printf(m, ",write_congestion_kb=%d", fsopt->congestion_kb); |
| 389 | if (fsopt->caps_wanted_delay_min != CEPH_CAPS_WANTED_DELAY_MIN_DEFAULT) | 389 | if (fsopt->caps_wanted_delay_min != CEPH_CAPS_WANTED_DELAY_MIN_DEFAULT) |
diff --git a/fs/ceph/super.h b/fs/ceph/super.h index 01bf189e08a9..edcbf3774a56 100644 --- a/fs/ceph/super.h +++ b/fs/ceph/super.h | |||
| @@ -220,7 +220,7 @@ struct ceph_dentry_info { | |||
| 220 | * The locking for D_COMPLETE is a bit odd: | 220 | * The locking for D_COMPLETE is a bit odd: |
| 221 | * - we can clear it at almost any time (see ceph_d_prune) | 221 | * - we can clear it at almost any time (see ceph_d_prune) |
| 222 | * - it is only meaningful if: | 222 | * - it is only meaningful if: |
| 223 | * - we hold dir inode i_lock | 223 | * - we hold dir inode i_ceph_lock |
| 224 | * - we hold dir FILE_SHARED caps | 224 | * - we hold dir FILE_SHARED caps |
| 225 | * - the dentry D_COMPLETE is set | 225 | * - the dentry D_COMPLETE is set |
| 226 | */ | 226 | */ |
| @@ -250,6 +250,8 @@ struct ceph_inode_xattrs_info { | |||
| 250 | struct ceph_inode_info { | 250 | struct ceph_inode_info { |
| 251 | struct ceph_vino i_vino; /* ceph ino + snap */ | 251 | struct ceph_vino i_vino; /* ceph ino + snap */ |
| 252 | 252 | ||
| 253 | spinlock_t i_ceph_lock; | ||
| 254 | |||
| 253 | u64 i_version; | 255 | u64 i_version; |
| 254 | u32 i_time_warp_seq; | 256 | u32 i_time_warp_seq; |
| 255 | 257 | ||
| @@ -271,7 +273,7 @@ struct ceph_inode_info { | |||
| 271 | 273 | ||
| 272 | struct ceph_inode_xattrs_info i_xattrs; | 274 | struct ceph_inode_xattrs_info i_xattrs; |
| 273 | 275 | ||
| 274 | /* capabilities. protected _both_ by i_lock and cap->session's | 276 | /* capabilities. protected _both_ by i_ceph_lock and cap->session's |
| 275 | * s_mutex. */ | 277 | * s_mutex. */ |
| 276 | struct rb_root i_caps; /* cap list */ | 278 | struct rb_root i_caps; /* cap list */ |
| 277 | struct ceph_cap *i_auth_cap; /* authoritative cap, if any */ | 279 | struct ceph_cap *i_auth_cap; /* authoritative cap, if any */ |
| @@ -437,18 +439,18 @@ static inline void ceph_i_clear(struct inode *inode, unsigned mask) | |||
| 437 | { | 439 | { |
| 438 | struct ceph_inode_info *ci = ceph_inode(inode); | 440 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 439 | 441 | ||
| 440 | spin_lock(&inode->i_lock); | 442 | spin_lock(&ci->i_ceph_lock); |
| 441 | ci->i_ceph_flags &= ~mask; | 443 | ci->i_ceph_flags &= ~mask; |
| 442 | spin_unlock(&inode->i_lock); | 444 | spin_unlock(&ci->i_ceph_lock); |
| 443 | } | 445 | } |
| 444 | 446 | ||
| 445 | static inline void ceph_i_set(struct inode *inode, unsigned mask) | 447 | static inline void ceph_i_set(struct inode *inode, unsigned mask) |
| 446 | { | 448 | { |
| 447 | struct ceph_inode_info *ci = ceph_inode(inode); | 449 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 448 | 450 | ||
| 449 | spin_lock(&inode->i_lock); | 451 | spin_lock(&ci->i_ceph_lock); |
| 450 | ci->i_ceph_flags |= mask; | 452 | ci->i_ceph_flags |= mask; |
| 451 | spin_unlock(&inode->i_lock); | 453 | spin_unlock(&ci->i_ceph_lock); |
| 452 | } | 454 | } |
| 453 | 455 | ||
| 454 | static inline bool ceph_i_test(struct inode *inode, unsigned mask) | 456 | static inline bool ceph_i_test(struct inode *inode, unsigned mask) |
| @@ -456,9 +458,9 @@ static inline bool ceph_i_test(struct inode *inode, unsigned mask) | |||
| 456 | struct ceph_inode_info *ci = ceph_inode(inode); | 458 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 457 | bool r; | 459 | bool r; |
| 458 | 460 | ||
| 459 | spin_lock(&inode->i_lock); | 461 | spin_lock(&ci->i_ceph_lock); |
| 460 | r = (ci->i_ceph_flags & mask) == mask; | 462 | r = (ci->i_ceph_flags & mask) == mask; |
| 461 | spin_unlock(&inode->i_lock); | 463 | spin_unlock(&ci->i_ceph_lock); |
| 462 | return r; | 464 | return r; |
| 463 | } | 465 | } |
| 464 | 466 | ||
| @@ -508,9 +510,9 @@ extern int __ceph_caps_issued_other(struct ceph_inode_info *ci, | |||
| 508 | static inline int ceph_caps_issued(struct ceph_inode_info *ci) | 510 | static inline int ceph_caps_issued(struct ceph_inode_info *ci) |
| 509 | { | 511 | { |
| 510 | int issued; | 512 | int issued; |
| 511 | spin_lock(&ci->vfs_inode.i_lock); | 513 | spin_lock(&ci->i_ceph_lock); |
| 512 | issued = __ceph_caps_issued(ci, NULL); | 514 | issued = __ceph_caps_issued(ci, NULL); |
| 513 | spin_unlock(&ci->vfs_inode.i_lock); | 515 | spin_unlock(&ci->i_ceph_lock); |
| 514 | return issued; | 516 | return issued; |
| 515 | } | 517 | } |
| 516 | 518 | ||
| @@ -518,9 +520,9 @@ static inline int ceph_caps_issued_mask(struct ceph_inode_info *ci, int mask, | |||
| 518 | int touch) | 520 | int touch) |
| 519 | { | 521 | { |
| 520 | int r; | 522 | int r; |
| 521 | spin_lock(&ci->vfs_inode.i_lock); | 523 | spin_lock(&ci->i_ceph_lock); |
| 522 | r = __ceph_caps_issued_mask(ci, mask, touch); | 524 | r = __ceph_caps_issued_mask(ci, mask, touch); |
| 523 | spin_unlock(&ci->vfs_inode.i_lock); | 525 | spin_unlock(&ci->i_ceph_lock); |
| 524 | return r; | 526 | return r; |
| 525 | } | 527 | } |
| 526 | 528 | ||
| @@ -743,10 +745,9 @@ extern int ceph_add_cap(struct inode *inode, | |||
| 743 | extern void __ceph_remove_cap(struct ceph_cap *cap); | 745 | extern void __ceph_remove_cap(struct ceph_cap *cap); |
| 744 | static inline void ceph_remove_cap(struct ceph_cap *cap) | 746 | static inline void ceph_remove_cap(struct ceph_cap *cap) |
| 745 | { | 747 | { |
| 746 | struct inode *inode = &cap->ci->vfs_inode; | 748 | spin_lock(&cap->ci->i_ceph_lock); |
| 747 | spin_lock(&inode->i_lock); | ||
| 748 | __ceph_remove_cap(cap); | 749 | __ceph_remove_cap(cap); |
| 749 | spin_unlock(&inode->i_lock); | 750 | spin_unlock(&cap->ci->i_ceph_lock); |
| 750 | } | 751 | } |
| 751 | extern void ceph_put_cap(struct ceph_mds_client *mdsc, | 752 | extern void ceph_put_cap(struct ceph_mds_client *mdsc, |
| 752 | struct ceph_cap *cap); | 753 | struct ceph_cap *cap); |
diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c index 96c6739a0280..a5e36e4488a7 100644 --- a/fs/ceph/xattr.c +++ b/fs/ceph/xattr.c | |||
| @@ -343,8 +343,8 @@ void __ceph_destroy_xattrs(struct ceph_inode_info *ci) | |||
| 343 | } | 343 | } |
| 344 | 344 | ||
| 345 | static int __build_xattrs(struct inode *inode) | 345 | static int __build_xattrs(struct inode *inode) |
| 346 | __releases(inode->i_lock) | 346 | __releases(ci->i_ceph_lock) |
| 347 | __acquires(inode->i_lock) | 347 | __acquires(ci->i_ceph_lock) |
| 348 | { | 348 | { |
| 349 | u32 namelen; | 349 | u32 namelen; |
| 350 | u32 numattr = 0; | 350 | u32 numattr = 0; |
| @@ -372,7 +372,7 @@ start: | |||
| 372 | end = p + ci->i_xattrs.blob->vec.iov_len; | 372 | end = p + ci->i_xattrs.blob->vec.iov_len; |
| 373 | ceph_decode_32_safe(&p, end, numattr, bad); | 373 | ceph_decode_32_safe(&p, end, numattr, bad); |
| 374 | xattr_version = ci->i_xattrs.version; | 374 | xattr_version = ci->i_xattrs.version; |
| 375 | spin_unlock(&inode->i_lock); | 375 | spin_unlock(&ci->i_ceph_lock); |
| 376 | 376 | ||
| 377 | xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *), | 377 | xattrs = kcalloc(numattr, sizeof(struct ceph_xattr *), |
| 378 | GFP_NOFS); | 378 | GFP_NOFS); |
| @@ -387,7 +387,7 @@ start: | |||
| 387 | goto bad_lock; | 387 | goto bad_lock; |
| 388 | } | 388 | } |
| 389 | 389 | ||
| 390 | spin_lock(&inode->i_lock); | 390 | spin_lock(&ci->i_ceph_lock); |
| 391 | if (ci->i_xattrs.version != xattr_version) { | 391 | if (ci->i_xattrs.version != xattr_version) { |
| 392 | /* lost a race, retry */ | 392 | /* lost a race, retry */ |
| 393 | for (i = 0; i < numattr; i++) | 393 | for (i = 0; i < numattr; i++) |
| @@ -418,7 +418,7 @@ start: | |||
| 418 | 418 | ||
| 419 | return err; | 419 | return err; |
| 420 | bad_lock: | 420 | bad_lock: |
| 421 | spin_lock(&inode->i_lock); | 421 | spin_lock(&ci->i_ceph_lock); |
| 422 | bad: | 422 | bad: |
| 423 | if (xattrs) { | 423 | if (xattrs) { |
| 424 | for (i = 0; i < numattr; i++) | 424 | for (i = 0; i < numattr; i++) |
| @@ -512,7 +512,7 @@ ssize_t ceph_getxattr(struct dentry *dentry, const char *name, void *value, | |||
| 512 | if (vxattrs) | 512 | if (vxattrs) |
| 513 | vxattr = ceph_match_vxattr(vxattrs, name); | 513 | vxattr = ceph_match_vxattr(vxattrs, name); |
| 514 | 514 | ||
| 515 | spin_lock(&inode->i_lock); | 515 | spin_lock(&ci->i_ceph_lock); |
| 516 | dout("getxattr %p ver=%lld index_ver=%lld\n", inode, | 516 | dout("getxattr %p ver=%lld index_ver=%lld\n", inode, |
| 517 | ci->i_xattrs.version, ci->i_xattrs.index_version); | 517 | ci->i_xattrs.version, ci->i_xattrs.index_version); |
| 518 | 518 | ||
| @@ -520,14 +520,14 @@ ssize_t ceph_getxattr(struct dentry *dentry, const char *name, void *value, | |||
| 520 | (ci->i_xattrs.index_version >= ci->i_xattrs.version)) { | 520 | (ci->i_xattrs.index_version >= ci->i_xattrs.version)) { |
| 521 | goto get_xattr; | 521 | goto get_xattr; |
| 522 | } else { | 522 | } else { |
| 523 | spin_unlock(&inode->i_lock); | 523 | spin_unlock(&ci->i_ceph_lock); |
| 524 | /* get xattrs from mds (if we don't already have them) */ | 524 | /* get xattrs from mds (if we don't already have them) */ |
| 525 | err = ceph_do_getattr(inode, CEPH_STAT_CAP_XATTR); | 525 | err = ceph_do_getattr(inode, CEPH_STAT_CAP_XATTR); |
| 526 | if (err) | 526 | if (err) |
| 527 | return err; | 527 | return err; |
| 528 | } | 528 | } |
| 529 | 529 | ||
| 530 | spin_lock(&inode->i_lock); | 530 | spin_lock(&ci->i_ceph_lock); |
| 531 | 531 | ||
| 532 | if (vxattr && vxattr->readonly) { | 532 | if (vxattr && vxattr->readonly) { |
| 533 | err = vxattr->getxattr_cb(ci, value, size); | 533 | err = vxattr->getxattr_cb(ci, value, size); |
| @@ -558,7 +558,7 @@ get_xattr: | |||
| 558 | memcpy(value, xattr->val, xattr->val_len); | 558 | memcpy(value, xattr->val, xattr->val_len); |
| 559 | 559 | ||
| 560 | out: | 560 | out: |
| 561 | spin_unlock(&inode->i_lock); | 561 | spin_unlock(&ci->i_ceph_lock); |
| 562 | return err; | 562 | return err; |
| 563 | } | 563 | } |
| 564 | 564 | ||
| @@ -573,7 +573,7 @@ ssize_t ceph_listxattr(struct dentry *dentry, char *names, size_t size) | |||
| 573 | u32 len; | 573 | u32 len; |
| 574 | int i; | 574 | int i; |
| 575 | 575 | ||
| 576 | spin_lock(&inode->i_lock); | 576 | spin_lock(&ci->i_ceph_lock); |
| 577 | dout("listxattr %p ver=%lld index_ver=%lld\n", inode, | 577 | dout("listxattr %p ver=%lld index_ver=%lld\n", inode, |
| 578 | ci->i_xattrs.version, ci->i_xattrs.index_version); | 578 | ci->i_xattrs.version, ci->i_xattrs.index_version); |
| 579 | 579 | ||
| @@ -581,13 +581,13 @@ ssize_t ceph_listxattr(struct dentry *dentry, char *names, size_t size) | |||
| 581 | (ci->i_xattrs.index_version >= ci->i_xattrs.version)) { | 581 | (ci->i_xattrs.index_version >= ci->i_xattrs.version)) { |
| 582 | goto list_xattr; | 582 | goto list_xattr; |
| 583 | } else { | 583 | } else { |
| 584 | spin_unlock(&inode->i_lock); | 584 | spin_unlock(&ci->i_ceph_lock); |
| 585 | err = ceph_do_getattr(inode, CEPH_STAT_CAP_XATTR); | 585 | err = ceph_do_getattr(inode, CEPH_STAT_CAP_XATTR); |
| 586 | if (err) | 586 | if (err) |
| 587 | return err; | 587 | return err; |
| 588 | } | 588 | } |
| 589 | 589 | ||
| 590 | spin_lock(&inode->i_lock); | 590 | spin_lock(&ci->i_ceph_lock); |
| 591 | 591 | ||
| 592 | err = __build_xattrs(inode); | 592 | err = __build_xattrs(inode); |
| 593 | if (err < 0) | 593 | if (err < 0) |
| @@ -619,7 +619,7 @@ list_xattr: | |||
| 619 | } | 619 | } |
| 620 | 620 | ||
| 621 | out: | 621 | out: |
| 622 | spin_unlock(&inode->i_lock); | 622 | spin_unlock(&ci->i_ceph_lock); |
| 623 | return err; | 623 | return err; |
| 624 | } | 624 | } |
| 625 | 625 | ||
| @@ -739,7 +739,7 @@ int ceph_setxattr(struct dentry *dentry, const char *name, | |||
| 739 | if (!xattr) | 739 | if (!xattr) |
| 740 | goto out; | 740 | goto out; |
| 741 | 741 | ||
| 742 | spin_lock(&inode->i_lock); | 742 | spin_lock(&ci->i_ceph_lock); |
| 743 | retry: | 743 | retry: |
| 744 | issued = __ceph_caps_issued(ci, NULL); | 744 | issued = __ceph_caps_issued(ci, NULL); |
| 745 | if (!(issued & CEPH_CAP_XATTR_EXCL)) | 745 | if (!(issued & CEPH_CAP_XATTR_EXCL)) |
| @@ -752,12 +752,12 @@ retry: | |||
| 752 | required_blob_size > ci->i_xattrs.prealloc_blob->alloc_len) { | 752 | required_blob_size > ci->i_xattrs.prealloc_blob->alloc_len) { |
| 753 | struct ceph_buffer *blob = NULL; | 753 | struct ceph_buffer *blob = NULL; |
| 754 | 754 | ||
| 755 | spin_unlock(&inode->i_lock); | 755 | spin_unlock(&ci->i_ceph_lock); |
| 756 | dout(" preaallocating new blob size=%d\n", required_blob_size); | 756 | dout(" preaallocating new blob size=%d\n", required_blob_size); |
| 757 | blob = ceph_buffer_new(required_blob_size, GFP_NOFS); | 757 | blob = ceph_buffer_new(required_blob_size, GFP_NOFS); |
| 758 | if (!blob) | 758 | if (!blob) |
| 759 | goto out; | 759 | goto out; |
| 760 | spin_lock(&inode->i_lock); | 760 | spin_lock(&ci->i_ceph_lock); |
| 761 | if (ci->i_xattrs.prealloc_blob) | 761 | if (ci->i_xattrs.prealloc_blob) |
| 762 | ceph_buffer_put(ci->i_xattrs.prealloc_blob); | 762 | ceph_buffer_put(ci->i_xattrs.prealloc_blob); |
| 763 | ci->i_xattrs.prealloc_blob = blob; | 763 | ci->i_xattrs.prealloc_blob = blob; |
| @@ -770,13 +770,13 @@ retry: | |||
| 770 | dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_XATTR_EXCL); | 770 | dirty = __ceph_mark_dirty_caps(ci, CEPH_CAP_XATTR_EXCL); |
| 771 | ci->i_xattrs.dirty = true; | 771 | ci->i_xattrs.dirty = true; |
| 772 | inode->i_ctime = CURRENT_TIME; | 772 | inode->i_ctime = CURRENT_TIME; |
| 773 | spin_unlock(&inode->i_lock); | 773 | spin_unlock(&ci->i_ceph_lock); |
| 774 | if (dirty) | 774 | if (dirty) |
| 775 | __mark_inode_dirty(inode, dirty); | 775 | __mark_inode_dirty(inode, dirty); |
| 776 | return err; | 776 | return err; |
| 777 | 777 | ||
| 778 | do_sync: | 778 | do_sync: |
| 779 | spin_unlock(&inode->i_lock); | 779 | spin_unlock(&ci->i_ceph_lock); |
| 780 | err = ceph_sync_setxattr(dentry, name, value, size, flags); | 780 | err = ceph_sync_setxattr(dentry, name, value, size, flags); |
| 781 | out: | 781 | out: |
| 782 | kfree(newname); | 782 | kfree(newname); |
| @@ -833,7 +833,7 @@ int ceph_removexattr(struct dentry *dentry, const char *name) | |||
| 833 | return -EOPNOTSUPP; | 833 | return -EOPNOTSUPP; |
| 834 | } | 834 | } |
| 835 | 835 | ||
| 836 | spin_lock(&inode->i_lock); | 836 | spin_lock(&ci->i_ceph_lock); |
| 837 | __build_xattrs(inode); | 837 | __build_xattrs(inode); |
| 838 | issued = __ceph_caps_issued(ci, NULL); | 838 | issued = __ceph_caps_issued(ci, NULL); |
| 839 | dout("removexattr %p issued %s\n", inode, ceph_cap_string(issued)); | 839 | dout("removexattr %p issued %s\n", inode, ceph_cap_string(issued)); |
| @@ -846,12 +846,12 @@ int ceph_removexattr(struct dentry *dentry, const char *name) | |||
| 846 | ci->i_xattrs.dirty = true; | 846 | ci->i_xattrs.dirty = true; |
| 847 | inode->i_ctime = CURRENT_TIME; | 847 | inode->i_ctime = CURRENT_TIME; |
| 848 | 848 | ||
| 849 | spin_unlock(&inode->i_lock); | 849 | spin_unlock(&ci->i_ceph_lock); |
| 850 | if (dirty) | 850 | if (dirty) |
| 851 | __mark_inode_dirty(inode, dirty); | 851 | __mark_inode_dirty(inode, dirty); |
| 852 | return err; | 852 | return err; |
| 853 | do_sync: | 853 | do_sync: |
| 854 | spin_unlock(&inode->i_lock); | 854 | spin_unlock(&ci->i_ceph_lock); |
| 855 | err = ceph_send_removexattr(dentry, name); | 855 | err = ceph_send_removexattr(dentry, name); |
| 856 | return err; | 856 | return err; |
| 857 | } | 857 | } |
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index d6a972df0338..8cd4b52d4217 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c | |||
| @@ -441,6 +441,8 @@ cifs_readv_from_socket(struct TCP_Server_Info *server, struct kvec *iov_orig, | |||
| 441 | smb_msg.msg_controllen = 0; | 441 | smb_msg.msg_controllen = 0; |
| 442 | 442 | ||
| 443 | for (total_read = 0; to_read; total_read += length, to_read -= length) { | 443 | for (total_read = 0; to_read; total_read += length, to_read -= length) { |
| 444 | try_to_freeze(); | ||
| 445 | |||
| 444 | if (server_unresponsive(server)) { | 446 | if (server_unresponsive(server)) { |
| 445 | total_read = -EAGAIN; | 447 | total_read = -EAGAIN; |
| 446 | break; | 448 | break; |
diff --git a/fs/cifs/file.c b/fs/cifs/file.c index cf0b1539b321..4dd9283885e7 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c | |||
| @@ -702,6 +702,13 @@ cifs_find_lock_conflict(struct cifsInodeInfo *cinode, struct cifsLockInfo *lock, | |||
| 702 | lock->type, lock->netfid, conf_lock); | 702 | lock->type, lock->netfid, conf_lock); |
| 703 | } | 703 | } |
| 704 | 704 | ||
| 705 | /* | ||
| 706 | * Check if there is another lock that prevents us to set the lock (mandatory | ||
| 707 | * style). If such a lock exists, update the flock structure with its | ||
| 708 | * properties. Otherwise, set the flock type to F_UNLCK if we can cache brlocks | ||
| 709 | * or leave it the same if we can't. Returns 0 if we don't need to request to | ||
| 710 | * the server or 1 otherwise. | ||
| 711 | */ | ||
| 705 | static int | 712 | static int |
| 706 | cifs_lock_test(struct cifsInodeInfo *cinode, __u64 offset, __u64 length, | 713 | cifs_lock_test(struct cifsInodeInfo *cinode, __u64 offset, __u64 length, |
| 707 | __u8 type, __u16 netfid, struct file_lock *flock) | 714 | __u8 type, __u16 netfid, struct file_lock *flock) |
| @@ -739,6 +746,12 @@ cifs_lock_add(struct cifsInodeInfo *cinode, struct cifsLockInfo *lock) | |||
| 739 | mutex_unlock(&cinode->lock_mutex); | 746 | mutex_unlock(&cinode->lock_mutex); |
| 740 | } | 747 | } |
| 741 | 748 | ||
| 749 | /* | ||
| 750 | * Set the byte-range lock (mandatory style). Returns: | ||
| 751 | * 1) 0, if we set the lock and don't need to request to the server; | ||
| 752 | * 2) 1, if no locks prevent us but we need to request to the server; | ||
| 753 | * 3) -EACCESS, if there is a lock that prevents us and wait is false. | ||
| 754 | */ | ||
| 742 | static int | 755 | static int |
| 743 | cifs_lock_add_if(struct cifsInodeInfo *cinode, struct cifsLockInfo *lock, | 756 | cifs_lock_add_if(struct cifsInodeInfo *cinode, struct cifsLockInfo *lock, |
| 744 | bool wait) | 757 | bool wait) |
| @@ -778,6 +791,13 @@ try_again: | |||
| 778 | return rc; | 791 | return rc; |
| 779 | } | 792 | } |
| 780 | 793 | ||
| 794 | /* | ||
| 795 | * Check if there is another lock that prevents us to set the lock (posix | ||
| 796 | * style). If such a lock exists, update the flock structure with its | ||
| 797 | * properties. Otherwise, set the flock type to F_UNLCK if we can cache brlocks | ||
| 798 | * or leave it the same if we can't. Returns 0 if we don't need to request to | ||
| 799 | * the server or 1 otherwise. | ||
| 800 | */ | ||
| 781 | static int | 801 | static int |
| 782 | cifs_posix_lock_test(struct file *file, struct file_lock *flock) | 802 | cifs_posix_lock_test(struct file *file, struct file_lock *flock) |
| 783 | { | 803 | { |
| @@ -800,6 +820,12 @@ cifs_posix_lock_test(struct file *file, struct file_lock *flock) | |||
| 800 | return rc; | 820 | return rc; |
| 801 | } | 821 | } |
| 802 | 822 | ||
| 823 | /* | ||
| 824 | * Set the byte-range lock (posix style). Returns: | ||
| 825 | * 1) 0, if we set the lock and don't need to request to the server; | ||
| 826 | * 2) 1, if we need to request to the server; | ||
| 827 | * 3) <0, if the error occurs while setting the lock. | ||
| 828 | */ | ||
| 803 | static int | 829 | static int |
| 804 | cifs_posix_lock_set(struct file *file, struct file_lock *flock) | 830 | cifs_posix_lock_set(struct file *file, struct file_lock *flock) |
| 805 | { | 831 | { |
diff --git a/fs/cifs/readdir.c b/fs/cifs/readdir.c index 5de03ec20144..a090bbe6ee29 100644 --- a/fs/cifs/readdir.c +++ b/fs/cifs/readdir.c | |||
| @@ -554,7 +554,10 @@ static int find_cifs_entry(const int xid, struct cifs_tcon *pTcon, | |||
| 554 | rc); | 554 | rc); |
| 555 | return rc; | 555 | return rc; |
| 556 | } | 556 | } |
| 557 | cifs_save_resume_key(cifsFile->srch_inf.last_entry, cifsFile); | 557 | /* FindFirst/Next set last_entry to NULL on malformed reply */ |
| 558 | if (cifsFile->srch_inf.last_entry) | ||
| 559 | cifs_save_resume_key(cifsFile->srch_inf.last_entry, | ||
| 560 | cifsFile); | ||
| 558 | } | 561 | } |
| 559 | 562 | ||
| 560 | while ((index_to_find >= cifsFile->srch_inf.index_of_last_entry) && | 563 | while ((index_to_find >= cifsFile->srch_inf.index_of_last_entry) && |
| @@ -562,7 +565,10 @@ static int find_cifs_entry(const int xid, struct cifs_tcon *pTcon, | |||
| 562 | cFYI(1, "calling findnext2"); | 565 | cFYI(1, "calling findnext2"); |
| 563 | rc = CIFSFindNext(xid, pTcon, cifsFile->netfid, | 566 | rc = CIFSFindNext(xid, pTcon, cifsFile->netfid, |
| 564 | &cifsFile->srch_inf); | 567 | &cifsFile->srch_inf); |
| 565 | cifs_save_resume_key(cifsFile->srch_inf.last_entry, cifsFile); | 568 | /* FindFirst/Next set last_entry to NULL on malformed reply */ |
| 569 | if (cifsFile->srch_inf.last_entry) | ||
| 570 | cifs_save_resume_key(cifsFile->srch_inf.last_entry, | ||
| 571 | cifsFile); | ||
| 566 | if (rc) | 572 | if (rc) |
| 567 | return -ENOENT; | 573 | return -ENOENT; |
| 568 | } | 574 | } |
diff --git a/fs/cifs/smbencrypt.c b/fs/cifs/smbencrypt.c index 7cacba12b8f1..80d850881938 100644 --- a/fs/cifs/smbencrypt.c +++ b/fs/cifs/smbencrypt.c | |||
| @@ -209,7 +209,7 @@ E_md4hash(const unsigned char *passwd, unsigned char *p16, | |||
| 209 | { | 209 | { |
| 210 | int rc; | 210 | int rc; |
| 211 | int len; | 211 | int len; |
| 212 | __u16 wpwd[129]; | 212 | __le16 wpwd[129]; |
| 213 | 213 | ||
| 214 | /* Password cannot be longer than 128 characters */ | 214 | /* Password cannot be longer than 128 characters */ |
| 215 | if (passwd) /* Password must be converted to NT unicode */ | 215 | if (passwd) /* Password must be converted to NT unicode */ |
| @@ -219,8 +219,8 @@ E_md4hash(const unsigned char *passwd, unsigned char *p16, | |||
| 219 | *wpwd = 0; /* Ensure string is null terminated */ | 219 | *wpwd = 0; /* Ensure string is null terminated */ |
| 220 | } | 220 | } |
| 221 | 221 | ||
| 222 | rc = mdfour(p16, (unsigned char *) wpwd, len * sizeof(__u16)); | 222 | rc = mdfour(p16, (unsigned char *) wpwd, len * sizeof(__le16)); |
| 223 | memset(wpwd, 0, 129 * sizeof(__u16)); | 223 | memset(wpwd, 0, 129 * sizeof(__le16)); |
| 224 | 224 | ||
| 225 | return rc; | 225 | return rc; |
| 226 | } | 226 | } |
diff --git a/fs/configfs/inode.c b/fs/configfs/inode.c index ca418aaf6352..9d8715c45f25 100644 --- a/fs/configfs/inode.c +++ b/fs/configfs/inode.c | |||
| @@ -292,7 +292,7 @@ int __init configfs_inode_init(void) | |||
| 292 | return bdi_init(&configfs_backing_dev_info); | 292 | return bdi_init(&configfs_backing_dev_info); |
| 293 | } | 293 | } |
| 294 | 294 | ||
| 295 | void __exit configfs_inode_exit(void) | 295 | void configfs_inode_exit(void) |
| 296 | { | 296 | { |
| 297 | bdi_destroy(&configfs_backing_dev_info); | 297 | bdi_destroy(&configfs_backing_dev_info); |
| 298 | } | 298 | } |
diff --git a/fs/configfs/mount.c b/fs/configfs/mount.c index ecc62178beda..276e15cafd58 100644 --- a/fs/configfs/mount.c +++ b/fs/configfs/mount.c | |||
| @@ -143,28 +143,26 @@ static int __init configfs_init(void) | |||
| 143 | goto out; | 143 | goto out; |
| 144 | 144 | ||
| 145 | config_kobj = kobject_create_and_add("config", kernel_kobj); | 145 | config_kobj = kobject_create_and_add("config", kernel_kobj); |
| 146 | if (!config_kobj) { | 146 | if (!config_kobj) |
| 147 | kmem_cache_destroy(configfs_dir_cachep); | 147 | goto out2; |
| 148 | configfs_dir_cachep = NULL; | 148 | |
| 149 | goto out; | 149 | err = configfs_inode_init(); |
| 150 | } | 150 | if (err) |
| 151 | goto out3; | ||
| 151 | 152 | ||
| 152 | err = register_filesystem(&configfs_fs_type); | 153 | err = register_filesystem(&configfs_fs_type); |
| 153 | if (err) { | 154 | if (err) |
| 154 | printk(KERN_ERR "configfs: Unable to register filesystem!\n"); | 155 | goto out4; |
| 155 | kobject_put(config_kobj); | ||
| 156 | kmem_cache_destroy(configfs_dir_cachep); | ||
| 157 | configfs_dir_cachep = NULL; | ||
| 158 | goto out; | ||
| 159 | } | ||
| 160 | 156 | ||
| 161 | err = configfs_inode_init(); | 157 | return 0; |
| 162 | if (err) { | 158 | out4: |
| 163 | unregister_filesystem(&configfs_fs_type); | 159 | printk(KERN_ERR "configfs: Unable to register filesystem!\n"); |
| 164 | kobject_put(config_kobj); | 160 | configfs_inode_exit(); |
| 165 | kmem_cache_destroy(configfs_dir_cachep); | 161 | out3: |
| 166 | configfs_dir_cachep = NULL; | 162 | kobject_put(config_kobj); |
| 167 | } | 163 | out2: |
| 164 | kmem_cache_destroy(configfs_dir_cachep); | ||
| 165 | configfs_dir_cachep = NULL; | ||
| 168 | out: | 166 | out: |
| 169 | return err; | 167 | return err; |
| 170 | } | 168 | } |
diff --git a/fs/dcache.c b/fs/dcache.c index 10ba92def3f6..89509b5a090e 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
| @@ -2439,16 +2439,14 @@ static int prepend_name(char **buffer, int *buflen, struct qstr *name) | |||
| 2439 | /** | 2439 | /** |
| 2440 | * prepend_path - Prepend path string to a buffer | 2440 | * prepend_path - Prepend path string to a buffer |
| 2441 | * @path: the dentry/vfsmount to report | 2441 | * @path: the dentry/vfsmount to report |
| 2442 | * @root: root vfsmnt/dentry (may be modified by this function) | 2442 | * @root: root vfsmnt/dentry |
| 2443 | * @buffer: pointer to the end of the buffer | 2443 | * @buffer: pointer to the end of the buffer |
| 2444 | * @buflen: pointer to buffer length | 2444 | * @buflen: pointer to buffer length |
| 2445 | * | 2445 | * |
| 2446 | * Caller holds the rename_lock. | 2446 | * Caller holds the rename_lock. |
| 2447 | * | ||
| 2448 | * If path is not reachable from the supplied root, then the value of | ||
| 2449 | * root is changed (without modifying refcounts). | ||
| 2450 | */ | 2447 | */ |
| 2451 | static int prepend_path(const struct path *path, struct path *root, | 2448 | static int prepend_path(const struct path *path, |
| 2449 | const struct path *root, | ||
| 2452 | char **buffer, int *buflen) | 2450 | char **buffer, int *buflen) |
| 2453 | { | 2451 | { |
| 2454 | struct dentry *dentry = path->dentry; | 2452 | struct dentry *dentry = path->dentry; |
| @@ -2483,10 +2481,10 @@ static int prepend_path(const struct path *path, struct path *root, | |||
| 2483 | dentry = parent; | 2481 | dentry = parent; |
| 2484 | } | 2482 | } |
| 2485 | 2483 | ||
| 2486 | out: | ||
| 2487 | if (!error && !slash) | 2484 | if (!error && !slash) |
| 2488 | error = prepend(buffer, buflen, "/", 1); | 2485 | error = prepend(buffer, buflen, "/", 1); |
| 2489 | 2486 | ||
| 2487 | out: | ||
| 2490 | br_read_unlock(vfsmount_lock); | 2488 | br_read_unlock(vfsmount_lock); |
| 2491 | return error; | 2489 | return error; |
| 2492 | 2490 | ||
| @@ -2500,15 +2498,17 @@ global_root: | |||
| 2500 | WARN(1, "Root dentry has weird name <%.*s>\n", | 2498 | WARN(1, "Root dentry has weird name <%.*s>\n", |
| 2501 | (int) dentry->d_name.len, dentry->d_name.name); | 2499 | (int) dentry->d_name.len, dentry->d_name.name); |
| 2502 | } | 2500 | } |
| 2503 | root->mnt = vfsmnt; | 2501 | if (!slash) |
| 2504 | root->dentry = dentry; | 2502 | error = prepend(buffer, buflen, "/", 1); |
| 2503 | if (!error) | ||
| 2504 | error = vfsmnt->mnt_ns ? 1 : 2; | ||
| 2505 | goto out; | 2505 | goto out; |
| 2506 | } | 2506 | } |
| 2507 | 2507 | ||
| 2508 | /** | 2508 | /** |
| 2509 | * __d_path - return the path of a dentry | 2509 | * __d_path - return the path of a dentry |
| 2510 | * @path: the dentry/vfsmount to report | 2510 | * @path: the dentry/vfsmount to report |
| 2511 | * @root: root vfsmnt/dentry (may be modified by this function) | 2511 | * @root: root vfsmnt/dentry |
| 2512 | * @buf: buffer to return value in | 2512 | * @buf: buffer to return value in |
| 2513 | * @buflen: buffer length | 2513 | * @buflen: buffer length |
| 2514 | * | 2514 | * |
| @@ -2519,10 +2519,10 @@ global_root: | |||
| 2519 | * | 2519 | * |
| 2520 | * "buflen" should be positive. | 2520 | * "buflen" should be positive. |
| 2521 | * | 2521 | * |
| 2522 | * If path is not reachable from the supplied root, then the value of | 2522 | * If the path is not reachable from the supplied root, return %NULL. |
| 2523 | * root is changed (without modifying refcounts). | ||
| 2524 | */ | 2523 | */ |
| 2525 | char *__d_path(const struct path *path, struct path *root, | 2524 | char *__d_path(const struct path *path, |
| 2525 | const struct path *root, | ||
| 2526 | char *buf, int buflen) | 2526 | char *buf, int buflen) |
| 2527 | { | 2527 | { |
| 2528 | char *res = buf + buflen; | 2528 | char *res = buf + buflen; |
| @@ -2533,7 +2533,28 @@ char *__d_path(const struct path *path, struct path *root, | |||
| 2533 | error = prepend_path(path, root, &res, &buflen); | 2533 | error = prepend_path(path, root, &res, &buflen); |
| 2534 | write_sequnlock(&rename_lock); | 2534 | write_sequnlock(&rename_lock); |
| 2535 | 2535 | ||
| 2536 | if (error) | 2536 | if (error < 0) |
| 2537 | return ERR_PTR(error); | ||
| 2538 | if (error > 0) | ||
| 2539 | return NULL; | ||
| 2540 | return res; | ||
| 2541 | } | ||
| 2542 | |||
| 2543 | char *d_absolute_path(const struct path *path, | ||
| 2544 | char *buf, int buflen) | ||
| 2545 | { | ||
| 2546 | struct path root = {}; | ||
| 2547 | char *res = buf + buflen; | ||
| 2548 | int error; | ||
| 2549 | |||
| 2550 | prepend(&res, &buflen, "\0", 1); | ||
| 2551 | write_seqlock(&rename_lock); | ||
| 2552 | error = prepend_path(path, &root, &res, &buflen); | ||
| 2553 | write_sequnlock(&rename_lock); | ||
| 2554 | |||
| 2555 | if (error > 1) | ||
| 2556 | error = -EINVAL; | ||
| 2557 | if (error < 0) | ||
| 2537 | return ERR_PTR(error); | 2558 | return ERR_PTR(error); |
| 2538 | return res; | 2559 | return res; |
| 2539 | } | 2560 | } |
| @@ -2541,8 +2562,9 @@ char *__d_path(const struct path *path, struct path *root, | |||
| 2541 | /* | 2562 | /* |
| 2542 | * same as __d_path but appends "(deleted)" for unlinked files. | 2563 | * same as __d_path but appends "(deleted)" for unlinked files. |
| 2543 | */ | 2564 | */ |
| 2544 | static int path_with_deleted(const struct path *path, struct path *root, | 2565 | static int path_with_deleted(const struct path *path, |
| 2545 | char **buf, int *buflen) | 2566 | const struct path *root, |
| 2567 | char **buf, int *buflen) | ||
| 2546 | { | 2568 | { |
| 2547 | prepend(buf, buflen, "\0", 1); | 2569 | prepend(buf, buflen, "\0", 1); |
| 2548 | if (d_unlinked(path->dentry)) { | 2570 | if (d_unlinked(path->dentry)) { |
| @@ -2579,7 +2601,6 @@ char *d_path(const struct path *path, char *buf, int buflen) | |||
| 2579 | { | 2601 | { |
| 2580 | char *res = buf + buflen; | 2602 | char *res = buf + buflen; |
| 2581 | struct path root; | 2603 | struct path root; |
| 2582 | struct path tmp; | ||
| 2583 | int error; | 2604 | int error; |
| 2584 | 2605 | ||
| 2585 | /* | 2606 | /* |
| @@ -2594,9 +2615,8 @@ char *d_path(const struct path *path, char *buf, int buflen) | |||
| 2594 | 2615 | ||
| 2595 | get_fs_root(current->fs, &root); | 2616 | get_fs_root(current->fs, &root); |
| 2596 | write_seqlock(&rename_lock); | 2617 | write_seqlock(&rename_lock); |
| 2597 | tmp = root; | 2618 | error = path_with_deleted(path, &root, &res, &buflen); |
| 2598 | error = path_with_deleted(path, &tmp, &res, &buflen); | 2619 | if (error < 0) |
| 2599 | if (error) | ||
| 2600 | res = ERR_PTR(error); | 2620 | res = ERR_PTR(error); |
| 2601 | write_sequnlock(&rename_lock); | 2621 | write_sequnlock(&rename_lock); |
| 2602 | path_put(&root); | 2622 | path_put(&root); |
| @@ -2617,7 +2637,6 @@ char *d_path_with_unreachable(const struct path *path, char *buf, int buflen) | |||
| 2617 | { | 2637 | { |
| 2618 | char *res = buf + buflen; | 2638 | char *res = buf + buflen; |
| 2619 | struct path root; | 2639 | struct path root; |
| 2620 | struct path tmp; | ||
| 2621 | int error; | 2640 | int error; |
| 2622 | 2641 | ||
| 2623 | if (path->dentry->d_op && path->dentry->d_op->d_dname) | 2642 | if (path->dentry->d_op && path->dentry->d_op->d_dname) |
| @@ -2625,9 +2644,8 @@ char *d_path_with_unreachable(const struct path *path, char *buf, int buflen) | |||
| 2625 | 2644 | ||
| 2626 | get_fs_root(current->fs, &root); | 2645 | get_fs_root(current->fs, &root); |
| 2627 | write_seqlock(&rename_lock); | 2646 | write_seqlock(&rename_lock); |
| 2628 | tmp = root; | 2647 | error = path_with_deleted(path, &root, &res, &buflen); |
| 2629 | error = path_with_deleted(path, &tmp, &res, &buflen); | 2648 | if (error > 0) |
| 2630 | if (!error && !path_equal(&tmp, &root)) | ||
| 2631 | error = prepend_unreachable(&res, &buflen); | 2649 | error = prepend_unreachable(&res, &buflen); |
| 2632 | write_sequnlock(&rename_lock); | 2650 | write_sequnlock(&rename_lock); |
| 2633 | path_put(&root); | 2651 | path_put(&root); |
| @@ -2758,19 +2776,18 @@ SYSCALL_DEFINE2(getcwd, char __user *, buf, unsigned long, size) | |||
| 2758 | write_seqlock(&rename_lock); | 2776 | write_seqlock(&rename_lock); |
| 2759 | if (!d_unlinked(pwd.dentry)) { | 2777 | if (!d_unlinked(pwd.dentry)) { |
| 2760 | unsigned long len; | 2778 | unsigned long len; |
| 2761 | struct path tmp = root; | ||
| 2762 | char *cwd = page + PAGE_SIZE; | 2779 | char *cwd = page + PAGE_SIZE; |
| 2763 | int buflen = PAGE_SIZE; | 2780 | int buflen = PAGE_SIZE; |
| 2764 | 2781 | ||
| 2765 | prepend(&cwd, &buflen, "\0", 1); | 2782 | prepend(&cwd, &buflen, "\0", 1); |
| 2766 | error = prepend_path(&pwd, &tmp, &cwd, &buflen); | 2783 | error = prepend_path(&pwd, &root, &cwd, &buflen); |
| 2767 | write_sequnlock(&rename_lock); | 2784 | write_sequnlock(&rename_lock); |
| 2768 | 2785 | ||
| 2769 | if (error) | 2786 | if (error < 0) |
| 2770 | goto out; | 2787 | goto out; |
| 2771 | 2788 | ||
| 2772 | /* Unreachable from current root */ | 2789 | /* Unreachable from current root */ |
| 2773 | if (!path_equal(&tmp, &root)) { | 2790 | if (error > 0) { |
| 2774 | error = prepend_unreachable(&cwd, &buflen); | 2791 | error = prepend_unreachable(&cwd, &buflen); |
| 2775 | if (error) | 2792 | if (error) |
| 2776 | goto out; | 2793 | goto out; |
diff --git a/fs/ecryptfs/crypto.c b/fs/ecryptfs/crypto.c index 58609bde3b9f..2a834255c75d 100644 --- a/fs/ecryptfs/crypto.c +++ b/fs/ecryptfs/crypto.c | |||
| @@ -967,7 +967,7 @@ static void ecryptfs_set_default_crypt_stat_vals( | |||
| 967 | 967 | ||
| 968 | /** | 968 | /** |
| 969 | * ecryptfs_new_file_context | 969 | * ecryptfs_new_file_context |
| 970 | * @ecryptfs_dentry: The eCryptfs dentry | 970 | * @ecryptfs_inode: The eCryptfs inode |
| 971 | * | 971 | * |
| 972 | * If the crypto context for the file has not yet been established, | 972 | * If the crypto context for the file has not yet been established, |
| 973 | * this is where we do that. Establishing a new crypto context | 973 | * this is where we do that. Establishing a new crypto context |
| @@ -984,13 +984,13 @@ static void ecryptfs_set_default_crypt_stat_vals( | |||
| 984 | * | 984 | * |
| 985 | * Returns zero on success; non-zero otherwise | 985 | * Returns zero on success; non-zero otherwise |
| 986 | */ | 986 | */ |
| 987 | int ecryptfs_new_file_context(struct dentry *ecryptfs_dentry) | 987 | int ecryptfs_new_file_context(struct inode *ecryptfs_inode) |
| 988 | { | 988 | { |
| 989 | struct ecryptfs_crypt_stat *crypt_stat = | 989 | struct ecryptfs_crypt_stat *crypt_stat = |
| 990 | &ecryptfs_inode_to_private(ecryptfs_dentry->d_inode)->crypt_stat; | 990 | &ecryptfs_inode_to_private(ecryptfs_inode)->crypt_stat; |
| 991 | struct ecryptfs_mount_crypt_stat *mount_crypt_stat = | 991 | struct ecryptfs_mount_crypt_stat *mount_crypt_stat = |
| 992 | &ecryptfs_superblock_to_private( | 992 | &ecryptfs_superblock_to_private( |
| 993 | ecryptfs_dentry->d_sb)->mount_crypt_stat; | 993 | ecryptfs_inode->i_sb)->mount_crypt_stat; |
| 994 | int cipher_name_len; | 994 | int cipher_name_len; |
| 995 | int rc = 0; | 995 | int rc = 0; |
| 996 | 996 | ||
| @@ -1299,12 +1299,12 @@ static int ecryptfs_write_headers_virt(char *page_virt, size_t max, | |||
| 1299 | } | 1299 | } |
| 1300 | 1300 | ||
| 1301 | static int | 1301 | static int |
| 1302 | ecryptfs_write_metadata_to_contents(struct dentry *ecryptfs_dentry, | 1302 | ecryptfs_write_metadata_to_contents(struct inode *ecryptfs_inode, |
| 1303 | char *virt, size_t virt_len) | 1303 | char *virt, size_t virt_len) |
| 1304 | { | 1304 | { |
| 1305 | int rc; | 1305 | int rc; |
| 1306 | 1306 | ||
| 1307 | rc = ecryptfs_write_lower(ecryptfs_dentry->d_inode, virt, | 1307 | rc = ecryptfs_write_lower(ecryptfs_inode, virt, |
| 1308 | 0, virt_len); | 1308 | 0, virt_len); |
| 1309 | if (rc < 0) | 1309 | if (rc < 0) |
| 1310 | printk(KERN_ERR "%s: Error attempting to write header " | 1310 | printk(KERN_ERR "%s: Error attempting to write header " |
| @@ -1338,7 +1338,8 @@ static unsigned long ecryptfs_get_zeroed_pages(gfp_t gfp_mask, | |||
| 1338 | 1338 | ||
| 1339 | /** | 1339 | /** |
| 1340 | * ecryptfs_write_metadata | 1340 | * ecryptfs_write_metadata |
| 1341 | * @ecryptfs_dentry: The eCryptfs dentry | 1341 | * @ecryptfs_dentry: The eCryptfs dentry, which should be negative |
| 1342 | * @ecryptfs_inode: The newly created eCryptfs inode | ||
| 1342 | * | 1343 | * |
| 1343 | * Write the file headers out. This will likely involve a userspace | 1344 | * Write the file headers out. This will likely involve a userspace |
| 1344 | * callout, in which the session key is encrypted with one or more | 1345 | * callout, in which the session key is encrypted with one or more |
| @@ -1348,10 +1349,11 @@ static unsigned long ecryptfs_get_zeroed_pages(gfp_t gfp_mask, | |||
| 1348 | * | 1349 | * |
| 1349 | * Returns zero on success; non-zero on error | 1350 | * Returns zero on success; non-zero on error |
| 1350 | */ | 1351 | */ |
| 1351 | int ecryptfs_write_metadata(struct dentry *ecryptfs_dentry) | 1352 | int ecryptfs_write_metadata(struct dentry *ecryptfs_dentry, |
| 1353 | struct inode *ecryptfs_inode) | ||
| 1352 | { | 1354 | { |
| 1353 | struct ecryptfs_crypt_stat *crypt_stat = | 1355 | struct ecryptfs_crypt_stat *crypt_stat = |
| 1354 | &ecryptfs_inode_to_private(ecryptfs_dentry->d_inode)->crypt_stat; | 1356 | &ecryptfs_inode_to_private(ecryptfs_inode)->crypt_stat; |
| 1355 | unsigned int order; | 1357 | unsigned int order; |
| 1356 | char *virt; | 1358 | char *virt; |
| 1357 | size_t virt_len; | 1359 | size_t virt_len; |
| @@ -1391,7 +1393,7 @@ int ecryptfs_write_metadata(struct dentry *ecryptfs_dentry) | |||
| 1391 | rc = ecryptfs_write_metadata_to_xattr(ecryptfs_dentry, virt, | 1393 | rc = ecryptfs_write_metadata_to_xattr(ecryptfs_dentry, virt, |
| 1392 | size); | 1394 | size); |
| 1393 | else | 1395 | else |
| 1394 | rc = ecryptfs_write_metadata_to_contents(ecryptfs_dentry, virt, | 1396 | rc = ecryptfs_write_metadata_to_contents(ecryptfs_inode, virt, |
| 1395 | virt_len); | 1397 | virt_len); |
| 1396 | if (rc) { | 1398 | if (rc) { |
| 1397 | printk(KERN_ERR "%s: Error writing metadata out to lower file; " | 1399 | printk(KERN_ERR "%s: Error writing metadata out to lower file; " |
| @@ -1943,7 +1945,7 @@ static unsigned char *portable_filename_chars = ("-.0123456789ABCD" | |||
| 1943 | 1945 | ||
| 1944 | /* We could either offset on every reverse map or just pad some 0x00's | 1946 | /* We could either offset on every reverse map or just pad some 0x00's |
| 1945 | * at the front here */ | 1947 | * at the front here */ |
| 1946 | static const unsigned char filename_rev_map[] = { | 1948 | static const unsigned char filename_rev_map[256] = { |
| 1947 | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 7 */ | 1949 | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 7 */ |
| 1948 | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 15 */ | 1950 | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 15 */ |
| 1949 | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 23 */ | 1951 | 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, /* 23 */ |
| @@ -1959,7 +1961,7 @@ static const unsigned char filename_rev_map[] = { | |||
| 1959 | 0x00, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x2B, 0x2C, /* 103 */ | 1961 | 0x00, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x2B, 0x2C, /* 103 */ |
| 1960 | 0x2D, 0x2E, 0x2F, 0x30, 0x31, 0x32, 0x33, 0x34, /* 111 */ | 1962 | 0x2D, 0x2E, 0x2F, 0x30, 0x31, 0x32, 0x33, 0x34, /* 111 */ |
| 1961 | 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x3B, 0x3C, /* 119 */ | 1963 | 0x35, 0x36, 0x37, 0x38, 0x39, 0x3A, 0x3B, 0x3C, /* 119 */ |
| 1962 | 0x3D, 0x3E, 0x3F | 1964 | 0x3D, 0x3E, 0x3F /* 123 - 255 initialized to 0x00 */ |
| 1963 | }; | 1965 | }; |
| 1964 | 1966 | ||
| 1965 | /** | 1967 | /** |
diff --git a/fs/ecryptfs/ecryptfs_kernel.h b/fs/ecryptfs/ecryptfs_kernel.h index 54481a3b2c79..a9f29b12fbf2 100644 --- a/fs/ecryptfs/ecryptfs_kernel.h +++ b/fs/ecryptfs/ecryptfs_kernel.h | |||
| @@ -584,9 +584,10 @@ int ecryptfs_init_crypt_ctx(struct ecryptfs_crypt_stat *crypt_stat); | |||
| 584 | int ecryptfs_write_inode_size_to_metadata(struct inode *ecryptfs_inode); | 584 | int ecryptfs_write_inode_size_to_metadata(struct inode *ecryptfs_inode); |
| 585 | int ecryptfs_encrypt_page(struct page *page); | 585 | int ecryptfs_encrypt_page(struct page *page); |
| 586 | int ecryptfs_decrypt_page(struct page *page); | 586 | int ecryptfs_decrypt_page(struct page *page); |
| 587 | int ecryptfs_write_metadata(struct dentry *ecryptfs_dentry); | 587 | int ecryptfs_write_metadata(struct dentry *ecryptfs_dentry, |
| 588 | struct inode *ecryptfs_inode); | ||
| 588 | int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry); | 589 | int ecryptfs_read_metadata(struct dentry *ecryptfs_dentry); |
| 589 | int ecryptfs_new_file_context(struct dentry *ecryptfs_dentry); | 590 | int ecryptfs_new_file_context(struct inode *ecryptfs_inode); |
| 590 | void ecryptfs_write_crypt_stat_flags(char *page_virt, | 591 | void ecryptfs_write_crypt_stat_flags(char *page_virt, |
| 591 | struct ecryptfs_crypt_stat *crypt_stat, | 592 | struct ecryptfs_crypt_stat *crypt_stat, |
| 592 | size_t *written); | 593 | size_t *written); |
diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index c6ac98cf9baa..d3f95f941c47 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c | |||
| @@ -139,6 +139,27 @@ out: | |||
| 139 | return rc; | 139 | return rc; |
| 140 | } | 140 | } |
| 141 | 141 | ||
| 142 | static void ecryptfs_vma_close(struct vm_area_struct *vma) | ||
| 143 | { | ||
| 144 | filemap_write_and_wait(vma->vm_file->f_mapping); | ||
| 145 | } | ||
| 146 | |||
| 147 | static const struct vm_operations_struct ecryptfs_file_vm_ops = { | ||
| 148 | .close = ecryptfs_vma_close, | ||
| 149 | .fault = filemap_fault, | ||
| 150 | }; | ||
| 151 | |||
| 152 | static int ecryptfs_file_mmap(struct file *file, struct vm_area_struct *vma) | ||
| 153 | { | ||
| 154 | int rc; | ||
| 155 | |||
| 156 | rc = generic_file_mmap(file, vma); | ||
| 157 | if (!rc) | ||
| 158 | vma->vm_ops = &ecryptfs_file_vm_ops; | ||
| 159 | |||
| 160 | return rc; | ||
| 161 | } | ||
| 162 | |||
| 142 | struct kmem_cache *ecryptfs_file_info_cache; | 163 | struct kmem_cache *ecryptfs_file_info_cache; |
| 143 | 164 | ||
| 144 | /** | 165 | /** |
| @@ -349,7 +370,7 @@ const struct file_operations ecryptfs_main_fops = { | |||
| 349 | #ifdef CONFIG_COMPAT | 370 | #ifdef CONFIG_COMPAT |
| 350 | .compat_ioctl = ecryptfs_compat_ioctl, | 371 | .compat_ioctl = ecryptfs_compat_ioctl, |
| 351 | #endif | 372 | #endif |
| 352 | .mmap = generic_file_mmap, | 373 | .mmap = ecryptfs_file_mmap, |
| 353 | .open = ecryptfs_open, | 374 | .open = ecryptfs_open, |
| 354 | .flush = ecryptfs_flush, | 375 | .flush = ecryptfs_flush, |
| 355 | .release = ecryptfs_release, | 376 | .release = ecryptfs_release, |
diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c index a36d327f1521..32f90a3ae63e 100644 --- a/fs/ecryptfs/inode.c +++ b/fs/ecryptfs/inode.c | |||
| @@ -172,22 +172,23 @@ ecryptfs_create_underlying_file(struct inode *lower_dir_inode, | |||
| 172 | * it. It will also update the eCryptfs directory inode to mimic the | 172 | * it. It will also update the eCryptfs directory inode to mimic the |
| 173 | * stat of the lower directory inode. | 173 | * stat of the lower directory inode. |
| 174 | * | 174 | * |
| 175 | * Returns zero on success; non-zero on error condition | 175 | * Returns the new eCryptfs inode on success; an ERR_PTR on error condition |
| 176 | */ | 176 | */ |
| 177 | static int | 177 | static struct inode * |
| 178 | ecryptfs_do_create(struct inode *directory_inode, | 178 | ecryptfs_do_create(struct inode *directory_inode, |
| 179 | struct dentry *ecryptfs_dentry, int mode) | 179 | struct dentry *ecryptfs_dentry, int mode) |
| 180 | { | 180 | { |
| 181 | int rc; | 181 | int rc; |
| 182 | struct dentry *lower_dentry; | 182 | struct dentry *lower_dentry; |
| 183 | struct dentry *lower_dir_dentry; | 183 | struct dentry *lower_dir_dentry; |
| 184 | struct inode *inode; | ||
| 184 | 185 | ||
| 185 | lower_dentry = ecryptfs_dentry_to_lower(ecryptfs_dentry); | 186 | lower_dentry = ecryptfs_dentry_to_lower(ecryptfs_dentry); |
| 186 | lower_dir_dentry = lock_parent(lower_dentry); | 187 | lower_dir_dentry = lock_parent(lower_dentry); |
| 187 | if (IS_ERR(lower_dir_dentry)) { | 188 | if (IS_ERR(lower_dir_dentry)) { |
| 188 | ecryptfs_printk(KERN_ERR, "Error locking directory of " | 189 | ecryptfs_printk(KERN_ERR, "Error locking directory of " |
| 189 | "dentry\n"); | 190 | "dentry\n"); |
| 190 | rc = PTR_ERR(lower_dir_dentry); | 191 | inode = ERR_CAST(lower_dir_dentry); |
| 191 | goto out; | 192 | goto out; |
| 192 | } | 193 | } |
| 193 | rc = ecryptfs_create_underlying_file(lower_dir_dentry->d_inode, | 194 | rc = ecryptfs_create_underlying_file(lower_dir_dentry->d_inode, |
| @@ -195,20 +196,19 @@ ecryptfs_do_create(struct inode *directory_inode, | |||
| 195 | if (rc) { | 196 | if (rc) { |
| 196 | printk(KERN_ERR "%s: Failure to create dentry in lower fs; " | 197 | printk(KERN_ERR "%s: Failure to create dentry in lower fs; " |
| 197 | "rc = [%d]\n", __func__, rc); | 198 | "rc = [%d]\n", __func__, rc); |
| 199 | inode = ERR_PTR(rc); | ||
| 198 | goto out_lock; | 200 | goto out_lock; |
| 199 | } | 201 | } |
| 200 | rc = ecryptfs_interpose(lower_dentry, ecryptfs_dentry, | 202 | inode = __ecryptfs_get_inode(lower_dentry->d_inode, |
| 201 | directory_inode->i_sb); | 203 | directory_inode->i_sb); |
| 202 | if (rc) { | 204 | if (IS_ERR(inode)) |
| 203 | ecryptfs_printk(KERN_ERR, "Failure in ecryptfs_interpose\n"); | ||
| 204 | goto out_lock; | 205 | goto out_lock; |
| 205 | } | ||
| 206 | fsstack_copy_attr_times(directory_inode, lower_dir_dentry->d_inode); | 206 | fsstack_copy_attr_times(directory_inode, lower_dir_dentry->d_inode); |
| 207 | fsstack_copy_inode_size(directory_inode, lower_dir_dentry->d_inode); | 207 | fsstack_copy_inode_size(directory_inode, lower_dir_dentry->d_inode); |
| 208 | out_lock: | 208 | out_lock: |
| 209 | unlock_dir(lower_dir_dentry); | 209 | unlock_dir(lower_dir_dentry); |
| 210 | out: | 210 | out: |
| 211 | return rc; | 211 | return inode; |
| 212 | } | 212 | } |
| 213 | 213 | ||
| 214 | /** | 214 | /** |
| @@ -219,26 +219,26 @@ out: | |||
| 219 | * | 219 | * |
| 220 | * Returns zero on success | 220 | * Returns zero on success |
| 221 | */ | 221 | */ |
| 222 | static int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry) | 222 | static int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry, |
| 223 | struct inode *ecryptfs_inode) | ||
| 223 | { | 224 | { |
| 224 | struct ecryptfs_crypt_stat *crypt_stat = | 225 | struct ecryptfs_crypt_stat *crypt_stat = |
| 225 | &ecryptfs_inode_to_private(ecryptfs_dentry->d_inode)->crypt_stat; | 226 | &ecryptfs_inode_to_private(ecryptfs_inode)->crypt_stat; |
| 226 | int rc = 0; | 227 | int rc = 0; |
| 227 | 228 | ||
| 228 | if (S_ISDIR(ecryptfs_dentry->d_inode->i_mode)) { | 229 | if (S_ISDIR(ecryptfs_inode->i_mode)) { |
| 229 | ecryptfs_printk(KERN_DEBUG, "This is a directory\n"); | 230 | ecryptfs_printk(KERN_DEBUG, "This is a directory\n"); |
| 230 | crypt_stat->flags &= ~(ECRYPTFS_ENCRYPTED); | 231 | crypt_stat->flags &= ~(ECRYPTFS_ENCRYPTED); |
| 231 | goto out; | 232 | goto out; |
| 232 | } | 233 | } |
| 233 | ecryptfs_printk(KERN_DEBUG, "Initializing crypto context\n"); | 234 | ecryptfs_printk(KERN_DEBUG, "Initializing crypto context\n"); |
| 234 | rc = ecryptfs_new_file_context(ecryptfs_dentry); | 235 | rc = ecryptfs_new_file_context(ecryptfs_inode); |
| 235 | if (rc) { | 236 | if (rc) { |
| 236 | ecryptfs_printk(KERN_ERR, "Error creating new file " | 237 | ecryptfs_printk(KERN_ERR, "Error creating new file " |
| 237 | "context; rc = [%d]\n", rc); | 238 | "context; rc = [%d]\n", rc); |
| 238 | goto out; | 239 | goto out; |
| 239 | } | 240 | } |
| 240 | rc = ecryptfs_get_lower_file(ecryptfs_dentry, | 241 | rc = ecryptfs_get_lower_file(ecryptfs_dentry, ecryptfs_inode); |
| 241 | ecryptfs_dentry->d_inode); | ||
| 242 | if (rc) { | 242 | if (rc) { |
| 243 | printk(KERN_ERR "%s: Error attempting to initialize " | 243 | printk(KERN_ERR "%s: Error attempting to initialize " |
| 244 | "the lower file for the dentry with name " | 244 | "the lower file for the dentry with name " |
| @@ -246,10 +246,10 @@ static int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry) | |||
| 246 | ecryptfs_dentry->d_name.name, rc); | 246 | ecryptfs_dentry->d_name.name, rc); |
| 247 | goto out; | 247 | goto out; |
| 248 | } | 248 | } |
| 249 | rc = ecryptfs_write_metadata(ecryptfs_dentry); | 249 | rc = ecryptfs_write_metadata(ecryptfs_dentry, ecryptfs_inode); |
| 250 | if (rc) | 250 | if (rc) |
| 251 | printk(KERN_ERR "Error writing headers; rc = [%d]\n", rc); | 251 | printk(KERN_ERR "Error writing headers; rc = [%d]\n", rc); |
| 252 | ecryptfs_put_lower_file(ecryptfs_dentry->d_inode); | 252 | ecryptfs_put_lower_file(ecryptfs_inode); |
| 253 | out: | 253 | out: |
| 254 | return rc; | 254 | return rc; |
| 255 | } | 255 | } |
| @@ -269,18 +269,28 @@ static int | |||
| 269 | ecryptfs_create(struct inode *directory_inode, struct dentry *ecryptfs_dentry, | 269 | ecryptfs_create(struct inode *directory_inode, struct dentry *ecryptfs_dentry, |
| 270 | int mode, struct nameidata *nd) | 270 | int mode, struct nameidata *nd) |
| 271 | { | 271 | { |
| 272 | struct inode *ecryptfs_inode; | ||
| 272 | int rc; | 273 | int rc; |
| 273 | 274 | ||
| 274 | /* ecryptfs_do_create() calls ecryptfs_interpose() */ | 275 | ecryptfs_inode = ecryptfs_do_create(directory_inode, ecryptfs_dentry, |
| 275 | rc = ecryptfs_do_create(directory_inode, ecryptfs_dentry, mode); | 276 | mode); |
| 276 | if (unlikely(rc)) { | 277 | if (unlikely(IS_ERR(ecryptfs_inode))) { |
| 277 | ecryptfs_printk(KERN_WARNING, "Failed to create file in" | 278 | ecryptfs_printk(KERN_WARNING, "Failed to create file in" |
| 278 | "lower filesystem\n"); | 279 | "lower filesystem\n"); |
| 280 | rc = PTR_ERR(ecryptfs_inode); | ||
| 279 | goto out; | 281 | goto out; |
| 280 | } | 282 | } |
| 281 | /* At this point, a file exists on "disk"; we need to make sure | 283 | /* At this point, a file exists on "disk"; we need to make sure |
| 282 | * that this on disk file is prepared to be an ecryptfs file */ | 284 | * that this on disk file is prepared to be an ecryptfs file */ |
| 283 | rc = ecryptfs_initialize_file(ecryptfs_dentry); | 285 | rc = ecryptfs_initialize_file(ecryptfs_dentry, ecryptfs_inode); |
| 286 | if (rc) { | ||
| 287 | drop_nlink(ecryptfs_inode); | ||
| 288 | unlock_new_inode(ecryptfs_inode); | ||
| 289 | iput(ecryptfs_inode); | ||
| 290 | goto out; | ||
| 291 | } | ||
| 292 | d_instantiate(ecryptfs_dentry, ecryptfs_inode); | ||
| 293 | unlock_new_inode(ecryptfs_inode); | ||
| 284 | out: | 294 | out: |
| 285 | return rc; | 295 | return rc; |
| 286 | } | 296 | } |
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 61fa9e1614af..607b1557d292 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c | |||
| @@ -1095,7 +1095,7 @@ static int ext4_ext_grow_indepth(handle_t *handle, struct inode *inode, | |||
| 1095 | le32_to_cpu(EXT_FIRST_INDEX(neh)->ei_block), | 1095 | le32_to_cpu(EXT_FIRST_INDEX(neh)->ei_block), |
| 1096 | ext4_idx_pblock(EXT_FIRST_INDEX(neh))); | 1096 | ext4_idx_pblock(EXT_FIRST_INDEX(neh))); |
| 1097 | 1097 | ||
| 1098 | neh->eh_depth = cpu_to_le16(neh->eh_depth + 1); | 1098 | neh->eh_depth = cpu_to_le16(le16_to_cpu(neh->eh_depth) + 1); |
| 1099 | ext4_mark_inode_dirty(handle, inode); | 1099 | ext4_mark_inode_dirty(handle, inode); |
| 1100 | out: | 1100 | out: |
| 1101 | brelse(bh); | 1101 | brelse(bh); |
| @@ -2955,7 +2955,6 @@ static int ext4_ext_convert_to_initialized(handle_t *handle, | |||
| 2955 | /* Pre-conditions */ | 2955 | /* Pre-conditions */ |
| 2956 | BUG_ON(!ext4_ext_is_uninitialized(ex)); | 2956 | BUG_ON(!ext4_ext_is_uninitialized(ex)); |
| 2957 | BUG_ON(!in_range(map->m_lblk, ee_block, ee_len)); | 2957 | BUG_ON(!in_range(map->m_lblk, ee_block, ee_len)); |
| 2958 | BUG_ON(map->m_lblk + map->m_len > ee_block + ee_len); | ||
| 2959 | 2958 | ||
| 2960 | /* | 2959 | /* |
| 2961 | * Attempt to transfer newly initialized blocks from the currently | 2960 | * Attempt to transfer newly initialized blocks from the currently |
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index fffec40d5996..92655fd89657 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
| @@ -1339,8 +1339,11 @@ static int mpage_da_submit_io(struct mpage_da_data *mpd, | |||
| 1339 | clear_buffer_unwritten(bh); | 1339 | clear_buffer_unwritten(bh); |
| 1340 | } | 1340 | } |
| 1341 | 1341 | ||
| 1342 | /* skip page if block allocation undone */ | 1342 | /* |
| 1343 | if (buffer_delay(bh) || buffer_unwritten(bh)) | 1343 | * skip page if block allocation undone and |
| 1344 | * block is dirty | ||
| 1345 | */ | ||
| 1346 | if (ext4_bh_delay_or_unwritten(NULL, bh)) | ||
| 1344 | skip_page = 1; | 1347 | skip_page = 1; |
| 1345 | bh = bh->b_this_page; | 1348 | bh = bh->b_this_page; |
| 1346 | block_start += bh->b_size; | 1349 | block_start += bh->b_size; |
| @@ -2387,7 +2390,6 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping, | |||
| 2387 | pgoff_t index; | 2390 | pgoff_t index; |
| 2388 | struct inode *inode = mapping->host; | 2391 | struct inode *inode = mapping->host; |
| 2389 | handle_t *handle; | 2392 | handle_t *handle; |
| 2390 | loff_t page_len; | ||
| 2391 | 2393 | ||
| 2392 | index = pos >> PAGE_CACHE_SHIFT; | 2394 | index = pos >> PAGE_CACHE_SHIFT; |
| 2393 | 2395 | ||
| @@ -2434,13 +2436,6 @@ retry: | |||
| 2434 | */ | 2436 | */ |
| 2435 | if (pos + len > inode->i_size) | 2437 | if (pos + len > inode->i_size) |
| 2436 | ext4_truncate_failed_write(inode); | 2438 | ext4_truncate_failed_write(inode); |
| 2437 | } else { | ||
| 2438 | page_len = pos & (PAGE_CACHE_SIZE - 1); | ||
| 2439 | if (page_len > 0) { | ||
| 2440 | ret = ext4_discard_partial_page_buffers_no_lock(handle, | ||
| 2441 | inode, page, pos - page_len, page_len, | ||
| 2442 | EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED); | ||
| 2443 | } | ||
| 2444 | } | 2439 | } |
| 2445 | 2440 | ||
| 2446 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) | 2441 | if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries)) |
| @@ -2483,7 +2478,6 @@ static int ext4_da_write_end(struct file *file, | |||
| 2483 | loff_t new_i_size; | 2478 | loff_t new_i_size; |
| 2484 | unsigned long start, end; | 2479 | unsigned long start, end; |
| 2485 | int write_mode = (int)(unsigned long)fsdata; | 2480 | int write_mode = (int)(unsigned long)fsdata; |
| 2486 | loff_t page_len; | ||
| 2487 | 2481 | ||
| 2488 | if (write_mode == FALL_BACK_TO_NONDELALLOC) { | 2482 | if (write_mode == FALL_BACK_TO_NONDELALLOC) { |
| 2489 | if (ext4_should_order_data(inode)) { | 2483 | if (ext4_should_order_data(inode)) { |
| @@ -2508,7 +2502,7 @@ static int ext4_da_write_end(struct file *file, | |||
| 2508 | */ | 2502 | */ |
| 2509 | 2503 | ||
| 2510 | new_i_size = pos + copied; | 2504 | new_i_size = pos + copied; |
| 2511 | if (new_i_size > EXT4_I(inode)->i_disksize) { | 2505 | if (copied && new_i_size > EXT4_I(inode)->i_disksize) { |
| 2512 | if (ext4_da_should_update_i_disksize(page, end)) { | 2506 | if (ext4_da_should_update_i_disksize(page, end)) { |
| 2513 | down_write(&EXT4_I(inode)->i_data_sem); | 2507 | down_write(&EXT4_I(inode)->i_data_sem); |
| 2514 | if (new_i_size > EXT4_I(inode)->i_disksize) { | 2508 | if (new_i_size > EXT4_I(inode)->i_disksize) { |
| @@ -2532,16 +2526,6 @@ static int ext4_da_write_end(struct file *file, | |||
| 2532 | } | 2526 | } |
| 2533 | ret2 = generic_write_end(file, mapping, pos, len, copied, | 2527 | ret2 = generic_write_end(file, mapping, pos, len, copied, |
| 2534 | page, fsdata); | 2528 | page, fsdata); |
| 2535 | |||
| 2536 | page_len = PAGE_CACHE_SIZE - | ||
| 2537 | ((pos + copied - 1) & (PAGE_CACHE_SIZE - 1)); | ||
| 2538 | |||
| 2539 | if (page_len > 0) { | ||
| 2540 | ret = ext4_discard_partial_page_buffers_no_lock(handle, | ||
| 2541 | inode, page, pos + copied - 1, page_len, | ||
| 2542 | EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED); | ||
| 2543 | } | ||
| 2544 | |||
| 2545 | copied = ret2; | 2529 | copied = ret2; |
| 2546 | if (ret2 < 0) | 2530 | if (ret2 < 0) |
| 2547 | ret = ret2; | 2531 | ret = ret2; |
| @@ -2781,10 +2765,11 @@ static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset, | |||
| 2781 | iocb->private, io_end->inode->i_ino, iocb, offset, | 2765 | iocb->private, io_end->inode->i_ino, iocb, offset, |
| 2782 | size); | 2766 | size); |
| 2783 | 2767 | ||
| 2768 | iocb->private = NULL; | ||
| 2769 | |||
| 2784 | /* if not aio dio with unwritten extents, just free io and return */ | 2770 | /* if not aio dio with unwritten extents, just free io and return */ |
| 2785 | if (!(io_end->flag & EXT4_IO_END_UNWRITTEN)) { | 2771 | if (!(io_end->flag & EXT4_IO_END_UNWRITTEN)) { |
| 2786 | ext4_free_io_end(io_end); | 2772 | ext4_free_io_end(io_end); |
| 2787 | iocb->private = NULL; | ||
| 2788 | out: | 2773 | out: |
| 2789 | if (is_async) | 2774 | if (is_async) |
| 2790 | aio_complete(iocb, ret, 0); | 2775 | aio_complete(iocb, ret, 0); |
| @@ -2808,7 +2793,6 @@ out: | |||
| 2808 | 2793 | ||
| 2809 | /* queue the work to convert unwritten extents to written */ | 2794 | /* queue the work to convert unwritten extents to written */ |
| 2810 | queue_work(wq, &io_end->work); | 2795 | queue_work(wq, &io_end->work); |
| 2811 | iocb->private = NULL; | ||
| 2812 | 2796 | ||
| 2813 | /* XXX: probably should move into the real I/O completion handler */ | 2797 | /* XXX: probably should move into the real I/O completion handler */ |
| 2814 | inode_dio_done(inode); | 2798 | inode_dio_done(inode); |
| @@ -3203,26 +3187,8 @@ int ext4_discard_partial_page_buffers_no_lock(handle_t *handle, | |||
| 3203 | 3187 | ||
| 3204 | iblock = index << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits); | 3188 | iblock = index << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits); |
| 3205 | 3189 | ||
| 3206 | if (!page_has_buffers(page)) { | 3190 | if (!page_has_buffers(page)) |
| 3207 | /* | 3191 | create_empty_buffers(page, blocksize, 0); |
| 3208 | * If the range to be discarded covers a partial block | ||
| 3209 | * we need to get the page buffers. This is because | ||
| 3210 | * partial blocks cannot be released and the page needs | ||
| 3211 | * to be updated with the contents of the block before | ||
| 3212 | * we write the zeros on top of it. | ||
| 3213 | */ | ||
| 3214 | if ((from & (blocksize - 1)) || | ||
| 3215 | ((from + length) & (blocksize - 1))) { | ||
| 3216 | create_empty_buffers(page, blocksize, 0); | ||
| 3217 | } else { | ||
| 3218 | /* | ||
| 3219 | * If there are no partial blocks, | ||
| 3220 | * there is nothing to update, | ||
| 3221 | * so we can return now | ||
| 3222 | */ | ||
| 3223 | return 0; | ||
| 3224 | } | ||
| 3225 | } | ||
| 3226 | 3192 | ||
| 3227 | /* Find the buffer that contains "offset" */ | 3193 | /* Find the buffer that contains "offset" */ |
| 3228 | bh = page_buffers(page); | 3194 | bh = page_buffers(page); |
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 7ce1d0b19c94..7e106c810c62 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c | |||
| @@ -385,6 +385,18 @@ int ext4_bio_write_page(struct ext4_io_submit *io, | |||
| 385 | 385 | ||
| 386 | block_end = block_start + blocksize; | 386 | block_end = block_start + blocksize; |
| 387 | if (block_start >= len) { | 387 | if (block_start >= len) { |
| 388 | /* | ||
| 389 | * Comments copied from block_write_full_page_endio: | ||
| 390 | * | ||
| 391 | * The page straddles i_size. It must be zeroed out on | ||
| 392 | * each and every writepage invocation because it may | ||
| 393 | * be mmapped. "A file is mapped in multiples of the | ||
| 394 | * page size. For a file that is not a multiple of | ||
| 395 | * the page size, the remaining memory is zeroed when | ||
| 396 | * mapped, and writes to that region are not written | ||
| 397 | * out to the file." | ||
| 398 | */ | ||
| 399 | zero_user_segment(page, block_start, block_end); | ||
| 388 | clear_buffer_dirty(bh); | 400 | clear_buffer_dirty(bh); |
| 389 | set_buffer_uptodate(bh); | 401 | set_buffer_uptodate(bh); |
| 390 | continue; | 402 | continue; |
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 3858767ec672..3e1329e2f826 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c | |||
| @@ -1155,9 +1155,9 @@ static int ext4_show_options(struct seq_file *seq, struct vfsmount *vfs) | |||
| 1155 | seq_puts(seq, ",block_validity"); | 1155 | seq_puts(seq, ",block_validity"); |
| 1156 | 1156 | ||
| 1157 | if (!test_opt(sb, INIT_INODE_TABLE)) | 1157 | if (!test_opt(sb, INIT_INODE_TABLE)) |
| 1158 | seq_puts(seq, ",noinit_inode_table"); | 1158 | seq_puts(seq, ",noinit_itable"); |
| 1159 | else if (sbi->s_li_wait_mult != EXT4_DEF_LI_WAIT_MULT) | 1159 | else if (sbi->s_li_wait_mult != EXT4_DEF_LI_WAIT_MULT) |
| 1160 | seq_printf(seq, ",init_inode_table=%u", | 1160 | seq_printf(seq, ",init_itable=%u", |
| 1161 | (unsigned) sbi->s_li_wait_mult); | 1161 | (unsigned) sbi->s_li_wait_mult); |
| 1162 | 1162 | ||
| 1163 | ext4_show_quota_options(seq, sb); | 1163 | ext4_show_quota_options(seq, sb); |
| @@ -1333,8 +1333,7 @@ enum { | |||
| 1333 | Opt_nomblk_io_submit, Opt_block_validity, Opt_noblock_validity, | 1333 | Opt_nomblk_io_submit, Opt_block_validity, Opt_noblock_validity, |
| 1334 | Opt_inode_readahead_blks, Opt_journal_ioprio, | 1334 | Opt_inode_readahead_blks, Opt_journal_ioprio, |
| 1335 | Opt_dioread_nolock, Opt_dioread_lock, | 1335 | Opt_dioread_nolock, Opt_dioread_lock, |
| 1336 | Opt_discard, Opt_nodiscard, | 1336 | Opt_discard, Opt_nodiscard, Opt_init_itable, Opt_noinit_itable, |
| 1337 | Opt_init_inode_table, Opt_noinit_inode_table, | ||
| 1338 | }; | 1337 | }; |
| 1339 | 1338 | ||
| 1340 | static const match_table_t tokens = { | 1339 | static const match_table_t tokens = { |
| @@ -1407,9 +1406,9 @@ static const match_table_t tokens = { | |||
| 1407 | {Opt_dioread_lock, "dioread_lock"}, | 1406 | {Opt_dioread_lock, "dioread_lock"}, |
| 1408 | {Opt_discard, "discard"}, | 1407 | {Opt_discard, "discard"}, |
| 1409 | {Opt_nodiscard, "nodiscard"}, | 1408 | {Opt_nodiscard, "nodiscard"}, |
| 1410 | {Opt_init_inode_table, "init_itable=%u"}, | 1409 | {Opt_init_itable, "init_itable=%u"}, |
| 1411 | {Opt_init_inode_table, "init_itable"}, | 1410 | {Opt_init_itable, "init_itable"}, |
| 1412 | {Opt_noinit_inode_table, "noinit_itable"}, | 1411 | {Opt_noinit_itable, "noinit_itable"}, |
| 1413 | {Opt_err, NULL}, | 1412 | {Opt_err, NULL}, |
| 1414 | }; | 1413 | }; |
| 1415 | 1414 | ||
| @@ -1892,7 +1891,7 @@ set_qf_format: | |||
| 1892 | case Opt_dioread_lock: | 1891 | case Opt_dioread_lock: |
| 1893 | clear_opt(sb, DIOREAD_NOLOCK); | 1892 | clear_opt(sb, DIOREAD_NOLOCK); |
| 1894 | break; | 1893 | break; |
| 1895 | case Opt_init_inode_table: | 1894 | case Opt_init_itable: |
| 1896 | set_opt(sb, INIT_INODE_TABLE); | 1895 | set_opt(sb, INIT_INODE_TABLE); |
| 1897 | if (args[0].from) { | 1896 | if (args[0].from) { |
| 1898 | if (match_int(&args[0], &option)) | 1897 | if (match_int(&args[0], &option)) |
| @@ -1903,7 +1902,7 @@ set_qf_format: | |||
| 1903 | return 0; | 1902 | return 0; |
| 1904 | sbi->s_li_wait_mult = option; | 1903 | sbi->s_li_wait_mult = option; |
| 1905 | break; | 1904 | break; |
| 1906 | case Opt_noinit_inode_table: | 1905 | case Opt_noinit_itable: |
| 1907 | clear_opt(sb, INIT_INODE_TABLE); | 1906 | clear_opt(sb, INIT_INODE_TABLE); |
| 1908 | break; | 1907 | break; |
| 1909 | default: | 1908 | default: |
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 73c3992b2bb4..ac86f8b3e3cb 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c | |||
| @@ -156,6 +156,7 @@ __bdi_start_writeback(struct backing_dev_info *bdi, long nr_pages, | |||
| 156 | * bdi_start_writeback - start writeback | 156 | * bdi_start_writeback - start writeback |
| 157 | * @bdi: the backing device to write from | 157 | * @bdi: the backing device to write from |
| 158 | * @nr_pages: the number of pages to write | 158 | * @nr_pages: the number of pages to write |
| 159 | * @reason: reason why some writeback work was initiated | ||
| 159 | * | 160 | * |
| 160 | * Description: | 161 | * Description: |
| 161 | * This does WB_SYNC_NONE opportunistic writeback. The IO is only | 162 | * This does WB_SYNC_NONE opportunistic writeback. The IO is only |
| @@ -1223,6 +1224,7 @@ static void wait_sb_inodes(struct super_block *sb) | |||
| 1223 | * writeback_inodes_sb_nr - writeback dirty inodes from given super_block | 1224 | * writeback_inodes_sb_nr - writeback dirty inodes from given super_block |
| 1224 | * @sb: the superblock | 1225 | * @sb: the superblock |
| 1225 | * @nr: the number of pages to write | 1226 | * @nr: the number of pages to write |
| 1227 | * @reason: reason why some writeback work initiated | ||
| 1226 | * | 1228 | * |
| 1227 | * Start writeback on some inodes on this super_block. No guarantees are made | 1229 | * Start writeback on some inodes on this super_block. No guarantees are made |
| 1228 | * on how many (if any) will be written, and this function does not wait | 1230 | * on how many (if any) will be written, and this function does not wait |
| @@ -1251,6 +1253,7 @@ EXPORT_SYMBOL(writeback_inodes_sb_nr); | |||
| 1251 | /** | 1253 | /** |
| 1252 | * writeback_inodes_sb - writeback dirty inodes from given super_block | 1254 | * writeback_inodes_sb - writeback dirty inodes from given super_block |
| 1253 | * @sb: the superblock | 1255 | * @sb: the superblock |
| 1256 | * @reason: reason why some writeback work was initiated | ||
| 1254 | * | 1257 | * |
| 1255 | * Start writeback on some inodes on this super_block. No guarantees are made | 1258 | * Start writeback on some inodes on this super_block. No guarantees are made |
| 1256 | * on how many (if any) will be written, and this function does not wait | 1259 | * on how many (if any) will be written, and this function does not wait |
| @@ -1265,6 +1268,7 @@ EXPORT_SYMBOL(writeback_inodes_sb); | |||
| 1265 | /** | 1268 | /** |
| 1266 | * writeback_inodes_sb_if_idle - start writeback if none underway | 1269 | * writeback_inodes_sb_if_idle - start writeback if none underway |
| 1267 | * @sb: the superblock | 1270 | * @sb: the superblock |
| 1271 | * @reason: reason why some writeback work was initiated | ||
| 1268 | * | 1272 | * |
| 1269 | * Invoke writeback_inodes_sb if no writeback is currently underway. | 1273 | * Invoke writeback_inodes_sb if no writeback is currently underway. |
| 1270 | * Returns 1 if writeback was started, 0 if not. | 1274 | * Returns 1 if writeback was started, 0 if not. |
| @@ -1285,6 +1289,7 @@ EXPORT_SYMBOL(writeback_inodes_sb_if_idle); | |||
| 1285 | * writeback_inodes_sb_if_idle - start writeback if none underway | 1289 | * writeback_inodes_sb_if_idle - start writeback if none underway |
| 1286 | * @sb: the superblock | 1290 | * @sb: the superblock |
| 1287 | * @nr: the number of pages to write | 1291 | * @nr: the number of pages to write |
| 1292 | * @reason: reason why some writeback work was initiated | ||
| 1288 | * | 1293 | * |
| 1289 | * Invoke writeback_inodes_sb if no writeback is currently underway. | 1294 | * Invoke writeback_inodes_sb if no writeback is currently underway. |
| 1290 | * Returns 1 if writeback was started, 0 if not. | 1295 | * Returns 1 if writeback was started, 0 if not. |
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 5cb8614508c3..2aaf3eaaf13d 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c | |||
| @@ -1512,7 +1512,7 @@ static int fuse_retrieve(struct fuse_conn *fc, struct inode *inode, | |||
| 1512 | else if (outarg->offset + num > file_size) | 1512 | else if (outarg->offset + num > file_size) |
| 1513 | num = file_size - outarg->offset; | 1513 | num = file_size - outarg->offset; |
| 1514 | 1514 | ||
| 1515 | while (num) { | 1515 | while (num && req->num_pages < FUSE_MAX_PAGES_PER_REQ) { |
| 1516 | struct page *page; | 1516 | struct page *page; |
| 1517 | unsigned int this_num; | 1517 | unsigned int this_num; |
| 1518 | 1518 | ||
| @@ -1526,6 +1526,7 @@ static int fuse_retrieve(struct fuse_conn *fc, struct inode *inode, | |||
| 1526 | 1526 | ||
| 1527 | num -= this_num; | 1527 | num -= this_num; |
| 1528 | total_len += this_num; | 1528 | total_len += this_num; |
| 1529 | index++; | ||
| 1529 | } | 1530 | } |
| 1530 | req->misc.retrieve_in.offset = outarg->offset; | 1531 | req->misc.retrieve_in.offset = outarg->offset; |
| 1531 | req->misc.retrieve_in.size = total_len; | 1532 | req->misc.retrieve_in.size = total_len; |
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index 594f07a81c28..0c84100acd44 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
| @@ -1556,7 +1556,7 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int origin) | |||
| 1556 | struct inode *inode = file->f_path.dentry->d_inode; | 1556 | struct inode *inode = file->f_path.dentry->d_inode; |
| 1557 | 1557 | ||
| 1558 | mutex_lock(&inode->i_mutex); | 1558 | mutex_lock(&inode->i_mutex); |
| 1559 | if (origin != SEEK_CUR || origin != SEEK_SET) { | 1559 | if (origin != SEEK_CUR && origin != SEEK_SET) { |
| 1560 | retval = fuse_update_attributes(inode, NULL, file, NULL); | 1560 | retval = fuse_update_attributes(inode, NULL, file, NULL); |
| 1561 | if (retval) | 1561 | if (retval) |
| 1562 | goto exit; | 1562 | goto exit; |
| @@ -1567,6 +1567,10 @@ static loff_t fuse_file_llseek(struct file *file, loff_t offset, int origin) | |||
| 1567 | offset += i_size_read(inode); | 1567 | offset += i_size_read(inode); |
| 1568 | break; | 1568 | break; |
| 1569 | case SEEK_CUR: | 1569 | case SEEK_CUR: |
| 1570 | if (offset == 0) { | ||
| 1571 | retval = file->f_pos; | ||
| 1572 | goto exit; | ||
| 1573 | } | ||
| 1570 | offset += file->f_pos; | 1574 | offset += file->f_pos; |
| 1571 | break; | 1575 | break; |
| 1572 | case SEEK_DATA: | 1576 | case SEEK_DATA: |
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 3e6d72756479..aa83109b9431 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse/inode.c | |||
| @@ -1138,28 +1138,28 @@ static int __init fuse_fs_init(void) | |||
| 1138 | { | 1138 | { |
| 1139 | int err; | 1139 | int err; |
| 1140 | 1140 | ||
| 1141 | err = register_filesystem(&fuse_fs_type); | ||
| 1142 | if (err) | ||
| 1143 | goto out; | ||
| 1144 | |||
| 1145 | err = register_fuseblk(); | ||
| 1146 | if (err) | ||
| 1147 | goto out_unreg; | ||
| 1148 | |||
| 1149 | fuse_inode_cachep = kmem_cache_create("fuse_inode", | 1141 | fuse_inode_cachep = kmem_cache_create("fuse_inode", |
| 1150 | sizeof(struct fuse_inode), | 1142 | sizeof(struct fuse_inode), |
| 1151 | 0, SLAB_HWCACHE_ALIGN, | 1143 | 0, SLAB_HWCACHE_ALIGN, |
| 1152 | fuse_inode_init_once); | 1144 | fuse_inode_init_once); |
| 1153 | err = -ENOMEM; | 1145 | err = -ENOMEM; |
| 1154 | if (!fuse_inode_cachep) | 1146 | if (!fuse_inode_cachep) |
| 1155 | goto out_unreg2; | 1147 | goto out; |
| 1148 | |||
| 1149 | err = register_fuseblk(); | ||
| 1150 | if (err) | ||
| 1151 | goto out2; | ||
| 1152 | |||
| 1153 | err = register_filesystem(&fuse_fs_type); | ||
| 1154 | if (err) | ||
| 1155 | goto out3; | ||
| 1156 | 1156 | ||
| 1157 | return 0; | 1157 | return 0; |
| 1158 | 1158 | ||
| 1159 | out_unreg2: | 1159 | out3: |
| 1160 | unregister_fuseblk(); | 1160 | unregister_fuseblk(); |
| 1161 | out_unreg: | 1161 | out2: |
| 1162 | unregister_filesystem(&fuse_fs_type); | 1162 | kmem_cache_destroy(fuse_inode_cachep); |
| 1163 | out: | 1163 | out: |
| 1164 | return err; | 1164 | return err; |
| 1165 | } | 1165 | } |
diff --git a/fs/namespace.c b/fs/namespace.c index 6d3a1963879b..cfc6d4448aa5 100644 --- a/fs/namespace.c +++ b/fs/namespace.c | |||
| @@ -1048,15 +1048,12 @@ static int show_mountinfo(struct seq_file *m, void *v) | |||
| 1048 | if (err) | 1048 | if (err) |
| 1049 | goto out; | 1049 | goto out; |
| 1050 | seq_putc(m, ' '); | 1050 | seq_putc(m, ' '); |
| 1051 | seq_path_root(m, &mnt_path, &root, " \t\n\\"); | 1051 | |
| 1052 | if (root.mnt != p->root.mnt || root.dentry != p->root.dentry) { | 1052 | /* mountpoints outside of chroot jail will give SEQ_SKIP on this */ |
| 1053 | /* | 1053 | err = seq_path_root(m, &mnt_path, &root, " \t\n\\"); |
| 1054 | * Mountpoint is outside root, discard that one. Ugly, | 1054 | if (err) |
| 1055 | * but less so than trying to do that in iterator in a | 1055 | goto out; |
| 1056 | * race-free way (due to renames). | 1056 | |
| 1057 | */ | ||
| 1058 | return SEQ_SKIP; | ||
| 1059 | } | ||
| 1060 | seq_puts(m, mnt->mnt_flags & MNT_READONLY ? " ro" : " rw"); | 1057 | seq_puts(m, mnt->mnt_flags & MNT_READONLY ? " ro" : " rw"); |
| 1061 | show_mnt_opts(m, mnt); | 1058 | show_mnt_opts(m, mnt); |
| 1062 | 1059 | ||
| @@ -2776,3 +2773,8 @@ void kern_unmount(struct vfsmount *mnt) | |||
| 2776 | } | 2773 | } |
| 2777 | } | 2774 | } |
| 2778 | EXPORT_SYMBOL(kern_unmount); | 2775 | EXPORT_SYMBOL(kern_unmount); |
| 2776 | |||
| 2777 | bool our_mnt(struct vfsmount *mnt) | ||
| 2778 | { | ||
| 2779 | return check_mnt(mnt); | ||
| 2780 | } | ||
diff --git a/fs/ncpfs/inode.c b/fs/ncpfs/inode.c index 5b5fa33b6b9d..cbd1a61c110a 100644 --- a/fs/ncpfs/inode.c +++ b/fs/ncpfs/inode.c | |||
| @@ -548,7 +548,7 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) | |||
| 548 | 548 | ||
| 549 | error = bdi_setup_and_register(&server->bdi, "ncpfs", BDI_CAP_MAP_COPY); | 549 | error = bdi_setup_and_register(&server->bdi, "ncpfs", BDI_CAP_MAP_COPY); |
| 550 | if (error) | 550 | if (error) |
| 551 | goto out_bdi; | 551 | goto out_fput; |
| 552 | 552 | ||
| 553 | server->ncp_filp = ncp_filp; | 553 | server->ncp_filp = ncp_filp; |
| 554 | server->ncp_sock = sock; | 554 | server->ncp_sock = sock; |
| @@ -559,7 +559,7 @@ static int ncp_fill_super(struct super_block *sb, void *raw_data, int silent) | |||
| 559 | error = -EBADF; | 559 | error = -EBADF; |
| 560 | server->info_filp = fget(data.info_fd); | 560 | server->info_filp = fget(data.info_fd); |
| 561 | if (!server->info_filp) | 561 | if (!server->info_filp) |
| 562 | goto out_fput; | 562 | goto out_bdi; |
| 563 | error = -ENOTSOCK; | 563 | error = -ENOTSOCK; |
| 564 | sock_inode = server->info_filp->f_path.dentry->d_inode; | 564 | sock_inode = server->info_filp->f_path.dentry->d_inode; |
| 565 | if (!S_ISSOCK(sock_inode->i_mode)) | 565 | if (!S_ISSOCK(sock_inode->i_mode)) |
| @@ -746,9 +746,9 @@ out_nls: | |||
| 746 | out_fput2: | 746 | out_fput2: |
| 747 | if (server->info_filp) | 747 | if (server->info_filp) |
| 748 | fput(server->info_filp); | 748 | fput(server->info_filp); |
| 749 | out_fput: | ||
| 750 | bdi_destroy(&server->bdi); | ||
| 751 | out_bdi: | 749 | out_bdi: |
| 750 | bdi_destroy(&server->bdi); | ||
| 751 | out_fput: | ||
| 752 | /* 23/12/1998 Marcin Dalecki <dalecki@cs.net.pl>: | 752 | /* 23/12/1998 Marcin Dalecki <dalecki@cs.net.pl>: |
| 753 | * | 753 | * |
| 754 | * The previously used put_filp(ncp_filp); was bogus, since | 754 | * The previously used put_filp(ncp_filp); was bogus, since |
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index ed553c60de82..3165aebb43c8 100644 --- a/fs/ocfs2/alloc.c +++ b/fs/ocfs2/alloc.c | |||
| @@ -5699,7 +5699,7 @@ int ocfs2_remove_btree_range(struct inode *inode, | |||
| 5699 | OCFS2_JOURNAL_ACCESS_WRITE); | 5699 | OCFS2_JOURNAL_ACCESS_WRITE); |
| 5700 | if (ret) { | 5700 | if (ret) { |
| 5701 | mlog_errno(ret); | 5701 | mlog_errno(ret); |
| 5702 | goto out; | 5702 | goto out_commit; |
| 5703 | } | 5703 | } |
| 5704 | 5704 | ||
| 5705 | dquot_free_space_nodirty(inode, | 5705 | dquot_free_space_nodirty(inode, |
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index c1efe939c774..78b68af3b0e3 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
| @@ -290,7 +290,15 @@ static int ocfs2_readpage(struct file *file, struct page *page) | |||
| 290 | } | 290 | } |
| 291 | 291 | ||
| 292 | if (down_read_trylock(&oi->ip_alloc_sem) == 0) { | 292 | if (down_read_trylock(&oi->ip_alloc_sem) == 0) { |
| 293 | /* | ||
| 294 | * Unlock the page and cycle ip_alloc_sem so that we don't | ||
| 295 | * busyloop waiting for ip_alloc_sem to unlock | ||
| 296 | */ | ||
| 293 | ret = AOP_TRUNCATED_PAGE; | 297 | ret = AOP_TRUNCATED_PAGE; |
| 298 | unlock_page(page); | ||
| 299 | unlock = 0; | ||
| 300 | down_read(&oi->ip_alloc_sem); | ||
| 301 | up_read(&oi->ip_alloc_sem); | ||
| 294 | goto out_inode_unlock; | 302 | goto out_inode_unlock; |
| 295 | } | 303 | } |
| 296 | 304 | ||
| @@ -563,6 +571,7 @@ static void ocfs2_dio_end_io(struct kiocb *iocb, | |||
| 563 | { | 571 | { |
| 564 | struct inode *inode = iocb->ki_filp->f_path.dentry->d_inode; | 572 | struct inode *inode = iocb->ki_filp->f_path.dentry->d_inode; |
| 565 | int level; | 573 | int level; |
| 574 | wait_queue_head_t *wq = ocfs2_ioend_wq(inode); | ||
| 566 | 575 | ||
| 567 | /* this io's submitter should not have unlocked this before we could */ | 576 | /* this io's submitter should not have unlocked this before we could */ |
| 568 | BUG_ON(!ocfs2_iocb_is_rw_locked(iocb)); | 577 | BUG_ON(!ocfs2_iocb_is_rw_locked(iocb)); |
| @@ -570,6 +579,15 @@ static void ocfs2_dio_end_io(struct kiocb *iocb, | |||
| 570 | if (ocfs2_iocb_is_sem_locked(iocb)) | 579 | if (ocfs2_iocb_is_sem_locked(iocb)) |
| 571 | ocfs2_iocb_clear_sem_locked(iocb); | 580 | ocfs2_iocb_clear_sem_locked(iocb); |
| 572 | 581 | ||
| 582 | if (ocfs2_iocb_is_unaligned_aio(iocb)) { | ||
| 583 | ocfs2_iocb_clear_unaligned_aio(iocb); | ||
| 584 | |||
| 585 | if (atomic_dec_and_test(&OCFS2_I(inode)->ip_unaligned_aio) && | ||
| 586 | waitqueue_active(wq)) { | ||
| 587 | wake_up_all(wq); | ||
| 588 | } | ||
| 589 | } | ||
| 590 | |||
| 573 | ocfs2_iocb_clear_rw_locked(iocb); | 591 | ocfs2_iocb_clear_rw_locked(iocb); |
| 574 | 592 | ||
| 575 | level = ocfs2_iocb_rw_locked_level(iocb); | 593 | level = ocfs2_iocb_rw_locked_level(iocb); |
| @@ -863,6 +881,12 @@ struct ocfs2_write_ctxt { | |||
| 863 | struct page *w_target_page; | 881 | struct page *w_target_page; |
| 864 | 882 | ||
| 865 | /* | 883 | /* |
| 884 | * w_target_locked is used for page_mkwrite path indicating no unlocking | ||
| 885 | * against w_target_page in ocfs2_write_end_nolock. | ||
| 886 | */ | ||
| 887 | unsigned int w_target_locked:1; | ||
| 888 | |||
| 889 | /* | ||
| 866 | * ocfs2_write_end() uses this to know what the real range to | 890 | * ocfs2_write_end() uses this to know what the real range to |
| 867 | * write in the target should be. | 891 | * write in the target should be. |
| 868 | */ | 892 | */ |
| @@ -895,6 +919,24 @@ void ocfs2_unlock_and_free_pages(struct page **pages, int num_pages) | |||
| 895 | 919 | ||
| 896 | static void ocfs2_free_write_ctxt(struct ocfs2_write_ctxt *wc) | 920 | static void ocfs2_free_write_ctxt(struct ocfs2_write_ctxt *wc) |
| 897 | { | 921 | { |
| 922 | int i; | ||
| 923 | |||
| 924 | /* | ||
| 925 | * w_target_locked is only set to true in the page_mkwrite() case. | ||
| 926 | * The intent is to allow us to lock the target page from write_begin() | ||
| 927 | * to write_end(). The caller must hold a ref on w_target_page. | ||
| 928 | */ | ||
| 929 | if (wc->w_target_locked) { | ||
| 930 | BUG_ON(!wc->w_target_page); | ||
| 931 | for (i = 0; i < wc->w_num_pages; i++) { | ||
| 932 | if (wc->w_target_page == wc->w_pages[i]) { | ||
| 933 | wc->w_pages[i] = NULL; | ||
| 934 | break; | ||
| 935 | } | ||
| 936 | } | ||
| 937 | mark_page_accessed(wc->w_target_page); | ||
| 938 | page_cache_release(wc->w_target_page); | ||
| 939 | } | ||
| 898 | ocfs2_unlock_and_free_pages(wc->w_pages, wc->w_num_pages); | 940 | ocfs2_unlock_and_free_pages(wc->w_pages, wc->w_num_pages); |
| 899 | 941 | ||
| 900 | brelse(wc->w_di_bh); | 942 | brelse(wc->w_di_bh); |
| @@ -1132,20 +1174,17 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping, | |||
| 1132 | */ | 1174 | */ |
| 1133 | lock_page(mmap_page); | 1175 | lock_page(mmap_page); |
| 1134 | 1176 | ||
| 1177 | /* Exit and let the caller retry */ | ||
| 1135 | if (mmap_page->mapping != mapping) { | 1178 | if (mmap_page->mapping != mapping) { |
| 1179 | WARN_ON(mmap_page->mapping); | ||
| 1136 | unlock_page(mmap_page); | 1180 | unlock_page(mmap_page); |
| 1137 | /* | 1181 | ret = -EAGAIN; |
| 1138 | * Sanity check - the locking in | ||
| 1139 | * ocfs2_pagemkwrite() should ensure | ||
| 1140 | * that this code doesn't trigger. | ||
| 1141 | */ | ||
| 1142 | ret = -EINVAL; | ||
| 1143 | mlog_errno(ret); | ||
| 1144 | goto out; | 1182 | goto out; |
| 1145 | } | 1183 | } |
| 1146 | 1184 | ||
| 1147 | page_cache_get(mmap_page); | 1185 | page_cache_get(mmap_page); |
| 1148 | wc->w_pages[i] = mmap_page; | 1186 | wc->w_pages[i] = mmap_page; |
| 1187 | wc->w_target_locked = true; | ||
| 1149 | } else { | 1188 | } else { |
| 1150 | wc->w_pages[i] = find_or_create_page(mapping, index, | 1189 | wc->w_pages[i] = find_or_create_page(mapping, index, |
| 1151 | GFP_NOFS); | 1190 | GFP_NOFS); |
| @@ -1160,6 +1199,8 @@ static int ocfs2_grab_pages_for_write(struct address_space *mapping, | |||
| 1160 | wc->w_target_page = wc->w_pages[i]; | 1199 | wc->w_target_page = wc->w_pages[i]; |
| 1161 | } | 1200 | } |
| 1162 | out: | 1201 | out: |
| 1202 | if (ret) | ||
| 1203 | wc->w_target_locked = false; | ||
| 1163 | return ret; | 1204 | return ret; |
| 1164 | } | 1205 | } |
| 1165 | 1206 | ||
| @@ -1817,11 +1858,23 @@ try_again: | |||
| 1817 | */ | 1858 | */ |
| 1818 | ret = ocfs2_grab_pages_for_write(mapping, wc, wc->w_cpos, pos, len, | 1859 | ret = ocfs2_grab_pages_for_write(mapping, wc, wc->w_cpos, pos, len, |
| 1819 | cluster_of_pages, mmap_page); | 1860 | cluster_of_pages, mmap_page); |
| 1820 | if (ret) { | 1861 | if (ret && ret != -EAGAIN) { |
| 1821 | mlog_errno(ret); | 1862 | mlog_errno(ret); |
| 1822 | goto out_quota; | 1863 | goto out_quota; |
| 1823 | } | 1864 | } |
| 1824 | 1865 | ||
| 1866 | /* | ||
| 1867 | * ocfs2_grab_pages_for_write() returns -EAGAIN if it could not lock | ||
| 1868 | * the target page. In this case, we exit with no error and no target | ||
| 1869 | * page. This will trigger the caller, page_mkwrite(), to re-try | ||
| 1870 | * the operation. | ||
| 1871 | */ | ||
| 1872 | if (ret == -EAGAIN) { | ||
| 1873 | BUG_ON(wc->w_target_page); | ||
| 1874 | ret = 0; | ||
| 1875 | goto out_quota; | ||
| 1876 | } | ||
| 1877 | |||
| 1825 | ret = ocfs2_write_cluster_by_desc(mapping, data_ac, meta_ac, wc, pos, | 1878 | ret = ocfs2_write_cluster_by_desc(mapping, data_ac, meta_ac, wc, pos, |
| 1826 | len); | 1879 | len); |
| 1827 | if (ret) { | 1880 | if (ret) { |
diff --git a/fs/ocfs2/aops.h b/fs/ocfs2/aops.h index 75cf3ad987a6..ffb2da370a99 100644 --- a/fs/ocfs2/aops.h +++ b/fs/ocfs2/aops.h | |||
| @@ -78,6 +78,7 @@ enum ocfs2_iocb_lock_bits { | |||
| 78 | OCFS2_IOCB_RW_LOCK = 0, | 78 | OCFS2_IOCB_RW_LOCK = 0, |
| 79 | OCFS2_IOCB_RW_LOCK_LEVEL, | 79 | OCFS2_IOCB_RW_LOCK_LEVEL, |
| 80 | OCFS2_IOCB_SEM, | 80 | OCFS2_IOCB_SEM, |
| 81 | OCFS2_IOCB_UNALIGNED_IO, | ||
| 81 | OCFS2_IOCB_NUM_LOCKS | 82 | OCFS2_IOCB_NUM_LOCKS |
| 82 | }; | 83 | }; |
| 83 | 84 | ||
| @@ -91,4 +92,17 @@ enum ocfs2_iocb_lock_bits { | |||
| 91 | clear_bit(OCFS2_IOCB_SEM, (unsigned long *)&iocb->private) | 92 | clear_bit(OCFS2_IOCB_SEM, (unsigned long *)&iocb->private) |
| 92 | #define ocfs2_iocb_is_sem_locked(iocb) \ | 93 | #define ocfs2_iocb_is_sem_locked(iocb) \ |
| 93 | test_bit(OCFS2_IOCB_SEM, (unsigned long *)&iocb->private) | 94 | test_bit(OCFS2_IOCB_SEM, (unsigned long *)&iocb->private) |
| 95 | |||
| 96 | #define ocfs2_iocb_set_unaligned_aio(iocb) \ | ||
| 97 | set_bit(OCFS2_IOCB_UNALIGNED_IO, (unsigned long *)&iocb->private) | ||
| 98 | #define ocfs2_iocb_clear_unaligned_aio(iocb) \ | ||
| 99 | clear_bit(OCFS2_IOCB_UNALIGNED_IO, (unsigned long *)&iocb->private) | ||
| 100 | #define ocfs2_iocb_is_unaligned_aio(iocb) \ | ||
| 101 | test_bit(OCFS2_IOCB_UNALIGNED_IO, (unsigned long *)&iocb->private) | ||
| 102 | |||
| 103 | #define OCFS2_IOEND_WQ_HASH_SZ 37 | ||
| 104 | #define ocfs2_ioend_wq(v) (&ocfs2__ioend_wq[((unsigned long)(v)) %\ | ||
| 105 | OCFS2_IOEND_WQ_HASH_SZ]) | ||
| 106 | extern wait_queue_head_t ocfs2__ioend_wq[OCFS2_IOEND_WQ_HASH_SZ]; | ||
| 107 | |||
| 94 | #endif /* OCFS2_FILE_H */ | 108 | #endif /* OCFS2_FILE_H */ |
diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c index 9a3e6bbff27b..a4e855e3690e 100644 --- a/fs/ocfs2/cluster/heartbeat.c +++ b/fs/ocfs2/cluster/heartbeat.c | |||
| @@ -216,6 +216,7 @@ struct o2hb_region { | |||
| 216 | 216 | ||
| 217 | struct list_head hr_all_item; | 217 | struct list_head hr_all_item; |
| 218 | unsigned hr_unclean_stop:1, | 218 | unsigned hr_unclean_stop:1, |
| 219 | hr_aborted_start:1, | ||
| 219 | hr_item_pinned:1, | 220 | hr_item_pinned:1, |
| 220 | hr_item_dropped:1; | 221 | hr_item_dropped:1; |
| 221 | 222 | ||
| @@ -254,6 +255,10 @@ struct o2hb_region { | |||
| 254 | * a more complete api that doesn't lead to this sort of fragility. */ | 255 | * a more complete api that doesn't lead to this sort of fragility. */ |
| 255 | atomic_t hr_steady_iterations; | 256 | atomic_t hr_steady_iterations; |
| 256 | 257 | ||
| 258 | /* terminate o2hb thread if it does not reach steady state | ||
| 259 | * (hr_steady_iterations == 0) within hr_unsteady_iterations */ | ||
| 260 | atomic_t hr_unsteady_iterations; | ||
| 261 | |||
| 257 | char hr_dev_name[BDEVNAME_SIZE]; | 262 | char hr_dev_name[BDEVNAME_SIZE]; |
| 258 | 263 | ||
| 259 | unsigned int hr_timeout_ms; | 264 | unsigned int hr_timeout_ms; |
| @@ -324,6 +329,10 @@ static void o2hb_write_timeout(struct work_struct *work) | |||
| 324 | 329 | ||
| 325 | static void o2hb_arm_write_timeout(struct o2hb_region *reg) | 330 | static void o2hb_arm_write_timeout(struct o2hb_region *reg) |
| 326 | { | 331 | { |
| 332 | /* Arm writeout only after thread reaches steady state */ | ||
| 333 | if (atomic_read(®->hr_steady_iterations) != 0) | ||
| 334 | return; | ||
| 335 | |||
| 327 | mlog(ML_HEARTBEAT, "Queue write timeout for %u ms\n", | 336 | mlog(ML_HEARTBEAT, "Queue write timeout for %u ms\n", |
| 328 | O2HB_MAX_WRITE_TIMEOUT_MS); | 337 | O2HB_MAX_WRITE_TIMEOUT_MS); |
| 329 | 338 | ||
| @@ -537,9 +546,14 @@ static int o2hb_verify_crc(struct o2hb_region *reg, | |||
| 537 | return read == computed; | 546 | return read == computed; |
| 538 | } | 547 | } |
| 539 | 548 | ||
| 540 | /* We want to make sure that nobody is heartbeating on top of us -- | 549 | /* |
| 541 | * this will help detect an invalid configuration. */ | 550 | * Compare the slot data with what we wrote in the last iteration. |
| 542 | static void o2hb_check_last_timestamp(struct o2hb_region *reg) | 551 | * If the match fails, print an appropriate error message. This is to |
| 552 | * detect errors like... another node hearting on the same slot, | ||
| 553 | * flaky device that is losing writes, etc. | ||
| 554 | * Returns 1 if check succeeds, 0 otherwise. | ||
| 555 | */ | ||
| 556 | static int o2hb_check_own_slot(struct o2hb_region *reg) | ||
| 543 | { | 557 | { |
| 544 | struct o2hb_disk_slot *slot; | 558 | struct o2hb_disk_slot *slot; |
| 545 | struct o2hb_disk_heartbeat_block *hb_block; | 559 | struct o2hb_disk_heartbeat_block *hb_block; |
| @@ -548,13 +562,13 @@ static void o2hb_check_last_timestamp(struct o2hb_region *reg) | |||
| 548 | slot = ®->hr_slots[o2nm_this_node()]; | 562 | slot = ®->hr_slots[o2nm_this_node()]; |
| 549 | /* Don't check on our 1st timestamp */ | 563 | /* Don't check on our 1st timestamp */ |
| 550 | if (!slot->ds_last_time) | 564 | if (!slot->ds_last_time) |
| 551 | return; | 565 | return 0; |
| 552 | 566 | ||
| 553 | hb_block = slot->ds_raw_block; | 567 | hb_block = slot->ds_raw_block; |
| 554 | if (le64_to_cpu(hb_block->hb_seq) == slot->ds_last_time && | 568 | if (le64_to_cpu(hb_block->hb_seq) == slot->ds_last_time && |
| 555 | le64_to_cpu(hb_block->hb_generation) == slot->ds_last_generation && | 569 | le64_to_cpu(hb_block->hb_generation) == slot->ds_last_generation && |
| 556 | hb_block->hb_node == slot->ds_node_num) | 570 | hb_block->hb_node == slot->ds_node_num) |
| 557 | return; | 571 | return 1; |
| 558 | 572 | ||
| 559 | #define ERRSTR1 "Another node is heartbeating on device" | 573 | #define ERRSTR1 "Another node is heartbeating on device" |
| 560 | #define ERRSTR2 "Heartbeat generation mismatch on device" | 574 | #define ERRSTR2 "Heartbeat generation mismatch on device" |
| @@ -574,6 +588,8 @@ static void o2hb_check_last_timestamp(struct o2hb_region *reg) | |||
| 574 | (unsigned long long)slot->ds_last_time, hb_block->hb_node, | 588 | (unsigned long long)slot->ds_last_time, hb_block->hb_node, |
| 575 | (unsigned long long)le64_to_cpu(hb_block->hb_generation), | 589 | (unsigned long long)le64_to_cpu(hb_block->hb_generation), |
| 576 | (unsigned long long)le64_to_cpu(hb_block->hb_seq)); | 590 | (unsigned long long)le64_to_cpu(hb_block->hb_seq)); |
| 591 | |||
| 592 | return 0; | ||
| 577 | } | 593 | } |
| 578 | 594 | ||
| 579 | static inline void o2hb_prepare_block(struct o2hb_region *reg, | 595 | static inline void o2hb_prepare_block(struct o2hb_region *reg, |
| @@ -719,17 +735,24 @@ static void o2hb_shutdown_slot(struct o2hb_disk_slot *slot) | |||
| 719 | o2nm_node_put(node); | 735 | o2nm_node_put(node); |
| 720 | } | 736 | } |
| 721 | 737 | ||
| 722 | static void o2hb_set_quorum_device(struct o2hb_region *reg, | 738 | static void o2hb_set_quorum_device(struct o2hb_region *reg) |
| 723 | struct o2hb_disk_slot *slot) | ||
| 724 | { | 739 | { |
| 725 | assert_spin_locked(&o2hb_live_lock); | ||
| 726 | |||
| 727 | if (!o2hb_global_heartbeat_active()) | 740 | if (!o2hb_global_heartbeat_active()) |
| 728 | return; | 741 | return; |
| 729 | 742 | ||
| 730 | if (test_bit(reg->hr_region_num, o2hb_quorum_region_bitmap)) | 743 | /* Prevent race with o2hb_heartbeat_group_drop_item() */ |
| 744 | if (kthread_should_stop()) | ||
| 745 | return; | ||
| 746 | |||
| 747 | /* Tag region as quorum only after thread reaches steady state */ | ||
| 748 | if (atomic_read(®->hr_steady_iterations) != 0) | ||
| 731 | return; | 749 | return; |
| 732 | 750 | ||
| 751 | spin_lock(&o2hb_live_lock); | ||
| 752 | |||
| 753 | if (test_bit(reg->hr_region_num, o2hb_quorum_region_bitmap)) | ||
| 754 | goto unlock; | ||
| 755 | |||
| 733 | /* | 756 | /* |
| 734 | * A region can be added to the quorum only when it sees all | 757 | * A region can be added to the quorum only when it sees all |
| 735 | * live nodes heartbeat on it. In other words, the region has been | 758 | * live nodes heartbeat on it. In other words, the region has been |
| @@ -737,13 +760,10 @@ static void o2hb_set_quorum_device(struct o2hb_region *reg, | |||
| 737 | */ | 760 | */ |
| 738 | if (memcmp(reg->hr_live_node_bitmap, o2hb_live_node_bitmap, | 761 | if (memcmp(reg->hr_live_node_bitmap, o2hb_live_node_bitmap, |
| 739 | sizeof(o2hb_live_node_bitmap))) | 762 | sizeof(o2hb_live_node_bitmap))) |
| 740 | return; | 763 | goto unlock; |
| 741 | |||
| 742 | if (slot->ds_changed_samples < O2HB_LIVE_THRESHOLD) | ||
| 743 | return; | ||
| 744 | 764 | ||
| 745 | printk(KERN_NOTICE "o2hb: Region %s is now a quorum device\n", | 765 | printk(KERN_NOTICE "o2hb: Region %s (%s) is now a quorum device\n", |
| 746 | config_item_name(®->hr_item)); | 766 | config_item_name(®->hr_item), reg->hr_dev_name); |
| 747 | 767 | ||
| 748 | set_bit(reg->hr_region_num, o2hb_quorum_region_bitmap); | 768 | set_bit(reg->hr_region_num, o2hb_quorum_region_bitmap); |
| 749 | 769 | ||
| @@ -754,6 +774,8 @@ static void o2hb_set_quorum_device(struct o2hb_region *reg, | |||
| 754 | if (o2hb_pop_count(&o2hb_quorum_region_bitmap, | 774 | if (o2hb_pop_count(&o2hb_quorum_region_bitmap, |
| 755 | O2NM_MAX_REGIONS) > O2HB_PIN_CUT_OFF) | 775 | O2NM_MAX_REGIONS) > O2HB_PIN_CUT_OFF) |
| 756 | o2hb_region_unpin(NULL); | 776 | o2hb_region_unpin(NULL); |
| 777 | unlock: | ||
| 778 | spin_unlock(&o2hb_live_lock); | ||
| 757 | } | 779 | } |
| 758 | 780 | ||
| 759 | static int o2hb_check_slot(struct o2hb_region *reg, | 781 | static int o2hb_check_slot(struct o2hb_region *reg, |
| @@ -925,8 +947,6 @@ fire_callbacks: | |||
| 925 | slot->ds_equal_samples = 0; | 947 | slot->ds_equal_samples = 0; |
| 926 | } | 948 | } |
| 927 | out: | 949 | out: |
| 928 | o2hb_set_quorum_device(reg, slot); | ||
| 929 | |||
| 930 | spin_unlock(&o2hb_live_lock); | 950 | spin_unlock(&o2hb_live_lock); |
| 931 | 951 | ||
| 932 | o2hb_run_event_list(&event); | 952 | o2hb_run_event_list(&event); |
| @@ -957,7 +977,8 @@ static int o2hb_highest_node(unsigned long *nodes, | |||
| 957 | 977 | ||
| 958 | static int o2hb_do_disk_heartbeat(struct o2hb_region *reg) | 978 | static int o2hb_do_disk_heartbeat(struct o2hb_region *reg) |
| 959 | { | 979 | { |
| 960 | int i, ret, highest_node, change = 0; | 980 | int i, ret, highest_node; |
| 981 | int membership_change = 0, own_slot_ok = 0; | ||
| 961 | unsigned long configured_nodes[BITS_TO_LONGS(O2NM_MAX_NODES)]; | 982 | unsigned long configured_nodes[BITS_TO_LONGS(O2NM_MAX_NODES)]; |
| 962 | unsigned long live_node_bitmap[BITS_TO_LONGS(O2NM_MAX_NODES)]; | 983 | unsigned long live_node_bitmap[BITS_TO_LONGS(O2NM_MAX_NODES)]; |
| 963 | struct o2hb_bio_wait_ctxt write_wc; | 984 | struct o2hb_bio_wait_ctxt write_wc; |
| @@ -966,7 +987,7 @@ static int o2hb_do_disk_heartbeat(struct o2hb_region *reg) | |||
| 966 | sizeof(configured_nodes)); | 987 | sizeof(configured_nodes)); |
| 967 | if (ret) { | 988 | if (ret) { |
| 968 | mlog_errno(ret); | 989 | mlog_errno(ret); |
| 969 | return ret; | 990 | goto bail; |
| 970 | } | 991 | } |
| 971 | 992 | ||
| 972 | /* | 993 | /* |
| @@ -982,8 +1003,9 @@ static int o2hb_do_disk_heartbeat(struct o2hb_region *reg) | |||
| 982 | 1003 | ||
| 983 | highest_node = o2hb_highest_node(configured_nodes, O2NM_MAX_NODES); | 1004 | highest_node = o2hb_highest_node(configured_nodes, O2NM_MAX_NODES); |
| 984 | if (highest_node >= O2NM_MAX_NODES) { | 1005 | if (highest_node >= O2NM_MAX_NODES) { |
| 985 | mlog(ML_NOTICE, "ocfs2_heartbeat: no configured nodes found!\n"); | 1006 | mlog(ML_NOTICE, "o2hb: No configured nodes found!\n"); |
| 986 | return -EINVAL; | 1007 | ret = -EINVAL; |
| 1008 | goto bail; | ||
| 987 | } | 1009 | } |
| 988 | 1010 | ||
| 989 | /* No sense in reading the slots of nodes that don't exist | 1011 | /* No sense in reading the slots of nodes that don't exist |
| @@ -993,29 +1015,27 @@ static int o2hb_do_disk_heartbeat(struct o2hb_region *reg) | |||
| 993 | ret = o2hb_read_slots(reg, highest_node + 1); | 1015 | ret = o2hb_read_slots(reg, highest_node + 1); |
| 994 | if (ret < 0) { | 1016 | if (ret < 0) { |
| 995 | mlog_errno(ret); | 1017 | mlog_errno(ret); |
| 996 | return ret; | 1018 | goto bail; |
| 997 | } | 1019 | } |
| 998 | 1020 | ||
| 999 | /* With an up to date view of the slots, we can check that no | 1021 | /* With an up to date view of the slots, we can check that no |
| 1000 | * other node has been improperly configured to heartbeat in | 1022 | * other node has been improperly configured to heartbeat in |
| 1001 | * our slot. */ | 1023 | * our slot. */ |
| 1002 | o2hb_check_last_timestamp(reg); | 1024 | own_slot_ok = o2hb_check_own_slot(reg); |
| 1003 | 1025 | ||
| 1004 | /* fill in the proper info for our next heartbeat */ | 1026 | /* fill in the proper info for our next heartbeat */ |
| 1005 | o2hb_prepare_block(reg, reg->hr_generation); | 1027 | o2hb_prepare_block(reg, reg->hr_generation); |
| 1006 | 1028 | ||
| 1007 | /* And fire off the write. Note that we don't wait on this I/O | ||
| 1008 | * until later. */ | ||
| 1009 | ret = o2hb_issue_node_write(reg, &write_wc); | 1029 | ret = o2hb_issue_node_write(reg, &write_wc); |
| 1010 | if (ret < 0) { | 1030 | if (ret < 0) { |
| 1011 | mlog_errno(ret); | 1031 | mlog_errno(ret); |
| 1012 | return ret; | 1032 | goto bail; |
| 1013 | } | 1033 | } |
| 1014 | 1034 | ||
| 1015 | i = -1; | 1035 | i = -1; |
| 1016 | while((i = find_next_bit(configured_nodes, | 1036 | while((i = find_next_bit(configured_nodes, |
| 1017 | O2NM_MAX_NODES, i + 1)) < O2NM_MAX_NODES) { | 1037 | O2NM_MAX_NODES, i + 1)) < O2NM_MAX_NODES) { |
| 1018 | change |= o2hb_check_slot(reg, ®->hr_slots[i]); | 1038 | membership_change |= o2hb_check_slot(reg, ®->hr_slots[i]); |
| 1019 | } | 1039 | } |
| 1020 | 1040 | ||
| 1021 | /* | 1041 | /* |
| @@ -1030,18 +1050,39 @@ static int o2hb_do_disk_heartbeat(struct o2hb_region *reg) | |||
| 1030 | * disk */ | 1050 | * disk */ |
| 1031 | mlog(ML_ERROR, "Write error %d on device \"%s\"\n", | 1051 | mlog(ML_ERROR, "Write error %d on device \"%s\"\n", |
| 1032 | write_wc.wc_error, reg->hr_dev_name); | 1052 | write_wc.wc_error, reg->hr_dev_name); |
| 1033 | return write_wc.wc_error; | 1053 | ret = write_wc.wc_error; |
| 1054 | goto bail; | ||
| 1034 | } | 1055 | } |
| 1035 | 1056 | ||
| 1036 | o2hb_arm_write_timeout(reg); | 1057 | /* Skip disarming the timeout if own slot has stale/bad data */ |
| 1058 | if (own_slot_ok) { | ||
| 1059 | o2hb_set_quorum_device(reg); | ||
| 1060 | o2hb_arm_write_timeout(reg); | ||
| 1061 | } | ||
| 1037 | 1062 | ||
| 1063 | bail: | ||
| 1038 | /* let the person who launched us know when things are steady */ | 1064 | /* let the person who launched us know when things are steady */ |
| 1039 | if (!change && (atomic_read(®->hr_steady_iterations) != 0)) { | 1065 | if (atomic_read(®->hr_steady_iterations) != 0) { |
| 1040 | if (atomic_dec_and_test(®->hr_steady_iterations)) | 1066 | if (!ret && own_slot_ok && !membership_change) { |
| 1067 | if (atomic_dec_and_test(®->hr_steady_iterations)) | ||
| 1068 | wake_up(&o2hb_steady_queue); | ||
| 1069 | } | ||
| 1070 | } | ||
| 1071 | |||
| 1072 | if (atomic_read(®->hr_steady_iterations) != 0) { | ||
| 1073 | if (atomic_dec_and_test(®->hr_unsteady_iterations)) { | ||
| 1074 | printk(KERN_NOTICE "o2hb: Unable to stabilize " | ||
| 1075 | "heartbeart on region %s (%s)\n", | ||
| 1076 | config_item_name(®->hr_item), | ||
| 1077 | reg->hr_dev_name); | ||
| 1078 | atomic_set(®->hr_steady_iterations, 0); | ||
| 1079 | reg->hr_aborted_start = 1; | ||
| 1041 | wake_up(&o2hb_steady_queue); | 1080 | wake_up(&o2hb_steady_queue); |
| 1081 | ret = -EIO; | ||
| 1082 | } | ||
| 1042 | } | 1083 | } |
| 1043 | 1084 | ||
| 1044 | return 0; | 1085 | return ret; |
| 1045 | } | 1086 | } |
| 1046 | 1087 | ||
| 1047 | /* Subtract b from a, storing the result in a. a *must* have a larger | 1088 | /* Subtract b from a, storing the result in a. a *must* have a larger |
| @@ -1095,7 +1136,8 @@ static int o2hb_thread(void *data) | |||
| 1095 | /* Pin node */ | 1136 | /* Pin node */ |
| 1096 | o2nm_depend_this_node(); | 1137 | o2nm_depend_this_node(); |
| 1097 | 1138 | ||
| 1098 | while (!kthread_should_stop() && !reg->hr_unclean_stop) { | 1139 | while (!kthread_should_stop() && |
| 1140 | !reg->hr_unclean_stop && !reg->hr_aborted_start) { | ||
| 1099 | /* We track the time spent inside | 1141 | /* We track the time spent inside |
| 1100 | * o2hb_do_disk_heartbeat so that we avoid more than | 1142 | * o2hb_do_disk_heartbeat so that we avoid more than |
| 1101 | * hr_timeout_ms between disk writes. On busy systems | 1143 | * hr_timeout_ms between disk writes. On busy systems |
| @@ -1103,10 +1145,7 @@ static int o2hb_thread(void *data) | |||
| 1103 | * likely to time itself out. */ | 1145 | * likely to time itself out. */ |
| 1104 | do_gettimeofday(&before_hb); | 1146 | do_gettimeofday(&before_hb); |
| 1105 | 1147 | ||
| 1106 | i = 0; | 1148 | ret = o2hb_do_disk_heartbeat(reg); |
| 1107 | do { | ||
| 1108 | ret = o2hb_do_disk_heartbeat(reg); | ||
| 1109 | } while (ret && ++i < 2); | ||
| 1110 | 1149 | ||
| 1111 | do_gettimeofday(&after_hb); | 1150 | do_gettimeofday(&after_hb); |
| 1112 | elapsed_msec = o2hb_elapsed_msecs(&before_hb, &after_hb); | 1151 | elapsed_msec = o2hb_elapsed_msecs(&before_hb, &after_hb); |
| @@ -1117,7 +1156,8 @@ static int o2hb_thread(void *data) | |||
| 1117 | after_hb.tv_sec, (unsigned long) after_hb.tv_usec, | 1156 | after_hb.tv_sec, (unsigned long) after_hb.tv_usec, |
| 1118 | elapsed_msec); | 1157 | elapsed_msec); |
| 1119 | 1158 | ||
| 1120 | if (elapsed_msec < reg->hr_timeout_ms) { | 1159 | if (!kthread_should_stop() && |
| 1160 | elapsed_msec < reg->hr_timeout_ms) { | ||
| 1121 | /* the kthread api has blocked signals for us so no | 1161 | /* the kthread api has blocked signals for us so no |
| 1122 | * need to record the return value. */ | 1162 | * need to record the return value. */ |
| 1123 | msleep_interruptible(reg->hr_timeout_ms - elapsed_msec); | 1163 | msleep_interruptible(reg->hr_timeout_ms - elapsed_msec); |
| @@ -1134,20 +1174,20 @@ static int o2hb_thread(void *data) | |||
| 1134 | * to timeout on this region when we could just as easily | 1174 | * to timeout on this region when we could just as easily |
| 1135 | * write a clear generation - thus indicating to them that | 1175 | * write a clear generation - thus indicating to them that |
| 1136 | * this node has left this region. | 1176 | * this node has left this region. |
| 1137 | * | 1177 | */ |
| 1138 | * XXX: Should we skip this on unclean_stop? */ | 1178 | if (!reg->hr_unclean_stop && !reg->hr_aborted_start) { |
| 1139 | o2hb_prepare_block(reg, 0); | 1179 | o2hb_prepare_block(reg, 0); |
| 1140 | ret = o2hb_issue_node_write(reg, &write_wc); | 1180 | ret = o2hb_issue_node_write(reg, &write_wc); |
| 1141 | if (ret == 0) { | 1181 | if (ret == 0) |
| 1142 | o2hb_wait_on_io(reg, &write_wc); | 1182 | o2hb_wait_on_io(reg, &write_wc); |
| 1143 | } else { | 1183 | else |
| 1144 | mlog_errno(ret); | 1184 | mlog_errno(ret); |
| 1145 | } | 1185 | } |
| 1146 | 1186 | ||
| 1147 | /* Unpin node */ | 1187 | /* Unpin node */ |
| 1148 | o2nm_undepend_this_node(); | 1188 | o2nm_undepend_this_node(); |
| 1149 | 1189 | ||
| 1150 | mlog(ML_HEARTBEAT|ML_KTHREAD, "hb thread exiting\n"); | 1190 | mlog(ML_HEARTBEAT|ML_KTHREAD, "o2hb thread exiting\n"); |
| 1151 | 1191 | ||
| 1152 | return 0; | 1192 | return 0; |
| 1153 | } | 1193 | } |
| @@ -1158,6 +1198,7 @@ static int o2hb_debug_open(struct inode *inode, struct file *file) | |||
| 1158 | struct o2hb_debug_buf *db = inode->i_private; | 1198 | struct o2hb_debug_buf *db = inode->i_private; |
| 1159 | struct o2hb_region *reg; | 1199 | struct o2hb_region *reg; |
| 1160 | unsigned long map[BITS_TO_LONGS(O2NM_MAX_NODES)]; | 1200 | unsigned long map[BITS_TO_LONGS(O2NM_MAX_NODES)]; |
| 1201 | unsigned long lts; | ||
| 1161 | char *buf = NULL; | 1202 | char *buf = NULL; |
| 1162 | int i = -1; | 1203 | int i = -1; |
| 1163 | int out = 0; | 1204 | int out = 0; |
| @@ -1194,9 +1235,11 @@ static int o2hb_debug_open(struct inode *inode, struct file *file) | |||
| 1194 | 1235 | ||
| 1195 | case O2HB_DB_TYPE_REGION_ELAPSED_TIME: | 1236 | case O2HB_DB_TYPE_REGION_ELAPSED_TIME: |
| 1196 | reg = (struct o2hb_region *)db->db_data; | 1237 | reg = (struct o2hb_region *)db->db_data; |
| 1197 | out += snprintf(buf + out, PAGE_SIZE - out, "%u\n", | 1238 | lts = reg->hr_last_timeout_start; |
| 1198 | jiffies_to_msecs(jiffies - | 1239 | /* If 0, it has never been set before */ |
| 1199 | reg->hr_last_timeout_start)); | 1240 | if (lts) |
| 1241 | lts = jiffies_to_msecs(jiffies - lts); | ||
| 1242 | out += snprintf(buf + out, PAGE_SIZE - out, "%lu\n", lts); | ||
| 1200 | goto done; | 1243 | goto done; |
| 1201 | 1244 | ||
| 1202 | case O2HB_DB_TYPE_REGION_PINNED: | 1245 | case O2HB_DB_TYPE_REGION_PINNED: |
| @@ -1426,6 +1469,8 @@ static void o2hb_region_release(struct config_item *item) | |||
| 1426 | struct page *page; | 1469 | struct page *page; |
| 1427 | struct o2hb_region *reg = to_o2hb_region(item); | 1470 | struct o2hb_region *reg = to_o2hb_region(item); |
| 1428 | 1471 | ||
| 1472 | mlog(ML_HEARTBEAT, "hb region release (%s)\n", reg->hr_dev_name); | ||
| 1473 | |||
| 1429 | if (reg->hr_tmp_block) | 1474 | if (reg->hr_tmp_block) |
| 1430 | kfree(reg->hr_tmp_block); | 1475 | kfree(reg->hr_tmp_block); |
| 1431 | 1476 | ||
| @@ -1792,7 +1837,10 @@ static ssize_t o2hb_region_dev_write(struct o2hb_region *reg, | |||
| 1792 | live_threshold <<= 1; | 1837 | live_threshold <<= 1; |
| 1793 | spin_unlock(&o2hb_live_lock); | 1838 | spin_unlock(&o2hb_live_lock); |
| 1794 | } | 1839 | } |
| 1795 | atomic_set(®->hr_steady_iterations, live_threshold + 1); | 1840 | ++live_threshold; |
| 1841 | atomic_set(®->hr_steady_iterations, live_threshold); | ||
| 1842 | /* unsteady_iterations is double the steady_iterations */ | ||
| 1843 | atomic_set(®->hr_unsteady_iterations, (live_threshold << 1)); | ||
| 1796 | 1844 | ||
| 1797 | hb_task = kthread_run(o2hb_thread, reg, "o2hb-%s", | 1845 | hb_task = kthread_run(o2hb_thread, reg, "o2hb-%s", |
| 1798 | reg->hr_item.ci_name); | 1846 | reg->hr_item.ci_name); |
| @@ -1809,14 +1857,12 @@ static ssize_t o2hb_region_dev_write(struct o2hb_region *reg, | |||
| 1809 | ret = wait_event_interruptible(o2hb_steady_queue, | 1857 | ret = wait_event_interruptible(o2hb_steady_queue, |
| 1810 | atomic_read(®->hr_steady_iterations) == 0); | 1858 | atomic_read(®->hr_steady_iterations) == 0); |
| 1811 | if (ret) { | 1859 | if (ret) { |
| 1812 | /* We got interrupted (hello ptrace!). Clean up */ | 1860 | atomic_set(®->hr_steady_iterations, 0); |
| 1813 | spin_lock(&o2hb_live_lock); | 1861 | reg->hr_aborted_start = 1; |
| 1814 | hb_task = reg->hr_task; | 1862 | } |
| 1815 | reg->hr_task = NULL; | ||
| 1816 | spin_unlock(&o2hb_live_lock); | ||
| 1817 | 1863 | ||
| 1818 | if (hb_task) | 1864 | if (reg->hr_aborted_start) { |
| 1819 | kthread_stop(hb_task); | 1865 | ret = -EIO; |
| 1820 | goto out; | 1866 | goto out; |
| 1821 | } | 1867 | } |
| 1822 | 1868 | ||
| @@ -1833,8 +1879,8 @@ static ssize_t o2hb_region_dev_write(struct o2hb_region *reg, | |||
| 1833 | ret = -EIO; | 1879 | ret = -EIO; |
| 1834 | 1880 | ||
| 1835 | if (hb_task && o2hb_global_heartbeat_active()) | 1881 | if (hb_task && o2hb_global_heartbeat_active()) |
| 1836 | printk(KERN_NOTICE "o2hb: Heartbeat started on region %s\n", | 1882 | printk(KERN_NOTICE "o2hb: Heartbeat started on region %s (%s)\n", |
| 1837 | config_item_name(®->hr_item)); | 1883 | config_item_name(®->hr_item), reg->hr_dev_name); |
| 1838 | 1884 | ||
| 1839 | out: | 1885 | out: |
| 1840 | if (filp) | 1886 | if (filp) |
| @@ -2092,13 +2138,6 @@ static void o2hb_heartbeat_group_drop_item(struct config_group *group, | |||
| 2092 | 2138 | ||
| 2093 | /* stop the thread when the user removes the region dir */ | 2139 | /* stop the thread when the user removes the region dir */ |
| 2094 | spin_lock(&o2hb_live_lock); | 2140 | spin_lock(&o2hb_live_lock); |
| 2095 | if (o2hb_global_heartbeat_active()) { | ||
| 2096 | clear_bit(reg->hr_region_num, o2hb_region_bitmap); | ||
| 2097 | clear_bit(reg->hr_region_num, o2hb_live_region_bitmap); | ||
| 2098 | if (test_bit(reg->hr_region_num, o2hb_quorum_region_bitmap)) | ||
| 2099 | quorum_region = 1; | ||
| 2100 | clear_bit(reg->hr_region_num, o2hb_quorum_region_bitmap); | ||
| 2101 | } | ||
| 2102 | hb_task = reg->hr_task; | 2141 | hb_task = reg->hr_task; |
| 2103 | reg->hr_task = NULL; | 2142 | reg->hr_task = NULL; |
| 2104 | reg->hr_item_dropped = 1; | 2143 | reg->hr_item_dropped = 1; |
| @@ -2107,19 +2146,30 @@ static void o2hb_heartbeat_group_drop_item(struct config_group *group, | |||
| 2107 | if (hb_task) | 2146 | if (hb_task) |
| 2108 | kthread_stop(hb_task); | 2147 | kthread_stop(hb_task); |
| 2109 | 2148 | ||
| 2149 | if (o2hb_global_heartbeat_active()) { | ||
| 2150 | spin_lock(&o2hb_live_lock); | ||
| 2151 | clear_bit(reg->hr_region_num, o2hb_region_bitmap); | ||
| 2152 | clear_bit(reg->hr_region_num, o2hb_live_region_bitmap); | ||
| 2153 | if (test_bit(reg->hr_region_num, o2hb_quorum_region_bitmap)) | ||
| 2154 | quorum_region = 1; | ||
| 2155 | clear_bit(reg->hr_region_num, o2hb_quorum_region_bitmap); | ||
| 2156 | spin_unlock(&o2hb_live_lock); | ||
| 2157 | printk(KERN_NOTICE "o2hb: Heartbeat %s on region %s (%s)\n", | ||
| 2158 | ((atomic_read(®->hr_steady_iterations) == 0) ? | ||
| 2159 | "stopped" : "start aborted"), config_item_name(item), | ||
| 2160 | reg->hr_dev_name); | ||
| 2161 | } | ||
| 2162 | |||
| 2110 | /* | 2163 | /* |
| 2111 | * If we're racing a dev_write(), we need to wake them. They will | 2164 | * If we're racing a dev_write(), we need to wake them. They will |
| 2112 | * check reg->hr_task | 2165 | * check reg->hr_task |
| 2113 | */ | 2166 | */ |
| 2114 | if (atomic_read(®->hr_steady_iterations) != 0) { | 2167 | if (atomic_read(®->hr_steady_iterations) != 0) { |
| 2168 | reg->hr_aborted_start = 1; | ||
| 2115 | atomic_set(®->hr_steady_iterations, 0); | 2169 | atomic_set(®->hr_steady_iterations, 0); |
| 2116 | wake_up(&o2hb_steady_queue); | 2170 | wake_up(&o2hb_steady_queue); |
| 2117 | } | 2171 | } |
| 2118 | 2172 | ||
| 2119 | if (o2hb_global_heartbeat_active()) | ||
| 2120 | printk(KERN_NOTICE "o2hb: Heartbeat stopped on region %s\n", | ||
| 2121 | config_item_name(®->hr_item)); | ||
| 2122 | |||
| 2123 | config_item_put(item); | 2173 | config_item_put(item); |
| 2124 | 2174 | ||
| 2125 | if (!o2hb_global_heartbeat_active() || !quorum_region) | 2175 | if (!o2hb_global_heartbeat_active() || !quorum_region) |
diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index 3a5835904b3d..dc45deb19e68 100644 --- a/fs/ocfs2/cluster/netdebug.c +++ b/fs/ocfs2/cluster/netdebug.c | |||
| @@ -47,6 +47,7 @@ | |||
| 47 | #define SC_DEBUG_NAME "sock_containers" | 47 | #define SC_DEBUG_NAME "sock_containers" |
| 48 | #define NST_DEBUG_NAME "send_tracking" | 48 | #define NST_DEBUG_NAME "send_tracking" |
| 49 | #define STATS_DEBUG_NAME "stats" | 49 | #define STATS_DEBUG_NAME "stats" |
| 50 | #define NODES_DEBUG_NAME "connected_nodes" | ||
| 50 | 51 | ||
| 51 | #define SHOW_SOCK_CONTAINERS 0 | 52 | #define SHOW_SOCK_CONTAINERS 0 |
| 52 | #define SHOW_SOCK_STATS 1 | 53 | #define SHOW_SOCK_STATS 1 |
| @@ -55,6 +56,7 @@ static struct dentry *o2net_dentry; | |||
| 55 | static struct dentry *sc_dentry; | 56 | static struct dentry *sc_dentry; |
| 56 | static struct dentry *nst_dentry; | 57 | static struct dentry *nst_dentry; |
| 57 | static struct dentry *stats_dentry; | 58 | static struct dentry *stats_dentry; |
| 59 | static struct dentry *nodes_dentry; | ||
| 58 | 60 | ||
| 59 | static DEFINE_SPINLOCK(o2net_debug_lock); | 61 | static DEFINE_SPINLOCK(o2net_debug_lock); |
| 60 | 62 | ||
| @@ -491,53 +493,87 @@ static const struct file_operations sc_seq_fops = { | |||
| 491 | .release = sc_fop_release, | 493 | .release = sc_fop_release, |
| 492 | }; | 494 | }; |
| 493 | 495 | ||
| 494 | int o2net_debugfs_init(void) | 496 | static int o2net_fill_bitmap(char *buf, int len) |
| 495 | { | 497 | { |
| 496 | o2net_dentry = debugfs_create_dir(O2NET_DEBUG_DIR, NULL); | 498 | unsigned long map[BITS_TO_LONGS(O2NM_MAX_NODES)]; |
| 497 | if (!o2net_dentry) { | 499 | int i = -1, out = 0; |
| 498 | mlog_errno(-ENOMEM); | ||
| 499 | goto bail; | ||
| 500 | } | ||
| 501 | 500 | ||
| 502 | nst_dentry = debugfs_create_file(NST_DEBUG_NAME, S_IFREG|S_IRUSR, | 501 | o2net_fill_node_map(map, sizeof(map)); |
| 503 | o2net_dentry, NULL, | ||
| 504 | &nst_seq_fops); | ||
| 505 | if (!nst_dentry) { | ||
| 506 | mlog_errno(-ENOMEM); | ||
| 507 | goto bail; | ||
| 508 | } | ||
| 509 | 502 | ||
| 510 | sc_dentry = debugfs_create_file(SC_DEBUG_NAME, S_IFREG|S_IRUSR, | 503 | while ((i = find_next_bit(map, O2NM_MAX_NODES, i + 1)) < O2NM_MAX_NODES) |
| 511 | o2net_dentry, NULL, | 504 | out += snprintf(buf + out, PAGE_SIZE - out, "%d ", i); |
| 512 | &sc_seq_fops); | 505 | out += snprintf(buf + out, PAGE_SIZE - out, "\n"); |
| 513 | if (!sc_dentry) { | ||
| 514 | mlog_errno(-ENOMEM); | ||
| 515 | goto bail; | ||
| 516 | } | ||
| 517 | 506 | ||
| 518 | stats_dentry = debugfs_create_file(STATS_DEBUG_NAME, S_IFREG|S_IRUSR, | 507 | return out; |
| 519 | o2net_dentry, NULL, | 508 | } |
| 520 | &stats_seq_fops); | 509 | |
| 521 | if (!stats_dentry) { | 510 | static int nodes_fop_open(struct inode *inode, struct file *file) |
| 522 | mlog_errno(-ENOMEM); | 511 | { |
| 523 | goto bail; | 512 | char *buf; |
| 524 | } | 513 | |
| 514 | buf = kmalloc(PAGE_SIZE, GFP_KERNEL); | ||
| 515 | if (!buf) | ||
| 516 | return -ENOMEM; | ||
| 517 | |||
| 518 | i_size_write(inode, o2net_fill_bitmap(buf, PAGE_SIZE)); | ||
| 519 | |||
| 520 | file->private_data = buf; | ||
| 525 | 521 | ||
| 526 | return 0; | 522 | return 0; |
| 527 | bail: | ||
| 528 | debugfs_remove(stats_dentry); | ||
| 529 | debugfs_remove(sc_dentry); | ||
| 530 | debugfs_remove(nst_dentry); | ||
| 531 | debugfs_remove(o2net_dentry); | ||
| 532 | return -ENOMEM; | ||
| 533 | } | 523 | } |
| 534 | 524 | ||
| 525 | static int o2net_debug_release(struct inode *inode, struct file *file) | ||
| 526 | { | ||
| 527 | kfree(file->private_data); | ||
| 528 | return 0; | ||
| 529 | } | ||
| 530 | |||
| 531 | static ssize_t o2net_debug_read(struct file *file, char __user *buf, | ||
| 532 | size_t nbytes, loff_t *ppos) | ||
| 533 | { | ||
| 534 | return simple_read_from_buffer(buf, nbytes, ppos, file->private_data, | ||
| 535 | i_size_read(file->f_mapping->host)); | ||
| 536 | } | ||
| 537 | |||
| 538 | static const struct file_operations nodes_fops = { | ||
| 539 | .open = nodes_fop_open, | ||
| 540 | .release = o2net_debug_release, | ||
| 541 | .read = o2net_debug_read, | ||
| 542 | .llseek = generic_file_llseek, | ||
| 543 | }; | ||
| 544 | |||
| 535 | void o2net_debugfs_exit(void) | 545 | void o2net_debugfs_exit(void) |
| 536 | { | 546 | { |
| 547 | debugfs_remove(nodes_dentry); | ||
| 537 | debugfs_remove(stats_dentry); | 548 | debugfs_remove(stats_dentry); |
| 538 | debugfs_remove(sc_dentry); | 549 | debugfs_remove(sc_dentry); |
| 539 | debugfs_remove(nst_dentry); | 550 | debugfs_remove(nst_dentry); |
| 540 | debugfs_remove(o2net_dentry); | 551 | debugfs_remove(o2net_dentry); |
| 541 | } | 552 | } |
| 542 | 553 | ||
| 554 | int o2net_debugfs_init(void) | ||
| 555 | { | ||
| 556 | mode_t mode = S_IFREG|S_IRUSR; | ||
| 557 | |||
| 558 | o2net_dentry = debugfs_create_dir(O2NET_DEBUG_DIR, NULL); | ||
| 559 | if (o2net_dentry) | ||
| 560 | nst_dentry = debugfs_create_file(NST_DEBUG_NAME, mode, | ||
| 561 | o2net_dentry, NULL, &nst_seq_fops); | ||
| 562 | if (nst_dentry) | ||
| 563 | sc_dentry = debugfs_create_file(SC_DEBUG_NAME, mode, | ||
| 564 | o2net_dentry, NULL, &sc_seq_fops); | ||
| 565 | if (sc_dentry) | ||
| 566 | stats_dentry = debugfs_create_file(STATS_DEBUG_NAME, mode, | ||
| 567 | o2net_dentry, NULL, &stats_seq_fops); | ||
| 568 | if (stats_dentry) | ||
| 569 | nodes_dentry = debugfs_create_file(NODES_DEBUG_NAME, mode, | ||
| 570 | o2net_dentry, NULL, &nodes_fops); | ||
| 571 | if (nodes_dentry) | ||
| 572 | return 0; | ||
| 573 | |||
| 574 | o2net_debugfs_exit(); | ||
| 575 | mlog_errno(-ENOMEM); | ||
| 576 | return -ENOMEM; | ||
| 577 | } | ||
| 578 | |||
| 543 | #endif /* CONFIG_DEBUG_FS */ | 579 | #endif /* CONFIG_DEBUG_FS */ |
diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index ad7d0c155de4..044e7b58d31c 100644 --- a/fs/ocfs2/cluster/tcp.c +++ b/fs/ocfs2/cluster/tcp.c | |||
| @@ -546,7 +546,7 @@ static void o2net_set_nn_state(struct o2net_node *nn, | |||
| 546 | } | 546 | } |
| 547 | 547 | ||
| 548 | if (was_valid && !valid) { | 548 | if (was_valid && !valid) { |
| 549 | printk(KERN_NOTICE "o2net: no longer connected to " | 549 | printk(KERN_NOTICE "o2net: No longer connected to " |
| 550 | SC_NODEF_FMT "\n", SC_NODEF_ARGS(old_sc)); | 550 | SC_NODEF_FMT "\n", SC_NODEF_ARGS(old_sc)); |
| 551 | o2net_complete_nodes_nsw(nn); | 551 | o2net_complete_nodes_nsw(nn); |
| 552 | } | 552 | } |
| @@ -556,7 +556,7 @@ static void o2net_set_nn_state(struct o2net_node *nn, | |||
| 556 | cancel_delayed_work(&nn->nn_connect_expired); | 556 | cancel_delayed_work(&nn->nn_connect_expired); |
| 557 | printk(KERN_NOTICE "o2net: %s " SC_NODEF_FMT "\n", | 557 | printk(KERN_NOTICE "o2net: %s " SC_NODEF_FMT "\n", |
| 558 | o2nm_this_node() > sc->sc_node->nd_num ? | 558 | o2nm_this_node() > sc->sc_node->nd_num ? |
| 559 | "connected to" : "accepted connection from", | 559 | "Connected to" : "Accepted connection from", |
| 560 | SC_NODEF_ARGS(sc)); | 560 | SC_NODEF_ARGS(sc)); |
| 561 | } | 561 | } |
| 562 | 562 | ||
| @@ -644,7 +644,7 @@ static void o2net_state_change(struct sock *sk) | |||
| 644 | o2net_sc_queue_work(sc, &sc->sc_connect_work); | 644 | o2net_sc_queue_work(sc, &sc->sc_connect_work); |
| 645 | break; | 645 | break; |
| 646 | default: | 646 | default: |
| 647 | printk(KERN_INFO "o2net: connection to " SC_NODEF_FMT | 647 | printk(KERN_INFO "o2net: Connection to " SC_NODEF_FMT |
| 648 | " shutdown, state %d\n", | 648 | " shutdown, state %d\n", |
| 649 | SC_NODEF_ARGS(sc), sk->sk_state); | 649 | SC_NODEF_ARGS(sc), sk->sk_state); |
| 650 | o2net_sc_queue_work(sc, &sc->sc_shutdown_work); | 650 | o2net_sc_queue_work(sc, &sc->sc_shutdown_work); |
| @@ -1035,6 +1035,25 @@ static int o2net_tx_can_proceed(struct o2net_node *nn, | |||
| 1035 | return ret; | 1035 | return ret; |
| 1036 | } | 1036 | } |
| 1037 | 1037 | ||
| 1038 | /* Get a map of all nodes to which this node is currently connected to */ | ||
| 1039 | void o2net_fill_node_map(unsigned long *map, unsigned bytes) | ||
| 1040 | { | ||
| 1041 | struct o2net_sock_container *sc; | ||
| 1042 | int node, ret; | ||
| 1043 | |||
| 1044 | BUG_ON(bytes < (BITS_TO_LONGS(O2NM_MAX_NODES) * sizeof(unsigned long))); | ||
| 1045 | |||
| 1046 | memset(map, 0, bytes); | ||
| 1047 | for (node = 0; node < O2NM_MAX_NODES; ++node) { | ||
| 1048 | o2net_tx_can_proceed(o2net_nn_from_num(node), &sc, &ret); | ||
| 1049 | if (!ret) { | ||
| 1050 | set_bit(node, map); | ||
| 1051 | sc_put(sc); | ||
| 1052 | } | ||
| 1053 | } | ||
| 1054 | } | ||
| 1055 | EXPORT_SYMBOL_GPL(o2net_fill_node_map); | ||
| 1056 | |||
| 1038 | int o2net_send_message_vec(u32 msg_type, u32 key, struct kvec *caller_vec, | 1057 | int o2net_send_message_vec(u32 msg_type, u32 key, struct kvec *caller_vec, |
| 1039 | size_t caller_veclen, u8 target_node, int *status) | 1058 | size_t caller_veclen, u8 target_node, int *status) |
| 1040 | { | 1059 | { |
| @@ -1285,11 +1304,11 @@ static int o2net_check_handshake(struct o2net_sock_container *sc) | |||
| 1285 | struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num); | 1304 | struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num); |
| 1286 | 1305 | ||
| 1287 | if (hand->protocol_version != cpu_to_be64(O2NET_PROTOCOL_VERSION)) { | 1306 | if (hand->protocol_version != cpu_to_be64(O2NET_PROTOCOL_VERSION)) { |
| 1288 | mlog(ML_NOTICE, SC_NODEF_FMT " advertised net protocol " | 1307 | printk(KERN_NOTICE "o2net: " SC_NODEF_FMT " Advertised net " |
| 1289 | "version %llu but %llu is required, disconnecting\n", | 1308 | "protocol version %llu but %llu is required. " |
| 1290 | SC_NODEF_ARGS(sc), | 1309 | "Disconnecting.\n", SC_NODEF_ARGS(sc), |
| 1291 | (unsigned long long)be64_to_cpu(hand->protocol_version), | 1310 | (unsigned long long)be64_to_cpu(hand->protocol_version), |
| 1292 | O2NET_PROTOCOL_VERSION); | 1311 | O2NET_PROTOCOL_VERSION); |
| 1293 | 1312 | ||
| 1294 | /* don't bother reconnecting if its the wrong version. */ | 1313 | /* don't bother reconnecting if its the wrong version. */ |
| 1295 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); | 1314 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); |
| @@ -1303,33 +1322,33 @@ static int o2net_check_handshake(struct o2net_sock_container *sc) | |||
| 1303 | */ | 1322 | */ |
| 1304 | if (be32_to_cpu(hand->o2net_idle_timeout_ms) != | 1323 | if (be32_to_cpu(hand->o2net_idle_timeout_ms) != |
| 1305 | o2net_idle_timeout()) { | 1324 | o2net_idle_timeout()) { |
| 1306 | mlog(ML_NOTICE, SC_NODEF_FMT " uses a network idle timeout of " | 1325 | printk(KERN_NOTICE "o2net: " SC_NODEF_FMT " uses a network " |
| 1307 | "%u ms, but we use %u ms locally. disconnecting\n", | 1326 | "idle timeout of %u ms, but we use %u ms locally. " |
| 1308 | SC_NODEF_ARGS(sc), | 1327 | "Disconnecting.\n", SC_NODEF_ARGS(sc), |
| 1309 | be32_to_cpu(hand->o2net_idle_timeout_ms), | 1328 | be32_to_cpu(hand->o2net_idle_timeout_ms), |
| 1310 | o2net_idle_timeout()); | 1329 | o2net_idle_timeout()); |
| 1311 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); | 1330 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); |
| 1312 | return -1; | 1331 | return -1; |
| 1313 | } | 1332 | } |
| 1314 | 1333 | ||
| 1315 | if (be32_to_cpu(hand->o2net_keepalive_delay_ms) != | 1334 | if (be32_to_cpu(hand->o2net_keepalive_delay_ms) != |
| 1316 | o2net_keepalive_delay()) { | 1335 | o2net_keepalive_delay()) { |
| 1317 | mlog(ML_NOTICE, SC_NODEF_FMT " uses a keepalive delay of " | 1336 | printk(KERN_NOTICE "o2net: " SC_NODEF_FMT " uses a keepalive " |
| 1318 | "%u ms, but we use %u ms locally. disconnecting\n", | 1337 | "delay of %u ms, but we use %u ms locally. " |
| 1319 | SC_NODEF_ARGS(sc), | 1338 | "Disconnecting.\n", SC_NODEF_ARGS(sc), |
| 1320 | be32_to_cpu(hand->o2net_keepalive_delay_ms), | 1339 | be32_to_cpu(hand->o2net_keepalive_delay_ms), |
| 1321 | o2net_keepalive_delay()); | 1340 | o2net_keepalive_delay()); |
| 1322 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); | 1341 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); |
| 1323 | return -1; | 1342 | return -1; |
| 1324 | } | 1343 | } |
| 1325 | 1344 | ||
| 1326 | if (be32_to_cpu(hand->o2hb_heartbeat_timeout_ms) != | 1345 | if (be32_to_cpu(hand->o2hb_heartbeat_timeout_ms) != |
| 1327 | O2HB_MAX_WRITE_TIMEOUT_MS) { | 1346 | O2HB_MAX_WRITE_TIMEOUT_MS) { |
| 1328 | mlog(ML_NOTICE, SC_NODEF_FMT " uses a heartbeat timeout of " | 1347 | printk(KERN_NOTICE "o2net: " SC_NODEF_FMT " uses a heartbeat " |
| 1329 | "%u ms, but we use %u ms locally. disconnecting\n", | 1348 | "timeout of %u ms, but we use %u ms locally. " |
| 1330 | SC_NODEF_ARGS(sc), | 1349 | "Disconnecting.\n", SC_NODEF_ARGS(sc), |
| 1331 | be32_to_cpu(hand->o2hb_heartbeat_timeout_ms), | 1350 | be32_to_cpu(hand->o2hb_heartbeat_timeout_ms), |
| 1332 | O2HB_MAX_WRITE_TIMEOUT_MS); | 1351 | O2HB_MAX_WRITE_TIMEOUT_MS); |
| 1333 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); | 1352 | o2net_ensure_shutdown(nn, sc, -ENOTCONN); |
| 1334 | return -1; | 1353 | return -1; |
| 1335 | } | 1354 | } |
| @@ -1540,28 +1559,16 @@ static void o2net_idle_timer(unsigned long data) | |||
| 1540 | { | 1559 | { |
| 1541 | struct o2net_sock_container *sc = (struct o2net_sock_container *)data; | 1560 | struct o2net_sock_container *sc = (struct o2net_sock_container *)data; |
| 1542 | struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num); | 1561 | struct o2net_node *nn = o2net_nn_from_num(sc->sc_node->nd_num); |
| 1543 | |||
| 1544 | #ifdef CONFIG_DEBUG_FS | 1562 | #ifdef CONFIG_DEBUG_FS |
| 1545 | ktime_t now = ktime_get(); | 1563 | unsigned long msecs = ktime_to_ms(ktime_get()) - |
| 1564 | ktime_to_ms(sc->sc_tv_timer); | ||
| 1565 | #else | ||
| 1566 | unsigned long msecs = o2net_idle_timeout(); | ||
| 1546 | #endif | 1567 | #endif |
| 1547 | 1568 | ||
| 1548 | printk(KERN_NOTICE "o2net: connection to " SC_NODEF_FMT " has been idle for %u.%u " | 1569 | printk(KERN_NOTICE "o2net: Connection to " SC_NODEF_FMT " has been " |
| 1549 | "seconds, shutting it down.\n", SC_NODEF_ARGS(sc), | 1570 | "idle for %lu.%lu secs, shutting it down.\n", SC_NODEF_ARGS(sc), |
| 1550 | o2net_idle_timeout() / 1000, | 1571 | msecs / 1000, msecs % 1000); |
| 1551 | o2net_idle_timeout() % 1000); | ||
| 1552 | |||
| 1553 | #ifdef CONFIG_DEBUG_FS | ||
| 1554 | mlog(ML_NOTICE, "Here are some times that might help debug the " | ||
| 1555 | "situation: (Timer: %lld, Now %lld, DataReady %lld, Advance %lld-%lld, " | ||
| 1556 | "Key 0x%08x, Func %u, FuncTime %lld-%lld)\n", | ||
| 1557 | (long long)ktime_to_us(sc->sc_tv_timer), (long long)ktime_to_us(now), | ||
| 1558 | (long long)ktime_to_us(sc->sc_tv_data_ready), | ||
| 1559 | (long long)ktime_to_us(sc->sc_tv_advance_start), | ||
| 1560 | (long long)ktime_to_us(sc->sc_tv_advance_stop), | ||
| 1561 | sc->sc_msg_key, sc->sc_msg_type, | ||
| 1562 | (long long)ktime_to_us(sc->sc_tv_func_start), | ||
| 1563 | (long long)ktime_to_us(sc->sc_tv_func_stop)); | ||
| 1564 | #endif | ||
| 1565 | 1572 | ||
| 1566 | /* | 1573 | /* |
| 1567 | * Initialize the nn_timeout so that the next connection attempt | 1574 | * Initialize the nn_timeout so that the next connection attempt |
| @@ -1694,8 +1701,8 @@ static void o2net_start_connect(struct work_struct *work) | |||
| 1694 | 1701 | ||
| 1695 | out: | 1702 | out: |
| 1696 | if (ret) { | 1703 | if (ret) { |
| 1697 | mlog(ML_NOTICE, "connect attempt to " SC_NODEF_FMT " failed " | 1704 | printk(KERN_NOTICE "o2net: Connect attempt to " SC_NODEF_FMT |
| 1698 | "with errno %d\n", SC_NODEF_ARGS(sc), ret); | 1705 | " failed with errno %d\n", SC_NODEF_ARGS(sc), ret); |
| 1699 | /* 0 err so that another will be queued and attempted | 1706 | /* 0 err so that another will be queued and attempted |
| 1700 | * from set_nn_state */ | 1707 | * from set_nn_state */ |
| 1701 | if (sc) | 1708 | if (sc) |
| @@ -1718,8 +1725,8 @@ static void o2net_connect_expired(struct work_struct *work) | |||
| 1718 | 1725 | ||
| 1719 | spin_lock(&nn->nn_lock); | 1726 | spin_lock(&nn->nn_lock); |
| 1720 | if (!nn->nn_sc_valid) { | 1727 | if (!nn->nn_sc_valid) { |
| 1721 | mlog(ML_ERROR, "no connection established with node %u after " | 1728 | printk(KERN_NOTICE "o2net: No connection established with " |
| 1722 | "%u.%u seconds, giving up and returning errors.\n", | 1729 | "node %u after %u.%u seconds, giving up.\n", |
| 1723 | o2net_num_from_nn(nn), | 1730 | o2net_num_from_nn(nn), |
| 1724 | o2net_idle_timeout() / 1000, | 1731 | o2net_idle_timeout() / 1000, |
| 1725 | o2net_idle_timeout() % 1000); | 1732 | o2net_idle_timeout() % 1000); |
| @@ -1862,21 +1869,21 @@ static int o2net_accept_one(struct socket *sock) | |||
| 1862 | 1869 | ||
| 1863 | node = o2nm_get_node_by_ip(sin.sin_addr.s_addr); | 1870 | node = o2nm_get_node_by_ip(sin.sin_addr.s_addr); |
| 1864 | if (node == NULL) { | 1871 | if (node == NULL) { |
| 1865 | mlog(ML_NOTICE, "attempt to connect from unknown node at %pI4:%d\n", | 1872 | printk(KERN_NOTICE "o2net: Attempt to connect from unknown " |
| 1866 | &sin.sin_addr.s_addr, ntohs(sin.sin_port)); | 1873 | "node at %pI4:%d\n", &sin.sin_addr.s_addr, |
| 1874 | ntohs(sin.sin_port)); | ||
| 1867 | ret = -EINVAL; | 1875 | ret = -EINVAL; |
| 1868 | goto out; | 1876 | goto out; |
| 1869 | } | 1877 | } |
| 1870 | 1878 | ||
| 1871 | if (o2nm_this_node() >= node->nd_num) { | 1879 | if (o2nm_this_node() >= node->nd_num) { |
| 1872 | local_node = o2nm_get_node_by_num(o2nm_this_node()); | 1880 | local_node = o2nm_get_node_by_num(o2nm_this_node()); |
| 1873 | mlog(ML_NOTICE, "unexpected connect attempt seen at node '%s' (" | 1881 | printk(KERN_NOTICE "o2net: Unexpected connect attempt seen " |
| 1874 | "%u, %pI4:%d) from node '%s' (%u, %pI4:%d)\n", | 1882 | "at node '%s' (%u, %pI4:%d) from node '%s' (%u, " |
| 1875 | local_node->nd_name, local_node->nd_num, | 1883 | "%pI4:%d)\n", local_node->nd_name, local_node->nd_num, |
| 1876 | &(local_node->nd_ipv4_address), | 1884 | &(local_node->nd_ipv4_address), |
| 1877 | ntohs(local_node->nd_ipv4_port), | 1885 | ntohs(local_node->nd_ipv4_port), node->nd_name, |
| 1878 | node->nd_name, node->nd_num, &sin.sin_addr.s_addr, | 1886 | node->nd_num, &sin.sin_addr.s_addr, ntohs(sin.sin_port)); |
| 1879 | ntohs(sin.sin_port)); | ||
| 1880 | ret = -EINVAL; | 1887 | ret = -EINVAL; |
| 1881 | goto out; | 1888 | goto out; |
| 1882 | } | 1889 | } |
| @@ -1901,10 +1908,10 @@ static int o2net_accept_one(struct socket *sock) | |||
| 1901 | ret = 0; | 1908 | ret = 0; |
| 1902 | spin_unlock(&nn->nn_lock); | 1909 | spin_unlock(&nn->nn_lock); |
| 1903 | if (ret) { | 1910 | if (ret) { |
| 1904 | mlog(ML_NOTICE, "attempt to connect from node '%s' at " | 1911 | printk(KERN_NOTICE "o2net: Attempt to connect from node '%s' " |
| 1905 | "%pI4:%d but it already has an open connection\n", | 1912 | "at %pI4:%d but it already has an open connection\n", |
| 1906 | node->nd_name, &sin.sin_addr.s_addr, | 1913 | node->nd_name, &sin.sin_addr.s_addr, |
| 1907 | ntohs(sin.sin_port)); | 1914 | ntohs(sin.sin_port)); |
| 1908 | goto out; | 1915 | goto out; |
| 1909 | } | 1916 | } |
| 1910 | 1917 | ||
| @@ -1984,7 +1991,7 @@ static int o2net_open_listening_sock(__be32 addr, __be16 port) | |||
| 1984 | 1991 | ||
| 1985 | ret = sock_create(PF_INET, SOCK_STREAM, IPPROTO_TCP, &sock); | 1992 | ret = sock_create(PF_INET, SOCK_STREAM, IPPROTO_TCP, &sock); |
| 1986 | if (ret < 0) { | 1993 | if (ret < 0) { |
| 1987 | mlog(ML_ERROR, "unable to create socket, ret=%d\n", ret); | 1994 | printk(KERN_ERR "o2net: Error %d while creating socket\n", ret); |
| 1988 | goto out; | 1995 | goto out; |
| 1989 | } | 1996 | } |
| 1990 | 1997 | ||
| @@ -2001,16 +2008,15 @@ static int o2net_open_listening_sock(__be32 addr, __be16 port) | |||
| 2001 | sock->sk->sk_reuse = 1; | 2008 | sock->sk->sk_reuse = 1; |
| 2002 | ret = sock->ops->bind(sock, (struct sockaddr *)&sin, sizeof(sin)); | 2009 | ret = sock->ops->bind(sock, (struct sockaddr *)&sin, sizeof(sin)); |
| 2003 | if (ret < 0) { | 2010 | if (ret < 0) { |
| 2004 | mlog(ML_ERROR, "unable to bind socket at %pI4:%u, " | 2011 | printk(KERN_ERR "o2net: Error %d while binding socket at " |
| 2005 | "ret=%d\n", &addr, ntohs(port), ret); | 2012 | "%pI4:%u\n", ret, &addr, ntohs(port)); |
| 2006 | goto out; | 2013 | goto out; |
| 2007 | } | 2014 | } |
| 2008 | 2015 | ||
| 2009 | ret = sock->ops->listen(sock, 64); | 2016 | ret = sock->ops->listen(sock, 64); |
| 2010 | if (ret < 0) { | 2017 | if (ret < 0) |
| 2011 | mlog(ML_ERROR, "unable to listen on %pI4:%u, ret=%d\n", | 2018 | printk(KERN_ERR "o2net: Error %d while listening on %pI4:%u\n", |
| 2012 | &addr, ntohs(port), ret); | 2019 | ret, &addr, ntohs(port)); |
| 2013 | } | ||
| 2014 | 2020 | ||
| 2015 | out: | 2021 | out: |
| 2016 | if (ret) { | 2022 | if (ret) { |
diff --git a/fs/ocfs2/cluster/tcp.h b/fs/ocfs2/cluster/tcp.h index fd6179eb26d4..5bada2a69b50 100644 --- a/fs/ocfs2/cluster/tcp.h +++ b/fs/ocfs2/cluster/tcp.h | |||
| @@ -106,6 +106,8 @@ int o2net_register_handler(u32 msg_type, u32 key, u32 max_len, | |||
| 106 | struct list_head *unreg_list); | 106 | struct list_head *unreg_list); |
| 107 | void o2net_unregister_handler_list(struct list_head *list); | 107 | void o2net_unregister_handler_list(struct list_head *list); |
| 108 | 108 | ||
| 109 | void o2net_fill_node_map(unsigned long *map, unsigned bytes); | ||
| 110 | |||
| 109 | struct o2nm_node; | 111 | struct o2nm_node; |
| 110 | int o2net_register_hb_callbacks(void); | 112 | int o2net_register_hb_callbacks(void); |
| 111 | void o2net_unregister_hb_callbacks(void); | 113 | void o2net_unregister_hb_callbacks(void); |
diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index e2878b5895fb..8fe4e2892ab9 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c | |||
| @@ -1184,8 +1184,7 @@ static int __ocfs2_delete_entry(handle_t *handle, struct inode *dir, | |||
| 1184 | if (pde) | 1184 | if (pde) |
| 1185 | le16_add_cpu(&pde->rec_len, | 1185 | le16_add_cpu(&pde->rec_len, |
| 1186 | le16_to_cpu(de->rec_len)); | 1186 | le16_to_cpu(de->rec_len)); |
| 1187 | else | 1187 | de->inode = 0; |
| 1188 | de->inode = 0; | ||
| 1189 | dir->i_version++; | 1188 | dir->i_version++; |
| 1190 | ocfs2_journal_dirty(handle, bh); | 1189 | ocfs2_journal_dirty(handle, bh); |
| 1191 | goto bail; | 1190 | goto bail; |
diff --git a/fs/ocfs2/dlm/dlmcommon.h b/fs/ocfs2/dlm/dlmcommon.h index d602abb51b61..a5952ceecba5 100644 --- a/fs/ocfs2/dlm/dlmcommon.h +++ b/fs/ocfs2/dlm/dlmcommon.h | |||
| @@ -859,8 +859,8 @@ void dlm_complete_recovery_thread(struct dlm_ctxt *dlm); | |||
| 859 | void dlm_wait_for_recovery(struct dlm_ctxt *dlm); | 859 | void dlm_wait_for_recovery(struct dlm_ctxt *dlm); |
| 860 | void dlm_kick_recovery_thread(struct dlm_ctxt *dlm); | 860 | void dlm_kick_recovery_thread(struct dlm_ctxt *dlm); |
| 861 | int dlm_is_node_dead(struct dlm_ctxt *dlm, u8 node); | 861 | int dlm_is_node_dead(struct dlm_ctxt *dlm, u8 node); |
| 862 | int dlm_wait_for_node_death(struct dlm_ctxt *dlm, u8 node, int timeout); | 862 | void dlm_wait_for_node_death(struct dlm_ctxt *dlm, u8 node, int timeout); |
| 863 | int dlm_wait_for_node_recovery(struct dlm_ctxt *dlm, u8 node, int timeout); | 863 | void dlm_wait_for_node_recovery(struct dlm_ctxt *dlm, u8 node, int timeout); |
| 864 | 864 | ||
| 865 | void dlm_put(struct dlm_ctxt *dlm); | 865 | void dlm_put(struct dlm_ctxt *dlm); |
| 866 | struct dlm_ctxt *dlm_grab(struct dlm_ctxt *dlm); | 866 | struct dlm_ctxt *dlm_grab(struct dlm_ctxt *dlm); |
| @@ -877,9 +877,8 @@ static inline void dlm_lockres_get(struct dlm_lock_resource *res) | |||
| 877 | kref_get(&res->refs); | 877 | kref_get(&res->refs); |
| 878 | } | 878 | } |
| 879 | void dlm_lockres_put(struct dlm_lock_resource *res); | 879 | void dlm_lockres_put(struct dlm_lock_resource *res); |
| 880 | void __dlm_unhash_lockres(struct dlm_lock_resource *res); | 880 | void __dlm_unhash_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res); |
| 881 | void __dlm_insert_lockres(struct dlm_ctxt *dlm, | 881 | void __dlm_insert_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res); |
| 882 | struct dlm_lock_resource *res); | ||
| 883 | struct dlm_lock_resource * __dlm_lookup_lockres_full(struct dlm_ctxt *dlm, | 882 | struct dlm_lock_resource * __dlm_lookup_lockres_full(struct dlm_ctxt *dlm, |
| 884 | const char *name, | 883 | const char *name, |
| 885 | unsigned int len, | 884 | unsigned int len, |
| @@ -902,46 +901,15 @@ struct dlm_lock_resource *dlm_new_lockres(struct dlm_ctxt *dlm, | |||
| 902 | const char *name, | 901 | const char *name, |
| 903 | unsigned int namelen); | 902 | unsigned int namelen); |
| 904 | 903 | ||
| 905 | #define dlm_lockres_set_refmap_bit(bit,res) \ | 904 | void dlm_lockres_set_refmap_bit(struct dlm_ctxt *dlm, |
| 906 | __dlm_lockres_set_refmap_bit(bit,res,__FILE__,__LINE__) | 905 | struct dlm_lock_resource *res, int bit); |
| 907 | #define dlm_lockres_clear_refmap_bit(bit,res) \ | 906 | void dlm_lockres_clear_refmap_bit(struct dlm_ctxt *dlm, |
| 908 | __dlm_lockres_clear_refmap_bit(bit,res,__FILE__,__LINE__) | 907 | struct dlm_lock_resource *res, int bit); |
| 909 | 908 | ||
| 910 | static inline void __dlm_lockres_set_refmap_bit(int bit, | 909 | void dlm_lockres_drop_inflight_ref(struct dlm_ctxt *dlm, |
| 911 | struct dlm_lock_resource *res, | 910 | struct dlm_lock_resource *res); |
| 912 | const char *file, | 911 | void dlm_lockres_grab_inflight_ref(struct dlm_ctxt *dlm, |
| 913 | int line) | 912 | struct dlm_lock_resource *res); |
| 914 | { | ||
| 915 | //printk("%s:%d:%.*s: setting bit %d\n", file, line, | ||
| 916 | // res->lockname.len, res->lockname.name, bit); | ||
| 917 | set_bit(bit, res->refmap); | ||
| 918 | } | ||
| 919 | |||
| 920 | static inline void __dlm_lockres_clear_refmap_bit(int bit, | ||
| 921 | struct dlm_lock_resource *res, | ||
| 922 | const char *file, | ||
| 923 | int line) | ||
| 924 | { | ||
| 925 | //printk("%s:%d:%.*s: clearing bit %d\n", file, line, | ||
| 926 | // res->lockname.len, res->lockname.name, bit); | ||
| 927 | clear_bit(bit, res->refmap); | ||
| 928 | } | ||
| 929 | |||
| 930 | void __dlm_lockres_drop_inflight_ref(struct dlm_ctxt *dlm, | ||
| 931 | struct dlm_lock_resource *res, | ||
| 932 | const char *file, | ||
| 933 | int line); | ||
| 934 | void __dlm_lockres_grab_inflight_ref(struct dlm_ctxt *dlm, | ||
| 935 | struct dlm_lock_resource *res, | ||
| 936 | int new_lockres, | ||
| 937 | const char *file, | ||
| 938 | int line); | ||
| 939 | #define dlm_lockres_drop_inflight_ref(d,r) \ | ||
| 940 | __dlm_lockres_drop_inflight_ref(d,r,__FILE__,__LINE__) | ||
| 941 | #define dlm_lockres_grab_inflight_ref(d,r) \ | ||
| 942 | __dlm_lockres_grab_inflight_ref(d,r,0,__FILE__,__LINE__) | ||
| 943 | #define dlm_lockres_grab_inflight_ref_new(d,r) \ | ||
| 944 | __dlm_lockres_grab_inflight_ref(d,r,1,__FILE__,__LINE__) | ||
| 945 | 913 | ||
| 946 | void dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock); | 914 | void dlm_queue_ast(struct dlm_ctxt *dlm, struct dlm_lock *lock); |
| 947 | void dlm_queue_bast(struct dlm_ctxt *dlm, struct dlm_lock *lock); | 915 | void dlm_queue_bast(struct dlm_ctxt *dlm, struct dlm_lock *lock); |
diff --git a/fs/ocfs2/dlm/dlmdomain.c b/fs/ocfs2/dlm/dlmdomain.c index 6ed6b95dcf93..92f2ead0fab6 100644 --- a/fs/ocfs2/dlm/dlmdomain.c +++ b/fs/ocfs2/dlm/dlmdomain.c | |||
| @@ -157,16 +157,18 @@ static int dlm_protocol_compare(struct dlm_protocol_version *existing, | |||
| 157 | 157 | ||
| 158 | static void dlm_unregister_domain_handlers(struct dlm_ctxt *dlm); | 158 | static void dlm_unregister_domain_handlers(struct dlm_ctxt *dlm); |
| 159 | 159 | ||
| 160 | void __dlm_unhash_lockres(struct dlm_lock_resource *lockres) | 160 | void __dlm_unhash_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res) |
| 161 | { | 161 | { |
| 162 | if (!hlist_unhashed(&lockres->hash_node)) { | 162 | if (hlist_unhashed(&res->hash_node)) |
| 163 | hlist_del_init(&lockres->hash_node); | 163 | return; |
| 164 | dlm_lockres_put(lockres); | 164 | |
| 165 | } | 165 | mlog(0, "%s: Unhash res %.*s\n", dlm->name, res->lockname.len, |
| 166 | res->lockname.name); | ||
| 167 | hlist_del_init(&res->hash_node); | ||
| 168 | dlm_lockres_put(res); | ||
| 166 | } | 169 | } |
| 167 | 170 | ||
| 168 | void __dlm_insert_lockres(struct dlm_ctxt *dlm, | 171 | void __dlm_insert_lockres(struct dlm_ctxt *dlm, struct dlm_lock_resource *res) |
| 169 | struct dlm_lock_resource *res) | ||
| 170 | { | 172 | { |
| 171 | struct hlist_head *bucket; | 173 | struct hlist_head *bucket; |
| 172 | struct qstr *q; | 174 | struct qstr *q; |
| @@ -180,6 +182,9 @@ void __dlm_insert_lockres(struct dlm_ctxt *dlm, | |||
| 180 | dlm_lockres_get(res); | 182 | dlm_lockres_get(res); |
| 181 | 183 | ||
| 182 | hlist_add_head(&res->hash_node, bucket); | 184 | hlist_add_head(&res->hash_node, bucket); |
| 185 | |||
| 186 | mlog(0, "%s: Hash res %.*s\n", dlm->name, res->lockname.len, | ||
| 187 | res->lockname.name); | ||
| 183 | } | 188 | } |
| 184 | 189 | ||
| 185 | struct dlm_lock_resource * __dlm_lookup_lockres_full(struct dlm_ctxt *dlm, | 190 | struct dlm_lock_resource * __dlm_lookup_lockres_full(struct dlm_ctxt *dlm, |
| @@ -539,17 +544,17 @@ again: | |||
| 539 | 544 | ||
| 540 | static void __dlm_print_nodes(struct dlm_ctxt *dlm) | 545 | static void __dlm_print_nodes(struct dlm_ctxt *dlm) |
| 541 | { | 546 | { |
| 542 | int node = -1; | 547 | int node = -1, num = 0; |
| 543 | 548 | ||
| 544 | assert_spin_locked(&dlm->spinlock); | 549 | assert_spin_locked(&dlm->spinlock); |
| 545 | 550 | ||
| 546 | printk(KERN_NOTICE "o2dlm: Nodes in domain %s: ", dlm->name); | 551 | printk("( "); |
| 547 | |||
| 548 | while ((node = find_next_bit(dlm->domain_map, O2NM_MAX_NODES, | 552 | while ((node = find_next_bit(dlm->domain_map, O2NM_MAX_NODES, |
| 549 | node + 1)) < O2NM_MAX_NODES) { | 553 | node + 1)) < O2NM_MAX_NODES) { |
| 550 | printk("%d ", node); | 554 | printk("%d ", node); |
| 555 | ++num; | ||
| 551 | } | 556 | } |
| 552 | printk("\n"); | 557 | printk(") %u nodes\n", num); |
| 553 | } | 558 | } |
| 554 | 559 | ||
| 555 | static int dlm_exit_domain_handler(struct o2net_msg *msg, u32 len, void *data, | 560 | static int dlm_exit_domain_handler(struct o2net_msg *msg, u32 len, void *data, |
| @@ -566,11 +571,10 @@ static int dlm_exit_domain_handler(struct o2net_msg *msg, u32 len, void *data, | |||
| 566 | 571 | ||
| 567 | node = exit_msg->node_idx; | 572 | node = exit_msg->node_idx; |
| 568 | 573 | ||
| 569 | printk(KERN_NOTICE "o2dlm: Node %u leaves domain %s\n", node, dlm->name); | ||
| 570 | |||
| 571 | spin_lock(&dlm->spinlock); | 574 | spin_lock(&dlm->spinlock); |
| 572 | clear_bit(node, dlm->domain_map); | 575 | clear_bit(node, dlm->domain_map); |
| 573 | clear_bit(node, dlm->exit_domain_map); | 576 | clear_bit(node, dlm->exit_domain_map); |
| 577 | printk(KERN_NOTICE "o2dlm: Node %u leaves domain %s ", node, dlm->name); | ||
| 574 | __dlm_print_nodes(dlm); | 578 | __dlm_print_nodes(dlm); |
| 575 | 579 | ||
| 576 | /* notify anything attached to the heartbeat events */ | 580 | /* notify anything attached to the heartbeat events */ |
| @@ -755,6 +759,7 @@ void dlm_unregister_domain(struct dlm_ctxt *dlm) | |||
| 755 | 759 | ||
| 756 | dlm_mark_domain_leaving(dlm); | 760 | dlm_mark_domain_leaving(dlm); |
| 757 | dlm_leave_domain(dlm); | 761 | dlm_leave_domain(dlm); |
| 762 | printk(KERN_NOTICE "o2dlm: Leaving domain %s\n", dlm->name); | ||
| 758 | dlm_force_free_mles(dlm); | 763 | dlm_force_free_mles(dlm); |
| 759 | dlm_complete_dlm_shutdown(dlm); | 764 | dlm_complete_dlm_shutdown(dlm); |
| 760 | } | 765 | } |
| @@ -970,7 +975,7 @@ static int dlm_assert_joined_handler(struct o2net_msg *msg, u32 len, void *data, | |||
| 970 | clear_bit(assert->node_idx, dlm->exit_domain_map); | 975 | clear_bit(assert->node_idx, dlm->exit_domain_map); |
| 971 | __dlm_set_joining_node(dlm, DLM_LOCK_RES_OWNER_UNKNOWN); | 976 | __dlm_set_joining_node(dlm, DLM_LOCK_RES_OWNER_UNKNOWN); |
| 972 | 977 | ||
| 973 | printk(KERN_NOTICE "o2dlm: Node %u joins domain %s\n", | 978 | printk(KERN_NOTICE "o2dlm: Node %u joins domain %s ", |
| 974 | assert->node_idx, dlm->name); | 979 | assert->node_idx, dlm->name); |
| 975 | __dlm_print_nodes(dlm); | 980 | __dlm_print_nodes(dlm); |
| 976 | 981 | ||
| @@ -1701,8 +1706,10 @@ static int dlm_try_to_join_domain(struct dlm_ctxt *dlm) | |||
| 1701 | bail: | 1706 | bail: |
| 1702 | spin_lock(&dlm->spinlock); | 1707 | spin_lock(&dlm->spinlock); |
| 1703 | __dlm_set_joining_node(dlm, DLM_LOCK_RES_OWNER_UNKNOWN); | 1708 | __dlm_set_joining_node(dlm, DLM_LOCK_RES_OWNER_UNKNOWN); |
| 1704 | if (!status) | 1709 | if (!status) { |
| 1710 | printk(KERN_NOTICE "o2dlm: Joining domain %s ", dlm->name); | ||
| 1705 | __dlm_print_nodes(dlm); | 1711 | __dlm_print_nodes(dlm); |
| 1712 | } | ||
| 1706 | spin_unlock(&dlm->spinlock); | 1713 | spin_unlock(&dlm->spinlock); |
| 1707 | 1714 | ||
| 1708 | if (ctxt) { | 1715 | if (ctxt) { |
| @@ -2131,13 +2138,6 @@ struct dlm_ctxt * dlm_register_domain(const char *domain, | |||
| 2131 | goto leave; | 2138 | goto leave; |
| 2132 | } | 2139 | } |
| 2133 | 2140 | ||
| 2134 | if (!o2hb_check_local_node_heartbeating()) { | ||
| 2135 | mlog(ML_ERROR, "the local node has not been configured, or is " | ||
| 2136 | "not heartbeating\n"); | ||
| 2137 | ret = -EPROTO; | ||
| 2138 | goto leave; | ||
| 2139 | } | ||
| 2140 | |||
| 2141 | mlog(0, "register called for domain \"%s\"\n", domain); | 2141 | mlog(0, "register called for domain \"%s\"\n", domain); |
| 2142 | 2142 | ||
| 2143 | retry: | 2143 | retry: |
diff --git a/fs/ocfs2/dlm/dlmlock.c b/fs/ocfs2/dlm/dlmlock.c index 8d39e0fd66f7..975810b98492 100644 --- a/fs/ocfs2/dlm/dlmlock.c +++ b/fs/ocfs2/dlm/dlmlock.c | |||
| @@ -183,10 +183,6 @@ static enum dlm_status dlmlock_master(struct dlm_ctxt *dlm, | |||
| 183 | kick_thread = 1; | 183 | kick_thread = 1; |
| 184 | } | 184 | } |
| 185 | } | 185 | } |
| 186 | /* reduce the inflight count, this may result in the lockres | ||
| 187 | * being purged below during calc_usage */ | ||
| 188 | if (lock->ml.node == dlm->node_num) | ||
| 189 | dlm_lockres_drop_inflight_ref(dlm, res); | ||
| 190 | 186 | ||
| 191 | spin_unlock(&res->spinlock); | 187 | spin_unlock(&res->spinlock); |
| 192 | wake_up(&res->wq); | 188 | wake_up(&res->wq); |
| @@ -231,10 +227,16 @@ static enum dlm_status dlmlock_remote(struct dlm_ctxt *dlm, | |||
| 231 | lock->ml.type, res->lockname.len, | 227 | lock->ml.type, res->lockname.len, |
| 232 | res->lockname.name, flags); | 228 | res->lockname.name, flags); |
| 233 | 229 | ||
| 230 | /* | ||
| 231 | * Wait if resource is getting recovered, remastered, etc. | ||
| 232 | * If the resource was remastered and new owner is self, then exit. | ||
| 233 | */ | ||
| 234 | spin_lock(&res->spinlock); | 234 | spin_lock(&res->spinlock); |
| 235 | |||
| 236 | /* will exit this call with spinlock held */ | ||
| 237 | __dlm_wait_on_lockres(res); | 235 | __dlm_wait_on_lockres(res); |
| 236 | if (res->owner == dlm->node_num) { | ||
| 237 | spin_unlock(&res->spinlock); | ||
| 238 | return DLM_RECOVERING; | ||
| 239 | } | ||
| 238 | res->state |= DLM_LOCK_RES_IN_PROGRESS; | 240 | res->state |= DLM_LOCK_RES_IN_PROGRESS; |
| 239 | 241 | ||
| 240 | /* add lock to local (secondary) queue */ | 242 | /* add lock to local (secondary) queue */ |
| @@ -319,27 +321,23 @@ static enum dlm_status dlm_send_remote_lock_request(struct dlm_ctxt *dlm, | |||
| 319 | tmpret = o2net_send_message(DLM_CREATE_LOCK_MSG, dlm->key, &create, | 321 | tmpret = o2net_send_message(DLM_CREATE_LOCK_MSG, dlm->key, &create, |
| 320 | sizeof(create), res->owner, &status); | 322 | sizeof(create), res->owner, &status); |
| 321 | if (tmpret >= 0) { | 323 | if (tmpret >= 0) { |
| 322 | // successfully sent and received | 324 | ret = status; |
| 323 | ret = status; // this is already a dlm_status | ||
| 324 | if (ret == DLM_REJECTED) { | 325 | if (ret == DLM_REJECTED) { |
| 325 | mlog(ML_ERROR, "%s:%.*s: BUG. this is a stale lockres " | 326 | mlog(ML_ERROR, "%s: res %.*s, Stale lockres no longer " |
| 326 | "no longer owned by %u. that node is coming back " | 327 | "owned by node %u. That node is coming back up " |
| 327 | "up currently.\n", dlm->name, create.namelen, | 328 | "currently.\n", dlm->name, create.namelen, |
| 328 | create.name, res->owner); | 329 | create.name, res->owner); |
| 329 | dlm_print_one_lock_resource(res); | 330 | dlm_print_one_lock_resource(res); |
| 330 | BUG(); | 331 | BUG(); |
| 331 | } | 332 | } |
| 332 | } else { | 333 | } else { |
| 333 | mlog(ML_ERROR, "Error %d when sending message %u (key 0x%x) to " | 334 | mlog(ML_ERROR, "%s: res %.*s, Error %d send CREATE LOCK to " |
| 334 | "node %u\n", tmpret, DLM_CREATE_LOCK_MSG, dlm->key, | 335 | "node %u\n", dlm->name, create.namelen, create.name, |
| 335 | res->owner); | 336 | tmpret, res->owner); |
| 336 | if (dlm_is_host_down(tmpret)) { | 337 | if (dlm_is_host_down(tmpret)) |
| 337 | ret = DLM_RECOVERING; | 338 | ret = DLM_RECOVERING; |
| 338 | mlog(0, "node %u died so returning DLM_RECOVERING " | 339 | else |
| 339 | "from lock message!\n", res->owner); | ||
| 340 | } else { | ||
| 341 | ret = dlm_err_to_dlm_status(tmpret); | 340 | ret = dlm_err_to_dlm_status(tmpret); |
| 342 | } | ||
| 343 | } | 341 | } |
| 344 | 342 | ||
| 345 | return ret; | 343 | return ret; |
| @@ -440,7 +438,7 @@ struct dlm_lock * dlm_new_lock(int type, u8 node, u64 cookie, | |||
| 440 | /* zero memory only if kernel-allocated */ | 438 | /* zero memory only if kernel-allocated */ |
| 441 | lksb = kzalloc(sizeof(*lksb), GFP_NOFS); | 439 | lksb = kzalloc(sizeof(*lksb), GFP_NOFS); |
| 442 | if (!lksb) { | 440 | if (!lksb) { |
| 443 | kfree(lock); | 441 | kmem_cache_free(dlm_lock_cache, lock); |
| 444 | return NULL; | 442 | return NULL; |
| 445 | } | 443 | } |
| 446 | kernel_allocated = 1; | 444 | kernel_allocated = 1; |
| @@ -718,18 +716,10 @@ retry_lock: | |||
| 718 | 716 | ||
| 719 | if (status == DLM_RECOVERING || status == DLM_MIGRATING || | 717 | if (status == DLM_RECOVERING || status == DLM_MIGRATING || |
| 720 | status == DLM_FORWARD) { | 718 | status == DLM_FORWARD) { |
| 721 | mlog(0, "retrying lock with migration/" | ||
| 722 | "recovery/in progress\n"); | ||
| 723 | msleep(100); | 719 | msleep(100); |
| 724 | /* no waiting for dlm_reco_thread */ | ||
| 725 | if (recovery) { | 720 | if (recovery) { |
| 726 | if (status != DLM_RECOVERING) | 721 | if (status != DLM_RECOVERING) |
| 727 | goto retry_lock; | 722 | goto retry_lock; |
| 728 | |||
| 729 | mlog(0, "%s: got RECOVERING " | ||
| 730 | "for $RECOVERY lock, master " | ||
| 731 | "was %u\n", dlm->name, | ||
| 732 | res->owner); | ||
| 733 | /* wait to see the node go down, then | 723 | /* wait to see the node go down, then |
| 734 | * drop down and allow the lockres to | 724 | * drop down and allow the lockres to |
| 735 | * get cleaned up. need to remaster. */ | 725 | * get cleaned up. need to remaster. */ |
| @@ -741,6 +731,14 @@ retry_lock: | |||
| 741 | } | 731 | } |
| 742 | } | 732 | } |
| 743 | 733 | ||
| 734 | /* Inflight taken in dlm_get_lock_resource() is dropped here */ | ||
| 735 | spin_lock(&res->spinlock); | ||
| 736 | dlm_lockres_drop_inflight_ref(dlm, res); | ||
| 737 | spin_unlock(&res->spinlock); | ||
| 738 | |||
| 739 | dlm_lockres_calc_usage(dlm, res); | ||
| 740 | dlm_kick_thread(dlm, res); | ||
| 741 | |||
| 744 | if (status != DLM_NORMAL) { | 742 | if (status != DLM_NORMAL) { |
| 745 | lock->lksb->flags &= ~DLM_LKSB_GET_LVB; | 743 | lock->lksb->flags &= ~DLM_LKSB_GET_LVB; |
| 746 | if (status != DLM_NOTQUEUED) | 744 | if (status != DLM_NOTQUEUED) |
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c index 11eefb8c12e9..005261c333b0 100644 --- a/fs/ocfs2/dlm/dlmmaster.c +++ b/fs/ocfs2/dlm/dlmmaster.c | |||
| @@ -631,39 +631,54 @@ error: | |||
| 631 | return NULL; | 631 | return NULL; |
| 632 | } | 632 | } |
| 633 | 633 | ||
| 634 | void __dlm_lockres_grab_inflight_ref(struct dlm_ctxt *dlm, | 634 | void dlm_lockres_set_refmap_bit(struct dlm_ctxt *dlm, |
| 635 | struct dlm_lock_resource *res, | 635 | struct dlm_lock_resource *res, int bit) |
| 636 | int new_lockres, | ||
| 637 | const char *file, | ||
| 638 | int line) | ||
| 639 | { | 636 | { |
| 640 | if (!new_lockres) | 637 | assert_spin_locked(&res->spinlock); |
| 641 | assert_spin_locked(&res->spinlock); | 638 | |
| 639 | mlog(0, "res %.*s, set node %u, %ps()\n", res->lockname.len, | ||
| 640 | res->lockname.name, bit, __builtin_return_address(0)); | ||
| 641 | |||
| 642 | set_bit(bit, res->refmap); | ||
| 643 | } | ||
| 644 | |||
| 645 | void dlm_lockres_clear_refmap_bit(struct dlm_ctxt *dlm, | ||
| 646 | struct dlm_lock_resource *res, int bit) | ||
| 647 | { | ||
| 648 | assert_spin_locked(&res->spinlock); | ||
| 649 | |||
| 650 | mlog(0, "res %.*s, clr node %u, %ps()\n", res->lockname.len, | ||
| 651 | res->lockname.name, bit, __builtin_return_address(0)); | ||
| 652 | |||
| 653 | clear_bit(bit, res->refmap); | ||
| 654 | } | ||
| 655 | |||
| 656 | |||
| 657 | void dlm_lockres_grab_inflight_ref(struct dlm_ctxt *dlm, | ||
| 658 | struct dlm_lock_resource *res) | ||
| 659 | { | ||
| 660 | assert_spin_locked(&res->spinlock); | ||
| 642 | 661 | ||
| 643 | if (!test_bit(dlm->node_num, res->refmap)) { | ||
| 644 | BUG_ON(res->inflight_locks != 0); | ||
| 645 | dlm_lockres_set_refmap_bit(dlm->node_num, res); | ||
| 646 | } | ||
| 647 | res->inflight_locks++; | 662 | res->inflight_locks++; |
| 648 | mlog(0, "%s:%.*s: inflight++: now %u\n", | 663 | |
| 649 | dlm->name, res->lockname.len, res->lockname.name, | 664 | mlog(0, "%s: res %.*s, inflight++: now %u, %ps()\n", dlm->name, |
| 650 | res->inflight_locks); | 665 | res->lockname.len, res->lockname.name, res->inflight_locks, |
| 666 | __builtin_return_address(0)); | ||
| 651 | } | 667 | } |
| 652 | 668 | ||
| 653 | void __dlm_lockres_drop_inflight_ref(struct dlm_ctxt *dlm, | 669 | void dlm_lockres_drop_inflight_ref(struct dlm_ctxt *dlm, |
| 654 | struct dlm_lock_resource *res, | 670 | struct dlm_lock_resource *res) |
| 655 | const char *file, | ||
| 656 | int line) | ||
| 657 | { | 671 | { |
| 658 | assert_spin_locked(&res->spinlock); | 672 | assert_spin_locked(&res->spinlock); |
| 659 | 673 | ||
| 660 | BUG_ON(res->inflight_locks == 0); | 674 | BUG_ON(res->inflight_locks == 0); |
| 675 | |||
| 661 | res->inflight_locks--; | 676 | res->inflight_locks--; |
| 662 | mlog(0, "%s:%.*s: inflight--: now %u\n", | 677 | |
| 663 | dlm->name, res->lockname.len, res->lockname.name, | 678 | mlog(0, "%s: res %.*s, inflight--: now %u, %ps()\n", dlm->name, |
| 664 | res->inflight_locks); | 679 | res->lockname.len, res->lockname.name, res->inflight_locks, |
| 665 | if (res->inflight_locks == 0) | 680 | __builtin_return_address(0)); |
| 666 | dlm_lockres_clear_refmap_bit(dlm->node_num, res); | 681 | |
| 667 | wake_up(&res->wq); | 682 | wake_up(&res->wq); |
| 668 | } | 683 | } |
| 669 | 684 | ||
| @@ -697,7 +712,6 @@ struct dlm_lock_resource * dlm_get_lock_resource(struct dlm_ctxt *dlm, | |||
| 697 | unsigned int hash; | 712 | unsigned int hash; |
| 698 | int tries = 0; | 713 | int tries = 0; |
| 699 | int bit, wait_on_recovery = 0; | 714 | int bit, wait_on_recovery = 0; |
| 700 | int drop_inflight_if_nonlocal = 0; | ||
| 701 | 715 | ||
| 702 | BUG_ON(!lockid); | 716 | BUG_ON(!lockid); |
| 703 | 717 | ||
| @@ -709,36 +723,33 @@ lookup: | |||
| 709 | spin_lock(&dlm->spinlock); | 723 | spin_lock(&dlm->spinlock); |
| 710 | tmpres = __dlm_lookup_lockres_full(dlm, lockid, namelen, hash); | 724 | tmpres = __dlm_lookup_lockres_full(dlm, lockid, namelen, hash); |
| 711 | if (tmpres) { | 725 | if (tmpres) { |
| 712 | int dropping_ref = 0; | ||
| 713 | |||
| 714 | spin_unlock(&dlm->spinlock); | 726 | spin_unlock(&dlm->spinlock); |
| 715 | |||
| 716 | spin_lock(&tmpres->spinlock); | 727 | spin_lock(&tmpres->spinlock); |
| 717 | /* We wait for the other thread that is mastering the resource */ | 728 | /* Wait on the thread that is mastering the resource */ |
| 718 | if (tmpres->owner == DLM_LOCK_RES_OWNER_UNKNOWN) { | 729 | if (tmpres->owner == DLM_LOCK_RES_OWNER_UNKNOWN) { |
| 719 | __dlm_wait_on_lockres(tmpres); | 730 | __dlm_wait_on_lockres(tmpres); |
| 720 | BUG_ON(tmpres->owner == DLM_LOCK_RES_OWNER_UNKNOWN); | 731 | BUG_ON(tmpres->owner == DLM_LOCK_RES_OWNER_UNKNOWN); |
| 732 | spin_unlock(&tmpres->spinlock); | ||
| 733 | dlm_lockres_put(tmpres); | ||
| 734 | tmpres = NULL; | ||
| 735 | goto lookup; | ||
| 721 | } | 736 | } |
| 722 | 737 | ||
| 723 | if (tmpres->owner == dlm->node_num) { | 738 | /* Wait on the resource purge to complete before continuing */ |
| 724 | BUG_ON(tmpres->state & DLM_LOCK_RES_DROPPING_REF); | 739 | if (tmpres->state & DLM_LOCK_RES_DROPPING_REF) { |
| 725 | dlm_lockres_grab_inflight_ref(dlm, tmpres); | 740 | BUG_ON(tmpres->owner == dlm->node_num); |
| 726 | } else if (tmpres->state & DLM_LOCK_RES_DROPPING_REF) | 741 | __dlm_wait_on_lockres_flags(tmpres, |
| 727 | dropping_ref = 1; | 742 | DLM_LOCK_RES_DROPPING_REF); |
| 728 | spin_unlock(&tmpres->spinlock); | ||
| 729 | |||
| 730 | /* wait until done messaging the master, drop our ref to allow | ||
| 731 | * the lockres to be purged, start over. */ | ||
| 732 | if (dropping_ref) { | ||
| 733 | spin_lock(&tmpres->spinlock); | ||
| 734 | __dlm_wait_on_lockres_flags(tmpres, DLM_LOCK_RES_DROPPING_REF); | ||
| 735 | spin_unlock(&tmpres->spinlock); | 743 | spin_unlock(&tmpres->spinlock); |
| 736 | dlm_lockres_put(tmpres); | 744 | dlm_lockres_put(tmpres); |
| 737 | tmpres = NULL; | 745 | tmpres = NULL; |
| 738 | goto lookup; | 746 | goto lookup; |
| 739 | } | 747 | } |
| 740 | 748 | ||
| 741 | mlog(0, "found in hash!\n"); | 749 | /* Grab inflight ref to pin the resource */ |
| 750 | dlm_lockres_grab_inflight_ref(dlm, tmpres); | ||
| 751 | |||
| 752 | spin_unlock(&tmpres->spinlock); | ||
| 742 | if (res) | 753 | if (res) |
| 743 | dlm_lockres_put(res); | 754 | dlm_lockres_put(res); |
| 744 | res = tmpres; | 755 | res = tmpres; |
| @@ -829,8 +840,8 @@ lookup: | |||
| 829 | * but they might own this lockres. wait on them. */ | 840 | * but they might own this lockres. wait on them. */ |
| 830 | bit = find_next_bit(dlm->recovery_map, O2NM_MAX_NODES, 0); | 841 | bit = find_next_bit(dlm->recovery_map, O2NM_MAX_NODES, 0); |
| 831 | if (bit < O2NM_MAX_NODES) { | 842 | if (bit < O2NM_MAX_NODES) { |
| 832 | mlog(ML_NOTICE, "%s:%.*s: at least one node (%d) to " | 843 | mlog(0, "%s: res %.*s, At least one node (%d) " |
| 833 | "recover before lock mastery can begin\n", | 844 | "to recover before lock mastery can begin\n", |
| 834 | dlm->name, namelen, (char *)lockid, bit); | 845 | dlm->name, namelen, (char *)lockid, bit); |
| 835 | wait_on_recovery = 1; | 846 | wait_on_recovery = 1; |
| 836 | } | 847 | } |
| @@ -843,12 +854,11 @@ lookup: | |||
| 843 | 854 | ||
| 844 | /* finally add the lockres to its hash bucket */ | 855 | /* finally add the lockres to its hash bucket */ |
| 845 | __dlm_insert_lockres(dlm, res); | 856 | __dlm_insert_lockres(dlm, res); |
| 846 | /* since this lockres is new it doesn't not require the spinlock */ | ||
| 847 | dlm_lockres_grab_inflight_ref_new(dlm, res); | ||
| 848 | 857 | ||
| 849 | /* if this node does not become the master make sure to drop | 858 | /* Grab inflight ref to pin the resource */ |
| 850 | * this inflight reference below */ | 859 | spin_lock(&res->spinlock); |
| 851 | drop_inflight_if_nonlocal = 1; | 860 | dlm_lockres_grab_inflight_ref(dlm, res); |
| 861 | spin_unlock(&res->spinlock); | ||
| 852 | 862 | ||
| 853 | /* get an extra ref on the mle in case this is a BLOCK | 863 | /* get an extra ref on the mle in case this is a BLOCK |
| 854 | * if so, the creator of the BLOCK may try to put the last | 864 | * if so, the creator of the BLOCK may try to put the last |
| @@ -864,8 +874,8 @@ redo_request: | |||
| 864 | * dlm spinlock would be detectable be a change on the mle, | 874 | * dlm spinlock would be detectable be a change on the mle, |
| 865 | * so we only need to clear out the recovery map once. */ | 875 | * so we only need to clear out the recovery map once. */ |
| 866 | if (dlm_is_recovery_lock(lockid, namelen)) { | 876 | if (dlm_is_recovery_lock(lockid, namelen)) { |
| 867 | mlog(ML_NOTICE, "%s: recovery map is not empty, but " | 877 | mlog(0, "%s: Recovery map is not empty, but must " |
| 868 | "must master $RECOVERY lock now\n", dlm->name); | 878 | "master $RECOVERY lock now\n", dlm->name); |
| 869 | if (!dlm_pre_master_reco_lockres(dlm, res)) | 879 | if (!dlm_pre_master_reco_lockres(dlm, res)) |
| 870 | wait_on_recovery = 0; | 880 | wait_on_recovery = 0; |
| 871 | else { | 881 | else { |
| @@ -883,8 +893,8 @@ redo_request: | |||
| 883 | spin_lock(&dlm->spinlock); | 893 | spin_lock(&dlm->spinlock); |
| 884 | bit = find_next_bit(dlm->recovery_map, O2NM_MAX_NODES, 0); | 894 | bit = find_next_bit(dlm->recovery_map, O2NM_MAX_NODES, 0); |
| 885 | if (bit < O2NM_MAX_NODES) { | 895 | if (bit < O2NM_MAX_NODES) { |
| 886 | mlog(ML_NOTICE, "%s:%.*s: at least one node (%d) to " | 896 | mlog(0, "%s: res %.*s, At least one node (%d) " |
| 887 | "recover before lock mastery can begin\n", | 897 | "to recover before lock mastery can begin\n", |
| 888 | dlm->name, namelen, (char *)lockid, bit); | 898 | dlm->name, namelen, (char *)lockid, bit); |
| 889 | wait_on_recovery = 1; | 899 | wait_on_recovery = 1; |
| 890 | } else | 900 | } else |
| @@ -913,8 +923,8 @@ redo_request: | |||
| 913 | * yet, keep going until it does. this is how the | 923 | * yet, keep going until it does. this is how the |
| 914 | * master will know that asserts are needed back to | 924 | * master will know that asserts are needed back to |
| 915 | * the lower nodes. */ | 925 | * the lower nodes. */ |
| 916 | mlog(0, "%s:%.*s: requests only up to %u but master " | 926 | mlog(0, "%s: res %.*s, Requests only up to %u but " |
| 917 | "is %u, keep going\n", dlm->name, namelen, | 927 | "master is %u, keep going\n", dlm->name, namelen, |
| 918 | lockid, nodenum, mle->master); | 928 | lockid, nodenum, mle->master); |
| 919 | } | 929 | } |
| 920 | } | 930 | } |
| @@ -924,13 +934,12 @@ wait: | |||
| 924 | ret = dlm_wait_for_lock_mastery(dlm, res, mle, &blocked); | 934 | ret = dlm_wait_for_lock_mastery(dlm, res, mle, &blocked); |
| 925 | if (ret < 0) { | 935 | if (ret < 0) { |
| 926 | wait_on_recovery = 1; | 936 | wait_on_recovery = 1; |
| 927 | mlog(0, "%s:%.*s: node map changed, redo the " | 937 | mlog(0, "%s: res %.*s, Node map changed, redo the master " |
| 928 | "master request now, blocked=%d\n", | 938 | "request now, blocked=%d\n", dlm->name, res->lockname.len, |
| 929 | dlm->name, res->lockname.len, | ||
| 930 | res->lockname.name, blocked); | 939 | res->lockname.name, blocked); |
| 931 | if (++tries > 20) { | 940 | if (++tries > 20) { |
| 932 | mlog(ML_ERROR, "%s:%.*s: spinning on " | 941 | mlog(ML_ERROR, "%s: res %.*s, Spinning on " |
| 933 | "dlm_wait_for_lock_mastery, blocked=%d\n", | 942 | "dlm_wait_for_lock_mastery, blocked = %d\n", |
| 934 | dlm->name, res->lockname.len, | 943 | dlm->name, res->lockname.len, |
| 935 | res->lockname.name, blocked); | 944 | res->lockname.name, blocked); |
| 936 | dlm_print_one_lock_resource(res); | 945 | dlm_print_one_lock_resource(res); |
| @@ -940,7 +949,8 @@ wait: | |||
| 940 | goto redo_request; | 949 | goto redo_request; |
| 941 | } | 950 | } |
| 942 | 951 | ||
| 943 | mlog(0, "lockres mastered by %u\n", res->owner); | 952 | mlog(0, "%s: res %.*s, Mastered by %u\n", dlm->name, res->lockname.len, |
| 953 | res->lockname.name, res->owner); | ||
| 944 | /* make sure we never continue without this */ | 954 | /* make sure we never continue without this */ |
| 945 | BUG_ON(res->owner == O2NM_MAX_NODES); | 955 | BUG_ON(res->owner == O2NM_MAX_NODES); |
| 946 | 956 | ||
| @@ -952,8 +962,6 @@ wait: | |||
| 952 | 962 | ||
| 953 | wake_waiters: | 963 | wake_waiters: |
| 954 | spin_lock(&res->spinlock); | 964 | spin_lock(&res->spinlock); |
| 955 | if (res->owner != dlm->node_num && drop_inflight_if_nonlocal) | ||
| 956 | dlm_lockres_drop_inflight_ref(dlm, res); | ||
| 957 | res->state &= ~DLM_LOCK_RES_IN_PROGRESS; | 965 | res->state &= ~DLM_LOCK_RES_IN_PROGRESS; |
| 958 | spin_unlock(&res->spinlock); | 966 | spin_unlock(&res->spinlock); |
| 959 | wake_up(&res->wq); | 967 | wake_up(&res->wq); |
| @@ -1426,9 +1434,7 @@ way_up_top: | |||
| 1426 | } | 1434 | } |
| 1427 | 1435 | ||
| 1428 | if (res->owner == dlm->node_num) { | 1436 | if (res->owner == dlm->node_num) { |
| 1429 | mlog(0, "%s:%.*s: setting bit %u in refmap\n", | 1437 | dlm_lockres_set_refmap_bit(dlm, res, request->node_idx); |
| 1430 | dlm->name, namelen, name, request->node_idx); | ||
| 1431 | dlm_lockres_set_refmap_bit(request->node_idx, res); | ||
| 1432 | spin_unlock(&res->spinlock); | 1438 | spin_unlock(&res->spinlock); |
| 1433 | response = DLM_MASTER_RESP_YES; | 1439 | response = DLM_MASTER_RESP_YES; |
| 1434 | if (mle) | 1440 | if (mle) |
| @@ -1493,10 +1499,8 @@ way_up_top: | |||
| 1493 | * go back and clean the mles on any | 1499 | * go back and clean the mles on any |
| 1494 | * other nodes */ | 1500 | * other nodes */ |
| 1495 | dispatch_assert = 1; | 1501 | dispatch_assert = 1; |
| 1496 | dlm_lockres_set_refmap_bit(request->node_idx, res); | 1502 | dlm_lockres_set_refmap_bit(dlm, res, |
| 1497 | mlog(0, "%s:%.*s: setting bit %u in refmap\n", | 1503 | request->node_idx); |
| 1498 | dlm->name, namelen, name, | ||
| 1499 | request->node_idx); | ||
| 1500 | } else | 1504 | } else |
| 1501 | response = DLM_MASTER_RESP_NO; | 1505 | response = DLM_MASTER_RESP_NO; |
| 1502 | } else { | 1506 | } else { |
| @@ -1702,7 +1706,7 @@ again: | |||
| 1702 | "lockres, set the bit in the refmap\n", | 1706 | "lockres, set the bit in the refmap\n", |
| 1703 | namelen, lockname, to); | 1707 | namelen, lockname, to); |
| 1704 | spin_lock(&res->spinlock); | 1708 | spin_lock(&res->spinlock); |
| 1705 | dlm_lockres_set_refmap_bit(to, res); | 1709 | dlm_lockres_set_refmap_bit(dlm, res, to); |
| 1706 | spin_unlock(&res->spinlock); | 1710 | spin_unlock(&res->spinlock); |
| 1707 | } | 1711 | } |
| 1708 | } | 1712 | } |
| @@ -2187,8 +2191,6 @@ int dlm_drop_lockres_ref(struct dlm_ctxt *dlm, struct dlm_lock_resource *res) | |||
| 2187 | namelen = res->lockname.len; | 2191 | namelen = res->lockname.len; |
| 2188 | BUG_ON(namelen > O2NM_MAX_NAME_LEN); | 2192 | BUG_ON(namelen > O2NM_MAX_NAME_LEN); |
| 2189 | 2193 | ||
| 2190 | mlog(0, "%s:%.*s: sending deref to %d\n", | ||
| 2191 | dlm->name, namelen, lockname, res->owner); | ||
| 2192 | memset(&deref, 0, sizeof(deref)); | 2194 | memset(&deref, 0, sizeof(deref)); |
| 2193 | deref.node_idx = dlm->node_num; | 2195 | deref.node_idx = dlm->node_num; |
| 2194 | deref.namelen = namelen; | 2196 | deref.namelen = namelen; |
| @@ -2197,14 +2199,12 @@ int dlm_drop_lockres_ref(struct dlm_ctxt *dlm, struct dlm_lock_resource *res) | |||
| 2197 | ret = o2net_send_message(DLM_DEREF_LOCKRES_MSG, dlm->key, | 2199 | ret = o2net_send_message(DLM_DEREF_LOCKRES_MSG, dlm->key, |
| 2198 | &deref, sizeof(deref), res->owner, &r); | 2200 | &deref, sizeof(deref), res->owner, &r); |
| 2199 | if (ret < 0) | 2201 | if (ret < 0) |
| 2200 | mlog(ML_ERROR, "Error %d when sending message %u (key 0x%x) to " | 2202 | mlog(ML_ERROR, "%s: res %.*s, error %d send DEREF to node %u\n", |
| 2201 | "node %u\n", ret, DLM_DEREF_LOCKRES_MSG, dlm->key, | 2203 | dlm->name, namelen, lockname, ret, res->owner); |
| 2202 | res->owner); | ||
| 2203 | else if (r < 0) { | 2204 | else if (r < 0) { |
| 2204 | /* BAD. other node says I did not have a ref. */ | 2205 | /* BAD. other node says I did not have a ref. */ |
| 2205 | mlog(ML_ERROR,"while dropping ref on %s:%.*s " | 2206 | mlog(ML_ERROR, "%s: res %.*s, DEREF to node %u got %d\n", |
| 2206 | "(master=%u) got %d.\n", dlm->name, namelen, | 2207 | dlm->name, namelen, lockname, res->owner, r); |
| 2207 | lockname, res->owner, r); | ||
| 2208 | dlm_print_one_lock_resource(res); | 2208 | dlm_print_one_lock_resource(res); |
| 2209 | BUG(); | 2209 | BUG(); |
| 2210 | } | 2210 | } |
| @@ -2260,7 +2260,7 @@ int dlm_deref_lockres_handler(struct o2net_msg *msg, u32 len, void *data, | |||
| 2260 | else { | 2260 | else { |
| 2261 | BUG_ON(res->state & DLM_LOCK_RES_DROPPING_REF); | 2261 | BUG_ON(res->state & DLM_LOCK_RES_DROPPING_REF); |
| 2262 | if (test_bit(node, res->refmap)) { | 2262 | if (test_bit(node, res->refmap)) { |
| 2263 | dlm_lockres_clear_refmap_bit(node, res); | 2263 | dlm_lockres_clear_refmap_bit(dlm, res, node); |
| 2264 | cleared = 1; | 2264 | cleared = 1; |
| 2265 | } | 2265 | } |
| 2266 | } | 2266 | } |
| @@ -2320,7 +2320,7 @@ static void dlm_deref_lockres_worker(struct dlm_work_item *item, void *data) | |||
| 2320 | BUG_ON(res->state & DLM_LOCK_RES_DROPPING_REF); | 2320 | BUG_ON(res->state & DLM_LOCK_RES_DROPPING_REF); |
| 2321 | if (test_bit(node, res->refmap)) { | 2321 | if (test_bit(node, res->refmap)) { |
| 2322 | __dlm_wait_on_lockres_flags(res, DLM_LOCK_RES_SETREF_INPROG); | 2322 | __dlm_wait_on_lockres_flags(res, DLM_LOCK_RES_SETREF_INPROG); |
| 2323 | dlm_lockres_clear_refmap_bit(node, res); | 2323 | dlm_lockres_clear_refmap_bit(dlm, res, node); |
| 2324 | cleared = 1; | 2324 | cleared = 1; |
| 2325 | } | 2325 | } |
| 2326 | spin_unlock(&res->spinlock); | 2326 | spin_unlock(&res->spinlock); |
| @@ -2802,7 +2802,8 @@ static void dlm_remove_nonlocal_locks(struct dlm_ctxt *dlm, | |||
| 2802 | BUG_ON(!list_empty(&lock->bast_list)); | 2802 | BUG_ON(!list_empty(&lock->bast_list)); |
| 2803 | BUG_ON(lock->ast_pending); | 2803 | BUG_ON(lock->ast_pending); |
| 2804 | BUG_ON(lock->bast_pending); | 2804 | BUG_ON(lock->bast_pending); |
| 2805 | dlm_lockres_clear_refmap_bit(lock->ml.node, res); | 2805 | dlm_lockres_clear_refmap_bit(dlm, res, |
| 2806 | lock->ml.node); | ||
| 2806 | list_del_init(&lock->list); | 2807 | list_del_init(&lock->list); |
| 2807 | dlm_lock_put(lock); | 2808 | dlm_lock_put(lock); |
| 2808 | /* In a normal unlock, we would have added a | 2809 | /* In a normal unlock, we would have added a |
| @@ -2823,7 +2824,7 @@ static void dlm_remove_nonlocal_locks(struct dlm_ctxt *dlm, | |||
| 2823 | mlog(0, "%s:%.*s: node %u had a ref to this " | 2824 | mlog(0, "%s:%.*s: node %u had a ref to this " |
| 2824 | "migrating lockres, clearing\n", dlm->name, | 2825 | "migrating lockres, clearing\n", dlm->name, |
| 2825 | res->lockname.len, res->lockname.name, bit); | 2826 | res->lockname.len, res->lockname.name, bit); |
| 2826 | dlm_lockres_clear_refmap_bit(bit, res); | 2827 | dlm_lockres_clear_refmap_bit(dlm, res, bit); |
| 2827 | } | 2828 | } |
| 2828 | bit++; | 2829 | bit++; |
| 2829 | } | 2830 | } |
| @@ -2916,9 +2917,9 @@ static int dlm_do_migrate_request(struct dlm_ctxt *dlm, | |||
| 2916 | &migrate, sizeof(migrate), nodenum, | 2917 | &migrate, sizeof(migrate), nodenum, |
| 2917 | &status); | 2918 | &status); |
| 2918 | if (ret < 0) { | 2919 | if (ret < 0) { |
| 2919 | mlog(ML_ERROR, "Error %d when sending message %u (key " | 2920 | mlog(ML_ERROR, "%s: res %.*s, Error %d send " |
| 2920 | "0x%x) to node %u\n", ret, DLM_MIGRATE_REQUEST_MSG, | 2921 | "MIGRATE_REQUEST to node %u\n", dlm->name, |
| 2921 | dlm->key, nodenum); | 2922 | migrate.namelen, migrate.name, ret, nodenum); |
| 2922 | if (!dlm_is_host_down(ret)) { | 2923 | if (!dlm_is_host_down(ret)) { |
| 2923 | mlog(ML_ERROR, "unhandled error=%d!\n", ret); | 2924 | mlog(ML_ERROR, "unhandled error=%d!\n", ret); |
| 2924 | BUG(); | 2925 | BUG(); |
| @@ -2937,7 +2938,7 @@ static int dlm_do_migrate_request(struct dlm_ctxt *dlm, | |||
| 2937 | dlm->name, res->lockname.len, res->lockname.name, | 2938 | dlm->name, res->lockname.len, res->lockname.name, |
| 2938 | nodenum); | 2939 | nodenum); |
| 2939 | spin_lock(&res->spinlock); | 2940 | spin_lock(&res->spinlock); |
| 2940 | dlm_lockres_set_refmap_bit(nodenum, res); | 2941 | dlm_lockres_set_refmap_bit(dlm, res, nodenum); |
| 2941 | spin_unlock(&res->spinlock); | 2942 | spin_unlock(&res->spinlock); |
| 2942 | } | 2943 | } |
| 2943 | } | 2944 | } |
| @@ -3271,7 +3272,7 @@ int dlm_finish_migration(struct dlm_ctxt *dlm, struct dlm_lock_resource *res, | |||
| 3271 | * mastery reference here since old_master will briefly have | 3272 | * mastery reference here since old_master will briefly have |
| 3272 | * a reference after the migration completes */ | 3273 | * a reference after the migration completes */ |
| 3273 | spin_lock(&res->spinlock); | 3274 | spin_lock(&res->spinlock); |
| 3274 | dlm_lockres_set_refmap_bit(old_master, res); | 3275 | dlm_lockres_set_refmap_bit(dlm, res, old_master); |
| 3275 | spin_unlock(&res->spinlock); | 3276 | spin_unlock(&res->spinlock); |
| 3276 | 3277 | ||
| 3277 | mlog(0, "now time to do a migrate request to other nodes\n"); | 3278 | mlog(0, "now time to do a migrate request to other nodes\n"); |
diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index 7efab6d28a21..01ebfd0bdad7 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c | |||
| @@ -362,40 +362,38 @@ static int dlm_is_node_recovered(struct dlm_ctxt *dlm, u8 node) | |||
| 362 | } | 362 | } |
| 363 | 363 | ||
| 364 | 364 | ||
| 365 | int dlm_wait_for_node_death(struct dlm_ctxt *dlm, u8 node, int timeout) | 365 | void dlm_wait_for_node_death(struct dlm_ctxt *dlm, u8 node, int timeout) |
| 366 | { | 366 | { |
| 367 | if (timeout) { | 367 | if (dlm_is_node_dead(dlm, node)) |
| 368 | mlog(ML_NOTICE, "%s: waiting %dms for notification of " | 368 | return; |
| 369 | "death of node %u\n", dlm->name, timeout, node); | 369 | |
| 370 | printk(KERN_NOTICE "o2dlm: Waiting on the death of node %u in " | ||
| 371 | "domain %s\n", node, dlm->name); | ||
| 372 | |||
| 373 | if (timeout) | ||
| 370 | wait_event_timeout(dlm->dlm_reco_thread_wq, | 374 | wait_event_timeout(dlm->dlm_reco_thread_wq, |
| 371 | dlm_is_node_dead(dlm, node), | 375 | dlm_is_node_dead(dlm, node), |
| 372 | msecs_to_jiffies(timeout)); | 376 | msecs_to_jiffies(timeout)); |
| 373 | } else { | 377 | else |
| 374 | mlog(ML_NOTICE, "%s: waiting indefinitely for notification " | ||
| 375 | "of death of node %u\n", dlm->name, node); | ||
| 376 | wait_event(dlm->dlm_reco_thread_wq, | 378 | wait_event(dlm->dlm_reco_thread_wq, |
| 377 | dlm_is_node_dead(dlm, node)); | 379 | dlm_is_node_dead(dlm, node)); |
| 378 | } | ||
| 379 | /* for now, return 0 */ | ||
| 380 | return 0; | ||
| 381 | } | 380 | } |
| 382 | 381 | ||
| 383 | int dlm_wait_for_node_recovery(struct dlm_ctxt *dlm, u8 node, int timeout) | 382 | void dlm_wait_for_node_recovery(struct dlm_ctxt *dlm, u8 node, int timeout) |
| 384 | { | 383 | { |
| 385 | if (timeout) { | 384 | if (dlm_is_node_recovered(dlm, node)) |
| 386 | mlog(0, "%s: waiting %dms for notification of " | 385 | return; |
| 387 | "recovery of node %u\n", dlm->name, timeout, node); | 386 | |
| 387 | printk(KERN_NOTICE "o2dlm: Waiting on the recovery of node %u in " | ||
| 388 | "domain %s\n", node, dlm->name); | ||
| 389 | |||
| 390 | if (timeout) | ||
| 388 | wait_event_timeout(dlm->dlm_reco_thread_wq, | 391 | wait_event_timeout(dlm->dlm_reco_thread_wq, |
| 389 | dlm_is_node_recovered(dlm, node), | 392 | dlm_is_node_recovered(dlm, node), |
| 390 | msecs_to_jiffies(timeout)); | 393 | msecs_to_jiffies(timeout)); |
| 391 | } else { | 394 | else |
| 392 | mlog(0, "%s: waiting indefinitely for notification " | ||
| 393 | "of recovery of node %u\n", dlm->name, node); | ||
| 394 | wait_event(dlm->dlm_reco_thread_wq, | 395 | wait_event(dlm->dlm_reco_thread_wq, |
| 395 | dlm_is_node_recovered(dlm, node)); | 396 | dlm_is_node_recovered(dlm, node)); |
| 396 | } | ||
| 397 | /* for now, return 0 */ | ||
| 398 | return 0; | ||
| 399 | } | 397 | } |
| 400 | 398 | ||
| 401 | /* callers of the top-level api calls (dlmlock/dlmunlock) should | 399 | /* callers of the top-level api calls (dlmlock/dlmunlock) should |
| @@ -430,6 +428,8 @@ static void dlm_begin_recovery(struct dlm_ctxt *dlm) | |||
| 430 | { | 428 | { |
| 431 | spin_lock(&dlm->spinlock); | 429 | spin_lock(&dlm->spinlock); |
| 432 | BUG_ON(dlm->reco.state & DLM_RECO_STATE_ACTIVE); | 430 | BUG_ON(dlm->reco.state & DLM_RECO_STATE_ACTIVE); |
| 431 | printk(KERN_NOTICE "o2dlm: Begin recovery on domain %s for node %u\n", | ||
| 432 | dlm->name, dlm->reco.dead_node); | ||
| 433 | dlm->reco.state |= DLM_RECO_STATE_ACTIVE; | 433 | dlm->reco.state |= DLM_RECO_STATE_ACTIVE; |
| 434 | spin_unlock(&dlm->spinlock); | 434 | spin_unlock(&dlm->spinlock); |
| 435 | } | 435 | } |
| @@ -440,9 +440,18 @@ static void dlm_end_recovery(struct dlm_ctxt *dlm) | |||
| 440 | BUG_ON(!(dlm->reco.state & DLM_RECO_STATE_ACTIVE)); | 440 | BUG_ON(!(dlm->reco.state & DLM_RECO_STATE_ACTIVE)); |
| 441 | dlm->reco.state &= ~DLM_RECO_STATE_ACTIVE; | 441 | dlm->reco.state &= ~DLM_RECO_STATE_ACTIVE; |
| 442 | spin_unlock(&dlm->spinlock); | 442 | spin_unlock(&dlm->spinlock); |
| 443 | printk(KERN_NOTICE "o2dlm: End recovery on domain %s\n", dlm->name); | ||
| 443 | wake_up(&dlm->reco.event); | 444 | wake_up(&dlm->reco.event); |
| 444 | } | 445 | } |
| 445 | 446 | ||
| 447 | static void dlm_print_recovery_master(struct dlm_ctxt *dlm) | ||
| 448 | { | ||
| 449 | printk(KERN_NOTICE "o2dlm: Node %u (%s) is the Recovery Master for the " | ||
| 450 | "dead node %u in domain %s\n", dlm->reco.new_master, | ||
| 451 | (dlm->node_num == dlm->reco.new_master ? "me" : "he"), | ||
| 452 | dlm->reco.dead_node, dlm->name); | ||
| 453 | } | ||
| 454 | |||
| 446 | static int dlm_do_recovery(struct dlm_ctxt *dlm) | 455 | static int dlm_do_recovery(struct dlm_ctxt *dlm) |
| 447 | { | 456 | { |
| 448 | int status = 0; | 457 | int status = 0; |
| @@ -505,9 +514,8 @@ static int dlm_do_recovery(struct dlm_ctxt *dlm) | |||
| 505 | } | 514 | } |
| 506 | mlog(0, "another node will master this recovery session.\n"); | 515 | mlog(0, "another node will master this recovery session.\n"); |
| 507 | } | 516 | } |
| 508 | mlog(0, "dlm=%s (%d), new_master=%u, this node=%u, dead_node=%u\n", | 517 | |
| 509 | dlm->name, task_pid_nr(dlm->dlm_reco_thread_task), dlm->reco.new_master, | 518 | dlm_print_recovery_master(dlm); |
| 510 | dlm->node_num, dlm->reco.dead_node); | ||
| 511 | 519 | ||
| 512 | /* it is safe to start everything back up here | 520 | /* it is safe to start everything back up here |
| 513 | * because all of the dead node's lock resources | 521 | * because all of the dead node's lock resources |
| @@ -518,15 +526,13 @@ static int dlm_do_recovery(struct dlm_ctxt *dlm) | |||
| 518 | return 0; | 526 | return 0; |
| 519 | 527 | ||
| 520 | master_here: | 528 | master_here: |
| 521 | mlog(ML_NOTICE, "(%d) Node %u is the Recovery Master for the Dead Node " | 529 | dlm_print_recovery_master(dlm); |
| 522 | "%u for Domain %s\n", task_pid_nr(dlm->dlm_reco_thread_task), | ||
| 523 | dlm->node_num, dlm->reco.dead_node, dlm->name); | ||
| 524 | 530 | ||
| 525 | status = dlm_remaster_locks(dlm, dlm->reco.dead_node); | 531 | status = dlm_remaster_locks(dlm, dlm->reco.dead_node); |
| 526 | if (status < 0) { | 532 | if (status < 0) { |
| 527 | /* we should never hit this anymore */ | 533 | /* we should never hit this anymore */ |
| 528 | mlog(ML_ERROR, "error %d remastering locks for node %u, " | 534 | mlog(ML_ERROR, "%s: Error %d remastering locks for node %u, " |
| 529 | "retrying.\n", status, dlm->reco.dead_node); | 535 | "retrying.\n", dlm->name, status, dlm->reco.dead_node); |
| 530 | /* yield a bit to allow any final network messages | 536 | /* yield a bit to allow any final network messages |
| 531 | * to get handled on remaining nodes */ | 537 | * to get handled on remaining nodes */ |
| 532 | msleep(100); | 538 | msleep(100); |
| @@ -567,7 +573,7 @@ static int dlm_remaster_locks(struct dlm_ctxt *dlm, u8 dead_node) | |||
| 567 | BUG_ON(ndata->state != DLM_RECO_NODE_DATA_INIT); | 573 | BUG_ON(ndata->state != DLM_RECO_NODE_DATA_INIT); |
| 568 | ndata->state = DLM_RECO_NODE_DATA_REQUESTING; | 574 | ndata->state = DLM_RECO_NODE_DATA_REQUESTING; |
| 569 | 575 | ||
| 570 | mlog(0, "requesting lock info from node %u\n", | 576 | mlog(0, "%s: Requesting lock info from node %u\n", dlm->name, |
| 571 | ndata->node_num); | 577 | ndata->node_num); |
| 572 | 578 | ||
| 573 | if (ndata->node_num == dlm->node_num) { | 579 | if (ndata->node_num == dlm->node_num) { |
| @@ -640,7 +646,7 @@ static int dlm_remaster_locks(struct dlm_ctxt *dlm, u8 dead_node) | |||
| 640 | spin_unlock(&dlm_reco_state_lock); | 646 | spin_unlock(&dlm_reco_state_lock); |
| 641 | } | 647 | } |
| 642 | 648 | ||
| 643 | mlog(0, "done requesting all lock info\n"); | 649 | mlog(0, "%s: Done requesting all lock info\n", dlm->name); |
| 644 | 650 | ||
| 645 | /* nodes should be sending reco data now | 651 | /* nodes should be sending reco data now |
| 646 | * just need to wait */ | 652 | * just need to wait */ |
| @@ -802,10 +808,9 @@ static int dlm_request_all_locks(struct dlm_ctxt *dlm, u8 request_from, | |||
| 802 | 808 | ||
| 803 | /* negative status is handled by caller */ | 809 | /* negative status is handled by caller */ |
| 804 | if (ret < 0) | 810 | if (ret < 0) |
| 805 | mlog(ML_ERROR, "Error %d when sending message %u (key " | 811 | mlog(ML_ERROR, "%s: Error %d send LOCK_REQUEST to node %u " |
| 806 | "0x%x) to node %u\n", ret, DLM_LOCK_REQUEST_MSG, | 812 | "to recover dead node %u\n", dlm->name, ret, |
| 807 | dlm->key, request_from); | 813 | request_from, dead_node); |
| 808 | |||
| 809 | // return from here, then | 814 | // return from here, then |
| 810 | // sleep until all received or error | 815 | // sleep until all received or error |
| 811 | return ret; | 816 | return ret; |
| @@ -956,9 +961,9 @@ static int dlm_send_all_done_msg(struct dlm_ctxt *dlm, u8 dead_node, u8 send_to) | |||
| 956 | ret = o2net_send_message(DLM_RECO_DATA_DONE_MSG, dlm->key, &done_msg, | 961 | ret = o2net_send_message(DLM_RECO_DATA_DONE_MSG, dlm->key, &done_msg, |
| 957 | sizeof(done_msg), send_to, &tmpret); | 962 | sizeof(done_msg), send_to, &tmpret); |
| 958 | if (ret < 0) { | 963 | if (ret < 0) { |
| 959 | mlog(ML_ERROR, "Error %d when sending message %u (key " | 964 | mlog(ML_ERROR, "%s: Error %d send RECO_DATA_DONE to node %u " |
| 960 | "0x%x) to node %u\n", ret, DLM_RECO_DATA_DONE_MSG, | 965 | "to recover dead node %u\n", dlm->name, ret, send_to, |
| 961 | dlm->key, send_to); | 966 | dead_node); |
| 962 | if (!dlm_is_host_down(ret)) { | 967 | if (!dlm_is_host_down(ret)) { |
| 963 | BUG(); | 968 | BUG(); |
| 964 | } | 969 | } |
| @@ -1127,9 +1132,11 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm, | |||
| 1127 | if (ret < 0) { | 1132 | if (ret < 0) { |
| 1128 | /* XXX: negative status is not handled. | 1133 | /* XXX: negative status is not handled. |
| 1129 | * this will end up killing this node. */ | 1134 | * this will end up killing this node. */ |
| 1130 | mlog(ML_ERROR, "Error %d when sending message %u (key " | 1135 | mlog(ML_ERROR, "%s: res %.*s, Error %d send MIG_LOCKRES to " |
| 1131 | "0x%x) to node %u\n", ret, DLM_MIG_LOCKRES_MSG, | 1136 | "node %u (%s)\n", dlm->name, mres->lockname_len, |
| 1132 | dlm->key, send_to); | 1137 | mres->lockname, ret, send_to, |
| 1138 | (orig_flags & DLM_MRES_MIGRATION ? | ||
| 1139 | "migration" : "recovery")); | ||
| 1133 | } else { | 1140 | } else { |
| 1134 | /* might get an -ENOMEM back here */ | 1141 | /* might get an -ENOMEM back here */ |
| 1135 | ret = status; | 1142 | ret = status; |
| @@ -1767,7 +1774,7 @@ static int dlm_process_recovery_data(struct dlm_ctxt *dlm, | |||
| 1767 | dlm->name, mres->lockname_len, mres->lockname, | 1774 | dlm->name, mres->lockname_len, mres->lockname, |
| 1768 | from); | 1775 | from); |
| 1769 | spin_lock(&res->spinlock); | 1776 | spin_lock(&res->spinlock); |
| 1770 | dlm_lockres_set_refmap_bit(from, res); | 1777 | dlm_lockres_set_refmap_bit(dlm, res, from); |
| 1771 | spin_unlock(&res->spinlock); | 1778 | spin_unlock(&res->spinlock); |
| 1772 | added++; | 1779 | added++; |
| 1773 | break; | 1780 | break; |
| @@ -1965,7 +1972,7 @@ skip_lvb: | |||
| 1965 | mlog(0, "%s:%.*s: added lock for node %u, " | 1972 | mlog(0, "%s:%.*s: added lock for node %u, " |
| 1966 | "setting refmap bit\n", dlm->name, | 1973 | "setting refmap bit\n", dlm->name, |
| 1967 | res->lockname.len, res->lockname.name, ml->node); | 1974 | res->lockname.len, res->lockname.name, ml->node); |
| 1968 | dlm_lockres_set_refmap_bit(ml->node, res); | 1975 | dlm_lockres_set_refmap_bit(dlm, res, ml->node); |
| 1969 | added++; | 1976 | added++; |
| 1970 | } | 1977 | } |
| 1971 | spin_unlock(&res->spinlock); | 1978 | spin_unlock(&res->spinlock); |
| @@ -2084,6 +2091,9 @@ static void dlm_finish_local_lockres_recovery(struct dlm_ctxt *dlm, | |||
| 2084 | 2091 | ||
| 2085 | list_for_each_entry_safe(res, next, &dlm->reco.resources, recovering) { | 2092 | list_for_each_entry_safe(res, next, &dlm->reco.resources, recovering) { |
| 2086 | if (res->owner == dead_node) { | 2093 | if (res->owner == dead_node) { |
| 2094 | mlog(0, "%s: res %.*s, Changing owner from %u to %u\n", | ||
| 2095 | dlm->name, res->lockname.len, res->lockname.name, | ||
| 2096 | res->owner, new_master); | ||
| 2087 | list_del_init(&res->recovering); | 2097 | list_del_init(&res->recovering); |
| 2088 | spin_lock(&res->spinlock); | 2098 | spin_lock(&res->spinlock); |
| 2089 | /* new_master has our reference from | 2099 | /* new_master has our reference from |
| @@ -2105,40 +2115,30 @@ static void dlm_finish_local_lockres_recovery(struct dlm_ctxt *dlm, | |||
| 2105 | for (i = 0; i < DLM_HASH_BUCKETS; i++) { | 2115 | for (i = 0; i < DLM_HASH_BUCKETS; i++) { |
| 2106 | bucket = dlm_lockres_hash(dlm, i); | 2116 | bucket = dlm_lockres_hash(dlm, i); |
| 2107 | hlist_for_each_entry(res, hash_iter, bucket, hash_node) { | 2117 | hlist_for_each_entry(res, hash_iter, bucket, hash_node) { |
| 2108 | if (res->state & DLM_LOCK_RES_RECOVERING) { | 2118 | if (!(res->state & DLM_LOCK_RES_RECOVERING)) |
| 2109 | if (res->owner == dead_node) { | 2119 | continue; |
| 2110 | mlog(0, "(this=%u) res %.*s owner=%u " | ||
| 2111 | "was not on recovering list, but " | ||
| 2112 | "clearing state anyway\n", | ||
| 2113 | dlm->node_num, res->lockname.len, | ||
| 2114 | res->lockname.name, new_master); | ||
| 2115 | } else if (res->owner == dlm->node_num) { | ||
| 2116 | mlog(0, "(this=%u) res %.*s owner=%u " | ||
| 2117 | "was not on recovering list, " | ||
| 2118 | "owner is THIS node, clearing\n", | ||
| 2119 | dlm->node_num, res->lockname.len, | ||
| 2120 | res->lockname.name, new_master); | ||
| 2121 | } else | ||
| 2122 | continue; | ||
| 2123 | 2120 | ||
| 2124 | if (!list_empty(&res->recovering)) { | 2121 | if (res->owner != dead_node && |
| 2125 | mlog(0, "%s:%.*s: lockres was " | 2122 | res->owner != dlm->node_num) |
| 2126 | "marked RECOVERING, owner=%u\n", | 2123 | continue; |
| 2127 | dlm->name, res->lockname.len, | 2124 | |
| 2128 | res->lockname.name, res->owner); | 2125 | if (!list_empty(&res->recovering)) { |
| 2129 | list_del_init(&res->recovering); | 2126 | list_del_init(&res->recovering); |
| 2130 | dlm_lockres_put(res); | 2127 | dlm_lockres_put(res); |
| 2131 | } | ||
| 2132 | spin_lock(&res->spinlock); | ||
| 2133 | /* new_master has our reference from | ||
| 2134 | * the lock state sent during recovery */ | ||
| 2135 | dlm_change_lockres_owner(dlm, res, new_master); | ||
| 2136 | res->state &= ~DLM_LOCK_RES_RECOVERING; | ||
| 2137 | if (__dlm_lockres_has_locks(res)) | ||
| 2138 | __dlm_dirty_lockres(dlm, res); | ||
| 2139 | spin_unlock(&res->spinlock); | ||
| 2140 | wake_up(&res->wq); | ||
| 2141 | } | 2128 | } |
| 2129 | |||
| 2130 | /* new_master has our reference from | ||
| 2131 | * the lock state sent during recovery */ | ||
| 2132 | mlog(0, "%s: res %.*s, Changing owner from %u to %u\n", | ||
| 2133 | dlm->name, res->lockname.len, res->lockname.name, | ||
| 2134 | res->owner, new_master); | ||
| 2135 | spin_lock(&res->spinlock); | ||
| 2136 | dlm_change_lockres_owner(dlm, res, new_master); | ||
| 2137 | res->state &= ~DLM_LOCK_RES_RECOVERING; | ||
| 2138 | if (__dlm_lockres_has_locks(res)) | ||
| 2139 | __dlm_dirty_lockres(dlm, res); | ||
| 2140 | spin_unlock(&res->spinlock); | ||
| 2141 | wake_up(&res->wq); | ||
| 2142 | } | 2142 | } |
| 2143 | } | 2143 | } |
| 2144 | } | 2144 | } |
| @@ -2252,12 +2252,12 @@ static void dlm_free_dead_locks(struct dlm_ctxt *dlm, | |||
| 2252 | res->lockname.len, res->lockname.name, freed, dead_node); | 2252 | res->lockname.len, res->lockname.name, freed, dead_node); |
| 2253 | __dlm_print_one_lock_resource(res); | 2253 | __dlm_print_one_lock_resource(res); |
| 2254 | } | 2254 | } |
| 2255 | dlm_lockres_clear_refmap_bit(dead_node, res); | 2255 | dlm_lockres_clear_refmap_bit(dlm, res, dead_node); |
| 2256 | } else if (test_bit(dead_node, res->refmap)) { | 2256 | } else if (test_bit(dead_node, res->refmap)) { |
| 2257 | mlog(0, "%s:%.*s: dead node %u had a ref, but had " | 2257 | mlog(0, "%s:%.*s: dead node %u had a ref, but had " |
| 2258 | "no locks and had not purged before dying\n", dlm->name, | 2258 | "no locks and had not purged before dying\n", dlm->name, |
| 2259 | res->lockname.len, res->lockname.name, dead_node); | 2259 | res->lockname.len, res->lockname.name, dead_node); |
| 2260 | dlm_lockres_clear_refmap_bit(dead_node, res); | 2260 | dlm_lockres_clear_refmap_bit(dlm, res, dead_node); |
| 2261 | } | 2261 | } |
| 2262 | 2262 | ||
| 2263 | /* do not kick thread yet */ | 2263 | /* do not kick thread yet */ |
| @@ -2324,9 +2324,9 @@ static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node) | |||
| 2324 | dlm_revalidate_lvb(dlm, res, dead_node); | 2324 | dlm_revalidate_lvb(dlm, res, dead_node); |
| 2325 | if (res->owner == dead_node) { | 2325 | if (res->owner == dead_node) { |
| 2326 | if (res->state & DLM_LOCK_RES_DROPPING_REF) { | 2326 | if (res->state & DLM_LOCK_RES_DROPPING_REF) { |
| 2327 | mlog(ML_NOTICE, "Ignore %.*s for " | 2327 | mlog(ML_NOTICE, "%s: res %.*s, Skip " |
| 2328 | "recovery as it is being freed\n", | 2328 | "recovery as it is being freed\n", |
| 2329 | res->lockname.len, | 2329 | dlm->name, res->lockname.len, |
| 2330 | res->lockname.name); | 2330 | res->lockname.name); |
| 2331 | } else | 2331 | } else |
| 2332 | dlm_move_lockres_to_recovery_list(dlm, | 2332 | dlm_move_lockres_to_recovery_list(dlm, |
diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c index 1d6d1d22c471..e73c833fc2a1 100644 --- a/fs/ocfs2/dlm/dlmthread.c +++ b/fs/ocfs2/dlm/dlmthread.c | |||
| @@ -94,24 +94,26 @@ int __dlm_lockres_unused(struct dlm_lock_resource *res) | |||
| 94 | { | 94 | { |
| 95 | int bit; | 95 | int bit; |
| 96 | 96 | ||
| 97 | assert_spin_locked(&res->spinlock); | ||
| 98 | |||
| 97 | if (__dlm_lockres_has_locks(res)) | 99 | if (__dlm_lockres_has_locks(res)) |
| 98 | return 0; | 100 | return 0; |
| 99 | 101 | ||
| 102 | /* Locks are in the process of being created */ | ||
| 103 | if (res->inflight_locks) | ||
| 104 | return 0; | ||
| 105 | |||
| 100 | if (!list_empty(&res->dirty) || res->state & DLM_LOCK_RES_DIRTY) | 106 | if (!list_empty(&res->dirty) || res->state & DLM_LOCK_RES_DIRTY) |
| 101 | return 0; | 107 | return 0; |
| 102 | 108 | ||
| 103 | if (res->state & DLM_LOCK_RES_RECOVERING) | 109 | if (res->state & DLM_LOCK_RES_RECOVERING) |
| 104 | return 0; | 110 | return 0; |
| 105 | 111 | ||
| 112 | /* Another node has this resource with this node as the master */ | ||
| 106 | bit = find_next_bit(res->refmap, O2NM_MAX_NODES, 0); | 113 | bit = find_next_bit(res->refmap, O2NM_MAX_NODES, 0); |
| 107 | if (bit < O2NM_MAX_NODES) | 114 | if (bit < O2NM_MAX_NODES) |
| 108 | return 0; | 115 | return 0; |
| 109 | 116 | ||
| 110 | /* | ||
| 111 | * since the bit for dlm->node_num is not set, inflight_locks better | ||
| 112 | * be zero | ||
| 113 | */ | ||
| 114 | BUG_ON(res->inflight_locks != 0); | ||
| 115 | return 1; | 117 | return 1; |
| 116 | } | 118 | } |
| 117 | 119 | ||
| @@ -185,8 +187,6 @@ static void dlm_purge_lockres(struct dlm_ctxt *dlm, | |||
| 185 | /* clear our bit from the master's refmap, ignore errors */ | 187 | /* clear our bit from the master's refmap, ignore errors */ |
| 186 | ret = dlm_drop_lockres_ref(dlm, res); | 188 | ret = dlm_drop_lockres_ref(dlm, res); |
| 187 | if (ret < 0) { | 189 | if (ret < 0) { |
| 188 | mlog(ML_ERROR, "%s: deref %.*s failed %d\n", dlm->name, | ||
| 189 | res->lockname.len, res->lockname.name, ret); | ||
| 190 | if (!dlm_is_host_down(ret)) | 190 | if (!dlm_is_host_down(ret)) |
| 191 | BUG(); | 191 | BUG(); |
| 192 | } | 192 | } |
| @@ -209,7 +209,7 @@ static void dlm_purge_lockres(struct dlm_ctxt *dlm, | |||
| 209 | BUG(); | 209 | BUG(); |
| 210 | } | 210 | } |
| 211 | 211 | ||
| 212 | __dlm_unhash_lockres(res); | 212 | __dlm_unhash_lockres(dlm, res); |
| 213 | 213 | ||
| 214 | /* lockres is not in the hash now. drop the flag and wake up | 214 | /* lockres is not in the hash now. drop the flag and wake up |
| 215 | * any processes waiting in dlm_get_lock_resource. */ | 215 | * any processes waiting in dlm_get_lock_resource. */ |
diff --git a/fs/ocfs2/dlmglue.c b/fs/ocfs2/dlmglue.c index e1ed5e502ff2..81a4cd22f80b 100644 --- a/fs/ocfs2/dlmglue.c +++ b/fs/ocfs2/dlmglue.c | |||
| @@ -1692,7 +1692,7 @@ int ocfs2_open_lock(struct inode *inode) | |||
| 1692 | mlog(0, "inode %llu take PRMODE open lock\n", | 1692 | mlog(0, "inode %llu take PRMODE open lock\n", |
| 1693 | (unsigned long long)OCFS2_I(inode)->ip_blkno); | 1693 | (unsigned long long)OCFS2_I(inode)->ip_blkno); |
| 1694 | 1694 | ||
| 1695 | if (ocfs2_mount_local(osb)) | 1695 | if (ocfs2_is_hard_readonly(osb) || ocfs2_mount_local(osb)) |
| 1696 | goto out; | 1696 | goto out; |
| 1697 | 1697 | ||
| 1698 | lockres = &OCFS2_I(inode)->ip_open_lockres; | 1698 | lockres = &OCFS2_I(inode)->ip_open_lockres; |
| @@ -1718,6 +1718,12 @@ int ocfs2_try_open_lock(struct inode *inode, int write) | |||
| 1718 | (unsigned long long)OCFS2_I(inode)->ip_blkno, | 1718 | (unsigned long long)OCFS2_I(inode)->ip_blkno, |
| 1719 | write ? "EXMODE" : "PRMODE"); | 1719 | write ? "EXMODE" : "PRMODE"); |
| 1720 | 1720 | ||
| 1721 | if (ocfs2_is_hard_readonly(osb)) { | ||
| 1722 | if (write) | ||
| 1723 | status = -EROFS; | ||
| 1724 | goto out; | ||
| 1725 | } | ||
| 1726 | |||
| 1721 | if (ocfs2_mount_local(osb)) | 1727 | if (ocfs2_mount_local(osb)) |
| 1722 | goto out; | 1728 | goto out; |
| 1723 | 1729 | ||
| @@ -2298,7 +2304,7 @@ int ocfs2_inode_lock_full_nested(struct inode *inode, | |||
| 2298 | if (ocfs2_is_hard_readonly(osb)) { | 2304 | if (ocfs2_is_hard_readonly(osb)) { |
| 2299 | if (ex) | 2305 | if (ex) |
| 2300 | status = -EROFS; | 2306 | status = -EROFS; |
| 2301 | goto bail; | 2307 | goto getbh; |
| 2302 | } | 2308 | } |
| 2303 | 2309 | ||
| 2304 | if (ocfs2_mount_local(osb)) | 2310 | if (ocfs2_mount_local(osb)) |
| @@ -2356,7 +2362,7 @@ local: | |||
| 2356 | mlog_errno(status); | 2362 | mlog_errno(status); |
| 2357 | goto bail; | 2363 | goto bail; |
| 2358 | } | 2364 | } |
| 2359 | 2365 | getbh: | |
| 2360 | if (ret_bh) { | 2366 | if (ret_bh) { |
| 2361 | status = ocfs2_assign_bh(inode, ret_bh, local_bh); | 2367 | status = ocfs2_assign_bh(inode, ret_bh, local_bh); |
| 2362 | if (status < 0) { | 2368 | if (status < 0) { |
| @@ -2628,8 +2634,11 @@ int ocfs2_dentry_lock(struct dentry *dentry, int ex) | |||
| 2628 | 2634 | ||
| 2629 | BUG_ON(!dl); | 2635 | BUG_ON(!dl); |
| 2630 | 2636 | ||
| 2631 | if (ocfs2_is_hard_readonly(osb)) | 2637 | if (ocfs2_is_hard_readonly(osb)) { |
| 2632 | return -EROFS; | 2638 | if (ex) |
| 2639 | return -EROFS; | ||
| 2640 | return 0; | ||
| 2641 | } | ||
| 2633 | 2642 | ||
| 2634 | if (ocfs2_mount_local(osb)) | 2643 | if (ocfs2_mount_local(osb)) |
| 2635 | return 0; | 2644 | return 0; |
| @@ -2647,7 +2656,7 @@ void ocfs2_dentry_unlock(struct dentry *dentry, int ex) | |||
| 2647 | struct ocfs2_dentry_lock *dl = dentry->d_fsdata; | 2656 | struct ocfs2_dentry_lock *dl = dentry->d_fsdata; |
| 2648 | struct ocfs2_super *osb = OCFS2_SB(dentry->d_sb); | 2657 | struct ocfs2_super *osb = OCFS2_SB(dentry->d_sb); |
| 2649 | 2658 | ||
| 2650 | if (!ocfs2_mount_local(osb)) | 2659 | if (!ocfs2_is_hard_readonly(osb) && !ocfs2_mount_local(osb)) |
| 2651 | ocfs2_cluster_unlock(osb, &dl->dl_lockres, level); | 2660 | ocfs2_cluster_unlock(osb, &dl->dl_lockres, level); |
| 2652 | } | 2661 | } |
| 2653 | 2662 | ||
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c index 23457b491e8c..2f5b92ef0e53 100644 --- a/fs/ocfs2/extent_map.c +++ b/fs/ocfs2/extent_map.c | |||
| @@ -832,6 +832,102 @@ out: | |||
| 832 | return ret; | 832 | return ret; |
| 833 | } | 833 | } |
| 834 | 834 | ||
| 835 | int ocfs2_seek_data_hole_offset(struct file *file, loff_t *offset, int origin) | ||
| 836 | { | ||
| 837 | struct inode *inode = file->f_mapping->host; | ||
| 838 | int ret; | ||
| 839 | unsigned int is_last = 0, is_data = 0; | ||
| 840 | u16 cs_bits = OCFS2_SB(inode->i_sb)->s_clustersize_bits; | ||
| 841 | u32 cpos, cend, clen, hole_size; | ||
| 842 | u64 extoff, extlen; | ||
| 843 | struct buffer_head *di_bh = NULL; | ||
| 844 | struct ocfs2_extent_rec rec; | ||
| 845 | |||
| 846 | BUG_ON(origin != SEEK_DATA && origin != SEEK_HOLE); | ||
| 847 | |||
| 848 | ret = ocfs2_inode_lock(inode, &di_bh, 0); | ||
| 849 | if (ret) { | ||
| 850 | mlog_errno(ret); | ||
| 851 | goto out; | ||
| 852 | } | ||
| 853 | |||
| 854 | down_read(&OCFS2_I(inode)->ip_alloc_sem); | ||
| 855 | |||
| 856 | if (*offset >= inode->i_size) { | ||
| 857 | ret = -ENXIO; | ||
| 858 | goto out_unlock; | ||
| 859 | } | ||
| 860 | |||
| 861 | if (OCFS2_I(inode)->ip_dyn_features & OCFS2_INLINE_DATA_FL) { | ||
| 862 | if (origin == SEEK_HOLE) | ||
| 863 | *offset = inode->i_size; | ||
| 864 | goto out_unlock; | ||
| 865 | } | ||
| 866 | |||
| 867 | clen = 0; | ||
| 868 | cpos = *offset >> cs_bits; | ||
| 869 | cend = ocfs2_clusters_for_bytes(inode->i_sb, inode->i_size); | ||
| 870 | |||
| 871 | while (cpos < cend && !is_last) { | ||
| 872 | ret = ocfs2_get_clusters_nocache(inode, di_bh, cpos, &hole_size, | ||
| 873 | &rec, &is_last); | ||
| 874 | if (ret) { | ||
| 875 | mlog_errno(ret); | ||
| 876 | goto out_unlock; | ||
| 877 | } | ||
| 878 | |||
| 879 | extoff = cpos; | ||
| 880 | extoff <<= cs_bits; | ||
| 881 | |||
| 882 | if (rec.e_blkno == 0ULL) { | ||
| 883 | clen = hole_size; | ||
| 884 | is_data = 0; | ||
| 885 | } else { | ||
| 886 | clen = le16_to_cpu(rec.e_leaf_clusters) - | ||
| 887 | (cpos - le32_to_cpu(rec.e_cpos)); | ||
| 888 | is_data = (rec.e_flags & OCFS2_EXT_UNWRITTEN) ? 0 : 1; | ||
| 889 | } | ||
| 890 | |||
| 891 | if ((!is_data && origin == SEEK_HOLE) || | ||
| 892 | (is_data && origin == SEEK_DATA)) { | ||
| 893 | if (extoff > *offset) | ||
| 894 | *offset = extoff; | ||
| 895 | goto out_unlock; | ||
| 896 | } | ||
| 897 | |||
| 898 | if (!is_last) | ||
| 899 | cpos += clen; | ||
| 900 | } | ||
| 901 | |||
| 902 | if (origin == SEEK_HOLE) { | ||
| 903 | extoff = cpos; | ||
| 904 | extoff <<= cs_bits; | ||
| 905 | extlen = clen; | ||
| 906 | extlen <<= cs_bits; | ||
| 907 | |||
| 908 | if ((extoff + extlen) > inode->i_size) | ||
| 909 | extlen = inode->i_size - extoff; | ||
| 910 | extoff += extlen; | ||
| 911 | if (extoff > *offset) | ||
| 912 | *offset = extoff; | ||
| 913 | goto out_unlock; | ||
| 914 | } | ||
| 915 | |||
| 916 | ret = -ENXIO; | ||
| 917 | |||
| 918 | out_unlock: | ||
| 919 | |||
| 920 | brelse(di_bh); | ||
| 921 | |||
| 922 | up_read(&OCFS2_I(inode)->ip_alloc_sem); | ||
| 923 | |||
| 924 | ocfs2_inode_unlock(inode, 0); | ||
| 925 | out: | ||
| 926 | if (ret && ret != -ENXIO) | ||
| 927 | ret = -ENXIO; | ||
| 928 | return ret; | ||
| 929 | } | ||
| 930 | |||
| 835 | int ocfs2_read_virt_blocks(struct inode *inode, u64 v_block, int nr, | 931 | int ocfs2_read_virt_blocks(struct inode *inode, u64 v_block, int nr, |
| 836 | struct buffer_head *bhs[], int flags, | 932 | struct buffer_head *bhs[], int flags, |
| 837 | int (*validate)(struct super_block *sb, | 933 | int (*validate)(struct super_block *sb, |
diff --git a/fs/ocfs2/extent_map.h b/fs/ocfs2/extent_map.h index e79d41c2c909..67ea57d2fd59 100644 --- a/fs/ocfs2/extent_map.h +++ b/fs/ocfs2/extent_map.h | |||
| @@ -53,6 +53,8 @@ int ocfs2_extent_map_get_blocks(struct inode *inode, u64 v_blkno, u64 *p_blkno, | |||
| 53 | int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, | 53 | int ocfs2_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, |
| 54 | u64 map_start, u64 map_len); | 54 | u64 map_start, u64 map_len); |
| 55 | 55 | ||
| 56 | int ocfs2_seek_data_hole_offset(struct file *file, loff_t *offset, int origin); | ||
| 57 | |||
| 56 | int ocfs2_xattr_get_clusters(struct inode *inode, u32 v_cluster, | 58 | int ocfs2_xattr_get_clusters(struct inode *inode, u32 v_cluster, |
| 57 | u32 *p_cluster, u32 *num_clusters, | 59 | u32 *p_cluster, u32 *num_clusters, |
| 58 | struct ocfs2_extent_list *el, | 60 | struct ocfs2_extent_list *el, |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index de4ea1af041b..6e396683c3d4 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
| @@ -1950,6 +1950,9 @@ static int __ocfs2_change_file_space(struct file *file, struct inode *inode, | |||
| 1950 | if (ret < 0) | 1950 | if (ret < 0) |
| 1951 | mlog_errno(ret); | 1951 | mlog_errno(ret); |
| 1952 | 1952 | ||
| 1953 | if (file->f_flags & O_SYNC) | ||
| 1954 | handle->h_sync = 1; | ||
| 1955 | |||
| 1953 | ocfs2_commit_trans(osb, handle); | 1956 | ocfs2_commit_trans(osb, handle); |
| 1954 | 1957 | ||
| 1955 | out_inode_unlock: | 1958 | out_inode_unlock: |
| @@ -2052,6 +2055,23 @@ out: | |||
| 2052 | return ret; | 2055 | return ret; |
| 2053 | } | 2056 | } |
| 2054 | 2057 | ||
| 2058 | static void ocfs2_aiodio_wait(struct inode *inode) | ||
| 2059 | { | ||
| 2060 | wait_queue_head_t *wq = ocfs2_ioend_wq(inode); | ||
| 2061 | |||
| 2062 | wait_event(*wq, (atomic_read(&OCFS2_I(inode)->ip_unaligned_aio) == 0)); | ||
| 2063 | } | ||
| 2064 | |||
| 2065 | static int ocfs2_is_io_unaligned(struct inode *inode, size_t count, loff_t pos) | ||
| 2066 | { | ||
| 2067 | int blockmask = inode->i_sb->s_blocksize - 1; | ||
| 2068 | loff_t final_size = pos + count; | ||
| 2069 | |||
| 2070 | if ((pos & blockmask) || (final_size & blockmask)) | ||
| 2071 | return 1; | ||
| 2072 | return 0; | ||
| 2073 | } | ||
| 2074 | |||
| 2055 | static int ocfs2_prepare_inode_for_refcount(struct inode *inode, | 2075 | static int ocfs2_prepare_inode_for_refcount(struct inode *inode, |
| 2056 | struct file *file, | 2076 | struct file *file, |
| 2057 | loff_t pos, size_t count, | 2077 | loff_t pos, size_t count, |
| @@ -2230,6 +2250,7 @@ static ssize_t ocfs2_file_aio_write(struct kiocb *iocb, | |||
| 2230 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); | 2250 | struct ocfs2_super *osb = OCFS2_SB(inode->i_sb); |
| 2231 | int full_coherency = !(osb->s_mount_opt & | 2251 | int full_coherency = !(osb->s_mount_opt & |
| 2232 | OCFS2_MOUNT_COHERENCY_BUFFERED); | 2252 | OCFS2_MOUNT_COHERENCY_BUFFERED); |
| 2253 | int unaligned_dio = 0; | ||
| 2233 | 2254 | ||
| 2234 | trace_ocfs2_file_aio_write(inode, file, file->f_path.dentry, | 2255 | trace_ocfs2_file_aio_write(inode, file, file->f_path.dentry, |
| 2235 | (unsigned long long)OCFS2_I(inode)->ip_blkno, | 2256 | (unsigned long long)OCFS2_I(inode)->ip_blkno, |
| @@ -2297,6 +2318,10 @@ relock: | |||
| 2297 | goto out; | 2318 | goto out; |
| 2298 | } | 2319 | } |
| 2299 | 2320 | ||
| 2321 | if (direct_io && !is_sync_kiocb(iocb)) | ||
| 2322 | unaligned_dio = ocfs2_is_io_unaligned(inode, iocb->ki_left, | ||
| 2323 | *ppos); | ||
| 2324 | |||
| 2300 | /* | 2325 | /* |
| 2301 | * We can't complete the direct I/O as requested, fall back to | 2326 | * We can't complete the direct I/O as requested, fall back to |
| 2302 | * buffered I/O. | 2327 | * buffered I/O. |
| @@ -2311,6 +2336,18 @@ relock: | |||
| 2311 | goto relock; | 2336 | goto relock; |
| 2312 | } | 2337 | } |
| 2313 | 2338 | ||
| 2339 | if (unaligned_dio) { | ||
| 2340 | /* | ||
| 2341 | * Wait on previous unaligned aio to complete before | ||
| 2342 | * proceeding. | ||
| 2343 | */ | ||
| 2344 | ocfs2_aiodio_wait(inode); | ||
| 2345 | |||
| 2346 | /* Mark the iocb as needing a decrement in ocfs2_dio_end_io */ | ||
| 2347 | atomic_inc(&OCFS2_I(inode)->ip_unaligned_aio); | ||
| 2348 | ocfs2_iocb_set_unaligned_aio(iocb); | ||
| 2349 | } | ||
| 2350 | |||
| 2314 | /* | 2351 | /* |
| 2315 | * To later detect whether a journal commit for sync writes is | 2352 | * To later detect whether a journal commit for sync writes is |
| 2316 | * necessary, we sample i_size, and cluster count here. | 2353 | * necessary, we sample i_size, and cluster count here. |
| @@ -2382,8 +2419,12 @@ out_dio: | |||
| 2382 | if ((ret == -EIOCBQUEUED) || (!ocfs2_iocb_is_rw_locked(iocb))) { | 2419 | if ((ret == -EIOCBQUEUED) || (!ocfs2_iocb_is_rw_locked(iocb))) { |
| 2383 | rw_level = -1; | 2420 | rw_level = -1; |
| 2384 | have_alloc_sem = 0; | 2421 | have_alloc_sem = 0; |
| 2422 | unaligned_dio = 0; | ||
| 2385 | } | 2423 | } |
| 2386 | 2424 | ||
| 2425 | if (unaligned_dio) | ||
| 2426 | atomic_dec(&OCFS2_I(inode)->ip_unaligned_aio); | ||
| 2427 | |||
| 2387 | out: | 2428 | out: |
| 2388 | if (rw_level != -1) | 2429 | if (rw_level != -1) |
| 2389 | ocfs2_rw_unlock(inode, rw_level); | 2430 | ocfs2_rw_unlock(inode, rw_level); |
| @@ -2591,6 +2632,57 @@ bail: | |||
| 2591 | return ret; | 2632 | return ret; |
| 2592 | } | 2633 | } |
| 2593 | 2634 | ||
| 2635 | /* Refer generic_file_llseek_unlocked() */ | ||
| 2636 | static loff_t ocfs2_file_llseek(struct file *file, loff_t offset, int origin) | ||
| 2637 | { | ||
| 2638 | struct inode *inode = file->f_mapping->host; | ||
| 2639 | int ret = 0; | ||
| 2640 | |||
| 2641 | mutex_lock(&inode->i_mutex); | ||
| 2642 | |||
| 2643 | switch (origin) { | ||
| 2644 | case SEEK_SET: | ||
| 2645 | break; | ||
| 2646 | case SEEK_END: | ||
| 2647 | offset += inode->i_size; | ||
| 2648 | break; | ||
| 2649 | case SEEK_CUR: | ||
| 2650 | if (offset == 0) { | ||
| 2651 | offset = file->f_pos; | ||
| 2652 | goto out; | ||
| 2653 | } | ||
| 2654 | offset += file->f_pos; | ||
| 2655 | break; | ||
| 2656 | case SEEK_DATA: | ||
| 2657 | case SEEK_HOLE: | ||
| 2658 | ret = ocfs2_seek_data_hole_offset(file, &offset, origin); | ||
| 2659 | if (ret) | ||
| 2660 | goto out; | ||
| 2661 | break; | ||
| 2662 | default: | ||
| 2663 | ret = -EINVAL; | ||
| 2664 | goto out; | ||
| 2665 | } | ||
| 2666 | |||
| 2667 | if (offset < 0 && !(file->f_mode & FMODE_UNSIGNED_OFFSET)) | ||
| 2668 | ret = -EINVAL; | ||
| 2669 | if (!ret && offset > inode->i_sb->s_maxbytes) | ||
| 2670 | ret = -EINVAL; | ||
| 2671 | if (ret) | ||
| 2672 | goto out; | ||
| 2673 | |||
| 2674 | if (offset != file->f_pos) { | ||
| 2675 | file->f_pos = offset; | ||
| 2676 | file->f_version = 0; | ||
| 2677 | } | ||
| 2678 | |||
| 2679 | out: | ||
| 2680 | mutex_unlock(&inode->i_mutex); | ||
| 2681 | if (ret) | ||
| 2682 | return ret; | ||
| 2683 | return offset; | ||
| 2684 | } | ||
| 2685 | |||
| 2594 | const struct inode_operations ocfs2_file_iops = { | 2686 | const struct inode_operations ocfs2_file_iops = { |
| 2595 | .setattr = ocfs2_setattr, | 2687 | .setattr = ocfs2_setattr, |
| 2596 | .getattr = ocfs2_getattr, | 2688 | .getattr = ocfs2_getattr, |
| @@ -2615,7 +2707,7 @@ const struct inode_operations ocfs2_special_file_iops = { | |||
| 2615 | * ocfs2_fops_no_plocks and ocfs2_dops_no_plocks! | 2707 | * ocfs2_fops_no_plocks and ocfs2_dops_no_plocks! |
| 2616 | */ | 2708 | */ |
| 2617 | const struct file_operations ocfs2_fops = { | 2709 | const struct file_operations ocfs2_fops = { |
| 2618 | .llseek = generic_file_llseek, | 2710 | .llseek = ocfs2_file_llseek, |
| 2619 | .read = do_sync_read, | 2711 | .read = do_sync_read, |
| 2620 | .write = do_sync_write, | 2712 | .write = do_sync_write, |
| 2621 | .mmap = ocfs2_mmap, | 2713 | .mmap = ocfs2_mmap, |
| @@ -2663,7 +2755,7 @@ const struct file_operations ocfs2_dops = { | |||
| 2663 | * the cluster. | 2755 | * the cluster. |
| 2664 | */ | 2756 | */ |
| 2665 | const struct file_operations ocfs2_fops_no_plocks = { | 2757 | const struct file_operations ocfs2_fops_no_plocks = { |
| 2666 | .llseek = generic_file_llseek, | 2758 | .llseek = ocfs2_file_llseek, |
| 2667 | .read = do_sync_read, | 2759 | .read = do_sync_read, |
| 2668 | .write = do_sync_write, | 2760 | .write = do_sync_write, |
| 2669 | .mmap = ocfs2_mmap, | 2761 | .mmap = ocfs2_mmap, |
diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index a22d2c098890..17454a904d7b 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c | |||
| @@ -951,7 +951,7 @@ static void ocfs2_cleanup_delete_inode(struct inode *inode, | |||
| 951 | trace_ocfs2_cleanup_delete_inode( | 951 | trace_ocfs2_cleanup_delete_inode( |
| 952 | (unsigned long long)OCFS2_I(inode)->ip_blkno, sync_data); | 952 | (unsigned long long)OCFS2_I(inode)->ip_blkno, sync_data); |
| 953 | if (sync_data) | 953 | if (sync_data) |
| 954 | write_inode_now(inode, 1); | 954 | filemap_write_and_wait(inode->i_mapping); |
| 955 | truncate_inode_pages(&inode->i_data, 0); | 955 | truncate_inode_pages(&inode->i_data, 0); |
| 956 | } | 956 | } |
| 957 | 957 | ||
diff --git a/fs/ocfs2/inode.h b/fs/ocfs2/inode.h index 1c508b149b3a..88924a3133fa 100644 --- a/fs/ocfs2/inode.h +++ b/fs/ocfs2/inode.h | |||
| @@ -43,6 +43,9 @@ struct ocfs2_inode_info | |||
| 43 | /* protects extended attribute changes on this inode */ | 43 | /* protects extended attribute changes on this inode */ |
| 44 | struct rw_semaphore ip_xattr_sem; | 44 | struct rw_semaphore ip_xattr_sem; |
| 45 | 45 | ||
| 46 | /* Number of outstanding AIO's which are not page aligned */ | ||
| 47 | atomic_t ip_unaligned_aio; | ||
| 48 | |||
| 46 | /* These fields are protected by ip_lock */ | 49 | /* These fields are protected by ip_lock */ |
| 47 | spinlock_t ip_lock; | 50 | spinlock_t ip_lock; |
| 48 | u32 ip_open_count; | 51 | u32 ip_open_count; |
diff --git a/fs/ocfs2/ioctl.c b/fs/ocfs2/ioctl.c index bc91072b7219..726ff265b296 100644 --- a/fs/ocfs2/ioctl.c +++ b/fs/ocfs2/ioctl.c | |||
| @@ -122,7 +122,7 @@ static int ocfs2_set_inode_attr(struct inode *inode, unsigned flags, | |||
| 122 | if ((oldflags & OCFS2_IMMUTABLE_FL) || ((flags ^ oldflags) & | 122 | if ((oldflags & OCFS2_IMMUTABLE_FL) || ((flags ^ oldflags) & |
| 123 | (OCFS2_APPEND_FL | OCFS2_IMMUTABLE_FL))) { | 123 | (OCFS2_APPEND_FL | OCFS2_IMMUTABLE_FL))) { |
| 124 | if (!capable(CAP_LINUX_IMMUTABLE)) | 124 | if (!capable(CAP_LINUX_IMMUTABLE)) |
| 125 | goto bail_unlock; | 125 | goto bail_commit; |
| 126 | } | 126 | } |
| 127 | 127 | ||
| 128 | ocfs2_inode->ip_attr = flags; | 128 | ocfs2_inode->ip_attr = flags; |
| @@ -132,6 +132,7 @@ static int ocfs2_set_inode_attr(struct inode *inode, unsigned flags, | |||
| 132 | if (status < 0) | 132 | if (status < 0) |
| 133 | mlog_errno(status); | 133 | mlog_errno(status); |
| 134 | 134 | ||
| 135 | bail_commit: | ||
| 135 | ocfs2_commit_trans(osb, handle); | 136 | ocfs2_commit_trans(osb, handle); |
| 136 | bail_unlock: | 137 | bail_unlock: |
| 137 | ocfs2_inode_unlock(inode, 1); | 138 | ocfs2_inode_unlock(inode, 1); |
| @@ -381,7 +382,7 @@ int ocfs2_info_handle_freeinode(struct inode *inode, | |||
| 381 | if (!oifi) { | 382 | if (!oifi) { |
| 382 | status = -ENOMEM; | 383 | status = -ENOMEM; |
| 383 | mlog_errno(status); | 384 | mlog_errno(status); |
| 384 | goto bail; | 385 | goto out_err; |
| 385 | } | 386 | } |
| 386 | 387 | ||
| 387 | if (o2info_from_user(*oifi, req)) | 388 | if (o2info_from_user(*oifi, req)) |
| @@ -431,7 +432,7 @@ bail: | |||
| 431 | o2info_set_request_error(&oifi->ifi_req, req); | 432 | o2info_set_request_error(&oifi->ifi_req, req); |
| 432 | 433 | ||
| 433 | kfree(oifi); | 434 | kfree(oifi); |
| 434 | 435 | out_err: | |
| 435 | return status; | 436 | return status; |
| 436 | } | 437 | } |
| 437 | 438 | ||
| @@ -666,7 +667,7 @@ int ocfs2_info_handle_freefrag(struct inode *inode, | |||
| 666 | if (!oiff) { | 667 | if (!oiff) { |
| 667 | status = -ENOMEM; | 668 | status = -ENOMEM; |
| 668 | mlog_errno(status); | 669 | mlog_errno(status); |
| 669 | goto bail; | 670 | goto out_err; |
| 670 | } | 671 | } |
| 671 | 672 | ||
| 672 | if (o2info_from_user(*oiff, req)) | 673 | if (o2info_from_user(*oiff, req)) |
| @@ -716,7 +717,7 @@ bail: | |||
| 716 | o2info_set_request_error(&oiff->iff_req, req); | 717 | o2info_set_request_error(&oiff->iff_req, req); |
| 717 | 718 | ||
| 718 | kfree(oiff); | 719 | kfree(oiff); |
| 719 | 720 | out_err: | |
| 720 | return status; | 721 | return status; |
| 721 | } | 722 | } |
| 722 | 723 | ||
diff --git a/fs/ocfs2/journal.c b/fs/ocfs2/journal.c index 295d56454e8b..0a42ae96dca7 100644 --- a/fs/ocfs2/journal.c +++ b/fs/ocfs2/journal.c | |||
| @@ -1544,9 +1544,9 @@ static int ocfs2_replay_journal(struct ocfs2_super *osb, | |||
| 1544 | /* we need to run complete recovery for offline orphan slots */ | 1544 | /* we need to run complete recovery for offline orphan slots */ |
| 1545 | ocfs2_replay_map_set_state(osb, REPLAY_NEEDED); | 1545 | ocfs2_replay_map_set_state(osb, REPLAY_NEEDED); |
| 1546 | 1546 | ||
| 1547 | mlog(ML_NOTICE, "Recovering node %d from slot %d on device (%u,%u)\n", | 1547 | printk(KERN_NOTICE "ocfs2: Begin replay journal (node %d, slot %d) on "\ |
| 1548 | node_num, slot_num, | 1548 | "device (%u,%u)\n", node_num, slot_num, MAJOR(osb->sb->s_dev), |
| 1549 | MAJOR(osb->sb->s_dev), MINOR(osb->sb->s_dev)); | 1549 | MINOR(osb->sb->s_dev)); |
| 1550 | 1550 | ||
| 1551 | OCFS2_I(inode)->ip_clusters = le32_to_cpu(fe->i_clusters); | 1551 | OCFS2_I(inode)->ip_clusters = le32_to_cpu(fe->i_clusters); |
| 1552 | 1552 | ||
| @@ -1601,6 +1601,9 @@ static int ocfs2_replay_journal(struct ocfs2_super *osb, | |||
| 1601 | 1601 | ||
| 1602 | jbd2_journal_destroy(journal); | 1602 | jbd2_journal_destroy(journal); |
| 1603 | 1603 | ||
| 1604 | printk(KERN_NOTICE "ocfs2: End replay journal (node %d, slot %d) on "\ | ||
| 1605 | "device (%u,%u)\n", node_num, slot_num, MAJOR(osb->sb->s_dev), | ||
| 1606 | MINOR(osb->sb->s_dev)); | ||
| 1604 | done: | 1607 | done: |
| 1605 | /* drop the lock on this nodes journal */ | 1608 | /* drop the lock on this nodes journal */ |
| 1606 | if (got_lock) | 1609 | if (got_lock) |
| @@ -1808,6 +1811,20 @@ static inline unsigned long ocfs2_orphan_scan_timeout(void) | |||
| 1808 | * every slot, queuing a recovery of the slot on the ocfs2_wq thread. This | 1811 | * every slot, queuing a recovery of the slot on the ocfs2_wq thread. This |
| 1809 | * is done to catch any orphans that are left over in orphan directories. | 1812 | * is done to catch any orphans that are left over in orphan directories. |
| 1810 | * | 1813 | * |
| 1814 | * It scans all slots, even ones that are in use. It does so to handle the | ||
| 1815 | * case described below: | ||
| 1816 | * | ||
| 1817 | * Node 1 has an inode it was using. The dentry went away due to memory | ||
| 1818 | * pressure. Node 1 closes the inode, but it's on the free list. The node | ||
| 1819 | * has the open lock. | ||
| 1820 | * Node 2 unlinks the inode. It grabs the dentry lock to notify others, | ||
| 1821 | * but node 1 has no dentry and doesn't get the message. It trylocks the | ||
| 1822 | * open lock, sees that another node has a PR, and does nothing. | ||
| 1823 | * Later node 2 runs its orphan dir. It igets the inode, trylocks the | ||
| 1824 | * open lock, sees the PR still, and does nothing. | ||
| 1825 | * Basically, we have to trigger an orphan iput on node 1. The only way | ||
| 1826 | * for this to happen is if node 1 runs node 2's orphan dir. | ||
| 1827 | * | ||
| 1811 | * ocfs2_queue_orphan_scan gets called every ORPHAN_SCAN_SCHEDULE_TIMEOUT | 1828 | * ocfs2_queue_orphan_scan gets called every ORPHAN_SCAN_SCHEDULE_TIMEOUT |
| 1812 | * seconds. It gets an EX lock on os_lockres and checks sequence number | 1829 | * seconds. It gets an EX lock on os_lockres and checks sequence number |
| 1813 | * stored in LVB. If the sequence number has changed, it means some other | 1830 | * stored in LVB. If the sequence number has changed, it means some other |
diff --git a/fs/ocfs2/journal.h b/fs/ocfs2/journal.h index 68cf2f6d3c6a..a3385b63ff5e 100644 --- a/fs/ocfs2/journal.h +++ b/fs/ocfs2/journal.h | |||
| @@ -441,10 +441,11 @@ static inline int ocfs2_mknod_credits(struct super_block *sb, int is_dir, | |||
| 441 | #define OCFS2_SIMPLE_DIR_EXTEND_CREDITS (2) | 441 | #define OCFS2_SIMPLE_DIR_EXTEND_CREDITS (2) |
| 442 | 442 | ||
| 443 | /* file update (nlink, etc) + directory mtime/ctime + dir entry block + quota | 443 | /* file update (nlink, etc) + directory mtime/ctime + dir entry block + quota |
| 444 | * update on dir + index leaf + dx root update for free list */ | 444 | * update on dir + index leaf + dx root update for free list + |
| 445 | * previous dirblock update in the free list */ | ||
| 445 | static inline int ocfs2_link_credits(struct super_block *sb) | 446 | static inline int ocfs2_link_credits(struct super_block *sb) |
| 446 | { | 447 | { |
| 447 | return 2*OCFS2_INODE_UPDATE_CREDITS + 3 + | 448 | return 2*OCFS2_INODE_UPDATE_CREDITS + 4 + |
| 448 | ocfs2_quota_trans_credits(sb); | 449 | ocfs2_quota_trans_credits(sb); |
| 449 | } | 450 | } |
| 450 | 451 | ||
diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/mmap.c index 3e9393ca39eb..9cd41083e991 100644 --- a/fs/ocfs2/mmap.c +++ b/fs/ocfs2/mmap.c | |||
| @@ -61,7 +61,7 @@ static int ocfs2_fault(struct vm_area_struct *area, struct vm_fault *vmf) | |||
| 61 | static int __ocfs2_page_mkwrite(struct file *file, struct buffer_head *di_bh, | 61 | static int __ocfs2_page_mkwrite(struct file *file, struct buffer_head *di_bh, |
| 62 | struct page *page) | 62 | struct page *page) |
| 63 | { | 63 | { |
| 64 | int ret; | 64 | int ret = VM_FAULT_NOPAGE; |
| 65 | struct inode *inode = file->f_path.dentry->d_inode; | 65 | struct inode *inode = file->f_path.dentry->d_inode; |
| 66 | struct address_space *mapping = inode->i_mapping; | 66 | struct address_space *mapping = inode->i_mapping; |
| 67 | loff_t pos = page_offset(page); | 67 | loff_t pos = page_offset(page); |
| @@ -71,32 +71,25 @@ static int __ocfs2_page_mkwrite(struct file *file, struct buffer_head *di_bh, | |||
| 71 | void *fsdata; | 71 | void *fsdata; |
| 72 | loff_t size = i_size_read(inode); | 72 | loff_t size = i_size_read(inode); |
| 73 | 73 | ||
| 74 | /* | ||
| 75 | * Another node might have truncated while we were waiting on | ||
| 76 | * cluster locks. | ||
| 77 | * We don't check size == 0 before the shift. This is borrowed | ||
| 78 | * from do_generic_file_read. | ||
| 79 | */ | ||
| 80 | last_index = (size - 1) >> PAGE_CACHE_SHIFT; | 74 | last_index = (size - 1) >> PAGE_CACHE_SHIFT; |
| 81 | if (unlikely(!size || page->index > last_index)) { | ||
| 82 | ret = -EINVAL; | ||
| 83 | goto out; | ||
| 84 | } | ||
| 85 | 75 | ||
| 86 | /* | 76 | /* |
| 87 | * The i_size check above doesn't catch the case where nodes | 77 | * There are cases that lead to the page no longer bebongs to the |
| 88 | * truncated and then re-extended the file. We'll re-check the | 78 | * mapping. |
| 89 | * page mapping after taking the page lock inside of | 79 | * 1) pagecache truncates locally due to memory pressure. |
| 90 | * ocfs2_write_begin_nolock(). | 80 | * 2) pagecache truncates when another is taking EX lock against |
| 81 | * inode lock. see ocfs2_data_convert_worker. | ||
| 82 | * | ||
| 83 | * The i_size check doesn't catch the case where nodes truncated and | ||
| 84 | * then re-extended the file. We'll re-check the page mapping after | ||
| 85 | * taking the page lock inside of ocfs2_write_begin_nolock(). | ||
| 86 | * | ||
| 87 | * Let VM retry with these cases. | ||
| 91 | */ | 88 | */ |
| 92 | if (!PageUptodate(page) || page->mapping != inode->i_mapping) { | 89 | if ((page->mapping != inode->i_mapping) || |
| 93 | /* | 90 | (!PageUptodate(page)) || |
| 94 | * the page has been umapped in ocfs2_data_downconvert_worker. | 91 | (page_offset(page) >= size)) |
| 95 | * So return 0 here and let VFS retry. | ||
| 96 | */ | ||
| 97 | ret = 0; | ||
| 98 | goto out; | 92 | goto out; |
| 99 | } | ||
| 100 | 93 | ||
| 101 | /* | 94 | /* |
| 102 | * Call ocfs2_write_begin() and ocfs2_write_end() to take | 95 | * Call ocfs2_write_begin() and ocfs2_write_end() to take |
| @@ -116,17 +109,21 @@ static int __ocfs2_page_mkwrite(struct file *file, struct buffer_head *di_bh, | |||
| 116 | if (ret) { | 109 | if (ret) { |
| 117 | if (ret != -ENOSPC) | 110 | if (ret != -ENOSPC) |
| 118 | mlog_errno(ret); | 111 | mlog_errno(ret); |
| 112 | if (ret == -ENOMEM) | ||
| 113 | ret = VM_FAULT_OOM; | ||
| 114 | else | ||
| 115 | ret = VM_FAULT_SIGBUS; | ||
| 119 | goto out; | 116 | goto out; |
| 120 | } | 117 | } |
| 121 | 118 | ||
| 122 | ret = ocfs2_write_end_nolock(mapping, pos, len, len, locked_page, | 119 | if (!locked_page) { |
| 123 | fsdata); | 120 | ret = VM_FAULT_NOPAGE; |
| 124 | if (ret < 0) { | ||
| 125 | mlog_errno(ret); | ||
| 126 | goto out; | 121 | goto out; |
| 127 | } | 122 | } |
| 123 | ret = ocfs2_write_end_nolock(mapping, pos, len, len, locked_page, | ||
| 124 | fsdata); | ||
| 128 | BUG_ON(ret != len); | 125 | BUG_ON(ret != len); |
| 129 | ret = 0; | 126 | ret = VM_FAULT_LOCKED; |
| 130 | out: | 127 | out: |
| 131 | return ret; | 128 | return ret; |
| 132 | } | 129 | } |
| @@ -168,8 +165,6 @@ static int ocfs2_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) | |||
| 168 | 165 | ||
| 169 | out: | 166 | out: |
| 170 | ocfs2_unblock_signals(&oldset); | 167 | ocfs2_unblock_signals(&oldset); |
| 171 | if (ret) | ||
| 172 | ret = VM_FAULT_SIGBUS; | ||
| 173 | return ret; | 168 | return ret; |
| 174 | } | 169 | } |
| 175 | 170 | ||
diff --git a/fs/ocfs2/move_extents.c b/fs/ocfs2/move_extents.c index d53cb706f14c..184c76b8c293 100644 --- a/fs/ocfs2/move_extents.c +++ b/fs/ocfs2/move_extents.c | |||
| @@ -745,7 +745,7 @@ static int ocfs2_move_extent(struct ocfs2_move_extents_context *context, | |||
| 745 | */ | 745 | */ |
| 746 | ocfs2_probe_alloc_group(inode, gd_bh, &goal_bit, len, move_max_hop, | 746 | ocfs2_probe_alloc_group(inode, gd_bh, &goal_bit, len, move_max_hop, |
| 747 | new_phys_cpos); | 747 | new_phys_cpos); |
| 748 | if (!new_phys_cpos) { | 748 | if (!*new_phys_cpos) { |
| 749 | ret = -ENOSPC; | 749 | ret = -ENOSPC; |
| 750 | goto out_commit; | 750 | goto out_commit; |
| 751 | } | 751 | } |
diff --git a/fs/ocfs2/ocfs2.h b/fs/ocfs2/ocfs2.h index 409285854f64..d355e6e36b36 100644 --- a/fs/ocfs2/ocfs2.h +++ b/fs/ocfs2/ocfs2.h | |||
| @@ -836,18 +836,65 @@ static inline unsigned int ocfs2_clusters_to_megabytes(struct super_block *sb, | |||
| 836 | 836 | ||
| 837 | static inline void _ocfs2_set_bit(unsigned int bit, unsigned long *bitmap) | 837 | static inline void _ocfs2_set_bit(unsigned int bit, unsigned long *bitmap) |
| 838 | { | 838 | { |
| 839 | __test_and_set_bit_le(bit, bitmap); | 839 | __set_bit_le(bit, bitmap); |
| 840 | } | 840 | } |
| 841 | #define ocfs2_set_bit(bit, addr) _ocfs2_set_bit((bit), (unsigned long *)(addr)) | 841 | #define ocfs2_set_bit(bit, addr) _ocfs2_set_bit((bit), (unsigned long *)(addr)) |
| 842 | 842 | ||
| 843 | static inline void _ocfs2_clear_bit(unsigned int bit, unsigned long *bitmap) | 843 | static inline void _ocfs2_clear_bit(unsigned int bit, unsigned long *bitmap) |
| 844 | { | 844 | { |
| 845 | __test_and_clear_bit_le(bit, bitmap); | 845 | __clear_bit_le(bit, bitmap); |
| 846 | } | 846 | } |
| 847 | #define ocfs2_clear_bit(bit, addr) _ocfs2_clear_bit((bit), (unsigned long *)(addr)) | 847 | #define ocfs2_clear_bit(bit, addr) _ocfs2_clear_bit((bit), (unsigned long *)(addr)) |
| 848 | 848 | ||
| 849 | #define ocfs2_test_bit test_bit_le | 849 | #define ocfs2_test_bit test_bit_le |
| 850 | #define ocfs2_find_next_zero_bit find_next_zero_bit_le | 850 | #define ocfs2_find_next_zero_bit find_next_zero_bit_le |
| 851 | #define ocfs2_find_next_bit find_next_bit_le | 851 | #define ocfs2_find_next_bit find_next_bit_le |
| 852 | |||
| 853 | static inline void *correct_addr_and_bit_unaligned(int *bit, void *addr) | ||
| 854 | { | ||
| 855 | #if BITS_PER_LONG == 64 | ||
| 856 | *bit += ((unsigned long) addr & 7UL) << 3; | ||
| 857 | addr = (void *) ((unsigned long) addr & ~7UL); | ||
| 858 | #elif BITS_PER_LONG == 32 | ||
| 859 | *bit += ((unsigned long) addr & 3UL) << 3; | ||
| 860 | addr = (void *) ((unsigned long) addr & ~3UL); | ||
| 861 | #else | ||
| 862 | #error "how many bits you are?!" | ||
| 863 | #endif | ||
| 864 | return addr; | ||
| 865 | } | ||
| 866 | |||
| 867 | static inline void ocfs2_set_bit_unaligned(int bit, void *bitmap) | ||
| 868 | { | ||
| 869 | bitmap = correct_addr_and_bit_unaligned(&bit, bitmap); | ||
| 870 | ocfs2_set_bit(bit, bitmap); | ||
| 871 | } | ||
| 872 | |||
| 873 | static inline void ocfs2_clear_bit_unaligned(int bit, void *bitmap) | ||
| 874 | { | ||
| 875 | bitmap = correct_addr_and_bit_unaligned(&bit, bitmap); | ||
| 876 | ocfs2_clear_bit(bit, bitmap); | ||
| 877 | } | ||
| 878 | |||
| 879 | static inline int ocfs2_test_bit_unaligned(int bit, void *bitmap) | ||
| 880 | { | ||
| 881 | bitmap = correct_addr_and_bit_unaligned(&bit, bitmap); | ||
| 882 | return ocfs2_test_bit(bit, bitmap); | ||
| 883 | } | ||
| 884 | |||
| 885 | static inline int ocfs2_find_next_zero_bit_unaligned(void *bitmap, int max, | ||
| 886 | int start) | ||
| 887 | { | ||
| 888 | int fix = 0, ret, tmpmax; | ||
| 889 | bitmap = correct_addr_and_bit_unaligned(&fix, bitmap); | ||
| 890 | tmpmax = max + fix; | ||
| 891 | start += fix; | ||
| 892 | |||
| 893 | ret = ocfs2_find_next_zero_bit(bitmap, tmpmax, start) - fix; | ||
| 894 | if (ret > max) | ||
| 895 | return max; | ||
| 896 | return ret; | ||
| 897 | } | ||
| 898 | |||
| 852 | #endif /* OCFS2_H */ | 899 | #endif /* OCFS2_H */ |
| 853 | 900 | ||
diff --git a/fs/ocfs2/quota_local.c b/fs/ocfs2/quota_local.c index dc8007fc9247..f100bf70a906 100644 --- a/fs/ocfs2/quota_local.c +++ b/fs/ocfs2/quota_local.c | |||
| @@ -404,7 +404,9 @@ struct ocfs2_quota_recovery *ocfs2_begin_quota_recovery( | |||
| 404 | int status = 0; | 404 | int status = 0; |
| 405 | struct ocfs2_quota_recovery *rec; | 405 | struct ocfs2_quota_recovery *rec; |
| 406 | 406 | ||
| 407 | mlog(ML_NOTICE, "Beginning quota recovery in slot %u\n", slot_num); | 407 | printk(KERN_NOTICE "ocfs2: Beginning quota recovery on device (%s) for " |
| 408 | "slot %u\n", osb->dev_str, slot_num); | ||
| 409 | |||
| 408 | rec = ocfs2_alloc_quota_recovery(); | 410 | rec = ocfs2_alloc_quota_recovery(); |
| 409 | if (!rec) | 411 | if (!rec) |
| 410 | return ERR_PTR(-ENOMEM); | 412 | return ERR_PTR(-ENOMEM); |
| @@ -549,8 +551,8 @@ static int ocfs2_recover_local_quota_file(struct inode *lqinode, | |||
| 549 | goto out_commit; | 551 | goto out_commit; |
| 550 | } | 552 | } |
| 551 | lock_buffer(qbh); | 553 | lock_buffer(qbh); |
| 552 | WARN_ON(!ocfs2_test_bit(bit, dchunk->dqc_bitmap)); | 554 | WARN_ON(!ocfs2_test_bit_unaligned(bit, dchunk->dqc_bitmap)); |
| 553 | ocfs2_clear_bit(bit, dchunk->dqc_bitmap); | 555 | ocfs2_clear_bit_unaligned(bit, dchunk->dqc_bitmap); |
| 554 | le32_add_cpu(&dchunk->dqc_free, 1); | 556 | le32_add_cpu(&dchunk->dqc_free, 1); |
| 555 | unlock_buffer(qbh); | 557 | unlock_buffer(qbh); |
| 556 | ocfs2_journal_dirty(handle, qbh); | 558 | ocfs2_journal_dirty(handle, qbh); |
| @@ -596,7 +598,9 @@ int ocfs2_finish_quota_recovery(struct ocfs2_super *osb, | |||
| 596 | struct inode *lqinode; | 598 | struct inode *lqinode; |
| 597 | unsigned int flags; | 599 | unsigned int flags; |
| 598 | 600 | ||
| 599 | mlog(ML_NOTICE, "Finishing quota recovery in slot %u\n", slot_num); | 601 | printk(KERN_NOTICE "ocfs2: Finishing quota recovery on device (%s) for " |
| 602 | "slot %u\n", osb->dev_str, slot_num); | ||
| 603 | |||
| 600 | mutex_lock(&sb_dqopt(sb)->dqonoff_mutex); | 604 | mutex_lock(&sb_dqopt(sb)->dqonoff_mutex); |
| 601 | for (type = 0; type < MAXQUOTAS; type++) { | 605 | for (type = 0; type < MAXQUOTAS; type++) { |
| 602 | if (list_empty(&(rec->r_list[type]))) | 606 | if (list_empty(&(rec->r_list[type]))) |
| @@ -612,8 +616,9 @@ int ocfs2_finish_quota_recovery(struct ocfs2_super *osb, | |||
| 612 | /* Someone else is holding the lock? Then he must be | 616 | /* Someone else is holding the lock? Then he must be |
| 613 | * doing the recovery. Just skip the file... */ | 617 | * doing the recovery. Just skip the file... */ |
| 614 | if (status == -EAGAIN) { | 618 | if (status == -EAGAIN) { |
| 615 | mlog(ML_NOTICE, "skipping quota recovery for slot %d " | 619 | printk(KERN_NOTICE "ocfs2: Skipping quota recovery on " |
| 616 | "because quota file is locked.\n", slot_num); | 620 | "device (%s) for slot %d because quota file is " |
| 621 | "locked.\n", osb->dev_str, slot_num); | ||
| 617 | status = 0; | 622 | status = 0; |
| 618 | goto out_put; | 623 | goto out_put; |
| 619 | } else if (status < 0) { | 624 | } else if (status < 0) { |
| @@ -944,7 +949,7 @@ static struct ocfs2_quota_chunk *ocfs2_find_free_entry(struct super_block *sb, | |||
| 944 | * ol_quota_entries_per_block(sb); | 949 | * ol_quota_entries_per_block(sb); |
| 945 | } | 950 | } |
| 946 | 951 | ||
| 947 | found = ocfs2_find_next_zero_bit(dchunk->dqc_bitmap, len, 0); | 952 | found = ocfs2_find_next_zero_bit_unaligned(dchunk->dqc_bitmap, len, 0); |
| 948 | /* We failed? */ | 953 | /* We failed? */ |
| 949 | if (found == len) { | 954 | if (found == len) { |
| 950 | mlog(ML_ERROR, "Did not find empty entry in chunk %d with %u" | 955 | mlog(ML_ERROR, "Did not find empty entry in chunk %d with %u" |
| @@ -1208,7 +1213,7 @@ static void olq_alloc_dquot(struct buffer_head *bh, void *private) | |||
| 1208 | struct ocfs2_local_disk_chunk *dchunk; | 1213 | struct ocfs2_local_disk_chunk *dchunk; |
| 1209 | 1214 | ||
| 1210 | dchunk = (struct ocfs2_local_disk_chunk *)bh->b_data; | 1215 | dchunk = (struct ocfs2_local_disk_chunk *)bh->b_data; |
| 1211 | ocfs2_set_bit(*offset, dchunk->dqc_bitmap); | 1216 | ocfs2_set_bit_unaligned(*offset, dchunk->dqc_bitmap); |
| 1212 | le32_add_cpu(&dchunk->dqc_free, -1); | 1217 | le32_add_cpu(&dchunk->dqc_free, -1); |
| 1213 | } | 1218 | } |
| 1214 | 1219 | ||
| @@ -1289,7 +1294,7 @@ int ocfs2_local_release_dquot(handle_t *handle, struct dquot *dquot) | |||
| 1289 | (od->dq_chunk->qc_headerbh->b_data); | 1294 | (od->dq_chunk->qc_headerbh->b_data); |
| 1290 | /* Mark structure as freed */ | 1295 | /* Mark structure as freed */ |
| 1291 | lock_buffer(od->dq_chunk->qc_headerbh); | 1296 | lock_buffer(od->dq_chunk->qc_headerbh); |
| 1292 | ocfs2_clear_bit(offset, dchunk->dqc_bitmap); | 1297 | ocfs2_clear_bit_unaligned(offset, dchunk->dqc_bitmap); |
| 1293 | le32_add_cpu(&dchunk->dqc_free, 1); | 1298 | le32_add_cpu(&dchunk->dqc_free, 1); |
| 1294 | unlock_buffer(od->dq_chunk->qc_headerbh); | 1299 | unlock_buffer(od->dq_chunk->qc_headerbh); |
| 1295 | ocfs2_journal_dirty(handle, od->dq_chunk->qc_headerbh); | 1300 | ocfs2_journal_dirty(handle, od->dq_chunk->qc_headerbh); |
diff --git a/fs/ocfs2/slot_map.c b/fs/ocfs2/slot_map.c index 26fc0014d509..1424c151cccc 100644 --- a/fs/ocfs2/slot_map.c +++ b/fs/ocfs2/slot_map.c | |||
| @@ -493,8 +493,8 @@ int ocfs2_find_slot(struct ocfs2_super *osb) | |||
| 493 | goto bail; | 493 | goto bail; |
| 494 | } | 494 | } |
| 495 | } else | 495 | } else |
| 496 | mlog(ML_NOTICE, "slot %d is already allocated to this node!\n", | 496 | printk(KERN_INFO "ocfs2: Slot %d on device (%s) was already " |
| 497 | slot); | 497 | "allocated to this node!\n", slot, osb->dev_str); |
| 498 | 498 | ||
| 499 | ocfs2_set_slot(si, slot, osb->node_num); | 499 | ocfs2_set_slot(si, slot, osb->node_num); |
| 500 | osb->slot_num = slot; | 500 | osb->slot_num = slot; |
diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c index 19965b00c43c..94368017edb3 100644 --- a/fs/ocfs2/stack_o2cb.c +++ b/fs/ocfs2/stack_o2cb.c | |||
| @@ -28,6 +28,7 @@ | |||
| 28 | #include "cluster/masklog.h" | 28 | #include "cluster/masklog.h" |
| 29 | #include "cluster/nodemanager.h" | 29 | #include "cluster/nodemanager.h" |
| 30 | #include "cluster/heartbeat.h" | 30 | #include "cluster/heartbeat.h" |
| 31 | #include "cluster/tcp.h" | ||
| 31 | 32 | ||
| 32 | #include "stackglue.h" | 33 | #include "stackglue.h" |
| 33 | 34 | ||
| @@ -256,6 +257,61 @@ static void o2cb_dump_lksb(struct ocfs2_dlm_lksb *lksb) | |||
| 256 | } | 257 | } |
| 257 | 258 | ||
| 258 | /* | 259 | /* |
| 260 | * Check if this node is heartbeating and is connected to all other | ||
| 261 | * heartbeating nodes. | ||
| 262 | */ | ||
| 263 | static int o2cb_cluster_check(void) | ||
| 264 | { | ||
| 265 | u8 node_num; | ||
| 266 | int i; | ||
| 267 | unsigned long hbmap[BITS_TO_LONGS(O2NM_MAX_NODES)]; | ||
| 268 | unsigned long netmap[BITS_TO_LONGS(O2NM_MAX_NODES)]; | ||
| 269 | |||
| 270 | node_num = o2nm_this_node(); | ||
| 271 | if (node_num == O2NM_MAX_NODES) { | ||
| 272 | printk(KERN_ERR "o2cb: This node has not been configured.\n"); | ||
| 273 | return -EINVAL; | ||
| 274 | } | ||
| 275 | |||
| 276 | /* | ||
| 277 | * o2dlm expects o2net sockets to be created. If not, then | ||
| 278 | * dlm_join_domain() fails with a stack of errors which are both cryptic | ||
| 279 | * and incomplete. The idea here is to detect upfront whether we have | ||
| 280 | * managed to connect to all nodes or not. If not, then list the nodes | ||
| 281 | * to allow the user to check the configuration (incorrect IP, firewall, | ||
| 282 | * etc.) Yes, this is racy. But its not the end of the world. | ||
| 283 | */ | ||
| 284 | #define O2CB_MAP_STABILIZE_COUNT 60 | ||
| 285 | for (i = 0; i < O2CB_MAP_STABILIZE_COUNT; ++i) { | ||
| 286 | o2hb_fill_node_map(hbmap, sizeof(hbmap)); | ||
| 287 | if (!test_bit(node_num, hbmap)) { | ||
| 288 | printk(KERN_ERR "o2cb: %s heartbeat has not been " | ||
| 289 | "started.\n", (o2hb_global_heartbeat_active() ? | ||
| 290 | "Global" : "Local")); | ||
| 291 | return -EINVAL; | ||
| 292 | } | ||
| 293 | o2net_fill_node_map(netmap, sizeof(netmap)); | ||
| 294 | /* Force set the current node to allow easy compare */ | ||
| 295 | set_bit(node_num, netmap); | ||
| 296 | if (!memcmp(hbmap, netmap, sizeof(hbmap))) | ||
| 297 | return 0; | ||
| 298 | if (i < O2CB_MAP_STABILIZE_COUNT) | ||
| 299 | msleep(1000); | ||
| 300 | } | ||
| 301 | |||
| 302 | printk(KERN_ERR "o2cb: This node could not connect to nodes:"); | ||
| 303 | i = -1; | ||
| 304 | while ((i = find_next_bit(hbmap, O2NM_MAX_NODES, | ||
| 305 | i + 1)) < O2NM_MAX_NODES) { | ||
| 306 | if (!test_bit(i, netmap)) | ||
| 307 | printk(" %u", i); | ||
| 308 | } | ||
| 309 | printk(".\n"); | ||
| 310 | |||
| 311 | return -ENOTCONN; | ||
| 312 | } | ||
| 313 | |||
| 314 | /* | ||
| 259 | * Called from the dlm when it's about to evict a node. This is how the | 315 | * Called from the dlm when it's about to evict a node. This is how the |
| 260 | * classic stack signals node death. | 316 | * classic stack signals node death. |
| 261 | */ | 317 | */ |
| @@ -263,8 +319,8 @@ static void o2dlm_eviction_cb(int node_num, void *data) | |||
| 263 | { | 319 | { |
| 264 | struct ocfs2_cluster_connection *conn = data; | 320 | struct ocfs2_cluster_connection *conn = data; |
| 265 | 321 | ||
| 266 | mlog(ML_NOTICE, "o2dlm has evicted node %d from group %.*s\n", | 322 | printk(KERN_NOTICE "o2cb: o2dlm has evicted node %d from domain %.*s\n", |
| 267 | node_num, conn->cc_namelen, conn->cc_name); | 323 | node_num, conn->cc_namelen, conn->cc_name); |
| 268 | 324 | ||
| 269 | conn->cc_recovery_handler(node_num, conn->cc_recovery_data); | 325 | conn->cc_recovery_handler(node_num, conn->cc_recovery_data); |
| 270 | } | 326 | } |
| @@ -280,12 +336,11 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn) | |||
| 280 | BUG_ON(conn == NULL); | 336 | BUG_ON(conn == NULL); |
| 281 | BUG_ON(conn->cc_proto == NULL); | 337 | BUG_ON(conn->cc_proto == NULL); |
| 282 | 338 | ||
| 283 | /* for now we only have one cluster/node, make sure we see it | 339 | /* Ensure cluster stack is up and all nodes are connected */ |
| 284 | * in the heartbeat universe */ | 340 | rc = o2cb_cluster_check(); |
| 285 | if (!o2hb_check_local_node_heartbeating()) { | 341 | if (rc) { |
| 286 | if (o2hb_global_heartbeat_active()) | 342 | printk(KERN_ERR "o2cb: Cluster check failed. Fix errors " |
| 287 | mlog(ML_ERROR, "Global heartbeat not started\n"); | 343 | "before retrying.\n"); |
| 288 | rc = -EINVAL; | ||
| 289 | goto out; | 344 | goto out; |
| 290 | } | 345 | } |
| 291 | 346 | ||
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 56f61027236b..4994f8b0e604 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c | |||
| @@ -54,6 +54,7 @@ | |||
| 54 | #include "ocfs1_fs_compat.h" | 54 | #include "ocfs1_fs_compat.h" |
| 55 | 55 | ||
| 56 | #include "alloc.h" | 56 | #include "alloc.h" |
| 57 | #include "aops.h" | ||
| 57 | #include "blockcheck.h" | 58 | #include "blockcheck.h" |
| 58 | #include "dlmglue.h" | 59 | #include "dlmglue.h" |
| 59 | #include "export.h" | 60 | #include "export.h" |
| @@ -1107,9 +1108,9 @@ static int ocfs2_fill_super(struct super_block *sb, void *data, int silent) | |||
| 1107 | 1108 | ||
| 1108 | ocfs2_set_ro_flag(osb, 1); | 1109 | ocfs2_set_ro_flag(osb, 1); |
| 1109 | 1110 | ||
| 1110 | printk(KERN_NOTICE "Readonly device detected. No cluster " | 1111 | printk(KERN_NOTICE "ocfs2: Readonly device (%s) detected. " |
| 1111 | "services will be utilized for this mount. Recovery " | 1112 | "Cluster services will not be used for this mount. " |
| 1112 | "will be skipped.\n"); | 1113 | "Recovery will be skipped.\n", osb->dev_str); |
| 1113 | } | 1114 | } |
| 1114 | 1115 | ||
| 1115 | if (!ocfs2_is_hard_readonly(osb)) { | 1116 | if (!ocfs2_is_hard_readonly(osb)) { |
| @@ -1616,12 +1617,17 @@ static int ocfs2_show_options(struct seq_file *s, struct vfsmount *mnt) | |||
| 1616 | return 0; | 1617 | return 0; |
| 1617 | } | 1618 | } |
| 1618 | 1619 | ||
| 1620 | wait_queue_head_t ocfs2__ioend_wq[OCFS2_IOEND_WQ_HASH_SZ]; | ||
| 1621 | |||
| 1619 | static int __init ocfs2_init(void) | 1622 | static int __init ocfs2_init(void) |
| 1620 | { | 1623 | { |
| 1621 | int status; | 1624 | int status, i; |
| 1622 | 1625 | ||
| 1623 | ocfs2_print_version(); | 1626 | ocfs2_print_version(); |
| 1624 | 1627 | ||
| 1628 | for (i = 0; i < OCFS2_IOEND_WQ_HASH_SZ; i++) | ||
| 1629 | init_waitqueue_head(&ocfs2__ioend_wq[i]); | ||
| 1630 | |||
| 1625 | status = init_ocfs2_uptodate_cache(); | 1631 | status = init_ocfs2_uptodate_cache(); |
| 1626 | if (status < 0) { | 1632 | if (status < 0) { |
| 1627 | mlog_errno(status); | 1633 | mlog_errno(status); |
| @@ -1760,7 +1766,7 @@ static void ocfs2_inode_init_once(void *data) | |||
| 1760 | ocfs2_extent_map_init(&oi->vfs_inode); | 1766 | ocfs2_extent_map_init(&oi->vfs_inode); |
| 1761 | INIT_LIST_HEAD(&oi->ip_io_markers); | 1767 | INIT_LIST_HEAD(&oi->ip_io_markers); |
| 1762 | oi->ip_dir_start_lookup = 0; | 1768 | oi->ip_dir_start_lookup = 0; |
| 1763 | 1769 | atomic_set(&oi->ip_unaligned_aio, 0); | |
| 1764 | init_rwsem(&oi->ip_alloc_sem); | 1770 | init_rwsem(&oi->ip_alloc_sem); |
| 1765 | init_rwsem(&oi->ip_xattr_sem); | 1771 | init_rwsem(&oi->ip_xattr_sem); |
| 1766 | mutex_init(&oi->ip_io_mutex); | 1772 | mutex_init(&oi->ip_io_mutex); |
| @@ -1974,7 +1980,8 @@ static void ocfs2_dismount_volume(struct super_block *sb, int mnt_err) | |||
| 1974 | * If we failed before we got a uuid_str yet, we can't stop | 1980 | * If we failed before we got a uuid_str yet, we can't stop |
| 1975 | * heartbeat. Otherwise, do it. | 1981 | * heartbeat. Otherwise, do it. |
| 1976 | */ | 1982 | */ |
| 1977 | if (!mnt_err && !ocfs2_mount_local(osb) && osb->uuid_str) | 1983 | if (!mnt_err && !ocfs2_mount_local(osb) && osb->uuid_str && |
| 1984 | !ocfs2_is_hard_readonly(osb)) | ||
| 1978 | hangup_needed = 1; | 1985 | hangup_needed = 1; |
| 1979 | 1986 | ||
| 1980 | if (osb->cconn) | 1987 | if (osb->cconn) |
| @@ -2353,7 +2360,7 @@ static int ocfs2_initialize_super(struct super_block *sb, | |||
| 2353 | mlog_errno(status); | 2360 | mlog_errno(status); |
| 2354 | goto bail; | 2361 | goto bail; |
| 2355 | } | 2362 | } |
| 2356 | cleancache_init_shared_fs((char *)&uuid_net_key, sb); | 2363 | cleancache_init_shared_fs((char *)&di->id2.i_super.s_uuid, sb); |
| 2357 | 2364 | ||
| 2358 | bail: | 2365 | bail: |
| 2359 | return status; | 2366 | return status; |
| @@ -2462,8 +2469,8 @@ static int ocfs2_check_volume(struct ocfs2_super *osb) | |||
| 2462 | goto finally; | 2469 | goto finally; |
| 2463 | } | 2470 | } |
| 2464 | } else { | 2471 | } else { |
| 2465 | mlog(ML_NOTICE, "File system was not unmounted cleanly, " | 2472 | printk(KERN_NOTICE "ocfs2: File system on device (%s) was not " |
| 2466 | "recovering volume.\n"); | 2473 | "unmounted cleanly, recovering it.\n", osb->dev_str); |
| 2467 | } | 2474 | } |
| 2468 | 2475 | ||
| 2469 | local = ocfs2_mount_local(osb); | 2476 | local = ocfs2_mount_local(osb); |
diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c index 194fb22ef79d..aa9e8777b09a 100644 --- a/fs/ocfs2/xattr.c +++ b/fs/ocfs2/xattr.c | |||
| @@ -2376,16 +2376,18 @@ static int ocfs2_remove_value_outside(struct inode*inode, | |||
| 2376 | } | 2376 | } |
| 2377 | 2377 | ||
| 2378 | ret = ocfs2_xattr_value_truncate(inode, vb, 0, &ctxt); | 2378 | ret = ocfs2_xattr_value_truncate(inode, vb, 0, &ctxt); |
| 2379 | if (ret < 0) { | ||
| 2380 | mlog_errno(ret); | ||
| 2381 | break; | ||
| 2382 | } | ||
| 2383 | 2379 | ||
| 2384 | ocfs2_commit_trans(osb, ctxt.handle); | 2380 | ocfs2_commit_trans(osb, ctxt.handle); |
| 2385 | if (ctxt.meta_ac) { | 2381 | if (ctxt.meta_ac) { |
| 2386 | ocfs2_free_alloc_context(ctxt.meta_ac); | 2382 | ocfs2_free_alloc_context(ctxt.meta_ac); |
| 2387 | ctxt.meta_ac = NULL; | 2383 | ctxt.meta_ac = NULL; |
| 2388 | } | 2384 | } |
| 2385 | |||
| 2386 | if (ret < 0) { | ||
| 2387 | mlog_errno(ret); | ||
| 2388 | break; | ||
| 2389 | } | ||
| 2390 | |||
| 2389 | } | 2391 | } |
| 2390 | 2392 | ||
| 2391 | if (ctxt.meta_ac) | 2393 | if (ctxt.meta_ac) |
diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c index 586174168e2a..80e4645f7990 100644 --- a/fs/proc/meminfo.c +++ b/fs/proc/meminfo.c | |||
| @@ -131,12 +131,13 @@ static int meminfo_proc_show(struct seq_file *m, void *v) | |||
| 131 | K(i.freeswap), | 131 | K(i.freeswap), |
| 132 | K(global_page_state(NR_FILE_DIRTY)), | 132 | K(global_page_state(NR_FILE_DIRTY)), |
| 133 | K(global_page_state(NR_WRITEBACK)), | 133 | K(global_page_state(NR_WRITEBACK)), |
| 134 | K(global_page_state(NR_ANON_PAGES) | ||
| 135 | #ifdef CONFIG_TRANSPARENT_HUGEPAGE | 134 | #ifdef CONFIG_TRANSPARENT_HUGEPAGE |
| 135 | K(global_page_state(NR_ANON_PAGES) | ||
| 136 | + global_page_state(NR_ANON_TRANSPARENT_HUGEPAGES) * | 136 | + global_page_state(NR_ANON_TRANSPARENT_HUGEPAGES) * |
| 137 | HPAGE_PMD_NR | 137 | HPAGE_PMD_NR), |
| 138 | #else | ||
| 139 | K(global_page_state(NR_ANON_PAGES)), | ||
| 138 | #endif | 140 | #endif |
| 139 | ), | ||
| 140 | K(global_page_state(NR_FILE_MAPPED)), | 141 | K(global_page_state(NR_FILE_MAPPED)), |
| 141 | K(global_page_state(NR_SHMEM)), | 142 | K(global_page_state(NR_SHMEM)), |
| 142 | K(global_page_state(NR_SLAB_RECLAIMABLE) + | 143 | K(global_page_state(NR_SLAB_RECLAIMABLE) + |
diff --git a/fs/proc/root.c b/fs/proc/root.c index 9a8a2b77b874..03102d978180 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
| @@ -91,20 +91,18 @@ static struct file_system_type proc_fs_type = { | |||
| 91 | 91 | ||
| 92 | void __init proc_root_init(void) | 92 | void __init proc_root_init(void) |
| 93 | { | 93 | { |
| 94 | struct vfsmount *mnt; | ||
| 95 | int err; | 94 | int err; |
| 96 | 95 | ||
| 97 | proc_init_inodecache(); | 96 | proc_init_inodecache(); |
| 98 | err = register_filesystem(&proc_fs_type); | 97 | err = register_filesystem(&proc_fs_type); |
| 99 | if (err) | 98 | if (err) |
| 100 | return; | 99 | return; |
| 101 | mnt = kern_mount_data(&proc_fs_type, &init_pid_ns); | 100 | err = pid_ns_prepare_proc(&init_pid_ns); |
| 102 | if (IS_ERR(mnt)) { | 101 | if (err) { |
| 103 | unregister_filesystem(&proc_fs_type); | 102 | unregister_filesystem(&proc_fs_type); |
| 104 | return; | 103 | return; |
| 105 | } | 104 | } |
| 106 | 105 | ||
| 107 | init_pid_ns.proc_mnt = mnt; | ||
| 108 | proc_symlink("mounts", NULL, "self/mounts"); | 106 | proc_symlink("mounts", NULL, "self/mounts"); |
| 109 | 107 | ||
| 110 | proc_net_init(); | 108 | proc_net_init(); |
| @@ -209,5 +207,5 @@ int pid_ns_prepare_proc(struct pid_namespace *ns) | |||
| 209 | 207 | ||
| 210 | void pid_ns_release_proc(struct pid_namespace *ns) | 208 | void pid_ns_release_proc(struct pid_namespace *ns) |
| 211 | { | 209 | { |
| 212 | mntput(ns->proc_mnt); | 210 | kern_unmount(ns->proc_mnt); |
| 213 | } | 211 | } |
diff --git a/fs/proc/stat.c b/fs/proc/stat.c index 42b274da92c3..2a30d67dd6b8 100644 --- a/fs/proc/stat.c +++ b/fs/proc/stat.c | |||
| @@ -32,7 +32,7 @@ static cputime64_t get_idle_time(int cpu) | |||
| 32 | idle = kstat_cpu(cpu).cpustat.idle; | 32 | idle = kstat_cpu(cpu).cpustat.idle; |
| 33 | idle = cputime64_add(idle, arch_idle_time(cpu)); | 33 | idle = cputime64_add(idle, arch_idle_time(cpu)); |
| 34 | } else | 34 | } else |
| 35 | idle = usecs_to_cputime(idle_time); | 35 | idle = nsecs_to_jiffies64(1000 * idle_time); |
| 36 | 36 | ||
| 37 | return idle; | 37 | return idle; |
| 38 | } | 38 | } |
| @@ -46,7 +46,7 @@ static cputime64_t get_iowait_time(int cpu) | |||
| 46 | /* !NO_HZ so we can rely on cpustat.iowait */ | 46 | /* !NO_HZ so we can rely on cpustat.iowait */ |
| 47 | iowait = kstat_cpu(cpu).cpustat.iowait; | 47 | iowait = kstat_cpu(cpu).cpustat.iowait; |
| 48 | else | 48 | else |
| 49 | iowait = usecs_to_cputime(iowait_time); | 49 | iowait = nsecs_to_jiffies64(1000 * iowait_time); |
| 50 | 50 | ||
| 51 | return iowait; | 51 | return iowait; |
| 52 | } | 52 | } |
diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 2bd620f0d796..57bbf9078ac8 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c | |||
| @@ -167,6 +167,7 @@ int pstore_register(struct pstore_info *psi) | |||
| 167 | } | 167 | } |
| 168 | 168 | ||
| 169 | psinfo = psi; | 169 | psinfo = psi; |
| 170 | mutex_init(&psinfo->read_mutex); | ||
| 170 | spin_unlock(&pstore_lock); | 171 | spin_unlock(&pstore_lock); |
| 171 | 172 | ||
| 172 | if (owner && !try_module_get(owner)) { | 173 | if (owner && !try_module_get(owner)) { |
| @@ -195,30 +196,32 @@ EXPORT_SYMBOL_GPL(pstore_register); | |||
| 195 | void pstore_get_records(int quiet) | 196 | void pstore_get_records(int quiet) |
| 196 | { | 197 | { |
| 197 | struct pstore_info *psi = psinfo; | 198 | struct pstore_info *psi = psinfo; |
| 199 | char *buf = NULL; | ||
| 198 | ssize_t size; | 200 | ssize_t size; |
| 199 | u64 id; | 201 | u64 id; |
| 200 | enum pstore_type_id type; | 202 | enum pstore_type_id type; |
| 201 | struct timespec time; | 203 | struct timespec time; |
| 202 | int failed = 0, rc; | 204 | int failed = 0, rc; |
| 203 | unsigned long flags; | ||
| 204 | 205 | ||
| 205 | if (!psi) | 206 | if (!psi) |
| 206 | return; | 207 | return; |
| 207 | 208 | ||
| 208 | spin_lock_irqsave(&psinfo->buf_lock, flags); | 209 | mutex_lock(&psi->read_mutex); |
| 209 | rc = psi->open(psi); | 210 | rc = psi->open(psi); |
| 210 | if (rc) | 211 | if (rc) |
| 211 | goto out; | 212 | goto out; |
| 212 | 213 | ||
| 213 | while ((size = psi->read(&id, &type, &time, psi)) > 0) { | 214 | while ((size = psi->read(&id, &type, &time, &buf, psi)) > 0) { |
| 214 | rc = pstore_mkfile(type, psi->name, id, psi->buf, (size_t)size, | 215 | rc = pstore_mkfile(type, psi->name, id, buf, (size_t)size, |
| 215 | time, psi); | 216 | time, psi); |
| 217 | kfree(buf); | ||
| 218 | buf = NULL; | ||
| 216 | if (rc && (rc != -EEXIST || !quiet)) | 219 | if (rc && (rc != -EEXIST || !quiet)) |
| 217 | failed++; | 220 | failed++; |
| 218 | } | 221 | } |
| 219 | psi->close(psi); | 222 | psi->close(psi); |
| 220 | out: | 223 | out: |
| 221 | spin_unlock_irqrestore(&psinfo->buf_lock, flags); | 224 | mutex_unlock(&psi->read_mutex); |
| 222 | 225 | ||
| 223 | if (failed) | 226 | if (failed) |
| 224 | printk(KERN_WARNING "pstore: failed to load %d record(s) from '%s'\n", | 227 | printk(KERN_WARNING "pstore: failed to load %d record(s) from '%s'\n", |
diff --git a/fs/seq_file.c b/fs/seq_file.c index 05d6b0e78c95..dba43c3ea3af 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c | |||
| @@ -449,8 +449,6 @@ EXPORT_SYMBOL(seq_path); | |||
| 449 | 449 | ||
| 450 | /* | 450 | /* |
| 451 | * Same as seq_path, but relative to supplied root. | 451 | * Same as seq_path, but relative to supplied root. |
| 452 | * | ||
| 453 | * root may be changed, see __d_path(). | ||
| 454 | */ | 452 | */ |
| 455 | int seq_path_root(struct seq_file *m, struct path *path, struct path *root, | 453 | int seq_path_root(struct seq_file *m, struct path *path, struct path *root, |
| 456 | char *esc) | 454 | char *esc) |
| @@ -463,6 +461,8 @@ int seq_path_root(struct seq_file *m, struct path *path, struct path *root, | |||
| 463 | char *p; | 461 | char *p; |
| 464 | 462 | ||
| 465 | p = __d_path(path, root, buf, size); | 463 | p = __d_path(path, root, buf, size); |
| 464 | if (!p) | ||
| 465 | return SEQ_SKIP; | ||
| 466 | res = PTR_ERR(p); | 466 | res = PTR_ERR(p); |
| 467 | if (!IS_ERR(p)) { | 467 | if (!IS_ERR(p)) { |
| 468 | char *end = mangle_path(buf, p, esc); | 468 | char *end = mangle_path(buf, p, esc); |
| @@ -474,7 +474,7 @@ int seq_path_root(struct seq_file *m, struct path *path, struct path *root, | |||
| 474 | } | 474 | } |
| 475 | seq_commit(m, res); | 475 | seq_commit(m, res); |
| 476 | 476 | ||
| 477 | return res < 0 ? res : 0; | 477 | return res < 0 && res != -ENAMETOOLONG ? res : 0; |
| 478 | } | 478 | } |
| 479 | 479 | ||
| 480 | /* | 480 | /* |
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 20403dc5d437..ae0e76bb6ebf 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
| @@ -2264,19 +2264,12 @@ static int __init ubifs_init(void) | |||
| 2264 | return -EINVAL; | 2264 | return -EINVAL; |
| 2265 | } | 2265 | } |
| 2266 | 2266 | ||
| 2267 | err = register_filesystem(&ubifs_fs_type); | ||
| 2268 | if (err) { | ||
| 2269 | ubifs_err("cannot register file system, error %d", err); | ||
| 2270 | return err; | ||
| 2271 | } | ||
| 2272 | |||
| 2273 | err = -ENOMEM; | ||
| 2274 | ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab", | 2267 | ubifs_inode_slab = kmem_cache_create("ubifs_inode_slab", |
| 2275 | sizeof(struct ubifs_inode), 0, | 2268 | sizeof(struct ubifs_inode), 0, |
| 2276 | SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT, | 2269 | SLAB_MEM_SPREAD | SLAB_RECLAIM_ACCOUNT, |
| 2277 | &inode_slab_ctor); | 2270 | &inode_slab_ctor); |
| 2278 | if (!ubifs_inode_slab) | 2271 | if (!ubifs_inode_slab) |
| 2279 | goto out_reg; | 2272 | return -ENOMEM; |
| 2280 | 2273 | ||
| 2281 | register_shrinker(&ubifs_shrinker_info); | 2274 | register_shrinker(&ubifs_shrinker_info); |
| 2282 | 2275 | ||
| @@ -2288,15 +2281,20 @@ static int __init ubifs_init(void) | |||
| 2288 | if (err) | 2281 | if (err) |
| 2289 | goto out_compr; | 2282 | goto out_compr; |
| 2290 | 2283 | ||
| 2284 | err = register_filesystem(&ubifs_fs_type); | ||
| 2285 | if (err) { | ||
| 2286 | ubifs_err("cannot register file system, error %d", err); | ||
| 2287 | goto out_dbg; | ||
| 2288 | } | ||
| 2291 | return 0; | 2289 | return 0; |
| 2292 | 2290 | ||
| 2291 | out_dbg: | ||
| 2292 | dbg_debugfs_exit(); | ||
| 2293 | out_compr: | 2293 | out_compr: |
| 2294 | ubifs_compressors_exit(); | 2294 | ubifs_compressors_exit(); |
| 2295 | out_shrinker: | 2295 | out_shrinker: |
| 2296 | unregister_shrinker(&ubifs_shrinker_info); | 2296 | unregister_shrinker(&ubifs_shrinker_info); |
| 2297 | kmem_cache_destroy(ubifs_inode_slab); | 2297 | kmem_cache_destroy(ubifs_inode_slab); |
| 2298 | out_reg: | ||
| 2299 | unregister_filesystem(&ubifs_fs_type); | ||
| 2300 | return err; | 2298 | return err; |
| 2301 | } | 2299 | } |
| 2302 | /* late_initcall to let compressors initialize first */ | 2300 | /* late_initcall to let compressors initialize first */ |
diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs_acl.c index b6c4b3795c4a..76e4266d2e7e 100644 --- a/fs/xfs/xfs_acl.c +++ b/fs/xfs/xfs_acl.c | |||
| @@ -42,6 +42,8 @@ xfs_acl_from_disk(struct xfs_acl *aclp) | |||
| 42 | int count, i; | 42 | int count, i; |
| 43 | 43 | ||
| 44 | count = be32_to_cpu(aclp->acl_cnt); | 44 | count = be32_to_cpu(aclp->acl_cnt); |
| 45 | if (count > XFS_ACL_MAX_ENTRIES) | ||
| 46 | return ERR_PTR(-EFSCORRUPTED); | ||
| 45 | 47 | ||
| 46 | acl = posix_acl_alloc(count, GFP_KERNEL); | 48 | acl = posix_acl_alloc(count, GFP_KERNEL); |
| 47 | if (!acl) | 49 | if (!acl) |
diff --git a/fs/xfs/xfs_attr_leaf.c b/fs/xfs/xfs_attr_leaf.c index d4906e7c9787..c1b55e596551 100644 --- a/fs/xfs/xfs_attr_leaf.c +++ b/fs/xfs/xfs_attr_leaf.c | |||
| @@ -110,6 +110,7 @@ xfs_attr_namesp_match(int arg_flags, int ondisk_flags) | |||
| 110 | /* | 110 | /* |
| 111 | * Query whether the requested number of additional bytes of extended | 111 | * Query whether the requested number of additional bytes of extended |
| 112 | * attribute space will be able to fit inline. | 112 | * attribute space will be able to fit inline. |
| 113 | * | ||
| 113 | * Returns zero if not, else the di_forkoff fork offset to be used in the | 114 | * Returns zero if not, else the di_forkoff fork offset to be used in the |
| 114 | * literal area for attribute data once the new bytes have been added. | 115 | * literal area for attribute data once the new bytes have been added. |
| 115 | * | 116 | * |
| @@ -122,7 +123,7 @@ xfs_attr_shortform_bytesfit(xfs_inode_t *dp, int bytes) | |||
| 122 | int offset; | 123 | int offset; |
| 123 | int minforkoff; /* lower limit on valid forkoff locations */ | 124 | int minforkoff; /* lower limit on valid forkoff locations */ |
| 124 | int maxforkoff; /* upper limit on valid forkoff locations */ | 125 | int maxforkoff; /* upper limit on valid forkoff locations */ |
| 125 | int dsize; | 126 | int dsize; |
| 126 | xfs_mount_t *mp = dp->i_mount; | 127 | xfs_mount_t *mp = dp->i_mount; |
| 127 | 128 | ||
| 128 | offset = (XFS_LITINO(mp) - bytes) >> 3; /* rounded down */ | 129 | offset = (XFS_LITINO(mp) - bytes) >> 3; /* rounded down */ |
| @@ -136,47 +137,60 @@ xfs_attr_shortform_bytesfit(xfs_inode_t *dp, int bytes) | |||
| 136 | return (offset >= minforkoff) ? minforkoff : 0; | 137 | return (offset >= minforkoff) ? minforkoff : 0; |
| 137 | } | 138 | } |
| 138 | 139 | ||
| 139 | if (!(mp->m_flags & XFS_MOUNT_ATTR2)) { | 140 | /* |
| 140 | if (bytes <= XFS_IFORK_ASIZE(dp)) | 141 | * If the requested numbers of bytes is smaller or equal to the |
| 141 | return dp->i_d.di_forkoff; | 142 | * current attribute fork size we can always proceed. |
| 143 | * | ||
| 144 | * Note that if_bytes in the data fork might actually be larger than | ||
| 145 | * the current data fork size is due to delalloc extents. In that | ||
| 146 | * case either the extent count will go down when they are converted | ||
| 147 | * to real extents, or the delalloc conversion will take care of the | ||
| 148 | * literal area rebalancing. | ||
| 149 | */ | ||
| 150 | if (bytes <= XFS_IFORK_ASIZE(dp)) | ||
| 151 | return dp->i_d.di_forkoff; | ||
| 152 | |||
| 153 | /* | ||
| 154 | * For attr2 we can try to move the forkoff if there is space in the | ||
| 155 | * literal area, but for the old format we are done if there is no | ||
| 156 | * space in the fixed attribute fork. | ||
| 157 | */ | ||
| 158 | if (!(mp->m_flags & XFS_MOUNT_ATTR2)) | ||
| 142 | return 0; | 159 | return 0; |
| 143 | } | ||
| 144 | 160 | ||
| 145 | dsize = dp->i_df.if_bytes; | 161 | dsize = dp->i_df.if_bytes; |
| 146 | 162 | ||
| 147 | switch (dp->i_d.di_format) { | 163 | switch (dp->i_d.di_format) { |
| 148 | case XFS_DINODE_FMT_EXTENTS: | 164 | case XFS_DINODE_FMT_EXTENTS: |
| 149 | /* | 165 | /* |
| 150 | * If there is no attr fork and the data fork is extents, | 166 | * If there is no attr fork and the data fork is extents, |
| 151 | * determine if creating the default attr fork will result | 167 | * determine if creating the default attr fork will result |
| 152 | * in the extents form migrating to btree. If so, the | 168 | * in the extents form migrating to btree. If so, the |
| 153 | * minimum offset only needs to be the space required for | 169 | * minimum offset only needs to be the space required for |
| 154 | * the btree root. | 170 | * the btree root. |
| 155 | */ | 171 | */ |
| 156 | if (!dp->i_d.di_forkoff && dp->i_df.if_bytes > | 172 | if (!dp->i_d.di_forkoff && dp->i_df.if_bytes > |
| 157 | xfs_default_attroffset(dp)) | 173 | xfs_default_attroffset(dp)) |
| 158 | dsize = XFS_BMDR_SPACE_CALC(MINDBTPTRS); | 174 | dsize = XFS_BMDR_SPACE_CALC(MINDBTPTRS); |
| 159 | break; | 175 | break; |
| 160 | |||
| 161 | case XFS_DINODE_FMT_BTREE: | 176 | case XFS_DINODE_FMT_BTREE: |
| 162 | /* | 177 | /* |
| 163 | * If have data btree then keep forkoff if we have one, | 178 | * If we have a data btree then keep forkoff if we have one, |
| 164 | * otherwise we are adding a new attr, so then we set | 179 | * otherwise we are adding a new attr, so then we set |
| 165 | * minforkoff to where the btree root can finish so we have | 180 | * minforkoff to where the btree root can finish so we have |
| 166 | * plenty of room for attrs | 181 | * plenty of room for attrs |
| 167 | */ | 182 | */ |
| 168 | if (dp->i_d.di_forkoff) { | 183 | if (dp->i_d.di_forkoff) { |
| 169 | if (offset < dp->i_d.di_forkoff) | 184 | if (offset < dp->i_d.di_forkoff) |
| 170 | return 0; | 185 | return 0; |
| 171 | else | 186 | return dp->i_d.di_forkoff; |
| 172 | return dp->i_d.di_forkoff; | 187 | } |
| 173 | } else | 188 | dsize = XFS_BMAP_BROOT_SPACE(dp->i_df.if_broot); |
| 174 | dsize = XFS_BMAP_BROOT_SPACE(dp->i_df.if_broot); | ||
| 175 | break; | 189 | break; |
| 176 | } | 190 | } |
| 177 | 191 | ||
| 178 | /* | 192 | /* |
| 179 | * A data fork btree root must have space for at least | 193 | * A data fork btree root must have space for at least |
| 180 | * MINDBTPTRS key/ptr pairs if the data fork is small or empty. | 194 | * MINDBTPTRS key/ptr pairs if the data fork is small or empty. |
| 181 | */ | 195 | */ |
| 182 | minforkoff = MAX(dsize, XFS_BMDR_SPACE_CALC(MINDBTPTRS)); | 196 | minforkoff = MAX(dsize, XFS_BMDR_SPACE_CALC(MINDBTPTRS)); |
| @@ -186,10 +200,10 @@ xfs_attr_shortform_bytesfit(xfs_inode_t *dp, int bytes) | |||
| 186 | maxforkoff = XFS_LITINO(mp) - XFS_BMDR_SPACE_CALC(MINABTPTRS); | 200 | maxforkoff = XFS_LITINO(mp) - XFS_BMDR_SPACE_CALC(MINABTPTRS); |
| 187 | maxforkoff = maxforkoff >> 3; /* rounded down */ | 201 | maxforkoff = maxforkoff >> 3; /* rounded down */ |
| 188 | 202 | ||
| 189 | if (offset >= minforkoff && offset < maxforkoff) | ||
| 190 | return offset; | ||
| 191 | if (offset >= maxforkoff) | 203 | if (offset >= maxforkoff) |
| 192 | return maxforkoff; | 204 | return maxforkoff; |
| 205 | if (offset >= minforkoff) | ||
| 206 | return offset; | ||
| 193 | return 0; | 207 | return 0; |
| 194 | } | 208 | } |
| 195 | 209 | ||
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c index c68baeb0974a..d0ab78837057 100644 --- a/fs/xfs/xfs_bmap.c +++ b/fs/xfs/xfs_bmap.c | |||
| @@ -2383,6 +2383,8 @@ xfs_bmap_btalloc( | |||
| 2383 | int tryagain; | 2383 | int tryagain; |
| 2384 | int error; | 2384 | int error; |
| 2385 | 2385 | ||
| 2386 | ASSERT(ap->length); | ||
| 2387 | |||
| 2386 | mp = ap->ip->i_mount; | 2388 | mp = ap->ip->i_mount; |
| 2387 | align = ap->userdata ? xfs_get_extsz_hint(ap->ip) : 0; | 2389 | align = ap->userdata ? xfs_get_extsz_hint(ap->ip) : 0; |
| 2388 | if (unlikely(align)) { | 2390 | if (unlikely(align)) { |
| @@ -4629,6 +4631,8 @@ xfs_bmapi_allocate( | |||
| 4629 | int error; | 4631 | int error; |
| 4630 | int rt; | 4632 | int rt; |
| 4631 | 4633 | ||
| 4634 | ASSERT(bma->length > 0); | ||
| 4635 | |||
| 4632 | rt = (whichfork == XFS_DATA_FORK) && XFS_IS_REALTIME_INODE(bma->ip); | 4636 | rt = (whichfork == XFS_DATA_FORK) && XFS_IS_REALTIME_INODE(bma->ip); |
| 4633 | 4637 | ||
| 4634 | /* | 4638 | /* |
| @@ -4849,6 +4853,7 @@ xfs_bmapi_write( | |||
| 4849 | ASSERT(*nmap <= XFS_BMAP_MAX_NMAP); | 4853 | ASSERT(*nmap <= XFS_BMAP_MAX_NMAP); |
| 4850 | ASSERT(!(flags & XFS_BMAPI_IGSTATE)); | 4854 | ASSERT(!(flags & XFS_BMAPI_IGSTATE)); |
| 4851 | ASSERT(tp != NULL); | 4855 | ASSERT(tp != NULL); |
| 4856 | ASSERT(len > 0); | ||
| 4852 | 4857 | ||
| 4853 | whichfork = (flags & XFS_BMAPI_ATTRFORK) ? | 4858 | whichfork = (flags & XFS_BMAPI_ATTRFORK) ? |
| 4854 | XFS_ATTR_FORK : XFS_DATA_FORK; | 4859 | XFS_ATTR_FORK : XFS_DATA_FORK; |
| @@ -4918,9 +4923,22 @@ xfs_bmapi_write( | |||
| 4918 | bma.eof = eof; | 4923 | bma.eof = eof; |
| 4919 | bma.conv = !!(flags & XFS_BMAPI_CONVERT); | 4924 | bma.conv = !!(flags & XFS_BMAPI_CONVERT); |
| 4920 | bma.wasdel = wasdelay; | 4925 | bma.wasdel = wasdelay; |
| 4921 | bma.length = len; | ||
| 4922 | bma.offset = bno; | 4926 | bma.offset = bno; |
| 4923 | 4927 | ||
| 4928 | /* | ||
| 4929 | * There's a 32/64 bit type mismatch between the | ||
| 4930 | * allocation length request (which can be 64 bits in | ||
| 4931 | * length) and the bma length request, which is | ||
| 4932 | * xfs_extlen_t and therefore 32 bits. Hence we have to | ||
| 4933 | * check for 32-bit overflows and handle them here. | ||
| 4934 | */ | ||
| 4935 | if (len > (xfs_filblks_t)MAXEXTLEN) | ||
| 4936 | bma.length = MAXEXTLEN; | ||
| 4937 | else | ||
| 4938 | bma.length = len; | ||
| 4939 | |||
| 4940 | ASSERT(len > 0); | ||
| 4941 | ASSERT(bma.length > 0); | ||
| 4924 | error = xfs_bmapi_allocate(&bma, flags); | 4942 | error = xfs_bmapi_allocate(&bma, flags); |
| 4925 | if (error) | 4943 | if (error) |
| 4926 | goto error0; | 4944 | goto error0; |
diff --git a/fs/xfs/xfs_export.c b/fs/xfs/xfs_export.c index da108977b21f..558910f5e3c0 100644 --- a/fs/xfs/xfs_export.c +++ b/fs/xfs/xfs_export.c | |||
| @@ -98,22 +98,22 @@ xfs_fs_encode_fh( | |||
| 98 | switch (fileid_type) { | 98 | switch (fileid_type) { |
| 99 | case FILEID_INO32_GEN_PARENT: | 99 | case FILEID_INO32_GEN_PARENT: |
| 100 | spin_lock(&dentry->d_lock); | 100 | spin_lock(&dentry->d_lock); |
| 101 | fid->i32.parent_ino = dentry->d_parent->d_inode->i_ino; | 101 | fid->i32.parent_ino = XFS_I(dentry->d_parent->d_inode)->i_ino; |
| 102 | fid->i32.parent_gen = dentry->d_parent->d_inode->i_generation; | 102 | fid->i32.parent_gen = dentry->d_parent->d_inode->i_generation; |
| 103 | spin_unlock(&dentry->d_lock); | 103 | spin_unlock(&dentry->d_lock); |
| 104 | /*FALLTHRU*/ | 104 | /*FALLTHRU*/ |
| 105 | case FILEID_INO32_GEN: | 105 | case FILEID_INO32_GEN: |
| 106 | fid->i32.ino = inode->i_ino; | 106 | fid->i32.ino = XFS_I(inode)->i_ino; |
| 107 | fid->i32.gen = inode->i_generation; | 107 | fid->i32.gen = inode->i_generation; |
| 108 | break; | 108 | break; |
| 109 | case FILEID_INO32_GEN_PARENT | XFS_FILEID_TYPE_64FLAG: | 109 | case FILEID_INO32_GEN_PARENT | XFS_FILEID_TYPE_64FLAG: |
| 110 | spin_lock(&dentry->d_lock); | 110 | spin_lock(&dentry->d_lock); |
| 111 | fid64->parent_ino = dentry->d_parent->d_inode->i_ino; | 111 | fid64->parent_ino = XFS_I(dentry->d_parent->d_inode)->i_ino; |
| 112 | fid64->parent_gen = dentry->d_parent->d_inode->i_generation; | 112 | fid64->parent_gen = dentry->d_parent->d_inode->i_generation; |
| 113 | spin_unlock(&dentry->d_lock); | 113 | spin_unlock(&dentry->d_lock); |
| 114 | /*FALLTHRU*/ | 114 | /*FALLTHRU*/ |
| 115 | case FILEID_INO32_GEN | XFS_FILEID_TYPE_64FLAG: | 115 | case FILEID_INO32_GEN | XFS_FILEID_TYPE_64FLAG: |
| 116 | fid64->ino = inode->i_ino; | 116 | fid64->ino = XFS_I(inode)->i_ino; |
| 117 | fid64->gen = inode->i_generation; | 117 | fid64->gen = inode->i_generation; |
| 118 | break; | 118 | break; |
| 119 | } | 119 | } |
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index c0237c602f11..755ee8164880 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c | |||
| @@ -2835,6 +2835,27 @@ corrupt_out: | |||
| 2835 | return XFS_ERROR(EFSCORRUPTED); | 2835 | return XFS_ERROR(EFSCORRUPTED); |
| 2836 | } | 2836 | } |
| 2837 | 2837 | ||
| 2838 | void | ||
| 2839 | xfs_promote_inode( | ||
| 2840 | struct xfs_inode *ip) | ||
| 2841 | { | ||
| 2842 | struct xfs_buf *bp; | ||
| 2843 | |||
| 2844 | ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL|XFS_ILOCK_SHARED)); | ||
| 2845 | |||
| 2846 | bp = xfs_incore(ip->i_mount->m_ddev_targp, ip->i_imap.im_blkno, | ||
| 2847 | ip->i_imap.im_len, XBF_TRYLOCK); | ||
| 2848 | if (!bp) | ||
| 2849 | return; | ||
| 2850 | |||
| 2851 | if (XFS_BUF_ISDELAYWRITE(bp)) { | ||
| 2852 | xfs_buf_delwri_promote(bp); | ||
| 2853 | wake_up_process(ip->i_mount->m_ddev_targp->bt_task); | ||
| 2854 | } | ||
| 2855 | |||
| 2856 | xfs_buf_relse(bp); | ||
| 2857 | } | ||
| 2858 | |||
| 2838 | /* | 2859 | /* |
| 2839 | * Return a pointer to the extent record at file index idx. | 2860 | * Return a pointer to the extent record at file index idx. |
| 2840 | */ | 2861 | */ |
diff --git a/fs/xfs/xfs_inode.h b/fs/xfs/xfs_inode.h index 760140d1dd66..b4cd4739f98e 100644 --- a/fs/xfs/xfs_inode.h +++ b/fs/xfs/xfs_inode.h | |||
| @@ -498,6 +498,7 @@ int xfs_iunlink(struct xfs_trans *, xfs_inode_t *); | |||
| 498 | void xfs_iext_realloc(xfs_inode_t *, int, int); | 498 | void xfs_iext_realloc(xfs_inode_t *, int, int); |
| 499 | void xfs_iunpin_wait(xfs_inode_t *); | 499 | void xfs_iunpin_wait(xfs_inode_t *); |
| 500 | int xfs_iflush(xfs_inode_t *, uint); | 500 | int xfs_iflush(xfs_inode_t *, uint); |
| 501 | void xfs_promote_inode(struct xfs_inode *); | ||
| 501 | void xfs_lock_inodes(xfs_inode_t **, int, uint); | 502 | void xfs_lock_inodes(xfs_inode_t **, int, uint); |
| 502 | void xfs_lock_two_inodes(xfs_inode_t *, xfs_inode_t *, uint); | 503 | void xfs_lock_two_inodes(xfs_inode_t *, xfs_inode_t *, uint); |
| 503 | 504 | ||
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index a14cd89fe465..34817adf4b9e 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c | |||
| @@ -150,6 +150,117 @@ xlog_grant_add_space( | |||
| 150 | } while (head_val != old); | 150 | } while (head_val != old); |
| 151 | } | 151 | } |
| 152 | 152 | ||
| 153 | STATIC bool | ||
| 154 | xlog_reserveq_wake( | ||
| 155 | struct log *log, | ||
| 156 | int *free_bytes) | ||
| 157 | { | ||
| 158 | struct xlog_ticket *tic; | ||
| 159 | int need_bytes; | ||
| 160 | |||
| 161 | list_for_each_entry(tic, &log->l_reserveq, t_queue) { | ||
| 162 | if (tic->t_flags & XLOG_TIC_PERM_RESERV) | ||
| 163 | need_bytes = tic->t_unit_res * tic->t_cnt; | ||
| 164 | else | ||
| 165 | need_bytes = tic->t_unit_res; | ||
| 166 | |||
| 167 | if (*free_bytes < need_bytes) | ||
| 168 | return false; | ||
| 169 | *free_bytes -= need_bytes; | ||
| 170 | |||
| 171 | trace_xfs_log_grant_wake_up(log, tic); | ||
| 172 | wake_up(&tic->t_wait); | ||
| 173 | } | ||
| 174 | |||
| 175 | return true; | ||
| 176 | } | ||
| 177 | |||
| 178 | STATIC bool | ||
| 179 | xlog_writeq_wake( | ||
| 180 | struct log *log, | ||
| 181 | int *free_bytes) | ||
| 182 | { | ||
| 183 | struct xlog_ticket *tic; | ||
| 184 | int need_bytes; | ||
| 185 | |||
| 186 | list_for_each_entry(tic, &log->l_writeq, t_queue) { | ||
| 187 | ASSERT(tic->t_flags & XLOG_TIC_PERM_RESERV); | ||
| 188 | |||
| 189 | need_bytes = tic->t_unit_res; | ||
| 190 | |||
| 191 | if (*free_bytes < need_bytes) | ||
| 192 | return false; | ||
| 193 | *free_bytes -= need_bytes; | ||
| 194 | |||
| 195 | trace_xfs_log_regrant_write_wake_up(log, tic); | ||
| 196 | wake_up(&tic->t_wait); | ||
| 197 | } | ||
| 198 | |||
| 199 | return true; | ||
| 200 | } | ||
| 201 | |||
| 202 | STATIC int | ||
| 203 | xlog_reserveq_wait( | ||
| 204 | struct log *log, | ||
| 205 | struct xlog_ticket *tic, | ||
| 206 | int need_bytes) | ||
| 207 | { | ||
| 208 | list_add_tail(&tic->t_queue, &log->l_reserveq); | ||
| 209 | |||
| 210 | do { | ||
| 211 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 212 | goto shutdown; | ||
| 213 | xlog_grant_push_ail(log, need_bytes); | ||
| 214 | |||
| 215 | XFS_STATS_INC(xs_sleep_logspace); | ||
| 216 | trace_xfs_log_grant_sleep(log, tic); | ||
| 217 | |||
| 218 | xlog_wait(&tic->t_wait, &log->l_grant_reserve_lock); | ||
| 219 | trace_xfs_log_grant_wake(log, tic); | ||
| 220 | |||
| 221 | spin_lock(&log->l_grant_reserve_lock); | ||
| 222 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 223 | goto shutdown; | ||
| 224 | } while (xlog_space_left(log, &log->l_grant_reserve_head) < need_bytes); | ||
| 225 | |||
| 226 | list_del_init(&tic->t_queue); | ||
| 227 | return 0; | ||
| 228 | shutdown: | ||
| 229 | list_del_init(&tic->t_queue); | ||
| 230 | return XFS_ERROR(EIO); | ||
| 231 | } | ||
| 232 | |||
| 233 | STATIC int | ||
| 234 | xlog_writeq_wait( | ||
| 235 | struct log *log, | ||
| 236 | struct xlog_ticket *tic, | ||
| 237 | int need_bytes) | ||
| 238 | { | ||
| 239 | list_add_tail(&tic->t_queue, &log->l_writeq); | ||
| 240 | |||
| 241 | do { | ||
| 242 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 243 | goto shutdown; | ||
| 244 | xlog_grant_push_ail(log, need_bytes); | ||
| 245 | |||
| 246 | XFS_STATS_INC(xs_sleep_logspace); | ||
| 247 | trace_xfs_log_regrant_write_sleep(log, tic); | ||
| 248 | |||
| 249 | xlog_wait(&tic->t_wait, &log->l_grant_write_lock); | ||
| 250 | trace_xfs_log_regrant_write_wake(log, tic); | ||
| 251 | |||
| 252 | spin_lock(&log->l_grant_write_lock); | ||
| 253 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 254 | goto shutdown; | ||
| 255 | } while (xlog_space_left(log, &log->l_grant_write_head) < need_bytes); | ||
| 256 | |||
| 257 | list_del_init(&tic->t_queue); | ||
| 258 | return 0; | ||
| 259 | shutdown: | ||
| 260 | list_del_init(&tic->t_queue); | ||
| 261 | return XFS_ERROR(EIO); | ||
| 262 | } | ||
| 263 | |||
| 153 | static void | 264 | static void |
| 154 | xlog_tic_reset_res(xlog_ticket_t *tic) | 265 | xlog_tic_reset_res(xlog_ticket_t *tic) |
| 155 | { | 266 | { |
| @@ -350,8 +461,19 @@ xfs_log_reserve( | |||
| 350 | retval = xlog_grant_log_space(log, internal_ticket); | 461 | retval = xlog_grant_log_space(log, internal_ticket); |
| 351 | } | 462 | } |
| 352 | 463 | ||
| 464 | if (unlikely(retval)) { | ||
| 465 | /* | ||
| 466 | * If we are failing, make sure the ticket doesn't have any | ||
| 467 | * current reservations. We don't want to add this back | ||
| 468 | * when the ticket/ transaction gets cancelled. | ||
| 469 | */ | ||
| 470 | internal_ticket->t_curr_res = 0; | ||
| 471 | /* ungrant will give back unit_res * t_cnt. */ | ||
| 472 | internal_ticket->t_cnt = 0; | ||
| 473 | } | ||
| 474 | |||
| 353 | return retval; | 475 | return retval; |
| 354 | } /* xfs_log_reserve */ | 476 | } |
| 355 | 477 | ||
| 356 | 478 | ||
| 357 | /* | 479 | /* |
| @@ -2481,8 +2603,8 @@ restart: | |||
| 2481 | /* | 2603 | /* |
| 2482 | * Atomically get the log space required for a log ticket. | 2604 | * Atomically get the log space required for a log ticket. |
| 2483 | * | 2605 | * |
| 2484 | * Once a ticket gets put onto the reserveq, it will only return after | 2606 | * Once a ticket gets put onto the reserveq, it will only return after the |
| 2485 | * the needed reservation is satisfied. | 2607 | * needed reservation is satisfied. |
| 2486 | * | 2608 | * |
| 2487 | * This function is structured so that it has a lock free fast path. This is | 2609 | * This function is structured so that it has a lock free fast path. This is |
| 2488 | * necessary because every new transaction reservation will come through this | 2610 | * necessary because every new transaction reservation will come through this |
| @@ -2490,113 +2612,53 @@ restart: | |||
| 2490 | * every pass. | 2612 | * every pass. |
| 2491 | * | 2613 | * |
| 2492 | * As tickets are only ever moved on and off the reserveq under the | 2614 | * As tickets are only ever moved on and off the reserveq under the |
| 2493 | * l_grant_reserve_lock, we only need to take that lock if we are going | 2615 | * l_grant_reserve_lock, we only need to take that lock if we are going to add |
| 2494 | * to add the ticket to the queue and sleep. We can avoid taking the lock if the | 2616 | * the ticket to the queue and sleep. We can avoid taking the lock if the ticket |
| 2495 | * ticket was never added to the reserveq because the t_queue list head will be | 2617 | * was never added to the reserveq because the t_queue list head will be empty |
| 2496 | * empty and we hold the only reference to it so it can safely be checked | 2618 | * and we hold the only reference to it so it can safely be checked unlocked. |
| 2497 | * unlocked. | ||
| 2498 | */ | 2619 | */ |
| 2499 | STATIC int | 2620 | STATIC int |
| 2500 | xlog_grant_log_space(xlog_t *log, | 2621 | xlog_grant_log_space( |
| 2501 | xlog_ticket_t *tic) | 2622 | struct log *log, |
| 2623 | struct xlog_ticket *tic) | ||
| 2502 | { | 2624 | { |
| 2503 | int free_bytes; | 2625 | int free_bytes, need_bytes; |
| 2504 | int need_bytes; | 2626 | int error = 0; |
| 2505 | 2627 | ||
| 2506 | #ifdef DEBUG | 2628 | ASSERT(!(log->l_flags & XLOG_ACTIVE_RECOVERY)); |
| 2507 | if (log->l_flags & XLOG_ACTIVE_RECOVERY) | ||
| 2508 | panic("grant Recovery problem"); | ||
| 2509 | #endif | ||
| 2510 | 2629 | ||
| 2511 | trace_xfs_log_grant_enter(log, tic); | 2630 | trace_xfs_log_grant_enter(log, tic); |
| 2512 | 2631 | ||
| 2632 | /* | ||
| 2633 | * If there are other waiters on the queue then give them a chance at | ||
| 2634 | * logspace before us. Wake up the first waiters, if we do not wake | ||
| 2635 | * up all the waiters then go to sleep waiting for more free space, | ||
| 2636 | * otherwise try to get some space for this transaction. | ||
| 2637 | */ | ||
| 2513 | need_bytes = tic->t_unit_res; | 2638 | need_bytes = tic->t_unit_res; |
| 2514 | if (tic->t_flags & XFS_LOG_PERM_RESERV) | 2639 | if (tic->t_flags & XFS_LOG_PERM_RESERV) |
| 2515 | need_bytes *= tic->t_ocnt; | 2640 | need_bytes *= tic->t_ocnt; |
| 2516 | |||
| 2517 | /* something is already sleeping; insert new transaction at end */ | ||
| 2518 | if (!list_empty_careful(&log->l_reserveq)) { | ||
| 2519 | spin_lock(&log->l_grant_reserve_lock); | ||
| 2520 | /* recheck the queue now we are locked */ | ||
| 2521 | if (list_empty(&log->l_reserveq)) { | ||
| 2522 | spin_unlock(&log->l_grant_reserve_lock); | ||
| 2523 | goto redo; | ||
| 2524 | } | ||
| 2525 | list_add_tail(&tic->t_queue, &log->l_reserveq); | ||
| 2526 | |||
| 2527 | trace_xfs_log_grant_sleep1(log, tic); | ||
| 2528 | |||
| 2529 | /* | ||
| 2530 | * Gotta check this before going to sleep, while we're | ||
| 2531 | * holding the grant lock. | ||
| 2532 | */ | ||
| 2533 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 2534 | goto error_return; | ||
| 2535 | |||
| 2536 | XFS_STATS_INC(xs_sleep_logspace); | ||
| 2537 | xlog_wait(&tic->t_wait, &log->l_grant_reserve_lock); | ||
| 2538 | |||
| 2539 | /* | ||
| 2540 | * If we got an error, and the filesystem is shutting down, | ||
| 2541 | * we'll catch it down below. So just continue... | ||
| 2542 | */ | ||
| 2543 | trace_xfs_log_grant_wake1(log, tic); | ||
| 2544 | } | ||
| 2545 | |||
| 2546 | redo: | ||
| 2547 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 2548 | goto error_return_unlocked; | ||
| 2549 | |||
| 2550 | free_bytes = xlog_space_left(log, &log->l_grant_reserve_head); | 2641 | free_bytes = xlog_space_left(log, &log->l_grant_reserve_head); |
| 2551 | if (free_bytes < need_bytes) { | 2642 | if (!list_empty_careful(&log->l_reserveq)) { |
| 2552 | spin_lock(&log->l_grant_reserve_lock); | 2643 | spin_lock(&log->l_grant_reserve_lock); |
| 2553 | if (list_empty(&tic->t_queue)) | 2644 | if (!xlog_reserveq_wake(log, &free_bytes) || |
| 2554 | list_add_tail(&tic->t_queue, &log->l_reserveq); | 2645 | free_bytes < need_bytes) |
| 2555 | 2646 | error = xlog_reserveq_wait(log, tic, need_bytes); | |
| 2556 | trace_xfs_log_grant_sleep2(log, tic); | 2647 | spin_unlock(&log->l_grant_reserve_lock); |
| 2557 | 2648 | } else if (free_bytes < need_bytes) { | |
| 2558 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 2559 | goto error_return; | ||
| 2560 | |||
| 2561 | xlog_grant_push_ail(log, need_bytes); | ||
| 2562 | |||
| 2563 | XFS_STATS_INC(xs_sleep_logspace); | ||
| 2564 | xlog_wait(&tic->t_wait, &log->l_grant_reserve_lock); | ||
| 2565 | |||
| 2566 | trace_xfs_log_grant_wake2(log, tic); | ||
| 2567 | goto redo; | ||
| 2568 | } | ||
| 2569 | |||
| 2570 | if (!list_empty(&tic->t_queue)) { | ||
| 2571 | spin_lock(&log->l_grant_reserve_lock); | 2649 | spin_lock(&log->l_grant_reserve_lock); |
| 2572 | list_del_init(&tic->t_queue); | 2650 | error = xlog_reserveq_wait(log, tic, need_bytes); |
| 2573 | spin_unlock(&log->l_grant_reserve_lock); | 2651 | spin_unlock(&log->l_grant_reserve_lock); |
| 2574 | } | 2652 | } |
| 2653 | if (error) | ||
| 2654 | return error; | ||
| 2575 | 2655 | ||
| 2576 | /* we've got enough space */ | ||
| 2577 | xlog_grant_add_space(log, &log->l_grant_reserve_head, need_bytes); | 2656 | xlog_grant_add_space(log, &log->l_grant_reserve_head, need_bytes); |
| 2578 | xlog_grant_add_space(log, &log->l_grant_write_head, need_bytes); | 2657 | xlog_grant_add_space(log, &log->l_grant_write_head, need_bytes); |
| 2579 | trace_xfs_log_grant_exit(log, tic); | 2658 | trace_xfs_log_grant_exit(log, tic); |
| 2580 | xlog_verify_grant_tail(log); | 2659 | xlog_verify_grant_tail(log); |
| 2581 | return 0; | 2660 | return 0; |
| 2582 | 2661 | } | |
| 2583 | error_return_unlocked: | ||
| 2584 | spin_lock(&log->l_grant_reserve_lock); | ||
| 2585 | error_return: | ||
| 2586 | list_del_init(&tic->t_queue); | ||
| 2587 | spin_unlock(&log->l_grant_reserve_lock); | ||
| 2588 | trace_xfs_log_grant_error(log, tic); | ||
| 2589 | |||
| 2590 | /* | ||
| 2591 | * If we are failing, make sure the ticket doesn't have any | ||
| 2592 | * current reservations. We don't want to add this back when | ||
| 2593 | * the ticket/transaction gets cancelled. | ||
| 2594 | */ | ||
| 2595 | tic->t_curr_res = 0; | ||
| 2596 | tic->t_cnt = 0; /* ungrant will give back unit_res * t_cnt. */ | ||
| 2597 | return XFS_ERROR(EIO); | ||
| 2598 | } /* xlog_grant_log_space */ | ||
| 2599 | |||
| 2600 | 2662 | ||
| 2601 | /* | 2663 | /* |
| 2602 | * Replenish the byte reservation required by moving the grant write head. | 2664 | * Replenish the byte reservation required by moving the grant write head. |
| @@ -2605,10 +2667,12 @@ error_return: | |||
| 2605 | * free fast path. | 2667 | * free fast path. |
| 2606 | */ | 2668 | */ |
| 2607 | STATIC int | 2669 | STATIC int |
| 2608 | xlog_regrant_write_log_space(xlog_t *log, | 2670 | xlog_regrant_write_log_space( |
| 2609 | xlog_ticket_t *tic) | 2671 | struct log *log, |
| 2672 | struct xlog_ticket *tic) | ||
| 2610 | { | 2673 | { |
| 2611 | int free_bytes, need_bytes; | 2674 | int free_bytes, need_bytes; |
| 2675 | int error = 0; | ||
| 2612 | 2676 | ||
| 2613 | tic->t_curr_res = tic->t_unit_res; | 2677 | tic->t_curr_res = tic->t_unit_res; |
| 2614 | xlog_tic_reset_res(tic); | 2678 | xlog_tic_reset_res(tic); |
| @@ -2616,104 +2680,38 @@ xlog_regrant_write_log_space(xlog_t *log, | |||
| 2616 | if (tic->t_cnt > 0) | 2680 | if (tic->t_cnt > 0) |
| 2617 | return 0; | 2681 | return 0; |
| 2618 | 2682 | ||
| 2619 | #ifdef DEBUG | 2683 | ASSERT(!(log->l_flags & XLOG_ACTIVE_RECOVERY)); |
| 2620 | if (log->l_flags & XLOG_ACTIVE_RECOVERY) | ||
| 2621 | panic("regrant Recovery problem"); | ||
| 2622 | #endif | ||
| 2623 | 2684 | ||
| 2624 | trace_xfs_log_regrant_write_enter(log, tic); | 2685 | trace_xfs_log_regrant_write_enter(log, tic); |
| 2625 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 2626 | goto error_return_unlocked; | ||
| 2627 | 2686 | ||
| 2628 | /* If there are other waiters on the queue then give them a | 2687 | /* |
| 2629 | * chance at logspace before us. Wake up the first waiters, | 2688 | * If there are other waiters on the queue then give them a chance at |
| 2630 | * if we do not wake up all the waiters then go to sleep waiting | 2689 | * logspace before us. Wake up the first waiters, if we do not wake |
| 2631 | * for more free space, otherwise try to get some space for | 2690 | * up all the waiters then go to sleep waiting for more free space, |
| 2632 | * this transaction. | 2691 | * otherwise try to get some space for this transaction. |
| 2633 | */ | 2692 | */ |
| 2634 | need_bytes = tic->t_unit_res; | 2693 | need_bytes = tic->t_unit_res; |
| 2635 | if (!list_empty_careful(&log->l_writeq)) { | ||
| 2636 | struct xlog_ticket *ntic; | ||
| 2637 | |||
| 2638 | spin_lock(&log->l_grant_write_lock); | ||
| 2639 | free_bytes = xlog_space_left(log, &log->l_grant_write_head); | ||
| 2640 | list_for_each_entry(ntic, &log->l_writeq, t_queue) { | ||
| 2641 | ASSERT(ntic->t_flags & XLOG_TIC_PERM_RESERV); | ||
| 2642 | |||
| 2643 | if (free_bytes < ntic->t_unit_res) | ||
| 2644 | break; | ||
| 2645 | free_bytes -= ntic->t_unit_res; | ||
| 2646 | wake_up(&ntic->t_wait); | ||
| 2647 | } | ||
| 2648 | |||
| 2649 | if (ntic != list_first_entry(&log->l_writeq, | ||
| 2650 | struct xlog_ticket, t_queue)) { | ||
| 2651 | if (list_empty(&tic->t_queue)) | ||
| 2652 | list_add_tail(&tic->t_queue, &log->l_writeq); | ||
| 2653 | trace_xfs_log_regrant_write_sleep1(log, tic); | ||
| 2654 | |||
| 2655 | xlog_grant_push_ail(log, need_bytes); | ||
| 2656 | |||
| 2657 | XFS_STATS_INC(xs_sleep_logspace); | ||
| 2658 | xlog_wait(&tic->t_wait, &log->l_grant_write_lock); | ||
| 2659 | trace_xfs_log_regrant_write_wake1(log, tic); | ||
| 2660 | } else | ||
| 2661 | spin_unlock(&log->l_grant_write_lock); | ||
| 2662 | } | ||
| 2663 | |||
| 2664 | redo: | ||
| 2665 | if (XLOG_FORCED_SHUTDOWN(log)) | ||
| 2666 | goto error_return_unlocked; | ||
| 2667 | |||
| 2668 | free_bytes = xlog_space_left(log, &log->l_grant_write_head); | 2694 | free_bytes = xlog_space_left(log, &log->l_grant_write_head); |
| 2669 | if (free_bytes < need_bytes) { | 2695 | if (!list_empty_careful(&log->l_writeq)) { |
| 2670 | spin_lock(&log->l_grant_write_lock); | 2696 | spin_lock(&log->l_grant_write_lock); |
| 2671 | if (list_empty(&tic->t_queue)) | 2697 | if (!xlog_writeq_wake(log, &free_bytes) || |
| 2672 | list_add_tail(&tic->t_queue, &log->l_writeq); | 2698 | free_bytes < need_bytes) |
| 2673 | 2699 | error = xlog_writeq_wait(log, tic, need_bytes); | |
| 2674 | if (XLOG_FORCED_SHUTDOWN(log)) | 2700 | spin_unlock(&log->l_grant_write_lock); |
| 2675 | goto error_return; | 2701 | } else if (free_bytes < need_bytes) { |
| 2676 | |||
| 2677 | xlog_grant_push_ail(log, need_bytes); | ||
| 2678 | |||
| 2679 | XFS_STATS_INC(xs_sleep_logspace); | ||
| 2680 | trace_xfs_log_regrant_write_sleep2(log, tic); | ||
| 2681 | xlog_wait(&tic->t_wait, &log->l_grant_write_lock); | ||
| 2682 | |||
| 2683 | trace_xfs_log_regrant_write_wake2(log, tic); | ||
| 2684 | goto redo; | ||
| 2685 | } | ||
| 2686 | |||
| 2687 | if (!list_empty(&tic->t_queue)) { | ||
| 2688 | spin_lock(&log->l_grant_write_lock); | 2702 | spin_lock(&log->l_grant_write_lock); |
| 2689 | list_del_init(&tic->t_queue); | 2703 | error = xlog_writeq_wait(log, tic, need_bytes); |
| 2690 | spin_unlock(&log->l_grant_write_lock); | 2704 | spin_unlock(&log->l_grant_write_lock); |
| 2691 | } | 2705 | } |
| 2692 | 2706 | ||
| 2693 | /* we've got enough space */ | 2707 | if (error) |
| 2708 | return error; | ||
| 2709 | |||
| 2694 | xlog_grant_add_space(log, &log->l_grant_write_head, need_bytes); | 2710 | xlog_grant_add_space(log, &log->l_grant_write_head, need_bytes); |
| 2695 | trace_xfs_log_regrant_write_exit(log, tic); | 2711 | trace_xfs_log_regrant_write_exit(log, tic); |
| 2696 | xlog_verify_grant_tail(log); | 2712 | xlog_verify_grant_tail(log); |
| 2697 | return 0; | 2713 | return 0; |
| 2698 | 2714 | } | |
| 2699 | |||
| 2700 | error_return_unlocked: | ||
| 2701 | spin_lock(&log->l_grant_write_lock); | ||
| 2702 | error_return: | ||
| 2703 | list_del_init(&tic->t_queue); | ||
| 2704 | spin_unlock(&log->l_grant_write_lock); | ||
| 2705 | trace_xfs_log_regrant_write_error(log, tic); | ||
| 2706 | |||
| 2707 | /* | ||
| 2708 | * If we are failing, make sure the ticket doesn't have any | ||
| 2709 | * current reservations. We don't want to add this back when | ||
| 2710 | * the ticket/transaction gets cancelled. | ||
| 2711 | */ | ||
| 2712 | tic->t_curr_res = 0; | ||
| 2713 | tic->t_cnt = 0; /* ungrant will give back unit_res * t_cnt. */ | ||
| 2714 | return XFS_ERROR(EIO); | ||
| 2715 | } /* xlog_regrant_write_log_space */ | ||
| 2716 | |||
| 2717 | 2715 | ||
| 2718 | /* The first cnt-1 times through here we don't need to | 2716 | /* The first cnt-1 times through here we don't need to |
| 2719 | * move the grant write head because the permanent | 2717 | * move the grant write head because the permanent |
diff --git a/fs/xfs/xfs_sync.c b/fs/xfs/xfs_sync.c index aa3dc1a4d53d..be5c51d8f757 100644 --- a/fs/xfs/xfs_sync.c +++ b/fs/xfs/xfs_sync.c | |||
| @@ -770,6 +770,17 @@ restart: | |||
| 770 | if (!xfs_iflock_nowait(ip)) { | 770 | if (!xfs_iflock_nowait(ip)) { |
| 771 | if (!(sync_mode & SYNC_WAIT)) | 771 | if (!(sync_mode & SYNC_WAIT)) |
| 772 | goto out; | 772 | goto out; |
| 773 | |||
| 774 | /* | ||
| 775 | * If we only have a single dirty inode in a cluster there is | ||
| 776 | * a fair chance that the AIL push may have pushed it into | ||
| 777 | * the buffer, but xfsbufd won't touch it until 30 seconds | ||
| 778 | * from now, and thus we will lock up here. | ||
| 779 | * | ||
| 780 | * Promote the inode buffer to the front of the delwri list | ||
| 781 | * and wake up xfsbufd now. | ||
| 782 | */ | ||
| 783 | xfs_promote_inode(ip); | ||
| 773 | xfs_iflock(ip); | 784 | xfs_iflock(ip); |
| 774 | } | 785 | } |
| 775 | 786 | ||
diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h index f1d2802b2f07..494035798873 100644 --- a/fs/xfs/xfs_trace.h +++ b/fs/xfs/xfs_trace.h | |||
| @@ -834,18 +834,14 @@ DEFINE_LOGGRANT_EVENT(xfs_log_umount_write); | |||
| 834 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_enter); | 834 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_enter); |
| 835 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_exit); | 835 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_exit); |
| 836 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_error); | 836 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_error); |
| 837 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_sleep1); | 837 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_sleep); |
| 838 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake1); | 838 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake); |
| 839 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_sleep2); | ||
| 840 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake2); | ||
| 841 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake_up); | 839 | DEFINE_LOGGRANT_EVENT(xfs_log_grant_wake_up); |
| 842 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_enter); | 840 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_enter); |
| 843 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_exit); | 841 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_exit); |
| 844 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_error); | 842 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_error); |
| 845 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_sleep1); | 843 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_sleep); |
| 846 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake1); | 844 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake); |
| 847 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_sleep2); | ||
| 848 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake2); | ||
| 849 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake_up); | 845 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_write_wake_up); |
| 850 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_enter); | 846 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_enter); |
| 851 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_exit); | 847 | DEFINE_LOGGRANT_EVENT(xfs_log_regrant_reserve_exit); |
diff --git a/include/asm-generic/unistd.h b/include/asm-generic/unistd.h index f4c38d8c6674..2292d1af9d70 100644 --- a/include/asm-generic/unistd.h +++ b/include/asm-generic/unistd.h | |||
| @@ -685,9 +685,15 @@ __SYSCALL(__NR_syncfs, sys_syncfs) | |||
| 685 | __SYSCALL(__NR_setns, sys_setns) | 685 | __SYSCALL(__NR_setns, sys_setns) |
| 686 | #define __NR_sendmmsg 269 | 686 | #define __NR_sendmmsg 269 |
| 687 | __SC_COMP(__NR_sendmmsg, sys_sendmmsg, compat_sys_sendmmsg) | 687 | __SC_COMP(__NR_sendmmsg, sys_sendmmsg, compat_sys_sendmmsg) |
| 688 | #define __NR_process_vm_readv 270 | ||
| 689 | __SC_COMP(__NR_process_vm_readv, sys_process_vm_readv, \ | ||
| 690 | compat_sys_process_vm_readv) | ||
| 691 | #define __NR_process_vm_writev 271 | ||
| 692 | __SC_COMP(__NR_process_vm_writev, sys_process_vm_writev, \ | ||
| 693 | compat_sys_process_vm_writev) | ||
| 688 | 694 | ||
| 689 | #undef __NR_syscalls | 695 | #undef __NR_syscalls |
| 690 | #define __NR_syscalls 270 | 696 | #define __NR_syscalls 272 |
| 691 | 697 | ||
| 692 | /* | 698 | /* |
| 693 | * All syscalls below here should go away really, | 699 | * All syscalls below here should go away really, |
diff --git a/include/drm/drm_pciids.h b/include/drm/drm_pciids.h index f81676f1b310..14b6cd022284 100644 --- a/include/drm/drm_pciids.h +++ b/include/drm/drm_pciids.h | |||
| @@ -182,8 +182,11 @@ | |||
| 182 | {0x1002, 0x6748, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | 182 | {0x1002, 0x6748, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ |
| 183 | {0x1002, 0x6749, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | 183 | {0x1002, 0x6749, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ |
| 184 | {0x1002, 0x6750, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | 184 | {0x1002, 0x6750, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ |
| 185 | {0x1002, 0x6751, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 185 | {0x1002, 0x6758, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | 186 | {0x1002, 0x6758, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ |
| 186 | {0x1002, 0x6759, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | 187 | {0x1002, 0x6759, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ |
| 188 | {0x1002, 0x675B, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 189 | {0x1002, 0x675D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 187 | {0x1002, 0x675F, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | 190 | {0x1002, 0x675F, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ |
| 188 | {0x1002, 0x6760, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | 191 | {0x1002, 0x6760, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ |
| 189 | {0x1002, 0x6761, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | 192 | {0x1002, 0x6761, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ |
| @@ -195,8 +198,18 @@ | |||
| 195 | {0x1002, 0x6767, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | 198 | {0x1002, 0x6767, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ |
| 196 | {0x1002, 0x6768, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | 199 | {0x1002, 0x6768, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ |
| 197 | {0x1002, 0x6770, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | 200 | {0x1002, 0x6770, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ |
| 201 | {0x1002, 0x6772, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | ||
| 198 | {0x1002, 0x6778, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | 202 | {0x1002, 0x6778, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ |
| 199 | {0x1002, 0x6779, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | 203 | {0x1002, 0x6779, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ |
| 204 | {0x1002, 0x677B, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CAICOS|RADEON_NEW_MEMMAP}, \ | ||
| 205 | {0x1002, 0x6840, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | ||
| 206 | {0x1002, 0x6841, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | ||
| 207 | {0x1002, 0x6842, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | ||
| 208 | {0x1002, 0x6843, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | ||
| 209 | {0x1002, 0x6849, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 210 | {0x1002, 0x6850, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 211 | {0x1002, 0x6858, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 212 | {0x1002, 0x6859, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_TURKS|RADEON_NEW_MEMMAP}, \ | ||
| 200 | {0x1002, 0x6880, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CYPRESS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | 213 | {0x1002, 0x6880, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CYPRESS|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ |
| 201 | {0x1002, 0x6888, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CYPRESS|RADEON_NEW_MEMMAP}, \ | 214 | {0x1002, 0x6888, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CYPRESS|RADEON_NEW_MEMMAP}, \ |
| 202 | {0x1002, 0x6889, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CYPRESS|RADEON_NEW_MEMMAP}, \ | 215 | {0x1002, 0x6889, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CYPRESS|RADEON_NEW_MEMMAP}, \ |
| @@ -238,6 +251,7 @@ | |||
| 238 | {0x1002, 0x68f2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ | 251 | {0x1002, 0x68f2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ |
| 239 | {0x1002, 0x68f8, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ | 252 | {0x1002, 0x68f8, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ |
| 240 | {0x1002, 0x68f9, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ | 253 | {0x1002, 0x68f9, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ |
| 254 | {0x1002, 0x68fa, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ | ||
| 241 | {0x1002, 0x68fe, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ | 255 | {0x1002, 0x68fe, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_CEDAR|RADEON_NEW_MEMMAP}, \ |
| 242 | {0x1002, 0x7100, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_R520|RADEON_NEW_MEMMAP}, \ | 256 | {0x1002, 0x7100, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_R520|RADEON_NEW_MEMMAP}, \ |
| 243 | {0x1002, 0x7101, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_R520|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ | 257 | {0x1002, 0x7101, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_R520|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ |
| @@ -480,6 +494,8 @@ | |||
| 480 | {0x1002, 0x9647, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ | 494 | {0x1002, 0x9647, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ |
| 481 | {0x1002, 0x9648, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ | 495 | {0x1002, 0x9648, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ |
| 482 | {0x1002, 0x964a, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | 496 | {0x1002, 0x964a, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ |
| 497 | {0x1002, 0x964b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | ||
| 498 | {0x1002, 0x964c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | ||
| 483 | {0x1002, 0x964e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ | 499 | {0x1002, 0x964e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ |
| 484 | {0x1002, 0x964f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ | 500 | {0x1002, 0x964f, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_SUMO|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP},\ |
| 485 | {0x1002, 0x9710, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | 501 | {0x1002, 0x9710, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_RS880|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ |
| @@ -494,6 +510,8 @@ | |||
| 494 | {0x1002, 0x9805, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | 510 | {0x1002, 0x9805, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ |
| 495 | {0x1002, 0x9806, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | 511 | {0x1002, 0x9806, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ |
| 496 | {0x1002, 0x9807, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | 512 | {0x1002, 0x9807, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ |
| 513 | {0x1002, 0x9808, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | ||
| 514 | {0x1002, 0x9809, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PALM|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ | ||
| 497 | {0, 0, 0} | 515 | {0, 0, 0} |
| 498 | 516 | ||
| 499 | #define r128_PCI_IDS \ | 517 | #define r128_PCI_IDS \ |
diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h index 1d161cb3aca5..12050434d57a 100644 --- a/include/drm/exynos_drm.h +++ b/include/drm/exynos_drm.h | |||
| @@ -32,17 +32,16 @@ | |||
| 32 | /** | 32 | /** |
| 33 | * User-desired buffer creation information structure. | 33 | * User-desired buffer creation information structure. |
| 34 | * | 34 | * |
| 35 | * @size: requested size for the object. | 35 | * @size: user-desired memory allocation size. |
| 36 | * - this size value would be page-aligned internally. | 36 | * - this size value would be page-aligned internally. |
| 37 | * @flags: user request for setting memory type or cache attributes. | 37 | * @flags: user request for setting memory type or cache attributes. |
| 38 | * @handle: returned handle for the object. | 38 | * @handle: returned a handle to created gem object. |
| 39 | * @pad: just padding to be 64-bit aligned. | 39 | * - this handle will be set by gem module of kernel side. |
| 40 | */ | 40 | */ |
| 41 | struct drm_exynos_gem_create { | 41 | struct drm_exynos_gem_create { |
| 42 | unsigned int size; | 42 | uint64_t size; |
| 43 | unsigned int flags; | 43 | unsigned int flags; |
| 44 | unsigned int handle; | 44 | unsigned int handle; |
| 45 | unsigned int pad; | ||
| 46 | }; | 45 | }; |
| 47 | 46 | ||
| 48 | /** | 47 | /** |
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index c7a6d3b5bc7b..94acd8172b5b 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h | |||
| @@ -805,9 +805,6 @@ extern void blk_unprep_request(struct request *); | |||
| 805 | */ | 805 | */ |
| 806 | extern struct request_queue *blk_init_queue_node(request_fn_proc *rfn, | 806 | extern struct request_queue *blk_init_queue_node(request_fn_proc *rfn, |
| 807 | spinlock_t *lock, int node_id); | 807 | spinlock_t *lock, int node_id); |
| 808 | extern struct request_queue *blk_init_allocated_queue_node(struct request_queue *, | ||
| 809 | request_fn_proc *, | ||
| 810 | spinlock_t *, int node_id); | ||
| 811 | extern struct request_queue *blk_init_queue(request_fn_proc *, spinlock_t *); | 808 | extern struct request_queue *blk_init_queue(request_fn_proc *, spinlock_t *); |
| 812 | extern struct request_queue *blk_init_allocated_queue(struct request_queue *, | 809 | extern struct request_queue *blk_init_allocated_queue(struct request_queue *, |
| 813 | request_fn_proc *, spinlock_t *); | 810 | request_fn_proc *, spinlock_t *); |
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 139c4db55f17..c86c940d1de3 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h | |||
| @@ -156,6 +156,7 @@ extern u64 timecounter_cyc2time(struct timecounter *tc, | |||
| 156 | * @mult: cycle to nanosecond multiplier | 156 | * @mult: cycle to nanosecond multiplier |
| 157 | * @shift: cycle to nanosecond divisor (power of two) | 157 | * @shift: cycle to nanosecond divisor (power of two) |
| 158 | * @max_idle_ns: max idle time permitted by the clocksource (nsecs) | 158 | * @max_idle_ns: max idle time permitted by the clocksource (nsecs) |
| 159 | * @maxadj maximum adjustment value to mult (~11%) | ||
| 159 | * @flags: flags describing special properties | 160 | * @flags: flags describing special properties |
| 160 | * @archdata: arch-specific data | 161 | * @archdata: arch-specific data |
| 161 | * @suspend: suspend function for the clocksource, if necessary | 162 | * @suspend: suspend function for the clocksource, if necessary |
| @@ -172,7 +173,7 @@ struct clocksource { | |||
| 172 | u32 mult; | 173 | u32 mult; |
| 173 | u32 shift; | 174 | u32 shift; |
| 174 | u64 max_idle_ns; | 175 | u64 max_idle_ns; |
| 175 | 176 | u32 maxadj; | |
| 176 | #ifdef CONFIG_ARCH_CLOCKSOURCE_DATA | 177 | #ifdef CONFIG_ARCH_CLOCKSOURCE_DATA |
| 177 | struct arch_clocksource_data archdata; | 178 | struct arch_clocksource_data archdata; |
| 178 | #endif | 179 | #endif |
diff --git a/include/linux/compat.h b/include/linux/compat.h index 154bf5683015..66ed067fb729 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h | |||
| @@ -552,5 +552,14 @@ extern ssize_t compat_rw_copy_check_uvector(int type, | |||
| 552 | 552 | ||
| 553 | extern void __user *compat_alloc_user_space(unsigned long len); | 553 | extern void __user *compat_alloc_user_space(unsigned long len); |
| 554 | 554 | ||
| 555 | asmlinkage ssize_t compat_sys_process_vm_readv(compat_pid_t pid, | ||
| 556 | const struct compat_iovec __user *lvec, | ||
| 557 | unsigned long liovcnt, const struct compat_iovec __user *rvec, | ||
| 558 | unsigned long riovcnt, unsigned long flags); | ||
| 559 | asmlinkage ssize_t compat_sys_process_vm_writev(compat_pid_t pid, | ||
| 560 | const struct compat_iovec __user *lvec, | ||
| 561 | unsigned long liovcnt, const struct compat_iovec __user *rvec, | ||
| 562 | unsigned long riovcnt, unsigned long flags); | ||
| 563 | |||
| 555 | #endif /* CONFIG_COMPAT */ | 564 | #endif /* CONFIG_COMPAT */ |
| 556 | #endif /* _LINUX_COMPAT_H */ | 565 | #endif /* _LINUX_COMPAT_H */ |
diff --git a/include/linux/dcache.h b/include/linux/dcache.h index 4df926199369..ed9f74f6c519 100644 --- a/include/linux/dcache.h +++ b/include/linux/dcache.h | |||
| @@ -339,7 +339,8 @@ extern int d_validate(struct dentry *, struct dentry *); | |||
| 339 | */ | 339 | */ |
| 340 | extern char *dynamic_dname(struct dentry *, char *, int, const char *, ...); | 340 | extern char *dynamic_dname(struct dentry *, char *, int, const char *, ...); |
| 341 | 341 | ||
| 342 | extern char *__d_path(const struct path *path, struct path *root, char *, int); | 342 | extern char *__d_path(const struct path *, const struct path *, char *, int); |
| 343 | extern char *d_absolute_path(const struct path *, char *, int); | ||
| 343 | extern char *d_path(const struct path *, char *, int); | 344 | extern char *d_path(const struct path *, char *, int); |
| 344 | extern char *d_path_with_unreachable(const struct path *, char *, int); | 345 | extern char *d_path_with_unreachable(const struct path *, char *, int); |
| 345 | extern char *dentry_path_raw(struct dentry *, char *, int); | 346 | extern char *dentry_path_raw(struct dentry *, char *, int); |
diff --git a/include/linux/dma_remapping.h b/include/linux/dma_remapping.h index ef90cbd8e173..57c9a8ae4f2d 100644 --- a/include/linux/dma_remapping.h +++ b/include/linux/dma_remapping.h | |||
| @@ -31,6 +31,7 @@ extern void free_dmar_iommu(struct intel_iommu *iommu); | |||
| 31 | extern int iommu_calculate_agaw(struct intel_iommu *iommu); | 31 | extern int iommu_calculate_agaw(struct intel_iommu *iommu); |
| 32 | extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu); | 32 | extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu); |
| 33 | extern int dmar_disabled; | 33 | extern int dmar_disabled; |
| 34 | extern int intel_iommu_enabled; | ||
| 34 | #else | 35 | #else |
| 35 | static inline int iommu_calculate_agaw(struct intel_iommu *iommu) | 36 | static inline int iommu_calculate_agaw(struct intel_iommu *iommu) |
| 36 | { | 37 | { |
| @@ -44,6 +45,7 @@ static inline void free_dmar_iommu(struct intel_iommu *iommu) | |||
| 44 | { | 45 | { |
| 45 | } | 46 | } |
| 46 | #define dmar_disabled (1) | 47 | #define dmar_disabled (1) |
| 48 | #define intel_iommu_enabled (0) | ||
| 47 | #endif | 49 | #endif |
| 48 | 50 | ||
| 49 | 51 | ||
diff --git a/include/linux/fs.h b/include/linux/fs.h index e3130220ce3e..e0bc4ffb8e7f 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h | |||
| @@ -393,8 +393,8 @@ struct inodes_stat_t { | |||
| 393 | #include <linux/semaphore.h> | 393 | #include <linux/semaphore.h> |
| 394 | #include <linux/fiemap.h> | 394 | #include <linux/fiemap.h> |
| 395 | #include <linux/rculist_bl.h> | 395 | #include <linux/rculist_bl.h> |
| 396 | #include <linux/shrinker.h> | ||
| 397 | #include <linux/atomic.h> | 396 | #include <linux/atomic.h> |
| 397 | #include <linux/shrinker.h> | ||
| 398 | 398 | ||
| 399 | #include <asm/byteorder.h> | 399 | #include <asm/byteorder.h> |
| 400 | 400 | ||
| @@ -1942,6 +1942,7 @@ extern int fd_statfs(int, struct kstatfs *); | |||
| 1942 | extern int statfs_by_dentry(struct dentry *, struct kstatfs *); | 1942 | extern int statfs_by_dentry(struct dentry *, struct kstatfs *); |
| 1943 | extern int freeze_super(struct super_block *super); | 1943 | extern int freeze_super(struct super_block *super); |
| 1944 | extern int thaw_super(struct super_block *super); | 1944 | extern int thaw_super(struct super_block *super); |
| 1945 | extern bool our_mnt(struct vfsmount *mnt); | ||
| 1945 | 1946 | ||
| 1946 | extern int current_umask(void); | 1947 | extern int current_umask(void); |
| 1947 | 1948 | ||
diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h index 96efa6794ea5..c3da42dd22ba 100644 --- a/include/linux/ftrace_event.h +++ b/include/linux/ftrace_event.h | |||
| @@ -172,6 +172,7 @@ enum { | |||
| 172 | TRACE_EVENT_FL_FILTERED_BIT, | 172 | TRACE_EVENT_FL_FILTERED_BIT, |
| 173 | TRACE_EVENT_FL_RECORDED_CMD_BIT, | 173 | TRACE_EVENT_FL_RECORDED_CMD_BIT, |
| 174 | TRACE_EVENT_FL_CAP_ANY_BIT, | 174 | TRACE_EVENT_FL_CAP_ANY_BIT, |
| 175 | TRACE_EVENT_FL_NO_SET_FILTER_BIT, | ||
| 175 | }; | 176 | }; |
| 176 | 177 | ||
| 177 | enum { | 178 | enum { |
| @@ -179,6 +180,7 @@ enum { | |||
| 179 | TRACE_EVENT_FL_FILTERED = (1 << TRACE_EVENT_FL_FILTERED_BIT), | 180 | TRACE_EVENT_FL_FILTERED = (1 << TRACE_EVENT_FL_FILTERED_BIT), |
| 180 | TRACE_EVENT_FL_RECORDED_CMD = (1 << TRACE_EVENT_FL_RECORDED_CMD_BIT), | 181 | TRACE_EVENT_FL_RECORDED_CMD = (1 << TRACE_EVENT_FL_RECORDED_CMD_BIT), |
| 181 | TRACE_EVENT_FL_CAP_ANY = (1 << TRACE_EVENT_FL_CAP_ANY_BIT), | 182 | TRACE_EVENT_FL_CAP_ANY = (1 << TRACE_EVENT_FL_CAP_ANY_BIT), |
| 183 | TRACE_EVENT_FL_NO_SET_FILTER = (1 << TRACE_EVENT_FL_NO_SET_FILTER_BIT), | ||
| 182 | }; | 184 | }; |
| 183 | 185 | ||
| 184 | struct ftrace_event_call { | 186 | struct ftrace_event_call { |
diff --git a/include/linux/init_task.h b/include/linux/init_task.h index 94b1e356c02a..32574eef9394 100644 --- a/include/linux/init_task.h +++ b/include/linux/init_task.h | |||
| @@ -126,6 +126,8 @@ extern struct cred init_cred; | |||
| 126 | # define INIT_PERF_EVENTS(tsk) | 126 | # define INIT_PERF_EVENTS(tsk) |
| 127 | #endif | 127 | #endif |
| 128 | 128 | ||
| 129 | #define INIT_TASK_COMM "swapper" | ||
| 130 | |||
| 129 | /* | 131 | /* |
| 130 | * INIT_TASK is used to set up the first task table, touch at | 132 | * INIT_TASK is used to set up the first task table, touch at |
| 131 | * your own risk!. Base=0, limit=0x1fffff (=2MB) | 133 | * your own risk!. Base=0, limit=0x1fffff (=2MB) |
| @@ -162,7 +164,7 @@ extern struct cred init_cred; | |||
| 162 | .group_leader = &tsk, \ | 164 | .group_leader = &tsk, \ |
| 163 | RCU_INIT_POINTER(.real_cred, &init_cred), \ | 165 | RCU_INIT_POINTER(.real_cred, &init_cred), \ |
| 164 | RCU_INIT_POINTER(.cred, &init_cred), \ | 166 | RCU_INIT_POINTER(.cred, &init_cred), \ |
| 165 | .comm = "swapper", \ | 167 | .comm = INIT_TASK_COMM, \ |
| 166 | .thread = INIT_THREAD, \ | 168 | .thread = INIT_THREAD, \ |
| 167 | .fs = &init_fs, \ | 169 | .fs = &init_fs, \ |
| 168 | .files = &init_files, \ | 170 | .files = &init_files, \ |
diff --git a/include/linux/log2.h b/include/linux/log2.h index 25b808631cd9..fd7ff3d91e6a 100644 --- a/include/linux/log2.h +++ b/include/linux/log2.h | |||
| @@ -185,7 +185,6 @@ unsigned long __rounddown_pow_of_two(unsigned long n) | |||
| 185 | #define rounddown_pow_of_two(n) \ | 185 | #define rounddown_pow_of_two(n) \ |
| 186 | ( \ | 186 | ( \ |
| 187 | __builtin_constant_p(n) ? ( \ | 187 | __builtin_constant_p(n) ? ( \ |
| 188 | (n == 1) ? 0 : \ | ||
| 189 | (1UL << ilog2(n))) : \ | 188 | (1UL << ilog2(n))) : \ |
| 190 | __rounddown_pow_of_two(n) \ | 189 | __rounddown_pow_of_two(n) \ |
| 191 | ) | 190 | ) |
diff --git a/include/linux/mm.h b/include/linux/mm.h index 3dc3a8c2c485..4baadd18f4ad 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h | |||
| @@ -10,6 +10,7 @@ | |||
| 10 | #include <linux/mmzone.h> | 10 | #include <linux/mmzone.h> |
| 11 | #include <linux/rbtree.h> | 11 | #include <linux/rbtree.h> |
| 12 | #include <linux/prio_tree.h> | 12 | #include <linux/prio_tree.h> |
| 13 | #include <linux/atomic.h> | ||
| 13 | #include <linux/debug_locks.h> | 14 | #include <linux/debug_locks.h> |
| 14 | #include <linux/mm_types.h> | 15 | #include <linux/mm_types.h> |
| 15 | #include <linux/range.h> | 16 | #include <linux/range.h> |
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index 415f2db414e1..c8ef9bc54d50 100644 --- a/include/linux/mmc/card.h +++ b/include/linux/mmc/card.h | |||
| @@ -218,6 +218,7 @@ struct mmc_card { | |||
| 218 | #define MMC_QUIRK_INAND_CMD38 (1<<6) /* iNAND devices have broken CMD38 */ | 218 | #define MMC_QUIRK_INAND_CMD38 (1<<6) /* iNAND devices have broken CMD38 */ |
| 219 | #define MMC_QUIRK_BLK_NO_CMD23 (1<<7) /* Avoid CMD23 for regular multiblock */ | 219 | #define MMC_QUIRK_BLK_NO_CMD23 (1<<7) /* Avoid CMD23 for regular multiblock */ |
| 220 | #define MMC_QUIRK_BROKEN_BYTE_MODE_512 (1<<8) /* Avoid sending 512 bytes in */ | 220 | #define MMC_QUIRK_BROKEN_BYTE_MODE_512 (1<<8) /* Avoid sending 512 bytes in */ |
| 221 | #define MMC_QUIRK_LONG_READ_TIME (1<<9) /* Data read time > CSD says */ | ||
| 221 | /* byte mode */ | 222 | /* byte mode */ |
| 222 | unsigned int poweroff_notify_state; /* eMMC4.5 notify feature */ | 223 | unsigned int poweroff_notify_state; /* eMMC4.5 notify feature */ |
| 223 | #define MMC_NO_POWER_NOTIFICATION 0 | 224 | #define MMC_NO_POWER_NOTIFICATION 0 |
| @@ -433,6 +434,11 @@ static inline int mmc_card_broken_byte_mode_512(const struct mmc_card *c) | |||
| 433 | return c->quirks & MMC_QUIRK_BROKEN_BYTE_MODE_512; | 434 | return c->quirks & MMC_QUIRK_BROKEN_BYTE_MODE_512; |
| 434 | } | 435 | } |
| 435 | 436 | ||
| 437 | static inline int mmc_card_long_read_time(const struct mmc_card *c) | ||
| 438 | { | ||
| 439 | return c->quirks & MMC_QUIRK_LONG_READ_TIME; | ||
| 440 | } | ||
| 441 | |||
| 436 | #define mmc_card_name(c) ((c)->cid.prod_name) | 442 | #define mmc_card_name(c) ((c)->cid.prod_name) |
| 437 | #define mmc_card_id(c) (dev_name(&(c)->dev)) | 443 | #define mmc_card_id(c) (dev_name(&(c)->dev)) |
| 438 | 444 | ||
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cbeb5867cff7..a82ad4dd306a 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h | |||
| @@ -2536,6 +2536,8 @@ extern void net_disable_timestamp(void); | |||
| 2536 | extern void *dev_seq_start(struct seq_file *seq, loff_t *pos); | 2536 | extern void *dev_seq_start(struct seq_file *seq, loff_t *pos); |
| 2537 | extern void *dev_seq_next(struct seq_file *seq, void *v, loff_t *pos); | 2537 | extern void *dev_seq_next(struct seq_file *seq, void *v, loff_t *pos); |
| 2538 | extern void dev_seq_stop(struct seq_file *seq, void *v); | 2538 | extern void dev_seq_stop(struct seq_file *seq, void *v); |
| 2539 | extern int dev_seq_open_ops(struct inode *inode, struct file *file, | ||
| 2540 | const struct seq_operations *ops); | ||
| 2539 | #endif | 2541 | #endif |
| 2540 | 2542 | ||
| 2541 | extern int netdev_class_create_file(struct class_attribute *class_attr); | 2543 | extern int netdev_class_create_file(struct class_attribute *class_attr); |
diff --git a/include/linux/pci-ats.h b/include/linux/pci-ats.h index e3d0b3890249..7ef68724f0f0 100644 --- a/include/linux/pci-ats.h +++ b/include/linux/pci-ats.h | |||
| @@ -12,7 +12,7 @@ struct pci_ats { | |||
| 12 | unsigned int is_enabled:1; /* Enable bit is set */ | 12 | unsigned int is_enabled:1; /* Enable bit is set */ |
| 13 | }; | 13 | }; |
| 14 | 14 | ||
| 15 | #ifdef CONFIG_PCI_IOV | 15 | #ifdef CONFIG_PCI_ATS |
| 16 | 16 | ||
| 17 | extern int pci_enable_ats(struct pci_dev *dev, int ps); | 17 | extern int pci_enable_ats(struct pci_dev *dev, int ps); |
| 18 | extern void pci_disable_ats(struct pci_dev *dev); | 18 | extern void pci_disable_ats(struct pci_dev *dev); |
| @@ -29,7 +29,7 @@ static inline int pci_ats_enabled(struct pci_dev *dev) | |||
| 29 | return dev->ats && dev->ats->is_enabled; | 29 | return dev->ats && dev->ats->is_enabled; |
| 30 | } | 30 | } |
| 31 | 31 | ||
| 32 | #else /* CONFIG_PCI_IOV */ | 32 | #else /* CONFIG_PCI_ATS */ |
| 33 | 33 | ||
| 34 | static inline int pci_enable_ats(struct pci_dev *dev, int ps) | 34 | static inline int pci_enable_ats(struct pci_dev *dev, int ps) |
| 35 | { | 35 | { |
| @@ -50,7 +50,7 @@ static inline int pci_ats_enabled(struct pci_dev *dev) | |||
| 50 | return 0; | 50 | return 0; |
| 51 | } | 51 | } |
| 52 | 52 | ||
| 53 | #endif /* CONFIG_PCI_IOV */ | 53 | #endif /* CONFIG_PCI_ATS */ |
| 54 | 54 | ||
| 55 | #ifdef CONFIG_PCI_PRI | 55 | #ifdef CONFIG_PCI_PRI |
| 56 | 56 | ||
diff --git a/include/linux/pci.h b/include/linux/pci.h index 337df0d5d5f7..7cda65b5f798 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h | |||
| @@ -338,7 +338,7 @@ struct pci_dev { | |||
| 338 | struct list_head msi_list; | 338 | struct list_head msi_list; |
| 339 | #endif | 339 | #endif |
| 340 | struct pci_vpd *vpd; | 340 | struct pci_vpd *vpd; |
| 341 | #ifdef CONFIG_PCI_IOV | 341 | #ifdef CONFIG_PCI_ATS |
| 342 | union { | 342 | union { |
| 343 | struct pci_sriov *sriov; /* SR-IOV capability related */ | 343 | struct pci_sriov *sriov; /* SR-IOV capability related */ |
| 344 | struct pci_dev *physfn; /* the PF this VF is associated with */ | 344 | struct pci_dev *physfn; /* the PF this VF is associated with */ |
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 172ba70306d1..2aaee0ca9da8 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h | |||
| @@ -517,8 +517,12 @@ | |||
| 517 | #define PCI_DEVICE_ID_AMD_11H_NB_DRAM 0x1302 | 517 | #define PCI_DEVICE_ID_AMD_11H_NB_DRAM 0x1302 |
| 518 | #define PCI_DEVICE_ID_AMD_11H_NB_MISC 0x1303 | 518 | #define PCI_DEVICE_ID_AMD_11H_NB_MISC 0x1303 |
| 519 | #define PCI_DEVICE_ID_AMD_11H_NB_LINK 0x1304 | 519 | #define PCI_DEVICE_ID_AMD_11H_NB_LINK 0x1304 |
| 520 | #define PCI_DEVICE_ID_AMD_15H_NB_F0 0x1600 | ||
| 521 | #define PCI_DEVICE_ID_AMD_15H_NB_F1 0x1601 | ||
| 522 | #define PCI_DEVICE_ID_AMD_15H_NB_F2 0x1602 | ||
| 520 | #define PCI_DEVICE_ID_AMD_15H_NB_F3 0x1603 | 523 | #define PCI_DEVICE_ID_AMD_15H_NB_F3 0x1603 |
| 521 | #define PCI_DEVICE_ID_AMD_15H_NB_F4 0x1604 | 524 | #define PCI_DEVICE_ID_AMD_15H_NB_F4 0x1604 |
| 525 | #define PCI_DEVICE_ID_AMD_15H_NB_F5 0x1605 | ||
| 522 | #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703 | 526 | #define PCI_DEVICE_ID_AMD_CNB17H_F3 0x1703 |
| 523 | #define PCI_DEVICE_ID_AMD_LANCE 0x2000 | 527 | #define PCI_DEVICE_ID_AMD_LANCE 0x2000 |
| 524 | #define PCI_DEVICE_ID_AMD_LANCE_HOME 0x2001 | 528 | #define PCI_DEVICE_ID_AMD_LANCE_HOME 0x2001 |
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 1e9ebe5e0091..b1f89122bf6a 100644 --- a/include/linux/perf_event.h +++ b/include/linux/perf_event.h | |||
| @@ -822,6 +822,7 @@ struct perf_event { | |||
| 822 | int mmap_locked; | 822 | int mmap_locked; |
| 823 | struct user_struct *mmap_user; | 823 | struct user_struct *mmap_user; |
| 824 | struct ring_buffer *rb; | 824 | struct ring_buffer *rb; |
| 825 | struct list_head rb_entry; | ||
| 825 | 826 | ||
| 826 | /* poll related */ | 827 | /* poll related */ |
| 827 | wait_queue_head_t waitq; | 828 | wait_queue_head_t waitq; |
diff --git a/include/linux/pkt_sched.h b/include/linux/pkt_sched.h index c5336705921f..7281d5acf2f9 100644 --- a/include/linux/pkt_sched.h +++ b/include/linux/pkt_sched.h | |||
| @@ -30,7 +30,7 @@ | |||
| 30 | */ | 30 | */ |
| 31 | 31 | ||
| 32 | struct tc_stats { | 32 | struct tc_stats { |
| 33 | __u64 bytes; /* NUmber of enqueues bytes */ | 33 | __u64 bytes; /* Number of enqueued bytes */ |
| 34 | __u32 packets; /* Number of enqueued packets */ | 34 | __u32 packets; /* Number of enqueued packets */ |
| 35 | __u32 drops; /* Packets dropped because of lack of resources */ | 35 | __u32 drops; /* Packets dropped because of lack of resources */ |
| 36 | __u32 overlimits; /* Number of throttle events when this | 36 | __u32 overlimits; /* Number of throttle events when this |
| @@ -297,7 +297,7 @@ struct tc_htb_glob { | |||
| 297 | __u32 debug; /* debug flags */ | 297 | __u32 debug; /* debug flags */ |
| 298 | 298 | ||
| 299 | /* stats */ | 299 | /* stats */ |
| 300 | __u32 direct_pkts; /* count of non shapped packets */ | 300 | __u32 direct_pkts; /* count of non shaped packets */ |
| 301 | }; | 301 | }; |
| 302 | enum { | 302 | enum { |
| 303 | TCA_HTB_UNSPEC, | 303 | TCA_HTB_UNSPEC, |
| @@ -503,7 +503,7 @@ enum { | |||
| 503 | }; | 503 | }; |
| 504 | #define NETEM_LOSS_MAX (__NETEM_LOSS_MAX - 1) | 504 | #define NETEM_LOSS_MAX (__NETEM_LOSS_MAX - 1) |
| 505 | 505 | ||
| 506 | /* State transition probablities for 4 state model */ | 506 | /* State transition probabilities for 4 state model */ |
| 507 | struct tc_netem_gimodel { | 507 | struct tc_netem_gimodel { |
| 508 | __u32 p13; | 508 | __u32 p13; |
| 509 | __u32 p31; | 509 | __u32 p31; |
diff --git a/include/linux/pm.h b/include/linux/pm.h index 5c4c8b18c8b7..3f3ed83a9aa5 100644 --- a/include/linux/pm.h +++ b/include/linux/pm.h | |||
| @@ -54,118 +54,145 @@ typedef struct pm_message { | |||
| 54 | /** | 54 | /** |
| 55 | * struct dev_pm_ops - device PM callbacks | 55 | * struct dev_pm_ops - device PM callbacks |
| 56 | * | 56 | * |
| 57 | * Several driver power state transitions are externally visible, affecting | 57 | * Several device power state transitions are externally visible, affecting |
| 58 | * the state of pending I/O queues and (for drivers that touch hardware) | 58 | * the state of pending I/O queues and (for drivers that touch hardware) |
| 59 | * interrupts, wakeups, DMA, and other hardware state. There may also be | 59 | * interrupts, wakeups, DMA, and other hardware state. There may also be |
| 60 | * internal transitions to various low power modes, which are transparent | 60 | * internal transitions to various low-power modes which are transparent |
| 61 | * to the rest of the driver stack (such as a driver that's ON gating off | 61 | * to the rest of the driver stack (such as a driver that's ON gating off |
| 62 | * clocks which are not in active use). | 62 | * clocks which are not in active use). |
| 63 | * | 63 | * |
| 64 | * The externally visible transitions are handled with the help of the following | 64 | * The externally visible transitions are handled with the help of callbacks |
| 65 | * callbacks included in this structure: | 65 | * included in this structure in such a way that two levels of callbacks are |
| 66 | * | 66 | * involved. First, the PM core executes callbacks provided by PM domains, |
| 67 | * @prepare: Prepare the device for the upcoming transition, but do NOT change | 67 | * device types, classes and bus types. They are the subsystem-level callbacks |
| 68 | * its hardware state. Prevent new children of the device from being | 68 | * supposed to execute callbacks provided by device drivers, although they may |
| 69 | * registered after @prepare() returns (the driver's subsystem and | 69 | * choose not to do that. If the driver callbacks are executed, they have to |
| 70 | * generally the rest of the kernel is supposed to prevent new calls to the | 70 | * collaborate with the subsystem-level callbacks to achieve the goals |
| 71 | * probe method from being made too once @prepare() has succeeded). If | 71 | * appropriate for the given system transition, given transition phase and the |
| 72 | * @prepare() detects a situation it cannot handle (e.g. registration of a | 72 | * subsystem the device belongs to. |
| 73 | * child already in progress), it may return -EAGAIN, so that the PM core | 73 | * |
| 74 | * can execute it once again (e.g. after the new child has been registered) | 74 | * @prepare: The principal role of this callback is to prevent new children of |
| 75 | * to recover from the race condition. This method is executed for all | 75 | * the device from being registered after it has returned (the driver's |
| 76 | * kinds of suspend transitions and is followed by one of the suspend | 76 | * subsystem and generally the rest of the kernel is supposed to prevent |
| 77 | * callbacks: @suspend(), @freeze(), or @poweroff(). | 77 | * new calls to the probe method from being made too once @prepare() has |
| 78 | * The PM core executes @prepare() for all devices before starting to | 78 | * succeeded). If @prepare() detects a situation it cannot handle (e.g. |
| 79 | * execute suspend callbacks for any of them, so drivers may assume all of | 79 | * registration of a child already in progress), it may return -EAGAIN, so |
| 80 | * the other devices to be present and functional while @prepare() is being | 80 | * that the PM core can execute it once again (e.g. after a new child has |
| 81 | * executed. In particular, it is safe to make GFP_KERNEL memory | 81 | * been registered) to recover from the race condition. |
| 82 | * allocations from within @prepare(). However, drivers may NOT assume | 82 | * This method is executed for all kinds of suspend transitions and is |
| 83 | * anything about the availability of the user space at that time and it | 83 | * followed by one of the suspend callbacks: @suspend(), @freeze(), or |
| 84 | * is not correct to request firmware from within @prepare() (it's too | 84 | * @poweroff(). The PM core executes subsystem-level @prepare() for all |
| 85 | * late to do that). [To work around this limitation, drivers may | 85 | * devices before starting to invoke suspend callbacks for any of them, so |
| 86 | * register suspend and hibernation notifiers that are executed before the | 86 | * generally devices may be assumed to be functional or to respond to |
| 87 | * freezing of tasks.] | 87 | * runtime resume requests while @prepare() is being executed. However, |
| 88 | * device drivers may NOT assume anything about the availability of user | ||
| 89 | * space at that time and it is NOT valid to request firmware from within | ||
| 90 | * @prepare() (it's too late to do that). It also is NOT valid to allocate | ||
| 91 | * substantial amounts of memory from @prepare() in the GFP_KERNEL mode. | ||
| 92 | * [To work around these limitations, drivers may register suspend and | ||
| 93 | * hibernation notifiers to be executed before the freezing of tasks.] | ||
| 88 | * | 94 | * |
| 89 | * @complete: Undo the changes made by @prepare(). This method is executed for | 95 | * @complete: Undo the changes made by @prepare(). This method is executed for |
| 90 | * all kinds of resume transitions, following one of the resume callbacks: | 96 | * all kinds of resume transitions, following one of the resume callbacks: |
| 91 | * @resume(), @thaw(), @restore(). Also called if the state transition | 97 | * @resume(), @thaw(), @restore(). Also called if the state transition |
| 92 | * fails before the driver's suspend callback (@suspend(), @freeze(), | 98 | * fails before the driver's suspend callback: @suspend(), @freeze() or |
| 93 | * @poweroff()) can be executed (e.g. if the suspend callback fails for one | 99 | * @poweroff(), can be executed (e.g. if the suspend callback fails for one |
| 94 | * of the other devices that the PM core has unsuccessfully attempted to | 100 | * of the other devices that the PM core has unsuccessfully attempted to |
| 95 | * suspend earlier). | 101 | * suspend earlier). |
| 96 | * The PM core executes @complete() after it has executed the appropriate | 102 | * The PM core executes subsystem-level @complete() after it has executed |
| 97 | * resume callback for all devices. | 103 | * the appropriate resume callbacks for all devices. |
| 98 | * | 104 | * |
| 99 | * @suspend: Executed before putting the system into a sleep state in which the | 105 | * @suspend: Executed before putting the system into a sleep state in which the |
| 100 | * contents of main memory are preserved. Quiesce the device, put it into | 106 | * contents of main memory are preserved. The exact action to perform |
| 101 | * a low power state appropriate for the upcoming system state (such as | 107 | * depends on the device's subsystem (PM domain, device type, class or bus |
| 102 | * PCI_D3hot), and enable wakeup events as appropriate. | 108 | * type), but generally the device must be quiescent after subsystem-level |
| 109 | * @suspend() has returned, so that it doesn't do any I/O or DMA. | ||
| 110 | * Subsystem-level @suspend() is executed for all devices after invoking | ||
| 111 | * subsystem-level @prepare() for all of them. | ||
| 103 | * | 112 | * |
| 104 | * @resume: Executed after waking the system up from a sleep state in which the | 113 | * @resume: Executed after waking the system up from a sleep state in which the |
| 105 | * contents of main memory were preserved. Put the device into the | 114 | * contents of main memory were preserved. The exact action to perform |
| 106 | * appropriate state, according to the information saved in memory by the | 115 | * depends on the device's subsystem, but generally the driver is expected |
| 107 | * preceding @suspend(). The driver starts working again, responding to | 116 | * to start working again, responding to hardware events and software |
| 108 | * hardware events and software requests. The hardware may have gone | 117 | * requests (the device itself may be left in a low-power state, waiting |
| 109 | * through a power-off reset, or it may have maintained state from the | 118 | * for a runtime resume to occur). The state of the device at the time its |
| 110 | * previous suspend() which the driver may rely on while resuming. On most | 119 | * driver's @resume() callback is run depends on the platform and subsystem |
| 111 | * platforms, there are no restrictions on availability of resources like | 120 | * the device belongs to. On most platforms, there are no restrictions on |
| 112 | * clocks during @resume(). | 121 | * availability of resources like clocks during @resume(). |
| 122 | * Subsystem-level @resume() is executed for all devices after invoking | ||
| 123 | * subsystem-level @resume_noirq() for all of them. | ||
| 113 | * | 124 | * |
| 114 | * @freeze: Hibernation-specific, executed before creating a hibernation image. | 125 | * @freeze: Hibernation-specific, executed before creating a hibernation image. |
| 115 | * Quiesce operations so that a consistent image can be created, but do NOT | 126 | * Analogous to @suspend(), but it should not enable the device to signal |
| 116 | * otherwise put the device into a low power device state and do NOT emit | 127 | * wakeup events or change its power state. The majority of subsystems |
| 117 | * system wakeup events. Save in main memory the device settings to be | 128 | * (with the notable exception of the PCI bus type) expect the driver-level |
| 118 | * used by @restore() during the subsequent resume from hibernation or by | 129 | * @freeze() to save the device settings in memory to be used by @restore() |
| 119 | * the subsequent @thaw(), if the creation of the image or the restoration | 130 | * during the subsequent resume from hibernation. |
| 120 | * of main memory contents from it fails. | 131 | * Subsystem-level @freeze() is executed for all devices after invoking |
| 132 | * subsystem-level @prepare() for all of them. | ||
| 121 | * | 133 | * |
| 122 | * @thaw: Hibernation-specific, executed after creating a hibernation image OR | 134 | * @thaw: Hibernation-specific, executed after creating a hibernation image OR |
| 123 | * if the creation of the image fails. Also executed after a failing | 135 | * if the creation of an image has failed. Also executed after a failing |
| 124 | * attempt to restore the contents of main memory from such an image. | 136 | * attempt to restore the contents of main memory from such an image. |
| 125 | * Undo the changes made by the preceding @freeze(), so the device can be | 137 | * Undo the changes made by the preceding @freeze(), so the device can be |
| 126 | * operated in the same way as immediately before the call to @freeze(). | 138 | * operated in the same way as immediately before the call to @freeze(). |
| 139 | * Subsystem-level @thaw() is executed for all devices after invoking | ||
| 140 | * subsystem-level @thaw_noirq() for all of them. It also may be executed | ||
| 141 | * directly after @freeze() in case of a transition error. | ||
| 127 | * | 142 | * |
| 128 | * @poweroff: Hibernation-specific, executed after saving a hibernation image. | 143 | * @poweroff: Hibernation-specific, executed after saving a hibernation image. |
| 129 | * Quiesce the device, put it into a low power state appropriate for the | 144 | * Analogous to @suspend(), but it need not save the device's settings in |
| 130 | * upcoming system state (such as PCI_D3hot), and enable wakeup events as | 145 | * memory. |
| 131 | * appropriate. | 146 | * Subsystem-level @poweroff() is executed for all devices after invoking |
| 147 | * subsystem-level @prepare() for all of them. | ||
| 132 | * | 148 | * |
| 133 | * @restore: Hibernation-specific, executed after restoring the contents of main | 149 | * @restore: Hibernation-specific, executed after restoring the contents of main |
| 134 | * memory from a hibernation image. Driver starts working again, | 150 | * memory from a hibernation image, analogous to @resume(). |
| 135 | * responding to hardware events and software requests. Drivers may NOT | 151 | * |
| 136 | * make ANY assumptions about the hardware state right prior to @restore(). | 152 | * @suspend_noirq: Complete the actions started by @suspend(). Carry out any |
| 137 | * On most platforms, there are no restrictions on availability of | 153 | * additional operations required for suspending the device that might be |
| 138 | * resources like clocks during @restore(). | 154 | * racing with its driver's interrupt handler, which is guaranteed not to |
| 139 | * | 155 | * run while @suspend_noirq() is being executed. |
| 140 | * @suspend_noirq: Complete the operations of ->suspend() by carrying out any | 156 | * It generally is expected that the device will be in a low-power state |
| 141 | * actions required for suspending the device that need interrupts to be | 157 | * (appropriate for the target system sleep state) after subsystem-level |
| 142 | * disabled | 158 | * @suspend_noirq() has returned successfully. If the device can generate |
| 143 | * | 159 | * system wakeup signals and is enabled to wake up the system, it should be |
| 144 | * @resume_noirq: Prepare for the execution of ->resume() by carrying out any | 160 | * configured to do so at that time. However, depending on the platform |
| 145 | * actions required for resuming the device that need interrupts to be | 161 | * and device's subsystem, @suspend() may be allowed to put the device into |
| 146 | * disabled | 162 | * the low-power state and configure it to generate wakeup signals, in |
| 147 | * | 163 | * which case it generally is not necessary to define @suspend_noirq(). |
| 148 | * @freeze_noirq: Complete the operations of ->freeze() by carrying out any | 164 | * |
| 149 | * actions required for freezing the device that need interrupts to be | 165 | * @resume_noirq: Prepare for the execution of @resume() by carrying out any |
| 150 | * disabled | 166 | * operations required for resuming the device that might be racing with |
| 151 | * | 167 | * its driver's interrupt handler, which is guaranteed not to run while |
| 152 | * @thaw_noirq: Prepare for the execution of ->thaw() by carrying out any | 168 | * @resume_noirq() is being executed. |
| 153 | * actions required for thawing the device that need interrupts to be | 169 | * |
| 154 | * disabled | 170 | * @freeze_noirq: Complete the actions started by @freeze(). Carry out any |
| 155 | * | 171 | * additional operations required for freezing the device that might be |
| 156 | * @poweroff_noirq: Complete the operations of ->poweroff() by carrying out any | 172 | * racing with its driver's interrupt handler, which is guaranteed not to |
| 157 | * actions required for handling the device that need interrupts to be | 173 | * run while @freeze_noirq() is being executed. |
| 158 | * disabled | 174 | * The power state of the device should not be changed by either @freeze() |
| 159 | * | 175 | * or @freeze_noirq() and it should not be configured to signal system |
| 160 | * @restore_noirq: Prepare for the execution of ->restore() by carrying out any | 176 | * wakeup by any of these callbacks. |
| 161 | * actions required for restoring the operations of the device that need | 177 | * |
| 162 | * interrupts to be disabled | 178 | * @thaw_noirq: Prepare for the execution of @thaw() by carrying out any |
| 179 | * operations required for thawing the device that might be racing with its | ||
| 180 | * driver's interrupt handler, which is guaranteed not to run while | ||
| 181 | * @thaw_noirq() is being executed. | ||
| 182 | * | ||
| 183 | * @poweroff_noirq: Complete the actions started by @poweroff(). Analogous to | ||
| 184 | * @suspend_noirq(), but it need not save the device's settings in memory. | ||
| 185 | * | ||
| 186 | * @restore_noirq: Prepare for the execution of @restore() by carrying out any | ||
| 187 | * operations required for thawing the device that might be racing with its | ||
| 188 | * driver's interrupt handler, which is guaranteed not to run while | ||
| 189 | * @restore_noirq() is being executed. Analogous to @resume_noirq(). | ||
| 163 | * | 190 | * |
| 164 | * All of the above callbacks, except for @complete(), return error codes. | 191 | * All of the above callbacks, except for @complete(), return error codes. |
| 165 | * However, the error codes returned by the resume operations, @resume(), | 192 | * However, the error codes returned by the resume operations, @resume(), |
| 166 | * @thaw(), @restore(), @resume_noirq(), @thaw_noirq(), and @restore_noirq() do | 193 | * @thaw(), @restore(), @resume_noirq(), @thaw_noirq(), and @restore_noirq(), do |
| 167 | * not cause the PM core to abort the resume transition during which they are | 194 | * not cause the PM core to abort the resume transition during which they are |
| 168 | * returned. The error codes returned in that cases are only printed by the PM | 195 | * returned. The error codes returned in those cases are only printed by the PM |
| 169 | * core to the system logs for debugging purposes. Still, it is recommended | 196 | * core to the system logs for debugging purposes. Still, it is recommended |
| 170 | * that drivers only return error codes from their resume methods in case of an | 197 | * that drivers only return error codes from their resume methods in case of an |
| 171 | * unrecoverable failure (i.e. when the device being handled refuses to resume | 198 | * unrecoverable failure (i.e. when the device being handled refuses to resume |
| @@ -174,31 +201,43 @@ typedef struct pm_message { | |||
| 174 | * their children. | 201 | * their children. |
| 175 | * | 202 | * |
| 176 | * It is allowed to unregister devices while the above callbacks are being | 203 | * It is allowed to unregister devices while the above callbacks are being |
| 177 | * executed. However, it is not allowed to unregister a device from within any | 204 | * executed. However, a callback routine must NOT try to unregister the device |
| 178 | * of its own callbacks. | 205 | * it was called for, although it may unregister children of that device (for |
| 206 | * example, if it detects that a child was unplugged while the system was | ||
| 207 | * asleep). | ||
| 208 | * | ||
| 209 | * Refer to Documentation/power/devices.txt for more information about the role | ||
| 210 | * of the above callbacks in the system suspend process. | ||
| 179 | * | 211 | * |
| 180 | * There also are the following callbacks related to run-time power management | 212 | * There also are callbacks related to runtime power management of devices. |
| 181 | * of devices: | 213 | * Again, these callbacks are executed by the PM core only for subsystems |
| 214 | * (PM domains, device types, classes and bus types) and the subsystem-level | ||
| 215 | * callbacks are supposed to invoke the driver callbacks. Moreover, the exact | ||
| 216 | * actions to be performed by a device driver's callbacks generally depend on | ||
| 217 | * the platform and subsystem the device belongs to. | ||
| 182 | * | 218 | * |
| 183 | * @runtime_suspend: Prepare the device for a condition in which it won't be | 219 | * @runtime_suspend: Prepare the device for a condition in which it won't be |
| 184 | * able to communicate with the CPU(s) and RAM due to power management. | 220 | * able to communicate with the CPU(s) and RAM due to power management. |
| 185 | * This need not mean that the device should be put into a low power state. | 221 | * This need not mean that the device should be put into a low-power state. |
| 186 | * For example, if the device is behind a link which is about to be turned | 222 | * For example, if the device is behind a link which is about to be turned |
| 187 | * off, the device may remain at full power. If the device does go to low | 223 | * off, the device may remain at full power. If the device does go to low |
| 188 | * power and is capable of generating run-time wake-up events, remote | 224 | * power and is capable of generating runtime wakeup events, remote wakeup |
| 189 | * wake-up (i.e., a hardware mechanism allowing the device to request a | 225 | * (i.e., a hardware mechanism allowing the device to request a change of |
| 190 | * change of its power state via a wake-up event, such as PCI PME) should | 226 | * its power state via an interrupt) should be enabled for it. |
| 191 | * be enabled for it. | ||
| 192 | * | 227 | * |
| 193 | * @runtime_resume: Put the device into the fully active state in response to a | 228 | * @runtime_resume: Put the device into the fully active state in response to a |
| 194 | * wake-up event generated by hardware or at the request of software. If | 229 | * wakeup event generated by hardware or at the request of software. If |
| 195 | * necessary, put the device into the full power state and restore its | 230 | * necessary, put the device into the full-power state and restore its |
| 196 | * registers, so that it is fully operational. | 231 | * registers, so that it is fully operational. |
| 197 | * | 232 | * |
| 198 | * @runtime_idle: Device appears to be inactive and it might be put into a low | 233 | * @runtime_idle: Device appears to be inactive and it might be put into a |
| 199 | * power state if all of the necessary conditions are satisfied. Check | 234 | * low-power state if all of the necessary conditions are satisfied. Check |
| 200 | * these conditions and handle the device as appropriate, possibly queueing | 235 | * these conditions and handle the device as appropriate, possibly queueing |
| 201 | * a suspend request for it. The return value is ignored by the PM core. | 236 | * a suspend request for it. The return value is ignored by the PM core. |
| 237 | * | ||
| 238 | * Refer to Documentation/power/runtime_pm.txt for more information about the | ||
| 239 | * role of the above callbacks in device runtime power management. | ||
| 240 | * | ||
| 202 | */ | 241 | */ |
| 203 | 242 | ||
| 204 | struct dev_pm_ops { | 243 | struct dev_pm_ops { |
diff --git a/include/linux/pstore.h b/include/linux/pstore.h index ea567321ae3c..2ca8cde5459d 100644 --- a/include/linux/pstore.h +++ b/include/linux/pstore.h | |||
| @@ -35,10 +35,12 @@ struct pstore_info { | |||
| 35 | spinlock_t buf_lock; /* serialize access to 'buf' */ | 35 | spinlock_t buf_lock; /* serialize access to 'buf' */ |
| 36 | char *buf; | 36 | char *buf; |
| 37 | size_t bufsize; | 37 | size_t bufsize; |
| 38 | struct mutex read_mutex; /* serialize open/read/close */ | ||
| 38 | int (*open)(struct pstore_info *psi); | 39 | int (*open)(struct pstore_info *psi); |
| 39 | int (*close)(struct pstore_info *psi); | 40 | int (*close)(struct pstore_info *psi); |
| 40 | ssize_t (*read)(u64 *id, enum pstore_type_id *type, | 41 | ssize_t (*read)(u64 *id, enum pstore_type_id *type, |
| 41 | struct timespec *time, struct pstore_info *psi); | 42 | struct timespec *time, char **buf, |
| 43 | struct pstore_info *psi); | ||
| 42 | int (*write)(enum pstore_type_id type, u64 *id, | 44 | int (*write)(enum pstore_type_id type, u64 *id, |
| 43 | unsigned int part, size_t size, struct pstore_info *psi); | 45 | unsigned int part, size_t size, struct pstore_info *psi); |
| 44 | int (*erase)(enum pstore_type_id type, u64 id, | 46 | int (*erase)(enum pstore_type_id type, u64 id, |
diff --git a/include/linux/shrinker.h b/include/linux/shrinker.h index a83833a1f7a2..07ceb97d53fa 100644 --- a/include/linux/shrinker.h +++ b/include/linux/shrinker.h | |||
| @@ -35,7 +35,7 @@ struct shrinker { | |||
| 35 | 35 | ||
| 36 | /* These are for internal use */ | 36 | /* These are for internal use */ |
| 37 | struct list_head list; | 37 | struct list_head list; |
| 38 | long nr; /* objs pending delete */ | 38 | atomic_long_t nr_in_batch; /* objs pending delete */ |
| 39 | }; | 39 | }; |
| 40 | #define DEFAULT_SEEKS 2 /* A good number if you don't know better. */ | 40 | #define DEFAULT_SEEKS 2 /* A good number if you don't know better. */ |
| 41 | extern void register_shrinker(struct shrinker *); | 41 | extern void register_shrinker(struct shrinker *); |
diff --git a/include/linux/sigma.h b/include/linux/sigma.h index e2accb3164d8..d0de882c0d96 100644 --- a/include/linux/sigma.h +++ b/include/linux/sigma.h | |||
| @@ -24,7 +24,7 @@ struct sigma_firmware { | |||
| 24 | struct sigma_firmware_header { | 24 | struct sigma_firmware_header { |
| 25 | unsigned char magic[7]; | 25 | unsigned char magic[7]; |
| 26 | u8 version; | 26 | u8 version; |
| 27 | u32 crc; | 27 | __le32 crc; |
| 28 | }; | 28 | }; |
| 29 | 29 | ||
| 30 | enum { | 30 | enum { |
| @@ -40,19 +40,14 @@ enum { | |||
| 40 | struct sigma_action { | 40 | struct sigma_action { |
| 41 | u8 instr; | 41 | u8 instr; |
| 42 | u8 len_hi; | 42 | u8 len_hi; |
| 43 | u16 len; | 43 | __le16 len; |
| 44 | u16 addr; | 44 | __be16 addr; |
| 45 | unsigned char payload[]; | 45 | unsigned char payload[]; |
| 46 | }; | 46 | }; |
| 47 | 47 | ||
| 48 | static inline u32 sigma_action_len(struct sigma_action *sa) | 48 | static inline u32 sigma_action_len(struct sigma_action *sa) |
| 49 | { | 49 | { |
| 50 | return (sa->len_hi << 16) | sa->len; | 50 | return (sa->len_hi << 16) | le16_to_cpu(sa->len); |
| 51 | } | ||
| 52 | |||
| 53 | static inline size_t sigma_action_size(struct sigma_action *sa, u32 payload_len) | ||
| 54 | { | ||
| 55 | return sizeof(*sa) + payload_len + (payload_len % 2); | ||
| 56 | } | 51 | } |
| 57 | 52 | ||
| 58 | extern int process_sigma_firmware(struct i2c_client *client, const char *name); | 53 | extern int process_sigma_firmware(struct i2c_client *client, const char *name); |
diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index add4790b21fe..e9e72bda1b72 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h | |||
| @@ -85,6 +85,8 @@ | |||
| 85 | * @reset: reset the device | 85 | * @reset: reset the device |
| 86 | * vdev: the virtio device | 86 | * vdev: the virtio device |
| 87 | * After this, status and feature negotiation must be done again | 87 | * After this, status and feature negotiation must be done again |
| 88 | * Device must not be reset from its vq/config callbacks, or in | ||
| 89 | * parallel with being added/removed. | ||
| 88 | * @find_vqs: find virtqueues and instantiate them. | 90 | * @find_vqs: find virtqueues and instantiate them. |
| 89 | * vdev: the virtio_device | 91 | * vdev: the virtio_device |
| 90 | * nvqs: the number of virtqueues to find | 92 | * nvqs: the number of virtqueues to find |
diff --git a/include/linux/virtio_mmio.h b/include/linux/virtio_mmio.h index 27c7edefbc86..5c7b6f0daef8 100644 --- a/include/linux/virtio_mmio.h +++ b/include/linux/virtio_mmio.h | |||
| @@ -63,7 +63,7 @@ | |||
| 63 | #define VIRTIO_MMIO_GUEST_FEATURES 0x020 | 63 | #define VIRTIO_MMIO_GUEST_FEATURES 0x020 |
| 64 | 64 | ||
| 65 | /* Activated features set selector - Write Only */ | 65 | /* Activated features set selector - Write Only */ |
| 66 | #define VIRTIO_MMIO_GUEST_FEATURES_SET 0x024 | 66 | #define VIRTIO_MMIO_GUEST_FEATURES_SEL 0x024 |
| 67 | 67 | ||
| 68 | /* Guest's memory page size in bytes - Write Only */ | 68 | /* Guest's memory page size in bytes - Write Only */ |
| 69 | #define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028 | 69 | #define VIRTIO_MMIO_GUEST_PAGE_SIZE 0x028 |
diff --git a/include/net/dst.h b/include/net/dst.h index 4fb6c4381791..6faec1a60216 100644 --- a/include/net/dst.h +++ b/include/net/dst.h | |||
| @@ -205,12 +205,7 @@ dst_feature(const struct dst_entry *dst, u32 feature) | |||
| 205 | 205 | ||
| 206 | static inline u32 dst_mtu(const struct dst_entry *dst) | 206 | static inline u32 dst_mtu(const struct dst_entry *dst) |
| 207 | { | 207 | { |
| 208 | u32 mtu = dst_metric_raw(dst, RTAX_MTU); | 208 | return dst->ops->mtu(dst); |
| 209 | |||
| 210 | if (!mtu) | ||
| 211 | mtu = dst->ops->default_mtu(dst); | ||
| 212 | |||
| 213 | return mtu; | ||
| 214 | } | 209 | } |
| 215 | 210 | ||
| 216 | /* RTT metrics are stored in milliseconds for user ABI, but used as jiffies */ | 211 | /* RTT metrics are stored in milliseconds for user ABI, but used as jiffies */ |
diff --git a/include/net/dst_ops.h b/include/net/dst_ops.h index 9adb99845a56..e1c2ee0eef47 100644 --- a/include/net/dst_ops.h +++ b/include/net/dst_ops.h | |||
| @@ -17,7 +17,7 @@ struct dst_ops { | |||
| 17 | int (*gc)(struct dst_ops *ops); | 17 | int (*gc)(struct dst_ops *ops); |
| 18 | struct dst_entry * (*check)(struct dst_entry *, __u32 cookie); | 18 | struct dst_entry * (*check)(struct dst_entry *, __u32 cookie); |
| 19 | unsigned int (*default_advmss)(const struct dst_entry *); | 19 | unsigned int (*default_advmss)(const struct dst_entry *); |
| 20 | unsigned int (*default_mtu)(const struct dst_entry *); | 20 | unsigned int (*mtu)(const struct dst_entry *); |
| 21 | u32 * (*cow_metrics)(struct dst_entry *, unsigned long); | 21 | u32 * (*cow_metrics)(struct dst_entry *, unsigned long); |
| 22 | void (*destroy)(struct dst_entry *); | 22 | void (*destroy)(struct dst_entry *); |
| 23 | void (*ifdown)(struct dst_entry *, | 23 | void (*ifdown)(struct dst_entry *, |
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index b897d6e6d0a5..f941964a9931 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h | |||
| @@ -31,6 +31,7 @@ | |||
| 31 | /** struct ip_options - IP Options | 31 | /** struct ip_options - IP Options |
| 32 | * | 32 | * |
| 33 | * @faddr - Saved first hop address | 33 | * @faddr - Saved first hop address |
| 34 | * @nexthop - Saved nexthop address in LSRR and SSRR | ||
| 34 | * @is_data - Options in __data, rather than skb | 35 | * @is_data - Options in __data, rather than skb |
| 35 | * @is_strictroute - Strict source route | 36 | * @is_strictroute - Strict source route |
| 36 | * @srr_is_hit - Packet destination addr was our one | 37 | * @srr_is_hit - Packet destination addr was our one |
| @@ -41,6 +42,7 @@ | |||
| 41 | */ | 42 | */ |
| 42 | struct ip_options { | 43 | struct ip_options { |
| 43 | __be32 faddr; | 44 | __be32 faddr; |
| 45 | __be32 nexthop; | ||
| 44 | unsigned char optlen; | 46 | unsigned char optlen; |
| 45 | unsigned char srr; | 47 | unsigned char srr; |
| 46 | unsigned char rr; | 48 | unsigned char rr; |
diff --git a/include/net/inetpeer.h b/include/net/inetpeer.h index 78c83e62218f..e9ff3fc5e688 100644 --- a/include/net/inetpeer.h +++ b/include/net/inetpeer.h | |||
| @@ -35,6 +35,7 @@ struct inet_peer { | |||
| 35 | 35 | ||
| 36 | u32 metrics[RTAX_MAX]; | 36 | u32 metrics[RTAX_MAX]; |
| 37 | u32 rate_tokens; /* rate limiting for ICMP */ | 37 | u32 rate_tokens; /* rate limiting for ICMP */ |
| 38 | int redirect_genid; | ||
| 38 | unsigned long rate_last; | 39 | unsigned long rate_last; |
| 39 | unsigned long pmtu_expires; | 40 | unsigned long pmtu_expires; |
| 40 | u32 pmtu_orig; | 41 | u32 pmtu_orig; |
diff --git a/include/net/netfilter/nf_conntrack_ecache.h b/include/net/netfilter/nf_conntrack_ecache.h index 4283508b3e18..a88fb6939387 100644 --- a/include/net/netfilter/nf_conntrack_ecache.h +++ b/include/net/netfilter/nf_conntrack_ecache.h | |||
| @@ -67,18 +67,18 @@ struct nf_ct_event_notifier { | |||
| 67 | int (*fcn)(unsigned int events, struct nf_ct_event *item); | 67 | int (*fcn)(unsigned int events, struct nf_ct_event *item); |
| 68 | }; | 68 | }; |
| 69 | 69 | ||
| 70 | extern struct nf_ct_event_notifier __rcu *nf_conntrack_event_cb; | 70 | extern int nf_conntrack_register_notifier(struct net *net, struct nf_ct_event_notifier *nb); |
| 71 | extern int nf_conntrack_register_notifier(struct nf_ct_event_notifier *nb); | 71 | extern void nf_conntrack_unregister_notifier(struct net *net, struct nf_ct_event_notifier *nb); |
| 72 | extern void nf_conntrack_unregister_notifier(struct nf_ct_event_notifier *nb); | ||
| 73 | 72 | ||
| 74 | extern void nf_ct_deliver_cached_events(struct nf_conn *ct); | 73 | extern void nf_ct_deliver_cached_events(struct nf_conn *ct); |
| 75 | 74 | ||
| 76 | static inline void | 75 | static inline void |
| 77 | nf_conntrack_event_cache(enum ip_conntrack_events event, struct nf_conn *ct) | 76 | nf_conntrack_event_cache(enum ip_conntrack_events event, struct nf_conn *ct) |
| 78 | { | 77 | { |
| 78 | struct net *net = nf_ct_net(ct); | ||
| 79 | struct nf_conntrack_ecache *e; | 79 | struct nf_conntrack_ecache *e; |
| 80 | 80 | ||
| 81 | if (nf_conntrack_event_cb == NULL) | 81 | if (net->ct.nf_conntrack_event_cb == NULL) |
| 82 | return; | 82 | return; |
| 83 | 83 | ||
| 84 | e = nf_ct_ecache_find(ct); | 84 | e = nf_ct_ecache_find(ct); |
| @@ -95,11 +95,12 @@ nf_conntrack_eventmask_report(unsigned int eventmask, | |||
| 95 | int report) | 95 | int report) |
| 96 | { | 96 | { |
| 97 | int ret = 0; | 97 | int ret = 0; |
| 98 | struct net *net = nf_ct_net(ct); | ||
| 98 | struct nf_ct_event_notifier *notify; | 99 | struct nf_ct_event_notifier *notify; |
| 99 | struct nf_conntrack_ecache *e; | 100 | struct nf_conntrack_ecache *e; |
| 100 | 101 | ||
| 101 | rcu_read_lock(); | 102 | rcu_read_lock(); |
| 102 | notify = rcu_dereference(nf_conntrack_event_cb); | 103 | notify = rcu_dereference(net->ct.nf_conntrack_event_cb); |
| 103 | if (notify == NULL) | 104 | if (notify == NULL) |
| 104 | goto out_unlock; | 105 | goto out_unlock; |
| 105 | 106 | ||
| @@ -164,9 +165,8 @@ struct nf_exp_event_notifier { | |||
| 164 | int (*fcn)(unsigned int events, struct nf_exp_event *item); | 165 | int (*fcn)(unsigned int events, struct nf_exp_event *item); |
| 165 | }; | 166 | }; |
| 166 | 167 | ||
| 167 | extern struct nf_exp_event_notifier __rcu *nf_expect_event_cb; | 168 | extern int nf_ct_expect_register_notifier(struct net *net, struct nf_exp_event_notifier *nb); |
| 168 | extern int nf_ct_expect_register_notifier(struct nf_exp_event_notifier *nb); | 169 | extern void nf_ct_expect_unregister_notifier(struct net *net, struct nf_exp_event_notifier *nb); |
| 169 | extern void nf_ct_expect_unregister_notifier(struct nf_exp_event_notifier *nb); | ||
| 170 | 170 | ||
| 171 | static inline void | 171 | static inline void |
| 172 | nf_ct_expect_event_report(enum ip_conntrack_expect_events event, | 172 | nf_ct_expect_event_report(enum ip_conntrack_expect_events event, |
| @@ -174,11 +174,12 @@ nf_ct_expect_event_report(enum ip_conntrack_expect_events event, | |||
| 174 | u32 pid, | 174 | u32 pid, |
| 175 | int report) | 175 | int report) |
| 176 | { | 176 | { |
| 177 | struct net *net = nf_ct_exp_net(exp); | ||
| 177 | struct nf_exp_event_notifier *notify; | 178 | struct nf_exp_event_notifier *notify; |
| 178 | struct nf_conntrack_ecache *e; | 179 | struct nf_conntrack_ecache *e; |
| 179 | 180 | ||
| 180 | rcu_read_lock(); | 181 | rcu_read_lock(); |
| 181 | notify = rcu_dereference(nf_expect_event_cb); | 182 | notify = rcu_dereference(net->ct.nf_expect_event_cb); |
| 182 | if (notify == NULL) | 183 | if (notify == NULL) |
| 183 | goto out_unlock; | 184 | goto out_unlock; |
| 184 | 185 | ||
diff --git a/include/net/netns/conntrack.h b/include/net/netns/conntrack.h index 0249399e51a7..7a911eca0f18 100644 --- a/include/net/netns/conntrack.h +++ b/include/net/netns/conntrack.h | |||
| @@ -18,6 +18,8 @@ struct netns_ct { | |||
| 18 | struct hlist_nulls_head unconfirmed; | 18 | struct hlist_nulls_head unconfirmed; |
| 19 | struct hlist_nulls_head dying; | 19 | struct hlist_nulls_head dying; |
| 20 | struct ip_conntrack_stat __percpu *stat; | 20 | struct ip_conntrack_stat __percpu *stat; |
| 21 | struct nf_ct_event_notifier __rcu *nf_conntrack_event_cb; | ||
| 22 | struct nf_exp_event_notifier __rcu *nf_expect_event_cb; | ||
| 21 | int sysctl_events; | 23 | int sysctl_events; |
| 22 | unsigned int sysctl_events_retry_timeout; | 24 | unsigned int sysctl_events_retry_timeout; |
| 23 | int sysctl_acct; | 25 | int sysctl_acct; |
diff --git a/include/net/red.h b/include/net/red.h index 3319f16b3beb..b72a3b833936 100644 --- a/include/net/red.h +++ b/include/net/red.h | |||
| @@ -116,7 +116,7 @@ struct red_parms { | |||
| 116 | u32 qR; /* Cached random number */ | 116 | u32 qR; /* Cached random number */ |
| 117 | 117 | ||
| 118 | unsigned long qavg; /* Average queue length: A scaled */ | 118 | unsigned long qavg; /* Average queue length: A scaled */ |
| 119 | psched_time_t qidlestart; /* Start of current idle period */ | 119 | ktime_t qidlestart; /* Start of current idle period */ |
| 120 | }; | 120 | }; |
| 121 | 121 | ||
| 122 | static inline u32 red_rmask(u8 Plog) | 122 | static inline u32 red_rmask(u8 Plog) |
| @@ -148,17 +148,17 @@ static inline void red_set_parms(struct red_parms *p, | |||
| 148 | 148 | ||
| 149 | static inline int red_is_idling(struct red_parms *p) | 149 | static inline int red_is_idling(struct red_parms *p) |
| 150 | { | 150 | { |
| 151 | return p->qidlestart != PSCHED_PASTPERFECT; | 151 | return p->qidlestart.tv64 != 0; |
| 152 | } | 152 | } |
| 153 | 153 | ||
| 154 | static inline void red_start_of_idle_period(struct red_parms *p) | 154 | static inline void red_start_of_idle_period(struct red_parms *p) |
| 155 | { | 155 | { |
| 156 | p->qidlestart = psched_get_time(); | 156 | p->qidlestart = ktime_get(); |
| 157 | } | 157 | } |
| 158 | 158 | ||
| 159 | static inline void red_end_of_idle_period(struct red_parms *p) | 159 | static inline void red_end_of_idle_period(struct red_parms *p) |
| 160 | { | 160 | { |
| 161 | p->qidlestart = PSCHED_PASTPERFECT; | 161 | p->qidlestart.tv64 = 0; |
| 162 | } | 162 | } |
| 163 | 163 | ||
| 164 | static inline void red_restart(struct red_parms *p) | 164 | static inline void red_restart(struct red_parms *p) |
| @@ -170,13 +170,10 @@ static inline void red_restart(struct red_parms *p) | |||
| 170 | 170 | ||
| 171 | static inline unsigned long red_calc_qavg_from_idle_time(struct red_parms *p) | 171 | static inline unsigned long red_calc_qavg_from_idle_time(struct red_parms *p) |
| 172 | { | 172 | { |
| 173 | psched_time_t now; | 173 | s64 delta = ktime_us_delta(ktime_get(), p->qidlestart); |
| 174 | long us_idle; | 174 | long us_idle = min_t(s64, delta, p->Scell_max); |
| 175 | int shift; | 175 | int shift; |
| 176 | 176 | ||
| 177 | now = psched_get_time(); | ||
| 178 | us_idle = psched_tdiff_bounded(now, p->qidlestart, p->Scell_max); | ||
| 179 | |||
| 180 | /* | 177 | /* |
| 181 | * The problem: ideally, average length queue recalcultion should | 178 | * The problem: ideally, average length queue recalcultion should |
| 182 | * be done over constant clock intervals. This is too expensive, so | 179 | * be done over constant clock intervals. This is too expensive, so |
diff --git a/include/net/route.h b/include/net/route.h index db7b3432f07c..91855d185b53 100644 --- a/include/net/route.h +++ b/include/net/route.h | |||
| @@ -71,12 +71,12 @@ struct rtable { | |||
| 71 | struct fib_info *fi; /* for client ref to shared metrics */ | 71 | struct fib_info *fi; /* for client ref to shared metrics */ |
| 72 | }; | 72 | }; |
| 73 | 73 | ||
| 74 | static inline bool rt_is_input_route(struct rtable *rt) | 74 | static inline bool rt_is_input_route(const struct rtable *rt) |
| 75 | { | 75 | { |
| 76 | return rt->rt_route_iif != 0; | 76 | return rt->rt_route_iif != 0; |
| 77 | } | 77 | } |
| 78 | 78 | ||
| 79 | static inline bool rt_is_output_route(struct rtable *rt) | 79 | static inline bool rt_is_output_route(const struct rtable *rt) |
| 80 | { | 80 | { |
| 81 | return rt->rt_route_iif == 0; | 81 | return rt->rt_route_iif == 0; |
| 82 | } | 82 | } |
diff --git a/include/scsi/libfcoe.h b/include/scsi/libfcoe.h index d1e95c6ac776..5a35a2a2d3c5 100644 --- a/include/scsi/libfcoe.h +++ b/include/scsi/libfcoe.h | |||
| @@ -147,6 +147,7 @@ struct fcoe_ctlr { | |||
| 147 | u8 map_dest; | 147 | u8 map_dest; |
| 148 | u8 spma; | 148 | u8 spma; |
| 149 | u8 probe_tries; | 149 | u8 probe_tries; |
| 150 | u8 priority; | ||
| 150 | u8 dest_addr[ETH_ALEN]; | 151 | u8 dest_addr[ETH_ALEN]; |
| 151 | u8 ctl_src_addr[ETH_ALEN]; | 152 | u8 ctl_src_addr[ETH_ALEN]; |
| 152 | 153 | ||
| @@ -301,6 +302,7 @@ struct fcoe_percpu_s { | |||
| 301 | * @lport: The associated local port | 302 | * @lport: The associated local port |
| 302 | * @fcoe_pending_queue: The pending Rx queue of skbs | 303 | * @fcoe_pending_queue: The pending Rx queue of skbs |
| 303 | * @fcoe_pending_queue_active: Indicates if the pending queue is active | 304 | * @fcoe_pending_queue_active: Indicates if the pending queue is active |
| 305 | * @priority: Packet priority (DCB) | ||
| 304 | * @max_queue_depth: Max queue depth of pending queue | 306 | * @max_queue_depth: Max queue depth of pending queue |
| 305 | * @min_queue_depth: Min queue depth of pending queue | 307 | * @min_queue_depth: Min queue depth of pending queue |
| 306 | * @timer: The queue timer | 308 | * @timer: The queue timer |
| @@ -316,6 +318,7 @@ struct fcoe_port { | |||
| 316 | struct fc_lport *lport; | 318 | struct fc_lport *lport; |
| 317 | struct sk_buff_head fcoe_pending_queue; | 319 | struct sk_buff_head fcoe_pending_queue; |
| 318 | u8 fcoe_pending_queue_active; | 320 | u8 fcoe_pending_queue_active; |
| 321 | u8 priority; | ||
| 319 | u32 max_queue_depth; | 322 | u32 max_queue_depth; |
| 320 | u32 min_queue_depth; | 323 | u32 min_queue_depth; |
| 321 | struct timer_list timer; | 324 | struct timer_list timer; |
diff --git a/include/target/target_core_base.h b/include/target/target_core_base.h index 7f5fed3c89e1..6873c7dd9145 100644 --- a/include/target/target_core_base.h +++ b/include/target/target_core_base.h | |||
| @@ -103,9 +103,10 @@ enum se_cmd_flags_table { | |||
| 103 | SCF_SCSI_NON_DATA_CDB = 0x00000040, | 103 | SCF_SCSI_NON_DATA_CDB = 0x00000040, |
| 104 | SCF_SCSI_CDB_EXCEPTION = 0x00000080, | 104 | SCF_SCSI_CDB_EXCEPTION = 0x00000080, |
| 105 | SCF_SCSI_RESERVATION_CONFLICT = 0x00000100, | 105 | SCF_SCSI_RESERVATION_CONFLICT = 0x00000100, |
| 106 | SCF_SE_CMD_FAILED = 0x00000400, | 106 | SCF_FUA = 0x00000200, |
| 107 | SCF_SE_LUN_CMD = 0x00000800, | 107 | SCF_SE_LUN_CMD = 0x00000800, |
| 108 | SCF_SE_ALLOW_EOO = 0x00001000, | 108 | SCF_SE_ALLOW_EOO = 0x00001000, |
| 109 | SCF_BIDI = 0x00002000, | ||
| 109 | SCF_SENT_CHECK_CONDITION = 0x00004000, | 110 | SCF_SENT_CHECK_CONDITION = 0x00004000, |
| 110 | SCF_OVERFLOW_BIT = 0x00008000, | 111 | SCF_OVERFLOW_BIT = 0x00008000, |
| 111 | SCF_UNDERFLOW_BIT = 0x00010000, | 112 | SCF_UNDERFLOW_BIT = 0x00010000, |
| @@ -154,6 +155,7 @@ enum tcm_sense_reason_table { | |||
| 154 | TCM_CHECK_CONDITION_ABORT_CMD = 0x0d, | 155 | TCM_CHECK_CONDITION_ABORT_CMD = 0x0d, |
| 155 | TCM_CHECK_CONDITION_UNIT_ATTENTION = 0x0e, | 156 | TCM_CHECK_CONDITION_UNIT_ATTENTION = 0x0e, |
| 156 | TCM_CHECK_CONDITION_NOT_READY = 0x0f, | 157 | TCM_CHECK_CONDITION_NOT_READY = 0x0f, |
| 158 | TCM_RESERVATION_CONFLICT = 0x10, | ||
| 157 | }; | 159 | }; |
| 158 | 160 | ||
| 159 | struct se_obj { | 161 | struct se_obj { |
| @@ -211,7 +213,6 @@ struct t10_alua_lu_gp { | |||
| 211 | u16 lu_gp_id; | 213 | u16 lu_gp_id; |
| 212 | int lu_gp_valid_id; | 214 | int lu_gp_valid_id; |
| 213 | u32 lu_gp_members; | 215 | u32 lu_gp_members; |
| 214 | atomic_t lu_gp_shutdown; | ||
| 215 | atomic_t lu_gp_ref_cnt; | 216 | atomic_t lu_gp_ref_cnt; |
| 216 | spinlock_t lu_gp_lock; | 217 | spinlock_t lu_gp_lock; |
| 217 | struct config_group lu_gp_group; | 218 | struct config_group lu_gp_group; |
| @@ -422,11 +423,9 @@ struct se_cmd { | |||
| 422 | int sam_task_attr; | 423 | int sam_task_attr; |
| 423 | /* Transport protocol dependent state, see transport_state_table */ | 424 | /* Transport protocol dependent state, see transport_state_table */ |
| 424 | enum transport_state_table t_state; | 425 | enum transport_state_table t_state; |
| 425 | /* Transport specific error status */ | ||
| 426 | int transport_error_status; | ||
| 427 | /* Used to signal cmd->se_tfo->check_release_cmd() usage per cmd */ | 426 | /* Used to signal cmd->se_tfo->check_release_cmd() usage per cmd */ |
| 428 | int check_release:1; | 427 | unsigned check_release:1; |
| 429 | int cmd_wait_set:1; | 428 | unsigned cmd_wait_set:1; |
| 430 | /* See se_cmd_flags_table */ | 429 | /* See se_cmd_flags_table */ |
| 431 | u32 se_cmd_flags; | 430 | u32 se_cmd_flags; |
| 432 | u32 se_ordered_id; | 431 | u32 se_ordered_id; |
| @@ -441,13 +440,10 @@ struct se_cmd { | |||
| 441 | /* Used for sense data */ | 440 | /* Used for sense data */ |
| 442 | void *sense_buffer; | 441 | void *sense_buffer; |
| 443 | struct list_head se_delayed_node; | 442 | struct list_head se_delayed_node; |
| 444 | struct list_head se_ordered_node; | ||
| 445 | struct list_head se_lun_node; | 443 | struct list_head se_lun_node; |
| 446 | struct list_head se_qf_node; | 444 | struct list_head se_qf_node; |
| 447 | struct se_device *se_dev; | 445 | struct se_device *se_dev; |
| 448 | struct se_dev_entry *se_deve; | 446 | struct se_dev_entry *se_deve; |
| 449 | struct se_device *se_obj_ptr; | ||
| 450 | struct se_device *se_orig_obj_ptr; | ||
| 451 | struct se_lun *se_lun; | 447 | struct se_lun *se_lun; |
| 452 | /* Only used for internal passthrough and legacy TCM fabric modules */ | 448 | /* Only used for internal passthrough and legacy TCM fabric modules */ |
| 453 | struct se_session *se_sess; | 449 | struct se_session *se_sess; |
| @@ -463,8 +459,6 @@ struct se_cmd { | |||
| 463 | unsigned char __t_task_cdb[TCM_MAX_COMMAND_SIZE]; | 459 | unsigned char __t_task_cdb[TCM_MAX_COMMAND_SIZE]; |
| 464 | unsigned long long t_task_lba; | 460 | unsigned long long t_task_lba; |
| 465 | int t_tasks_failed; | 461 | int t_tasks_failed; |
| 466 | int t_tasks_fua; | ||
| 467 | bool t_tasks_bidi; | ||
| 468 | u32 t_tasks_sg_chained_no; | 462 | u32 t_tasks_sg_chained_no; |
| 469 | atomic_t t_fe_count; | 463 | atomic_t t_fe_count; |
| 470 | atomic_t t_se_count; | 464 | atomic_t t_se_count; |
| @@ -489,14 +483,6 @@ struct se_cmd { | |||
| 489 | 483 | ||
| 490 | struct work_struct work; | 484 | struct work_struct work; |
| 491 | 485 | ||
| 492 | /* | ||
| 493 | * Used for pre-registered fabric SGL passthrough WRITE and READ | ||
| 494 | * with the special SCF_PASSTHROUGH_CONTIG_TO_SG case for TCM_Loop | ||
| 495 | * and other HW target mode fabric modules. | ||
| 496 | */ | ||
| 497 | struct scatterlist *t_task_pt_sgl; | ||
| 498 | u32 t_task_pt_sgl_num; | ||
| 499 | |||
| 500 | struct scatterlist *t_data_sg; | 486 | struct scatterlist *t_data_sg; |
| 501 | unsigned int t_data_nents; | 487 | unsigned int t_data_nents; |
| 502 | struct scatterlist *t_bidi_data_sg; | 488 | struct scatterlist *t_bidi_data_sg; |
| @@ -562,7 +548,7 @@ struct se_node_acl { | |||
| 562 | } ____cacheline_aligned; | 548 | } ____cacheline_aligned; |
| 563 | 549 | ||
| 564 | struct se_session { | 550 | struct se_session { |
| 565 | int sess_tearing_down:1; | 551 | unsigned sess_tearing_down:1; |
| 566 | u64 sess_bin_isid; | 552 | u64 sess_bin_isid; |
| 567 | struct se_node_acl *se_node_acl; | 553 | struct se_node_acl *se_node_acl; |
| 568 | struct se_portal_group *se_tpg; | 554 | struct se_portal_group *se_tpg; |
| @@ -683,7 +669,6 @@ struct se_subsystem_dev { | |||
| 683 | struct t10_reservation t10_pr; | 669 | struct t10_reservation t10_pr; |
| 684 | spinlock_t se_dev_lock; | 670 | spinlock_t se_dev_lock; |
| 685 | void *se_dev_su_ptr; | 671 | void *se_dev_su_ptr; |
| 686 | struct list_head se_dev_node; | ||
| 687 | struct config_group se_dev_group; | 672 | struct config_group se_dev_group; |
| 688 | /* For T10 Reservations */ | 673 | /* For T10 Reservations */ |
| 689 | struct config_group se_dev_pr_group; | 674 | struct config_group se_dev_pr_group; |
| @@ -692,9 +677,6 @@ struct se_subsystem_dev { | |||
| 692 | } ____cacheline_aligned; | 677 | } ____cacheline_aligned; |
| 693 | 678 | ||
| 694 | struct se_device { | 679 | struct se_device { |
| 695 | /* Set to 1 if thread is NOT sleeping on thread_sem */ | ||
| 696 | u8 thread_active; | ||
| 697 | u8 dev_status_timer_flags; | ||
| 698 | /* RELATIVE TARGET PORT IDENTIFER Counter */ | 680 | /* RELATIVE TARGET PORT IDENTIFER Counter */ |
| 699 | u16 dev_rpti_counter; | 681 | u16 dev_rpti_counter; |
| 700 | /* Used for SAM Task Attribute ordering */ | 682 | /* Used for SAM Task Attribute ordering */ |
| @@ -719,14 +701,10 @@ struct se_device { | |||
| 719 | u64 write_bytes; | 701 | u64 write_bytes; |
| 720 | spinlock_t stats_lock; | 702 | spinlock_t stats_lock; |
| 721 | /* Active commands on this virtual SE device */ | 703 | /* Active commands on this virtual SE device */ |
| 722 | atomic_t active_cmds; | ||
| 723 | atomic_t simple_cmds; | 704 | atomic_t simple_cmds; |
| 724 | atomic_t depth_left; | 705 | atomic_t depth_left; |
| 725 | atomic_t dev_ordered_id; | 706 | atomic_t dev_ordered_id; |
| 726 | atomic_t dev_tur_active; | ||
| 727 | atomic_t execute_tasks; | 707 | atomic_t execute_tasks; |
| 728 | atomic_t dev_status_thr_count; | ||
| 729 | atomic_t dev_hoq_count; | ||
| 730 | atomic_t dev_ordered_sync; | 708 | atomic_t dev_ordered_sync; |
| 731 | atomic_t dev_qf_count; | 709 | atomic_t dev_qf_count; |
| 732 | struct se_obj dev_obj; | 710 | struct se_obj dev_obj; |
| @@ -734,14 +712,9 @@ struct se_device { | |||
| 734 | struct se_obj dev_export_obj; | 712 | struct se_obj dev_export_obj; |
| 735 | struct se_queue_obj dev_queue_obj; | 713 | struct se_queue_obj dev_queue_obj; |
| 736 | spinlock_t delayed_cmd_lock; | 714 | spinlock_t delayed_cmd_lock; |
| 737 | spinlock_t ordered_cmd_lock; | ||
| 738 | spinlock_t execute_task_lock; | 715 | spinlock_t execute_task_lock; |
| 739 | spinlock_t state_task_lock; | ||
| 740 | spinlock_t dev_alua_lock; | ||
| 741 | spinlock_t dev_reservation_lock; | 716 | spinlock_t dev_reservation_lock; |
| 742 | spinlock_t dev_state_lock; | ||
| 743 | spinlock_t dev_status_lock; | 717 | spinlock_t dev_status_lock; |
| 744 | spinlock_t dev_status_thr_lock; | ||
| 745 | spinlock_t se_port_lock; | 718 | spinlock_t se_port_lock; |
| 746 | spinlock_t se_tmr_lock; | 719 | spinlock_t se_tmr_lock; |
| 747 | spinlock_t qf_cmd_lock; | 720 | spinlock_t qf_cmd_lock; |
| @@ -753,14 +726,10 @@ struct se_device { | |||
| 753 | struct t10_pr_registration *dev_pr_res_holder; | 726 | struct t10_pr_registration *dev_pr_res_holder; |
| 754 | struct list_head dev_sep_list; | 727 | struct list_head dev_sep_list; |
| 755 | struct list_head dev_tmr_list; | 728 | struct list_head dev_tmr_list; |
| 756 | struct timer_list dev_status_timer; | ||
| 757 | /* Pointer to descriptor for processing thread */ | 729 | /* Pointer to descriptor for processing thread */ |
| 758 | struct task_struct *process_thread; | 730 | struct task_struct *process_thread; |
| 759 | pid_t process_thread_pid; | ||
| 760 | struct task_struct *dev_mgmt_thread; | ||
| 761 | struct work_struct qf_work_queue; | 731 | struct work_struct qf_work_queue; |
| 762 | struct list_head delayed_cmd_list; | 732 | struct list_head delayed_cmd_list; |
| 763 | struct list_head ordered_cmd_list; | ||
| 764 | struct list_head execute_task_list; | 733 | struct list_head execute_task_list; |
| 765 | struct list_head state_task_list; | 734 | struct list_head state_task_list; |
| 766 | struct list_head qf_cmd_list; | 735 | struct list_head qf_cmd_list; |
| @@ -771,8 +740,6 @@ struct se_device { | |||
| 771 | struct se_subsystem_api *transport; | 740 | struct se_subsystem_api *transport; |
| 772 | /* Linked list for struct se_hba struct se_device list */ | 741 | /* Linked list for struct se_hba struct se_device list */ |
| 773 | struct list_head dev_list; | 742 | struct list_head dev_list; |
| 774 | /* Linked list for struct se_global->g_se_dev_list */ | ||
| 775 | struct list_head g_se_dev_list; | ||
| 776 | } ____cacheline_aligned; | 743 | } ____cacheline_aligned; |
| 777 | 744 | ||
| 778 | struct se_hba { | 745 | struct se_hba { |
| @@ -834,7 +801,6 @@ struct se_port { | |||
| 834 | u32 sep_index; | 801 | u32 sep_index; |
| 835 | struct scsi_port_stats sep_stats; | 802 | struct scsi_port_stats sep_stats; |
| 836 | /* Used for ALUA Target Port Groups membership */ | 803 | /* Used for ALUA Target Port Groups membership */ |
| 837 | atomic_t sep_tg_pt_gp_active; | ||
| 838 | atomic_t sep_tg_pt_secondary_offline; | 804 | atomic_t sep_tg_pt_secondary_offline; |
| 839 | /* Used for PR ALL_TG_PT=1 */ | 805 | /* Used for PR ALL_TG_PT=1 */ |
| 840 | atomic_t sep_tg_pt_ref_cnt; | 806 | atomic_t sep_tg_pt_ref_cnt; |
diff --git a/include/target/target_core_transport.h b/include/target/target_core_transport.h index c16e9431dd01..dac4f2d859fd 100644 --- a/include/target/target_core_transport.h +++ b/include/target/target_core_transport.h | |||
| @@ -10,29 +10,6 @@ | |||
| 10 | 10 | ||
| 11 | #define PYX_TRANSPORT_STATUS_INTERVAL 5 /* In seconds */ | 11 | #define PYX_TRANSPORT_STATUS_INTERVAL 5 /* In seconds */ |
| 12 | 12 | ||
| 13 | #define PYX_TRANSPORT_SENT_TO_TRANSPORT 0 | ||
| 14 | #define PYX_TRANSPORT_WRITE_PENDING 1 | ||
| 15 | |||
| 16 | #define PYX_TRANSPORT_UNKNOWN_SAM_OPCODE -1 | ||
| 17 | #define PYX_TRANSPORT_HBA_QUEUE_FULL -2 | ||
| 18 | #define PYX_TRANSPORT_REQ_TOO_MANY_SECTORS -3 | ||
| 19 | #define PYX_TRANSPORT_OUT_OF_MEMORY_RESOURCES -4 | ||
| 20 | #define PYX_TRANSPORT_INVALID_CDB_FIELD -5 | ||
| 21 | #define PYX_TRANSPORT_INVALID_PARAMETER_LIST -6 | ||
| 22 | #define PYX_TRANSPORT_LU_COMM_FAILURE -7 | ||
| 23 | #define PYX_TRANSPORT_UNKNOWN_MODE_PAGE -8 | ||
| 24 | #define PYX_TRANSPORT_WRITE_PROTECTED -9 | ||
| 25 | #define PYX_TRANSPORT_RESERVATION_CONFLICT -10 | ||
| 26 | #define PYX_TRANSPORT_ILLEGAL_REQUEST -11 | ||
| 27 | #define PYX_TRANSPORT_USE_SENSE_REASON -12 | ||
| 28 | |||
| 29 | #ifndef SAM_STAT_RESERVATION_CONFLICT | ||
| 30 | #define SAM_STAT_RESERVATION_CONFLICT 0x18 | ||
| 31 | #endif | ||
| 32 | |||
| 33 | #define TRANSPORT_PLUGIN_FREE 0 | ||
| 34 | #define TRANSPORT_PLUGIN_REGISTERED 1 | ||
| 35 | |||
| 36 | #define TRANSPORT_PLUGIN_PHBA_PDEV 1 | 13 | #define TRANSPORT_PLUGIN_PHBA_PDEV 1 |
| 37 | #define TRANSPORT_PLUGIN_VHBA_PDEV 2 | 14 | #define TRANSPORT_PLUGIN_VHBA_PDEV 2 |
| 38 | #define TRANSPORT_PLUGIN_VHBA_VDEV 3 | 15 | #define TRANSPORT_PLUGIN_VHBA_VDEV 3 |
| @@ -158,7 +135,6 @@ extern int transport_generic_allocate_tasks(struct se_cmd *, unsigned char *); | |||
| 158 | extern int transport_handle_cdb_direct(struct se_cmd *); | 135 | extern int transport_handle_cdb_direct(struct se_cmd *); |
| 159 | extern int transport_generic_handle_cdb_map(struct se_cmd *); | 136 | extern int transport_generic_handle_cdb_map(struct se_cmd *); |
| 160 | extern int transport_generic_handle_data(struct se_cmd *); | 137 | extern int transport_generic_handle_data(struct se_cmd *); |
| 161 | extern void transport_new_cmd_failure(struct se_cmd *); | ||
| 162 | extern int transport_generic_handle_tmr(struct se_cmd *); | 138 | extern int transport_generic_handle_tmr(struct se_cmd *); |
| 163 | extern bool target_stop_task(struct se_task *task, unsigned long *flags); | 139 | extern bool target_stop_task(struct se_task *task, unsigned long *flags); |
| 164 | extern int transport_generic_map_mem_to_cmd(struct se_cmd *cmd, struct scatterlist *, u32, | 140 | extern int transport_generic_map_mem_to_cmd(struct se_cmd *cmd, struct scatterlist *, u32, |
diff --git a/include/video/omapdss.h b/include/video/omapdss.h index b66ebb2032c6..378c7ed6760b 100644 --- a/include/video/omapdss.h +++ b/include/video/omapdss.h | |||
| @@ -307,15 +307,8 @@ struct omap_dss_board_info { | |||
| 307 | void (*dsi_disable_pads)(int dsi_id, unsigned lane_mask); | 307 | void (*dsi_disable_pads)(int dsi_id, unsigned lane_mask); |
| 308 | }; | 308 | }; |
| 309 | 309 | ||
| 310 | #if defined(CONFIG_OMAP2_DSS_MODULE) || defined(CONFIG_OMAP2_DSS) | ||
| 311 | /* Init with the board info */ | 310 | /* Init with the board info */ |
| 312 | extern int omap_display_init(struct omap_dss_board_info *board_data); | 311 | extern int omap_display_init(struct omap_dss_board_info *board_data); |
| 313 | #else | ||
| 314 | static inline int omap_display_init(struct omap_dss_board_info *board_data) | ||
| 315 | { | ||
| 316 | return 0; | ||
| 317 | } | ||
| 318 | #endif | ||
| 319 | 312 | ||
| 320 | struct omap_display_platform_data { | 313 | struct omap_display_platform_data { |
| 321 | struct omap_dss_board_info *board_data; | 314 | struct omap_dss_board_info *board_data; |
diff --git a/ipc/mqueue.c b/ipc/mqueue.c index 2e0ecfcc881d..5b4293d9819d 100644 --- a/ipc/mqueue.c +++ b/ipc/mqueue.c | |||
| @@ -1269,7 +1269,7 @@ void mq_clear_sbinfo(struct ipc_namespace *ns) | |||
| 1269 | 1269 | ||
| 1270 | void mq_put_mnt(struct ipc_namespace *ns) | 1270 | void mq_put_mnt(struct ipc_namespace *ns) |
| 1271 | { | 1271 | { |
| 1272 | mntput(ns->mq_mnt); | 1272 | kern_unmount(ns->mq_mnt); |
| 1273 | } | 1273 | } |
| 1274 | 1274 | ||
| 1275 | static int __init init_mqueue_fs(void) | 1275 | static int __init init_mqueue_fs(void) |
| @@ -1291,11 +1291,9 @@ static int __init init_mqueue_fs(void) | |||
| 1291 | 1291 | ||
| 1292 | spin_lock_init(&mq_lock); | 1292 | spin_lock_init(&mq_lock); |
| 1293 | 1293 | ||
| 1294 | init_ipc_ns.mq_mnt = kern_mount_data(&mqueue_fs_type, &init_ipc_ns); | 1294 | error = mq_init_ns(&init_ipc_ns); |
| 1295 | if (IS_ERR(init_ipc_ns.mq_mnt)) { | 1295 | if (error) |
| 1296 | error = PTR_ERR(init_ipc_ns.mq_mnt); | ||
| 1297 | goto out_filesystem; | 1296 | goto out_filesystem; |
| 1298 | } | ||
| 1299 | 1297 | ||
| 1300 | return 0; | 1298 | return 0; |
| 1301 | 1299 | ||
diff --git a/ipc/msgutil.c b/ipc/msgutil.c index 8b5ce5d3f3ef..5652101cdac0 100644 --- a/ipc/msgutil.c +++ b/ipc/msgutil.c | |||
| @@ -27,11 +27,6 @@ DEFINE_SPINLOCK(mq_lock); | |||
| 27 | */ | 27 | */ |
| 28 | struct ipc_namespace init_ipc_ns = { | 28 | struct ipc_namespace init_ipc_ns = { |
| 29 | .count = ATOMIC_INIT(1), | 29 | .count = ATOMIC_INIT(1), |
| 30 | #ifdef CONFIG_POSIX_MQUEUE | ||
| 31 | .mq_queues_max = DFLT_QUEUESMAX, | ||
| 32 | .mq_msg_max = DFLT_MSGMAX, | ||
| 33 | .mq_msgsize_max = DFLT_MSGSIZEMAX, | ||
| 34 | #endif | ||
| 35 | .user_ns = &init_user_ns, | 30 | .user_ns = &init_user_ns, |
| 36 | }; | 31 | }; |
| 37 | 32 | ||
diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c index 5e828a2ca8e6..213c0351dad8 100644 --- a/kernel/cgroup_freezer.c +++ b/kernel/cgroup_freezer.c | |||
| @@ -153,6 +153,13 @@ static void freezer_destroy(struct cgroup_subsys *ss, | |||
| 153 | kfree(cgroup_freezer(cgroup)); | 153 | kfree(cgroup_freezer(cgroup)); |
| 154 | } | 154 | } |
| 155 | 155 | ||
| 156 | /* task is frozen or will freeze immediately when next it gets woken */ | ||
| 157 | static bool is_task_frozen_enough(struct task_struct *task) | ||
| 158 | { | ||
| 159 | return frozen(task) || | ||
| 160 | (task_is_stopped_or_traced(task) && freezing(task)); | ||
| 161 | } | ||
| 162 | |||
| 156 | /* | 163 | /* |
| 157 | * The call to cgroup_lock() in the freezer.state write method prevents | 164 | * The call to cgroup_lock() in the freezer.state write method prevents |
| 158 | * a write to that file racing against an attach, and hence the | 165 | * a write to that file racing against an attach, and hence the |
| @@ -231,7 +238,7 @@ static void update_if_frozen(struct cgroup *cgroup, | |||
| 231 | cgroup_iter_start(cgroup, &it); | 238 | cgroup_iter_start(cgroup, &it); |
| 232 | while ((task = cgroup_iter_next(cgroup, &it))) { | 239 | while ((task = cgroup_iter_next(cgroup, &it))) { |
| 233 | ntotal++; | 240 | ntotal++; |
| 234 | if (frozen(task)) | 241 | if (is_task_frozen_enough(task)) |
| 235 | nfrozen++; | 242 | nfrozen++; |
| 236 | } | 243 | } |
| 237 | 244 | ||
| @@ -284,7 +291,7 @@ static int try_to_freeze_cgroup(struct cgroup *cgroup, struct freezer *freezer) | |||
| 284 | while ((task = cgroup_iter_next(cgroup, &it))) { | 291 | while ((task = cgroup_iter_next(cgroup, &it))) { |
| 285 | if (!freeze_task(task, true)) | 292 | if (!freeze_task(task, true)) |
| 286 | continue; | 293 | continue; |
| 287 | if (frozen(task)) | 294 | if (is_task_frozen_enough(task)) |
| 288 | continue; | 295 | continue; |
| 289 | if (!freezing(task) && !freezer_should_skip(task)) | 296 | if (!freezing(task) && !freezer_should_skip(task)) |
| 290 | num_cant_freeze_now++; | 297 | num_cant_freeze_now++; |
diff --git a/kernel/events/core.c b/kernel/events/core.c index 0e8457da6f95..58690af323e4 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c | |||
| @@ -185,6 +185,9 @@ static void cpu_ctx_sched_in(struct perf_cpu_context *cpuctx, | |||
| 185 | static void update_context_time(struct perf_event_context *ctx); | 185 | static void update_context_time(struct perf_event_context *ctx); |
| 186 | static u64 perf_event_time(struct perf_event *event); | 186 | static u64 perf_event_time(struct perf_event *event); |
| 187 | 187 | ||
| 188 | static void ring_buffer_attach(struct perf_event *event, | ||
| 189 | struct ring_buffer *rb); | ||
| 190 | |||
| 188 | void __weak perf_event_print_debug(void) { } | 191 | void __weak perf_event_print_debug(void) { } |
| 189 | 192 | ||
| 190 | extern __weak const char *perf_pmu_name(void) | 193 | extern __weak const char *perf_pmu_name(void) |
| @@ -2171,9 +2174,10 @@ static void perf_event_context_sched_in(struct perf_event_context *ctx, | |||
| 2171 | */ | 2174 | */ |
| 2172 | cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); | 2175 | cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); |
| 2173 | 2176 | ||
| 2174 | perf_event_sched_in(cpuctx, ctx, task); | 2177 | if (ctx->nr_events) |
| 2178 | cpuctx->task_ctx = ctx; | ||
| 2175 | 2179 | ||
| 2176 | cpuctx->task_ctx = ctx; | 2180 | perf_event_sched_in(cpuctx, cpuctx->task_ctx, task); |
| 2177 | 2181 | ||
| 2178 | perf_pmu_enable(ctx->pmu); | 2182 | perf_pmu_enable(ctx->pmu); |
| 2179 | perf_ctx_unlock(cpuctx, ctx); | 2183 | perf_ctx_unlock(cpuctx, ctx); |
| @@ -3190,12 +3194,33 @@ static unsigned int perf_poll(struct file *file, poll_table *wait) | |||
| 3190 | struct ring_buffer *rb; | 3194 | struct ring_buffer *rb; |
| 3191 | unsigned int events = POLL_HUP; | 3195 | unsigned int events = POLL_HUP; |
| 3192 | 3196 | ||
| 3197 | /* | ||
| 3198 | * Race between perf_event_set_output() and perf_poll(): perf_poll() | ||
| 3199 | * grabs the rb reference but perf_event_set_output() overrides it. | ||
| 3200 | * Here is the timeline for two threads T1, T2: | ||
| 3201 | * t0: T1, rb = rcu_dereference(event->rb) | ||
| 3202 | * t1: T2, old_rb = event->rb | ||
| 3203 | * t2: T2, event->rb = new rb | ||
| 3204 | * t3: T2, ring_buffer_detach(old_rb) | ||
| 3205 | * t4: T1, ring_buffer_attach(rb1) | ||
| 3206 | * t5: T1, poll_wait(event->waitq) | ||
| 3207 | * | ||
| 3208 | * To avoid this problem, we grab mmap_mutex in perf_poll() | ||
| 3209 | * thereby ensuring that the assignment of the new ring buffer | ||
| 3210 | * and the detachment of the old buffer appear atomic to perf_poll() | ||
| 3211 | */ | ||
| 3212 | mutex_lock(&event->mmap_mutex); | ||
| 3213 | |||
| 3193 | rcu_read_lock(); | 3214 | rcu_read_lock(); |
| 3194 | rb = rcu_dereference(event->rb); | 3215 | rb = rcu_dereference(event->rb); |
| 3195 | if (rb) | 3216 | if (rb) { |
| 3217 | ring_buffer_attach(event, rb); | ||
| 3196 | events = atomic_xchg(&rb->poll, 0); | 3218 | events = atomic_xchg(&rb->poll, 0); |
| 3219 | } | ||
| 3197 | rcu_read_unlock(); | 3220 | rcu_read_unlock(); |
| 3198 | 3221 | ||
| 3222 | mutex_unlock(&event->mmap_mutex); | ||
| 3223 | |||
| 3199 | poll_wait(file, &event->waitq, wait); | 3224 | poll_wait(file, &event->waitq, wait); |
| 3200 | 3225 | ||
| 3201 | return events; | 3226 | return events; |
| @@ -3496,6 +3521,53 @@ unlock: | |||
| 3496 | return ret; | 3521 | return ret; |
| 3497 | } | 3522 | } |
| 3498 | 3523 | ||
| 3524 | static void ring_buffer_attach(struct perf_event *event, | ||
| 3525 | struct ring_buffer *rb) | ||
| 3526 | { | ||
| 3527 | unsigned long flags; | ||
| 3528 | |||
| 3529 | if (!list_empty(&event->rb_entry)) | ||
| 3530 | return; | ||
| 3531 | |||
| 3532 | spin_lock_irqsave(&rb->event_lock, flags); | ||
| 3533 | if (!list_empty(&event->rb_entry)) | ||
| 3534 | goto unlock; | ||
| 3535 | |||
| 3536 | list_add(&event->rb_entry, &rb->event_list); | ||
| 3537 | unlock: | ||
| 3538 | spin_unlock_irqrestore(&rb->event_lock, flags); | ||
| 3539 | } | ||
| 3540 | |||
| 3541 | static void ring_buffer_detach(struct perf_event *event, | ||
| 3542 | struct ring_buffer *rb) | ||
| 3543 | { | ||
| 3544 | unsigned long flags; | ||
| 3545 | |||
| 3546 | if (list_empty(&event->rb_entry)) | ||
| 3547 | return; | ||
| 3548 | |||
| 3549 | spin_lock_irqsave(&rb->event_lock, flags); | ||
| 3550 | list_del_init(&event->rb_entry); | ||
| 3551 | wake_up_all(&event->waitq); | ||
| 3552 | spin_unlock_irqrestore(&rb->event_lock, flags); | ||
| 3553 | } | ||
| 3554 | |||
| 3555 | static void ring_buffer_wakeup(struct perf_event *event) | ||
| 3556 | { | ||
| 3557 | struct ring_buffer *rb; | ||
| 3558 | |||
| 3559 | rcu_read_lock(); | ||
| 3560 | rb = rcu_dereference(event->rb); | ||
| 3561 | if (!rb) | ||
| 3562 | goto unlock; | ||
| 3563 | |||
| 3564 | list_for_each_entry_rcu(event, &rb->event_list, rb_entry) | ||
| 3565 | wake_up_all(&event->waitq); | ||
| 3566 | |||
| 3567 | unlock: | ||
| 3568 | rcu_read_unlock(); | ||
| 3569 | } | ||
| 3570 | |||
| 3499 | static void rb_free_rcu(struct rcu_head *rcu_head) | 3571 | static void rb_free_rcu(struct rcu_head *rcu_head) |
| 3500 | { | 3572 | { |
| 3501 | struct ring_buffer *rb; | 3573 | struct ring_buffer *rb; |
| @@ -3521,9 +3593,19 @@ static struct ring_buffer *ring_buffer_get(struct perf_event *event) | |||
| 3521 | 3593 | ||
| 3522 | static void ring_buffer_put(struct ring_buffer *rb) | 3594 | static void ring_buffer_put(struct ring_buffer *rb) |
| 3523 | { | 3595 | { |
| 3596 | struct perf_event *event, *n; | ||
| 3597 | unsigned long flags; | ||
| 3598 | |||
| 3524 | if (!atomic_dec_and_test(&rb->refcount)) | 3599 | if (!atomic_dec_and_test(&rb->refcount)) |
| 3525 | return; | 3600 | return; |
| 3526 | 3601 | ||
| 3602 | spin_lock_irqsave(&rb->event_lock, flags); | ||
| 3603 | list_for_each_entry_safe(event, n, &rb->event_list, rb_entry) { | ||
| 3604 | list_del_init(&event->rb_entry); | ||
| 3605 | wake_up_all(&event->waitq); | ||
| 3606 | } | ||
| 3607 | spin_unlock_irqrestore(&rb->event_lock, flags); | ||
| 3608 | |||
| 3527 | call_rcu(&rb->rcu_head, rb_free_rcu); | 3609 | call_rcu(&rb->rcu_head, rb_free_rcu); |
| 3528 | } | 3610 | } |
| 3529 | 3611 | ||
| @@ -3546,6 +3628,7 @@ static void perf_mmap_close(struct vm_area_struct *vma) | |||
| 3546 | atomic_long_sub((size >> PAGE_SHIFT) + 1, &user->locked_vm); | 3628 | atomic_long_sub((size >> PAGE_SHIFT) + 1, &user->locked_vm); |
| 3547 | vma->vm_mm->pinned_vm -= event->mmap_locked; | 3629 | vma->vm_mm->pinned_vm -= event->mmap_locked; |
| 3548 | rcu_assign_pointer(event->rb, NULL); | 3630 | rcu_assign_pointer(event->rb, NULL); |
| 3631 | ring_buffer_detach(event, rb); | ||
| 3549 | mutex_unlock(&event->mmap_mutex); | 3632 | mutex_unlock(&event->mmap_mutex); |
| 3550 | 3633 | ||
| 3551 | ring_buffer_put(rb); | 3634 | ring_buffer_put(rb); |
| @@ -3700,7 +3783,7 @@ static const struct file_operations perf_fops = { | |||
| 3700 | 3783 | ||
| 3701 | void perf_event_wakeup(struct perf_event *event) | 3784 | void perf_event_wakeup(struct perf_event *event) |
| 3702 | { | 3785 | { |
| 3703 | wake_up_all(&event->waitq); | 3786 | ring_buffer_wakeup(event); |
| 3704 | 3787 | ||
| 3705 | if (event->pending_kill) { | 3788 | if (event->pending_kill) { |
| 3706 | kill_fasync(&event->fasync, SIGIO, event->pending_kill); | 3789 | kill_fasync(&event->fasync, SIGIO, event->pending_kill); |
| @@ -5822,6 +5905,8 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu, | |||
| 5822 | INIT_LIST_HEAD(&event->group_entry); | 5905 | INIT_LIST_HEAD(&event->group_entry); |
| 5823 | INIT_LIST_HEAD(&event->event_entry); | 5906 | INIT_LIST_HEAD(&event->event_entry); |
| 5824 | INIT_LIST_HEAD(&event->sibling_list); | 5907 | INIT_LIST_HEAD(&event->sibling_list); |
| 5908 | INIT_LIST_HEAD(&event->rb_entry); | ||
| 5909 | |||
| 5825 | init_waitqueue_head(&event->waitq); | 5910 | init_waitqueue_head(&event->waitq); |
| 5826 | init_irq_work(&event->pending, perf_pending_event); | 5911 | init_irq_work(&event->pending, perf_pending_event); |
| 5827 | 5912 | ||
| @@ -6028,6 +6113,8 @@ set: | |||
| 6028 | 6113 | ||
| 6029 | old_rb = event->rb; | 6114 | old_rb = event->rb; |
| 6030 | rcu_assign_pointer(event->rb, rb); | 6115 | rcu_assign_pointer(event->rb, rb); |
| 6116 | if (old_rb) | ||
| 6117 | ring_buffer_detach(event, old_rb); | ||
| 6031 | ret = 0; | 6118 | ret = 0; |
| 6032 | unlock: | 6119 | unlock: |
| 6033 | mutex_unlock(&event->mmap_mutex); | 6120 | mutex_unlock(&event->mmap_mutex); |
diff --git a/kernel/events/internal.h b/kernel/events/internal.h index 09097dd8116c..64568a699375 100644 --- a/kernel/events/internal.h +++ b/kernel/events/internal.h | |||
| @@ -22,6 +22,9 @@ struct ring_buffer { | |||
| 22 | local_t lost; /* nr records lost */ | 22 | local_t lost; /* nr records lost */ |
| 23 | 23 | ||
| 24 | long watermark; /* wakeup watermark */ | 24 | long watermark; /* wakeup watermark */ |
| 25 | /* poll crap */ | ||
| 26 | spinlock_t event_lock; | ||
| 27 | struct list_head event_list; | ||
| 25 | 28 | ||
| 26 | struct perf_event_mmap_page *user_page; | 29 | struct perf_event_mmap_page *user_page; |
| 27 | void *data_pages[0]; | 30 | void *data_pages[0]; |
diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c index a2a29205cc0f..7f3011c6b57f 100644 --- a/kernel/events/ring_buffer.c +++ b/kernel/events/ring_buffer.c | |||
| @@ -209,6 +209,9 @@ ring_buffer_init(struct ring_buffer *rb, long watermark, int flags) | |||
| 209 | rb->writable = 1; | 209 | rb->writable = 1; |
| 210 | 210 | ||
| 211 | atomic_set(&rb->refcount, 1); | 211 | atomic_set(&rb->refcount, 1); |
| 212 | |||
| 213 | INIT_LIST_HEAD(&rb->event_list); | ||
| 214 | spin_lock_init(&rb->event_lock); | ||
| 212 | } | 215 | } |
| 213 | 216 | ||
| 214 | #ifndef CONFIG_PERF_USE_VMALLOC | 217 | #ifndef CONFIG_PERF_USE_VMALLOC |
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 422e567eecf6..ae34bf51682b 100644 --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c | |||
| @@ -885,10 +885,13 @@ static void __remove_hrtimer(struct hrtimer *timer, | |||
| 885 | struct hrtimer_clock_base *base, | 885 | struct hrtimer_clock_base *base, |
| 886 | unsigned long newstate, int reprogram) | 886 | unsigned long newstate, int reprogram) |
| 887 | { | 887 | { |
| 888 | struct timerqueue_node *next_timer; | ||
| 888 | if (!(timer->state & HRTIMER_STATE_ENQUEUED)) | 889 | if (!(timer->state & HRTIMER_STATE_ENQUEUED)) |
| 889 | goto out; | 890 | goto out; |
| 890 | 891 | ||
| 891 | if (&timer->node == timerqueue_getnext(&base->active)) { | 892 | next_timer = timerqueue_getnext(&base->active); |
| 893 | timerqueue_del(&base->active, &timer->node); | ||
| 894 | if (&timer->node == next_timer) { | ||
| 892 | #ifdef CONFIG_HIGH_RES_TIMERS | 895 | #ifdef CONFIG_HIGH_RES_TIMERS |
| 893 | /* Reprogram the clock event device. if enabled */ | 896 | /* Reprogram the clock event device. if enabled */ |
| 894 | if (reprogram && hrtimer_hres_active()) { | 897 | if (reprogram && hrtimer_hres_active()) { |
| @@ -901,7 +904,6 @@ static void __remove_hrtimer(struct hrtimer *timer, | |||
| 901 | } | 904 | } |
| 902 | #endif | 905 | #endif |
| 903 | } | 906 | } |
| 904 | timerqueue_del(&base->active, &timer->node); | ||
| 905 | if (!timerqueue_getnext(&base->active)) | 907 | if (!timerqueue_getnext(&base->active)) |
| 906 | base->cpu_base->active_bases &= ~(1 << base->index); | 908 | base->cpu_base->active_bases &= ~(1 << base->index); |
| 907 | out: | 909 | out: |
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 67ce837ae52c..1da999f5e746 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
| @@ -623,8 +623,9 @@ static irqreturn_t irq_nested_primary_handler(int irq, void *dev_id) | |||
| 623 | 623 | ||
| 624 | static int irq_wait_for_interrupt(struct irqaction *action) | 624 | static int irq_wait_for_interrupt(struct irqaction *action) |
| 625 | { | 625 | { |
| 626 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 627 | |||
| 626 | while (!kthread_should_stop()) { | 628 | while (!kthread_should_stop()) { |
| 627 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 628 | 629 | ||
| 629 | if (test_and_clear_bit(IRQTF_RUNTHREAD, | 630 | if (test_and_clear_bit(IRQTF_RUNTHREAD, |
| 630 | &action->thread_flags)) { | 631 | &action->thread_flags)) { |
| @@ -632,7 +633,9 @@ static int irq_wait_for_interrupt(struct irqaction *action) | |||
| 632 | return 0; | 633 | return 0; |
| 633 | } | 634 | } |
| 634 | schedule(); | 635 | schedule(); |
| 636 | set_current_state(TASK_INTERRUPTIBLE); | ||
| 635 | } | 637 | } |
| 638 | __set_current_state(TASK_RUNNING); | ||
| 636 | return -1; | 639 | return -1; |
| 637 | } | 640 | } |
| 638 | 641 | ||
| @@ -1596,7 +1599,7 @@ int request_percpu_irq(unsigned int irq, irq_handler_t handler, | |||
| 1596 | return -ENOMEM; | 1599 | return -ENOMEM; |
| 1597 | 1600 | ||
| 1598 | action->handler = handler; | 1601 | action->handler = handler; |
| 1599 | action->flags = IRQF_PERCPU; | 1602 | action->flags = IRQF_PERCPU | IRQF_NO_SUSPEND; |
| 1600 | action->name = devname; | 1603 | action->name = devname; |
| 1601 | action->percpu_dev_id = dev_id; | 1604 | action->percpu_dev_id = dev_id; |
| 1602 | 1605 | ||
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index b5f4742693c0..dc813a948be2 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c | |||
| @@ -84,7 +84,9 @@ static int try_one_irq(int irq, struct irq_desc *desc, bool force) | |||
| 84 | */ | 84 | */ |
| 85 | action = desc->action; | 85 | action = desc->action; |
| 86 | if (!action || !(action->flags & IRQF_SHARED) || | 86 | if (!action || !(action->flags & IRQF_SHARED) || |
| 87 | (action->flags & __IRQF_TIMER) || !action->next) | 87 | (action->flags & __IRQF_TIMER) || |
| 88 | (action->handler(irq, action->dev_id) == IRQ_HANDLED) || | ||
| 89 | !action->next) | ||
| 88 | goto out; | 90 | goto out; |
| 89 | 91 | ||
| 90 | /* Already running on another processor */ | 92 | /* Already running on another processor */ |
diff --git a/kernel/jump_label.c b/kernel/jump_label.c index bbdfe2a462a0..66ff7109f697 100644 --- a/kernel/jump_label.c +++ b/kernel/jump_label.c | |||
| @@ -66,8 +66,9 @@ void jump_label_inc(struct jump_label_key *key) | |||
| 66 | return; | 66 | return; |
| 67 | 67 | ||
| 68 | jump_label_lock(); | 68 | jump_label_lock(); |
| 69 | if (atomic_add_return(1, &key->enabled) == 1) | 69 | if (atomic_read(&key->enabled) == 0) |
| 70 | jump_label_update(key, JUMP_LABEL_ENABLE); | 70 | jump_label_update(key, JUMP_LABEL_ENABLE); |
| 71 | atomic_inc(&key->enabled); | ||
| 71 | jump_label_unlock(); | 72 | jump_label_unlock(); |
| 72 | } | 73 | } |
| 73 | 74 | ||
diff --git a/kernel/lockdep.c b/kernel/lockdep.c index e69434b070da..b2e08c932d91 100644 --- a/kernel/lockdep.c +++ b/kernel/lockdep.c | |||
| @@ -44,6 +44,7 @@ | |||
| 44 | #include <linux/stringify.h> | 44 | #include <linux/stringify.h> |
| 45 | #include <linux/bitops.h> | 45 | #include <linux/bitops.h> |
| 46 | #include <linux/gfp.h> | 46 | #include <linux/gfp.h> |
| 47 | #include <linux/kmemcheck.h> | ||
| 47 | 48 | ||
| 48 | #include <asm/sections.h> | 49 | #include <asm/sections.h> |
| 49 | 50 | ||
| @@ -2948,7 +2949,12 @@ static int mark_lock(struct task_struct *curr, struct held_lock *this, | |||
| 2948 | void lockdep_init_map(struct lockdep_map *lock, const char *name, | 2949 | void lockdep_init_map(struct lockdep_map *lock, const char *name, |
| 2949 | struct lock_class_key *key, int subclass) | 2950 | struct lock_class_key *key, int subclass) |
| 2950 | { | 2951 | { |
| 2951 | memset(lock, 0, sizeof(*lock)); | 2952 | int i; |
| 2953 | |||
| 2954 | kmemcheck_mark_initialized(lock, sizeof(*lock)); | ||
| 2955 | |||
| 2956 | for (i = 0; i < NR_LOCKDEP_CACHING_CLASSES; i++) | ||
| 2957 | lock->class_cache[i] = NULL; | ||
| 2952 | 2958 | ||
| 2953 | #ifdef CONFIG_LOCK_STAT | 2959 | #ifdef CONFIG_LOCK_STAT |
| 2954 | lock->cpu = raw_smp_processor_id(); | 2960 | lock->cpu = raw_smp_processor_id(); |
diff --git a/kernel/printk.c b/kernel/printk.c index 1455a0d4eedd..7982a0a841ea 100644 --- a/kernel/printk.c +++ b/kernel/printk.c | |||
| @@ -1293,10 +1293,11 @@ again: | |||
| 1293 | raw_spin_lock(&logbuf_lock); | 1293 | raw_spin_lock(&logbuf_lock); |
| 1294 | if (con_start != log_end) | 1294 | if (con_start != log_end) |
| 1295 | retry = 1; | 1295 | retry = 1; |
| 1296 | raw_spin_unlock_irqrestore(&logbuf_lock, flags); | ||
| 1297 | |||
| 1296 | if (retry && console_trylock()) | 1298 | if (retry && console_trylock()) |
| 1297 | goto again; | 1299 | goto again; |
| 1298 | 1300 | ||
| 1299 | raw_spin_unlock_irqrestore(&logbuf_lock, flags); | ||
| 1300 | if (wake_klogd) | 1301 | if (wake_klogd) |
| 1301 | wake_up_klogd(); | 1302 | wake_up_klogd(); |
| 1302 | } | 1303 | } |
diff --git a/kernel/sched.c b/kernel/sched.c index 0e9344a71be3..d6b149ccf925 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
| @@ -71,6 +71,7 @@ | |||
| 71 | #include <linux/ctype.h> | 71 | #include <linux/ctype.h> |
| 72 | #include <linux/ftrace.h> | 72 | #include <linux/ftrace.h> |
| 73 | #include <linux/slab.h> | 73 | #include <linux/slab.h> |
| 74 | #include <linux/init_task.h> | ||
| 74 | 75 | ||
| 75 | #include <asm/tlb.h> | 76 | #include <asm/tlb.h> |
| 76 | #include <asm/irq_regs.h> | 77 | #include <asm/irq_regs.h> |
| @@ -4810,6 +4811,9 @@ EXPORT_SYMBOL(wait_for_completion); | |||
| 4810 | * This waits for either a completion of a specific task to be signaled or for a | 4811 | * This waits for either a completion of a specific task to be signaled or for a |
| 4811 | * specified timeout to expire. The timeout is in jiffies. It is not | 4812 | * specified timeout to expire. The timeout is in jiffies. It is not |
| 4812 | * interruptible. | 4813 | * interruptible. |
| 4814 | * | ||
| 4815 | * The return value is 0 if timed out, and positive (at least 1, or number of | ||
| 4816 | * jiffies left till timeout) if completed. | ||
| 4813 | */ | 4817 | */ |
| 4814 | unsigned long __sched | 4818 | unsigned long __sched |
| 4815 | wait_for_completion_timeout(struct completion *x, unsigned long timeout) | 4819 | wait_for_completion_timeout(struct completion *x, unsigned long timeout) |
| @@ -4824,6 +4828,8 @@ EXPORT_SYMBOL(wait_for_completion_timeout); | |||
| 4824 | * | 4828 | * |
| 4825 | * This waits for completion of a specific task to be signaled. It is | 4829 | * This waits for completion of a specific task to be signaled. It is |
| 4826 | * interruptible. | 4830 | * interruptible. |
| 4831 | * | ||
| 4832 | * The return value is -ERESTARTSYS if interrupted, 0 if completed. | ||
| 4827 | */ | 4833 | */ |
| 4828 | int __sched wait_for_completion_interruptible(struct completion *x) | 4834 | int __sched wait_for_completion_interruptible(struct completion *x) |
| 4829 | { | 4835 | { |
| @@ -4841,6 +4847,9 @@ EXPORT_SYMBOL(wait_for_completion_interruptible); | |||
| 4841 | * | 4847 | * |
| 4842 | * This waits for either a completion of a specific task to be signaled or for a | 4848 | * This waits for either a completion of a specific task to be signaled or for a |
| 4843 | * specified timeout to expire. It is interruptible. The timeout is in jiffies. | 4849 | * specified timeout to expire. It is interruptible. The timeout is in jiffies. |
| 4850 | * | ||
| 4851 | * The return value is -ERESTARTSYS if interrupted, 0 if timed out, | ||
| 4852 | * positive (at least 1, or number of jiffies left till timeout) if completed. | ||
| 4844 | */ | 4853 | */ |
| 4845 | long __sched | 4854 | long __sched |
| 4846 | wait_for_completion_interruptible_timeout(struct completion *x, | 4855 | wait_for_completion_interruptible_timeout(struct completion *x, |
| @@ -4856,6 +4865,8 @@ EXPORT_SYMBOL(wait_for_completion_interruptible_timeout); | |||
| 4856 | * | 4865 | * |
| 4857 | * This waits to be signaled for completion of a specific task. It can be | 4866 | * This waits to be signaled for completion of a specific task. It can be |
| 4858 | * interrupted by a kill signal. | 4867 | * interrupted by a kill signal. |
| 4868 | * | ||
| 4869 | * The return value is -ERESTARTSYS if interrupted, 0 if completed. | ||
| 4859 | */ | 4870 | */ |
| 4860 | int __sched wait_for_completion_killable(struct completion *x) | 4871 | int __sched wait_for_completion_killable(struct completion *x) |
| 4861 | { | 4872 | { |
| @@ -4874,6 +4885,9 @@ EXPORT_SYMBOL(wait_for_completion_killable); | |||
| 4874 | * This waits for either a completion of a specific task to be | 4885 | * This waits for either a completion of a specific task to be |
| 4875 | * signaled or for a specified timeout to expire. It can be | 4886 | * signaled or for a specified timeout to expire. It can be |
| 4876 | * interrupted by a kill signal. The timeout is in jiffies. | 4887 | * interrupted by a kill signal. The timeout is in jiffies. |
| 4888 | * | ||
| 4889 | * The return value is -ERESTARTSYS if interrupted, 0 if timed out, | ||
| 4890 | * positive (at least 1, or number of jiffies left till timeout) if completed. | ||
| 4877 | */ | 4891 | */ |
| 4878 | long __sched | 4892 | long __sched |
| 4879 | wait_for_completion_killable_timeout(struct completion *x, | 4893 | wait_for_completion_killable_timeout(struct completion *x, |
| @@ -6099,6 +6113,9 @@ void __cpuinit init_idle(struct task_struct *idle, int cpu) | |||
| 6099 | */ | 6113 | */ |
| 6100 | idle->sched_class = &idle_sched_class; | 6114 | idle->sched_class = &idle_sched_class; |
| 6101 | ftrace_graph_init_idle_task(idle, cpu); | 6115 | ftrace_graph_init_idle_task(idle, cpu); |
| 6116 | #if defined(CONFIG_SMP) | ||
| 6117 | sprintf(idle->comm, "%s/%d", INIT_TASK_COMM, cpu); | ||
| 6118 | #endif | ||
| 6102 | } | 6119 | } |
| 6103 | 6120 | ||
| 6104 | /* | 6121 | /* |
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 5c9e67923b7c..8a39fa3e3c6c 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c | |||
| @@ -772,19 +772,32 @@ static void update_cfs_load(struct cfs_rq *cfs_rq, int global_update) | |||
| 772 | list_del_leaf_cfs_rq(cfs_rq); | 772 | list_del_leaf_cfs_rq(cfs_rq); |
| 773 | } | 773 | } |
| 774 | 774 | ||
| 775 | static inline long calc_tg_weight(struct task_group *tg, struct cfs_rq *cfs_rq) | ||
| 776 | { | ||
| 777 | long tg_weight; | ||
| 778 | |||
| 779 | /* | ||
| 780 | * Use this CPU's actual weight instead of the last load_contribution | ||
| 781 | * to gain a more accurate current total weight. See | ||
| 782 | * update_cfs_rq_load_contribution(). | ||
| 783 | */ | ||
| 784 | tg_weight = atomic_read(&tg->load_weight); | ||
| 785 | tg_weight -= cfs_rq->load_contribution; | ||
| 786 | tg_weight += cfs_rq->load.weight; | ||
| 787 | |||
| 788 | return tg_weight; | ||
| 789 | } | ||
| 790 | |||
| 775 | static long calc_cfs_shares(struct cfs_rq *cfs_rq, struct task_group *tg) | 791 | static long calc_cfs_shares(struct cfs_rq *cfs_rq, struct task_group *tg) |
| 776 | { | 792 | { |
| 777 | long load_weight, load, shares; | 793 | long tg_weight, load, shares; |
| 778 | 794 | ||
| 795 | tg_weight = calc_tg_weight(tg, cfs_rq); | ||
| 779 | load = cfs_rq->load.weight; | 796 | load = cfs_rq->load.weight; |
| 780 | 797 | ||
| 781 | load_weight = atomic_read(&tg->load_weight); | ||
| 782 | load_weight += load; | ||
| 783 | load_weight -= cfs_rq->load_contribution; | ||
| 784 | |||
| 785 | shares = (tg->shares * load); | 798 | shares = (tg->shares * load); |
| 786 | if (load_weight) | 799 | if (tg_weight) |
| 787 | shares /= load_weight; | 800 | shares /= tg_weight; |
| 788 | 801 | ||
| 789 | if (shares < MIN_SHARES) | 802 | if (shares < MIN_SHARES) |
| 790 | shares = MIN_SHARES; | 803 | shares = MIN_SHARES; |
| @@ -1743,7 +1756,7 @@ static void __return_cfs_rq_runtime(struct cfs_rq *cfs_rq) | |||
| 1743 | 1756 | ||
| 1744 | static __always_inline void return_cfs_rq_runtime(struct cfs_rq *cfs_rq) | 1757 | static __always_inline void return_cfs_rq_runtime(struct cfs_rq *cfs_rq) |
| 1745 | { | 1758 | { |
| 1746 | if (!cfs_rq->runtime_enabled || !cfs_rq->nr_running) | 1759 | if (!cfs_rq->runtime_enabled || cfs_rq->nr_running) |
| 1747 | return; | 1760 | return; |
| 1748 | 1761 | ||
| 1749 | __return_cfs_rq_runtime(cfs_rq); | 1762 | __return_cfs_rq_runtime(cfs_rq); |
| @@ -2036,36 +2049,100 @@ static void task_waking_fair(struct task_struct *p) | |||
| 2036 | * Adding load to a group doesn't make a group heavier, but can cause movement | 2049 | * Adding load to a group doesn't make a group heavier, but can cause movement |
| 2037 | * of group shares between cpus. Assuming the shares were perfectly aligned one | 2050 | * of group shares between cpus. Assuming the shares were perfectly aligned one |
| 2038 | * can calculate the shift in shares. | 2051 | * can calculate the shift in shares. |
| 2052 | * | ||
| 2053 | * Calculate the effective load difference if @wl is added (subtracted) to @tg | ||
| 2054 | * on this @cpu and results in a total addition (subtraction) of @wg to the | ||
| 2055 | * total group weight. | ||
| 2056 | * | ||
| 2057 | * Given a runqueue weight distribution (rw_i) we can compute a shares | ||
| 2058 | * distribution (s_i) using: | ||
| 2059 | * | ||
| 2060 | * s_i = rw_i / \Sum rw_j (1) | ||
| 2061 | * | ||
| 2062 | * Suppose we have 4 CPUs and our @tg is a direct child of the root group and | ||
| 2063 | * has 7 equal weight tasks, distributed as below (rw_i), with the resulting | ||
| 2064 | * shares distribution (s_i): | ||
| 2065 | * | ||
| 2066 | * rw_i = { 2, 4, 1, 0 } | ||
| 2067 | * s_i = { 2/7, 4/7, 1/7, 0 } | ||
| 2068 | * | ||
| 2069 | * As per wake_affine() we're interested in the load of two CPUs (the CPU the | ||
| 2070 | * task used to run on and the CPU the waker is running on), we need to | ||
| 2071 | * compute the effect of waking a task on either CPU and, in case of a sync | ||
| 2072 | * wakeup, compute the effect of the current task going to sleep. | ||
| 2073 | * | ||
| 2074 | * So for a change of @wl to the local @cpu with an overall group weight change | ||
| 2075 | * of @wl we can compute the new shares distribution (s'_i) using: | ||
| 2076 | * | ||
| 2077 | * s'_i = (rw_i + @wl) / (@wg + \Sum rw_j) (2) | ||
| 2078 | * | ||
| 2079 | * Suppose we're interested in CPUs 0 and 1, and want to compute the load | ||
| 2080 | * differences in waking a task to CPU 0. The additional task changes the | ||
| 2081 | * weight and shares distributions like: | ||
| 2082 | * | ||
| 2083 | * rw'_i = { 3, 4, 1, 0 } | ||
| 2084 | * s'_i = { 3/8, 4/8, 1/8, 0 } | ||
| 2085 | * | ||
| 2086 | * We can then compute the difference in effective weight by using: | ||
| 2087 | * | ||
| 2088 | * dw_i = S * (s'_i - s_i) (3) | ||
| 2089 | * | ||
| 2090 | * Where 'S' is the group weight as seen by its parent. | ||
| 2091 | * | ||
| 2092 | * Therefore the effective change in loads on CPU 0 would be 5/56 (3/8 - 2/7) | ||
| 2093 | * times the weight of the group. The effect on CPU 1 would be -4/56 (4/8 - | ||
| 2094 | * 4/7) times the weight of the group. | ||
| 2039 | */ | 2095 | */ |
| 2040 | static long effective_load(struct task_group *tg, int cpu, long wl, long wg) | 2096 | static long effective_load(struct task_group *tg, int cpu, long wl, long wg) |
| 2041 | { | 2097 | { |
| 2042 | struct sched_entity *se = tg->se[cpu]; | 2098 | struct sched_entity *se = tg->se[cpu]; |
| 2043 | 2099 | ||
| 2044 | if (!tg->parent) | 2100 | if (!tg->parent) /* the trivial, non-cgroup case */ |
| 2045 | return wl; | 2101 | return wl; |
| 2046 | 2102 | ||
| 2047 | for_each_sched_entity(se) { | 2103 | for_each_sched_entity(se) { |
| 2048 | long lw, w; | 2104 | long w, W; |
| 2049 | 2105 | ||
| 2050 | tg = se->my_q->tg; | 2106 | tg = se->my_q->tg; |
| 2051 | w = se->my_q->load.weight; | ||
| 2052 | 2107 | ||
| 2053 | /* use this cpu's instantaneous contribution */ | 2108 | /* |
| 2054 | lw = atomic_read(&tg->load_weight); | 2109 | * W = @wg + \Sum rw_j |
| 2055 | lw -= se->my_q->load_contribution; | 2110 | */ |
| 2056 | lw += w + wg; | 2111 | W = wg + calc_tg_weight(tg, se->my_q); |
| 2057 | 2112 | ||
| 2058 | wl += w; | 2113 | /* |
| 2114 | * w = rw_i + @wl | ||
| 2115 | */ | ||
| 2116 | w = se->my_q->load.weight + wl; | ||
| 2059 | 2117 | ||
| 2060 | if (lw > 0 && wl < lw) | 2118 | /* |
| 2061 | wl = (wl * tg->shares) / lw; | 2119 | * wl = S * s'_i; see (2) |
| 2120 | */ | ||
| 2121 | if (W > 0 && w < W) | ||
| 2122 | wl = (w * tg->shares) / W; | ||
| 2062 | else | 2123 | else |
| 2063 | wl = tg->shares; | 2124 | wl = tg->shares; |
| 2064 | 2125 | ||
| 2065 | /* zero point is MIN_SHARES */ | 2126 | /* |
| 2127 | * Per the above, wl is the new se->load.weight value; since | ||
| 2128 | * those are clipped to [MIN_SHARES, ...) do so now. See | ||
| 2129 | * calc_cfs_shares(). | ||
| 2130 | */ | ||
| 2066 | if (wl < MIN_SHARES) | 2131 | if (wl < MIN_SHARES) |
| 2067 | wl = MIN_SHARES; | 2132 | wl = MIN_SHARES; |
| 2133 | |||
| 2134 | /* | ||
| 2135 | * wl = dw_i = S * (s'_i - s_i); see (3) | ||
| 2136 | */ | ||
| 2068 | wl -= se->load.weight; | 2137 | wl -= se->load.weight; |
| 2138 | |||
| 2139 | /* | ||
| 2140 | * Recursively apply this logic to all parent groups to compute | ||
| 2141 | * the final effective load change on the root group. Since | ||
| 2142 | * only the @tg group gets extra weight, all parent groups can | ||
| 2143 | * only redistribute existing shares. @wl is the shift in shares | ||
| 2144 | * resulting from this level per the above. | ||
| 2145 | */ | ||
| 2069 | wg = 0; | 2146 | wg = 0; |
| 2070 | } | 2147 | } |
| 2071 | 2148 | ||
| @@ -2249,7 +2326,8 @@ static int select_idle_sibling(struct task_struct *p, int target) | |||
| 2249 | int cpu = smp_processor_id(); | 2326 | int cpu = smp_processor_id(); |
| 2250 | int prev_cpu = task_cpu(p); | 2327 | int prev_cpu = task_cpu(p); |
| 2251 | struct sched_domain *sd; | 2328 | struct sched_domain *sd; |
| 2252 | int i; | 2329 | struct sched_group *sg; |
| 2330 | int i, smt = 0; | ||
| 2253 | 2331 | ||
| 2254 | /* | 2332 | /* |
| 2255 | * If the task is going to be woken-up on this cpu and if it is | 2333 | * If the task is going to be woken-up on this cpu and if it is |
| @@ -2269,25 +2347,40 @@ static int select_idle_sibling(struct task_struct *p, int target) | |||
| 2269 | * Otherwise, iterate the domains and find an elegible idle cpu. | 2347 | * Otherwise, iterate the domains and find an elegible idle cpu. |
| 2270 | */ | 2348 | */ |
| 2271 | rcu_read_lock(); | 2349 | rcu_read_lock(); |
| 2350 | again: | ||
| 2272 | for_each_domain(target, sd) { | 2351 | for_each_domain(target, sd) { |
| 2352 | if (!smt && (sd->flags & SD_SHARE_CPUPOWER)) | ||
| 2353 | continue; | ||
| 2354 | |||
| 2355 | if (smt && !(sd->flags & SD_SHARE_CPUPOWER)) | ||
| 2356 | break; | ||
| 2357 | |||
| 2273 | if (!(sd->flags & SD_SHARE_PKG_RESOURCES)) | 2358 | if (!(sd->flags & SD_SHARE_PKG_RESOURCES)) |
| 2274 | break; | 2359 | break; |
| 2275 | 2360 | ||
| 2276 | for_each_cpu_and(i, sched_domain_span(sd), tsk_cpus_allowed(p)) { | 2361 | sg = sd->groups; |
| 2277 | if (idle_cpu(i)) { | 2362 | do { |
| 2278 | target = i; | 2363 | if (!cpumask_intersects(sched_group_cpus(sg), |
| 2279 | break; | 2364 | tsk_cpus_allowed(p))) |
| 2365 | goto next; | ||
| 2366 | |||
| 2367 | for_each_cpu(i, sched_group_cpus(sg)) { | ||
| 2368 | if (!idle_cpu(i)) | ||
| 2369 | goto next; | ||
| 2280 | } | 2370 | } |
| 2281 | } | ||
| 2282 | 2371 | ||
| 2283 | /* | 2372 | target = cpumask_first_and(sched_group_cpus(sg), |
| 2284 | * Lets stop looking for an idle sibling when we reached | 2373 | tsk_cpus_allowed(p)); |
| 2285 | * the domain that spans the current cpu and prev_cpu. | 2374 | goto done; |
| 2286 | */ | 2375 | next: |
| 2287 | if (cpumask_test_cpu(cpu, sched_domain_span(sd)) && | 2376 | sg = sg->next; |
| 2288 | cpumask_test_cpu(prev_cpu, sched_domain_span(sd))) | 2377 | } while (sg != sd->groups); |
| 2289 | break; | 2378 | } |
| 2379 | if (!smt) { | ||
| 2380 | smt = 1; | ||
| 2381 | goto again; | ||
| 2290 | } | 2382 | } |
| 2383 | done: | ||
| 2291 | rcu_read_unlock(); | 2384 | rcu_read_unlock(); |
| 2292 | 2385 | ||
| 2293 | return target; | 2386 | return target; |
| @@ -3511,7 +3604,7 @@ static bool update_sd_pick_busiest(struct sched_domain *sd, | |||
| 3511 | } | 3604 | } |
| 3512 | 3605 | ||
| 3513 | /** | 3606 | /** |
| 3514 | * update_sd_lb_stats - Update sched_group's statistics for load balancing. | 3607 | * update_sd_lb_stats - Update sched_domain's statistics for load balancing. |
| 3515 | * @sd: sched_domain whose statistics are to be updated. | 3608 | * @sd: sched_domain whose statistics are to be updated. |
| 3516 | * @this_cpu: Cpu for which load balance is currently performed. | 3609 | * @this_cpu: Cpu for which load balance is currently performed. |
| 3517 | * @idle: Idle status of this_cpu | 3610 | * @idle: Idle status of this_cpu |
diff --git a/kernel/sched_features.h b/kernel/sched_features.h index efa0a7b75dde..84802245abd2 100644 --- a/kernel/sched_features.h +++ b/kernel/sched_features.h | |||
| @@ -67,3 +67,4 @@ SCHED_FEAT(NONTASK_POWER, 1) | |||
| 67 | SCHED_FEAT(TTWU_QUEUE, 1) | 67 | SCHED_FEAT(TTWU_QUEUE, 1) |
| 68 | 68 | ||
| 69 | SCHED_FEAT(FORCE_SD_OVERLAP, 0) | 69 | SCHED_FEAT(FORCE_SD_OVERLAP, 0) |
| 70 | SCHED_FEAT(RT_RUNTIME_SHARE, 1) | ||
diff --git a/kernel/sched_rt.c b/kernel/sched_rt.c index 056cbd2e2a27..583a1368afe6 100644 --- a/kernel/sched_rt.c +++ b/kernel/sched_rt.c | |||
| @@ -560,6 +560,9 @@ static int balance_runtime(struct rt_rq *rt_rq) | |||
| 560 | { | 560 | { |
| 561 | int more = 0; | 561 | int more = 0; |
| 562 | 562 | ||
| 563 | if (!sched_feat(RT_RUNTIME_SHARE)) | ||
| 564 | return more; | ||
| 565 | |||
| 563 | if (rt_rq->rt_time > rt_rq->rt_runtime) { | 566 | if (rt_rq->rt_time > rt_rq->rt_runtime) { |
| 564 | raw_spin_unlock(&rt_rq->rt_runtime_lock); | 567 | raw_spin_unlock(&rt_rq->rt_runtime_lock); |
| 565 | more = do_balance_runtime(rt_rq); | 568 | more = do_balance_runtime(rt_rq); |
diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c index c436e790b21b..8a46f5d64504 100644 --- a/kernel/time/alarmtimer.c +++ b/kernel/time/alarmtimer.c | |||
| @@ -195,7 +195,7 @@ static enum hrtimer_restart alarmtimer_fired(struct hrtimer *timer) | |||
| 195 | struct alarm *alarm; | 195 | struct alarm *alarm; |
| 196 | ktime_t expired = next->expires; | 196 | ktime_t expired = next->expires; |
| 197 | 197 | ||
| 198 | if (expired.tv64 >= now.tv64) | 198 | if (expired.tv64 > now.tv64) |
| 199 | break; | 199 | break; |
| 200 | 200 | ||
| 201 | alarm = container_of(next, struct alarm, node); | 201 | alarm = container_of(next, struct alarm, node); |
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 1ecd6ba36d6c..c4eb71c8b2ea 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c | |||
| @@ -387,6 +387,7 @@ void clockevents_exchange_device(struct clock_event_device *old, | |||
| 387 | * released list and do a notify add later. | 387 | * released list and do a notify add later. |
| 388 | */ | 388 | */ |
| 389 | if (old) { | 389 | if (old) { |
| 390 | old->event_handler = clockevents_handle_noop; | ||
| 390 | clockevents_set_mode(old, CLOCK_EVT_MODE_UNUSED); | 391 | clockevents_set_mode(old, CLOCK_EVT_MODE_UNUSED); |
| 391 | list_del(&old->list); | 392 | list_del(&old->list); |
| 392 | list_add(&old->list, &clockevents_released); | 393 | list_add(&old->list, &clockevents_released); |
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index cf52fda2e096..da2f760e780c 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c | |||
| @@ -492,6 +492,22 @@ void clocksource_touch_watchdog(void) | |||
| 492 | } | 492 | } |
| 493 | 493 | ||
| 494 | /** | 494 | /** |
| 495 | * clocksource_max_adjustment- Returns max adjustment amount | ||
| 496 | * @cs: Pointer to clocksource | ||
| 497 | * | ||
| 498 | */ | ||
| 499 | static u32 clocksource_max_adjustment(struct clocksource *cs) | ||
| 500 | { | ||
| 501 | u64 ret; | ||
| 502 | /* | ||
| 503 | * We won't try to correct for more then 11% adjustments (110,000 ppm), | ||
| 504 | */ | ||
| 505 | ret = (u64)cs->mult * 11; | ||
| 506 | do_div(ret,100); | ||
| 507 | return (u32)ret; | ||
| 508 | } | ||
| 509 | |||
| 510 | /** | ||
| 495 | * clocksource_max_deferment - Returns max time the clocksource can be deferred | 511 | * clocksource_max_deferment - Returns max time the clocksource can be deferred |
| 496 | * @cs: Pointer to clocksource | 512 | * @cs: Pointer to clocksource |
| 497 | * | 513 | * |
| @@ -503,25 +519,28 @@ static u64 clocksource_max_deferment(struct clocksource *cs) | |||
| 503 | /* | 519 | /* |
| 504 | * Calculate the maximum number of cycles that we can pass to the | 520 | * Calculate the maximum number of cycles that we can pass to the |
| 505 | * cyc2ns function without overflowing a 64-bit signed result. The | 521 | * cyc2ns function without overflowing a 64-bit signed result. The |
| 506 | * maximum number of cycles is equal to ULLONG_MAX/cs->mult which | 522 | * maximum number of cycles is equal to ULLONG_MAX/(cs->mult+cs->maxadj) |
| 507 | * is equivalent to the below. | 523 | * which is equivalent to the below. |
| 508 | * max_cycles < (2^63)/cs->mult | 524 | * max_cycles < (2^63)/(cs->mult + cs->maxadj) |
| 509 | * max_cycles < 2^(log2((2^63)/cs->mult)) | 525 | * max_cycles < 2^(log2((2^63)/(cs->mult + cs->maxadj))) |
| 510 | * max_cycles < 2^(log2(2^63) - log2(cs->mult)) | 526 | * max_cycles < 2^(log2(2^63) - log2(cs->mult + cs->maxadj)) |
| 511 | * max_cycles < 2^(63 - log2(cs->mult)) | 527 | * max_cycles < 2^(63 - log2(cs->mult + cs->maxadj)) |
| 512 | * max_cycles < 1 << (63 - log2(cs->mult)) | 528 | * max_cycles < 1 << (63 - log2(cs->mult + cs->maxadj)) |
| 513 | * Please note that we add 1 to the result of the log2 to account for | 529 | * Please note that we add 1 to the result of the log2 to account for |
| 514 | * any rounding errors, ensure the above inequality is satisfied and | 530 | * any rounding errors, ensure the above inequality is satisfied and |
| 515 | * no overflow will occur. | 531 | * no overflow will occur. |
| 516 | */ | 532 | */ |
| 517 | max_cycles = 1ULL << (63 - (ilog2(cs->mult) + 1)); | 533 | max_cycles = 1ULL << (63 - (ilog2(cs->mult + cs->maxadj) + 1)); |
| 518 | 534 | ||
| 519 | /* | 535 | /* |
| 520 | * The actual maximum number of cycles we can defer the clocksource is | 536 | * The actual maximum number of cycles we can defer the clocksource is |
| 521 | * determined by the minimum of max_cycles and cs->mask. | 537 | * determined by the minimum of max_cycles and cs->mask. |
| 538 | * Note: Here we subtract the maxadj to make sure we don't sleep for | ||
| 539 | * too long if there's a large negative adjustment. | ||
| 522 | */ | 540 | */ |
| 523 | max_cycles = min_t(u64, max_cycles, (u64) cs->mask); | 541 | max_cycles = min_t(u64, max_cycles, (u64) cs->mask); |
| 524 | max_nsecs = clocksource_cyc2ns(max_cycles, cs->mult, cs->shift); | 542 | max_nsecs = clocksource_cyc2ns(max_cycles, cs->mult - cs->maxadj, |
| 543 | cs->shift); | ||
| 525 | 544 | ||
| 526 | /* | 545 | /* |
| 527 | * To ensure that the clocksource does not wrap whilst we are idle, | 546 | * To ensure that the clocksource does not wrap whilst we are idle, |
| @@ -529,7 +548,7 @@ static u64 clocksource_max_deferment(struct clocksource *cs) | |||
| 529 | * note a margin of 12.5% is used because this can be computed with | 548 | * note a margin of 12.5% is used because this can be computed with |
| 530 | * a shift, versus say 10% which would require division. | 549 | * a shift, versus say 10% which would require division. |
| 531 | */ | 550 | */ |
| 532 | return max_nsecs - (max_nsecs >> 5); | 551 | return max_nsecs - (max_nsecs >> 3); |
| 533 | } | 552 | } |
| 534 | 553 | ||
| 535 | #ifndef CONFIG_ARCH_USES_GETTIMEOFFSET | 554 | #ifndef CONFIG_ARCH_USES_GETTIMEOFFSET |
| @@ -640,7 +659,6 @@ static void clocksource_enqueue(struct clocksource *cs) | |||
| 640 | void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq) | 659 | void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq) |
| 641 | { | 660 | { |
| 642 | u64 sec; | 661 | u64 sec; |
| 643 | |||
| 644 | /* | 662 | /* |
| 645 | * Calc the maximum number of seconds which we can run before | 663 | * Calc the maximum number of seconds which we can run before |
| 646 | * wrapping around. For clocksources which have a mask > 32bit | 664 | * wrapping around. For clocksources which have a mask > 32bit |
| @@ -651,7 +669,7 @@ void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq) | |||
| 651 | * ~ 0.06ppm granularity for NTP. We apply the same 12.5% | 669 | * ~ 0.06ppm granularity for NTP. We apply the same 12.5% |
| 652 | * margin as we do in clocksource_max_deferment() | 670 | * margin as we do in clocksource_max_deferment() |
| 653 | */ | 671 | */ |
| 654 | sec = (cs->mask - (cs->mask >> 5)); | 672 | sec = (cs->mask - (cs->mask >> 3)); |
| 655 | do_div(sec, freq); | 673 | do_div(sec, freq); |
| 656 | do_div(sec, scale); | 674 | do_div(sec, scale); |
| 657 | if (!sec) | 675 | if (!sec) |
| @@ -661,6 +679,20 @@ void __clocksource_updatefreq_scale(struct clocksource *cs, u32 scale, u32 freq) | |||
| 661 | 679 | ||
| 662 | clocks_calc_mult_shift(&cs->mult, &cs->shift, freq, | 680 | clocks_calc_mult_shift(&cs->mult, &cs->shift, freq, |
| 663 | NSEC_PER_SEC / scale, sec * scale); | 681 | NSEC_PER_SEC / scale, sec * scale); |
| 682 | |||
| 683 | /* | ||
| 684 | * for clocksources that have large mults, to avoid overflow. | ||
| 685 | * Since mult may be adjusted by ntp, add an safety extra margin | ||
| 686 | * | ||
| 687 | */ | ||
| 688 | cs->maxadj = clocksource_max_adjustment(cs); | ||
| 689 | while ((cs->mult + cs->maxadj < cs->mult) | ||
| 690 | || (cs->mult - cs->maxadj > cs->mult)) { | ||
| 691 | cs->mult >>= 1; | ||
| 692 | cs->shift--; | ||
| 693 | cs->maxadj = clocksource_max_adjustment(cs); | ||
| 694 | } | ||
| 695 | |||
| 664 | cs->max_idle_ns = clocksource_max_deferment(cs); | 696 | cs->max_idle_ns = clocksource_max_deferment(cs); |
| 665 | } | 697 | } |
| 666 | EXPORT_SYMBOL_GPL(__clocksource_updatefreq_scale); | 698 | EXPORT_SYMBOL_GPL(__clocksource_updatefreq_scale); |
| @@ -701,6 +733,12 @@ EXPORT_SYMBOL_GPL(__clocksource_register_scale); | |||
| 701 | */ | 733 | */ |
| 702 | int clocksource_register(struct clocksource *cs) | 734 | int clocksource_register(struct clocksource *cs) |
| 703 | { | 735 | { |
| 736 | /* calculate max adjustment for given mult/shift */ | ||
| 737 | cs->maxadj = clocksource_max_adjustment(cs); | ||
| 738 | WARN_ONCE(cs->mult + cs->maxadj < cs->mult, | ||
| 739 | "Clocksource %s might overflow on 11%% adjustment\n", | ||
| 740 | cs->name); | ||
| 741 | |||
| 704 | /* calculate max idle time permitted for this clocksource */ | 742 | /* calculate max idle time permitted for this clocksource */ |
| 705 | cs->max_idle_ns = clocksource_max_deferment(cs); | 743 | cs->max_idle_ns = clocksource_max_deferment(cs); |
| 706 | 744 | ||
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index f954282d9a82..fd4a7b1625a2 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c | |||
| @@ -71,7 +71,7 @@ int tick_check_broadcast_device(struct clock_event_device *dev) | |||
| 71 | (dev->features & CLOCK_EVT_FEAT_C3STOP)) | 71 | (dev->features & CLOCK_EVT_FEAT_C3STOP)) |
| 72 | return 0; | 72 | return 0; |
| 73 | 73 | ||
| 74 | clockevents_exchange_device(NULL, dev); | 74 | clockevents_exchange_device(tick_broadcast_device.evtdev, dev); |
| 75 | tick_broadcast_device.evtdev = dev; | 75 | tick_broadcast_device.evtdev = dev; |
| 76 | if (!cpumask_empty(tick_get_broadcast_mask())) | 76 | if (!cpumask_empty(tick_get_broadcast_mask())) |
| 77 | tick_broadcast_start_periodic(dev); | 77 | tick_broadcast_start_periodic(dev); |
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 2b021b0e8507..237841378c03 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c | |||
| @@ -249,6 +249,8 @@ ktime_t ktime_get(void) | |||
| 249 | secs = xtime.tv_sec + wall_to_monotonic.tv_sec; | 249 | secs = xtime.tv_sec + wall_to_monotonic.tv_sec; |
| 250 | nsecs = xtime.tv_nsec + wall_to_monotonic.tv_nsec; | 250 | nsecs = xtime.tv_nsec + wall_to_monotonic.tv_nsec; |
| 251 | nsecs += timekeeping_get_ns(); | 251 | nsecs += timekeeping_get_ns(); |
| 252 | /* If arch requires, add in gettimeoffset() */ | ||
| 253 | nsecs += arch_gettimeoffset(); | ||
| 252 | 254 | ||
| 253 | } while (read_seqretry(&xtime_lock, seq)); | 255 | } while (read_seqretry(&xtime_lock, seq)); |
| 254 | /* | 256 | /* |
| @@ -280,6 +282,8 @@ void ktime_get_ts(struct timespec *ts) | |||
| 280 | *ts = xtime; | 282 | *ts = xtime; |
| 281 | tomono = wall_to_monotonic; | 283 | tomono = wall_to_monotonic; |
| 282 | nsecs = timekeeping_get_ns(); | 284 | nsecs = timekeeping_get_ns(); |
| 285 | /* If arch requires, add in gettimeoffset() */ | ||
| 286 | nsecs += arch_gettimeoffset(); | ||
| 283 | 287 | ||
| 284 | } while (read_seqretry(&xtime_lock, seq)); | 288 | } while (read_seqretry(&xtime_lock, seq)); |
| 285 | 289 | ||
| @@ -802,14 +806,44 @@ static void timekeeping_adjust(s64 offset) | |||
| 802 | s64 error, interval = timekeeper.cycle_interval; | 806 | s64 error, interval = timekeeper.cycle_interval; |
| 803 | int adj; | 807 | int adj; |
| 804 | 808 | ||
| 809 | /* | ||
| 810 | * The point of this is to check if the error is greater then half | ||
| 811 | * an interval. | ||
| 812 | * | ||
| 813 | * First we shift it down from NTP_SHIFT to clocksource->shifted nsecs. | ||
| 814 | * | ||
| 815 | * Note we subtract one in the shift, so that error is really error*2. | ||
| 816 | * This "saves" dividing(shifting) intererval twice, but keeps the | ||
| 817 | * (error > interval) comparision as still measuring if error is | ||
| 818 | * larger then half an interval. | ||
| 819 | * | ||
| 820 | * Note: It does not "save" on aggrivation when reading the code. | ||
| 821 | */ | ||
| 805 | error = timekeeper.ntp_error >> (timekeeper.ntp_error_shift - 1); | 822 | error = timekeeper.ntp_error >> (timekeeper.ntp_error_shift - 1); |
| 806 | if (error > interval) { | 823 | if (error > interval) { |
| 824 | /* | ||
| 825 | * We now divide error by 4(via shift), which checks if | ||
| 826 | * the error is greater then twice the interval. | ||
| 827 | * If it is greater, we need a bigadjust, if its smaller, | ||
| 828 | * we can adjust by 1. | ||
| 829 | */ | ||
| 807 | error >>= 2; | 830 | error >>= 2; |
| 831 | /* | ||
| 832 | * XXX - In update_wall_time, we round up to the next | ||
| 833 | * nanosecond, and store the amount rounded up into | ||
| 834 | * the error. This causes the likely below to be unlikely. | ||
| 835 | * | ||
| 836 | * The properfix is to avoid rounding up by using | ||
| 837 | * the high precision timekeeper.xtime_nsec instead of | ||
| 838 | * xtime.tv_nsec everywhere. Fixing this will take some | ||
| 839 | * time. | ||
| 840 | */ | ||
| 808 | if (likely(error <= interval)) | 841 | if (likely(error <= interval)) |
| 809 | adj = 1; | 842 | adj = 1; |
| 810 | else | 843 | else |
| 811 | adj = timekeeping_bigadjust(error, &interval, &offset); | 844 | adj = timekeeping_bigadjust(error, &interval, &offset); |
| 812 | } else if (error < -interval) { | 845 | } else if (error < -interval) { |
| 846 | /* See comment above, this is just switched for the negative */ | ||
| 813 | error >>= 2; | 847 | error >>= 2; |
| 814 | if (likely(error >= -interval)) { | 848 | if (likely(error >= -interval)) { |
| 815 | adj = -1; | 849 | adj = -1; |
| @@ -817,9 +851,65 @@ static void timekeeping_adjust(s64 offset) | |||
| 817 | offset = -offset; | 851 | offset = -offset; |
| 818 | } else | 852 | } else |
| 819 | adj = timekeeping_bigadjust(error, &interval, &offset); | 853 | adj = timekeeping_bigadjust(error, &interval, &offset); |
| 820 | } else | 854 | } else /* No adjustment needed */ |
| 821 | return; | 855 | return; |
| 822 | 856 | ||
| 857 | WARN_ONCE(timekeeper.clock->maxadj && | ||
| 858 | (timekeeper.mult + adj > timekeeper.clock->mult + | ||
| 859 | timekeeper.clock->maxadj), | ||
| 860 | "Adjusting %s more then 11%% (%ld vs %ld)\n", | ||
| 861 | timekeeper.clock->name, (long)timekeeper.mult + adj, | ||
| 862 | (long)timekeeper.clock->mult + | ||
| 863 | timekeeper.clock->maxadj); | ||
| 864 | /* | ||
| 865 | * So the following can be confusing. | ||
| 866 | * | ||
| 867 | * To keep things simple, lets assume adj == 1 for now. | ||
| 868 | * | ||
| 869 | * When adj != 1, remember that the interval and offset values | ||
| 870 | * have been appropriately scaled so the math is the same. | ||
| 871 | * | ||
| 872 | * The basic idea here is that we're increasing the multiplier | ||
| 873 | * by one, this causes the xtime_interval to be incremented by | ||
| 874 | * one cycle_interval. This is because: | ||
| 875 | * xtime_interval = cycle_interval * mult | ||
| 876 | * So if mult is being incremented by one: | ||
| 877 | * xtime_interval = cycle_interval * (mult + 1) | ||
| 878 | * Its the same as: | ||
| 879 | * xtime_interval = (cycle_interval * mult) + cycle_interval | ||
| 880 | * Which can be shortened to: | ||
| 881 | * xtime_interval += cycle_interval | ||
| 882 | * | ||
| 883 | * So offset stores the non-accumulated cycles. Thus the current | ||
| 884 | * time (in shifted nanoseconds) is: | ||
| 885 | * now = (offset * adj) + xtime_nsec | ||
| 886 | * Now, even though we're adjusting the clock frequency, we have | ||
| 887 | * to keep time consistent. In other words, we can't jump back | ||
| 888 | * in time, and we also want to avoid jumping forward in time. | ||
| 889 | * | ||
| 890 | * So given the same offset value, we need the time to be the same | ||
| 891 | * both before and after the freq adjustment. | ||
| 892 | * now = (offset * adj_1) + xtime_nsec_1 | ||
| 893 | * now = (offset * adj_2) + xtime_nsec_2 | ||
| 894 | * So: | ||
| 895 | * (offset * adj_1) + xtime_nsec_1 = | ||
| 896 | * (offset * adj_2) + xtime_nsec_2 | ||
| 897 | * And we know: | ||
| 898 | * adj_2 = adj_1 + 1 | ||
| 899 | * So: | ||
| 900 | * (offset * adj_1) + xtime_nsec_1 = | ||
| 901 | * (offset * (adj_1+1)) + xtime_nsec_2 | ||
| 902 | * (offset * adj_1) + xtime_nsec_1 = | ||
| 903 | * (offset * adj_1) + offset + xtime_nsec_2 | ||
| 904 | * Canceling the sides: | ||
| 905 | * xtime_nsec_1 = offset + xtime_nsec_2 | ||
| 906 | * Which gives us: | ||
| 907 | * xtime_nsec_2 = xtime_nsec_1 - offset | ||
| 908 | * Which simplfies to: | ||
| 909 | * xtime_nsec -= offset | ||
| 910 | * | ||
| 911 | * XXX - TODO: Doc ntp_error calculation. | ||
| 912 | */ | ||
| 823 | timekeeper.mult += adj; | 913 | timekeeper.mult += adj; |
| 824 | timekeeper.xtime_interval += interval; | 914 | timekeeper.xtime_interval += interval; |
| 825 | timekeeper.xtime_nsec -= offset; | 915 | timekeeper.xtime_nsec -= offset; |
diff --git a/kernel/timer.c b/kernel/timer.c index dbaa62422b13..9c3c62b0c4bc 100644 --- a/kernel/timer.c +++ b/kernel/timer.c | |||
| @@ -1368,7 +1368,7 @@ SYSCALL_DEFINE0(getppid) | |||
| 1368 | int pid; | 1368 | int pid; |
| 1369 | 1369 | ||
| 1370 | rcu_read_lock(); | 1370 | rcu_read_lock(); |
| 1371 | pid = task_tgid_vnr(current->real_parent); | 1371 | pid = task_tgid_vnr(rcu_dereference(current->real_parent)); |
| 1372 | rcu_read_unlock(); | 1372 | rcu_read_unlock(); |
| 1373 | 1373 | ||
| 1374 | return pid; | 1374 | return pid; |
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 900b409543db..b1e8943fed1d 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
| @@ -152,7 +152,6 @@ void clear_ftrace_function(void) | |||
| 152 | ftrace_pid_function = ftrace_stub; | 152 | ftrace_pid_function = ftrace_stub; |
| 153 | } | 153 | } |
| 154 | 154 | ||
| 155 | #undef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST | ||
| 156 | #ifndef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST | 155 | #ifndef CONFIG_HAVE_FUNCTION_TRACE_MCOUNT_TEST |
| 157 | /* | 156 | /* |
| 158 | * For those archs that do not test ftrace_trace_stop in their | 157 | * For those archs that do not test ftrace_trace_stop in their |
| @@ -1212,7 +1211,9 @@ ftrace_hash_move(struct ftrace_ops *ops, int enable, | |||
| 1212 | if (!src->count) { | 1211 | if (!src->count) { |
| 1213 | free_ftrace_hash_rcu(*dst); | 1212 | free_ftrace_hash_rcu(*dst); |
| 1214 | rcu_assign_pointer(*dst, EMPTY_HASH); | 1213 | rcu_assign_pointer(*dst, EMPTY_HASH); |
| 1215 | return 0; | 1214 | /* still need to update the function records */ |
| 1215 | ret = 0; | ||
| 1216 | goto out; | ||
| 1216 | } | 1217 | } |
| 1217 | 1218 | ||
| 1218 | /* | 1219 | /* |
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 581876f9f387..c212a7f934ec 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c | |||
| @@ -1078,7 +1078,6 @@ event_subsystem_dir(const char *name, struct dentry *d_events) | |||
| 1078 | /* First see if we did not already create this dir */ | 1078 | /* First see if we did not already create this dir */ |
| 1079 | list_for_each_entry(system, &event_subsystems, list) { | 1079 | list_for_each_entry(system, &event_subsystems, list) { |
| 1080 | if (strcmp(system->name, name) == 0) { | 1080 | if (strcmp(system->name, name) == 0) { |
| 1081 | __get_system(system); | ||
| 1082 | system->nr_events++; | 1081 | system->nr_events++; |
| 1083 | return system->entry; | 1082 | return system->entry; |
| 1084 | } | 1083 | } |
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index 816d3d074979..95dc31efd6dd 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c | |||
| @@ -1649,7 +1649,9 @@ static int replace_system_preds(struct event_subsystem *system, | |||
| 1649 | */ | 1649 | */ |
| 1650 | err = replace_preds(call, NULL, ps, filter_string, true); | 1650 | err = replace_preds(call, NULL, ps, filter_string, true); |
| 1651 | if (err) | 1651 | if (err) |
| 1652 | goto fail; | 1652 | call->flags |= TRACE_EVENT_FL_NO_SET_FILTER; |
| 1653 | else | ||
| 1654 | call->flags &= ~TRACE_EVENT_FL_NO_SET_FILTER; | ||
| 1653 | } | 1655 | } |
| 1654 | 1656 | ||
| 1655 | list_for_each_entry(call, &ftrace_events, list) { | 1657 | list_for_each_entry(call, &ftrace_events, list) { |
| @@ -1658,6 +1660,9 @@ static int replace_system_preds(struct event_subsystem *system, | |||
| 1658 | if (strcmp(call->class->system, system->name) != 0) | 1660 | if (strcmp(call->class->system, system->name) != 0) |
| 1659 | continue; | 1661 | continue; |
| 1660 | 1662 | ||
| 1663 | if (call->flags & TRACE_EVENT_FL_NO_SET_FILTER) | ||
| 1664 | continue; | ||
| 1665 | |||
| 1661 | filter_item = kzalloc(sizeof(*filter_item), GFP_KERNEL); | 1666 | filter_item = kzalloc(sizeof(*filter_item), GFP_KERNEL); |
| 1662 | if (!filter_item) | 1667 | if (!filter_item) |
| 1663 | goto fail_mem; | 1668 | goto fail_mem; |
| @@ -1686,7 +1691,7 @@ static int replace_system_preds(struct event_subsystem *system, | |||
| 1686 | * replace the filter for the call. | 1691 | * replace the filter for the call. |
| 1687 | */ | 1692 | */ |
| 1688 | filter = call->filter; | 1693 | filter = call->filter; |
| 1689 | call->filter = filter_item->filter; | 1694 | rcu_assign_pointer(call->filter, filter_item->filter); |
| 1690 | filter_item->filter = filter; | 1695 | filter_item->filter = filter; |
| 1691 | 1696 | ||
| 1692 | fail = false; | 1697 | fail = false; |
| @@ -1741,7 +1746,7 @@ int apply_event_filter(struct ftrace_event_call *call, char *filter_string) | |||
| 1741 | filter = call->filter; | 1746 | filter = call->filter; |
| 1742 | if (!filter) | 1747 | if (!filter) |
| 1743 | goto out_unlock; | 1748 | goto out_unlock; |
| 1744 | call->filter = NULL; | 1749 | RCU_INIT_POINTER(call->filter, NULL); |
| 1745 | /* Make sure the filter is not being used */ | 1750 | /* Make sure the filter is not being used */ |
| 1746 | synchronize_sched(); | 1751 | synchronize_sched(); |
| 1747 | __free_filter(filter); | 1752 | __free_filter(filter); |
| @@ -1782,7 +1787,7 @@ out: | |||
| 1782 | * string | 1787 | * string |
| 1783 | */ | 1788 | */ |
| 1784 | tmp = call->filter; | 1789 | tmp = call->filter; |
| 1785 | call->filter = filter; | 1790 | rcu_assign_pointer(call->filter, filter); |
| 1786 | if (tmp) { | 1791 | if (tmp) { |
| 1787 | /* Make sure the call is done with the filter */ | 1792 | /* Make sure the call is done with the filter */ |
| 1788 | synchronize_sched(); | 1793 | synchronize_sched(); |
diff --git a/lib/dma-debug.c b/lib/dma-debug.c index 74c6c7fce749..fea790a2b176 100644 --- a/lib/dma-debug.c +++ b/lib/dma-debug.c | |||
| @@ -245,7 +245,7 @@ static void put_hash_bucket(struct hash_bucket *bucket, | |||
| 245 | 245 | ||
| 246 | static bool exact_match(struct dma_debug_entry *a, struct dma_debug_entry *b) | 246 | static bool exact_match(struct dma_debug_entry *a, struct dma_debug_entry *b) |
| 247 | { | 247 | { |
| 248 | return ((a->dev_addr == a->dev_addr) && | 248 | return ((a->dev_addr == b->dev_addr) && |
| 249 | (a->dev == b->dev)) ? true : false; | 249 | (a->dev == b->dev)) ? true : false; |
| 250 | } | 250 | } |
| 251 | 251 | ||
diff --git a/mm/filemap.c b/mm/filemap.c index c0018f2d50e0..c106d3b3cc64 100644 --- a/mm/filemap.c +++ b/mm/filemap.c | |||
| @@ -2407,7 +2407,6 @@ static ssize_t generic_perform_write(struct file *file, | |||
| 2407 | iov_iter_count(i)); | 2407 | iov_iter_count(i)); |
| 2408 | 2408 | ||
| 2409 | again: | 2409 | again: |
| 2410 | |||
| 2411 | /* | 2410 | /* |
| 2412 | * Bring in the user page that we will copy from _first_. | 2411 | * Bring in the user page that we will copy from _first_. |
| 2413 | * Otherwise there's a nasty deadlock on copying from the | 2412 | * Otherwise there's a nasty deadlock on copying from the |
| @@ -2463,7 +2462,10 @@ again: | |||
| 2463 | written += copied; | 2462 | written += copied; |
| 2464 | 2463 | ||
| 2465 | balance_dirty_pages_ratelimited(mapping); | 2464 | balance_dirty_pages_ratelimited(mapping); |
| 2466 | 2465 | if (fatal_signal_pending(current)) { | |
| 2466 | status = -EINTR; | ||
| 2467 | break; | ||
| 2468 | } | ||
| 2467 | } while (iov_iter_count(i)); | 2469 | } while (iov_iter_count(i)); |
| 2468 | 2470 | ||
| 2469 | return written ? written : status; | 2471 | return written ? written : status; |
diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 4298abaae153..36b3d988b4ef 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c | |||
| @@ -2259,12 +2259,8 @@ static void khugepaged_do_scan(struct page **hpage) | |||
| 2259 | 2259 | ||
| 2260 | static void khugepaged_alloc_sleep(void) | 2260 | static void khugepaged_alloc_sleep(void) |
| 2261 | { | 2261 | { |
| 2262 | DEFINE_WAIT(wait); | 2262 | wait_event_freezable_timeout(khugepaged_wait, false, |
| 2263 | add_wait_queue(&khugepaged_wait, &wait); | 2263 | msecs_to_jiffies(khugepaged_alloc_sleep_millisecs)); |
| 2264 | schedule_timeout_interruptible( | ||
| 2265 | msecs_to_jiffies( | ||
| 2266 | khugepaged_alloc_sleep_millisecs)); | ||
| 2267 | remove_wait_queue(&khugepaged_wait, &wait); | ||
| 2268 | } | 2264 | } |
| 2269 | 2265 | ||
| 2270 | #ifndef CONFIG_NUMA | 2266 | #ifndef CONFIG_NUMA |
| @@ -2313,14 +2309,10 @@ static void khugepaged_loop(void) | |||
| 2313 | if (unlikely(kthread_should_stop())) | 2309 | if (unlikely(kthread_should_stop())) |
| 2314 | break; | 2310 | break; |
| 2315 | if (khugepaged_has_work()) { | 2311 | if (khugepaged_has_work()) { |
| 2316 | DEFINE_WAIT(wait); | ||
| 2317 | if (!khugepaged_scan_sleep_millisecs) | 2312 | if (!khugepaged_scan_sleep_millisecs) |
| 2318 | continue; | 2313 | continue; |
| 2319 | add_wait_queue(&khugepaged_wait, &wait); | 2314 | wait_event_freezable_timeout(khugepaged_wait, false, |
| 2320 | schedule_timeout_interruptible( | 2315 | msecs_to_jiffies(khugepaged_scan_sleep_millisecs)); |
| 2321 | msecs_to_jiffies( | ||
| 2322 | khugepaged_scan_sleep_millisecs)); | ||
| 2323 | remove_wait_queue(&khugepaged_wait, &wait); | ||
| 2324 | } else if (khugepaged_enabled()) | 2316 | } else if (khugepaged_enabled()) |
| 2325 | wait_event_freezable(khugepaged_wait, | 2317 | wait_event_freezable(khugepaged_wait, |
| 2326 | khugepaged_wait_event()); | 2318 | khugepaged_wait_event()); |
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index bb28a5f9db8d..73f17c0293c0 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c | |||
| @@ -576,6 +576,7 @@ static void prep_compound_gigantic_page(struct page *page, unsigned long order) | |||
| 576 | __SetPageHead(page); | 576 | __SetPageHead(page); |
| 577 | for (i = 1; i < nr_pages; i++, p = mem_map_next(p, page, i)) { | 577 | for (i = 1; i < nr_pages; i++, p = mem_map_next(p, page, i)) { |
| 578 | __SetPageTail(p); | 578 | __SetPageTail(p); |
| 579 | set_page_count(p, 0); | ||
| 579 | p->first_page = page; | 580 | p->first_page = page; |
| 580 | } | 581 | } |
| 581 | } | 582 | } |
diff --git a/mm/migrate.c b/mm/migrate.c index 578e29174fa6..177aca424a06 100644 --- a/mm/migrate.c +++ b/mm/migrate.c | |||
| @@ -871,9 +871,9 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, | |||
| 871 | 871 | ||
| 872 | if (anon_vma) | 872 | if (anon_vma) |
| 873 | put_anon_vma(anon_vma); | 873 | put_anon_vma(anon_vma); |
| 874 | out: | ||
| 875 | unlock_page(hpage); | 874 | unlock_page(hpage); |
| 876 | 875 | ||
| 876 | out: | ||
| 877 | if (rc != -EAGAIN) { | 877 | if (rc != -EAGAIN) { |
| 878 | list_del(&hpage->lru); | 878 | list_del(&hpage->lru); |
| 879 | put_page(hpage); | 879 | put_page(hpage); |
diff --git a/mm/page-writeback.c b/mm/page-writeback.c index 71252486bc6f..50f08241f981 100644 --- a/mm/page-writeback.c +++ b/mm/page-writeback.c | |||
| @@ -411,8 +411,13 @@ void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty) | |||
| 411 | * | 411 | * |
| 412 | * Returns @bdi's dirty limit in pages. The term "dirty" in the context of | 412 | * Returns @bdi's dirty limit in pages. The term "dirty" in the context of |
| 413 | * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. | 413 | * dirty balancing includes all PG_dirty, PG_writeback and NFS unstable pages. |
| 414 | * And the "limit" in the name is not seriously taken as hard limit in | 414 | * |
| 415 | * balance_dirty_pages(). | 415 | * Note that balance_dirty_pages() will only seriously take it as a hard limit |
| 416 | * when sleeping max_pause per page is not enough to keep the dirty pages under | ||
| 417 | * control. For example, when the device is completely stalled due to some error | ||
| 418 | * conditions, or when there are 1000 dd tasks writing to a slow 10MB/s USB key. | ||
| 419 | * In the other normal situations, it acts more gently by throttling the tasks | ||
| 420 | * more (rather than completely block them) when the bdi dirty pages go high. | ||
| 416 | * | 421 | * |
| 417 | * It allocates high/low dirty limits to fast/slow devices, in order to prevent | 422 | * It allocates high/low dirty limits to fast/slow devices, in order to prevent |
| 418 | * - starving fast devices | 423 | * - starving fast devices |
| @@ -594,6 +599,13 @@ static unsigned long bdi_position_ratio(struct backing_dev_info *bdi, | |||
| 594 | */ | 599 | */ |
| 595 | if (unlikely(bdi_thresh > thresh)) | 600 | if (unlikely(bdi_thresh > thresh)) |
| 596 | bdi_thresh = thresh; | 601 | bdi_thresh = thresh; |
| 602 | /* | ||
| 603 | * It's very possible that bdi_thresh is close to 0 not because the | ||
| 604 | * device is slow, but that it has remained inactive for long time. | ||
| 605 | * Honour such devices a reasonable good (hopefully IO efficient) | ||
| 606 | * threshold, so that the occasional writes won't be blocked and active | ||
| 607 | * writes can rampup the threshold quickly. | ||
| 608 | */ | ||
| 597 | bdi_thresh = max(bdi_thresh, (limit - dirty) / 8); | 609 | bdi_thresh = max(bdi_thresh, (limit - dirty) / 8); |
| 598 | /* | 610 | /* |
| 599 | * scale global setpoint to bdi's: | 611 | * scale global setpoint to bdi's: |
| @@ -977,8 +989,7 @@ static unsigned long bdi_max_pause(struct backing_dev_info *bdi, | |||
| 977 | * | 989 | * |
| 978 | * 8 serves as the safety ratio. | 990 | * 8 serves as the safety ratio. |
| 979 | */ | 991 | */ |
| 980 | if (bdi_dirty) | 992 | t = min(t, bdi_dirty * HZ / (8 * bw + 1)); |
| 981 | t = min(t, bdi_dirty * HZ / (8 * bw + 1)); | ||
| 982 | 993 | ||
| 983 | /* | 994 | /* |
| 984 | * The pause time will be settled within range (max_pause/4, max_pause). | 995 | * The pause time will be settled within range (max_pause/4, max_pause). |
| @@ -1136,6 +1147,19 @@ pause: | |||
| 1136 | if (task_ratelimit) | 1147 | if (task_ratelimit) |
| 1137 | break; | 1148 | break; |
| 1138 | 1149 | ||
| 1150 | /* | ||
| 1151 | * In the case of an unresponding NFS server and the NFS dirty | ||
| 1152 | * pages exceeds dirty_thresh, give the other good bdi's a pipe | ||
| 1153 | * to go through, so that tasks on them still remain responsive. | ||
| 1154 | * | ||
| 1155 | * In theory 1 page is enough to keep the comsumer-producer | ||
| 1156 | * pipe going: the flusher cleans 1 page => the task dirties 1 | ||
| 1157 | * more page. However bdi_dirty has accounting errors. So use | ||
| 1158 | * the larger and more IO friendly bdi_stat_error. | ||
| 1159 | */ | ||
| 1160 | if (bdi_dirty <= bdi_stat_error(bdi)) | ||
| 1161 | break; | ||
| 1162 | |||
| 1139 | if (fatal_signal_pending(current)) | 1163 | if (fatal_signal_pending(current)) |
| 1140 | break; | 1164 | break; |
| 1141 | } | 1165 | } |
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9dd443d89d8b..2b8ba3aebf6e 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c | |||
| @@ -356,8 +356,8 @@ void prep_compound_page(struct page *page, unsigned long order) | |||
| 356 | __SetPageHead(page); | 356 | __SetPageHead(page); |
| 357 | for (i = 1; i < nr_pages; i++) { | 357 | for (i = 1; i < nr_pages; i++) { |
| 358 | struct page *p = page + i; | 358 | struct page *p = page + i; |
| 359 | |||
| 360 | __SetPageTail(p); | 359 | __SetPageTail(p); |
| 360 | set_page_count(p, 0); | ||
| 361 | p->first_page = page; | 361 | p->first_page = page; |
| 362 | } | 362 | } |
| 363 | } | 363 | } |
| @@ -3377,9 +3377,15 @@ static void setup_zone_migrate_reserve(struct zone *zone) | |||
| 3377 | unsigned long block_migratetype; | 3377 | unsigned long block_migratetype; |
| 3378 | int reserve; | 3378 | int reserve; |
| 3379 | 3379 | ||
| 3380 | /* Get the start pfn, end pfn and the number of blocks to reserve */ | 3380 | /* |
| 3381 | * Get the start pfn, end pfn and the number of blocks to reserve | ||
| 3382 | * We have to be careful to be aligned to pageblock_nr_pages to | ||
| 3383 | * make sure that we always check pfn_valid for the first page in | ||
| 3384 | * the block. | ||
| 3385 | */ | ||
| 3381 | start_pfn = zone->zone_start_pfn; | 3386 | start_pfn = zone->zone_start_pfn; |
| 3382 | end_pfn = start_pfn + zone->spanned_pages; | 3387 | end_pfn = start_pfn + zone->spanned_pages; |
| 3388 | start_pfn = roundup(start_pfn, pageblock_nr_pages); | ||
| 3383 | reserve = roundup(min_wmark_pages(zone), pageblock_nr_pages) >> | 3389 | reserve = roundup(min_wmark_pages(zone), pageblock_nr_pages) >> |
| 3384 | pageblock_order; | 3390 | pageblock_order; |
| 3385 | 3391 | ||
diff --git a/mm/percpu-vm.c b/mm/percpu-vm.c index ea534960a04b..12a48a88c0d8 100644 --- a/mm/percpu-vm.c +++ b/mm/percpu-vm.c | |||
| @@ -50,14 +50,13 @@ static struct page **pcpu_get_pages_and_bitmap(struct pcpu_chunk *chunk, | |||
| 50 | 50 | ||
| 51 | if (!pages || !bitmap) { | 51 | if (!pages || !bitmap) { |
| 52 | if (may_alloc && !pages) | 52 | if (may_alloc && !pages) |
| 53 | pages = pcpu_mem_alloc(pages_size); | 53 | pages = pcpu_mem_zalloc(pages_size); |
| 54 | if (may_alloc && !bitmap) | 54 | if (may_alloc && !bitmap) |
| 55 | bitmap = pcpu_mem_alloc(bitmap_size); | 55 | bitmap = pcpu_mem_zalloc(bitmap_size); |
| 56 | if (!pages || !bitmap) | 56 | if (!pages || !bitmap) |
| 57 | return NULL; | 57 | return NULL; |
| 58 | } | 58 | } |
| 59 | 59 | ||
| 60 | memset(pages, 0, pages_size); | ||
| 61 | bitmap_copy(bitmap, chunk->populated, pcpu_unit_pages); | 60 | bitmap_copy(bitmap, chunk->populated, pcpu_unit_pages); |
| 62 | 61 | ||
| 63 | *bitmapp = bitmap; | 62 | *bitmapp = bitmap; |
| @@ -143,8 +142,8 @@ static void pcpu_pre_unmap_flush(struct pcpu_chunk *chunk, | |||
| 143 | int page_start, int page_end) | 142 | int page_start, int page_end) |
| 144 | { | 143 | { |
| 145 | flush_cache_vunmap( | 144 | flush_cache_vunmap( |
| 146 | pcpu_chunk_addr(chunk, pcpu_first_unit_cpu, page_start), | 145 | pcpu_chunk_addr(chunk, pcpu_low_unit_cpu, page_start), |
| 147 | pcpu_chunk_addr(chunk, pcpu_last_unit_cpu, page_end)); | 146 | pcpu_chunk_addr(chunk, pcpu_high_unit_cpu, page_end)); |
| 148 | } | 147 | } |
| 149 | 148 | ||
| 150 | static void __pcpu_unmap_pages(unsigned long addr, int nr_pages) | 149 | static void __pcpu_unmap_pages(unsigned long addr, int nr_pages) |
| @@ -206,8 +205,8 @@ static void pcpu_post_unmap_tlb_flush(struct pcpu_chunk *chunk, | |||
| 206 | int page_start, int page_end) | 205 | int page_start, int page_end) |
| 207 | { | 206 | { |
| 208 | flush_tlb_kernel_range( | 207 | flush_tlb_kernel_range( |
| 209 | pcpu_chunk_addr(chunk, pcpu_first_unit_cpu, page_start), | 208 | pcpu_chunk_addr(chunk, pcpu_low_unit_cpu, page_start), |
| 210 | pcpu_chunk_addr(chunk, pcpu_last_unit_cpu, page_end)); | 209 | pcpu_chunk_addr(chunk, pcpu_high_unit_cpu, page_end)); |
| 211 | } | 210 | } |
| 212 | 211 | ||
| 213 | static int __pcpu_map_pages(unsigned long addr, struct page **pages, | 212 | static int __pcpu_map_pages(unsigned long addr, struct page **pages, |
| @@ -284,8 +283,8 @@ static void pcpu_post_map_flush(struct pcpu_chunk *chunk, | |||
| 284 | int page_start, int page_end) | 283 | int page_start, int page_end) |
| 285 | { | 284 | { |
| 286 | flush_cache_vmap( | 285 | flush_cache_vmap( |
| 287 | pcpu_chunk_addr(chunk, pcpu_first_unit_cpu, page_start), | 286 | pcpu_chunk_addr(chunk, pcpu_low_unit_cpu, page_start), |
| 288 | pcpu_chunk_addr(chunk, pcpu_last_unit_cpu, page_end)); | 287 | pcpu_chunk_addr(chunk, pcpu_high_unit_cpu, page_end)); |
| 289 | } | 288 | } |
| 290 | 289 | ||
| 291 | /** | 290 | /** |
diff --git a/mm/percpu.c b/mm/percpu.c index bf80e55dbed7..3bb810a72006 100644 --- a/mm/percpu.c +++ b/mm/percpu.c | |||
| @@ -116,9 +116,9 @@ static int pcpu_atom_size __read_mostly; | |||
| 116 | static int pcpu_nr_slots __read_mostly; | 116 | static int pcpu_nr_slots __read_mostly; |
| 117 | static size_t pcpu_chunk_struct_size __read_mostly; | 117 | static size_t pcpu_chunk_struct_size __read_mostly; |
| 118 | 118 | ||
| 119 | /* cpus with the lowest and highest unit numbers */ | 119 | /* cpus with the lowest and highest unit addresses */ |
| 120 | static unsigned int pcpu_first_unit_cpu __read_mostly; | 120 | static unsigned int pcpu_low_unit_cpu __read_mostly; |
| 121 | static unsigned int pcpu_last_unit_cpu __read_mostly; | 121 | static unsigned int pcpu_high_unit_cpu __read_mostly; |
| 122 | 122 | ||
| 123 | /* the address of the first chunk which starts with the kernel static area */ | 123 | /* the address of the first chunk which starts with the kernel static area */ |
| 124 | void *pcpu_base_addr __read_mostly; | 124 | void *pcpu_base_addr __read_mostly; |
| @@ -273,11 +273,11 @@ static void __maybe_unused pcpu_next_pop(struct pcpu_chunk *chunk, | |||
| 273 | (rs) = (re) + 1, pcpu_next_pop((chunk), &(rs), &(re), (end))) | 273 | (rs) = (re) + 1, pcpu_next_pop((chunk), &(rs), &(re), (end))) |
| 274 | 274 | ||
| 275 | /** | 275 | /** |
| 276 | * pcpu_mem_alloc - allocate memory | 276 | * pcpu_mem_zalloc - allocate memory |
| 277 | * @size: bytes to allocate | 277 | * @size: bytes to allocate |
| 278 | * | 278 | * |
| 279 | * Allocate @size bytes. If @size is smaller than PAGE_SIZE, | 279 | * Allocate @size bytes. If @size is smaller than PAGE_SIZE, |
| 280 | * kzalloc() is used; otherwise, vmalloc() is used. The returned | 280 | * kzalloc() is used; otherwise, vzalloc() is used. The returned |
| 281 | * memory is always zeroed. | 281 | * memory is always zeroed. |
| 282 | * | 282 | * |
| 283 | * CONTEXT: | 283 | * CONTEXT: |
| @@ -286,7 +286,7 @@ static void __maybe_unused pcpu_next_pop(struct pcpu_chunk *chunk, | |||
| 286 | * RETURNS: | 286 | * RETURNS: |
| 287 | * Pointer to the allocated area on success, NULL on failure. | 287 | * Pointer to the allocated area on success, NULL on failure. |
| 288 | */ | 288 | */ |
| 289 | static void *pcpu_mem_alloc(size_t size) | 289 | static void *pcpu_mem_zalloc(size_t size) |
| 290 | { | 290 | { |
| 291 | if (WARN_ON_ONCE(!slab_is_available())) | 291 | if (WARN_ON_ONCE(!slab_is_available())) |
| 292 | return NULL; | 292 | return NULL; |
| @@ -302,7 +302,7 @@ static void *pcpu_mem_alloc(size_t size) | |||
| 302 | * @ptr: memory to free | 302 | * @ptr: memory to free |
| 303 | * @size: size of the area | 303 | * @size: size of the area |
| 304 | * | 304 | * |
| 305 | * Free @ptr. @ptr should have been allocated using pcpu_mem_alloc(). | 305 | * Free @ptr. @ptr should have been allocated using pcpu_mem_zalloc(). |
| 306 | */ | 306 | */ |
| 307 | static void pcpu_mem_free(void *ptr, size_t size) | 307 | static void pcpu_mem_free(void *ptr, size_t size) |
| 308 | { | 308 | { |
| @@ -384,7 +384,7 @@ static int pcpu_extend_area_map(struct pcpu_chunk *chunk, int new_alloc) | |||
| 384 | size_t old_size = 0, new_size = new_alloc * sizeof(new[0]); | 384 | size_t old_size = 0, new_size = new_alloc * sizeof(new[0]); |
| 385 | unsigned long flags; | 385 | unsigned long flags; |
| 386 | 386 | ||
| 387 | new = pcpu_mem_alloc(new_size); | 387 | new = pcpu_mem_zalloc(new_size); |
| 388 | if (!new) | 388 | if (!new) |
| 389 | return -ENOMEM; | 389 | return -ENOMEM; |
| 390 | 390 | ||
| @@ -604,11 +604,12 @@ static struct pcpu_chunk *pcpu_alloc_chunk(void) | |||
| 604 | { | 604 | { |
| 605 | struct pcpu_chunk *chunk; | 605 | struct pcpu_chunk *chunk; |
| 606 | 606 | ||
| 607 | chunk = pcpu_mem_alloc(pcpu_chunk_struct_size); | 607 | chunk = pcpu_mem_zalloc(pcpu_chunk_struct_size); |
| 608 | if (!chunk) | 608 | if (!chunk) |
| 609 | return NULL; | 609 | return NULL; |
| 610 | 610 | ||
| 611 | chunk->map = pcpu_mem_alloc(PCPU_DFL_MAP_ALLOC * sizeof(chunk->map[0])); | 611 | chunk->map = pcpu_mem_zalloc(PCPU_DFL_MAP_ALLOC * |
| 612 | sizeof(chunk->map[0])); | ||
| 612 | if (!chunk->map) { | 613 | if (!chunk->map) { |
| 613 | kfree(chunk); | 614 | kfree(chunk); |
| 614 | return NULL; | 615 | return NULL; |
| @@ -977,6 +978,17 @@ bool is_kernel_percpu_address(unsigned long addr) | |||
| 977 | * address. The caller is responsible for ensuring @addr stays valid | 978 | * address. The caller is responsible for ensuring @addr stays valid |
| 978 | * until this function finishes. | 979 | * until this function finishes. |
| 979 | * | 980 | * |
| 981 | * percpu allocator has special setup for the first chunk, which currently | ||
| 982 | * supports either embedding in linear address space or vmalloc mapping, | ||
| 983 | * and, from the second one, the backing allocator (currently either vm or | ||
| 984 | * km) provides translation. | ||
| 985 | * | ||
| 986 | * The addr can be tranlated simply without checking if it falls into the | ||
| 987 | * first chunk. But the current code reflects better how percpu allocator | ||
| 988 | * actually works, and the verification can discover both bugs in percpu | ||
| 989 | * allocator itself and per_cpu_ptr_to_phys() callers. So we keep current | ||
| 990 | * code. | ||
| 991 | * | ||
| 980 | * RETURNS: | 992 | * RETURNS: |
| 981 | * The physical address for @addr. | 993 | * The physical address for @addr. |
| 982 | */ | 994 | */ |
| @@ -984,19 +996,19 @@ phys_addr_t per_cpu_ptr_to_phys(void *addr) | |||
| 984 | { | 996 | { |
| 985 | void __percpu *base = __addr_to_pcpu_ptr(pcpu_base_addr); | 997 | void __percpu *base = __addr_to_pcpu_ptr(pcpu_base_addr); |
| 986 | bool in_first_chunk = false; | 998 | bool in_first_chunk = false; |
| 987 | unsigned long first_start, first_end; | 999 | unsigned long first_low, first_high; |
| 988 | unsigned int cpu; | 1000 | unsigned int cpu; |
| 989 | 1001 | ||
| 990 | /* | 1002 | /* |
| 991 | * The following test on first_start/end isn't strictly | 1003 | * The following test on unit_low/high isn't strictly |
| 992 | * necessary but will speed up lookups of addresses which | 1004 | * necessary but will speed up lookups of addresses which |
| 993 | * aren't in the first chunk. | 1005 | * aren't in the first chunk. |
| 994 | */ | 1006 | */ |
| 995 | first_start = pcpu_chunk_addr(pcpu_first_chunk, pcpu_first_unit_cpu, 0); | 1007 | first_low = pcpu_chunk_addr(pcpu_first_chunk, pcpu_low_unit_cpu, 0); |
| 996 | first_end = pcpu_chunk_addr(pcpu_first_chunk, pcpu_last_unit_cpu, | 1008 | first_high = pcpu_chunk_addr(pcpu_first_chunk, pcpu_high_unit_cpu, |
| 997 | pcpu_unit_pages); | 1009 | pcpu_unit_pages); |
| 998 | if ((unsigned long)addr >= first_start && | 1010 | if ((unsigned long)addr >= first_low && |
| 999 | (unsigned long)addr < first_end) { | 1011 | (unsigned long)addr < first_high) { |
| 1000 | for_each_possible_cpu(cpu) { | 1012 | for_each_possible_cpu(cpu) { |
| 1001 | void *start = per_cpu_ptr(base, cpu); | 1013 | void *start = per_cpu_ptr(base, cpu); |
| 1002 | 1014 | ||
| @@ -1233,7 +1245,9 @@ int __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai, | |||
| 1233 | 1245 | ||
| 1234 | for (cpu = 0; cpu < nr_cpu_ids; cpu++) | 1246 | for (cpu = 0; cpu < nr_cpu_ids; cpu++) |
| 1235 | unit_map[cpu] = UINT_MAX; | 1247 | unit_map[cpu] = UINT_MAX; |
| 1236 | pcpu_first_unit_cpu = NR_CPUS; | 1248 | |
| 1249 | pcpu_low_unit_cpu = NR_CPUS; | ||
| 1250 | pcpu_high_unit_cpu = NR_CPUS; | ||
| 1237 | 1251 | ||
| 1238 | for (group = 0, unit = 0; group < ai->nr_groups; group++, unit += i) { | 1252 | for (group = 0, unit = 0; group < ai->nr_groups; group++, unit += i) { |
| 1239 | const struct pcpu_group_info *gi = &ai->groups[group]; | 1253 | const struct pcpu_group_info *gi = &ai->groups[group]; |
| @@ -1253,9 +1267,13 @@ int __init pcpu_setup_first_chunk(const struct pcpu_alloc_info *ai, | |||
| 1253 | unit_map[cpu] = unit + i; | 1267 | unit_map[cpu] = unit + i; |
| 1254 | unit_off[cpu] = gi->base_offset + i * ai->unit_size; | 1268 | unit_off[cpu] = gi->base_offset + i * ai->unit_size; |
| 1255 | 1269 | ||
| 1256 | if (pcpu_first_unit_cpu == NR_CPUS) | 1270 | /* determine low/high unit_cpu */ |
| 1257 | pcpu_first_unit_cpu = cpu; | 1271 | if (pcpu_low_unit_cpu == NR_CPUS || |
| 1258 | pcpu_last_unit_cpu = cpu; | 1272 | unit_off[cpu] < unit_off[pcpu_low_unit_cpu]) |
| 1273 | pcpu_low_unit_cpu = cpu; | ||
| 1274 | if (pcpu_high_unit_cpu == NR_CPUS || | ||
| 1275 | unit_off[cpu] > unit_off[pcpu_high_unit_cpu]) | ||
| 1276 | pcpu_high_unit_cpu = cpu; | ||
| 1259 | } | 1277 | } |
| 1260 | } | 1278 | } |
| 1261 | pcpu_nr_units = unit; | 1279 | pcpu_nr_units = unit; |
| @@ -1889,7 +1907,7 @@ void __init percpu_init_late(void) | |||
| 1889 | 1907 | ||
| 1890 | BUILD_BUG_ON(size > PAGE_SIZE); | 1908 | BUILD_BUG_ON(size > PAGE_SIZE); |
| 1891 | 1909 | ||
| 1892 | map = pcpu_mem_alloc(size); | 1910 | map = pcpu_mem_zalloc(size); |
| 1893 | BUG_ON(!map); | 1911 | BUG_ON(!map); |
| 1894 | 1912 | ||
| 1895 | spin_lock_irqsave(&pcpu_lock, flags); | 1913 | spin_lock_irqsave(&pcpu_lock, flags); |
| @@ -595,6 +595,7 @@ static enum { | |||
| 595 | PARTIAL_AC, | 595 | PARTIAL_AC, |
| 596 | PARTIAL_L3, | 596 | PARTIAL_L3, |
| 597 | EARLY, | 597 | EARLY, |
| 598 | LATE, | ||
| 598 | FULL | 599 | FULL |
| 599 | } g_cpucache_up; | 600 | } g_cpucache_up; |
| 600 | 601 | ||
| @@ -671,7 +672,7 @@ static void init_node_lock_keys(int q) | |||
| 671 | { | 672 | { |
| 672 | struct cache_sizes *s = malloc_sizes; | 673 | struct cache_sizes *s = malloc_sizes; |
| 673 | 674 | ||
| 674 | if (g_cpucache_up != FULL) | 675 | if (g_cpucache_up < LATE) |
| 675 | return; | 676 | return; |
| 676 | 677 | ||
| 677 | for (s = malloc_sizes; s->cs_size != ULONG_MAX; s++) { | 678 | for (s = malloc_sizes; s->cs_size != ULONG_MAX; s++) { |
| @@ -1666,6 +1667,8 @@ void __init kmem_cache_init_late(void) | |||
| 1666 | { | 1667 | { |
| 1667 | struct kmem_cache *cachep; | 1668 | struct kmem_cache *cachep; |
| 1668 | 1669 | ||
| 1670 | g_cpucache_up = LATE; | ||
| 1671 | |||
| 1669 | /* Annotate slab for lockdep -- annotate the malloc caches */ | 1672 | /* Annotate slab for lockdep -- annotate the malloc caches */ |
| 1670 | init_lock_keys(); | 1673 | init_lock_keys(); |
| 1671 | 1674 | ||
| @@ -1862,7 +1862,7 @@ static void unfreeze_partials(struct kmem_cache *s) | |||
| 1862 | { | 1862 | { |
| 1863 | struct kmem_cache_node *n = NULL; | 1863 | struct kmem_cache_node *n = NULL; |
| 1864 | struct kmem_cache_cpu *c = this_cpu_ptr(s->cpu_slab); | 1864 | struct kmem_cache_cpu *c = this_cpu_ptr(s->cpu_slab); |
| 1865 | struct page *page; | 1865 | struct page *page, *discard_page = NULL; |
| 1866 | 1866 | ||
| 1867 | while ((page = c->partial)) { | 1867 | while ((page = c->partial)) { |
| 1868 | enum slab_modes { M_PARTIAL, M_FREE }; | 1868 | enum slab_modes { M_PARTIAL, M_FREE }; |
| @@ -1904,7 +1904,8 @@ static void unfreeze_partials(struct kmem_cache *s) | |||
| 1904 | if (l == M_PARTIAL) | 1904 | if (l == M_PARTIAL) |
| 1905 | remove_partial(n, page); | 1905 | remove_partial(n, page); |
| 1906 | else | 1906 | else |
| 1907 | add_partial(n, page, 1); | 1907 | add_partial(n, page, |
| 1908 | DEACTIVATE_TO_TAIL); | ||
| 1908 | 1909 | ||
| 1909 | l = m; | 1910 | l = m; |
| 1910 | } | 1911 | } |
| @@ -1915,14 +1916,22 @@ static void unfreeze_partials(struct kmem_cache *s) | |||
| 1915 | "unfreezing slab")); | 1916 | "unfreezing slab")); |
| 1916 | 1917 | ||
| 1917 | if (m == M_FREE) { | 1918 | if (m == M_FREE) { |
| 1918 | stat(s, DEACTIVATE_EMPTY); | 1919 | page->next = discard_page; |
| 1919 | discard_slab(s, page); | 1920 | discard_page = page; |
| 1920 | stat(s, FREE_SLAB); | ||
| 1921 | } | 1921 | } |
| 1922 | } | 1922 | } |
| 1923 | 1923 | ||
| 1924 | if (n) | 1924 | if (n) |
| 1925 | spin_unlock(&n->list_lock); | 1925 | spin_unlock(&n->list_lock); |
| 1926 | |||
| 1927 | while (discard_page) { | ||
| 1928 | page = discard_page; | ||
| 1929 | discard_page = discard_page->next; | ||
| 1930 | |||
| 1931 | stat(s, DEACTIVATE_EMPTY); | ||
| 1932 | discard_slab(s, page); | ||
| 1933 | stat(s, FREE_SLAB); | ||
| 1934 | } | ||
| 1926 | } | 1935 | } |
| 1927 | 1936 | ||
| 1928 | /* | 1937 | /* |
| @@ -1969,7 +1978,7 @@ int put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) | |||
| 1969 | page->pobjects = pobjects; | 1978 | page->pobjects = pobjects; |
| 1970 | page->next = oldpage; | 1979 | page->next = oldpage; |
| 1971 | 1980 | ||
| 1972 | } while (this_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage); | 1981 | } while (irqsafe_cpu_cmpxchg(s->cpu_slab->partial, oldpage, page) != oldpage); |
| 1973 | stat(s, CPU_PARTIAL_FREE); | 1982 | stat(s, CPU_PARTIAL_FREE); |
| 1974 | return pobjects; | 1983 | return pobjects; |
| 1975 | } | 1984 | } |
| @@ -4435,30 +4444,31 @@ static ssize_t show_slab_objects(struct kmem_cache *s, | |||
| 4435 | 4444 | ||
| 4436 | for_each_possible_cpu(cpu) { | 4445 | for_each_possible_cpu(cpu) { |
| 4437 | struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu); | 4446 | struct kmem_cache_cpu *c = per_cpu_ptr(s->cpu_slab, cpu); |
| 4447 | int node = ACCESS_ONCE(c->node); | ||
| 4438 | struct page *page; | 4448 | struct page *page; |
| 4439 | 4449 | ||
| 4440 | if (!c || c->node < 0) | 4450 | if (node < 0) |
| 4441 | continue; | 4451 | continue; |
| 4442 | 4452 | page = ACCESS_ONCE(c->page); | |
| 4443 | if (c->page) { | 4453 | if (page) { |
| 4444 | if (flags & SO_TOTAL) | 4454 | if (flags & SO_TOTAL) |
| 4445 | x = c->page->objects; | 4455 | x = page->objects; |
| 4446 | else if (flags & SO_OBJECTS) | 4456 | else if (flags & SO_OBJECTS) |
| 4447 | x = c->page->inuse; | 4457 | x = page->inuse; |
| 4448 | else | 4458 | else |
| 4449 | x = 1; | 4459 | x = 1; |
| 4450 | 4460 | ||
| 4451 | total += x; | 4461 | total += x; |
| 4452 | nodes[c->node] += x; | 4462 | nodes[node] += x; |
| 4453 | } | 4463 | } |
| 4454 | page = c->partial; | 4464 | page = c->partial; |
| 4455 | 4465 | ||
| 4456 | if (page) { | 4466 | if (page) { |
| 4457 | x = page->pobjects; | 4467 | x = page->pobjects; |
| 4458 | total += x; | 4468 | total += x; |
| 4459 | nodes[c->node] += x; | 4469 | nodes[node] += x; |
| 4460 | } | 4470 | } |
| 4461 | per_cpu[c->node]++; | 4471 | per_cpu[node]++; |
| 4462 | } | 4472 | } |
| 4463 | } | 4473 | } |
| 4464 | 4474 | ||
diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 3231bf332878..1d8b32f07139 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c | |||
| @@ -1633,6 +1633,8 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, | |||
| 1633 | goto fail; | 1633 | goto fail; |
| 1634 | 1634 | ||
| 1635 | addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller); | 1635 | addr = __vmalloc_area_node(area, gfp_mask, prot, node, caller); |
| 1636 | if (!addr) | ||
| 1637 | return NULL; | ||
| 1636 | 1638 | ||
| 1637 | /* | 1639 | /* |
| 1638 | * In this function, newly allocated vm_struct is not added | 1640 | * In this function, newly allocated vm_struct is not added |
diff --git a/mm/vmscan.c b/mm/vmscan.c index a1893c050795..f54a05b7a61d 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c | |||
| @@ -183,7 +183,7 @@ static unsigned long zone_nr_lru_pages(struct zone *zone, | |||
| 183 | */ | 183 | */ |
| 184 | void register_shrinker(struct shrinker *shrinker) | 184 | void register_shrinker(struct shrinker *shrinker) |
| 185 | { | 185 | { |
| 186 | shrinker->nr = 0; | 186 | atomic_long_set(&shrinker->nr_in_batch, 0); |
| 187 | down_write(&shrinker_rwsem); | 187 | down_write(&shrinker_rwsem); |
| 188 | list_add_tail(&shrinker->list, &shrinker_list); | 188 | list_add_tail(&shrinker->list, &shrinker_list); |
| 189 | up_write(&shrinker_rwsem); | 189 | up_write(&shrinker_rwsem); |
| @@ -247,25 +247,26 @@ unsigned long shrink_slab(struct shrink_control *shrink, | |||
| 247 | 247 | ||
| 248 | list_for_each_entry(shrinker, &shrinker_list, list) { | 248 | list_for_each_entry(shrinker, &shrinker_list, list) { |
| 249 | unsigned long long delta; | 249 | unsigned long long delta; |
| 250 | unsigned long total_scan; | 250 | long total_scan; |
| 251 | unsigned long max_pass; | 251 | long max_pass; |
| 252 | int shrink_ret = 0; | 252 | int shrink_ret = 0; |
| 253 | long nr; | 253 | long nr; |
| 254 | long new_nr; | 254 | long new_nr; |
| 255 | long batch_size = shrinker->batch ? shrinker->batch | 255 | long batch_size = shrinker->batch ? shrinker->batch |
| 256 | : SHRINK_BATCH; | 256 | : SHRINK_BATCH; |
| 257 | 257 | ||
| 258 | max_pass = do_shrinker_shrink(shrinker, shrink, 0); | ||
| 259 | if (max_pass <= 0) | ||
| 260 | continue; | ||
| 261 | |||
| 258 | /* | 262 | /* |
| 259 | * copy the current shrinker scan count into a local variable | 263 | * copy the current shrinker scan count into a local variable |
| 260 | * and zero it so that other concurrent shrinker invocations | 264 | * and zero it so that other concurrent shrinker invocations |
| 261 | * don't also do this scanning work. | 265 | * don't also do this scanning work. |
| 262 | */ | 266 | */ |
| 263 | do { | 267 | nr = atomic_long_xchg(&shrinker->nr_in_batch, 0); |
| 264 | nr = shrinker->nr; | ||
| 265 | } while (cmpxchg(&shrinker->nr, nr, 0) != nr); | ||
| 266 | 268 | ||
| 267 | total_scan = nr; | 269 | total_scan = nr; |
| 268 | max_pass = do_shrinker_shrink(shrinker, shrink, 0); | ||
| 269 | delta = (4 * nr_pages_scanned) / shrinker->seeks; | 270 | delta = (4 * nr_pages_scanned) / shrinker->seeks; |
| 270 | delta *= max_pass; | 271 | delta *= max_pass; |
| 271 | do_div(delta, lru_pages + 1); | 272 | do_div(delta, lru_pages + 1); |
| @@ -325,12 +326,11 @@ unsigned long shrink_slab(struct shrink_control *shrink, | |||
| 325 | * manner that handles concurrent updates. If we exhausted the | 326 | * manner that handles concurrent updates. If we exhausted the |
| 326 | * scan, there is no need to do an update. | 327 | * scan, there is no need to do an update. |
| 327 | */ | 328 | */ |
| 328 | do { | 329 | if (total_scan > 0) |
| 329 | nr = shrinker->nr; | 330 | new_nr = atomic_long_add_return(total_scan, |
| 330 | new_nr = total_scan + nr; | 331 | &shrinker->nr_in_batch); |
| 331 | if (total_scan <= 0) | 332 | else |
| 332 | break; | 333 | new_nr = atomic_long_read(&shrinker->nr_in_batch); |
| 333 | } while (cmpxchg(&shrinker->nr, nr, new_nr) != nr); | ||
| 334 | 334 | ||
| 335 | trace_mm_shrink_slab_end(shrinker, shrink_ret, nr, new_nr); | 335 | trace_mm_shrink_slab_end(shrinker, shrink_ret, nr, new_nr); |
| 336 | } | 336 | } |
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c index c7aafc7c5ed4..5f09a578d49d 100644 --- a/net/batman-adv/translation-table.c +++ b/net/batman-adv/translation-table.c | |||
| @@ -245,9 +245,11 @@ void tt_local_add(struct net_device *soft_iface, const uint8_t *addr, | |||
| 245 | if (tt_global_entry) { | 245 | if (tt_global_entry) { |
| 246 | /* This node is probably going to update its tt table */ | 246 | /* This node is probably going to update its tt table */ |
| 247 | tt_global_entry->orig_node->tt_poss_change = true; | 247 | tt_global_entry->orig_node->tt_poss_change = true; |
| 248 | /* The global entry has to be marked as PENDING and has to be | 248 | /* The global entry has to be marked as ROAMING and has to be |
| 249 | * kept for consistency purpose */ | 249 | * kept for consistency purpose */ |
| 250 | tt_global_entry->flags |= TT_CLIENT_PENDING; | 250 | tt_global_entry->flags |= TT_CLIENT_ROAM; |
| 251 | tt_global_entry->roam_at = jiffies; | ||
| 252 | |||
| 251 | send_roam_adv(bat_priv, tt_global_entry->addr, | 253 | send_roam_adv(bat_priv, tt_global_entry->addr, |
| 252 | tt_global_entry->orig_node); | 254 | tt_global_entry->orig_node); |
| 253 | } | 255 | } |
| @@ -694,6 +696,7 @@ void tt_global_del(struct bat_priv *bat_priv, | |||
| 694 | const char *message, bool roaming) | 696 | const char *message, bool roaming) |
| 695 | { | 697 | { |
| 696 | struct tt_global_entry *tt_global_entry = NULL; | 698 | struct tt_global_entry *tt_global_entry = NULL; |
| 699 | struct tt_local_entry *tt_local_entry = NULL; | ||
| 697 | 700 | ||
| 698 | tt_global_entry = tt_global_hash_find(bat_priv, addr); | 701 | tt_global_entry = tt_global_hash_find(bat_priv, addr); |
| 699 | if (!tt_global_entry) | 702 | if (!tt_global_entry) |
| @@ -701,15 +704,29 @@ void tt_global_del(struct bat_priv *bat_priv, | |||
| 701 | 704 | ||
| 702 | if (tt_global_entry->orig_node == orig_node) { | 705 | if (tt_global_entry->orig_node == orig_node) { |
| 703 | if (roaming) { | 706 | if (roaming) { |
| 704 | tt_global_entry->flags |= TT_CLIENT_ROAM; | 707 | /* if we are deleting a global entry due to a roam |
| 705 | tt_global_entry->roam_at = jiffies; | 708 | * event, there are two possibilities: |
| 706 | goto out; | 709 | * 1) the client roamed from node A to node B => we mark |
| 710 | * it with TT_CLIENT_ROAM, we start a timer and we | ||
| 711 | * wait for node B to claim it. In case of timeout | ||
| 712 | * the entry is purged. | ||
| 713 | * 2) the client roamed to us => we can directly delete | ||
| 714 | * the global entry, since it is useless now. */ | ||
| 715 | tt_local_entry = tt_local_hash_find(bat_priv, | ||
| 716 | tt_global_entry->addr); | ||
| 717 | if (!tt_local_entry) { | ||
| 718 | tt_global_entry->flags |= TT_CLIENT_ROAM; | ||
| 719 | tt_global_entry->roam_at = jiffies; | ||
| 720 | goto out; | ||
| 721 | } | ||
| 707 | } | 722 | } |
| 708 | _tt_global_del(bat_priv, tt_global_entry, message); | 723 | _tt_global_del(bat_priv, tt_global_entry, message); |
| 709 | } | 724 | } |
| 710 | out: | 725 | out: |
| 711 | if (tt_global_entry) | 726 | if (tt_global_entry) |
| 712 | tt_global_entry_free_ref(tt_global_entry); | 727 | tt_global_entry_free_ref(tt_global_entry); |
| 728 | if (tt_local_entry) | ||
| 729 | tt_local_entry_free_ref(tt_local_entry); | ||
| 713 | } | 730 | } |
| 714 | 731 | ||
| 715 | void tt_global_del_orig(struct bat_priv *bat_priv, | 732 | void tt_global_del_orig(struct bat_priv *bat_priv, |
diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c index 91bcd3a961ec..1eea8208b2cc 100644 --- a/net/bluetooth/bnep/core.c +++ b/net/bluetooth/bnep/core.c | |||
| @@ -79,17 +79,12 @@ static struct bnep_session *__bnep_get_session(u8 *dst) | |||
| 79 | 79 | ||
| 80 | static void __bnep_link_session(struct bnep_session *s) | 80 | static void __bnep_link_session(struct bnep_session *s) |
| 81 | { | 81 | { |
| 82 | /* It's safe to call __module_get() here because sessions are added | ||
| 83 | by the socket layer which has to hold the reference to this module. | ||
| 84 | */ | ||
| 85 | __module_get(THIS_MODULE); | ||
| 86 | list_add(&s->list, &bnep_session_list); | 82 | list_add(&s->list, &bnep_session_list); |
| 87 | } | 83 | } |
| 88 | 84 | ||
| 89 | static void __bnep_unlink_session(struct bnep_session *s) | 85 | static void __bnep_unlink_session(struct bnep_session *s) |
| 90 | { | 86 | { |
| 91 | list_del(&s->list); | 87 | list_del(&s->list); |
| 92 | module_put(THIS_MODULE); | ||
| 93 | } | 88 | } |
| 94 | 89 | ||
| 95 | static int bnep_send(struct bnep_session *s, void *data, size_t len) | 90 | static int bnep_send(struct bnep_session *s, void *data, size_t len) |
| @@ -530,6 +525,7 @@ static int bnep_session(void *arg) | |||
| 530 | 525 | ||
| 531 | up_write(&bnep_session_sem); | 526 | up_write(&bnep_session_sem); |
| 532 | free_netdev(dev); | 527 | free_netdev(dev); |
| 528 | module_put_and_exit(0); | ||
| 533 | return 0; | 529 | return 0; |
| 534 | } | 530 | } |
| 535 | 531 | ||
| @@ -616,9 +612,11 @@ int bnep_add_connection(struct bnep_connadd_req *req, struct socket *sock) | |||
| 616 | 612 | ||
| 617 | __bnep_link_session(s); | 613 | __bnep_link_session(s); |
| 618 | 614 | ||
| 615 | __module_get(THIS_MODULE); | ||
| 619 | s->task = kthread_run(bnep_session, s, "kbnepd %s", dev->name); | 616 | s->task = kthread_run(bnep_session, s, "kbnepd %s", dev->name); |
| 620 | if (IS_ERR(s->task)) { | 617 | if (IS_ERR(s->task)) { |
| 621 | /* Session thread start failed, gotta cleanup. */ | 618 | /* Session thread start failed, gotta cleanup. */ |
| 619 | module_put(THIS_MODULE); | ||
| 622 | unregister_netdev(dev); | 620 | unregister_netdev(dev); |
| 623 | __bnep_unlink_session(s); | 621 | __bnep_unlink_session(s); |
| 624 | err = PTR_ERR(s->task); | 622 | err = PTR_ERR(s->task); |
diff --git a/net/bluetooth/cmtp/core.c b/net/bluetooth/cmtp/core.c index 7d00ddf9e9dc..5a6e634f7fca 100644 --- a/net/bluetooth/cmtp/core.c +++ b/net/bluetooth/cmtp/core.c | |||
| @@ -67,14 +67,12 @@ static struct cmtp_session *__cmtp_get_session(bdaddr_t *bdaddr) | |||
| 67 | 67 | ||
| 68 | static void __cmtp_link_session(struct cmtp_session *session) | 68 | static void __cmtp_link_session(struct cmtp_session *session) |
| 69 | { | 69 | { |
| 70 | __module_get(THIS_MODULE); | ||
| 71 | list_add(&session->list, &cmtp_session_list); | 70 | list_add(&session->list, &cmtp_session_list); |
| 72 | } | 71 | } |
| 73 | 72 | ||
| 74 | static void __cmtp_unlink_session(struct cmtp_session *session) | 73 | static void __cmtp_unlink_session(struct cmtp_session *session) |
| 75 | { | 74 | { |
| 76 | list_del(&session->list); | 75 | list_del(&session->list); |
| 77 | module_put(THIS_MODULE); | ||
| 78 | } | 76 | } |
| 79 | 77 | ||
| 80 | static void __cmtp_copy_session(struct cmtp_session *session, struct cmtp_conninfo *ci) | 78 | static void __cmtp_copy_session(struct cmtp_session *session, struct cmtp_conninfo *ci) |
| @@ -327,6 +325,7 @@ static int cmtp_session(void *arg) | |||
| 327 | up_write(&cmtp_session_sem); | 325 | up_write(&cmtp_session_sem); |
| 328 | 326 | ||
| 329 | kfree(session); | 327 | kfree(session); |
| 328 | module_put_and_exit(0); | ||
| 330 | return 0; | 329 | return 0; |
| 331 | } | 330 | } |
| 332 | 331 | ||
| @@ -376,9 +375,11 @@ int cmtp_add_connection(struct cmtp_connadd_req *req, struct socket *sock) | |||
| 376 | 375 | ||
| 377 | __cmtp_link_session(session); | 376 | __cmtp_link_session(session); |
| 378 | 377 | ||
| 378 | __module_get(THIS_MODULE); | ||
| 379 | session->task = kthread_run(cmtp_session, session, "kcmtpd_ctr_%d", | 379 | session->task = kthread_run(cmtp_session, session, "kcmtpd_ctr_%d", |
| 380 | session->num); | 380 | session->num); |
| 381 | if (IS_ERR(session->task)) { | 381 | if (IS_ERR(session->task)) { |
| 382 | module_put(THIS_MODULE); | ||
| 382 | err = PTR_ERR(session->task); | 383 | err = PTR_ERR(session->task); |
| 383 | goto unlink; | 384 | goto unlink; |
| 384 | } | 385 | } |
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index d7d96b6b1f0d..643a41b76e2e 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c | |||
| @@ -545,7 +545,7 @@ static void hci_setup(struct hci_dev *hdev) | |||
| 545 | { | 545 | { |
| 546 | hci_setup_event_mask(hdev); | 546 | hci_setup_event_mask(hdev); |
| 547 | 547 | ||
| 548 | if (hdev->lmp_ver > 1) | 548 | if (hdev->hci_ver > 1) |
| 549 | hci_send_cmd(hdev, HCI_OP_READ_LOCAL_COMMANDS, 0, NULL); | 549 | hci_send_cmd(hdev, HCI_OP_READ_LOCAL_COMMANDS, 0, NULL); |
| 550 | 550 | ||
| 551 | if (hdev->features[6] & LMP_SIMPLE_PAIR) { | 551 | if (hdev->features[6] & LMP_SIMPLE_PAIR) { |
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index e5f9ece3c9a0..a1daf8227ed1 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c | |||
| @@ -18,6 +18,7 @@ | |||
| 18 | #include <net/sock.h> | 18 | #include <net/sock.h> |
| 19 | 19 | ||
| 20 | #include "br_private.h" | 20 | #include "br_private.h" |
| 21 | #include "br_private_stp.h" | ||
| 21 | 22 | ||
| 22 | static inline size_t br_nlmsg_size(void) | 23 | static inline size_t br_nlmsg_size(void) |
| 23 | { | 24 | { |
| @@ -188,6 +189,11 @@ static int br_rtm_setlink(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg) | |||
| 188 | 189 | ||
| 189 | p->state = new_state; | 190 | p->state = new_state; |
| 190 | br_log_state(p); | 191 | br_log_state(p); |
| 192 | |||
| 193 | spin_lock_bh(&p->br->lock); | ||
| 194 | br_port_state_selection(p->br); | ||
| 195 | spin_unlock_bh(&p->br->lock); | ||
| 196 | |||
| 191 | br_ifinfo_notify(RTM_NEWLINK, p); | 197 | br_ifinfo_notify(RTM_NEWLINK, p); |
| 192 | 198 | ||
| 193 | return 0; | 199 | return 0; |
diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c index ad0a3f7cf6cc..dd147d78a588 100644 --- a/net/bridge/br_stp.c +++ b/net/bridge/br_stp.c | |||
| @@ -399,25 +399,24 @@ void br_port_state_selection(struct net_bridge *br) | |||
| 399 | struct net_bridge_port *p; | 399 | struct net_bridge_port *p; |
| 400 | unsigned int liveports = 0; | 400 | unsigned int liveports = 0; |
| 401 | 401 | ||
| 402 | /* Don't change port states if userspace is handling STP */ | ||
| 403 | if (br->stp_enabled == BR_USER_STP) | ||
| 404 | return; | ||
| 405 | |||
| 406 | list_for_each_entry(p, &br->port_list, list) { | 402 | list_for_each_entry(p, &br->port_list, list) { |
| 407 | if (p->state == BR_STATE_DISABLED) | 403 | if (p->state == BR_STATE_DISABLED) |
| 408 | continue; | 404 | continue; |
| 409 | 405 | ||
| 410 | if (p->port_no == br->root_port) { | 406 | /* Don't change port states if userspace is handling STP */ |
| 411 | p->config_pending = 0; | 407 | if (br->stp_enabled != BR_USER_STP) { |
| 412 | p->topology_change_ack = 0; | 408 | if (p->port_no == br->root_port) { |
| 413 | br_make_forwarding(p); | 409 | p->config_pending = 0; |
| 414 | } else if (br_is_designated_port(p)) { | 410 | p->topology_change_ack = 0; |
| 415 | del_timer(&p->message_age_timer); | 411 | br_make_forwarding(p); |
| 416 | br_make_forwarding(p); | 412 | } else if (br_is_designated_port(p)) { |
| 417 | } else { | 413 | del_timer(&p->message_age_timer); |
| 418 | p->config_pending = 0; | 414 | br_make_forwarding(p); |
| 419 | p->topology_change_ack = 0; | 415 | } else { |
| 420 | br_make_blocking(p); | 416 | p->config_pending = 0; |
| 417 | p->topology_change_ack = 0; | ||
| 418 | br_make_blocking(p); | ||
| 419 | } | ||
| 421 | } | 420 | } |
| 422 | 421 | ||
| 423 | if (p->state == BR_STATE_FORWARDING) | 422 | if (p->state == BR_STATE_FORWARDING) |
diff --git a/net/caif/cffrml.c b/net/caif/cffrml.c index f39921171d0d..d3ca87bf23b7 100644 --- a/net/caif/cffrml.c +++ b/net/caif/cffrml.c | |||
| @@ -136,20 +136,21 @@ static int cffrml_receive(struct cflayer *layr, struct cfpkt *pkt) | |||
| 136 | 136 | ||
| 137 | static int cffrml_transmit(struct cflayer *layr, struct cfpkt *pkt) | 137 | static int cffrml_transmit(struct cflayer *layr, struct cfpkt *pkt) |
| 138 | { | 138 | { |
| 139 | int tmp; | ||
| 140 | u16 chks; | 139 | u16 chks; |
| 141 | u16 len; | 140 | u16 len; |
| 141 | __le16 data; | ||
| 142 | |||
| 142 | struct cffrml *this = container_obj(layr); | 143 | struct cffrml *this = container_obj(layr); |
| 143 | if (this->dofcs) { | 144 | if (this->dofcs) { |
| 144 | chks = cfpkt_iterate(pkt, cffrml_checksum, 0xffff); | 145 | chks = cfpkt_iterate(pkt, cffrml_checksum, 0xffff); |
| 145 | tmp = cpu_to_le16(chks); | 146 | data = cpu_to_le16(chks); |
| 146 | cfpkt_add_trail(pkt, &tmp, 2); | 147 | cfpkt_add_trail(pkt, &data, 2); |
| 147 | } else { | 148 | } else { |
| 148 | cfpkt_pad_trail(pkt, 2); | 149 | cfpkt_pad_trail(pkt, 2); |
| 149 | } | 150 | } |
| 150 | len = cfpkt_getlen(pkt); | 151 | len = cfpkt_getlen(pkt); |
| 151 | tmp = cpu_to_le16(len); | 152 | data = cpu_to_le16(len); |
| 152 | cfpkt_add_head(pkt, &tmp, 2); | 153 | cfpkt_add_head(pkt, &data, 2); |
| 153 | cfpkt_info(pkt)->hdr_len += 2; | 154 | cfpkt_info(pkt)->hdr_len += 2; |
| 154 | if (cfpkt_erroneous(pkt)) { | 155 | if (cfpkt_erroneous(pkt)) { |
| 155 | pr_err("Packet is erroneous!\n"); | 156 | pr_err("Packet is erroneous!\n"); |
diff --git a/net/ceph/crush/mapper.c b/net/ceph/crush/mapper.c index 42599e31dcad..3a94eae7abe9 100644 --- a/net/ceph/crush/mapper.c +++ b/net/ceph/crush/mapper.c | |||
| @@ -477,7 +477,6 @@ int crush_do_rule(struct crush_map *map, | |||
| 477 | int i, j; | 477 | int i, j; |
| 478 | int numrep; | 478 | int numrep; |
| 479 | int firstn; | 479 | int firstn; |
| 480 | int rc = -1; | ||
| 481 | 480 | ||
| 482 | BUG_ON(ruleno >= map->max_rules); | 481 | BUG_ON(ruleno >= map->max_rules); |
| 483 | 482 | ||
| @@ -491,23 +490,18 @@ int crush_do_rule(struct crush_map *map, | |||
| 491 | * that this may or may not correspond to the specific types | 490 | * that this may or may not correspond to the specific types |
| 492 | * referenced by the crush rule. | 491 | * referenced by the crush rule. |
| 493 | */ | 492 | */ |
| 494 | if (force >= 0) { | 493 | if (force >= 0 && |
| 495 | if (force >= map->max_devices || | 494 | force < map->max_devices && |
| 496 | map->device_parents[force] == 0) { | 495 | map->device_parents[force] != 0 && |
| 497 | /*dprintk("CRUSH: forcefed device dne\n");*/ | 496 | !is_out(map, weight, force, x)) { |
| 498 | rc = -1; /* force fed device dne */ | 497 | while (1) { |
| 499 | goto out; | 498 | force_context[++force_pos] = force; |
| 500 | } | 499 | if (force >= 0) |
| 501 | if (!is_out(map, weight, force, x)) { | 500 | force = map->device_parents[force]; |
| 502 | while (1) { | 501 | else |
| 503 | force_context[++force_pos] = force; | 502 | force = map->bucket_parents[-1-force]; |
| 504 | if (force >= 0) | 503 | if (force == 0) |
| 505 | force = map->device_parents[force]; | 504 | break; |
| 506 | else | ||
| 507 | force = map->bucket_parents[-1-force]; | ||
| 508 | if (force == 0) | ||
| 509 | break; | ||
| 510 | } | ||
| 511 | } | 505 | } |
| 512 | } | 506 | } |
| 513 | 507 | ||
| @@ -600,10 +594,7 @@ int crush_do_rule(struct crush_map *map, | |||
| 600 | BUG_ON(1); | 594 | BUG_ON(1); |
| 601 | } | 595 | } |
| 602 | } | 596 | } |
| 603 | rc = result_len; | 597 | return result_len; |
| 604 | |||
| 605 | out: | ||
| 606 | return rc; | ||
| 607 | } | 598 | } |
| 608 | 599 | ||
| 609 | 600 | ||
diff --git a/net/core/dev.c b/net/core/dev.c index 6ba50a1e404c..5a13edfc9f73 100644 --- a/net/core/dev.c +++ b/net/core/dev.c | |||
| @@ -1396,7 +1396,7 @@ rollback: | |||
| 1396 | for_each_net(net) { | 1396 | for_each_net(net) { |
| 1397 | for_each_netdev(net, dev) { | 1397 | for_each_netdev(net, dev) { |
| 1398 | if (dev == last) | 1398 | if (dev == last) |
| 1399 | break; | 1399 | goto outroll; |
| 1400 | 1400 | ||
| 1401 | if (dev->flags & IFF_UP) { | 1401 | if (dev->flags & IFF_UP) { |
| 1402 | nb->notifier_call(nb, NETDEV_GOING_DOWN, dev); | 1402 | nb->notifier_call(nb, NETDEV_GOING_DOWN, dev); |
| @@ -1407,6 +1407,7 @@ rollback: | |||
| 1407 | } | 1407 | } |
| 1408 | } | 1408 | } |
| 1409 | 1409 | ||
| 1410 | outroll: | ||
| 1410 | raw_notifier_chain_unregister(&netdev_chain, nb); | 1411 | raw_notifier_chain_unregister(&netdev_chain, nb); |
| 1411 | goto unlock; | 1412 | goto unlock; |
| 1412 | } | 1413 | } |
| @@ -4282,6 +4283,12 @@ static int dev_seq_open(struct inode *inode, struct file *file) | |||
| 4282 | sizeof(struct dev_iter_state)); | 4283 | sizeof(struct dev_iter_state)); |
| 4283 | } | 4284 | } |
| 4284 | 4285 | ||
| 4286 | int dev_seq_open_ops(struct inode *inode, struct file *file, | ||
| 4287 | const struct seq_operations *ops) | ||
| 4288 | { | ||
| 4289 | return seq_open_net(inode, file, ops, sizeof(struct dev_iter_state)); | ||
| 4290 | } | ||
| 4291 | |||
| 4285 | static const struct file_operations dev_seq_fops = { | 4292 | static const struct file_operations dev_seq_fops = { |
| 4286 | .owner = THIS_MODULE, | 4293 | .owner = THIS_MODULE, |
| 4287 | .open = dev_seq_open, | 4294 | .open = dev_seq_open, |
diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index 277faef9148d..febba516db62 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c | |||
| @@ -696,8 +696,7 @@ static const struct seq_operations dev_mc_seq_ops = { | |||
| 696 | 696 | ||
| 697 | static int dev_mc_seq_open(struct inode *inode, struct file *file) | 697 | static int dev_mc_seq_open(struct inode *inode, struct file *file) |
| 698 | { | 698 | { |
| 699 | return seq_open_net(inode, file, &dev_mc_seq_ops, | 699 | return dev_seq_open_ops(inode, file, &dev_mc_seq_ops); |
| 700 | sizeof(struct seq_net_private)); | ||
| 701 | } | 700 | } |
| 702 | 701 | ||
| 703 | static const struct file_operations dev_mc_seq_fops = { | 702 | static const struct file_operations dev_mc_seq_fops = { |
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 039d51e6c284..5ac07d31fbc9 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c | |||
| @@ -2397,7 +2397,10 @@ static struct pneigh_entry *pneigh_get_next(struct seq_file *seq, | |||
| 2397 | struct net *net = seq_file_net(seq); | 2397 | struct net *net = seq_file_net(seq); |
| 2398 | struct neigh_table *tbl = state->tbl; | 2398 | struct neigh_table *tbl = state->tbl; |
| 2399 | 2399 | ||
| 2400 | pn = pn->next; | 2400 | do { |
| 2401 | pn = pn->next; | ||
| 2402 | } while (pn && !net_eq(pneigh_net(pn), net)); | ||
| 2403 | |||
| 2401 | while (!pn) { | 2404 | while (!pn) { |
| 2402 | if (++state->bucket > PNEIGH_HASHMASK) | 2405 | if (++state->bucket > PNEIGH_HASHMASK) |
| 2403 | break; | 2406 | break; |
diff --git a/net/core/request_sock.c b/net/core/request_sock.c index 182236b2510a..9b570a6a33c5 100644 --- a/net/core/request_sock.c +++ b/net/core/request_sock.c | |||
| @@ -26,10 +26,11 @@ | |||
| 26 | * but then some measure against one socket starving all other sockets | 26 | * but then some measure against one socket starving all other sockets |
| 27 | * would be needed. | 27 | * would be needed. |
| 28 | * | 28 | * |
| 29 | * It was 128 by default. Experiments with real servers show, that | 29 | * The minimum value of it is 128. Experiments with real servers show that |
| 30 | * it is absolutely not enough even at 100conn/sec. 256 cures most | 30 | * it is absolutely not enough even at 100conn/sec. 256 cures most |
| 31 | * of problems. This value is adjusted to 128 for very small machines | 31 | * of problems. |
| 32 | * (<=32Mb of memory) and to 1024 on normal or better ones (>=256Mb). | 32 | * This value is adjusted to 128 for low memory machines, |
| 33 | * and it will increase in proportion to the memory of machine. | ||
| 33 | * Note : Dont forget somaxconn that may limit backlog too. | 34 | * Note : Dont forget somaxconn that may limit backlog too. |
| 34 | */ | 35 | */ |
| 35 | int sysctl_max_syn_backlog = 256; | 36 | int sysctl_max_syn_backlog = 256; |
diff --git a/net/core/secure_seq.c b/net/core/secure_seq.c index 025233de25f9..925991ae6f52 100644 --- a/net/core/secure_seq.c +++ b/net/core/secure_seq.c | |||
| @@ -19,6 +19,7 @@ static int __init net_secret_init(void) | |||
| 19 | } | 19 | } |
| 20 | late_initcall(net_secret_init); | 20 | late_initcall(net_secret_init); |
| 21 | 21 | ||
| 22 | #ifdef CONFIG_INET | ||
| 22 | static u32 seq_scale(u32 seq) | 23 | static u32 seq_scale(u32 seq) |
| 23 | { | 24 | { |
| 24 | /* | 25 | /* |
| @@ -33,6 +34,7 @@ static u32 seq_scale(u32 seq) | |||
| 33 | */ | 34 | */ |
| 34 | return seq + (ktime_to_ns(ktime_get_real()) >> 6); | 35 | return seq + (ktime_to_ns(ktime_get_real()) >> 6); |
| 35 | } | 36 | } |
| 37 | #endif | ||
| 36 | 38 | ||
| 37 | #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) | 39 | #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) |
| 38 | __u32 secure_tcpv6_sequence_number(const __be32 *saddr, const __be32 *daddr, | 40 | __u32 secure_tcpv6_sequence_number(const __be32 *saddr, const __be32 *daddr, |
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 18a3cebb753d..3c30ee4a5710 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c | |||
| @@ -2230,7 +2230,7 @@ static int skb_prepare_for_shift(struct sk_buff *skb) | |||
| 2230 | * @shiftlen: shift up to this many bytes | 2230 | * @shiftlen: shift up to this many bytes |
| 2231 | * | 2231 | * |
| 2232 | * Attempts to shift up to shiftlen worth of bytes, which may be less than | 2232 | * Attempts to shift up to shiftlen worth of bytes, which may be less than |
| 2233 | * the length of the skb, from tgt to skb. Returns number bytes shifted. | 2233 | * the length of the skb, from skb to tgt. Returns number bytes shifted. |
| 2234 | * It's up to caller to free skb if everything was shifted. | 2234 | * It's up to caller to free skb if everything was shifted. |
| 2235 | * | 2235 | * |
| 2236 | * If @tgt runs out of frags, the whole operation is aborted. | 2236 | * If @tgt runs out of frags, the whole operation is aborted. |
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c index 90a919afbed7..3f4e5414c8e5 100644 --- a/net/dccp/ipv4.c +++ b/net/dccp/ipv4.c | |||
| @@ -111,6 +111,7 @@ int dccp_v4_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len) | |||
| 111 | rt = ip_route_newports(fl4, rt, orig_sport, orig_dport, | 111 | rt = ip_route_newports(fl4, rt, orig_sport, orig_dport, |
| 112 | inet->inet_sport, inet->inet_dport, sk); | 112 | inet->inet_sport, inet->inet_dport, sk); |
| 113 | if (IS_ERR(rt)) { | 113 | if (IS_ERR(rt)) { |
| 114 | err = PTR_ERR(rt); | ||
| 114 | rt = NULL; | 115 | rt = NULL; |
| 115 | goto failure; | 116 | goto failure; |
| 116 | } | 117 | } |
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c index a77d16158eb6..94f4ec036669 100644 --- a/net/decnet/dn_route.c +++ b/net/decnet/dn_route.c | |||
| @@ -112,7 +112,7 @@ static unsigned long dn_rt_deadline; | |||
| 112 | static int dn_dst_gc(struct dst_ops *ops); | 112 | static int dn_dst_gc(struct dst_ops *ops); |
| 113 | static struct dst_entry *dn_dst_check(struct dst_entry *, __u32); | 113 | static struct dst_entry *dn_dst_check(struct dst_entry *, __u32); |
| 114 | static unsigned int dn_dst_default_advmss(const struct dst_entry *dst); | 114 | static unsigned int dn_dst_default_advmss(const struct dst_entry *dst); |
| 115 | static unsigned int dn_dst_default_mtu(const struct dst_entry *dst); | 115 | static unsigned int dn_dst_mtu(const struct dst_entry *dst); |
| 116 | static void dn_dst_destroy(struct dst_entry *); | 116 | static void dn_dst_destroy(struct dst_entry *); |
| 117 | static struct dst_entry *dn_dst_negative_advice(struct dst_entry *); | 117 | static struct dst_entry *dn_dst_negative_advice(struct dst_entry *); |
| 118 | static void dn_dst_link_failure(struct sk_buff *); | 118 | static void dn_dst_link_failure(struct sk_buff *); |
| @@ -135,7 +135,7 @@ static struct dst_ops dn_dst_ops = { | |||
| 135 | .gc = dn_dst_gc, | 135 | .gc = dn_dst_gc, |
| 136 | .check = dn_dst_check, | 136 | .check = dn_dst_check, |
| 137 | .default_advmss = dn_dst_default_advmss, | 137 | .default_advmss = dn_dst_default_advmss, |
| 138 | .default_mtu = dn_dst_default_mtu, | 138 | .mtu = dn_dst_mtu, |
| 139 | .cow_metrics = dst_cow_metrics_generic, | 139 | .cow_metrics = dst_cow_metrics_generic, |
| 140 | .destroy = dn_dst_destroy, | 140 | .destroy = dn_dst_destroy, |
| 141 | .negative_advice = dn_dst_negative_advice, | 141 | .negative_advice = dn_dst_negative_advice, |
| @@ -825,9 +825,11 @@ static unsigned int dn_dst_default_advmss(const struct dst_entry *dst) | |||
| 825 | return dn_mss_from_pmtu(dst->dev, dst_mtu(dst)); | 825 | return dn_mss_from_pmtu(dst->dev, dst_mtu(dst)); |
| 826 | } | 826 | } |
| 827 | 827 | ||
| 828 | static unsigned int dn_dst_default_mtu(const struct dst_entry *dst) | 828 | static unsigned int dn_dst_mtu(const struct dst_entry *dst) |
| 829 | { | 829 | { |
| 830 | return dst->dev->mtu; | 830 | unsigned int mtu = dst_metric_raw(dst, RTAX_MTU); |
| 831 | |||
| 832 | return mtu ? : dst->dev->mtu; | ||
| 831 | } | 833 | } |
| 832 | 834 | ||
| 833 | static struct neighbour *dn_dst_neigh_lookup(const struct dst_entry *dst, const void *daddr) | 835 | static struct neighbour *dn_dst_neigh_lookup(const struct dst_entry *dst, const void *daddr) |
diff --git a/net/decnet/dn_timer.c b/net/decnet/dn_timer.c index 67f691bd4acf..d9c150cc59a9 100644 --- a/net/decnet/dn_timer.c +++ b/net/decnet/dn_timer.c | |||
| @@ -36,16 +36,13 @@ static void dn_slow_timer(unsigned long arg); | |||
| 36 | 36 | ||
| 37 | void dn_start_slow_timer(struct sock *sk) | 37 | void dn_start_slow_timer(struct sock *sk) |
| 38 | { | 38 | { |
| 39 | sk->sk_timer.expires = jiffies + SLOW_INTERVAL; | 39 | setup_timer(&sk->sk_timer, dn_slow_timer, (unsigned long)sk); |
| 40 | sk->sk_timer.function = dn_slow_timer; | 40 | sk_reset_timer(sk, &sk->sk_timer, jiffies + SLOW_INTERVAL); |
| 41 | sk->sk_timer.data = (unsigned long)sk; | ||
| 42 | |||
| 43 | add_timer(&sk->sk_timer); | ||
| 44 | } | 41 | } |
| 45 | 42 | ||
| 46 | void dn_stop_slow_timer(struct sock *sk) | 43 | void dn_stop_slow_timer(struct sock *sk) |
| 47 | { | 44 | { |
| 48 | del_timer(&sk->sk_timer); | 45 | sk_stop_timer(sk, &sk->sk_timer); |
| 49 | } | 46 | } |
| 50 | 47 | ||
| 51 | static void dn_slow_timer(unsigned long arg) | 48 | static void dn_slow_timer(unsigned long arg) |
| @@ -53,12 +50,10 @@ static void dn_slow_timer(unsigned long arg) | |||
| 53 | struct sock *sk = (struct sock *)arg; | 50 | struct sock *sk = (struct sock *)arg; |
| 54 | struct dn_scp *scp = DN_SK(sk); | 51 | struct dn_scp *scp = DN_SK(sk); |
| 55 | 52 | ||
| 56 | sock_hold(sk); | ||
| 57 | bh_lock_sock(sk); | 53 | bh_lock_sock(sk); |
| 58 | 54 | ||
| 59 | if (sock_owned_by_user(sk)) { | 55 | if (sock_owned_by_user(sk)) { |
| 60 | sk->sk_timer.expires = jiffies + HZ / 10; | 56 | sk_reset_timer(sk, &sk->sk_timer, jiffies + HZ / 10); |
| 61 | add_timer(&sk->sk_timer); | ||
| 62 | goto out; | 57 | goto out; |
| 63 | } | 58 | } |
| 64 | 59 | ||
| @@ -100,9 +95,7 @@ static void dn_slow_timer(unsigned long arg) | |||
| 100 | scp->keepalive_fxn(sk); | 95 | scp->keepalive_fxn(sk); |
| 101 | } | 96 | } |
| 102 | 97 | ||
| 103 | sk->sk_timer.expires = jiffies + SLOW_INTERVAL; | 98 | sk_reset_timer(sk, &sk->sk_timer, jiffies + SLOW_INTERVAL); |
| 104 | |||
| 105 | add_timer(&sk->sk_timer); | ||
| 106 | out: | 99 | out: |
| 107 | bh_unlock_sock(sk); | 100 | bh_unlock_sock(sk); |
| 108 | sock_put(sk); | 101 | sock_put(sk); |
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index c6b5092f29a1..65f01dc47565 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c | |||
| @@ -1490,7 +1490,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write, | |||
| 1490 | void __user *buffer, | 1490 | void __user *buffer, |
| 1491 | size_t *lenp, loff_t *ppos) | 1491 | size_t *lenp, loff_t *ppos) |
| 1492 | { | 1492 | { |
| 1493 | int old_value = *(int *)ctl->data; | ||
| 1493 | int ret = proc_dointvec(ctl, write, buffer, lenp, ppos); | 1494 | int ret = proc_dointvec(ctl, write, buffer, lenp, ppos); |
| 1495 | int new_value = *(int *)ctl->data; | ||
| 1494 | 1496 | ||
| 1495 | if (write) { | 1497 | if (write) { |
| 1496 | struct ipv4_devconf *cnf = ctl->extra1; | 1498 | struct ipv4_devconf *cnf = ctl->extra1; |
| @@ -1501,6 +1503,9 @@ static int devinet_conf_proc(ctl_table *ctl, int write, | |||
| 1501 | 1503 | ||
| 1502 | if (cnf == net->ipv4.devconf_dflt) | 1504 | if (cnf == net->ipv4.devconf_dflt) |
| 1503 | devinet_copy_dflt_conf(net, i); | 1505 | devinet_copy_dflt_conf(net, i); |
| 1506 | if (i == IPV4_DEVCONF_ACCEPT_LOCAL - 1) | ||
| 1507 | if ((new_value == 0) && (old_value != 0)) | ||
| 1508 | rt_cache_flush(net, 0); | ||
| 1504 | } | 1509 | } |
| 1505 | 1510 | ||
| 1506 | return ret; | 1511 | return ret; |
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index c7472eff2d51..b2ca095cb9da 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c | |||
| @@ -1716,7 +1716,8 @@ static int ip_mc_add_src(struct in_device *in_dev, __be32 *pmca, int sfmode, | |||
| 1716 | if (err) { | 1716 | if (err) { |
| 1717 | int j; | 1717 | int j; |
| 1718 | 1718 | ||
| 1719 | pmc->sfcount[sfmode]--; | 1719 | if (!delta) |
| 1720 | pmc->sfcount[sfmode]--; | ||
| 1720 | for (j=0; j<i; j++) | 1721 | for (j=0; j<i; j++) |
| 1721 | (void) ip_mc_del1_src(pmc, sfmode, &psfsrc[j]); | 1722 | (void) ip_mc_del1_src(pmc, sfmode, &psfsrc[j]); |
| 1722 | } else if (isexclude != (pmc->sfcount[MCAST_EXCLUDE] != 0)) { | 1723 | } else if (isexclude != (pmc->sfcount[MCAST_EXCLUDE] != 0)) { |
diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index 68e8ac514383..ccee270a9b65 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag.c | |||
| @@ -108,9 +108,6 @@ static int inet_csk_diag_fill(struct sock *sk, | |||
| 108 | icsk->icsk_ca_ops->name); | 108 | icsk->icsk_ca_ops->name); |
| 109 | } | 109 | } |
| 110 | 110 | ||
| 111 | if ((ext & (1 << (INET_DIAG_TOS - 1))) && (sk->sk_family != AF_INET6)) | ||
| 112 | RTA_PUT_U8(skb, INET_DIAG_TOS, inet->tos); | ||
| 113 | |||
| 114 | r->idiag_family = sk->sk_family; | 111 | r->idiag_family = sk->sk_family; |
| 115 | r->idiag_state = sk->sk_state; | 112 | r->idiag_state = sk->sk_state; |
| 116 | r->idiag_timer = 0; | 113 | r->idiag_timer = 0; |
| @@ -125,16 +122,23 @@ static int inet_csk_diag_fill(struct sock *sk, | |||
| 125 | r->id.idiag_src[0] = inet->inet_rcv_saddr; | 122 | r->id.idiag_src[0] = inet->inet_rcv_saddr; |
| 126 | r->id.idiag_dst[0] = inet->inet_daddr; | 123 | r->id.idiag_dst[0] = inet->inet_daddr; |
| 127 | 124 | ||
| 125 | /* IPv6 dual-stack sockets use inet->tos for IPv4 connections, | ||
| 126 | * hence this needs to be included regardless of socket family. | ||
| 127 | */ | ||
| 128 | if (ext & (1 << (INET_DIAG_TOS - 1))) | ||
| 129 | RTA_PUT_U8(skb, INET_DIAG_TOS, inet->tos); | ||
| 130 | |||
| 128 | #if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE) | 131 | #if defined(CONFIG_IPV6) || defined (CONFIG_IPV6_MODULE) |
| 129 | if (r->idiag_family == AF_INET6) { | 132 | if (r->idiag_family == AF_INET6) { |
| 130 | const struct ipv6_pinfo *np = inet6_sk(sk); | 133 | const struct ipv6_pinfo *np = inet6_sk(sk); |
| 131 | 134 | ||
| 135 | if (ext & (1 << (INET_DIAG_TCLASS - 1))) | ||
| 136 | RTA_PUT_U8(skb, INET_DIAG_TCLASS, np->tclass); | ||
| 137 | |||
| 132 | ipv6_addr_copy((struct in6_addr *)r->id.idiag_src, | 138 | ipv6_addr_copy((struct in6_addr *)r->id.idiag_src, |
| 133 | &np->rcv_saddr); | 139 | &np->rcv_saddr); |
| 134 | ipv6_addr_copy((struct in6_addr *)r->id.idiag_dst, | 140 | ipv6_addr_copy((struct in6_addr *)r->id.idiag_dst, |
| 135 | &np->daddr); | 141 | &np->daddr); |
| 136 | if (ext & (1 << (INET_DIAG_TCLASS - 1))) | ||
| 137 | RTA_PUT_U8(skb, INET_DIAG_TCLASS, np->tclass); | ||
| 138 | } | 142 | } |
| 139 | #endif | 143 | #endif |
| 140 | 144 | ||
diff --git a/net/ipv4/ip_forward.c b/net/ipv4/ip_forward.c index 3b34d1c86270..29a07b6c7168 100644 --- a/net/ipv4/ip_forward.c +++ b/net/ipv4/ip_forward.c | |||
| @@ -84,7 +84,7 @@ int ip_forward(struct sk_buff *skb) | |||
| 84 | 84 | ||
| 85 | rt = skb_rtable(skb); | 85 | rt = skb_rtable(skb); |
| 86 | 86 | ||
| 87 | if (opt->is_strictroute && ip_hdr(skb)->daddr != rt->rt_gateway) | 87 | if (opt->is_strictroute && opt->nexthop != rt->rt_gateway) |
| 88 | goto sr_failed; | 88 | goto sr_failed; |
| 89 | 89 | ||
| 90 | if (unlikely(skb->len > dst_mtu(&rt->dst) && !skb_is_gso(skb) && | 90 | if (unlikely(skb->len > dst_mtu(&rt->dst) && !skb_is_gso(skb) && |
diff --git a/net/ipv4/ip_options.c b/net/ipv4/ip_options.c index 05d20cca9d66..1e60f7679075 100644 --- a/net/ipv4/ip_options.c +++ b/net/ipv4/ip_options.c | |||
| @@ -568,12 +568,13 @@ void ip_forward_options(struct sk_buff *skb) | |||
| 568 | ) { | 568 | ) { |
| 569 | if (srrptr + 3 > srrspace) | 569 | if (srrptr + 3 > srrspace) |
| 570 | break; | 570 | break; |
| 571 | if (memcmp(&ip_hdr(skb)->daddr, &optptr[srrptr-1], 4) == 0) | 571 | if (memcmp(&opt->nexthop, &optptr[srrptr-1], 4) == 0) |
| 572 | break; | 572 | break; |
| 573 | } | 573 | } |
| 574 | if (srrptr + 3 <= srrspace) { | 574 | if (srrptr + 3 <= srrspace) { |
| 575 | opt->is_changed = 1; | 575 | opt->is_changed = 1; |
| 576 | ip_rt_get_source(&optptr[srrptr-1], skb, rt); | 576 | ip_rt_get_source(&optptr[srrptr-1], skb, rt); |
| 577 | ip_hdr(skb)->daddr = opt->nexthop; | ||
| 577 | optptr[2] = srrptr+4; | 578 | optptr[2] = srrptr+4; |
| 578 | } else if (net_ratelimit()) | 579 | } else if (net_ratelimit()) |
| 579 | printk(KERN_CRIT "ip_forward(): Argh! Destination lost!\n"); | 580 | printk(KERN_CRIT "ip_forward(): Argh! Destination lost!\n"); |
| @@ -640,7 +641,7 @@ int ip_options_rcv_srr(struct sk_buff *skb) | |||
| 640 | } | 641 | } |
| 641 | if (srrptr <= srrspace) { | 642 | if (srrptr <= srrspace) { |
| 642 | opt->srr_is_hit = 1; | 643 | opt->srr_is_hit = 1; |
| 643 | iph->daddr = nexthop; | 644 | opt->nexthop = nexthop; |
| 644 | opt->is_changed = 1; | 645 | opt->is_changed = 1; |
| 645 | } | 646 | } |
| 646 | return 0; | 647 | return 0; |
diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 065effd8349a..0b2e7329abda 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c | |||
| @@ -285,6 +285,8 @@ static struct ip_tunnel * ipip_tunnel_locate(struct net *net, | |||
| 285 | if (register_netdevice(dev) < 0) | 285 | if (register_netdevice(dev) < 0) |
| 286 | goto failed_free; | 286 | goto failed_free; |
| 287 | 287 | ||
| 288 | strcpy(nt->parms.name, dev->name); | ||
| 289 | |||
| 288 | dev_hold(dev); | 290 | dev_hold(dev); |
| 289 | ipip_tunnel_link(ipn, nt); | 291 | ipip_tunnel_link(ipn, nt); |
| 290 | return nt; | 292 | return nt; |
| @@ -759,7 +761,6 @@ static int ipip_tunnel_init(struct net_device *dev) | |||
| 759 | struct ip_tunnel *tunnel = netdev_priv(dev); | 761 | struct ip_tunnel *tunnel = netdev_priv(dev); |
| 760 | 762 | ||
| 761 | tunnel->dev = dev; | 763 | tunnel->dev = dev; |
| 762 | strcpy(tunnel->parms.name, dev->name); | ||
| 763 | 764 | ||
| 764 | memcpy(dev->dev_addr, &tunnel->parms.iph.saddr, 4); | 765 | memcpy(dev->dev_addr, &tunnel->parms.iph.saddr, 4); |
| 765 | memcpy(dev->broadcast, &tunnel->parms.iph.daddr, 4); | 766 | memcpy(dev->broadcast, &tunnel->parms.iph.daddr, 4); |
| @@ -825,6 +826,7 @@ static void ipip_destroy_tunnels(struct ipip_net *ipn, struct list_head *head) | |||
| 825 | static int __net_init ipip_init_net(struct net *net) | 826 | static int __net_init ipip_init_net(struct net *net) |
| 826 | { | 827 | { |
| 827 | struct ipip_net *ipn = net_generic(net, ipip_net_id); | 828 | struct ipip_net *ipn = net_generic(net, ipip_net_id); |
| 829 | struct ip_tunnel *t; | ||
| 828 | int err; | 830 | int err; |
| 829 | 831 | ||
| 830 | ipn->tunnels[0] = ipn->tunnels_wc; | 832 | ipn->tunnels[0] = ipn->tunnels_wc; |
| @@ -848,6 +850,9 @@ static int __net_init ipip_init_net(struct net *net) | |||
| 848 | if ((err = register_netdev(ipn->fb_tunnel_dev))) | 850 | if ((err = register_netdev(ipn->fb_tunnel_dev))) |
| 849 | goto err_reg_dev; | 851 | goto err_reg_dev; |
| 850 | 852 | ||
| 853 | t = netdev_priv(ipn->fb_tunnel_dev); | ||
| 854 | |||
| 855 | strcpy(t->parms.name, ipn->fb_tunnel_dev->name); | ||
| 851 | return 0; | 856 | return 0; |
| 852 | 857 | ||
| 853 | err_reg_dev: | 858 | err_reg_dev: |
diff --git a/net/ipv4/netfilter.c b/net/ipv4/netfilter.c index 9899619ab9b8..4f47e064e262 100644 --- a/net/ipv4/netfilter.c +++ b/net/ipv4/netfilter.c | |||
| @@ -64,7 +64,8 @@ int ip_route_me_harder(struct sk_buff *skb, unsigned addr_type) | |||
| 64 | /* Change in oif may mean change in hh_len. */ | 64 | /* Change in oif may mean change in hh_len. */ |
| 65 | hh_len = skb_dst(skb)->dev->hard_header_len; | 65 | hh_len = skb_dst(skb)->dev->hard_header_len; |
| 66 | if (skb_headroom(skb) < hh_len && | 66 | if (skb_headroom(skb) < hh_len && |
| 67 | pskb_expand_head(skb, hh_len - skb_headroom(skb), 0, GFP_ATOMIC)) | 67 | pskb_expand_head(skb, HH_DATA_ALIGN(hh_len - skb_headroom(skb)), |
| 68 | 0, GFP_ATOMIC)) | ||
| 68 | return -1; | 69 | return -1; |
| 69 | 70 | ||
| 70 | return 0; | 71 | return 0; |
diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig index 1dfc18a03fd4..f19f2182894c 100644 --- a/net/ipv4/netfilter/Kconfig +++ b/net/ipv4/netfilter/Kconfig | |||
| @@ -325,7 +325,6 @@ config IP_NF_TARGET_TTL | |||
| 325 | # raw + specific targets | 325 | # raw + specific targets |
| 326 | config IP_NF_RAW | 326 | config IP_NF_RAW |
| 327 | tristate 'raw table support (required for NOTRACK/TRACE)' | 327 | tristate 'raw table support (required for NOTRACK/TRACE)' |
| 328 | depends on NETFILTER_ADVANCED | ||
| 329 | help | 328 | help |
| 330 | This option adds a `raw' table to iptables. This table is the very | 329 | This option adds a `raw' table to iptables. This table is the very |
| 331 | first in the netfilter framework and hooks in at the PREROUTING | 330 | first in the netfilter framework and hooks in at the PREROUTING |
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 0c74da8a0473..46af62363b8c 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c | |||
| @@ -112,7 +112,7 @@ | |||
| 112 | #include <net/secure_seq.h> | 112 | #include <net/secure_seq.h> |
| 113 | 113 | ||
| 114 | #define RT_FL_TOS(oldflp4) \ | 114 | #define RT_FL_TOS(oldflp4) \ |
| 115 | ((u32)(oldflp4->flowi4_tos & (IPTOS_RT_MASK | RTO_ONLINK))) | 115 | ((oldflp4)->flowi4_tos & (IPTOS_RT_MASK | RTO_ONLINK)) |
| 116 | 116 | ||
| 117 | #define IP_MAX_MTU 0xFFF0 | 117 | #define IP_MAX_MTU 0xFFF0 |
| 118 | 118 | ||
| @@ -131,6 +131,7 @@ static int ip_rt_mtu_expires __read_mostly = 10 * 60 * HZ; | |||
| 131 | static int ip_rt_min_pmtu __read_mostly = 512 + 20 + 20; | 131 | static int ip_rt_min_pmtu __read_mostly = 512 + 20 + 20; |
| 132 | static int ip_rt_min_advmss __read_mostly = 256; | 132 | static int ip_rt_min_advmss __read_mostly = 256; |
| 133 | static int rt_chain_length_max __read_mostly = 20; | 133 | static int rt_chain_length_max __read_mostly = 20; |
| 134 | static int redirect_genid; | ||
| 134 | 135 | ||
| 135 | /* | 136 | /* |
| 136 | * Interface to generic destination cache. | 137 | * Interface to generic destination cache. |
| @@ -138,7 +139,7 @@ static int rt_chain_length_max __read_mostly = 20; | |||
| 138 | 139 | ||
| 139 | static struct dst_entry *ipv4_dst_check(struct dst_entry *dst, u32 cookie); | 140 | static struct dst_entry *ipv4_dst_check(struct dst_entry *dst, u32 cookie); |
| 140 | static unsigned int ipv4_default_advmss(const struct dst_entry *dst); | 141 | static unsigned int ipv4_default_advmss(const struct dst_entry *dst); |
| 141 | static unsigned int ipv4_default_mtu(const struct dst_entry *dst); | 142 | static unsigned int ipv4_mtu(const struct dst_entry *dst); |
| 142 | static void ipv4_dst_destroy(struct dst_entry *dst); | 143 | static void ipv4_dst_destroy(struct dst_entry *dst); |
| 143 | static struct dst_entry *ipv4_negative_advice(struct dst_entry *dst); | 144 | static struct dst_entry *ipv4_negative_advice(struct dst_entry *dst); |
| 144 | static void ipv4_link_failure(struct sk_buff *skb); | 145 | static void ipv4_link_failure(struct sk_buff *skb); |
| @@ -193,7 +194,7 @@ static struct dst_ops ipv4_dst_ops = { | |||
| 193 | .gc = rt_garbage_collect, | 194 | .gc = rt_garbage_collect, |
| 194 | .check = ipv4_dst_check, | 195 | .check = ipv4_dst_check, |
| 195 | .default_advmss = ipv4_default_advmss, | 196 | .default_advmss = ipv4_default_advmss, |
| 196 | .default_mtu = ipv4_default_mtu, | 197 | .mtu = ipv4_mtu, |
| 197 | .cow_metrics = ipv4_cow_metrics, | 198 | .cow_metrics = ipv4_cow_metrics, |
| 198 | .destroy = ipv4_dst_destroy, | 199 | .destroy = ipv4_dst_destroy, |
| 199 | .ifdown = ipv4_dst_ifdown, | 200 | .ifdown = ipv4_dst_ifdown, |
| @@ -416,9 +417,13 @@ static int rt_cache_seq_show(struct seq_file *seq, void *v) | |||
| 416 | else { | 417 | else { |
| 417 | struct rtable *r = v; | 418 | struct rtable *r = v; |
| 418 | struct neighbour *n; | 419 | struct neighbour *n; |
| 419 | int len; | 420 | int len, HHUptod; |
| 420 | 421 | ||
| 422 | rcu_read_lock(); | ||
| 421 | n = dst_get_neighbour(&r->dst); | 423 | n = dst_get_neighbour(&r->dst); |
| 424 | HHUptod = (n && (n->nud_state & NUD_CONNECTED)) ? 1 : 0; | ||
| 425 | rcu_read_unlock(); | ||
| 426 | |||
| 422 | seq_printf(seq, "%s\t%08X\t%08X\t%8X\t%d\t%u\t%d\t" | 427 | seq_printf(seq, "%s\t%08X\t%08X\t%8X\t%d\t%u\t%d\t" |
| 423 | "%08X\t%d\t%u\t%u\t%02X\t%d\t%1d\t%08X%n", | 428 | "%08X\t%d\t%u\t%u\t%02X\t%d\t%1d\t%08X%n", |
| 424 | r->dst.dev ? r->dst.dev->name : "*", | 429 | r->dst.dev ? r->dst.dev->name : "*", |
| @@ -432,7 +437,7 @@ static int rt_cache_seq_show(struct seq_file *seq, void *v) | |||
| 432 | dst_metric(&r->dst, RTAX_RTTVAR)), | 437 | dst_metric(&r->dst, RTAX_RTTVAR)), |
| 433 | r->rt_key_tos, | 438 | r->rt_key_tos, |
| 434 | -1, | 439 | -1, |
| 435 | (n && (n->nud_state & NUD_CONNECTED)) ? 1 : 0, | 440 | HHUptod, |
| 436 | r->rt_spec_dst, &len); | 441 | r->rt_spec_dst, &len); |
| 437 | 442 | ||
| 438 | seq_printf(seq, "%*s\n", 127 - len, ""); | 443 | seq_printf(seq, "%*s\n", 127 - len, ""); |
| @@ -837,6 +842,7 @@ static void rt_cache_invalidate(struct net *net) | |||
| 837 | 842 | ||
| 838 | get_random_bytes(&shuffle, sizeof(shuffle)); | 843 | get_random_bytes(&shuffle, sizeof(shuffle)); |
| 839 | atomic_add(shuffle + 1U, &net->ipv4.rt_genid); | 844 | atomic_add(shuffle + 1U, &net->ipv4.rt_genid); |
| 845 | redirect_genid++; | ||
| 840 | } | 846 | } |
| 841 | 847 | ||
| 842 | /* | 848 | /* |
| @@ -1304,7 +1310,7 @@ static void rt_del(unsigned hash, struct rtable *rt) | |||
| 1304 | spin_unlock_bh(rt_hash_lock_addr(hash)); | 1310 | spin_unlock_bh(rt_hash_lock_addr(hash)); |
| 1305 | } | 1311 | } |
| 1306 | 1312 | ||
| 1307 | static int check_peer_redir(struct dst_entry *dst, struct inet_peer *peer) | 1313 | static void check_peer_redir(struct dst_entry *dst, struct inet_peer *peer) |
| 1308 | { | 1314 | { |
| 1309 | struct rtable *rt = (struct rtable *) dst; | 1315 | struct rtable *rt = (struct rtable *) dst; |
| 1310 | __be32 orig_gw = rt->rt_gateway; | 1316 | __be32 orig_gw = rt->rt_gateway; |
| @@ -1315,21 +1321,19 @@ static int check_peer_redir(struct dst_entry *dst, struct inet_peer *peer) | |||
| 1315 | rt->rt_gateway = peer->redirect_learned.a4; | 1321 | rt->rt_gateway = peer->redirect_learned.a4; |
| 1316 | 1322 | ||
| 1317 | n = ipv4_neigh_lookup(&rt->dst, &rt->rt_gateway); | 1323 | n = ipv4_neigh_lookup(&rt->dst, &rt->rt_gateway); |
| 1318 | if (IS_ERR(n)) | 1324 | if (IS_ERR(n)) { |
| 1319 | return PTR_ERR(n); | 1325 | rt->rt_gateway = orig_gw; |
| 1326 | return; | ||
| 1327 | } | ||
| 1320 | old_n = xchg(&rt->dst._neighbour, n); | 1328 | old_n = xchg(&rt->dst._neighbour, n); |
| 1321 | if (old_n) | 1329 | if (old_n) |
| 1322 | neigh_release(old_n); | 1330 | neigh_release(old_n); |
| 1323 | if (!n || !(n->nud_state & NUD_VALID)) { | 1331 | if (!(n->nud_state & NUD_VALID)) { |
| 1324 | if (n) | 1332 | neigh_event_send(n, NULL); |
| 1325 | neigh_event_send(n, NULL); | ||
| 1326 | rt->rt_gateway = orig_gw; | ||
| 1327 | return -EAGAIN; | ||
| 1328 | } else { | 1333 | } else { |
| 1329 | rt->rt_flags |= RTCF_REDIRECTED; | 1334 | rt->rt_flags |= RTCF_REDIRECTED; |
| 1330 | call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, n); | 1335 | call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, n); |
| 1331 | } | 1336 | } |
| 1332 | return 0; | ||
| 1333 | } | 1337 | } |
| 1334 | 1338 | ||
| 1335 | /* called in rcu_read_lock() section */ | 1339 | /* called in rcu_read_lock() section */ |
| @@ -1391,8 +1395,10 @@ void ip_rt_redirect(__be32 old_gw, __be32 daddr, __be32 new_gw, | |||
| 1391 | 1395 | ||
| 1392 | peer = rt->peer; | 1396 | peer = rt->peer; |
| 1393 | if (peer) { | 1397 | if (peer) { |
| 1394 | if (peer->redirect_learned.a4 != new_gw) { | 1398 | if (peer->redirect_learned.a4 != new_gw || |
| 1399 | peer->redirect_genid != redirect_genid) { | ||
| 1395 | peer->redirect_learned.a4 = new_gw; | 1400 | peer->redirect_learned.a4 = new_gw; |
| 1401 | peer->redirect_genid = redirect_genid; | ||
| 1396 | atomic_inc(&__rt_peer_genid); | 1402 | atomic_inc(&__rt_peer_genid); |
| 1397 | } | 1403 | } |
| 1398 | check_peer_redir(&rt->dst, peer); | 1404 | check_peer_redir(&rt->dst, peer); |
| @@ -1685,12 +1691,8 @@ static void ip_rt_update_pmtu(struct dst_entry *dst, u32 mtu) | |||
| 1685 | } | 1691 | } |
| 1686 | 1692 | ||
| 1687 | 1693 | ||
| 1688 | static struct dst_entry *ipv4_dst_check(struct dst_entry *dst, u32 cookie) | 1694 | static void ipv4_validate_peer(struct rtable *rt) |
| 1689 | { | 1695 | { |
| 1690 | struct rtable *rt = (struct rtable *) dst; | ||
| 1691 | |||
| 1692 | if (rt_is_expired(rt)) | ||
| 1693 | return NULL; | ||
| 1694 | if (rt->rt_peer_genid != rt_peer_genid()) { | 1696 | if (rt->rt_peer_genid != rt_peer_genid()) { |
| 1695 | struct inet_peer *peer; | 1697 | struct inet_peer *peer; |
| 1696 | 1698 | ||
| @@ -1699,17 +1701,26 @@ static struct dst_entry *ipv4_dst_check(struct dst_entry *dst, u32 cookie) | |||
| 1699 | 1701 | ||
| 1700 | peer = rt->peer; | 1702 | peer = rt->peer; |
| 1701 | if (peer) { | 1703 | if (peer) { |
| 1702 | check_peer_pmtu(dst, peer); | 1704 | check_peer_pmtu(&rt->dst, peer); |
| 1703 | 1705 | ||
| 1706 | if (peer->redirect_genid != redirect_genid) | ||
| 1707 | peer->redirect_learned.a4 = 0; | ||
| 1704 | if (peer->redirect_learned.a4 && | 1708 | if (peer->redirect_learned.a4 && |
| 1705 | peer->redirect_learned.a4 != rt->rt_gateway) { | 1709 | peer->redirect_learned.a4 != rt->rt_gateway) |
| 1706 | if (check_peer_redir(dst, peer)) | 1710 | check_peer_redir(&rt->dst, peer); |
| 1707 | return NULL; | ||
| 1708 | } | ||
| 1709 | } | 1711 | } |
| 1710 | 1712 | ||
| 1711 | rt->rt_peer_genid = rt_peer_genid(); | 1713 | rt->rt_peer_genid = rt_peer_genid(); |
| 1712 | } | 1714 | } |
| 1715 | } | ||
| 1716 | |||
| 1717 | static struct dst_entry *ipv4_dst_check(struct dst_entry *dst, u32 cookie) | ||
| 1718 | { | ||
| 1719 | struct rtable *rt = (struct rtable *) dst; | ||
| 1720 | |||
| 1721 | if (rt_is_expired(rt)) | ||
| 1722 | return NULL; | ||
| 1723 | ipv4_validate_peer(rt); | ||
| 1713 | return dst; | 1724 | return dst; |
| 1714 | } | 1725 | } |
| 1715 | 1726 | ||
| @@ -1814,12 +1825,17 @@ static unsigned int ipv4_default_advmss(const struct dst_entry *dst) | |||
| 1814 | return advmss; | 1825 | return advmss; |
| 1815 | } | 1826 | } |
| 1816 | 1827 | ||
| 1817 | static unsigned int ipv4_default_mtu(const struct dst_entry *dst) | 1828 | static unsigned int ipv4_mtu(const struct dst_entry *dst) |
| 1818 | { | 1829 | { |
| 1819 | unsigned int mtu = dst->dev->mtu; | 1830 | const struct rtable *rt = (const struct rtable *) dst; |
| 1831 | unsigned int mtu = dst_metric_raw(dst, RTAX_MTU); | ||
| 1832 | |||
| 1833 | if (mtu && rt_is_output_route(rt)) | ||
| 1834 | return mtu; | ||
| 1835 | |||
| 1836 | mtu = dst->dev->mtu; | ||
| 1820 | 1837 | ||
| 1821 | if (unlikely(dst_metric_locked(dst, RTAX_MTU))) { | 1838 | if (unlikely(dst_metric_locked(dst, RTAX_MTU))) { |
| 1822 | const struct rtable *rt = (const struct rtable *) dst; | ||
| 1823 | 1839 | ||
| 1824 | if (rt->rt_gateway != rt->rt_dst && mtu > 576) | 1840 | if (rt->rt_gateway != rt->rt_dst && mtu > 576) |
| 1825 | mtu = 576; | 1841 | mtu = 576; |
| @@ -1852,6 +1868,8 @@ static void rt_init_metrics(struct rtable *rt, const struct flowi4 *fl4, | |||
| 1852 | dst_init_metrics(&rt->dst, peer->metrics, false); | 1868 | dst_init_metrics(&rt->dst, peer->metrics, false); |
| 1853 | 1869 | ||
| 1854 | check_peer_pmtu(&rt->dst, peer); | 1870 | check_peer_pmtu(&rt->dst, peer); |
| 1871 | if (peer->redirect_genid != redirect_genid) | ||
| 1872 | peer->redirect_learned.a4 = 0; | ||
| 1855 | if (peer->redirect_learned.a4 && | 1873 | if (peer->redirect_learned.a4 && |
| 1856 | peer->redirect_learned.a4 != rt->rt_gateway) { | 1874 | peer->redirect_learned.a4 != rt->rt_gateway) { |
| 1857 | rt->rt_gateway = peer->redirect_learned.a4; | 1875 | rt->rt_gateway = peer->redirect_learned.a4; |
| @@ -2357,6 +2375,7 @@ int ip_route_input_common(struct sk_buff *skb, __be32 daddr, __be32 saddr, | |||
| 2357 | rth->rt_mark == skb->mark && | 2375 | rth->rt_mark == skb->mark && |
| 2358 | net_eq(dev_net(rth->dst.dev), net) && | 2376 | net_eq(dev_net(rth->dst.dev), net) && |
| 2359 | !rt_is_expired(rth)) { | 2377 | !rt_is_expired(rth)) { |
| 2378 | ipv4_validate_peer(rth); | ||
| 2360 | if (noref) { | 2379 | if (noref) { |
| 2361 | dst_use_noref(&rth->dst, jiffies); | 2380 | dst_use_noref(&rth->dst, jiffies); |
| 2362 | skb_dst_set_noref(skb, &rth->dst); | 2381 | skb_dst_set_noref(skb, &rth->dst); |
| @@ -2415,11 +2434,11 @@ EXPORT_SYMBOL(ip_route_input_common); | |||
| 2415 | static struct rtable *__mkroute_output(const struct fib_result *res, | 2434 | static struct rtable *__mkroute_output(const struct fib_result *res, |
| 2416 | const struct flowi4 *fl4, | 2435 | const struct flowi4 *fl4, |
| 2417 | __be32 orig_daddr, __be32 orig_saddr, | 2436 | __be32 orig_daddr, __be32 orig_saddr, |
| 2418 | int orig_oif, struct net_device *dev_out, | 2437 | int orig_oif, __u8 orig_rtos, |
| 2438 | struct net_device *dev_out, | ||
| 2419 | unsigned int flags) | 2439 | unsigned int flags) |
| 2420 | { | 2440 | { |
| 2421 | struct fib_info *fi = res->fi; | 2441 | struct fib_info *fi = res->fi; |
| 2422 | u32 tos = RT_FL_TOS(fl4); | ||
| 2423 | struct in_device *in_dev; | 2442 | struct in_device *in_dev; |
| 2424 | u16 type = res->type; | 2443 | u16 type = res->type; |
| 2425 | struct rtable *rth; | 2444 | struct rtable *rth; |
| @@ -2470,7 +2489,7 @@ static struct rtable *__mkroute_output(const struct fib_result *res, | |||
| 2470 | rth->rt_genid = rt_genid(dev_net(dev_out)); | 2489 | rth->rt_genid = rt_genid(dev_net(dev_out)); |
| 2471 | rth->rt_flags = flags; | 2490 | rth->rt_flags = flags; |
| 2472 | rth->rt_type = type; | 2491 | rth->rt_type = type; |
| 2473 | rth->rt_key_tos = tos; | 2492 | rth->rt_key_tos = orig_rtos; |
| 2474 | rth->rt_dst = fl4->daddr; | 2493 | rth->rt_dst = fl4->daddr; |
| 2475 | rth->rt_src = fl4->saddr; | 2494 | rth->rt_src = fl4->saddr; |
| 2476 | rth->rt_route_iif = 0; | 2495 | rth->rt_route_iif = 0; |
| @@ -2520,7 +2539,7 @@ static struct rtable *__mkroute_output(const struct fib_result *res, | |||
| 2520 | static struct rtable *ip_route_output_slow(struct net *net, struct flowi4 *fl4) | 2539 | static struct rtable *ip_route_output_slow(struct net *net, struct flowi4 *fl4) |
| 2521 | { | 2540 | { |
| 2522 | struct net_device *dev_out = NULL; | 2541 | struct net_device *dev_out = NULL; |
| 2523 | u32 tos = RT_FL_TOS(fl4); | 2542 | __u8 tos = RT_FL_TOS(fl4); |
| 2524 | unsigned int flags = 0; | 2543 | unsigned int flags = 0; |
| 2525 | struct fib_result res; | 2544 | struct fib_result res; |
| 2526 | struct rtable *rth; | 2545 | struct rtable *rth; |
| @@ -2696,7 +2715,7 @@ static struct rtable *ip_route_output_slow(struct net *net, struct flowi4 *fl4) | |||
| 2696 | 2715 | ||
| 2697 | make_route: | 2716 | make_route: |
| 2698 | rth = __mkroute_output(&res, fl4, orig_daddr, orig_saddr, orig_oif, | 2717 | rth = __mkroute_output(&res, fl4, orig_daddr, orig_saddr, orig_oif, |
| 2699 | dev_out, flags); | 2718 | tos, dev_out, flags); |
| 2700 | if (!IS_ERR(rth)) { | 2719 | if (!IS_ERR(rth)) { |
| 2701 | unsigned int hash; | 2720 | unsigned int hash; |
| 2702 | 2721 | ||
| @@ -2732,6 +2751,7 @@ struct rtable *__ip_route_output_key(struct net *net, struct flowi4 *flp4) | |||
| 2732 | (IPTOS_RT_MASK | RTO_ONLINK)) && | 2751 | (IPTOS_RT_MASK | RTO_ONLINK)) && |
| 2733 | net_eq(dev_net(rth->dst.dev), net) && | 2752 | net_eq(dev_net(rth->dst.dev), net) && |
| 2734 | !rt_is_expired(rth)) { | 2753 | !rt_is_expired(rth)) { |
| 2754 | ipv4_validate_peer(rth); | ||
| 2735 | dst_use(&rth->dst, jiffies); | 2755 | dst_use(&rth->dst, jiffies); |
| 2736 | RT_CACHE_STAT_INC(out_hit); | 2756 | RT_CACHE_STAT_INC(out_hit); |
| 2737 | rcu_read_unlock_bh(); | 2757 | rcu_read_unlock_bh(); |
| @@ -2755,9 +2775,11 @@ static struct dst_entry *ipv4_blackhole_dst_check(struct dst_entry *dst, u32 coo | |||
| 2755 | return NULL; | 2775 | return NULL; |
| 2756 | } | 2776 | } |
| 2757 | 2777 | ||
| 2758 | static unsigned int ipv4_blackhole_default_mtu(const struct dst_entry *dst) | 2778 | static unsigned int ipv4_blackhole_mtu(const struct dst_entry *dst) |
| 2759 | { | 2779 | { |
| 2760 | return 0; | 2780 | unsigned int mtu = dst_metric_raw(dst, RTAX_MTU); |
| 2781 | |||
| 2782 | return mtu ? : dst->dev->mtu; | ||
| 2761 | } | 2783 | } |
| 2762 | 2784 | ||
| 2763 | static void ipv4_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) | 2785 | static void ipv4_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) |
| @@ -2775,7 +2797,7 @@ static struct dst_ops ipv4_dst_blackhole_ops = { | |||
| 2775 | .protocol = cpu_to_be16(ETH_P_IP), | 2797 | .protocol = cpu_to_be16(ETH_P_IP), |
| 2776 | .destroy = ipv4_dst_destroy, | 2798 | .destroy = ipv4_dst_destroy, |
| 2777 | .check = ipv4_blackhole_dst_check, | 2799 | .check = ipv4_blackhole_dst_check, |
| 2778 | .default_mtu = ipv4_blackhole_default_mtu, | 2800 | .mtu = ipv4_blackhole_mtu, |
| 2779 | .default_advmss = ipv4_default_advmss, | 2801 | .default_advmss = ipv4_default_advmss, |
| 2780 | .update_pmtu = ipv4_rt_blackhole_update_pmtu, | 2802 | .update_pmtu = ipv4_rt_blackhole_update_pmtu, |
| 2781 | .cow_metrics = ipv4_rt_blackhole_cow_metrics, | 2803 | .cow_metrics = ipv4_rt_blackhole_cow_metrics, |
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index ab0966df1e2a..5a65eeac1d29 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c | |||
| @@ -1164,7 +1164,7 @@ int udp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, | |||
| 1164 | struct inet_sock *inet = inet_sk(sk); | 1164 | struct inet_sock *inet = inet_sk(sk); |
| 1165 | struct sockaddr_in *sin = (struct sockaddr_in *)msg->msg_name; | 1165 | struct sockaddr_in *sin = (struct sockaddr_in *)msg->msg_name; |
| 1166 | struct sk_buff *skb; | 1166 | struct sk_buff *skb; |
| 1167 | unsigned int ulen; | 1167 | unsigned int ulen, copied; |
| 1168 | int peeked; | 1168 | int peeked; |
| 1169 | int err; | 1169 | int err; |
| 1170 | int is_udplite = IS_UDPLITE(sk); | 1170 | int is_udplite = IS_UDPLITE(sk); |
| @@ -1186,9 +1186,10 @@ try_again: | |||
| 1186 | goto out; | 1186 | goto out; |
| 1187 | 1187 | ||
| 1188 | ulen = skb->len - sizeof(struct udphdr); | 1188 | ulen = skb->len - sizeof(struct udphdr); |
| 1189 | if (len > ulen) | 1189 | copied = len; |
| 1190 | len = ulen; | 1190 | if (copied > ulen) |
| 1191 | else if (len < ulen) | 1191 | copied = ulen; |
| 1192 | else if (copied < ulen) | ||
| 1192 | msg->msg_flags |= MSG_TRUNC; | 1193 | msg->msg_flags |= MSG_TRUNC; |
| 1193 | 1194 | ||
| 1194 | /* | 1195 | /* |
| @@ -1197,14 +1198,14 @@ try_again: | |||
| 1197 | * coverage checksum (UDP-Lite), do it before the copy. | 1198 | * coverage checksum (UDP-Lite), do it before the copy. |
| 1198 | */ | 1199 | */ |
| 1199 | 1200 | ||
| 1200 | if (len < ulen || UDP_SKB_CB(skb)->partial_cov) { | 1201 | if (copied < ulen || UDP_SKB_CB(skb)->partial_cov) { |
| 1201 | if (udp_lib_checksum_complete(skb)) | 1202 | if (udp_lib_checksum_complete(skb)) |
| 1202 | goto csum_copy_err; | 1203 | goto csum_copy_err; |
| 1203 | } | 1204 | } |
| 1204 | 1205 | ||
| 1205 | if (skb_csum_unnecessary(skb)) | 1206 | if (skb_csum_unnecessary(skb)) |
| 1206 | err = skb_copy_datagram_iovec(skb, sizeof(struct udphdr), | 1207 | err = skb_copy_datagram_iovec(skb, sizeof(struct udphdr), |
| 1207 | msg->msg_iov, len); | 1208 | msg->msg_iov, copied); |
| 1208 | else { | 1209 | else { |
| 1209 | err = skb_copy_and_csum_datagram_iovec(skb, | 1210 | err = skb_copy_and_csum_datagram_iovec(skb, |
| 1210 | sizeof(struct udphdr), | 1211 | sizeof(struct udphdr), |
| @@ -1233,7 +1234,7 @@ try_again: | |||
| 1233 | if (inet->cmsg_flags) | 1234 | if (inet->cmsg_flags) |
| 1234 | ip_cmsg_recv(msg, skb); | 1235 | ip_cmsg_recv(msg, skb); |
| 1235 | 1236 | ||
| 1236 | err = len; | 1237 | err = copied; |
| 1237 | if (flags & MSG_TRUNC) | 1238 | if (flags & MSG_TRUNC) |
| 1238 | err = ulen; | 1239 | err = ulen; |
| 1239 | 1240 | ||
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index cf88df82e2c2..36806def8cfd 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c | |||
| @@ -1805,7 +1805,8 @@ static struct inet6_dev *addrconf_add_dev(struct net_device *dev) | |||
| 1805 | return ERR_PTR(-EACCES); | 1805 | return ERR_PTR(-EACCES); |
| 1806 | 1806 | ||
| 1807 | /* Add default multicast route */ | 1807 | /* Add default multicast route */ |
| 1808 | addrconf_add_mroute(dev); | 1808 | if (!(dev->flags & IFF_LOOPBACK)) |
| 1809 | addrconf_add_mroute(dev); | ||
| 1809 | 1810 | ||
| 1810 | /* Add link local route */ | 1811 | /* Add link local route */ |
| 1811 | addrconf_add_lroute(dev); | 1812 | addrconf_add_lroute(dev); |
diff --git a/net/ipv6/inet6_connection_sock.c b/net/ipv6/inet6_connection_sock.c index fee46d5a2f12..1567fb120392 100644 --- a/net/ipv6/inet6_connection_sock.c +++ b/net/ipv6/inet6_connection_sock.c | |||
| @@ -85,7 +85,7 @@ struct dst_entry *inet6_csk_route_req(struct sock *sk, | |||
| 85 | * request_sock (formerly open request) hash tables. | 85 | * request_sock (formerly open request) hash tables. |
| 86 | */ | 86 | */ |
| 87 | static u32 inet6_synq_hash(const struct in6_addr *raddr, const __be16 rport, | 87 | static u32 inet6_synq_hash(const struct in6_addr *raddr, const __be16 rport, |
| 88 | const u32 rnd, const u16 synq_hsize) | 88 | const u32 rnd, const u32 synq_hsize) |
| 89 | { | 89 | { |
| 90 | u32 c; | 90 | u32 c; |
| 91 | 91 | ||
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index c99e3ee9781f..26cb08c84b74 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c | |||
| @@ -503,7 +503,7 @@ done: | |||
| 503 | goto e_inval; | 503 | goto e_inval; |
| 504 | if (val > 255 || val < -1) | 504 | if (val > 255 || val < -1) |
| 505 | goto e_inval; | 505 | goto e_inval; |
| 506 | np->mcast_hops = val; | 506 | np->mcast_hops = (val == -1 ? IPV6_DEFAULT_MCASTHOPS : val); |
| 507 | retv = 0; | 507 | retv = 0; |
| 508 | break; | 508 | break; |
| 509 | 509 | ||
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 44e5b7f2a6c1..0cb78d7ddaf5 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c | |||
| @@ -1571,7 +1571,7 @@ void ndisc_send_redirect(struct sk_buff *skb, struct neighbour *neigh, | |||
| 1571 | } | 1571 | } |
| 1572 | if (!rt->rt6i_peer) | 1572 | if (!rt->rt6i_peer) |
| 1573 | rt6_bind_peer(rt, 1); | 1573 | rt6_bind_peer(rt, 1); |
| 1574 | if (inet_peer_xrlim_allow(rt->rt6i_peer, 1*HZ)) | 1574 | if (!inet_peer_xrlim_allow(rt->rt6i_peer, 1*HZ)) |
| 1575 | goto release; | 1575 | goto release; |
| 1576 | 1576 | ||
| 1577 | if (dev->addr_len) { | 1577 | if (dev->addr_len) { |
diff --git a/net/ipv6/netfilter/Kconfig b/net/ipv6/netfilter/Kconfig index 448464844a25..f792b34cbe9c 100644 --- a/net/ipv6/netfilter/Kconfig +++ b/net/ipv6/netfilter/Kconfig | |||
| @@ -186,7 +186,6 @@ config IP6_NF_MANGLE | |||
| 186 | 186 | ||
| 187 | config IP6_NF_RAW | 187 | config IP6_NF_RAW |
| 188 | tristate 'raw table support (required for TRACE)' | 188 | tristate 'raw table support (required for TRACE)' |
| 189 | depends on NETFILTER_ADVANCED | ||
| 190 | help | 189 | help |
| 191 | This option adds a `raw' table to ip6tables. This table is the very | 190 | This option adds a `raw' table to ip6tables. This table is the very |
| 192 | first in the netfilter framework and hooks in at the PREROUTING | 191 | first in the netfilter framework and hooks in at the PREROUTING |
diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 8473016bba4a..b582a0a0f1c5 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c | |||
| @@ -77,7 +77,7 @@ static struct rt6_info *ip6_rt_copy(const struct rt6_info *ort, | |||
| 77 | const struct in6_addr *dest); | 77 | const struct in6_addr *dest); |
| 78 | static struct dst_entry *ip6_dst_check(struct dst_entry *dst, u32 cookie); | 78 | static struct dst_entry *ip6_dst_check(struct dst_entry *dst, u32 cookie); |
| 79 | static unsigned int ip6_default_advmss(const struct dst_entry *dst); | 79 | static unsigned int ip6_default_advmss(const struct dst_entry *dst); |
| 80 | static unsigned int ip6_default_mtu(const struct dst_entry *dst); | 80 | static unsigned int ip6_mtu(const struct dst_entry *dst); |
| 81 | static struct dst_entry *ip6_negative_advice(struct dst_entry *); | 81 | static struct dst_entry *ip6_negative_advice(struct dst_entry *); |
| 82 | static void ip6_dst_destroy(struct dst_entry *); | 82 | static void ip6_dst_destroy(struct dst_entry *); |
| 83 | static void ip6_dst_ifdown(struct dst_entry *, | 83 | static void ip6_dst_ifdown(struct dst_entry *, |
| @@ -144,7 +144,7 @@ static struct dst_ops ip6_dst_ops_template = { | |||
| 144 | .gc_thresh = 1024, | 144 | .gc_thresh = 1024, |
| 145 | .check = ip6_dst_check, | 145 | .check = ip6_dst_check, |
| 146 | .default_advmss = ip6_default_advmss, | 146 | .default_advmss = ip6_default_advmss, |
| 147 | .default_mtu = ip6_default_mtu, | 147 | .mtu = ip6_mtu, |
| 148 | .cow_metrics = ipv6_cow_metrics, | 148 | .cow_metrics = ipv6_cow_metrics, |
| 149 | .destroy = ip6_dst_destroy, | 149 | .destroy = ip6_dst_destroy, |
| 150 | .ifdown = ip6_dst_ifdown, | 150 | .ifdown = ip6_dst_ifdown, |
| @@ -155,9 +155,11 @@ static struct dst_ops ip6_dst_ops_template = { | |||
| 155 | .neigh_lookup = ip6_neigh_lookup, | 155 | .neigh_lookup = ip6_neigh_lookup, |
| 156 | }; | 156 | }; |
| 157 | 157 | ||
| 158 | static unsigned int ip6_blackhole_default_mtu(const struct dst_entry *dst) | 158 | static unsigned int ip6_blackhole_mtu(const struct dst_entry *dst) |
| 159 | { | 159 | { |
| 160 | return 0; | 160 | unsigned int mtu = dst_metric_raw(dst, RTAX_MTU); |
| 161 | |||
| 162 | return mtu ? : dst->dev->mtu; | ||
| 161 | } | 163 | } |
| 162 | 164 | ||
| 163 | static void ip6_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) | 165 | static void ip6_rt_blackhole_update_pmtu(struct dst_entry *dst, u32 mtu) |
| @@ -175,7 +177,7 @@ static struct dst_ops ip6_dst_blackhole_ops = { | |||
| 175 | .protocol = cpu_to_be16(ETH_P_IPV6), | 177 | .protocol = cpu_to_be16(ETH_P_IPV6), |
| 176 | .destroy = ip6_dst_destroy, | 178 | .destroy = ip6_dst_destroy, |
| 177 | .check = ip6_dst_check, | 179 | .check = ip6_dst_check, |
| 178 | .default_mtu = ip6_blackhole_default_mtu, | 180 | .mtu = ip6_blackhole_mtu, |
| 179 | .default_advmss = ip6_default_advmss, | 181 | .default_advmss = ip6_default_advmss, |
| 180 | .update_pmtu = ip6_rt_blackhole_update_pmtu, | 182 | .update_pmtu = ip6_rt_blackhole_update_pmtu, |
| 181 | .cow_metrics = ip6_rt_blackhole_cow_metrics, | 183 | .cow_metrics = ip6_rt_blackhole_cow_metrics, |
| @@ -726,7 +728,7 @@ static struct rt6_info *rt6_alloc_cow(const struct rt6_info *ort, | |||
| 726 | int attempts = !in_softirq(); | 728 | int attempts = !in_softirq(); |
| 727 | 729 | ||
| 728 | if (!(rt->rt6i_flags&RTF_GATEWAY)) { | 730 | if (!(rt->rt6i_flags&RTF_GATEWAY)) { |
| 729 | if (rt->rt6i_dst.plen != 128 && | 731 | if (ort->rt6i_dst.plen != 128 && |
| 730 | ipv6_addr_equal(&ort->rt6i_dst.addr, daddr)) | 732 | ipv6_addr_equal(&ort->rt6i_dst.addr, daddr)) |
| 731 | rt->rt6i_flags |= RTF_ANYCAST; | 733 | rt->rt6i_flags |= RTF_ANYCAST; |
| 732 | ipv6_addr_copy(&rt->rt6i_gateway, daddr); | 734 | ipv6_addr_copy(&rt->rt6i_gateway, daddr); |
| @@ -1041,10 +1043,15 @@ static unsigned int ip6_default_advmss(const struct dst_entry *dst) | |||
| 1041 | return mtu; | 1043 | return mtu; |
| 1042 | } | 1044 | } |
| 1043 | 1045 | ||
| 1044 | static unsigned int ip6_default_mtu(const struct dst_entry *dst) | 1046 | static unsigned int ip6_mtu(const struct dst_entry *dst) |
| 1045 | { | 1047 | { |
| 1046 | unsigned int mtu = IPV6_MIN_MTU; | ||
| 1047 | struct inet6_dev *idev; | 1048 | struct inet6_dev *idev; |
| 1049 | unsigned int mtu = dst_metric_raw(dst, RTAX_MTU); | ||
| 1050 | |||
| 1051 | if (mtu) | ||
| 1052 | return mtu; | ||
| 1053 | |||
| 1054 | mtu = IPV6_MIN_MTU; | ||
| 1048 | 1055 | ||
| 1049 | rcu_read_lock(); | 1056 | rcu_read_lock(); |
| 1050 | idev = __in6_dev_get(dst->dev); | 1057 | idev = __in6_dev_get(dst->dev); |
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index a7a18602a046..96f3623618e3 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c | |||
| @@ -263,6 +263,8 @@ static struct ip_tunnel *ipip6_tunnel_locate(struct net *net, | |||
| 263 | if (register_netdevice(dev) < 0) | 263 | if (register_netdevice(dev) < 0) |
| 264 | goto failed_free; | 264 | goto failed_free; |
| 265 | 265 | ||
| 266 | strcpy(nt->parms.name, dev->name); | ||
| 267 | |||
| 266 | dev_hold(dev); | 268 | dev_hold(dev); |
| 267 | 269 | ||
| 268 | ipip6_tunnel_link(sitn, nt); | 270 | ipip6_tunnel_link(sitn, nt); |
| @@ -1144,7 +1146,6 @@ static int ipip6_tunnel_init(struct net_device *dev) | |||
| 1144 | struct ip_tunnel *tunnel = netdev_priv(dev); | 1146 | struct ip_tunnel *tunnel = netdev_priv(dev); |
| 1145 | 1147 | ||
| 1146 | tunnel->dev = dev; | 1148 | tunnel->dev = dev; |
| 1147 | strcpy(tunnel->parms.name, dev->name); | ||
| 1148 | 1149 | ||
| 1149 | memcpy(dev->dev_addr, &tunnel->parms.iph.saddr, 4); | 1150 | memcpy(dev->dev_addr, &tunnel->parms.iph.saddr, 4); |
| 1150 | memcpy(dev->broadcast, &tunnel->parms.iph.daddr, 4); | 1151 | memcpy(dev->broadcast, &tunnel->parms.iph.daddr, 4); |
| @@ -1207,6 +1208,7 @@ static void __net_exit sit_destroy_tunnels(struct sit_net *sitn, struct list_hea | |||
| 1207 | static int __net_init sit_init_net(struct net *net) | 1208 | static int __net_init sit_init_net(struct net *net) |
| 1208 | { | 1209 | { |
| 1209 | struct sit_net *sitn = net_generic(net, sit_net_id); | 1210 | struct sit_net *sitn = net_generic(net, sit_net_id); |
| 1211 | struct ip_tunnel *t; | ||
| 1210 | int err; | 1212 | int err; |
| 1211 | 1213 | ||
| 1212 | sitn->tunnels[0] = sitn->tunnels_wc; | 1214 | sitn->tunnels[0] = sitn->tunnels_wc; |
| @@ -1231,6 +1233,9 @@ static int __net_init sit_init_net(struct net *net) | |||
| 1231 | if ((err = register_netdev(sitn->fb_tunnel_dev))) | 1233 | if ((err = register_netdev(sitn->fb_tunnel_dev))) |
| 1232 | goto err_reg_dev; | 1234 | goto err_reg_dev; |
| 1233 | 1235 | ||
| 1236 | t = netdev_priv(sitn->fb_tunnel_dev); | ||
| 1237 | |||
| 1238 | strcpy(t->parms.name, sitn->fb_tunnel_dev->name); | ||
| 1234 | return 0; | 1239 | return 0; |
| 1235 | 1240 | ||
| 1236 | err_reg_dev: | 1241 | err_reg_dev: |
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 36131d122a6f..2dea4bb7b54a 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c | |||
| @@ -1255,6 +1255,13 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1255 | if (!want_cookie || tmp_opt.tstamp_ok) | 1255 | if (!want_cookie || tmp_opt.tstamp_ok) |
| 1256 | TCP_ECN_create_request(req, tcp_hdr(skb)); | 1256 | TCP_ECN_create_request(req, tcp_hdr(skb)); |
| 1257 | 1257 | ||
| 1258 | treq->iif = sk->sk_bound_dev_if; | ||
| 1259 | |||
| 1260 | /* So that link locals have meaning */ | ||
| 1261 | if (!sk->sk_bound_dev_if && | ||
| 1262 | ipv6_addr_type(&treq->rmt_addr) & IPV6_ADDR_LINKLOCAL) | ||
| 1263 | treq->iif = inet6_iif(skb); | ||
| 1264 | |||
| 1258 | if (!isn) { | 1265 | if (!isn) { |
| 1259 | struct inet_peer *peer = NULL; | 1266 | struct inet_peer *peer = NULL; |
| 1260 | 1267 | ||
| @@ -1264,12 +1271,6 @@ static int tcp_v6_conn_request(struct sock *sk, struct sk_buff *skb) | |||
| 1264 | atomic_inc(&skb->users); | 1271 | atomic_inc(&skb->users); |
| 1265 | treq->pktopts = skb; | 1272 | treq->pktopts = skb; |
| 1266 | } | 1273 | } |
| 1267 | treq->iif = sk->sk_bound_dev_if; | ||
| 1268 | |||
| 1269 | /* So that link locals have meaning */ | ||
| 1270 | if (!sk->sk_bound_dev_if && | ||
| 1271 | ipv6_addr_type(&treq->rmt_addr) & IPV6_ADDR_LINKLOCAL) | ||
| 1272 | treq->iif = inet6_iif(skb); | ||
| 1273 | 1274 | ||
| 1274 | if (want_cookie) { | 1275 | if (want_cookie) { |
| 1275 | isn = cookie_v6_init_sequence(sk, skb, &req->mss); | 1276 | isn = cookie_v6_init_sequence(sk, skb, &req->mss); |
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c index 846f4757eb8d..8c2541915183 100644 --- a/net/ipv6/udp.c +++ b/net/ipv6/udp.c | |||
| @@ -340,7 +340,7 @@ int udpv6_recvmsg(struct kiocb *iocb, struct sock *sk, | |||
| 340 | struct ipv6_pinfo *np = inet6_sk(sk); | 340 | struct ipv6_pinfo *np = inet6_sk(sk); |
| 341 | struct inet_sock *inet = inet_sk(sk); | 341 | struct inet_sock *inet = inet_sk(sk); |
| 342 | struct sk_buff *skb; | 342 | struct sk_buff *skb; |
| 343 | unsigned int ulen; | 343 | unsigned int ulen, copied; |
| 344 | int peeked; | 344 | int peeked; |
| 345 | int err; | 345 | int err; |
| 346 | int is_udplite = IS_UDPLITE(sk); | 346 | int is_udplite = IS_UDPLITE(sk); |
| @@ -363,9 +363,10 @@ try_again: | |||
| 363 | goto out; | 363 | goto out; |
| 364 | 364 | ||
| 365 | ulen = skb->len - sizeof(struct udphdr); | 365 | ulen = skb->len - sizeof(struct udphdr); |
| 366 | if (len > ulen) | 366 | copied = len; |
| 367 | len = ulen; | 367 | if (copied > ulen) |
| 368 | else if (len < ulen) | 368 | copied = ulen; |
| 369 | else if (copied < ulen) | ||
| 369 | msg->msg_flags |= MSG_TRUNC; | 370 | msg->msg_flags |= MSG_TRUNC; |
| 370 | 371 | ||
| 371 | is_udp4 = (skb->protocol == htons(ETH_P_IP)); | 372 | is_udp4 = (skb->protocol == htons(ETH_P_IP)); |
| @@ -376,14 +377,14 @@ try_again: | |||
| 376 | * coverage checksum (UDP-Lite), do it before the copy. | 377 | * coverage checksum (UDP-Lite), do it before the copy. |
| 377 | */ | 378 | */ |
| 378 | 379 | ||
| 379 | if (len < ulen || UDP_SKB_CB(skb)->partial_cov) { | 380 | if (copied < ulen || UDP_SKB_CB(skb)->partial_cov) { |
| 380 | if (udp_lib_checksum_complete(skb)) | 381 | if (udp_lib_checksum_complete(skb)) |
| 381 | goto csum_copy_err; | 382 | goto csum_copy_err; |
| 382 | } | 383 | } |
| 383 | 384 | ||
| 384 | if (skb_csum_unnecessary(skb)) | 385 | if (skb_csum_unnecessary(skb)) |
| 385 | err = skb_copy_datagram_iovec(skb, sizeof(struct udphdr), | 386 | err = skb_copy_datagram_iovec(skb, sizeof(struct udphdr), |
| 386 | msg->msg_iov,len); | 387 | msg->msg_iov, copied ); |
| 387 | else { | 388 | else { |
| 388 | err = skb_copy_and_csum_datagram_iovec(skb, sizeof(struct udphdr), msg->msg_iov); | 389 | err = skb_copy_and_csum_datagram_iovec(skb, sizeof(struct udphdr), msg->msg_iov); |
| 389 | if (err == -EINVAL) | 390 | if (err == -EINVAL) |
| @@ -432,7 +433,7 @@ try_again: | |||
| 432 | datagram_recv_ctl(sk, msg, skb); | 433 | datagram_recv_ctl(sk, msg, skb); |
| 433 | } | 434 | } |
| 434 | 435 | ||
| 435 | err = len; | 436 | err = copied; |
| 436 | if (flags & MSG_TRUNC) | 437 | if (flags & MSG_TRUNC) |
| 437 | err = ulen; | 438 | err = ulen; |
| 438 | 439 | ||
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index cf0f308abf5e..89ff8c67943e 100644 --- a/net/l2tp/l2tp_core.c +++ b/net/l2tp/l2tp_core.c | |||
| @@ -1072,7 +1072,7 @@ int l2tp_xmit_skb(struct l2tp_session *session, struct sk_buff *skb, int hdr_len | |||
| 1072 | 1072 | ||
| 1073 | /* Get routing info from the tunnel socket */ | 1073 | /* Get routing info from the tunnel socket */ |
| 1074 | skb_dst_drop(skb); | 1074 | skb_dst_drop(skb); |
| 1075 | skb_dst_set(skb, dst_clone(__sk_dst_get(sk))); | 1075 | skb_dst_set(skb, dst_clone(__sk_dst_check(sk, 0))); |
| 1076 | 1076 | ||
| 1077 | inet = inet_sk(sk); | 1077 | inet = inet_sk(sk); |
| 1078 | fl = &inet->cork.fl; | 1078 | fl = &inet->cork.fl; |
diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index b3f65520e7a7..2e4b961648d4 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c | |||
| @@ -161,6 +161,12 @@ int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, | |||
| 161 | return -ENOENT; | 161 | return -ENOENT; |
| 162 | } | 162 | } |
| 163 | 163 | ||
| 164 | /* if we're already stopping ignore any new requests to stop */ | ||
| 165 | if (test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) { | ||
| 166 | spin_unlock_bh(&sta->lock); | ||
| 167 | return -EALREADY; | ||
| 168 | } | ||
| 169 | |||
| 164 | if (test_bit(HT_AGG_STATE_WANT_START, &tid_tx->state)) { | 170 | if (test_bit(HT_AGG_STATE_WANT_START, &tid_tx->state)) { |
| 165 | /* not even started yet! */ | 171 | /* not even started yet! */ |
| 166 | ieee80211_assign_tid_tx(sta, tid, NULL); | 172 | ieee80211_assign_tid_tx(sta, tid, NULL); |
| @@ -169,6 +175,8 @@ int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, | |||
| 169 | return 0; | 175 | return 0; |
| 170 | } | 176 | } |
| 171 | 177 | ||
| 178 | set_bit(HT_AGG_STATE_STOPPING, &tid_tx->state); | ||
| 179 | |||
| 172 | spin_unlock_bh(&sta->lock); | 180 | spin_unlock_bh(&sta->lock); |
| 173 | 181 | ||
| 174 | #ifdef CONFIG_MAC80211_HT_DEBUG | 182 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| @@ -176,8 +184,6 @@ int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, | |||
| 176 | sta->sta.addr, tid); | 184 | sta->sta.addr, tid); |
| 177 | #endif /* CONFIG_MAC80211_HT_DEBUG */ | 185 | #endif /* CONFIG_MAC80211_HT_DEBUG */ |
| 178 | 186 | ||
| 179 | set_bit(HT_AGG_STATE_STOPPING, &tid_tx->state); | ||
| 180 | |||
| 181 | del_timer_sync(&tid_tx->addba_resp_timer); | 187 | del_timer_sync(&tid_tx->addba_resp_timer); |
| 182 | 188 | ||
| 183 | /* | 189 | /* |
| @@ -187,6 +193,20 @@ int ___ieee80211_stop_tx_ba_session(struct sta_info *sta, u16 tid, | |||
| 187 | */ | 193 | */ |
| 188 | clear_bit(HT_AGG_STATE_OPERATIONAL, &tid_tx->state); | 194 | clear_bit(HT_AGG_STATE_OPERATIONAL, &tid_tx->state); |
| 189 | 195 | ||
| 196 | /* | ||
| 197 | * There might be a few packets being processed right now (on | ||
| 198 | * another CPU) that have already gotten past the aggregation | ||
| 199 | * check when it was still OPERATIONAL and consequently have | ||
| 200 | * IEEE80211_TX_CTL_AMPDU set. In that case, this code might | ||
| 201 | * call into the driver at the same time or even before the | ||
| 202 | * TX paths calls into it, which could confuse the driver. | ||
| 203 | * | ||
| 204 | * Wait for all currently running TX paths to finish before | ||
| 205 | * telling the driver. New packets will not go through since | ||
| 206 | * the aggregation session is no longer OPERATIONAL. | ||
| 207 | */ | ||
| 208 | synchronize_net(); | ||
| 209 | |||
| 190 | tid_tx->stop_initiator = initiator; | 210 | tid_tx->stop_initiator = initiator; |
| 191 | tid_tx->tx_stop = tx; | 211 | tid_tx->tx_stop = tx; |
| 192 | 212 | ||
| @@ -283,6 +303,38 @@ ieee80211_wake_queue_agg(struct ieee80211_local *local, int tid) | |||
| 283 | __release(agg_queue); | 303 | __release(agg_queue); |
| 284 | } | 304 | } |
| 285 | 305 | ||
| 306 | /* | ||
| 307 | * splice packets from the STA's pending to the local pending, | ||
| 308 | * requires a call to ieee80211_agg_splice_finish later | ||
| 309 | */ | ||
| 310 | static void __acquires(agg_queue) | ||
| 311 | ieee80211_agg_splice_packets(struct ieee80211_local *local, | ||
| 312 | struct tid_ampdu_tx *tid_tx, u16 tid) | ||
| 313 | { | ||
| 314 | int queue = ieee80211_ac_from_tid(tid); | ||
| 315 | unsigned long flags; | ||
| 316 | |||
| 317 | ieee80211_stop_queue_agg(local, tid); | ||
| 318 | |||
| 319 | if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates" | ||
| 320 | " from the pending queue\n", tid)) | ||
| 321 | return; | ||
| 322 | |||
| 323 | if (!skb_queue_empty(&tid_tx->pending)) { | ||
| 324 | spin_lock_irqsave(&local->queue_stop_reason_lock, flags); | ||
| 325 | /* copy over remaining packets */ | ||
| 326 | skb_queue_splice_tail_init(&tid_tx->pending, | ||
| 327 | &local->pending[queue]); | ||
| 328 | spin_unlock_irqrestore(&local->queue_stop_reason_lock, flags); | ||
| 329 | } | ||
| 330 | } | ||
| 331 | |||
| 332 | static void __releases(agg_queue) | ||
| 333 | ieee80211_agg_splice_finish(struct ieee80211_local *local, u16 tid) | ||
| 334 | { | ||
| 335 | ieee80211_wake_queue_agg(local, tid); | ||
| 336 | } | ||
| 337 | |||
| 286 | void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid) | 338 | void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid) |
| 287 | { | 339 | { |
| 288 | struct tid_ampdu_tx *tid_tx; | 340 | struct tid_ampdu_tx *tid_tx; |
| @@ -294,19 +346,17 @@ void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid) | |||
| 294 | tid_tx = rcu_dereference_protected_tid_tx(sta, tid); | 346 | tid_tx = rcu_dereference_protected_tid_tx(sta, tid); |
| 295 | 347 | ||
| 296 | /* | 348 | /* |
| 297 | * While we're asking the driver about the aggregation, | 349 | * Start queuing up packets for this aggregation session. |
| 298 | * stop the AC queue so that we don't have to worry | 350 | * We're going to release them once the driver is OK with |
| 299 | * about frames that came in while we were doing that, | 351 | * that. |
| 300 | * which would require us to put them to the AC pending | ||
| 301 | * afterwards which just makes the code more complex. | ||
| 302 | */ | 352 | */ |
| 303 | ieee80211_stop_queue_agg(local, tid); | ||
| 304 | |||
| 305 | clear_bit(HT_AGG_STATE_WANT_START, &tid_tx->state); | 353 | clear_bit(HT_AGG_STATE_WANT_START, &tid_tx->state); |
| 306 | 354 | ||
| 307 | /* | 355 | /* |
| 308 | * make sure no packets are being processed to get | 356 | * Make sure no packets are being processed. This ensures that |
| 309 | * valid starting sequence number | 357 | * we have a valid starting sequence number and that in-flight |
| 358 | * packets have been flushed out and no packets for this TID | ||
| 359 | * will go into the driver during the ampdu_action call. | ||
| 310 | */ | 360 | */ |
| 311 | synchronize_net(); | 361 | synchronize_net(); |
| 312 | 362 | ||
| @@ -320,17 +370,15 @@ void ieee80211_tx_ba_session_handle_start(struct sta_info *sta, int tid) | |||
| 320 | " tid %d\n", tid); | 370 | " tid %d\n", tid); |
| 321 | #endif | 371 | #endif |
| 322 | spin_lock_bh(&sta->lock); | 372 | spin_lock_bh(&sta->lock); |
| 373 | ieee80211_agg_splice_packets(local, tid_tx, tid); | ||
| 323 | ieee80211_assign_tid_tx(sta, tid, NULL); | 374 | ieee80211_assign_tid_tx(sta, tid, NULL); |
| 375 | ieee80211_agg_splice_finish(local, tid); | ||
| 324 | spin_unlock_bh(&sta->lock); | 376 | spin_unlock_bh(&sta->lock); |
| 325 | 377 | ||
| 326 | ieee80211_wake_queue_agg(local, tid); | ||
| 327 | kfree_rcu(tid_tx, rcu_head); | 378 | kfree_rcu(tid_tx, rcu_head); |
| 328 | return; | 379 | return; |
| 329 | } | 380 | } |
| 330 | 381 | ||
| 331 | /* we can take packets again now */ | ||
| 332 | ieee80211_wake_queue_agg(local, tid); | ||
| 333 | |||
| 334 | /* activate the timer for the recipient's addBA response */ | 382 | /* activate the timer for the recipient's addBA response */ |
| 335 | mod_timer(&tid_tx->addba_resp_timer, jiffies + ADDBA_RESP_INTERVAL); | 383 | mod_timer(&tid_tx->addba_resp_timer, jiffies + ADDBA_RESP_INTERVAL); |
| 336 | #ifdef CONFIG_MAC80211_HT_DEBUG | 384 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| @@ -446,38 +494,6 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, | |||
| 446 | } | 494 | } |
| 447 | EXPORT_SYMBOL(ieee80211_start_tx_ba_session); | 495 | EXPORT_SYMBOL(ieee80211_start_tx_ba_session); |
| 448 | 496 | ||
| 449 | /* | ||
| 450 | * splice packets from the STA's pending to the local pending, | ||
| 451 | * requires a call to ieee80211_agg_splice_finish later | ||
| 452 | */ | ||
| 453 | static void __acquires(agg_queue) | ||
| 454 | ieee80211_agg_splice_packets(struct ieee80211_local *local, | ||
| 455 | struct tid_ampdu_tx *tid_tx, u16 tid) | ||
| 456 | { | ||
| 457 | int queue = ieee80211_ac_from_tid(tid); | ||
| 458 | unsigned long flags; | ||
| 459 | |||
| 460 | ieee80211_stop_queue_agg(local, tid); | ||
| 461 | |||
| 462 | if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates" | ||
| 463 | " from the pending queue\n", tid)) | ||
| 464 | return; | ||
| 465 | |||
| 466 | if (!skb_queue_empty(&tid_tx->pending)) { | ||
| 467 | spin_lock_irqsave(&local->queue_stop_reason_lock, flags); | ||
| 468 | /* copy over remaining packets */ | ||
| 469 | skb_queue_splice_tail_init(&tid_tx->pending, | ||
| 470 | &local->pending[queue]); | ||
| 471 | spin_unlock_irqrestore(&local->queue_stop_reason_lock, flags); | ||
| 472 | } | ||
| 473 | } | ||
| 474 | |||
| 475 | static void __releases(agg_queue) | ||
| 476 | ieee80211_agg_splice_finish(struct ieee80211_local *local, u16 tid) | ||
| 477 | { | ||
| 478 | ieee80211_wake_queue_agg(local, tid); | ||
| 479 | } | ||
| 480 | |||
| 481 | static void ieee80211_agg_tx_operational(struct ieee80211_local *local, | 497 | static void ieee80211_agg_tx_operational(struct ieee80211_local *local, |
| 482 | struct sta_info *sta, u16 tid) | 498 | struct sta_info *sta, u16 tid) |
| 483 | { | 499 | { |
| @@ -757,11 +773,27 @@ void ieee80211_process_addba_resp(struct ieee80211_local *local, | |||
| 757 | goto out; | 773 | goto out; |
| 758 | } | 774 | } |
| 759 | 775 | ||
| 760 | del_timer(&tid_tx->addba_resp_timer); | 776 | del_timer_sync(&tid_tx->addba_resp_timer); |
| 761 | 777 | ||
| 762 | #ifdef CONFIG_MAC80211_HT_DEBUG | 778 | #ifdef CONFIG_MAC80211_HT_DEBUG |
| 763 | printk(KERN_DEBUG "switched off addBA timer for tid %d\n", tid); | 779 | printk(KERN_DEBUG "switched off addBA timer for tid %d\n", tid); |
| 764 | #endif | 780 | #endif |
| 781 | |||
| 782 | /* | ||
| 783 | * addba_resp_timer may have fired before we got here, and | ||
| 784 | * caused WANT_STOP to be set. If the stop then was already | ||
| 785 | * processed further, STOPPING might be set. | ||
| 786 | */ | ||
| 787 | if (test_bit(HT_AGG_STATE_WANT_STOP, &tid_tx->state) || | ||
| 788 | test_bit(HT_AGG_STATE_STOPPING, &tid_tx->state)) { | ||
| 789 | #ifdef CONFIG_MAC80211_HT_DEBUG | ||
| 790 | printk(KERN_DEBUG | ||
| 791 | "got addBA resp for tid %d but we already gave up\n", | ||
| 792 | tid); | ||
| 793 | #endif | ||
| 794 | goto out; | ||
| 795 | } | ||
| 796 | |||
| 765 | /* | 797 | /* |
| 766 | * IEEE 802.11-2007 7.3.1.14: | 798 | * IEEE 802.11-2007 7.3.1.14: |
| 767 | * In an ADDBA Response frame, when the Status Code field | 799 | * In an ADDBA Response frame, when the Status Code field |
diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c index c5f341798c16..3110cbdc501b 100644 --- a/net/mac80211/debugfs_sta.c +++ b/net/mac80211/debugfs_sta.c | |||
| @@ -274,9 +274,9 @@ static ssize_t sta_ht_capa_read(struct file *file, char __user *userbuf, | |||
| 274 | 274 | ||
| 275 | PRINT_HT_CAP((htc->cap & BIT(10)), "HT Delayed Block Ack"); | 275 | PRINT_HT_CAP((htc->cap & BIT(10)), "HT Delayed Block Ack"); |
| 276 | 276 | ||
| 277 | PRINT_HT_CAP((htc->cap & BIT(11)), "Max AMSDU length: " | ||
| 278 | "3839 bytes"); | ||
| 279 | PRINT_HT_CAP(!(htc->cap & BIT(11)), "Max AMSDU length: " | 277 | PRINT_HT_CAP(!(htc->cap & BIT(11)), "Max AMSDU length: " |
| 278 | "3839 bytes"); | ||
| 279 | PRINT_HT_CAP((htc->cap & BIT(11)), "Max AMSDU length: " | ||
| 280 | "7935 bytes"); | 280 | "7935 bytes"); |
| 281 | 281 | ||
| 282 | /* | 282 | /* |
diff --git a/net/mac80211/main.c b/net/mac80211/main.c index d999bf3b84e1..cae443563ec9 100644 --- a/net/mac80211/main.c +++ b/net/mac80211/main.c | |||
| @@ -757,6 +757,12 @@ int ieee80211_register_hw(struct ieee80211_hw *hw) | |||
| 757 | if (!local->int_scan_req) | 757 | if (!local->int_scan_req) |
| 758 | return -ENOMEM; | 758 | return -ENOMEM; |
| 759 | 759 | ||
| 760 | for (band = 0; band < IEEE80211_NUM_BANDS; band++) { | ||
| 761 | if (!local->hw.wiphy->bands[band]) | ||
| 762 | continue; | ||
| 763 | local->int_scan_req->rates[band] = (u32) -1; | ||
| 764 | } | ||
| 765 | |||
| 760 | /* if low-level driver supports AP, we also support VLAN */ | 766 | /* if low-level driver supports AP, we also support VLAN */ |
| 761 | if (local->hw.wiphy->interface_modes & BIT(NL80211_IFTYPE_AP)) { | 767 | if (local->hw.wiphy->interface_modes & BIT(NL80211_IFTYPE_AP)) { |
| 762 | hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN); | 768 | hw->wiphy->interface_modes |= BIT(NL80211_IFTYPE_AP_VLAN); |
diff --git a/net/mac80211/status.c b/net/mac80211/status.c index 80de436eae20..16518f386117 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c | |||
| @@ -260,7 +260,7 @@ static void ieee80211_add_tx_radiotap_header(struct ieee80211_supported_band | |||
| 260 | struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data; | 260 | struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data; |
| 261 | struct ieee80211_radiotap_header *rthdr; | 261 | struct ieee80211_radiotap_header *rthdr; |
| 262 | unsigned char *pos; | 262 | unsigned char *pos; |
| 263 | __le16 txflags; | 263 | u16 txflags; |
| 264 | 264 | ||
| 265 | rthdr = (struct ieee80211_radiotap_header *) skb_push(skb, rtap_len); | 265 | rthdr = (struct ieee80211_radiotap_header *) skb_push(skb, rtap_len); |
| 266 | 266 | ||
| @@ -290,13 +290,13 @@ static void ieee80211_add_tx_radiotap_header(struct ieee80211_supported_band | |||
| 290 | txflags = 0; | 290 | txflags = 0; |
| 291 | if (!(info->flags & IEEE80211_TX_STAT_ACK) && | 291 | if (!(info->flags & IEEE80211_TX_STAT_ACK) && |
| 292 | !is_multicast_ether_addr(hdr->addr1)) | 292 | !is_multicast_ether_addr(hdr->addr1)) |
| 293 | txflags |= cpu_to_le16(IEEE80211_RADIOTAP_F_TX_FAIL); | 293 | txflags |= IEEE80211_RADIOTAP_F_TX_FAIL; |
| 294 | 294 | ||
| 295 | if ((info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS) || | 295 | if ((info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS) || |
| 296 | (info->status.rates[0].flags & IEEE80211_TX_RC_USE_CTS_PROTECT)) | 296 | (info->status.rates[0].flags & IEEE80211_TX_RC_USE_CTS_PROTECT)) |
| 297 | txflags |= cpu_to_le16(IEEE80211_RADIOTAP_F_TX_CTS); | 297 | txflags |= IEEE80211_RADIOTAP_F_TX_CTS; |
| 298 | else if (info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS) | 298 | else if (info->status.rates[0].flags & IEEE80211_TX_RC_USE_RTS_CTS) |
| 299 | txflags |= cpu_to_le16(IEEE80211_RADIOTAP_F_TX_RTS); | 299 | txflags |= IEEE80211_RADIOTAP_F_TX_RTS; |
| 300 | 300 | ||
| 301 | put_unaligned_le16(txflags, pos); | 301 | put_unaligned_le16(txflags, pos); |
| 302 | pos += 2; | 302 | pos += 2; |
diff --git a/net/mac80211/util.c b/net/mac80211/util.c index eca0fad09709..d5230ecc784d 100644 --- a/net/mac80211/util.c +++ b/net/mac80211/util.c | |||
| @@ -1039,7 +1039,6 @@ int ieee80211_reconfig(struct ieee80211_local *local) | |||
| 1039 | struct ieee80211_sub_if_data, | 1039 | struct ieee80211_sub_if_data, |
| 1040 | u.ap); | 1040 | u.ap); |
| 1041 | 1041 | ||
| 1042 | memset(&sta->sta.drv_priv, 0, hw->sta_data_size); | ||
| 1043 | WARN_ON(drv_sta_add(local, sdata, &sta->sta)); | 1042 | WARN_ON(drv_sta_add(local, sdata, &sta->sta)); |
| 1044 | } | 1043 | } |
| 1045 | } | 1044 | } |
diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 8260b13d93c9..d5597b759ba3 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig | |||
| @@ -201,7 +201,6 @@ config NF_CONNTRACK_BROADCAST | |||
| 201 | 201 | ||
| 202 | config NF_CONNTRACK_NETBIOS_NS | 202 | config NF_CONNTRACK_NETBIOS_NS |
| 203 | tristate "NetBIOS name service protocol support" | 203 | tristate "NetBIOS name service protocol support" |
| 204 | depends on NETFILTER_ADVANCED | ||
| 205 | select NF_CONNTRACK_BROADCAST | 204 | select NF_CONNTRACK_BROADCAST |
| 206 | help | 205 | help |
| 207 | NetBIOS name service requests are sent as broadcast messages from an | 206 | NetBIOS name service requests are sent as broadcast messages from an |
| @@ -542,7 +541,6 @@ config NETFILTER_XT_TARGET_NOTRACK | |||
| 542 | tristate '"NOTRACK" target support' | 541 | tristate '"NOTRACK" target support' |
| 543 | depends on IP_NF_RAW || IP6_NF_RAW | 542 | depends on IP_NF_RAW || IP6_NF_RAW |
| 544 | depends on NF_CONNTRACK | 543 | depends on NF_CONNTRACK |
| 545 | depends on NETFILTER_ADVANCED | ||
| 546 | help | 544 | help |
| 547 | The NOTRACK target allows a select rule to specify | 545 | The NOTRACK target allows a select rule to specify |
| 548 | which packets *not* to enter the conntrack/NAT | 546 | which packets *not* to enter the conntrack/NAT |
diff --git a/net/netfilter/ipset/ip_set_hash_ipport.c b/net/netfilter/ipset/ip_set_hash_ipport.c index 6ee10f5d59bd..37d667e3f6f8 100644 --- a/net/netfilter/ipset/ip_set_hash_ipport.c +++ b/net/netfilter/ipset/ip_set_hash_ipport.c | |||
| @@ -158,7 +158,7 @@ hash_ipport4_uadt(struct ip_set *set, struct nlattr *tb[], | |||
| 158 | const struct ip_set_hash *h = set->data; | 158 | const struct ip_set_hash *h = set->data; |
| 159 | ipset_adtfn adtfn = set->variant->adt[adt]; | 159 | ipset_adtfn adtfn = set->variant->adt[adt]; |
| 160 | struct hash_ipport4_elem data = { }; | 160 | struct hash_ipport4_elem data = { }; |
| 161 | u32 ip, ip_to, p = 0, port, port_to; | 161 | u32 ip, ip_to = 0, p = 0, port, port_to; |
| 162 | u32 timeout = h->timeout; | 162 | u32 timeout = h->timeout; |
| 163 | bool with_ports = false; | 163 | bool with_ports = false; |
| 164 | int ret; | 164 | int ret; |
diff --git a/net/netfilter/ipset/ip_set_hash_ipportip.c b/net/netfilter/ipset/ip_set_hash_ipportip.c index fb90e344e907..e69e2718fbe1 100644 --- a/net/netfilter/ipset/ip_set_hash_ipportip.c +++ b/net/netfilter/ipset/ip_set_hash_ipportip.c | |||
| @@ -162,7 +162,7 @@ hash_ipportip4_uadt(struct ip_set *set, struct nlattr *tb[], | |||
| 162 | const struct ip_set_hash *h = set->data; | 162 | const struct ip_set_hash *h = set->data; |
| 163 | ipset_adtfn adtfn = set->variant->adt[adt]; | 163 | ipset_adtfn adtfn = set->variant->adt[adt]; |
| 164 | struct hash_ipportip4_elem data = { }; | 164 | struct hash_ipportip4_elem data = { }; |
| 165 | u32 ip, ip_to, p = 0, port, port_to; | 165 | u32 ip, ip_to = 0, p = 0, port, port_to; |
| 166 | u32 timeout = h->timeout; | 166 | u32 timeout = h->timeout; |
| 167 | bool with_ports = false; | 167 | bool with_ports = false; |
| 168 | int ret; | 168 | int ret; |
diff --git a/net/netfilter/ipset/ip_set_hash_ipportnet.c b/net/netfilter/ipset/ip_set_hash_ipportnet.c index deb3e3dfa5fc..64199b4e93c9 100644 --- a/net/netfilter/ipset/ip_set_hash_ipportnet.c +++ b/net/netfilter/ipset/ip_set_hash_ipportnet.c | |||
| @@ -184,7 +184,7 @@ hash_ipportnet4_uadt(struct ip_set *set, struct nlattr *tb[], | |||
| 184 | const struct ip_set_hash *h = set->data; | 184 | const struct ip_set_hash *h = set->data; |
| 185 | ipset_adtfn adtfn = set->variant->adt[adt]; | 185 | ipset_adtfn adtfn = set->variant->adt[adt]; |
| 186 | struct hash_ipportnet4_elem data = { .cidr = HOST_MASK }; | 186 | struct hash_ipportnet4_elem data = { .cidr = HOST_MASK }; |
| 187 | u32 ip, ip_to, p = 0, port, port_to; | 187 | u32 ip, ip_to = 0, p = 0, port, port_to; |
| 188 | u32 ip2_from = 0, ip2_to, ip2_last, ip2; | 188 | u32 ip2_from = 0, ip2_to, ip2_last, ip2; |
| 189 | u32 timeout = h->timeout; | 189 | u32 timeout = h->timeout; |
| 190 | bool with_ports = false; | 190 | bool with_ports = false; |
diff --git a/net/netfilter/nf_conntrack_ecache.c b/net/netfilter/nf_conntrack_ecache.c index 6b368be937c6..b62c4148b921 100644 --- a/net/netfilter/nf_conntrack_ecache.c +++ b/net/netfilter/nf_conntrack_ecache.c | |||
| @@ -27,22 +27,17 @@ | |||
| 27 | 27 | ||
| 28 | static DEFINE_MUTEX(nf_ct_ecache_mutex); | 28 | static DEFINE_MUTEX(nf_ct_ecache_mutex); |
| 29 | 29 | ||
| 30 | struct nf_ct_event_notifier __rcu *nf_conntrack_event_cb __read_mostly; | ||
| 31 | EXPORT_SYMBOL_GPL(nf_conntrack_event_cb); | ||
| 32 | |||
| 33 | struct nf_exp_event_notifier __rcu *nf_expect_event_cb __read_mostly; | ||
| 34 | EXPORT_SYMBOL_GPL(nf_expect_event_cb); | ||
| 35 | |||
| 36 | /* deliver cached events and clear cache entry - must be called with locally | 30 | /* deliver cached events and clear cache entry - must be called with locally |
| 37 | * disabled softirqs */ | 31 | * disabled softirqs */ |
| 38 | void nf_ct_deliver_cached_events(struct nf_conn *ct) | 32 | void nf_ct_deliver_cached_events(struct nf_conn *ct) |
| 39 | { | 33 | { |
| 34 | struct net *net = nf_ct_net(ct); | ||
| 40 | unsigned long events; | 35 | unsigned long events; |
| 41 | struct nf_ct_event_notifier *notify; | 36 | struct nf_ct_event_notifier *notify; |
| 42 | struct nf_conntrack_ecache *e; | 37 | struct nf_conntrack_ecache *e; |
| 43 | 38 | ||
| 44 | rcu_read_lock(); | 39 | rcu_read_lock(); |
| 45 | notify = rcu_dereference(nf_conntrack_event_cb); | 40 | notify = rcu_dereference(net->ct.nf_conntrack_event_cb); |
| 46 | if (notify == NULL) | 41 | if (notify == NULL) |
| 47 | goto out_unlock; | 42 | goto out_unlock; |
| 48 | 43 | ||
| @@ -83,19 +78,20 @@ out_unlock: | |||
| 83 | } | 78 | } |
| 84 | EXPORT_SYMBOL_GPL(nf_ct_deliver_cached_events); | 79 | EXPORT_SYMBOL_GPL(nf_ct_deliver_cached_events); |
| 85 | 80 | ||
| 86 | int nf_conntrack_register_notifier(struct nf_ct_event_notifier *new) | 81 | int nf_conntrack_register_notifier(struct net *net, |
| 82 | struct nf_ct_event_notifier *new) | ||
| 87 | { | 83 | { |
| 88 | int ret = 0; | 84 | int ret = 0; |
| 89 | struct nf_ct_event_notifier *notify; | 85 | struct nf_ct_event_notifier *notify; |
| 90 | 86 | ||
| 91 | mutex_lock(&nf_ct_ecache_mutex); | 87 | mutex_lock(&nf_ct_ecache_mutex); |
| 92 | notify = rcu_dereference_protected(nf_conntrack_event_cb, | 88 | notify = rcu_dereference_protected(net->ct.nf_conntrack_event_cb, |
| 93 | lockdep_is_held(&nf_ct_ecache_mutex)); | 89 | lockdep_is_held(&nf_ct_ecache_mutex)); |
| 94 | if (notify != NULL) { | 90 | if (notify != NULL) { |
| 95 | ret = -EBUSY; | 91 | ret = -EBUSY; |
| 96 | goto out_unlock; | 92 | goto out_unlock; |
| 97 | } | 93 | } |
| 98 | RCU_INIT_POINTER(nf_conntrack_event_cb, new); | 94 | RCU_INIT_POINTER(net->ct.nf_conntrack_event_cb, new); |
| 99 | mutex_unlock(&nf_ct_ecache_mutex); | 95 | mutex_unlock(&nf_ct_ecache_mutex); |
| 100 | return ret; | 96 | return ret; |
| 101 | 97 | ||
| @@ -105,32 +101,34 @@ out_unlock: | |||
| 105 | } | 101 | } |
| 106 | EXPORT_SYMBOL_GPL(nf_conntrack_register_notifier); | 102 | EXPORT_SYMBOL_GPL(nf_conntrack_register_notifier); |
| 107 | 103 | ||
| 108 | void nf_conntrack_unregister_notifier(struct nf_ct_event_notifier *new) | 104 | void nf_conntrack_unregister_notifier(struct net *net, |
| 105 | struct nf_ct_event_notifier *new) | ||
| 109 | { | 106 | { |
| 110 | struct nf_ct_event_notifier *notify; | 107 | struct nf_ct_event_notifier *notify; |
| 111 | 108 | ||
| 112 | mutex_lock(&nf_ct_ecache_mutex); | 109 | mutex_lock(&nf_ct_ecache_mutex); |
| 113 | notify = rcu_dereference_protected(nf_conntrack_event_cb, | 110 | notify = rcu_dereference_protected(net->ct.nf_conntrack_event_cb, |
| 114 | lockdep_is_held(&nf_ct_ecache_mutex)); | 111 | lockdep_is_held(&nf_ct_ecache_mutex)); |
| 115 | BUG_ON(notify != new); | 112 | BUG_ON(notify != new); |
| 116 | RCU_INIT_POINTER(nf_conntrack_event_cb, NULL); | 113 | RCU_INIT_POINTER(net->ct.nf_conntrack_event_cb, NULL); |
| 117 | mutex_unlock(&nf_ct_ecache_mutex); | 114 | mutex_unlock(&nf_ct_ecache_mutex); |
| 118 | } | 115 | } |
| 119 | EXPORT_SYMBOL_GPL(nf_conntrack_unregister_notifier); | 116 | EXPORT_SYMBOL_GPL(nf_conntrack_unregister_notifier); |
| 120 | 117 | ||
| 121 | int nf_ct_expect_register_notifier(struct nf_exp_event_notifier *new) | 118 | int nf_ct_expect_register_notifier(struct net *net, |
| 119 | struct nf_exp_event_notifier *new) | ||
| 122 | { | 120 | { |
| 123 | int ret = 0; | 121 | int ret = 0; |
| 124 | struct nf_exp_event_notifier *notify; | 122 | struct nf_exp_event_notifier *notify; |
| 125 | 123 | ||
| 126 | mutex_lock(&nf_ct_ecache_mutex); | 124 | mutex_lock(&nf_ct_ecache_mutex); |
| 127 | notify = rcu_dereference_protected(nf_expect_event_cb, | 125 | notify = rcu_dereference_protected(net->ct.nf_expect_event_cb, |
| 128 | lockdep_is_held(&nf_ct_ecache_mutex)); | 126 | lockdep_is_held(&nf_ct_ecache_mutex)); |
| 129 | if (notify != NULL) { | 127 | if (notify != NULL) { |
| 130 | ret = -EBUSY; | 128 | ret = -EBUSY; |
| 131 | goto out_unlock; | 129 | goto out_unlock; |
| 132 | } | 130 | } |
| 133 | RCU_INIT_POINTER(nf_expect_event_cb, new); | 131 | RCU_INIT_POINTER(net->ct.nf_expect_event_cb, new); |
| 134 | mutex_unlock(&nf_ct_ecache_mutex); | 132 | mutex_unlock(&nf_ct_ecache_mutex); |
| 135 | return ret; | 133 | return ret; |
| 136 | 134 | ||
| @@ -140,15 +138,16 @@ out_unlock: | |||
| 140 | } | 138 | } |
| 141 | EXPORT_SYMBOL_GPL(nf_ct_expect_register_notifier); | 139 | EXPORT_SYMBOL_GPL(nf_ct_expect_register_notifier); |
| 142 | 140 | ||
| 143 | void nf_ct_expect_unregister_notifier(struct nf_exp_event_notifier *new) | 141 | void nf_ct_expect_unregister_notifier(struct net *net, |
| 142 | struct nf_exp_event_notifier *new) | ||
| 144 | { | 143 | { |
| 145 | struct nf_exp_event_notifier *notify; | 144 | struct nf_exp_event_notifier *notify; |
| 146 | 145 | ||
| 147 | mutex_lock(&nf_ct_ecache_mutex); | 146 | mutex_lock(&nf_ct_ecache_mutex); |
| 148 | notify = rcu_dereference_protected(nf_expect_event_cb, | 147 | notify = rcu_dereference_protected(net->ct.nf_expect_event_cb, |
| 149 | lockdep_is_held(&nf_ct_ecache_mutex)); | 148 | lockdep_is_held(&nf_ct_ecache_mutex)); |
| 150 | BUG_ON(notify != new); | 149 | BUG_ON(notify != new); |
| 151 | RCU_INIT_POINTER(nf_expect_event_cb, NULL); | 150 | RCU_INIT_POINTER(net->ct.nf_expect_event_cb, NULL); |
| 152 | mutex_unlock(&nf_ct_ecache_mutex); | 151 | mutex_unlock(&nf_ct_ecache_mutex); |
| 153 | } | 152 | } |
| 154 | EXPORT_SYMBOL_GPL(nf_ct_expect_unregister_notifier); | 153 | EXPORT_SYMBOL_GPL(nf_ct_expect_unregister_notifier); |
diff --git a/net/netfilter/nf_conntrack_netlink.c b/net/netfilter/nf_conntrack_netlink.c index e58aa9b1fe8a..ef21b221f036 100644 --- a/net/netfilter/nf_conntrack_netlink.c +++ b/net/netfilter/nf_conntrack_netlink.c | |||
| @@ -4,7 +4,7 @@ | |||
| 4 | * (C) 2001 by Jay Schulist <jschlst@samba.org> | 4 | * (C) 2001 by Jay Schulist <jschlst@samba.org> |
| 5 | * (C) 2002-2006 by Harald Welte <laforge@gnumonks.org> | 5 | * (C) 2002-2006 by Harald Welte <laforge@gnumonks.org> |
| 6 | * (C) 2003 by Patrick Mchardy <kaber@trash.net> | 6 | * (C) 2003 by Patrick Mchardy <kaber@trash.net> |
| 7 | * (C) 2005-2008 by Pablo Neira Ayuso <pablo@netfilter.org> | 7 | * (C) 2005-2011 by Pablo Neira Ayuso <pablo@netfilter.org> |
| 8 | * | 8 | * |
| 9 | * Initial connection tracking via netlink development funded and | 9 | * Initial connection tracking via netlink development funded and |
| 10 | * generally made possible by Network Robots, Inc. (www.networkrobots.com) | 10 | * generally made possible by Network Robots, Inc. (www.networkrobots.com) |
| @@ -2163,6 +2163,54 @@ MODULE_ALIAS("ip_conntrack_netlink"); | |||
| 2163 | MODULE_ALIAS_NFNL_SUBSYS(NFNL_SUBSYS_CTNETLINK); | 2163 | MODULE_ALIAS_NFNL_SUBSYS(NFNL_SUBSYS_CTNETLINK); |
| 2164 | MODULE_ALIAS_NFNL_SUBSYS(NFNL_SUBSYS_CTNETLINK_EXP); | 2164 | MODULE_ALIAS_NFNL_SUBSYS(NFNL_SUBSYS_CTNETLINK_EXP); |
| 2165 | 2165 | ||
| 2166 | static int __net_init ctnetlink_net_init(struct net *net) | ||
| 2167 | { | ||
| 2168 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | ||
| 2169 | int ret; | ||
| 2170 | |||
| 2171 | ret = nf_conntrack_register_notifier(net, &ctnl_notifier); | ||
| 2172 | if (ret < 0) { | ||
| 2173 | pr_err("ctnetlink_init: cannot register notifier.\n"); | ||
| 2174 | goto err_out; | ||
| 2175 | } | ||
| 2176 | |||
| 2177 | ret = nf_ct_expect_register_notifier(net, &ctnl_notifier_exp); | ||
| 2178 | if (ret < 0) { | ||
| 2179 | pr_err("ctnetlink_init: cannot expect register notifier.\n"); | ||
| 2180 | goto err_unreg_notifier; | ||
| 2181 | } | ||
| 2182 | #endif | ||
| 2183 | return 0; | ||
| 2184 | |||
| 2185 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | ||
| 2186 | err_unreg_notifier: | ||
| 2187 | nf_conntrack_unregister_notifier(net, &ctnl_notifier); | ||
| 2188 | err_out: | ||
| 2189 | return ret; | ||
| 2190 | #endif | ||
| 2191 | } | ||
| 2192 | |||
| 2193 | static void ctnetlink_net_exit(struct net *net) | ||
| 2194 | { | ||
| 2195 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | ||
| 2196 | nf_ct_expect_unregister_notifier(net, &ctnl_notifier_exp); | ||
| 2197 | nf_conntrack_unregister_notifier(net, &ctnl_notifier); | ||
| 2198 | #endif | ||
| 2199 | } | ||
| 2200 | |||
| 2201 | static void __net_exit ctnetlink_net_exit_batch(struct list_head *net_exit_list) | ||
| 2202 | { | ||
| 2203 | struct net *net; | ||
| 2204 | |||
| 2205 | list_for_each_entry(net, net_exit_list, exit_list) | ||
| 2206 | ctnetlink_net_exit(net); | ||
| 2207 | } | ||
| 2208 | |||
| 2209 | static struct pernet_operations ctnetlink_net_ops = { | ||
| 2210 | .init = ctnetlink_net_init, | ||
| 2211 | .exit_batch = ctnetlink_net_exit_batch, | ||
| 2212 | }; | ||
| 2213 | |||
| 2166 | static int __init ctnetlink_init(void) | 2214 | static int __init ctnetlink_init(void) |
| 2167 | { | 2215 | { |
| 2168 | int ret; | 2216 | int ret; |
| @@ -2180,28 +2228,15 @@ static int __init ctnetlink_init(void) | |||
| 2180 | goto err_unreg_subsys; | 2228 | goto err_unreg_subsys; |
| 2181 | } | 2229 | } |
| 2182 | 2230 | ||
| 2183 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | 2231 | if (register_pernet_subsys(&ctnetlink_net_ops)) { |
| 2184 | ret = nf_conntrack_register_notifier(&ctnl_notifier); | 2232 | pr_err("ctnetlink_init: cannot register pernet operations\n"); |
| 2185 | if (ret < 0) { | ||
| 2186 | pr_err("ctnetlink_init: cannot register notifier.\n"); | ||
| 2187 | goto err_unreg_exp_subsys; | 2233 | goto err_unreg_exp_subsys; |
| 2188 | } | 2234 | } |
| 2189 | 2235 | ||
| 2190 | ret = nf_ct_expect_register_notifier(&ctnl_notifier_exp); | ||
| 2191 | if (ret < 0) { | ||
| 2192 | pr_err("ctnetlink_init: cannot expect register notifier.\n"); | ||
| 2193 | goto err_unreg_notifier; | ||
| 2194 | } | ||
| 2195 | #endif | ||
| 2196 | |||
| 2197 | return 0; | 2236 | return 0; |
| 2198 | 2237 | ||
| 2199 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | ||
| 2200 | err_unreg_notifier: | ||
| 2201 | nf_conntrack_unregister_notifier(&ctnl_notifier); | ||
| 2202 | err_unreg_exp_subsys: | 2238 | err_unreg_exp_subsys: |
| 2203 | nfnetlink_subsys_unregister(&ctnl_exp_subsys); | 2239 | nfnetlink_subsys_unregister(&ctnl_exp_subsys); |
| 2204 | #endif | ||
| 2205 | err_unreg_subsys: | 2240 | err_unreg_subsys: |
| 2206 | nfnetlink_subsys_unregister(&ctnl_subsys); | 2241 | nfnetlink_subsys_unregister(&ctnl_subsys); |
| 2207 | err_out: | 2242 | err_out: |
| @@ -2213,11 +2248,7 @@ static void __exit ctnetlink_exit(void) | |||
| 2213 | pr_info("ctnetlink: unregistering from nfnetlink.\n"); | 2248 | pr_info("ctnetlink: unregistering from nfnetlink.\n"); |
| 2214 | 2249 | ||
| 2215 | nf_ct_remove_userspace_expectations(); | 2250 | nf_ct_remove_userspace_expectations(); |
| 2216 | #ifdef CONFIG_NF_CONNTRACK_EVENTS | 2251 | unregister_pernet_subsys(&ctnetlink_net_ops); |
| 2217 | nf_ct_expect_unregister_notifier(&ctnl_notifier_exp); | ||
| 2218 | nf_conntrack_unregister_notifier(&ctnl_notifier); | ||
| 2219 | #endif | ||
| 2220 | |||
| 2221 | nfnetlink_subsys_unregister(&ctnl_exp_subsys); | 2252 | nfnetlink_subsys_unregister(&ctnl_exp_subsys); |
| 2222 | nfnetlink_subsys_unregister(&ctnl_subsys); | 2253 | nfnetlink_subsys_unregister(&ctnl_subsys); |
| 2223 | } | 2254 | } |
diff --git a/net/netlabel/netlabel_kapi.c b/net/netlabel/netlabel_kapi.c index 9c24de10a657..824f184f7a9b 100644 --- a/net/netlabel/netlabel_kapi.c +++ b/net/netlabel/netlabel_kapi.c | |||
| @@ -111,8 +111,6 @@ int netlbl_cfg_unlbl_map_add(const char *domain, | |||
| 111 | struct netlbl_domaddr_map *addrmap = NULL; | 111 | struct netlbl_domaddr_map *addrmap = NULL; |
| 112 | struct netlbl_domaddr4_map *map4 = NULL; | 112 | struct netlbl_domaddr4_map *map4 = NULL; |
| 113 | struct netlbl_domaddr6_map *map6 = NULL; | 113 | struct netlbl_domaddr6_map *map6 = NULL; |
| 114 | const struct in_addr *addr4, *mask4; | ||
| 115 | const struct in6_addr *addr6, *mask6; | ||
| 116 | 114 | ||
| 117 | entry = kzalloc(sizeof(*entry), GFP_ATOMIC); | 115 | entry = kzalloc(sizeof(*entry), GFP_ATOMIC); |
| 118 | if (entry == NULL) | 116 | if (entry == NULL) |
| @@ -133,9 +131,9 @@ int netlbl_cfg_unlbl_map_add(const char *domain, | |||
| 133 | INIT_LIST_HEAD(&addrmap->list6); | 131 | INIT_LIST_HEAD(&addrmap->list6); |
| 134 | 132 | ||
| 135 | switch (family) { | 133 | switch (family) { |
| 136 | case AF_INET: | 134 | case AF_INET: { |
| 137 | addr4 = addr; | 135 | const struct in_addr *addr4 = addr; |
| 138 | mask4 = mask; | 136 | const struct in_addr *mask4 = mask; |
| 139 | map4 = kzalloc(sizeof(*map4), GFP_ATOMIC); | 137 | map4 = kzalloc(sizeof(*map4), GFP_ATOMIC); |
| 140 | if (map4 == NULL) | 138 | if (map4 == NULL) |
| 141 | goto cfg_unlbl_map_add_failure; | 139 | goto cfg_unlbl_map_add_failure; |
| @@ -148,9 +146,11 @@ int netlbl_cfg_unlbl_map_add(const char *domain, | |||
| 148 | if (ret_val != 0) | 146 | if (ret_val != 0) |
| 149 | goto cfg_unlbl_map_add_failure; | 147 | goto cfg_unlbl_map_add_failure; |
| 150 | break; | 148 | break; |
| 151 | case AF_INET6: | 149 | } |
| 152 | addr6 = addr; | 150 | #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) |
| 153 | mask6 = mask; | 151 | case AF_INET6: { |
| 152 | const struct in6_addr *addr6 = addr; | ||
| 153 | const struct in6_addr *mask6 = mask; | ||
| 154 | map6 = kzalloc(sizeof(*map6), GFP_ATOMIC); | 154 | map6 = kzalloc(sizeof(*map6), GFP_ATOMIC); |
| 155 | if (map6 == NULL) | 155 | if (map6 == NULL) |
| 156 | goto cfg_unlbl_map_add_failure; | 156 | goto cfg_unlbl_map_add_failure; |
| @@ -162,11 +162,13 @@ int netlbl_cfg_unlbl_map_add(const char *domain, | |||
| 162 | map6->list.addr.s6_addr32[3] &= mask6->s6_addr32[3]; | 162 | map6->list.addr.s6_addr32[3] &= mask6->s6_addr32[3]; |
| 163 | ipv6_addr_copy(&map6->list.mask, mask6); | 163 | ipv6_addr_copy(&map6->list.mask, mask6); |
| 164 | map6->list.valid = 1; | 164 | map6->list.valid = 1; |
| 165 | ret_val = netlbl_af4list_add(&map4->list, | 165 | ret_val = netlbl_af6list_add(&map6->list, |
| 166 | &addrmap->list4); | 166 | &addrmap->list6); |
| 167 | if (ret_val != 0) | 167 | if (ret_val != 0) |
| 168 | goto cfg_unlbl_map_add_failure; | 168 | goto cfg_unlbl_map_add_failure; |
| 169 | break; | 169 | break; |
| 170 | } | ||
| 171 | #endif /* IPv6 */ | ||
| 170 | default: | 172 | default: |
| 171 | goto cfg_unlbl_map_add_failure; | 173 | goto cfg_unlbl_map_add_failure; |
| 172 | break; | 174 | break; |
| @@ -225,9 +227,11 @@ int netlbl_cfg_unlbl_static_add(struct net *net, | |||
| 225 | case AF_INET: | 227 | case AF_INET: |
| 226 | addr_len = sizeof(struct in_addr); | 228 | addr_len = sizeof(struct in_addr); |
| 227 | break; | 229 | break; |
| 230 | #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) | ||
| 228 | case AF_INET6: | 231 | case AF_INET6: |
| 229 | addr_len = sizeof(struct in6_addr); | 232 | addr_len = sizeof(struct in6_addr); |
| 230 | break; | 233 | break; |
| 234 | #endif /* IPv6 */ | ||
| 231 | default: | 235 | default: |
| 232 | return -EPFNOSUPPORT; | 236 | return -EPFNOSUPPORT; |
| 233 | } | 237 | } |
| @@ -266,9 +270,11 @@ int netlbl_cfg_unlbl_static_del(struct net *net, | |||
| 266 | case AF_INET: | 270 | case AF_INET: |
| 267 | addr_len = sizeof(struct in_addr); | 271 | addr_len = sizeof(struct in_addr); |
| 268 | break; | 272 | break; |
| 273 | #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) | ||
| 269 | case AF_INET6: | 274 | case AF_INET6: |
| 270 | addr_len = sizeof(struct in6_addr); | 275 | addr_len = sizeof(struct in6_addr); |
| 271 | break; | 276 | break; |
| 277 | #endif /* IPv6 */ | ||
| 272 | default: | 278 | default: |
| 273 | return -EPFNOSUPPORT; | 279 | return -EPFNOSUPPORT; |
| 274 | } | 280 | } |
diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c index b9493a09a870..6cd8ddfb512d 100644 --- a/net/sched/sch_gred.c +++ b/net/sched/sch_gred.c | |||
| @@ -385,7 +385,7 @@ static inline int gred_change_vq(struct Qdisc *sch, int dp, | |||
| 385 | struct gred_sched_data *q; | 385 | struct gred_sched_data *q; |
| 386 | 386 | ||
| 387 | if (table->tab[dp] == NULL) { | 387 | if (table->tab[dp] == NULL) { |
| 388 | table->tab[dp] = kzalloc(sizeof(*q), GFP_KERNEL); | 388 | table->tab[dp] = kzalloc(sizeof(*q), GFP_ATOMIC); |
| 389 | if (table->tab[dp] == NULL) | 389 | if (table->tab[dp] == NULL) |
| 390 | return -ENOMEM; | 390 | return -ENOMEM; |
| 391 | } | 391 | } |
diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c index 6649463da1b6..d617161f8dd3 100644 --- a/net/sched/sch_red.c +++ b/net/sched/sch_red.c | |||
| @@ -209,8 +209,8 @@ static int red_change(struct Qdisc *sch, struct nlattr *opt) | |||
| 209 | ctl->Plog, ctl->Scell_log, | 209 | ctl->Plog, ctl->Scell_log, |
| 210 | nla_data(tb[TCA_RED_STAB])); | 210 | nla_data(tb[TCA_RED_STAB])); |
| 211 | 211 | ||
| 212 | if (skb_queue_empty(&sch->q)) | 212 | if (!q->qdisc->q.qlen) |
| 213 | red_end_of_idle_period(&q->parms); | 213 | red_start_of_idle_period(&q->parms); |
| 214 | 214 | ||
| 215 | sch_tree_unlock(sch); | 215 | sch_tree_unlock(sch); |
| 216 | return 0; | 216 | return 0; |
diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index a3b7120fcc74..4f4c52c0eeb3 100644 --- a/net/sched/sch_teql.c +++ b/net/sched/sch_teql.c | |||
| @@ -225,11 +225,11 @@ static int teql_qdisc_init(struct Qdisc *sch, struct nlattr *opt) | |||
| 225 | 225 | ||
| 226 | 226 | ||
| 227 | static int | 227 | static int |
| 228 | __teql_resolve(struct sk_buff *skb, struct sk_buff *skb_res, struct net_device *dev) | 228 | __teql_resolve(struct sk_buff *skb, struct sk_buff *skb_res, |
| 229 | struct net_device *dev, struct netdev_queue *txq, | ||
| 230 | struct neighbour *mn) | ||
| 229 | { | 231 | { |
| 230 | struct netdev_queue *dev_queue = netdev_get_tx_queue(dev, 0); | 232 | struct teql_sched_data *q = qdisc_priv(txq->qdisc); |
| 231 | struct teql_sched_data *q = qdisc_priv(dev_queue->qdisc); | ||
| 232 | struct neighbour *mn = dst_get_neighbour(skb_dst(skb)); | ||
| 233 | struct neighbour *n = q->ncache; | 233 | struct neighbour *n = q->ncache; |
| 234 | 234 | ||
| 235 | if (mn->tbl == NULL) | 235 | if (mn->tbl == NULL) |
| @@ -262,17 +262,26 @@ __teql_resolve(struct sk_buff *skb, struct sk_buff *skb_res, struct net_device * | |||
| 262 | } | 262 | } |
| 263 | 263 | ||
| 264 | static inline int teql_resolve(struct sk_buff *skb, | 264 | static inline int teql_resolve(struct sk_buff *skb, |
| 265 | struct sk_buff *skb_res, struct net_device *dev) | 265 | struct sk_buff *skb_res, |
| 266 | struct net_device *dev, | ||
| 267 | struct netdev_queue *txq) | ||
| 266 | { | 268 | { |
| 267 | struct netdev_queue *txq = netdev_get_tx_queue(dev, 0); | 269 | struct dst_entry *dst = skb_dst(skb); |
| 270 | struct neighbour *mn; | ||
| 271 | int res; | ||
| 272 | |||
| 268 | if (txq->qdisc == &noop_qdisc) | 273 | if (txq->qdisc == &noop_qdisc) |
| 269 | return -ENODEV; | 274 | return -ENODEV; |
| 270 | 275 | ||
| 271 | if (dev->header_ops == NULL || | 276 | if (!dev->header_ops || !dst) |
| 272 | skb_dst(skb) == NULL || | ||
| 273 | dst_get_neighbour(skb_dst(skb)) == NULL) | ||
| 274 | return 0; | 277 | return 0; |
| 275 | return __teql_resolve(skb, skb_res, dev); | 278 | |
| 279 | rcu_read_lock(); | ||
| 280 | mn = dst_get_neighbour(dst); | ||
| 281 | res = mn ? __teql_resolve(skb, skb_res, dev, txq, mn) : 0; | ||
| 282 | rcu_read_unlock(); | ||
| 283 | |||
| 284 | return res; | ||
| 276 | } | 285 | } |
| 277 | 286 | ||
| 278 | static netdev_tx_t teql_master_xmit(struct sk_buff *skb, struct net_device *dev) | 287 | static netdev_tx_t teql_master_xmit(struct sk_buff *skb, struct net_device *dev) |
| @@ -307,7 +316,7 @@ restart: | |||
| 307 | continue; | 316 | continue; |
| 308 | } | 317 | } |
| 309 | 318 | ||
| 310 | switch (teql_resolve(skb, skb_res, slave)) { | 319 | switch (teql_resolve(skb, skb_res, slave, slave_txq)) { |
| 311 | case 0: | 320 | case 0: |
| 312 | if (__netif_tx_trylock(slave_txq)) { | 321 | if (__netif_tx_trylock(slave_txq)) { |
| 313 | unsigned int length = qdisc_pkt_len(skb); | 322 | unsigned int length = qdisc_pkt_len(skb); |
diff --git a/net/sctp/auth.c b/net/sctp/auth.c index 865e68fef21c..bf812048cf6f 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c | |||
| @@ -82,7 +82,7 @@ static struct sctp_auth_bytes *sctp_auth_create_key(__u32 key_len, gfp_t gfp) | |||
| 82 | struct sctp_auth_bytes *key; | 82 | struct sctp_auth_bytes *key; |
| 83 | 83 | ||
| 84 | /* Verify that we are not going to overflow INT_MAX */ | 84 | /* Verify that we are not going to overflow INT_MAX */ |
| 85 | if ((INT_MAX - key_len) < sizeof(struct sctp_auth_bytes)) | 85 | if (key_len > (INT_MAX - sizeof(struct sctp_auth_bytes))) |
| 86 | return NULL; | 86 | return NULL; |
| 87 | 87 | ||
| 88 | /* Allocate the shared key */ | 88 | /* Allocate the shared key */ |
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c index 2d78d95955ab..55472c48825e 100644 --- a/net/sunrpc/xprtsock.c +++ b/net/sunrpc/xprtsock.c | |||
| @@ -496,7 +496,7 @@ static int xs_nospace(struct rpc_task *task) | |||
| 496 | struct rpc_rqst *req = task->tk_rqstp; | 496 | struct rpc_rqst *req = task->tk_rqstp; |
| 497 | struct rpc_xprt *xprt = req->rq_xprt; | 497 | struct rpc_xprt *xprt = req->rq_xprt; |
| 498 | struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt); | 498 | struct sock_xprt *transport = container_of(xprt, struct sock_xprt, xprt); |
| 499 | int ret = 0; | 499 | int ret = -EAGAIN; |
| 500 | 500 | ||
| 501 | dprintk("RPC: %5u xmit incomplete (%u left of %u)\n", | 501 | dprintk("RPC: %5u xmit incomplete (%u left of %u)\n", |
| 502 | task->tk_pid, req->rq_slen - req->rq_bytes_sent, | 502 | task->tk_pid, req->rq_slen - req->rq_bytes_sent, |
| @@ -508,7 +508,6 @@ static int xs_nospace(struct rpc_task *task) | |||
| 508 | /* Don't race with disconnect */ | 508 | /* Don't race with disconnect */ |
| 509 | if (xprt_connected(xprt)) { | 509 | if (xprt_connected(xprt)) { |
| 510 | if (test_bit(SOCK_ASYNC_NOSPACE, &transport->sock->flags)) { | 510 | if (test_bit(SOCK_ASYNC_NOSPACE, &transport->sock->flags)) { |
| 511 | ret = -EAGAIN; | ||
| 512 | /* | 511 | /* |
| 513 | * Notify TCP that we're limited by the application | 512 | * Notify TCP that we're limited by the application |
| 514 | * window size | 513 | * window size |
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 466fbcc5cf77..b595a3d8679f 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c | |||
| @@ -1957,6 +1957,7 @@ static int unix_stream_recvmsg(struct kiocb *iocb, struct socket *sock, | |||
| 1957 | if ((UNIXCB(skb).pid != siocb->scm->pid) || | 1957 | if ((UNIXCB(skb).pid != siocb->scm->pid) || |
| 1958 | (UNIXCB(skb).cred != siocb->scm->cred)) { | 1958 | (UNIXCB(skb).cred != siocb->scm->cred)) { |
| 1959 | skb_queue_head(&sk->sk_receive_queue, skb); | 1959 | skb_queue_head(&sk->sk_receive_queue, skb); |
| 1960 | sk->sk_data_ready(sk, skb->len); | ||
| 1960 | break; | 1961 | break; |
| 1961 | } | 1962 | } |
| 1962 | } else { | 1963 | } else { |
| @@ -1974,6 +1975,7 @@ static int unix_stream_recvmsg(struct kiocb *iocb, struct socket *sock, | |||
| 1974 | chunk = min_t(unsigned int, skb->len, size); | 1975 | chunk = min_t(unsigned int, skb->len, size); |
| 1975 | if (memcpy_toiovec(msg->msg_iov, skb->data, chunk)) { | 1976 | if (memcpy_toiovec(msg->msg_iov, skb->data, chunk)) { |
| 1976 | skb_queue_head(&sk->sk_receive_queue, skb); | 1977 | skb_queue_head(&sk->sk_receive_queue, skb); |
| 1978 | sk->sk_data_ready(sk, skb->len); | ||
| 1977 | if (copied == 0) | 1979 | if (copied == 0) |
| 1978 | copied = -EFAULT; | 1980 | copied = -EFAULT; |
| 1979 | break; | 1981 | break; |
| @@ -1991,6 +1993,7 @@ static int unix_stream_recvmsg(struct kiocb *iocb, struct socket *sock, | |||
| 1991 | /* put the skb back if we didn't use it up.. */ | 1993 | /* put the skb back if we didn't use it up.. */ |
| 1992 | if (skb->len) { | 1994 | if (skb->len) { |
| 1993 | skb_queue_head(&sk->sk_receive_queue, skb); | 1995 | skb_queue_head(&sk->sk_receive_queue, skb); |
| 1996 | sk->sk_data_ready(sk, skb->len); | ||
| 1994 | break; | 1997 | break; |
| 1995 | } | 1998 | } |
| 1996 | 1999 | ||
| @@ -2006,6 +2009,7 @@ static int unix_stream_recvmsg(struct kiocb *iocb, struct socket *sock, | |||
| 2006 | 2009 | ||
| 2007 | /* put message back and return */ | 2010 | /* put message back and return */ |
| 2008 | skb_queue_head(&sk->sk_receive_queue, skb); | 2011 | skb_queue_head(&sk->sk_receive_queue, skb); |
| 2012 | sk->sk_data_ready(sk, skb->len); | ||
| 2009 | break; | 2013 | break; |
| 2010 | } | 2014 | } |
| 2011 | } while (size); | 2015 | } while (size); |
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index b3a476fe8272..ffafda5022c2 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c | |||
| @@ -89,8 +89,8 @@ static const struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] = { | |||
| 89 | [NL80211_ATTR_IFINDEX] = { .type = NLA_U32 }, | 89 | [NL80211_ATTR_IFINDEX] = { .type = NLA_U32 }, |
| 90 | [NL80211_ATTR_IFNAME] = { .type = NLA_NUL_STRING, .len = IFNAMSIZ-1 }, | 90 | [NL80211_ATTR_IFNAME] = { .type = NLA_NUL_STRING, .len = IFNAMSIZ-1 }, |
| 91 | 91 | ||
| 92 | [NL80211_ATTR_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, | 92 | [NL80211_ATTR_MAC] = { .len = ETH_ALEN }, |
| 93 | [NL80211_ATTR_PREV_BSSID] = { .type = NLA_BINARY, .len = ETH_ALEN }, | 93 | [NL80211_ATTR_PREV_BSSID] = { .len = ETH_ALEN }, |
| 94 | 94 | ||
| 95 | [NL80211_ATTR_KEY] = { .type = NLA_NESTED, }, | 95 | [NL80211_ATTR_KEY] = { .type = NLA_NESTED, }, |
| 96 | [NL80211_ATTR_KEY_DATA] = { .type = NLA_BINARY, | 96 | [NL80211_ATTR_KEY_DATA] = { .type = NLA_BINARY, |
diff --git a/net/wireless/reg.c b/net/wireless/reg.c index e71f5a66574e..3302c56f60d1 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c | |||
| @@ -57,8 +57,17 @@ | |||
| 57 | #define REG_DBG_PRINT(args...) | 57 | #define REG_DBG_PRINT(args...) |
| 58 | #endif | 58 | #endif |
| 59 | 59 | ||
| 60 | static struct regulatory_request core_request_world = { | ||
| 61 | .initiator = NL80211_REGDOM_SET_BY_CORE, | ||
| 62 | .alpha2[0] = '0', | ||
| 63 | .alpha2[1] = '0', | ||
| 64 | .intersect = false, | ||
| 65 | .processed = true, | ||
| 66 | .country_ie_env = ENVIRON_ANY, | ||
| 67 | }; | ||
| 68 | |||
| 60 | /* Receipt of information from last regulatory request */ | 69 | /* Receipt of information from last regulatory request */ |
| 61 | static struct regulatory_request *last_request; | 70 | static struct regulatory_request *last_request = &core_request_world; |
| 62 | 71 | ||
| 63 | /* To trigger userspace events */ | 72 | /* To trigger userspace events */ |
| 64 | static struct platform_device *reg_pdev; | 73 | static struct platform_device *reg_pdev; |
| @@ -150,7 +159,7 @@ static char user_alpha2[2]; | |||
| 150 | module_param(ieee80211_regdom, charp, 0444); | 159 | module_param(ieee80211_regdom, charp, 0444); |
| 151 | MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain code"); | 160 | MODULE_PARM_DESC(ieee80211_regdom, "IEEE 802.11 regulatory domain code"); |
| 152 | 161 | ||
| 153 | static void reset_regdomains(void) | 162 | static void reset_regdomains(bool full_reset) |
| 154 | { | 163 | { |
| 155 | /* avoid freeing static information or freeing something twice */ | 164 | /* avoid freeing static information or freeing something twice */ |
| 156 | if (cfg80211_regdomain == cfg80211_world_regdom) | 165 | if (cfg80211_regdomain == cfg80211_world_regdom) |
| @@ -165,6 +174,13 @@ static void reset_regdomains(void) | |||
| 165 | 174 | ||
| 166 | cfg80211_world_regdom = &world_regdom; | 175 | cfg80211_world_regdom = &world_regdom; |
| 167 | cfg80211_regdomain = NULL; | 176 | cfg80211_regdomain = NULL; |
| 177 | |||
| 178 | if (!full_reset) | ||
| 179 | return; | ||
| 180 | |||
| 181 | if (last_request != &core_request_world) | ||
| 182 | kfree(last_request); | ||
| 183 | last_request = &core_request_world; | ||
| 168 | } | 184 | } |
| 169 | 185 | ||
| 170 | /* | 186 | /* |
| @@ -175,7 +191,7 @@ static void update_world_regdomain(const struct ieee80211_regdomain *rd) | |||
| 175 | { | 191 | { |
| 176 | BUG_ON(!last_request); | 192 | BUG_ON(!last_request); |
| 177 | 193 | ||
| 178 | reset_regdomains(); | 194 | reset_regdomains(false); |
| 179 | 195 | ||
| 180 | cfg80211_world_regdom = rd; | 196 | cfg80211_world_regdom = rd; |
| 181 | cfg80211_regdomain = rd; | 197 | cfg80211_regdomain = rd; |
| @@ -1407,7 +1423,8 @@ static int __regulatory_hint(struct wiphy *wiphy, | |||
| 1407 | } | 1423 | } |
| 1408 | 1424 | ||
| 1409 | new_request: | 1425 | new_request: |
| 1410 | kfree(last_request); | 1426 | if (last_request != &core_request_world) |
| 1427 | kfree(last_request); | ||
| 1411 | 1428 | ||
| 1412 | last_request = pending_request; | 1429 | last_request = pending_request; |
| 1413 | last_request->intersect = intersect; | 1430 | last_request->intersect = intersect; |
| @@ -1577,9 +1594,6 @@ static int regulatory_hint_core(const char *alpha2) | |||
| 1577 | { | 1594 | { |
| 1578 | struct regulatory_request *request; | 1595 | struct regulatory_request *request; |
| 1579 | 1596 | ||
| 1580 | kfree(last_request); | ||
| 1581 | last_request = NULL; | ||
| 1582 | |||
| 1583 | request = kzalloc(sizeof(struct regulatory_request), | 1597 | request = kzalloc(sizeof(struct regulatory_request), |
| 1584 | GFP_KERNEL); | 1598 | GFP_KERNEL); |
| 1585 | if (!request) | 1599 | if (!request) |
| @@ -1777,7 +1791,7 @@ static void restore_regulatory_settings(bool reset_user) | |||
| 1777 | mutex_lock(&cfg80211_mutex); | 1791 | mutex_lock(&cfg80211_mutex); |
| 1778 | mutex_lock(®_mutex); | 1792 | mutex_lock(®_mutex); |
| 1779 | 1793 | ||
| 1780 | reset_regdomains(); | 1794 | reset_regdomains(true); |
| 1781 | restore_alpha2(alpha2, reset_user); | 1795 | restore_alpha2(alpha2, reset_user); |
| 1782 | 1796 | ||
| 1783 | /* | 1797 | /* |
| @@ -2037,12 +2051,18 @@ static int __set_regdom(const struct ieee80211_regdomain *rd) | |||
| 2037 | } | 2051 | } |
| 2038 | 2052 | ||
| 2039 | request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx); | 2053 | request_wiphy = wiphy_idx_to_wiphy(last_request->wiphy_idx); |
| 2054 | if (!request_wiphy && | ||
| 2055 | (last_request->initiator == NL80211_REGDOM_SET_BY_DRIVER || | ||
| 2056 | last_request->initiator == NL80211_REGDOM_SET_BY_COUNTRY_IE)) { | ||
| 2057 | schedule_delayed_work(®_timeout, 0); | ||
| 2058 | return -ENODEV; | ||
| 2059 | } | ||
| 2040 | 2060 | ||
| 2041 | if (!last_request->intersect) { | 2061 | if (!last_request->intersect) { |
| 2042 | int r; | 2062 | int r; |
| 2043 | 2063 | ||
| 2044 | if (last_request->initiator != NL80211_REGDOM_SET_BY_DRIVER) { | 2064 | if (last_request->initiator != NL80211_REGDOM_SET_BY_DRIVER) { |
| 2045 | reset_regdomains(); | 2065 | reset_regdomains(false); |
| 2046 | cfg80211_regdomain = rd; | 2066 | cfg80211_regdomain = rd; |
| 2047 | return 0; | 2067 | return 0; |
| 2048 | } | 2068 | } |
| @@ -2063,7 +2083,7 @@ static int __set_regdom(const struct ieee80211_regdomain *rd) | |||
| 2063 | if (r) | 2083 | if (r) |
| 2064 | return r; | 2084 | return r; |
| 2065 | 2085 | ||
| 2066 | reset_regdomains(); | 2086 | reset_regdomains(false); |
| 2067 | cfg80211_regdomain = rd; | 2087 | cfg80211_regdomain = rd; |
| 2068 | return 0; | 2088 | return 0; |
| 2069 | } | 2089 | } |
| @@ -2088,7 +2108,7 @@ static int __set_regdom(const struct ieee80211_regdomain *rd) | |||
| 2088 | 2108 | ||
| 2089 | rd = NULL; | 2109 | rd = NULL; |
| 2090 | 2110 | ||
| 2091 | reset_regdomains(); | 2111 | reset_regdomains(false); |
| 2092 | cfg80211_regdomain = intersected_rd; | 2112 | cfg80211_regdomain = intersected_rd; |
| 2093 | 2113 | ||
| 2094 | return 0; | 2114 | return 0; |
| @@ -2108,7 +2128,7 @@ static int __set_regdom(const struct ieee80211_regdomain *rd) | |||
| 2108 | kfree(rd); | 2128 | kfree(rd); |
| 2109 | rd = NULL; | 2129 | rd = NULL; |
| 2110 | 2130 | ||
| 2111 | reset_regdomains(); | 2131 | reset_regdomains(false); |
| 2112 | cfg80211_regdomain = intersected_rd; | 2132 | cfg80211_regdomain = intersected_rd; |
| 2113 | 2133 | ||
| 2114 | return 0; | 2134 | return 0; |
| @@ -2261,11 +2281,8 @@ void /* __init_or_exit */ regulatory_exit(void) | |||
| 2261 | mutex_lock(&cfg80211_mutex); | 2281 | mutex_lock(&cfg80211_mutex); |
| 2262 | mutex_lock(®_mutex); | 2282 | mutex_lock(®_mutex); |
| 2263 | 2283 | ||
| 2264 | reset_regdomains(); | 2284 | reset_regdomains(true); |
| 2265 | |||
| 2266 | kfree(last_request); | ||
| 2267 | 2285 | ||
| 2268 | last_request = NULL; | ||
| 2269 | dev_set_uevent_suppress(®_pdev->dev, true); | 2286 | dev_set_uevent_suppress(®_pdev->dev, true); |
| 2270 | 2287 | ||
| 2271 | platform_device_unregister(reg_pdev); | 2288 | platform_device_unregister(reg_pdev); |
diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 552df27dcf53..2118d6446630 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.c | |||
| @@ -2382,9 +2382,11 @@ static unsigned int xfrm_default_advmss(const struct dst_entry *dst) | |||
| 2382 | return dst_metric_advmss(dst->path); | 2382 | return dst_metric_advmss(dst->path); |
| 2383 | } | 2383 | } |
| 2384 | 2384 | ||
| 2385 | static unsigned int xfrm_default_mtu(const struct dst_entry *dst) | 2385 | static unsigned int xfrm_mtu(const struct dst_entry *dst) |
| 2386 | { | 2386 | { |
| 2387 | return dst_mtu(dst->path); | 2387 | unsigned int mtu = dst_metric_raw(dst, RTAX_MTU); |
| 2388 | |||
| 2389 | return mtu ? : dst_mtu(dst->path); | ||
| 2388 | } | 2390 | } |
| 2389 | 2391 | ||
| 2390 | static struct neighbour *xfrm_neigh_lookup(const struct dst_entry *dst, const void *daddr) | 2392 | static struct neighbour *xfrm_neigh_lookup(const struct dst_entry *dst, const void *daddr) |
| @@ -2411,8 +2413,8 @@ int xfrm_policy_register_afinfo(struct xfrm_policy_afinfo *afinfo) | |||
| 2411 | dst_ops->check = xfrm_dst_check; | 2413 | dst_ops->check = xfrm_dst_check; |
| 2412 | if (likely(dst_ops->default_advmss == NULL)) | 2414 | if (likely(dst_ops->default_advmss == NULL)) |
| 2413 | dst_ops->default_advmss = xfrm_default_advmss; | 2415 | dst_ops->default_advmss = xfrm_default_advmss; |
| 2414 | if (likely(dst_ops->default_mtu == NULL)) | 2416 | if (likely(dst_ops->mtu == NULL)) |
| 2415 | dst_ops->default_mtu = xfrm_default_mtu; | 2417 | dst_ops->mtu = xfrm_mtu; |
| 2416 | if (likely(dst_ops->negative_advice == NULL)) | 2418 | if (likely(dst_ops->negative_advice == NULL)) |
| 2417 | dst_ops->negative_advice = xfrm_negative_advice; | 2419 | dst_ops->negative_advice = xfrm_negative_advice; |
| 2418 | if (likely(dst_ops->link_failure == NULL)) | 2420 | if (likely(dst_ops->link_failure == NULL)) |
diff --git a/security/apparmor/path.c b/security/apparmor/path.c index 36cc0cc39e78..b566eba4a65c 100644 --- a/security/apparmor/path.c +++ b/security/apparmor/path.c | |||
| @@ -57,23 +57,44 @@ static int prepend(char **buffer, int buflen, const char *str, int namelen) | |||
| 57 | static int d_namespace_path(struct path *path, char *buf, int buflen, | 57 | static int d_namespace_path(struct path *path, char *buf, int buflen, |
| 58 | char **name, int flags) | 58 | char **name, int flags) |
| 59 | { | 59 | { |
| 60 | struct path root, tmp; | ||
| 61 | char *res; | 60 | char *res; |
| 62 | int connected, error = 0; | 61 | int error = 0; |
| 62 | int connected = 1; | ||
| 63 | |||
| 64 | if (path->mnt->mnt_flags & MNT_INTERNAL) { | ||
| 65 | /* it's not mounted anywhere */ | ||
| 66 | res = dentry_path(path->dentry, buf, buflen); | ||
| 67 | *name = res; | ||
| 68 | if (IS_ERR(res)) { | ||
| 69 | *name = buf; | ||
| 70 | return PTR_ERR(res); | ||
| 71 | } | ||
| 72 | if (path->dentry->d_sb->s_magic == PROC_SUPER_MAGIC && | ||
| 73 | strncmp(*name, "/sys/", 5) == 0) { | ||
| 74 | /* TODO: convert over to using a per namespace | ||
| 75 | * control instead of hard coded /proc | ||
| 76 | */ | ||
| 77 | return prepend(name, *name - buf, "/proc", 5); | ||
| 78 | } | ||
| 79 | return 0; | ||
| 80 | } | ||
| 63 | 81 | ||
| 64 | /* Get the root we want to resolve too, released below */ | 82 | /* resolve paths relative to chroot?*/ |
| 65 | if (flags & PATH_CHROOT_REL) { | 83 | if (flags & PATH_CHROOT_REL) { |
| 66 | /* resolve paths relative to chroot */ | 84 | struct path root; |
| 67 | get_fs_root(current->fs, &root); | 85 | get_fs_root(current->fs, &root); |
| 68 | } else { | 86 | res = __d_path(path, &root, buf, buflen); |
| 69 | /* resolve paths relative to namespace */ | 87 | if (res && !IS_ERR(res)) { |
| 70 | root.mnt = current->nsproxy->mnt_ns->root; | 88 | /* everything's fine */ |
| 71 | root.dentry = root.mnt->mnt_root; | 89 | *name = res; |
| 72 | path_get(&root); | 90 | path_put(&root); |
| 91 | goto ok; | ||
| 92 | } | ||
| 93 | path_put(&root); | ||
| 94 | connected = 0; | ||
| 73 | } | 95 | } |
| 74 | 96 | ||
| 75 | tmp = root; | 97 | res = d_absolute_path(path, buf, buflen); |
| 76 | res = __d_path(path, &tmp, buf, buflen); | ||
| 77 | 98 | ||
| 78 | *name = res; | 99 | *name = res; |
| 79 | /* handle error conditions - and still allow a partial path to | 100 | /* handle error conditions - and still allow a partial path to |
| @@ -84,7 +105,10 @@ static int d_namespace_path(struct path *path, char *buf, int buflen, | |||
| 84 | *name = buf; | 105 | *name = buf; |
| 85 | goto out; | 106 | goto out; |
| 86 | } | 107 | } |
| 108 | if (!our_mnt(path->mnt)) | ||
| 109 | connected = 0; | ||
| 87 | 110 | ||
| 111 | ok: | ||
| 88 | /* Handle two cases: | 112 | /* Handle two cases: |
| 89 | * 1. A deleted dentry && profile is not allowing mediation of deleted | 113 | * 1. A deleted dentry && profile is not allowing mediation of deleted |
| 90 | * 2. On some filesystems, newly allocated dentries appear to the | 114 | * 2. On some filesystems, newly allocated dentries appear to the |
| @@ -97,10 +121,7 @@ static int d_namespace_path(struct path *path, char *buf, int buflen, | |||
| 97 | goto out; | 121 | goto out; |
| 98 | } | 122 | } |
| 99 | 123 | ||
| 100 | /* Determine if the path is connected to the expected root */ | 124 | /* If the path is not connected to the expected root, |
| 101 | connected = tmp.dentry == root.dentry && tmp.mnt == root.mnt; | ||
| 102 | |||
| 103 | /* If the path is not connected, | ||
| 104 | * check if it is a sysctl and handle specially else remove any | 125 | * check if it is a sysctl and handle specially else remove any |
| 105 | * leading / that __d_path may have returned. | 126 | * leading / that __d_path may have returned. |
| 106 | * Unless | 127 | * Unless |
| @@ -112,17 +133,9 @@ static int d_namespace_path(struct path *path, char *buf, int buflen, | |||
| 112 | * namespace root. | 133 | * namespace root. |
| 113 | */ | 134 | */ |
| 114 | if (!connected) { | 135 | if (!connected) { |
| 115 | /* is the disconnect path a sysctl? */ | 136 | if (!(flags & PATH_CONNECT_PATH) && |
| 116 | if (tmp.dentry->d_sb->s_magic == PROC_SUPER_MAGIC && | ||
| 117 | strncmp(*name, "/sys/", 5) == 0) { | ||
| 118 | /* TODO: convert over to using a per namespace | ||
| 119 | * control instead of hard coded /proc | ||
| 120 | */ | ||
| 121 | error = prepend(name, *name - buf, "/proc", 5); | ||
| 122 | } else if (!(flags & PATH_CONNECT_PATH) && | ||
| 123 | !(((flags & CHROOT_NSCONNECT) == CHROOT_NSCONNECT) && | 137 | !(((flags & CHROOT_NSCONNECT) == CHROOT_NSCONNECT) && |
| 124 | (tmp.mnt == current->nsproxy->mnt_ns->root && | 138 | our_mnt(path->mnt))) { |
| 125 | tmp.dentry == tmp.mnt->mnt_root))) { | ||
| 126 | /* disconnected path, don't return pathname starting | 139 | /* disconnected path, don't return pathname starting |
| 127 | * with '/' | 140 | * with '/' |
| 128 | */ | 141 | */ |
| @@ -133,8 +146,6 @@ static int d_namespace_path(struct path *path, char *buf, int buflen, | |||
| 133 | } | 146 | } |
| 134 | 147 | ||
| 135 | out: | 148 | out: |
| 136 | path_put(&root); | ||
| 137 | |||
| 138 | return error; | 149 | return error; |
| 139 | } | 150 | } |
| 140 | 151 | ||
diff --git a/security/tomoyo/realpath.c b/security/tomoyo/realpath.c index 738bbdf8d4c7..d9f3ced8756e 100644 --- a/security/tomoyo/realpath.c +++ b/security/tomoyo/realpath.c | |||
| @@ -101,9 +101,8 @@ static char *tomoyo_get_absolute_path(struct path *path, char * const buffer, | |||
| 101 | { | 101 | { |
| 102 | char *pos = ERR_PTR(-ENOMEM); | 102 | char *pos = ERR_PTR(-ENOMEM); |
| 103 | if (buflen >= 256) { | 103 | if (buflen >= 256) { |
| 104 | struct path ns_root = { }; | ||
| 105 | /* go to whatever namespace root we are under */ | 104 | /* go to whatever namespace root we are under */ |
| 106 | pos = __d_path(path, &ns_root, buffer, buflen - 1); | 105 | pos = d_absolute_path(path, buffer, buflen - 1); |
| 107 | if (!IS_ERR(pos) && *pos == '/' && pos[1]) { | 106 | if (!IS_ERR(pos) && *pos == '/' && pos[1]) { |
| 108 | struct inode *inode = path->dentry->d_inode; | 107 | struct inode *inode = path->dentry->d_inode; |
| 109 | if (inode && S_ISDIR(inode->i_mode)) { | 108 | if (inode && S_ISDIR(inode->i_mode)) { |
| @@ -294,8 +293,16 @@ char *tomoyo_realpath_from_path(struct path *path) | |||
| 294 | pos = tomoyo_get_local_path(path->dentry, buf, | 293 | pos = tomoyo_get_local_path(path->dentry, buf, |
| 295 | buf_len - 1); | 294 | buf_len - 1); |
| 296 | /* Get absolute name for the rest. */ | 295 | /* Get absolute name for the rest. */ |
| 297 | else | 296 | else { |
| 298 | pos = tomoyo_get_absolute_path(path, buf, buf_len - 1); | 297 | pos = tomoyo_get_absolute_path(path, buf, buf_len - 1); |
| 298 | /* | ||
| 299 | * Fall back to local name if absolute name is not | ||
| 300 | * available. | ||
| 301 | */ | ||
| 302 | if (pos == ERR_PTR(-EINVAL)) | ||
| 303 | pos = tomoyo_get_local_path(path->dentry, buf, | ||
| 304 | buf_len - 1); | ||
| 305 | } | ||
| 299 | encode: | 306 | encode: |
| 300 | if (IS_ERR(pos)) | 307 | if (IS_ERR(pos)) |
| 301 | continue; | 308 | continue; |
diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c index e083122ca55a..dbf94b189e75 100644 --- a/sound/pci/cs5535audio/cs5535audio_pcm.c +++ b/sound/pci/cs5535audio/cs5535audio_pcm.c | |||
| @@ -148,7 +148,7 @@ static int cs5535audio_build_dma_packets(struct cs5535audio *cs5535au, | |||
| 148 | struct cs5535audio_dma_desc *desc = | 148 | struct cs5535audio_dma_desc *desc = |
| 149 | &((struct cs5535audio_dma_desc *) dma->desc_buf.area)[i]; | 149 | &((struct cs5535audio_dma_desc *) dma->desc_buf.area)[i]; |
| 150 | desc->addr = cpu_to_le32(addr); | 150 | desc->addr = cpu_to_le32(addr); |
| 151 | desc->size = cpu_to_le32(period_bytes); | 151 | desc->size = cpu_to_le16(period_bytes); |
| 152 | desc->ctlreserved = cpu_to_le16(PRD_EOP); | 152 | desc->ctlreserved = cpu_to_le16(PRD_EOP); |
| 153 | desc_addr += sizeof(struct cs5535audio_dma_desc); | 153 | desc_addr += sizeof(struct cs5535audio_dma_desc); |
| 154 | addr += period_bytes; | 154 | addr += period_bytes; |
diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c index e44b107fdc75..4562e9de6a1a 100644 --- a/sound/pci/hda/hda_codec.c +++ b/sound/pci/hda/hda_codec.c | |||
| @@ -4046,9 +4046,9 @@ int snd_hda_check_board_codec_sid_config(struct hda_codec *codec, | |||
| 4046 | 4046 | ||
| 4047 | /* Search for codec ID */ | 4047 | /* Search for codec ID */ |
| 4048 | for (q = tbl; q->subvendor; q++) { | 4048 | for (q = tbl; q->subvendor; q++) { |
| 4049 | unsigned long vendorid = (q->subdevice) | (q->subvendor << 16); | 4049 | unsigned int mask = 0xffff0000 | q->subdevice_mask; |
| 4050 | 4050 | unsigned int id = (q->subdevice | (q->subvendor << 16)) & mask; | |
| 4051 | if (vendorid == codec->subsystem_id) | 4051 | if ((codec->subsystem_id & mask) == id) |
| 4052 | break; | 4052 | break; |
| 4053 | } | 4053 | } |
| 4054 | 4054 | ||
diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c index 7ae7578bdcc0..c1da422e085a 100644 --- a/sound/pci/hda/hda_eld.c +++ b/sound/pci/hda/hda_eld.c | |||
| @@ -347,18 +347,28 @@ int snd_hdmi_get_eld(struct hdmi_eld *eld, | |||
| 347 | 347 | ||
| 348 | for (i = 0; i < size; i++) { | 348 | for (i = 0; i < size; i++) { |
| 349 | unsigned int val = hdmi_get_eld_data(codec, nid, i); | 349 | unsigned int val = hdmi_get_eld_data(codec, nid, i); |
| 350 | /* | ||
| 351 | * Graphics driver might be writing to ELD buffer right now. | ||
| 352 | * Just abort. The caller will repoll after a while. | ||
| 353 | */ | ||
| 350 | if (!(val & AC_ELDD_ELD_VALID)) { | 354 | if (!(val & AC_ELDD_ELD_VALID)) { |
| 351 | if (!i) { | ||
| 352 | snd_printd(KERN_INFO | ||
| 353 | "HDMI: invalid ELD data\n"); | ||
| 354 | ret = -EINVAL; | ||
| 355 | goto error; | ||
| 356 | } | ||
| 357 | snd_printd(KERN_INFO | 355 | snd_printd(KERN_INFO |
| 358 | "HDMI: invalid ELD data byte %d\n", i); | 356 | "HDMI: invalid ELD data byte %d\n", i); |
| 359 | val = 0; | 357 | ret = -EINVAL; |
| 360 | } else | 358 | goto error; |
| 361 | val &= AC_ELDD_ELD_DATA; | 359 | } |
| 360 | val &= AC_ELDD_ELD_DATA; | ||
| 361 | /* | ||
| 362 | * The first byte cannot be zero. This can happen on some DVI | ||
| 363 | * connections. Some Intel chips may also need some 250ms delay | ||
| 364 | * to return non-zero ELD data, even when the graphics driver | ||
| 365 | * correctly writes ELD content before setting ELD_valid bit. | ||
| 366 | */ | ||
| 367 | if (!val && !i) { | ||
| 368 | snd_printdd(KERN_INFO "HDMI: 0 ELD data\n"); | ||
| 369 | ret = -EINVAL; | ||
| 370 | goto error; | ||
| 371 | } | ||
| 362 | buf[i] = val; | 372 | buf[i] = val; |
| 363 | } | 373 | } |
| 364 | 374 | ||
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 096507d2ca9a..c2f79e63124d 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c | |||
| @@ -2507,8 +2507,8 @@ static struct snd_pci_quirk position_fix_list[] __devinitdata = { | |||
| 2507 | SND_PCI_QUIRK(0x1043, 0x813d, "ASUS P5AD2", POS_FIX_LPIB), | 2507 | SND_PCI_QUIRK(0x1043, 0x813d, "ASUS P5AD2", POS_FIX_LPIB), |
| 2508 | SND_PCI_QUIRK(0x1043, 0x81b3, "ASUS", POS_FIX_LPIB), | 2508 | SND_PCI_QUIRK(0x1043, 0x81b3, "ASUS", POS_FIX_LPIB), |
| 2509 | SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB), | 2509 | SND_PCI_QUIRK(0x1043, 0x81e7, "ASUS M2V", POS_FIX_LPIB), |
| 2510 | SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS 1101HA", POS_FIX_LPIB), | ||
| 2510 | SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), | 2511 | SND_PCI_QUIRK(0x104d, 0x9069, "Sony VPCS11V9E", POS_FIX_LPIB), |
| 2511 | SND_PCI_QUIRK(0x1106, 0x3288, "ASUS M2V-MX SE", POS_FIX_LPIB), | ||
| 2512 | SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), | 2512 | SND_PCI_QUIRK(0x1297, 0x3166, "Shuttle", POS_FIX_LPIB), |
| 2513 | SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), | 2513 | SND_PCI_QUIRK(0x1458, 0xa022, "ga-ma770-ud3", POS_FIX_LPIB), |
| 2514 | SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB), | 2514 | SND_PCI_QUIRK(0x1462, 0x1002, "MSI Wind U115", POS_FIX_LPIB), |
| @@ -2971,7 +2971,8 @@ static DEFINE_PCI_DEVICE_TABLE(azx_ids) = { | |||
| 2971 | /* SCH */ | 2971 | /* SCH */ |
| 2972 | { PCI_DEVICE(0x8086, 0x811b), | 2972 | { PCI_DEVICE(0x8086, 0x811b), |
| 2973 | .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_SCH_SNOOP | | 2973 | .driver_data = AZX_DRIVER_SCH | AZX_DCAPS_SCH_SNOOP | |
| 2974 | AZX_DCAPS_BUFSIZE}, | 2974 | AZX_DCAPS_BUFSIZE | AZX_DCAPS_POSFIX_LPIB }, /* Poulsbo */ |
| 2975 | /* ICH */ | ||
| 2975 | { PCI_DEVICE(0x8086, 0x2668), | 2976 | { PCI_DEVICE(0x8086, 0x2668), |
| 2976 | .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC | | 2977 | .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC | |
| 2977 | AZX_DCAPS_BUFSIZE }, /* ICH6 */ | 2978 | AZX_DCAPS_BUFSIZE }, /* ICH6 */ |
diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c index 2fbab8e29576..70a7abda7e22 100644 --- a/sound/pci/hda/patch_cirrus.c +++ b/sound/pci/hda/patch_cirrus.c | |||
| @@ -58,6 +58,8 @@ struct cs_spec { | |||
| 58 | unsigned int gpio_mask; | 58 | unsigned int gpio_mask; |
| 59 | unsigned int gpio_dir; | 59 | unsigned int gpio_dir; |
| 60 | unsigned int gpio_data; | 60 | unsigned int gpio_data; |
| 61 | unsigned int gpio_eapd_hp; /* EAPD GPIO bit for headphones */ | ||
| 62 | unsigned int gpio_eapd_speaker; /* EAPD GPIO bit for speakers */ | ||
| 61 | 63 | ||
| 62 | struct hda_pcm pcm_rec[2]; /* PCM information */ | 64 | struct hda_pcm pcm_rec[2]; /* PCM information */ |
| 63 | 65 | ||
| @@ -76,6 +78,7 @@ enum { | |||
| 76 | CS420X_MBP53, | 78 | CS420X_MBP53, |
| 77 | CS420X_MBP55, | 79 | CS420X_MBP55, |
| 78 | CS420X_IMAC27, | 80 | CS420X_IMAC27, |
| 81 | CS420X_APPLE, | ||
| 79 | CS420X_AUTO, | 82 | CS420X_AUTO, |
| 80 | CS420X_MODELS | 83 | CS420X_MODELS |
| 81 | }; | 84 | }; |
| @@ -928,10 +931,9 @@ static void cs_automute(struct hda_codec *codec) | |||
| 928 | spdif_present ? 0 : PIN_OUT); | 931 | spdif_present ? 0 : PIN_OUT); |
| 929 | } | 932 | } |
| 930 | } | 933 | } |
| 931 | if (spec->board_config == CS420X_MBP53 || | 934 | if (spec->gpio_eapd_hp) { |
| 932 | spec->board_config == CS420X_MBP55 || | 935 | unsigned int gpio = hp_present ? |
| 933 | spec->board_config == CS420X_IMAC27) { | 936 | spec->gpio_eapd_hp : spec->gpio_eapd_speaker; |
| 934 | unsigned int gpio = hp_present ? 0x02 : 0x08; | ||
| 935 | snd_hda_codec_write(codec, 0x01, 0, | 937 | snd_hda_codec_write(codec, 0x01, 0, |
| 936 | AC_VERB_SET_GPIO_DATA, gpio); | 938 | AC_VERB_SET_GPIO_DATA, gpio); |
| 937 | } | 939 | } |
| @@ -1276,6 +1278,7 @@ static const char * const cs420x_models[CS420X_MODELS] = { | |||
| 1276 | [CS420X_MBP53] = "mbp53", | 1278 | [CS420X_MBP53] = "mbp53", |
| 1277 | [CS420X_MBP55] = "mbp55", | 1279 | [CS420X_MBP55] = "mbp55", |
| 1278 | [CS420X_IMAC27] = "imac27", | 1280 | [CS420X_IMAC27] = "imac27", |
| 1281 | [CS420X_APPLE] = "apple", | ||
| 1279 | [CS420X_AUTO] = "auto", | 1282 | [CS420X_AUTO] = "auto", |
| 1280 | }; | 1283 | }; |
| 1281 | 1284 | ||
| @@ -1285,7 +1288,13 @@ static const struct snd_pci_quirk cs420x_cfg_tbl[] = { | |||
| 1285 | SND_PCI_QUIRK(0x10de, 0x0d94, "MacBookAir 3,1(2)", CS420X_MBP55), | 1288 | SND_PCI_QUIRK(0x10de, 0x0d94, "MacBookAir 3,1(2)", CS420X_MBP55), |
| 1286 | SND_PCI_QUIRK(0x10de, 0xcb79, "MacBookPro 5,5", CS420X_MBP55), | 1289 | SND_PCI_QUIRK(0x10de, 0xcb79, "MacBookPro 5,5", CS420X_MBP55), |
| 1287 | SND_PCI_QUIRK(0x10de, 0xcb89, "MacBookPro 7,1", CS420X_MBP55), | 1290 | SND_PCI_QUIRK(0x10de, 0xcb89, "MacBookPro 7,1", CS420X_MBP55), |
| 1288 | SND_PCI_QUIRK(0x8086, 0x7270, "IMac 27 Inch", CS420X_IMAC27), | 1291 | /* this conflicts with too many other models */ |
| 1292 | /*SND_PCI_QUIRK(0x8086, 0x7270, "IMac 27 Inch", CS420X_IMAC27),*/ | ||
| 1293 | {} /* terminator */ | ||
| 1294 | }; | ||
| 1295 | |||
| 1296 | static const struct snd_pci_quirk cs420x_codec_cfg_tbl[] = { | ||
| 1297 | SND_PCI_QUIRK_VENDOR(0x106b, "Apple", CS420X_APPLE), | ||
| 1289 | {} /* terminator */ | 1298 | {} /* terminator */ |
| 1290 | }; | 1299 | }; |
| 1291 | 1300 | ||
| @@ -1367,6 +1376,10 @@ static int patch_cs420x(struct hda_codec *codec) | |||
| 1367 | spec->board_config = | 1376 | spec->board_config = |
| 1368 | snd_hda_check_board_config(codec, CS420X_MODELS, | 1377 | snd_hda_check_board_config(codec, CS420X_MODELS, |
| 1369 | cs420x_models, cs420x_cfg_tbl); | 1378 | cs420x_models, cs420x_cfg_tbl); |
| 1379 | if (spec->board_config < 0) | ||
| 1380 | spec->board_config = | ||
| 1381 | snd_hda_check_board_codec_sid_config(codec, | ||
| 1382 | CS420X_MODELS, NULL, cs420x_codec_cfg_tbl); | ||
| 1370 | if (spec->board_config >= 0) | 1383 | if (spec->board_config >= 0) |
| 1371 | fix_pincfg(codec, spec->board_config, cs_pincfgs); | 1384 | fix_pincfg(codec, spec->board_config, cs_pincfgs); |
| 1372 | 1385 | ||
| @@ -1374,10 +1387,11 @@ static int patch_cs420x(struct hda_codec *codec) | |||
| 1374 | case CS420X_IMAC27: | 1387 | case CS420X_IMAC27: |
| 1375 | case CS420X_MBP53: | 1388 | case CS420X_MBP53: |
| 1376 | case CS420X_MBP55: | 1389 | case CS420X_MBP55: |
| 1377 | /* GPIO1 = headphones */ | 1390 | case CS420X_APPLE: |
| 1378 | /* GPIO3 = speakers */ | 1391 | spec->gpio_eapd_hp = 2; /* GPIO1 = headphones */ |
| 1379 | spec->gpio_mask = 0x0a; | 1392 | spec->gpio_eapd_speaker = 8; /* GPIO3 = speakers */ |
| 1380 | spec->gpio_dir = 0x0a; | 1393 | spec->gpio_mask = spec->gpio_dir = |
| 1394 | spec->gpio_eapd_hp | spec->gpio_eapd_speaker; | ||
| 1381 | break; | 1395 | break; |
| 1382 | } | 1396 | } |
| 1383 | 1397 | ||
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c index 9850c5b481ea..c505fd5d338c 100644 --- a/sound/pci/hda/patch_hdmi.c +++ b/sound/pci/hda/patch_hdmi.c | |||
| @@ -69,6 +69,7 @@ struct hdmi_spec_per_pin { | |||
| 69 | struct hda_codec *codec; | 69 | struct hda_codec *codec; |
| 70 | struct hdmi_eld sink_eld; | 70 | struct hdmi_eld sink_eld; |
| 71 | struct delayed_work work; | 71 | struct delayed_work work; |
| 72 | int repoll_count; | ||
| 72 | }; | 73 | }; |
| 73 | 74 | ||
| 74 | struct hdmi_spec { | 75 | struct hdmi_spec { |
| @@ -748,7 +749,7 @@ static void hdmi_setup_audio_infoframe(struct hda_codec *codec, int pin_idx, | |||
| 748 | * Unsolicited events | 749 | * Unsolicited events |
| 749 | */ | 750 | */ |
| 750 | 751 | ||
| 751 | static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, bool retry); | 752 | static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll); |
| 752 | 753 | ||
| 753 | static void hdmi_intrinsic_event(struct hda_codec *codec, unsigned int res) | 754 | static void hdmi_intrinsic_event(struct hda_codec *codec, unsigned int res) |
| 754 | { | 755 | { |
| @@ -766,7 +767,7 @@ static void hdmi_intrinsic_event(struct hda_codec *codec, unsigned int res) | |||
| 766 | if (pin_idx < 0) | 767 | if (pin_idx < 0) |
| 767 | return; | 768 | return; |
| 768 | 769 | ||
| 769 | hdmi_present_sense(&spec->pins[pin_idx], true); | 770 | hdmi_present_sense(&spec->pins[pin_idx], 1); |
| 770 | } | 771 | } |
| 771 | 772 | ||
| 772 | static void hdmi_non_intrinsic_event(struct hda_codec *codec, unsigned int res) | 773 | static void hdmi_non_intrinsic_event(struct hda_codec *codec, unsigned int res) |
| @@ -960,7 +961,7 @@ static int hdmi_read_pin_conn(struct hda_codec *codec, int pin_idx) | |||
| 960 | return 0; | 961 | return 0; |
| 961 | } | 962 | } |
| 962 | 963 | ||
| 963 | static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, bool retry) | 964 | static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll) |
| 964 | { | 965 | { |
| 965 | struct hda_codec *codec = per_pin->codec; | 966 | struct hda_codec *codec = per_pin->codec; |
| 966 | struct hdmi_eld *eld = &per_pin->sink_eld; | 967 | struct hdmi_eld *eld = &per_pin->sink_eld; |
| @@ -989,7 +990,7 @@ static void hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, bool retry) | |||
| 989 | if (eld_valid) { | 990 | if (eld_valid) { |
| 990 | if (!snd_hdmi_get_eld(eld, codec, pin_nid)) | 991 | if (!snd_hdmi_get_eld(eld, codec, pin_nid)) |
| 991 | snd_hdmi_show_eld(eld); | 992 | snd_hdmi_show_eld(eld); |
| 992 | else if (retry) { | 993 | else if (repoll) { |
| 993 | queue_delayed_work(codec->bus->workq, | 994 | queue_delayed_work(codec->bus->workq, |
| 994 | &per_pin->work, | 995 | &per_pin->work, |
| 995 | msecs_to_jiffies(300)); | 996 | msecs_to_jiffies(300)); |
| @@ -1004,7 +1005,10 @@ static void hdmi_repoll_eld(struct work_struct *work) | |||
| 1004 | struct hdmi_spec_per_pin *per_pin = | 1005 | struct hdmi_spec_per_pin *per_pin = |
| 1005 | container_of(to_delayed_work(work), struct hdmi_spec_per_pin, work); | 1006 | container_of(to_delayed_work(work), struct hdmi_spec_per_pin, work); |
| 1006 | 1007 | ||
| 1007 | hdmi_present_sense(per_pin, false); | 1008 | if (per_pin->repoll_count++ > 6) |
| 1009 | per_pin->repoll_count = 0; | ||
| 1010 | |||
| 1011 | hdmi_present_sense(per_pin, per_pin->repoll_count); | ||
| 1008 | } | 1012 | } |
| 1009 | 1013 | ||
| 1010 | static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) | 1014 | static int hdmi_add_pin(struct hda_codec *codec, hda_nid_t pin_nid) |
| @@ -1235,7 +1239,7 @@ static int generic_hdmi_build_jack(struct hda_codec *codec, int pin_idx) | |||
| 1235 | if (err < 0) | 1239 | if (err < 0) |
| 1236 | return err; | 1240 | return err; |
| 1237 | 1241 | ||
| 1238 | hdmi_present_sense(per_pin, false); | 1242 | hdmi_present_sense(per_pin, 0); |
| 1239 | return 0; | 1243 | return 0; |
| 1240 | } | 1244 | } |
| 1241 | 1245 | ||
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 336d14eb72af..1d07e8fa2433 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c | |||
| @@ -277,6 +277,12 @@ static bool alc_dyn_adc_pcm_resetup(struct hda_codec *codec, int cur) | |||
| 277 | return false; | 277 | return false; |
| 278 | } | 278 | } |
| 279 | 279 | ||
| 280 | static inline hda_nid_t get_capsrc(struct alc_spec *spec, int idx) | ||
| 281 | { | ||
| 282 | return spec->capsrc_nids ? | ||
| 283 | spec->capsrc_nids[idx] : spec->adc_nids[idx]; | ||
| 284 | } | ||
| 285 | |||
| 280 | /* select the given imux item; either unmute exclusively or select the route */ | 286 | /* select the given imux item; either unmute exclusively or select the route */ |
| 281 | static int alc_mux_select(struct hda_codec *codec, unsigned int adc_idx, | 287 | static int alc_mux_select(struct hda_codec *codec, unsigned int adc_idx, |
| 282 | unsigned int idx, bool force) | 288 | unsigned int idx, bool force) |
| @@ -291,6 +297,8 @@ static int alc_mux_select(struct hda_codec *codec, unsigned int adc_idx, | |||
| 291 | imux = &spec->input_mux[mux_idx]; | 297 | imux = &spec->input_mux[mux_idx]; |
| 292 | if (!imux->num_items && mux_idx > 0) | 298 | if (!imux->num_items && mux_idx > 0) |
| 293 | imux = &spec->input_mux[0]; | 299 | imux = &spec->input_mux[0]; |
| 300 | if (!imux->num_items) | ||
| 301 | return 0; | ||
| 294 | 302 | ||
| 295 | if (idx >= imux->num_items) | 303 | if (idx >= imux->num_items) |
| 296 | idx = imux->num_items - 1; | 304 | idx = imux->num_items - 1; |
| @@ -303,8 +311,7 @@ static int alc_mux_select(struct hda_codec *codec, unsigned int adc_idx, | |||
| 303 | adc_idx = spec->dyn_adc_idx[idx]; | 311 | adc_idx = spec->dyn_adc_idx[idx]; |
| 304 | } | 312 | } |
| 305 | 313 | ||
| 306 | nid = spec->capsrc_nids ? | 314 | nid = get_capsrc(spec, adc_idx); |
| 307 | spec->capsrc_nids[adc_idx] : spec->adc_nids[adc_idx]; | ||
| 308 | 315 | ||
| 309 | /* no selection? */ | 316 | /* no selection? */ |
| 310 | num_conns = snd_hda_get_conn_list(codec, nid, NULL); | 317 | num_conns = snd_hda_get_conn_list(codec, nid, NULL); |
| @@ -1054,8 +1061,19 @@ static bool alc_rebuild_imux_for_auto_mic(struct hda_codec *codec) | |||
| 1054 | spec->imux_pins[2] = spec->dock_mic_pin; | 1061 | spec->imux_pins[2] = spec->dock_mic_pin; |
| 1055 | for (i = 0; i < 3; i++) { | 1062 | for (i = 0; i < 3; i++) { |
| 1056 | strcpy(imux->items[i].label, texts[i]); | 1063 | strcpy(imux->items[i].label, texts[i]); |
| 1057 | if (spec->imux_pins[i]) | 1064 | if (spec->imux_pins[i]) { |
| 1065 | hda_nid_t pin = spec->imux_pins[i]; | ||
| 1066 | int c; | ||
| 1067 | for (c = 0; c < spec->num_adc_nids; c++) { | ||
| 1068 | hda_nid_t cap = get_capsrc(spec, c); | ||
| 1069 | int idx = get_connection_index(codec, cap, pin); | ||
| 1070 | if (idx >= 0) { | ||
| 1071 | imux->items[i].index = idx; | ||
| 1072 | break; | ||
| 1073 | } | ||
| 1074 | } | ||
| 1058 | imux->num_items = i + 1; | 1075 | imux->num_items = i + 1; |
| 1076 | } | ||
| 1059 | } | 1077 | } |
| 1060 | spec->num_mux_defs = 1; | 1078 | spec->num_mux_defs = 1; |
| 1061 | spec->input_mux = imux; | 1079 | spec->input_mux = imux; |
| @@ -1957,10 +1975,8 @@ static int alc_build_controls(struct hda_codec *codec) | |||
| 1957 | if (!kctl) | 1975 | if (!kctl) |
| 1958 | kctl = snd_hda_find_mixer_ctl(codec, "Input Source"); | 1976 | kctl = snd_hda_find_mixer_ctl(codec, "Input Source"); |
| 1959 | for (i = 0; kctl && i < kctl->count; i++) { | 1977 | for (i = 0; kctl && i < kctl->count; i++) { |
| 1960 | const hda_nid_t *nids = spec->capsrc_nids; | 1978 | err = snd_hda_add_nid(codec, kctl, i, |
| 1961 | if (!nids) | 1979 | get_capsrc(spec, i)); |
| 1962 | nids = spec->adc_nids; | ||
| 1963 | err = snd_hda_add_nid(codec, kctl, i, nids[i]); | ||
| 1964 | if (err < 0) | 1980 | if (err < 0) |
| 1965 | return err; | 1981 | return err; |
| 1966 | } | 1982 | } |
| @@ -2615,6 +2631,8 @@ static const char *alc_get_line_out_pfx(struct alc_spec *spec, int ch, | |||
| 2615 | case AUTO_PIN_SPEAKER_OUT: | 2631 | case AUTO_PIN_SPEAKER_OUT: |
| 2616 | if (cfg->line_outs == 1) | 2632 | if (cfg->line_outs == 1) |
| 2617 | return "Speaker"; | 2633 | return "Speaker"; |
| 2634 | if (cfg->line_outs == 2) | ||
| 2635 | return ch ? "Bass Speaker" : "Speaker"; | ||
| 2618 | break; | 2636 | break; |
| 2619 | case AUTO_PIN_HP_OUT: | 2637 | case AUTO_PIN_HP_OUT: |
| 2620 | /* for multi-io case, only the primary out */ | 2638 | /* for multi-io case, only the primary out */ |
| @@ -2747,8 +2765,7 @@ static int alc_auto_create_input_ctls(struct hda_codec *codec) | |||
| 2747 | } | 2765 | } |
| 2748 | 2766 | ||
| 2749 | for (c = 0; c < num_adcs; c++) { | 2767 | for (c = 0; c < num_adcs; c++) { |
| 2750 | hda_nid_t cap = spec->capsrc_nids ? | 2768 | hda_nid_t cap = get_capsrc(spec, c); |
| 2751 | spec->capsrc_nids[c] : spec->adc_nids[c]; | ||
| 2752 | idx = get_connection_index(codec, cap, pin); | 2769 | idx = get_connection_index(codec, cap, pin); |
| 2753 | if (idx >= 0) { | 2770 | if (idx >= 0) { |
| 2754 | spec->imux_pins[imux->num_items] = pin; | 2771 | spec->imux_pins[imux->num_items] = pin; |
| @@ -2889,7 +2906,7 @@ static hda_nid_t alc_auto_look_for_dac(struct hda_codec *codec, hda_nid_t pin) | |||
| 2889 | if (!nid) | 2906 | if (!nid) |
| 2890 | continue; | 2907 | continue; |
| 2891 | if (found_in_nid_list(nid, spec->multiout.dac_nids, | 2908 | if (found_in_nid_list(nid, spec->multiout.dac_nids, |
| 2892 | spec->multiout.num_dacs)) | 2909 | ARRAY_SIZE(spec->private_dac_nids))) |
| 2893 | continue; | 2910 | continue; |
| 2894 | if (found_in_nid_list(nid, spec->multiout.hp_out_nid, | 2911 | if (found_in_nid_list(nid, spec->multiout.hp_out_nid, |
| 2895 | ARRAY_SIZE(spec->multiout.hp_out_nid))) | 2912 | ARRAY_SIZE(spec->multiout.hp_out_nid))) |
| @@ -2910,6 +2927,7 @@ static hda_nid_t get_dac_if_single(struct hda_codec *codec, hda_nid_t pin) | |||
| 2910 | return 0; | 2927 | return 0; |
| 2911 | } | 2928 | } |
| 2912 | 2929 | ||
| 2930 | /* return 0 if no possible DAC is found, 1 if one or more found */ | ||
| 2913 | static int alc_auto_fill_extra_dacs(struct hda_codec *codec, int num_outs, | 2931 | static int alc_auto_fill_extra_dacs(struct hda_codec *codec, int num_outs, |
| 2914 | const hda_nid_t *pins, hda_nid_t *dacs) | 2932 | const hda_nid_t *pins, hda_nid_t *dacs) |
| 2915 | { | 2933 | { |
| @@ -2927,7 +2945,7 @@ static int alc_auto_fill_extra_dacs(struct hda_codec *codec, int num_outs, | |||
| 2927 | if (!dacs[i]) | 2945 | if (!dacs[i]) |
| 2928 | dacs[i] = alc_auto_look_for_dac(codec, pins[i]); | 2946 | dacs[i] = alc_auto_look_for_dac(codec, pins[i]); |
| 2929 | } | 2947 | } |
| 2930 | return 0; | 2948 | return 1; |
| 2931 | } | 2949 | } |
| 2932 | 2950 | ||
| 2933 | static int alc_auto_fill_multi_ios(struct hda_codec *codec, | 2951 | static int alc_auto_fill_multi_ios(struct hda_codec *codec, |
| @@ -2937,7 +2955,7 @@ static int alc_auto_fill_multi_ios(struct hda_codec *codec, | |||
| 2937 | static int alc_auto_fill_dac_nids(struct hda_codec *codec) | 2955 | static int alc_auto_fill_dac_nids(struct hda_codec *codec) |
| 2938 | { | 2956 | { |
| 2939 | struct alc_spec *spec = codec->spec; | 2957 | struct alc_spec *spec = codec->spec; |
| 2940 | const struct auto_pin_cfg *cfg = &spec->autocfg; | 2958 | struct auto_pin_cfg *cfg = &spec->autocfg; |
| 2941 | bool redone = false; | 2959 | bool redone = false; |
| 2942 | int i; | 2960 | int i; |
| 2943 | 2961 | ||
| @@ -2948,6 +2966,7 @@ static int alc_auto_fill_dac_nids(struct hda_codec *codec) | |||
| 2948 | spec->multiout.extra_out_nid[0] = 0; | 2966 | spec->multiout.extra_out_nid[0] = 0; |
| 2949 | memset(spec->private_dac_nids, 0, sizeof(spec->private_dac_nids)); | 2967 | memset(spec->private_dac_nids, 0, sizeof(spec->private_dac_nids)); |
| 2950 | spec->multiout.dac_nids = spec->private_dac_nids; | 2968 | spec->multiout.dac_nids = spec->private_dac_nids; |
| 2969 | spec->multi_ios = 0; | ||
| 2951 | 2970 | ||
| 2952 | /* fill hard-wired DACs first */ | 2971 | /* fill hard-wired DACs first */ |
| 2953 | if (!redone) { | 2972 | if (!redone) { |
| @@ -2981,10 +3000,12 @@ static int alc_auto_fill_dac_nids(struct hda_codec *codec) | |||
| 2981 | for (i = 0; i < cfg->line_outs; i++) { | 3000 | for (i = 0; i < cfg->line_outs; i++) { |
| 2982 | if (spec->private_dac_nids[i]) | 3001 | if (spec->private_dac_nids[i]) |
| 2983 | spec->multiout.num_dacs++; | 3002 | spec->multiout.num_dacs++; |
| 2984 | else | 3003 | else { |
| 2985 | memmove(spec->private_dac_nids + i, | 3004 | memmove(spec->private_dac_nids + i, |
| 2986 | spec->private_dac_nids + i + 1, | 3005 | spec->private_dac_nids + i + 1, |
| 2987 | sizeof(hda_nid_t) * (cfg->line_outs - i - 1)); | 3006 | sizeof(hda_nid_t) * (cfg->line_outs - i - 1)); |
| 3007 | spec->private_dac_nids[cfg->line_outs - 1] = 0; | ||
| 3008 | } | ||
| 2988 | } | 3009 | } |
| 2989 | 3010 | ||
| 2990 | if (cfg->line_outs == 1 && cfg->line_out_type != AUTO_PIN_SPEAKER_OUT) { | 3011 | if (cfg->line_outs == 1 && cfg->line_out_type != AUTO_PIN_SPEAKER_OUT) { |
| @@ -3006,9 +3027,28 @@ static int alc_auto_fill_dac_nids(struct hda_codec *codec) | |||
| 3006 | if (cfg->line_out_type != AUTO_PIN_HP_OUT) | 3027 | if (cfg->line_out_type != AUTO_PIN_HP_OUT) |
| 3007 | alc_auto_fill_extra_dacs(codec, cfg->hp_outs, cfg->hp_pins, | 3028 | alc_auto_fill_extra_dacs(codec, cfg->hp_outs, cfg->hp_pins, |
| 3008 | spec->multiout.hp_out_nid); | 3029 | spec->multiout.hp_out_nid); |
| 3009 | if (cfg->line_out_type != AUTO_PIN_SPEAKER_OUT) | 3030 | if (cfg->line_out_type != AUTO_PIN_SPEAKER_OUT) { |
| 3010 | alc_auto_fill_extra_dacs(codec, cfg->speaker_outs, cfg->speaker_pins, | 3031 | int err = alc_auto_fill_extra_dacs(codec, cfg->speaker_outs, |
| 3011 | spec->multiout.extra_out_nid); | 3032 | cfg->speaker_pins, |
| 3033 | spec->multiout.extra_out_nid); | ||
| 3034 | /* if no speaker volume is assigned, try again as the primary | ||
| 3035 | * output | ||
| 3036 | */ | ||
| 3037 | if (!err && cfg->speaker_outs > 0 && | ||
| 3038 | cfg->line_out_type == AUTO_PIN_HP_OUT) { | ||
| 3039 | cfg->hp_outs = cfg->line_outs; | ||
| 3040 | memcpy(cfg->hp_pins, cfg->line_out_pins, | ||
| 3041 | sizeof(cfg->hp_pins)); | ||
| 3042 | cfg->line_outs = cfg->speaker_outs; | ||
| 3043 | memcpy(cfg->line_out_pins, cfg->speaker_pins, | ||
| 3044 | sizeof(cfg->speaker_pins)); | ||
| 3045 | cfg->speaker_outs = 0; | ||
| 3046 | memset(cfg->speaker_pins, 0, sizeof(cfg->speaker_pins)); | ||
| 3047 | cfg->line_out_type = AUTO_PIN_SPEAKER_OUT; | ||
| 3048 | redone = false; | ||
| 3049 | goto again; | ||
| 3050 | } | ||
| 3051 | } | ||
| 3012 | 3052 | ||
| 3013 | return 0; | 3053 | return 0; |
| 3014 | } | 3054 | } |
| @@ -3158,7 +3198,8 @@ static int alc_auto_create_multi_out_ctls(struct hda_codec *codec, | |||
| 3158 | } | 3198 | } |
| 3159 | 3199 | ||
| 3160 | static int alc_auto_create_extra_out(struct hda_codec *codec, hda_nid_t pin, | 3200 | static int alc_auto_create_extra_out(struct hda_codec *codec, hda_nid_t pin, |
| 3161 | hda_nid_t dac, const char *pfx) | 3201 | hda_nid_t dac, const char *pfx, |
| 3202 | int cidx) | ||
| 3162 | { | 3203 | { |
| 3163 | struct alc_spec *spec = codec->spec; | 3204 | struct alc_spec *spec = codec->spec; |
| 3164 | hda_nid_t sw, vol; | 3205 | hda_nid_t sw, vol; |
| @@ -3174,15 +3215,15 @@ static int alc_auto_create_extra_out(struct hda_codec *codec, hda_nid_t pin, | |||
| 3174 | if (is_ctl_used(spec->sw_ctls, val)) | 3215 | if (is_ctl_used(spec->sw_ctls, val)) |
| 3175 | return 0; /* already created */ | 3216 | return 0; /* already created */ |
| 3176 | mark_ctl_usage(spec->sw_ctls, val); | 3217 | mark_ctl_usage(spec->sw_ctls, val); |
| 3177 | return add_pb_sw_ctrl(spec, ALC_CTL_WIDGET_MUTE, pfx, val); | 3218 | return __add_pb_sw_ctrl(spec, ALC_CTL_WIDGET_MUTE, pfx, cidx, val); |
| 3178 | } | 3219 | } |
| 3179 | 3220 | ||
| 3180 | sw = alc_look_for_out_mute_nid(codec, pin, dac); | 3221 | sw = alc_look_for_out_mute_nid(codec, pin, dac); |
| 3181 | vol = alc_look_for_out_vol_nid(codec, pin, dac); | 3222 | vol = alc_look_for_out_vol_nid(codec, pin, dac); |
| 3182 | err = alc_auto_add_stereo_vol(codec, pfx, 0, vol); | 3223 | err = alc_auto_add_stereo_vol(codec, pfx, cidx, vol); |
| 3183 | if (err < 0) | 3224 | if (err < 0) |
| 3184 | return err; | 3225 | return err; |
| 3185 | err = alc_auto_add_stereo_sw(codec, pfx, 0, sw); | 3226 | err = alc_auto_add_stereo_sw(codec, pfx, cidx, sw); |
| 3186 | if (err < 0) | 3227 | if (err < 0) |
| 3187 | return err; | 3228 | return err; |
| 3188 | return 0; | 3229 | return 0; |
| @@ -3223,16 +3264,21 @@ static int alc_auto_create_extra_outs(struct hda_codec *codec, int num_pins, | |||
| 3223 | hda_nid_t dac = *dacs; | 3264 | hda_nid_t dac = *dacs; |
| 3224 | if (!dac) | 3265 | if (!dac) |
| 3225 | dac = spec->multiout.dac_nids[0]; | 3266 | dac = spec->multiout.dac_nids[0]; |
| 3226 | return alc_auto_create_extra_out(codec, *pins, dac, pfx); | 3267 | return alc_auto_create_extra_out(codec, *pins, dac, pfx, 0); |
| 3227 | } | 3268 | } |
| 3228 | 3269 | ||
| 3229 | if (dacs[num_pins - 1]) { | 3270 | if (dacs[num_pins - 1]) { |
| 3230 | /* OK, we have a multi-output system with individual volumes */ | 3271 | /* OK, we have a multi-output system with individual volumes */ |
| 3231 | for (i = 0; i < num_pins; i++) { | 3272 | for (i = 0; i < num_pins; i++) { |
| 3232 | snprintf(name, sizeof(name), "%s %s", | 3273 | if (num_pins >= 3) { |
| 3233 | pfx, channel_name[i]); | 3274 | snprintf(name, sizeof(name), "%s %s", |
| 3234 | err = alc_auto_create_extra_out(codec, pins[i], dacs[i], | 3275 | pfx, channel_name[i]); |
| 3235 | name); | 3276 | err = alc_auto_create_extra_out(codec, pins[i], dacs[i], |
| 3277 | name, 0); | ||
| 3278 | } else { | ||
| 3279 | err = alc_auto_create_extra_out(codec, pins[i], dacs[i], | ||
| 3280 | pfx, i); | ||
| 3281 | } | ||
| 3236 | if (err < 0) | 3282 | if (err < 0) |
| 3237 | return err; | 3283 | return err; |
| 3238 | } | 3284 | } |
| @@ -3694,8 +3740,7 @@ static int init_capsrc_for_pin(struct hda_codec *codec, hda_nid_t pin) | |||
| 3694 | if (!pin) | 3740 | if (!pin) |
| 3695 | return 0; | 3741 | return 0; |
| 3696 | for (i = 0; i < spec->num_adc_nids; i++) { | 3742 | for (i = 0; i < spec->num_adc_nids; i++) { |
| 3697 | hda_nid_t cap = spec->capsrc_nids ? | 3743 | hda_nid_t cap = get_capsrc(spec, i); |
| 3698 | spec->capsrc_nids[i] : spec->adc_nids[i]; | ||
| 3699 | int idx; | 3744 | int idx; |
| 3700 | 3745 | ||
| 3701 | idx = get_connection_index(codec, cap, pin); | 3746 | idx = get_connection_index(codec, cap, pin); |
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c index 470f6f286e81..616678fde486 100644 --- a/sound/pci/hda/patch_sigmatel.c +++ b/sound/pci/hda/patch_sigmatel.c | |||
| @@ -215,6 +215,7 @@ struct sigmatel_spec { | |||
| 215 | unsigned int gpio_mute; | 215 | unsigned int gpio_mute; |
| 216 | unsigned int gpio_led; | 216 | unsigned int gpio_led; |
| 217 | unsigned int gpio_led_polarity; | 217 | unsigned int gpio_led_polarity; |
| 218 | unsigned int vref_mute_led_nid; /* pin NID for mute-LED vref control */ | ||
| 218 | unsigned int vref_led; | 219 | unsigned int vref_led; |
| 219 | 220 | ||
| 220 | /* stream */ | 221 | /* stream */ |
| @@ -1641,6 +1642,8 @@ static const struct snd_pci_quirk stac92hd73xx_codec_id_cfg_tbl[] = { | |||
| 1641 | "Alienware M17x", STAC_ALIENWARE_M17X), | 1642 | "Alienware M17x", STAC_ALIENWARE_M17X), |
| 1642 | SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x043a, | 1643 | SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x043a, |
| 1643 | "Alienware M17x", STAC_ALIENWARE_M17X), | 1644 | "Alienware M17x", STAC_ALIENWARE_M17X), |
| 1645 | SND_PCI_QUIRK(PCI_VENDOR_ID_DELL, 0x0490, | ||
| 1646 | "Alienware M17x", STAC_ALIENWARE_M17X), | ||
| 1644 | {} /* terminator */ | 1647 | {} /* terminator */ |
| 1645 | }; | 1648 | }; |
| 1646 | 1649 | ||
| @@ -4316,12 +4319,10 @@ static void stac_store_hints(struct hda_codec *codec) | |||
| 4316 | spec->eapd_switch = val; | 4319 | spec->eapd_switch = val; |
| 4317 | get_int_hint(codec, "gpio_led_polarity", &spec->gpio_led_polarity); | 4320 | get_int_hint(codec, "gpio_led_polarity", &spec->gpio_led_polarity); |
| 4318 | if (get_int_hint(codec, "gpio_led", &spec->gpio_led)) { | 4321 | if (get_int_hint(codec, "gpio_led", &spec->gpio_led)) { |
| 4319 | if (spec->gpio_led <= 8) { | 4322 | spec->gpio_mask |= spec->gpio_led; |
| 4320 | spec->gpio_mask |= spec->gpio_led; | 4323 | spec->gpio_dir |= spec->gpio_led; |
| 4321 | spec->gpio_dir |= spec->gpio_led; | 4324 | if (spec->gpio_led_polarity) |
| 4322 | if (spec->gpio_led_polarity) | 4325 | spec->gpio_data |= spec->gpio_led; |
| 4323 | spec->gpio_data |= spec->gpio_led; | ||
| 4324 | } | ||
| 4325 | } | 4326 | } |
| 4326 | } | 4327 | } |
| 4327 | 4328 | ||
| @@ -4439,7 +4440,9 @@ static int stac92xx_init(struct hda_codec *codec) | |||
| 4439 | int pinctl, def_conf; | 4440 | int pinctl, def_conf; |
| 4440 | 4441 | ||
| 4441 | /* power on when no jack detection is available */ | 4442 | /* power on when no jack detection is available */ |
| 4442 | if (!spec->hp_detect) { | 4443 | /* or when the VREF is used for controlling LED */ |
| 4444 | if (!spec->hp_detect || | ||
| 4445 | spec->vref_mute_led_nid == nid) { | ||
| 4443 | stac_toggle_power_map(codec, nid, 1); | 4446 | stac_toggle_power_map(codec, nid, 1); |
| 4444 | continue; | 4447 | continue; |
| 4445 | } | 4448 | } |
| @@ -4911,8 +4914,14 @@ static int find_mute_led_gpio(struct hda_codec *codec, int default_polarity) | |||
| 4911 | if (sscanf(dev->name, "HP_Mute_LED_%d_%x", | 4914 | if (sscanf(dev->name, "HP_Mute_LED_%d_%x", |
| 4912 | &spec->gpio_led_polarity, | 4915 | &spec->gpio_led_polarity, |
| 4913 | &spec->gpio_led) == 2) { | 4916 | &spec->gpio_led) == 2) { |
| 4914 | if (spec->gpio_led < 4) | 4917 | unsigned int max_gpio; |
| 4918 | max_gpio = snd_hda_param_read(codec, codec->afg, | ||
| 4919 | AC_PAR_GPIO_CAP); | ||
| 4920 | max_gpio &= AC_GPIO_IO_COUNT; | ||
| 4921 | if (spec->gpio_led < max_gpio) | ||
| 4915 | spec->gpio_led = 1 << spec->gpio_led; | 4922 | spec->gpio_led = 1 << spec->gpio_led; |
| 4923 | else | ||
| 4924 | spec->vref_mute_led_nid = spec->gpio_led; | ||
| 4916 | return 1; | 4925 | return 1; |
| 4917 | } | 4926 | } |
| 4918 | if (sscanf(dev->name, "HP_Mute_LED_%d", | 4927 | if (sscanf(dev->name, "HP_Mute_LED_%d", |
| @@ -4920,6 +4929,12 @@ static int find_mute_led_gpio(struct hda_codec *codec, int default_polarity) | |||
| 4920 | set_hp_led_gpio(codec); | 4929 | set_hp_led_gpio(codec); |
| 4921 | return 1; | 4930 | return 1; |
| 4922 | } | 4931 | } |
| 4932 | /* BIOS bug: unfilled OEM string */ | ||
| 4933 | if (strstr(dev->name, "HP_Mute_LED_P_G")) { | ||
| 4934 | set_hp_led_gpio(codec); | ||
| 4935 | spec->gpio_led_polarity = 1; | ||
| 4936 | return 1; | ||
| 4937 | } | ||
| 4923 | } | 4938 | } |
| 4924 | 4939 | ||
| 4925 | /* | 4940 | /* |
| @@ -5041,29 +5056,12 @@ static int stac92xx_pre_resume(struct hda_codec *codec) | |||
| 5041 | struct sigmatel_spec *spec = codec->spec; | 5056 | struct sigmatel_spec *spec = codec->spec; |
| 5042 | 5057 | ||
| 5043 | /* sync mute LED */ | 5058 | /* sync mute LED */ |
| 5044 | if (spec->gpio_led) { | 5059 | if (spec->vref_mute_led_nid) |
| 5045 | if (spec->gpio_led <= 8) { | 5060 | stac_vrefout_set(codec, spec->vref_mute_led_nid, |
| 5046 | stac_gpio_set(codec, spec->gpio_mask, | 5061 | spec->vref_led); |
| 5047 | spec->gpio_dir, spec->gpio_data); | 5062 | else if (spec->gpio_led) |
| 5048 | } else { | 5063 | stac_gpio_set(codec, spec->gpio_mask, |
| 5049 | stac_vrefout_set(codec, | 5064 | spec->gpio_dir, spec->gpio_data); |
| 5050 | spec->gpio_led, spec->vref_led); | ||
| 5051 | } | ||
| 5052 | } | ||
| 5053 | return 0; | ||
| 5054 | } | ||
| 5055 | |||
| 5056 | static int stac92xx_post_suspend(struct hda_codec *codec) | ||
| 5057 | { | ||
| 5058 | struct sigmatel_spec *spec = codec->spec; | ||
| 5059 | if (spec->gpio_led > 8) { | ||
| 5060 | /* with vref-out pin used for mute led control | ||
| 5061 | * codec AFG is prevented from D3 state, but on | ||
| 5062 | * system suspend it can (and should) be used | ||
| 5063 | */ | ||
| 5064 | snd_hda_codec_read(codec, codec->afg, 0, | ||
| 5065 | AC_VERB_SET_POWER_STATE, AC_PWRST_D3); | ||
| 5066 | } | ||
| 5067 | return 0; | 5065 | return 0; |
| 5068 | } | 5066 | } |
| 5069 | 5067 | ||
| @@ -5074,7 +5072,7 @@ static void stac92xx_set_power_state(struct hda_codec *codec, hda_nid_t fg, | |||
| 5074 | struct sigmatel_spec *spec = codec->spec; | 5072 | struct sigmatel_spec *spec = codec->spec; |
| 5075 | 5073 | ||
| 5076 | if (power_state == AC_PWRST_D3) { | 5074 | if (power_state == AC_PWRST_D3) { |
| 5077 | if (spec->gpio_led > 8) { | 5075 | if (spec->vref_mute_led_nid) { |
| 5078 | /* with vref-out pin used for mute led control | 5076 | /* with vref-out pin used for mute led control |
| 5079 | * codec AFG is prevented from D3 state | 5077 | * codec AFG is prevented from D3 state |
| 5080 | */ | 5078 | */ |
| @@ -5127,7 +5125,7 @@ static int stac92xx_update_led_status(struct hda_codec *codec) | |||
| 5127 | } | 5125 | } |
| 5128 | } | 5126 | } |
| 5129 | /*polarity defines *not* muted state level*/ | 5127 | /*polarity defines *not* muted state level*/ |
| 5130 | if (spec->gpio_led <= 8) { | 5128 | if (!spec->vref_mute_led_nid) { |
| 5131 | if (muted) | 5129 | if (muted) |
| 5132 | spec->gpio_data &= ~spec->gpio_led; /* orange */ | 5130 | spec->gpio_data &= ~spec->gpio_led; /* orange */ |
| 5133 | else | 5131 | else |
| @@ -5145,7 +5143,8 @@ static int stac92xx_update_led_status(struct hda_codec *codec) | |||
| 5145 | muted_lvl = spec->gpio_led_polarity ? | 5143 | muted_lvl = spec->gpio_led_polarity ? |
| 5146 | AC_PINCTL_VREF_GRD : AC_PINCTL_VREF_HIZ; | 5144 | AC_PINCTL_VREF_GRD : AC_PINCTL_VREF_HIZ; |
| 5147 | spec->vref_led = muted ? muted_lvl : notmtd_lvl; | 5145 | spec->vref_led = muted ? muted_lvl : notmtd_lvl; |
| 5148 | stac_vrefout_set(codec, spec->gpio_led, spec->vref_led); | 5146 | stac_vrefout_set(codec, spec->vref_mute_led_nid, |
| 5147 | spec->vref_led); | ||
| 5149 | } | 5148 | } |
| 5150 | return 0; | 5149 | return 0; |
| 5151 | } | 5150 | } |
| @@ -5659,15 +5658,13 @@ again: | |||
| 5659 | 5658 | ||
| 5660 | #ifdef CONFIG_SND_HDA_POWER_SAVE | 5659 | #ifdef CONFIG_SND_HDA_POWER_SAVE |
| 5661 | if (spec->gpio_led) { | 5660 | if (spec->gpio_led) { |
| 5662 | if (spec->gpio_led <= 8) { | 5661 | if (!spec->vref_mute_led_nid) { |
| 5663 | spec->gpio_mask |= spec->gpio_led; | 5662 | spec->gpio_mask |= spec->gpio_led; |
| 5664 | spec->gpio_dir |= spec->gpio_led; | 5663 | spec->gpio_dir |= spec->gpio_led; |
| 5665 | spec->gpio_data |= spec->gpio_led; | 5664 | spec->gpio_data |= spec->gpio_led; |
| 5666 | } else { | 5665 | } else { |
| 5667 | codec->patch_ops.set_power_state = | 5666 | codec->patch_ops.set_power_state = |
| 5668 | stac92xx_set_power_state; | 5667 | stac92xx_set_power_state; |
| 5669 | codec->patch_ops.post_suspend = | ||
| 5670 | stac92xx_post_suspend; | ||
| 5671 | } | 5668 | } |
| 5672 | codec->patch_ops.pre_resume = stac92xx_pre_resume; | 5669 | codec->patch_ops.pre_resume = stac92xx_pre_resume; |
| 5673 | codec->patch_ops.check_power_status = | 5670 | codec->patch_ops.check_power_status = |
| @@ -5974,15 +5971,13 @@ again: | |||
| 5974 | 5971 | ||
| 5975 | #ifdef CONFIG_SND_HDA_POWER_SAVE | 5972 | #ifdef CONFIG_SND_HDA_POWER_SAVE |
| 5976 | if (spec->gpio_led) { | 5973 | if (spec->gpio_led) { |
| 5977 | if (spec->gpio_led <= 8) { | 5974 | if (!spec->vref_mute_led_nid) { |
| 5978 | spec->gpio_mask |= spec->gpio_led; | 5975 | spec->gpio_mask |= spec->gpio_led; |
| 5979 | spec->gpio_dir |= spec->gpio_led; | 5976 | spec->gpio_dir |= spec->gpio_led; |
| 5980 | spec->gpio_data |= spec->gpio_led; | 5977 | spec->gpio_data |= spec->gpio_led; |
| 5981 | } else { | 5978 | } else { |
| 5982 | codec->patch_ops.set_power_state = | 5979 | codec->patch_ops.set_power_state = |
| 5983 | stac92xx_set_power_state; | 5980 | stac92xx_set_power_state; |
| 5984 | codec->patch_ops.post_suspend = | ||
| 5985 | stac92xx_post_suspend; | ||
| 5986 | } | 5981 | } |
| 5987 | codec->patch_ops.pre_resume = stac92xx_pre_resume; | 5982 | codec->patch_ops.pre_resume = stac92xx_pre_resume; |
| 5988 | codec->patch_ops.check_power_status = | 5983 | codec->patch_ops.check_power_status = |
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c index 431c0d417eeb..b5137629f8e9 100644 --- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c | |||
| @@ -208,6 +208,7 @@ struct via_spec { | |||
| 208 | /* work to check hp jack state */ | 208 | /* work to check hp jack state */ |
| 209 | struct hda_codec *codec; | 209 | struct hda_codec *codec; |
| 210 | struct delayed_work vt1708_hp_work; | 210 | struct delayed_work vt1708_hp_work; |
| 211 | int hp_work_active; | ||
| 211 | int vt1708_jack_detect; | 212 | int vt1708_jack_detect; |
| 212 | int vt1708_hp_present; | 213 | int vt1708_hp_present; |
| 213 | 214 | ||
| @@ -305,27 +306,35 @@ enum { | |||
| 305 | static void analog_low_current_mode(struct hda_codec *codec); | 306 | static void analog_low_current_mode(struct hda_codec *codec); |
| 306 | static bool is_aa_path_mute(struct hda_codec *codec); | 307 | static bool is_aa_path_mute(struct hda_codec *codec); |
| 307 | 308 | ||
| 308 | static void vt1708_start_hp_work(struct via_spec *spec) | 309 | #define hp_detect_with_aa(codec) \ |
| 310 | (snd_hda_get_bool_hint(codec, "analog_loopback_hp_detect") == 1 && \ | ||
| 311 | !is_aa_path_mute(codec)) | ||
| 312 | |||
| 313 | static void vt1708_stop_hp_work(struct via_spec *spec) | ||
| 309 | { | 314 | { |
| 310 | if (spec->codec_type != VT1708 || spec->autocfg.hp_pins[0] == 0) | 315 | if (spec->codec_type != VT1708 || spec->autocfg.hp_pins[0] == 0) |
| 311 | return; | 316 | return; |
| 312 | snd_hda_codec_write(spec->codec, 0x1, 0, 0xf81, | 317 | if (spec->hp_work_active) { |
| 313 | !spec->vt1708_jack_detect); | 318 | snd_hda_codec_write(spec->codec, 0x1, 0, 0xf81, 1); |
| 314 | if (!delayed_work_pending(&spec->vt1708_hp_work)) | 319 | cancel_delayed_work_sync(&spec->vt1708_hp_work); |
| 315 | schedule_delayed_work(&spec->vt1708_hp_work, | 320 | spec->hp_work_active = 0; |
| 316 | msecs_to_jiffies(100)); | 321 | } |
| 317 | } | 322 | } |
| 318 | 323 | ||
| 319 | static void vt1708_stop_hp_work(struct via_spec *spec) | 324 | static void vt1708_update_hp_work(struct via_spec *spec) |
| 320 | { | 325 | { |
| 321 | if (spec->codec_type != VT1708 || spec->autocfg.hp_pins[0] == 0) | 326 | if (spec->codec_type != VT1708 || spec->autocfg.hp_pins[0] == 0) |
| 322 | return; | 327 | return; |
| 323 | if (snd_hda_get_bool_hint(spec->codec, "analog_loopback_hp_detect") == 1 | 328 | if (spec->vt1708_jack_detect && |
| 324 | && !is_aa_path_mute(spec->codec)) | 329 | (spec->active_streams || hp_detect_with_aa(spec->codec))) { |
| 325 | return; | 330 | if (!spec->hp_work_active) { |
| 326 | snd_hda_codec_write(spec->codec, 0x1, 0, 0xf81, | 331 | snd_hda_codec_write(spec->codec, 0x1, 0, 0xf81, 0); |
| 327 | !spec->vt1708_jack_detect); | 332 | schedule_delayed_work(&spec->vt1708_hp_work, |
| 328 | cancel_delayed_work_sync(&spec->vt1708_hp_work); | 333 | msecs_to_jiffies(100)); |
| 334 | spec->hp_work_active = 1; | ||
| 335 | } | ||
| 336 | } else if (!hp_detect_with_aa(spec->codec)) | ||
| 337 | vt1708_stop_hp_work(spec); | ||
| 329 | } | 338 | } |
| 330 | 339 | ||
| 331 | static void set_widgets_power_state(struct hda_codec *codec) | 340 | static void set_widgets_power_state(struct hda_codec *codec) |
| @@ -343,12 +352,7 @@ static int analog_input_switch_put(struct snd_kcontrol *kcontrol, | |||
| 343 | 352 | ||
| 344 | set_widgets_power_state(codec); | 353 | set_widgets_power_state(codec); |
| 345 | analog_low_current_mode(snd_kcontrol_chip(kcontrol)); | 354 | analog_low_current_mode(snd_kcontrol_chip(kcontrol)); |
| 346 | if (snd_hda_get_bool_hint(codec, "analog_loopback_hp_detect") == 1) { | 355 | vt1708_update_hp_work(codec->spec); |
| 347 | if (is_aa_path_mute(codec)) | ||
| 348 | vt1708_start_hp_work(codec->spec); | ||
| 349 | else | ||
| 350 | vt1708_stop_hp_work(codec->spec); | ||
| 351 | } | ||
| 352 | return change; | 356 | return change; |
| 353 | } | 357 | } |
| 354 | 358 | ||
| @@ -1154,7 +1158,7 @@ static int via_playback_multi_pcm_prepare(struct hda_pcm_stream *hinfo, | |||
| 1154 | spec->cur_dac_stream_tag = stream_tag; | 1158 | spec->cur_dac_stream_tag = stream_tag; |
| 1155 | spec->cur_dac_format = format; | 1159 | spec->cur_dac_format = format; |
| 1156 | mutex_unlock(&spec->config_mutex); | 1160 | mutex_unlock(&spec->config_mutex); |
| 1157 | vt1708_start_hp_work(spec); | 1161 | vt1708_update_hp_work(spec); |
| 1158 | return 0; | 1162 | return 0; |
| 1159 | } | 1163 | } |
| 1160 | 1164 | ||
| @@ -1174,7 +1178,7 @@ static int via_playback_hp_pcm_prepare(struct hda_pcm_stream *hinfo, | |||
| 1174 | spec->cur_hp_stream_tag = stream_tag; | 1178 | spec->cur_hp_stream_tag = stream_tag; |
| 1175 | spec->cur_hp_format = format; | 1179 | spec->cur_hp_format = format; |
| 1176 | mutex_unlock(&spec->config_mutex); | 1180 | mutex_unlock(&spec->config_mutex); |
| 1177 | vt1708_start_hp_work(spec); | 1181 | vt1708_update_hp_work(spec); |
| 1178 | return 0; | 1182 | return 0; |
| 1179 | } | 1183 | } |
| 1180 | 1184 | ||
| @@ -1188,7 +1192,7 @@ static int via_playback_multi_pcm_cleanup(struct hda_pcm_stream *hinfo, | |||
| 1188 | snd_hda_multi_out_analog_cleanup(codec, &spec->multiout); | 1192 | snd_hda_multi_out_analog_cleanup(codec, &spec->multiout); |
| 1189 | spec->active_streams &= ~STREAM_MULTI_OUT; | 1193 | spec->active_streams &= ~STREAM_MULTI_OUT; |
| 1190 | mutex_unlock(&spec->config_mutex); | 1194 | mutex_unlock(&spec->config_mutex); |
| 1191 | vt1708_stop_hp_work(spec); | 1195 | vt1708_update_hp_work(spec); |
| 1192 | return 0; | 1196 | return 0; |
| 1193 | } | 1197 | } |
| 1194 | 1198 | ||
| @@ -1203,7 +1207,7 @@ static int via_playback_hp_pcm_cleanup(struct hda_pcm_stream *hinfo, | |||
| 1203 | snd_hda_codec_setup_stream(codec, spec->hp_dac_nid, 0, 0, 0); | 1207 | snd_hda_codec_setup_stream(codec, spec->hp_dac_nid, 0, 0, 0); |
| 1204 | spec->active_streams &= ~STREAM_INDEP_HP; | 1208 | spec->active_streams &= ~STREAM_INDEP_HP; |
| 1205 | mutex_unlock(&spec->config_mutex); | 1209 | mutex_unlock(&spec->config_mutex); |
| 1206 | vt1708_stop_hp_work(spec); | 1210 | vt1708_update_hp_work(spec); |
| 1207 | return 0; | 1211 | return 0; |
| 1208 | } | 1212 | } |
| 1209 | 1213 | ||
| @@ -1645,7 +1649,8 @@ static void via_hp_automute(struct hda_codec *codec) | |||
| 1645 | int nums; | 1649 | int nums; |
| 1646 | struct via_spec *spec = codec->spec; | 1650 | struct via_spec *spec = codec->spec; |
| 1647 | 1651 | ||
| 1648 | if (!spec->hp_independent_mode && spec->autocfg.hp_pins[0]) | 1652 | if (!spec->hp_independent_mode && spec->autocfg.hp_pins[0] && |
| 1653 | (spec->codec_type != VT1708 || spec->vt1708_jack_detect)) | ||
| 1649 | present = snd_hda_jack_detect(codec, spec->autocfg.hp_pins[0]); | 1654 | present = snd_hda_jack_detect(codec, spec->autocfg.hp_pins[0]); |
| 1650 | 1655 | ||
| 1651 | if (spec->smart51_enabled) | 1656 | if (spec->smart51_enabled) |
| @@ -2612,8 +2617,6 @@ static int vt1708_jack_detect_get(struct snd_kcontrol *kcontrol, | |||
| 2612 | 2617 | ||
| 2613 | if (spec->codec_type != VT1708) | 2618 | if (spec->codec_type != VT1708) |
| 2614 | return 0; | 2619 | return 0; |
| 2615 | spec->vt1708_jack_detect = | ||
| 2616 | !((snd_hda_codec_read(codec, 0x1, 0, 0xf84, 0) >> 8) & 0x1); | ||
| 2617 | ucontrol->value.integer.value[0] = spec->vt1708_jack_detect; | 2620 | ucontrol->value.integer.value[0] = spec->vt1708_jack_detect; |
| 2618 | return 0; | 2621 | return 0; |
| 2619 | } | 2622 | } |
| @@ -2623,18 +2626,22 @@ static int vt1708_jack_detect_put(struct snd_kcontrol *kcontrol, | |||
| 2623 | { | 2626 | { |
| 2624 | struct hda_codec *codec = snd_kcontrol_chip(kcontrol); | 2627 | struct hda_codec *codec = snd_kcontrol_chip(kcontrol); |
| 2625 | struct via_spec *spec = codec->spec; | 2628 | struct via_spec *spec = codec->spec; |
| 2626 | int change; | 2629 | int val; |
| 2627 | 2630 | ||
| 2628 | if (spec->codec_type != VT1708) | 2631 | if (spec->codec_type != VT1708) |
| 2629 | return 0; | 2632 | return 0; |
| 2630 | spec->vt1708_jack_detect = ucontrol->value.integer.value[0]; | 2633 | val = !!ucontrol->value.integer.value[0]; |
| 2631 | change = (0x1 & (snd_hda_codec_read(codec, 0x1, 0, 0xf84, 0) >> 8)) | 2634 | if (spec->vt1708_jack_detect == val) |
| 2632 | == !spec->vt1708_jack_detect; | 2635 | return 0; |
| 2633 | if (spec->vt1708_jack_detect) { | 2636 | spec->vt1708_jack_detect = val; |
| 2637 | if (spec->vt1708_jack_detect && | ||
| 2638 | snd_hda_get_bool_hint(codec, "analog_loopback_hp_detect") != 1) { | ||
| 2634 | mute_aa_path(codec, 1); | 2639 | mute_aa_path(codec, 1); |
| 2635 | notify_aa_path_ctls(codec); | 2640 | notify_aa_path_ctls(codec); |
| 2636 | } | 2641 | } |
| 2637 | return change; | 2642 | via_hp_automute(codec); |
| 2643 | vt1708_update_hp_work(spec); | ||
| 2644 | return 1; | ||
| 2638 | } | 2645 | } |
| 2639 | 2646 | ||
| 2640 | static const struct snd_kcontrol_new vt1708_jack_detect_ctl = { | 2647 | static const struct snd_kcontrol_new vt1708_jack_detect_ctl = { |
| @@ -2771,6 +2778,7 @@ static int via_init(struct hda_codec *codec) | |||
| 2771 | via_auto_init_unsol_event(codec); | 2778 | via_auto_init_unsol_event(codec); |
| 2772 | 2779 | ||
| 2773 | via_hp_automute(codec); | 2780 | via_hp_automute(codec); |
| 2781 | vt1708_update_hp_work(spec); | ||
| 2774 | 2782 | ||
| 2775 | return 0; | 2783 | return 0; |
| 2776 | } | 2784 | } |
| @@ -2787,7 +2795,9 @@ static void vt1708_update_hp_jack_state(struct work_struct *work) | |||
| 2787 | spec->vt1708_hp_present ^= 1; | 2795 | spec->vt1708_hp_present ^= 1; |
| 2788 | via_hp_automute(spec->codec); | 2796 | via_hp_automute(spec->codec); |
| 2789 | } | 2797 | } |
| 2790 | vt1708_start_hp_work(spec); | 2798 | if (spec->vt1708_jack_detect) |
| 2799 | schedule_delayed_work(&spec->vt1708_hp_work, | ||
| 2800 | msecs_to_jiffies(100)); | ||
| 2791 | } | 2801 | } |
| 2792 | 2802 | ||
| 2793 | static int get_mux_nids(struct hda_codec *codec) | 2803 | static int get_mux_nids(struct hda_codec *codec) |
diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c index 5c8717e29eeb..8c3e7fcefd99 100644 --- a/sound/pci/lx6464es/lx_core.c +++ b/sound/pci/lx6464es/lx_core.c | |||
| @@ -78,10 +78,15 @@ unsigned long lx_dsp_reg_read(struct lx6464es *chip, int port) | |||
| 78 | return ioread32(address); | 78 | return ioread32(address); |
| 79 | } | 79 | } |
| 80 | 80 | ||
| 81 | void lx_dsp_reg_readbuf(struct lx6464es *chip, int port, u32 *data, u32 len) | 81 | static void lx_dsp_reg_readbuf(struct lx6464es *chip, int port, u32 *data, |
| 82 | u32 len) | ||
| 82 | { | 83 | { |
| 83 | void __iomem *address = lx_dsp_register(chip, port); | 84 | u32 __iomem *address = lx_dsp_register(chip, port); |
| 84 | memcpy_fromio(data, address, len*sizeof(u32)); | 85 | int i; |
| 86 | |||
| 87 | /* we cannot use memcpy_fromio */ | ||
| 88 | for (i = 0; i != len; ++i) | ||
| 89 | data[i] = ioread32(address + i); | ||
| 85 | } | 90 | } |
| 86 | 91 | ||
| 87 | 92 | ||
| @@ -91,11 +96,15 @@ void lx_dsp_reg_write(struct lx6464es *chip, int port, unsigned data) | |||
| 91 | iowrite32(data, address); | 96 | iowrite32(data, address); |
| 92 | } | 97 | } |
| 93 | 98 | ||
| 94 | void lx_dsp_reg_writebuf(struct lx6464es *chip, int port, const u32 *data, | 99 | static void lx_dsp_reg_writebuf(struct lx6464es *chip, int port, |
| 95 | u32 len) | 100 | const u32 *data, u32 len) |
| 96 | { | 101 | { |
| 97 | void __iomem *address = lx_dsp_register(chip, port); | 102 | u32 __iomem *address = lx_dsp_register(chip, port); |
| 98 | memcpy_toio(address, data, len*sizeof(u32)); | 103 | int i; |
| 104 | |||
| 105 | /* we cannot use memcpy_to */ | ||
| 106 | for (i = 0; i != len; ++i) | ||
| 107 | iowrite32(data[i], address + i); | ||
| 99 | } | 108 | } |
| 100 | 109 | ||
| 101 | 110 | ||
diff --git a/sound/pci/lx6464es/lx_core.h b/sound/pci/lx6464es/lx_core.h index 1dd562980b6c..4d7ff797a646 100644 --- a/sound/pci/lx6464es/lx_core.h +++ b/sound/pci/lx6464es/lx_core.h | |||
| @@ -72,10 +72,7 @@ enum { | |||
| 72 | }; | 72 | }; |
| 73 | 73 | ||
| 74 | unsigned long lx_dsp_reg_read(struct lx6464es *chip, int port); | 74 | unsigned long lx_dsp_reg_read(struct lx6464es *chip, int port); |
| 75 | void lx_dsp_reg_readbuf(struct lx6464es *chip, int port, u32 *data, u32 len); | ||
| 76 | void lx_dsp_reg_write(struct lx6464es *chip, int port, unsigned data); | 75 | void lx_dsp_reg_write(struct lx6464es *chip, int port, unsigned data); |
| 77 | void lx_dsp_reg_writebuf(struct lx6464es *chip, int port, const u32 *data, | ||
| 78 | u32 len); | ||
| 79 | 76 | ||
| 80 | /* plx register access */ | 77 | /* plx register access */ |
| 81 | enum { | 78 | enum { |
diff --git a/sound/pci/rme9652/hdspm.c b/sound/pci/rme9652/hdspm.c index e760adad9523..19ee2203cbb5 100644 --- a/sound/pci/rme9652/hdspm.c +++ b/sound/pci/rme9652/hdspm.c | |||
| @@ -6518,7 +6518,7 @@ static int __devinit snd_hdspm_create(struct snd_card *card, | |||
| 6518 | hdspm->io_type = AES32; | 6518 | hdspm->io_type = AES32; |
| 6519 | hdspm->card_name = "RME AES32"; | 6519 | hdspm->card_name = "RME AES32"; |
| 6520 | hdspm->midiPorts = 2; | 6520 | hdspm->midiPorts = 2; |
| 6521 | } else if ((hdspm->firmware_rev == 0xd5) || | 6521 | } else if ((hdspm->firmware_rev == 0xd2) || |
| 6522 | ((hdspm->firmware_rev >= 0xc8) && | 6522 | ((hdspm->firmware_rev >= 0xc8) && |
| 6523 | (hdspm->firmware_rev <= 0xcf))) { | 6523 | (hdspm->firmware_rev <= 0xcf))) { |
| 6524 | hdspm->io_type = MADI; | 6524 | hdspm->io_type = MADI; |
diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c index a391e622a192..28dfafb56dd1 100644 --- a/sound/pci/sis7019.c +++ b/sound/pci/sis7019.c | |||
| @@ -41,6 +41,7 @@ MODULE_SUPPORTED_DEVICE("{{SiS,SiS7019 Audio Accelerator}}"); | |||
| 41 | static int index = SNDRV_DEFAULT_IDX1; /* Index 0-MAX */ | 41 | static int index = SNDRV_DEFAULT_IDX1; /* Index 0-MAX */ |
| 42 | static char *id = SNDRV_DEFAULT_STR1; /* ID for this card */ | 42 | static char *id = SNDRV_DEFAULT_STR1; /* ID for this card */ |
| 43 | static int enable = 1; | 43 | static int enable = 1; |
| 44 | static int codecs = 1; | ||
| 44 | 45 | ||
| 45 | module_param(index, int, 0444); | 46 | module_param(index, int, 0444); |
| 46 | MODULE_PARM_DESC(index, "Index value for SiS7019 Audio Accelerator."); | 47 | MODULE_PARM_DESC(index, "Index value for SiS7019 Audio Accelerator."); |
| @@ -48,6 +49,8 @@ module_param(id, charp, 0444); | |||
| 48 | MODULE_PARM_DESC(id, "ID string for SiS7019 Audio Accelerator."); | 49 | MODULE_PARM_DESC(id, "ID string for SiS7019 Audio Accelerator."); |
| 49 | module_param(enable, bool, 0444); | 50 | module_param(enable, bool, 0444); |
| 50 | MODULE_PARM_DESC(enable, "Enable SiS7019 Audio Accelerator."); | 51 | MODULE_PARM_DESC(enable, "Enable SiS7019 Audio Accelerator."); |
| 52 | module_param(codecs, int, 0444); | ||
| 53 | MODULE_PARM_DESC(codecs, "Set bit to indicate that codec number is expected to be present (default 1)"); | ||
| 51 | 54 | ||
| 52 | static DEFINE_PCI_DEVICE_TABLE(snd_sis7019_ids) = { | 55 | static DEFINE_PCI_DEVICE_TABLE(snd_sis7019_ids) = { |
| 53 | { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x7019) }, | 56 | { PCI_DEVICE(PCI_VENDOR_ID_SI, 0x7019) }, |
| @@ -140,6 +143,9 @@ struct sis7019 { | |||
| 140 | dma_addr_t silence_dma_addr; | 143 | dma_addr_t silence_dma_addr; |
| 141 | }; | 144 | }; |
| 142 | 145 | ||
| 146 | /* These values are also used by the module param 'codecs' to indicate | ||
| 147 | * which codecs should be present. | ||
| 148 | */ | ||
| 143 | #define SIS_PRIMARY_CODEC_PRESENT 0x0001 | 149 | #define SIS_PRIMARY_CODEC_PRESENT 0x0001 |
| 144 | #define SIS_SECONDARY_CODEC_PRESENT 0x0002 | 150 | #define SIS_SECONDARY_CODEC_PRESENT 0x0002 |
| 145 | #define SIS_TERTIARY_CODEC_PRESENT 0x0004 | 151 | #define SIS_TERTIARY_CODEC_PRESENT 0x0004 |
| @@ -1078,6 +1084,7 @@ static int sis_chip_init(struct sis7019 *sis) | |||
| 1078 | { | 1084 | { |
| 1079 | unsigned long io = sis->ioport; | 1085 | unsigned long io = sis->ioport; |
| 1080 | void __iomem *ioaddr = sis->ioaddr; | 1086 | void __iomem *ioaddr = sis->ioaddr; |
| 1087 | unsigned long timeout; | ||
| 1081 | u16 status; | 1088 | u16 status; |
| 1082 | int count; | 1089 | int count; |
| 1083 | int i; | 1090 | int i; |
| @@ -1104,21 +1111,45 @@ static int sis_chip_init(struct sis7019 *sis) | |||
| 1104 | while ((inw(io + SIS_AC97_STATUS) & SIS_AC97_STATUS_BUSY) && --count) | 1111 | while ((inw(io + SIS_AC97_STATUS) & SIS_AC97_STATUS_BUSY) && --count) |
| 1105 | udelay(1); | 1112 | udelay(1); |
| 1106 | 1113 | ||
| 1114 | /* Command complete, we can let go of the semaphore now. | ||
| 1115 | */ | ||
| 1116 | outl(SIS_AC97_SEMA_RELEASE, io + SIS_AC97_SEMA); | ||
| 1117 | if (!count) | ||
| 1118 | return -EIO; | ||
| 1119 | |||
| 1107 | /* Now that we've finished the reset, find out what's attached. | 1120 | /* Now that we've finished the reset, find out what's attached. |
| 1121 | * There are some codec/board combinations that take an extremely | ||
| 1122 | * long time to come up. 350+ ms has been observed in the field, | ||
| 1123 | * so we'll give them up to 500ms. | ||
| 1108 | */ | 1124 | */ |
| 1109 | status = inl(io + SIS_AC97_STATUS); | 1125 | sis->codecs_present = 0; |
| 1110 | if (status & SIS_AC97_STATUS_CODEC_READY) | 1126 | timeout = msecs_to_jiffies(500) + jiffies; |
| 1111 | sis->codecs_present |= SIS_PRIMARY_CODEC_PRESENT; | 1127 | while (time_before_eq(jiffies, timeout)) { |
| 1112 | if (status & SIS_AC97_STATUS_CODEC2_READY) | 1128 | status = inl(io + SIS_AC97_STATUS); |
| 1113 | sis->codecs_present |= SIS_SECONDARY_CODEC_PRESENT; | 1129 | if (status & SIS_AC97_STATUS_CODEC_READY) |
| 1114 | if (status & SIS_AC97_STATUS_CODEC3_READY) | 1130 | sis->codecs_present |= SIS_PRIMARY_CODEC_PRESENT; |
| 1115 | sis->codecs_present |= SIS_TERTIARY_CODEC_PRESENT; | 1131 | if (status & SIS_AC97_STATUS_CODEC2_READY) |
| 1116 | 1132 | sis->codecs_present |= SIS_SECONDARY_CODEC_PRESENT; | |
| 1117 | /* All done, let go of the semaphore, and check for errors | 1133 | if (status & SIS_AC97_STATUS_CODEC3_READY) |
| 1134 | sis->codecs_present |= SIS_TERTIARY_CODEC_PRESENT; | ||
| 1135 | |||
| 1136 | if (sis->codecs_present == codecs) | ||
| 1137 | break; | ||
| 1138 | |||
| 1139 | msleep(1); | ||
| 1140 | } | ||
| 1141 | |||
| 1142 | /* All done, check for errors. | ||
| 1118 | */ | 1143 | */ |
| 1119 | outl(SIS_AC97_SEMA_RELEASE, io + SIS_AC97_SEMA); | 1144 | if (!sis->codecs_present) { |
| 1120 | if (!sis->codecs_present || !count) | 1145 | printk(KERN_ERR "sis7019: could not find any codecs\n"); |
| 1121 | return -EIO; | 1146 | return -EIO; |
| 1147 | } | ||
| 1148 | |||
| 1149 | if (sis->codecs_present != codecs) { | ||
| 1150 | printk(KERN_WARNING "sis7019: missing codecs, found %0x, expected %0x\n", | ||
| 1151 | sis->codecs_present, codecs); | ||
| 1152 | } | ||
| 1122 | 1153 | ||
| 1123 | /* Let the hardware know that the audio driver is alive, | 1154 | /* Let the hardware know that the audio driver is alive, |
| 1124 | * and enable PCM slots on the AC-link for L/R playback (3 & 4) and | 1155 | * and enable PCM slots on the AC-link for L/R playback (3 & 4) and |
| @@ -1390,6 +1421,17 @@ static int __devinit snd_sis7019_probe(struct pci_dev *pci, | |||
| 1390 | if (!enable) | 1421 | if (!enable) |
| 1391 | goto error_out; | 1422 | goto error_out; |
| 1392 | 1423 | ||
| 1424 | /* The user can specify which codecs should be present so that we | ||
| 1425 | * can wait for them to show up if they are slow to recover from | ||
| 1426 | * the AC97 cold reset. We default to a single codec, the primary. | ||
| 1427 | * | ||
| 1428 | * We assume that SIS_PRIMARY_*_PRESENT matches bits 0-2. | ||
| 1429 | */ | ||
| 1430 | codecs &= SIS_PRIMARY_CODEC_PRESENT | SIS_SECONDARY_CODEC_PRESENT | | ||
| 1431 | SIS_TERTIARY_CODEC_PRESENT; | ||
| 1432 | if (!codecs) | ||
| 1433 | codecs = SIS_PRIMARY_CODEC_PRESENT; | ||
| 1434 | |||
| 1393 | rc = snd_card_create(index, id, THIS_MODULE, sizeof(*sis), &card); | 1435 | rc = snd_card_create(index, id, THIS_MODULE, sizeof(*sis), &card); |
| 1394 | if (rc < 0) | 1436 | if (rc < 0) |
| 1395 | goto error_out; | 1437 | goto error_out; |
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig index bee3c94f58b0..d1fcc816ce97 100644 --- a/sound/soc/atmel/Kconfig +++ b/sound/soc/atmel/Kconfig | |||
| @@ -1,6 +1,6 @@ | |||
| 1 | config SND_ATMEL_SOC | 1 | config SND_ATMEL_SOC |
| 2 | tristate "SoC Audio for the Atmel System-on-Chip" | 2 | tristate "SoC Audio for the Atmel System-on-Chip" |
| 3 | depends on ARCH_AT91 || AVR32 | 3 | depends on ARCH_AT91 |
| 4 | help | 4 | help |
| 5 | Say Y or M if you want to add support for codecs attached to | 5 | Say Y or M if you want to add support for codecs attached to |
| 6 | the ATMEL SSC interface. You will also need | 6 | the ATMEL SSC interface. You will also need |
| @@ -24,25 +24,6 @@ config SND_AT91_SOC_SAM9G20_WM8731 | |||
| 24 | Say Y if you want to add support for SoC audio on WM8731-based | 24 | Say Y if you want to add support for SoC audio on WM8731-based |
| 25 | AT91sam9g20 evaluation board. | 25 | AT91sam9g20 evaluation board. |
| 26 | 26 | ||
| 27 | config SND_AT32_SOC_PLAYPAQ | ||
| 28 | tristate "SoC Audio support for PlayPaq with WM8510" | ||
| 29 | depends on SND_ATMEL_SOC && BOARD_PLAYPAQ && AT91_PROGRAMMABLE_CLOCKS | ||
| 30 | select SND_ATMEL_SOC_SSC | ||
| 31 | select SND_SOC_WM8510 | ||
| 32 | help | ||
| 33 | Say Y or M here if you want to add support for SoC audio | ||
| 34 | on the LRS PlayPaq. | ||
| 35 | |||
| 36 | config SND_AT32_SOC_PLAYPAQ_SLAVE | ||
| 37 | bool "Run CODEC on PlayPaq in slave mode" | ||
| 38 | depends on SND_AT32_SOC_PLAYPAQ | ||
| 39 | default n | ||
| 40 | help | ||
| 41 | Say Y if you want to run with the AT32 SSC generating the BCLK | ||
| 42 | and FRAME signals on the PlayPaq. Unless you want to play | ||
| 43 | with the AT32 as the SSC master, you probably want to say N here, | ||
| 44 | as this will give you better sound quality. | ||
| 45 | |||
| 46 | config SND_AT91_SOC_AFEB9260 | 27 | config SND_AT91_SOC_AFEB9260 |
| 47 | tristate "SoC Audio support for AFEB9260 board" | 28 | tristate "SoC Audio support for AFEB9260 board" |
| 48 | depends on ARCH_AT91 && MACH_AFEB9260 && SND_ATMEL_SOC | 29 | depends on ARCH_AT91 && MACH_AFEB9260 && SND_ATMEL_SOC |
diff --git a/sound/soc/atmel/Makefile b/sound/soc/atmel/Makefile index e7ea56bd5f82..a5c0bf19da78 100644 --- a/sound/soc/atmel/Makefile +++ b/sound/soc/atmel/Makefile | |||
| @@ -8,9 +8,5 @@ obj-$(CONFIG_SND_ATMEL_SOC_SSC) += snd-soc-atmel_ssc_dai.o | |||
| 8 | # AT91 Machine Support | 8 | # AT91 Machine Support |
| 9 | snd-soc-sam9g20-wm8731-objs := sam9g20_wm8731.o | 9 | snd-soc-sam9g20-wm8731-objs := sam9g20_wm8731.o |
| 10 | 10 | ||
| 11 | # AT32 Machine Support | ||
| 12 | snd-soc-playpaq-objs := playpaq_wm8510.o | ||
| 13 | |||
| 14 | obj-$(CONFIG_SND_AT91_SOC_SAM9G20_WM8731) += snd-soc-sam9g20-wm8731.o | 11 | obj-$(CONFIG_SND_AT91_SOC_SAM9G20_WM8731) += snd-soc-sam9g20-wm8731.o |
| 15 | obj-$(CONFIG_SND_AT32_SOC_PLAYPAQ) += snd-soc-playpaq.o | ||
| 16 | obj-$(CONFIG_SND_AT91_SOC_AFEB9260) += snd-soc-afeb9260.o | 12 | obj-$(CONFIG_SND_AT91_SOC_AFEB9260) += snd-soc-afeb9260.o |
diff --git a/sound/soc/atmel/playpaq_wm8510.c b/sound/soc/atmel/playpaq_wm8510.c deleted file mode 100644 index 73ae99ad4578..000000000000 --- a/sound/soc/atmel/playpaq_wm8510.c +++ /dev/null | |||
| @@ -1,473 +0,0 @@ | |||
| 1 | /* sound/soc/at32/playpaq_wm8510.c | ||
| 2 | * ASoC machine driver for PlayPaq using WM8510 codec | ||
| 3 | * | ||
| 4 | * Copyright (C) 2008 Long Range Systems | ||
| 5 | * Geoffrey Wossum <gwossum@acm.org> | ||
| 6 | * | ||
| 7 | * This program is free software; you can redistribute it and/or modify | ||
| 8 | * it under the terms of the GNU General Public License version 2 as | ||
| 9 | * published by the Free Software Foundation. | ||
| 10 | * | ||
| 11 | * This code is largely inspired by sound/soc/at91/eti_b1_wm8731.c | ||
| 12 | * | ||
| 13 | * NOTE: If you don't have the AT32 enhanced portmux configured (which | ||
| 14 | * isn't currently in the mainline or Atmel patched kernel), you will | ||
| 15 | * need to set the MCLK pin (PA30) to peripheral A in your board initialization | ||
| 16 | * code. Something like: | ||
| 17 | * at32_select_periph(GPIO_PIN_PA(30), GPIO_PERIPH_A, 0); | ||
| 18 | * | ||
| 19 | */ | ||
| 20 | |||
| 21 | /* #define DEBUG */ | ||
| 22 | |||
| 23 | #include <linux/module.h> | ||
| 24 | #include <linux/moduleparam.h> | ||
| 25 | #include <linux/kernel.h> | ||
| 26 | #include <linux/errno.h> | ||
| 27 | #include <linux/clk.h> | ||
| 28 | #include <linux/timer.h> | ||
| 29 | #include <linux/interrupt.h> | ||
| 30 | #include <linux/platform_device.h> | ||
| 31 | |||
| 32 | #include <sound/core.h> | ||
| 33 | #include <sound/pcm.h> | ||
| 34 | #include <sound/pcm_params.h> | ||
| 35 | #include <sound/soc.h> | ||
| 36 | |||
| 37 | #include <mach/at32ap700x.h> | ||
| 38 | #include <mach/portmux.h> | ||
| 39 | |||
| 40 | #include "../codecs/wm8510.h" | ||
| 41 | #include "atmel-pcm.h" | ||
| 42 | #include "atmel_ssc_dai.h" | ||
| 43 | |||
| 44 | |||
| 45 | /*-------------------------------------------------------------------------*\ | ||
| 46 | * constants | ||
| 47 | \*-------------------------------------------------------------------------*/ | ||
| 48 | #define MCLK_PIN GPIO_PIN_PA(30) | ||
| 49 | #define MCLK_PERIPH GPIO_PERIPH_A | ||
| 50 | |||
| 51 | |||
| 52 | /*-------------------------------------------------------------------------*\ | ||
| 53 | * data types | ||
| 54 | \*-------------------------------------------------------------------------*/ | ||
| 55 | /* SSC clocking data */ | ||
| 56 | struct ssc_clock_data { | ||
| 57 | /* CMR div */ | ||
| 58 | unsigned int cmr_div; | ||
| 59 | |||
| 60 | /* Frame period (as needed by xCMR.PERIOD) */ | ||
| 61 | unsigned int period; | ||
| 62 | |||
| 63 | /* The SSC clock rate these settings where calculated for */ | ||
| 64 | unsigned long ssc_rate; | ||
| 65 | }; | ||
| 66 | |||
| 67 | |||
| 68 | /*-------------------------------------------------------------------------*\ | ||
| 69 | * module data | ||
| 70 | \*-------------------------------------------------------------------------*/ | ||
| 71 | static struct clk *_gclk0; | ||
| 72 | static struct clk *_pll0; | ||
| 73 | |||
| 74 | #define CODEC_CLK (_gclk0) | ||
| 75 | |||
| 76 | |||
| 77 | /*-------------------------------------------------------------------------*\ | ||
| 78 | * Sound SOC operations | ||
| 79 | \*-------------------------------------------------------------------------*/ | ||
| 80 | #if defined CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE | ||
| 81 | static struct ssc_clock_data playpaq_wm8510_calc_ssc_clock( | ||
| 82 | struct snd_pcm_hw_params *params, | ||
| 83 | struct snd_soc_dai *cpu_dai) | ||
| 84 | { | ||
| 85 | struct at32_ssc_info *ssc_p = snd_soc_dai_get_drvdata(cpu_dai); | ||
| 86 | struct ssc_device *ssc = ssc_p->ssc; | ||
| 87 | struct ssc_clock_data cd; | ||
| 88 | unsigned int rate, width_bits, channels; | ||
| 89 | unsigned int bitrate, ssc_div; | ||
| 90 | unsigned actual_rate; | ||
| 91 | |||
| 92 | |||
| 93 | /* | ||
| 94 | * Figure out required bitrate | ||
| 95 | */ | ||
| 96 | rate = params_rate(params); | ||
| 97 | channels = params_channels(params); | ||
| 98 | width_bits = snd_pcm_format_physical_width(params_format(params)); | ||
| 99 | bitrate = rate * width_bits * channels; | ||
| 100 | |||
| 101 | |||
| 102 | /* | ||
| 103 | * Figure out required SSC divider and period for required bitrate | ||
| 104 | */ | ||
| 105 | cd.ssc_rate = clk_get_rate(ssc->clk); | ||
| 106 | ssc_div = cd.ssc_rate / bitrate; | ||
| 107 | cd.cmr_div = ssc_div / 2; | ||
| 108 | if (ssc_div & 1) { | ||
| 109 | /* round cmr_div up */ | ||
| 110 | cd.cmr_div++; | ||
| 111 | } | ||
| 112 | cd.period = width_bits - 1; | ||
| 113 | |||
| 114 | |||
| 115 | /* | ||
| 116 | * Find actual rate, compare to requested rate | ||
| 117 | */ | ||
| 118 | actual_rate = (cd.ssc_rate / (cd.cmr_div * 2)) / (2 * (cd.period + 1)); | ||
| 119 | pr_debug("playpaq_wm8510: Request rate = %u, actual rate = %u\n", | ||
| 120 | rate, actual_rate); | ||
| 121 | |||
| 122 | |||
| 123 | return cd; | ||
| 124 | } | ||
| 125 | #endif /* CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE */ | ||
| 126 | |||
| 127 | |||
| 128 | |||
| 129 | static int playpaq_wm8510_hw_params(struct snd_pcm_substream *substream, | ||
| 130 | struct snd_pcm_hw_params *params) | ||
| 131 | { | ||
| 132 | struct snd_soc_pcm_runtime *rtd = substream->private_data; | ||
| 133 | struct snd_soc_dai *codec_dai = rtd->codec_dai; | ||
| 134 | struct snd_soc_dai *cpu_dai = rtd->cpu_dai; | ||
| 135 | struct at32_ssc_info *ssc_p = snd_soc_dai_get_drvdata(cpu_dai); | ||
| 136 | struct ssc_device *ssc = ssc_p->ssc; | ||
| 137 | unsigned int pll_out = 0, bclk = 0, mclk_div = 0; | ||
| 138 | int ret; | ||
| 139 | |||
| 140 | |||
| 141 | /* Due to difficulties with getting the correct clocks from the AT32's | ||
| 142 | * PLL0, we're going to let the CODEC be in charge of all the clocks | ||
| 143 | */ | ||
| 144 | #if !defined CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE | ||
| 145 | const unsigned int fmt = (SND_SOC_DAIFMT_I2S | | ||
| 146 | SND_SOC_DAIFMT_NB_NF | | ||
| 147 | SND_SOC_DAIFMT_CBM_CFM); | ||
| 148 | #else | ||
| 149 | struct ssc_clock_data cd; | ||
| 150 | const unsigned int fmt = (SND_SOC_DAIFMT_I2S | | ||
| 151 | SND_SOC_DAIFMT_NB_NF | | ||
| 152 | SND_SOC_DAIFMT_CBS_CFS); | ||
| 153 | #endif | ||
| 154 | |||
| 155 | if (ssc == NULL) { | ||
| 156 | pr_warning("playpaq_wm8510_hw_params: ssc is NULL!\n"); | ||
| 157 | return -EINVAL; | ||
| 158 | } | ||
| 159 | |||
| 160 | |||
| 161 | /* | ||
| 162 | * Figure out PLL and BCLK dividers for WM8510 | ||
| 163 | */ | ||
| 164 | switch (params_rate(params)) { | ||
| 165 | case 48000: | ||
| 166 | pll_out = 24576000; | ||
| 167 | mclk_div = WM8510_MCLKDIV_2; | ||
| 168 | bclk = WM8510_BCLKDIV_8; | ||
| 169 | break; | ||
| 170 | |||
| 171 | case 44100: | ||
| 172 | pll_out = 22579200; | ||
| 173 | mclk_div = WM8510_MCLKDIV_2; | ||
| 174 | bclk = WM8510_BCLKDIV_8; | ||
| 175 | break; | ||
| 176 | |||
| 177 | case 22050: | ||
| 178 | pll_out = 22579200; | ||
| 179 | mclk_div = WM8510_MCLKDIV_4; | ||
| 180 | bclk = WM8510_BCLKDIV_8; | ||
| 181 | break; | ||
| 182 | |||
| 183 | case 16000: | ||
| 184 | pll_out = 24576000; | ||
| 185 | mclk_div = WM8510_MCLKDIV_6; | ||
| 186 | bclk = WM8510_BCLKDIV_8; | ||
| 187 | break; | ||
| 188 | |||
| 189 | case 11025: | ||
| 190 | pll_out = 22579200; | ||
| 191 | mclk_div = WM8510_MCLKDIV_8; | ||
| 192 | bclk = WM8510_BCLKDIV_8; | ||
| 193 | break; | ||
| 194 | |||
| 195 | case 8000: | ||
| 196 | pll_out = 24576000; | ||
| 197 | mclk_div = WM8510_MCLKDIV_12; | ||
| 198 | bclk = WM8510_BCLKDIV_8; | ||
| 199 | break; | ||
| 200 | |||
| 201 | default: | ||
| 202 | pr_warning("playpaq_wm8510: Unsupported sample rate %d\n", | ||
| 203 | params_rate(params)); | ||
| 204 | return -EINVAL; | ||
| 205 | } | ||
| 206 | |||
| 207 | |||
| 208 | /* | ||
| 209 | * set CPU and CODEC DAI configuration | ||
| 210 | */ | ||
| 211 | ret = snd_soc_dai_set_fmt(codec_dai, fmt); | ||
| 212 | if (ret < 0) { | ||
| 213 | pr_warning("playpaq_wm8510: " | ||
| 214 | "Failed to set CODEC DAI format (%d)\n", | ||
| 215 | ret); | ||
| 216 | return ret; | ||
| 217 | } | ||
| 218 | ret = snd_soc_dai_set_fmt(cpu_dai, fmt); | ||
| 219 | if (ret < 0) { | ||
| 220 | pr_warning("playpaq_wm8510: " | ||
| 221 | "Failed to set CPU DAI format (%d)\n", | ||
| 222 | ret); | ||
| 223 | return ret; | ||
| 224 | } | ||
| 225 | |||
| 226 | |||
| 227 | /* | ||
| 228 | * Set CPU clock configuration | ||
| 229 | */ | ||
| 230 | #if defined CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE | ||
| 231 | cd = playpaq_wm8510_calc_ssc_clock(params, cpu_dai); | ||
| 232 | pr_debug("playpaq_wm8510: cmr_div = %d, period = %d\n", | ||
| 233 | cd.cmr_div, cd.period); | ||
| 234 | ret = snd_soc_dai_set_clkdiv(cpu_dai, AT32_SSC_CMR_DIV, cd.cmr_div); | ||
| 235 | if (ret < 0) { | ||
| 236 | pr_warning("playpaq_wm8510: Failed to set CPU CMR_DIV (%d)\n", | ||
| 237 | ret); | ||
| 238 | return ret; | ||
| 239 | } | ||
| 240 | ret = snd_soc_dai_set_clkdiv(cpu_dai, AT32_SSC_TCMR_PERIOD, | ||
| 241 | cd.period); | ||
| 242 | if (ret < 0) { | ||
| 243 | pr_warning("playpaq_wm8510: " | ||
| 244 | "Failed to set CPU transmit period (%d)\n", | ||
| 245 | ret); | ||
| 246 | return ret; | ||
| 247 | } | ||
| 248 | #endif /* CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE */ | ||
| 249 | |||
| 250 | |||
| 251 | /* | ||
| 252 | * Set CODEC clock configuration | ||
| 253 | */ | ||
| 254 | pr_debug("playpaq_wm8510: " | ||
| 255 | "pll_in = %ld, pll_out = %u, bclk = %x, mclk = %x\n", | ||
| 256 | clk_get_rate(CODEC_CLK), pll_out, bclk, mclk_div); | ||
| 257 | |||
| 258 | |||
| 259 | #if !defined CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE | ||
| 260 | ret = snd_soc_dai_set_clkdiv(codec_dai, WM8510_BCLKDIV, bclk); | ||
| 261 | if (ret < 0) { | ||
| 262 | pr_warning | ||
| 263 | ("playpaq_wm8510: Failed to set CODEC DAI BCLKDIV (%d)\n", | ||
| 264 | ret); | ||
| 265 | return ret; | ||
| 266 | } | ||
| 267 | #endif /* CONFIG_SND_AT32_SOC_PLAYPAQ_SLAVE */ | ||
| 268 | |||
| 269 | |||
| 270 | ret = snd_soc_dai_set_pll(codec_dai, 0, 0, | ||
| 271 | clk_get_rate(CODEC_CLK), pll_out); | ||
| 272 | if (ret < 0) { | ||
| 273 | pr_warning("playpaq_wm8510: Failed to set CODEC DAI PLL (%d)\n", | ||
| 274 | ret); | ||
| 275 | return ret; | ||
| 276 | } | ||
| 277 | |||
| 278 | |||
| 279 | ret = snd_soc_dai_set_clkdiv(codec_dai, WM8510_MCLKDIV, mclk_div); | ||
| 280 | if (ret < 0) { | ||
| 281 | pr_warning("playpaq_wm8510: Failed to set CODEC MCLKDIV (%d)\n", | ||
| 282 | ret); | ||
| 283 | return ret; | ||
| 284 | } | ||
| 285 | |||
| 286 | |||
| 287 | return 0; | ||
| 288 | } | ||
| 289 | |||
| 290 | |||
| 291 | |||
| 292 | static struct snd_soc_ops playpaq_wm8510_ops = { | ||
| 293 | .hw_params = playpaq_wm8510_hw_params, | ||
| 294 | }; | ||
| 295 | |||
| 296 | |||
| 297 | |||
| 298 | static const struct snd_soc_dapm_widget playpaq_dapm_widgets[] = { | ||
| 299 | SND_SOC_DAPM_MIC("Int Mic", NULL), | ||
| 300 | SND_SOC_DAPM_SPK("Ext Spk", NULL), | ||
| 301 | }; | ||
| 302 | |||
| 303 | |||
| 304 | |||
| 305 | static const struct snd_soc_dapm_route intercon[] = { | ||
| 306 | /* speaker connected to SPKOUT */ | ||
| 307 | {"Ext Spk", NULL, "SPKOUTP"}, | ||
| 308 | {"Ext Spk", NULL, "SPKOUTN"}, | ||
| 309 | |||
| 310 | {"Mic Bias", NULL, "Int Mic"}, | ||
| 311 | {"MICN", NULL, "Mic Bias"}, | ||
| 312 | {"MICP", NULL, "Mic Bias"}, | ||
| 313 | }; | ||
| 314 | |||
| 315 | |||
| 316 | |||
| 317 | static int playpaq_wm8510_init(struct snd_soc_pcm_runtime *rtd) | ||
| 318 | { | ||
| 319 | struct snd_soc_codec *codec = rtd->codec; | ||
| 320 | struct snd_soc_dapm_context *dapm = &codec->dapm; | ||
| 321 | int i; | ||
| 322 | |||
| 323 | /* | ||
| 324 | * Add DAPM widgets | ||
| 325 | */ | ||
| 326 | for (i = 0; i < ARRAY_SIZE(playpaq_dapm_widgets); i++) | ||
| 327 | snd_soc_dapm_new_control(dapm, &playpaq_dapm_widgets[i]); | ||
| 328 | |||
| 329 | |||
| 330 | |||
| 331 | /* | ||
| 332 | * Setup audio path interconnects | ||
| 333 | */ | ||
| 334 | snd_soc_dapm_add_routes(dapm, intercon, ARRAY_SIZE(intercon)); | ||
| 335 | |||
| 336 | |||
| 337 | |||
| 338 | /* always connected pins */ | ||
| 339 | snd_soc_dapm_enable_pin(dapm, "Int Mic"); | ||
| 340 | snd_soc_dapm_enable_pin(dapm, "Ext Spk"); | ||
| 341 | |||
| 342 | |||
| 343 | |||
| 344 | /* Make CSB show PLL rate */ | ||
| 345 | snd_soc_dai_set_clkdiv(rtd->codec_dai, WM8510_OPCLKDIV, | ||
| 346 | WM8510_OPCLKDIV_1 | 4); | ||
| 347 | |||
| 348 | return 0; | ||
| 349 | } | ||
| 350 | |||
| 351 | |||
| 352 | |||
| 353 | static struct snd_soc_dai_link playpaq_wm8510_dai = { | ||
| 354 | .name = "WM8510", | ||
| 355 | .stream_name = "WM8510 PCM", | ||
| 356 | .cpu_dai_name= "atmel-ssc-dai.0", | ||
| 357 | .platform_name = "atmel-pcm-audio", | ||
| 358 | .codec_name = "wm8510-codec.0-0x1a", | ||
| 359 | .codec_dai_name = "wm8510-hifi", | ||
| 360 | .init = playpaq_wm8510_init, | ||
| 361 | .ops = &playpaq_wm8510_ops, | ||
| 362 | }; | ||
| 363 | |||
| 364 | |||
| 365 | |||
| 366 | static struct snd_soc_card snd_soc_playpaq = { | ||
| 367 | .name = "LRS_PlayPaq_WM8510", | ||
| 368 | .dai_link = &playpaq_wm8510_dai, | ||
| 369 | .num_links = 1, | ||
| 370 | }; | ||
| 371 | |||
| 372 | static struct platform_device *playpaq_snd_device; | ||
| 373 | |||
| 374 | |||
| 375 | static int __init playpaq_asoc_init(void) | ||
| 376 | { | ||
| 377 | int ret = 0; | ||
| 378 | |||
| 379 | /* | ||
| 380 | * Configure MCLK for WM8510 | ||
| 381 | */ | ||
| 382 | _gclk0 = clk_get(NULL, "gclk0"); | ||
| 383 | if (IS_ERR(_gclk0)) { | ||
| 384 | _gclk0 = NULL; | ||
| 385 | ret = PTR_ERR(_gclk0); | ||
| 386 | goto err_gclk0; | ||
| 387 | } | ||
| 388 | _pll0 = clk_get(NULL, "pll0"); | ||
| 389 | if (IS_ERR(_pll0)) { | ||
| 390 | _pll0 = NULL; | ||
| 391 | ret = PTR_ERR(_pll0); | ||
| 392 | goto err_pll0; | ||
| 393 | } | ||
| 394 | ret = clk_set_parent(_gclk0, _pll0); | ||
| 395 | if (ret) { | ||
| 396 | pr_warning("snd-soc-playpaq: " | ||
| 397 | "Failed to set PLL0 as parent for DAC clock\n"); | ||
| 398 | goto err_set_clk; | ||
| 399 | } | ||
| 400 | clk_set_rate(CODEC_CLK, 12000000); | ||
| 401 | clk_enable(CODEC_CLK); | ||
| 402 | |||
| 403 | #if defined CONFIG_AT32_ENHANCED_PORTMUX | ||
| 404 | at32_select_periph(MCLK_PIN, MCLK_PERIPH, 0); | ||
| 405 | #endif | ||
| 406 | |||
| 407 | |||
| 408 | /* | ||
| 409 | * Create and register platform device | ||
| 410 | */ | ||
| 411 | playpaq_snd_device = platform_device_alloc("soc-audio", 0); | ||
| 412 | if (playpaq_snd_device == NULL) { | ||
| 413 | ret = -ENOMEM; | ||
| 414 | goto err_device_alloc; | ||
| 415 | } | ||
| 416 | |||
| 417 | platform_set_drvdata(playpaq_snd_device, &snd_soc_playpaq); | ||
| 418 | |||
| 419 | ret = platform_device_add(playpaq_snd_device); | ||
| 420 | if (ret) { | ||
| 421 | pr_warning("playpaq_wm8510: platform_device_add failed (%d)\n", | ||
| 422 | ret); | ||
| 423 | goto err_device_add; | ||
| 424 | } | ||
| 425 | |||
| 426 | return 0; | ||
| 427 | |||
| 428 | |||
| 429 | err_device_add: | ||
| 430 | if (playpaq_snd_device != NULL) { | ||
| 431 | platform_device_put(playpaq_snd_device); | ||
| 432 | playpaq_snd_device = NULL; | ||
| 433 | } | ||
| 434 | err_device_alloc: | ||
| 435 | err_set_clk: | ||
| 436 | if (_pll0 != NULL) { | ||
| 437 | clk_put(_pll0); | ||
| 438 | _pll0 = NULL; | ||
| 439 | } | ||
| 440 | err_pll0: | ||
| 441 | if (_gclk0 != NULL) { | ||
| 442 | clk_put(_gclk0); | ||
| 443 | _gclk0 = NULL; | ||
| 444 | } | ||
| 445 | return ret; | ||
| 446 | } | ||
| 447 | |||
| 448 | |||
| 449 | static void __exit playpaq_asoc_exit(void) | ||
| 450 | { | ||
| 451 | if (_gclk0 != NULL) { | ||
| 452 | clk_put(_gclk0); | ||
| 453 | _gclk0 = NULL; | ||
| 454 | } | ||
| 455 | if (_pll0 != NULL) { | ||
| 456 | clk_put(_pll0); | ||
| 457 | _pll0 = NULL; | ||
| 458 | } | ||
| 459 | |||
| 460 | #if defined CONFIG_AT32_ENHANCED_PORTMUX | ||
| 461 | at32_free_pin(MCLK_PIN); | ||
| 462 | #endif | ||
| 463 | |||
| 464 | platform_device_unregister(playpaq_snd_device); | ||
| 465 | playpaq_snd_device = NULL; | ||
| 466 | } | ||
| 467 | |||
| 468 | module_init(playpaq_asoc_init); | ||
| 469 | module_exit(playpaq_asoc_exit); | ||
| 470 | |||
| 471 | MODULE_AUTHOR("Geoffrey Wossum <gwossum@acm.org>"); | ||
| 472 | MODULE_DESCRIPTION("ASoC machine driver for LRS PlayPaq"); | ||
| 473 | MODULE_LICENSE("GPL"); | ||
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 4584514d93d4..fa787d45d74a 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig | |||
| @@ -33,7 +33,7 @@ config SND_SOC_ALL_CODECS | |||
| 33 | select SND_SOC_CX20442 | 33 | select SND_SOC_CX20442 |
| 34 | select SND_SOC_DA7210 if I2C | 34 | select SND_SOC_DA7210 if I2C |
| 35 | select SND_SOC_DFBMCS320 | 35 | select SND_SOC_DFBMCS320 |
| 36 | select SND_SOC_JZ4740_CODEC if SOC_JZ4740 | 36 | select SND_SOC_JZ4740_CODEC |
| 37 | select SND_SOC_LM4857 if I2C | 37 | select SND_SOC_LM4857 if I2C |
| 38 | select SND_SOC_MAX98088 if I2C | 38 | select SND_SOC_MAX98088 if I2C |
| 39 | select SND_SOC_MAX98095 if I2C | 39 | select SND_SOC_MAX98095 if I2C |
diff --git a/sound/soc/codecs/ad1836.h b/sound/soc/codecs/ad1836.h index 444747f0db26..dd7be0dbbc58 100644 --- a/sound/soc/codecs/ad1836.h +++ b/sound/soc/codecs/ad1836.h | |||
| @@ -34,7 +34,7 @@ | |||
| 34 | 34 | ||
| 35 | #define AD1836_ADC_CTRL2 13 | 35 | #define AD1836_ADC_CTRL2 13 |
| 36 | #define AD1836_ADC_WORD_LEN_MASK 0x30 | 36 | #define AD1836_ADC_WORD_LEN_MASK 0x30 |
| 37 | #define AD1836_ADC_WORD_OFFSET 5 | 37 | #define AD1836_ADC_WORD_OFFSET 4 |
| 38 | #define AD1836_ADC_SERFMT_MASK (7 << 6) | 38 | #define AD1836_ADC_SERFMT_MASK (7 << 6) |
| 39 | #define AD1836_ADC_SERFMT_PCK256 (0x4 << 6) | 39 | #define AD1836_ADC_SERFMT_PCK256 (0x4 << 6) |
| 40 | #define AD1836_ADC_SERFMT_PCK128 (0x5 << 6) | 40 | #define AD1836_ADC_SERFMT_PCK128 (0x5 << 6) |
diff --git a/sound/soc/codecs/adau1373.c b/sound/soc/codecs/adau1373.c index 1ccf8dd47576..45c63028b40d 100644 --- a/sound/soc/codecs/adau1373.c +++ b/sound/soc/codecs/adau1373.c | |||
| @@ -245,7 +245,7 @@ static const char *adau1373_bass_hpf_cutoff_text[] = { | |||
| 245 | }; | 245 | }; |
| 246 | 246 | ||
| 247 | static const unsigned int adau1373_bass_tlv[] = { | 247 | static const unsigned int adau1373_bass_tlv[] = { |
| 248 | TLV_DB_RANGE_HEAD(4), | 248 | TLV_DB_RANGE_HEAD(3), |
| 249 | 0, 2, TLV_DB_SCALE_ITEM(-600, 600, 1), | 249 | 0, 2, TLV_DB_SCALE_ITEM(-600, 600, 1), |
| 250 | 3, 4, TLV_DB_SCALE_ITEM(950, 250, 0), | 250 | 3, 4, TLV_DB_SCALE_ITEM(950, 250, 0), |
| 251 | 5, 7, TLV_DB_SCALE_ITEM(1400, 150, 0), | 251 | 5, 7, TLV_DB_SCALE_ITEM(1400, 150, 0), |
diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c index f1f237ecec2a..73f46eb459f1 100644 --- a/sound/soc/codecs/cs4270.c +++ b/sound/soc/codecs/cs4270.c | |||
| @@ -601,7 +601,6 @@ static int cs4270_soc_suspend(struct snd_soc_codec *codec, pm_message_t mesg) | |||
| 601 | static int cs4270_soc_resume(struct snd_soc_codec *codec) | 601 | static int cs4270_soc_resume(struct snd_soc_codec *codec) |
| 602 | { | 602 | { |
| 603 | struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec); | 603 | struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec); |
| 604 | struct i2c_client *i2c_client = to_i2c_client(codec->dev); | ||
| 605 | int reg; | 604 | int reg; |
| 606 | 605 | ||
| 607 | regulator_bulk_enable(ARRAY_SIZE(cs4270->supplies), | 606 | regulator_bulk_enable(ARRAY_SIZE(cs4270->supplies), |
| @@ -612,14 +611,7 @@ static int cs4270_soc_resume(struct snd_soc_codec *codec) | |||
| 612 | ndelay(500); | 611 | ndelay(500); |
| 613 | 612 | ||
| 614 | /* first restore the entire register cache ... */ | 613 | /* first restore the entire register cache ... */ |
| 615 | for (reg = CS4270_FIRSTREG; reg <= CS4270_LASTREG; reg++) { | 614 | snd_soc_cache_sync(codec); |
| 616 | u8 val = snd_soc_read(codec, reg); | ||
| 617 | |||
| 618 | if (i2c_smbus_write_byte_data(i2c_client, reg, val)) { | ||
| 619 | dev_err(codec->dev, "i2c write failed\n"); | ||
| 620 | return -EIO; | ||
| 621 | } | ||
| 622 | } | ||
| 623 | 615 | ||
| 624 | /* ... then disable the power-down bits */ | 616 | /* ... then disable the power-down bits */ |
| 625 | reg = snd_soc_read(codec, CS4270_PWRCTL); | 617 | reg = snd_soc_read(codec, CS4270_PWRCTL); |
diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c index 23d1bd5dadda..69fde1506fe1 100644 --- a/sound/soc/codecs/cs4271.c +++ b/sound/soc/codecs/cs4271.c | |||
| @@ -434,7 +434,8 @@ static int cs4271_soc_suspend(struct snd_soc_codec *codec, pm_message_t mesg) | |||
| 434 | { | 434 | { |
| 435 | int ret; | 435 | int ret; |
| 436 | /* Set power-down bit */ | 436 | /* Set power-down bit */ |
| 437 | ret = snd_soc_update_bits(codec, CS4271_MODE2, 0, CS4271_MODE2_PDN); | 437 | ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, |
| 438 | CS4271_MODE2_PDN); | ||
| 438 | if (ret < 0) | 439 | if (ret < 0) |
| 439 | return ret; | 440 | return ret; |
| 440 | return 0; | 441 | return 0; |
| @@ -501,8 +502,9 @@ static int cs4271_probe(struct snd_soc_codec *codec) | |||
| 501 | return ret; | 502 | return ret; |
| 502 | } | 503 | } |
| 503 | 504 | ||
| 504 | ret = snd_soc_update_bits(codec, CS4271_MODE2, 0, | 505 | ret = snd_soc_update_bits(codec, CS4271_MODE2, |
| 505 | CS4271_MODE2_PDN | CS4271_MODE2_CPEN); | 506 | CS4271_MODE2_PDN | CS4271_MODE2_CPEN, |
| 507 | CS4271_MODE2_PDN | CS4271_MODE2_CPEN); | ||
| 506 | if (ret < 0) | 508 | if (ret < 0) |
| 507 | return ret; | 509 | return ret; |
| 508 | ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, 0); | 510 | ret = snd_soc_update_bits(codec, CS4271_MODE2, CS4271_MODE2_PDN, 0); |
diff --git a/sound/soc/codecs/cs42l51.c b/sound/soc/codecs/cs42l51.c index 8c3c8205d19e..1ee66361f61b 100644 --- a/sound/soc/codecs/cs42l51.c +++ b/sound/soc/codecs/cs42l51.c | |||
| @@ -555,7 +555,7 @@ static int cs42l51_probe(struct snd_soc_codec *codec) | |||
| 555 | 555 | ||
| 556 | static struct snd_soc_codec_driver soc_codec_device_cs42l51 = { | 556 | static struct snd_soc_codec_driver soc_codec_device_cs42l51 = { |
| 557 | .probe = cs42l51_probe, | 557 | .probe = cs42l51_probe, |
| 558 | .reg_cache_size = CS42L51_NUMREGS, | 558 | .reg_cache_size = CS42L51_NUMREGS + 1, |
| 559 | .reg_word_size = sizeof(u8), | 559 | .reg_word_size = sizeof(u8), |
| 560 | }; | 560 | }; |
| 561 | 561 | ||
diff --git a/sound/soc/codecs/jz4740.c b/sound/soc/codecs/jz4740.c index e373f8f06907..3e1f4e172bfb 100644 --- a/sound/soc/codecs/jz4740.c +++ b/sound/soc/codecs/jz4740.c | |||
| @@ -15,6 +15,7 @@ | |||
| 15 | #include <linux/module.h> | 15 | #include <linux/module.h> |
| 16 | #include <linux/platform_device.h> | 16 | #include <linux/platform_device.h> |
| 17 | #include <linux/slab.h> | 17 | #include <linux/slab.h> |
| 18 | #include <linux/io.h> | ||
| 18 | 19 | ||
| 19 | #include <linux/delay.h> | 20 | #include <linux/delay.h> |
| 20 | 21 | ||
diff --git a/sound/soc/codecs/max9877.c b/sound/soc/codecs/max9877.c index 9e7e964a5fa3..dcf6f2a1600a 100644 --- a/sound/soc/codecs/max9877.c +++ b/sound/soc/codecs/max9877.c | |||
| @@ -106,13 +106,13 @@ static int max9877_set_2reg(struct snd_kcontrol *kcontrol, | |||
| 106 | unsigned int mask = mc->max; | 106 | unsigned int mask = mc->max; |
| 107 | unsigned int val = (ucontrol->value.integer.value[0] & mask); | 107 | unsigned int val = (ucontrol->value.integer.value[0] & mask); |
| 108 | unsigned int val2 = (ucontrol->value.integer.value[1] & mask); | 108 | unsigned int val2 = (ucontrol->value.integer.value[1] & mask); |
| 109 | unsigned int change = 1; | 109 | unsigned int change = 0; |
| 110 | 110 | ||
| 111 | if (((max9877_regs[reg] >> shift) & mask) == val) | 111 | if (((max9877_regs[reg] >> shift) & mask) != val) |
| 112 | change = 0; | 112 | change = 1; |
| 113 | 113 | ||
| 114 | if (((max9877_regs[reg2] >> shift) & mask) == val2) | 114 | if (((max9877_regs[reg2] >> shift) & mask) != val2) |
| 115 | change = 0; | 115 | change = 1; |
| 116 | 116 | ||
| 117 | if (change) { | 117 | if (change) { |
| 118 | max9877_regs[reg] &= ~(mask << shift); | 118 | max9877_regs[reg] &= ~(mask << shift); |
diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index 27a078cbb6eb..4646e808b90a 100644 --- a/sound/soc/codecs/rt5631.c +++ b/sound/soc/codecs/rt5631.c | |||
| @@ -177,7 +177,7 @@ static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -95625, 375, 0); | |||
| 177 | static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -3450, 150, 0); | 177 | static const DECLARE_TLV_DB_SCALE(in_vol_tlv, -3450, 150, 0); |
| 178 | /* {0, +20, +24, +30, +35, +40, +44, +50, +52}dB */ | 178 | /* {0, +20, +24, +30, +35, +40, +44, +50, +52}dB */ |
| 179 | static unsigned int mic_bst_tlv[] = { | 179 | static unsigned int mic_bst_tlv[] = { |
| 180 | TLV_DB_RANGE_HEAD(6), | 180 | TLV_DB_RANGE_HEAD(7), |
| 181 | 0, 0, TLV_DB_SCALE_ITEM(0, 0, 0), | 181 | 0, 0, TLV_DB_SCALE_ITEM(0, 0, 0), |
| 182 | 1, 1, TLV_DB_SCALE_ITEM(2000, 0, 0), | 182 | 1, 1, TLV_DB_SCALE_ITEM(2000, 0, 0), |
| 183 | 2, 2, TLV_DB_SCALE_ITEM(2400, 0, 0), | 183 | 2, 2, TLV_DB_SCALE_ITEM(2400, 0, 0), |
diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index d15695d1c273..bbcf921166f7 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c | |||
| @@ -365,7 +365,7 @@ static const DECLARE_TLV_DB_SCALE(capture_6db_attenuate, -600, 600, 0); | |||
| 365 | 365 | ||
| 366 | /* tlv for mic gain, 0db 20db 30db 40db */ | 366 | /* tlv for mic gain, 0db 20db 30db 40db */ |
| 367 | static const unsigned int mic_gain_tlv[] = { | 367 | static const unsigned int mic_gain_tlv[] = { |
| 368 | TLV_DB_RANGE_HEAD(4), | 368 | TLV_DB_RANGE_HEAD(2), |
| 369 | 0, 0, TLV_DB_SCALE_ITEM(0, 0, 0), | 369 | 0, 0, TLV_DB_SCALE_ITEM(0, 0, 0), |
| 370 | 1, 3, TLV_DB_SCALE_ITEM(2000, 1000, 0), | 370 | 1, 3, TLV_DB_SCALE_ITEM(2000, 1000, 0), |
| 371 | }; | 371 | }; |
diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index bb82408ab8e1..d2f37152f940 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c | |||
| @@ -76,6 +76,8 @@ struct sta32x_priv { | |||
| 76 | 76 | ||
| 77 | unsigned int mclk; | 77 | unsigned int mclk; |
| 78 | unsigned int format; | 78 | unsigned int format; |
| 79 | |||
| 80 | u32 coef_shadow[STA32X_COEF_COUNT]; | ||
| 79 | }; | 81 | }; |
| 80 | 82 | ||
| 81 | static const DECLARE_TLV_DB_SCALE(mvol_tlv, -12700, 50, 1); | 83 | static const DECLARE_TLV_DB_SCALE(mvol_tlv, -12700, 50, 1); |
| @@ -227,6 +229,7 @@ static int sta32x_coefficient_put(struct snd_kcontrol *kcontrol, | |||
| 227 | struct snd_ctl_elem_value *ucontrol) | 229 | struct snd_ctl_elem_value *ucontrol) |
| 228 | { | 230 | { |
| 229 | struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); | 231 | struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol); |
| 232 | struct sta32x_priv *sta32x = snd_soc_codec_get_drvdata(codec); | ||
| 230 | int numcoef = kcontrol->private_value >> 16; | 233 | int numcoef = kcontrol->private_value >> 16; |
| 231 | int index = kcontrol->private_value & 0xffff; | 234 | int index = kcontrol->private_value & 0xffff; |
| 232 | unsigned int cfud; | 235 | unsigned int cfud; |
| @@ -239,6 +242,11 @@ static int sta32x_coefficient_put(struct snd_kcontrol *kcontrol, | |||
| 239 | snd_soc_write(codec, STA32X_CFUD, cfud); | 242 | snd_soc_write(codec, STA32X_CFUD, cfud); |
| 240 | 243 | ||
| 241 | snd_soc_write(codec, STA32X_CFADDR2, index); | 244 | snd_soc_write(codec, STA32X_CFADDR2, index); |
| 245 | for (i = 0; i < numcoef && (index + i < STA32X_COEF_COUNT); i++) | ||
| 246 | sta32x->coef_shadow[index + i] = | ||
| 247 | (ucontrol->value.bytes.data[3 * i] << 16) | ||
| 248 | | (ucontrol->value.bytes.data[3 * i + 1] << 8) | ||
| 249 | | (ucontrol->value.bytes.data[3 * i + 2]); | ||
| 242 | for (i = 0; i < 3 * numcoef; i++) | 250 | for (i = 0; i < 3 * numcoef; i++) |
| 243 | snd_soc_write(codec, STA32X_B1CF1 + i, | 251 | snd_soc_write(codec, STA32X_B1CF1 + i, |
| 244 | ucontrol->value.bytes.data[i]); | 252 | ucontrol->value.bytes.data[i]); |
| @@ -252,6 +260,48 @@ static int sta32x_coefficient_put(struct snd_kcontrol *kcontrol, | |||
| 252 | return 0; | 260 | return 0; |
| 253 | } | 261 | } |
| 254 | 262 | ||
| 263 | int sta32x_sync_coef_shadow(struct snd_soc_codec *codec) | ||
| 264 | { | ||
| 265 | struct sta32x_priv *sta32x = snd_soc_codec_get_drvdata(codec); | ||
| 266 | unsigned int cfud; | ||
| 267 | int i; | ||
| 268 | |||
| 269 | /* preserve reserved bits in STA32X_CFUD */ | ||
| 270 | cfud = snd_soc_read(codec, STA32X_CFUD) & 0xf0; | ||
| 271 | |||
| 272 | for (i = 0; i < STA32X_COEF_COUNT; i++) { | ||
| 273 | snd_soc_write(codec, STA32X_CFADDR2, i); | ||
| 274 | snd_soc_write(codec, STA32X_B1CF1, | ||
| 275 | (sta32x->coef_shadow[i] >> 16) & 0xff); | ||
| 276 | snd_soc_write(codec, STA32X_B1CF2, | ||
| 277 | (sta32x->coef_shadow[i] >> 8) & 0xff); | ||
| 278 | snd_soc_write(codec, STA32X_B1CF3, | ||
| 279 | (sta32x->coef_shadow[i]) & 0xff); | ||
| 280 | /* chip documentation does not say if the bits are | ||
| 281 | * self-clearing, so do it explicitly */ | ||
| 282 | snd_soc_write(codec, STA32X_CFUD, cfud); | ||
| 283 | snd_soc_write(codec, STA32X_CFUD, cfud | 0x01); | ||
| 284 | } | ||
| 285 | return 0; | ||
| 286 | } | ||
| 287 | |||
| 288 | int sta32x_cache_sync(struct snd_soc_codec *codec) | ||
| 289 | { | ||
| 290 | unsigned int mute; | ||
| 291 | int rc; | ||
| 292 | |||
| 293 | if (!codec->cache_sync) | ||
| 294 | return 0; | ||
| 295 | |||
| 296 | /* mute during register sync */ | ||
| 297 | mute = snd_soc_read(codec, STA32X_MMUTE); | ||
| 298 | snd_soc_write(codec, STA32X_MMUTE, mute | STA32X_MMUTE_MMUTE); | ||
| 299 | sta32x_sync_coef_shadow(codec); | ||
| 300 | rc = snd_soc_cache_sync(codec); | ||
| 301 | snd_soc_write(codec, STA32X_MMUTE, mute); | ||
| 302 | return rc; | ||
| 303 | } | ||
| 304 | |||
| 255 | #define SINGLE_COEF(xname, index) \ | 305 | #define SINGLE_COEF(xname, index) \ |
| 256 | { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \ | 306 | { .iface = SNDRV_CTL_ELEM_IFACE_MIXER, .name = xname, \ |
| 257 | .info = sta32x_coefficient_info, \ | 307 | .info = sta32x_coefficient_info, \ |
| @@ -661,7 +711,7 @@ static int sta32x_set_bias_level(struct snd_soc_codec *codec, | |||
| 661 | return ret; | 711 | return ret; |
| 662 | } | 712 | } |
| 663 | 713 | ||
| 664 | snd_soc_cache_sync(codec); | 714 | sta32x_cache_sync(codec); |
| 665 | } | 715 | } |
| 666 | 716 | ||
| 667 | /* Power up to mute */ | 717 | /* Power up to mute */ |
| @@ -790,6 +840,17 @@ static int sta32x_probe(struct snd_soc_codec *codec) | |||
| 790 | STA32X_CxCFG_OM_MASK, | 840 | STA32X_CxCFG_OM_MASK, |
| 791 | 2 << STA32X_CxCFG_OM_SHIFT); | 841 | 2 << STA32X_CxCFG_OM_SHIFT); |
| 792 | 842 | ||
| 843 | /* initialize coefficient shadow RAM with reset values */ | ||
| 844 | for (i = 4; i <= 49; i += 5) | ||
| 845 | sta32x->coef_shadow[i] = 0x400000; | ||
| 846 | for (i = 50; i <= 54; i++) | ||
| 847 | sta32x->coef_shadow[i] = 0x7fffff; | ||
| 848 | sta32x->coef_shadow[55] = 0x5a9df7; | ||
| 849 | sta32x->coef_shadow[56] = 0x7fffff; | ||
| 850 | sta32x->coef_shadow[59] = 0x7fffff; | ||
| 851 | sta32x->coef_shadow[60] = 0x400000; | ||
| 852 | sta32x->coef_shadow[61] = 0x400000; | ||
| 853 | |||
| 793 | sta32x_set_bias_level(codec, SND_SOC_BIAS_STANDBY); | 854 | sta32x_set_bias_level(codec, SND_SOC_BIAS_STANDBY); |
| 794 | /* Bias level configuration will have done an extra enable */ | 855 | /* Bias level configuration will have done an extra enable */ |
| 795 | regulator_bulk_disable(ARRAY_SIZE(sta32x->supplies), sta32x->supplies); | 856 | regulator_bulk_disable(ARRAY_SIZE(sta32x->supplies), sta32x->supplies); |
diff --git a/sound/soc/codecs/sta32x.h b/sound/soc/codecs/sta32x.h index b97ee5a75667..d8e32a6262ee 100644 --- a/sound/soc/codecs/sta32x.h +++ b/sound/soc/codecs/sta32x.h | |||
| @@ -19,6 +19,7 @@ | |||
| 19 | /* STA326 register addresses */ | 19 | /* STA326 register addresses */ |
| 20 | 20 | ||
| 21 | #define STA32X_REGISTER_COUNT 0x2d | 21 | #define STA32X_REGISTER_COUNT 0x2d |
| 22 | #define STA32X_COEF_COUNT 62 | ||
| 22 | 23 | ||
| 23 | #define STA32X_CONFA 0x00 | 24 | #define STA32X_CONFA 0x00 |
| 24 | #define STA32X_CONFB 0x01 | 25 | #define STA32X_CONFB 0x01 |
diff --git a/sound/soc/codecs/uda1380.c b/sound/soc/codecs/uda1380.c index c5ca8cfea60f..0441893e270e 100644 --- a/sound/soc/codecs/uda1380.c +++ b/sound/soc/codecs/uda1380.c | |||
| @@ -863,13 +863,13 @@ static struct i2c_driver uda1380_i2c_driver = { | |||
| 863 | 863 | ||
| 864 | static int __init uda1380_modinit(void) | 864 | static int __init uda1380_modinit(void) |
| 865 | { | 865 | { |
| 866 | int ret; | 866 | int ret = 0; |
| 867 | #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) | 867 | #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE) |
| 868 | ret = i2c_add_driver(&uda1380_i2c_driver); | 868 | ret = i2c_add_driver(&uda1380_i2c_driver); |
| 869 | if (ret != 0) | 869 | if (ret != 0) |
| 870 | pr_err("Failed to register UDA1380 I2C driver: %d\n", ret); | 870 | pr_err("Failed to register UDA1380 I2C driver: %d\n", ret); |
| 871 | #endif | 871 | #endif |
| 872 | return 0; | 872 | return ret; |
| 873 | } | 873 | } |
| 874 | module_init(uda1380_modinit); | 874 | module_init(uda1380_modinit); |
| 875 | 875 | ||
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c index 7e5ec03f6f8d..a7c9ae17fc7e 100644 --- a/sound/soc/codecs/wm8731.c +++ b/sound/soc/codecs/wm8731.c | |||
| @@ -453,6 +453,7 @@ static int wm8731_set_bias_level(struct snd_soc_codec *codec, | |||
| 453 | snd_soc_write(codec, WM8731_PWR, 0xffff); | 453 | snd_soc_write(codec, WM8731_PWR, 0xffff); |
| 454 | regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), | 454 | regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), |
| 455 | wm8731->supplies); | 455 | wm8731->supplies); |
| 456 | codec->cache_sync = 1; | ||
| 456 | break; | 457 | break; |
| 457 | } | 458 | } |
| 458 | codec->dapm.bias_level = level; | 459 | codec->dapm.bias_level = level; |
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c index a9504710bb69..3a629d0d690e 100644 --- a/sound/soc/codecs/wm8753.c +++ b/sound/soc/codecs/wm8753.c | |||
| @@ -190,6 +190,9 @@ static int wm8753_set_dai(struct snd_kcontrol *kcontrol, | |||
| 190 | struct wm8753_priv *wm8753 = snd_soc_codec_get_drvdata(codec); | 190 | struct wm8753_priv *wm8753 = snd_soc_codec_get_drvdata(codec); |
| 191 | u16 ioctl; | 191 | u16 ioctl; |
| 192 | 192 | ||
| 193 | if (wm8753->dai_func == ucontrol->value.integer.value[0]) | ||
| 194 | return 0; | ||
| 195 | |||
| 193 | if (codec->active) | 196 | if (codec->active) |
| 194 | return -EBUSY; | 197 | return -EBUSY; |
| 195 | 198 | ||
diff --git a/sound/soc/codecs/wm8958-dsp2.c b/sound/soc/codecs/wm8958-dsp2.c index 0293763debe5..5a14d5c0e0e1 100644 --- a/sound/soc/codecs/wm8958-dsp2.c +++ b/sound/soc/codecs/wm8958-dsp2.c | |||
| @@ -60,6 +60,8 @@ static int wm8958_dsp2_fw(struct snd_soc_codec *codec, const char *name, | |||
| 60 | } | 60 | } |
| 61 | 61 | ||
| 62 | if (memcmp(fw->data, "WMFW", 4) != 0) { | 62 | if (memcmp(fw->data, "WMFW", 4) != 0) { |
| 63 | memcpy(&data32, fw->data, sizeof(data32)); | ||
| 64 | data32 = be32_to_cpu(data32); | ||
| 63 | dev_err(codec->dev, "%s: firmware has bad file magic %08x\n", | 65 | dev_err(codec->dev, "%s: firmware has bad file magic %08x\n", |
| 64 | name, data32); | 66 | name, data32); |
| 65 | goto err; | 67 | goto err; |
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c index 91d3c6dbeba3..53edd9a8c758 100644 --- a/sound/soc/codecs/wm8962.c +++ b/sound/soc/codecs/wm8962.c | |||
| @@ -1973,7 +1973,7 @@ static int wm8962_reset(struct snd_soc_codec *codec) | |||
| 1973 | static const DECLARE_TLV_DB_SCALE(inpga_tlv, -2325, 75, 0); | 1973 | static const DECLARE_TLV_DB_SCALE(inpga_tlv, -2325, 75, 0); |
| 1974 | static const DECLARE_TLV_DB_SCALE(mixin_tlv, -1500, 300, 0); | 1974 | static const DECLARE_TLV_DB_SCALE(mixin_tlv, -1500, 300, 0); |
| 1975 | static const unsigned int mixinpga_tlv[] = { | 1975 | static const unsigned int mixinpga_tlv[] = { |
| 1976 | TLV_DB_RANGE_HEAD(7), | 1976 | TLV_DB_RANGE_HEAD(5), |
| 1977 | 0, 1, TLV_DB_SCALE_ITEM(0, 600, 0), | 1977 | 0, 1, TLV_DB_SCALE_ITEM(0, 600, 0), |
| 1978 | 2, 2, TLV_DB_SCALE_ITEM(1300, 1300, 0), | 1978 | 2, 2, TLV_DB_SCALE_ITEM(1300, 1300, 0), |
| 1979 | 3, 4, TLV_DB_SCALE_ITEM(1800, 200, 0), | 1979 | 3, 4, TLV_DB_SCALE_ITEM(1800, 200, 0), |
| @@ -1988,7 +1988,7 @@ static const DECLARE_TLV_DB_SCALE(bypass_tlv, -1500, 300, 0); | |||
| 1988 | static const DECLARE_TLV_DB_SCALE(out_tlv, -12100, 100, 1); | 1988 | static const DECLARE_TLV_DB_SCALE(out_tlv, -12100, 100, 1); |
| 1989 | static const DECLARE_TLV_DB_SCALE(hp_tlv, -700, 100, 0); | 1989 | static const DECLARE_TLV_DB_SCALE(hp_tlv, -700, 100, 0); |
| 1990 | static const unsigned int classd_tlv[] = { | 1990 | static const unsigned int classd_tlv[] = { |
| 1991 | TLV_DB_RANGE_HEAD(7), | 1991 | TLV_DB_RANGE_HEAD(2), |
| 1992 | 0, 6, TLV_DB_SCALE_ITEM(0, 150, 0), | 1992 | 0, 6, TLV_DB_SCALE_ITEM(0, 150, 0), |
| 1993 | 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), | 1993 | 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), |
| 1994 | }; | 1994 | }; |
diff --git a/sound/soc/codecs/wm8993.c b/sound/soc/codecs/wm8993.c index eec8e1435116..d1a142f48b09 100644 --- a/sound/soc/codecs/wm8993.c +++ b/sound/soc/codecs/wm8993.c | |||
| @@ -512,7 +512,7 @@ static const DECLARE_TLV_DB_SCALE(drc_comp_threash, -4500, 75, 0); | |||
| 512 | static const DECLARE_TLV_DB_SCALE(drc_comp_amp, -2250, 75, 0); | 512 | static const DECLARE_TLV_DB_SCALE(drc_comp_amp, -2250, 75, 0); |
| 513 | static const DECLARE_TLV_DB_SCALE(drc_min_tlv, -1800, 600, 0); | 513 | static const DECLARE_TLV_DB_SCALE(drc_min_tlv, -1800, 600, 0); |
| 514 | static const unsigned int drc_max_tlv[] = { | 514 | static const unsigned int drc_max_tlv[] = { |
| 515 | TLV_DB_RANGE_HEAD(4), | 515 | TLV_DB_RANGE_HEAD(2), |
| 516 | 0, 2, TLV_DB_SCALE_ITEM(1200, 600, 0), | 516 | 0, 2, TLV_DB_SCALE_ITEM(1200, 600, 0), |
| 517 | 3, 3, TLV_DB_SCALE_ITEM(3600, 0, 0), | 517 | 3, 3, TLV_DB_SCALE_ITEM(3600, 0, 0), |
| 518 | }; | 518 | }; |
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c index 9c982e47eb99..d0c545b73d78 100644 --- a/sound/soc/codecs/wm8994.c +++ b/sound/soc/codecs/wm8994.c | |||
| @@ -1325,15 +1325,15 @@ SND_SOC_DAPM_DAC("DAC1R", NULL, WM8994_POWER_MANAGEMENT_5, 0, 0), | |||
| 1325 | }; | 1325 | }; |
| 1326 | 1326 | ||
| 1327 | static const struct snd_soc_dapm_widget wm8994_adc_revd_widgets[] = { | 1327 | static const struct snd_soc_dapm_widget wm8994_adc_revd_widgets[] = { |
| 1328 | SND_SOC_DAPM_MUX_E("ADCL Mux", WM8994_POWER_MANAGEMENT_4, 1, 0, &adcl_mux, | 1328 | SND_SOC_DAPM_VIRT_MUX_E("ADCL Mux", WM8994_POWER_MANAGEMENT_4, 1, 0, &adcl_mux, |
| 1329 | adc_mux_ev, SND_SOC_DAPM_PRE_PMU), | 1329 | adc_mux_ev, SND_SOC_DAPM_PRE_PMU), |
| 1330 | SND_SOC_DAPM_MUX_E("ADCR Mux", WM8994_POWER_MANAGEMENT_4, 0, 0, &adcr_mux, | 1330 | SND_SOC_DAPM_VIRT_MUX_E("ADCR Mux", WM8994_POWER_MANAGEMENT_4, 0, 0, &adcr_mux, |
| 1331 | adc_mux_ev, SND_SOC_DAPM_PRE_PMU), | 1331 | adc_mux_ev, SND_SOC_DAPM_PRE_PMU), |
| 1332 | }; | 1332 | }; |
| 1333 | 1333 | ||
| 1334 | static const struct snd_soc_dapm_widget wm8994_adc_widgets[] = { | 1334 | static const struct snd_soc_dapm_widget wm8994_adc_widgets[] = { |
| 1335 | SND_SOC_DAPM_MUX("ADCL Mux", WM8994_POWER_MANAGEMENT_4, 1, 0, &adcl_mux), | 1335 | SND_SOC_DAPM_VIRT_MUX("ADCL Mux", WM8994_POWER_MANAGEMENT_4, 1, 0, &adcl_mux), |
| 1336 | SND_SOC_DAPM_MUX("ADCR Mux", WM8994_POWER_MANAGEMENT_4, 0, 0, &adcr_mux), | 1336 | SND_SOC_DAPM_VIRT_MUX("ADCR Mux", WM8994_POWER_MANAGEMENT_4, 0, 0, &adcr_mux), |
| 1337 | }; | 1337 | }; |
| 1338 | 1338 | ||
| 1339 | static const struct snd_soc_dapm_widget wm8994_dapm_widgets[] = { | 1339 | static const struct snd_soc_dapm_widget wm8994_dapm_widgets[] = { |
| @@ -2357,6 +2357,11 @@ static int wm8994_hw_params(struct snd_pcm_substream *substream, | |||
| 2357 | bclk |= best << WM8994_AIF1_BCLK_DIV_SHIFT; | 2357 | bclk |= best << WM8994_AIF1_BCLK_DIV_SHIFT; |
| 2358 | 2358 | ||
| 2359 | lrclk = bclk_rate / params_rate(params); | 2359 | lrclk = bclk_rate / params_rate(params); |
| 2360 | if (!lrclk) { | ||
| 2361 | dev_err(dai->dev, "Unable to generate LRCLK from %dHz BCLK\n", | ||
| 2362 | bclk_rate); | ||
| 2363 | return -EINVAL; | ||
| 2364 | } | ||
| 2360 | dev_dbg(dai->dev, "Using LRCLK rate %d for actual LRCLK %dHz\n", | 2365 | dev_dbg(dai->dev, "Using LRCLK rate %d for actual LRCLK %dHz\n", |
| 2361 | lrclk, bclk_rate / lrclk); | 2366 | lrclk, bclk_rate / lrclk); |
| 2362 | 2367 | ||
| @@ -3178,6 +3183,8 @@ static int wm8994_codec_probe(struct snd_soc_codec *codec) | |||
| 3178 | switch (wm8994->revision) { | 3183 | switch (wm8994->revision) { |
| 3179 | case 0: | 3184 | case 0: |
| 3180 | case 1: | 3185 | case 1: |
| 3186 | case 2: | ||
| 3187 | case 3: | ||
| 3181 | wm8994->hubs.dcs_codes_l = -9; | 3188 | wm8994->hubs.dcs_codes_l = -9; |
| 3182 | wm8994->hubs.dcs_codes_r = -5; | 3189 | wm8994->hubs.dcs_codes_r = -5; |
| 3183 | break; | 3190 | break; |
diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c index 645c980d6b80..a33b04d17195 100644 --- a/sound/soc/codecs/wm8996.c +++ b/sound/soc/codecs/wm8996.c | |||
| @@ -1968,6 +1968,7 @@ static int wm8996_set_sysclk(struct snd_soc_dai *dai, | |||
| 1968 | break; | 1968 | break; |
| 1969 | case 24576000: | 1969 | case 24576000: |
| 1970 | ratediv = WM8996_SYSCLK_DIV; | 1970 | ratediv = WM8996_SYSCLK_DIV; |
| 1971 | wm8996->sysclk /= 2; | ||
| 1971 | case 12288000: | 1972 | case 12288000: |
| 1972 | snd_soc_update_bits(codec, WM8996_AIF_RATE, | 1973 | snd_soc_update_bits(codec, WM8996_AIF_RATE, |
| 1973 | WM8996_SYSCLK_RATE, WM8996_SYSCLK_RATE); | 1974 | WM8996_SYSCLK_RATE, WM8996_SYSCLK_RATE); |
diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c index 3cd35a02c28c..4a398c3bfe84 100644 --- a/sound/soc/codecs/wm9081.c +++ b/sound/soc/codecs/wm9081.c | |||
| @@ -807,7 +807,6 @@ static int wm9081_set_bias_level(struct snd_soc_codec *codec, | |||
| 807 | mdelay(100); | 807 | mdelay(100); |
| 808 | 808 | ||
| 809 | /* Normal bias enable & soft start off */ | 809 | /* Normal bias enable & soft start off */ |
| 810 | reg |= WM9081_BIAS_ENA; | ||
| 811 | reg &= ~WM9081_VMID_RAMP; | 810 | reg &= ~WM9081_VMID_RAMP; |
| 812 | snd_soc_write(codec, WM9081_VMID_CONTROL, reg); | 811 | snd_soc_write(codec, WM9081_VMID_CONTROL, reg); |
| 813 | 812 | ||
| @@ -818,7 +817,7 @@ static int wm9081_set_bias_level(struct snd_soc_codec *codec, | |||
| 818 | } | 817 | } |
| 819 | 818 | ||
| 820 | /* VMID 2*240k */ | 819 | /* VMID 2*240k */ |
| 821 | reg = snd_soc_read(codec, WM9081_BIAS_CONTROL_1); | 820 | reg = snd_soc_read(codec, WM9081_VMID_CONTROL); |
| 822 | reg &= ~WM9081_VMID_SEL_MASK; | 821 | reg &= ~WM9081_VMID_SEL_MASK; |
| 823 | reg |= 0x04; | 822 | reg |= 0x04; |
| 824 | snd_soc_write(codec, WM9081_VMID_CONTROL, reg); | 823 | snd_soc_write(codec, WM9081_VMID_CONTROL, reg); |
| @@ -830,14 +829,15 @@ static int wm9081_set_bias_level(struct snd_soc_codec *codec, | |||
| 830 | break; | 829 | break; |
| 831 | 830 | ||
| 832 | case SND_SOC_BIAS_OFF: | 831 | case SND_SOC_BIAS_OFF: |
| 833 | /* Startup bias source */ | 832 | /* Startup bias source and disable bias */ |
| 834 | reg = snd_soc_read(codec, WM9081_BIAS_CONTROL_1); | 833 | reg = snd_soc_read(codec, WM9081_BIAS_CONTROL_1); |
| 835 | reg |= WM9081_BIAS_SRC; | 834 | reg |= WM9081_BIAS_SRC; |
| 835 | reg &= ~WM9081_BIAS_ENA; | ||
| 836 | snd_soc_write(codec, WM9081_BIAS_CONTROL_1, reg); | 836 | snd_soc_write(codec, WM9081_BIAS_CONTROL_1, reg); |
| 837 | 837 | ||
| 838 | /* Disable VMID and biases with soft ramping */ | 838 | /* Disable VMID with soft ramping */ |
| 839 | reg = snd_soc_read(codec, WM9081_VMID_CONTROL); | 839 | reg = snd_soc_read(codec, WM9081_VMID_CONTROL); |
| 840 | reg &= ~(WM9081_VMID_SEL_MASK | WM9081_BIAS_ENA); | 840 | reg &= ~WM9081_VMID_SEL_MASK; |
| 841 | reg |= WM9081_VMID_RAMP; | 841 | reg |= WM9081_VMID_RAMP; |
| 842 | snd_soc_write(codec, WM9081_VMID_CONTROL, reg); | 842 | snd_soc_write(codec, WM9081_VMID_CONTROL, reg); |
| 843 | 843 | ||
diff --git a/sound/soc/codecs/wm9090.c b/sound/soc/codecs/wm9090.c index 2b5252c9e377..f94c06057c64 100644 --- a/sound/soc/codecs/wm9090.c +++ b/sound/soc/codecs/wm9090.c | |||
| @@ -177,19 +177,19 @@ static void wait_for_dc_servo(struct snd_soc_codec *codec) | |||
| 177 | } | 177 | } |
| 178 | 178 | ||
| 179 | static const unsigned int in_tlv[] = { | 179 | static const unsigned int in_tlv[] = { |
| 180 | TLV_DB_RANGE_HEAD(6), | 180 | TLV_DB_RANGE_HEAD(3), |
| 181 | 0, 0, TLV_DB_SCALE_ITEM(-600, 0, 0), | 181 | 0, 0, TLV_DB_SCALE_ITEM(-600, 0, 0), |
| 182 | 1, 3, TLV_DB_SCALE_ITEM(-350, 350, 0), | 182 | 1, 3, TLV_DB_SCALE_ITEM(-350, 350, 0), |
| 183 | 4, 6, TLV_DB_SCALE_ITEM(600, 600, 0), | 183 | 4, 6, TLV_DB_SCALE_ITEM(600, 600, 0), |
| 184 | }; | 184 | }; |
| 185 | static const unsigned int mix_tlv[] = { | 185 | static const unsigned int mix_tlv[] = { |
| 186 | TLV_DB_RANGE_HEAD(4), | 186 | TLV_DB_RANGE_HEAD(2), |
| 187 | 0, 2, TLV_DB_SCALE_ITEM(-1200, 300, 0), | 187 | 0, 2, TLV_DB_SCALE_ITEM(-1200, 300, 0), |
| 188 | 3, 3, TLV_DB_SCALE_ITEM(0, 0, 0), | 188 | 3, 3, TLV_DB_SCALE_ITEM(0, 0, 0), |
| 189 | }; | 189 | }; |
| 190 | static const DECLARE_TLV_DB_SCALE(out_tlv, -5700, 100, 0); | 190 | static const DECLARE_TLV_DB_SCALE(out_tlv, -5700, 100, 0); |
| 191 | static const unsigned int spkboost_tlv[] = { | 191 | static const unsigned int spkboost_tlv[] = { |
| 192 | TLV_DB_RANGE_HEAD(7), | 192 | TLV_DB_RANGE_HEAD(2), |
| 193 | 0, 6, TLV_DB_SCALE_ITEM(0, 150, 0), | 193 | 0, 6, TLV_DB_SCALE_ITEM(0, 150, 0), |
| 194 | 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), | 194 | 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), |
| 195 | }; | 195 | }; |
diff --git a/sound/soc/codecs/wm_hubs.c b/sound/soc/codecs/wm_hubs.c index 84f33d4ea2cd..48e61e912400 100644 --- a/sound/soc/codecs/wm_hubs.c +++ b/sound/soc/codecs/wm_hubs.c | |||
| @@ -40,7 +40,7 @@ static const DECLARE_TLV_DB_SCALE(outmix_tlv, -2100, 300, 0); | |||
| 40 | static const DECLARE_TLV_DB_SCALE(spkmixout_tlv, -1800, 600, 1); | 40 | static const DECLARE_TLV_DB_SCALE(spkmixout_tlv, -1800, 600, 1); |
| 41 | static const DECLARE_TLV_DB_SCALE(outpga_tlv, -5700, 100, 0); | 41 | static const DECLARE_TLV_DB_SCALE(outpga_tlv, -5700, 100, 0); |
| 42 | static const unsigned int spkboost_tlv[] = { | 42 | static const unsigned int spkboost_tlv[] = { |
| 43 | TLV_DB_RANGE_HEAD(7), | 43 | TLV_DB_RANGE_HEAD(2), |
| 44 | 0, 6, TLV_DB_SCALE_ITEM(0, 150, 0), | 44 | 0, 6, TLV_DB_SCALE_ITEM(0, 150, 0), |
| 45 | 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), | 45 | 7, 7, TLV_DB_SCALE_ITEM(1200, 0, 0), |
| 46 | }; | 46 | }; |
diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 0268cf989736..83c4bd5b2dd7 100644 --- a/sound/soc/fsl/fsl_ssi.c +++ b/sound/soc/fsl/fsl_ssi.c | |||
| @@ -694,6 +694,7 @@ static int __devinit fsl_ssi_probe(struct platform_device *pdev) | |||
| 694 | 694 | ||
| 695 | /* Initialize the the device_attribute structure */ | 695 | /* Initialize the the device_attribute structure */ |
| 696 | dev_attr = &ssi_private->dev_attr; | 696 | dev_attr = &ssi_private->dev_attr; |
| 697 | sysfs_attr_init(&dev_attr->attr); | ||
| 697 | dev_attr->attr.name = "statistics"; | 698 | dev_attr->attr.name = "statistics"; |
| 698 | dev_attr->attr.mode = S_IRUGO; | 699 | dev_attr->attr.mode = S_IRUGO; |
| 699 | dev_attr->show = fsl_sysfs_ssi_show; | 700 | dev_attr->show = fsl_sysfs_ssi_show; |
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c index 31af405bda84..ae49f1c78c6d 100644 --- a/sound/soc/fsl/mpc8610_hpcd.c +++ b/sound/soc/fsl/mpc8610_hpcd.c | |||
| @@ -392,7 +392,8 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev) | |||
| 392 | } | 392 | } |
| 393 | 393 | ||
| 394 | if (strcasecmp(sprop, "i2s-slave") == 0) { | 394 | if (strcasecmp(sprop, "i2s-slave") == 0) { |
| 395 | machine_data->dai_format = SND_SOC_DAIFMT_I2S; | 395 | machine_data->dai_format = |
| 396 | SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM; | ||
| 396 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; | 397 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; |
| 397 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; | 398 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; |
| 398 | 399 | ||
| @@ -409,31 +410,38 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev) | |||
| 409 | } | 410 | } |
| 410 | machine_data->clk_frequency = be32_to_cpup(iprop); | 411 | machine_data->clk_frequency = be32_to_cpup(iprop); |
| 411 | } else if (strcasecmp(sprop, "i2s-master") == 0) { | 412 | } else if (strcasecmp(sprop, "i2s-master") == 0) { |
| 412 | machine_data->dai_format = SND_SOC_DAIFMT_I2S; | 413 | machine_data->dai_format = |
| 414 | SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBS_CFS; | ||
| 413 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; | 415 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; |
| 414 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; | 416 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; |
| 415 | } else if (strcasecmp(sprop, "lj-slave") == 0) { | 417 | } else if (strcasecmp(sprop, "lj-slave") == 0) { |
| 416 | machine_data->dai_format = SND_SOC_DAIFMT_LEFT_J; | 418 | machine_data->dai_format = |
| 419 | SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM; | ||
| 417 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; | 420 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; |
| 418 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; | 421 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; |
| 419 | } else if (strcasecmp(sprop, "lj-master") == 0) { | 422 | } else if (strcasecmp(sprop, "lj-master") == 0) { |
| 420 | machine_data->dai_format = SND_SOC_DAIFMT_LEFT_J; | 423 | machine_data->dai_format = |
| 424 | SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBS_CFS; | ||
| 421 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; | 425 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; |
| 422 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; | 426 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; |
| 423 | } else if (strcasecmp(sprop, "rj-slave") == 0) { | 427 | } else if (strcasecmp(sprop, "rj-slave") == 0) { |
| 424 | machine_data->dai_format = SND_SOC_DAIFMT_RIGHT_J; | 428 | machine_data->dai_format = |
| 429 | SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBM_CFM; | ||
| 425 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; | 430 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; |
| 426 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; | 431 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; |
| 427 | } else if (strcasecmp(sprop, "rj-master") == 0) { | 432 | } else if (strcasecmp(sprop, "rj-master") == 0) { |
| 428 | machine_data->dai_format = SND_SOC_DAIFMT_RIGHT_J; | 433 | machine_data->dai_format = |
| 434 | SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBS_CFS; | ||
| 429 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; | 435 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; |
| 430 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; | 436 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; |
| 431 | } else if (strcasecmp(sprop, "ac97-slave") == 0) { | 437 | } else if (strcasecmp(sprop, "ac97-slave") == 0) { |
| 432 | machine_data->dai_format = SND_SOC_DAIFMT_AC97; | 438 | machine_data->dai_format = |
| 439 | SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBM_CFM; | ||
| 433 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; | 440 | machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT; |
| 434 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; | 441 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN; |
| 435 | } else if (strcasecmp(sprop, "ac97-master") == 0) { | 442 | } else if (strcasecmp(sprop, "ac97-master") == 0) { |
| 436 | machine_data->dai_format = SND_SOC_DAIFMT_AC97; | 443 | machine_data->dai_format = |
| 444 | SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBS_CFS; | ||
| 437 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; | 445 | machine_data->codec_clk_direction = SND_SOC_CLOCK_IN; |
| 438 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; | 446 | machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT; |
| 439 | } else { | 447 | } else { |
diff --git a/sound/soc/imx/Kconfig b/sound/soc/imx/Kconfig index b133bfcc5848..738391757f2c 100644 --- a/sound/soc/imx/Kconfig +++ b/sound/soc/imx/Kconfig | |||
| @@ -28,7 +28,7 @@ config SND_MXC_SOC_WM1133_EV1 | |||
| 28 | 28 | ||
| 29 | config SND_SOC_MX27VIS_AIC32X4 | 29 | config SND_SOC_MX27VIS_AIC32X4 |
| 30 | tristate "SoC audio support for Visstrim M10 boards" | 30 | tristate "SoC audio support for Visstrim M10 boards" |
| 31 | depends on MACH_IMX27_VISSTRIM_M10 | 31 | depends on MACH_IMX27_VISSTRIM_M10 && I2C |
| 32 | select SND_SOC_TLV320AIC32X4 | 32 | select SND_SOC_TLV320AIC32X4 |
| 33 | select SND_MXC_SOC_MX2 | 33 | select SND_MXC_SOC_MX2 |
| 34 | help | 34 | help |
diff --git a/sound/soc/kirkwood/Kconfig b/sound/soc/kirkwood/Kconfig index 8f49e165f4d1..c62d715235e2 100644 --- a/sound/soc/kirkwood/Kconfig +++ b/sound/soc/kirkwood/Kconfig | |||
| @@ -12,6 +12,7 @@ config SND_KIRKWOOD_SOC_I2S | |||
| 12 | config SND_KIRKWOOD_SOC_OPENRD | 12 | config SND_KIRKWOOD_SOC_OPENRD |
| 13 | tristate "SoC Audio support for Kirkwood Openrd Client" | 13 | tristate "SoC Audio support for Kirkwood Openrd Client" |
| 14 | depends on SND_KIRKWOOD_SOC && (MACH_OPENRD_CLIENT || MACH_OPENRD_ULTIMATE) | 14 | depends on SND_KIRKWOOD_SOC && (MACH_OPENRD_CLIENT || MACH_OPENRD_ULTIMATE) |
| 15 | depends on I2C | ||
| 15 | select SND_KIRKWOOD_SOC_I2S | 16 | select SND_KIRKWOOD_SOC_I2S |
| 16 | select SND_SOC_CS42L51 | 17 | select SND_SOC_CS42L51 |
| 17 | help | 18 | help |
| @@ -20,7 +21,7 @@ config SND_KIRKWOOD_SOC_OPENRD | |||
| 20 | 21 | ||
| 21 | config SND_KIRKWOOD_SOC_T5325 | 22 | config SND_KIRKWOOD_SOC_T5325 |
| 22 | tristate "SoC Audio support for HP t5325" | 23 | tristate "SoC Audio support for HP t5325" |
| 23 | depends on SND_KIRKWOOD_SOC && MACH_T5325 | 24 | depends on SND_KIRKWOOD_SOC && MACH_T5325 && I2C |
| 24 | select SND_KIRKWOOD_SOC_I2S | 25 | select SND_KIRKWOOD_SOC_I2S |
| 25 | select SND_SOC_ALC5623 | 26 | select SND_SOC_ALC5623 |
| 26 | help | 27 | help |
diff --git a/sound/soc/mxs/mxs-pcm.c b/sound/soc/mxs/mxs-pcm.c index dea5aa4aa647..f39d7dd9fbcb 100644 --- a/sound/soc/mxs/mxs-pcm.c +++ b/sound/soc/mxs/mxs-pcm.c | |||
| @@ -357,3 +357,6 @@ static void __exit snd_mxs_pcm_exit(void) | |||
| 357 | platform_driver_unregister(&mxs_pcm_driver); | 357 | platform_driver_unregister(&mxs_pcm_driver); |
| 358 | } | 358 | } |
| 359 | module_exit(snd_mxs_pcm_exit); | 359 | module_exit(snd_mxs_pcm_exit); |
| 360 | |||
| 361 | MODULE_LICENSE("GPL"); | ||
| 362 | MODULE_ALIAS("platform:mxs-pcm-audio"); | ||
diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c index 7fbeaec06eb4..1c57f6630a48 100644 --- a/sound/soc/mxs/mxs-sgtl5000.c +++ b/sound/soc/mxs/mxs-sgtl5000.c | |||
| @@ -171,3 +171,4 @@ module_exit(mxs_sgtl5000_exit); | |||
| 171 | MODULE_AUTHOR("Freescale Semiconductor, Inc."); | 171 | MODULE_AUTHOR("Freescale Semiconductor, Inc."); |
| 172 | MODULE_DESCRIPTION("MXS ALSA SoC Machine driver"); | 172 | MODULE_DESCRIPTION("MXS ALSA SoC Machine driver"); |
| 173 | MODULE_LICENSE("GPL"); | 173 | MODULE_LICENSE("GPL"); |
| 174 | MODULE_ALIAS("platform:mxs-sgtl5000"); | ||
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c index 9c0edad90d8b..a4e3237956e2 100644 --- a/sound/soc/nuc900/nuc900-ac97.c +++ b/sound/soc/nuc900/nuc900-ac97.c | |||
| @@ -365,7 +365,8 @@ static int __devinit nuc900_ac97_drvprobe(struct platform_device *pdev) | |||
| 365 | if (ret) | 365 | if (ret) |
| 366 | goto out3; | 366 | goto out3; |
| 367 | 367 | ||
| 368 | mfp_set_groupg(nuc900_audio->dev); /* enbale ac97 multifunction pin*/ | 368 | /* enbale ac97 multifunction pin */ |
| 369 | mfp_set_groupg(nuc900_audio->dev, "nuc900-audio"); | ||
| 369 | 370 | ||
| 370 | return 0; | 371 | return 0; |
| 371 | 372 | ||
diff --git a/sound/soc/pxa/Kconfig b/sound/soc/pxa/Kconfig index ffd2242e305f..a0f7d3cfa470 100644 --- a/sound/soc/pxa/Kconfig +++ b/sound/soc/pxa/Kconfig | |||
| @@ -151,6 +151,7 @@ config SND_SOC_ZYLONITE | |||
| 151 | config SND_SOC_RAUMFELD | 151 | config SND_SOC_RAUMFELD |
| 152 | tristate "SoC Audio support Raumfeld audio adapter" | 152 | tristate "SoC Audio support Raumfeld audio adapter" |
| 153 | depends on SND_PXA2XX_SOC && (MACH_RAUMFELD_SPEAKER || MACH_RAUMFELD_CONNECTOR) | 153 | depends on SND_PXA2XX_SOC && (MACH_RAUMFELD_SPEAKER || MACH_RAUMFELD_CONNECTOR) |
| 154 | depends on I2C && SPI_MASTER | ||
| 154 | select SND_PXA_SOC_SSP | 155 | select SND_PXA_SOC_SSP |
| 155 | select SND_SOC_CS4270 | 156 | select SND_SOC_CS4270 |
| 156 | select SND_SOC_AK4104 | 157 | select SND_SOC_AK4104 |
| @@ -159,7 +160,7 @@ config SND_SOC_RAUMFELD | |||
| 159 | 160 | ||
| 160 | config SND_PXA2XX_SOC_HX4700 | 161 | config SND_PXA2XX_SOC_HX4700 |
| 161 | tristate "SoC Audio support for HP iPAQ hx4700" | 162 | tristate "SoC Audio support for HP iPAQ hx4700" |
| 162 | depends on SND_PXA2XX_SOC && MACH_H4700 | 163 | depends on SND_PXA2XX_SOC && MACH_H4700 && I2C |
| 163 | select SND_PXA2XX_SOC_I2S | 164 | select SND_PXA2XX_SOC_I2S |
| 164 | select SND_SOC_AK4641 | 165 | select SND_SOC_AK4641 |
| 165 | help | 166 | help |
diff --git a/sound/soc/pxa/hx4700.c b/sound/soc/pxa/hx4700.c index 65c124831a00..c664e33fb6d7 100644 --- a/sound/soc/pxa/hx4700.c +++ b/sound/soc/pxa/hx4700.c | |||
| @@ -209,9 +209,10 @@ static int __devinit hx4700_audio_probe(struct platform_device *pdev) | |||
| 209 | snd_soc_card_hx4700.dev = &pdev->dev; | 209 | snd_soc_card_hx4700.dev = &pdev->dev; |
| 210 | ret = snd_soc_register_card(&snd_soc_card_hx4700); | 210 | ret = snd_soc_register_card(&snd_soc_card_hx4700); |
| 211 | if (ret) | 211 | if (ret) |
| 212 | return ret; | 212 | gpio_free_array(hx4700_audio_gpios, |
| 213 | ARRAY_SIZE(hx4700_audio_gpios)); | ||
| 213 | 214 | ||
| 214 | return 0; | 215 | return ret; |
| 215 | } | 216 | } |
| 216 | 217 | ||
| 217 | static int __devexit hx4700_audio_remove(struct platform_device *pdev) | 218 | static int __devexit hx4700_audio_remove(struct platform_device *pdev) |
diff --git a/sound/soc/samsung/jive_wm8750.c b/sound/soc/samsung/jive_wm8750.c index 1826acf20f7c..8e523fd9189e 100644 --- a/sound/soc/samsung/jive_wm8750.c +++ b/sound/soc/samsung/jive_wm8750.c | |||
| @@ -101,7 +101,6 @@ static int jive_wm8750_init(struct snd_soc_pcm_runtime *rtd) | |||
| 101 | { | 101 | { |
| 102 | struct snd_soc_codec *codec = rtd->codec; | 102 | struct snd_soc_codec *codec = rtd->codec; |
| 103 | struct snd_soc_dapm_context *dapm = &codec->dapm; | 103 | struct snd_soc_dapm_context *dapm = &codec->dapm; |
| 104 | int err; | ||
| 105 | 104 | ||
| 106 | /* These endpoints are not being used. */ | 105 | /* These endpoints are not being used. */ |
| 107 | snd_soc_dapm_nc_pin(dapm, "LINPUT2"); | 106 | snd_soc_dapm_nc_pin(dapm, "LINPUT2"); |
| @@ -131,7 +130,7 @@ static struct snd_soc_card snd_soc_machine_jive = { | |||
| 131 | .dai_link = &jive_dai, | 130 | .dai_link = &jive_dai, |
| 132 | .num_links = 1, | 131 | .num_links = 1, |
| 133 | 132 | ||
| 134 | .dapm_widgtets = wm8750_dapm_widgets, | 133 | .dapm_widgets = wm8750_dapm_widgets, |
| 135 | .num_dapm_widgets = ARRAY_SIZE(wm8750_dapm_widgets), | 134 | .num_dapm_widgets = ARRAY_SIZE(wm8750_dapm_widgets), |
| 136 | .dapm_routes = audio_map, | 135 | .dapm_routes = audio_map, |
| 137 | .num_dapm_routes = ARRAY_SIZE(audio_map), | 136 | .num_dapm_routes = ARRAY_SIZE(audio_map), |
diff --git a/sound/soc/samsung/smdk2443_wm9710.c b/sound/soc/samsung/smdk2443_wm9710.c index 3a0dbfc793f0..8bd1dc5706bf 100644 --- a/sound/soc/samsung/smdk2443_wm9710.c +++ b/sound/soc/samsung/smdk2443_wm9710.c | |||
| @@ -12,6 +12,7 @@ | |||
| 12 | * | 12 | * |
| 13 | */ | 13 | */ |
| 14 | 14 | ||
| 15 | #include <linux/module.h> | ||
| 15 | #include <sound/soc.h> | 16 | #include <sound/soc.h> |
| 16 | 17 | ||
| 17 | static struct snd_soc_card smdk2443; | 18 | static struct snd_soc_card smdk2443; |
diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index f75e43997d5b..ad9ac42522e2 100644 --- a/sound/soc/samsung/smdk_wm8994.c +++ b/sound/soc/samsung/smdk_wm8994.c | |||
| @@ -9,6 +9,7 @@ | |||
| 9 | 9 | ||
| 10 | #include "../codecs/wm8994.h" | 10 | #include "../codecs/wm8994.h" |
| 11 | #include <sound/pcm_params.h> | 11 | #include <sound/pcm_params.h> |
| 12 | #include <linux/module.h> | ||
| 12 | 13 | ||
| 13 | /* | 14 | /* |
| 14 | * Default CFG switch settings to use this driver: | 15 | * Default CFG switch settings to use this driver: |
diff --git a/sound/soc/samsung/speyside.c b/sound/soc/samsung/speyside.c index 85bf541a771d..4b8e35410eb1 100644 --- a/sound/soc/samsung/speyside.c +++ b/sound/soc/samsung/speyside.c | |||
| @@ -191,7 +191,7 @@ static int speyside_late_probe(struct snd_soc_card *card) | |||
| 191 | snd_soc_dapm_ignore_suspend(&card->dapm, "Headset Mic"); | 191 | snd_soc_dapm_ignore_suspend(&card->dapm, "Headset Mic"); |
| 192 | snd_soc_dapm_ignore_suspend(&card->dapm, "Main AMIC"); | 192 | snd_soc_dapm_ignore_suspend(&card->dapm, "Main AMIC"); |
| 193 | snd_soc_dapm_ignore_suspend(&card->dapm, "Main DMIC"); | 193 | snd_soc_dapm_ignore_suspend(&card->dapm, "Main DMIC"); |
| 194 | snd_soc_dapm_ignore_suspend(&card->dapm, "Speaker"); | 194 | snd_soc_dapm_ignore_suspend(&card->dapm, "Main Speaker"); |
| 195 | snd_soc_dapm_ignore_suspend(&card->dapm, "WM1250 Output"); | 195 | snd_soc_dapm_ignore_suspend(&card->dapm, "WM1250 Output"); |
| 196 | snd_soc_dapm_ignore_suspend(&card->dapm, "WM1250 Input"); | 196 | snd_soc_dapm_ignore_suspend(&card->dapm, "WM1250 Input"); |
| 197 | 197 | ||
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index a5d3685a5d38..a25fa63ce9a2 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c | |||
| @@ -709,6 +709,12 @@ int snd_soc_resume(struct device *dev) | |||
| 709 | struct snd_soc_card *card = dev_get_drvdata(dev); | 709 | struct snd_soc_card *card = dev_get_drvdata(dev); |
| 710 | int i, ac97_control = 0; | 710 | int i, ac97_control = 0; |
| 711 | 711 | ||
| 712 | /* If the initialization of this soc device failed, there is no codec | ||
| 713 | * associated with it. Just bail out in this case. | ||
| 714 | */ | ||
| 715 | if (list_empty(&card->codec_dev_list)) | ||
| 716 | return 0; | ||
| 717 | |||
| 712 | /* AC97 devices might have other drivers hanging off them so | 718 | /* AC97 devices might have other drivers hanging off them so |
| 713 | * need to resume immediately. Other drivers don't have that | 719 | * need to resume immediately. Other drivers don't have that |
| 714 | * problem and may take a substantial amount of time to resume | 720 | * problem and may take a substantial amount of time to resume |
diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c index 0c12b98484bd..4220bb0f2730 100644 --- a/sound/soc/soc-utils.c +++ b/sound/soc/soc-utils.c | |||
| @@ -58,7 +58,36 @@ int snd_soc_params_to_bclk(struct snd_pcm_hw_params *params) | |||
| 58 | } | 58 | } |
| 59 | EXPORT_SYMBOL_GPL(snd_soc_params_to_bclk); | 59 | EXPORT_SYMBOL_GPL(snd_soc_params_to_bclk); |
| 60 | 60 | ||
| 61 | static struct snd_soc_platform_driver dummy_platform; | 61 | static const struct snd_pcm_hardware dummy_dma_hardware = { |
| 62 | .formats = 0xffffffff, | ||
| 63 | .channels_min = 1, | ||
| 64 | .channels_max = UINT_MAX, | ||
| 65 | |||
| 66 | /* Random values to keep userspace happy when checking constraints */ | ||
| 67 | .info = SNDRV_PCM_INFO_INTERLEAVED | | ||
| 68 | SNDRV_PCM_INFO_BLOCK_TRANSFER, | ||
| 69 | .buffer_bytes_max = 128*1024, | ||
| 70 | .period_bytes_min = PAGE_SIZE, | ||
| 71 | .period_bytes_max = PAGE_SIZE*2, | ||
| 72 | .periods_min = 2, | ||
| 73 | .periods_max = 128, | ||
| 74 | }; | ||
| 75 | |||
| 76 | static int dummy_dma_open(struct snd_pcm_substream *substream) | ||
| 77 | { | ||
| 78 | snd_soc_set_runtime_hwparams(substream, &dummy_dma_hardware); | ||
| 79 | |||
| 80 | return 0; | ||
| 81 | } | ||
| 82 | |||
| 83 | static struct snd_pcm_ops dummy_dma_ops = { | ||
| 84 | .open = dummy_dma_open, | ||
| 85 | .ioctl = snd_pcm_lib_ioctl, | ||
| 86 | }; | ||
| 87 | |||
| 88 | static struct snd_soc_platform_driver dummy_platform = { | ||
| 89 | .ops = &dummy_dma_ops, | ||
| 90 | }; | ||
| 62 | 91 | ||
| 63 | static __devinit int snd_soc_dummy_probe(struct platform_device *pdev) | 92 | static __devinit int snd_soc_dummy_probe(struct platform_device *pdev) |
| 64 | { | 93 | { |
diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h index b61945f3af9e..32d2a21f2e3b 100644 --- a/sound/usb/quirks-table.h +++ b/sound/usb/quirks-table.h | |||
| @@ -1633,6 +1633,37 @@ YAMAHA_DEVICE(0x7010, "UB99"), | |||
| 1633 | } | 1633 | } |
| 1634 | }, | 1634 | }, |
| 1635 | { | 1635 | { |
| 1636 | /* Roland GAIA SH-01 */ | ||
| 1637 | USB_DEVICE(0x0582, 0x0111), | ||
| 1638 | .driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) { | ||
| 1639 | .vendor_name = "Roland", | ||
| 1640 | .product_name = "GAIA", | ||
| 1641 | .ifnum = QUIRK_ANY_INTERFACE, | ||
| 1642 | .type = QUIRK_COMPOSITE, | ||
| 1643 | .data = (const struct snd_usb_audio_quirk[]) { | ||
| 1644 | { | ||
| 1645 | .ifnum = 0, | ||
| 1646 | .type = QUIRK_AUDIO_STANDARD_INTERFACE | ||
| 1647 | }, | ||
| 1648 | { | ||
| 1649 | .ifnum = 1, | ||
| 1650 | .type = QUIRK_AUDIO_STANDARD_INTERFACE | ||
| 1651 | }, | ||
| 1652 | { | ||
| 1653 | .ifnum = 2, | ||
| 1654 | .type = QUIRK_MIDI_FIXED_ENDPOINT, | ||
| 1655 | .data = &(const struct snd_usb_midi_endpoint_info) { | ||
| 1656 | .out_cables = 0x0003, | ||
| 1657 | .in_cables = 0x0003 | ||
| 1658 | } | ||
| 1659 | }, | ||
| 1660 | { | ||
| 1661 | .ifnum = -1 | ||
| 1662 | } | ||
| 1663 | } | ||
| 1664 | } | ||
| 1665 | }, | ||
| 1666 | { | ||
| 1636 | USB_DEVICE(0x0582, 0x0113), | 1667 | USB_DEVICE(0x0582, 0x0113), |
| 1637 | .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { | 1668 | .driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) { |
| 1638 | /* .vendor_name = "BOSS", */ | 1669 | /* .vendor_name = "BOSS", */ |
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 7d98676808d8..955930e0a5c3 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c | |||
| @@ -463,7 +463,8 @@ static int run_perf_stat(int argc __used, const char **argv) | |||
| 463 | 463 | ||
| 464 | list_for_each_entry(counter, &evsel_list->entries, node) { | 464 | list_for_each_entry(counter, &evsel_list->entries, node) { |
| 465 | if (create_perf_stat_counter(counter, first) < 0) { | 465 | if (create_perf_stat_counter(counter, first) < 0) { |
| 466 | if (errno == EINVAL || errno == ENOSYS || errno == ENOENT) { | 466 | if (errno == EINVAL || errno == ENOSYS || |
| 467 | errno == ENOENT || errno == EOPNOTSUPP) { | ||
| 467 | if (verbose) | 468 | if (verbose) |
| 468 | ui__warning("%s event is not supported by the kernel.\n", | 469 | ui__warning("%s event is not supported by the kernel.\n", |
| 469 | event_name(counter)); | 470 | event_name(counter)); |
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index e42626422587..d7915d4e77cb 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c | |||
| @@ -34,6 +34,16 @@ int __perf_evsel__sample_size(u64 sample_type) | |||
| 34 | return size; | 34 | return size; |
| 35 | } | 35 | } |
| 36 | 36 | ||
| 37 | static void hists__init(struct hists *hists) | ||
| 38 | { | ||
| 39 | memset(hists, 0, sizeof(*hists)); | ||
| 40 | hists->entries_in_array[0] = hists->entries_in_array[1] = RB_ROOT; | ||
| 41 | hists->entries_in = &hists->entries_in_array[0]; | ||
| 42 | hists->entries_collapsed = RB_ROOT; | ||
| 43 | hists->entries = RB_ROOT; | ||
| 44 | pthread_mutex_init(&hists->lock, NULL); | ||
| 45 | } | ||
| 46 | |||
| 37 | void perf_evsel__init(struct perf_evsel *evsel, | 47 | void perf_evsel__init(struct perf_evsel *evsel, |
| 38 | struct perf_event_attr *attr, int idx) | 48 | struct perf_event_attr *attr, int idx) |
| 39 | { | 49 | { |
diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index bcd05d05b4f0..33c17a2b2a81 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c | |||
| @@ -388,7 +388,7 @@ static int write_event_desc(int fd, struct perf_header *h __used, | |||
| 388 | /* | 388 | /* |
| 389 | * write event string as passed on cmdline | 389 | * write event string as passed on cmdline |
| 390 | */ | 390 | */ |
| 391 | ret = do_write_string(fd, attr->name); | 391 | ret = do_write_string(fd, event_name(attr)); |
| 392 | if (ret < 0) | 392 | if (ret < 0) |
| 393 | return ret; | 393 | return ret; |
| 394 | /* | 394 | /* |
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index a36a3fa81ffb..abef2703cd24 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c | |||
| @@ -1211,13 +1211,3 @@ size_t hists__fprintf_nr_events(struct hists *hists, FILE *fp) | |||
| 1211 | 1211 | ||
| 1212 | return ret; | 1212 | return ret; |
| 1213 | } | 1213 | } |
| 1214 | |||
| 1215 | void hists__init(struct hists *hists) | ||
| 1216 | { | ||
| 1217 | memset(hists, 0, sizeof(*hists)); | ||
| 1218 | hists->entries_in_array[0] = hists->entries_in_array[1] = RB_ROOT; | ||
| 1219 | hists->entries_in = &hists->entries_in_array[0]; | ||
| 1220 | hists->entries_collapsed = RB_ROOT; | ||
| 1221 | hists->entries = RB_ROOT; | ||
| 1222 | pthread_mutex_init(&hists->lock, NULL); | ||
| 1223 | } | ||
diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h index c86c1d27bd1e..89289c8e935e 100644 --- a/tools/perf/util/hist.h +++ b/tools/perf/util/hist.h | |||
| @@ -63,8 +63,6 @@ struct hists { | |||
| 63 | struct callchain_cursor callchain_cursor; | 63 | struct callchain_cursor callchain_cursor; |
| 64 | }; | 64 | }; |
| 65 | 65 | ||
| 66 | void hists__init(struct hists *hists); | ||
| 67 | |||
| 68 | struct hist_entry *__hists__add_entry(struct hists *self, | 66 | struct hist_entry *__hists__add_entry(struct hists *self, |
| 69 | struct addr_location *al, | 67 | struct addr_location *al, |
| 70 | struct symbol *parent, u64 period); | 68 | struct symbol *parent, u64 period); |
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c index 85c1e6b76f0a..0f4555ce9063 100644 --- a/tools/perf/util/session.c +++ b/tools/perf/util/session.c | |||
| @@ -1333,6 +1333,10 @@ int perf_session__cpu_bitmap(struct perf_session *session, | |||
| 1333 | } | 1333 | } |
| 1334 | 1334 | ||
| 1335 | map = cpu_map__new(cpu_list); | 1335 | map = cpu_map__new(cpu_list); |
| 1336 | if (map == NULL) { | ||
| 1337 | pr_err("Invalid cpu_list\n"); | ||
| 1338 | return -1; | ||
| 1339 | } | ||
| 1336 | 1340 | ||
| 1337 | for (i = 0; i < map->nr; i++) { | 1341 | for (i = 0; i < map->nr; i++) { |
| 1338 | int cpu = map->map[i]; | 1342 | int cpu = map->map[i]; |
diff --git a/tools/perf/util/trace-event-parse.c b/tools/perf/util/trace-event-parse.c index 0a7ed5b5e281..6c164dc9ee95 100644 --- a/tools/perf/util/trace-event-parse.c +++ b/tools/perf/util/trace-event-parse.c | |||
| @@ -1537,6 +1537,8 @@ process_flags(struct event *event, struct print_arg *arg, char **tok) | |||
| 1537 | field = malloc_or_die(sizeof(*field)); | 1537 | field = malloc_or_die(sizeof(*field)); |
| 1538 | 1538 | ||
| 1539 | type = process_arg(event, field, &token); | 1539 | type = process_arg(event, field, &token); |
| 1540 | while (type == EVENT_OP) | ||
| 1541 | type = process_op(event, field, &token); | ||
| 1540 | if (test_type_token(type, token, EVENT_DELIM, ",")) | 1542 | if (test_type_token(type, token, EVENT_DELIM, ",")) |
| 1541 | goto out_free; | 1543 | goto out_free; |
| 1542 | 1544 | ||
