diff options
author | David S. Miller <davem@davemloft.net> | 2013-10-23 16:58:52 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-10-23 16:58:52 -0400 |
commit | df33db0f5efe8895203d221b9e701c0a61832c76 (patch) | |
tree | d1835e5b728f09bc269f14c042143b3070eab1db | |
parent | 305a3388b5b3121aff6b10054136b40ca91ab35b (diff) | |
parent | a3b8a16b802469884c1597414911c8b4d2117674 (diff) |
Merge branch 'pci_set_drvdata'
Jingoo Han syas:
====================
ethernet: remove unnecessary pci_set_drvdata() part 4
Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
(device-core: Ensure drvdata = NULL when no driver is bound),
the driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
====================
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/sun/niu.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/sun/sungem.c | 2 | ||||
-rw-r--r-- | drivers/net/ethernet/tehuti/tehuti.c | 1 | ||||
-rw-r--r-- | drivers/net/ethernet/ti/tlan.c | 1 | ||||
-rw-r--r-- | drivers/net/ethernet/toshiba/spider_net.c | 1 | ||||
-rw-r--r-- | drivers/net/ethernet/toshiba/tc35815.c | 1 | ||||
-rw-r--r-- | drivers/net/ethernet/via/via-rhine.c | 1 |
7 files changed, 0 insertions, 9 deletions
diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index f28460ce24a7..388540fcb977 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c | |||
@@ -9875,7 +9875,6 @@ err_out_free_res: | |||
9875 | 9875 | ||
9876 | err_out_disable_pdev: | 9876 | err_out_disable_pdev: |
9877 | pci_disable_device(pdev); | 9877 | pci_disable_device(pdev); |
9878 | pci_set_drvdata(pdev, NULL); | ||
9879 | 9878 | ||
9880 | return err; | 9879 | return err; |
9881 | } | 9880 | } |
@@ -9900,7 +9899,6 @@ static void niu_pci_remove_one(struct pci_dev *pdev) | |||
9900 | free_netdev(dev); | 9899 | free_netdev(dev); |
9901 | pci_release_regions(pdev); | 9900 | pci_release_regions(pdev); |
9902 | pci_disable_device(pdev); | 9901 | pci_disable_device(pdev); |
9903 | pci_set_drvdata(pdev, NULL); | ||
9904 | } | 9902 | } |
9905 | } | 9903 | } |
9906 | 9904 | ||
diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index a235bd9fd980..b5655b79bd3b 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c | |||
@@ -2806,8 +2806,6 @@ static void gem_remove_one(struct pci_dev *pdev) | |||
2806 | iounmap(gp->regs); | 2806 | iounmap(gp->regs); |
2807 | pci_release_regions(pdev); | 2807 | pci_release_regions(pdev); |
2808 | free_netdev(dev); | 2808 | free_netdev(dev); |
2809 | |||
2810 | pci_set_drvdata(pdev, NULL); | ||
2811 | } | 2809 | } |
2812 | } | 2810 | } |
2813 | 2811 | ||
diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index 571452e786d5..dd0dd6279b4e 100644 --- a/drivers/net/ethernet/tehuti/tehuti.c +++ b/drivers/net/ethernet/tehuti/tehuti.c | |||
@@ -2447,7 +2447,6 @@ static void bdx_remove(struct pci_dev *pdev) | |||
2447 | iounmap(nic->regs); | 2447 | iounmap(nic->regs); |
2448 | pci_release_regions(pdev); | 2448 | pci_release_regions(pdev); |
2449 | pci_disable_device(pdev); | 2449 | pci_disable_device(pdev); |
2450 | pci_set_drvdata(pdev, NULL); | ||
2451 | vfree(nic); | 2450 | vfree(nic); |
2452 | 2451 | ||
2453 | RET(); | 2452 | RET(); |
diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c index 591437e59b90..62b19be5183d 100644 --- a/drivers/net/ethernet/ti/tlan.c +++ b/drivers/net/ethernet/ti/tlan.c | |||
@@ -319,7 +319,6 @@ static void tlan_remove_one(struct pci_dev *pdev) | |||
319 | 319 | ||
320 | free_netdev(dev); | 320 | free_netdev(dev); |
321 | 321 | ||
322 | pci_set_drvdata(pdev, NULL); | ||
323 | cancel_work_sync(&priv->tlan_tqueue); | 322 | cancel_work_sync(&priv->tlan_tqueue); |
324 | } | 323 | } |
325 | 324 | ||
diff --git a/drivers/net/ethernet/toshiba/spider_net.c b/drivers/net/ethernet/toshiba/spider_net.c index 5734480c1ecf..3f4a32e39d27 100644 --- a/drivers/net/ethernet/toshiba/spider_net.c +++ b/drivers/net/ethernet/toshiba/spider_net.c | |||
@@ -2478,7 +2478,6 @@ out_release_regions: | |||
2478 | pci_release_regions(pdev); | 2478 | pci_release_regions(pdev); |
2479 | out_disable_dev: | 2479 | out_disable_dev: |
2480 | pci_disable_device(pdev); | 2480 | pci_disable_device(pdev); |
2481 | pci_set_drvdata(pdev, NULL); | ||
2482 | return NULL; | 2481 | return NULL; |
2483 | } | 2482 | } |
2484 | 2483 | ||
diff --git a/drivers/net/ethernet/toshiba/tc35815.c b/drivers/net/ethernet/toshiba/tc35815.c index a971b9cca564..1322546d92ac 100644 --- a/drivers/net/ethernet/toshiba/tc35815.c +++ b/drivers/net/ethernet/toshiba/tc35815.c | |||
@@ -887,7 +887,6 @@ static void tc35815_remove_one(struct pci_dev *pdev) | |||
887 | mdiobus_free(lp->mii_bus); | 887 | mdiobus_free(lp->mii_bus); |
888 | unregister_netdev(dev); | 888 | unregister_netdev(dev); |
889 | free_netdev(dev); | 889 | free_netdev(dev); |
890 | pci_set_drvdata(pdev, NULL); | ||
891 | } | 890 | } |
892 | 891 | ||
893 | static int | 892 | static int |
diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c index bdf697b184ae..4a7293ed95e9 100644 --- a/drivers/net/ethernet/via/via-rhine.c +++ b/drivers/net/ethernet/via/via-rhine.c | |||
@@ -2292,7 +2292,6 @@ static void rhine_remove_one(struct pci_dev *pdev) | |||
2292 | 2292 | ||
2293 | free_netdev(dev); | 2293 | free_netdev(dev); |
2294 | pci_disable_device(pdev); | 2294 | pci_disable_device(pdev); |
2295 | pci_set_drvdata(pdev, NULL); | ||
2296 | } | 2295 | } |
2297 | 2296 | ||
2298 | static void rhine_shutdown (struct pci_dev *pdev) | 2297 | static void rhine_shutdown (struct pci_dev *pdev) |