diff options
author | Amit Kumar Salecha <amit.salecha@qlogic.com> | 2010-05-12 23:07:43 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-05-14 06:06:53 -0400 |
commit | deffab05308f783482d11c1bb52f24afa94cd632 (patch) | |
tree | cb2e4bf95cd74451de33aedb5bd76dab28ab04bf | |
parent | 2372a5f1c869fd1e4dc11fb41600197fcce1121c (diff) |
qlcnic: remove obsolete register
MSI_MODE, CAPABILITIES_FW and SCRATCHPAD registers are obsolete.
Driver should not use them.
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/qlcnic/qlcnic_ethtool.c | 9 | ||||
-rw-r--r-- | drivers/net/qlcnic/qlcnic_hdr.h | 7 | ||||
-rw-r--r-- | drivers/net/qlcnic/qlcnic_init.c | 1 |
3 files changed, 1 insertions, 16 deletions
diff --git a/drivers/net/qlcnic/qlcnic_ethtool.c b/drivers/net/qlcnic/qlcnic_ethtool.c index 6cdc5ebb7411..e494cccf8a93 100644 --- a/drivers/net/qlcnic/qlcnic_ethtool.c +++ b/drivers/net/qlcnic/qlcnic_ethtool.c | |||
@@ -606,19 +606,12 @@ qlcnic_set_pauseparam(struct net_device *netdev, | |||
606 | static int qlcnic_reg_test(struct net_device *dev) | 606 | static int qlcnic_reg_test(struct net_device *dev) |
607 | { | 607 | { |
608 | struct qlcnic_adapter *adapter = netdev_priv(dev); | 608 | struct qlcnic_adapter *adapter = netdev_priv(dev); |
609 | u32 data_read, data_written; | 609 | u32 data_read; |
610 | 610 | ||
611 | data_read = QLCRD32(adapter, QLCNIC_PCIX_PH_REG(0)); | 611 | data_read = QLCRD32(adapter, QLCNIC_PCIX_PH_REG(0)); |
612 | if ((data_read & 0xffff) != adapter->pdev->vendor) | 612 | if ((data_read & 0xffff) != adapter->pdev->vendor) |
613 | return 1; | 613 | return 1; |
614 | 614 | ||
615 | data_written = (u32)0xa5a5a5a5; | ||
616 | |||
617 | QLCWR32(adapter, CRB_SCRATCHPAD_TEST, data_written); | ||
618 | data_read = QLCRD32(adapter, CRB_SCRATCHPAD_TEST); | ||
619 | if (data_written != data_read) | ||
620 | return 1; | ||
621 | |||
622 | return 0; | 615 | return 0; |
623 | } | 616 | } |
624 | 617 | ||
diff --git a/drivers/net/qlcnic/qlcnic_hdr.h b/drivers/net/qlcnic/qlcnic_hdr.h index a984cd227582..13740785d051 100644 --- a/drivers/net/qlcnic/qlcnic_hdr.h +++ b/drivers/net/qlcnic/qlcnic_hdr.h | |||
@@ -585,15 +585,8 @@ enum { | |||
585 | * for backward compability | 585 | * for backward compability |
586 | */ | 586 | */ |
587 | #define CRB_NIC_CAPABILITIES_HOST QLCNIC_REG(0x1a8) | 587 | #define CRB_NIC_CAPABILITIES_HOST QLCNIC_REG(0x1a8) |
588 | #define CRB_NIC_CAPABILITIES_FW QLCNIC_REG(0x1dc) | ||
589 | #define CRB_NIC_MSI_MODE_HOST QLCNIC_REG(0x270) | ||
590 | #define CRB_NIC_MSI_MODE_FW QLCNIC_REG(0x274) | ||
591 | 588 | ||
592 | #define INTR_SCHEME_PERPORT 0x1 | 589 | #define INTR_SCHEME_PERPORT 0x1 |
593 | #define MSI_MODE_MULTIFUNC 0x1 | ||
594 | |||
595 | /* used for ethtool tests */ | ||
596 | #define CRB_SCRATCHPAD_TEST QLCNIC_REG(0x280) | ||
597 | 590 | ||
598 | /* | 591 | /* |
599 | * CrbPortPhanCntrHi/Lo is used to pass the address of HostPhantomIndex address | 592 | * CrbPortPhanCntrHi/Lo is used to pass the address of HostPhantomIndex address |
diff --git a/drivers/net/qlcnic/qlcnic_init.c b/drivers/net/qlcnic/qlcnic_init.c index 1b621ca13e25..9b010422e9a6 100644 --- a/drivers/net/qlcnic/qlcnic_init.c +++ b/drivers/net/qlcnic/qlcnic_init.c | |||
@@ -1189,7 +1189,6 @@ int qlcnic_init_firmware(struct qlcnic_adapter *adapter) | |||
1189 | return err; | 1189 | return err; |
1190 | 1190 | ||
1191 | QLCWR32(adapter, CRB_NIC_CAPABILITIES_HOST, INTR_SCHEME_PERPORT); | 1191 | QLCWR32(adapter, CRB_NIC_CAPABILITIES_HOST, INTR_SCHEME_PERPORT); |
1192 | QLCWR32(adapter, CRB_NIC_MSI_MODE_HOST, MSI_MODE_MULTIFUNC); | ||
1193 | QLCWR32(adapter, CRB_MPORT_MODE, MPORT_MULTI_FUNCTION_MODE); | 1192 | QLCWR32(adapter, CRB_MPORT_MODE, MPORT_MULTI_FUNCTION_MODE); |
1194 | QLCWR32(adapter, CRB_CMDPEG_STATE, PHAN_INITIALIZE_ACK); | 1193 | QLCWR32(adapter, CRB_CMDPEG_STATE, PHAN_INITIALIZE_ACK); |
1195 | 1194 | ||