aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeorgi Chorbadzhiyski <gf@unixsol.org>2014-01-16 10:07:11 -0500
committerMauro Carvalho Chehab <m.chehab@samsung.com>2014-02-04 10:07:01 -0500
commitdef62216041a63d45d0fd0ff014abdc9832ee611 (patch)
tree835ee5f7f99c89d11d6b77ee0d3fdf8831d15393
parent692a228e9ae419b3f51e94d1c60c1b18f37e3676 (diff)
[media] FE_READ_SNR and FE_READ_SIGNAL_STRENGTH docs
Around 01/14/2014 06:07 PM, Mauro Carvalho Chehab scribbled: > Em Tue, 14 Jan 2014 17:55:19 +0200 > Georgi Chorbadzhiyski <gf@unixsol.org> escreveu: >> Around 01/14/2014 05:30 PM, Mauro Carvalho Chehab scribbled: >>> Em Tue, 14 Jan 2014 17:16:10 +0200 >>> Georgi Chorbadzhiyski <gf@unixsol.org> escreveu: >>> >>>> Hi guys, I'm confused the documentation on: >>>> >>>> http://linuxtv.org/downloads/v4l-dvb-apis/frontend_fcalls.html#FE_READ_SNR >>>> http://linuxtv.org/downloads/v4l-dvb-apis/frontend_fcalls.html#FE_READ_SIGNAL_STRENGTH >>>> >>>> states that these ioctls return int16_t values but frontend.h states: >>>> >>>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/dvb/frontend.h >>>> >>>> #define FE_READ_SIGNAL_STRENGTH _IOR('o', 71, __u16) >>>> #define FE_READ_SNR _IOR('o', 72, __u16) >>>> >>>> So which one is true? >>> >>> Documentation is wrong. The returned values are unsigned. Would you mind send >>> us a patch fixing it? >> >> I would be happy to, but I can't find the repo that holds the documentation. > > It is in the Kernel tree, under Documentation/DocBook/media/dvb. The attached file contains the discussed documentation fixes. Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
-rw-r--r--Documentation/DocBook/media/dvb/frontend.xml8
1 files changed, 4 insertions, 4 deletions
diff --git a/Documentation/DocBook/media/dvb/frontend.xml b/Documentation/DocBook/media/dvb/frontend.xml
index 0d6e81bd9ed2..8a6a6ff27af5 100644
--- a/Documentation/DocBook/media/dvb/frontend.xml
+++ b/Documentation/DocBook/media/dvb/frontend.xml
@@ -744,7 +744,7 @@ typedef enum fe_hierarchy {
744</para> 744</para>
745<informaltable><tgroup cols="1"><tbody><row><entry 745<informaltable><tgroup cols="1"><tbody><row><entry
746 align="char"> 746 align="char">
747<para>int ioctl(int fd, int request = <link linkend="FE_READ_SNR">FE_READ_SNR</link>, int16_t 747<para>int ioctl(int fd, int request = <link linkend="FE_READ_SNR">FE_READ_SNR</link>, uint16_t
748 &#x22C6;snr);</para> 748 &#x22C6;snr);</para>
749</entry> 749</entry>
750 </row></tbody></tgroup></informaltable> 750 </row></tbody></tgroup></informaltable>
@@ -766,7 +766,7 @@ typedef enum fe_hierarchy {
766</entry> 766</entry>
767 </row><row><entry 767 </row><row><entry
768 align="char"> 768 align="char">
769<para>int16_t *snr</para> 769<para>uint16_t *snr</para>
770</entry><entry 770</entry><entry
771 align="char"> 771 align="char">
772<para>The signal-to-noise ratio is stored into *snr.</para> 772<para>The signal-to-noise ratio is stored into *snr.</para>
@@ -791,7 +791,7 @@ typedef enum fe_hierarchy {
791<informaltable><tgroup cols="1"><tbody><row><entry 791<informaltable><tgroup cols="1"><tbody><row><entry
792 align="char"> 792 align="char">
793<para>int ioctl( int fd, int request = 793<para>int ioctl( int fd, int request =
794 <link linkend="FE_READ_SIGNAL_STRENGTH">FE_READ_SIGNAL_STRENGTH</link>, int16_t &#x22C6;strength);</para> 794 <link linkend="FE_READ_SIGNAL_STRENGTH">FE_READ_SIGNAL_STRENGTH</link>, uint16_t &#x22C6;strength);</para>
795</entry> 795</entry>
796 </row></tbody></tgroup></informaltable> 796 </row></tbody></tgroup></informaltable>
797 797
@@ -814,7 +814,7 @@ typedef enum fe_hierarchy {
814</entry> 814</entry>
815 </row><row><entry 815 </row><row><entry
816 align="char"> 816 align="char">
817<para>int16_t *strength</para> 817<para>uint16_t *strength</para>
818</entry><entry 818</entry><entry
819 align="char"> 819 align="char">
820<para>The signal strength value is stored into *strength.</para> 820<para>The signal strength value is stored into *strength.</para>