aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Senna Tschudin <peter.senna@gmail.com>2013-10-02 08:19:50 -0400
committerDavid S. Miller <davem@davemloft.net>2013-10-03 15:40:33 -0400
commitde36cef3e76e6e912f311759d7849bc6e81882cf (patch)
tree80e397b243a6174cadd8ad240b1e3a8c6cda1bc7
parentb85d717c1b66a40f006148a31e6bbb88ca6b45c0 (diff)
net: myri10ge: Change variable type to bool
There is the rc variable on both myri10ge_ss_lock_napi and myri10ge_ss_lock_poll functions. In both cases rc is only assigned the values true and false. Both functions already return bool. Change rc type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\) Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/ethernet/myricom/myri10ge/myri10ge.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
index 6ddaf7b3d92e..1975550c3634 100644
--- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
+++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c
@@ -934,7 +934,7 @@ static inline void myri10ge_ss_init_lock(struct myri10ge_slice_state *ss)
934 934
935static inline bool myri10ge_ss_lock_napi(struct myri10ge_slice_state *ss) 935static inline bool myri10ge_ss_lock_napi(struct myri10ge_slice_state *ss)
936{ 936{
937 int rc = true; 937 bool rc = true;
938 spin_lock(&ss->lock); 938 spin_lock(&ss->lock);
939 if ((ss->state & SLICE_LOCKED)) { 939 if ((ss->state & SLICE_LOCKED)) {
940 WARN_ON((ss->state & SLICE_STATE_NAPI)); 940 WARN_ON((ss->state & SLICE_STATE_NAPI));
@@ -957,7 +957,7 @@ static inline void myri10ge_ss_unlock_napi(struct myri10ge_slice_state *ss)
957 957
958static inline bool myri10ge_ss_lock_poll(struct myri10ge_slice_state *ss) 958static inline bool myri10ge_ss_lock_poll(struct myri10ge_slice_state *ss)
959{ 959{
960 int rc = true; 960 bool rc = true;
961 spin_lock_bh(&ss->lock); 961 spin_lock_bh(&ss->lock);
962 if ((ss->state & SLICE_LOCKED)) { 962 if ((ss->state & SLICE_LOCKED)) {
963 ss->state |= SLICE_STATE_POLL_YIELD; 963 ss->state |= SLICE_STATE_POLL_YIELD;