diff options
author | Tiejun Chen <tiejun.chen@windriver.com> | 2013-07-15 23:09:30 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2013-08-14 00:57:47 -0400 |
commit | de021bb79c7636df24864fa2dbb958121303663b (patch) | |
tree | c2833f1a4ac4455b2b4f1ca2bc19d0e3a321fcf2 | |
parent | 7033b64b48a3eafdd5d5f541ff6ccb96f69d9911 (diff) |
powerpc/ppc64: Rename SOFT_DISABLE_INTS with RECONCILE_IRQ_STATE
The SOFT_DISABLE_INTS seems an odd name for something that updates the
software state to be consistent with interrupts being hard disabled, so
rename SOFT_DISABLE_INTS with RECONCILE_IRQ_STATE to avoid this confusion.
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r-- | arch/powerpc/include/asm/exception-64s.h | 2 | ||||
-rw-r--r-- | arch/powerpc/include/asm/irqflags.h | 7 | ||||
-rw-r--r-- | arch/powerpc/kernel/entry_64.S | 4 | ||||
-rw-r--r-- | arch/powerpc/kernel/exceptions-64e.S | 4 |
4 files changed, 9 insertions, 8 deletions
diff --git a/arch/powerpc/include/asm/exception-64s.h b/arch/powerpc/include/asm/exception-64s.h index 07ca627e52c0..4834a6d5a75c 100644 --- a/arch/powerpc/include/asm/exception-64s.h +++ b/arch/powerpc/include/asm/exception-64s.h | |||
@@ -479,7 +479,7 @@ label##_relon_hv: \ | |||
479 | */ | 479 | */ |
480 | 480 | ||
481 | /* Exception addition: Hard disable interrupts */ | 481 | /* Exception addition: Hard disable interrupts */ |
482 | #define DISABLE_INTS SOFT_DISABLE_INTS(r10,r11) | 482 | #define DISABLE_INTS RECONCILE_IRQ_STATE(r10,r11) |
483 | 483 | ||
484 | #define ADD_NVGPRS \ | 484 | #define ADD_NVGPRS \ |
485 | bl .save_nvgprs | 485 | bl .save_nvgprs |
diff --git a/arch/powerpc/include/asm/irqflags.h b/arch/powerpc/include/asm/irqflags.h index 6f9b6e23dc5a..f51a5580bfd0 100644 --- a/arch/powerpc/include/asm/irqflags.h +++ b/arch/powerpc/include/asm/irqflags.h | |||
@@ -40,9 +40,10 @@ | |||
40 | #define TRACE_DISABLE_INTS TRACE_WITH_FRAME_BUFFER(.trace_hardirqs_off) | 40 | #define TRACE_DISABLE_INTS TRACE_WITH_FRAME_BUFFER(.trace_hardirqs_off) |
41 | 41 | ||
42 | /* | 42 | /* |
43 | * This is used by assembly code to soft-disable interrupts | 43 | * This is used by assembly code to soft-disable interrupts first and |
44 | * reconcile irq state. | ||
44 | */ | 45 | */ |
45 | #define SOFT_DISABLE_INTS(__rA, __rB) \ | 46 | #define RECONCILE_IRQ_STATE(__rA, __rB) \ |
46 | lbz __rA,PACASOFTIRQEN(r13); \ | 47 | lbz __rA,PACASOFTIRQEN(r13); \ |
47 | lbz __rB,PACAIRQHAPPENED(r13); \ | 48 | lbz __rB,PACAIRQHAPPENED(r13); \ |
48 | cmpwi cr0,__rA,0; \ | 49 | cmpwi cr0,__rA,0; \ |
@@ -58,7 +59,7 @@ | |||
58 | #define TRACE_ENABLE_INTS | 59 | #define TRACE_ENABLE_INTS |
59 | #define TRACE_DISABLE_INTS | 60 | #define TRACE_DISABLE_INTS |
60 | 61 | ||
61 | #define SOFT_DISABLE_INTS(__rA, __rB) \ | 62 | #define RECONCILE_IRQ_STATE(__rA, __rB) \ |
62 | lbz __rA,PACAIRQHAPPENED(r13); \ | 63 | lbz __rA,PACAIRQHAPPENED(r13); \ |
63 | li __rB,0; \ | 64 | li __rB,0; \ |
64 | ori __rA,__rA,PACA_IRQ_HARD_DIS; \ | 65 | ori __rA,__rA,PACA_IRQ_HARD_DIS; \ |
diff --git a/arch/powerpc/kernel/entry_64.S b/arch/powerpc/kernel/entry_64.S index ab15b8d057ad..c1055a150b88 100644 --- a/arch/powerpc/kernel/entry_64.S +++ b/arch/powerpc/kernel/entry_64.S | |||
@@ -721,9 +721,9 @@ resume_kernel: | |||
721 | 721 | ||
722 | /* | 722 | /* |
723 | * Here we are preempting the current task. We want to make | 723 | * Here we are preempting the current task. We want to make |
724 | * sure we are soft-disabled first | 724 | * sure we are soft-disabled first and reconcile irq state. |
725 | */ | 725 | */ |
726 | SOFT_DISABLE_INTS(r3,r4) | 726 | RECONCILE_IRQ_STATE(r3,r4) |
727 | 1: bl .preempt_schedule_irq | 727 | 1: bl .preempt_schedule_irq |
728 | 728 | ||
729 | /* Re-test flags and eventually loop */ | 729 | /* Re-test flags and eventually loop */ |
diff --git a/arch/powerpc/kernel/exceptions-64e.S b/arch/powerpc/kernel/exceptions-64e.S index 645170a07ada..2d067049db27 100644 --- a/arch/powerpc/kernel/exceptions-64e.S +++ b/arch/powerpc/kernel/exceptions-64e.S | |||
@@ -198,9 +198,9 @@ exc_##n##_common: \ | |||
198 | /* This second version is meant for exceptions that don't immediately | 198 | /* This second version is meant for exceptions that don't immediately |
199 | * hard-enable. We set a bit in paca->irq_happened to ensure that | 199 | * hard-enable. We set a bit in paca->irq_happened to ensure that |
200 | * a subsequent call to arch_local_irq_restore() will properly | 200 | * a subsequent call to arch_local_irq_restore() will properly |
201 | * hard-enable and avoid the fast-path | 201 | * hard-enable and avoid the fast-path, and then reconcile irq state. |
202 | */ | 202 | */ |
203 | #define INTS_DISABLE SOFT_DISABLE_INTS(r3,r4) | 203 | #define INTS_DISABLE RECONCILE_IRQ_STATE(r3,r4) |
204 | 204 | ||
205 | /* This is called by exceptions that used INTS_KEEP (that did not touch | 205 | /* This is called by exceptions that used INTS_KEEP (that did not touch |
206 | * irq indicators in the PACA). This will restore MSR:EE to it's previous | 206 | * irq indicators in the PACA). This will restore MSR:EE to it's previous |