diff options
author | Kalesh AP <kalesh.purayil@emulex.com> | 2014-07-17 06:50:28 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-07-17 19:38:15 -0400 |
commit | ddf1169fec57c68f9ab561ac818b02aae95943b4 (patch) | |
tree | 4b62be2238bc14eb94a55a918a71e69a9837047d | |
parent | b99f8036ff04d30d27ab8144b409cecdcb0bf035 (diff) |
be2net: use "if (!foo)" test style
Replace "if (foo == NULL)" statements with "if (!foo)" to be consistent
across the driver.
Signed-off-by: Kalesh AP <kalesh.purayil@emulex.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/emulex/benet/be_main.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c index 8ffcffab62f8..75c8f111d1c6 100644 --- a/drivers/net/ethernet/emulex/benet/be_main.c +++ b/drivers/net/ethernet/emulex/benet/be_main.c | |||
@@ -2034,7 +2034,7 @@ static void be_rx_cq_clean(struct be_rx_obj *rxo) | |||
2034 | */ | 2034 | */ |
2035 | for (;;) { | 2035 | for (;;) { |
2036 | rxcp = be_rx_compl_get(rxo); | 2036 | rxcp = be_rx_compl_get(rxo); |
2037 | if (rxcp == NULL) { | 2037 | if (!rxcp) { |
2038 | if (lancer_chip(adapter)) | 2038 | if (lancer_chip(adapter)) |
2039 | break; | 2039 | break; |
2040 | 2040 | ||
@@ -2941,7 +2941,7 @@ static int be_setup_wol(struct be_adapter *adapter, bool enable) | |||
2941 | cmd.size = sizeof(struct be_cmd_req_acpi_wol_magic_config); | 2941 | cmd.size = sizeof(struct be_cmd_req_acpi_wol_magic_config); |
2942 | cmd.va = dma_zalloc_coherent(&adapter->pdev->dev, cmd.size, &cmd.dma, | 2942 | cmd.va = dma_zalloc_coherent(&adapter->pdev->dev, cmd.size, &cmd.dma, |
2943 | GFP_KERNEL); | 2943 | GFP_KERNEL); |
2944 | if (cmd.va == NULL) | 2944 | if (!cmd.va) |
2945 | return -ENOMEM; | 2945 | return -ENOMEM; |
2946 | 2946 | ||
2947 | if (enable) { | 2947 | if (enable) { |
@@ -4133,7 +4133,7 @@ lancer_fw_exit: | |||
4133 | static int be_get_ufi_type(struct be_adapter *adapter, | 4133 | static int be_get_ufi_type(struct be_adapter *adapter, |
4134 | struct flash_file_hdr_g3 *fhdr) | 4134 | struct flash_file_hdr_g3 *fhdr) |
4135 | { | 4135 | { |
4136 | if (fhdr == NULL) | 4136 | if (!fhdr) |
4137 | goto be_get_ufi_exit; | 4137 | goto be_get_ufi_exit; |
4138 | 4138 | ||
4139 | if (skyhawk_chip(adapter) && fhdr->build[0] == '4') | 4139 | if (skyhawk_chip(adapter) && fhdr->build[0] == '4') |
@@ -4475,12 +4475,12 @@ static int be_map_pci_bars(struct be_adapter *adapter) | |||
4475 | 4475 | ||
4476 | if (BEx_chip(adapter) && be_physfn(adapter)) { | 4476 | if (BEx_chip(adapter) && be_physfn(adapter)) { |
4477 | adapter->csr = pci_iomap(adapter->pdev, 2, 0); | 4477 | adapter->csr = pci_iomap(adapter->pdev, 2, 0); |
4478 | if (adapter->csr == NULL) | 4478 | if (!adapter->csr) |
4479 | return -ENOMEM; | 4479 | return -ENOMEM; |
4480 | } | 4480 | } |
4481 | 4481 | ||
4482 | addr = pci_iomap(adapter->pdev, db_bar(adapter), 0); | 4482 | addr = pci_iomap(adapter->pdev, db_bar(adapter), 0); |
4483 | if (addr == NULL) | 4483 | if (!addr) |
4484 | goto pci_map_err; | 4484 | goto pci_map_err; |
4485 | adapter->db = addr; | 4485 | adapter->db = addr; |
4486 | 4486 | ||
@@ -4543,7 +4543,7 @@ static int be_ctrl_init(struct be_adapter *adapter) | |||
4543 | rx_filter->va = dma_zalloc_coherent(&adapter->pdev->dev, | 4543 | rx_filter->va = dma_zalloc_coherent(&adapter->pdev->dev, |
4544 | rx_filter->size, &rx_filter->dma, | 4544 | rx_filter->size, &rx_filter->dma, |
4545 | GFP_KERNEL); | 4545 | GFP_KERNEL); |
4546 | if (rx_filter->va == NULL) { | 4546 | if (!rx_filter->va) { |
4547 | status = -ENOMEM; | 4547 | status = -ENOMEM; |
4548 | goto free_mbox; | 4548 | goto free_mbox; |
4549 | } | 4549 | } |
@@ -4592,7 +4592,7 @@ static int be_stats_init(struct be_adapter *adapter) | |||
4592 | 4592 | ||
4593 | cmd->va = dma_zalloc_coherent(&adapter->pdev->dev, cmd->size, &cmd->dma, | 4593 | cmd->va = dma_zalloc_coherent(&adapter->pdev->dev, cmd->size, &cmd->dma, |
4594 | GFP_KERNEL); | 4594 | GFP_KERNEL); |
4595 | if (cmd->va == NULL) | 4595 | if (!cmd->va) |
4596 | return -ENOMEM; | 4596 | return -ENOMEM; |
4597 | return 0; | 4597 | return 0; |
4598 | } | 4598 | } |
@@ -4814,7 +4814,7 @@ static int be_probe(struct pci_dev *pdev, const struct pci_device_id *pdev_id) | |||
4814 | pci_set_master(pdev); | 4814 | pci_set_master(pdev); |
4815 | 4815 | ||
4816 | netdev = alloc_etherdev_mqs(sizeof(*adapter), MAX_TX_QS, MAX_RX_QS); | 4816 | netdev = alloc_etherdev_mqs(sizeof(*adapter), MAX_TX_QS, MAX_RX_QS); |
4817 | if (netdev == NULL) { | 4817 | if (!netdev) { |
4818 | status = -ENOMEM; | 4818 | status = -ENOMEM; |
4819 | goto rel_reg; | 4819 | goto rel_reg; |
4820 | } | 4820 | } |