aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRoss Kirk <ross.kirk@gmail.com>2013-09-16 10:58:09 -0400
committerChris Mason <chris.mason@fusionio.com>2013-11-11 21:50:48 -0500
commitdd3cc16b8750251ea9b1a843ce7806e82b015d5e (patch)
tree9cb6e2d093ff52dffaa09b7474e805152691a541
parentf06becc4119856c984e3beef54aa75538e656c6d (diff)
btrfs: drop unused parameter from btrfs_item_nr
Remove unused eb parameter from btrfs_item_nr Signed-off-by: Ross Kirk <ross.kirk@gmail.com> Reviewed-by: David Sterba <dsterba@suse.cz> Signed-off-by: Josef Bacik <jbacik@fusionio.com> Signed-off-by: Chris Mason <chris.mason@fusionio.com>
-rw-r--r--fs/btrfs/backref.c2
-rw-r--r--fs/btrfs/ctree.c34
-rw-r--r--fs/btrfs/ctree.h13
-rw-r--r--fs/btrfs/dir-item.c2
-rw-r--r--fs/btrfs/inode-item.c2
-rw-r--r--fs/btrfs/inode.c4
-rw-r--r--fs/btrfs/print-tree.c2
-rw-r--r--fs/btrfs/send.c4
8 files changed, 31 insertions, 32 deletions
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
index 0552a599b28f..721936a5b2ca 100644
--- a/fs/btrfs/backref.c
+++ b/fs/btrfs/backref.c
@@ -1619,7 +1619,7 @@ static int iterate_inode_refs(u64 inum, struct btrfs_root *fs_root,
1619 btrfs_set_lock_blocking_rw(eb, BTRFS_READ_LOCK); 1619 btrfs_set_lock_blocking_rw(eb, BTRFS_READ_LOCK);
1620 btrfs_release_path(path); 1620 btrfs_release_path(path);
1621 1621
1622 item = btrfs_item_nr(eb, slot); 1622 item = btrfs_item_nr(slot);
1623 iref = btrfs_item_ptr(eb, slot, struct btrfs_inode_ref); 1623 iref = btrfs_item_ptr(eb, slot, struct btrfs_inode_ref);
1624 1624
1625 for (cur = 0; cur < btrfs_item_size(eb, item); cur += len) { 1625 for (cur = 0; cur < btrfs_item_size(eb, item); cur += len) {
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 61b5bcd57b7e..c274a752c93d 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -3337,8 +3337,8 @@ static int leaf_space_used(struct extent_buffer *l, int start, int nr)
3337 if (!nr) 3337 if (!nr)
3338 return 0; 3338 return 0;
3339 btrfs_init_map_token(&token); 3339 btrfs_init_map_token(&token);
3340 start_item = btrfs_item_nr(l, start); 3340 start_item = btrfs_item_nr(start);
3341 end_item = btrfs_item_nr(l, end); 3341 end_item = btrfs_item_nr(end);
3342 data_len = btrfs_token_item_offset(l, start_item, &token) + 3342 data_len = btrfs_token_item_offset(l, start_item, &token) +
3343 btrfs_token_item_size(l, start_item, &token); 3343 btrfs_token_item_size(l, start_item, &token);
3344 data_len = data_len - btrfs_token_item_offset(l, end_item, &token); 3344 data_len = data_len - btrfs_token_item_offset(l, end_item, &token);
@@ -3406,7 +3406,7 @@ static noinline int __push_leaf_right(struct btrfs_trans_handle *trans,
3406 slot = path->slots[1]; 3406 slot = path->slots[1];
3407 i = left_nritems - 1; 3407 i = left_nritems - 1;
3408 while (i >= nr) { 3408 while (i >= nr) {
3409 item = btrfs_item_nr(left, i); 3409 item = btrfs_item_nr(i);
3410 3410
3411 if (!empty && push_items > 0) { 3411 if (!empty && push_items > 0) {
3412 if (path->slots[0] > i) 3412 if (path->slots[0] > i)
@@ -3470,7 +3470,7 @@ static noinline int __push_leaf_right(struct btrfs_trans_handle *trans,
3470 btrfs_set_header_nritems(right, right_nritems); 3470 btrfs_set_header_nritems(right, right_nritems);
3471 push_space = BTRFS_LEAF_DATA_SIZE(root); 3471 push_space = BTRFS_LEAF_DATA_SIZE(root);
3472 for (i = 0; i < right_nritems; i++) { 3472 for (i = 0; i < right_nritems; i++) {
3473 item = btrfs_item_nr(right, i); 3473 item = btrfs_item_nr(i);
3474 push_space -= btrfs_token_item_size(right, item, &token); 3474 push_space -= btrfs_token_item_size(right, item, &token);
3475 btrfs_set_token_item_offset(right, item, push_space, &token); 3475 btrfs_set_token_item_offset(right, item, push_space, &token);
3476 } 3476 }
@@ -3612,7 +3612,7 @@ static noinline int __push_leaf_left(struct btrfs_trans_handle *trans,
3612 nr = min(right_nritems - 1, max_slot); 3612 nr = min(right_nritems - 1, max_slot);
3613 3613
3614 for (i = 0; i < nr; i++) { 3614 for (i = 0; i < nr; i++) {
3615 item = btrfs_item_nr(right, i); 3615 item = btrfs_item_nr(i);
3616 3616
3617 if (!empty && push_items > 0) { 3617 if (!empty && push_items > 0) {
3618 if (path->slots[0] < i) 3618 if (path->slots[0] < i)
@@ -3663,7 +3663,7 @@ static noinline int __push_leaf_left(struct btrfs_trans_handle *trans,
3663 for (i = old_left_nritems; i < old_left_nritems + push_items; i++) { 3663 for (i = old_left_nritems; i < old_left_nritems + push_items; i++) {
3664 u32 ioff; 3664 u32 ioff;
3665 3665
3666 item = btrfs_item_nr(left, i); 3666 item = btrfs_item_nr(i);
3667 3667
3668 ioff = btrfs_token_item_offset(left, item, &token); 3668 ioff = btrfs_token_item_offset(left, item, &token);
3669 btrfs_set_token_item_offset(left, item, 3669 btrfs_set_token_item_offset(left, item,
@@ -3694,7 +3694,7 @@ static noinline int __push_leaf_left(struct btrfs_trans_handle *trans,
3694 btrfs_set_header_nritems(right, right_nritems); 3694 btrfs_set_header_nritems(right, right_nritems);
3695 push_space = BTRFS_LEAF_DATA_SIZE(root); 3695 push_space = BTRFS_LEAF_DATA_SIZE(root);
3696 for (i = 0; i < right_nritems; i++) { 3696 for (i = 0; i < right_nritems; i++) {
3697 item = btrfs_item_nr(right, i); 3697 item = btrfs_item_nr(i);
3698 3698
3699 push_space = push_space - btrfs_token_item_size(right, 3699 push_space = push_space - btrfs_token_item_size(right,
3700 item, &token); 3700 item, &token);
@@ -3835,7 +3835,7 @@ static noinline void copy_for_split(struct btrfs_trans_handle *trans,
3835 btrfs_item_end_nr(l, mid); 3835 btrfs_item_end_nr(l, mid);
3836 3836
3837 for (i = 0; i < nritems; i++) { 3837 for (i = 0; i < nritems; i++) {
3838 struct btrfs_item *item = btrfs_item_nr(right, i); 3838 struct btrfs_item *item = btrfs_item_nr(i);
3839 u32 ioff; 3839 u32 ioff;
3840 3840
3841 ioff = btrfs_token_item_offset(right, item, &token); 3841 ioff = btrfs_token_item_offset(right, item, &token);
@@ -4177,7 +4177,7 @@ static noinline int split_item(struct btrfs_trans_handle *trans,
4177 4177
4178 btrfs_set_path_blocking(path); 4178 btrfs_set_path_blocking(path);
4179 4179
4180 item = btrfs_item_nr(leaf, path->slots[0]); 4180 item = btrfs_item_nr(path->slots[0]);
4181 orig_offset = btrfs_item_offset(leaf, item); 4181 orig_offset = btrfs_item_offset(leaf, item);
4182 item_size = btrfs_item_size(leaf, item); 4182 item_size = btrfs_item_size(leaf, item);
4183 4183
@@ -4200,7 +4200,7 @@ static noinline int split_item(struct btrfs_trans_handle *trans,
4200 btrfs_cpu_key_to_disk(&disk_key, new_key); 4200 btrfs_cpu_key_to_disk(&disk_key, new_key);
4201 btrfs_set_item_key(leaf, &disk_key, slot); 4201 btrfs_set_item_key(leaf, &disk_key, slot);
4202 4202
4203 new_item = btrfs_item_nr(leaf, slot); 4203 new_item = btrfs_item_nr(slot);
4204 4204
4205 btrfs_set_item_offset(leaf, new_item, orig_offset); 4205 btrfs_set_item_offset(leaf, new_item, orig_offset);
4206 btrfs_set_item_size(leaf, new_item, item_size - split_offset); 4206 btrfs_set_item_size(leaf, new_item, item_size - split_offset);
@@ -4339,7 +4339,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path,
4339 /* first correct the data pointers */ 4339 /* first correct the data pointers */
4340 for (i = slot; i < nritems; i++) { 4340 for (i = slot; i < nritems; i++) {
4341 u32 ioff; 4341 u32 ioff;
4342 item = btrfs_item_nr(leaf, i); 4342 item = btrfs_item_nr(i);
4343 4343
4344 ioff = btrfs_token_item_offset(leaf, item, &token); 4344 ioff = btrfs_token_item_offset(leaf, item, &token);
4345 btrfs_set_token_item_offset(leaf, item, 4345 btrfs_set_token_item_offset(leaf, item,
@@ -4387,7 +4387,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path,
4387 fixup_low_keys(root, path, &disk_key, 1); 4387 fixup_low_keys(root, path, &disk_key, 1);
4388 } 4388 }
4389 4389
4390 item = btrfs_item_nr(leaf, slot); 4390 item = btrfs_item_nr(slot);
4391 btrfs_set_item_size(leaf, item, new_size); 4391 btrfs_set_item_size(leaf, item, new_size);
4392 btrfs_mark_buffer_dirty(leaf); 4392 btrfs_mark_buffer_dirty(leaf);
4393 4393
@@ -4441,7 +4441,7 @@ void btrfs_extend_item(struct btrfs_root *root, struct btrfs_path *path,
4441 /* first correct the data pointers */ 4441 /* first correct the data pointers */
4442 for (i = slot; i < nritems; i++) { 4442 for (i = slot; i < nritems; i++) {
4443 u32 ioff; 4443 u32 ioff;
4444 item = btrfs_item_nr(leaf, i); 4444 item = btrfs_item_nr(i);
4445 4445
4446 ioff = btrfs_token_item_offset(leaf, item, &token); 4446 ioff = btrfs_token_item_offset(leaf, item, &token);
4447 btrfs_set_token_item_offset(leaf, item, 4447 btrfs_set_token_item_offset(leaf, item,
@@ -4455,7 +4455,7 @@ void btrfs_extend_item(struct btrfs_root *root, struct btrfs_path *path,
4455 4455
4456 data_end = old_data; 4456 data_end = old_data;
4457 old_size = btrfs_item_size_nr(leaf, slot); 4457 old_size = btrfs_item_size_nr(leaf, slot);
4458 item = btrfs_item_nr(leaf, slot); 4458 item = btrfs_item_nr(slot);
4459 btrfs_set_item_size(leaf, item, old_size + data_size); 4459 btrfs_set_item_size(leaf, item, old_size + data_size);
4460 btrfs_mark_buffer_dirty(leaf); 4460 btrfs_mark_buffer_dirty(leaf);
4461 4461
@@ -4514,7 +4514,7 @@ void setup_items_for_insert(struct btrfs_root *root, struct btrfs_path *path,
4514 for (i = slot; i < nritems; i++) { 4514 for (i = slot; i < nritems; i++) {
4515 u32 ioff; 4515 u32 ioff;
4516 4516
4517 item = btrfs_item_nr(leaf, i); 4517 item = btrfs_item_nr( i);
4518 ioff = btrfs_token_item_offset(leaf, item, &token); 4518 ioff = btrfs_token_item_offset(leaf, item, &token);
4519 btrfs_set_token_item_offset(leaf, item, 4519 btrfs_set_token_item_offset(leaf, item,
4520 ioff - total_data, &token); 4520 ioff - total_data, &token);
@@ -4535,7 +4535,7 @@ void setup_items_for_insert(struct btrfs_root *root, struct btrfs_path *path,
4535 for (i = 0; i < nr; i++) { 4535 for (i = 0; i < nr; i++) {
4536 btrfs_cpu_key_to_disk(&disk_key, cpu_key + i); 4536 btrfs_cpu_key_to_disk(&disk_key, cpu_key + i);
4537 btrfs_set_item_key(leaf, &disk_key, slot + i); 4537 btrfs_set_item_key(leaf, &disk_key, slot + i);
4538 item = btrfs_item_nr(leaf, slot + i); 4538 item = btrfs_item_nr(slot + i);
4539 btrfs_set_token_item_offset(leaf, item, 4539 btrfs_set_token_item_offset(leaf, item,
4540 data_end - data_size[i], &token); 4540 data_end - data_size[i], &token);
4541 data_end -= data_size[i]; 4541 data_end -= data_size[i];
@@ -4730,7 +4730,7 @@ int btrfs_del_items(struct btrfs_trans_handle *trans, struct btrfs_root *root,
4730 for (i = slot + nr; i < nritems; i++) { 4730 for (i = slot + nr; i < nritems; i++) {
4731 u32 ioff; 4731 u32 ioff;
4732 4732
4733 item = btrfs_item_nr(leaf, i); 4733 item = btrfs_item_nr(i);
4734 ioff = btrfs_token_item_offset(leaf, item, &token); 4734 ioff = btrfs_token_item_offset(leaf, item, &token);
4735 btrfs_set_token_item_offset(leaf, item, 4735 btrfs_set_token_item_offset(leaf, item,
4736 ioff + dsize, &token); 4736 ioff + dsize, &token);
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 0506f40ede83..fa117f7d5a8f 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -2461,8 +2461,7 @@ static inline unsigned long btrfs_item_nr_offset(int nr)
2461 sizeof(struct btrfs_item) * nr; 2461 sizeof(struct btrfs_item) * nr;
2462} 2462}
2463 2463
2464static inline struct btrfs_item *btrfs_item_nr(struct extent_buffer *eb, 2464static inline struct btrfs_item *btrfs_item_nr(int nr)
2465 int nr)
2466{ 2465{
2467 return (struct btrfs_item *)btrfs_item_nr_offset(nr); 2466 return (struct btrfs_item *)btrfs_item_nr_offset(nr);
2468} 2467}
@@ -2475,30 +2474,30 @@ static inline u32 btrfs_item_end(struct extent_buffer *eb,
2475 2474
2476static inline u32 btrfs_item_end_nr(struct extent_buffer *eb, int nr) 2475static inline u32 btrfs_item_end_nr(struct extent_buffer *eb, int nr)
2477{ 2476{
2478 return btrfs_item_end(eb, btrfs_item_nr(eb, nr)); 2477 return btrfs_item_end(eb, btrfs_item_nr(nr));
2479} 2478}
2480 2479
2481static inline u32 btrfs_item_offset_nr(struct extent_buffer *eb, int nr) 2480static inline u32 btrfs_item_offset_nr(struct extent_buffer *eb, int nr)
2482{ 2481{
2483 return btrfs_item_offset(eb, btrfs_item_nr(eb, nr)); 2482 return btrfs_item_offset(eb, btrfs_item_nr(nr));
2484} 2483}
2485 2484
2486static inline u32 btrfs_item_size_nr(struct extent_buffer *eb, int nr) 2485static inline u32 btrfs_item_size_nr(struct extent_buffer *eb, int nr)
2487{ 2486{
2488 return btrfs_item_size(eb, btrfs_item_nr(eb, nr)); 2487 return btrfs_item_size(eb, btrfs_item_nr(nr));
2489} 2488}
2490 2489
2491static inline void btrfs_item_key(struct extent_buffer *eb, 2490static inline void btrfs_item_key(struct extent_buffer *eb,
2492 struct btrfs_disk_key *disk_key, int nr) 2491 struct btrfs_disk_key *disk_key, int nr)
2493{ 2492{
2494 struct btrfs_item *item = btrfs_item_nr(eb, nr); 2493 struct btrfs_item *item = btrfs_item_nr(nr);
2495 read_eb_member(eb, item, struct btrfs_item, key, disk_key); 2494 read_eb_member(eb, item, struct btrfs_item, key, disk_key);
2496} 2495}
2497 2496
2498static inline void btrfs_set_item_key(struct extent_buffer *eb, 2497static inline void btrfs_set_item_key(struct extent_buffer *eb,
2499 struct btrfs_disk_key *disk_key, int nr) 2498 struct btrfs_disk_key *disk_key, int nr)
2500{ 2499{
2501 struct btrfs_item *item = btrfs_item_nr(eb, nr); 2500 struct btrfs_item *item = btrfs_item_nr(nr);
2502 write_eb_member(eb, item, struct btrfs_item, key, disk_key); 2501 write_eb_member(eb, item, struct btrfs_item, key, disk_key);
2503} 2502}
2504 2503
diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c
index 79e594e341c7..1c529db1697f 100644
--- a/fs/btrfs/dir-item.c
+++ b/fs/btrfs/dir-item.c
@@ -58,7 +58,7 @@ static struct btrfs_dir_item *insert_with_overflow(struct btrfs_trans_handle
58 return ERR_PTR(ret); 58 return ERR_PTR(ret);
59 WARN_ON(ret > 0); 59 WARN_ON(ret > 0);
60 leaf = path->nodes[0]; 60 leaf = path->nodes[0];
61 item = btrfs_item_nr(leaf, path->slots[0]); 61 item = btrfs_item_nr(path->slots[0]);
62 ptr = btrfs_item_ptr(leaf, path->slots[0], char); 62 ptr = btrfs_item_ptr(leaf, path->slots[0], char);
63 BUG_ON(data_size > btrfs_item_size(leaf, item)); 63 BUG_ON(data_size > btrfs_item_size(leaf, item));
64 ptr += btrfs_item_size(leaf, item) - data_size; 64 ptr += btrfs_item_size(leaf, item) - data_size;
diff --git a/fs/btrfs/inode-item.c b/fs/btrfs/inode-item.c
index e0b7034d6343..ec82fae07097 100644
--- a/fs/btrfs/inode-item.c
+++ b/fs/btrfs/inode-item.c
@@ -369,7 +369,7 @@ static int btrfs_insert_inode_extref(struct btrfs_trans_handle *trans,
369 goto out; 369 goto out;
370 370
371 leaf = path->nodes[0]; 371 leaf = path->nodes[0];
372 item = btrfs_item_nr(leaf, path->slots[0]); 372 item = btrfs_item_nr(path->slots[0]);
373 ptr = (unsigned long)btrfs_item_ptr(leaf, path->slots[0], char); 373 ptr = (unsigned long)btrfs_item_ptr(leaf, path->slots[0], char);
374 ptr += btrfs_item_size(leaf, item) - ins_len; 374 ptr += btrfs_item_size(leaf, item) - ins_len;
375 extref = (struct btrfs_inode_extref *)ptr; 375 extref = (struct btrfs_inode_extref *)ptr;
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 59b4e2e495ac..57b27012d43a 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -5044,7 +5044,7 @@ static int btrfs_real_readdir(struct file *file, struct dir_context *ctx)
5044 continue; 5044 continue;
5045 } 5045 }
5046 5046
5047 item = btrfs_item_nr(leaf, slot); 5047 item = btrfs_item_nr(slot);
5048 btrfs_item_key_to_cpu(leaf, &found_key, slot); 5048 btrfs_item_key_to_cpu(leaf, &found_key, slot);
5049 5049
5050 if (found_key.objectid != key.objectid) 5050 if (found_key.objectid != key.objectid)
@@ -5856,7 +5856,7 @@ static noinline int uncompress_inline(struct btrfs_path *path,
5856 compress_type = btrfs_file_extent_compression(leaf, item); 5856 compress_type = btrfs_file_extent_compression(leaf, item);
5857 max_size = btrfs_file_extent_ram_bytes(leaf, item); 5857 max_size = btrfs_file_extent_ram_bytes(leaf, item);
5858 inline_size = btrfs_file_extent_inline_item_len(leaf, 5858 inline_size = btrfs_file_extent_inline_item_len(leaf,
5859 btrfs_item_nr(leaf, path->slots[0])); 5859 btrfs_item_nr(path->slots[0]));
5860 tmp = kmalloc(inline_size, GFP_NOFS); 5860 tmp = kmalloc(inline_size, GFP_NOFS);
5861 if (!tmp) 5861 if (!tmp)
5862 return -ENOMEM; 5862 return -ENOMEM;
diff --git a/fs/btrfs/print-tree.c b/fs/btrfs/print-tree.c
index 0088bedc8631..417053b17181 100644
--- a/fs/btrfs/print-tree.c
+++ b/fs/btrfs/print-tree.c
@@ -193,7 +193,7 @@ void btrfs_print_leaf(struct btrfs_root *root, struct extent_buffer *l)
193 btrfs_info(root->fs_info, "leaf %llu total ptrs %d free space %d", 193 btrfs_info(root->fs_info, "leaf %llu total ptrs %d free space %d",
194 btrfs_header_bytenr(l), nr, btrfs_leaf_free_space(root, l)); 194 btrfs_header_bytenr(l), nr, btrfs_leaf_free_space(root, l));
195 for (i = 0 ; i < nr ; i++) { 195 for (i = 0 ; i < nr ; i++) {
196 item = btrfs_item_nr(l, i); 196 item = btrfs_item_nr(i);
197 btrfs_item_key_to_cpu(l, &key, i); 197 btrfs_item_key_to_cpu(l, &key, i);
198 type = btrfs_key_type(&key); 198 type = btrfs_key_type(&key);
199 printk(KERN_INFO "\titem %d key (%llu %u %llu) itemoff %d " 199 printk(KERN_INFO "\titem %d key (%llu %u %llu) itemoff %d "
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index e46e0ed74925..0a894399be16 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -791,7 +791,7 @@ static int iterate_inode_ref(struct btrfs_root *root, struct btrfs_path *path,
791 if (found_key->type == BTRFS_INODE_REF_KEY) { 791 if (found_key->type == BTRFS_INODE_REF_KEY) {
792 ptr = (unsigned long)btrfs_item_ptr(eb, slot, 792 ptr = (unsigned long)btrfs_item_ptr(eb, slot,
793 struct btrfs_inode_ref); 793 struct btrfs_inode_ref);
794 item = btrfs_item_nr(eb, slot); 794 item = btrfs_item_nr(slot);
795 total = btrfs_item_size(eb, item); 795 total = btrfs_item_size(eb, item);
796 elem_size = sizeof(*iref); 796 elem_size = sizeof(*iref);
797 } else { 797 } else {
@@ -905,7 +905,7 @@ static int iterate_dir_item(struct btrfs_root *root, struct btrfs_path *path,
905 905
906 eb = path->nodes[0]; 906 eb = path->nodes[0];
907 slot = path->slots[0]; 907 slot = path->slots[0];
908 item = btrfs_item_nr(eb, slot); 908 item = btrfs_item_nr(slot);
909 di = btrfs_item_ptr(eb, slot, struct btrfs_dir_item); 909 di = btrfs_item_ptr(eb, slot, struct btrfs_dir_item);
910 cur = 0; 910 cur = 0;
911 len = 0; 911 len = 0;