diff options
author | Eric Sandeen <sandeen@redhat.com> | 2014-02-20 13:32:10 -0500 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2014-02-20 13:32:10 -0500 |
commit | dc9ddd984df5f5611c7e2149d19be5a8721c1ac5 (patch) | |
tree | 529e27a9059cff932de90b11e558cca38bfd0e38 | |
parent | e861b5e9a47bd8c6a7491a2b9f6e9a230b1b8e86 (diff) |
ext4: remove unused ac_ex_scanned
When looking at a bug report with:
> kernel: EXT4-fs: 0 scanned, 0 found
I thought wow, 0 scanned, that's odd? But it's not odd; it's printing
a variable that is initialized to 0 and never touched again.
It's never been used since the original merge, so I don't really even
know what the original intent was, either.
If anyone knows how to hook it up, speak now via patch, otherwise just
yank it so it's not making a confusing situation more confusing in
kernel logs.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
-rw-r--r-- | fs/ext4/mballoc.c | 3 | ||||
-rw-r--r-- | fs/ext4/mballoc.h | 2 |
2 files changed, 1 insertions, 4 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 0d42f635dda9..a888cac76e9c 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c | |||
@@ -4008,8 +4008,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) | |||
4008 | (unsigned long)ac->ac_b_ex.fe_len, | 4008 | (unsigned long)ac->ac_b_ex.fe_len, |
4009 | (unsigned long)ac->ac_b_ex.fe_logical, | 4009 | (unsigned long)ac->ac_b_ex.fe_logical, |
4010 | (int)ac->ac_criteria); | 4010 | (int)ac->ac_criteria); |
4011 | ext4_msg(ac->ac_sb, KERN_ERR, "%lu scanned, %d found", | 4011 | ext4_msg(ac->ac_sb, KERN_ERR, "%d found", ac->ac_found); |
4012 | ac->ac_ex_scanned, ac->ac_found); | ||
4013 | ext4_msg(ac->ac_sb, KERN_ERR, "groups: "); | 4012 | ext4_msg(ac->ac_sb, KERN_ERR, "groups: "); |
4014 | ngroups = ext4_get_groups_count(sb); | 4013 | ngroups = ext4_get_groups_count(sb); |
4015 | for (i = 0; i < ngroups; i++) { | 4014 | for (i = 0; i < ngroups; i++) { |
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h index 9347328d1cc5..d634e183b4d4 100644 --- a/fs/ext4/mballoc.h +++ b/fs/ext4/mballoc.h | |||
@@ -175,8 +175,6 @@ struct ext4_allocation_context { | |||
175 | /* copy of the best found extent taken before preallocation efforts */ | 175 | /* copy of the best found extent taken before preallocation efforts */ |
176 | struct ext4_free_extent ac_f_ex; | 176 | struct ext4_free_extent ac_f_ex; |
177 | 177 | ||
178 | /* number of iterations done. we have to track to limit searching */ | ||
179 | unsigned long ac_ex_scanned; | ||
180 | __u16 ac_groups_scanned; | 178 | __u16 ac_groups_scanned; |
181 | __u16 ac_found; | 179 | __u16 ac_found; |
182 | __u16 ac_tail; | 180 | __u16 ac_tail; |