diff options
author | Andi Kleen <ak@linux.intel.com> | 2013-04-22 03:46:40 -0400 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2013-04-25 21:49:18 -0400 |
commit | dc3d226f3366f98af73caffc46b5c0a57fe32a51 (patch) | |
tree | 11bf0f2112761d476c50a71af7974bb946942ff7 | |
parent | a3b87a4c69619f5366b7225aafbf7983eed31a9a (diff) |
igb: limit udelay for phy changes to 10000us
If you really want 100000us you should really use mdelay or so.
Found by the LTO kernel build
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
-rw-r--r-- | drivers/net/ethernet/intel/igb/e1000_phy.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c index fd46add6c4e4..115b0da6e013 100644 --- a/drivers/net/ethernet/intel/igb/e1000_phy.c +++ b/drivers/net/ethernet/intel/igb/e1000_phy.c | |||
@@ -1130,7 +1130,7 @@ s32 igb_phy_force_speed_duplex_igp(struct e1000_hw *hw) | |||
1130 | if (phy->autoneg_wait_to_complete) { | 1130 | if (phy->autoneg_wait_to_complete) { |
1131 | hw_dbg("Waiting for forced speed/duplex link on IGP phy.\n"); | 1131 | hw_dbg("Waiting for forced speed/duplex link on IGP phy.\n"); |
1132 | 1132 | ||
1133 | ret_val = igb_phy_has_link(hw, PHY_FORCE_LIMIT, 100000, &link); | 1133 | ret_val = igb_phy_has_link(hw, PHY_FORCE_LIMIT, 10000, &link); |
1134 | if (ret_val) | 1134 | if (ret_val) |
1135 | goto out; | 1135 | goto out; |
1136 | 1136 | ||
@@ -1138,7 +1138,7 @@ s32 igb_phy_force_speed_duplex_igp(struct e1000_hw *hw) | |||
1138 | hw_dbg("Link taking longer than expected.\n"); | 1138 | hw_dbg("Link taking longer than expected.\n"); |
1139 | 1139 | ||
1140 | /* Try once more */ | 1140 | /* Try once more */ |
1141 | ret_val = igb_phy_has_link(hw, PHY_FORCE_LIMIT, 100000, &link); | 1141 | ret_val = igb_phy_has_link(hw, PHY_FORCE_LIMIT, 10000, &link); |
1142 | if (ret_val) | 1142 | if (ret_val) |
1143 | goto out; | 1143 | goto out; |
1144 | } | 1144 | } |
@@ -1590,7 +1590,7 @@ s32 igb_phy_has_link(struct e1000_hw *hw, u32 iterations, | |||
1590 | * it across the board. | 1590 | * it across the board. |
1591 | */ | 1591 | */ |
1592 | ret_val = hw->phy.ops.read_reg(hw, PHY_STATUS, &phy_status); | 1592 | ret_val = hw->phy.ops.read_reg(hw, PHY_STATUS, &phy_status); |
1593 | if (ret_val) { | 1593 | if (ret_val && usec_interval > 0) { |
1594 | /* If the first read fails, another entity may have | 1594 | /* If the first read fails, another entity may have |
1595 | * ownership of the resources, wait and try again to | 1595 | * ownership of the resources, wait and try again to |
1596 | * see if they have relinquished the resources yet. | 1596 | * see if they have relinquished the resources yet. |