dw_dmac: use devm_* functions to simplify code

Use devm_kzalloc, devm_clk_get, devm_request_irq, and devm_request_and_ioremap
to reduce the code and to simplify the error path.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Viresh Kumar <viresh.linux@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>

2 files changed, 10 insertions, 45 deletions

diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
index 57beb5c8e3fd..ed2c9499d3ea 100644
--- a/drivers/dma/dw_dmac.c
+++ b/drivers/dma/dw_dmac.c
@@ -1392,26 +1392,17 @@ static int __devinit dw_probe(struct platform_device *pdev)
 
         size = sizeof(struct dw_dma);
         size += pdata->nr_channels * sizeof(struct dw_dma_chan);
-        dw = kzalloc(size, GFP_KERNEL);
+        dw = devm_kzalloc(&pdev->dev, size, GFP_KERNEL);
         if (!dw)
                 return -ENOMEM;
 
-        if (!request_mem_region(io->start, DW_REGLEN, pdev->dev.driver->name)) {
-                err = -EBUSY;
-                goto err_kfree;
-        }
-
-        dw->regs = ioremap(io->start, DW_REGLEN);
-        if (!dw->regs) {
-                err = -ENOMEM;
-                goto err_release_r;
-        }
+        dw->regs = devm_request_and_ioremap(&pdev->dev, io);
+        if (!dw->regs)
+                return -EBUSY;
 
-        dw->clk = clk_get(&pdev->dev, "hclk");
-        if (IS_ERR(dw->clk)) {
-                err = PTR_ERR(dw->clk);
-                goto err_clk;
-        }
+        dw->clk = devm_clk_get(&pdev->dev, "hclk");
+        if (IS_ERR(dw->clk))
+                return PTR_ERR(dw->clk);
         clk_prepare_enable(dw->clk);
 
         /* Calculate all channel mask before DMA setup */
@@ -1423,9 +1414,10 @@ static int __devinit dw_probe(struct platform_device *pdev)
         /* disable BLOCK interrupts as well */
         channel_clear_bit(dw, MASK.BLOCK, dw->all_chan_mask);
 
-        err = request_irq(irq, dw_dma_interrupt, 0, "dw_dmac", dw);
+        err = devm_request_irq(&pdev->dev, irq, dw_dma_interrupt, 0,
+                               "dw_dmac", dw);
         if (err)
-                goto err_irq;
+                return err;
 
         platform_set_drvdata(pdev, dw);
 
@@ -1491,30 +1483,16 @@ static int __devinit dw_probe(struct platform_device *pdev)
         dma_async_device_register(&dw->dma);
 
         return 0;
-
-err_irq:
-        clk_disable_unprepare(dw->clk);
-        clk_put(dw->clk);
-err_clk:
-        iounmap(dw->regs);
-        dw->regs = NULL;
-err_release_r:
-        release_resource(io);
-err_kfree:
-        kfree(dw);
-        return err;
 }
 
 static int __devexit dw_remove(struct platform_device *pdev)
 {
         struct dw_dma           *dw = platform_get_drvdata(pdev);
         struct dw_dma_chan      *dwc, *_dwc;
-        struct resource         *io;
 
         dw_dma_off(dw);
         dma_async_device_unregister(&dw->dma);
 
-        free_irq(platform_get_irq(pdev, 0), dw);
         tasklet_kill(&dw->tasklet);
 
         list_for_each_entry_safe(dwc, _dwc, &dw->dma.channels,
@@ -1523,17 +1501,6 @@ static int __devexit dw_remove(struct platform_device *pdev)
                 channel_clear_bit(dw, CH_EN, dwc->mask);
         }
 
-        clk_disable_unprepare(dw->clk);
-        clk_put(dw->clk);
-
-        iounmap(dw->regs);
-        dw->regs = NULL;
-
-        io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-        release_mem_region(io->start, DW_REGLEN);
-
-        kfree(dw);
-
         return 0;
 }
 
diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h
index 50830bee087a..f6d92d72ae40 100644
--- a/drivers/dma/dw_dmac_regs.h
+++ b/drivers/dma/dw_dmac_regs.h
@@ -140,8 +140,6 @@ struct dw_dma_regs {
 /* Bitfields in CFG */
 #define DW_CFG_DMA_EN           (1 << 0)
 
-#define DW_REGLEN               0x400
-
 enum dw_dmac_flags {
         DW_DMA_IS_CYCLIC = 0,
 };