diff options
author | Vinod Koul <vinod.koul@intel.com> | 2013-10-30 08:52:30 -0400 |
---|---|---|
committer | Vinod Koul <vinod.koul@intel.com> | 2013-10-30 08:57:56 -0400 |
commit | db60d8da8f643586c95f8fc3e383954f8c57f1f3 (patch) | |
tree | be686ebbfd8b0f9a2a87ae7b10ed1207afb64254 | |
parent | 7db5f7274a0b065abdc358be2a44b4a911d75707 (diff) |
dmanengine: fix edma driver to not define DMA_COMPLETE
edma header defines DMA_COMPLETE, this causes issues as commit adfedd9a32e4 move
DMA_SUCCESS to DMA_COMPLETE. edma should properly namespace its defines and
needs a future fix
Reported-by: Olof Johansson <olof@lixom.net>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
-rw-r--r-- | arch/arm/common/edma.c | 4 | ||||
-rw-r--r-- | drivers/dma/edma.c | 4 | ||||
-rw-r--r-- | include/linux/platform_data/edma.h | 8 |
3 files changed, 8 insertions, 8 deletions
diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 8e1a0245907f..41bca32409fc 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c | |||
@@ -404,7 +404,7 @@ static irqreturn_t dma_irq_handler(int irq, void *data) | |||
404 | BIT(slot)); | 404 | BIT(slot)); |
405 | if (edma_cc[ctlr]->intr_data[channel].callback) | 405 | if (edma_cc[ctlr]->intr_data[channel].callback) |
406 | edma_cc[ctlr]->intr_data[channel].callback( | 406 | edma_cc[ctlr]->intr_data[channel].callback( |
407 | channel, DMA_COMPLETE, | 407 | channel, EDMA_DMA_COMPLETE, |
408 | edma_cc[ctlr]->intr_data[channel].data); | 408 | edma_cc[ctlr]->intr_data[channel].data); |
409 | } | 409 | } |
410 | } while (sh_ipr); | 410 | } while (sh_ipr); |
@@ -459,7 +459,7 @@ static irqreturn_t dma_ccerr_handler(int irq, void *data) | |||
459 | callback) { | 459 | callback) { |
460 | edma_cc[ctlr]->intr_data[k]. | 460 | edma_cc[ctlr]->intr_data[k]. |
461 | callback(k, | 461 | callback(k, |
462 | DMA_CC_ERROR, | 462 | EDMA_DMA_CC_ERROR, |
463 | edma_cc[ctlr]->intr_data | 463 | edma_cc[ctlr]->intr_data |
464 | [k].data); | 464 | [k].data); |
465 | } | 465 | } |
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 29fa35807f09..cb69f3a674e0 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c | |||
@@ -407,7 +407,7 @@ static void edma_callback(unsigned ch_num, u16 ch_status, void *data) | |||
407 | edma_pause(echan->ch_num); | 407 | edma_pause(echan->ch_num); |
408 | 408 | ||
409 | switch (ch_status) { | 409 | switch (ch_status) { |
410 | case DMA_COMPLETE: | 410 | case EDMA_DMA_COMPLETE: |
411 | spin_lock_irqsave(&echan->vchan.lock, flags); | 411 | spin_lock_irqsave(&echan->vchan.lock, flags); |
412 | 412 | ||
413 | edesc = echan->edesc; | 413 | edesc = echan->edesc; |
@@ -426,7 +426,7 @@ static void edma_callback(unsigned ch_num, u16 ch_status, void *data) | |||
426 | spin_unlock_irqrestore(&echan->vchan.lock, flags); | 426 | spin_unlock_irqrestore(&echan->vchan.lock, flags); |
427 | 427 | ||
428 | break; | 428 | break; |
429 | case DMA_CC_ERROR: | 429 | case EDMA_DMA_CC_ERROR: |
430 | spin_lock_irqsave(&echan->vchan.lock, flags); | 430 | spin_lock_irqsave(&echan->vchan.lock, flags); |
431 | 431 | ||
432 | edma_read_slot(EDMA_CHAN_SLOT(echan->slot[0]), &p); | 432 | edma_read_slot(EDMA_CHAN_SLOT(echan->slot[0]), &p); |
diff --git a/include/linux/platform_data/edma.h b/include/linux/platform_data/edma.h index 179fb91bb5f2..f50821cb64be 100644 --- a/include/linux/platform_data/edma.h +++ b/include/linux/platform_data/edma.h | |||
@@ -67,10 +67,10 @@ struct edmacc_param { | |||
67 | #define ITCCHEN BIT(23) | 67 | #define ITCCHEN BIT(23) |
68 | 68 | ||
69 | /*ch_status paramater of callback function possible values*/ | 69 | /*ch_status paramater of callback function possible values*/ |
70 | #define DMA_COMPLETE 1 | 70 | #define EDMA_DMA_COMPLETE 1 |
71 | #define DMA_CC_ERROR 2 | 71 | #define EDMA_DMA_CC_ERROR 2 |
72 | #define DMA_TC1_ERROR 3 | 72 | #define EDMA_DMA_TC1_ERROR 3 |
73 | #define DMA_TC2_ERROR 4 | 73 | #define EDMA_DMA_TC2_ERROR 4 |
74 | 74 | ||
75 | enum address_mode { | 75 | enum address_mode { |
76 | INCR = 0, | 76 | INCR = 0, |