diff options
| author | Arun Sharma <asharma@fb.com> | 2012-04-20 18:41:36 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2012-06-06 11:08:04 -0400 |
| commit | db0dc75d6403b6663c0eab4c6ccb672eb9b2ed72 (patch) | |
| tree | 9c23cf7df8683a3c54bd7f074ceef16712aa7272 | |
| parent | bc6ca7b342d5ae15c3ba3081fd40271b8039fb25 (diff) | |
perf/x86: Check user address explicitly in copy_from_user_nmi()
Signed-off-by: Arun Sharma <asharma@fb.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1334961696-19580-5-git-send-email-asharma@fb.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
| -rw-r--r-- | arch/x86/lib/usercopy.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/arch/x86/lib/usercopy.c b/arch/x86/lib/usercopy.c index f61ee67ec00f..677b1ed184c9 100644 --- a/arch/x86/lib/usercopy.c +++ b/arch/x86/lib/usercopy.c | |||
| @@ -8,6 +8,7 @@ | |||
| 8 | #include <linux/module.h> | 8 | #include <linux/module.h> |
| 9 | 9 | ||
| 10 | #include <asm/word-at-a-time.h> | 10 | #include <asm/word-at-a-time.h> |
| 11 | #include <linux/sched.h> | ||
| 11 | 12 | ||
| 12 | /* | 13 | /* |
| 13 | * best effort, GUP based copy_from_user() that is NMI-safe | 14 | * best effort, GUP based copy_from_user() that is NMI-safe |
| @@ -21,6 +22,9 @@ copy_from_user_nmi(void *to, const void __user *from, unsigned long n) | |||
| 21 | void *map; | 22 | void *map; |
| 22 | int ret; | 23 | int ret; |
| 23 | 24 | ||
| 25 | if (__range_not_ok(from, n, TASK_SIZE) == 0) | ||
| 26 | return len; | ||
| 27 | |||
| 24 | do { | 28 | do { |
| 25 | ret = __get_user_pages_fast(addr, 1, 0, &page); | 29 | ret = __get_user_pages_fast(addr, 1, 0, &page); |
| 26 | if (!ret) | 30 | if (!ret) |
