aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTomas Winkler <tomas.winkler@intel.com>2013-01-08 16:07:18 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-01-08 19:40:45 -0500
commitd91aaed30a938c5daae2641e6758dfab8727862e (patch)
treeea42318ed306ca9747fe33a0d04a812857a013b5
parent9dc64d6a26b016df52d222abe9279a92d9f7cc4c (diff)
mei: drop read_pending member form struct mei_cl
read_pending never changes, it is a leftover from the old code. Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/mei/client.c2
-rw-r--r--drivers/misc/mei/main.c4
-rw-r--r--drivers/misc/mei/mei_dev.h1
3 files changed, 2 insertions, 5 deletions
diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c
index e2e9cb7df067..231eda2b09e1 100644
--- a/drivers/misc/mei/client.c
+++ b/drivers/misc/mei/client.c
@@ -631,7 +631,7 @@ int mei_cl_read_start(struct mei_cl *cl)
631 if (dev->dev_state != MEI_DEV_ENABLED) 631 if (dev->dev_state != MEI_DEV_ENABLED)
632 return -ENODEV; 632 return -ENODEV;
633 633
634 if (cl->read_pending || cl->read_cb) { 634 if (cl->read_cb) {
635 dev_dbg(&dev->pdev->dev, "read is pending.\n"); 635 dev_dbg(&dev->pdev->dev, "read is pending.\n");
636 return -EBUSY; 636 return -EBUSY;
637 } 637 }
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index e31ade30086d..5c7c85505c91 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -380,7 +380,6 @@ free:
380 mei_io_cb_free(cb); 380 mei_io_cb_free(cb);
381 cl->reading_state = MEI_IDLE; 381 cl->reading_state = MEI_IDLE;
382 cl->read_cb = NULL; 382 cl->read_cb = NULL;
383 cl->read_pending = 0;
384out: 383out:
385 dev_dbg(&dev->pdev->dev, "end mei read rets= %d\n", rets); 384 dev_dbg(&dev->pdev->dev, "end mei read rets= %d\n", rets);
386 mutex_unlock(&dev->device_lock); 385 mutex_unlock(&dev->device_lock);
@@ -462,9 +461,8 @@ static ssize_t mei_write(struct file *file, const char __user *ubuf,
462 write_cb = NULL; 461 write_cb = NULL;
463 cl->reading_state = MEI_IDLE; 462 cl->reading_state = MEI_IDLE;
464 cl->read_cb = NULL; 463 cl->read_cb = NULL;
465 cl->read_pending = 0;
466 } 464 }
467 } else if (cl->reading_state == MEI_IDLE && !cl->read_pending) 465 } else if (cl->reading_state == MEI_IDLE)
468 *offset = 0; 466 *offset = 0;
469 467
470 468
diff --git a/drivers/misc/mei/mei_dev.h b/drivers/misc/mei/mei_dev.h
index 87b1f6a1a1dd..11ff875e8658 100644
--- a/drivers/misc/mei/mei_dev.h
+++ b/drivers/misc/mei/mei_dev.h
@@ -199,7 +199,6 @@ struct mei_cl {
199 wait_queue_head_t tx_wait; 199 wait_queue_head_t tx_wait;
200 wait_queue_head_t rx_wait; 200 wait_queue_head_t rx_wait;
201 wait_queue_head_t wait; 201 wait_queue_head_t wait;
202 int read_pending;
203 int status; 202 int status;
204 /* ID of client connected */ 203 /* ID of client connected */
205 u8 host_client_id; 204 u8 host_client_id;