diff options
author | Tyrel Datwyler <tyreld@linux.vnet.ibm.com> | 2013-08-15 01:23:45 -0400 |
---|---|---|
committer | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2013-08-27 00:45:10 -0400 |
commit | d8e533b45fd98aa72957d9580d97aa0ab45265ad (patch) | |
tree | 5893062a920f299f6f8ed0d1323a81667bfd53f1 | |
parent | b3f6a45925232d29519007f1ba6687e1e790fb5d (diff) |
powerpc/pseries: Fix creation of loop in device node property list
The update_dt_prop helper function fails to set the IN/OUT parameter prop to
NULL after a complete property has been parsed from the work area returned by
the ibm,update-properties rtas function. This results in the property list of
the device node being updated is corrupted and becomes a loop since the same
property structure is used repeatedly.
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Acked-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
-rw-r--r-- | arch/powerpc/platforms/pseries/mobility.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/platforms/pseries/mobility.c b/arch/powerpc/platforms/pseries/mobility.c index 3d01eee9ffb1..f28abeeecbd5 100644 --- a/arch/powerpc/platforms/pseries/mobility.c +++ b/arch/powerpc/platforms/pseries/mobility.c | |||
@@ -119,7 +119,7 @@ static int update_dt_property(struct device_node *dn, struct property **prop, | |||
119 | 119 | ||
120 | if (!more) { | 120 | if (!more) { |
121 | of_update_property(dn, new_prop); | 121 | of_update_property(dn, new_prop); |
122 | new_prop = NULL; | 122 | *prop = NULL; |
123 | } | 123 | } |
124 | 124 | ||
125 | return 0; | 125 | return 0; |