diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2014-11-30 12:03:47 -0500 |
---|---|---|
committer | Herbert Xu <herbert@gondor.apana.org.au> | 2014-12-02 09:55:50 -0500 |
commit | d83480b061f95db90bd9df69a21c20d0fd5c9232 (patch) | |
tree | b9f8d01de0402abde928c0bdb7dc463acb90d3ab | |
parent | a6326ba025a4bc025c8c9a15ea2f307936a93843 (diff) |
crypto: powerpc - replace memset by memzero_explicit
Memset on a local variable may be removed when it is called just before the
variable goes out of scope. Using memzero_explicit defeats this
optimization. A simplified version of the semantic patch that makes this
change is as follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
identifier x;
type T;
@@
{
... when any
T x[...];
... when any
when exists
- memset
+ memzero_explicit
(x,
-0,
...)
... when != x
when strict
}
// </smpl>
This change was suggested by Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
-rw-r--r-- | arch/powerpc/crypto/sha1.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/crypto/sha1.c b/arch/powerpc/crypto/sha1.c index 0f88c7b41119..d3feba5a275f 100644 --- a/arch/powerpc/crypto/sha1.c +++ b/arch/powerpc/crypto/sha1.c | |||
@@ -66,7 +66,7 @@ static int sha1_update(struct shash_desc *desc, const u8 *data, | |||
66 | src = data + done; | 66 | src = data + done; |
67 | } while (done + 63 < len); | 67 | } while (done + 63 < len); |
68 | 68 | ||
69 | memset(temp, 0, sizeof(temp)); | 69 | memzero_explicit(temp, sizeof(temp)); |
70 | partial = 0; | 70 | partial = 0; |
71 | } | 71 | } |
72 | memcpy(sctx->buffer + partial, src, len - done); | 72 | memcpy(sctx->buffer + partial, src, len - done); |