aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartyn Welch <martyn.welch@ge.com>2013-11-08 06:58:35 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-12-03 14:15:58 -0500
commitd7729f0fc40296f91b483dfb929e71b27cf75345 (patch)
tree6c6d2a0f7645831c5d0908bec40fa786814f2699
parent978f47d64365fa1659178e54c5106154c315b595 (diff)
VME: Rename vme_slot_get to avoid confusion with reference counting
Traditionally the "get" functions increment the reference count of the object that is returned, which does not happen with vme_slot_get. The function vme_slot_get returns the physical VME slot associated with a particular struct vme_dev. Rename vme_slot_num to avoid any confusion. Signed-off-by: Martyn Welch <martyn.welch@ge.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--Documentation/vme_api.txt2
-rw-r--r--drivers/staging/vme/devices/vme_user.c2
-rw-r--r--drivers/vme/vme.c6
-rw-r--r--include/linux/vme.h2
4 files changed, 6 insertions, 6 deletions
diff --git a/Documentation/vme_api.txt b/Documentation/vme_api.txt
index 126a1f1d5151..ffe6e22a2ccd 100644
--- a/Documentation/vme_api.txt
+++ b/Documentation/vme_api.txt
@@ -393,7 +393,7 @@ Slot Detection
393 393
394This function returns the slot ID of the provided bridge. 394This function returns the slot ID of the provided bridge.
395 395
396 int vme_slot_get(struct vme_dev *dev); 396 int vme_slot_num(struct vme_dev *dev);
397 397
398 398
399Bus Detection 399Bus Detection
diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
index caee906f9b38..bc4f8623c8cc 100644
--- a/drivers/staging/vme/devices/vme_user.c
+++ b/drivers/staging/vme/devices/vme_user.c
@@ -666,7 +666,7 @@ static int vme_user_match(struct vme_dev *vdev)
666 int i; 666 int i;
667 667
668 int cur_bus = vme_bus_num(vdev); 668 int cur_bus = vme_bus_num(vdev);
669 int cur_slot = vme_slot_get(vdev); 669 int cur_slot = vme_slot_num(vdev);
670 670
671 for (i = 0; i < bus_num; i++) 671 for (i = 0; i < bus_num; i++)
672 if ((cur_bus == bus[i]) && (cur_slot == vdev->num)) 672 if ((cur_bus == bus[i]) && (cur_slot == vdev->num))
diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c
index 8df5e4efc1ca..96562c9a8b1b 100644
--- a/drivers/vme/vme.c
+++ b/drivers/vme/vme.c
@@ -1274,7 +1274,7 @@ void vme_lm_free(struct vme_resource *resource)
1274} 1274}
1275EXPORT_SYMBOL(vme_lm_free); 1275EXPORT_SYMBOL(vme_lm_free);
1276 1276
1277int vme_slot_get(struct vme_dev *vdev) 1277int vme_slot_num(struct vme_dev *vdev)
1278{ 1278{
1279 struct vme_bridge *bridge; 1279 struct vme_bridge *bridge;
1280 1280
@@ -1285,13 +1285,13 @@ int vme_slot_get(struct vme_dev *vdev)
1285 } 1285 }
1286 1286
1287 if (bridge->slot_get == NULL) { 1287 if (bridge->slot_get == NULL) {
1288 printk(KERN_WARNING "vme_slot_get not supported\n"); 1288 printk(KERN_WARNING "vme_slot_num not supported\n");
1289 return -EINVAL; 1289 return -EINVAL;
1290 } 1290 }
1291 1291
1292 return bridge->slot_get(bridge); 1292 return bridge->slot_get(bridge);
1293} 1293}
1294EXPORT_SYMBOL(vme_slot_get); 1294EXPORT_SYMBOL(vme_slot_num);
1295 1295
1296int vme_bus_num(struct vme_dev *vdev) 1296int vme_bus_num(struct vme_dev *vdev)
1297{ 1297{
diff --git a/include/linux/vme.h b/include/linux/vme.h
index 4eb42c8f097d..8cd6f19ca518 100644
--- a/include/linux/vme.h
+++ b/include/linux/vme.h
@@ -164,7 +164,7 @@ int vme_lm_attach(struct vme_resource *, int, void (*callback)(int));
164int vme_lm_detach(struct vme_resource *, int); 164int vme_lm_detach(struct vme_resource *, int);
165void vme_lm_free(struct vme_resource *); 165void vme_lm_free(struct vme_resource *);
166 166
167int vme_slot_get(struct vme_dev *); 167int vme_slot_num(struct vme_dev *);
168int vme_bus_num(struct vme_dev *); 168int vme_bus_num(struct vme_dev *);
169 169
170int vme_register_driver(struct vme_driver *, unsigned int); 170int vme_register_driver(struct vme_driver *, unsigned int);