diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-11-16 10:46:38 -0500 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-11-16 10:46:38 -0500 |
| commit | d6ee1a2894c445a0bed1d2dc04e8f13f1f6c0311 (patch) | |
| tree | 78bd745e014adc8cfbce8421d6bf966d5815388d | |
| parent | 7e111565b70e57ae45d154d79581ecc591d19d9a (diff) | |
| parent | 1838b8c487378c6c576029d9e0e07b5a73036bac (diff) | |
Merge tag 'tty-3.7-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
Pull TTY fixes from Greg Kroah-Hartman:
"Here are two TTY driver fixes for 3.7-rc5.
They resolve a bug in the hvc driver that has been reported, and fix a
problem with the list of device ids in the max310x serial driver.
Both have been in linux-next for a while.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>"
* tag 'tty-3.7-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty:
tty: serial: max310x: Add terminating entry for spi_device_id table
TTY: hvc_console, fix port reference count going to zero prematurely
| -rw-r--r-- | drivers/tty/hvc/hvc_console.c | 7 | ||||
| -rw-r--r-- | drivers/tty/serial/max310x.c | 1 |
2 files changed, 1 insertions, 7 deletions
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index a5dec1ca1b82..13ee53bd0bf6 100644 --- a/drivers/tty/hvc/hvc_console.c +++ b/drivers/tty/hvc/hvc_console.c | |||
| @@ -424,7 +424,6 @@ static void hvc_hangup(struct tty_struct *tty) | |||
| 424 | { | 424 | { |
| 425 | struct hvc_struct *hp = tty->driver_data; | 425 | struct hvc_struct *hp = tty->driver_data; |
| 426 | unsigned long flags; | 426 | unsigned long flags; |
| 427 | int temp_open_count; | ||
| 428 | 427 | ||
| 429 | if (!hp) | 428 | if (!hp) |
| 430 | return; | 429 | return; |
| @@ -444,7 +443,6 @@ static void hvc_hangup(struct tty_struct *tty) | |||
| 444 | return; | 443 | return; |
| 445 | } | 444 | } |
| 446 | 445 | ||
| 447 | temp_open_count = hp->port.count; | ||
| 448 | hp->port.count = 0; | 446 | hp->port.count = 0; |
| 449 | spin_unlock_irqrestore(&hp->port.lock, flags); | 447 | spin_unlock_irqrestore(&hp->port.lock, flags); |
| 450 | tty_port_tty_set(&hp->port, NULL); | 448 | tty_port_tty_set(&hp->port, NULL); |
| @@ -453,11 +451,6 @@ static void hvc_hangup(struct tty_struct *tty) | |||
| 453 | 451 | ||
| 454 | if (hp->ops->notifier_hangup) | 452 | if (hp->ops->notifier_hangup) |
| 455 | hp->ops->notifier_hangup(hp, hp->data); | 453 | hp->ops->notifier_hangup(hp, hp->data); |
| 456 | |||
| 457 | while(temp_open_count) { | ||
| 458 | --temp_open_count; | ||
| 459 | tty_port_put(&hp->port); | ||
| 460 | } | ||
| 461 | } | 454 | } |
| 462 | 455 | ||
| 463 | /* | 456 | /* |
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty/serial/max310x.c index 2bc28a59d385..1ab1d2c66de4 100644 --- a/drivers/tty/serial/max310x.c +++ b/drivers/tty/serial/max310x.c | |||
| @@ -1239,6 +1239,7 @@ static int __devexit max310x_remove(struct spi_device *spi) | |||
| 1239 | static const struct spi_device_id max310x_id_table[] = { | 1239 | static const struct spi_device_id max310x_id_table[] = { |
| 1240 | { "max3107", MAX310X_TYPE_MAX3107 }, | 1240 | { "max3107", MAX310X_TYPE_MAX3107 }, |
| 1241 | { "max3108", MAX310X_TYPE_MAX3108 }, | 1241 | { "max3108", MAX310X_TYPE_MAX3108 }, |
| 1242 | { } | ||
| 1242 | }; | 1243 | }; |
| 1243 | MODULE_DEVICE_TABLE(spi, max310x_id_table); | 1244 | MODULE_DEVICE_TABLE(spi, max310x_id_table); |
| 1244 | 1245 | ||
