diff options
author | Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> | 2014-12-20 11:19:02 -0500 |
---|---|---|
committer | Roland Dreier <roland@purestorage.com> | 2015-02-13 14:17:29 -0500 |
commit | d6522223e4a07f7bc59d5b37b26d38a0a85baaaf (patch) | |
tree | ad6dcebd21b9f3fd4b2465714788e4d99a40dd1d | |
parent | bfa76d49576599a4b9f9b7a71f23d73d6dcff735 (diff) |
IB/ipath: Remove unused function in ipath_wc_ppc64
Remove the function ipath_unordered_wc() that is not used anywhere.
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
-rw-r--r-- | drivers/infiniband/hw/ipath/ipath_kernel.h | 3 | ||||
-rw-r--r-- | drivers/infiniband/hw/ipath/ipath_wc_ppc64.c | 13 | ||||
-rw-r--r-- | drivers/infiniband/hw/ipath/ipath_wc_x86_64.c | 15 |
3 files changed, 0 insertions, 31 deletions
diff --git a/drivers/infiniband/hw/ipath/ipath_kernel.h b/drivers/infiniband/hw/ipath/ipath_kernel.h index 6559af60bffd..e08db7020cd4 100644 --- a/drivers/infiniband/hw/ipath/ipath_kernel.h +++ b/drivers/infiniband/hw/ipath/ipath_kernel.h | |||
@@ -908,9 +908,6 @@ void ipath_chip_cleanup(struct ipath_devdata *); | |||
908 | /* clean up any chip type-specific stuff */ | 908 | /* clean up any chip type-specific stuff */ |
909 | void ipath_chip_done(void); | 909 | void ipath_chip_done(void); |
910 | 910 | ||
911 | /* check to see if we have to force ordering for write combining */ | ||
912 | int ipath_unordered_wc(void); | ||
913 | |||
914 | void ipath_disarm_piobufs(struct ipath_devdata *, unsigned first, | 911 | void ipath_disarm_piobufs(struct ipath_devdata *, unsigned first, |
915 | unsigned cnt); | 912 | unsigned cnt); |
916 | void ipath_cancel_sends(struct ipath_devdata *, int); | 913 | void ipath_cancel_sends(struct ipath_devdata *, int); |
diff --git a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c b/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c index 1d7bd82a1fb1..1a7e20a75149 100644 --- a/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c +++ b/drivers/infiniband/hw/ipath/ipath_wc_ppc64.c | |||
@@ -47,16 +47,3 @@ int ipath_enable_wc(struct ipath_devdata *dd) | |||
47 | { | 47 | { |
48 | return 0; | 48 | return 0; |
49 | } | 49 | } |
50 | |||
51 | /** | ||
52 | * ipath_unordered_wc - indicate whether write combining is unordered | ||
53 | * | ||
54 | * Because our performance depends on our ability to do write | ||
55 | * combining mmio writes in the most efficient way, we need to | ||
56 | * know if we are on a processor that may reorder stores when | ||
57 | * write combining. | ||
58 | */ | ||
59 | int ipath_unordered_wc(void) | ||
60 | { | ||
61 | return 1; | ||
62 | } | ||
diff --git a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c b/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c index 3428acb0868c..4ad0b932df1f 100644 --- a/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c +++ b/drivers/infiniband/hw/ipath/ipath_wc_x86_64.c | |||
@@ -167,18 +167,3 @@ void ipath_disable_wc(struct ipath_devdata *dd) | |||
167 | dd->ipath_wc_cookie = 0; /* even on failure */ | 167 | dd->ipath_wc_cookie = 0; /* even on failure */ |
168 | } | 168 | } |
169 | } | 169 | } |
170 | |||
171 | /** | ||
172 | * ipath_unordered_wc - indicate whether write combining is ordered | ||
173 | * | ||
174 | * Because our performance depends on our ability to do write combining mmio | ||
175 | * writes in the most efficient way, we need to know if we are on an Intel | ||
176 | * or AMD x86_64 processor. AMD x86_64 processors flush WC buffers out in | ||
177 | * the order completed, and so no special flushing is required to get | ||
178 | * correct ordering. Intel processors, however, will flush write buffers | ||
179 | * out in "random" orders, and so explicit ordering is needed at times. | ||
180 | */ | ||
181 | int ipath_unordered_wc(void) | ||
182 | { | ||
183 | return boot_cpu_data.x86_vendor != X86_VENDOR_AMD; | ||
184 | } | ||