diff options
author | Peter Senna Tschudin <peter.senna@gmail.com> | 2012-10-03 08:40:43 -0400 |
---|---|---|
committer | Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2012-10-09 22:06:18 -0400 |
commit | d63f2c532fb8885e481a7b626823a0c183694b53 (patch) | |
tree | 317fa30f83ac38defb971006a4fb4095a61e2588 | |
parent | 5ce24978983477034f0b0c0bfd7e4a6026103958 (diff) |
drivers/video/savage/savagefb_driver.c: fix error return code
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
-rw-r--r-- | drivers/video/savage/savagefb_driver.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/savage/savagefb_driver.c b/drivers/video/savage/savagefb_driver.c index 0d0f52c18fd8..f4f53b082d05 100644 --- a/drivers/video/savage/savagefb_driver.c +++ b/drivers/video/savage/savagefb_driver.c | |||
@@ -2266,8 +2266,10 @@ static int __devinit savagefb_probe(struct pci_dev* dev, | |||
2266 | lpitch = info->var.xres_virtual*((info->var.bits_per_pixel + 7) >> 3); | 2266 | lpitch = info->var.xres_virtual*((info->var.bits_per_pixel + 7) >> 3); |
2267 | info->var.yres_virtual = info->fix.smem_len/lpitch; | 2267 | info->var.yres_virtual = info->fix.smem_len/lpitch; |
2268 | 2268 | ||
2269 | if (info->var.yres_virtual < info->var.yres) | 2269 | if (info->var.yres_virtual < info->var.yres) { |
2270 | err = -ENOMEM; | ||
2270 | goto failed; | 2271 | goto failed; |
2272 | } | ||
2271 | 2273 | ||
2272 | #if defined(CONFIG_FB_SAVAGE_ACCEL) | 2274 | #if defined(CONFIG_FB_SAVAGE_ACCEL) |
2273 | /* | 2275 | /* |