diff options
author | Laurent Pinchart <laurent.pinchart@skynet.be> | 2008-09-15 21:24:29 -0400 |
---|---|---|
committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2008-10-12 07:37:08 -0400 |
commit | d63beb9ef004ff9587b3c466361276254d57d7a7 (patch) | |
tree | 76b06c29dc32ffd60d0b54e719da31b5d6d78b1e | |
parent | 80845e1078463913f8b456e45f1fae886687c363 (diff) |
V4L/DVB (9031): uvcvideo: Fix incomplete frame drop when switching to a variable size format.
When streaming in a fixed size format the driver sets a flag in the uvc_queue
structure to drop incomplete incoming frames. The flag wasn't cleared when
switching to a variable size format, which resulted in a broken
'MJPEG after YUV'.
Signed-off-by: Laurent Pinchart <laurent.pinchart@skynet.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
-rw-r--r-- | drivers/media/video/uvc/uvc_v4l2.c | 4 | ||||
-rw-r--r-- | drivers/media/video/uvc/uvc_video.c | 5 |
2 files changed, 5 insertions, 4 deletions
diff --git a/drivers/media/video/uvc/uvc_v4l2.c b/drivers/media/video/uvc/uvc_v4l2.c index d4758c8e13ad..78e4c4e09d89 100644 --- a/drivers/media/video/uvc/uvc_v4l2.c +++ b/drivers/media/video/uvc/uvc_v4l2.c | |||
@@ -842,10 +842,6 @@ static int uvc_v4l2_do_ioctl(struct inode *inode, struct file *file, | |||
842 | if (ret < 0) | 842 | if (ret < 0) |
843 | return ret; | 843 | return ret; |
844 | 844 | ||
845 | if (!(video->streaming->cur_format->flags & | ||
846 | UVC_FMT_FLAG_COMPRESSED)) | ||
847 | video->queue.flags |= UVC_QUEUE_DROP_INCOMPLETE; | ||
848 | |||
849 | rb->count = ret; | 845 | rb->count = ret; |
850 | ret = 0; | 846 | ret = 0; |
851 | break; | 847 | break; |
diff --git a/drivers/media/video/uvc/uvc_video.c b/drivers/media/video/uvc/uvc_video.c index 593aebffe57d..b7bb23820d80 100644 --- a/drivers/media/video/uvc/uvc_video.c +++ b/drivers/media/video/uvc/uvc_video.c | |||
@@ -971,6 +971,11 @@ int uvc_video_enable(struct uvc_video_device *video, int enable) | |||
971 | return 0; | 971 | return 0; |
972 | } | 972 | } |
973 | 973 | ||
974 | if (video->streaming->cur_format->flags & UVC_FMT_FLAG_COMPRESSED) | ||
975 | video->queue.flags &= ~UVC_QUEUE_DROP_INCOMPLETE; | ||
976 | else | ||
977 | video->queue.flags |= UVC_QUEUE_DROP_INCOMPLETE; | ||
978 | |||
974 | if ((ret = uvc_queue_enable(&video->queue, 1)) < 0) | 979 | if ((ret = uvc_queue_enable(&video->queue, 1)) < 0) |
975 | return ret; | 980 | return ret; |
976 | 981 | ||