aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPavel Emelyanov <xemul@openvz.org>2008-05-19 16:45:33 -0400
committerDavid S. Miller <davem@davemloft.net>2008-05-19 16:45:33 -0400
commitd62c612ef8a66be534a3ada598cfa28d40cd0b3c (patch)
treed076e1ceaaff2aca70883a915bfb771c56034487
parent5b06c85c3b96fa8db632f1ee94f99a2bd0215f3a (diff)
netns: Introduce sysctl root for read-only net sysctls.
This one stores all ctl-heads in one list and restricts the permissions not give write access to non-init net namespaces. Signed-off-by: Pavel Emelyanov <xemul@openvz.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--include/net/net_namespace.h3
-rw-r--r--net/sysctl_net.c30
2 files changed, 33 insertions, 0 deletions
diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h
index aa540e6be502..8df751b3be55 100644
--- a/include/net/net_namespace.h
+++ b/include/net/net_namespace.h
@@ -201,8 +201,11 @@ extern void unregister_pernet_gen_device(int id, struct pernet_operations *);
201struct ctl_path; 201struct ctl_path;
202struct ctl_table; 202struct ctl_table;
203struct ctl_table_header; 203struct ctl_table_header;
204
204extern struct ctl_table_header *register_net_sysctl_table(struct net *net, 205extern struct ctl_table_header *register_net_sysctl_table(struct net *net,
205 const struct ctl_path *path, struct ctl_table *table); 206 const struct ctl_path *path, struct ctl_table *table);
207extern struct ctl_table_header *register_net_sysctl_rotable(
208 const struct ctl_path *path, struct ctl_table *table);
206extern void unregister_net_sysctl_table(struct ctl_table_header *header); 209extern void unregister_net_sysctl_table(struct ctl_table_header *header);
207 210
208#endif /* __NET_NET_NAMESPACE_H */ 211#endif /* __NET_NET_NAMESPACE_H */
diff --git a/net/sysctl_net.c b/net/sysctl_net.c
index b4f0525f91af..d8e79162724c 100644
--- a/net/sysctl_net.c
+++ b/net/sysctl_net.c
@@ -40,6 +40,27 @@ static struct ctl_table_root net_sysctl_root = {
40 .lookup = net_ctl_header_lookup, 40 .lookup = net_ctl_header_lookup,
41}; 41};
42 42
43static LIST_HEAD(net_sysctl_ro_tables);
44static struct list_head *net_ctl_ro_header_lookup(struct ctl_table_root *root,
45 struct nsproxy *namespaces)
46{
47 return &net_sysctl_ro_tables;
48}
49
50static int net_ctl_ro_header_perms(struct ctl_table_root *root,
51 struct nsproxy *namespaces, struct ctl_table *table)
52{
53 if (namespaces->net_ns == &init_net)
54 return table->mode;
55 else
56 return table->mode & ~0222;
57}
58
59static struct ctl_table_root net_sysctl_ro_root = {
60 .lookup = net_ctl_ro_header_lookup,
61 .permissions = net_ctl_ro_header_perms,
62};
63
43static int sysctl_net_init(struct net *net) 64static int sysctl_net_init(struct net *net)
44{ 65{
45 INIT_LIST_HEAD(&net->sysctl_table_headers); 66 INIT_LIST_HEAD(&net->sysctl_table_headers);
@@ -64,6 +85,7 @@ static __init int sysctl_init(void)
64 if (ret) 85 if (ret)
65 goto out; 86 goto out;
66 register_sysctl_root(&net_sysctl_root); 87 register_sysctl_root(&net_sysctl_root);
88 register_sysctl_root(&net_sysctl_ro_root);
67out: 89out:
68 return ret; 90 return ret;
69} 91}
@@ -80,6 +102,14 @@ struct ctl_table_header *register_net_sysctl_table(struct net *net,
80} 102}
81EXPORT_SYMBOL_GPL(register_net_sysctl_table); 103EXPORT_SYMBOL_GPL(register_net_sysctl_table);
82 104
105struct ctl_table_header *register_net_sysctl_rotable(const
106 struct ctl_path *path, struct ctl_table *table)
107{
108 return __register_sysctl_paths(&net_sysctl_ro_root,
109 &init_nsproxy, path, table);
110}
111EXPORT_SYMBOL_GPL(register_net_sysctl_rotable);
112
83void unregister_net_sysctl_table(struct ctl_table_header *header) 113void unregister_net_sysctl_table(struct ctl_table_header *header)
84{ 114{
85 unregister_sysctl_table(header); 115 unregister_sysctl_table(header);