diff options
author | Lee Jones <lee.jones@linaro.org> | 2014-07-21 10:10:35 -0400 |
---|---|---|
committer | Lee Jones <lee.jones@linaro.org> | 2014-07-25 10:31:43 -0400 |
commit | d5ce79ff20914dd187c25d000b6a8a25a47d7ebe (patch) | |
tree | 81a3fe6b4f54515e8432ba667885bc796a4ecd17 | |
parent | 3103de8cd4e862c48a02327a21aec459c2c7dbb0 (diff) |
mfd: tc6387xb: Remove unnecessary braces and correct style warnings
This is part of an effort to clean-up the MFD subsystem.
WARNING: braces {} are not necessary for single statement blocks
+ if (!iomem) {
+ return -EINVAL;
+ }
WARNING: sizeof *tc6387xb should be sizeof(*tc6387xb)
+ tc6387xb = kzalloc(sizeof *tc6387xb, GFP_KERNEL);
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
+ printk(KERN_INFO "Toshiba tc6387xb initialised\n");
total: 0 errors, 3 warnings, 242 lines checked
Signed-off-by: Lee Jones <lee.jones@linaro.org>
-rw-r--r-- | drivers/mfd/tc6387xb.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/drivers/mfd/tc6387xb.c b/drivers/mfd/tc6387xb.c index 591a331d8d83..e71f88000ae5 100644 --- a/drivers/mfd/tc6387xb.c +++ b/drivers/mfd/tc6387xb.c | |||
@@ -147,11 +147,10 @@ static int tc6387xb_probe(struct platform_device *dev) | |||
147 | int irq, ret; | 147 | int irq, ret; |
148 | 148 | ||
149 | iomem = platform_get_resource(dev, IORESOURCE_MEM, 0); | 149 | iomem = platform_get_resource(dev, IORESOURCE_MEM, 0); |
150 | if (!iomem) { | 150 | if (!iomem) |
151 | return -EINVAL; | 151 | return -EINVAL; |
152 | } | ||
153 | 152 | ||
154 | tc6387xb = kzalloc(sizeof *tc6387xb, GFP_KERNEL); | 153 | tc6387xb = kzalloc(sizeof(*tc6387xb), GFP_KERNEL); |
155 | if (!tc6387xb) | 154 | if (!tc6387xb) |
156 | return -ENOMEM; | 155 | return -ENOMEM; |
157 | 156 | ||
@@ -189,7 +188,7 @@ static int tc6387xb_probe(struct platform_device *dev) | |||
189 | if (pdata && pdata->enable) | 188 | if (pdata && pdata->enable) |
190 | pdata->enable(dev); | 189 | pdata->enable(dev); |
191 | 190 | ||
192 | printk(KERN_INFO "Toshiba tc6387xb initialised\n"); | 191 | dev_info(&dev->dev, "Toshiba tc6387xb initialised\n"); |
193 | 192 | ||
194 | ret = mfd_add_devices(&dev->dev, dev->id, tc6387xb_cells, | 193 | ret = mfd_add_devices(&dev->dev, dev->id, tc6387xb_cells, |
195 | ARRAY_SIZE(tc6387xb_cells), iomem, irq, NULL); | 194 | ARRAY_SIZE(tc6387xb_cells), iomem, irq, NULL); |