diff options
author | Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> | 2014-11-13 10:01:21 -0500 |
---|---|---|
committer | Eduardo Valentin <edubezval@gmail.com> | 2014-11-20 09:54:20 -0500 |
commit | d564b55a81e720430f50e301ff330b1c9ec3944c (patch) | |
tree | 633673fd6a801c5e7b4975aa70260afb013cc9dd | |
parent | e0761533a1d41e7486bddac75ee878e9814ec0e3 (diff) |
thermal: exynos: remove TMU_SUPPORT_EMUL_TIME flag
Replace TMU_SUPPORT_EMUL_TIME flag check in get_emul_con_reg()
by an explicit check for a SoC type (all SoC types except
Exynos4210 and Exynos5440 have TMU_SUPPORT_EMUL_TIME flag set
in their struct exynos_tmu_init_data instances).
There should be no functional changes caused by this patch.
Cc: Amit Daniel Kachhap <amit.daniel@samsung.com>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Tested-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
-rw-r--r-- | drivers/thermal/samsung/exynos_tmu.c | 4 | ||||
-rw-r--r-- | drivers/thermal/samsung/exynos_tmu.h | 5 | ||||
-rw-r--r-- | drivers/thermal/samsung/exynos_tmu_data.c | 11 |
3 files changed, 7 insertions, 13 deletions
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 6795ddc07b4c..209221f1fab2 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c | |||
@@ -427,12 +427,10 @@ static int exynos_tmu_read(struct exynos_tmu_data *data) | |||
427 | static u32 get_emul_con_reg(struct exynos_tmu_data *data, unsigned int val, | 427 | static u32 get_emul_con_reg(struct exynos_tmu_data *data, unsigned int val, |
428 | unsigned long temp) | 428 | unsigned long temp) |
429 | { | 429 | { |
430 | struct exynos_tmu_platform_data *pdata = data->pdata; | ||
431 | |||
432 | if (temp) { | 430 | if (temp) { |
433 | temp /= MCELSIUS; | 431 | temp /= MCELSIUS; |
434 | 432 | ||
435 | if (TMU_SUPPORTS(pdata, EMUL_TIME)) { | 433 | if (data->soc != SOC_ARCH_EXYNOS5440) { |
436 | val &= ~(EXYNOS_EMUL_TIME_MASK << EXYNOS_EMUL_TIME_SHIFT); | 434 | val &= ~(EXYNOS_EMUL_TIME_MASK << EXYNOS_EMUL_TIME_SHIFT); |
437 | val |= (EXYNOS_EMUL_TIME << EXYNOS_EMUL_TIME_SHIFT); | 435 | val |= (EXYNOS_EMUL_TIME << EXYNOS_EMUL_TIME_SHIFT); |
438 | } | 436 | } |
diff --git a/drivers/thermal/samsung/exynos_tmu.h b/drivers/thermal/samsung/exynos_tmu.h index ed83d3d10ad8..d90852a0b403 100644 --- a/drivers/thermal/samsung/exynos_tmu.h +++ b/drivers/thermal/samsung/exynos_tmu.h | |||
@@ -51,16 +51,13 @@ enum soc_type { | |||
51 | * temperature to the TMU controller. | 51 | * temperature to the TMU controller. |
52 | * TMU_SUPPORT_MULTI_INST - This features denotes that the soc | 52 | * TMU_SUPPORT_MULTI_INST - This features denotes that the soc |
53 | * has many instances of TMU. | 53 | * has many instances of TMU. |
54 | * TMU_SUPPORT_EMUL_TIME - This features allows to set next temp emulation | ||
55 | * sample time. | ||
56 | * TMU_SUPPORT_ADDRESS_MULTIPLE - This feature tells that the different TMU | 54 | * TMU_SUPPORT_ADDRESS_MULTIPLE - This feature tells that the different TMU |
57 | * sensors shares some common registers. | 55 | * sensors shares some common registers. |
58 | * TMU_SUPPORT - macro to compare the above features with the supplied. | 56 | * TMU_SUPPORT - macro to compare the above features with the supplied. |
59 | */ | 57 | */ |
60 | #define TMU_SUPPORT_EMULATION BIT(0) | 58 | #define TMU_SUPPORT_EMULATION BIT(0) |
61 | #define TMU_SUPPORT_MULTI_INST BIT(1) | 59 | #define TMU_SUPPORT_MULTI_INST BIT(1) |
62 | #define TMU_SUPPORT_EMUL_TIME BIT(2) | 60 | #define TMU_SUPPORT_ADDRESS_MULTIPLE BIT(2) |
63 | #define TMU_SUPPORT_ADDRESS_MULTIPLE BIT(3) | ||
64 | 61 | ||
65 | #define TMU_SUPPORTS(a, b) (a->features & TMU_SUPPORT_ ## b) | 62 | #define TMU_SUPPORTS(a, b) (a->features & TMU_SUPPORT_ ## b) |
66 | 63 | ||
diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c index 39b96514b540..82f1cba2dc7f 100644 --- a/drivers/thermal/samsung/exynos_tmu_data.c +++ b/drivers/thermal/samsung/exynos_tmu_data.c | |||
@@ -101,7 +101,7 @@ struct exynos_tmu_init_data const exynos4210_default_tmu_data = { | |||
101 | .temp_level = 95, \ | 101 | .temp_level = 95, \ |
102 | }, \ | 102 | }, \ |
103 | .freq_tab_count = 2, \ | 103 | .freq_tab_count = 2, \ |
104 | .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_EMUL_TIME) | 104 | .features = TMU_SUPPORT_EMULATION |
105 | #endif | 105 | #endif |
106 | 106 | ||
107 | #if defined(CONFIG_SOC_EXYNOS3250) | 107 | #if defined(CONFIG_SOC_EXYNOS3250) |
@@ -153,7 +153,7 @@ struct exynos_tmu_init_data const exynos3250_default_tmu_data = { | |||
153 | .temp_level = 95, \ | 153 | .temp_level = 95, \ |
154 | }, \ | 154 | }, \ |
155 | .freq_tab_count = 2, \ | 155 | .freq_tab_count = 2, \ |
156 | .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_EMUL_TIME) | 156 | .features = TMU_SUPPORT_EMULATION |
157 | #endif | 157 | #endif |
158 | 158 | ||
159 | #if defined(CONFIG_SOC_EXYNOS4412) | 159 | #if defined(CONFIG_SOC_EXYNOS4412) |
@@ -221,7 +221,7 @@ struct exynos_tmu_init_data const exynos5250_default_tmu_data = { | |||
221 | #define EXYNOS5260_TMU_DATA \ | 221 | #define EXYNOS5260_TMU_DATA \ |
222 | __EXYNOS5260_TMU_DATA \ | 222 | __EXYNOS5260_TMU_DATA \ |
223 | .type = SOC_ARCH_EXYNOS5260, \ | 223 | .type = SOC_ARCH_EXYNOS5260, \ |
224 | .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_EMUL_TIME) | 224 | .features = TMU_SUPPORT_EMULATION |
225 | 225 | ||
226 | struct exynos_tmu_init_data const exynos5260_default_tmu_data = { | 226 | struct exynos_tmu_init_data const exynos5260_default_tmu_data = { |
227 | .tmu_data = { | 227 | .tmu_data = { |
@@ -275,13 +275,12 @@ struct exynos_tmu_init_data const exynos5260_default_tmu_data = { | |||
275 | #define EXYNOS5420_TMU_DATA \ | 275 | #define EXYNOS5420_TMU_DATA \ |
276 | __EXYNOS5420_TMU_DATA \ | 276 | __EXYNOS5420_TMU_DATA \ |
277 | .type = SOC_ARCH_EXYNOS5420, \ | 277 | .type = SOC_ARCH_EXYNOS5420, \ |
278 | .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_EMUL_TIME) | 278 | .features = TMU_SUPPORT_EMULATION |
279 | 279 | ||
280 | #define EXYNOS5420_TMU_DATA_SHARED \ | 280 | #define EXYNOS5420_TMU_DATA_SHARED \ |
281 | __EXYNOS5420_TMU_DATA \ | 281 | __EXYNOS5420_TMU_DATA \ |
282 | .type = SOC_ARCH_EXYNOS5420_TRIMINFO, \ | 282 | .type = SOC_ARCH_EXYNOS5420_TRIMINFO, \ |
283 | .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_EMUL_TIME | \ | 283 | .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_ADDRESS_MULTIPLE) |
284 | TMU_SUPPORT_ADDRESS_MULTIPLE) | ||
285 | 284 | ||
286 | struct exynos_tmu_init_data const exynos5420_default_tmu_data = { | 285 | struct exynos_tmu_init_data const exynos5420_default_tmu_data = { |
287 | .tmu_data = { | 286 | .tmu_data = { |