diff options
author | Fabian Frederick <fabf@skynet.be> | 2014-07-15 15:26:35 -0400 |
---|---|---|
committer | Artem Bityutskiy <artem.bityutskiy@linux.intel.com> | 2014-07-19 02:53:52 -0400 |
commit | d4eb08ff0a8e1de010252e6646e2fc907a7e9b4e (patch) | |
tree | 60522ed81c8be28c6a9ad4589fe9229abc9baa7a | |
parent | 86b4c14de34d19ec3fc4662761feed9918491658 (diff) |
UBIFS: replace seq_printf by seq_puts
Fix checkpatch warnings:
"WARNING: Prefer seq_puts to seq_printf"
Andrew Morton wrote:
"
- puts is presumably faster
- puts doesn't go rogue if you accidentally pass it a "%".
- this patch actually made fs/ubifs/super.o 12 bytes smaller.
Perhaps because seq_printf() is a varargs function, forcing the
caller to pass args on the stack instead of in registers.
"
Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
-rw-r--r-- | fs/ubifs/super.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index 177dd629d88f..bed5ebfb7c71 100644 --- a/fs/ubifs/super.c +++ b/fs/ubifs/super.c | |||
@@ -424,19 +424,19 @@ static int ubifs_show_options(struct seq_file *s, struct dentry *root) | |||
424 | struct ubifs_info *c = root->d_sb->s_fs_info; | 424 | struct ubifs_info *c = root->d_sb->s_fs_info; |
425 | 425 | ||
426 | if (c->mount_opts.unmount_mode == 2) | 426 | if (c->mount_opts.unmount_mode == 2) |
427 | seq_printf(s, ",fast_unmount"); | 427 | seq_puts(s, ",fast_unmount"); |
428 | else if (c->mount_opts.unmount_mode == 1) | 428 | else if (c->mount_opts.unmount_mode == 1) |
429 | seq_printf(s, ",norm_unmount"); | 429 | seq_puts(s, ",norm_unmount"); |
430 | 430 | ||
431 | if (c->mount_opts.bulk_read == 2) | 431 | if (c->mount_opts.bulk_read == 2) |
432 | seq_printf(s, ",bulk_read"); | 432 | seq_puts(s, ",bulk_read"); |
433 | else if (c->mount_opts.bulk_read == 1) | 433 | else if (c->mount_opts.bulk_read == 1) |
434 | seq_printf(s, ",no_bulk_read"); | 434 | seq_puts(s, ",no_bulk_read"); |
435 | 435 | ||
436 | if (c->mount_opts.chk_data_crc == 2) | 436 | if (c->mount_opts.chk_data_crc == 2) |
437 | seq_printf(s, ",chk_data_crc"); | 437 | seq_puts(s, ",chk_data_crc"); |
438 | else if (c->mount_opts.chk_data_crc == 1) | 438 | else if (c->mount_opts.chk_data_crc == 1) |
439 | seq_printf(s, ",no_chk_data_crc"); | 439 | seq_puts(s, ",no_chk_data_crc"); |
440 | 440 | ||
441 | if (c->mount_opts.override_compr) { | 441 | if (c->mount_opts.override_compr) { |
442 | seq_printf(s, ",compr=%s", | 442 | seq_printf(s, ",compr=%s", |