diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2012-08-12 15:20:10 -0400 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2012-08-17 04:10:02 -0400 |
commit | d2434ab7fb085ac6848acd9d82366f96a642e471 (patch) | |
tree | d6a4a733dd1872093f01c4cfceca14ca7162bd3e | |
parent | 24218aacac65f5b731bbff8eeb09ea7847dda2ef (diff) |
drm/i915: drop intel_encoder argument to load_detect_pipe functions
Since it's redundant - we can get the attached encoder in the
functions themselves.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-rw-r--r-- | drivers/gpu/drm/i915/intel_crt.c | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_display.c | 10 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_drv.h | 6 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/intel_tv.c | 7 |
4 files changed, 12 insertions, 17 deletions
diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/intel_crt.c index bc5e2c97db61..62b6555cfa27 100644 --- a/drivers/gpu/drm/i915/intel_crt.c +++ b/drivers/gpu/drm/i915/intel_crt.c | |||
@@ -517,14 +517,12 @@ intel_crt_detect(struct drm_connector *connector, bool force) | |||
517 | return connector->status; | 517 | return connector->status; |
518 | 518 | ||
519 | /* for pre-945g platforms use load detect */ | 519 | /* for pre-945g platforms use load detect */ |
520 | if (intel_get_load_detect_pipe(&crt->base, connector, NULL, | 520 | if (intel_get_load_detect_pipe(connector, NULL, &tmp)) { |
521 | &tmp)) { | ||
522 | if (intel_crt_detect_ddc(connector)) | 521 | if (intel_crt_detect_ddc(connector)) |
523 | status = connector_status_connected; | 522 | status = connector_status_connected; |
524 | else | 523 | else |
525 | status = intel_crt_load_detect(crt); | 524 | status = intel_crt_load_detect(crt); |
526 | intel_release_load_detect_pipe(&crt->base, connector, | 525 | intel_release_load_detect_pipe(connector, &tmp); |
527 | &tmp); | ||
528 | } else | 526 | } else |
529 | status = connector_status_unknown; | 527 | status = connector_status_unknown; |
530 | 528 | ||
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index f851474fe066..62524b036bd1 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c | |||
@@ -5584,12 +5584,13 @@ mode_fits_in_fbdev(struct drm_device *dev, | |||
5584 | return fb; | 5584 | return fb; |
5585 | } | 5585 | } |
5586 | 5586 | ||
5587 | bool intel_get_load_detect_pipe(struct intel_encoder *intel_encoder, | 5587 | bool intel_get_load_detect_pipe(struct drm_connector *connector, |
5588 | struct drm_connector *connector, | ||
5589 | struct drm_display_mode *mode, | 5588 | struct drm_display_mode *mode, |
5590 | struct intel_load_detect_pipe *old) | 5589 | struct intel_load_detect_pipe *old) |
5591 | { | 5590 | { |
5592 | struct intel_crtc *intel_crtc; | 5591 | struct intel_crtc *intel_crtc; |
5592 | struct intel_encoder *intel_encoder = | ||
5593 | intel_attached_encoder(connector); | ||
5593 | struct drm_crtc *possible_crtc; | 5594 | struct drm_crtc *possible_crtc; |
5594 | struct drm_encoder *encoder = &intel_encoder->base; | 5595 | struct drm_encoder *encoder = &intel_encoder->base; |
5595 | struct drm_crtc *crtc = NULL; | 5596 | struct drm_crtc *crtc = NULL; |
@@ -5694,10 +5695,11 @@ fail: | |||
5694 | return false; | 5695 | return false; |
5695 | } | 5696 | } |
5696 | 5697 | ||
5697 | void intel_release_load_detect_pipe(struct intel_encoder *intel_encoder, | 5698 | void intel_release_load_detect_pipe(struct drm_connector *connector, |
5698 | struct drm_connector *connector, | ||
5699 | struct intel_load_detect_pipe *old) | 5699 | struct intel_load_detect_pipe *old) |
5700 | { | 5700 | { |
5701 | struct intel_encoder *intel_encoder = | ||
5702 | intel_attached_encoder(connector); | ||
5701 | struct drm_encoder *encoder = &intel_encoder->base; | 5703 | struct drm_encoder *encoder = &intel_encoder->base; |
5702 | struct drm_device *dev = encoder->dev; | 5704 | struct drm_device *dev = encoder->dev; |
5703 | 5705 | ||
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index 6920bc26a2e9..95f635b70b5b 100644 --- a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h | |||
@@ -433,12 +433,10 @@ struct intel_load_detect_pipe { | |||
433 | bool load_detect_temp; | 433 | bool load_detect_temp; |
434 | int dpms_mode; | 434 | int dpms_mode; |
435 | }; | 435 | }; |
436 | extern bool intel_get_load_detect_pipe(struct intel_encoder *intel_encoder, | 436 | extern bool intel_get_load_detect_pipe(struct drm_connector *connector, |
437 | struct drm_connector *connector, | ||
438 | struct drm_display_mode *mode, | 437 | struct drm_display_mode *mode, |
439 | struct intel_load_detect_pipe *old); | 438 | struct intel_load_detect_pipe *old); |
440 | extern void intel_release_load_detect_pipe(struct intel_encoder *intel_encoder, | 439 | extern void intel_release_load_detect_pipe(struct drm_connector *connector, |
441 | struct drm_connector *connector, | ||
442 | struct intel_load_detect_pipe *old); | 440 | struct intel_load_detect_pipe *old); |
443 | 441 | ||
444 | extern void intelfb_restore(void); | 442 | extern void intelfb_restore(void); |
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c index 1a0bab07699e..95653a508987 100644 --- a/drivers/gpu/drm/i915/intel_tv.c +++ b/drivers/gpu/drm/i915/intel_tv.c | |||
@@ -1303,12 +1303,9 @@ intel_tv_detect(struct drm_connector *connector, bool force) | |||
1303 | if (force) { | 1303 | if (force) { |
1304 | struct intel_load_detect_pipe tmp; | 1304 | struct intel_load_detect_pipe tmp; |
1305 | 1305 | ||
1306 | if (intel_get_load_detect_pipe(&intel_tv->base, connector, | 1306 | if (intel_get_load_detect_pipe(connector, &mode, &tmp)) { |
1307 | &mode, &tmp)) { | ||
1308 | type = intel_tv_detect_type(intel_tv, connector); | 1307 | type = intel_tv_detect_type(intel_tv, connector); |
1309 | intel_release_load_detect_pipe(&intel_tv->base, | 1308 | intel_release_load_detect_pipe(connector, &tmp); |
1310 | connector, | ||
1311 | &tmp); | ||
1312 | } else | 1309 | } else |
1313 | return connector_status_unknown; | 1310 | return connector_status_unknown; |
1314 | } else | 1311 | } else |