aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAlex Elder <elder@inktank.com>2012-06-26 15:57:03 -0400
committerSage Weil <sage@inktank.com>2012-07-30 12:30:09 -0400
commitd1f57ea66369b5c34bd42f104b8070db409447f9 (patch)
tree747842f157676e5ee548a6b073ce26f5a913214f
parent43ae47011232c1e792d77e78db4a7d0ab05032be (diff)
rbd: kill num_reply parameters
Several functions include a num_reply parameter, but it is never used. Just get rid of it everywhere--it seems to be something that never got fully implemented. Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
-rw-r--r--drivers/block/rbd.c19
1 files changed, 6 insertions, 13 deletions
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index cf6f49101794..b124442dab3a 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -864,7 +864,6 @@ static int rbd_do_request(struct request *rq,
864 int num_pages, 864 int num_pages,
865 int flags, 865 int flags,
866 struct ceph_osd_req_op *ops, 866 struct ceph_osd_req_op *ops,
867 int num_reply,
868 struct rbd_req_coll *coll, 867 struct rbd_req_coll *coll,
869 int coll_index, 868 int coll_index,
870 void (*rbd_cb)(struct ceph_osd_request *req, 869 void (*rbd_cb)(struct ceph_osd_request *req,
@@ -1020,7 +1019,6 @@ static int rbd_req_sync_op(struct rbd_device *rbd_dev,
1020 int opcode, 1019 int opcode,
1021 int flags, 1020 int flags,
1022 struct ceph_osd_req_op *orig_ops, 1021 struct ceph_osd_req_op *orig_ops,
1023 int num_reply,
1024 const char *object_name, 1022 const char *object_name,
1025 u64 ofs, u64 len, 1023 u64 ofs, u64 len,
1026 char *buf, 1024 char *buf,
@@ -1056,7 +1054,6 @@ static int rbd_req_sync_op(struct rbd_device *rbd_dev,
1056 pages, num_pages, 1054 pages, num_pages,
1057 flags, 1055 flags,
1058 ops, 1056 ops,
1059 2,
1060 NULL, 0, 1057 NULL, 0,
1061 NULL, 1058 NULL,
1062 linger_req, ver); 1059 linger_req, ver);
@@ -1081,7 +1078,7 @@ static int rbd_do_op(struct request *rq,
1081 struct rbd_device *rbd_dev, 1078 struct rbd_device *rbd_dev,
1082 struct ceph_snap_context *snapc, 1079 struct ceph_snap_context *snapc,
1083 u64 snapid, 1080 u64 snapid,
1084 int opcode, int flags, int num_reply, 1081 int opcode, int flags,
1085 u64 ofs, u64 len, 1082 u64 ofs, u64 len,
1086 struct bio *bio, 1083 struct bio *bio,
1087 struct rbd_req_coll *coll, 1084 struct rbd_req_coll *coll,
@@ -1120,7 +1117,6 @@ static int rbd_do_op(struct request *rq,
1120 NULL, 0, 1117 NULL, 0,
1121 flags, 1118 flags,
1122 ops, 1119 ops,
1123 num_reply,
1124 coll, coll_index, 1120 coll, coll_index,
1125 rbd_req_cb, 0, NULL); 1121 rbd_req_cb, 0, NULL);
1126 1122
@@ -1144,7 +1140,6 @@ static int rbd_req_write(struct request *rq,
1144 return rbd_do_op(rq, rbd_dev, snapc, CEPH_NOSNAP, 1140 return rbd_do_op(rq, rbd_dev, snapc, CEPH_NOSNAP,
1145 CEPH_OSD_OP_WRITE, 1141 CEPH_OSD_OP_WRITE,
1146 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK, 1142 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK,
1147 2,
1148 ofs, len, bio, coll, coll_index); 1143 ofs, len, bio, coll, coll_index);
1149} 1144}
1150 1145
@@ -1163,7 +1158,6 @@ static int rbd_req_read(struct request *rq,
1163 snapid, 1158 snapid,
1164 CEPH_OSD_OP_READ, 1159 CEPH_OSD_OP_READ,
1165 CEPH_OSD_FLAG_READ, 1160 CEPH_OSD_FLAG_READ,
1166 2,
1167 ofs, len, bio, coll, coll_index); 1161 ofs, len, bio, coll, coll_index);
1168} 1162}
1169 1163
@@ -1183,7 +1177,7 @@ static int rbd_req_sync_read(struct rbd_device *rbd_dev,
1183 CEPH_OSD_OP_READ, 1177 CEPH_OSD_OP_READ,
1184 CEPH_OSD_FLAG_READ, 1178 CEPH_OSD_FLAG_READ,
1185 NULL, 1179 NULL,
1186 1, object_name, ofs, len, buf, NULL, ver); 1180 object_name, ofs, len, buf, NULL, ver);
1187} 1181}
1188 1182
1189/* 1183/*
@@ -1210,7 +1204,6 @@ static int rbd_req_sync_notify_ack(struct rbd_device *rbd_dev,
1210 NULL, 0, 1204 NULL, 0,
1211 CEPH_OSD_FLAG_READ, 1205 CEPH_OSD_FLAG_READ,
1212 ops, 1206 ops,
1213 1,
1214 NULL, 0, 1207 NULL, 0,
1215 rbd_simple_req_cb, 0, NULL); 1208 rbd_simple_req_cb, 0, NULL);
1216 1209
@@ -1266,7 +1259,7 @@ static int rbd_req_sync_watch(struct rbd_device *rbd_dev,
1266 0, 1259 0,
1267 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK, 1260 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK,
1268 ops, 1261 ops,
1269 1, object_name, 0, 0, NULL, 1262 object_name, 0, 0, NULL,
1270 &rbd_dev->watch_request, NULL); 1263 &rbd_dev->watch_request, NULL);
1271 1264
1272 if (ret < 0) 1265 if (ret < 0)
@@ -1304,7 +1297,7 @@ static int rbd_req_sync_unwatch(struct rbd_device *rbd_dev,
1304 0, 1297 0,
1305 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK, 1298 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK,
1306 ops, 1299 ops,
1307 1, object_name, 0, 0, NULL, NULL, NULL); 1300 object_name, 0, 0, NULL, NULL, NULL);
1308 1301
1309 rbd_destroy_ops(ops); 1302 rbd_destroy_ops(ops);
1310 ceph_osdc_cancel_event(rbd_dev->watch_event); 1303 ceph_osdc_cancel_event(rbd_dev->watch_event);
@@ -1362,7 +1355,7 @@ static int rbd_req_sync_notify(struct rbd_device *rbd_dev,
1362 0, 1355 0,
1363 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK, 1356 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK,
1364 ops, 1357 ops,
1365 1, object_name, 0, 0, NULL, NULL, NULL); 1358 object_name, 0, 0, NULL, NULL, NULL);
1366 if (ret < 0) 1359 if (ret < 0)
1367 goto fail_event; 1360 goto fail_event;
1368 1361
@@ -1410,7 +1403,7 @@ static int rbd_req_sync_exec(struct rbd_device *rbd_dev,
1410 0, 1403 0,
1411 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK, 1404 CEPH_OSD_FLAG_WRITE | CEPH_OSD_FLAG_ONDISK,
1412 ops, 1405 ops,
1413 1, object_name, 0, 0, NULL, NULL, ver); 1406 object_name, 0, 0, NULL, NULL, ver);
1414 1407
1415 rbd_destroy_ops(ops); 1408 rbd_destroy_ops(ops);
1416 1409