diff options
author | Julia Lawall <julia@diku.dk> | 2010-10-29 15:14:23 -0400 |
---|---|---|
committer | Chris Mason <chris.mason@oracle.com> | 2010-10-29 15:14:23 -0400 |
commit | d0b678cb0a26783ab7238784f1e7e608e5caafa3 (patch) | |
tree | a912b938a6558550960f6b07139bd119d86f89eb | |
parent | 2354d08fe9aeec3e451b85cb5387a6b28dbca0b1 (diff) |
Btrfs: Use ERR_CAST helpers
Use ERR_CAST(x) rather than ERR_PTR(PTR_ERR(x)). The former makes more
clear what is the purpose of the operation, which otherwise looks like a
no-op.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
type T;
T x;
identifier f;
@@
T f (...) { <+...
- ERR_PTR(PTR_ERR(x))
+ x
...+> }
@@
expression x;
@@
- ERR_PTR(PTR_ERR(x))
+ ERR_CAST(x)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Chris Mason <chris.mason@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Chris Mason <chris.mason@oracle.com>
-rw-r--r-- | fs/btrfs/extent_map.c | 4 | ||||
-rw-r--r-- | fs/btrfs/super.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c index 454ca52d6451..23cb8da3ff66 100644 --- a/fs/btrfs/extent_map.c +++ b/fs/btrfs/extent_map.c | |||
@@ -335,7 +335,7 @@ struct extent_map *lookup_extent_mapping(struct extent_map_tree *tree, | |||
335 | goto out; | 335 | goto out; |
336 | } | 336 | } |
337 | if (IS_ERR(rb_node)) { | 337 | if (IS_ERR(rb_node)) { |
338 | em = ERR_PTR(PTR_ERR(rb_node)); | 338 | em = ERR_CAST(rb_node); |
339 | goto out; | 339 | goto out; |
340 | } | 340 | } |
341 | em = rb_entry(rb_node, struct extent_map, rb_node); | 341 | em = rb_entry(rb_node, struct extent_map, rb_node); |
@@ -384,7 +384,7 @@ struct extent_map *search_extent_mapping(struct extent_map_tree *tree, | |||
384 | goto out; | 384 | goto out; |
385 | } | 385 | } |
386 | if (IS_ERR(rb_node)) { | 386 | if (IS_ERR(rb_node)) { |
387 | em = ERR_PTR(PTR_ERR(rb_node)); | 387 | em = ERR_CAST(rb_node); |
388 | goto out; | 388 | goto out; |
389 | } | 389 | } |
390 | em = rb_entry(rb_node, struct extent_map, rb_node); | 390 | em = rb_entry(rb_node, struct extent_map, rb_node); |
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 65b62daa3f80..d7fb2733d028 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c | |||
@@ -389,7 +389,7 @@ static struct dentry *get_default_root(struct super_block *sb, | |||
389 | find_root: | 389 | find_root: |
390 | new_root = btrfs_read_fs_root_no_name(root->fs_info, &location); | 390 | new_root = btrfs_read_fs_root_no_name(root->fs_info, &location); |
391 | if (IS_ERR(new_root)) | 391 | if (IS_ERR(new_root)) |
392 | return ERR_PTR(PTR_ERR(new_root)); | 392 | return ERR_CAST(new_root); |
393 | 393 | ||
394 | if (btrfs_root_refs(&new_root->root_item) == 0) | 394 | if (btrfs_root_refs(&new_root->root_item) == 0) |
395 | return ERR_PTR(-ENOENT); | 395 | return ERR_PTR(-ENOENT); |