diff options
author | Nicholas Bellinger <nab@linux-iscsi.org> | 2015-02-13 20:56:19 -0500 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2015-02-13 21:54:40 -0500 |
commit | d0a91295557666f9e58b79b5177a98229007803b (patch) | |
tree | 2a4dcb4c633d2d8b7ccd962abbc74f0193e69f61 | |
parent | fde9f50f80fe89a9115b4bfa773017272597d85d (diff) |
target: Fail WRITE_SAME w/ UNMAP=1 when emulate_tpws=0
This patch adds a check within sbc_setup_write_same() to fail a
WRITE_SAME w/ UNMAP=1 op, if the backend device has emulate_tpws
disabled.
Cc: Martin Petersen <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
-rw-r--r-- | drivers/target/target_core_sbc.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c index 856e800926b8..0d307c34f08e 100644 --- a/drivers/target/target_core_sbc.c +++ b/drivers/target/target_core_sbc.c | |||
@@ -293,6 +293,11 @@ sbc_setup_write_same(struct se_cmd *cmd, unsigned char *flags, struct sbc_ops *o | |||
293 | if (!ops->execute_write_same_unmap) | 293 | if (!ops->execute_write_same_unmap) |
294 | return TCM_UNSUPPORTED_SCSI_OPCODE; | 294 | return TCM_UNSUPPORTED_SCSI_OPCODE; |
295 | 295 | ||
296 | if (!dev->dev_attrib.emulate_tpws) { | ||
297 | pr_err("Got WRITE_SAME w/ UNMAP=1, but backend device" | ||
298 | " has emulate_tpws disabled\n"); | ||
299 | return TCM_UNSUPPORTED_SCSI_OPCODE; | ||
300 | } | ||
296 | cmd->execute_cmd = ops->execute_write_same_unmap; | 301 | cmd->execute_cmd = ops->execute_write_same_unmap; |
297 | return 0; | 302 | return 0; |
298 | } | 303 | } |