gigaset: correct clearing of at_state strings on RING

commit 3a0a3a6b92edf181f849ebd8417122392ba73a96 upstream.

In RING handling, clear the table of received parameter strings in
a loop like everywhere else, instead of by enumeration which had
already gotten out of sync.

Impact: minor bugfix
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Acked-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

1 files changed, 4 insertions, 8 deletions

diff --git a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c
index ddeb0456d202..0304d026be3e 100644
--- a/drivers/isdn/gigaset/ev-layer.c
+++ b/drivers/isdn/gigaset/ev-layer.c
@@ -1259,14 +1259,10 @@ static void do_action(int action, struct cardstate *cs,
                  * note that bcs may be NULL if no B channel is free
                  */
                 at_state2->ConState = 700;
-                kfree(at_state2->str_var[STR_NMBR]);
-                at_state2->str_var[STR_NMBR] = NULL;
-                kfree(at_state2->str_var[STR_ZCPN]);
-                at_state2->str_var[STR_ZCPN] = NULL;
-                kfree(at_state2->str_var[STR_ZBC]);
-                at_state2->str_var[STR_ZBC] = NULL;
-                kfree(at_state2->str_var[STR_ZHLC]);
-                at_state2->str_var[STR_ZHLC] = NULL;
+                for (i = 0; i < STR_NUM; ++i) {
+                        kfree(at_state2->str_var[i]);
+                        at_state2->str_var[i] = NULL;
+                }
                 at_state2->int_var[VAR_ZCTP] = -1;
 
                 spin_lock_irqsave(&cs->lock, flags);