diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-28 14:34:03 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-05-29 14:22:47 -0400 |
commit | cf24df6061b02063af19aba130d0fc4546959520 (patch) | |
tree | e83938cca368c6ea936949efc70b698ac5043199 | |
parent | 834b4d5136a8171066537b3c73c79863a50155cb (diff) |
USB: media: lirc: igorplugusb: remove CONFIG_USB_DEBUG support
The config option is gone, so port the driver over to using the dynamic
debug infrastructure instead, like all other USB drivers.
Cc: Jarod Wilson <jarod@wilsonet.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Cc: Matina Maria Trompouki <mtrompou@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/media/lirc/lirc_igorplugusb.c | 30 |
1 files changed, 7 insertions, 23 deletions
diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c index f508a1372ad8..44b0d0766084 100644 --- a/drivers/staging/media/lirc/lirc_igorplugusb.c +++ b/drivers/staging/media/lirc/lirc_igorplugusb.c | |||
@@ -60,19 +60,6 @@ | |||
60 | #define DRIVER_DESC "Igorplug USB remote driver for LIRC" | 60 | #define DRIVER_DESC "Igorplug USB remote driver for LIRC" |
61 | #define DRIVER_NAME "lirc_igorplugusb" | 61 | #define DRIVER_NAME "lirc_igorplugusb" |
62 | 62 | ||
63 | /* debugging support */ | ||
64 | #ifdef CONFIG_USB_DEBUG | ||
65 | static bool debug = true; | ||
66 | #else | ||
67 | static bool debug; | ||
68 | #endif | ||
69 | |||
70 | #define dprintk(fmt, args...) \ | ||
71 | do { \ | ||
72 | if (debug) \ | ||
73 | printk(KERN_DEBUG fmt, ## args); \ | ||
74 | } while (0) | ||
75 | |||
76 | /* One mode2 pulse/space has 4 bytes. */ | 63 | /* One mode2 pulse/space has 4 bytes. */ |
77 | #define CODE_LENGTH sizeof(int) | 64 | #define CODE_LENGTH sizeof(int) |
78 | 65 | ||
@@ -237,7 +224,7 @@ static int unregister_from_lirc(struct igorplug *ir) | |||
237 | return -EINVAL; | 224 | return -EINVAL; |
238 | } | 225 | } |
239 | 226 | ||
240 | dprintk(DRIVER_NAME "[%d]: calling lirc_unregister_driver\n", devnum); | 227 | dev_dbg(&ir->usbdev->dev, "calling lirc_unregister_driver\n"); |
241 | lirc_unregister_driver(d->minor); | 228 | lirc_unregister_driver(d->minor); |
242 | 229 | ||
243 | return devnum; | 230 | return devnum; |
@@ -252,7 +239,7 @@ static int set_use_inc(void *data) | |||
252 | return -EIO; | 239 | return -EIO; |
253 | } | 240 | } |
254 | 241 | ||
255 | dprintk(DRIVER_NAME "[%d]: set use inc\n", ir->devnum); | 242 | dev_dbg(&ir->usbdev->dev, "set use inc\n"); |
256 | 243 | ||
257 | if (!ir->usbdev) | 244 | if (!ir->usbdev) |
258 | return -ENODEV; | 245 | return -ENODEV; |
@@ -269,7 +256,7 @@ static void set_use_dec(void *data) | |||
269 | return; | 256 | return; |
270 | } | 257 | } |
271 | 258 | ||
272 | dprintk(DRIVER_NAME "[%d]: set use dec\n", ir->devnum); | 259 | dev_dbg(&ir->usbdev->dev, "set use dec\n"); |
273 | } | 260 | } |
274 | 261 | ||
275 | static void send_fragment(struct igorplug *ir, struct lirc_buffer *buf, | 262 | static void send_fragment(struct igorplug *ir, struct lirc_buffer *buf, |
@@ -321,7 +308,7 @@ static int igorplugusb_remote_poll(void *data, struct lirc_buffer *buf) | |||
321 | if (ret < DEVICE_HEADERLEN) | 308 | if (ret < DEVICE_HEADERLEN) |
322 | return -ENODATA; | 309 | return -ENODATA; |
323 | 310 | ||
324 | dprintk(DRIVER_NAME ": Got %d bytes. Header: %*ph\n", | 311 | dev_dbg(&ir->usbdev->dev, "Got %d bytes. Header: %*ph\n", |
325 | ret, 3, ir->buf_in); | 312 | ret, 3, ir->buf_in); |
326 | 313 | ||
327 | do_gettimeofday(&now); | 314 | do_gettimeofday(&now); |
@@ -385,7 +372,7 @@ static int igorplugusb_remote_probe(struct usb_interface *intf, | |||
385 | char buf[63], name[128] = ""; | 372 | char buf[63], name[128] = ""; |
386 | int ret; | 373 | int ret; |
387 | 374 | ||
388 | dprintk(DRIVER_NAME ": usb probe called.\n"); | 375 | dev_dbg(&intf->dev, "%s: usb probe called.\n", __func__); |
389 | 376 | ||
390 | dev = interface_to_usbdev(intf); | 377 | dev = interface_to_usbdev(intf); |
391 | 378 | ||
@@ -405,8 +392,8 @@ static int igorplugusb_remote_probe(struct usb_interface *intf, | |||
405 | devnum = dev->devnum; | 392 | devnum = dev->devnum; |
406 | maxp = usb_maxpacket(dev, pipe, usb_pipeout(pipe)); | 393 | maxp = usb_maxpacket(dev, pipe, usb_pipeout(pipe)); |
407 | 394 | ||
408 | dprintk(DRIVER_NAME "[%d]: bytes_in_key=%zu maxp=%d\n", | 395 | dev_dbg(&intf->dev, "%s: bytes_in_key=%zu maxp=%d\n", |
409 | devnum, CODE_LENGTH, maxp); | 396 | __func__, CODE_LENGTH, maxp); |
410 | 397 | ||
411 | ir = devm_kzalloc(&intf->dev, sizeof(*ir), GFP_KERNEL); | 398 | ir = devm_kzalloc(&intf->dev, sizeof(*ir), GFP_KERNEL); |
412 | if (!ir) | 399 | if (!ir) |
@@ -525,6 +512,3 @@ MODULE_DEVICE_TABLE(usb, igorplugusb_remote_id_table); | |||
525 | 512 | ||
526 | module_param(sample_rate, int, S_IRUGO | S_IWUSR); | 513 | module_param(sample_rate, int, S_IRUGO | S_IWUSR); |
527 | MODULE_PARM_DESC(sample_rate, "Sampling rate in Hz (default: 100)"); | 514 | MODULE_PARM_DESC(sample_rate, "Sampling rate in Hz (default: 100)"); |
528 | |||
529 | module_param(debug, bool, S_IRUGO | S_IWUSR); | ||
530 | MODULE_PARM_DESC(debug, "Debug enabled or not"); | ||