diff options
author | Tomasz Figa <tomasz.figa@gmail.com> | 2013-06-16 20:10:24 -0400 |
---|---|---|
committer | Tomasz Figa <tomasz.figa@gmail.com> | 2013-08-05 19:21:41 -0400 |
commit | ceea124103c6f00561491b45133be5ccefc8ea1d (patch) | |
tree | 1e6dbd59c3f6e82d6337567de108c9a64dc8cb2d | |
parent | e24154896e2f60b0c20bda492d662ad77ffa5c32 (diff) |
clocksource: samsung_pwm_timer: Correct definition of AUTORELOAD bit
PWM channel 4 has its autoreload bit located at different position. This
patch fixes the driver to account for that.
This fixes a problem with the clocksource hanging after it overflows because
it is not reloaded any more.
Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Tested-by: Mark Brown <broonie@linaro.org>
Tested-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
-rw-r--r-- | drivers/clocksource/samsung_pwm_timer.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/clocksource/samsung_pwm_timer.c b/drivers/clocksource/samsung_pwm_timer.c index 3fa5b07fa50d..5d0049f07af4 100644 --- a/drivers/clocksource/samsung_pwm_timer.c +++ b/drivers/clocksource/samsung_pwm_timer.c | |||
@@ -44,10 +44,21 @@ | |||
44 | #define TCFG1_SHIFT(x) ((x) * 4) | 44 | #define TCFG1_SHIFT(x) ((x) * 4) |
45 | #define TCFG1_MUX_MASK 0xf | 45 | #define TCFG1_MUX_MASK 0xf |
46 | 46 | ||
47 | /* | ||
48 | * Each channel occupies 4 bits in TCON register, but there is a gap of 4 | ||
49 | * bits (one channel) after channel 0, so channels have different numbering | ||
50 | * when accessing TCON register. | ||
51 | * | ||
52 | * In addition, the location of autoreload bit for channel 4 (TCON channel 5) | ||
53 | * in its set of bits is 2 as opposed to 3 for other channels. | ||
54 | */ | ||
47 | #define TCON_START(chan) (1 << (4 * (chan) + 0)) | 55 | #define TCON_START(chan) (1 << (4 * (chan) + 0)) |
48 | #define TCON_MANUALUPDATE(chan) (1 << (4 * (chan) + 1)) | 56 | #define TCON_MANUALUPDATE(chan) (1 << (4 * (chan) + 1)) |
49 | #define TCON_INVERT(chan) (1 << (4 * (chan) + 2)) | 57 | #define TCON_INVERT(chan) (1 << (4 * (chan) + 2)) |
50 | #define TCON_AUTORELOAD(chan) (1 << (4 * (chan) + 3)) | 58 | #define _TCON_AUTORELOAD(chan) (1 << (4 * (chan) + 3)) |
59 | #define _TCON_AUTORELOAD4(chan) (1 << (4 * (chan) + 2)) | ||
60 | #define TCON_AUTORELOAD(chan) \ | ||
61 | ((chan < 5) ? _TCON_AUTORELOAD(chan) : _TCON_AUTORELOAD4(chan)) | ||
51 | 62 | ||
52 | DEFINE_SPINLOCK(samsung_pwm_lock); | 63 | DEFINE_SPINLOCK(samsung_pwm_lock); |
53 | EXPORT_SYMBOL(samsung_pwm_lock); | 64 | EXPORT_SYMBOL(samsung_pwm_lock); |