diff options
| author | Kulikov Vasiliy <segooon@gmail.com> | 2010-10-29 19:04:33 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-10-30 19:49:38 -0400 |
| commit | ce384d91cd7a4269a1ed5d4307a70aa4c6fa14f2 (patch) | |
| tree | dad07ece7f32cfa73cfe3bf4e31f04c9a4b9a5ef | |
| parent | 3e9ebd3cf48d9181e0931c6fd8f1a7dc4d6cb27c (diff) | |
isdn: mISDN: socket: fix information leak to userland
Structure mISDN_devinfo is copied to userland with the field "name"
that has the last elements unitialized. It leads to leaking of
contents of kernel stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/isdn/mISDN/socket.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/isdn/mISDN/socket.c b/drivers/isdn/mISDN/socket.c index 3232206406b1..7446d8b4282d 100644 --- a/drivers/isdn/mISDN/socket.c +++ b/drivers/isdn/mISDN/socket.c | |||
| @@ -392,6 +392,7 @@ data_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) | |||
| 392 | if (dev) { | 392 | if (dev) { |
| 393 | struct mISDN_devinfo di; | 393 | struct mISDN_devinfo di; |
| 394 | 394 | ||
| 395 | memset(&di, 0, sizeof(di)); | ||
| 395 | di.id = dev->id; | 396 | di.id = dev->id; |
| 396 | di.Dprotocols = dev->Dprotocols; | 397 | di.Dprotocols = dev->Dprotocols; |
| 397 | di.Bprotocols = dev->Bprotocols | get_all_Bprotocols(); | 398 | di.Bprotocols = dev->Bprotocols | get_all_Bprotocols(); |
| @@ -672,6 +673,7 @@ base_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) | |||
| 672 | if (dev) { | 673 | if (dev) { |
| 673 | struct mISDN_devinfo di; | 674 | struct mISDN_devinfo di; |
| 674 | 675 | ||
| 676 | memset(&di, 0, sizeof(di)); | ||
| 675 | di.id = dev->id; | 677 | di.id = dev->id; |
| 676 | di.Dprotocols = dev->Dprotocols; | 678 | di.Dprotocols = dev->Dprotocols; |
| 677 | di.Bprotocols = dev->Bprotocols | get_all_Bprotocols(); | 679 | di.Bprotocols = dev->Bprotocols | get_all_Bprotocols(); |
