diff options
| author | Jeffrey (Sheng-Hui) Chu <jeffchu@broadcom.com> | 2011-11-23 05:33:07 -0500 |
|---|---|---|
| committer | Jean Delvare <khali@endymion.delvare> | 2011-11-23 05:33:07 -0500 |
| commit | cc6bcf7d2ec2234e7b41770185e4dc826390185e (patch) | |
| tree | 930acbf0183df80cc6457d1febe10dae0886f92f | |
| parent | b4bbb02934e4511d9083f15c23e90703482e84ad (diff) | |
i2c-algo-bit: Generate correct i2c address sequence for 10-bit target
The wrong bits were put on the wire, fix that.
This fixes kernel bug #42562.
Signed-off-by: Sheng-Hui J. Chu <jeffchu@broadcom.com>
Cc: stable@kernel.org
Signed-off-by: Jean Delvare <khali@linux-fr.org>
| -rw-r--r-- | drivers/i2c/algos/i2c-algo-bit.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c index 85584a547c25..525c7345fa0b 100644 --- a/drivers/i2c/algos/i2c-algo-bit.c +++ b/drivers/i2c/algos/i2c-algo-bit.c | |||
| @@ -488,7 +488,7 @@ static int bit_doAddress(struct i2c_adapter *i2c_adap, struct i2c_msg *msg) | |||
| 488 | 488 | ||
| 489 | if (flags & I2C_M_TEN) { | 489 | if (flags & I2C_M_TEN) { |
| 490 | /* a ten bit address */ | 490 | /* a ten bit address */ |
| 491 | addr = 0xf0 | ((msg->addr >> 7) & 0x03); | 491 | addr = 0xf0 | ((msg->addr >> 7) & 0x06); |
| 492 | bit_dbg(2, &i2c_adap->dev, "addr0: %d\n", addr); | 492 | bit_dbg(2, &i2c_adap->dev, "addr0: %d\n", addr); |
| 493 | /* try extended address code...*/ | 493 | /* try extended address code...*/ |
| 494 | ret = try_address(i2c_adap, addr, retries); | 494 | ret = try_address(i2c_adap, addr, retries); |
| @@ -498,7 +498,7 @@ static int bit_doAddress(struct i2c_adapter *i2c_adap, struct i2c_msg *msg) | |||
| 498 | return -ENXIO; | 498 | return -ENXIO; |
| 499 | } | 499 | } |
| 500 | /* the remaining 8 bit address */ | 500 | /* the remaining 8 bit address */ |
| 501 | ret = i2c_outb(i2c_adap, msg->addr & 0x7f); | 501 | ret = i2c_outb(i2c_adap, msg->addr & 0xff); |
| 502 | if ((ret != 1) && !nak_ok) { | 502 | if ((ret != 1) && !nak_ok) { |
| 503 | /* the chip did not ack / xmission error occurred */ | 503 | /* the chip did not ack / xmission error occurred */ |
| 504 | dev_err(&i2c_adap->dev, "died at 2nd address code\n"); | 504 | dev_err(&i2c_adap->dev, "died at 2nd address code\n"); |
