diff options
| author | Steven Hardy <shardy@redhat.com> | 2011-04-04 13:02:25 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-13 18:53:16 -0400 |
| commit | cb62d65f966146a39fdde548cb474dacf1d00fa5 (patch) | |
| tree | 52ad1605b719a2891ba3ed49066cc6e11c589142 | |
| parent | 99ab3f9e4eaec35fd2d7159c31b71f17f7e613e3 (diff) | |
usb: qcserial add missing errorpath kfrees
There are two -ENODEV error paths in qcprobe where the allocated private
data is not freed, this patch adds the two missing kfrees to avoid
leaking memory on the error path
Signed-off-by: Steven Hardy <shardy@redhat.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | drivers/usb/serial/qcserial.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index cd638648479a..54a9dab1f33b 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c | |||
| @@ -167,6 +167,7 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id) | |||
| 167 | "Could not set interface, error %d\n", | 167 | "Could not set interface, error %d\n", |
| 168 | retval); | 168 | retval); |
| 169 | retval = -ENODEV; | 169 | retval = -ENODEV; |
| 170 | kfree(data); | ||
| 170 | } | 171 | } |
| 171 | } else if (ifnum == 2) { | 172 | } else if (ifnum == 2) { |
| 172 | dbg("Modem port found"); | 173 | dbg("Modem port found"); |
| @@ -191,6 +192,7 @@ static int qcprobe(struct usb_serial *serial, const struct usb_device_id *id) | |||
| 191 | "Could not set interface, error %d\n", | 192 | "Could not set interface, error %d\n", |
| 192 | retval); | 193 | retval); |
| 193 | retval = -ENODEV; | 194 | retval = -ENODEV; |
| 195 | kfree(data); | ||
| 194 | } | 196 | } |
| 195 | } | 197 | } |
| 196 | break; | 198 | break; |
