diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-14 18:31:03 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-04-14 18:31:03 -0400 |
| commit | ca2ec32658db160745990496f0f4580056a5dc9f (patch) | |
| tree | d211f239219c85214da46dc1cbad4184a81d0248 | |
| parent | 6c8a53c9e6a151fffb07f8b4c34bd1e33dddd467 (diff) | |
| parent | fdc81f45e9f57858da6351836507fbcf1b7583ee (diff) | |
Merge branch 'for-linus-1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
Pull vfs update from Al Viro:
"Part one:
- struct filename-related cleanups
- saner iov_iter_init() replacements (and switching the syscalls to
use of those)
- ntfs switch to ->write_iter() (Anton)
- aio cleanups and splitting iocb into common and async parts
(Christoph)
- assorted fixes (me, bfields, Andrew Elble)
There's a lot more, including the completion of switchover to
->{read,write}_iter(), d_inode/d_backing_inode annotations, f_flags
race fixes, etc, but that goes after #for-davem merge. David has
pulled it, and once it's in I'll send the next vfs pull request"
* 'for-linus-1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: (35 commits)
sg_start_req(): use import_iovec()
sg_start_req(): make sure that there's not too many elements in iovec
blk_rq_map_user(): use import_single_range()
sg_io(): use import_iovec()
process_vm_access: switch to {compat_,}import_iovec()
switch keyctl_instantiate_key_common() to iov_iter
switch {compat_,}do_readv_writev() to {compat_,}import_iovec()
aio_setup_vectored_rw(): switch to {compat_,}import_iovec()
vmsplice_to_user(): switch to import_iovec()
kill aio_setup_single_vector()
aio: simplify arguments of aio_setup_..._rw()
aio: lift iov_iter_init() into aio_setup_..._rw()
lift iov_iter into {compat_,}do_readv_writev()
NFS: fix BUG() crash in notify_change() with patch to chown_common()
dcache: return -ESTALE not -EBUSY on distributed fs race
NTFS: Version 2.1.32 - Update file write from aio_write to write_iter.
VFS: Add iov_iter_fault_in_multipages_readable()
drop bogus check in file_open_root()
switch security_inode_getattr() to struct path *
constify tomoyo_realpath_from_path()
...
103 files changed, 839 insertions, 1118 deletions
diff --git a/arch/arc/kernel/process.c b/arch/arc/kernel/process.c index 98c00a2d4dd9..f46efd14059d 100644 --- a/arch/arc/kernel/process.c +++ b/arch/arc/kernel/process.c | |||
| @@ -155,8 +155,6 @@ int copy_thread(unsigned long clone_flags, | |||
| 155 | */ | 155 | */ |
| 156 | void start_thread(struct pt_regs * regs, unsigned long pc, unsigned long usp) | 156 | void start_thread(struct pt_regs * regs, unsigned long pc, unsigned long usp) |
| 157 | { | 157 | { |
| 158 | set_fs(USER_DS); /* user space */ | ||
| 159 | |||
| 160 | regs->sp = usp; | 158 | regs->sp = usp; |
| 161 | regs->ret = pc; | 159 | regs->ret = pc; |
| 162 | 160 | ||
diff --git a/arch/c6x/kernel/process.c b/arch/c6x/kernel/process.c index 57d2ea8d1977..3ae9f5a166a0 100644 --- a/arch/c6x/kernel/process.c +++ b/arch/c6x/kernel/process.c | |||
| @@ -101,7 +101,6 @@ void start_thread(struct pt_regs *regs, unsigned int pc, unsigned long usp) | |||
| 101 | */ | 101 | */ |
| 102 | usp -= 8; | 102 | usp -= 8; |
| 103 | 103 | ||
| 104 | set_fs(USER_DS); | ||
| 105 | regs->pc = pc; | 104 | regs->pc = pc; |
| 106 | regs->sp = usp; | 105 | regs->sp = usp; |
| 107 | regs->tsr |= 0x40; /* set user mode */ | 106 | regs->tsr |= 0x40; /* set user mode */ |
diff --git a/arch/frv/kernel/signal.c b/arch/frv/kernel/signal.c index 336713ab4745..85ca6727ca07 100644 --- a/arch/frv/kernel/signal.c +++ b/arch/frv/kernel/signal.c | |||
| @@ -176,8 +176,6 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set) | |||
| 176 | struct sigframe __user *frame; | 176 | struct sigframe __user *frame; |
| 177 | int rsig, sig = ksig->sig; | 177 | int rsig, sig = ksig->sig; |
| 178 | 178 | ||
| 179 | set_fs(USER_DS); | ||
| 180 | |||
| 181 | frame = get_sigframe(ksig, sizeof(*frame)); | 179 | frame = get_sigframe(ksig, sizeof(*frame)); |
| 182 | 180 | ||
| 183 | if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame))) | 181 | if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame))) |
| @@ -257,8 +255,6 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set) | |||
| 257 | struct rt_sigframe __user *frame; | 255 | struct rt_sigframe __user *frame; |
| 258 | int rsig, sig = ksig->sig; | 256 | int rsig, sig = ksig->sig; |
| 259 | 257 | ||
| 260 | set_fs(USER_DS); | ||
| 261 | |||
| 262 | frame = get_sigframe(ksig, sizeof(*frame)); | 258 | frame = get_sigframe(ksig, sizeof(*frame)); |
| 263 | 259 | ||
| 264 | if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame))) | 260 | if (!access_ok(VERIFY_WRITE, frame, sizeof(*frame))) |
diff --git a/arch/hexagon/kernel/process.c b/arch/hexagon/kernel/process.c index 0a0dd5c05b46..a9ebd471823a 100644 --- a/arch/hexagon/kernel/process.c +++ b/arch/hexagon/kernel/process.c | |||
| @@ -37,8 +37,6 @@ | |||
| 37 | */ | 37 | */ |
| 38 | void start_thread(struct pt_regs *regs, unsigned long pc, unsigned long sp) | 38 | void start_thread(struct pt_regs *regs, unsigned long pc, unsigned long sp) |
| 39 | { | 39 | { |
| 40 | /* Set to run with user-mode data segmentation */ | ||
| 41 | set_fs(USER_DS); | ||
| 42 | /* We want to zero all data-containing registers. Is this overkill? */ | 40 | /* We want to zero all data-containing registers. Is this overkill? */ |
| 43 | memset(regs, 0, sizeof(*regs)); | 41 | memset(regs, 0, sizeof(*regs)); |
| 44 | /* We might want to also zero all Processor registers here */ | 42 | /* We might want to also zero all Processor registers here */ |
diff --git a/arch/m32r/kernel/signal.c b/arch/m32r/kernel/signal.c index 7736c6660a15..8c25e0c8f6a5 100644 --- a/arch/m32r/kernel/signal.c +++ b/arch/m32r/kernel/signal.c | |||
| @@ -214,8 +214,6 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set, | |||
| 214 | regs->r2 = (unsigned long)&frame->uc; | 214 | regs->r2 = (unsigned long)&frame->uc; |
| 215 | regs->bpc = (unsigned long)ksig->ka.sa.sa_handler; | 215 | regs->bpc = (unsigned long)ksig->ka.sa.sa_handler; |
| 216 | 216 | ||
| 217 | set_fs(USER_DS); | ||
| 218 | |||
| 219 | #if DEBUG_SIG | 217 | #if DEBUG_SIG |
| 220 | printk("SIG deliver (%s:%d): sp=%p pc=%p\n", | 218 | printk("SIG deliver (%s:%d): sp=%p pc=%p\n", |
| 221 | current->comm, current->pid, frame, regs->pc); | 219 | current->comm, current->pid, frame, regs->pc); |
diff --git a/arch/metag/include/asm/processor.h b/arch/metag/include/asm/processor.h index 13272fd5a5ba..0838ca699764 100644 --- a/arch/metag/include/asm/processor.h +++ b/arch/metag/include/asm/processor.h | |||
| @@ -111,7 +111,6 @@ struct thread_struct { | |||
| 111 | */ | 111 | */ |
| 112 | #define start_thread(regs, pc, usp) do { \ | 112 | #define start_thread(regs, pc, usp) do { \ |
| 113 | unsigned int *argc = (unsigned int *) bprm->exec; \ | 113 | unsigned int *argc = (unsigned int *) bprm->exec; \ |
| 114 | set_fs(USER_DS); \ | ||
| 115 | current->thread.int_depth = 1; \ | 114 | current->thread.int_depth = 1; \ |
| 116 | /* Force this process down to user land */ \ | 115 | /* Force this process down to user land */ \ |
| 117 | regs->ctx.SaveMask = TBICTX_PRIV_BIT; \ | 116 | regs->ctx.SaveMask = TBICTX_PRIV_BIT; \ |
diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/signal.c index a1cbaf90e2ea..20ccd4e2baa5 100644 --- a/arch/microblaze/kernel/signal.c +++ b/arch/microblaze/kernel/signal.c | |||
| @@ -236,8 +236,6 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set, | |||
| 236 | /* Offset to handle microblaze rtid r14, 0 */ | 236 | /* Offset to handle microblaze rtid r14, 0 */ |
| 237 | regs->pc = (unsigned long)ksig->ka.sa.sa_handler; | 237 | regs->pc = (unsigned long)ksig->ka.sa.sa_handler; |
| 238 | 238 | ||
| 239 | set_fs(USER_DS); | ||
| 240 | |||
| 241 | #ifdef DEBUG_SIG | 239 | #ifdef DEBUG_SIG |
| 242 | pr_info("SIG deliver (%s:%d): sp=%p pc=%08lx\n", | 240 | pr_info("SIG deliver (%s:%d): sp=%p pc=%08lx\n", |
| 243 | current->comm, current->pid, frame, regs->pc); | 241 | current->comm, current->pid, frame, regs->pc); |
diff --git a/arch/nios2/kernel/process.c b/arch/nios2/kernel/process.c index 0e075b5ad2a5..2f8c74f93e70 100644 --- a/arch/nios2/kernel/process.c +++ b/arch/nios2/kernel/process.c | |||
| @@ -94,7 +94,6 @@ void show_regs(struct pt_regs *regs) | |||
| 94 | 94 | ||
| 95 | void flush_thread(void) | 95 | void flush_thread(void) |
| 96 | { | 96 | { |
| 97 | set_fs(USER_DS); | ||
| 98 | } | 97 | } |
| 99 | 98 | ||
| 100 | int copy_thread(unsigned long clone_flags, | 99 | int copy_thread(unsigned long clone_flags, |
diff --git a/arch/openrisc/kernel/process.c b/arch/openrisc/kernel/process.c index 386af258591d..7095dfe7666b 100644 --- a/arch/openrisc/kernel/process.c +++ b/arch/openrisc/kernel/process.c | |||
| @@ -197,7 +197,6 @@ void start_thread(struct pt_regs *regs, unsigned long pc, unsigned long sp) | |||
| 197 | { | 197 | { |
| 198 | unsigned long sr = mfspr(SPR_SR) & ~SPR_SR_SM; | 198 | unsigned long sr = mfspr(SPR_SR) & ~SPR_SR_SM; |
| 199 | 199 | ||
| 200 | set_fs(USER_DS); | ||
| 201 | memset(regs, 0, sizeof(struct pt_regs)); | 200 | memset(regs, 0, sizeof(struct pt_regs)); |
| 202 | 201 | ||
| 203 | regs->pc = pc; | 202 | regs->pc = pc; |
diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c index 99824ff8dd35..df7d8cbee377 100644 --- a/arch/s390/hypfs/inode.c +++ b/arch/s390/hypfs/inode.c | |||
| @@ -21,7 +21,7 @@ | |||
| 21 | #include <linux/module.h> | 21 | #include <linux/module.h> |
| 22 | #include <linux/seq_file.h> | 22 | #include <linux/seq_file.h> |
| 23 | #include <linux/mount.h> | 23 | #include <linux/mount.h> |
| 24 | #include <linux/aio.h> | 24 | #include <linux/uio.h> |
| 25 | #include <asm/ebcdic.h> | 25 | #include <asm/ebcdic.h> |
| 26 | #include "hypfs.h" | 26 | #include "hypfs.h" |
| 27 | 27 | ||
diff --git a/arch/sh/kernel/signal_32.c b/arch/sh/kernel/signal_32.c index 0b34f2a704fe..97292890b51b 100644 --- a/arch/sh/kernel/signal_32.c +++ b/arch/sh/kernel/signal_32.c | |||
| @@ -329,8 +329,6 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set, | |||
| 329 | if (err) | 329 | if (err) |
| 330 | return -EFAULT; | 330 | return -EFAULT; |
| 331 | 331 | ||
| 332 | set_fs(USER_DS); | ||
| 333 | |||
| 334 | pr_debug("SIG deliver (%s:%d): sp=%p pc=%08lx pr=%08lx\n", | 332 | pr_debug("SIG deliver (%s:%d): sp=%p pc=%08lx pr=%08lx\n", |
| 335 | current->comm, task_pid_nr(current), frame, regs->pc, regs->pr); | 333 | current->comm, task_pid_nr(current), frame, regs->pc, regs->pr); |
| 336 | 334 | ||
| @@ -408,8 +406,6 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set, | |||
| 408 | if (err) | 406 | if (err) |
| 409 | return -EFAULT; | 407 | return -EFAULT; |
| 410 | 408 | ||
| 411 | set_fs(USER_DS); | ||
| 412 | |||
| 413 | pr_debug("SIG deliver (%s:%d): sp=%p pc=%08lx pr=%08lx\n", | 409 | pr_debug("SIG deliver (%s:%d): sp=%p pc=%08lx pr=%08lx\n", |
| 414 | current->comm, task_pid_nr(current), frame, regs->pc, regs->pr); | 410 | current->comm, task_pid_nr(current), frame, regs->pc, regs->pr); |
| 415 | 411 | ||
diff --git a/arch/sh/kernel/signal_64.c b/arch/sh/kernel/signal_64.c index 71993c6a7d94..0462995d4d7f 100644 --- a/arch/sh/kernel/signal_64.c +++ b/arch/sh/kernel/signal_64.c | |||
| @@ -457,8 +457,6 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set, struct pt_regs *regs | |||
| 457 | 457 | ||
| 458 | regs->pc = neff_sign_extend((unsigned long)ksig->ka.sa.sa_handler); | 458 | regs->pc = neff_sign_extend((unsigned long)ksig->ka.sa.sa_handler); |
| 459 | 459 | ||
| 460 | set_fs(USER_DS); | ||
| 461 | |||
| 462 | /* Broken %016Lx */ | 460 | /* Broken %016Lx */ |
| 463 | pr_debug("SIG deliver (#%d,%s:%d): sp=%p pc=%08Lx%08Lx link=%08Lx%08Lx\n", | 461 | pr_debug("SIG deliver (#%d,%s:%d): sp=%p pc=%08Lx%08Lx link=%08Lx%08Lx\n", |
| 464 | signal, current->comm, current->pid, frame, | 462 | signal, current->comm, current->pid, frame, |
| @@ -547,8 +545,6 @@ static int setup_rt_frame(struct ksignal *kig, sigset_t *set, | |||
| 547 | regs->regs[REG_ARG3] = (unsigned long long)(unsigned long)(signed long)&frame->uc.uc_mcontext; | 545 | regs->regs[REG_ARG3] = (unsigned long long)(unsigned long)(signed long)&frame->uc.uc_mcontext; |
| 548 | regs->pc = neff_sign_extend((unsigned long)ksig->ka.sa.sa_handler); | 546 | regs->pc = neff_sign_extend((unsigned long)ksig->ka.sa.sa_handler); |
| 549 | 547 | ||
| 550 | set_fs(USER_DS); | ||
| 551 | |||
| 552 | pr_debug("SIG deliver (#%d,%s:%d): sp=%p pc=%08Lx%08Lx link=%08Lx%08Lx\n", | 548 | pr_debug("SIG deliver (#%d,%s:%d): sp=%p pc=%08Lx%08Lx link=%08Lx%08Lx\n", |
| 553 | signal, current->comm, current->pid, frame, | 549 | signal, current->comm, current->pid, frame, |
| 554 | regs->pc >> 32, regs->pc & 0xffffffff, | 550 | regs->pc >> 32, regs->pc & 0xffffffff, |
diff --git a/arch/xtensa/kernel/signal.c b/arch/xtensa/kernel/signal.c index 3d733ba16f28..6b3790445cbe 100644 --- a/arch/xtensa/kernel/signal.c +++ b/arch/xtensa/kernel/signal.c | |||
| @@ -405,11 +405,6 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set, | |||
| 405 | regs->areg[8] = (unsigned long) &frame->uc; | 405 | regs->areg[8] = (unsigned long) &frame->uc; |
| 406 | regs->threadptr = tp; | 406 | regs->threadptr = tp; |
| 407 | 407 | ||
| 408 | /* Set access mode to USER_DS. Nomenclature is outdated, but | ||
| 409 | * functionality is used in uaccess.h | ||
| 410 | */ | ||
| 411 | set_fs(USER_DS); | ||
| 412 | |||
| 413 | #if DEBUG_SIG | 408 | #if DEBUG_SIG |
| 414 | printk("SIG rt deliver (%s:%d): signal=%d sp=%p pc=%08x\n", | 409 | printk("SIG rt deliver (%s:%d): signal=%d sp=%p pc=%08x\n", |
| 415 | current->comm, current->pid, signal, frame, regs->pc); | 410 | current->comm, current->pid, signal, frame, regs->pc); |
diff --git a/block/blk-map.c b/block/blk-map.c index b8d2725324a6..da310a105429 100644 --- a/block/blk-map.c +++ b/block/blk-map.c | |||
| @@ -124,10 +124,10 @@ int blk_rq_map_user(struct request_queue *q, struct request *rq, | |||
| 124 | { | 124 | { |
| 125 | struct iovec iov; | 125 | struct iovec iov; |
| 126 | struct iov_iter i; | 126 | struct iov_iter i; |
| 127 | int ret = import_single_range(rq_data_dir(rq), ubuf, len, &iov, &i); | ||
| 127 | 128 | ||
| 128 | iov.iov_base = ubuf; | 129 | if (unlikely(ret < 0)) |
| 129 | iov.iov_len = len; | 130 | return ret; |
| 130 | iov_iter_init(&i, rq_data_dir(rq), &iov, 1, len); | ||
| 131 | 131 | ||
| 132 | return blk_rq_map_user_iov(q, rq, map_data, &i, gfp_mask); | 132 | return blk_rq_map_user_iov(q, rq, map_data, &i, gfp_mask); |
| 133 | } | 133 | } |
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index e1f71c396193..55b6f15dac90 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c | |||
| @@ -335,16 +335,14 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk, | |||
| 335 | struct iov_iter i; | 335 | struct iov_iter i; |
| 336 | struct iovec *iov = NULL; | 336 | struct iovec *iov = NULL; |
| 337 | 337 | ||
| 338 | ret = rw_copy_check_uvector(-1, hdr->dxferp, hdr->iovec_count, | 338 | ret = import_iovec(rq_data_dir(rq), |
| 339 | 0, NULL, &iov); | 339 | hdr->dxferp, hdr->iovec_count, |
| 340 | if (ret < 0) { | 340 | 0, &iov, &i); |
| 341 | kfree(iov); | 341 | if (ret < 0) |
| 342 | goto out_free_cdb; | 342 | goto out_free_cdb; |
| 343 | } | ||
| 344 | 343 | ||
| 345 | /* SG_IO howto says that the shorter of the two wins */ | 344 | /* SG_IO howto says that the shorter of the two wins */ |
| 346 | iov_iter_init(&i, rq_data_dir(rq), iov, hdr->iovec_count, | 345 | iov_iter_truncate(&i, hdr->dxfer_len); |
| 347 | min_t(unsigned, ret, hdr->dxfer_len)); | ||
| 348 | 346 | ||
| 349 | ret = blk_rq_map_user_iov(q, rq, NULL, &i, GFP_KERNEL); | 347 | ret = blk_rq_map_user_iov(q, rq, NULL, &i, GFP_KERNEL); |
| 350 | kfree(iov); | 348 | kfree(iov); |
diff --git a/drivers/char/mem.c b/drivers/char/mem.c index 297110c12635..9c4fd7a8e2e5 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c | |||
| @@ -26,7 +26,7 @@ | |||
| 26 | #include <linux/pfn.h> | 26 | #include <linux/pfn.h> |
| 27 | #include <linux/export.h> | 27 | #include <linux/export.h> |
| 28 | #include <linux/io.h> | 28 | #include <linux/io.h> |
| 29 | #include <linux/aio.h> | 29 | #include <linux/uio.h> |
| 30 | 30 | ||
| 31 | #include <linux/uaccess.h> | 31 | #include <linux/uaccess.h> |
| 32 | 32 | ||
diff --git a/drivers/char/tile-srom.c b/drivers/char/tile-srom.c index 02e76ac6d282..69f6b4acc377 100644 --- a/drivers/char/tile-srom.c +++ b/drivers/char/tile-srom.c | |||
| @@ -27,7 +27,6 @@ | |||
| 27 | #include <linux/types.h> /* size_t */ | 27 | #include <linux/types.h> /* size_t */ |
| 28 | #include <linux/proc_fs.h> | 28 | #include <linux/proc_fs.h> |
| 29 | #include <linux/fcntl.h> /* O_ACCMODE */ | 29 | #include <linux/fcntl.h> /* O_ACCMODE */ |
| 30 | #include <linux/aio.h> | ||
| 31 | #include <linux/pagemap.h> | 30 | #include <linux/pagemap.h> |
| 32 | #include <linux/hugetlb.h> | 31 | #include <linux/hugetlb.h> |
| 33 | #include <linux/uaccess.h> | 32 | #include <linux/uaccess.h> |
diff --git a/drivers/infiniband/hw/ipath/ipath_file_ops.c b/drivers/infiniband/hw/ipath/ipath_file_ops.c index 6d7f453b4d05..aed8afee56da 100644 --- a/drivers/infiniband/hw/ipath/ipath_file_ops.c +++ b/drivers/infiniband/hw/ipath/ipath_file_ops.c | |||
| @@ -40,7 +40,6 @@ | |||
| 40 | #include <linux/slab.h> | 40 | #include <linux/slab.h> |
| 41 | #include <linux/highmem.h> | 41 | #include <linux/highmem.h> |
| 42 | #include <linux/io.h> | 42 | #include <linux/io.h> |
| 43 | #include <linux/aio.h> | ||
| 44 | #include <linux/jiffies.h> | 43 | #include <linux/jiffies.h> |
| 45 | #include <linux/cpu.h> | 44 | #include <linux/cpu.h> |
| 46 | #include <asm/pgtable.h> | 45 | #include <asm/pgtable.h> |
diff --git a/drivers/infiniband/hw/qib/qib_file_ops.c b/drivers/infiniband/hw/qib/qib_file_ops.c index 41937c6f888a..14046f5a37fa 100644 --- a/drivers/infiniband/hw/qib/qib_file_ops.c +++ b/drivers/infiniband/hw/qib/qib_file_ops.c | |||
| @@ -39,7 +39,6 @@ | |||
| 39 | #include <linux/vmalloc.h> | 39 | #include <linux/vmalloc.h> |
| 40 | #include <linux/highmem.h> | 40 | #include <linux/highmem.h> |
| 41 | #include <linux/io.h> | 41 | #include <linux/io.h> |
| 42 | #include <linux/aio.h> | ||
| 43 | #include <linux/jiffies.h> | 42 | #include <linux/jiffies.h> |
| 44 | #include <asm/pgtable.h> | 43 | #include <asm/pgtable.h> |
| 45 | #include <linux/delay.h> | 44 | #include <linux/delay.h> |
diff --git a/drivers/misc/mei/amthif.c b/drivers/misc/mei/amthif.c index c4cb9a984a5f..40ea639fa413 100644 --- a/drivers/misc/mei/amthif.c +++ b/drivers/misc/mei/amthif.c | |||
| @@ -19,7 +19,6 @@ | |||
| 19 | #include <linux/errno.h> | 19 | #include <linux/errno.h> |
| 20 | #include <linux/types.h> | 20 | #include <linux/types.h> |
| 21 | #include <linux/fcntl.h> | 21 | #include <linux/fcntl.h> |
| 22 | #include <linux/aio.h> | ||
| 23 | #include <linux/ioctl.h> | 22 | #include <linux/ioctl.h> |
| 24 | #include <linux/cdev.h> | 23 | #include <linux/cdev.h> |
| 25 | #include <linux/list.h> | 24 | #include <linux/list.h> |
diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index 3c019c0e60eb..47680c84801c 100644 --- a/drivers/misc/mei/main.c +++ b/drivers/misc/mei/main.c | |||
| @@ -22,7 +22,6 @@ | |||
| 22 | #include <linux/errno.h> | 22 | #include <linux/errno.h> |
| 23 | #include <linux/types.h> | 23 | #include <linux/types.h> |
| 24 | #include <linux/fcntl.h> | 24 | #include <linux/fcntl.h> |
| 25 | #include <linux/aio.h> | ||
| 26 | #include <linux/poll.h> | 25 | #include <linux/poll.h> |
| 27 | #include <linux/init.h> | 26 | #include <linux/init.h> |
| 28 | #include <linux/ioctl.h> | 27 | #include <linux/ioctl.h> |
diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c index bd3039ab8f98..af44ee26075d 100644 --- a/drivers/misc/mei/pci-me.c +++ b/drivers/misc/mei/pci-me.c | |||
| @@ -21,7 +21,6 @@ | |||
| 21 | #include <linux/errno.h> | 21 | #include <linux/errno.h> |
| 22 | #include <linux/types.h> | 22 | #include <linux/types.h> |
| 23 | #include <linux/fcntl.h> | 23 | #include <linux/fcntl.h> |
| 24 | #include <linux/aio.h> | ||
| 25 | #include <linux/pci.h> | 24 | #include <linux/pci.h> |
| 26 | #include <linux/poll.h> | 25 | #include <linux/poll.h> |
| 27 | #include <linux/ioctl.h> | 26 | #include <linux/ioctl.h> |
diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 2270bd51f9c2..9d7b7db75e4b 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c | |||
| @@ -33,7 +33,6 @@ static int sg_version_num = 30536; /* 2 digits for each component */ | |||
| 33 | #include <linux/sched.h> | 33 | #include <linux/sched.h> |
| 34 | #include <linux/string.h> | 34 | #include <linux/string.h> |
| 35 | #include <linux/mm.h> | 35 | #include <linux/mm.h> |
| 36 | #include <linux/aio.h> | ||
| 37 | #include <linux/errno.h> | 36 | #include <linux/errno.h> |
| 38 | #include <linux/mtio.h> | 37 | #include <linux/mtio.h> |
| 39 | #include <linux/ioctl.h> | 38 | #include <linux/ioctl.h> |
| @@ -51,6 +50,7 @@ static int sg_version_num = 30536; /* 2 digits for each component */ | |||
| 51 | #include <linux/mutex.h> | 50 | #include <linux/mutex.h> |
| 52 | #include <linux/atomic.h> | 51 | #include <linux/atomic.h> |
| 53 | #include <linux/ratelimit.h> | 52 | #include <linux/ratelimit.h> |
| 53 | #include <linux/uio.h> | ||
| 54 | 54 | ||
| 55 | #include "scsi.h" | 55 | #include "scsi.h" |
| 56 | #include <scsi/scsi_dbg.h> | 56 | #include <scsi/scsi_dbg.h> |
| @@ -1745,17 +1745,14 @@ sg_start_req(Sg_request *srp, unsigned char *cmd) | |||
| 1745 | } | 1745 | } |
| 1746 | 1746 | ||
| 1747 | if (iov_count) { | 1747 | if (iov_count) { |
| 1748 | int size = sizeof(struct iovec) * iov_count; | 1748 | struct iovec *iov = NULL; |
| 1749 | struct iovec *iov; | ||
| 1750 | struct iov_iter i; | 1749 | struct iov_iter i; |
| 1751 | 1750 | ||
| 1752 | iov = memdup_user(hp->dxferp, size); | 1751 | res = import_iovec(rw, hp->dxferp, iov_count, 0, &iov, &i); |
| 1753 | if (IS_ERR(iov)) | 1752 | if (res < 0) |
| 1754 | return PTR_ERR(iov); | 1753 | return res; |
| 1755 | 1754 | ||
| 1756 | iov_iter_init(&i, rw, iov, iov_count, | 1755 | iov_iter_truncate(&i, hp->dxfer_len); |
| 1757 | min_t(size_t, hp->dxfer_len, | ||
| 1758 | iov_length(iov, iov_count))); | ||
| 1759 | 1756 | ||
| 1760 | res = blk_rq_map_user_iov(q, rq, md, &i, GFP_ATOMIC); | 1757 | res = blk_rq_map_user_iov(q, rq, md, &i, GFP_ATOMIC); |
| 1761 | kfree(iov); | 1758 | kfree(iov); |
diff --git a/drivers/staging/unisys/include/timskmod.h b/drivers/staging/unisys/include/timskmod.h index 5a933d7bf39f..cde2494ad896 100644 --- a/drivers/staging/unisys/include/timskmod.h +++ b/drivers/staging/unisys/include/timskmod.h | |||
| @@ -46,7 +46,6 @@ | |||
| 46 | #include <linux/module.h> | 46 | #include <linux/module.h> |
| 47 | #include <linux/moduleparam.h> | 47 | #include <linux/moduleparam.h> |
| 48 | #include <linux/fcntl.h> | 48 | #include <linux/fcntl.h> |
| 49 | #include <linux/aio.h> | ||
| 50 | #include <linux/workqueue.h> | 49 | #include <linux/workqueue.h> |
| 51 | #include <linux/kthread.h> | 50 | #include <linux/kthread.h> |
| 52 | #include <linux/seq_file.h> | 51 | #include <linux/seq_file.h> |
diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index 175c9956cbe3..a12315a78248 100644 --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c | |||
| @@ -23,6 +23,7 @@ | |||
| 23 | #include <linux/export.h> | 23 | #include <linux/export.h> |
| 24 | #include <linux/hid.h> | 24 | #include <linux/hid.h> |
| 25 | #include <linux/module.h> | 25 | #include <linux/module.h> |
| 26 | #include <linux/uio.h> | ||
| 26 | #include <asm/unaligned.h> | 27 | #include <asm/unaligned.h> |
| 27 | 28 | ||
| 28 | #include <linux/usb/composite.h> | 29 | #include <linux/usb/composite.h> |
| @@ -655,9 +656,10 @@ static void ffs_user_copy_worker(struct work_struct *work) | |||
| 655 | unuse_mm(io_data->mm); | 656 | unuse_mm(io_data->mm); |
| 656 | } | 657 | } |
| 657 | 658 | ||
| 658 | aio_complete(io_data->kiocb, ret, ret); | 659 | io_data->kiocb->ki_complete(io_data->kiocb, ret, ret); |
| 659 | 660 | ||
| 660 | if (io_data->ffs->ffs_eventfd && !io_data->kiocb->ki_eventfd) | 661 | if (io_data->ffs->ffs_eventfd && |
| 662 | !(io_data->kiocb->ki_flags & IOCB_EVENTFD)) | ||
| 661 | eventfd_signal(io_data->ffs->ffs_eventfd, 1); | 663 | eventfd_signal(io_data->ffs->ffs_eventfd, 1); |
| 662 | 664 | ||
| 663 | usb_ep_free_request(io_data->ep, io_data->req); | 665 | usb_ep_free_request(io_data->ep, io_data->req); |
diff --git a/drivers/usb/gadget/legacy/inode.c b/drivers/usb/gadget/legacy/inode.c index 200f9a584064..662ef2c1c62b 100644 --- a/drivers/usb/gadget/legacy/inode.c +++ b/drivers/usb/gadget/legacy/inode.c | |||
| @@ -26,6 +26,7 @@ | |||
| 26 | #include <linux/poll.h> | 26 | #include <linux/poll.h> |
| 27 | #include <linux/mmu_context.h> | 27 | #include <linux/mmu_context.h> |
| 28 | #include <linux/aio.h> | 28 | #include <linux/aio.h> |
| 29 | #include <linux/uio.h> | ||
| 29 | 30 | ||
| 30 | #include <linux/device.h> | 31 | #include <linux/device.h> |
| 31 | #include <linux/moduleparam.h> | 32 | #include <linux/moduleparam.h> |
| @@ -469,7 +470,7 @@ static void ep_user_copy_worker(struct work_struct *work) | |||
| 469 | ret = -EFAULT; | 470 | ret = -EFAULT; |
| 470 | 471 | ||
| 471 | /* completing the iocb can drop the ctx and mm, don't touch mm after */ | 472 | /* completing the iocb can drop the ctx and mm, don't touch mm after */ |
| 472 | aio_complete(iocb, ret, ret); | 473 | iocb->ki_complete(iocb, ret, ret); |
| 473 | 474 | ||
| 474 | kfree(priv->buf); | 475 | kfree(priv->buf); |
| 475 | kfree(priv->to_free); | 476 | kfree(priv->to_free); |
| @@ -497,7 +498,8 @@ static void ep_aio_complete(struct usb_ep *ep, struct usb_request *req) | |||
| 497 | kfree(priv); | 498 | kfree(priv); |
| 498 | iocb->private = NULL; | 499 | iocb->private = NULL; |
| 499 | /* aio_complete() reports bytes-transferred _and_ faults */ | 500 | /* aio_complete() reports bytes-transferred _and_ faults */ |
| 500 | aio_complete(iocb, req->actual ? req->actual : req->status, | 501 | |
| 502 | iocb->ki_complete(iocb, req->actual ? req->actual : req->status, | ||
| 501 | req->status); | 503 | req->status); |
| 502 | } else { | 504 | } else { |
| 503 | /* ep_copy_to_user() won't report both; we hide some faults */ | 505 | /* ep_copy_to_user() won't report both; we hide some faults */ |
diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c index eb14e055ea83..ff1a5bac4200 100644 --- a/fs/9p/vfs_addr.c +++ b/fs/9p/vfs_addr.c | |||
| @@ -33,7 +33,7 @@ | |||
| 33 | #include <linux/pagemap.h> | 33 | #include <linux/pagemap.h> |
| 34 | #include <linux/idr.h> | 34 | #include <linux/idr.h> |
| 35 | #include <linux/sched.h> | 35 | #include <linux/sched.h> |
| 36 | #include <linux/aio.h> | 36 | #include <linux/uio.h> |
| 37 | #include <net/9p/9p.h> | 37 | #include <net/9p/9p.h> |
| 38 | #include <net/9p/client.h> | 38 | #include <net/9p/client.h> |
| 39 | 39 | ||
diff --git a/fs/affs/file.c b/fs/affs/file.c index a91795e01a7f..3aa7eb66547e 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c | |||
| @@ -12,7 +12,7 @@ | |||
| 12 | * affs regular file handling primitives | 12 | * affs regular file handling primitives |
| 13 | */ | 13 | */ |
| 14 | 14 | ||
| 15 | #include <linux/aio.h> | 15 | #include <linux/uio.h> |
| 16 | #include "affs.h" | 16 | #include "affs.h" |
| 17 | 17 | ||
| 18 | static struct buffer_head *affs_get_extblock_slow(struct inode *inode, u32 ext); | 18 | static struct buffer_head *affs_get_extblock_slow(struct inode *inode, u32 ext); |
diff --git a/fs/afs/write.c b/fs/afs/write.c index c13cb08964ed..0714abcd7f32 100644 --- a/fs/afs/write.c +++ b/fs/afs/write.c | |||
| @@ -14,7 +14,6 @@ | |||
| 14 | #include <linux/pagemap.h> | 14 | #include <linux/pagemap.h> |
| 15 | #include <linux/writeback.h> | 15 | #include <linux/writeback.h> |
| 16 | #include <linux/pagevec.h> | 16 | #include <linux/pagevec.h> |
| 17 | #include <linux/aio.h> | ||
| 18 | #include "internal.h" | 17 | #include "internal.h" |
| 19 | 18 | ||
| 20 | static int afs_write_back_from_locked_page(struct afs_writeback *wb, | 19 | static int afs_write_back_from_locked_page(struct afs_writeback *wb, |
| @@ -151,6 +151,38 @@ struct kioctx { | |||
| 151 | unsigned id; | 151 | unsigned id; |
| 152 | }; | 152 | }; |
| 153 | 153 | ||
| 154 | /* | ||
| 155 | * We use ki_cancel == KIOCB_CANCELLED to indicate that a kiocb has been either | ||
| 156 | * cancelled or completed (this makes a certain amount of sense because | ||
| 157 | * successful cancellation - io_cancel() - does deliver the completion to | ||
| 158 | * userspace). | ||
| 159 | * | ||
| 160 | * And since most things don't implement kiocb cancellation and we'd really like | ||
| 161 | * kiocb completion to be lockless when possible, we use ki_cancel to | ||
| 162 | * synchronize cancellation and completion - we only set it to KIOCB_CANCELLED | ||
| 163 | * with xchg() or cmpxchg(), see batch_complete_aio() and kiocb_cancel(). | ||
| 164 | */ | ||
| 165 | #define KIOCB_CANCELLED ((void *) (~0ULL)) | ||
| 166 | |||
| 167 | struct aio_kiocb { | ||
| 168 | struct kiocb common; | ||
| 169 | |||
| 170 | struct kioctx *ki_ctx; | ||
| 171 | kiocb_cancel_fn *ki_cancel; | ||
| 172 | |||
| 173 | struct iocb __user *ki_user_iocb; /* user's aiocb */ | ||
| 174 | __u64 ki_user_data; /* user's data for completion */ | ||
| 175 | |||
| 176 | struct list_head ki_list; /* the aio core uses this | ||
| 177 | * for cancellation */ | ||
| 178 | |||
| 179 | /* | ||
| 180 | * If the aio_resfd field of the userspace iocb is not zero, | ||
| 181 | * this is the underlying eventfd context to deliver events to. | ||
| 182 | */ | ||
| 183 | struct eventfd_ctx *ki_eventfd; | ||
| 184 | }; | ||
| 185 | |||
| 154 | /*------ sysctl variables----*/ | 186 | /*------ sysctl variables----*/ |
| 155 | static DEFINE_SPINLOCK(aio_nr_lock); | 187 | static DEFINE_SPINLOCK(aio_nr_lock); |
| 156 | unsigned long aio_nr; /* current system wide number of aio requests */ | 188 | unsigned long aio_nr; /* current system wide number of aio requests */ |
| @@ -220,7 +252,7 @@ static int __init aio_setup(void) | |||
| 220 | if (IS_ERR(aio_mnt)) | 252 | if (IS_ERR(aio_mnt)) |
| 221 | panic("Failed to create aio fs mount."); | 253 | panic("Failed to create aio fs mount."); |
| 222 | 254 | ||
| 223 | kiocb_cachep = KMEM_CACHE(kiocb, SLAB_HWCACHE_ALIGN|SLAB_PANIC); | 255 | kiocb_cachep = KMEM_CACHE(aio_kiocb, SLAB_HWCACHE_ALIGN|SLAB_PANIC); |
| 224 | kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC); | 256 | kioctx_cachep = KMEM_CACHE(kioctx,SLAB_HWCACHE_ALIGN|SLAB_PANIC); |
| 225 | 257 | ||
| 226 | pr_debug("sizeof(struct page) = %zu\n", sizeof(struct page)); | 258 | pr_debug("sizeof(struct page) = %zu\n", sizeof(struct page)); |
| @@ -484,8 +516,9 @@ static int aio_setup_ring(struct kioctx *ctx) | |||
| 484 | #define AIO_EVENTS_FIRST_PAGE ((PAGE_SIZE - sizeof(struct aio_ring)) / sizeof(struct io_event)) | 516 | #define AIO_EVENTS_FIRST_PAGE ((PAGE_SIZE - sizeof(struct aio_ring)) / sizeof(struct io_event)) |
| 485 | #define AIO_EVENTS_OFFSET (AIO_EVENTS_PER_PAGE - AIO_EVENTS_FIRST_PAGE) | 517 | #define AIO_EVENTS_OFFSET (AIO_EVENTS_PER_PAGE - AIO_EVENTS_FIRST_PAGE) |
| 486 | 518 | ||
| 487 | void kiocb_set_cancel_fn(struct kiocb *req, kiocb_cancel_fn *cancel) | 519 | void kiocb_set_cancel_fn(struct kiocb *iocb, kiocb_cancel_fn *cancel) |
| 488 | { | 520 | { |
| 521 | struct aio_kiocb *req = container_of(iocb, struct aio_kiocb, common); | ||
| 489 | struct kioctx *ctx = req->ki_ctx; | 522 | struct kioctx *ctx = req->ki_ctx; |
| 490 | unsigned long flags; | 523 | unsigned long flags; |
| 491 | 524 | ||
| @@ -500,7 +533,7 @@ void kiocb_set_cancel_fn(struct kiocb *req, kiocb_cancel_fn *cancel) | |||
| 500 | } | 533 | } |
| 501 | EXPORT_SYMBOL(kiocb_set_cancel_fn); | 534 | EXPORT_SYMBOL(kiocb_set_cancel_fn); |
| 502 | 535 | ||
| 503 | static int kiocb_cancel(struct kiocb *kiocb) | 536 | static int kiocb_cancel(struct aio_kiocb *kiocb) |
| 504 | { | 537 | { |
| 505 | kiocb_cancel_fn *old, *cancel; | 538 | kiocb_cancel_fn *old, *cancel; |
| 506 | 539 | ||
| @@ -518,7 +551,7 @@ static int kiocb_cancel(struct kiocb *kiocb) | |||
| 518 | cancel = cmpxchg(&kiocb->ki_cancel, old, KIOCB_CANCELLED); | 551 | cancel = cmpxchg(&kiocb->ki_cancel, old, KIOCB_CANCELLED); |
| 519 | } while (cancel != old); | 552 | } while (cancel != old); |
| 520 | 553 | ||
| 521 | return cancel(kiocb); | 554 | return cancel(&kiocb->common); |
| 522 | } | 555 | } |
| 523 | 556 | ||
| 524 | static void free_ioctx(struct work_struct *work) | 557 | static void free_ioctx(struct work_struct *work) |
| @@ -554,13 +587,13 @@ static void free_ioctx_reqs(struct percpu_ref *ref) | |||
| 554 | static void free_ioctx_users(struct percpu_ref *ref) | 587 | static void free_ioctx_users(struct percpu_ref *ref) |
| 555 | { | 588 | { |
| 556 | struct kioctx *ctx = container_of(ref, struct kioctx, users); | 589 | struct kioctx *ctx = container_of(ref, struct kioctx, users); |
| 557 | struct kiocb *req; | 590 | struct aio_kiocb *req; |
| 558 | 591 | ||
| 559 | spin_lock_irq(&ctx->ctx_lock); | 592 | spin_lock_irq(&ctx->ctx_lock); |
| 560 | 593 | ||
| 561 | while (!list_empty(&ctx->active_reqs)) { | 594 | while (!list_empty(&ctx->active_reqs)) { |
| 562 | req = list_first_entry(&ctx->active_reqs, | 595 | req = list_first_entry(&ctx->active_reqs, |
| 563 | struct kiocb, ki_list); | 596 | struct aio_kiocb, ki_list); |
| 564 | 597 | ||
| 565 | list_del_init(&req->ki_list); | 598 | list_del_init(&req->ki_list); |
| 566 | kiocb_cancel(req); | 599 | kiocb_cancel(req); |
| @@ -786,22 +819,6 @@ static int kill_ioctx(struct mm_struct *mm, struct kioctx *ctx, | |||
| 786 | return 0; | 819 | return 0; |
| 787 | } | 820 | } |
| 788 | 821 | ||
| 789 | /* wait_on_sync_kiocb: | ||
| 790 | * Waits on the given sync kiocb to complete. | ||
| 791 | */ | ||
| 792 | ssize_t wait_on_sync_kiocb(struct kiocb *req) | ||
| 793 | { | ||
| 794 | while (!req->ki_ctx) { | ||
| 795 | set_current_state(TASK_UNINTERRUPTIBLE); | ||
| 796 | if (req->ki_ctx) | ||
| 797 | break; | ||
| 798 | io_schedule(); | ||
| 799 | } | ||
| 800 | __set_current_state(TASK_RUNNING); | ||
| 801 | return req->ki_user_data; | ||
| 802 | } | ||
| 803 | EXPORT_SYMBOL(wait_on_sync_kiocb); | ||
| 804 | |||
| 805 | /* | 822 | /* |
| 806 | * exit_aio: called when the last user of mm goes away. At this point, there is | 823 | * exit_aio: called when the last user of mm goes away. At this point, there is |
| 807 | * no way for any new requests to be submited or any of the io_* syscalls to be | 824 | * no way for any new requests to be submited or any of the io_* syscalls to be |
| @@ -956,9 +973,9 @@ static void user_refill_reqs_available(struct kioctx *ctx) | |||
| 956 | * Allocate a slot for an aio request. | 973 | * Allocate a slot for an aio request. |
| 957 | * Returns NULL if no requests are free. | 974 | * Returns NULL if no requests are free. |
| 958 | */ | 975 | */ |
| 959 | static inline struct kiocb *aio_get_req(struct kioctx *ctx) | 976 | static inline struct aio_kiocb *aio_get_req(struct kioctx *ctx) |
| 960 | { | 977 | { |
| 961 | struct kiocb *req; | 978 | struct aio_kiocb *req; |
| 962 | 979 | ||
| 963 | if (!get_reqs_available(ctx)) { | 980 | if (!get_reqs_available(ctx)) { |
| 964 | user_refill_reqs_available(ctx); | 981 | user_refill_reqs_available(ctx); |
| @@ -979,10 +996,10 @@ out_put: | |||
| 979 | return NULL; | 996 | return NULL; |
| 980 | } | 997 | } |
| 981 | 998 | ||
| 982 | static void kiocb_free(struct kiocb *req) | 999 | static void kiocb_free(struct aio_kiocb *req) |
| 983 | { | 1000 | { |
| 984 | if (req->ki_filp) | 1001 | if (req->common.ki_filp) |
| 985 | fput(req->ki_filp); | 1002 | fput(req->common.ki_filp); |
| 986 | if (req->ki_eventfd != NULL) | 1003 | if (req->ki_eventfd != NULL) |
| 987 | eventfd_ctx_put(req->ki_eventfd); | 1004 | eventfd_ctx_put(req->ki_eventfd); |
| 988 | kmem_cache_free(kiocb_cachep, req); | 1005 | kmem_cache_free(kiocb_cachep, req); |
| @@ -1018,8 +1035,9 @@ out: | |||
| 1018 | /* aio_complete | 1035 | /* aio_complete |
| 1019 | * Called when the io request on the given iocb is complete. | 1036 | * Called when the io request on the given iocb is complete. |
| 1020 | */ | 1037 | */ |
| 1021 | void aio_complete(struct kiocb *iocb, long res, long res2) | 1038 | static void aio_complete(struct kiocb *kiocb, long res, long res2) |
| 1022 | { | 1039 | { |
| 1040 | struct aio_kiocb *iocb = container_of(kiocb, struct aio_kiocb, common); | ||
| 1023 | struct kioctx *ctx = iocb->ki_ctx; | 1041 | struct kioctx *ctx = iocb->ki_ctx; |
| 1024 | struct aio_ring *ring; | 1042 | struct aio_ring *ring; |
| 1025 | struct io_event *ev_page, *event; | 1043 | struct io_event *ev_page, *event; |
| @@ -1033,13 +1051,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2) | |||
| 1033 | * ref, no other paths have a way to get another ref | 1051 | * ref, no other paths have a way to get another ref |
| 1034 | * - the sync task helpfully left a reference to itself in the iocb | 1052 | * - the sync task helpfully left a reference to itself in the iocb |
| 1035 | */ | 1053 | */ |
| 1036 | if (is_sync_kiocb(iocb)) { | 1054 | BUG_ON(is_sync_kiocb(kiocb)); |
| 1037 | iocb->ki_user_data = res; | ||
| 1038 | smp_wmb(); | ||
| 1039 | iocb->ki_ctx = ERR_PTR(-EXDEV); | ||
| 1040 | wake_up_process(iocb->ki_obj.tsk); | ||
| 1041 | return; | ||
| 1042 | } | ||
| 1043 | 1055 | ||
| 1044 | if (iocb->ki_list.next) { | 1056 | if (iocb->ki_list.next) { |
| 1045 | unsigned long flags; | 1057 | unsigned long flags; |
| @@ -1065,7 +1077,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2) | |||
| 1065 | ev_page = kmap_atomic(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE]); | 1077 | ev_page = kmap_atomic(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE]); |
| 1066 | event = ev_page + pos % AIO_EVENTS_PER_PAGE; | 1078 | event = ev_page + pos % AIO_EVENTS_PER_PAGE; |
| 1067 | 1079 | ||
| 1068 | event->obj = (u64)(unsigned long)iocb->ki_obj.user; | 1080 | event->obj = (u64)(unsigned long)iocb->ki_user_iocb; |
| 1069 | event->data = iocb->ki_user_data; | 1081 | event->data = iocb->ki_user_data; |
| 1070 | event->res = res; | 1082 | event->res = res; |
| 1071 | event->res2 = res2; | 1083 | event->res2 = res2; |
| @@ -1074,7 +1086,7 @@ void aio_complete(struct kiocb *iocb, long res, long res2) | |||
| 1074 | flush_dcache_page(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE]); | 1086 | flush_dcache_page(ctx->ring_pages[pos / AIO_EVENTS_PER_PAGE]); |
| 1075 | 1087 | ||
| 1076 | pr_debug("%p[%u]: %p: %p %Lx %lx %lx\n", | 1088 | pr_debug("%p[%u]: %p: %p %Lx %lx %lx\n", |
| 1077 | ctx, tail, iocb, iocb->ki_obj.user, iocb->ki_user_data, | 1089 | ctx, tail, iocb, iocb->ki_user_iocb, iocb->ki_user_data, |
| 1078 | res, res2); | 1090 | res, res2); |
| 1079 | 1091 | ||
| 1080 | /* after flagging the request as done, we | 1092 | /* after flagging the request as done, we |
| @@ -1121,7 +1133,6 @@ void aio_complete(struct kiocb *iocb, long res, long res2) | |||
| 1121 | 1133 | ||
| 1122 | percpu_ref_put(&ctx->reqs); | 1134 | percpu_ref_put(&ctx->reqs); |
| 1123 | } | 1135 | } |
| 1124 | EXPORT_SYMBOL(aio_complete); | ||
| 1125 | 1136 | ||
| 1126 | /* aio_read_events_ring | 1137 | /* aio_read_events_ring |
| 1127 | * Pull an event off of the ioctx's event ring. Returns the number of | 1138 | * Pull an event off of the ioctx's event ring. Returns the number of |
| @@ -1349,46 +1360,19 @@ typedef ssize_t (aio_rw_op)(struct kiocb *, const struct iovec *, | |||
| 1349 | unsigned long, loff_t); | 1360 | unsigned long, loff_t); |
| 1350 | typedef ssize_t (rw_iter_op)(struct kiocb *, struct iov_iter *); | 1361 | typedef ssize_t (rw_iter_op)(struct kiocb *, struct iov_iter *); |
| 1351 | 1362 | ||
| 1352 | static ssize_t aio_setup_vectored_rw(struct kiocb *kiocb, | 1363 | static int aio_setup_vectored_rw(int rw, char __user *buf, size_t len, |
| 1353 | int rw, char __user *buf, | 1364 | struct iovec **iovec, |
| 1354 | unsigned long *nr_segs, | 1365 | bool compat, |
| 1355 | struct iovec **iovec, | 1366 | struct iov_iter *iter) |
| 1356 | bool compat) | ||
| 1357 | { | 1367 | { |
| 1358 | ssize_t ret; | ||
| 1359 | |||
| 1360 | *nr_segs = kiocb->ki_nbytes; | ||
| 1361 | |||
| 1362 | #ifdef CONFIG_COMPAT | 1368 | #ifdef CONFIG_COMPAT |
| 1363 | if (compat) | 1369 | if (compat) |
| 1364 | ret = compat_rw_copy_check_uvector(rw, | 1370 | return compat_import_iovec(rw, |
| 1365 | (struct compat_iovec __user *)buf, | 1371 | (struct compat_iovec __user *)buf, |
| 1366 | *nr_segs, UIO_FASTIOV, *iovec, iovec); | 1372 | len, UIO_FASTIOV, iovec, iter); |
| 1367 | else | ||
| 1368 | #endif | 1373 | #endif |
| 1369 | ret = rw_copy_check_uvector(rw, | 1374 | return import_iovec(rw, (struct iovec __user *)buf, |
| 1370 | (struct iovec __user *)buf, | 1375 | len, UIO_FASTIOV, iovec, iter); |
| 1371 | *nr_segs, UIO_FASTIOV, *iovec, iovec); | ||
| 1372 | if (ret < 0) | ||
| 1373 | return ret; | ||
| 1374 | |||
| 1375 | /* ki_nbytes now reflect bytes instead of segs */ | ||
| 1376 | kiocb->ki_nbytes = ret; | ||
| 1377 | return 0; | ||
| 1378 | } | ||
| 1379 | |||
| 1380 | static ssize_t aio_setup_single_vector(struct kiocb *kiocb, | ||
| 1381 | int rw, char __user *buf, | ||
| 1382 | unsigned long *nr_segs, | ||
| 1383 | struct iovec *iovec) | ||
| 1384 | { | ||
| 1385 | if (unlikely(!access_ok(!rw, buf, kiocb->ki_nbytes))) | ||
| 1386 | return -EFAULT; | ||
| 1387 | |||
| 1388 | iovec->iov_base = buf; | ||
| 1389 | iovec->iov_len = kiocb->ki_nbytes; | ||
| 1390 | *nr_segs = 1; | ||
| 1391 | return 0; | ||
| 1392 | } | 1376 | } |
| 1393 | 1377 | ||
| 1394 | /* | 1378 | /* |
| @@ -1396,11 +1380,10 @@ static ssize_t aio_setup_single_vector(struct kiocb *kiocb, | |||
| 1396 | * Performs the initial checks and io submission. | 1380 | * Performs the initial checks and io submission. |
| 1397 | */ | 1381 | */ |
| 1398 | static ssize_t aio_run_iocb(struct kiocb *req, unsigned opcode, | 1382 | static ssize_t aio_run_iocb(struct kiocb *req, unsigned opcode, |
| 1399 | char __user *buf, bool compat) | 1383 | char __user *buf, size_t len, bool compat) |
| 1400 | { | 1384 | { |
| 1401 | struct file *file = req->ki_filp; | 1385 | struct file *file = req->ki_filp; |
| 1402 | ssize_t ret; | 1386 | ssize_t ret; |
| 1403 | unsigned long nr_segs; | ||
| 1404 | int rw; | 1387 | int rw; |
| 1405 | fmode_t mode; | 1388 | fmode_t mode; |
| 1406 | aio_rw_op *rw_op; | 1389 | aio_rw_op *rw_op; |
| @@ -1431,21 +1414,22 @@ rw_common: | |||
| 1431 | if (!rw_op && !iter_op) | 1414 | if (!rw_op && !iter_op) |
| 1432 | return -EINVAL; | 1415 | return -EINVAL; |
| 1433 | 1416 | ||
| 1434 | ret = (opcode == IOCB_CMD_PREADV || | 1417 | if (opcode == IOCB_CMD_PREADV || opcode == IOCB_CMD_PWRITEV) |
| 1435 | opcode == IOCB_CMD_PWRITEV) | 1418 | ret = aio_setup_vectored_rw(rw, buf, len, |
| 1436 | ? aio_setup_vectored_rw(req, rw, buf, &nr_segs, | 1419 | &iovec, compat, &iter); |
| 1437 | &iovec, compat) | 1420 | else { |
| 1438 | : aio_setup_single_vector(req, rw, buf, &nr_segs, | 1421 | ret = import_single_range(rw, buf, len, iovec, &iter); |
| 1439 | iovec); | 1422 | iovec = NULL; |
| 1423 | } | ||
| 1440 | if (!ret) | 1424 | if (!ret) |
| 1441 | ret = rw_verify_area(rw, file, &req->ki_pos, req->ki_nbytes); | 1425 | ret = rw_verify_area(rw, file, &req->ki_pos, |
| 1426 | iov_iter_count(&iter)); | ||
| 1442 | if (ret < 0) { | 1427 | if (ret < 0) { |
| 1443 | if (iovec != inline_vecs) | 1428 | kfree(iovec); |
| 1444 | kfree(iovec); | ||
| 1445 | return ret; | 1429 | return ret; |
| 1446 | } | 1430 | } |
| 1447 | 1431 | ||
| 1448 | req->ki_nbytes = ret; | 1432 | len = ret; |
| 1449 | 1433 | ||
| 1450 | /* XXX: move/kill - rw_verify_area()? */ | 1434 | /* XXX: move/kill - rw_verify_area()? */ |
| 1451 | /* This matches the pread()/pwrite() logic */ | 1435 | /* This matches the pread()/pwrite() logic */ |
| @@ -1458,14 +1442,14 @@ rw_common: | |||
| 1458 | file_start_write(file); | 1442 | file_start_write(file); |
| 1459 | 1443 | ||
| 1460 | if (iter_op) { | 1444 | if (iter_op) { |
| 1461 | iov_iter_init(&iter, rw, iovec, nr_segs, req->ki_nbytes); | ||
| 1462 | ret = iter_op(req, &iter); | 1445 | ret = iter_op(req, &iter); |
| 1463 | } else { | 1446 | } else { |
| 1464 | ret = rw_op(req, iovec, nr_segs, req->ki_pos); | 1447 | ret = rw_op(req, iter.iov, iter.nr_segs, req->ki_pos); |
| 1465 | } | 1448 | } |
| 1466 | 1449 | ||
| 1467 | if (rw == WRITE) | 1450 | if (rw == WRITE) |
| 1468 | file_end_write(file); | 1451 | file_end_write(file); |
| 1452 | kfree(iovec); | ||
| 1469 | break; | 1453 | break; |
| 1470 | 1454 | ||
| 1471 | case IOCB_CMD_FDSYNC: | 1455 | case IOCB_CMD_FDSYNC: |
| @@ -1487,9 +1471,6 @@ rw_common: | |||
| 1487 | return -EINVAL; | 1471 | return -EINVAL; |
| 1488 | } | 1472 | } |
| 1489 | 1473 | ||
| 1490 | if (iovec != inline_vecs) | ||
| 1491 | kfree(iovec); | ||
| 1492 | |||
| 1493 | if (ret != -EIOCBQUEUED) { | 1474 | if (ret != -EIOCBQUEUED) { |
| 1494 | /* | 1475 | /* |
| 1495 | * There's no easy way to restart the syscall since other AIO's | 1476 | * There's no easy way to restart the syscall since other AIO's |
| @@ -1508,7 +1489,7 @@ rw_common: | |||
| 1508 | static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, | 1489 | static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, |
| 1509 | struct iocb *iocb, bool compat) | 1490 | struct iocb *iocb, bool compat) |
| 1510 | { | 1491 | { |
| 1511 | struct kiocb *req; | 1492 | struct aio_kiocb *req; |
| 1512 | ssize_t ret; | 1493 | ssize_t ret; |
| 1513 | 1494 | ||
| 1514 | /* enforce forwards compatibility on users */ | 1495 | /* enforce forwards compatibility on users */ |
| @@ -1531,11 +1512,14 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, | |||
| 1531 | if (unlikely(!req)) | 1512 | if (unlikely(!req)) |
| 1532 | return -EAGAIN; | 1513 | return -EAGAIN; |
| 1533 | 1514 | ||
| 1534 | req->ki_filp = fget(iocb->aio_fildes); | 1515 | req->common.ki_filp = fget(iocb->aio_fildes); |
| 1535 | if (unlikely(!req->ki_filp)) { | 1516 | if (unlikely(!req->common.ki_filp)) { |
| 1536 | ret = -EBADF; | 1517 | ret = -EBADF; |
| 1537 | goto out_put_req; | 1518 | goto out_put_req; |
| 1538 | } | 1519 | } |
| 1520 | req->common.ki_pos = iocb->aio_offset; | ||
| 1521 | req->common.ki_complete = aio_complete; | ||
| 1522 | req->common.ki_flags = 0; | ||
| 1539 | 1523 | ||
| 1540 | if (iocb->aio_flags & IOCB_FLAG_RESFD) { | 1524 | if (iocb->aio_flags & IOCB_FLAG_RESFD) { |
| 1541 | /* | 1525 | /* |
| @@ -1550,6 +1534,8 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, | |||
| 1550 | req->ki_eventfd = NULL; | 1534 | req->ki_eventfd = NULL; |
| 1551 | goto out_put_req; | 1535 | goto out_put_req; |
| 1552 | } | 1536 | } |
| 1537 | |||
| 1538 | req->common.ki_flags |= IOCB_EVENTFD; | ||
| 1553 | } | 1539 | } |
| 1554 | 1540 | ||
| 1555 | ret = put_user(KIOCB_KEY, &user_iocb->aio_key); | 1541 | ret = put_user(KIOCB_KEY, &user_iocb->aio_key); |
| @@ -1558,13 +1544,12 @@ static int io_submit_one(struct kioctx *ctx, struct iocb __user *user_iocb, | |||
| 1558 | goto out_put_req; | 1544 | goto out_put_req; |
| 1559 | } | 1545 | } |
| 1560 | 1546 | ||
| 1561 | req->ki_obj.user = user_iocb; | 1547 | req->ki_user_iocb = user_iocb; |
| 1562 | req->ki_user_data = iocb->aio_data; | 1548 | req->ki_user_data = iocb->aio_data; |
| 1563 | req->ki_pos = iocb->aio_offset; | ||
| 1564 | req->ki_nbytes = iocb->aio_nbytes; | ||
| 1565 | 1549 | ||
| 1566 | ret = aio_run_iocb(req, iocb->aio_lio_opcode, | 1550 | ret = aio_run_iocb(&req->common, iocb->aio_lio_opcode, |
| 1567 | (char __user *)(unsigned long)iocb->aio_buf, | 1551 | (char __user *)(unsigned long)iocb->aio_buf, |
| 1552 | iocb->aio_nbytes, | ||
| 1568 | compat); | 1553 | compat); |
| 1569 | if (ret) | 1554 | if (ret) |
| 1570 | goto out_put_req; | 1555 | goto out_put_req; |
| @@ -1651,10 +1636,10 @@ SYSCALL_DEFINE3(io_submit, aio_context_t, ctx_id, long, nr, | |||
| 1651 | /* lookup_kiocb | 1636 | /* lookup_kiocb |
| 1652 | * Finds a given iocb for cancellation. | 1637 | * Finds a given iocb for cancellation. |
| 1653 | */ | 1638 | */ |
| 1654 | static struct kiocb *lookup_kiocb(struct kioctx *ctx, struct iocb __user *iocb, | 1639 | static struct aio_kiocb * |
| 1655 | u32 key) | 1640 | lookup_kiocb(struct kioctx *ctx, struct iocb __user *iocb, u32 key) |
| 1656 | { | 1641 | { |
| 1657 | struct list_head *pos; | 1642 | struct aio_kiocb *kiocb; |
| 1658 | 1643 | ||
| 1659 | assert_spin_locked(&ctx->ctx_lock); | 1644 | assert_spin_locked(&ctx->ctx_lock); |
| 1660 | 1645 | ||
| @@ -1662,9 +1647,8 @@ static struct kiocb *lookup_kiocb(struct kioctx *ctx, struct iocb __user *iocb, | |||
| 1662 | return NULL; | 1647 | return NULL; |
| 1663 | 1648 | ||
| 1664 | /* TODO: use a hash or array, this sucks. */ | 1649 | /* TODO: use a hash or array, this sucks. */ |
| 1665 | list_for_each(pos, &ctx->active_reqs) { | 1650 | list_for_each_entry(kiocb, &ctx->active_reqs, ki_list) { |
| 1666 | struct kiocb *kiocb = list_kiocb(pos); | 1651 | if (kiocb->ki_user_iocb == iocb) |
| 1667 | if (kiocb->ki_obj.user == iocb) | ||
| 1668 | return kiocb; | 1652 | return kiocb; |
| 1669 | } | 1653 | } |
| 1670 | return NULL; | 1654 | return NULL; |
| @@ -1684,7 +1668,7 @@ SYSCALL_DEFINE3(io_cancel, aio_context_t, ctx_id, struct iocb __user *, iocb, | |||
| 1684 | struct io_event __user *, result) | 1668 | struct io_event __user *, result) |
| 1685 | { | 1669 | { |
| 1686 | struct kioctx *ctx; | 1670 | struct kioctx *ctx; |
| 1687 | struct kiocb *kiocb; | 1671 | struct aio_kiocb *kiocb; |
| 1688 | u32 key; | 1672 | u32 key; |
| 1689 | int ret; | 1673 | int ret; |
| 1690 | 1674 | ||
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c index 90bc079d9982..fdcb4d69f430 100644 --- a/fs/bfs/inode.c +++ b/fs/bfs/inode.c | |||
| @@ -15,6 +15,7 @@ | |||
| 15 | #include <linux/buffer_head.h> | 15 | #include <linux/buffer_head.h> |
| 16 | #include <linux/vfs.h> | 16 | #include <linux/vfs.h> |
| 17 | #include <linux/writeback.h> | 17 | #include <linux/writeback.h> |
| 18 | #include <linux/uio.h> | ||
| 18 | #include <asm/uaccess.h> | 19 | #include <asm/uaccess.h> |
| 19 | #include "bfs.h" | 20 | #include "bfs.h" |
| 20 | 21 | ||
diff --git a/fs/block_dev.c b/fs/block_dev.c index 975266be67d3..2e522aed6584 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c | |||
| @@ -27,7 +27,6 @@ | |||
| 27 | #include <linux/namei.h> | 27 | #include <linux/namei.h> |
| 28 | #include <linux/log2.h> | 28 | #include <linux/log2.h> |
| 29 | #include <linux/cleancache.h> | 29 | #include <linux/cleancache.h> |
| 30 | #include <linux/aio.h> | ||
| 31 | #include <asm/uaccess.h> | 30 | #include <asm/uaccess.h> |
| 32 | #include "internal.h" | 31 | #include "internal.h" |
| 33 | 32 | ||
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index 30982bbd31c3..aee18f84e315 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c | |||
| @@ -24,7 +24,6 @@ | |||
| 24 | #include <linux/string.h> | 24 | #include <linux/string.h> |
| 25 | #include <linux/backing-dev.h> | 25 | #include <linux/backing-dev.h> |
| 26 | #include <linux/mpage.h> | 26 | #include <linux/mpage.h> |
| 27 | #include <linux/aio.h> | ||
| 28 | #include <linux/falloc.h> | 27 | #include <linux/falloc.h> |
| 29 | #include <linux/swap.h> | 28 | #include <linux/swap.h> |
| 30 | #include <linux/writeback.h> | 29 | #include <linux/writeback.h> |
| @@ -32,6 +31,7 @@ | |||
| 32 | #include <linux/compat.h> | 31 | #include <linux/compat.h> |
| 33 | #include <linux/slab.h> | 32 | #include <linux/slab.h> |
| 34 | #include <linux/btrfs.h> | 33 | #include <linux/btrfs.h> |
| 34 | #include <linux/uio.h> | ||
| 35 | #include "ctree.h" | 35 | #include "ctree.h" |
| 36 | #include "disk-io.h" | 36 | #include "disk-io.h" |
| 37 | #include "transaction.h" | 37 | #include "transaction.h" |
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index d2e732d7af52..686331f22b15 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c | |||
| @@ -32,7 +32,6 @@ | |||
| 32 | #include <linux/writeback.h> | 32 | #include <linux/writeback.h> |
| 33 | #include <linux/statfs.h> | 33 | #include <linux/statfs.h> |
| 34 | #include <linux/compat.h> | 34 | #include <linux/compat.h> |
| 35 | #include <linux/aio.h> | ||
| 36 | #include <linux/bit_spinlock.h> | 35 | #include <linux/bit_spinlock.h> |
| 37 | #include <linux/xattr.h> | 36 | #include <linux/xattr.h> |
| 38 | #include <linux/posix_acl.h> | 37 | #include <linux/posix_acl.h> |
| @@ -43,6 +42,7 @@ | |||
| 43 | #include <linux/btrfs.h> | 42 | #include <linux/btrfs.h> |
| 44 | #include <linux/blkdev.h> | 43 | #include <linux/blkdev.h> |
| 45 | #include <linux/posix_acl_xattr.h> | 44 | #include <linux/posix_acl_xattr.h> |
| 45 | #include <linux/uio.h> | ||
| 46 | #include "ctree.h" | 46 | #include "ctree.h" |
| 47 | #include "disk-io.h" | 47 | #include "disk-io.h" |
| 48 | #include "transaction.h" | 48 | #include "transaction.h" |
diff --git a/fs/ceph/file.c b/fs/ceph/file.c index d533075a823d..139f2fea91a0 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c | |||
| @@ -7,7 +7,6 @@ | |||
| 7 | #include <linux/mount.h> | 7 | #include <linux/mount.h> |
| 8 | #include <linux/namei.h> | 8 | #include <linux/namei.h> |
| 9 | #include <linux/writeback.h> | 9 | #include <linux/writeback.h> |
| 10 | #include <linux/aio.h> | ||
| 11 | #include <linux/falloc.h> | 10 | #include <linux/falloc.h> |
| 12 | 11 | ||
| 13 | #include "super.h" | 12 | #include "super.h" |
| @@ -808,7 +807,7 @@ static ssize_t ceph_read_iter(struct kiocb *iocb, struct iov_iter *to) | |||
| 808 | { | 807 | { |
| 809 | struct file *filp = iocb->ki_filp; | 808 | struct file *filp = iocb->ki_filp; |
| 810 | struct ceph_file_info *fi = filp->private_data; | 809 | struct ceph_file_info *fi = filp->private_data; |
| 811 | size_t len = iocb->ki_nbytes; | 810 | size_t len = iov_iter_count(to); |
| 812 | struct inode *inode = file_inode(filp); | 811 | struct inode *inode = file_inode(filp); |
| 813 | struct ceph_inode_info *ci = ceph_inode(inode); | 812 | struct ceph_inode_info *ci = ceph_inode(inode); |
| 814 | struct page *pinned_page = NULL; | 813 | struct page *pinned_page = NULL; |
diff --git a/fs/dcache.c b/fs/dcache.c index c71e3732e53b..d99736a63e3c 100644 --- a/fs/dcache.c +++ b/fs/dcache.c | |||
| @@ -2690,7 +2690,7 @@ static int __d_unalias(struct inode *inode, | |||
| 2690 | struct dentry *dentry, struct dentry *alias) | 2690 | struct dentry *dentry, struct dentry *alias) |
| 2691 | { | 2691 | { |
| 2692 | struct mutex *m1 = NULL, *m2 = NULL; | 2692 | struct mutex *m1 = NULL, *m2 = NULL; |
| 2693 | int ret = -EBUSY; | 2693 | int ret = -ESTALE; |
| 2694 | 2694 | ||
| 2695 | /* If alias and dentry share a parent, then no extra locks required */ | 2695 | /* If alias and dentry share a parent, then no extra locks required */ |
| 2696 | if (alias->d_parent == dentry->d_parent) | 2696 | if (alias->d_parent == dentry->d_parent) |
diff --git a/fs/direct-io.c b/fs/direct-io.c index e181b6b2e297..6fb00e3f1059 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c | |||
| @@ -37,7 +37,6 @@ | |||
| 37 | #include <linux/uio.h> | 37 | #include <linux/uio.h> |
| 38 | #include <linux/atomic.h> | 38 | #include <linux/atomic.h> |
| 39 | #include <linux/prefetch.h> | 39 | #include <linux/prefetch.h> |
| 40 | #include <linux/aio.h> | ||
| 41 | 40 | ||
| 42 | /* | 41 | /* |
| 43 | * How many user pages to map in one call to get_user_pages(). This determines | 42 | * How many user pages to map in one call to get_user_pages(). This determines |
| @@ -265,7 +264,7 @@ static ssize_t dio_complete(struct dio *dio, loff_t offset, ssize_t ret, | |||
| 265 | ret = err; | 264 | ret = err; |
| 266 | } | 265 | } |
| 267 | 266 | ||
| 268 | aio_complete(dio->iocb, ret, 0); | 267 | dio->iocb->ki_complete(dio->iocb, ret, 0); |
| 269 | } | 268 | } |
| 270 | 269 | ||
| 271 | kmem_cache_free(dio_cache, dio); | 270 | kmem_cache_free(dio_cache, dio); |
| @@ -1056,7 +1055,7 @@ static inline int drop_refcount(struct dio *dio) | |||
| 1056 | * operation. AIO can if it was a broken operation described above or | 1055 | * operation. AIO can if it was a broken operation described above or |
| 1057 | * in fact if all the bios race to complete before we get here. In | 1056 | * in fact if all the bios race to complete before we get here. In |
| 1058 | * that case dio_complete() translates the EIOCBQUEUED into the proper | 1057 | * that case dio_complete() translates the EIOCBQUEUED into the proper |
| 1059 | * return code that the caller will hand to aio_complete(). | 1058 | * return code that the caller will hand to ->complete(). |
| 1060 | * | 1059 | * |
| 1061 | * This is managed by the bio_lock instead of being an atomic_t so that | 1060 | * This is managed by the bio_lock instead of being an atomic_t so that |
| 1062 | * completion paths can drop their ref and use the remaining count to | 1061 | * completion paths can drop their ref and use the remaining count to |
diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/file.c index fd39bad6f1bd..79675089443d 100644 --- a/fs/ecryptfs/file.c +++ b/fs/ecryptfs/file.c | |||
| @@ -31,7 +31,6 @@ | |||
| 31 | #include <linux/security.h> | 31 | #include <linux/security.h> |
| 32 | #include <linux/compat.h> | 32 | #include <linux/compat.h> |
| 33 | #include <linux/fs_stack.h> | 33 | #include <linux/fs_stack.h> |
| 34 | #include <linux/aio.h> | ||
| 35 | #include "ecryptfs_kernel.h" | 34 | #include "ecryptfs_kernel.h" |
| 36 | 35 | ||
| 37 | /** | 36 | /** |
| @@ -52,12 +51,6 @@ static ssize_t ecryptfs_read_update_atime(struct kiocb *iocb, | |||
| 52 | struct file *file = iocb->ki_filp; | 51 | struct file *file = iocb->ki_filp; |
| 53 | 52 | ||
| 54 | rc = generic_file_read_iter(iocb, to); | 53 | rc = generic_file_read_iter(iocb, to); |
| 55 | /* | ||
| 56 | * Even though this is a async interface, we need to wait | ||
| 57 | * for IO to finish to update atime | ||
| 58 | */ | ||
| 59 | if (-EIOCBQUEUED == rc) | ||
| 60 | rc = wait_on_sync_kiocb(iocb); | ||
| 61 | if (rc >= 0) { | 54 | if (rc >= 0) { |
| 62 | path = ecryptfs_dentry_to_lower_path(file->f_path.dentry); | 55 | path = ecryptfs_dentry_to_lower_path(file->f_path.dentry); |
| 63 | touch_atime(path); | 56 | touch_atime(path); |
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c index 6434bc000125..df9d6afbc5d5 100644 --- a/fs/ext2/inode.c +++ b/fs/ext2/inode.c | |||
| @@ -31,7 +31,7 @@ | |||
| 31 | #include <linux/mpage.h> | 31 | #include <linux/mpage.h> |
| 32 | #include <linux/fiemap.h> | 32 | #include <linux/fiemap.h> |
| 33 | #include <linux/namei.h> | 33 | #include <linux/namei.h> |
| 34 | #include <linux/aio.h> | 34 | #include <linux/uio.h> |
| 35 | #include "ext2.h" | 35 | #include "ext2.h" |
| 36 | #include "acl.h" | 36 | #include "acl.h" |
| 37 | #include "xattr.h" | 37 | #include "xattr.h" |
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index 2c6ccc49ba27..db07ffbe7c85 100644 --- a/fs/ext3/inode.c +++ b/fs/ext3/inode.c | |||
| @@ -27,7 +27,7 @@ | |||
| 27 | #include <linux/writeback.h> | 27 | #include <linux/writeback.h> |
| 28 | #include <linux/mpage.h> | 28 | #include <linux/mpage.h> |
| 29 | #include <linux/namei.h> | 29 | #include <linux/namei.h> |
| 30 | #include <linux/aio.h> | 30 | #include <linux/uio.h> |
| 31 | #include "ext3.h" | 31 | #include "ext3.h" |
| 32 | #include "xattr.h" | 32 | #include "xattr.h" |
| 33 | #include "acl.h" | 33 | #include "acl.h" |
diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 33a09da16c9c..598abbbe6786 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c | |||
| @@ -23,9 +23,9 @@ | |||
| 23 | #include <linux/jbd2.h> | 23 | #include <linux/jbd2.h> |
| 24 | #include <linux/mount.h> | 24 | #include <linux/mount.h> |
| 25 | #include <linux/path.h> | 25 | #include <linux/path.h> |
| 26 | #include <linux/aio.h> | ||
| 27 | #include <linux/quotaops.h> | 26 | #include <linux/quotaops.h> |
| 28 | #include <linux/pagevec.h> | 27 | #include <linux/pagevec.h> |
| 28 | #include <linux/uio.h> | ||
| 29 | #include "ext4.h" | 29 | #include "ext4.h" |
| 30 | #include "ext4_jbd2.h" | 30 | #include "ext4_jbd2.h" |
| 31 | #include "xattr.h" | 31 | #include "xattr.h" |
diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c index 45fe924f82bc..740c7871c117 100644 --- a/fs/ext4/indirect.c +++ b/fs/ext4/indirect.c | |||
| @@ -20,9 +20,9 @@ | |||
| 20 | * (sct@redhat.com), 1993, 1998 | 20 | * (sct@redhat.com), 1993, 1998 |
| 21 | */ | 21 | */ |
| 22 | 22 | ||
| 23 | #include <linux/aio.h> | ||
| 24 | #include "ext4_jbd2.h" | 23 | #include "ext4_jbd2.h" |
| 25 | #include "truncate.h" | 24 | #include "truncate.h" |
| 25 | #include <linux/uio.h> | ||
| 26 | 26 | ||
| 27 | #include <trace/events/ext4.h> | 27 | #include <trace/events/ext4.h> |
| 28 | 28 | ||
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 5cb9a212b86f..a3f451370bef 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c | |||
| @@ -37,7 +37,6 @@ | |||
| 37 | #include <linux/printk.h> | 37 | #include <linux/printk.h> |
| 38 | #include <linux/slab.h> | 38 | #include <linux/slab.h> |
| 39 | #include <linux/ratelimit.h> | 39 | #include <linux/ratelimit.h> |
| 40 | #include <linux/aio.h> | ||
| 41 | #include <linux/bitops.h> | 40 | #include <linux/bitops.h> |
| 42 | 41 | ||
| 43 | #include "ext4_jbd2.h" | 42 | #include "ext4_jbd2.h" |
diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index b24a2541a9ba..464984261e69 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c | |||
| @@ -18,7 +18,6 @@ | |||
| 18 | #include <linux/pagevec.h> | 18 | #include <linux/pagevec.h> |
| 19 | #include <linux/mpage.h> | 19 | #include <linux/mpage.h> |
| 20 | #include <linux/namei.h> | 20 | #include <linux/namei.h> |
| 21 | #include <linux/aio.h> | ||
| 22 | #include <linux/uio.h> | 21 | #include <linux/uio.h> |
| 23 | #include <linux/bio.h> | 22 | #include <linux/bio.h> |
| 24 | #include <linux/workqueue.h> | 23 | #include <linux/workqueue.h> |
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 985ed023a750..497f8515d205 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c | |||
| @@ -12,12 +12,12 @@ | |||
| 12 | #include <linux/f2fs_fs.h> | 12 | #include <linux/f2fs_fs.h> |
| 13 | #include <linux/buffer_head.h> | 13 | #include <linux/buffer_head.h> |
| 14 | #include <linux/mpage.h> | 14 | #include <linux/mpage.h> |
| 15 | #include <linux/aio.h> | ||
| 16 | #include <linux/writeback.h> | 15 | #include <linux/writeback.h> |
| 17 | #include <linux/backing-dev.h> | 16 | #include <linux/backing-dev.h> |
| 18 | #include <linux/blkdev.h> | 17 | #include <linux/blkdev.h> |
| 19 | #include <linux/bio.h> | 18 | #include <linux/bio.h> |
| 20 | #include <linux/prefetch.h> | 19 | #include <linux/prefetch.h> |
| 20 | #include <linux/uio.h> | ||
| 21 | 21 | ||
| 22 | #include "f2fs.h" | 22 | #include "f2fs.h" |
| 23 | #include "node.h" | 23 | #include "node.h" |
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 497c7c5263c7..8521207de229 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c | |||
| @@ -19,7 +19,6 @@ | |||
| 19 | #include <linux/mpage.h> | 19 | #include <linux/mpage.h> |
| 20 | #include <linux/buffer_head.h> | 20 | #include <linux/buffer_head.h> |
| 21 | #include <linux/mount.h> | 21 | #include <linux/mount.h> |
| 22 | #include <linux/aio.h> | ||
| 23 | #include <linux/vfs.h> | 22 | #include <linux/vfs.h> |
| 24 | #include <linux/parser.h> | 23 | #include <linux/parser.h> |
| 25 | #include <linux/uio.h> | 24 | #include <linux/uio.h> |
diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c index 28d0c7abba1c..b3fa05032234 100644 --- a/fs/fuse/cuse.c +++ b/fs/fuse/cuse.c | |||
| @@ -38,7 +38,6 @@ | |||
| 38 | #include <linux/device.h> | 38 | #include <linux/device.h> |
| 39 | #include <linux/file.h> | 39 | #include <linux/file.h> |
| 40 | #include <linux/fs.h> | 40 | #include <linux/fs.h> |
| 41 | #include <linux/aio.h> | ||
| 42 | #include <linux/kdev_t.h> | 41 | #include <linux/kdev_t.h> |
| 43 | #include <linux/kthread.h> | 42 | #include <linux/kthread.h> |
| 44 | #include <linux/list.h> | 43 | #include <linux/list.h> |
| @@ -48,6 +47,7 @@ | |||
| 48 | #include <linux/slab.h> | 47 | #include <linux/slab.h> |
| 49 | #include <linux/stat.h> | 48 | #include <linux/stat.h> |
| 50 | #include <linux/module.h> | 49 | #include <linux/module.h> |
| 50 | #include <linux/uio.h> | ||
| 51 | 51 | ||
| 52 | #include "fuse_i.h" | 52 | #include "fuse_i.h" |
| 53 | 53 | ||
diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index 39706c57ad3c..95a2797eef66 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c | |||
| @@ -19,7 +19,6 @@ | |||
| 19 | #include <linux/pipe_fs_i.h> | 19 | #include <linux/pipe_fs_i.h> |
| 20 | #include <linux/swap.h> | 20 | #include <linux/swap.h> |
| 21 | #include <linux/splice.h> | 21 | #include <linux/splice.h> |
| 22 | #include <linux/aio.h> | ||
| 23 | 22 | ||
| 24 | MODULE_ALIAS_MISCDEV(FUSE_MINOR); | 23 | MODULE_ALIAS_MISCDEV(FUSE_MINOR); |
| 25 | MODULE_ALIAS("devname:fuse"); | 24 | MODULE_ALIAS("devname:fuse"); |
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index c01ec3bdcfd8..ff102cbf16ea 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c | |||
| @@ -15,8 +15,8 @@ | |||
| 15 | #include <linux/module.h> | 15 | #include <linux/module.h> |
| 16 | #include <linux/compat.h> | 16 | #include <linux/compat.h> |
| 17 | #include <linux/swap.h> | 17 | #include <linux/swap.h> |
| 18 | #include <linux/aio.h> | ||
| 19 | #include <linux/falloc.h> | 18 | #include <linux/falloc.h> |
| 19 | #include <linux/uio.h> | ||
| 20 | 20 | ||
| 21 | static const struct file_operations fuse_direct_io_file_operations; | 21 | static const struct file_operations fuse_direct_io_file_operations; |
| 22 | 22 | ||
| @@ -528,6 +528,17 @@ static void fuse_release_user_pages(struct fuse_req *req, int write) | |||
| 528 | } | 528 | } |
| 529 | } | 529 | } |
| 530 | 530 | ||
| 531 | static ssize_t fuse_get_res_by_io(struct fuse_io_priv *io) | ||
| 532 | { | ||
| 533 | if (io->err) | ||
| 534 | return io->err; | ||
| 535 | |||
| 536 | if (io->bytes >= 0 && io->write) | ||
| 537 | return -EIO; | ||
| 538 | |||
| 539 | return io->bytes < 0 ? io->size : io->bytes; | ||
| 540 | } | ||
| 541 | |||
| 531 | /** | 542 | /** |
| 532 | * In case of short read, the caller sets 'pos' to the position of | 543 | * In case of short read, the caller sets 'pos' to the position of |
| 533 | * actual end of fuse request in IO request. Otherwise, if bytes_requested | 544 | * actual end of fuse request in IO request. Otherwise, if bytes_requested |
| @@ -546,6 +557,7 @@ static void fuse_release_user_pages(struct fuse_req *req, int write) | |||
| 546 | */ | 557 | */ |
| 547 | static void fuse_aio_complete(struct fuse_io_priv *io, int err, ssize_t pos) | 558 | static void fuse_aio_complete(struct fuse_io_priv *io, int err, ssize_t pos) |
| 548 | { | 559 | { |
| 560 | bool is_sync = is_sync_kiocb(io->iocb); | ||
| 549 | int left; | 561 | int left; |
| 550 | 562 | ||
| 551 | spin_lock(&io->lock); | 563 | spin_lock(&io->lock); |
| @@ -555,30 +567,24 @@ static void fuse_aio_complete(struct fuse_io_priv *io, int err, ssize_t pos) | |||
| 555 | io->bytes = pos; | 567 | io->bytes = pos; |
| 556 | 568 | ||
| 557 | left = --io->reqs; | 569 | left = --io->reqs; |
| 570 | if (!left && is_sync) | ||
| 571 | complete(io->done); | ||
| 558 | spin_unlock(&io->lock); | 572 | spin_unlock(&io->lock); |
| 559 | 573 | ||
| 560 | if (!left) { | 574 | if (!left && !is_sync) { |
| 561 | long res; | 575 | ssize_t res = fuse_get_res_by_io(io); |
| 562 | 576 | ||
| 563 | if (io->err) | 577 | if (res >= 0) { |
| 564 | res = io->err; | 578 | struct inode *inode = file_inode(io->iocb->ki_filp); |
| 565 | else if (io->bytes >= 0 && io->write) | 579 | struct fuse_conn *fc = get_fuse_conn(inode); |
| 566 | res = -EIO; | 580 | struct fuse_inode *fi = get_fuse_inode(inode); |
| 567 | else { | ||
| 568 | res = io->bytes < 0 ? io->size : io->bytes; | ||
| 569 | 581 | ||
| 570 | if (!is_sync_kiocb(io->iocb)) { | 582 | spin_lock(&fc->lock); |
| 571 | struct inode *inode = file_inode(io->iocb->ki_filp); | 583 | fi->attr_version = ++fc->attr_version; |
| 572 | struct fuse_conn *fc = get_fuse_conn(inode); | 584 | spin_unlock(&fc->lock); |
| 573 | struct fuse_inode *fi = get_fuse_inode(inode); | ||
| 574 | |||
| 575 | spin_lock(&fc->lock); | ||
| 576 | fi->attr_version = ++fc->attr_version; | ||
| 577 | spin_unlock(&fc->lock); | ||
| 578 | } | ||
| 579 | } | 585 | } |
| 580 | 586 | ||
| 581 | aio_complete(io->iocb, res, 0); | 587 | io->iocb->ki_complete(io->iocb, res, 0); |
| 582 | kfree(io); | 588 | kfree(io); |
| 583 | } | 589 | } |
| 584 | } | 590 | } |
| @@ -2801,6 +2807,7 @@ static ssize_t | |||
| 2801 | fuse_direct_IO(int rw, struct kiocb *iocb, struct iov_iter *iter, | 2807 | fuse_direct_IO(int rw, struct kiocb *iocb, struct iov_iter *iter, |
| 2802 | loff_t offset) | 2808 | loff_t offset) |
| 2803 | { | 2809 | { |
| 2810 | DECLARE_COMPLETION_ONSTACK(wait); | ||
| 2804 | ssize_t ret = 0; | 2811 | ssize_t ret = 0; |
| 2805 | struct file *file = iocb->ki_filp; | 2812 | struct file *file = iocb->ki_filp; |
| 2806 | struct fuse_file *ff = file->private_data; | 2813 | struct fuse_file *ff = file->private_data; |
| @@ -2852,6 +2859,9 @@ fuse_direct_IO(int rw, struct kiocb *iocb, struct iov_iter *iter, | |||
| 2852 | if (!is_sync_kiocb(iocb) && (offset + count > i_size) && rw == WRITE) | 2859 | if (!is_sync_kiocb(iocb) && (offset + count > i_size) && rw == WRITE) |
| 2853 | io->async = false; | 2860 | io->async = false; |
| 2854 | 2861 | ||
| 2862 | if (io->async && is_sync_kiocb(iocb)) | ||
| 2863 | io->done = &wait; | ||
| 2864 | |||
| 2855 | if (rw == WRITE) | 2865 | if (rw == WRITE) |
| 2856 | ret = __fuse_direct_write(io, iter, &pos); | 2866 | ret = __fuse_direct_write(io, iter, &pos); |
| 2857 | else | 2867 | else |
| @@ -2864,11 +2874,12 @@ fuse_direct_IO(int rw, struct kiocb *iocb, struct iov_iter *iter, | |||
| 2864 | if (!is_sync_kiocb(iocb)) | 2874 | if (!is_sync_kiocb(iocb)) |
| 2865 | return -EIOCBQUEUED; | 2875 | return -EIOCBQUEUED; |
| 2866 | 2876 | ||
| 2867 | ret = wait_on_sync_kiocb(iocb); | 2877 | wait_for_completion(&wait); |
| 2868 | } else { | 2878 | ret = fuse_get_res_by_io(io); |
| 2869 | kfree(io); | ||
| 2870 | } | 2879 | } |
| 2871 | 2880 | ||
| 2881 | kfree(io); | ||
| 2882 | |||
| 2872 | if (rw == WRITE) { | 2883 | if (rw == WRITE) { |
| 2873 | if (ret > 0) | 2884 | if (ret > 0) |
| 2874 | fuse_write_update_size(inode, pos); | 2885 | fuse_write_update_size(inode, pos); |
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index 1cdfb07c1376..7354dc142a50 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h | |||
| @@ -263,6 +263,7 @@ struct fuse_io_priv { | |||
| 263 | int err; | 263 | int err; |
| 264 | struct kiocb *iocb; | 264 | struct kiocb *iocb; |
| 265 | struct file *file; | 265 | struct file *file; |
| 266 | struct completion *done; | ||
| 266 | }; | 267 | }; |
| 267 | 268 | ||
| 268 | /** | 269 | /** |
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 4ad4f94edebe..fe6634d25d1d 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c | |||
| @@ -20,7 +20,7 @@ | |||
| 20 | #include <linux/swap.h> | 20 | #include <linux/swap.h> |
| 21 | #include <linux/gfs2_ondisk.h> | 21 | #include <linux/gfs2_ondisk.h> |
| 22 | #include <linux/backing-dev.h> | 22 | #include <linux/backing-dev.h> |
| 23 | #include <linux/aio.h> | 23 | #include <linux/uio.h> |
| 24 | #include <trace/events/writeback.h> | 24 | #include <trace/events/writeback.h> |
| 25 | 25 | ||
| 26 | #include "gfs2.h" | 26 | #include "gfs2.h" |
diff --git a/fs/gfs2/file.c b/fs/gfs2/file.c index 3e32bb8e2d7e..f6fc412b1100 100644 --- a/fs/gfs2/file.c +++ b/fs/gfs2/file.c | |||
| @@ -25,7 +25,6 @@ | |||
| 25 | #include <asm/uaccess.h> | 25 | #include <asm/uaccess.h> |
| 26 | #include <linux/dlm.h> | 26 | #include <linux/dlm.h> |
| 27 | #include <linux/dlm_plock.h> | 27 | #include <linux/dlm_plock.h> |
| 28 | #include <linux/aio.h> | ||
| 29 | #include <linux/delay.h> | 28 | #include <linux/delay.h> |
| 30 | 29 | ||
| 31 | #include "gfs2.h" | 30 | #include "gfs2.h" |
diff --git a/fs/hfs/inode.c b/fs/hfs/inode.c index d0929bc81782..98d4ea45bb70 100644 --- a/fs/hfs/inode.c +++ b/fs/hfs/inode.c | |||
| @@ -14,7 +14,7 @@ | |||
| 14 | #include <linux/pagemap.h> | 14 | #include <linux/pagemap.h> |
| 15 | #include <linux/mpage.h> | 15 | #include <linux/mpage.h> |
| 16 | #include <linux/sched.h> | 16 | #include <linux/sched.h> |
| 17 | #include <linux/aio.h> | 17 | #include <linux/uio.h> |
| 18 | 18 | ||
| 19 | #include "hfs_fs.h" | 19 | #include "hfs_fs.h" |
| 20 | #include "btree.h" | 20 | #include "btree.h" |
diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c index 0cf786f2d046..f541196d4ee9 100644 --- a/fs/hfsplus/inode.c +++ b/fs/hfsplus/inode.c | |||
| @@ -14,7 +14,7 @@ | |||
| 14 | #include <linux/pagemap.h> | 14 | #include <linux/pagemap.h> |
| 15 | #include <linux/mpage.h> | 15 | #include <linux/mpage.h> |
| 16 | #include <linux/sched.h> | 16 | #include <linux/sched.h> |
| 17 | #include <linux/aio.h> | 17 | #include <linux/uio.h> |
| 18 | 18 | ||
| 19 | #include "hfsplus_fs.h" | 19 | #include "hfsplus_fs.h" |
| 20 | #include "hfsplus_raw.h" | 20 | #include "hfsplus_raw.h" |
diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c index bd3df1ca3c9b..3197aed10614 100644 --- a/fs/jfs/inode.c +++ b/fs/jfs/inode.c | |||
| @@ -22,8 +22,8 @@ | |||
| 22 | #include <linux/buffer_head.h> | 22 | #include <linux/buffer_head.h> |
| 23 | #include <linux/pagemap.h> | 23 | #include <linux/pagemap.h> |
| 24 | #include <linux/quotaops.h> | 24 | #include <linux/quotaops.h> |
| 25 | #include <linux/uio.h> | ||
| 25 | #include <linux/writeback.h> | 26 | #include <linux/writeback.h> |
| 26 | #include <linux/aio.h> | ||
| 27 | #include "jfs_incore.h" | 27 | #include "jfs_incore.h" |
| 28 | #include "jfs_inode.h" | 28 | #include "jfs_inode.h" |
| 29 | #include "jfs_filsys.h" | 29 | #include "jfs_filsys.h" |
diff --git a/fs/namei.c b/fs/namei.c index c83145af4bfc..76fb76a0818b 100644 --- a/fs/namei.c +++ b/fs/namei.c | |||
| @@ -119,15 +119,14 @@ | |||
| 119 | * PATH_MAX includes the nul terminator --RR. | 119 | * PATH_MAX includes the nul terminator --RR. |
| 120 | */ | 120 | */ |
| 121 | 121 | ||
| 122 | #define EMBEDDED_NAME_MAX (PATH_MAX - sizeof(struct filename)) | 122 | #define EMBEDDED_NAME_MAX (PATH_MAX - offsetof(struct filename, iname)) |
| 123 | 123 | ||
| 124 | struct filename * | 124 | struct filename * |
| 125 | getname_flags(const char __user *filename, int flags, int *empty) | 125 | getname_flags(const char __user *filename, int flags, int *empty) |
| 126 | { | 126 | { |
| 127 | struct filename *result, *err; | 127 | struct filename *result; |
| 128 | int len; | ||
| 129 | long max; | ||
| 130 | char *kname; | 128 | char *kname; |
| 129 | int len; | ||
| 131 | 130 | ||
| 132 | result = audit_reusename(filename); | 131 | result = audit_reusename(filename); |
| 133 | if (result) | 132 | if (result) |
| @@ -136,22 +135,18 @@ getname_flags(const char __user *filename, int flags, int *empty) | |||
| 136 | result = __getname(); | 135 | result = __getname(); |
| 137 | if (unlikely(!result)) | 136 | if (unlikely(!result)) |
| 138 | return ERR_PTR(-ENOMEM); | 137 | return ERR_PTR(-ENOMEM); |
| 139 | result->refcnt = 1; | ||
| 140 | 138 | ||
| 141 | /* | 139 | /* |
| 142 | * First, try to embed the struct filename inside the names_cache | 140 | * First, try to embed the struct filename inside the names_cache |
| 143 | * allocation | 141 | * allocation |
| 144 | */ | 142 | */ |
| 145 | kname = (char *)result + sizeof(*result); | 143 | kname = (char *)result->iname; |
| 146 | result->name = kname; | 144 | result->name = kname; |
| 147 | result->separate = false; | ||
| 148 | max = EMBEDDED_NAME_MAX; | ||
| 149 | 145 | ||
| 150 | recopy: | 146 | len = strncpy_from_user(kname, filename, EMBEDDED_NAME_MAX); |
| 151 | len = strncpy_from_user(kname, filename, max); | ||
| 152 | if (unlikely(len < 0)) { | 147 | if (unlikely(len < 0)) { |
| 153 | err = ERR_PTR(len); | 148 | __putname(result); |
| 154 | goto error; | 149 | return ERR_PTR(len); |
| 155 | } | 150 | } |
| 156 | 151 | ||
| 157 | /* | 152 | /* |
| @@ -160,43 +155,49 @@ recopy: | |||
| 160 | * names_cache allocation for the pathname, and re-do the copy from | 155 | * names_cache allocation for the pathname, and re-do the copy from |
| 161 | * userland. | 156 | * userland. |
| 162 | */ | 157 | */ |
| 163 | if (len == EMBEDDED_NAME_MAX && max == EMBEDDED_NAME_MAX) { | 158 | if (unlikely(len == EMBEDDED_NAME_MAX)) { |
| 159 | const size_t size = offsetof(struct filename, iname[1]); | ||
| 164 | kname = (char *)result; | 160 | kname = (char *)result; |
| 165 | 161 | ||
| 166 | result = kzalloc(sizeof(*result), GFP_KERNEL); | 162 | /* |
| 167 | if (!result) { | 163 | * size is chosen that way we to guarantee that |
| 168 | err = ERR_PTR(-ENOMEM); | 164 | * result->iname[0] is within the same object and that |
| 169 | result = (struct filename *)kname; | 165 | * kname can't be equal to result->iname, no matter what. |
| 170 | goto error; | 166 | */ |
| 167 | result = kzalloc(size, GFP_KERNEL); | ||
| 168 | if (unlikely(!result)) { | ||
| 169 | __putname(kname); | ||
| 170 | return ERR_PTR(-ENOMEM); | ||
| 171 | } | 171 | } |
| 172 | result->name = kname; | 172 | result->name = kname; |
| 173 | result->separate = true; | 173 | len = strncpy_from_user(kname, filename, PATH_MAX); |
| 174 | result->refcnt = 1; | 174 | if (unlikely(len < 0)) { |
| 175 | max = PATH_MAX; | 175 | __putname(kname); |
| 176 | goto recopy; | 176 | kfree(result); |
| 177 | return ERR_PTR(len); | ||
| 178 | } | ||
| 179 | if (unlikely(len == PATH_MAX)) { | ||
| 180 | __putname(kname); | ||
| 181 | kfree(result); | ||
| 182 | return ERR_PTR(-ENAMETOOLONG); | ||
| 183 | } | ||
| 177 | } | 184 | } |
| 178 | 185 | ||
| 186 | result->refcnt = 1; | ||
| 179 | /* The empty path is special. */ | 187 | /* The empty path is special. */ |
| 180 | if (unlikely(!len)) { | 188 | if (unlikely(!len)) { |
| 181 | if (empty) | 189 | if (empty) |
| 182 | *empty = 1; | 190 | *empty = 1; |
| 183 | err = ERR_PTR(-ENOENT); | 191 | if (!(flags & LOOKUP_EMPTY)) { |
| 184 | if (!(flags & LOOKUP_EMPTY)) | 192 | putname(result); |
| 185 | goto error; | 193 | return ERR_PTR(-ENOENT); |
| 194 | } | ||
| 186 | } | 195 | } |
| 187 | 196 | ||
| 188 | err = ERR_PTR(-ENAMETOOLONG); | ||
| 189 | if (unlikely(len >= PATH_MAX)) | ||
| 190 | goto error; | ||
| 191 | |||
| 192 | result->uptr = filename; | 197 | result->uptr = filename; |
| 193 | result->aname = NULL; | 198 | result->aname = NULL; |
| 194 | audit_getname(result); | 199 | audit_getname(result); |
| 195 | return result; | 200 | return result; |
| 196 | |||
| 197 | error: | ||
| 198 | putname(result); | ||
| 199 | return err; | ||
| 200 | } | 201 | } |
| 201 | 202 | ||
| 202 | struct filename * | 203 | struct filename * |
| @@ -216,8 +217,7 @@ getname_kernel(const char * filename) | |||
| 216 | return ERR_PTR(-ENOMEM); | 217 | return ERR_PTR(-ENOMEM); |
| 217 | 218 | ||
| 218 | if (len <= EMBEDDED_NAME_MAX) { | 219 | if (len <= EMBEDDED_NAME_MAX) { |
| 219 | result->name = (char *)(result) + sizeof(*result); | 220 | result->name = (char *)result->iname; |
| 220 | result->separate = false; | ||
| 221 | } else if (len <= PATH_MAX) { | 221 | } else if (len <= PATH_MAX) { |
| 222 | struct filename *tmp; | 222 | struct filename *tmp; |
| 223 | 223 | ||
| @@ -227,7 +227,6 @@ getname_kernel(const char * filename) | |||
| 227 | return ERR_PTR(-ENOMEM); | 227 | return ERR_PTR(-ENOMEM); |
| 228 | } | 228 | } |
| 229 | tmp->name = (char *)result; | 229 | tmp->name = (char *)result; |
| 230 | tmp->separate = true; | ||
| 231 | result = tmp; | 230 | result = tmp; |
| 232 | } else { | 231 | } else { |
| 233 | __putname(result); | 232 | __putname(result); |
| @@ -249,7 +248,7 @@ void putname(struct filename *name) | |||
| 249 | if (--name->refcnt > 0) | 248 | if (--name->refcnt > 0) |
| 250 | return; | 249 | return; |
| 251 | 250 | ||
| 252 | if (name->separate) { | 251 | if (name->name != name->iname) { |
| 253 | __putname(name->name); | 252 | __putname(name->name); |
| 254 | kfree(name); | 253 | kfree(name); |
| 255 | } else | 254 | } else |
| @@ -1851,10 +1850,11 @@ static int link_path_walk(const char *name, struct nameidata *nd) | |||
| 1851 | return err; | 1850 | return err; |
| 1852 | } | 1851 | } |
| 1853 | 1852 | ||
| 1854 | static int path_init(int dfd, const char *name, unsigned int flags, | 1853 | static int path_init(int dfd, const struct filename *name, unsigned int flags, |
| 1855 | struct nameidata *nd) | 1854 | struct nameidata *nd) |
| 1856 | { | 1855 | { |
| 1857 | int retval = 0; | 1856 | int retval = 0; |
| 1857 | const char *s = name->name; | ||
| 1858 | 1858 | ||
| 1859 | nd->last_type = LAST_ROOT; /* if there are only slashes... */ | 1859 | nd->last_type = LAST_ROOT; /* if there are only slashes... */ |
| 1860 | nd->flags = flags | LOOKUP_JUMPED | LOOKUP_PARENT; | 1860 | nd->flags = flags | LOOKUP_JUMPED | LOOKUP_PARENT; |
| @@ -1863,7 +1863,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
| 1863 | if (flags & LOOKUP_ROOT) { | 1863 | if (flags & LOOKUP_ROOT) { |
| 1864 | struct dentry *root = nd->root.dentry; | 1864 | struct dentry *root = nd->root.dentry; |
| 1865 | struct inode *inode = root->d_inode; | 1865 | struct inode *inode = root->d_inode; |
| 1866 | if (*name) { | 1866 | if (*s) { |
| 1867 | if (!d_can_lookup(root)) | 1867 | if (!d_can_lookup(root)) |
| 1868 | return -ENOTDIR; | 1868 | return -ENOTDIR; |
| 1869 | retval = inode_permission(inode, MAY_EXEC); | 1869 | retval = inode_permission(inode, MAY_EXEC); |
| @@ -1885,7 +1885,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
| 1885 | nd->root.mnt = NULL; | 1885 | nd->root.mnt = NULL; |
| 1886 | 1886 | ||
| 1887 | nd->m_seq = read_seqbegin(&mount_lock); | 1887 | nd->m_seq = read_seqbegin(&mount_lock); |
| 1888 | if (*name=='/') { | 1888 | if (*s == '/') { |
| 1889 | if (flags & LOOKUP_RCU) { | 1889 | if (flags & LOOKUP_RCU) { |
| 1890 | rcu_read_lock(); | 1890 | rcu_read_lock(); |
| 1891 | nd->seq = set_root_rcu(nd); | 1891 | nd->seq = set_root_rcu(nd); |
| @@ -1919,7 +1919,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
| 1919 | 1919 | ||
| 1920 | dentry = f.file->f_path.dentry; | 1920 | dentry = f.file->f_path.dentry; |
| 1921 | 1921 | ||
| 1922 | if (*name) { | 1922 | if (*s) { |
| 1923 | if (!d_can_lookup(dentry)) { | 1923 | if (!d_can_lookup(dentry)) { |
| 1924 | fdput(f); | 1924 | fdput(f); |
| 1925 | return -ENOTDIR; | 1925 | return -ENOTDIR; |
| @@ -1949,7 +1949,7 @@ static int path_init(int dfd, const char *name, unsigned int flags, | |||
| 1949 | return -ECHILD; | 1949 | return -ECHILD; |
| 1950 | done: | 1950 | done: |
| 1951 | current->total_link_count = 0; | 1951 | current->total_link_count = 0; |
| 1952 | return link_path_walk(name, nd); | 1952 | return link_path_walk(s, nd); |
| 1953 | } | 1953 | } |
| 1954 | 1954 | ||
| 1955 | static void path_cleanup(struct nameidata *nd) | 1955 | static void path_cleanup(struct nameidata *nd) |
| @@ -1972,7 +1972,7 @@ static inline int lookup_last(struct nameidata *nd, struct path *path) | |||
| 1972 | } | 1972 | } |
| 1973 | 1973 | ||
| 1974 | /* Returns 0 and nd will be valid on success; Retuns error, otherwise. */ | 1974 | /* Returns 0 and nd will be valid on success; Retuns error, otherwise. */ |
| 1975 | static int path_lookupat(int dfd, const char *name, | 1975 | static int path_lookupat(int dfd, const struct filename *name, |
| 1976 | unsigned int flags, struct nameidata *nd) | 1976 | unsigned int flags, struct nameidata *nd) |
| 1977 | { | 1977 | { |
| 1978 | struct path path; | 1978 | struct path path; |
| @@ -2027,31 +2027,17 @@ static int path_lookupat(int dfd, const char *name, | |||
| 2027 | static int filename_lookup(int dfd, struct filename *name, | 2027 | static int filename_lookup(int dfd, struct filename *name, |
| 2028 | unsigned int flags, struct nameidata *nd) | 2028 | unsigned int flags, struct nameidata *nd) |
| 2029 | { | 2029 | { |
| 2030 | int retval = path_lookupat(dfd, name->name, flags | LOOKUP_RCU, nd); | 2030 | int retval = path_lookupat(dfd, name, flags | LOOKUP_RCU, nd); |
| 2031 | if (unlikely(retval == -ECHILD)) | 2031 | if (unlikely(retval == -ECHILD)) |
| 2032 | retval = path_lookupat(dfd, name->name, flags, nd); | 2032 | retval = path_lookupat(dfd, name, flags, nd); |
| 2033 | if (unlikely(retval == -ESTALE)) | 2033 | if (unlikely(retval == -ESTALE)) |
| 2034 | retval = path_lookupat(dfd, name->name, | 2034 | retval = path_lookupat(dfd, name, flags | LOOKUP_REVAL, nd); |
| 2035 | flags | LOOKUP_REVAL, nd); | ||
| 2036 | 2035 | ||
| 2037 | if (likely(!retval)) | 2036 | if (likely(!retval)) |
| 2038 | audit_inode(name, nd->path.dentry, flags & LOOKUP_PARENT); | 2037 | audit_inode(name, nd->path.dentry, flags & LOOKUP_PARENT); |
| 2039 | return retval; | 2038 | return retval; |
| 2040 | } | 2039 | } |
| 2041 | 2040 | ||
| 2042 | static int do_path_lookup(int dfd, const char *name, | ||
| 2043 | unsigned int flags, struct nameidata *nd) | ||
| 2044 | { | ||
| 2045 | struct filename *filename = getname_kernel(name); | ||
| 2046 | int retval = PTR_ERR(filename); | ||
| 2047 | |||
| 2048 | if (!IS_ERR(filename)) { | ||
| 2049 | retval = filename_lookup(dfd, filename, flags, nd); | ||
| 2050 | putname(filename); | ||
| 2051 | } | ||
| 2052 | return retval; | ||
| 2053 | } | ||
| 2054 | |||
| 2055 | /* does lookup, returns the object with parent locked */ | 2041 | /* does lookup, returns the object with parent locked */ |
| 2056 | struct dentry *kern_path_locked(const char *name, struct path *path) | 2042 | struct dentry *kern_path_locked(const char *name, struct path *path) |
| 2057 | { | 2043 | { |
| @@ -2089,9 +2075,15 @@ out: | |||
| 2089 | int kern_path(const char *name, unsigned int flags, struct path *path) | 2075 | int kern_path(const char *name, unsigned int flags, struct path *path) |
| 2090 | { | 2076 | { |
| 2091 | struct nameidata nd; | 2077 | struct nameidata nd; |
| 2092 | int res = do_path_lookup(AT_FDCWD, name, flags, &nd); | 2078 | struct filename *filename = getname_kernel(name); |
| 2093 | if (!res) | 2079 | int res = PTR_ERR(filename); |
| 2094 | *path = nd.path; | 2080 | |
| 2081 | if (!IS_ERR(filename)) { | ||
| 2082 | res = filename_lookup(AT_FDCWD, filename, flags, &nd); | ||
| 2083 | putname(filename); | ||
| 2084 | if (!res) | ||
| 2085 | *path = nd.path; | ||
| 2086 | } | ||
| 2095 | return res; | 2087 | return res; |
| 2096 | } | 2088 | } |
| 2097 | EXPORT_SYMBOL(kern_path); | 2089 | EXPORT_SYMBOL(kern_path); |
| @@ -2108,15 +2100,22 @@ int vfs_path_lookup(struct dentry *dentry, struct vfsmount *mnt, | |||
| 2108 | const char *name, unsigned int flags, | 2100 | const char *name, unsigned int flags, |
| 2109 | struct path *path) | 2101 | struct path *path) |
| 2110 | { | 2102 | { |
| 2111 | struct nameidata nd; | 2103 | struct filename *filename = getname_kernel(name); |
| 2112 | int err; | 2104 | int err = PTR_ERR(filename); |
| 2113 | nd.root.dentry = dentry; | 2105 | |
| 2114 | nd.root.mnt = mnt; | ||
| 2115 | BUG_ON(flags & LOOKUP_PARENT); | 2106 | BUG_ON(flags & LOOKUP_PARENT); |
| 2116 | /* the first argument of do_path_lookup() is ignored with LOOKUP_ROOT */ | 2107 | |
| 2117 | err = do_path_lookup(AT_FDCWD, name, flags | LOOKUP_ROOT, &nd); | 2108 | /* the first argument of filename_lookup() is ignored with LOOKUP_ROOT */ |
| 2118 | if (!err) | 2109 | if (!IS_ERR(filename)) { |
| 2119 | *path = nd.path; | 2110 | struct nameidata nd; |
| 2111 | nd.root.dentry = dentry; | ||
| 2112 | nd.root.mnt = mnt; | ||
| 2113 | err = filename_lookup(AT_FDCWD, filename, | ||
| 2114 | flags | LOOKUP_ROOT, &nd); | ||
| 2115 | if (!err) | ||
| 2116 | *path = nd.path; | ||
| 2117 | putname(filename); | ||
| 2118 | } | ||
| 2120 | return err; | 2119 | return err; |
| 2121 | } | 2120 | } |
| 2122 | EXPORT_SYMBOL(vfs_path_lookup); | 2121 | EXPORT_SYMBOL(vfs_path_lookup); |
| @@ -2138,9 +2137,7 @@ static struct dentry *lookup_hash(struct nameidata *nd) | |||
| 2138 | * @len: maximum length @len should be interpreted to | 2137 | * @len: maximum length @len should be interpreted to |
| 2139 | * | 2138 | * |
| 2140 | * Note that this routine is purely a helper for filesystem usage and should | 2139 | * Note that this routine is purely a helper for filesystem usage and should |
| 2141 | * not be called by generic code. Also note that by using this function the | 2140 | * not be called by generic code. |
| 2142 | * nameidata argument is passed to the filesystem methods and a filesystem | ||
| 2143 | * using this helper needs to be prepared for that. | ||
| 2144 | */ | 2141 | */ |
| 2145 | struct dentry *lookup_one_len(const char *name, struct dentry *base, int len) | 2142 | struct dentry *lookup_one_len(const char *name, struct dentry *base, int len) |
| 2146 | { | 2143 | { |
| @@ -2341,7 +2338,8 @@ out: | |||
| 2341 | * Returns 0 and "path" will be valid on success; Returns error otherwise. | 2338 | * Returns 0 and "path" will be valid on success; Returns error otherwise. |
| 2342 | */ | 2339 | */ |
| 2343 | static int | 2340 | static int |
| 2344 | path_mountpoint(int dfd, const char *name, struct path *path, unsigned int flags) | 2341 | path_mountpoint(int dfd, const struct filename *name, struct path *path, |
| 2342 | unsigned int flags) | ||
| 2345 | { | 2343 | { |
| 2346 | struct nameidata nd; | 2344 | struct nameidata nd; |
| 2347 | int err; | 2345 | int err; |
| @@ -2370,20 +2368,20 @@ out: | |||
| 2370 | } | 2368 | } |
| 2371 | 2369 | ||
| 2372 | static int | 2370 | static int |
| 2373 | filename_mountpoint(int dfd, struct filename *s, struct path *path, | 2371 | filename_mountpoint(int dfd, struct filename *name, struct path *path, |
| 2374 | unsigned int flags) | 2372 | unsigned int flags) |
| 2375 | { | 2373 | { |
| 2376 | int error; | 2374 | int error; |
| 2377 | if (IS_ERR(s)) | 2375 | if (IS_ERR(name)) |
| 2378 | return PTR_ERR(s); | 2376 | return PTR_ERR(name); |
| 2379 | error = path_mountpoint(dfd, s->name, path, flags | LOOKUP_RCU); | 2377 | error = path_mountpoint(dfd, name, path, flags | LOOKUP_RCU); |
| 2380 | if (unlikely(error == -ECHILD)) | 2378 | if (unlikely(error == -ECHILD)) |
| 2381 | error = path_mountpoint(dfd, s->name, path, flags); | 2379 | error = path_mountpoint(dfd, name, path, flags); |
| 2382 | if (unlikely(error == -ESTALE)) | 2380 | if (unlikely(error == -ESTALE)) |
| 2383 | error = path_mountpoint(dfd, s->name, path, flags | LOOKUP_REVAL); | 2381 | error = path_mountpoint(dfd, name, path, flags | LOOKUP_REVAL); |
| 2384 | if (likely(!error)) | 2382 | if (likely(!error)) |
| 2385 | audit_inode(s, path->dentry, 0); | 2383 | audit_inode(name, path->dentry, 0); |
| 2386 | putname(s); | 2384 | putname(name); |
| 2387 | return error; | 2385 | return error; |
| 2388 | } | 2386 | } |
| 2389 | 2387 | ||
| @@ -3156,7 +3154,7 @@ static int do_tmpfile(int dfd, struct filename *pathname, | |||
| 3156 | static const struct qstr name = QSTR_INIT("/", 1); | 3154 | static const struct qstr name = QSTR_INIT("/", 1); |
| 3157 | struct dentry *dentry, *child; | 3155 | struct dentry *dentry, *child; |
| 3158 | struct inode *dir; | 3156 | struct inode *dir; |
| 3159 | int error = path_lookupat(dfd, pathname->name, | 3157 | int error = path_lookupat(dfd, pathname, |
| 3160 | flags | LOOKUP_DIRECTORY, nd); | 3158 | flags | LOOKUP_DIRECTORY, nd); |
| 3161 | if (unlikely(error)) | 3159 | if (unlikely(error)) |
| 3162 | return error; | 3160 | return error; |
| @@ -3229,7 +3227,7 @@ static struct file *path_openat(int dfd, struct filename *pathname, | |||
| 3229 | goto out; | 3227 | goto out; |
| 3230 | } | 3228 | } |
| 3231 | 3229 | ||
| 3232 | error = path_init(dfd, pathname->name, flags, nd); | 3230 | error = path_init(dfd, pathname, flags, nd); |
| 3233 | if (unlikely(error)) | 3231 | if (unlikely(error)) |
| 3234 | goto out; | 3232 | goto out; |
| 3235 | 3233 | ||
diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c index e907c8cf732e..c3929fb2ab26 100644 --- a/fs/nfs/direct.c +++ b/fs/nfs/direct.c | |||
| @@ -265,7 +265,7 @@ ssize_t nfs_direct_IO(int rw, struct kiocb *iocb, struct iov_iter *iter, loff_t | |||
| 265 | 265 | ||
| 266 | return -EINVAL; | 266 | return -EINVAL; |
| 267 | #else | 267 | #else |
| 268 | VM_BUG_ON(iocb->ki_nbytes != PAGE_SIZE); | 268 | VM_BUG_ON(iov_iter_count(iter) != PAGE_SIZE); |
| 269 | 269 | ||
| 270 | if (rw == READ) | 270 | if (rw == READ) |
| 271 | return nfs_file_direct_read(iocb, iter, pos); | 271 | return nfs_file_direct_read(iocb, iter, pos); |
| @@ -393,7 +393,7 @@ static void nfs_direct_complete(struct nfs_direct_req *dreq, bool write) | |||
| 393 | long res = (long) dreq->error; | 393 | long res = (long) dreq->error; |
| 394 | if (!res) | 394 | if (!res) |
| 395 | res = (long) dreq->count; | 395 | res = (long) dreq->count; |
| 396 | aio_complete(dreq->iocb, res, 0); | 396 | dreq->iocb->ki_complete(dreq->iocb, res, 0); |
| 397 | } | 397 | } |
| 398 | 398 | ||
| 399 | complete_all(&dreq->completion); | 399 | complete_all(&dreq->completion); |
diff --git a/fs/nfs/file.c b/fs/nfs/file.c index e679d24c39d3..37b15582e0de 100644 --- a/fs/nfs/file.c +++ b/fs/nfs/file.c | |||
| @@ -26,7 +26,6 @@ | |||
| 26 | #include <linux/nfs_mount.h> | 26 | #include <linux/nfs_mount.h> |
| 27 | #include <linux/mm.h> | 27 | #include <linux/mm.h> |
| 28 | #include <linux/pagemap.h> | 28 | #include <linux/pagemap.h> |
| 29 | #include <linux/aio.h> | ||
| 30 | #include <linux/gfp.h> | 29 | #include <linux/gfp.h> |
| 31 | #include <linux/swap.h> | 30 | #include <linux/swap.h> |
| 32 | 31 | ||
diff --git a/fs/nilfs2/inode.c b/fs/nilfs2/inode.c index 8b5969538f39..ab4987bc637f 100644 --- a/fs/nilfs2/inode.c +++ b/fs/nilfs2/inode.c | |||
| @@ -26,7 +26,7 @@ | |||
| 26 | #include <linux/mpage.h> | 26 | #include <linux/mpage.h> |
| 27 | #include <linux/pagemap.h> | 27 | #include <linux/pagemap.h> |
| 28 | #include <linux/writeback.h> | 28 | #include <linux/writeback.h> |
| 29 | #include <linux/aio.h> | 29 | #include <linux/uio.h> |
| 30 | #include "nilfs.h" | 30 | #include "nilfs.h" |
| 31 | #include "btnode.h" | 31 | #include "btnode.h" |
| 32 | #include "segment.h" | 32 | #include "segment.h" |
diff --git a/fs/ntfs/Makefile b/fs/ntfs/Makefile index 36ae529511c4..2ff263e6d363 100644 --- a/fs/ntfs/Makefile +++ b/fs/ntfs/Makefile | |||
| @@ -8,7 +8,7 @@ ntfs-y := aops.o attrib.o collate.o compress.o debug.o dir.o file.o \ | |||
| 8 | 8 | ||
| 9 | ntfs-$(CONFIG_NTFS_RW) += bitmap.o lcnalloc.o logfile.o quota.o usnjrnl.o | 9 | ntfs-$(CONFIG_NTFS_RW) += bitmap.o lcnalloc.o logfile.o quota.o usnjrnl.o |
| 10 | 10 | ||
| 11 | ccflags-y := -DNTFS_VERSION=\"2.1.31\" | 11 | ccflags-y := -DNTFS_VERSION=\"2.1.32\" |
| 12 | ccflags-$(CONFIG_NTFS_DEBUG) += -DDEBUG | 12 | ccflags-$(CONFIG_NTFS_DEBUG) += -DDEBUG |
| 13 | ccflags-$(CONFIG_NTFS_RW) += -DNTFS_RW | 13 | ccflags-$(CONFIG_NTFS_RW) += -DNTFS_RW |
| 14 | 14 | ||
diff --git a/fs/ntfs/file.c b/fs/ntfs/file.c index 1da9b2d184dc..c1da78dad1af 100644 --- a/fs/ntfs/file.c +++ b/fs/ntfs/file.c | |||
| @@ -1,7 +1,7 @@ | |||
| 1 | /* | 1 | /* |
| 2 | * file.c - NTFS kernel file operations. Part of the Linux-NTFS project. | 2 | * file.c - NTFS kernel file operations. Part of the Linux-NTFS project. |
| 3 | * | 3 | * |
| 4 | * Copyright (c) 2001-2014 Anton Altaparmakov and Tuxera Inc. | 4 | * Copyright (c) 2001-2015 Anton Altaparmakov and Tuxera Inc. |
| 5 | * | 5 | * |
| 6 | * This program/include file is free software; you can redistribute it and/or | 6 | * This program/include file is free software; you can redistribute it and/or |
| 7 | * modify it under the terms of the GNU General Public License as published | 7 | * modify it under the terms of the GNU General Public License as published |
| @@ -28,7 +28,6 @@ | |||
| 28 | #include <linux/swap.h> | 28 | #include <linux/swap.h> |
| 29 | #include <linux/uio.h> | 29 | #include <linux/uio.h> |
| 30 | #include <linux/writeback.h> | 30 | #include <linux/writeback.h> |
| 31 | #include <linux/aio.h> | ||
| 32 | 31 | ||
| 33 | #include <asm/page.h> | 32 | #include <asm/page.h> |
| 34 | #include <asm/uaccess.h> | 33 | #include <asm/uaccess.h> |
| @@ -329,62 +328,168 @@ err_out: | |||
| 329 | return err; | 328 | return err; |
| 330 | } | 329 | } |
| 331 | 330 | ||
| 332 | /** | 331 | static ssize_t ntfs_prepare_file_for_write(struct file *file, loff_t *ppos, |
| 333 | * ntfs_fault_in_pages_readable - | 332 | size_t *count) |
| 334 | * | ||
| 335 | * Fault a number of userspace pages into pagetables. | ||
| 336 | * | ||
| 337 | * Unlike include/linux/pagemap.h::fault_in_pages_readable(), this one copes | ||
| 338 | * with more than two userspace pages as well as handling the single page case | ||
| 339 | * elegantly. | ||
| 340 | * | ||
| 341 | * If you find this difficult to understand, then think of the while loop being | ||
| 342 | * the following code, except that we do without the integer variable ret: | ||
| 343 | * | ||
| 344 | * do { | ||
| 345 | * ret = __get_user(c, uaddr); | ||
| 346 | * uaddr += PAGE_SIZE; | ||
| 347 | * } while (!ret && uaddr < end); | ||
| 348 | * | ||
| 349 | * Note, the final __get_user() may well run out-of-bounds of the user buffer, | ||
| 350 | * but _not_ out-of-bounds of the page the user buffer belongs to, and since | ||
| 351 | * this is only a read and not a write, and since it is still in the same page, | ||
| 352 | * it should not matter and this makes the code much simpler. | ||
| 353 | */ | ||
| 354 | static inline void ntfs_fault_in_pages_readable(const char __user *uaddr, | ||
| 355 | int bytes) | ||
| 356 | { | 333 | { |
| 357 | const char __user *end; | 334 | loff_t pos; |
| 358 | volatile char c; | 335 | s64 end, ll; |
| 359 | 336 | ssize_t err; | |
| 360 | /* Set @end to the first byte outside the last page we care about. */ | 337 | unsigned long flags; |
| 361 | end = (const char __user*)PAGE_ALIGN((unsigned long)uaddr + bytes); | 338 | struct inode *vi = file_inode(file); |
| 362 | 339 | ntfs_inode *base_ni, *ni = NTFS_I(vi); | |
| 363 | while (!__get_user(c, uaddr) && (uaddr += PAGE_SIZE, uaddr < end)) | 340 | ntfs_volume *vol = ni->vol; |
| 364 | ; | ||
| 365 | } | ||
| 366 | |||
| 367 | /** | ||
| 368 | * ntfs_fault_in_pages_readable_iovec - | ||
| 369 | * | ||
| 370 | * Same as ntfs_fault_in_pages_readable() but operates on an array of iovecs. | ||
| 371 | */ | ||
| 372 | static inline void ntfs_fault_in_pages_readable_iovec(const struct iovec *iov, | ||
| 373 | size_t iov_ofs, int bytes) | ||
| 374 | { | ||
| 375 | do { | ||
| 376 | const char __user *buf; | ||
| 377 | unsigned len; | ||
| 378 | 341 | ||
| 379 | buf = iov->iov_base + iov_ofs; | 342 | ntfs_debug("Entering for i_ino 0x%lx, attribute type 0x%x, pos " |
| 380 | len = iov->iov_len - iov_ofs; | 343 | "0x%llx, count 0x%lx.", vi->i_ino, |
| 381 | if (len > bytes) | 344 | (unsigned)le32_to_cpu(ni->type), |
| 382 | len = bytes; | 345 | (unsigned long long)*ppos, (unsigned long)*count); |
| 383 | ntfs_fault_in_pages_readable(buf, len); | 346 | /* We can write back this queue in page reclaim. */ |
| 384 | bytes -= len; | 347 | current->backing_dev_info = inode_to_bdi(vi); |
| 385 | iov++; | 348 | err = generic_write_checks(file, ppos, count, S_ISBLK(vi->i_mode)); |
| 386 | iov_ofs = 0; | 349 | if (unlikely(err)) |
| 387 | } while (bytes); | 350 | goto out; |
| 351 | /* | ||
| 352 | * All checks have passed. Before we start doing any writing we want | ||
| 353 | * to abort any totally illegal writes. | ||
| 354 | */ | ||
| 355 | BUG_ON(NInoMstProtected(ni)); | ||
| 356 | BUG_ON(ni->type != AT_DATA); | ||
| 357 | /* If file is encrypted, deny access, just like NT4. */ | ||
| 358 | if (NInoEncrypted(ni)) { | ||
| 359 | /* Only $DATA attributes can be encrypted. */ | ||
| 360 | /* | ||
| 361 | * Reminder for later: Encrypted files are _always_ | ||
| 362 | * non-resident so that the content can always be encrypted. | ||
| 363 | */ | ||
| 364 | ntfs_debug("Denying write access to encrypted file."); | ||
| 365 | err = -EACCES; | ||
| 366 | goto out; | ||
| 367 | } | ||
| 368 | if (NInoCompressed(ni)) { | ||
| 369 | /* Only unnamed $DATA attribute can be compressed. */ | ||
| 370 | BUG_ON(ni->name_len); | ||
| 371 | /* | ||
| 372 | * Reminder for later: If resident, the data is not actually | ||
| 373 | * compressed. Only on the switch to non-resident does | ||
| 374 | * compression kick in. This is in contrast to encrypted files | ||
| 375 | * (see above). | ||
| 376 | */ | ||
| 377 | ntfs_error(vi->i_sb, "Writing to compressed files is not " | ||
| 378 | "implemented yet. Sorry."); | ||
| 379 | err = -EOPNOTSUPP; | ||
| 380 | goto out; | ||
| 381 | } | ||
| 382 | if (*count == 0) | ||
| 383 | goto out; | ||
| 384 | base_ni = ni; | ||
| 385 | if (NInoAttr(ni)) | ||
| 386 | base_ni = ni->ext.base_ntfs_ino; | ||
| 387 | err = file_remove_suid(file); | ||
| 388 | if (unlikely(err)) | ||
| 389 | goto out; | ||
| 390 | /* | ||
| 391 | * Our ->update_time method always succeeds thus file_update_time() | ||
| 392 | * cannot fail either so there is no need to check the return code. | ||
| 393 | */ | ||
| 394 | file_update_time(file); | ||
| 395 | pos = *ppos; | ||
| 396 | /* The first byte after the last cluster being written to. */ | ||
| 397 | end = (pos + *count + vol->cluster_size_mask) & | ||
| 398 | ~(u64)vol->cluster_size_mask; | ||
| 399 | /* | ||
| 400 | * If the write goes beyond the allocated size, extend the allocation | ||
| 401 | * to cover the whole of the write, rounded up to the nearest cluster. | ||
| 402 | */ | ||
| 403 | read_lock_irqsave(&ni->size_lock, flags); | ||
| 404 | ll = ni->allocated_size; | ||
| 405 | read_unlock_irqrestore(&ni->size_lock, flags); | ||
| 406 | if (end > ll) { | ||
| 407 | /* | ||
| 408 | * Extend the allocation without changing the data size. | ||
| 409 | * | ||
| 410 | * Note we ensure the allocation is big enough to at least | ||
| 411 | * write some data but we do not require the allocation to be | ||
| 412 | * complete, i.e. it may be partial. | ||
| 413 | */ | ||
| 414 | ll = ntfs_attr_extend_allocation(ni, end, -1, pos); | ||
| 415 | if (likely(ll >= 0)) { | ||
| 416 | BUG_ON(pos >= ll); | ||
| 417 | /* If the extension was partial truncate the write. */ | ||
| 418 | if (end > ll) { | ||
| 419 | ntfs_debug("Truncating write to inode 0x%lx, " | ||
| 420 | "attribute type 0x%x, because " | ||
| 421 | "the allocation was only " | ||
| 422 | "partially extended.", | ||
| 423 | vi->i_ino, (unsigned) | ||
| 424 | le32_to_cpu(ni->type)); | ||
| 425 | *count = ll - pos; | ||
| 426 | } | ||
| 427 | } else { | ||
| 428 | err = ll; | ||
| 429 | read_lock_irqsave(&ni->size_lock, flags); | ||
| 430 | ll = ni->allocated_size; | ||
| 431 | read_unlock_irqrestore(&ni->size_lock, flags); | ||
| 432 | /* Perform a partial write if possible or fail. */ | ||
| 433 | if (pos < ll) { | ||
| 434 | ntfs_debug("Truncating write to inode 0x%lx " | ||
| 435 | "attribute type 0x%x, because " | ||
| 436 | "extending the allocation " | ||
| 437 | "failed (error %d).", | ||
| 438 | vi->i_ino, (unsigned) | ||
| 439 | le32_to_cpu(ni->type), | ||
| 440 | (int)-err); | ||
| 441 | *count = ll - pos; | ||
| 442 | } else { | ||
| 443 | if (err != -ENOSPC) | ||
| 444 | ntfs_error(vi->i_sb, "Cannot perform " | ||
| 445 | "write to inode " | ||
| 446 | "0x%lx, attribute " | ||
| 447 | "type 0x%x, because " | ||
| 448 | "extending the " | ||
| 449 | "allocation failed " | ||
| 450 | "(error %ld).", | ||
| 451 | vi->i_ino, (unsigned) | ||
| 452 | le32_to_cpu(ni->type), | ||
| 453 | (long)-err); | ||
| 454 | else | ||
| 455 | ntfs_debug("Cannot perform write to " | ||
| 456 | "inode 0x%lx, " | ||
| 457 | "attribute type 0x%x, " | ||
| 458 | "because there is not " | ||
| 459 | "space left.", | ||
| 460 | vi->i_ino, (unsigned) | ||
| 461 | le32_to_cpu(ni->type)); | ||
| 462 | goto out; | ||
| 463 | } | ||
| 464 | } | ||
| 465 | } | ||
| 466 | /* | ||
| 467 | * If the write starts beyond the initialized size, extend it up to the | ||
| 468 | * beginning of the write and initialize all non-sparse space between | ||
| 469 | * the old initialized size and the new one. This automatically also | ||
| 470 | * increments the vfs inode->i_size to keep it above or equal to the | ||
| 471 | * initialized_size. | ||
| 472 | */ | ||
| 473 | read_lock_irqsave(&ni->size_lock, flags); | ||
| 474 | ll = ni->initialized_size; | ||
| 475 | read_unlock_irqrestore(&ni->size_lock, flags); | ||
| 476 | if (pos > ll) { | ||
| 477 | /* | ||
| 478 | * Wait for ongoing direct i/o to complete before proceeding. | ||
| 479 | * New direct i/o cannot start as we hold i_mutex. | ||
| 480 | */ | ||
| 481 | inode_dio_wait(vi); | ||
| 482 | err = ntfs_attr_extend_initialized(ni, pos); | ||
| 483 | if (unlikely(err < 0)) | ||
| 484 | ntfs_error(vi->i_sb, "Cannot perform write to inode " | ||
| 485 | "0x%lx, attribute type 0x%x, because " | ||
| 486 | "extending the initialized size " | ||
| 487 | "failed (error %d).", vi->i_ino, | ||
| 488 | (unsigned)le32_to_cpu(ni->type), | ||
| 489 | (int)-err); | ||
| 490 | } | ||
| 491 | out: | ||
| 492 | return err; | ||
| 388 | } | 493 | } |
| 389 | 494 | ||
| 390 | /** | 495 | /** |
| @@ -421,8 +526,8 @@ static inline int __ntfs_grab_cache_pages(struct address_space *mapping, | |||
| 421 | goto err_out; | 526 | goto err_out; |
| 422 | } | 527 | } |
| 423 | } | 528 | } |
| 424 | err = add_to_page_cache_lru(*cached_page, mapping, index, | 529 | err = add_to_page_cache_lru(*cached_page, mapping, |
| 425 | GFP_KERNEL); | 530 | index, GFP_KERNEL); |
| 426 | if (unlikely(err)) { | 531 | if (unlikely(err)) { |
| 427 | if (err == -EEXIST) | 532 | if (err == -EEXIST) |
| 428 | continue; | 533 | continue; |
| @@ -1268,180 +1373,6 @@ rl_not_mapped_enoent: | |||
| 1268 | return err; | 1373 | return err; |
| 1269 | } | 1374 | } |
| 1270 | 1375 | ||
| 1271 | /* | ||
| 1272 | * Copy as much as we can into the pages and return the number of bytes which | ||
| 1273 | * were successfully copied. If a fault is encountered then clear the pages | ||
| 1274 | * out to (ofs + bytes) and return the number of bytes which were copied. | ||
| 1275 | */ | ||
| 1276 | static inline size_t ntfs_copy_from_user(struct page **pages, | ||
| 1277 | unsigned nr_pages, unsigned ofs, const char __user *buf, | ||
| 1278 | size_t bytes) | ||
| 1279 | { | ||
| 1280 | struct page **last_page = pages + nr_pages; | ||
| 1281 | char *addr; | ||
| 1282 | size_t total = 0; | ||
| 1283 | unsigned len; | ||
| 1284 | int left; | ||
| 1285 | |||
| 1286 | do { | ||
| 1287 | len = PAGE_CACHE_SIZE - ofs; | ||
| 1288 | if (len > bytes) | ||
| 1289 | len = bytes; | ||
| 1290 | addr = kmap_atomic(*pages); | ||
| 1291 | left = __copy_from_user_inatomic(addr + ofs, buf, len); | ||
| 1292 | kunmap_atomic(addr); | ||
| 1293 | if (unlikely(left)) { | ||
| 1294 | /* Do it the slow way. */ | ||
| 1295 | addr = kmap(*pages); | ||
| 1296 | left = __copy_from_user(addr + ofs, buf, len); | ||
| 1297 | kunmap(*pages); | ||
| 1298 | if (unlikely(left)) | ||
| 1299 | goto err_out; | ||
| 1300 | } | ||
| 1301 | total += len; | ||
| 1302 | bytes -= len; | ||
| 1303 | if (!bytes) | ||
| 1304 | break; | ||
| 1305 | buf += len; | ||
| 1306 | ofs = 0; | ||
| 1307 | } while (++pages < last_page); | ||
| 1308 | out: | ||
| 1309 | return total; | ||
| 1310 | err_out: | ||
| 1311 | total += len - left; | ||
| 1312 | /* Zero the rest of the target like __copy_from_user(). */ | ||
| 1313 | while (++pages < last_page) { | ||
| 1314 | bytes -= len; | ||
| 1315 | if (!bytes) | ||
| 1316 | break; | ||
| 1317 | len = PAGE_CACHE_SIZE; | ||
| 1318 | if (len > bytes) | ||
| 1319 | len = bytes; | ||
| 1320 | zero_user(*pages, 0, len); | ||
| 1321 | } | ||
| 1322 | goto out; | ||
| 1323 | } | ||
| 1324 | |||
| 1325 | static size_t __ntfs_copy_from_user_iovec_inatomic(char *vaddr, | ||
| 1326 | const struct iovec *iov, size_t iov_ofs, size_t bytes) | ||
| 1327 | { | ||
| 1328 | size_t total = 0; | ||
| 1329 | |||
| 1330 | while (1) { | ||
| 1331 | const char __user *buf = iov->iov_base + iov_ofs; | ||
| 1332 | unsigned len; | ||
| 1333 | size_t left; | ||
| 1334 | |||
| 1335 | len = iov->iov_len - iov_ofs; | ||
| 1336 | if (len > bytes) | ||
| 1337 | len = bytes; | ||
| 1338 | left = __copy_from_user_inatomic(vaddr, buf, len); | ||
| 1339 | total += len; | ||
| 1340 | bytes -= len; | ||
| 1341 | vaddr += len; | ||
| 1342 | if (unlikely(left)) { | ||
| 1343 | total -= left; | ||
| 1344 | break; | ||
| 1345 | } | ||
| 1346 | if (!bytes) | ||
| 1347 | break; | ||
| 1348 | iov++; | ||
| 1349 | iov_ofs = 0; | ||
| 1350 | } | ||
| 1351 | return total; | ||
| 1352 | } | ||
| 1353 | |||
| 1354 | static inline void ntfs_set_next_iovec(const struct iovec **iovp, | ||
| 1355 | size_t *iov_ofsp, size_t bytes) | ||
| 1356 | { | ||
| 1357 | const struct iovec *iov = *iovp; | ||
| 1358 | size_t iov_ofs = *iov_ofsp; | ||
| 1359 | |||
| 1360 | while (bytes) { | ||
| 1361 | unsigned len; | ||
| 1362 | |||
| 1363 | len = iov->iov_len - iov_ofs; | ||
| 1364 | if (len > bytes) | ||
| 1365 | len = bytes; | ||
| 1366 | bytes -= len; | ||
| 1367 | iov_ofs += len; | ||
| 1368 | if (iov->iov_len == iov_ofs) { | ||
| 1369 | iov++; | ||
| 1370 | iov_ofs = 0; | ||
| 1371 | } | ||
| 1372 | } | ||
| 1373 | *iovp = iov; | ||
| 1374 | *iov_ofsp = iov_ofs; | ||
| 1375 | } | ||
| 1376 | |||
| 1377 | /* | ||
| 1378 | * This has the same side-effects and return value as ntfs_copy_from_user(). | ||
| 1379 | * The difference is that on a fault we need to memset the remainder of the | ||
| 1380 | * pages (out to offset + bytes), to emulate ntfs_copy_from_user()'s | ||
| 1381 | * single-segment behaviour. | ||
| 1382 | * | ||
| 1383 | * We call the same helper (__ntfs_copy_from_user_iovec_inatomic()) both when | ||
| 1384 | * atomic and when not atomic. This is ok because it calls | ||
| 1385 | * __copy_from_user_inatomic() and it is ok to call this when non-atomic. In | ||
| 1386 | * fact, the only difference between __copy_from_user_inatomic() and | ||
| 1387 | * __copy_from_user() is that the latter calls might_sleep() and the former | ||
| 1388 | * should not zero the tail of the buffer on error. And on many architectures | ||
| 1389 | * __copy_from_user_inatomic() is just defined to __copy_from_user() so it | ||
| 1390 | * makes no difference at all on those architectures. | ||
| 1391 | */ | ||
| 1392 | static inline size_t ntfs_copy_from_user_iovec(struct page **pages, | ||
| 1393 | unsigned nr_pages, unsigned ofs, const struct iovec **iov, | ||
| 1394 | size_t *iov_ofs, size_t bytes) | ||
| 1395 | { | ||
| 1396 | struct page **last_page = pages + nr_pages; | ||
| 1397 | char *addr; | ||
| 1398 | size_t copied, len, total = 0; | ||
| 1399 | |||
| 1400 | do { | ||
| 1401 | len = PAGE_CACHE_SIZE - ofs; | ||
| 1402 | if (len > bytes) | ||
| 1403 | len = bytes; | ||
| 1404 | addr = kmap_atomic(*pages); | ||
| 1405 | copied = __ntfs_copy_from_user_iovec_inatomic(addr + ofs, | ||
| 1406 | *iov, *iov_ofs, len); | ||
| 1407 | kunmap_atomic(addr); | ||
| 1408 | if (unlikely(copied != len)) { | ||
| 1409 | /* Do it the slow way. */ | ||
| 1410 | addr = kmap(*pages); | ||
| 1411 | copied = __ntfs_copy_from_user_iovec_inatomic(addr + | ||
| 1412 | ofs, *iov, *iov_ofs, len); | ||
| 1413 | if (unlikely(copied != len)) | ||
| 1414 | goto err_out; | ||
| 1415 | kunmap(*pages); | ||
| 1416 | } | ||
| 1417 | total += len; | ||
| 1418 | ntfs_set_next_iovec(iov, iov_ofs, len); | ||
| 1419 | bytes -= len; | ||
| 1420 | if (!bytes) | ||
| 1421 | break; | ||
| 1422 | ofs = 0; | ||
| 1423 | } while (++pages < last_page); | ||
| 1424 | out: | ||
| 1425 | return total; | ||
| 1426 | err_out: | ||
| 1427 | BUG_ON(copied > len); | ||
| 1428 | /* Zero the rest of the target like __copy_from_user(). */ | ||
| 1429 | memset(addr + ofs + copied, 0, len - copied); | ||
| 1430 | kunmap(*pages); | ||
| 1431 | total += copied; | ||
| 1432 | ntfs_set_next_iovec(iov, iov_ofs, copied); | ||
| 1433 | while (++pages < last_page) { | ||
| 1434 | bytes -= len; | ||
| 1435 | if (!bytes) | ||
| 1436 | break; | ||
| 1437 | len = PAGE_CACHE_SIZE; | ||
| 1438 | if (len > bytes) | ||
| 1439 | len = bytes; | ||
| 1440 | zero_user(*pages, 0, len); | ||
| 1441 | } | ||
| 1442 | goto out; | ||
| 1443 | } | ||
| 1444 | |||
| 1445 | static inline void ntfs_flush_dcache_pages(struct page **pages, | 1376 | static inline void ntfs_flush_dcache_pages(struct page **pages, |
| 1446 | unsigned nr_pages) | 1377 | unsigned nr_pages) |
| 1447 | { | 1378 | { |
| @@ -1762,86 +1693,83 @@ err_out: | |||
| 1762 | return err; | 1693 | return err; |
| 1763 | } | 1694 | } |
| 1764 | 1695 | ||
| 1765 | static void ntfs_write_failed(struct address_space *mapping, loff_t to) | 1696 | /* |
| 1697 | * Copy as much as we can into the pages and return the number of bytes which | ||
| 1698 | * were successfully copied. If a fault is encountered then clear the pages | ||
| 1699 | * out to (ofs + bytes) and return the number of bytes which were copied. | ||
| 1700 | */ | ||
| 1701 | static size_t ntfs_copy_from_user_iter(struct page **pages, unsigned nr_pages, | ||
| 1702 | unsigned ofs, struct iov_iter *i, size_t bytes) | ||
| 1766 | { | 1703 | { |
| 1767 | struct inode *inode = mapping->host; | 1704 | struct page **last_page = pages + nr_pages; |
| 1705 | size_t total = 0; | ||
| 1706 | struct iov_iter data = *i; | ||
| 1707 | unsigned len, copied; | ||
| 1768 | 1708 | ||
| 1769 | if (to > inode->i_size) { | 1709 | do { |
| 1770 | truncate_pagecache(inode, inode->i_size); | 1710 | len = PAGE_CACHE_SIZE - ofs; |
| 1771 | ntfs_truncate_vfs(inode); | 1711 | if (len > bytes) |
| 1772 | } | 1712 | len = bytes; |
| 1713 | copied = iov_iter_copy_from_user_atomic(*pages, &data, ofs, | ||
| 1714 | len); | ||
| 1715 | total += copied; | ||
| 1716 | bytes -= copied; | ||
| 1717 | if (!bytes) | ||
| 1718 | break; | ||
| 1719 | iov_iter_advance(&data, copied); | ||
| 1720 | if (copied < len) | ||
| 1721 | goto err; | ||
| 1722 | ofs = 0; | ||
| 1723 | } while (++pages < last_page); | ||
| 1724 | out: | ||
| 1725 | return total; | ||
| 1726 | err: | ||
| 1727 | /* Zero the rest of the target like __copy_from_user(). */ | ||
| 1728 | len = PAGE_CACHE_SIZE - copied; | ||
| 1729 | do { | ||
| 1730 | if (len > bytes) | ||
| 1731 | len = bytes; | ||
| 1732 | zero_user(*pages, copied, len); | ||
| 1733 | bytes -= len; | ||
| 1734 | copied = 0; | ||
| 1735 | len = PAGE_CACHE_SIZE; | ||
| 1736 | } while (++pages < last_page); | ||
| 1737 | goto out; | ||
| 1773 | } | 1738 | } |
| 1774 | 1739 | ||
| 1775 | /** | 1740 | /** |
| 1776 | * ntfs_file_buffered_write - | 1741 | * ntfs_perform_write - perform buffered write to a file |
| 1777 | * | 1742 | * @file: file to write to |
| 1778 | * Locking: The vfs is holding ->i_mutex on the inode. | 1743 | * @i: iov_iter with data to write |
| 1744 | * @pos: byte offset in file at which to begin writing to | ||
| 1779 | */ | 1745 | */ |
| 1780 | static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | 1746 | static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i, |
| 1781 | const struct iovec *iov, unsigned long nr_segs, | 1747 | loff_t pos) |
| 1782 | loff_t pos, loff_t *ppos, size_t count) | ||
| 1783 | { | 1748 | { |
| 1784 | struct file *file = iocb->ki_filp; | ||
| 1785 | struct address_space *mapping = file->f_mapping; | 1749 | struct address_space *mapping = file->f_mapping; |
| 1786 | struct inode *vi = mapping->host; | 1750 | struct inode *vi = mapping->host; |
| 1787 | ntfs_inode *ni = NTFS_I(vi); | 1751 | ntfs_inode *ni = NTFS_I(vi); |
| 1788 | ntfs_volume *vol = ni->vol; | 1752 | ntfs_volume *vol = ni->vol; |
| 1789 | struct page *pages[NTFS_MAX_PAGES_PER_CLUSTER]; | 1753 | struct page *pages[NTFS_MAX_PAGES_PER_CLUSTER]; |
| 1790 | struct page *cached_page = NULL; | 1754 | struct page *cached_page = NULL; |
| 1791 | char __user *buf = NULL; | ||
| 1792 | s64 end, ll; | ||
| 1793 | VCN last_vcn; | 1755 | VCN last_vcn; |
| 1794 | LCN lcn; | 1756 | LCN lcn; |
| 1795 | unsigned long flags; | 1757 | size_t bytes; |
| 1796 | size_t bytes, iov_ofs = 0; /* Offset in the current iovec. */ | 1758 | ssize_t status, written = 0; |
| 1797 | ssize_t status, written; | ||
| 1798 | unsigned nr_pages; | 1759 | unsigned nr_pages; |
| 1799 | int err; | ||
| 1800 | 1760 | ||
| 1801 | ntfs_debug("Entering for i_ino 0x%lx, attribute type 0x%x, " | 1761 | ntfs_debug("Entering for i_ino 0x%lx, attribute type 0x%x, pos " |
| 1802 | "pos 0x%llx, count 0x%lx.", | 1762 | "0x%llx, count 0x%lx.", vi->i_ino, |
| 1803 | vi->i_ino, (unsigned)le32_to_cpu(ni->type), | 1763 | (unsigned)le32_to_cpu(ni->type), |
| 1804 | (unsigned long long)pos, (unsigned long)count); | 1764 | (unsigned long long)pos, |
| 1805 | if (unlikely(!count)) | 1765 | (unsigned long)iov_iter_count(i)); |
| 1806 | return 0; | ||
| 1807 | BUG_ON(NInoMstProtected(ni)); | ||
| 1808 | /* | ||
| 1809 | * If the attribute is not an index root and it is encrypted or | ||
| 1810 | * compressed, we cannot write to it yet. Note we need to check for | ||
| 1811 | * AT_INDEX_ALLOCATION since this is the type of both directory and | ||
| 1812 | * index inodes. | ||
| 1813 | */ | ||
| 1814 | if (ni->type != AT_INDEX_ALLOCATION) { | ||
| 1815 | /* If file is encrypted, deny access, just like NT4. */ | ||
| 1816 | if (NInoEncrypted(ni)) { | ||
| 1817 | /* | ||
| 1818 | * Reminder for later: Encrypted files are _always_ | ||
| 1819 | * non-resident so that the content can always be | ||
| 1820 | * encrypted. | ||
| 1821 | */ | ||
| 1822 | ntfs_debug("Denying write access to encrypted file."); | ||
| 1823 | return -EACCES; | ||
| 1824 | } | ||
| 1825 | if (NInoCompressed(ni)) { | ||
| 1826 | /* Only unnamed $DATA attribute can be compressed. */ | ||
| 1827 | BUG_ON(ni->type != AT_DATA); | ||
| 1828 | BUG_ON(ni->name_len); | ||
| 1829 | /* | ||
| 1830 | * Reminder for later: If resident, the data is not | ||
| 1831 | * actually compressed. Only on the switch to non- | ||
| 1832 | * resident does compression kick in. This is in | ||
| 1833 | * contrast to encrypted files (see above). | ||
| 1834 | */ | ||
| 1835 | ntfs_error(vi->i_sb, "Writing to compressed files is " | ||
| 1836 | "not implemented yet. Sorry."); | ||
| 1837 | return -EOPNOTSUPP; | ||
| 1838 | } | ||
| 1839 | } | ||
| 1840 | /* | 1766 | /* |
| 1841 | * If a previous ntfs_truncate() failed, repeat it and abort if it | 1767 | * If a previous ntfs_truncate() failed, repeat it and abort if it |
| 1842 | * fails again. | 1768 | * fails again. |
| 1843 | */ | 1769 | */ |
| 1844 | if (unlikely(NInoTruncateFailed(ni))) { | 1770 | if (unlikely(NInoTruncateFailed(ni))) { |
| 1771 | int err; | ||
| 1772 | |||
| 1845 | inode_dio_wait(vi); | 1773 | inode_dio_wait(vi); |
| 1846 | err = ntfs_truncate(vi); | 1774 | err = ntfs_truncate(vi); |
| 1847 | if (err || NInoTruncateFailed(ni)) { | 1775 | if (err || NInoTruncateFailed(ni)) { |
| @@ -1855,81 +1783,6 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 1855 | return err; | 1783 | return err; |
| 1856 | } | 1784 | } |
| 1857 | } | 1785 | } |
| 1858 | /* The first byte after the write. */ | ||
| 1859 | end = pos + count; | ||
| 1860 | /* | ||
| 1861 | * If the write goes beyond the allocated size, extend the allocation | ||
| 1862 | * to cover the whole of the write, rounded up to the nearest cluster. | ||
| 1863 | */ | ||
| 1864 | read_lock_irqsave(&ni->size_lock, flags); | ||
| 1865 | ll = ni->allocated_size; | ||
| 1866 | read_unlock_irqrestore(&ni->size_lock, flags); | ||
| 1867 | if (end > ll) { | ||
| 1868 | /* Extend the allocation without changing the data size. */ | ||
| 1869 | ll = ntfs_attr_extend_allocation(ni, end, -1, pos); | ||
| 1870 | if (likely(ll >= 0)) { | ||
| 1871 | BUG_ON(pos >= ll); | ||
| 1872 | /* If the extension was partial truncate the write. */ | ||
| 1873 | if (end > ll) { | ||
| 1874 | ntfs_debug("Truncating write to inode 0x%lx, " | ||
| 1875 | "attribute type 0x%x, because " | ||
| 1876 | "the allocation was only " | ||
| 1877 | "partially extended.", | ||
| 1878 | vi->i_ino, (unsigned) | ||
| 1879 | le32_to_cpu(ni->type)); | ||
| 1880 | end = ll; | ||
| 1881 | count = ll - pos; | ||
| 1882 | } | ||
| 1883 | } else { | ||
| 1884 | err = ll; | ||
| 1885 | read_lock_irqsave(&ni->size_lock, flags); | ||
| 1886 | ll = ni->allocated_size; | ||
| 1887 | read_unlock_irqrestore(&ni->size_lock, flags); | ||
| 1888 | /* Perform a partial write if possible or fail. */ | ||
| 1889 | if (pos < ll) { | ||
| 1890 | ntfs_debug("Truncating write to inode 0x%lx, " | ||
| 1891 | "attribute type 0x%x, because " | ||
| 1892 | "extending the allocation " | ||
| 1893 | "failed (error code %i).", | ||
| 1894 | vi->i_ino, (unsigned) | ||
| 1895 | le32_to_cpu(ni->type), err); | ||
| 1896 | end = ll; | ||
| 1897 | count = ll - pos; | ||
| 1898 | } else { | ||
| 1899 | ntfs_error(vol->sb, "Cannot perform write to " | ||
| 1900 | "inode 0x%lx, attribute type " | ||
| 1901 | "0x%x, because extending the " | ||
| 1902 | "allocation failed (error " | ||
| 1903 | "code %i).", vi->i_ino, | ||
| 1904 | (unsigned) | ||
| 1905 | le32_to_cpu(ni->type), err); | ||
| 1906 | return err; | ||
| 1907 | } | ||
| 1908 | } | ||
| 1909 | } | ||
| 1910 | written = 0; | ||
| 1911 | /* | ||
| 1912 | * If the write starts beyond the initialized size, extend it up to the | ||
| 1913 | * beginning of the write and initialize all non-sparse space between | ||
| 1914 | * the old initialized size and the new one. This automatically also | ||
| 1915 | * increments the vfs inode->i_size to keep it above or equal to the | ||
| 1916 | * initialized_size. | ||
| 1917 | */ | ||
| 1918 | read_lock_irqsave(&ni->size_lock, flags); | ||
| 1919 | ll = ni->initialized_size; | ||
| 1920 | read_unlock_irqrestore(&ni->size_lock, flags); | ||
| 1921 | if (pos > ll) { | ||
| 1922 | err = ntfs_attr_extend_initialized(ni, pos); | ||
| 1923 | if (err < 0) { | ||
| 1924 | ntfs_error(vol->sb, "Cannot perform write to inode " | ||
| 1925 | "0x%lx, attribute type 0x%x, because " | ||
| 1926 | "extending the initialized size " | ||
| 1927 | "failed (error code %i).", vi->i_ino, | ||
| 1928 | (unsigned)le32_to_cpu(ni->type), err); | ||
| 1929 | status = err; | ||
| 1930 | goto err_out; | ||
| 1931 | } | ||
| 1932 | } | ||
| 1933 | /* | 1786 | /* |
| 1934 | * Determine the number of pages per cluster for non-resident | 1787 | * Determine the number of pages per cluster for non-resident |
| 1935 | * attributes. | 1788 | * attributes. |
| @@ -1937,10 +1790,7 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 1937 | nr_pages = 1; | 1790 | nr_pages = 1; |
| 1938 | if (vol->cluster_size > PAGE_CACHE_SIZE && NInoNonResident(ni)) | 1791 | if (vol->cluster_size > PAGE_CACHE_SIZE && NInoNonResident(ni)) |
| 1939 | nr_pages = vol->cluster_size >> PAGE_CACHE_SHIFT; | 1792 | nr_pages = vol->cluster_size >> PAGE_CACHE_SHIFT; |
| 1940 | /* Finally, perform the actual write. */ | ||
| 1941 | last_vcn = -1; | 1793 | last_vcn = -1; |
| 1942 | if (likely(nr_segs == 1)) | ||
| 1943 | buf = iov->iov_base; | ||
| 1944 | do { | 1794 | do { |
| 1945 | VCN vcn; | 1795 | VCN vcn; |
| 1946 | pgoff_t idx, start_idx; | 1796 | pgoff_t idx, start_idx; |
| @@ -1965,10 +1815,10 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 1965 | vol->cluster_size_bits, false); | 1815 | vol->cluster_size_bits, false); |
| 1966 | up_read(&ni->runlist.lock); | 1816 | up_read(&ni->runlist.lock); |
| 1967 | if (unlikely(lcn < LCN_HOLE)) { | 1817 | if (unlikely(lcn < LCN_HOLE)) { |
| 1968 | status = -EIO; | ||
| 1969 | if (lcn == LCN_ENOMEM) | 1818 | if (lcn == LCN_ENOMEM) |
| 1970 | status = -ENOMEM; | 1819 | status = -ENOMEM; |
| 1971 | else | 1820 | else { |
| 1821 | status = -EIO; | ||
| 1972 | ntfs_error(vol->sb, "Cannot " | 1822 | ntfs_error(vol->sb, "Cannot " |
| 1973 | "perform write to " | 1823 | "perform write to " |
| 1974 | "inode 0x%lx, " | 1824 | "inode 0x%lx, " |
| @@ -1977,6 +1827,7 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 1977 | "is corrupt.", | 1827 | "is corrupt.", |
| 1978 | vi->i_ino, (unsigned) | 1828 | vi->i_ino, (unsigned) |
| 1979 | le32_to_cpu(ni->type)); | 1829 | le32_to_cpu(ni->type)); |
| 1830 | } | ||
| 1980 | break; | 1831 | break; |
| 1981 | } | 1832 | } |
| 1982 | if (lcn == LCN_HOLE) { | 1833 | if (lcn == LCN_HOLE) { |
| @@ -1989,8 +1840,9 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 1989 | } | 1840 | } |
| 1990 | } | 1841 | } |
| 1991 | } | 1842 | } |
| 1992 | if (bytes > count) | 1843 | if (bytes > iov_iter_count(i)) |
| 1993 | bytes = count; | 1844 | bytes = iov_iter_count(i); |
| 1845 | again: | ||
| 1994 | /* | 1846 | /* |
| 1995 | * Bring in the user page(s) that we will copy from _first_. | 1847 | * Bring in the user page(s) that we will copy from _first_. |
| 1996 | * Otherwise there is a nasty deadlock on copying from the same | 1848 | * Otherwise there is a nasty deadlock on copying from the same |
| @@ -1999,10 +1851,10 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 1999 | * pages being swapped out between us bringing them into memory | 1851 | * pages being swapped out between us bringing them into memory |
| 2000 | * and doing the actual copying. | 1852 | * and doing the actual copying. |
| 2001 | */ | 1853 | */ |
| 2002 | if (likely(nr_segs == 1)) | 1854 | if (unlikely(iov_iter_fault_in_multipages_readable(i, bytes))) { |
| 2003 | ntfs_fault_in_pages_readable(buf, bytes); | 1855 | status = -EFAULT; |
| 2004 | else | 1856 | break; |
| 2005 | ntfs_fault_in_pages_readable_iovec(iov, iov_ofs, bytes); | 1857 | } |
| 2006 | /* Get and lock @do_pages starting at index @start_idx. */ | 1858 | /* Get and lock @do_pages starting at index @start_idx. */ |
| 2007 | status = __ntfs_grab_cache_pages(mapping, start_idx, do_pages, | 1859 | status = __ntfs_grab_cache_pages(mapping, start_idx, do_pages, |
| 2008 | pages, &cached_page); | 1860 | pages, &cached_page); |
| @@ -2018,56 +1870,57 @@ static ssize_t ntfs_file_buffered_write(struct kiocb *iocb, | |||
| 2018 | status = ntfs_prepare_pages_for_non_resident_write( | 1870 | status = ntfs_prepare_pages_for_non_resident_write( |
| 2019 | pages, do_pages, pos, bytes); | 1871 | pages, do_pages, pos, bytes); |
| 2020 | if (unlikely(status)) { | 1872 | if (unlikely(status)) { |
| 2021 | loff_t i_size; | ||
| 2022 | |||
| 2023 | do { | 1873 | do { |
| 2024 | unlock_page(pages[--do_pages]); | 1874 | unlock_page(pages[--do_pages]); |
| 2025 | page_cache_release(pages[do_pages]); | 1875 | page_cache_release(pages[do_pages]); |
| 2026 | } while (do_pages); | 1876 | } while (do_pages); |
| 2027 | /* | ||
| 2028 | * The write preparation may have instantiated | ||
| 2029 | * allocated space outside i_size. Trim this | ||
| 2030 | * off again. We can ignore any errors in this | ||
| 2031 | * case as we will just be waisting a bit of | ||
| 2032 | * allocated space, which is not a disaster. | ||
| 2033 | */ | ||
| 2034 | i_size = i_size_read(vi); | ||
| 2035 | if (pos + bytes > i_size) { | ||
| 2036 | ntfs_write_failed(mapping, pos + bytes); | ||
| 2037 | } | ||
| 2038 | break; | 1877 | break; |
| 2039 | } | 1878 | } |
| 2040 | } | 1879 | } |
| 2041 | u = (pos >> PAGE_CACHE_SHIFT) - pages[0]->index; | 1880 | u = (pos >> PAGE_CACHE_SHIFT) - pages[0]->index; |
| 2042 | if (likely(nr_segs == 1)) { | 1881 | copied = ntfs_copy_from_user_iter(pages + u, do_pages - u, ofs, |
| 2043 | copied = ntfs_copy_from_user(pages + u, do_pages - u, | 1882 | i, bytes); |
| 2044 | ofs, buf, bytes); | ||
| 2045 | buf += copied; | ||
| 2046 | } else | ||
| 2047 | copied = ntfs_copy_from_user_iovec(pages + u, | ||
| 2048 | do_pages - u, ofs, &iov, &iov_ofs, | ||
| 2049 | bytes); | ||
| 2050 | ntfs_flush_dcache_pages(pages + u, do_pages - u); | 1883 | ntfs_flush_dcache_pages(pages + u, do_pages - u); |
| 2051 | status = ntfs_commit_pages_after_write(pages, do_pages, pos, | 1884 | status = 0; |
| 2052 | bytes); | 1885 | if (likely(copied == bytes)) { |
| 2053 | if (likely(!status)) { | 1886 | status = ntfs_commit_pages_after_write(pages, do_pages, |
| 2054 | written += copied; | 1887 | pos, bytes); |
| 2055 | count -= copied; | 1888 | if (!status) |
| 2056 | pos += copied; | 1889 | status = bytes; |
| 2057 | if (unlikely(copied != bytes)) | ||
| 2058 | status = -EFAULT; | ||
| 2059 | } | 1890 | } |
| 2060 | do { | 1891 | do { |
| 2061 | unlock_page(pages[--do_pages]); | 1892 | unlock_page(pages[--do_pages]); |
| 2062 | page_cache_release(pages[do_pages]); | 1893 | page_cache_release(pages[do_pages]); |
| 2063 | } while (do_pages); | 1894 | } while (do_pages); |
| 2064 | if (unlikely(status)) | 1895 | if (unlikely(status < 0)) |
| 2065 | break; | 1896 | break; |
| 2066 | balance_dirty_pages_ratelimited(mapping); | 1897 | copied = status; |
| 2067 | cond_resched(); | 1898 | cond_resched(); |
| 2068 | } while (count); | 1899 | if (unlikely(!copied)) { |
| 2069 | err_out: | 1900 | size_t sc; |
| 2070 | *ppos = pos; | 1901 | |
| 1902 | /* | ||
| 1903 | * We failed to copy anything. Fall back to single | ||
| 1904 | * segment length write. | ||
| 1905 | * | ||
| 1906 | * This is needed to avoid possible livelock in the | ||
| 1907 | * case that all segments in the iov cannot be copied | ||
| 1908 | * at once without a pagefault. | ||
| 1909 | */ | ||
| 1910 | sc = iov_iter_single_seg_count(i); | ||
| 1911 | if (bytes > sc) | ||
| 1912 | bytes = sc; | ||
| 1913 | goto again; | ||
| 1914 | } | ||
| 1915 | iov_iter_advance(i, copied); | ||
| 1916 | pos += copied; | ||
| 1917 | written += copied; | ||
| 1918 | balance_dirty_pages_ratelimited(mapping); | ||
| 1919 | if (fatal_signal_pending(current)) { | ||
| 1920 | status = -EINTR; | ||
| 1921 | break; | ||
| 1922 | } | ||
| 1923 | } while (iov_iter_count(i)); | ||
| 2071 | if (cached_page) | 1924 | if (cached_page) |
| 2072 | page_cache_release(cached_page); | 1925 | page_cache_release(cached_page); |
| 2073 | ntfs_debug("Done. Returning %s (written 0x%lx, status %li).", | 1926 | ntfs_debug("Done. Returning %s (written 0x%lx, status %li).", |
| @@ -2077,59 +1930,56 @@ err_out: | |||
| 2077 | } | 1930 | } |
| 2078 | 1931 | ||
| 2079 | /** | 1932 | /** |
| 2080 | * ntfs_file_aio_write_nolock - | 1933 | * ntfs_file_write_iter_nolock - write data to a file |
| 1934 | * @iocb: IO state structure (file, offset, etc.) | ||
| 1935 | * @from: iov_iter with data to write | ||
| 1936 | * | ||
| 1937 | * Basically the same as __generic_file_write_iter() except that it ends | ||
| 1938 | * up calling ntfs_perform_write() instead of generic_perform_write() and that | ||
| 1939 | * O_DIRECT is not implemented. | ||
| 2081 | */ | 1940 | */ |
| 2082 | static ssize_t ntfs_file_aio_write_nolock(struct kiocb *iocb, | 1941 | static ssize_t ntfs_file_write_iter_nolock(struct kiocb *iocb, |
| 2083 | const struct iovec *iov, unsigned long nr_segs, loff_t *ppos) | 1942 | struct iov_iter *from) |
| 2084 | { | 1943 | { |
| 2085 | struct file *file = iocb->ki_filp; | 1944 | struct file *file = iocb->ki_filp; |
| 2086 | struct address_space *mapping = file->f_mapping; | 1945 | loff_t pos = iocb->ki_pos; |
| 2087 | struct inode *inode = mapping->host; | 1946 | ssize_t written = 0; |
| 2088 | loff_t pos; | 1947 | ssize_t err; |
| 2089 | size_t count; /* after file limit checks */ | 1948 | size_t count = iov_iter_count(from); |
| 2090 | ssize_t written, err; | ||
| 2091 | 1949 | ||
| 2092 | count = iov_length(iov, nr_segs); | 1950 | err = ntfs_prepare_file_for_write(file, &pos, &count); |
| 2093 | pos = *ppos; | 1951 | if (count && !err) { |
| 2094 | /* We can write back this queue in page reclaim. */ | 1952 | iov_iter_truncate(from, count); |
| 2095 | current->backing_dev_info = inode_to_bdi(inode); | 1953 | written = ntfs_perform_write(file, from, pos); |
| 2096 | written = 0; | 1954 | if (likely(written >= 0)) |
| 2097 | err = generic_write_checks(file, &pos, &count, S_ISBLK(inode->i_mode)); | 1955 | iocb->ki_pos = pos + written; |
| 2098 | if (err) | 1956 | } |
| 2099 | goto out; | ||
| 2100 | if (!count) | ||
| 2101 | goto out; | ||
| 2102 | err = file_remove_suid(file); | ||
| 2103 | if (err) | ||
| 2104 | goto out; | ||
| 2105 | err = file_update_time(file); | ||
| 2106 | if (err) | ||
| 2107 | goto out; | ||
| 2108 | written = ntfs_file_buffered_write(iocb, iov, nr_segs, pos, ppos, | ||
| 2109 | count); | ||
| 2110 | out: | ||
| 2111 | current->backing_dev_info = NULL; | 1957 | current->backing_dev_info = NULL; |
| 2112 | return written ? written : err; | 1958 | return written ? written : err; |
| 2113 | } | 1959 | } |
| 2114 | 1960 | ||
| 2115 | /** | 1961 | /** |
| 2116 | * ntfs_file_aio_write - | 1962 | * ntfs_file_write_iter - simple wrapper for ntfs_file_write_iter_nolock() |
| 1963 | * @iocb: IO state structure | ||
| 1964 | * @from: iov_iter with data to write | ||
| 1965 | * | ||
| 1966 | * Basically the same as generic_file_write_iter() except that it ends up | ||
| 1967 | * calling ntfs_file_write_iter_nolock() instead of | ||
| 1968 | * __generic_file_write_iter(). | ||
| 2117 | */ | 1969 | */ |
| 2118 | static ssize_t ntfs_file_aio_write(struct kiocb *iocb, const struct iovec *iov, | 1970 | static ssize_t ntfs_file_write_iter(struct kiocb *iocb, struct iov_iter *from) |
| 2119 | unsigned long nr_segs, loff_t pos) | ||
| 2120 | { | 1971 | { |
| 2121 | struct file *file = iocb->ki_filp; | 1972 | struct file *file = iocb->ki_filp; |
| 2122 | struct address_space *mapping = file->f_mapping; | 1973 | struct inode *vi = file_inode(file); |
| 2123 | struct inode *inode = mapping->host; | ||
| 2124 | ssize_t ret; | 1974 | ssize_t ret; |
| 2125 | 1975 | ||
| 2126 | BUG_ON(iocb->ki_pos != pos); | 1976 | mutex_lock(&vi->i_mutex); |
| 2127 | 1977 | ret = ntfs_file_write_iter_nolock(iocb, from); | |
| 2128 | mutex_lock(&inode->i_mutex); | 1978 | mutex_unlock(&vi->i_mutex); |
| 2129 | ret = ntfs_file_aio_write_nolock(iocb, iov, nr_segs, &iocb->ki_pos); | ||
| 2130 | mutex_unlock(&inode->i_mutex); | ||
| 2131 | if (ret > 0) { | 1979 | if (ret > 0) { |
| 2132 | int err = generic_write_sync(file, iocb->ki_pos - ret, ret); | 1980 | ssize_t err; |
| 1981 | |||
| 1982 | err = generic_write_sync(file, iocb->ki_pos - ret, ret); | ||
| 2133 | if (err < 0) | 1983 | if (err < 0) |
| 2134 | ret = err; | 1984 | ret = err; |
| 2135 | } | 1985 | } |
| @@ -2197,37 +2047,17 @@ static int ntfs_file_fsync(struct file *filp, loff_t start, loff_t end, | |||
| 2197 | #endif /* NTFS_RW */ | 2047 | #endif /* NTFS_RW */ |
| 2198 | 2048 | ||
| 2199 | const struct file_operations ntfs_file_ops = { | 2049 | const struct file_operations ntfs_file_ops = { |
| 2200 | .llseek = generic_file_llseek, /* Seek inside file. */ | 2050 | .llseek = generic_file_llseek, |
| 2201 | .read = new_sync_read, /* Read from file. */ | 2051 | .read = new_sync_read, |
| 2202 | .read_iter = generic_file_read_iter, /* Async read from file. */ | 2052 | .read_iter = generic_file_read_iter, |
| 2203 | #ifdef NTFS_RW | 2053 | #ifdef NTFS_RW |
| 2204 | .write = do_sync_write, /* Write to file. */ | 2054 | .write = new_sync_write, |
| 2205 | .aio_write = ntfs_file_aio_write, /* Async write to file. */ | 2055 | .write_iter = ntfs_file_write_iter, |
| 2206 | /*.release = ,*/ /* Last file is closed. See | 2056 | .fsync = ntfs_file_fsync, |
| 2207 | fs/ext2/file.c:: | ||
| 2208 | ext2_release_file() for | ||
| 2209 | how to use this to discard | ||
| 2210 | preallocated space for | ||
| 2211 | write opened files. */ | ||
| 2212 | .fsync = ntfs_file_fsync, /* Sync a file to disk. */ | ||
| 2213 | /*.aio_fsync = ,*/ /* Sync all outstanding async | ||
| 2214 | i/o operations on a | ||
| 2215 | kiocb. */ | ||
| 2216 | #endif /* NTFS_RW */ | 2057 | #endif /* NTFS_RW */ |
| 2217 | /*.ioctl = ,*/ /* Perform function on the | 2058 | .mmap = generic_file_mmap, |
| 2218 | mounted filesystem. */ | 2059 | .open = ntfs_file_open, |
| 2219 | .mmap = generic_file_mmap, /* Mmap file. */ | 2060 | .splice_read = generic_file_splice_read, |
| 2220 | .open = ntfs_file_open, /* Open file. */ | ||
| 2221 | .splice_read = generic_file_splice_read /* Zero-copy data send with | ||
| 2222 | the data source being on | ||
| 2223 | the ntfs partition. We do | ||
| 2224 | not need to care about the | ||
| 2225 | data destination. */ | ||
| 2226 | /*.sendpage = ,*/ /* Zero-copy data send with | ||
| 2227 | the data destination being | ||
| 2228 | on the ntfs partition. We | ||
| 2229 | do not need to care about | ||
| 2230 | the data source. */ | ||
| 2231 | }; | 2061 | }; |
| 2232 | 2062 | ||
| 2233 | const struct inode_operations ntfs_file_inode_ops = { | 2063 | const struct inode_operations ntfs_file_inode_ops = { |
diff --git a/fs/ntfs/inode.c b/fs/ntfs/inode.c index 898b9949d363..1d0c21df0d80 100644 --- a/fs/ntfs/inode.c +++ b/fs/ntfs/inode.c | |||
| @@ -28,7 +28,6 @@ | |||
| 28 | #include <linux/quotaops.h> | 28 | #include <linux/quotaops.h> |
| 29 | #include <linux/slab.h> | 29 | #include <linux/slab.h> |
| 30 | #include <linux/log2.h> | 30 | #include <linux/log2.h> |
| 31 | #include <linux/aio.h> | ||
| 32 | 31 | ||
| 33 | #include "aops.h" | 32 | #include "aops.h" |
| 34 | #include "attrib.h" | 33 | #include "attrib.h" |
diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c index 44db1808cdb5..e1bf18c5d25e 100644 --- a/fs/ocfs2/aops.c +++ b/fs/ocfs2/aops.c | |||
| @@ -29,6 +29,7 @@ | |||
| 29 | #include <linux/mpage.h> | 29 | #include <linux/mpage.h> |
| 30 | #include <linux/quotaops.h> | 30 | #include <linux/quotaops.h> |
| 31 | #include <linux/blkdev.h> | 31 | #include <linux/blkdev.h> |
| 32 | #include <linux/uio.h> | ||
| 32 | 33 | ||
| 33 | #include <cluster/masklog.h> | 34 | #include <cluster/masklog.h> |
| 34 | 35 | ||
diff --git a/fs/ocfs2/aops.h b/fs/ocfs2/aops.h index 6cae155d54df..dd59599b022d 100644 --- a/fs/ocfs2/aops.h +++ b/fs/ocfs2/aops.h | |||
| @@ -22,7 +22,7 @@ | |||
| 22 | #ifndef OCFS2_AOPS_H | 22 | #ifndef OCFS2_AOPS_H |
| 23 | #define OCFS2_AOPS_H | 23 | #define OCFS2_AOPS_H |
| 24 | 24 | ||
| 25 | #include <linux/aio.h> | 25 | #include <linux/fs.h> |
| 26 | 26 | ||
| 27 | handle_t *ocfs2_start_walk_page_trans(struct inode *inode, | 27 | handle_t *ocfs2_start_walk_page_trans(struct inode *inode, |
| 28 | struct page *page, | 28 | struct page *page, |
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c index ba1790e52ff2..91f03ce98108 100644 --- a/fs/ocfs2/file.c +++ b/fs/ocfs2/file.c | |||
| @@ -2280,7 +2280,7 @@ static ssize_t ocfs2_file_write_iter(struct kiocb *iocb, | |||
| 2280 | file->f_path.dentry->d_name.name, | 2280 | file->f_path.dentry->d_name.name, |
| 2281 | (unsigned int)from->nr_segs); /* GRRRRR */ | 2281 | (unsigned int)from->nr_segs); /* GRRRRR */ |
| 2282 | 2282 | ||
| 2283 | if (iocb->ki_nbytes == 0) | 2283 | if (count == 0) |
| 2284 | return 0; | 2284 | return 0; |
| 2285 | 2285 | ||
| 2286 | appending = file->f_flags & O_APPEND ? 1 : 0; | 2286 | appending = file->f_flags & O_APPEND ? 1 : 0; |
| @@ -2330,8 +2330,7 @@ relock: | |||
| 2330 | } | 2330 | } |
| 2331 | 2331 | ||
| 2332 | can_do_direct = direct_io; | 2332 | can_do_direct = direct_io; |
| 2333 | ret = ocfs2_prepare_inode_for_write(file, ppos, | 2333 | ret = ocfs2_prepare_inode_for_write(file, ppos, count, appending, |
| 2334 | iocb->ki_nbytes, appending, | ||
| 2335 | &can_do_direct, &has_refcount); | 2334 | &can_do_direct, &has_refcount); |
| 2336 | if (ret < 0) { | 2335 | if (ret < 0) { |
| 2337 | mlog_errno(ret); | 2336 | mlog_errno(ret); |
| @@ -2339,8 +2338,7 @@ relock: | |||
| 2339 | } | 2338 | } |
| 2340 | 2339 | ||
| 2341 | if (direct_io && !is_sync_kiocb(iocb)) | 2340 | if (direct_io && !is_sync_kiocb(iocb)) |
| 2342 | unaligned_dio = ocfs2_is_io_unaligned(inode, iocb->ki_nbytes, | 2341 | unaligned_dio = ocfs2_is_io_unaligned(inode, count, *ppos); |
| 2343 | *ppos); | ||
| 2344 | 2342 | ||
| 2345 | /* | 2343 | /* |
| 2346 | * We can't complete the direct I/O as requested, fall back to | 2344 | * We can't complete the direct I/O as requested, fall back to |
| @@ -570,6 +570,7 @@ static int chown_common(struct path *path, uid_t user, gid_t group) | |||
| 570 | uid = make_kuid(current_user_ns(), user); | 570 | uid = make_kuid(current_user_ns(), user); |
| 571 | gid = make_kgid(current_user_ns(), group); | 571 | gid = make_kgid(current_user_ns(), group); |
| 572 | 572 | ||
| 573 | retry_deleg: | ||
| 573 | newattrs.ia_valid = ATTR_CTIME; | 574 | newattrs.ia_valid = ATTR_CTIME; |
| 574 | if (user != (uid_t) -1) { | 575 | if (user != (uid_t) -1) { |
| 575 | if (!uid_valid(uid)) | 576 | if (!uid_valid(uid)) |
| @@ -586,7 +587,6 @@ static int chown_common(struct path *path, uid_t user, gid_t group) | |||
| 586 | if (!S_ISDIR(inode->i_mode)) | 587 | if (!S_ISDIR(inode->i_mode)) |
| 587 | newattrs.ia_valid |= | 588 | newattrs.ia_valid |= |
| 588 | ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; | 589 | ATTR_KILL_SUID | ATTR_KILL_SGID | ATTR_KILL_PRIV; |
| 589 | retry_deleg: | ||
| 590 | mutex_lock(&inode->i_mutex); | 590 | mutex_lock(&inode->i_mutex); |
| 591 | error = security_path_chown(path, uid, gid); | 591 | error = security_path_chown(path, uid, gid); |
| 592 | if (!error) | 592 | if (!error) |
| @@ -988,9 +988,6 @@ struct file *file_open_root(struct dentry *dentry, struct vfsmount *mnt, | |||
| 988 | return ERR_PTR(err); | 988 | return ERR_PTR(err); |
| 989 | if (flags & O_CREAT) | 989 | if (flags & O_CREAT) |
| 990 | return ERR_PTR(-EINVAL); | 990 | return ERR_PTR(-EINVAL); |
| 991 | if (!filename && (flags & O_DIRECTORY)) | ||
| 992 | if (!dentry->d_inode->i_op->lookup) | ||
| 993 | return ERR_PTR(-ENOTDIR); | ||
| 994 | return do_file_open_root(dentry, mnt, filename, &op); | 991 | return do_file_open_root(dentry, mnt, filename, &op); |
| 995 | } | 992 | } |
| 996 | EXPORT_SYMBOL(file_open_root); | 993 | EXPORT_SYMBOL(file_open_root); |
| @@ -21,7 +21,6 @@ | |||
| 21 | #include <linux/audit.h> | 21 | #include <linux/audit.h> |
| 22 | #include <linux/syscalls.h> | 22 | #include <linux/syscalls.h> |
| 23 | #include <linux/fcntl.h> | 23 | #include <linux/fcntl.h> |
| 24 | #include <linux/aio.h> | ||
| 25 | 24 | ||
| 26 | #include <asm/uaccess.h> | 25 | #include <asm/uaccess.h> |
| 27 | #include <asm/ioctls.h> | 26 | #include <asm/ioctls.h> |
diff --git a/fs/read_write.c b/fs/read_write.c index 8e1b68786d66..69128b378646 100644 --- a/fs/read_write.c +++ b/fs/read_write.c | |||
| @@ -9,7 +9,6 @@ | |||
| 9 | #include <linux/fcntl.h> | 9 | #include <linux/fcntl.h> |
| 10 | #include <linux/file.h> | 10 | #include <linux/file.h> |
| 11 | #include <linux/uio.h> | 11 | #include <linux/uio.h> |
| 12 | #include <linux/aio.h> | ||
| 13 | #include <linux/fsnotify.h> | 12 | #include <linux/fsnotify.h> |
| 14 | #include <linux/security.h> | 13 | #include <linux/security.h> |
| 15 | #include <linux/export.h> | 14 | #include <linux/export.h> |
| @@ -343,13 +342,10 @@ ssize_t vfs_iter_read(struct file *file, struct iov_iter *iter, loff_t *ppos) | |||
| 343 | 342 | ||
| 344 | init_sync_kiocb(&kiocb, file); | 343 | init_sync_kiocb(&kiocb, file); |
| 345 | kiocb.ki_pos = *ppos; | 344 | kiocb.ki_pos = *ppos; |
| 346 | kiocb.ki_nbytes = iov_iter_count(iter); | ||
| 347 | 345 | ||
| 348 | iter->type |= READ; | 346 | iter->type |= READ; |
| 349 | ret = file->f_op->read_iter(&kiocb, iter); | 347 | ret = file->f_op->read_iter(&kiocb, iter); |
| 350 | if (ret == -EIOCBQUEUED) | 348 | BUG_ON(ret == -EIOCBQUEUED); |
| 351 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 352 | |||
| 353 | if (ret > 0) | 349 | if (ret > 0) |
| 354 | *ppos = kiocb.ki_pos; | 350 | *ppos = kiocb.ki_pos; |
| 355 | return ret; | 351 | return ret; |
| @@ -366,13 +362,10 @@ ssize_t vfs_iter_write(struct file *file, struct iov_iter *iter, loff_t *ppos) | |||
| 366 | 362 | ||
| 367 | init_sync_kiocb(&kiocb, file); | 363 | init_sync_kiocb(&kiocb, file); |
| 368 | kiocb.ki_pos = *ppos; | 364 | kiocb.ki_pos = *ppos; |
| 369 | kiocb.ki_nbytes = iov_iter_count(iter); | ||
| 370 | 365 | ||
| 371 | iter->type |= WRITE; | 366 | iter->type |= WRITE; |
| 372 | ret = file->f_op->write_iter(&kiocb, iter); | 367 | ret = file->f_op->write_iter(&kiocb, iter); |
| 373 | if (ret == -EIOCBQUEUED) | 368 | BUG_ON(ret == -EIOCBQUEUED); |
| 374 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 375 | |||
| 376 | if (ret > 0) | 369 | if (ret > 0) |
| 377 | *ppos = kiocb.ki_pos; | 370 | *ppos = kiocb.ki_pos; |
| 378 | return ret; | 371 | return ret; |
| @@ -426,11 +419,9 @@ ssize_t do_sync_read(struct file *filp, char __user *buf, size_t len, loff_t *pp | |||
| 426 | 419 | ||
| 427 | init_sync_kiocb(&kiocb, filp); | 420 | init_sync_kiocb(&kiocb, filp); |
| 428 | kiocb.ki_pos = *ppos; | 421 | kiocb.ki_pos = *ppos; |
| 429 | kiocb.ki_nbytes = len; | ||
| 430 | 422 | ||
| 431 | ret = filp->f_op->aio_read(&kiocb, &iov, 1, kiocb.ki_pos); | 423 | ret = filp->f_op->aio_read(&kiocb, &iov, 1, kiocb.ki_pos); |
| 432 | if (-EIOCBQUEUED == ret) | 424 | BUG_ON(ret == -EIOCBQUEUED); |
| 433 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 434 | *ppos = kiocb.ki_pos; | 425 | *ppos = kiocb.ki_pos; |
| 435 | return ret; | 426 | return ret; |
| 436 | } | 427 | } |
| @@ -446,12 +437,10 @@ ssize_t new_sync_read(struct file *filp, char __user *buf, size_t len, loff_t *p | |||
| 446 | 437 | ||
| 447 | init_sync_kiocb(&kiocb, filp); | 438 | init_sync_kiocb(&kiocb, filp); |
| 448 | kiocb.ki_pos = *ppos; | 439 | kiocb.ki_pos = *ppos; |
| 449 | kiocb.ki_nbytes = len; | ||
| 450 | iov_iter_init(&iter, READ, &iov, 1, len); | 440 | iov_iter_init(&iter, READ, &iov, 1, len); |
| 451 | 441 | ||
| 452 | ret = filp->f_op->read_iter(&kiocb, &iter); | 442 | ret = filp->f_op->read_iter(&kiocb, &iter); |
| 453 | if (-EIOCBQUEUED == ret) | 443 | BUG_ON(ret == -EIOCBQUEUED); |
| 454 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 455 | *ppos = kiocb.ki_pos; | 444 | *ppos = kiocb.ki_pos; |
| 456 | return ret; | 445 | return ret; |
| 457 | } | 446 | } |
| @@ -510,11 +499,9 @@ ssize_t do_sync_write(struct file *filp, const char __user *buf, size_t len, lof | |||
| 510 | 499 | ||
| 511 | init_sync_kiocb(&kiocb, filp); | 500 | init_sync_kiocb(&kiocb, filp); |
| 512 | kiocb.ki_pos = *ppos; | 501 | kiocb.ki_pos = *ppos; |
| 513 | kiocb.ki_nbytes = len; | ||
| 514 | 502 | ||
| 515 | ret = filp->f_op->aio_write(&kiocb, &iov, 1, kiocb.ki_pos); | 503 | ret = filp->f_op->aio_write(&kiocb, &iov, 1, kiocb.ki_pos); |
| 516 | if (-EIOCBQUEUED == ret) | 504 | BUG_ON(ret == -EIOCBQUEUED); |
| 517 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 518 | *ppos = kiocb.ki_pos; | 505 | *ppos = kiocb.ki_pos; |
| 519 | return ret; | 506 | return ret; |
| 520 | } | 507 | } |
| @@ -530,12 +517,10 @@ ssize_t new_sync_write(struct file *filp, const char __user *buf, size_t len, lo | |||
| 530 | 517 | ||
| 531 | init_sync_kiocb(&kiocb, filp); | 518 | init_sync_kiocb(&kiocb, filp); |
| 532 | kiocb.ki_pos = *ppos; | 519 | kiocb.ki_pos = *ppos; |
| 533 | kiocb.ki_nbytes = len; | ||
| 534 | iov_iter_init(&iter, WRITE, &iov, 1, len); | 520 | iov_iter_init(&iter, WRITE, &iov, 1, len); |
| 535 | 521 | ||
| 536 | ret = filp->f_op->write_iter(&kiocb, &iter); | 522 | ret = filp->f_op->write_iter(&kiocb, &iter); |
| 537 | if (-EIOCBQUEUED == ret) | 523 | BUG_ON(ret == -EIOCBQUEUED); |
| 538 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 539 | *ppos = kiocb.ki_pos; | 524 | *ppos = kiocb.ki_pos; |
| 540 | return ret; | 525 | return ret; |
| 541 | } | 526 | } |
| @@ -710,60 +695,47 @@ unsigned long iov_shorten(struct iovec *iov, unsigned long nr_segs, size_t to) | |||
| 710 | } | 695 | } |
| 711 | EXPORT_SYMBOL(iov_shorten); | 696 | EXPORT_SYMBOL(iov_shorten); |
| 712 | 697 | ||
| 713 | static ssize_t do_iter_readv_writev(struct file *filp, int rw, const struct iovec *iov, | 698 | static ssize_t do_iter_readv_writev(struct file *filp, struct iov_iter *iter, |
| 714 | unsigned long nr_segs, size_t len, loff_t *ppos, iter_fn_t fn) | 699 | loff_t *ppos, iter_fn_t fn) |
| 715 | { | 700 | { |
| 716 | struct kiocb kiocb; | 701 | struct kiocb kiocb; |
| 717 | struct iov_iter iter; | ||
| 718 | ssize_t ret; | 702 | ssize_t ret; |
| 719 | 703 | ||
| 720 | init_sync_kiocb(&kiocb, filp); | 704 | init_sync_kiocb(&kiocb, filp); |
| 721 | kiocb.ki_pos = *ppos; | 705 | kiocb.ki_pos = *ppos; |
| 722 | kiocb.ki_nbytes = len; | ||
| 723 | 706 | ||
| 724 | iov_iter_init(&iter, rw, iov, nr_segs, len); | 707 | ret = fn(&kiocb, iter); |
| 725 | ret = fn(&kiocb, &iter); | 708 | BUG_ON(ret == -EIOCBQUEUED); |
| 726 | if (ret == -EIOCBQUEUED) | ||
| 727 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 728 | *ppos = kiocb.ki_pos; | 709 | *ppos = kiocb.ki_pos; |
| 729 | return ret; | 710 | return ret; |
| 730 | } | 711 | } |
| 731 | 712 | ||
| 732 | static ssize_t do_sync_readv_writev(struct file *filp, const struct iovec *iov, | 713 | static ssize_t do_sync_readv_writev(struct file *filp, struct iov_iter *iter, |
| 733 | unsigned long nr_segs, size_t len, loff_t *ppos, iov_fn_t fn) | 714 | loff_t *ppos, iov_fn_t fn) |
| 734 | { | 715 | { |
| 735 | struct kiocb kiocb; | 716 | struct kiocb kiocb; |
| 736 | ssize_t ret; | 717 | ssize_t ret; |
| 737 | 718 | ||
| 738 | init_sync_kiocb(&kiocb, filp); | 719 | init_sync_kiocb(&kiocb, filp); |
| 739 | kiocb.ki_pos = *ppos; | 720 | kiocb.ki_pos = *ppos; |
| 740 | kiocb.ki_nbytes = len; | ||
| 741 | 721 | ||
| 742 | ret = fn(&kiocb, iov, nr_segs, kiocb.ki_pos); | 722 | ret = fn(&kiocb, iter->iov, iter->nr_segs, kiocb.ki_pos); |
| 743 | if (ret == -EIOCBQUEUED) | 723 | BUG_ON(ret == -EIOCBQUEUED); |
| 744 | ret = wait_on_sync_kiocb(&kiocb); | ||
| 745 | *ppos = kiocb.ki_pos; | 724 | *ppos = kiocb.ki_pos; |
| 746 | return ret; | 725 | return ret; |
| 747 | } | 726 | } |
| 748 | 727 | ||
| 749 | /* Do it by hand, with file-ops */ | 728 | /* Do it by hand, with file-ops */ |
| 750 | static ssize_t do_loop_readv_writev(struct file *filp, struct iovec *iov, | 729 | static ssize_t do_loop_readv_writev(struct file *filp, struct iov_iter *iter, |
| 751 | unsigned long nr_segs, loff_t *ppos, io_fn_t fn) | 730 | loff_t *ppos, io_fn_t fn) |
| 752 | { | 731 | { |
| 753 | struct iovec *vector = iov; | ||
| 754 | ssize_t ret = 0; | 732 | ssize_t ret = 0; |
| 755 | 733 | ||
| 756 | while (nr_segs > 0) { | 734 | while (iov_iter_count(iter)) { |
| 757 | void __user *base; | 735 | struct iovec iovec = iov_iter_iovec(iter); |
| 758 | size_t len; | ||
| 759 | ssize_t nr; | 736 | ssize_t nr; |
| 760 | 737 | ||
| 761 | base = vector->iov_base; | 738 | nr = fn(filp, iovec.iov_base, iovec.iov_len, ppos); |
| 762 | len = vector->iov_len; | ||
| 763 | vector++; | ||
| 764 | nr_segs--; | ||
| 765 | |||
| 766 | nr = fn(filp, base, len, ppos); | ||
| 767 | 739 | ||
| 768 | if (nr < 0) { | 740 | if (nr < 0) { |
| 769 | if (!ret) | 741 | if (!ret) |
| @@ -771,8 +743,9 @@ static ssize_t do_loop_readv_writev(struct file *filp, struct iovec *iov, | |||
| 771 | break; | 743 | break; |
| 772 | } | 744 | } |
| 773 | ret += nr; | 745 | ret += nr; |
| 774 | if (nr != len) | 746 | if (nr != iovec.iov_len) |
| 775 | break; | 747 | break; |
| 748 | iov_iter_advance(iter, nr); | ||
| 776 | } | 749 | } |
| 777 | 750 | ||
| 778 | return ret; | 751 | return ret; |
| @@ -863,17 +836,20 @@ static ssize_t do_readv_writev(int type, struct file *file, | |||
| 863 | size_t tot_len; | 836 | size_t tot_len; |
| 864 | struct iovec iovstack[UIO_FASTIOV]; | 837 | struct iovec iovstack[UIO_FASTIOV]; |
| 865 | struct iovec *iov = iovstack; | 838 | struct iovec *iov = iovstack; |
| 839 | struct iov_iter iter; | ||
| 866 | ssize_t ret; | 840 | ssize_t ret; |
| 867 | io_fn_t fn; | 841 | io_fn_t fn; |
| 868 | iov_fn_t fnv; | 842 | iov_fn_t fnv; |
| 869 | iter_fn_t iter_fn; | 843 | iter_fn_t iter_fn; |
| 870 | 844 | ||
| 871 | ret = rw_copy_check_uvector(type, uvector, nr_segs, | 845 | ret = import_iovec(type, uvector, nr_segs, |
| 872 | ARRAY_SIZE(iovstack), iovstack, &iov); | 846 | ARRAY_SIZE(iovstack), &iov, &iter); |
| 873 | if (ret <= 0) | 847 | if (ret < 0) |
| 874 | goto out; | 848 | return ret; |
| 875 | 849 | ||
| 876 | tot_len = ret; | 850 | tot_len = iov_iter_count(&iter); |
| 851 | if (!tot_len) | ||
| 852 | goto out; | ||
| 877 | ret = rw_verify_area(type, file, pos, tot_len); | 853 | ret = rw_verify_area(type, file, pos, tot_len); |
| 878 | if (ret < 0) | 854 | if (ret < 0) |
| 879 | goto out; | 855 | goto out; |
| @@ -891,20 +867,17 @@ static ssize_t do_readv_writev(int type, struct file *file, | |||
| 891 | } | 867 | } |
| 892 | 868 | ||
| 893 | if (iter_fn) | 869 | if (iter_fn) |
| 894 | ret = do_iter_readv_writev(file, type, iov, nr_segs, tot_len, | 870 | ret = do_iter_readv_writev(file, &iter, pos, iter_fn); |
| 895 | pos, iter_fn); | ||
| 896 | else if (fnv) | 871 | else if (fnv) |
| 897 | ret = do_sync_readv_writev(file, iov, nr_segs, tot_len, | 872 | ret = do_sync_readv_writev(file, &iter, pos, fnv); |
| 898 | pos, fnv); | ||
| 899 | else | 873 | else |
| 900 | ret = do_loop_readv_writev(file, iov, nr_segs, pos, fn); | 874 | ret = do_loop_readv_writev(file, &iter, pos, fn); |
| 901 | 875 | ||
| 902 | if (type != READ) | 876 | if (type != READ) |
| 903 | file_end_write(file); | 877 | file_end_write(file); |
| 904 | 878 | ||
| 905 | out: | 879 | out: |
| 906 | if (iov != iovstack) | 880 | kfree(iov); |
| 907 | kfree(iov); | ||
| 908 | if ((ret + (type == READ)) > 0) { | 881 | if ((ret + (type == READ)) > 0) { |
| 909 | if (type == READ) | 882 | if (type == READ) |
| 910 | fsnotify_access(file); | 883 | fsnotify_access(file); |
| @@ -1043,17 +1016,20 @@ static ssize_t compat_do_readv_writev(int type, struct file *file, | |||
| 1043 | compat_ssize_t tot_len; | 1016 | compat_ssize_t tot_len; |
| 1044 | struct iovec iovstack[UIO_FASTIOV]; | 1017 | struct iovec iovstack[UIO_FASTIOV]; |
| 1045 | struct iovec *iov = iovstack; | 1018 | struct iovec *iov = iovstack; |
| 1019 | struct iov_iter iter; | ||
| 1046 | ssize_t ret; | 1020 | ssize_t ret; |
| 1047 | io_fn_t fn; | 1021 | io_fn_t fn; |
| 1048 | iov_fn_t fnv; | 1022 | iov_fn_t fnv; |
| 1049 | iter_fn_t iter_fn; | 1023 | iter_fn_t iter_fn; |
| 1050 | 1024 | ||
| 1051 | ret = compat_rw_copy_check_uvector(type, uvector, nr_segs, | 1025 | ret = compat_import_iovec(type, uvector, nr_segs, |
| 1052 | UIO_FASTIOV, iovstack, &iov); | 1026 | UIO_FASTIOV, &iov, &iter); |
| 1053 | if (ret <= 0) | 1027 | if (ret < 0) |
| 1054 | goto out; | 1028 | return ret; |
| 1055 | 1029 | ||
| 1056 | tot_len = ret; | 1030 | tot_len = iov_iter_count(&iter); |
| 1031 | if (!tot_len) | ||
| 1032 | goto out; | ||
| 1057 | ret = rw_verify_area(type, file, pos, tot_len); | 1033 | ret = rw_verify_area(type, file, pos, tot_len); |
| 1058 | if (ret < 0) | 1034 | if (ret < 0) |
| 1059 | goto out; | 1035 | goto out; |
| @@ -1071,20 +1047,17 @@ static ssize_t compat_do_readv_writev(int type, struct file *file, | |||
| 1071 | } | 1047 | } |
| 1072 | 1048 | ||
| 1073 | if (iter_fn) | 1049 | if (iter_fn) |
| 1074 | ret = do_iter_readv_writev(file, type, iov, nr_segs, tot_len, | 1050 | ret = do_iter_readv_writev(file, &iter, pos, iter_fn); |
| 1075 | pos, iter_fn); | ||
| 1076 | else if (fnv) | 1051 | else if (fnv) |
| 1077 | ret = do_sync_readv_writev(file, iov, nr_segs, tot_len, | 1052 | ret = do_sync_readv_writev(file, &iter, pos, fnv); |
| 1078 | pos, fnv); | ||
| 1079 | else | 1053 | else |
| 1080 | ret = do_loop_readv_writev(file, iov, nr_segs, pos, fn); | 1054 | ret = do_loop_readv_writev(file, &iter, pos, fn); |
| 1081 | 1055 | ||
| 1082 | if (type != READ) | 1056 | if (type != READ) |
| 1083 | file_end_write(file); | 1057 | file_end_write(file); |
| 1084 | 1058 | ||
| 1085 | out: | 1059 | out: |
| 1086 | if (iov != iovstack) | 1060 | kfree(iov); |
| 1087 | kfree(iov); | ||
| 1088 | if ((ret + (type == READ)) > 0) { | 1061 | if ((ret + (type == READ)) > 0) { |
| 1089 | if (type == READ) | 1062 | if (type == READ) |
| 1090 | fsnotify_access(file); | 1063 | fsnotify_access(file); |
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index e72401e1f995..9312b7842e03 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
| @@ -18,7 +18,7 @@ | |||
| 18 | #include <linux/writeback.h> | 18 | #include <linux/writeback.h> |
| 19 | #include <linux/quotaops.h> | 19 | #include <linux/quotaops.h> |
| 20 | #include <linux/swap.h> | 20 | #include <linux/swap.h> |
| 21 | #include <linux/aio.h> | 21 | #include <linux/uio.h> |
| 22 | 22 | ||
| 23 | int reiserfs_commit_write(struct file *f, struct page *page, | 23 | int reiserfs_commit_write(struct file *f, struct page *page, |
| 24 | unsigned from, unsigned to); | 24 | unsigned from, unsigned to); |
diff --git a/fs/splice.c b/fs/splice.c index 7968da96bebb..41cbb16299e0 100644 --- a/fs/splice.c +++ b/fs/splice.c | |||
| @@ -32,7 +32,6 @@ | |||
| 32 | #include <linux/gfp.h> | 32 | #include <linux/gfp.h> |
| 33 | #include <linux/socket.h> | 33 | #include <linux/socket.h> |
| 34 | #include <linux/compat.h> | 34 | #include <linux/compat.h> |
| 35 | #include <linux/aio.h> | ||
| 36 | #include "internal.h" | 35 | #include "internal.h" |
| 37 | 36 | ||
| 38 | /* | 37 | /* |
| @@ -1534,34 +1533,29 @@ static long vmsplice_to_user(struct file *file, const struct iovec __user *uiov, | |||
| 1534 | struct iovec iovstack[UIO_FASTIOV]; | 1533 | struct iovec iovstack[UIO_FASTIOV]; |
| 1535 | struct iovec *iov = iovstack; | 1534 | struct iovec *iov = iovstack; |
| 1536 | struct iov_iter iter; | 1535 | struct iov_iter iter; |
| 1537 | ssize_t count; | ||
| 1538 | 1536 | ||
| 1539 | pipe = get_pipe_info(file); | 1537 | pipe = get_pipe_info(file); |
| 1540 | if (!pipe) | 1538 | if (!pipe) |
| 1541 | return -EBADF; | 1539 | return -EBADF; |
| 1542 | 1540 | ||
| 1543 | ret = rw_copy_check_uvector(READ, uiov, nr_segs, | 1541 | ret = import_iovec(READ, uiov, nr_segs, |
| 1544 | ARRAY_SIZE(iovstack), iovstack, &iov); | 1542 | ARRAY_SIZE(iovstack), &iov, &iter); |
| 1545 | if (ret <= 0) | 1543 | if (ret < 0) |
| 1546 | goto out; | 1544 | return ret; |
| 1547 | |||
| 1548 | count = ret; | ||
| 1549 | iov_iter_init(&iter, READ, iov, nr_segs, count); | ||
| 1550 | 1545 | ||
| 1546 | sd.total_len = iov_iter_count(&iter); | ||
| 1551 | sd.len = 0; | 1547 | sd.len = 0; |
| 1552 | sd.total_len = count; | ||
| 1553 | sd.flags = flags; | 1548 | sd.flags = flags; |
| 1554 | sd.u.data = &iter; | 1549 | sd.u.data = &iter; |
| 1555 | sd.pos = 0; | 1550 | sd.pos = 0; |
| 1556 | 1551 | ||
| 1557 | pipe_lock(pipe); | 1552 | if (sd.total_len) { |
| 1558 | ret = __splice_from_pipe(pipe, &sd, pipe_to_user); | 1553 | pipe_lock(pipe); |
| 1559 | pipe_unlock(pipe); | 1554 | ret = __splice_from_pipe(pipe, &sd, pipe_to_user); |
| 1560 | 1555 | pipe_unlock(pipe); | |
| 1561 | out: | 1556 | } |
| 1562 | if (iov != iovstack) | ||
| 1563 | kfree(iov); | ||
| 1564 | 1557 | ||
| 1558 | kfree(iov); | ||
| 1565 | return ret; | 1559 | return ret; |
| 1566 | } | 1560 | } |
| 1567 | 1561 | ||
| @@ -66,7 +66,7 @@ int vfs_getattr(struct path *path, struct kstat *stat) | |||
| 66 | { | 66 | { |
| 67 | int retval; | 67 | int retval; |
| 68 | 68 | ||
| 69 | retval = security_inode_getattr(path->mnt, path->dentry); | 69 | retval = security_inode_getattr(path); |
| 70 | if (retval) | 70 | if (retval) |
| 71 | return retval; | 71 | return retval; |
| 72 | return vfs_getattr_nosec(path, stat); | 72 | return vfs_getattr_nosec(path, stat); |
diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c index e627c0acf626..c3d15fe83403 100644 --- a/fs/ubifs/file.c +++ b/fs/ubifs/file.c | |||
| @@ -50,7 +50,6 @@ | |||
| 50 | */ | 50 | */ |
| 51 | 51 | ||
| 52 | #include "ubifs.h" | 52 | #include "ubifs.h" |
| 53 | #include <linux/aio.h> | ||
| 54 | #include <linux/mount.h> | 53 | #include <linux/mount.h> |
| 55 | #include <linux/namei.h> | 54 | #include <linux/namei.h> |
| 56 | #include <linux/slab.h> | 55 | #include <linux/slab.h> |
diff --git a/fs/udf/file.c b/fs/udf/file.c index 08f3555fbeac..7f885cc8b0b7 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c | |||
| @@ -34,7 +34,7 @@ | |||
| 34 | #include <linux/errno.h> | 34 | #include <linux/errno.h> |
| 35 | #include <linux/pagemap.h> | 35 | #include <linux/pagemap.h> |
| 36 | #include <linux/buffer_head.h> | 36 | #include <linux/buffer_head.h> |
| 37 | #include <linux/aio.h> | 37 | #include <linux/uio.h> |
| 38 | 38 | ||
| 39 | #include "udf_i.h" | 39 | #include "udf_i.h" |
| 40 | #include "udf_sb.h" | 40 | #include "udf_sb.h" |
| @@ -122,7 +122,7 @@ static ssize_t udf_file_write_iter(struct kiocb *iocb, struct iov_iter *from) | |||
| 122 | struct file *file = iocb->ki_filp; | 122 | struct file *file = iocb->ki_filp; |
| 123 | struct inode *inode = file_inode(file); | 123 | struct inode *inode = file_inode(file); |
| 124 | int err, pos; | 124 | int err, pos; |
| 125 | size_t count = iocb->ki_nbytes; | 125 | size_t count = iov_iter_count(from); |
| 126 | struct udf_inode_info *iinfo = UDF_I(inode); | 126 | struct udf_inode_info *iinfo = UDF_I(inode); |
| 127 | 127 | ||
| 128 | mutex_lock(&inode->i_mutex); | 128 | mutex_lock(&inode->i_mutex); |
diff --git a/fs/udf/inode.c b/fs/udf/inode.c index a445d599098d..9c1fbd23913d 100644 --- a/fs/udf/inode.c +++ b/fs/udf/inode.c | |||
| @@ -38,7 +38,7 @@ | |||
| 38 | #include <linux/slab.h> | 38 | #include <linux/slab.h> |
| 39 | #include <linux/crc-itu-t.h> | 39 | #include <linux/crc-itu-t.h> |
| 40 | #include <linux/mpage.h> | 40 | #include <linux/mpage.h> |
| 41 | #include <linux/aio.h> | 41 | #include <linux/uio.h> |
| 42 | 42 | ||
| 43 | #include "udf_i.h" | 43 | #include "udf_i.h" |
| 44 | #include "udf_sb.h" | 44 | #include "udf_sb.h" |
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 3a9b7a1b8704..4f8cdc59bc38 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c | |||
| @@ -31,7 +31,6 @@ | |||
| 31 | #include "xfs_bmap.h" | 31 | #include "xfs_bmap.h" |
| 32 | #include "xfs_bmap_util.h" | 32 | #include "xfs_bmap_util.h" |
| 33 | #include "xfs_bmap_btree.h" | 33 | #include "xfs_bmap_btree.h" |
| 34 | #include <linux/aio.h> | ||
| 35 | #include <linux/gfp.h> | 34 | #include <linux/gfp.h> |
| 36 | #include <linux/mpage.h> | 35 | #include <linux/mpage.h> |
| 37 | #include <linux/pagevec.h> | 36 | #include <linux/pagevec.h> |
diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index a2e1cb8a568b..f44212fae653 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c | |||
| @@ -38,7 +38,6 @@ | |||
| 38 | #include "xfs_icache.h" | 38 | #include "xfs_icache.h" |
| 39 | #include "xfs_pnfs.h" | 39 | #include "xfs_pnfs.h" |
| 40 | 40 | ||
| 41 | #include <linux/aio.h> | ||
| 42 | #include <linux/dcache.h> | 41 | #include <linux/dcache.h> |
| 43 | #include <linux/falloc.h> | 42 | #include <linux/falloc.h> |
| 44 | #include <linux/pagevec.h> | 43 | #include <linux/pagevec.h> |
diff --git a/include/linux/aio.h b/include/linux/aio.h index d9c92daa3944..9eb42dbc5582 100644 --- a/include/linux/aio.h +++ b/include/linux/aio.h | |||
| @@ -1,86 +1,23 @@ | |||
| 1 | #ifndef __LINUX__AIO_H | 1 | #ifndef __LINUX__AIO_H |
| 2 | #define __LINUX__AIO_H | 2 | #define __LINUX__AIO_H |
| 3 | 3 | ||
| 4 | #include <linux/list.h> | ||
| 5 | #include <linux/workqueue.h> | ||
| 6 | #include <linux/aio_abi.h> | 4 | #include <linux/aio_abi.h> |
| 7 | #include <linux/uio.h> | ||
| 8 | #include <linux/rcupdate.h> | ||
| 9 | |||
| 10 | #include <linux/atomic.h> | ||
| 11 | 5 | ||
| 12 | struct kioctx; | 6 | struct kioctx; |
| 13 | struct kiocb; | 7 | struct kiocb; |
| 8 | struct mm_struct; | ||
| 14 | 9 | ||
| 15 | #define KIOCB_KEY 0 | 10 | #define KIOCB_KEY 0 |
| 16 | 11 | ||
| 17 | /* | ||
| 18 | * We use ki_cancel == KIOCB_CANCELLED to indicate that a kiocb has been either | ||
| 19 | * cancelled or completed (this makes a certain amount of sense because | ||
| 20 | * successful cancellation - io_cancel() - does deliver the completion to | ||
| 21 | * userspace). | ||
| 22 | * | ||
| 23 | * And since most things don't implement kiocb cancellation and we'd really like | ||
| 24 | * kiocb completion to be lockless when possible, we use ki_cancel to | ||
| 25 | * synchronize cancellation and completion - we only set it to KIOCB_CANCELLED | ||
| 26 | * with xchg() or cmpxchg(), see batch_complete_aio() and kiocb_cancel(). | ||
| 27 | */ | ||
| 28 | #define KIOCB_CANCELLED ((void *) (~0ULL)) | ||
| 29 | |||
| 30 | typedef int (kiocb_cancel_fn)(struct kiocb *); | 12 | typedef int (kiocb_cancel_fn)(struct kiocb *); |
| 31 | 13 | ||
| 32 | struct kiocb { | ||
| 33 | struct file *ki_filp; | ||
| 34 | struct kioctx *ki_ctx; /* NULL for sync ops */ | ||
| 35 | kiocb_cancel_fn *ki_cancel; | ||
| 36 | void *private; | ||
| 37 | |||
| 38 | union { | ||
| 39 | void __user *user; | ||
| 40 | struct task_struct *tsk; | ||
| 41 | } ki_obj; | ||
| 42 | |||
| 43 | __u64 ki_user_data; /* user's data for completion */ | ||
| 44 | loff_t ki_pos; | ||
| 45 | size_t ki_nbytes; /* copy of iocb->aio_nbytes */ | ||
| 46 | |||
| 47 | struct list_head ki_list; /* the aio core uses this | ||
| 48 | * for cancellation */ | ||
| 49 | |||
| 50 | /* | ||
| 51 | * If the aio_resfd field of the userspace iocb is not zero, | ||
| 52 | * this is the underlying eventfd context to deliver events to. | ||
| 53 | */ | ||
| 54 | struct eventfd_ctx *ki_eventfd; | ||
| 55 | }; | ||
| 56 | |||
| 57 | static inline bool is_sync_kiocb(struct kiocb *kiocb) | ||
| 58 | { | ||
| 59 | return kiocb->ki_ctx == NULL; | ||
| 60 | } | ||
| 61 | |||
| 62 | static inline void init_sync_kiocb(struct kiocb *kiocb, struct file *filp) | ||
| 63 | { | ||
| 64 | *kiocb = (struct kiocb) { | ||
| 65 | .ki_ctx = NULL, | ||
| 66 | .ki_filp = filp, | ||
| 67 | .ki_obj.tsk = current, | ||
| 68 | }; | ||
| 69 | } | ||
| 70 | |||
| 71 | /* prototypes */ | 14 | /* prototypes */ |
| 72 | #ifdef CONFIG_AIO | 15 | #ifdef CONFIG_AIO |
| 73 | extern ssize_t wait_on_sync_kiocb(struct kiocb *iocb); | ||
| 74 | extern void aio_complete(struct kiocb *iocb, long res, long res2); | ||
| 75 | struct mm_struct; | ||
| 76 | extern void exit_aio(struct mm_struct *mm); | 16 | extern void exit_aio(struct mm_struct *mm); |
| 77 | extern long do_io_submit(aio_context_t ctx_id, long nr, | 17 | extern long do_io_submit(aio_context_t ctx_id, long nr, |
| 78 | struct iocb __user *__user *iocbpp, bool compat); | 18 | struct iocb __user *__user *iocbpp, bool compat); |
| 79 | void kiocb_set_cancel_fn(struct kiocb *req, kiocb_cancel_fn *cancel); | 19 | void kiocb_set_cancel_fn(struct kiocb *req, kiocb_cancel_fn *cancel); |
| 80 | #else | 20 | #else |
| 81 | static inline ssize_t wait_on_sync_kiocb(struct kiocb *iocb) { return 0; } | ||
| 82 | static inline void aio_complete(struct kiocb *iocb, long res, long res2) { } | ||
| 83 | struct mm_struct; | ||
| 84 | static inline void exit_aio(struct mm_struct *mm) { } | 21 | static inline void exit_aio(struct mm_struct *mm) { } |
| 85 | static inline long do_io_submit(aio_context_t ctx_id, long nr, | 22 | static inline long do_io_submit(aio_context_t ctx_id, long nr, |
| 86 | struct iocb __user * __user *iocbpp, | 23 | struct iocb __user * __user *iocbpp, |
| @@ -89,11 +26,6 @@ static inline void kiocb_set_cancel_fn(struct kiocb *req, | |||
| 89 | kiocb_cancel_fn *cancel) { } | 26 | kiocb_cancel_fn *cancel) { } |
| 90 | #endif /* CONFIG_AIO */ | 27 | #endif /* CONFIG_AIO */ |
| 91 | 28 | ||
| 92 | static inline struct kiocb *list_kiocb(struct list_head *h) | ||
| 93 | { | ||
| 94 | return list_entry(h, struct kiocb, ki_list); | ||
| 95 | } | ||
| 96 | |||
| 97 | /* for sysctl: */ | 29 | /* for sysctl: */ |
| 98 | extern unsigned long aio_nr; | 30 | extern unsigned long aio_nr; |
| 99 | extern unsigned long aio_max_nr; | 31 | extern unsigned long aio_max_nr; |
diff --git a/include/linux/fs.h b/include/linux/fs.h index 52cc4492cb3a..d502e5436c84 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h | |||
| @@ -314,6 +314,28 @@ struct page; | |||
| 314 | struct address_space; | 314 | struct address_space; |
| 315 | struct writeback_control; | 315 | struct writeback_control; |
| 316 | 316 | ||
| 317 | #define IOCB_EVENTFD (1 << 0) | ||
| 318 | |||
| 319 | struct kiocb { | ||
| 320 | struct file *ki_filp; | ||
| 321 | loff_t ki_pos; | ||
| 322 | void (*ki_complete)(struct kiocb *iocb, long ret, long ret2); | ||
| 323 | void *private; | ||
| 324 | int ki_flags; | ||
| 325 | }; | ||
| 326 | |||
| 327 | static inline bool is_sync_kiocb(struct kiocb *kiocb) | ||
| 328 | { | ||
| 329 | return kiocb->ki_complete == NULL; | ||
| 330 | } | ||
| 331 | |||
| 332 | static inline void init_sync_kiocb(struct kiocb *kiocb, struct file *filp) | ||
| 333 | { | ||
| 334 | *kiocb = (struct kiocb) { | ||
| 335 | .ki_filp = filp, | ||
| 336 | }; | ||
| 337 | } | ||
| 338 | |||
| 317 | /* | 339 | /* |
| 318 | * "descriptor" for what we're up to with a read. | 340 | * "descriptor" for what we're up to with a read. |
| 319 | * This allows us to use the same read code yet | 341 | * This allows us to use the same read code yet |
| @@ -2145,7 +2167,7 @@ struct filename { | |||
| 2145 | const __user char *uptr; /* original userland pointer */ | 2167 | const __user char *uptr; /* original userland pointer */ |
| 2146 | struct audit_names *aname; | 2168 | struct audit_names *aname; |
| 2147 | int refcnt; | 2169 | int refcnt; |
| 2148 | bool separate; /* should "name" be freed? */ | 2170 | const char iname[]; |
| 2149 | }; | 2171 | }; |
| 2150 | 2172 | ||
| 2151 | extern long vfs_truncate(struct path *, loff_t); | 2173 | extern long vfs_truncate(struct path *, loff_t); |
diff --git a/include/linux/security.h b/include/linux/security.h index a1b7dbd127ff..4e14e3d6309f 100644 --- a/include/linux/security.h +++ b/include/linux/security.h | |||
| @@ -1556,7 +1556,7 @@ struct security_operations { | |||
| 1556 | int (*inode_follow_link) (struct dentry *dentry, struct nameidata *nd); | 1556 | int (*inode_follow_link) (struct dentry *dentry, struct nameidata *nd); |
| 1557 | int (*inode_permission) (struct inode *inode, int mask); | 1557 | int (*inode_permission) (struct inode *inode, int mask); |
| 1558 | int (*inode_setattr) (struct dentry *dentry, struct iattr *attr); | 1558 | int (*inode_setattr) (struct dentry *dentry, struct iattr *attr); |
| 1559 | int (*inode_getattr) (struct vfsmount *mnt, struct dentry *dentry); | 1559 | int (*inode_getattr) (const struct path *path); |
| 1560 | int (*inode_setxattr) (struct dentry *dentry, const char *name, | 1560 | int (*inode_setxattr) (struct dentry *dentry, const char *name, |
| 1561 | const void *value, size_t size, int flags); | 1561 | const void *value, size_t size, int flags); |
| 1562 | void (*inode_post_setxattr) (struct dentry *dentry, const char *name, | 1562 | void (*inode_post_setxattr) (struct dentry *dentry, const char *name, |
| @@ -1843,7 +1843,7 @@ int security_inode_readlink(struct dentry *dentry); | |||
| 1843 | int security_inode_follow_link(struct dentry *dentry, struct nameidata *nd); | 1843 | int security_inode_follow_link(struct dentry *dentry, struct nameidata *nd); |
| 1844 | int security_inode_permission(struct inode *inode, int mask); | 1844 | int security_inode_permission(struct inode *inode, int mask); |
| 1845 | int security_inode_setattr(struct dentry *dentry, struct iattr *attr); | 1845 | int security_inode_setattr(struct dentry *dentry, struct iattr *attr); |
| 1846 | int security_inode_getattr(struct vfsmount *mnt, struct dentry *dentry); | 1846 | int security_inode_getattr(const struct path *path); |
| 1847 | int security_inode_setxattr(struct dentry *dentry, const char *name, | 1847 | int security_inode_setxattr(struct dentry *dentry, const char *name, |
| 1848 | const void *value, size_t size, int flags); | 1848 | const void *value, size_t size, int flags); |
| 1849 | void security_inode_post_setxattr(struct dentry *dentry, const char *name, | 1849 | void security_inode_post_setxattr(struct dentry *dentry, const char *name, |
| @@ -2259,8 +2259,7 @@ static inline int security_inode_setattr(struct dentry *dentry, | |||
| 2259 | return 0; | 2259 | return 0; |
| 2260 | } | 2260 | } |
| 2261 | 2261 | ||
| 2262 | static inline int security_inode_getattr(struct vfsmount *mnt, | 2262 | static inline int security_inode_getattr(const struct path *path) |
| 2263 | struct dentry *dentry) | ||
| 2264 | { | 2263 | { |
| 2265 | return 0; | 2264 | return 0; |
| 2266 | } | 2265 | } |
diff --git a/include/linux/uio.h b/include/linux/uio.h index 71880299ed48..15f11fb9fff6 100644 --- a/include/linux/uio.h +++ b/include/linux/uio.h | |||
| @@ -76,6 +76,7 @@ size_t iov_iter_copy_from_user_atomic(struct page *page, | |||
| 76 | struct iov_iter *i, unsigned long offset, size_t bytes); | 76 | struct iov_iter *i, unsigned long offset, size_t bytes); |
| 77 | void iov_iter_advance(struct iov_iter *i, size_t bytes); | 77 | void iov_iter_advance(struct iov_iter *i, size_t bytes); |
| 78 | int iov_iter_fault_in_readable(struct iov_iter *i, size_t bytes); | 78 | int iov_iter_fault_in_readable(struct iov_iter *i, size_t bytes); |
| 79 | int iov_iter_fault_in_multipages_readable(struct iov_iter *i, size_t bytes); | ||
| 79 | size_t iov_iter_single_seg_count(const struct iov_iter *i); | 80 | size_t iov_iter_single_seg_count(const struct iov_iter *i); |
| 80 | size_t copy_page_to_iter(struct page *page, size_t offset, size_t bytes, | 81 | size_t copy_page_to_iter(struct page *page, size_t offset, size_t bytes, |
| 81 | struct iov_iter *i); | 82 | struct iov_iter *i); |
| @@ -139,4 +140,18 @@ static inline void iov_iter_reexpand(struct iov_iter *i, size_t count) | |||
| 139 | size_t csum_and_copy_to_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); | 140 | size_t csum_and_copy_to_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); |
| 140 | size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); | 141 | size_t csum_and_copy_from_iter(void *addr, size_t bytes, __wsum *csum, struct iov_iter *i); |
| 141 | 142 | ||
| 143 | int import_iovec(int type, const struct iovec __user * uvector, | ||
| 144 | unsigned nr_segs, unsigned fast_segs, | ||
| 145 | struct iovec **iov, struct iov_iter *i); | ||
| 146 | |||
| 147 | #ifdef CONFIG_COMPAT | ||
| 148 | struct compat_iovec; | ||
| 149 | int compat_import_iovec(int type, const struct compat_iovec __user * uvector, | ||
| 150 | unsigned nr_segs, unsigned fast_segs, | ||
| 151 | struct iovec **iov, struct iov_iter *i); | ||
| 152 | #endif | ||
| 153 | |||
| 154 | int import_single_range(int type, void __user *buf, size_t len, | ||
| 155 | struct iovec *iov, struct iov_iter *i); | ||
| 156 | |||
| 142 | #endif | 157 | #endif |
diff --git a/include/net/sock.h b/include/net/sock.h index e4079c28e6b8..81c81ead9a35 100644 --- a/include/net/sock.h +++ b/include/net/sock.h | |||
| @@ -57,7 +57,6 @@ | |||
| 57 | #include <linux/page_counter.h> | 57 | #include <linux/page_counter.h> |
| 58 | #include <linux/memcontrol.h> | 58 | #include <linux/memcontrol.h> |
| 59 | #include <linux/static_key.h> | 59 | #include <linux/static_key.h> |
| 60 | #include <linux/aio.h> | ||
| 61 | #include <linux/sched.h> | 60 | #include <linux/sched.h> |
| 62 | 61 | ||
| 63 | #include <linux/filter.h> | 62 | #include <linux/filter.h> |
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index bb0635bd74f2..879edfc5ee52 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c | |||
| @@ -32,7 +32,6 @@ | |||
| 32 | #include <linux/security.h> | 32 | #include <linux/security.h> |
| 33 | #include <linux/bootmem.h> | 33 | #include <linux/bootmem.h> |
| 34 | #include <linux/memblock.h> | 34 | #include <linux/memblock.h> |
| 35 | #include <linux/aio.h> | ||
| 36 | #include <linux/syscalls.h> | 35 | #include <linux/syscalls.h> |
| 37 | #include <linux/kexec.h> | 36 | #include <linux/kexec.h> |
| 38 | #include <linux/kdb.h> | 37 | #include <linux/kdb.h> |
| @@ -46,6 +45,7 @@ | |||
| 46 | #include <linux/irq_work.h> | 45 | #include <linux/irq_work.h> |
| 47 | #include <linux/utsname.h> | 46 | #include <linux/utsname.h> |
| 48 | #include <linux/ctype.h> | 47 | #include <linux/ctype.h> |
| 48 | #include <linux/uio.h> | ||
| 49 | 49 | ||
| 50 | #include <asm/uaccess.h> | 50 | #include <asm/uaccess.h> |
| 51 | 51 | ||
| @@ -521,7 +521,7 @@ static ssize_t devkmsg_write(struct kiocb *iocb, struct iov_iter *from) | |||
| 521 | int i; | 521 | int i; |
| 522 | int level = default_message_loglevel; | 522 | int level = default_message_loglevel; |
| 523 | int facility = 1; /* LOG_USER */ | 523 | int facility = 1; /* LOG_USER */ |
| 524 | size_t len = iocb->ki_nbytes; | 524 | size_t len = iov_iter_count(from); |
| 525 | ssize_t ret = len; | 525 | ssize_t ret = len; |
| 526 | 526 | ||
| 527 | if (len > LOG_LINE_MAX) | 527 | if (len > LOG_LINE_MAX) |
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index ce410bb9f2e1..4012336de30f 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c | |||
| @@ -19,6 +19,7 @@ | |||
| 19 | */ | 19 | */ |
| 20 | 20 | ||
| 21 | #include <linux/module.h> | 21 | #include <linux/module.h> |
| 22 | #include <linux/aio.h> | ||
| 22 | #include <linux/mm.h> | 23 | #include <linux/mm.h> |
| 23 | #include <linux/swap.h> | 24 | #include <linux/swap.h> |
| 24 | #include <linux/slab.h> | 25 | #include <linux/slab.h> |
diff --git a/lib/iov_iter.c b/lib/iov_iter.c index 9d96e283520c..75232ad0a5e7 100644 --- a/lib/iov_iter.c +++ b/lib/iov_iter.c | |||
| @@ -317,6 +317,32 @@ int iov_iter_fault_in_readable(struct iov_iter *i, size_t bytes) | |||
| 317 | } | 317 | } |
| 318 | EXPORT_SYMBOL(iov_iter_fault_in_readable); | 318 | EXPORT_SYMBOL(iov_iter_fault_in_readable); |
| 319 | 319 | ||
| 320 | /* | ||
| 321 | * Fault in one or more iovecs of the given iov_iter, to a maximum length of | ||
| 322 | * bytes. For each iovec, fault in each page that constitutes the iovec. | ||
| 323 | * | ||
| 324 | * Return 0 on success, or non-zero if the memory could not be accessed (i.e. | ||
| 325 | * because it is an invalid address). | ||
| 326 | */ | ||
| 327 | int iov_iter_fault_in_multipages_readable(struct iov_iter *i, size_t bytes) | ||
| 328 | { | ||
| 329 | size_t skip = i->iov_offset; | ||
| 330 | const struct iovec *iov; | ||
| 331 | int err; | ||
| 332 | struct iovec v; | ||
| 333 | |||
| 334 | if (!(i->type & (ITER_BVEC|ITER_KVEC))) { | ||
| 335 | iterate_iovec(i, bytes, v, iov, skip, ({ | ||
| 336 | err = fault_in_multipages_readable(v.iov_base, | ||
| 337 | v.iov_len); | ||
| 338 | if (unlikely(err)) | ||
| 339 | return err; | ||
| 340 | 0;})) | ||
| 341 | } | ||
| 342 | return 0; | ||
| 343 | } | ||
| 344 | EXPORT_SYMBOL(iov_iter_fault_in_multipages_readable); | ||
| 345 | |||
| 320 | void iov_iter_init(struct iov_iter *i, int direction, | 346 | void iov_iter_init(struct iov_iter *i, int direction, |
| 321 | const struct iovec *iov, unsigned long nr_segs, | 347 | const struct iovec *iov, unsigned long nr_segs, |
| 322 | size_t count) | 348 | size_t count) |
| @@ -766,3 +792,60 @@ const void *dup_iter(struct iov_iter *new, struct iov_iter *old, gfp_t flags) | |||
| 766 | flags); | 792 | flags); |
| 767 | } | 793 | } |
| 768 | EXPORT_SYMBOL(dup_iter); | 794 | EXPORT_SYMBOL(dup_iter); |
| 795 | |||
| 796 | int import_iovec(int type, const struct iovec __user * uvector, | ||
| 797 | unsigned nr_segs, unsigned fast_segs, | ||
| 798 | struct iovec **iov, struct iov_iter *i) | ||
| 799 | { | ||
| 800 | ssize_t n; | ||
| 801 | struct iovec *p; | ||
| 802 | n = rw_copy_check_uvector(type, uvector, nr_segs, fast_segs, | ||
| 803 | *iov, &p); | ||
| 804 | if (n < 0) { | ||
| 805 | if (p != *iov) | ||
| 806 | kfree(p); | ||
| 807 | *iov = NULL; | ||
| 808 | return n; | ||
| 809 | } | ||
| 810 | iov_iter_init(i, type, p, nr_segs, n); | ||
| 811 | *iov = p == *iov ? NULL : p; | ||
| 812 | return 0; | ||
| 813 | } | ||
| 814 | EXPORT_SYMBOL(import_iovec); | ||
| 815 | |||
| 816 | #ifdef CONFIG_COMPAT | ||
| 817 | #include <linux/compat.h> | ||
| 818 | |||
| 819 | int compat_import_iovec(int type, const struct compat_iovec __user * uvector, | ||
| 820 | unsigned nr_segs, unsigned fast_segs, | ||
| 821 | struct iovec **iov, struct iov_iter *i) | ||
| 822 | { | ||
| 823 | ssize_t n; | ||
| 824 | struct iovec *p; | ||
| 825 | n = compat_rw_copy_check_uvector(type, uvector, nr_segs, fast_segs, | ||
| 826 | *iov, &p); | ||
| 827 | if (n < 0) { | ||
| 828 | if (p != *iov) | ||
| 829 | kfree(p); | ||
| 830 | *iov = NULL; | ||
| 831 | return n; | ||
| 832 | } | ||
| 833 | iov_iter_init(i, type, p, nr_segs, n); | ||
| 834 | *iov = p == *iov ? NULL : p; | ||
| 835 | return 0; | ||
| 836 | } | ||
| 837 | #endif | ||
| 838 | |||
| 839 | int import_single_range(int rw, void __user *buf, size_t len, | ||
| 840 | struct iovec *iov, struct iov_iter *i) | ||
| 841 | { | ||
| 842 | if (len > MAX_RW_COUNT) | ||
| 843 | len = MAX_RW_COUNT; | ||
| 844 | if (unlikely(!access_ok(!rw, buf, len))) | ||
| 845 | return -EFAULT; | ||
| 846 | |||
| 847 | iov->iov_base = buf; | ||
| 848 | iov->iov_len = len; | ||
| 849 | iov_iter_init(i, rw, iov, 1, len); | ||
| 850 | return 0; | ||
| 851 | } | ||
diff --git a/mm/filemap.c b/mm/filemap.c index ad7242043bdb..876f4e6f3ed6 100644 --- a/mm/filemap.c +++ b/mm/filemap.c | |||
| @@ -13,7 +13,6 @@ | |||
| 13 | #include <linux/compiler.h> | 13 | #include <linux/compiler.h> |
| 14 | #include <linux/fs.h> | 14 | #include <linux/fs.h> |
| 15 | #include <linux/uaccess.h> | 15 | #include <linux/uaccess.h> |
| 16 | #include <linux/aio.h> | ||
| 17 | #include <linux/capability.h> | 16 | #include <linux/capability.h> |
| 18 | #include <linux/kernel_stat.h> | 17 | #include <linux/kernel_stat.h> |
| 19 | #include <linux/gfp.h> | 18 | #include <linux/gfp.h> |
diff --git a/mm/page_io.c b/mm/page_io.c index e6045804c8d8..a96c8562d835 100644 --- a/mm/page_io.c +++ b/mm/page_io.c | |||
| @@ -20,8 +20,8 @@ | |||
| 20 | #include <linux/buffer_head.h> | 20 | #include <linux/buffer_head.h> |
| 21 | #include <linux/writeback.h> | 21 | #include <linux/writeback.h> |
| 22 | #include <linux/frontswap.h> | 22 | #include <linux/frontswap.h> |
| 23 | #include <linux/aio.h> | ||
| 24 | #include <linux/blkdev.h> | 23 | #include <linux/blkdev.h> |
| 24 | #include <linux/uio.h> | ||
| 25 | #include <asm/pgtable.h> | 25 | #include <asm/pgtable.h> |
| 26 | 26 | ||
| 27 | static struct bio *get_swap_bio(gfp_t gfp_flags, | 27 | static struct bio *get_swap_bio(gfp_t gfp_flags, |
| @@ -274,7 +274,6 @@ int __swap_writepage(struct page *page, struct writeback_control *wbc, | |||
| 274 | iov_iter_bvec(&from, ITER_BVEC | WRITE, &bv, 1, PAGE_SIZE); | 274 | iov_iter_bvec(&from, ITER_BVEC | WRITE, &bv, 1, PAGE_SIZE); |
| 275 | init_sync_kiocb(&kiocb, swap_file); | 275 | init_sync_kiocb(&kiocb, swap_file); |
| 276 | kiocb.ki_pos = page_file_offset(page); | 276 | kiocb.ki_pos = page_file_offset(page); |
| 277 | kiocb.ki_nbytes = PAGE_SIZE; | ||
| 278 | 277 | ||
| 279 | set_page_writeback(page); | 278 | set_page_writeback(page); |
| 280 | unlock_page(page); | 279 | unlock_page(page); |
diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c index b1597690530c..e88d071648c2 100644 --- a/mm/process_vm_access.c +++ b/mm/process_vm_access.c | |||
| @@ -257,22 +257,18 @@ static ssize_t process_vm_rw(pid_t pid, | |||
| 257 | struct iovec *iov_r = iovstack_r; | 257 | struct iovec *iov_r = iovstack_r; |
| 258 | struct iov_iter iter; | 258 | struct iov_iter iter; |
| 259 | ssize_t rc; | 259 | ssize_t rc; |
| 260 | int dir = vm_write ? WRITE : READ; | ||
| 260 | 261 | ||
| 261 | if (flags != 0) | 262 | if (flags != 0) |
| 262 | return -EINVAL; | 263 | return -EINVAL; |
| 263 | 264 | ||
| 264 | /* Check iovecs */ | 265 | /* Check iovecs */ |
| 265 | if (vm_write) | 266 | rc = import_iovec(dir, lvec, liovcnt, UIO_FASTIOV, &iov_l, &iter); |
| 266 | rc = rw_copy_check_uvector(WRITE, lvec, liovcnt, UIO_FASTIOV, | 267 | if (rc < 0) |
| 267 | iovstack_l, &iov_l); | 268 | return rc; |
| 268 | else | 269 | if (!iov_iter_count(&iter)) |
| 269 | rc = rw_copy_check_uvector(READ, lvec, liovcnt, UIO_FASTIOV, | ||
| 270 | iovstack_l, &iov_l); | ||
| 271 | if (rc <= 0) | ||
| 272 | goto free_iovecs; | 270 | goto free_iovecs; |
| 273 | 271 | ||
| 274 | iov_iter_init(&iter, vm_write ? WRITE : READ, iov_l, liovcnt, rc); | ||
| 275 | |||
| 276 | rc = rw_copy_check_uvector(CHECK_IOVEC_ONLY, rvec, riovcnt, UIO_FASTIOV, | 272 | rc = rw_copy_check_uvector(CHECK_IOVEC_ONLY, rvec, riovcnt, UIO_FASTIOV, |
| 277 | iovstack_r, &iov_r); | 273 | iovstack_r, &iov_r); |
| 278 | if (rc <= 0) | 274 | if (rc <= 0) |
| @@ -283,8 +279,7 @@ static ssize_t process_vm_rw(pid_t pid, | |||
| 283 | free_iovecs: | 279 | free_iovecs: |
| 284 | if (iov_r != iovstack_r) | 280 | if (iov_r != iovstack_r) |
| 285 | kfree(iov_r); | 281 | kfree(iov_r); |
| 286 | if (iov_l != iovstack_l) | 282 | kfree(iov_l); |
| 287 | kfree(iov_l); | ||
| 288 | 283 | ||
| 289 | return rc; | 284 | return rc; |
| 290 | } | 285 | } |
| @@ -320,21 +315,16 @@ compat_process_vm_rw(compat_pid_t pid, | |||
| 320 | struct iovec *iov_r = iovstack_r; | 315 | struct iovec *iov_r = iovstack_r; |
| 321 | struct iov_iter iter; | 316 | struct iov_iter iter; |
| 322 | ssize_t rc = -EFAULT; | 317 | ssize_t rc = -EFAULT; |
| 318 | int dir = vm_write ? WRITE : READ; | ||
| 323 | 319 | ||
| 324 | if (flags != 0) | 320 | if (flags != 0) |
| 325 | return -EINVAL; | 321 | return -EINVAL; |
| 326 | 322 | ||
| 327 | if (vm_write) | 323 | rc = compat_import_iovec(dir, lvec, liovcnt, UIO_FASTIOV, &iov_l, &iter); |
| 328 | rc = compat_rw_copy_check_uvector(WRITE, lvec, liovcnt, | 324 | if (rc < 0) |
| 329 | UIO_FASTIOV, iovstack_l, | 325 | return rc; |
| 330 | &iov_l); | 326 | if (!iov_iter_count(&iter)) |
| 331 | else | ||
| 332 | rc = compat_rw_copy_check_uvector(READ, lvec, liovcnt, | ||
| 333 | UIO_FASTIOV, iovstack_l, | ||
| 334 | &iov_l); | ||
| 335 | if (rc <= 0) | ||
| 336 | goto free_iovecs; | 327 | goto free_iovecs; |
| 337 | iov_iter_init(&iter, vm_write ? WRITE : READ, iov_l, liovcnt, rc); | ||
| 338 | rc = compat_rw_copy_check_uvector(CHECK_IOVEC_ONLY, rvec, riovcnt, | 328 | rc = compat_rw_copy_check_uvector(CHECK_IOVEC_ONLY, rvec, riovcnt, |
| 339 | UIO_FASTIOV, iovstack_r, | 329 | UIO_FASTIOV, iovstack_r, |
| 340 | &iov_r); | 330 | &iov_r); |
| @@ -346,8 +336,7 @@ compat_process_vm_rw(compat_pid_t pid, | |||
| 346 | free_iovecs: | 336 | free_iovecs: |
| 347 | if (iov_r != iovstack_r) | 337 | if (iov_r != iovstack_r) |
| 348 | kfree(iov_r); | 338 | kfree(iov_r); |
| 349 | if (iov_l != iovstack_l) | 339 | kfree(iov_l); |
| 350 | kfree(iov_l); | ||
| 351 | return rc; | 340 | return rc; |
| 352 | } | 341 | } |
| 353 | 342 | ||
diff --git a/mm/shmem.c b/mm/shmem.c index cf2d0ca010bc..80b360c7bcd1 100644 --- a/mm/shmem.c +++ b/mm/shmem.c | |||
| @@ -31,7 +31,7 @@ | |||
| 31 | #include <linux/mm.h> | 31 | #include <linux/mm.h> |
| 32 | #include <linux/export.h> | 32 | #include <linux/export.h> |
| 33 | #include <linux/swap.h> | 33 | #include <linux/swap.h> |
| 34 | #include <linux/aio.h> | 34 | #include <linux/uio.h> |
| 35 | 35 | ||
| 36 | static struct vfsmount *shm_mnt; | 36 | static struct vfsmount *shm_mnt; |
| 37 | 37 | ||
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c index f027a708b7e0..4a356b7c081b 100644 --- a/net/ipv4/raw.c +++ b/net/ipv4/raw.c | |||
| @@ -46,7 +46,6 @@ | |||
| 46 | #include <linux/stddef.h> | 46 | #include <linux/stddef.h> |
| 47 | #include <linux/slab.h> | 47 | #include <linux/slab.h> |
| 48 | #include <linux/errno.h> | 48 | #include <linux/errno.h> |
| 49 | #include <linux/aio.h> | ||
| 50 | #include <linux/kernel.h> | 49 | #include <linux/kernel.h> |
| 51 | #include <linux/export.h> | 50 | #include <linux/export.h> |
| 52 | #include <linux/spinlock.h> | 51 | #include <linux/spinlock.h> |
diff --git a/net/socket.c b/net/socket.c index 245330ca0015..1dbff3e60437 100644 --- a/net/socket.c +++ b/net/socket.c | |||
| @@ -633,8 +633,7 @@ static int do_sock_sendmsg(struct socket *sock, struct msghdr *msg, | |||
| 633 | init_sync_kiocb(&iocb, NULL); | 633 | init_sync_kiocb(&iocb, NULL); |
| 634 | ret = nosec ? __sock_sendmsg_nosec(&iocb, sock, msg, size) : | 634 | ret = nosec ? __sock_sendmsg_nosec(&iocb, sock, msg, size) : |
| 635 | __sock_sendmsg(&iocb, sock, msg, size); | 635 | __sock_sendmsg(&iocb, sock, msg, size); |
| 636 | if (-EIOCBQUEUED == ret) | 636 | BUG_ON(ret == -EIOCBQUEUED); |
| 637 | ret = wait_on_sync_kiocb(&iocb); | ||
| 638 | return ret; | 637 | return ret; |
| 639 | } | 638 | } |
| 640 | 639 | ||
| @@ -766,8 +765,7 @@ int sock_recvmsg(struct socket *sock, struct msghdr *msg, | |||
| 766 | 765 | ||
| 767 | init_sync_kiocb(&iocb, NULL); | 766 | init_sync_kiocb(&iocb, NULL); |
| 768 | ret = __sock_recvmsg(&iocb, sock, msg, size, flags); | 767 | ret = __sock_recvmsg(&iocb, sock, msg, size, flags); |
| 769 | if (-EIOCBQUEUED == ret) | 768 | BUG_ON(ret == -EIOCBQUEUED); |
| 770 | ret = wait_on_sync_kiocb(&iocb); | ||
| 771 | return ret; | 769 | return ret; |
| 772 | } | 770 | } |
| 773 | EXPORT_SYMBOL(sock_recvmsg); | 771 | EXPORT_SYMBOL(sock_recvmsg); |
| @@ -780,8 +778,7 @@ static int sock_recvmsg_nosec(struct socket *sock, struct msghdr *msg, | |||
| 780 | 778 | ||
| 781 | init_sync_kiocb(&iocb, NULL); | 779 | init_sync_kiocb(&iocb, NULL); |
| 782 | ret = __sock_recvmsg_nosec(&iocb, sock, msg, size, flags); | 780 | ret = __sock_recvmsg_nosec(&iocb, sock, msg, size, flags); |
| 783 | if (-EIOCBQUEUED == ret) | 781 | BUG_ON(ret == -EIOCBQUEUED); |
| 784 | ret = wait_on_sync_kiocb(&iocb); | ||
| 785 | return ret; | 782 | return ret; |
| 786 | } | 783 | } |
| 787 | 784 | ||
| @@ -858,11 +855,11 @@ static ssize_t sock_read_iter(struct kiocb *iocb, struct iov_iter *to) | |||
| 858 | if (iocb->ki_pos != 0) | 855 | if (iocb->ki_pos != 0) |
| 859 | return -ESPIPE; | 856 | return -ESPIPE; |
| 860 | 857 | ||
| 861 | if (iocb->ki_nbytes == 0) /* Match SYS5 behaviour */ | 858 | if (!iov_iter_count(to)) /* Match SYS5 behaviour */ |
| 862 | return 0; | 859 | return 0; |
| 863 | 860 | ||
| 864 | res = __sock_recvmsg(iocb, sock, &msg, | 861 | res = __sock_recvmsg(iocb, sock, &msg, |
| 865 | iocb->ki_nbytes, msg.msg_flags); | 862 | iov_iter_count(to), msg.msg_flags); |
| 866 | *to = msg.msg_iter; | 863 | *to = msg.msg_iter; |
| 867 | return res; | 864 | return res; |
| 868 | } | 865 | } |
| @@ -883,7 +880,7 @@ static ssize_t sock_write_iter(struct kiocb *iocb, struct iov_iter *from) | |||
| 883 | if (sock->type == SOCK_SEQPACKET) | 880 | if (sock->type == SOCK_SEQPACKET) |
| 884 | msg.msg_flags |= MSG_EOR; | 881 | msg.msg_flags |= MSG_EOR; |
| 885 | 882 | ||
| 886 | res = __sock_sendmsg(iocb, sock, &msg, iocb->ki_nbytes); | 883 | res = __sock_sendmsg(iocb, sock, &msg, iov_iter_count(from)); |
| 887 | *from = msg.msg_iter; | 884 | *from = msg.msg_iter; |
| 888 | return res; | 885 | return res; |
| 889 | } | 886 | } |
diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c index 107db88b1d5f..dd56bffd6500 100644 --- a/security/apparmor/lsm.c +++ b/security/apparmor/lsm.c | |||
| @@ -364,12 +364,12 @@ static int apparmor_path_chown(struct path *path, kuid_t uid, kgid_t gid) | |||
| 364 | return common_perm(OP_CHOWN, path, AA_MAY_CHOWN, &cond); | 364 | return common_perm(OP_CHOWN, path, AA_MAY_CHOWN, &cond); |
| 365 | } | 365 | } |
| 366 | 366 | ||
| 367 | static int apparmor_inode_getattr(struct vfsmount *mnt, struct dentry *dentry) | 367 | static int apparmor_inode_getattr(const struct path *path) |
| 368 | { | 368 | { |
| 369 | if (!mediated_filesystem(dentry)) | 369 | if (!mediated_filesystem(path->dentry)) |
| 370 | return 0; | 370 | return 0; |
| 371 | 371 | ||
| 372 | return common_perm_mnt_dentry(OP_GETATTR, mnt, dentry, | 372 | return common_perm_mnt_dentry(OP_GETATTR, path->mnt, path->dentry, |
| 373 | AA_MAY_META_READ); | 373 | AA_MAY_META_READ); |
| 374 | } | 374 | } |
| 375 | 375 | ||
diff --git a/security/capability.c b/security/capability.c index 070dd46f62f4..bdf22034a961 100644 --- a/security/capability.c +++ b/security/capability.c | |||
| @@ -225,7 +225,7 @@ static int cap_inode_setattr(struct dentry *dentry, struct iattr *iattr) | |||
| 225 | return 0; | 225 | return 0; |
| 226 | } | 226 | } |
| 227 | 227 | ||
| 228 | static int cap_inode_getattr(struct vfsmount *mnt, struct dentry *dentry) | 228 | static int cap_inode_getattr(const struct path *path) |
| 229 | { | 229 | { |
| 230 | return 0; | 230 | return 0; |
| 231 | } | 231 | } |
diff --git a/security/keys/compat.c b/security/keys/compat.c index 347896548ad3..25430a3aa7f7 100644 --- a/security/keys/compat.c +++ b/security/keys/compat.c | |||
| @@ -31,30 +31,21 @@ static long compat_keyctl_instantiate_key_iov( | |||
| 31 | key_serial_t ringid) | 31 | key_serial_t ringid) |
| 32 | { | 32 | { |
| 33 | struct iovec iovstack[UIO_FASTIOV], *iov = iovstack; | 33 | struct iovec iovstack[UIO_FASTIOV], *iov = iovstack; |
| 34 | struct iov_iter from; | ||
| 34 | long ret; | 35 | long ret; |
| 35 | 36 | ||
| 36 | if (!_payload_iov || !ioc) | 37 | if (!_payload_iov) |
| 37 | goto no_payload; | 38 | ioc = 0; |
| 38 | 39 | ||
| 39 | ret = compat_rw_copy_check_uvector(WRITE, _payload_iov, ioc, | 40 | ret = compat_import_iovec(WRITE, _payload_iov, ioc, |
| 40 | ARRAY_SIZE(iovstack), | 41 | ARRAY_SIZE(iovstack), &iov, |
| 41 | iovstack, &iov); | 42 | &from); |
| 42 | if (ret < 0) | 43 | if (ret < 0) |
| 43 | goto err; | 44 | return ret; |
| 44 | if (ret == 0) | ||
| 45 | goto no_payload_free; | ||
| 46 | |||
| 47 | ret = keyctl_instantiate_key_common(id, iov, ioc, ret, ringid); | ||
| 48 | err: | ||
| 49 | if (iov != iovstack) | ||
| 50 | kfree(iov); | ||
| 51 | return ret; | ||
| 52 | 45 | ||
| 53 | no_payload_free: | 46 | ret = keyctl_instantiate_key_common(id, &from, ringid); |
| 54 | if (iov != iovstack) | 47 | kfree(iov); |
| 55 | kfree(iov); | 48 | return ret; |
| 56 | no_payload: | ||
| 57 | return keyctl_instantiate_key_common(id, NULL, 0, 0, ringid); | ||
| 58 | } | 49 | } |
| 59 | 50 | ||
| 60 | /* | 51 | /* |
diff --git a/security/keys/internal.h b/security/keys/internal.h index 200e37867336..5105c2c2da75 100644 --- a/security/keys/internal.h +++ b/security/keys/internal.h | |||
| @@ -243,9 +243,10 @@ extern long keyctl_instantiate_key_iov(key_serial_t, | |||
| 243 | unsigned, key_serial_t); | 243 | unsigned, key_serial_t); |
| 244 | extern long keyctl_invalidate_key(key_serial_t); | 244 | extern long keyctl_invalidate_key(key_serial_t); |
| 245 | 245 | ||
| 246 | struct iov_iter; | ||
| 246 | extern long keyctl_instantiate_key_common(key_serial_t, | 247 | extern long keyctl_instantiate_key_common(key_serial_t, |
| 247 | const struct iovec *, | 248 | struct iov_iter *, |
| 248 | unsigned, size_t, key_serial_t); | 249 | key_serial_t); |
| 249 | #ifdef CONFIG_PERSISTENT_KEYRINGS | 250 | #ifdef CONFIG_PERSISTENT_KEYRINGS |
| 250 | extern long keyctl_get_persistent(uid_t, key_serial_t); | 251 | extern long keyctl_get_persistent(uid_t, key_serial_t); |
| 251 | extern unsigned persistent_keyring_expiry; | 252 | extern unsigned persistent_keyring_expiry; |
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c index 4743d71e4aa6..0b9ec78a7a7a 100644 --- a/security/keys/keyctl.c +++ b/security/keys/keyctl.c | |||
| @@ -998,21 +998,6 @@ static int keyctl_change_reqkey_auth(struct key *key) | |||
| 998 | } | 998 | } |
| 999 | 999 | ||
| 1000 | /* | 1000 | /* |
| 1001 | * Copy the iovec data from userspace | ||
| 1002 | */ | ||
| 1003 | static long copy_from_user_iovec(void *buffer, const struct iovec *iov, | ||
| 1004 | unsigned ioc) | ||
| 1005 | { | ||
| 1006 | for (; ioc > 0; ioc--) { | ||
| 1007 | if (copy_from_user(buffer, iov->iov_base, iov->iov_len) != 0) | ||
| 1008 | return -EFAULT; | ||
| 1009 | buffer += iov->iov_len; | ||
| 1010 | iov++; | ||
| 1011 | } | ||
| 1012 | return 0; | ||
| 1013 | } | ||
| 1014 | |||
| 1015 | /* | ||
| 1016 | * Instantiate a key with the specified payload and link the key into the | 1001 | * Instantiate a key with the specified payload and link the key into the |
| 1017 | * destination keyring if one is given. | 1002 | * destination keyring if one is given. |
| 1018 | * | 1003 | * |
| @@ -1022,20 +1007,21 @@ static long copy_from_user_iovec(void *buffer, const struct iovec *iov, | |||
| 1022 | * If successful, 0 will be returned. | 1007 | * If successful, 0 will be returned. |
| 1023 | */ | 1008 | */ |
| 1024 | long keyctl_instantiate_key_common(key_serial_t id, | 1009 | long keyctl_instantiate_key_common(key_serial_t id, |
| 1025 | const struct iovec *payload_iov, | 1010 | struct iov_iter *from, |
| 1026 | unsigned ioc, | ||
| 1027 | size_t plen, | ||
| 1028 | key_serial_t ringid) | 1011 | key_serial_t ringid) |
| 1029 | { | 1012 | { |
| 1030 | const struct cred *cred = current_cred(); | 1013 | const struct cred *cred = current_cred(); |
| 1031 | struct request_key_auth *rka; | 1014 | struct request_key_auth *rka; |
| 1032 | struct key *instkey, *dest_keyring; | 1015 | struct key *instkey, *dest_keyring; |
| 1016 | size_t plen = from ? iov_iter_count(from) : 0; | ||
| 1033 | void *payload; | 1017 | void *payload; |
| 1034 | long ret; | 1018 | long ret; |
| 1035 | bool vm = false; | ||
| 1036 | 1019 | ||
| 1037 | kenter("%d,,%zu,%d", id, plen, ringid); | 1020 | kenter("%d,,%zu,%d", id, plen, ringid); |
| 1038 | 1021 | ||
| 1022 | if (!plen) | ||
| 1023 | from = NULL; | ||
| 1024 | |||
| 1039 | ret = -EINVAL; | 1025 | ret = -EINVAL; |
| 1040 | if (plen > 1024 * 1024 - 1) | 1026 | if (plen > 1024 * 1024 - 1) |
| 1041 | goto error; | 1027 | goto error; |
| @@ -1054,20 +1040,19 @@ long keyctl_instantiate_key_common(key_serial_t id, | |||
| 1054 | /* pull the payload in if one was supplied */ | 1040 | /* pull the payload in if one was supplied */ |
| 1055 | payload = NULL; | 1041 | payload = NULL; |
| 1056 | 1042 | ||
| 1057 | if (payload_iov) { | 1043 | if (from) { |
| 1058 | ret = -ENOMEM; | 1044 | ret = -ENOMEM; |
| 1059 | payload = kmalloc(plen, GFP_KERNEL); | 1045 | payload = kmalloc(plen, GFP_KERNEL); |
| 1060 | if (!payload) { | 1046 | if (!payload) { |
| 1061 | if (plen <= PAGE_SIZE) | 1047 | if (plen <= PAGE_SIZE) |
| 1062 | goto error; | 1048 | goto error; |
| 1063 | vm = true; | ||
| 1064 | payload = vmalloc(plen); | 1049 | payload = vmalloc(plen); |
| 1065 | if (!payload) | 1050 | if (!payload) |
| 1066 | goto error; | 1051 | goto error; |
| 1067 | } | 1052 | } |
| 1068 | 1053 | ||
| 1069 | ret = copy_from_user_iovec(payload, payload_iov, ioc); | 1054 | ret = -EFAULT; |
| 1070 | if (ret < 0) | 1055 | if (copy_from_iter(payload, plen, from) != plen) |
| 1071 | goto error2; | 1056 | goto error2; |
| 1072 | } | 1057 | } |
| 1073 | 1058 | ||
| @@ -1089,10 +1074,7 @@ long keyctl_instantiate_key_common(key_serial_t id, | |||
| 1089 | keyctl_change_reqkey_auth(NULL); | 1074 | keyctl_change_reqkey_auth(NULL); |
| 1090 | 1075 | ||
| 1091 | error2: | 1076 | error2: |
| 1092 | if (!vm) | 1077 | kvfree(payload); |
| 1093 | kfree(payload); | ||
| 1094 | else | ||
| 1095 | vfree(payload); | ||
| 1096 | error: | 1078 | error: |
| 1097 | return ret; | 1079 | return ret; |
| 1098 | } | 1080 | } |
| @@ -1112,15 +1094,19 @@ long keyctl_instantiate_key(key_serial_t id, | |||
| 1112 | key_serial_t ringid) | 1094 | key_serial_t ringid) |
| 1113 | { | 1095 | { |
| 1114 | if (_payload && plen) { | 1096 | if (_payload && plen) { |
| 1115 | struct iovec iov[1] = { | 1097 | struct iovec iov; |
| 1116 | [0].iov_base = (void __user *)_payload, | 1098 | struct iov_iter from; |
| 1117 | [0].iov_len = plen | 1099 | int ret; |
| 1118 | }; | ||
| 1119 | 1100 | ||
| 1120 | return keyctl_instantiate_key_common(id, iov, 1, plen, ringid); | 1101 | ret = import_single_range(WRITE, (void __user *)_payload, plen, |
| 1102 | &iov, &from); | ||
| 1103 | if (unlikely(ret)) | ||
| 1104 | return ret; | ||
| 1105 | |||
| 1106 | return keyctl_instantiate_key_common(id, &from, ringid); | ||
| 1121 | } | 1107 | } |
| 1122 | 1108 | ||
| 1123 | return keyctl_instantiate_key_common(id, NULL, 0, 0, ringid); | 1109 | return keyctl_instantiate_key_common(id, NULL, ringid); |
| 1124 | } | 1110 | } |
| 1125 | 1111 | ||
| 1126 | /* | 1112 | /* |
| @@ -1138,29 +1124,19 @@ long keyctl_instantiate_key_iov(key_serial_t id, | |||
| 1138 | key_serial_t ringid) | 1124 | key_serial_t ringid) |
| 1139 | { | 1125 | { |
| 1140 | struct iovec iovstack[UIO_FASTIOV], *iov = iovstack; | 1126 | struct iovec iovstack[UIO_FASTIOV], *iov = iovstack; |
| 1127 | struct iov_iter from; | ||
| 1141 | long ret; | 1128 | long ret; |
| 1142 | 1129 | ||
| 1143 | if (!_payload_iov || !ioc) | 1130 | if (!_payload_iov) |
| 1144 | goto no_payload; | 1131 | ioc = 0; |
| 1145 | 1132 | ||
| 1146 | ret = rw_copy_check_uvector(WRITE, _payload_iov, ioc, | 1133 | ret = import_iovec(WRITE, _payload_iov, ioc, |
| 1147 | ARRAY_SIZE(iovstack), iovstack, &iov); | 1134 | ARRAY_SIZE(iovstack), &iov, &from); |
| 1148 | if (ret < 0) | 1135 | if (ret < 0) |
| 1149 | goto err; | 1136 | return ret; |
| 1150 | if (ret == 0) | 1137 | ret = keyctl_instantiate_key_common(id, &from, ringid); |
| 1151 | goto no_payload_free; | 1138 | kfree(iov); |
| 1152 | |||
| 1153 | ret = keyctl_instantiate_key_common(id, iov, ioc, ret, ringid); | ||
| 1154 | err: | ||
| 1155 | if (iov != iovstack) | ||
| 1156 | kfree(iov); | ||
| 1157 | return ret; | 1139 | return ret; |
| 1158 | |||
| 1159 | no_payload_free: | ||
| 1160 | if (iov != iovstack) | ||
| 1161 | kfree(iov); | ||
| 1162 | no_payload: | ||
| 1163 | return keyctl_instantiate_key_common(id, NULL, 0, 0, ringid); | ||
| 1164 | } | 1140 | } |
| 1165 | 1141 | ||
| 1166 | /* | 1142 | /* |
diff --git a/security/security.c b/security/security.c index e81d5bbe7363..ed890c6d31c5 100644 --- a/security/security.c +++ b/security/security.c | |||
| @@ -608,11 +608,11 @@ int security_inode_setattr(struct dentry *dentry, struct iattr *attr) | |||
| 608 | } | 608 | } |
| 609 | EXPORT_SYMBOL_GPL(security_inode_setattr); | 609 | EXPORT_SYMBOL_GPL(security_inode_setattr); |
| 610 | 610 | ||
| 611 | int security_inode_getattr(struct vfsmount *mnt, struct dentry *dentry) | 611 | int security_inode_getattr(const struct path *path) |
| 612 | { | 612 | { |
| 613 | if (unlikely(IS_PRIVATE(dentry->d_inode))) | 613 | if (unlikely(IS_PRIVATE(path->dentry->d_inode))) |
| 614 | return 0; | 614 | return 0; |
| 615 | return security_ops->inode_getattr(mnt, dentry); | 615 | return security_ops->inode_getattr(path); |
| 616 | } | 616 | } |
| 617 | 617 | ||
| 618 | int security_inode_setxattr(struct dentry *dentry, const char *name, | 618 | int security_inode_setxattr(struct dentry *dentry, const char *name, |
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 4d1a54190388..e119cdcffc87 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c | |||
| @@ -1623,7 +1623,7 @@ static inline int dentry_has_perm(const struct cred *cred, | |||
| 1623 | the path to help the auditing code to more easily generate the | 1623 | the path to help the auditing code to more easily generate the |
| 1624 | pathname if needed. */ | 1624 | pathname if needed. */ |
| 1625 | static inline int path_has_perm(const struct cred *cred, | 1625 | static inline int path_has_perm(const struct cred *cred, |
| 1626 | struct path *path, | 1626 | const struct path *path, |
| 1627 | u32 av) | 1627 | u32 av) |
| 1628 | { | 1628 | { |
| 1629 | struct inode *inode = path->dentry->d_inode; | 1629 | struct inode *inode = path->dentry->d_inode; |
| @@ -2954,15 +2954,9 @@ static int selinux_inode_setattr(struct dentry *dentry, struct iattr *iattr) | |||
| 2954 | return dentry_has_perm(cred, dentry, av); | 2954 | return dentry_has_perm(cred, dentry, av); |
| 2955 | } | 2955 | } |
| 2956 | 2956 | ||
| 2957 | static int selinux_inode_getattr(struct vfsmount *mnt, struct dentry *dentry) | 2957 | static int selinux_inode_getattr(const struct path *path) |
| 2958 | { | 2958 | { |
| 2959 | const struct cred *cred = current_cred(); | 2959 | return path_has_perm(current_cred(), path, FILE__GETATTR); |
| 2960 | struct path path; | ||
| 2961 | |||
| 2962 | path.dentry = dentry; | ||
| 2963 | path.mnt = mnt; | ||
| 2964 | |||
| 2965 | return path_has_perm(cred, &path, FILE__GETATTR); | ||
| 2966 | } | 2960 | } |
| 2967 | 2961 | ||
| 2968 | static int selinux_inode_setotherxattr(struct dentry *dentry, const char *name) | 2962 | static int selinux_inode_setotherxattr(struct dentry *dentry, const char *name) |
diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index c934311812f1..1511965549b8 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c | |||
| @@ -1034,19 +1034,16 @@ static int smack_inode_setattr(struct dentry *dentry, struct iattr *iattr) | |||
| 1034 | * | 1034 | * |
| 1035 | * Returns 0 if access is permitted, an error code otherwise | 1035 | * Returns 0 if access is permitted, an error code otherwise |
| 1036 | */ | 1036 | */ |
| 1037 | static int smack_inode_getattr(struct vfsmount *mnt, struct dentry *dentry) | 1037 | static int smack_inode_getattr(const struct path *path) |
| 1038 | { | 1038 | { |
| 1039 | struct smk_audit_info ad; | 1039 | struct smk_audit_info ad; |
| 1040 | struct path path; | 1040 | struct inode *inode = path->dentry->d_inode; |
| 1041 | int rc; | 1041 | int rc; |
| 1042 | 1042 | ||
| 1043 | path.dentry = dentry; | ||
| 1044 | path.mnt = mnt; | ||
| 1045 | |||
| 1046 | smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH); | 1043 | smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH); |
| 1047 | smk_ad_setfield_u_fs_path(&ad, path); | 1044 | smk_ad_setfield_u_fs_path(&ad, *path); |
| 1048 | rc = smk_curacc(smk_of_inode(dentry->d_inode), MAY_READ, &ad); | 1045 | rc = smk_curacc(smk_of_inode(inode), MAY_READ, &ad); |
| 1049 | rc = smk_bu_inode(dentry->d_inode, MAY_READ, rc); | 1046 | rc = smk_bu_inode(inode, MAY_READ, rc); |
| 1050 | return rc; | 1047 | return rc; |
| 1051 | } | 1048 | } |
| 1052 | 1049 | ||
diff --git a/security/tomoyo/common.h b/security/tomoyo/common.h index b897d4862016..f9c9fb1d56b4 100644 --- a/security/tomoyo/common.h +++ b/security/tomoyo/common.h | |||
| @@ -945,7 +945,7 @@ char *tomoyo_encode2(const char *str, int str_len); | |||
| 945 | char *tomoyo_init_log(struct tomoyo_request_info *r, int len, const char *fmt, | 945 | char *tomoyo_init_log(struct tomoyo_request_info *r, int len, const char *fmt, |
| 946 | va_list args); | 946 | va_list args); |
| 947 | char *tomoyo_read_token(struct tomoyo_acl_param *param); | 947 | char *tomoyo_read_token(struct tomoyo_acl_param *param); |
| 948 | char *tomoyo_realpath_from_path(struct path *path); | 948 | char *tomoyo_realpath_from_path(const struct path *path); |
| 949 | char *tomoyo_realpath_nofollow(const char *pathname); | 949 | char *tomoyo_realpath_nofollow(const char *pathname); |
| 950 | const char *tomoyo_get_exe(void); | 950 | const char *tomoyo_get_exe(void); |
| 951 | const char *tomoyo_yesno(const unsigned int value); | 951 | const char *tomoyo_yesno(const unsigned int value); |
| @@ -978,7 +978,7 @@ int tomoyo_path2_perm(const u8 operation, struct path *path1, | |||
| 978 | struct path *path2); | 978 | struct path *path2); |
| 979 | int tomoyo_path_number_perm(const u8 operation, struct path *path, | 979 | int tomoyo_path_number_perm(const u8 operation, struct path *path, |
| 980 | unsigned long number); | 980 | unsigned long number); |
| 981 | int tomoyo_path_perm(const u8 operation, struct path *path, | 981 | int tomoyo_path_perm(const u8 operation, const struct path *path, |
| 982 | const char *target); | 982 | const char *target); |
| 983 | unsigned int tomoyo_poll_control(struct file *file, poll_table *wait); | 983 | unsigned int tomoyo_poll_control(struct file *file, poll_table *wait); |
| 984 | unsigned int tomoyo_poll_log(struct file *file, poll_table *wait); | 984 | unsigned int tomoyo_poll_log(struct file *file, poll_table *wait); |
diff --git a/security/tomoyo/file.c b/security/tomoyo/file.c index c151a1869597..2367b100cc62 100644 --- a/security/tomoyo/file.c +++ b/security/tomoyo/file.c | |||
| @@ -145,7 +145,7 @@ static void tomoyo_add_slash(struct tomoyo_path_info *buf) | |||
| 145 | * | 145 | * |
| 146 | * Returns true on success, false otherwise. | 146 | * Returns true on success, false otherwise. |
| 147 | */ | 147 | */ |
| 148 | static bool tomoyo_get_realpath(struct tomoyo_path_info *buf, struct path *path) | 148 | static bool tomoyo_get_realpath(struct tomoyo_path_info *buf, const struct path *path) |
| 149 | { | 149 | { |
| 150 | buf->name = tomoyo_realpath_from_path(path); | 150 | buf->name = tomoyo_realpath_from_path(path); |
| 151 | if (buf->name) { | 151 | if (buf->name) { |
| @@ -782,7 +782,7 @@ int tomoyo_check_open_permission(struct tomoyo_domain_info *domain, | |||
| 782 | * | 782 | * |
| 783 | * Returns 0 on success, negative value otherwise. | 783 | * Returns 0 on success, negative value otherwise. |
| 784 | */ | 784 | */ |
| 785 | int tomoyo_path_perm(const u8 operation, struct path *path, const char *target) | 785 | int tomoyo_path_perm(const u8 operation, const struct path *path, const char *target) |
| 786 | { | 786 | { |
| 787 | struct tomoyo_request_info r; | 787 | struct tomoyo_request_info r; |
| 788 | struct tomoyo_obj_info obj = { | 788 | struct tomoyo_obj_info obj = { |
diff --git a/security/tomoyo/realpath.c b/security/tomoyo/realpath.c index bed745c8b1a3..1e0d480ff6a6 100644 --- a/security/tomoyo/realpath.c +++ b/security/tomoyo/realpath.c | |||
| @@ -89,7 +89,7 @@ char *tomoyo_encode(const char *str) | |||
| 89 | * | 89 | * |
| 90 | * If dentry is a directory, trailing '/' is appended. | 90 | * If dentry is a directory, trailing '/' is appended. |
| 91 | */ | 91 | */ |
| 92 | static char *tomoyo_get_absolute_path(struct path *path, char * const buffer, | 92 | static char *tomoyo_get_absolute_path(const struct path *path, char * const buffer, |
| 93 | const int buflen) | 93 | const int buflen) |
| 94 | { | 94 | { |
| 95 | char *pos = ERR_PTR(-ENOMEM); | 95 | char *pos = ERR_PTR(-ENOMEM); |
| @@ -216,7 +216,7 @@ out: | |||
| 216 | * | 216 | * |
| 217 | * Returns the buffer. | 217 | * Returns the buffer. |
| 218 | */ | 218 | */ |
| 219 | static char *tomoyo_get_socket_name(struct path *path, char * const buffer, | 219 | static char *tomoyo_get_socket_name(const struct path *path, char * const buffer, |
| 220 | const int buflen) | 220 | const int buflen) |
| 221 | { | 221 | { |
| 222 | struct inode *inode = path->dentry->d_inode; | 222 | struct inode *inode = path->dentry->d_inode; |
| @@ -247,7 +247,7 @@ static char *tomoyo_get_socket_name(struct path *path, char * const buffer, | |||
| 247 | * These functions use kzalloc(), so the caller must call kfree() | 247 | * These functions use kzalloc(), so the caller must call kfree() |
| 248 | * if these functions didn't return NULL. | 248 | * if these functions didn't return NULL. |
| 249 | */ | 249 | */ |
| 250 | char *tomoyo_realpath_from_path(struct path *path) | 250 | char *tomoyo_realpath_from_path(const struct path *path) |
| 251 | { | 251 | { |
| 252 | char *buf = NULL; | 252 | char *buf = NULL; |
| 253 | char *name = NULL; | 253 | char *name = NULL; |
diff --git a/security/tomoyo/tomoyo.c b/security/tomoyo/tomoyo.c index f0b756e27fed..57c88d52ffa5 100644 --- a/security/tomoyo/tomoyo.c +++ b/security/tomoyo/tomoyo.c | |||
| @@ -144,10 +144,9 @@ static int tomoyo_bprm_check_security(struct linux_binprm *bprm) | |||
| 144 | * | 144 | * |
| 145 | * Returns 0 on success, negative value otherwise. | 145 | * Returns 0 on success, negative value otherwise. |
| 146 | */ | 146 | */ |
| 147 | static int tomoyo_inode_getattr(struct vfsmount *mnt, struct dentry *dentry) | 147 | static int tomoyo_inode_getattr(const struct path *path) |
| 148 | { | 148 | { |
| 149 | struct path path = { mnt, dentry }; | 149 | return tomoyo_path_perm(TOMOYO_TYPE_GETATTR, path, NULL); |
| 150 | return tomoyo_path_perm(TOMOYO_TYPE_GETATTR, &path, NULL); | ||
| 151 | } | 150 | } |
| 152 | 151 | ||
| 153 | /** | 152 | /** |
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index 279e24f61305..a69ebc79bc50 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c | |||
| @@ -25,7 +25,6 @@ | |||
| 25 | #include <linux/slab.h> | 25 | #include <linux/slab.h> |
| 26 | #include <linux/time.h> | 26 | #include <linux/time.h> |
| 27 | #include <linux/pm_qos.h> | 27 | #include <linux/pm_qos.h> |
| 28 | #include <linux/aio.h> | ||
| 29 | #include <linux/io.h> | 28 | #include <linux/io.h> |
| 30 | #include <linux/dma-mapping.h> | 29 | #include <linux/dma-mapping.h> |
| 31 | #include <sound/core.h> | 30 | #include <sound/core.h> |
| @@ -35,6 +34,7 @@ | |||
| 35 | #include <sound/pcm_params.h> | 34 | #include <sound/pcm_params.h> |
| 36 | #include <sound/timer.h> | 35 | #include <sound/timer.h> |
| 37 | #include <sound/minors.h> | 36 | #include <sound/minors.h> |
| 37 | #include <linux/uio.h> | ||
| 38 | 38 | ||
| 39 | /* | 39 | /* |
| 40 | * Compatibility | 40 | * Compatibility |
