diff options
| author | Jean Delvare <jdelvare@suse.de> | 2011-07-08 05:04:38 -0400 |
|---|---|---|
| committer | Paul Mundt <lethal@linux-sh.org> | 2011-07-13 03:53:23 -0400 |
| commit | c84c14224bbca6ec60d5851fcc87be0e34df2f44 (patch) | |
| tree | 7bdf80f9cef91d5910d70bd01d906d20449b47bb | |
| parent | af48d1c6c85752053ddfed5cfb3933d6336d645c (diff) | |
carminefb: Fix module parameters permissions
The third parameter of module_param is supposed to be an octal value.
The missing leading "0" causes the following:
$ ls -l /sys/module/carminefb/parameters/
total 0
-rw-rwxr-- 1 root root 4096 Jul 8 08:55 fb_displays
-rw-rwxr-- 1 root root 4096 Jul 8 08:55 fb_mode
-rw-rwxr-- 1 root root 4096 Jul 8 08:55 fb_mode_str
After fixing the perm parameter, we get the expected:
$ ls -l /sys/module/carminefb/parameters/
total 0
-r--r--r-- 1 root root 4096 Jul 8 08:56 fb_displays
-r--r--r-- 1 root root 4096 Jul 8 08:56 fb_mode
-r--r--r-- 1 root root 4096 Jul 8 08:56 fb_mode_str
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Cc: stable@kernel.org
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
| -rw-r--r-- | drivers/video/carminefb.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/carminefb.c b/drivers/video/carminefb.c index caaa27d4a46a..cb09aa1fa138 100644 --- a/drivers/video/carminefb.c +++ b/drivers/video/carminefb.c | |||
| @@ -32,11 +32,11 @@ | |||
| 32 | #define CARMINEFB_DEFAULT_VIDEO_MODE 1 | 32 | #define CARMINEFB_DEFAULT_VIDEO_MODE 1 |
| 33 | 33 | ||
| 34 | static unsigned int fb_mode = CARMINEFB_DEFAULT_VIDEO_MODE; | 34 | static unsigned int fb_mode = CARMINEFB_DEFAULT_VIDEO_MODE; |
| 35 | module_param(fb_mode, uint, 444); | 35 | module_param(fb_mode, uint, 0444); |
| 36 | MODULE_PARM_DESC(fb_mode, "Initial video mode as integer."); | 36 | MODULE_PARM_DESC(fb_mode, "Initial video mode as integer."); |
| 37 | 37 | ||
| 38 | static char *fb_mode_str; | 38 | static char *fb_mode_str; |
| 39 | module_param(fb_mode_str, charp, 444); | 39 | module_param(fb_mode_str, charp, 0444); |
| 40 | MODULE_PARM_DESC(fb_mode_str, "Initial video mode in characters."); | 40 | MODULE_PARM_DESC(fb_mode_str, "Initial video mode in characters."); |
| 41 | 41 | ||
| 42 | /* | 42 | /* |
| @@ -46,7 +46,7 @@ MODULE_PARM_DESC(fb_mode_str, "Initial video mode in characters."); | |||
| 46 | * 0b010 Display 1 | 46 | * 0b010 Display 1 |
| 47 | */ | 47 | */ |
| 48 | static int fb_displays = CARMINE_USE_DISPLAY0 | CARMINE_USE_DISPLAY1; | 48 | static int fb_displays = CARMINE_USE_DISPLAY0 | CARMINE_USE_DISPLAY1; |
| 49 | module_param(fb_displays, int, 444); | 49 | module_param(fb_displays, int, 0444); |
| 50 | MODULE_PARM_DESC(fb_displays, "Bit mode, which displays are used"); | 50 | MODULE_PARM_DESC(fb_displays, "Bit mode, which displays are used"); |
| 51 | 51 | ||
| 52 | struct carmine_hw { | 52 | struct carmine_hw { |
