diff options
| author | Jiri Olsa <jolsa@kernel.org> | 2014-06-27 12:26:58 -0400 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-07-07 14:23:31 -0400 |
| commit | c83023676dc34f1b4422b842e1e2dc5c21bfc4dc (patch) | |
| tree | cdcbb3448184ccbf935ade0dd58cb1536f62ee42 | |
| parent | 81a888fea2cfd727052926e95510c11981d9b1c2 (diff) | |
perf hists browser: Add ui.show-headers config file option
Adding ui.show-headers config file option to define if the histogram
entries headers will start visible or not.
Currently columns headers are displayed by default, following
lines in ~/.perfconfig file will disable that:
[ui]
show-headers = false
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1403886418-5556-4-git-send-email-jolsa@kernel.org
[ renamed symbol_conf.show_headers to .show_hist_headers ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/ui/browsers/hists.c | 2 | ||||
| -rw-r--r-- | tools/perf/util/config.c | 13 | ||||
| -rw-r--r-- | tools/perf/util/symbol.c | 1 | ||||
| -rw-r--r-- | tools/perf/util/symbol.h | 3 |
4 files changed, 17 insertions, 2 deletions
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 5fa2e181ef0c..a94b11fc5e00 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c | |||
| @@ -1284,7 +1284,7 @@ static struct hist_browser *hist_browser__new(struct hists *hists) | |||
| 1284 | browser->b.refresh_dimensions = hist_browser__refresh_dimensions; | 1284 | browser->b.refresh_dimensions = hist_browser__refresh_dimensions; |
| 1285 | browser->b.seek = ui_browser__hists_seek; | 1285 | browser->b.seek = ui_browser__hists_seek; |
| 1286 | browser->b.use_navkeypressed = true; | 1286 | browser->b.use_navkeypressed = true; |
| 1287 | browser->show_headers = true; | 1287 | browser->show_headers = symbol_conf.show_hist_headers; |
| 1288 | } | 1288 | } |
| 1289 | 1289 | ||
| 1290 | return browser; | 1290 | return browser; |
diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c index 24519e14ac56..1e5e2e5af6b1 100644 --- a/tools/perf/util/config.c +++ b/tools/perf/util/config.c | |||
| @@ -350,6 +350,16 @@ static int perf_default_core_config(const char *var __maybe_unused, | |||
| 350 | return 0; | 350 | return 0; |
| 351 | } | 351 | } |
| 352 | 352 | ||
| 353 | static int perf_ui_config(const char *var, const char *value) | ||
| 354 | { | ||
| 355 | /* Add other config variables here. */ | ||
| 356 | if (!strcmp(var, "ui.show-headers")) { | ||
| 357 | symbol_conf.show_hist_headers = perf_config_bool(var, value); | ||
| 358 | return 0; | ||
| 359 | } | ||
| 360 | return 0; | ||
| 361 | } | ||
| 362 | |||
| 353 | int perf_default_config(const char *var, const char *value, | 363 | int perf_default_config(const char *var, const char *value, |
| 354 | void *dummy __maybe_unused) | 364 | void *dummy __maybe_unused) |
| 355 | { | 365 | { |
| @@ -359,6 +369,9 @@ int perf_default_config(const char *var, const char *value, | |||
| 359 | if (!prefixcmp(var, "hist.")) | 369 | if (!prefixcmp(var, "hist.")) |
| 360 | return perf_hist_config(var, value); | 370 | return perf_hist_config(var, value); |
| 361 | 371 | ||
| 372 | if (!prefixcmp(var, "ui.")) | ||
| 373 | return perf_ui_config(var, value); | ||
| 374 | |||
| 362 | /* Add other config variables here. */ | 375 | /* Add other config variables here. */ |
| 363 | return 0; | 376 | return 0; |
| 364 | } | 377 | } |
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c index 7b9096f29cdb..2e6a2e219eb9 100644 --- a/tools/perf/util/symbol.c +++ b/tools/perf/util/symbol.c | |||
| @@ -34,6 +34,7 @@ struct symbol_conf symbol_conf = { | |||
| 34 | .annotate_src = true, | 34 | .annotate_src = true, |
| 35 | .demangle = true, | 35 | .demangle = true, |
| 36 | .cumulate_callchain = true, | 36 | .cumulate_callchain = true, |
| 37 | .show_hist_headers = true, | ||
| 37 | .symfs = "", | 38 | .symfs = "", |
| 38 | }; | 39 | }; |
| 39 | 40 | ||
diff --git a/tools/perf/util/symbol.h b/tools/perf/util/symbol.h index 615c752dd767..a81877b1dee0 100644 --- a/tools/perf/util/symbol.h +++ b/tools/perf/util/symbol.h | |||
| @@ -118,7 +118,8 @@ struct symbol_conf { | |||
| 118 | annotate_src, | 118 | annotate_src, |
| 119 | event_group, | 119 | event_group, |
| 120 | demangle, | 120 | demangle, |
| 121 | filter_relative; | 121 | filter_relative, |
| 122 | show_hist_headers; | ||
| 122 | const char *vmlinux_name, | 123 | const char *vmlinux_name, |
| 123 | *kallsyms_name, | 124 | *kallsyms_name, |
| 124 | *source_prefix, | 125 | *source_prefix, |
