diff options
| author | WANG Cong <amwang@redhat.com> | 2011-11-02 16:39:25 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-11-02 19:07:02 -0400 |
| commit | c736de60aed869df8a9aba512cdaf89e32545b00 (patch) | |
| tree | 09397ad20f12fd5d97b1e4e6b46df617b0971982 | |
| parent | f1ecf06854a66ee663f4d4cf029c78cd62a15e04 (diff) | |
sysctl: make CONFIG_SYSCTL_SYSCALL default to n
When I tried to send a patch to remove it, Andi told me we still need to
keep compabitlies for old libc, so we can't remove this completely. Then
just make it default to n and remove the doc from
feature-removal-schedule.txt.
Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
| -rw-r--r-- | Documentation/feature-removal-schedule.txt | 35 | ||||
| -rw-r--r-- | init/Kconfig | 4 |
2 files changed, 2 insertions, 37 deletions
diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt index 7c799fc5b88e..3d849122b5b1 100644 --- a/Documentation/feature-removal-schedule.txt +++ b/Documentation/feature-removal-schedule.txt | |||
| @@ -133,41 +133,6 @@ Who: Pavel Machek <pavel@ucw.cz> | |||
| 133 | 133 | ||
| 134 | --------------------------- | 134 | --------------------------- |
| 135 | 135 | ||
| 136 | What: sys_sysctl | ||
| 137 | When: September 2010 | ||
| 138 | Option: CONFIG_SYSCTL_SYSCALL | ||
| 139 | Why: The same information is available in a more convenient from | ||
| 140 | /proc/sys, and none of the sysctl variables appear to be | ||
| 141 | important performance wise. | ||
| 142 | |||
| 143 | Binary sysctls are a long standing source of subtle kernel | ||
| 144 | bugs and security issues. | ||
| 145 | |||
| 146 | When I looked several months ago all I could find after | ||
| 147 | searching several distributions were 5 user space programs and | ||
| 148 | glibc (which falls back to /proc/sys) using this syscall. | ||
| 149 | |||
| 150 | The man page for sysctl(2) documents it as unusable for user | ||
| 151 | space programs. | ||
| 152 | |||
| 153 | sysctl(2) is not generally ABI compatible to a 32bit user | ||
| 154 | space application on a 64bit and a 32bit kernel. | ||
| 155 | |||
| 156 | For the last several months the policy has been no new binary | ||
| 157 | sysctls and no one has put forward an argument to use them. | ||
| 158 | |||
| 159 | Binary sysctls issues seem to keep happening appearing so | ||
| 160 | properly deprecating them (with a warning to user space) and a | ||
| 161 | 2 year grace warning period will mean eventually we can kill | ||
| 162 | them and end the pain. | ||
| 163 | |||
| 164 | In the mean time individual binary sysctls can be dealt with | ||
| 165 | in a piecewise fashion. | ||
| 166 | |||
| 167 | Who: Eric Biederman <ebiederm@xmission.com> | ||
| 168 | |||
| 169 | --------------------------- | ||
| 170 | |||
| 171 | What: /proc/<pid>/oom_adj | 136 | What: /proc/<pid>/oom_adj |
| 172 | When: August 2012 | 137 | When: August 2012 |
| 173 | Why: /proc/<pid>/oom_adj allows userspace to influence the oom killer's | 138 | Why: /proc/<pid>/oom_adj allows userspace to influence the oom killer's |
diff --git a/init/Kconfig b/init/Kconfig index 31ba0fd0f36b..43298f9810fb 100644 --- a/init/Kconfig +++ b/init/Kconfig | |||
| @@ -947,7 +947,7 @@ config UID16 | |||
| 947 | config SYSCTL_SYSCALL | 947 | config SYSCTL_SYSCALL |
| 948 | bool "Sysctl syscall support" if EXPERT | 948 | bool "Sysctl syscall support" if EXPERT |
| 949 | depends on PROC_SYSCTL | 949 | depends on PROC_SYSCTL |
| 950 | default y | 950 | default n |
| 951 | select SYSCTL | 951 | select SYSCTL |
| 952 | ---help--- | 952 | ---help--- |
| 953 | sys_sysctl uses binary paths that have been found challenging | 953 | sys_sysctl uses binary paths that have been found challenging |
| @@ -959,7 +959,7 @@ config SYSCTL_SYSCALL | |||
| 959 | trying to save some space it is probably safe to disable this, | 959 | trying to save some space it is probably safe to disable this, |
| 960 | making your kernel marginally smaller. | 960 | making your kernel marginally smaller. |
| 961 | 961 | ||
| 962 | If unsure say Y here. | 962 | If unsure say N here. |
| 963 | 963 | ||
| 964 | config KALLSYMS | 964 | config KALLSYMS |
| 965 | bool "Load all symbols for debugging/ksymoops" if EXPERT | 965 | bool "Load all symbols for debugging/ksymoops" if EXPERT |
