diff options
| author | James Hogan <james.hogan@imgtec.com> | 2014-05-01 07:31:14 -0400 |
|---|---|---|
| committer | James Hogan <james.hogan@imgtec.com> | 2014-05-14 19:30:32 -0400 |
| commit | c70458f50cd4271410aa75011f56ffabc0e2d34a (patch) | |
| tree | 797efbbd36e4331f1fd5a51adc449ef0fadf3ef9 | |
| parent | 042d27acb64924a0e8a43e972485913a32407beb (diff) | |
metag: Remove _STK_LIM_MAX override
Meta overrode _STK_LIM_MAX (the default RLIMIT_STACK hard limit) to
256MB, apparently in an attempt to prevent setup_arg_pages's
STACK_GROWSUP code from choosing the maximum stack size of 1GB, which is
far too large for Meta's limited virtual address space and hits a BUG_ON
(stack_top is usually 0x3ffff000).
However the commit "metag: Reduce maximum stack size to 256MB" reduces
the absolute stack size limit to a safe value for metag. This allows the
default _STK_LIM_MAX override to be removed, bringing the default
behaviour in line with all other architectures. Parisc in particular
recently removed their override of _STK_LIMT_MAX in commit e0d8898d76a7
(parisc: remove _STK_LIM_MAX override) since it subtly affects stack
allocation semantics in userland. Meta's uapi/asm/resource.h can now be
removed and switch to using generic-y.
Suggested-by: Helge Deller <deller@gmx.de>
Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: linux-metag@vger.kernel.org
Cc: John David Anglin <dave.anglin@bell.net>
| -rw-r--r-- | arch/metag/include/uapi/asm/Kbuild | 2 | ||||
| -rw-r--r-- | arch/metag/include/uapi/asm/resource.h | 7 |
2 files changed, 1 insertions, 8 deletions
diff --git a/arch/metag/include/uapi/asm/Kbuild b/arch/metag/include/uapi/asm/Kbuild index 84e09feb4d54..ab78be2b6eb0 100644 --- a/arch/metag/include/uapi/asm/Kbuild +++ b/arch/metag/include/uapi/asm/Kbuild | |||
| @@ -4,11 +4,11 @@ include include/uapi/asm-generic/Kbuild.asm | |||
| 4 | header-y += byteorder.h | 4 | header-y += byteorder.h |
| 5 | header-y += ech.h | 5 | header-y += ech.h |
| 6 | header-y += ptrace.h | 6 | header-y += ptrace.h |
| 7 | header-y += resource.h | ||
| 8 | header-y += sigcontext.h | 7 | header-y += sigcontext.h |
| 9 | header-y += siginfo.h | 8 | header-y += siginfo.h |
| 10 | header-y += swab.h | 9 | header-y += swab.h |
| 11 | header-y += unistd.h | 10 | header-y += unistd.h |
| 12 | 11 | ||
| 13 | generic-y += mman.h | 12 | generic-y += mman.h |
| 13 | generic-y += resource.h | ||
| 14 | generic-y += setup.h | 14 | generic-y += setup.h |
diff --git a/arch/metag/include/uapi/asm/resource.h b/arch/metag/include/uapi/asm/resource.h deleted file mode 100644 index 526d23cc3054..000000000000 --- a/arch/metag/include/uapi/asm/resource.h +++ /dev/null | |||
| @@ -1,7 +0,0 @@ | |||
| 1 | #ifndef _UAPI_METAG_RESOURCE_H | ||
| 2 | #define _UAPI_METAG_RESOURCE_H | ||
| 3 | |||
| 4 | #define _STK_LIM_MAX (1 << 28) | ||
| 5 | #include <asm-generic/resource.h> | ||
| 6 | |||
| 7 | #endif /* _UAPI_METAG_RESOURCE_H */ | ||
