diff options
author | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-01-13 12:30:24 -0500 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-01-13 13:28:17 -0500 |
commit | c61c3094a630b2f795addc3a74fbd5ff7f704ca9 (patch) | |
tree | b871fe2f56322a8cdf2c9d8fb2f13acbd7644f7e | |
parent | e4a3bc1c2c1aebb09ef12f0eb52cf5e6a1d5b9d3 (diff) |
[media] go7007-usb: only use go->dev after allocated
Fixes those warnings:
drivers/staging/media/go7007/go7007-usb.c: In function 'go7007_usb_probe':
drivers/staging/media/go7007/go7007-usb.c:1060: warning: 'go' is used uninitialized in this function
While here, comment a code that will never run.
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
-rw-r--r-- | drivers/staging/media/go7007/go7007-usb.c | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index 58684da45e6c..1d747de6dfa6 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c | |||
@@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, | |||
1057 | char *name; | 1057 | char *name; |
1058 | int video_pipe, i, v_urb_len; | 1058 | int video_pipe, i, v_urb_len; |
1059 | 1059 | ||
1060 | dev_dbg(go->dev, "probing new GO7007 USB board\n"); | 1060 | printk(KERN_DEBUG "go7007-usb: probing new board\n"); |
1061 | 1061 | ||
1062 | switch (id->driver_info) { | 1062 | switch (id->driver_info) { |
1063 | case GO7007_BOARDID_MATRIX_II: | 1063 | case GO7007_BOARDID_MATRIX_II: |
@@ -1097,13 +1097,16 @@ static int go7007_usb_probe(struct usb_interface *intf, | |||
1097 | board = &board_px_tv402u; | 1097 | board = &board_px_tv402u; |
1098 | break; | 1098 | break; |
1099 | case GO7007_BOARDID_LIFEVIEW_LR192: | 1099 | case GO7007_BOARDID_LIFEVIEW_LR192: |
1100 | dev_err(go->dev, "The Lifeview TV Walker Ultra is not supported. Sorry!\n"); | 1100 | printk(KERN_ERR |
1101 | "The Lifeview TV Walker Ultra is not supported. Sorry!\n"); | ||
1101 | return -ENODEV; | 1102 | return -ENODEV; |
1103 | #if 0 | ||
1102 | name = "Lifeview TV Walker Ultra"; | 1104 | name = "Lifeview TV Walker Ultra"; |
1103 | board = &board_lifeview_lr192; | 1105 | board = &board_lifeview_lr192; |
1104 | break; | 1106 | break; |
1107 | #endif | ||
1105 | case GO7007_BOARDID_SENSORAY_2250: | 1108 | case GO7007_BOARDID_SENSORAY_2250: |
1106 | dev_info(go->dev, "Sensoray 2250 found\n"); | 1109 | printk(KERN_INFO "Sensoray 2250 found\n"); |
1107 | name = "Sensoray 2250/2251"; | 1110 | name = "Sensoray 2250/2251"; |
1108 | board = &board_sensoray_2250; | 1111 | board = &board_sensoray_2250; |
1109 | break; | 1112 | break; |
@@ -1112,8 +1115,9 @@ static int go7007_usb_probe(struct usb_interface *intf, | |||
1112 | board = &board_ads_usbav_709; | 1115 | board = &board_ads_usbav_709; |
1113 | break; | 1116 | break; |
1114 | default: | 1117 | default: |
1115 | dev_err(go->dev, "unknown board ID %d!\n", | 1118 | printk(KERN_ERR |
1116 | (unsigned int)id->driver_info); | 1119 | "unknown board ID %d!\n", |
1120 | (unsigned int)id->driver_info); | ||
1117 | return -ENODEV; | 1121 | return -ENODEV; |
1118 | } | 1122 | } |
1119 | 1123 | ||