diff options
author | Fred Isaman <iisaman@netapp.com> | 2012-03-20 12:51:24 -0400 |
---|---|---|
committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-03-20 13:05:08 -0400 |
commit | c4f1b62a4b50a01e8d820717906b674807ef9ca3 (patch) | |
tree | 00235f72dd714761d9536408d3c7342d0da10c6d | |
parent | 540a0f7584169651f485e8ab67461fcb06934e38 (diff) |
NFS: ncommit count is being double decremented
The decrement is handled by each call to nfs_request_remove_commit_list,
no need to do it again in nfs_scan_commit.
Signed-off-by: Fred Isaman <iisaman@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
-rw-r--r-- | fs/nfs/write.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/nfs/write.c b/fs/nfs/write.c index 0de19f413f92..628d9a69d0a2 100644 --- a/fs/nfs/write.c +++ b/fs/nfs/write.c | |||
@@ -595,12 +595,9 @@ nfs_scan_commit(struct inode *inode, struct list_head *dst) | |||
595 | spin_lock(&inode->i_lock); | 595 | spin_lock(&inode->i_lock); |
596 | if (nfsi->ncommit > 0) { | 596 | if (nfsi->ncommit > 0) { |
597 | const int max = INT_MAX; | 597 | const int max = INT_MAX; |
598 | int pnfs_ret; | ||
599 | 598 | ||
600 | ret = nfs_scan_commit_list(&nfsi->commit_list, dst, max); | 599 | ret = nfs_scan_commit_list(&nfsi->commit_list, dst, max); |
601 | pnfs_ret = pnfs_scan_commit_lists(inode, max - ret); | 600 | ret += pnfs_scan_commit_lists(inode, max - ret); |
602 | ret += pnfs_ret; | ||
603 | nfsi->ncommit -= ret; | ||
604 | } | 601 | } |
605 | spin_unlock(&inode->i_lock); | 602 | spin_unlock(&inode->i_lock); |
606 | return ret; | 603 | return ret; |