aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAkinobu Mita <akinobu.mita@gmail.com>2014-02-26 08:56:58 -0500
committerJames Bottomley <JBottomley@Parallels.com>2014-03-19 14:30:20 -0400
commitc45eabec08776d462c34802d3e5bad295bda628e (patch)
tree61e57fe067407f86f23c4a9fca6abe9a2b605897
parent134997a041f70d4aa5434d2833c8a3cf33697899 (diff)
[SCSI] scsi_debug: fix false positive logical block reference tag check fail
Reading partially unwritten sectors generates a false positive logical block reference tag check failure when DIF is enabled. This bug is caused by missing ei_lba increment in loop of dif_verify() when unwritten sector is skipped. Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Acked-by: Martin K. Petersen <martin.petersen@oracle.com> Reviewed-by: Douglas Gilbert <dgilbert@interlog.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
-rw-r--r--drivers/scsi/scsi_debug.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
index 2decc6417518..bdfb9be1ec75 100644
--- a/drivers/scsi/scsi_debug.c
+++ b/drivers/scsi/scsi_debug.c
@@ -1832,7 +1832,7 @@ static int prot_verify_read(struct scsi_cmnd *SCpnt, sector_t start_sec,
1832 struct sd_dif_tuple *sdt; 1832 struct sd_dif_tuple *sdt;
1833 sector_t sector; 1833 sector_t sector;
1834 1834
1835 for (i = 0; i < sectors; i++) { 1835 for (i = 0; i < sectors; i++, ei_lba++) {
1836 int ret; 1836 int ret;
1837 1837
1838 sector = start_sec + i; 1838 sector = start_sec + i;
@@ -1846,8 +1846,6 @@ static int prot_verify_read(struct scsi_cmnd *SCpnt, sector_t start_sec,
1846 dif_errors++; 1846 dif_errors++;
1847 return ret; 1847 return ret;
1848 } 1848 }
1849
1850 ei_lba++;
1851 } 1849 }
1852 1850
1853 dif_copy_prot(SCpnt, start_sec, sectors, true); 1851 dif_copy_prot(SCpnt, start_sec, sectors, true);