diff options
author | Ben Hutchings <bhutchings@solarflare.com> | 2012-09-18 19:31:18 -0400 |
---|---|---|
committer | Ben Hutchings <bhutchings@solarflare.com> | 2012-11-30 20:56:22 -0500 |
commit | c3771a35bebeea16c4fd94d1116010cc02b1f75e (patch) | |
tree | e29ba609fba85c1fe451443cb52e326144fb552b | |
parent | ef492f11efed9a6a1686bf914fb74468df59385c (diff) |
sfc: Do not initialise buffer in efx_alloc_special_buffer()
Currently we initialise the newly allocated buffer to all-1s, which is
important for event queues but not for descriptor queues. And since
we also do that in efx_nic_init_eventq(), it is completely pointless
to do it here.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
-rw-r--r-- | drivers/net/ethernet/sfc/nic.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/sfc/nic.c b/drivers/net/ethernet/sfc/nic.c index 368659d6362a..1327f29d086f 100644 --- a/drivers/net/ethernet/sfc/nic.c +++ b/drivers/net/ethernet/sfc/nic.c | |||
@@ -255,9 +255,6 @@ static int efx_alloc_special_buffer(struct efx_nic *efx, | |||
255 | buffer->entries = len / EFX_BUF_SIZE; | 255 | buffer->entries = len / EFX_BUF_SIZE; |
256 | BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1)); | 256 | BUG_ON(buffer->dma_addr & (EFX_BUF_SIZE - 1)); |
257 | 257 | ||
258 | /* All zeros is a potentially valid event so memset to 0xff */ | ||
259 | memset(buffer->addr, 0xff, len); | ||
260 | |||
261 | /* Select new buffer ID */ | 258 | /* Select new buffer ID */ |
262 | buffer->index = efx->next_buffer_table; | 259 | buffer->index = efx->next_buffer_table; |
263 | efx->next_buffer_table += buffer->entries; | 260 | efx->next_buffer_table += buffer->entries; |