diff options
| author | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-03-13 20:39:01 -0400 |
|---|---|---|
| committer | Anton Vorontsov <anton.vorontsov@linaro.org> | 2012-03-26 12:41:11 -0400 |
| commit | c34a61b4e7a9966edc0e87d7b0a12fbb8cc58168 (patch) | |
| tree | 1c347755b106d0b6663caf9447b3b3d35ce6ff84 | |
| parent | 450ceb2b23ed0feba8c1238f52a1d3feacd5379d (diff) | |
ab8500_fg: Get rid of 'struct battery_type'
The struct is duplicated, plus causes the following flood:
CC drivers/power/ab8500_fg.o
ab8500_fg.c: In function ‘ab8500_fg_get_ext_psy_data’:
b8500_fg.c:2081:8: warning: assignment from incompatible pointer type [enabled by default]
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
| -rw-r--r-- | drivers/power/ab8500_fg.c | 3 | ||||
| -rw-r--r-- | include/linux/mfd/abx500/ab8500-bm.h | 59 |
2 files changed, 2 insertions, 60 deletions
diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c index 180c21ad6800..b7e12c8af8cd 100644 --- a/drivers/power/ab8500_fg.c +++ b/drivers/power/ab8500_fg.c | |||
| @@ -2077,7 +2077,8 @@ static int ab8500_fg_get_ext_psy_data(struct device *dev, void *data) | |||
| 2077 | switch (ext->type) { | 2077 | switch (ext->type) { |
| 2078 | case POWER_SUPPLY_TYPE_BATTERY: | 2078 | case POWER_SUPPLY_TYPE_BATTERY: |
| 2079 | if (!di->flags.batt_id_received) { | 2079 | if (!di->flags.batt_id_received) { |
| 2080 | const struct battery_type *b; | 2080 | const struct abx500_battery_type *b; |
| 2081 | |||
| 2081 | b = &(di->bat->bat_type[di->bat->batt_id]); | 2082 | b = &(di->bat->bat_type[di->bat->batt_id]); |
| 2082 | 2083 | ||
| 2083 | di->flags.batt_id_received = true; | 2084 | di->flags.batt_id_received = true; |
diff --git a/include/linux/mfd/abx500/ab8500-bm.h b/include/linux/mfd/abx500/ab8500-bm.h index 44d86206a253..44310c98ee6e 100644 --- a/include/linux/mfd/abx500/ab8500-bm.h +++ b/include/linux/mfd/abx500/ab8500-bm.h | |||
| @@ -313,64 +313,6 @@ struct ab8500_maxim_parameters { | |||
| 313 | }; | 313 | }; |
| 314 | 314 | ||
| 315 | /** | 315 | /** |
| 316 | * struct battery_type - different batteries supported | ||
| 317 | * @name: battery technology | ||
| 318 | * @resis_high: battery upper resistance limit | ||
| 319 | * @resis_low: battery lower resistance limit | ||
| 320 | * @charge_full_design: Maximum battery capacity in mAh | ||
| 321 | * @nominal_voltage: Nominal voltage of the battery in mV | ||
| 322 | * @termination_vol: max voltage upto which battery can be charged | ||
| 323 | * @termination_curr battery charging termination current in mA | ||
| 324 | * @recharge_vol battery voltage limit that will trigger a new | ||
| 325 | * full charging cycle in the case where maintenan- | ||
| 326 | * -ce charging has been disabled | ||
| 327 | * @normal_cur_lvl: charger current in normal state in mA | ||
| 328 | * @normal_vol_lvl: charger voltage in normal state in mV | ||
| 329 | * @maint_a_cur_lvl: charger current in maintenance A state in mA | ||
| 330 | * @maint_a_vol_lvl: charger voltage in maintenance A state in mV | ||
| 331 | * @maint_a_chg_timer_h: charge time in maintenance A state | ||
| 332 | * @maint_b_cur_lvl: charger current in maintenance B state in mA | ||
| 333 | * @maint_b_vol_lvl: charger voltage in maintenance B state in mV | ||
| 334 | * @maint_b_chg_timer_h: charge time in maintenance B state | ||
| 335 | * @low_high_cur_lvl: charger current in temp low/high state in mA | ||
| 336 | * @low_high_vol_lvl: charger voltage in temp low/high state in mV' | ||
| 337 | * @battery_resistance: battery inner resistance in mOhm. | ||
| 338 | * @n_r_t_tbl_elements: number of elements in r_to_t_tbl | ||
| 339 | * @r_to_t_tbl: table containing resistance to temp points | ||
| 340 | * @n_v_cap_tbl_elements: number of elements in v_to_cap_tbl | ||
| 341 | * @v_to_cap_tbl: Voltage to capacity (in %) table | ||
| 342 | * @n_batres_tbl_elements number of elements in the batres_tbl | ||
| 343 | * @batres_tbl battery internal resistance vs temperature table | ||
| 344 | */ | ||
| 345 | struct battery_type { | ||
| 346 | int name; | ||
| 347 | int resis_high; | ||
| 348 | int resis_low; | ||
| 349 | int charge_full_design; | ||
| 350 | int nominal_voltage; | ||
| 351 | int termination_vol; | ||
| 352 | int termination_curr; | ||
| 353 | int recharge_vol; | ||
| 354 | int normal_cur_lvl; | ||
| 355 | int normal_vol_lvl; | ||
| 356 | int maint_a_cur_lvl; | ||
| 357 | int maint_a_vol_lvl; | ||
| 358 | int maint_a_chg_timer_h; | ||
| 359 | int maint_b_cur_lvl; | ||
| 360 | int maint_b_vol_lvl; | ||
| 361 | int maint_b_chg_timer_h; | ||
| 362 | int low_high_cur_lvl; | ||
| 363 | int low_high_vol_lvl; | ||
| 364 | int battery_resistance; | ||
| 365 | int n_temp_tbl_elements; | ||
| 366 | struct res_to_temp *r_to_t_tbl; | ||
| 367 | int n_v_cap_tbl_elements; | ||
| 368 | struct v_to_cap *v_to_cap_tbl; | ||
| 369 | int n_batres_tbl_elements; | ||
| 370 | struct batres_vs_temp *batres_tbl; | ||
| 371 | }; | ||
| 372 | |||
| 373 | /** | ||
| 374 | * struct ab8500_bm_capacity_levels - ab8500 capacity level data | 316 | * struct ab8500_bm_capacity_levels - ab8500 capacity level data |
| 375 | * @critical: critical capacity level in percent | 317 | * @critical: critical capacity level in percent |
| 376 | * @low: low capacity level in percent | 318 | * @low: low capacity level in percent |
| @@ -453,7 +395,6 @@ struct ab8500_bm_data { | |||
| 453 | int gnd_lift_resistance; | 395 | int gnd_lift_resistance; |
| 454 | const struct ab8500_maxim_parameters *maxi; | 396 | const struct ab8500_maxim_parameters *maxi; |
| 455 | const struct ab8500_bm_capacity_levels *cap_levels; | 397 | const struct ab8500_bm_capacity_levels *cap_levels; |
| 456 | const struct battery_type *bat_type; | ||
| 457 | const struct ab8500_bm_charger_parameters *chg_params; | 398 | const struct ab8500_bm_charger_parameters *chg_params; |
| 458 | const struct ab8500_fg_parameters *fg_params; | 399 | const struct ab8500_fg_parameters *fg_params; |
| 459 | }; | 400 | }; |
